Re: [PATCH] gitlab-ci.yml: Run check-qtest and check-unit at the end of the fuzzer job

On 31/08/2020 23.31, Philippe Mathieu-Daudé wrote: > Hi Thomas, > > Le lun. 31 août 2020 17:33, Thomas Huth > a écrit : > > The fuzzer job finishes quite early, so we can run the unit tests and > qtests with -fsanitize=address here without extending the total tes

Re: [PATCH v2 1/3] adb: Correct class size on TYPE_ADB_DEVICE

On 9/1/20 1:51 AM, David Gibson wrote: > The TypeInfo incorrectly just lets the class size be inherited. It won't > actually break things, since the class is abstract, but we should get it > right. > > Signed-off-by: David Gibson Reviewed-by: Cédric Le Goater > --- > hw/input/adb.c | 1 + >

Re: [PATCH] gitlab-ci.yml: Run check-qtest and check-unit at the end of the fuzzer job

On 31/08/2020 18.40, Alexander Bulekov wrote: > On 200831 1732, Thomas Huth wrote: >> The fuzzer job finishes quite early, so we can run the unit tests and >> qtests with -fsanitize=address here without extending the total test time. >> > > Sounds good to me, though its too bad that this is limite

Re: [PATCH] gitlab-ci.yml: Run check-qtest and check-unit at the end of the fuzzer job

On Tue, Sep 1, 2020 at 8:05 AM Thomas Huth wrote: > > On 31/08/2020 23.31, Philippe Mathieu-Daudé wrote: > > Hi Thomas, > > > > Le lun. 31 août 2020 17:33, Thomas Huth > > a écrit : > > > > The fuzzer job finishes quite early, so we can run the unit tests and > >

Re: [PATCH] gitlab-ci.yml: Run check-qtest and check-unit at the end of the fuzzer job

On 01/09/2020 08.12, Philippe Mathieu-Daudé wrote: > On Tue, Sep 1, 2020 at 8:05 AM Thomas Huth wrote: >> >> On 31/08/2020 23.31, Philippe Mathieu-Daudé wrote: >>> Hi Thomas, >>> >>> Le lun. 31 août 2020 17:33, Thomas Huth >> > a écrit : >>> >>> The fuzzer job finishes

[PATCH 07/13] net: relocate paths to helpers and scripts

Signed-off-by: Paolo Bonzini --- include/net/net.h | 4 ++-- net/tap.c | 28 +--- 2 files changed, 23 insertions(+), 9 deletions(-) diff --git a/include/net/net.h b/include/net/net.h index e7ef42d62b..897b2d7595 100644 --- a/include/net/net.h +++ b/include/net/ne

[PATCH 05/13] oslib-posix: relocate path to /var

Signed-off-by: Paolo Bonzini --- util/oslib-posix.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/util/oslib-posix.c b/util/oslib-posix.c index a68fccb52d..8e23b8fac0 100644 --- a/util/oslib-posix.c +++ b/util/oslib-posix.c @@ -339,8 +339,10 @@ int qemu_pipe(int pipefd

[PATCH 01/13] fuzz: use qemu_get_exec_dir

Make things consistent with how softmmu/vl.c uses os_find_datadir. Initializing the path to the executables will also be needed for get_relocatable_path to work. Signed-off-by: Paolo Bonzini --- tests/qtest/fuzz/fuzz.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/q

[PATCH 09/13] vl: relocate path to configuration file

Signed-off-by: Paolo Bonzini --- softmmu/vl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/softmmu/vl.c b/softmmu/vl.c index 81e325fa44..b79de9cd66 100644 --- a/softmmu/vl.c +++ b/softmmu/vl.c @@ -2676,8 +2676,9 @@ static int global_init_func(void *opaque, QemuOpts *opts,

[PATCH 02/13] oslib: do not call g_strdup from qemu_get_exec_dir

Just return the directory without requiring the caller to free it. This also removes a bogus check for NULL in os_find_datadir and module_load_one; g_strdup of a static variable cannot return NULL. Signed-off-by: Paolo Bonzini --- include/qemu/osdep.h| 8 ++-- os-posix.c |

[PATCH 03/13] oslib-posix: default exec_dir to bindir

If the exec_dir cannot be retrieved, just assume it's the installation directory that was specified at configure time. This makes it simpler to reason about what the callers will do if they get back an empty path. Signed-off-by: Paolo Bonzini --- meson.build| 2 +- util/oslib-posix.c |

[PATCH 12/13] ui: relocate paths to icons and translations

Signed-off-by: Paolo Bonzini --- ui/gtk.c | 10 -- ui/sdl2.c | 9 +++-- 2 files changed, 15 insertions(+), 4 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index b0cc08ad6d..597f829ad9 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -51,6 +51,7 @@ #include #include "trace.h" +#include

[PATCH 08/13] vl: relocate paths to data directories

As an additional advantage, the logic is now unified between POSIX and Win32 systems. Signed-off-by: Paolo Bonzini --- include/qemu-common.h | 1 - include/sysemu/sysemu.h | 2 +- os-posix.c | 20 os-win32.c | 11 --- softmmu/vl.c

[PATCH 00/13] Make QEMU installation relocatable

Right now, the installation of QEMU is not relocatable; there is a local hack in os_find_datadir() so that Windows binaries look for ROMs in the executable directory, but that has several limitations: - it does not extend to configuration files, icons, etc. - it does not allow changing the data d

[PATCH 06/13] module: relocate path to modules

Signed-off-by: Paolo Bonzini --- util/module.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/util/module.c b/util/module.c index aed04b578a..c117d770fd 100644 --- a/util/module.c +++ b/util/module.c @@ -19,6 +19,7 @@ #endif #include "qemu/queue.h" #include "qemu/module.

[PATCH 13/13] configure: use a platform-neutral prefix

Now that the installation is relocatable, there is no need to compile a Windows-format prefix into Win32 binaries. Instead, the prefix will only be used to compute installation-relative paths, and it can be any string. Drop the "Program Files" path completely: it is only usable on English version

[PATCH 11/13] qga: relocate path to default configuration and hook

Signed-off-by: Paolo Bonzini --- qga/main.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/qga/main.c b/qga/main.c index 3febf3b0fd..740f5f7303 100644 --- a/qga/main.c +++ b/qga/main.c @@ -29,6 +29,7 @@ #include "qapi/error.h" #include "channel.h" #include "qemu/bs

[PATCH 10/13] qemu-bridge-helper: relocate path to default ACL

Signed-off-by: Paolo Bonzini --- qemu-bridge-helper.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/qemu-bridge-helper.c b/qemu-bridge-helper.c index 88b26747fc..a26e1663f0 100644 --- a/qemu-bridge-helper.c +++ b/qemu-bridge-helper.c @@ -40,6 +40,7 @@ #endif #in

[PATCH 04/13] cutils: introduce get_relocated_path

Add the function that will compute a relocated version of the directories in CONFIG_QEMU_*DIR and CONFIG_QEMU_*PATH. Signed-off-by: Paolo Bonzini --- include/qemu/cutils.h | 12 + meson.build | 4 +-- util/cutils.c | 61 +++ 3 fi

Re: [PATCH] cirrus: handle wraparound in cirrus_invalidate_region

Gerd Hoffmann 于2020年9月1日周二 下午1:15写道： > > Hi, > > > > > > off_cur_end = ((off_cur + bytesperline - 1) & > > > > > s->cirrus_addr_mask) + 1; > [ ... ] > > > > > +memory_region_set_dirty(&s->vga.vram, 0, off_cur_end); > > > > > > > > And here be 'off_cur_end -1' > > > > > > --

Re: [PULL 06/13] Introduce a new flag for i440fx to disable PCI hotplug on the root bus

On Fri, Aug 28, 2020 at 6:40 PM Julia Suvorova wrote: > > On Fri, Aug 28, 2020 at 11:53 AM Ani Sinha wrote: > > > > > > Ani > > On Aug 28, 2020, 15:19 +0530, Igor Mammedov , wrote: > > > > On Thu, 27 Aug 2020 23:29:34 +0530 > > > > Ani Sinha wrote: > > > > > > On Thu, Aug 27, 2020 at 11:11 PM Ig

Re: [PATCH 01/12] target/arm/kvm: Remove superfluous break

Le 13/07/2020 à 11:30, Thomas Huth a écrit : > On 13/07/2020 11.03, Yi Wang wrote: >> From: Liao Pingfang >> >> Remove superfluous break. >> >> Signed-off-by: Liao Pingfang >> Signed-off-by: Yi Wang >> Reviewed-by: Philippe Mathieu-Daudé >> --- >> target/arm/kvm64.c | 1 - >> 1 file changed,

Re: [PATCH 02/12] target/ppc: Remove superfluous breaks

Le 13/07/2020 à 11:30, Thomas Huth a écrit : > On 13/07/2020 11.03, Yi Wang wrote: >> From: Liao Pingfang >> >> Remove superfluous breaks, as there is a "return" before them. >> >> Signed-off-by: Liao Pingfang >> Signed-off-by: Yi Wang >> Reviewed-by: Philippe Mathieu-Daudé >> --- >> target/p

Re: [PATCH 04/12] scsi: Remove superfluous breaks

Le 13/07/2020 à 11:33, Thomas Huth a écrit : > On 13/07/2020 11.04, Yi Wang wrote: >> From: Liao Pingfang >> >> Remove superfluous breaks, as there is a "return" before them. >> >> Signed-off-by: Liao Pingfang >> Signed-off-by: Yi Wang >> Reviewed-by: Philippe Mathieu-Daudé >> --- >> scsi/uti

Re: [PATCH 07/12] vnc: Remove the superfluous break

Le 13/07/2020 à 11:35, Thomas Huth a écrit : > On 13/07/2020 11.04, Yi Wang wrote: >> From: Liao Pingfang >> >> Remove the superfluous break, as there is a "return" before. >> >> Signed-off-by: Liao Pingfang a >> Signed-off-by: Yi Wang >> Reviewed-by: Philippe Mathieu-Daudé >> --- >> ui/vnc-enc

Re: [PATCH 09/12] hw: Remove superfluous breaks

Le 13/07/2020 à 11:37, Thomas Huth a écrit : > On 13/07/2020 11.05, Yi Wang wrote: >> From: Liao Pingfang >> >> Remove superfluous breaks, as there is a "return" before them. >> >> Signed-off-by: Liao Pingfang >> Signed-off-by: Yi Wang >> Reviewed-by: Philippe Mathieu-Daudé >> --- >> hw/block/

Re: [PATCH 08/12] block/vmdk: Remove superfluous breaks

Le 13/07/2020 à 11:36, Thomas Huth a écrit : > On 13/07/2020 11.05, Yi Wang wrote: >> From: Liao Pingfang >> >> Remove superfluous breaks, as there is a "return" before them. >> >> Signed-off-by: Liao Pingfang >> Signed-off-by: Yi Wang >> Reviewed-by: Philippe Mathieu-Daudé >> --- >> block/vmd

Re: [PATCH 11/12] target/sh4: Remove superfluous breaks

Le 13/07/2020 à 11:38, Thomas Huth a écrit : > On 13/07/2020 11.05, Yi Wang wrote: >> From: Liao Pingfang >> >> Remove superfluous breaks, as there is a "return" before them. >> >> Signed-off-by: Liao Pingfang >> Signed-off-by: Yi Wang >> Reviewed-by: Philippe Mathieu-Daudé >> --- >> target/sh

Re: [PATCH 12/12] target/cris: Remove superfluous breaks

Le 13/07/2020 à 11:39, Thomas Huth a écrit : > On 13/07/2020 11.05, Yi Wang wrote: >> From: Liao Pingfang >> >> Remove superfluous breaks, as there is a "return" before them. >> >> Signed-off-by: Liao Pingfang >> Signed-off-by: Yi Wang >> Reviewed-by: Philippe Mathieu-Daudé >> --- >> target/cr

Re: [PATCH] hw/net/can: Add missing fallthrough statements

Le 14/07/2020 à 00:09, Pavel Pisa a écrit : > Hello Laurent and others, > > On Monday 06 of July 2020 18:35:50 Laurent Vivier wrote: >> Le 30/06/2020 à 09:55, Thomas Huth a écrit : >>> Add fallthrough annotations to be able to compile the code without >>> warnings when using -Wimplicit-fallthrough

Re: [PATCH 9/9] vhost-vdpa: allow pre-opend file descriptor

On 2020/8/31 下午7:16, Cindy Lu wrote: On Mon, 31 Aug 2020 at 16:30, Jason Wang wrote: This patch allows to initialize vhost-vdpa network backend with pre opened vhost-vdpa file descriptor. This is useful for running unprivileged qemu through libvirt. Cc: Eric Blake Cc: Markus Armbruster Sig

Re: [PATCH-for-5.1] hw/misc/milkymist-pfpu: Fix pFPU region size

Le 19/07/2020 à 19:23, Michael Walle a écrit : > Hi Philippe, > > Am 2020-07-18 11:37, schrieb Philippe Mathieu-Daudé: >> The last microcode word (address 0x6000.6ffc) is not reachable. >> Correct the programmable FPU I/O size (which is 4 KiB) to be >> able to use all the microcode area. >> >> Sig

Re: [PATCH v4 5/7] misc: Add versal-usb2-regs module

On Sat, Aug 29, 2020 at 12:49:38AM +0530, Sai Pavan Boddu wrote: > This is a dummy module to emulate control registers of versal usb2 > controller. --verbose please. xhci supports all usb speeds, including usb2. So why this hardware is here, what does it on a real device and what is the emulatio

Re: [PATCH v4 6/7] usb: Add DWC3 model

On Sat, Aug 29, 2020 at 12:49:39AM +0530, Sai Pavan Boddu wrote: > From: Vikram Garhwal > > This patch adds skeleton model of dwc3 usb controller attached to > xhci-sysbus device. --verbose. This looks like xhci with a bunch of extra registers? What these registers are good for? > +/* > + * QE

Re: [PATCH v4 7/7] Versal: Connect DWC3 controller with virt-versal

Hi, > +unsigned int irq = VERSAL_USB0_IRQ_0; > +const char intName[] = "dwc_usb3"; > +qemu_fdt_setprop(s->fdt, name, "interrupt-names", > + intName, sizeof(intName)); > +qemu_fdt_setprop_cells(s->fdt, name, "interrupts", > +

[PATCH v2 07/10] migration/colo: Plug memleaks in colo_process_incoming_thread

'local_err' forgot to free in colo_process_incoming_thread error path. Fix that. Reported-by: Euler Robot Signed-off-by: Pan Nengyuan --- Cc: Hailiang Zhang Cc: Juan Quintela Cc: "Dr. David Alan Gilbert" --- - V2: Arrange all 'error_report_err' in 'out' label(suggested by Li Qiang). --- migr

<    1   2   3   4   5