Re: [PATCH v2 02/21] m25p80: Add support for mx25l25635f

2020-08-28 Thread Cédric Le Goater
On 8/19/20 12:09 PM, Cédric Le Goater wrote: > The mx25l25635f is an extenstion of the mx25l25635e. It includes QPI > support, 4-Byte Address Command Set and faster transfers. See this > document for more details : > > https://www.macronix.com/Lists/ApplicationNote/Attachments/1892/AN0200V1_MGRT_M

Re: [PATCH] test-vmstate: fix bad GTree usage, use-after-free

2020-08-28 Thread Auger Eric
Hi Marc-André, On 8/27/20 8:35 PM, Marc-André Lureau wrote: > Hi > > On Thu, Aug 27, 2020 at 8:34 PM Auger Eric > wrote: > > Hi Marc-Andre > > On 8/27/20 6:18 PM, marcandre.lur...@redhat.com > wrote: > > From: M

Re: [PATCH] test-vmstate: fix bad GTree usage, use-after-free

2020-08-28 Thread Auger Eric
Hi Marc-André, On 8/28/20 9:19 AM, Auger Eric wrote: > Hi Marc-André, > > On 8/27/20 8:35 PM, Marc-André Lureau wrote: >> Hi >> >> On Thu, Aug 27, 2020 at 8:34 PM Auger Eric > > wrote: >> >> Hi Marc-Andre >> >> On 8/27/20 6:18 PM, marcandre.lur...@redhat.com

[PULL 03/18] hw: ehci: check return value of 'usb_packet_map'

2020-08-28 Thread Gerd Hoffmann
From: Li Qiang If 'usb_packet_map' fails, we should stop to process the usb request. Signed-off-by: Li Qiang Message-Id: <20200812161727.29412-1-liq...@163.com> Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/hw

[PULL 14/18] scripts: Add u2f-setup-gen script

2020-08-28 Thread Gerd Hoffmann
From: César Belley This patch adds the script used to generate setup directories, needed for the device u2f-emulated configuration in directory mode: python u2f-setup-gen.py $DIR qemu -usb -device u2f-emulated,dir=$DIR Signed-off-by: César Belley Message-id: 20200826114209.28821-11-ces

[PULL 16/18] hw/usb: Add U2F device autoscan to passthru mode

2020-08-28 Thread Gerd Hoffmann
From: César Belley This patch adds an autoscan to let u2f-passthru choose the first U2F device it finds. The autoscan is performed using libudev with an enumeration of all the hidraw devices present on the host. The first device which happens to be a U2F device is taken to do the passtru. Sign

[PULL 13/18] docs/qdev-device-use.txt: Add USB U2F key to the QDEV devices examples

2020-08-28 Thread Gerd Hoffmann
From: César Belley Signed-off-by: César Belley Message-id: 20200826114209.28821-10-cesar.bel...@lse.epita.fr Signed-off-by: Gerd Hoffmann --- docs/qdev-device-use.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/qdev-device-use.txt b/docs/qdev-device-use.txt index f8d0d2fe297a..988

[PULL 07/18] hw/usb: Add U2F key base class

2020-08-28 Thread Gerd Hoffmann
From: César Belley This patch adds the specification for the U2F key base class. Used to group the common characteristics, this device class will be inherited by its two variants, corresponding to the two modes: passthrough and emulated This prepares the U2F devices hierarchy which is as follow:

[PULL 06/18] docs: Add USB U2F key device documentation

2020-08-28 Thread Gerd Hoffmann
From: César Belley Add USB U2F key device documentation: - USB U2F key device - Building - Using u2f-emulated - Using u2f-passthru - Libu2f-emu Signed-off-by: César Belley Message-id: 20200826114209.28821-3-cesar.bel...@lse.epita.fr Signed-off-by: Gerd Hoffmann --- docs/u2f.txt | 101

[PULL 17/18] usb-host: workaround libusb bug

2020-08-28 Thread Gerd Hoffmann
libusb_get_device_speed() does not work for libusb_wrap_sys_device() devices in v1.0.23. Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1871090 Signed-off-by: Gerd Hoffmann Message-id: 20200824110057.32089-1-kra...@redhat.com --- hw/usb/host-libusb.c | 37 ++

[PULL 02/18] hw: ehci: destroy sglist in error path

2020-08-28 Thread Gerd Hoffmann
From: Li Qiang This may cause resource leak. Signed-off-by: Li Qiang Message-Id: <20200812161712.29361-1-liq...@163.com> Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index 1495e8f7fab1..58cceacbf83

[PULL 18/18] usb: fix setup_len init (CVE-2020-14364)

2020-08-28 Thread Gerd Hoffmann
Store calculated setup_len in a local variable, verify it, and only write it to the struct (USBDevice->setup_len) in case it passed the sanity checks. This prevents other code (do_token_{in,out} functions specifically) from working with invalid USBDevice->setup_len values and overrunning the USBDe

[PULL 00/18] Usb 20200828 patches

2020-08-28 Thread Gerd Hoffmann
The following changes since commit 19591e9e0938ea5066984553c256a043bd5d822f: Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (= 2020-08-27 16:59:02 +0100) are available in the Git repository at: git://git.kraxel.org/qemu tags/usb-20200828-pull-request

[PULL 08/18] hw/usb: Add U2F key base class implementation

2020-08-28 Thread Gerd Hoffmann
From: César Belley This patch adds the U2F key base class implementation. The U2F key base mainly takes care of the HID interfacing with guest. On the one hand, it retrieves the guest U2FHID packets and transmits them to the variant associated according to the mode: pass-through or emulated. On

[PULL 04/18] ehci: drop pointless warn_report for guest bugs.

2020-08-28 Thread Gerd Hoffmann
We have a tracepoint at the same place which can be enabled if needed. Buglink: https://bugzilla.redhat.com//show_bug.cgi?id=1859236 Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20200722072613.10390-1-kra...@redhat.com> --- hw/usb/hcd-ehci.c | 1 - 1 file change

[PULL 05/18] hw/usb: Regroup USB HID protocol values

2020-08-28 Thread Gerd Hoffmann
From: César Belley Group some HID values that are used pretty much everywhere when dealing with HID devices. Signed-off-by: César Belley Message-id: 20200812094135.20550-2-cesar.bel...@lse.epita.fr Signed-off-by: Gerd Hoffmann --- include/hw/usb/hid.h | 17 + hw/usb/dev-hid.c

[PULL 01/18] hw: xhci: check return value of 'usb_packet_map'

2020-08-28 Thread Gerd Hoffmann
From: Li Qiang Currently we don't check the return value of 'usb_packet_map', this will cause an UAF issue. This is LP#1891341. Following is the reproducer provided in: -->https://bugs.launchpad.net/qemu/+bug/1891341 cat << EOF | ./i386-softmmu/qemu-system-i386 -device nec-usb-xhci \ -trace usb\

[PULL 12/18] docs/system: Add U2F key to the USB devices examples

2020-08-28 Thread Gerd Hoffmann
From: César Belley Signed-off-by: César Belley Message-id: 20200826114209.28821-9-cesar.bel...@lse.epita.fr Signed-off-by: Gerd Hoffmann --- docs/system/usb.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/docs/system/usb.rst b/docs/system/usb.rst index ddfa828d74ae..9a2f1927c451 100

[PULL 11/18] meson: Add U2F key to meson

2020-08-28 Thread Gerd Hoffmann
From: César Belley Signed-off-by: César Belley Message-id: 20200826114209.28821-8-cesar.bel...@lse.epita.fr Signed-off-by: Gerd Hoffmann --- configure | 8 +++- meson_options.txt | 1 + hw/usb/Kconfig | 5 + hw/usb/meson.build | 7 +++ meson.build| 7 +++

[PULL 15/18] hw/usb: Add U2F device check to passthru mode

2020-08-28 Thread Gerd Hoffmann
From: César Belley This patchs adds a check to verify that the device passed through the hidraw property is a U2F device. The check is done by ensuring that the first values of the report descriptor (USAGE PAGE and USAGE) correspond to those of a U2F device. Signed-off-by: César Belley Message

[PULL 09/18] hw/usb: Add U2F key passthru mode

2020-08-28 Thread Gerd Hoffmann
From: César Belley This patch adds the U2F key pass-through mode. The pass-through mode consists of passing all requests made from the guest to the physical security key connected to the host machine and vice versa. In addition, the dedicated pass-through allows to have a U2F security key share

[PULL 10/18] hw/usb: Add U2F key emulated mode

2020-08-28 Thread Gerd Hoffmann
From: César Belley This patch adds the U2F key emulated mode. The emulated mode consists of completely emulating the behavior of a U2F device through software part. Libu2f-emu is used for that. The emulated mode is associated with a device inheriting from u2f-key base. To work, an emulated U2F

Re: [PATCH v5 0/8] Remove EPYC mode apicid decode and use generic decode

2020-08-28 Thread Igor Mammedov
On Thu, 27 Aug 2020 17:58:01 -0500 Babu Moger wrote: > > -Original Message- > > From: Igor Mammedov > > Sent: Thursday, August 27, 2020 4:19 PM > > To: Dr. David Alan Gilbert > > Cc: ehabk...@redhat.com; m...@redhat.com; qemu-devel@nongnu.org; > > Moger, Babu ; pbonz...@redhat.com; > >

Re: [PATCH v2 (BROKEN) 0/6] migration: bring improved savevm/loadvm/delvm to QMP

2020-08-28 Thread Kevin Wolf
Am 28.08.2020 um 08:20 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 27.08.2020 um 13:06 hat Markus Armbruster geschrieben: > >> Daniel P. Berrangé writes: > >> > >> > On Wed, Aug 26, 2020 at 07:28:24PM +0100, Daniel P. Berrangé wrote: > >> >> On Wed, Aug 26, 2020 at 05

Re: [PATCH v5 0/8] Remove EPYC mode apicid decode and use generic decode

2020-08-28 Thread Dr. David Alan Gilbert
* Igor Mammedov (imamm...@redhat.com) wrote: > On Wed, 26 Aug 2020 15:10:46 +0100 > "Dr. David Alan Gilbert" wrote: > > > * Igor Mammedov (imamm...@redhat.com) wrote: > > > On Tue, 25 Aug 2020 16:25:21 +0100 > > > "Dr. David Alan Gilbert" wrote: > > > > > > > * Igor Mammedov (imamm...@redhat.co

Re: [PATCH v5 0/8] Remove EPYC mode apicid decode and use generic decode

2020-08-28 Thread Daniel P . Berrangé
On Thu, Aug 27, 2020 at 10:55:26PM +0200, Igor Mammedov wrote: > On Thu, 27 Aug 2020 15:07:52 -0400 > Eduardo Habkost wrote: > > > On Thu, Aug 27, 2020 at 07:03:14PM +0200, Igor Mammedov wrote: > > > On Wed, 26 Aug 2020 16:03:40 +0100 > > > Daniel P. Berrangé wrote: > > > > > > > On Wed, Aug 26

Re: [PATCH v5 0/8] Remove EPYC mode apicid decode and use generic decode

2020-08-28 Thread Daniel P . Berrangé
On Thu, Aug 27, 2020 at 10:21:10PM +0200, Igor Mammedov wrote: > On Wed, 26 Aug 2020 13:45:51 -0500 > Babu Moger wrote: > > > > > > > > -Original Message- > > > From: Dr. David Alan Gilbert > > > Sent: Wednesday, August 26, 2020 1:34 PM > > > To: Moger, Babu > > > Cc: Igor Mammedov ;

Re: [PATCH] cirrus.yml: Exclude some targets in the FreeBSD job to speed up the build

2020-08-28 Thread Daniel P . Berrangé
On Mon, Aug 24, 2020 at 11:44:10AM +0200, Thomas Huth wrote: > The FreeBSD jobs currently hit the 1h time limit in the Cirrus-CI. > We've got to exclude some build targets here to make sure that the job > finishes in time again. The targets that are excluded should not hurt > much, since e.g. all t

Re: build broken with --enable-gcrypt

2020-08-28 Thread Daniel P . Berrangé
On Thu, Aug 27, 2020 at 02:18:46PM -0700, Richard Henderson wrote: > The meson conversion seems to have not been properly accomplished for the > gcrypt option: we fail to link against -lgcrypt. > > I tried aping the nettle bits, like the following, but it has no effect. I > don't understand how t

Re: [PATCH v2 0/2] util/hexdump: Cleanup qemu_hexdump()

2020-08-28 Thread Stefano Garzarella
On Sat, Aug 22, 2020 at 08:09:48PM +0200, Philippe Mathieu-Daudé wrote: > - Pass const void* buffer > - Reorder arguments > > Supersedes: <20200822150457.1322519-1-f4...@amsat.org> > > Philippe Mathieu-Daudé (2): > util/hexdump: Convert to take a void pointer argument > util/hexdump: Reorde

Re: [PATCH v2 1/2] util/hexdump: Convert to take a void pointer argument

2020-08-28 Thread Edgar E. Iglesias
On Sat, Aug 22, 2020 at 08:09:49PM +0200, Philippe Mathieu-Daudé wrote: > Most uses of qemu_hexdump() do not take an array of char > as input, forcing use of cast. Since we can use this > helper to dump any kind of buffer, use a pointer to void > argument instead. > > Signed-off-by: Philippe Mathi

Re: [PATCH v2 2/2] util/hexdump: Reorder qemu_hexdump() arguments

2020-08-28 Thread Edgar E. Iglesias
On Sat, Aug 22, 2020 at 08:09:50PM +0200, Philippe Mathieu-Daudé wrote: > qemu_hexdump()'s pointer to the buffer and length of the > buffer are closely related arguments but are widely separated > in the argument list order (also, the format of > function prototypes is usually to have the FILE* ar

[PULL 00/35] target-arm queue

2020-08-28 Thread Peter Maydell
s/mst/tags/for_upstream' into staging (2020-08-27 16:59:02 +0100) are available in the Git repository at: https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20200828 for you to fetch changes up to ed78849d9711805bda37ee026018d6ee7a606d0e: target/arm: Convert sq{,

[PULL 02/35] hw/clock: Remove unused clock_init*() functions

2020-08-28 Thread Peter Maydell
From: Philippe Mathieu-Daudé clock_init*() inlined funtions are simple wrappers around clock_set*() and are not used. Remove them in favor of clock_set*(). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-id: 20200806123858.30058-2-f4...@amsat.org Signed-off-by: Pet

[PULL 03/35] hw/clock: Let clock_set() return boolean value

2020-08-28 Thread Peter Maydell
From: Philippe Mathieu-Daudé Let clock_set() return a boolean value whether the clock has been updated or not. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-id: 20200806123858.30058-3-f4...@amsat.org Signed-off-by: Peter Maydell --- include/hw/clock.h | 12

[PULL 01/35] hw/arm/sbsa-ref: fix typo breaking PCIe IRQs

2020-08-28 Thread Peter Maydell
From: Graeme Gregory Fixing a typo in a previous patch that translated an "i" to a 1 and therefore breaking the allocation of PCIe interrupts. This was discovered when virtio-net-pci devices ceased to function correctly. Cc: qemu-sta...@nongnu.org Fixes: 48ba18e6d3f3 ("hw/arm/sbsa-ref: Simplify

[PULL 05/35] hw/arm/musicpal: Use AddressSpace for DMA transfers

2020-08-28 Thread Peter Maydell
From: Philippe Mathieu-Daudé Allow the device to execute the DMA transfers in a different AddressSpace. We keep using the system_memory address space, but via the proper dma_memory_access() API. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-id: 20200814125533.40

[PULL 06/35] target/arm: Clarify HCR_EL2 ARMCPRegInfo type

2020-08-28 Thread Peter Maydell
From: Philippe Mathieu-Daudé In commit ce4afed839 ("target/arm: Implement AArch32 HCR and HCR2") the HCR_EL2 register has been changed from type NO_RAW (no underlying state and does not support raw access for state saving/loading) to type CONST (TCG can assume the value to be constant), removing

[PULL 09/35] hw/sd/allwinner-sdhost: Use AddressSpace for DMA transfers

2020-08-28 Thread Peter Maydell
From: Philippe Mathieu-Daudé Allow the device to execute the DMA transfers in a different AddressSpace. The A10 and H3 SoC keep using the system_memory address space, but via the proper dma_memory_access() API. Signed-off-by: Philippe Mathieu-Daudé Tested-by: Niek Linnenbank Reviewed-by: Niek

[PULL 04/35] hw/clock: Only propagate clock changes if the clock is changed

2020-08-28 Thread Peter Maydell
From: Philippe Mathieu-Daudé Avoid propagating the clock change when the clock does not change. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-id: 20200806123858.30058-4-f4...@amsat.org Signed-off-by: Peter Maydell --- include/hw/clock.h | 5 +++-- 1 file change

[PULL 07/35] target/arm: Pass the entire mte descriptor to mte_check_fail

2020-08-28 Thread Peter Maydell
From: Richard Henderson We need more information than just the mmu_idx in order to create the proper exception syndrome. Only change the function signature so far. Signed-off-by: Richard Henderson Message-id: 20200813200816.3037186-2-richard.hender...@linaro.org Reviewed-by: Peter Maydell Sig

[PULL 18/35] armsse: Define ARMSSEClass correctly

2020-08-28 Thread Peter Maydell
From: Eduardo Habkost TYPE_ARM_SSE is a TYPE_SYS_BUS_DEVICE subclass, but ARMSSEClass::parent_class is declared as DeviceClass. It never caused any problems by pure luck: We were not setting class_size for TYPE_ARM_SSE, so class_size of TYPE_SYS_BUS_DEVICE was being used (sizeof(SysBusDeviceCla

[PULL 10/35] hw/net/allwinner-sun8i-emac: Use AddressSpace for DMA transfers

2020-08-28 Thread Peter Maydell
From: Philippe Mathieu-Daudé Allow the device to execute the DMA transfers in a different AddressSpace. The H3 SoC keeps using the system_memory address space, but via the proper dma_memory_access() API. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Niek Li

[PULL 12/35] hw/arm/xilinx_zynq: Call qdev_connect_clock_in() before DeviceRealize

2020-08-28 Thread Peter Maydell
From: Philippe Mathieu-Daudé Clock canonical name is set in device_set_realized (see the block added to hw/core/qdev.c in commit 0e6934f264). If we connect a clock after the device is realized, this code is not executed. This is currently not a problem as this name is only used for trace events,

[PULL 15/35] hw/misc/unimp: Display value after offset

2020-08-28 Thread Peter Maydell
From: Philippe Mathieu-Daudé To better align the read/write accesses, display the value after the offset (read accesses only display the offset). Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Message-id: 20200812190206.31595-2-f4...@amsat.org Signed-off-by: Peter Maydell

[PULL 08/35] target/arm: Fill in the WnR syndrome bit in mte_check_fail

2020-08-28 Thread Peter Maydell
From: Richard Henderson According to AArch64.TagCheckFault, none of the other ISS values are provided, so we do not need to go so far as merge_syn_data_abort. But we were missing the WnR bit. Tested-by: Andrey Konovalov Reported-by: Andrey Konovalov Signed-off-by: Richard Henderson Message-id

[PULL 13/35] hw/qdev-clock: Uninline qdev_connect_clock_in()

2020-08-28 Thread Peter Maydell
From: Philippe Mathieu-Daudé We want to assert the device is not realized. To avoid overloading this header including "hw/qdev-core.h", uninline the function first. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Message-id: 20200803105647.3-4-f4...@amsat.org Signed-off

[PULL 19/35] qemu/int128: Add int128_lshift

2020-08-28 Thread Peter Maydell
From: Richard Henderson Add left-shift to match the existing right-shift. Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell Message-id: 20200815013145.539409-2-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- include/qemu/int128.h | 16 1 file changed,

[PULL 11/35] hw/arm/xilinx_zynq: Uninline cadence_uart_create()

2020-08-28 Thread Peter Maydell
From: Philippe Mathieu-Daudé As we want to call qdev_connect_clock_in() before the device is realized, we need to uninline cadence_uart_create() first. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Message-id: 20200803105647.3-2-f4...@amsat.org Signed-off-by: Peter Ma

[PULL 23/35] target/arm: Merge do_vector2_p into do_mov_p

2020-08-28 Thread Peter Maydell
From: Richard Henderson This is the only user of the function. Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell Message-id: 20200815013145.539409-6-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/translate-sve.c | 19 ++- 1 file changed, 6

[PULL 14/35] hw/qdev-clock: Avoid calling qdev_connect_clock_in after DeviceRealize

2020-08-28 Thread Peter Maydell
From: Philippe Mathieu-Daudé Clock canonical name is set in device_set_realized (see the block added to hw/core/qdev.c in commit 0e6934f264). If we connect a clock after the device is realized, this code is not executed. This is currently not a problem as this name is only used for trace events,

[PULL 16/35] hw/misc/unimp: Display the value with width of the access size

2020-08-28 Thread Peter Maydell
From: Philippe Mathieu-Daudé To quickly notice the access size, display the value with the width of the access (i.e. 16-bit access is displayed 0x, while 8-bit access 0x00). Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Message-id: 20200812190206.31595-3-f4...@amsat.

[PULL 27/35] target/arm: Merge helper_sve_clr_* and helper_sve_movz_*

2020-08-28 Thread Peter Maydell
From: Richard Henderson The existing clr functions have only one vector argument, and so can only clear in place. The existing movz functions have two vector arguments, and so can clear while moving. Merge them, with a flag that controls the sense of active vs inactive elements being cleared.

[PULL 20/35] target/arm: Split out gen_gvec_fn_zz

2020-08-28 Thread Peter Maydell
From: Richard Henderson Model the new function on gen_gvec_fn2 in translate-a64.c, but indicating which kind of register and in which order. Since there is only one user of do_vector2_z, fold it into do_mov_z. Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell Message-id: 20200815013

[PULL 21/35] target/arm: Split out gen_gvec_fn_zzz, do_zzz_fn

2020-08-28 Thread Peter Maydell
From: Richard Henderson Model gen_gvec_fn_zzz on gen_gvec_fn3 in translate-a64.c, but indicating which kind of register and in which order. Model do_zzz_fn on the other do_foo functions that take an argument set and verify sve enabled. Signed-off-by: Richard Henderson Reviewed-by: Peter Maydel

[PULL 17/35] hw/misc/unimp: Display the offset with width of the region size

2020-08-28 Thread Peter Maydell
From: Philippe Mathieu-Daudé To have a better idea of how big is the region where the offset belongs, display the value with the width of the region size (i.e. a region of 0x1000 bytes uses 0x000 format). Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Message-id: 20200812

[PULL 30/35] target/arm: Split out gen_gvec_ool_zz

2020-08-28 Thread Peter Maydell
From: Richard Henderson Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell Message-id: 20200815013145.539409-13-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/translate-sve.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff -

[PULL 26/35] target/arm: Split out gen_gvec_ool_zzzp

2020-08-28 Thread Peter Maydell
From: Richard Henderson Model after gen_gvec_fn_zzz et al. Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell Message-id: 20200815013145.539409-9-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/translate-sve.c | 35 --- 1 file

[PULL 22/35] target/arm: Rearrange {sve,fp}_check_access assert

2020-08-28 Thread Peter Maydell
From: Richard Henderson We want to ensure that access is checked by the time we ask for a specific fp/vector register. We want to ensure that we do not emit two lots of code to raise an exception. But sometimes it's difficult to cleanly organize the code such that we never pass through sve_chec

[PULL 28/35] target/arm: Split out gen_gvec_ool_zzp

2020-08-28 Thread Peter Maydell
From: Richard Henderson Model after gen_gvec_fn_zzz et al. Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell Message-id: 20200815013145.539409-11-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/translate-sve.c | 29 ++--- 1 file chan

[PULL 33/35] target/arm: Convert integer multiply (indexed) to gvec for aa64 advsimd

2020-08-28 Thread Peter Maydell
From: Richard Henderson Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell Message-id: 20200815013145.539409-19-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/helper.h| 4 target/arm/translate-a64.c | 16 target/arm/vec_helper.

[PULL 24/35] target/arm: Clean up 4-operand predicate expansion

2020-08-28 Thread Peter Maydell
From: Richard Henderson Move the check for !S into do__flags, which allows to merge in do_vecop4_p. Split out gen_gvec_fn_ppp without sve_access_check, to mirror gen_gvec_fn_zzz. Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell Message-id: 20200815013145.539409-7-richard.hender

[PULL 35/35] target/arm: Convert sq{, r}dmulh to gvec for aa64 advsimd

2020-08-28 Thread Peter Maydell
From: Richard Henderson Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell Message-id: 20200815013145.539409-21-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/helper.h| 10 target/arm/translate-a64.c | 33 ++ target/a

[PULL 31/35] target/arm: Tidy SVE tszimm shift formats

2020-08-28 Thread Peter Maydell
From: Richard Henderson Rather than require the user to fill in the immediate (shl or shr), create full formats that include the immediate. Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell Message-id: 20200815013145.539409-14-richard.hender...@linaro.org Signed-off-by: Peter Maydell

[PULL 25/35] target/arm: Use tcg_gen_gvec_bitsel for trans_SEL_pppp

2020-08-28 Thread Peter Maydell
From: Richard Henderson The gvec operation was added after the initial implementation of the SEL instruction and was missed in the conversion. Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell Message-id: 20200815013145.539409-8-richard.hender...@linaro.org Signed-off-by: Peter Mayde

[PULL 29/35] target/arm: Split out gen_gvec_ool_zzz

2020-08-28 Thread Peter Maydell
From: Richard Henderson Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell Message-id: 20200815013145.539409-12-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/translate-sve.c | 53 +- 1 file changed, 18 insertions(+), 35 d

[PULL 32/35] target/arm: Generalize inl_qrdmlah_* helper functions

2020-08-28 Thread Peter Maydell
From: Richard Henderson Unify add/sub helpers and add a parameter for rounding. This will allow saturating non-rounding to reuse this code. Signed-off-by: Richard Henderson [PMM: fixed accidental use of '=' rather than '+=' in do_sqrdmlah_s] Reviewed-by: Peter Maydell Message-id: 2020081501314

[PULL 34/35] target/arm: Convert integer multiply-add (indexed) to gvec for aa64 advsimd

2020-08-28 Thread Peter Maydell
From: Richard Henderson Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell Message-id: 20200815013145.539409-20-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/helper.h| 14 ++ target/arm/translate-a64.c | 34 ++

Re: [PULL 06/13] Introduce a new flag for i440fx to disable PCI hotplug on the root bus

2020-08-28 Thread Igor Mammedov
On Thu, 27 Aug 2020 23:29:34 +0530 Ani Sinha wrote: > On Thu, Aug 27, 2020 at 11:11 PM Igor Mammedov wrote: > > > > On Thu, 27 Aug 2020 09:40:34 -0400 > > "Michael S. Tsirkin" wrote: > > > > > From: Ani Sinha > > > > > > We introduce a new global flag 'acpi-root-pci-hotplug' for i440fx with

Re: [PULL 06/13] Introduce a new flag for i440fx to disable PCI hotplug on the root bus

2020-08-28 Thread Ani Sinha
Ani On Aug 28, 2020, 15:19 +0530, Igor Mammedov , wrote: > On Thu, 27 Aug 2020 23:29:34 +0530 > Ani Sinha wrote: > > > On Thu, Aug 27, 2020 at 11:11 PM Igor Mammedov wrote: > > > > > > On Thu, 27 Aug 2020 09:40:34 -0400 > > > "Michael S. Tsirkin" wrote: > > > > > > > From: Ani Sinha > > > > >

Re: [PATCH] cirrus.yml: Exclude some targets in the FreeBSD job to speed up the build

2020-08-28 Thread Thomas Huth
On 28/08/2020 10.59, Daniel P. Berrangé wrote: > On Mon, Aug 24, 2020 at 11:44:10AM +0200, Thomas Huth wrote: >> The FreeBSD jobs currently hit the 1h time limit in the Cirrus-CI. >> We've got to exclude some build targets here to make sure that the job >> finishes in time again. The targets that a

Re: [PATCH v2 1/2] util/hexdump: Convert to take a void pointer argument

2020-08-28 Thread Li Qiang
Philippe Mathieu-Daudé 于2020年8月23日周日 上午2:11写道: > > Most uses of qemu_hexdump() do not take an array of char > as input, forcing use of cast. Since we can use this > helper to dump any kind of buffer, use a pointer to void > argument instead. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by:

[PATCH 1/2] memory: Allow a MemoryRegion to be marked no_vhost

2020-08-28 Thread Wang Xin
Allow a memory region to be marked as 'no_vhost' and exclude that region from vhost's list build. Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Wang Xin --- hw/virtio/vhost.c | 5 - include/exec/memory.h | 21 + softmmu/memory.c | 15 +++ 3 f

[PATCH 2/2] misc/ivshmem: Mark shared memory regions as no vhost

2020-08-28 Thread Wang Xin
Since ivshmem_bar2 not normal RAM in Guest, and it shouldn't have vhost DMAing into them, exclude it from the vhost sections, mark the shared memory regions as novhost. Signed-off-by: Wang Xin --- hw/misc/ivshmem.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/misc/ivshmem.c b/hw/misc

[PATCH 0/2][RFC] exclude ivshmem mr from vhost sections

2020-08-28 Thread Wang Xin
The ivshmem me now mapped to vhost memory regions, and it reduces the number of available memslots of vhost backend, which may causes vhost backend memory slots limit check failure in vhost dev init. Since ivshmem_bar2 not normal RAM in Guest, and it shouldn't have vhost DMAing into them, exclude

Re: [PULL 00/17] Meson fixes for 2020-08-27

2020-08-28 Thread Peter Maydell
On Thu, 27 Aug 2020 at 18:02, Paolo Bonzini wrote: > > The following changes since commit d1a2b51f868d09ca8489ee9aee9c55632ed8fb92: > > Merge remote-tracking branch > 'remotes/berrange/tags/socket-next-pull-request' into staging (2020-08-25 > 15:01:43 +0100) > > are available in the Git reposi

Re: [PATCH] util/vfio-helpers: Unify trace-events size format

2020-08-28 Thread Li Qiang
Philippe Mathieu-Daudé 于2020年8月21日周五 上午1:11写道: > > Some 'qemu_vfio_*' trace events sizes are displayed using > decimal notation, other using hexadecimal notation: > > qemu_vfio_ram_block_added s 0xf2448d90 host 0x5bc0 size > 0x400 > qemu_vfio_dma_map s 0xf2448d90 host 0xff

[REPORT] [GSoC - TCG Continuous Benchmarking] [#10] Measuring QEMU Performance in System Mode - Part Two

2020-08-28 Thread Ahmed Karaman
Greetings, In part two of the final TCG Continuous Benchmarking report, the same procedures introduced in part one are used for inspecting the performance of QEMU system mode emulation. The only difference is instead of emulating the same OS for all targets, different images where selected from th

[PATCH 4/9] scripts/performance: Add list_fn_callees.py script

2020-08-28 Thread Ahmed Karaman
Python script that prints the callees of a given list of QEMU functions. Syntax: list_fn_callees.py [-h] -f FUNCTION [FUNCTION ...] -- \ [] \ [] [-h] - Print the script arguments help message. -f FUNCTION [FUNCTION ...] - List of function names Example of usage: l

[PATCH 0/9] GSoC 2020 - TCG Continuous Benchmarking scripts and tools

2020-08-28 Thread Ahmed Karaman
Greetings, This series includes all of the scripts, tools, and benchmarks developed in the TCG Continuous Benchmarking GSoC project for 2020. The series includes one patch for updating the MAINTAINERS file and eight patches each with a separate script or tool. All scripts and tools were thorough

[PATCH 3/9] scripts/performance: Refactor dissect.py

2020-08-28 Thread Ahmed Karaman
- Apply pylint and flake8 formatting rules to the script. - Move syntax and usage exmaple to main() docstring. - Update get_jit_line() to only detect the main jit call. - Use mypy for specifying parameters and return types in functions. Signed-off-by: Ahmed Karaman --- scripts/performance/dissec

[PATCH 1/9] scripts/performance: Refactor topN_perf.py

2020-08-28 Thread Ahmed Karaman
- Apply pylint and flake8 formatting rules to the script. - Use 'tempfile' instead of '/tmp' for creating temporary files. Signed-off-by: Ahmed Karaman --- scripts/performance/topN_perf.py | 174 +++ 1 file changed, 87 insertions(+), 87 deletions(-) diff --git a/scri

[PATCH 5/9] scripts/performance: Add list_helpers.py script

2020-08-28 Thread Ahmed Karaman
Python script that prints executed helpers of a QEMU invocation. Syntax: list_helpers.py [-h] -- \ [] \ [] [-h] - Print the script arguments help message. Example of usage: list_helpers.py -- qemu-mips coulomb_double-mips -n10 Example output: Total number of ins

[PATCH 9/9] scripts/performance: Add topN_system.py script

2020-08-28 Thread Ahmed Karaman
Python script for listing the topN executed QEMU functions in system mode. Syntax: topN_system.py [-h] [-n ] -- \ [-h] - Print the script arguments help message. [-n] - Specify the number of top functions to print. - If this flag is not specified, the tool defaults to 25. Example of u

[PATCH 2/9] scripts/performance: Refactor topN_callgrind.py

2020-08-28 Thread Ahmed Karaman
- Apply pylint and flake8 formatting rules to the script. - Use 'tempfile' instead of '/tmp' for creating temporary files. Signed-off-by: Ahmed Karaman --- scripts/performance/topN_callgrind.py | 169 +- 1 file changed, 87 insertions(+), 82 deletions(-) diff

[PATCH 6/9] scripts/performance: Add bisect.py script

2020-08-28 Thread Ahmed Karaman
Python script that locates the commit that caused a performance degradation or improvement in QEMU using the git bisect command (binary search). Syntax: bisect.py [-h] -s,--start START [-e,--end END] [-q,--qemu QEMU] \ --target TARGET --tool {perf,callgrind} -- \ [] [-h] - Print the script argum

[PATCH 8/9] MAINTAINERS: Add 'tests/performance' to 'Performance Tools and Tests' subsection

2020-08-28 Thread Ahmed Karaman
Add a new 'tests/performance' directory under the 'Performance Tools and Tests' subsection. Signed-off-by: Ahmed Karaman --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 5a22c8be42..8923307642 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3124,

[PATCH 7/9] tests/performance: Add nightly tests

2020-08-28 Thread Ahmed Karaman
A nightly performance testing system to monitor any change in QEMU performance across seventeen different targets. The system includes eight different benchmarks to provide a variety of testing workloads. dijkstra_double: Find the shortest path between the source node and all other nodes using Di

Re: [PULL 11/18] meson: Add U2F key to meson

2020-08-28 Thread Paolo Bonzini
Il ven 28 ago 2020, 10:08 Gerd Hoffmann ha scritto: > > +u2f = dependency('u2f-emu', required: get_option('u2f'), static: > enable_static, > + include_type: 'system') > +if u2f.found() > + u2f = declare_dependency(dependencies: u2f) > +endif > Better: u2f = not_found if have_sy

Re: [PATCH v6 03/20] seabios: add bios-microvm.bin binary

2020-08-28 Thread Sergio Lopez
On Fri, Aug 28, 2020 at 07:02:32AM +0200, Gerd Hoffmann wrote: > On Thu, Aug 27, 2020 at 04:48:54PM +0200, Sergio Lopez wrote: > > On Wed, Aug 26, 2020 at 12:52:37PM +0200, Gerd Hoffmann wrote: > > > Signed-off-by: Gerd Hoffmann > > > --- > > > pc-bios/bios-microvm.bin | Bin 0 -> 131072 bytes > >

[PATCH 00/16] meson: convert unit tests in tests/Makefile.include

2020-08-28 Thread marcandre . lureau
From: Marc-André Lureau Hi, This series convert the unit tests from tests/Makefile.include to meson. Based-on: <20200823111757.72002-2-th...@redhat.com> Marc-André Lureau (16): meson: build qapi tests library meson: declare tasn1 dependency meson: declare keyutils dependency meson: con

[PATCH 02/16] meson: declare tasn1 dependency

2020-08-28 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- meson.build | 5 + 1 file changed, 5 insertions(+) diff --git a/meson.build b/meson.build index 74f8ea0c2e..2002728487 100644 --- a/meson.build +++ b/meson.build @@ -401,6 +401,11 @@ libdaxctl = not_found if 'CONFIG_LIBDAXCTL' i

[PATCH 04/16] meson: convert qht-bench

2020-08-28 Thread marcandre . lureau
From: Marc-André Lureau This is required by test-qht-par unit test. Signed-off-by: Marc-André Lureau --- tests/Makefile.include | 1 - tests/meson.build | 4 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 950a83

[PATCH 01/16] meson: build qapi tests library

2020-08-28 Thread marcandre . lureau
From: Marc-André Lureau - builds QAPI builtins types/visitor to fix a linking issue with unresolved symbols in the static library. - work around a meson limitation on generated file output directories. Signed-off-by: Marc-André Lureau --- tests/Makefile.include| 79 +

[PATCH 09/16] meson: convert vhost-user-bridge

2020-08-28 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- tests/Makefile.include | 2 -- tests/meson.build | 9 + 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 2a6f29d1b5..d4635f9b5b 100644 --- a/tests/Makefi

[PATCH 03/16] meson: declare keyutils dependency

2020-08-28 Thread marcandre . lureau
From: Marc-André Lureau Rename the variable to be more explicit. A further clean-up patch will move the actual to dependency check to meson entirely. Signed-off-by: Marc-André Lureau --- configure | 2 +- meson.build| 4 tests/Makefile.include | 2 +

[PATCH 06/16] meson: convert the unit tests

2020-08-28 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- tests/Makefile.include | 256 + tests/meson.build | 169 +++ tests/test-qga.c | 2 +- 3 files changed, 173 insertions(+), 254 deletions(-) diff --git a/test

[PATCH 10/16] meson: convert atomic*-bench

2020-08-28 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- tests/Makefile.include | 5 - tests/meson.build | 10 ++ 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index d4635f9b5b..30de192567 100644 --- a/tests

[PATCH 05/16] tests: qga has virtio-serial by default when host has it

2020-08-28 Thread marcandre . lureau
From: Marc-André Lureau When dumping the default configuration, don't expect virtio-serial as the configured method, unless the host has CONFIG_VIRTIO_SERIAL. Signed-off-by: Marc-André Lureau --- tests/test-qga.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/test-qga.c b/tests/te

[PATCH 07/16] meson: move keyutils dependency check

2020-08-28 Thread marcandre . lureau
From: Marc-André Lureau Since there is not minimum version specified, and it's a test-only dependency, it's fair to depend on a version that ships with a .pc I suppose. Signed-off-by: Marc-André Lureau --- configure | 25 - meson.build | 6 ++ 2 files changed, 2

  1   2   3   4   5   >