QEMU | Pipeline #182269677 has failed for master | 25f6dc28

2020-08-26 Thread GitLab via
Your pipeline has failed. Project: QEMU ( https://gitlab.com/qemu-project/qemu ) Branch: master ( https://gitlab.com/qemu-project/qemu/-/commits/master ) Commit: 25f6dc28 ( https://gitlab.com/qemu-project/qemu/-/commit/25f6dc28a3a8dd231c2c092a0e65bd796353c769 ) Commit Message: Merge remote-tr

Re: Contributor wanting to get started with simple contributions

2020-08-26 Thread John Snow
On 8/26/20 11:00 AM, Rohit Shinde wrote: Hey Thomas, I didn't really have any specific questions. I wanted to know if there was any part of qemu that I could contribute to. Qemu is overwhelmingly vast and without some pointers, I felt very lost. Yeah, it can be hard to get started. What are

Re: [PATCH v2 (BROKEN) 0/6] migration: bring improved savevm/loadvm/delvm to QMP

2020-08-26 Thread Markus Armbruster
Sorry for taking so long to reply. Daniel P. Berrangé writes: > A followup to: > > v1: https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg00866.html > > When QMP was first introduced some 10+ years ago now, the snapshot > related commands (savevm/loadvm/delvm) were not converted. This was

Re: [RFC v6 00/13] memory: Delete assertion in memory_region_unregister_iommu_notifier

2020-08-26 Thread Peter Xu
On Wed, Aug 26, 2020 at 05:00:30PM +0200, Eugenio Perez Martin wrote: > Hi! > > Sending v6 to see if that is on the same page as what you meant. > Making each setting of "type" explicitly IOMMU_IOTLB_NONE if not used > in notifications. This is done in different commits in case this helps > review

Re: [PATCH v3 72/74] [automated] Remove redundant instance_size/class_size fields

2020-08-26 Thread Eduardo Habkost
On Tue, Aug 25, 2020 at 03:21:08PM -0400, Eduardo Habkost wrote: > This will remove instance_size/class_size fields from TypeInfo > variables when the value is exactly the same as the one in the > parent class. > > Generated by: > > $ ./scripts/codeconverter/converter.py -i \ >--pattern=Redu

Re: [PATCH v5 1/6] meson: Fixes the ninjatool issue that E$$: are generated in Makefile.ninja

2020-08-26 Thread Paolo Bonzini
Yes that would be great. We are tracking all CI "holes" that we didn't catch before committing the Meson transition, and MSYS is certainly one of them. You can send a patch and it will be reviewed and included. Thanks, Paolo On Wed, Aug 26, 2020 at 5:48 PM 罗勇刚(Yonggang Luo) wrote: > > How abou

Re: [PULL 00/18] Usb 20200826 patches

2020-08-26 Thread Peter Maydell
; > are available in the Git repository at: > > git://git.kraxel.org/qemu tags/usb-20200826-pull-request > > for you to fetch changes up to 0cb60cbaf4831d859134eea39ae99ae23db79d9d: > > usb: fix setup_len init (CVE-2020-14364) (2020-08-26 14:42:00 +0200) > > ---

Re: [PATCH v5 1/6] meson: Fixes the ninjatool issue that E$$: are generated in Makefile.ninja

2020-08-26 Thread Yonggang Luo
On Wed, Aug 26, 2020 at 11:56 PM Paolo Bonzini wrote: > Yes that would be great. We are tracking all CI "holes" that we didn't > catch before committing the Meson transition, and MSYS is certainly > one of them. > > You can send a patch and it will be reviewed and included. > > Thanks, > After th

Re: [PATCH 01/77] tests/tcg: Add microblaze to arches filter

2020-08-26 Thread Edgar E. Iglesias
On Tue, Aug 25, 2020 at 01:58:34PM -0700, Richard Henderson wrote: > Not attempting to use a single cross-compiler for both > big-endian and little-endian at this time. > > Cc: Alex Bennée > Signed-off-by: Richard Henderson Reviewed-by: Edgar E. Iglesias > --- > tests/tcg/configure.sh | 2 +

Re: [PATCH 03/77] tests/tcg: Do not require FE_* exception bits

2020-08-26 Thread Edgar E. Iglesias
On Tue, Aug 25, 2020 at 01:58:36PM -0700, Richard Henderson wrote: > Define anything that is missing as 0, so that flags & FE_FOO > is false for any missing FOO. > > Cc: Alex Bennée > Signed-off-by: Richard Henderson Reviewed-by: Edgar E. Iglesias > --- > tests/tcg/multiarch/float_helpers.h

Re: [PATCH 02/77] tests/tcg: Do not require FE_TOWARDZERO

2020-08-26 Thread Edgar E. Iglesias
On Tue, Aug 25, 2020 at 01:58:35PM -0700, Richard Henderson wrote: > This is optional in ISO C, and not all cpus provide it. > > Cc: Alex Bennée > Signed-off-by: Richard Henderson Reviewed-by: Edgar E. Iglesias > --- > tests/tcg/multiarch/float_convs.c | 2 ++ > tests/tcg/multiarch/float_m

Re: [PATCH 3/3] spapr: Correct type for SPAPR_DRC_PCI

2020-08-26 Thread Eduardo Habkost
On Tue, Aug 25, 2020 at 09:16:27PM +1000, David Gibson wrote: > TYPE_SPAPR_DRC_PCI inherits from TYPE_SPAPR_DRC_PHYSICAL, so its checker > macro should use the corresponding instance type. We got away with it > because we never actually used that checker macro. > > Signed-off-by: David Gibson >

Re: [PATCH v2 1/2] hw/isa/superio: Set abstract TYPE_ISA_SUPERIO instance size

2020-08-26 Thread Eduardo Habkost
On Sat, Aug 22, 2020 at 04:28:15PM +0200, Philippe Mathieu-Daudé wrote: > Instead of setting the instance size on each implementations, > set it on the abstract parent, so we are sure no implementation > will forget to set it. > > Reported-by: Eduardo Habkost > Signed-off-by: Philippe Mathieu-Da

Re: [PATCH v5 07/12] migration/dirtyrate: Compare page hash results for recorded sampled page

2020-08-26 Thread Dr. David Alan Gilbert
* Chuan Zheng (zhengch...@huawei.com) wrote: > Compare page hash results for recorded sampled page. > > Signed-off-by: Chuan Zheng > Signed-off-by: YanYing Zhuang So I think this is OK, with the minor clean up suggestions of David E. > --- > migration/dirtyrate.c | 64 > +

Re: [PATCH v3 0/8] meson: mingw installation fixes & nsis conversion

2020-08-26 Thread Marc-André Lureau
Hi On Wed, Aug 26, 2020 at 5:47 PM Paolo Bonzini wrote: > We should document the difference in the 5.2 changelog then (it's okay to > introduce it since the configure option is named differently). > > Not directly related, but I can't help thinking that we would be better off maintaining the cha

Re: [RFC v6 12/13] intel_iommu: Do not notify regular iotlb to device-iotlb notifiers

2020-08-26 Thread Yonggang Luo
On Wed, Aug 26, 2020 at 10:42 PM Eugenio Pérez wrote: > This improves performance in case of netperf with vhost-net: > * TCP_STREAM: From 9049.59Mbit/s to 9049.59Mbit/s (13%) > What's improvement ? they are the same > * TCP_RR: From 8464.73 trans/s to 8932.70 trans/s (5.5%) > * UDP_RR: From

Re: [PATCH v5 08/12] migration/dirtyrate: skip sampling ramblock with size below MIN_RAMBLOCK_SIZE

2020-08-26 Thread Dr. David Alan Gilbert
* Chuan Zheng (zhengch...@huawei.com) wrote: > In order to sample real RAM, skip ramblock with size below MIN_RAMBLOCK_SIZE > which is set as 128M. > > Signed-off-by: Chuan Zheng > --- > migration/dirtyrate.c | 24 > migration/dirtyrate.h | 10 ++ > 2 files chang

Re: [RFC v4 00/70] support vector extension v1.0

2020-08-26 Thread Alistair Francis
On Tue, Aug 25, 2020 at 1:29 AM Frank Chang wrote: > > On Mon, Aug 17, 2020 at 4:50 PM wrote: >> >> From: Frank Chang >> >> This patchset implements the vector extension v1.0 for RISC-V on QEMU. >> >> This patchset is sent as RFC because RVV v1.0 is still in draft state. >> v2 patchset was sent

Re: [PATCH v3 00/74] qom: Automated conversion of type checking boilerplate

2020-08-26 Thread Roman Bolshakov
On Wed, Aug 26, 2020 at 07:18:15AM -0400, Eduardo Habkost wrote: > On Wed, Aug 26, 2020 at 01:22:38PM +0300, Roman Bolshakov wrote: > > On Tue, Aug 25, 2020 at 03:19:56PM -0400, Eduardo Habkost wrote: > > > git tree for this series: > > > https://github.com/ehabkost/qemu-hacks/tree/work/qom-macros-

[PATCH 1/4] tosa-ssp: No need to override instance_size

2020-08-26 Thread Eduardo Habkost
TYPE_SSI_SLAVE already sets instance_size=sizeof(SSISlave), there's no need to override it. Signed-off-by: Eduardo Habkost --- Cc: Andrzej Zaborowski Cc: Peter Maydell Cc: qemu-...@nongnu.org Cc: qemu-devel@nongnu.org --- hw/arm/tosa.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/arm/

[PATCH 3/4] slavio_misc: Correct instance_size

2020-08-26 Thread Eduardo Habkost
TYPE_APC was using the wrong struct for instance_size. Luckily this never caused any problems because MiscState is larger than APCState. Signed-off-by: Eduardo Habkost --- Cc: Mark Cave-Ayland Cc: qemu-devel@nongnu.org --- hw/misc/slavio_misc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletio

[PATCH 4/4] tls-cipher-suites: Correct instance_size

2020-08-26 Thread Eduardo Habkost
We do have a QCryptoTLSCipherSuites struct. It must be used when setting instance_size of the QOM type. Luckily this never caused problems because the QCryptoTLSCipherSuites struct has only a parent_obj field and nothing else. Signed-off-by: Eduardo Habkost --- Cc: "Daniel P. Berrangé" Cc: qem

[PATCH 0/4] QOM instance_size cleanups and fixes

2020-08-26 Thread Eduardo Habkost
Additional batch of fixes to code setting instance_size on QOM types. Eduardo Habkost (4): tosa-ssp: No need to override instance_size hda-audio: Set instance_size at base class slavio_misc: Correct instance_size tls-cipher-suites: Correct instance_size crypto/tls-cipher-suites.c | 2 +-

[PATCH 2/4] hda-audio: Set instance_size at base class

2020-08-26 Thread Eduardo Habkost
Setting instance_size correctly at the base class will help us avoid mistakes when declaring new subclasses. Signed-off-by: Eduardo Habkost --- Cc: Gerd Hoffmann Cc: qemu-devel@nongnu.org --- hw/audio/hda-codec.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/audio/hd

Re: [PATCH 4/4] tls-cipher-suites: Correct instance_size

2020-08-26 Thread Daniel P . Berrangé
On Wed, Aug 26, 2020 at 01:10:05PM -0400, Eduardo Habkost wrote: > We do have a QCryptoTLSCipherSuites struct. It must be used when > setting instance_size of the QOM type. Luckily this never caused > problems because the QCryptoTLSCipherSuites struct has only a > parent_obj field and nothing els

Re: [PATCH v5 12/12] migration/dirtyrate: Add trace_calls to make it easier to debug

2020-08-26 Thread Dr. David Alan Gilbert
* Chuan Zheng (zhengch...@huawei.com) wrote: > Add trace_calls to make it easier to debug > > Signed-off-by: Chuan Zheng Reviewed-by: Dr. David Alan Gilbert > --- > migration/dirtyrate.c | 7 +++ > migration/trace-events | 8 > 2 files changed, 15 insertions(+) > > diff --git

Re: [PATCH v5 1/8] hw/i386: Remove node_id, nr_nodes and nodes_per_pkg from topology

2020-08-26 Thread Babu Moger
On 8/26/20 4:57 AM, Igor Mammedov wrote: > On Fri, 21 Aug 2020 17:12:25 -0500 > Babu Moger wrote: > >> Remove node_id, nr_nodes and nodes_per_pkg from topology. Use >> die_id, nr_dies and dies_per_pkg which is already available. >> Removes the confusion over two variables. >> >> With node_id r

RE: [PATCH v5 0/8] Remove EPYC mode apicid decode and use generic decode

2020-08-26 Thread Babu Moger
> -Original Message- > From: Igor Mammedov > Sent: Wednesday, August 26, 2020 8:31 AM > To: Daniel P. Berrangé > Cc: Moger, Babu ; pbonz...@redhat.com; > r...@twiddle.net; ehabk...@redhat.com; qemu-devel@nongnu.org; > m...@redhat.com; Michal Privoznik > Subject: Re: [PATCH v5 0/8] Remo

Re: [RFC v4 00/70] support vector extension v1.0

2020-08-26 Thread Frank Chang
On Thu, Aug 27, 2020 at 12:56 AM Alistair Francis wrote: > On Tue, Aug 25, 2020 at 1:29 AM Frank Chang > wrote: > > > > On Mon, Aug 17, 2020 at 4:50 PM wrote: > >> > >> From: Frank Chang > >> > >> This patchset implements the vector extension v1.0 for RISC-V on QEMU. > >> > >> This patchset is

Re: [PATCH] hw/arm/sbsa-ref: add "reg" property to DT cpu nodes

2020-08-26 Thread Graeme Gregory
On Tue, Aug 25, 2020 at 05:52:17PM +0100, Leif Lindholm wrote: > The sbsa-ref platform uses a minimal device tree to pass amount of memory > as well as number of cpus to the firmware. However, when dumping that > minimal dtb (with -M sbsa-virt,dumpdtb=), the resulting blob > generates a warning whe

Re: Contributor wanting to get started with simple contributions

2020-08-26 Thread Rohit Shinde
Hey John, I came across QEMU in 2015 when I was looking to participate in GSOC. I did GSoC through another org. I kept following qemu because I was interested in virtualization, systems level coding and device emulation. Currently, most of my professional dev work is done in Java and Python (with

Re: [RFC v4 00/70] support vector extension v1.0

2020-08-26 Thread Alistair Francis
On Wed, Aug 26, 2020 at 10:39 AM Frank Chang wrote: > > On Thu, Aug 27, 2020 at 12:56 AM Alistair Francis > wrote: >> >> On Tue, Aug 25, 2020 at 1:29 AM Frank Chang wrote: >> > >> > On Mon, Aug 17, 2020 at 4:50 PM wrote: >> >> >> >> From: Frank Chang >> >> >> >> This patchset implements the v

Re: [PATCH 00/77] target/microblaze improvements

2020-08-26 Thread Edgar E. Iglesias
On Tue, Aug 25, 2020 at 01:58:33PM -0700, Richard Henderson wrote: > Well, this is larger than I expected. > > I started off thinking conversion to decodetree would be quick, > after I reviewed the mttcg patches last week. Then I realized > that this could also use conversion to the generic trans

[PATCH] armsse: Define ARMSSEClass correctly

2020-08-26 Thread Eduardo Habkost
TYPE_ARM_SSE is a TYPE_SYS_BUS_DEVICE subclass, but ARMSSEClass::parent_class is declared as DeviceClass. It never caused any problems by pure luck: We were not setting class_size for TYPE_ARM_SSE, so class_size of TYPE_SYS_BUS_DEVICE was being used (sizeof(SysBusDeviceClass)). This made the syst

Re: [RFC v4 00/70] support vector extension v1.0

2020-08-26 Thread Frank Chang
On Thu, Aug 27, 2020 at 2:03 AM Alistair Francis wrote: > On Wed, Aug 26, 2020 at 10:39 AM Frank Chang > wrote: > > > > On Thu, Aug 27, 2020 at 12:56 AM Alistair Francis > wrote: > >> > >> On Tue, Aug 25, 2020 at 1:29 AM Frank Chang > wrote: > >> > > >> > On Mon, Aug 17, 2020 at 4:50 PM wrote

Re: [PATCH v2 (BROKEN) 0/6] migration: bring improved savevm/loadvm/delvm to QMP

2020-08-26 Thread Daniel P . Berrangé
On Wed, Aug 26, 2020 at 05:52:06PM +0200, Markus Armbruster wrote: > Sorry for taking so long to reply. > > Daniel P. Berrangé writes: > > > A followup to: > > > > v1: https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg00866.html > > > > When QMP was first introduced some 10+ years ago no

Re: [PATCH v5 0/8] Remove EPYC mode apicid decode and use generic decode

2020-08-26 Thread Dr. David Alan Gilbert
* Babu Moger (babu.mo...@amd.com) wrote: > > > -Original Message- > > From: Igor Mammedov > > Sent: Wednesday, August 26, 2020 8:31 AM > > To: Daniel P. Berrangé > > Cc: Moger, Babu ; pbonz...@redhat.com; > > r...@twiddle.net; ehabk...@redhat.com; qemu-devel@nongnu.org; > > m...@redhat.

Re: [PATCH v2 (BROKEN) 0/6] migration: bring improved savevm/loadvm/delvm to QMP

2020-08-26 Thread Daniel P . Berrangé
On Wed, Aug 26, 2020 at 07:28:24PM +0100, Daniel P. Berrangé wrote: > On Wed, Aug 26, 2020 at 05:52:06PM +0200, Markus Armbruster wrote: > > Open questions: > > > > * Do we want the QMP command to delete existing snapshots with > > conflicting tag / ID, like HMP savevm does? Or do we want it to

Re: [PATCH 0/1] qcow2: Skip copy-on-write when allocating a zero cluster

2020-08-26 Thread Alberto Garcia
On Tue 25 Aug 2020 09:47:24 PM CEST, Brian Foster wrote: > My fio fallocates the entire file by default with this command. Is that > the intent of this particular test? I added --fallocate=none to my test > runs to incorporate the allocation cost in the I/Os. That wasn't intentional, you're right

[PATCH 8/8] dc390: Use TYPE_DC390_DEVICE constant

2020-08-26 Thread Eduardo Habkost
This will make future conversion to use OBJECT_DECLARE* easier. Signed-off-by: Eduardo Habkost --- Cc: Paolo Bonzini Cc: Fam Zheng Cc: qemu-devel@nongnu.org --- hw/scsi/esp-pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/scsi/esp-pci.c b/hw/scsi/esp-pci.c index 497

[PATCH 0/8] qom: Use TYPE_* constants

2020-08-26 Thread Eduardo Habkost
Clean up code that uses hardcoded strings instead of TYPE_* constants when defining QOM types. Eduardo Habkost (8): etsec: Use TYPE_ETSEC_COMMON constant nios2_iic: Use TYPE_ALTERA_IIC constant amd_iommu: Use TYPE_AMD_IOMMU_PCI constant sclpconsole: Use TYPE_* constants xlnx-zcu102: Use

[PATCH 2/8] nios2_iic: Use TYPE_ALTERA_IIC constant

2020-08-26 Thread Eduardo Habkost
This will make future conversion to use OBJECT_DECLARE* easier. Signed-off-by: Eduardo Habkost --- Cc: Chris Wulff Cc: Marek Vasut Cc: qemu-devel@nongnu.org --- hw/intc/nios2_iic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/intc/nios2_iic.c b/hw/intc/nios2_iic.c ind

[PATCH 4/8] sclpconsole: Use TYPE_* constants

2020-08-26 Thread Eduardo Habkost
This will make future conversion to use OBJECT_DECLARE* easier. Signed-off-by: Eduardo Habkost --- Cc: Cornelia Huck Cc: Halil Pasic Cc: Christian Borntraeger Cc: Thomas Huth Cc: "Marc-André Lureau" Cc: Paolo Bonzini Cc: qemu-s3...@nongnu.org Cc: qemu-devel@nongnu.org --- hw/char/sclpconso

[PATCH 1/8] etsec: Use TYPE_ETSEC_COMMON constant

2020-08-26 Thread Eduardo Habkost
This will make future conversion to use OBJECT_DECLARE* easier. Signed-off-by: Eduardo Habkost --- Cc: David Gibson Cc: Jason Wang Cc: qemu-...@nongnu.org Cc: qemu-devel@nongnu.org --- hw/net/fsl_etsec/etsec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/fsl_etsec

RE: [PATCH v5 0/8] Remove EPYC mode apicid decode and use generic decode

2020-08-26 Thread Babu Moger
> -Original Message- > From: Dr. David Alan Gilbert > Sent: Wednesday, August 26, 2020 1:34 PM > To: Moger, Babu > Cc: Igor Mammedov ; Daniel P. Berrangé > ; ehabk...@redhat.com; m...@redhat.com; Michal > Privoznik ; qemu-devel@nongnu.org; > pbonz...@redhat.com; r...@twiddle.net > Subj

[PATCH 5/8] xlnx-zcu102: Use TYPE_ZCU102_MACHINE constant

2020-08-26 Thread Eduardo Habkost
This will make future conversion to use OBJECT_DECLARE* easier. Signed-off-by: Eduardo Habkost --- Cc: Alistair Francis Cc: "Edgar E. Iglesias" Cc: Peter Maydell Cc: qemu-...@nongnu.org Cc: qemu-devel@nongnu.org --- hw/arm/xlnx-zcu102.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) d

[PATCH 3/8] amd_iommu: Use TYPE_AMD_IOMMU_PCI constant

2020-08-26 Thread Eduardo Habkost
This will make future conversion to use OBJECT_DECLARE* easier. Signed-off-by: Eduardo Habkost --- Cc: "Michael S. Tsirkin" Cc: Marcel Apfelbaum Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Cc: qemu-devel@nongnu.org --- hw/i386/amd_iommu.c | 2 +- 1 file changed, 1 insertion(

[PATCH 6/8] tosa: Use TYPE_TOSA_MISC_GPIO constant

2020-08-26 Thread Eduardo Habkost
This will make future conversion to use OBJECT_DECLARE* easier. Signed-off-by: Eduardo Habkost --- Cc: Andrzej Zaborowski Cc: Peter Maydell Cc: qemu-...@nongnu.org Cc: qemu-devel@nongnu.org --- hw/arm/tosa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/tosa.c b/hw

[PATCH 7/8] ppce500: Use TYPE_PPC_E500_PCI_BRIDGE constant

2020-08-26 Thread Eduardo Habkost
This will make future conversion to use OBJECT_DECLARE* easier. Signed-off-by: Eduardo Habkost --- Cc: David Gibson Cc: qemu-...@nongnu.org Cc: qemu-devel@nongnu.org --- hw/pci-host/ppce500.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/pci-host/ppce500.c b/hw/pci-host

Re: [PATCH 5/8] xlnx-zcu102: Use TYPE_ZCU102_MACHINE constant

2020-08-26 Thread Edgar E. Iglesias
On Wed, Aug 26, 2020 at 02:43:31PM -0400, Eduardo Habkost wrote: > This will make future conversion to use OBJECT_DECLARE* easier. > > Signed-off-by: Eduardo Habkost Reviewed-by: Edgar E. Iglesias > --- > Cc: Alistair Francis > Cc: "Edgar E. Iglesias" > Cc: Peter Maydell > Cc: qemu-...@non

[PATCH] ninjatool: quote dollars in variables

2020-08-26 Thread Paolo Bonzini
Otherwise, dollars (such as in the special $ORIGIN rpath) are eaten by Make. Reported-by: Laurent Vivier Signed-off-by: Paolo Bonzini --- scripts/ninjatool.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/ninjatool.py b/scripts/ninjatool.py index cc77d51aa8..c33e

[PATCH v2] configure: add --ninja option

2020-08-26 Thread Paolo Bonzini
On Windows it is not possible to invoke a Python script as $NINJA. If ninja is present use it directly, while if it is not we can keep using ninjatool. Reported-by: Mark Cave-Ayland Signed-off-by: Paolo Bonzini --- configure | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-)

Re: [PATCH 2/4] sev/i386: Allow AP booting under SEV-ES

2020-08-26 Thread Connor Kuehl
On 8/25/20 2:05 PM, Tom Lendacky wrote: From: Tom Lendacky When SEV-ES is enabled, it is not possible modify the guests register state after it has been initially created, encrypted and measured. Normally, an INIT-SIPI-SIPI request is used to boot the AP. However, the hypervisor cannot emulate

Re: [PATCH 1/4] sev/i386: Add initial support for SEV-ES

2020-08-26 Thread Connor Kuehl
On 8/25/20 2:05 PM, Tom Lendacky wrote: From: Tom Lendacky Provide initial support for SEV-ES. This includes creating a function to indicate the guest is an SEV-ES guest (which will return false until all support is in place), performing the proper SEV initialization and ensuring that the guest

Re: [PATCH 4/4] sev/i386: Enable an SEV-ES guest based on SEV policy

2020-08-26 Thread Connor Kuehl
On 8/25/20 2:05 PM, Tom Lendacky wrote: From: Tom Lendacky Update the sev_es_enabled() function return value to be based on the SEV policy that has been specified. SEV-ES is enabled if SEV is enabled and the SEV-ES policy bit is set in the policy object. Signed-off-by: Tom Lendacky --- targ

Re: [PATCH 3/4] sev/i386: Don't allow a system reset under an SEV-ES guest

2020-08-26 Thread Connor Kuehl
On 8/25/20 2:05 PM, Tom Lendacky wrote: From: Tom Lendacky An SEV-ES guest does not allow register state to be altered once it has been measured. When a SEV-ES guest issues a reboot command, Qemu will reset the vCPU state and resume the guest. This will cause failures under SEV-ES, so prevent t

Re: [PATCH 2/4] sev/i386: Allow AP booting under SEV-ES

2020-08-26 Thread Tom Lendacky
On 8/26/20 2:07 PM, Connor Kuehl wrote: On 8/25/20 2:05 PM, Tom Lendacky wrote: From: Tom Lendacky When SEV-ES is enabled, it is not possible modify the guests register state after it has been initially created, encrypted and measured. Normally, an INIT-SIPI-SIPI request is used to boot the A

Re: [PATCH] ninjatool: quote dollars in variables

2020-08-26 Thread Peter Maydell
On Wed, 26 Aug 2020 at 20:03, Paolo Bonzini wrote: > > Otherwise, dollars (such as in the special $ORIGIN rpath) are > eaten by Make. Incidentally, why are we using rpath anyway? I'm pretty sure the old build system didn't need it, and it's one of those features I have mentally filed away under "

Re: [PATCH 5/8] xlnx-zcu102: Use TYPE_ZCU102_MACHINE constant

2020-08-26 Thread Alistair Francis
On Wed, Aug 26, 2020 at 11:47 AM Eduardo Habkost wrote: > > This will make future conversion to use OBJECT_DECLARE* easier. > > Signed-off-by: Eduardo Habkost Reviewed-by: Alistair Francis Alistair > --- > Cc: Alistair Francis > Cc: "Edgar E. Iglesias" > Cc: Peter Maydell > Cc: qemu-...@no

Re: [PATCH 1/4] sev/i386: Add initial support for SEV-ES

2020-08-26 Thread Tom Lendacky
On 8/26/20 2:07 PM, Connor Kuehl wrote: On 8/25/20 2:05 PM, Tom Lendacky wrote: From: Tom Lendacky Provide initial support for SEV-ES. This includes creating a function to indicate the guest is an SEV-ES guest (which will return false until all support is in place), performing the proper SEV i

Re: [PATCH v2 1/1] core/register: Specify instance_size in the TypeInfo

2020-08-26 Thread Eduardo Habkost
On Tue, Aug 25, 2020 at 10:30:59AM -0700, Alistair Francis wrote: > Reported-by: Eduardo Habkost > Signed-off-by: Alistair Francis > --- > hw/core/register.c | 31 +-- > 1 file changed, 13 insertions(+), 18 deletions(-) > > diff --git a/hw/core/register.c b/hw/core/r

Help with usb-host hostdevice property

2020-08-26 Thread Diego Viola
Hi, I'm trying to use the new usb-host hostdevice property that was added here: https://git.qemu.org/?p=qemu.git;a=commit;h=9f815e83e983d247a3cd67579d2d9c1765adc644 This is the command line that I am using: qemu-system-x86_64 -enable-kvm -hda arch-zoom.qcow2 -m 4G -device qemu-xhci,id=xhci -dev

Re: [PATCH 08/10] spapr: introduce SpaprMachineClass::numa_assoc_domains

2020-08-26 Thread Daniel Henrique Barboza
On 8/20/20 1:26 AM, David Gibson wrote: On Fri, Aug 14, 2020 at 05:54:22PM -0300, Daniel Henrique Barboza wrote: We can't use the input from machine->numa_state->nodes directly in the pSeries machine because PAPR does not work with raw distance values, like ACPI SLIT does. We need to determin

Re: [PATCH 0/5] hw/avr: Start using the Clock API

2020-08-26 Thread Michael Rolnik
Tested-by: Michael Rolnik On Fri, Aug 14, 2020 at 7:39 PM Philippe Mathieu-Daudé wrote: > In this series we slowly start to use the recently added > Clock API in the AVR ATmega MCU. > > As the Clock Control Unit is not yet modelled, we simply > connect the XTAL sink to the UART and Timer source

Re: [PULL v2 00/12] target-hppa fixes pull request v2

2020-08-26 Thread Peter Maydell
On Mon, 10 Aug 2020 at 14:24, Helge Deller wrote: > > Please pull from > https://github.com/hdeller/qemu-hppa.git target-hppa > to fix those bugs in target-hppa: > > * Fix the SeaBIOS-hppa firmware build with gcc-10 on Debian > > * Fix the SeaBIOS-hppa firmware to boot NetBSD again > > * Fix m

[PULL v5 10/12] hw/display/artist: Unbreak size mismatch memory accesses

2020-08-26 Thread Helge Deller
Commit 5d971f9e6725 ("memory: Revert "memory: accept mismatching sizes in memory_region_access_valid") broke the artist driver in a way that the dtwm window manager on HP-UX rendered wrong. Fixes: 5d971f9e6725 ("memory: Revert "memory: accept mismatching sizes in memory_region_access_valid") Sign

[PULL v5 03/12] hw/hppa: Implement proper SeaBIOS version check

2020-08-26 Thread Helge Deller
It's important that the SeaBIOS hppa firmware is at least at a minimal level to ensure proper interaction between qemu and firmware. Implement a proper firmware version check by telling SeaBIOS via the fw_cfg interface which minimal SeaBIOS version is required by this running qemu instance. If the

[PULL v5 05/12] hw/hppa/lasi: Don't abort on invalid IMR value

2020-08-26 Thread Helge Deller
NetBSD initializes the LASI IMR value with 0x to disable all LASI interrupts. This triggered an assert() and stopped the emulation. By replacing the check with a warning in the guest log we now allow NetBSD to boot again. Signed-off-by: Helge Deller --- hw/hppa/lasi.c | 8 ++-- 1 fi

[PULL v5 00/12] The following changes since commit 3461487523b897d324e8d91f3fd20ed55f849544:

2020-08-26 Thread Helge Deller
Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20200727' into staging (2020-07-28 18:43:48 +0100) are available in the Git repository at: g...@github.com:hdeller/qemu-hppa.git tags/target-hppa-v3-pull-request for you to fetch changes up to 2f8cd515477edab1cbf38ecbdbfa2c

[PULL v5 11/12] hw/display/artist: Fix invalidation of lines in artist_draw_line()

2020-08-26 Thread Helge Deller
From: Sven Schnelle The old code didn't invalidate correctly when vertical lines were drawn. Fix this and move the invalidation out of the loop. Signed-off-by: Sven Schnelle Signed-off-by: Helge Deller --- hw/display/artist.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --g

[PULL v5 01/12] hw/hppa: Sync hppa_hardware.h file with SeaBIOS sources

2020-08-26 Thread Helge Deller
The hppa_hardware.h file is shared with SeaBIOS. Sync it. Acked-by: Richard Henderson Signed-off-by: Helge Deller --- hw/hppa/hppa_hardware.h | 6 ++ hw/hppa/lasi.c | 2 -- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/hw/hppa/hppa_hardware.h b/hw/hppa/hppa_hardwar

[PULL v5 06/12] hw/display/artist: Check offset in draw_line to avoid buffer over-run

2020-08-26 Thread Helge Deller
From: Philippe Mathieu-Daudé Invalid I/O writes can craft an offset out of the vram_buffer range. We avoid: Program terminated with signal SIGSEGV, Segmentation fault. 284 *dst &= ~plane_mask; (gdb) bt #0 0x55d5dccdc5c0 in artist_rop8 (s=0x55d5defee510, dst=0x7f8e84ed82

[PULL v5 12/12] hw/display/artist: Fix invalidation of lines near screen border

2020-08-26 Thread Helge Deller
From: Sven Schnelle If parts of the invalidated screen lines are outside of the VRAM buffer, the code skips the whole invalidate. This is incorrect when only parts of the buffer are invisble - which is the case when the mouse cursor is located near the screen border. Signed-off-by: Sven Schnelle

Re: [PATCH 05/10] spapr: make ibm,max-associativity-domains scale with user input

2020-08-26 Thread Daniel Henrique Barboza
On 8/19/20 11:55 PM, David Gibson wrote: On Fri, Aug 14, 2020 at 05:54:19PM -0300, Daniel Henrique Barboza wrote: The ibm,max-associativity-domains is considering that only a single associativity domain can exist in the same NUMA level. This is true today because we do not support any type of

[PULL v5 07/12] hw/display/artist: Refactor artist_rop8() to avoid buffer over-run

2020-08-26 Thread Helge Deller
From: Philippe Mathieu-Daudé Invalid I/O writes can craft an offset out of the vram_buffer range. Instead of passing an unsafe pointer to artist_rop8(), pass the vram_buffer and the offset. We can now check if the offset is in range before accessing it. We avoid: Program terminated with signa

[PULL v5 08/12] Revert "hw/display/artist: Avoid drawing line when nothing to display"

2020-08-26 Thread Helge Deller
This reverts commit b0f6455feac97e41045ee394e11c24d92c370f6e. It's wrong. A line could even be a dot. Signed-off-by: Helge Deller --- hw/display/artist.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/hw/display/artist.c b/hw/display/artist.c index 47de17b9e9..f37aa9eb49 100644 --- a/hw/d

[PULL v5 09/12] hw/display/artist: Prevent out of VRAM buffer accesses

2020-08-26 Thread Helge Deller
Simplify various bounds checks by changing parameters like row and column numbers to become unsigned instead of signed. With that we can check if the calculated offset is bigger than the size of the VRAM region and bail out if not. Reported-by: LLVM libFuzzer Reported-by: Alexander Bulekov Buglin

Re: [PATCH v2 1/1] core/register: Specify instance_size in the TypeInfo

2020-08-26 Thread Alistair Francis
On Wed, Aug 26, 2020 at 2:40 AM Philippe Mathieu-Daudé wrote: > > Le mar. 25 août 2020 19:42, Alistair Francis a > écrit : >> >> Reported-by: Eduardo Habkost >> Signed-off-by: Alistair Francis >> --- >> hw/core/register.c | 31 +-- >> 1 file changed, 13 insertions(

[PULL v5 04/12] hw/display/artist.c: fix out of bounds check

2020-08-26 Thread Helge Deller
From: Sven Schnelle Fix the following runtime warning with artist framebuffer: "write outside bounds: wants 1256x1023, max size 1280x1024" Reviewed-by: Richard Henderson Signed-off-by: Sven Schnelle Signed-off-by: Helge Deller --- hw/display/artist.c | 24 +++- 1 file cha

Re: [PATCH 03/10] spapr: robustify NVLink2 NUMA node logic

2020-08-26 Thread Daniel Henrique Barboza
On 8/19/20 11:14 PM, David Gibson wrote: On Fri, Aug 14, 2020 at 05:54:17PM -0300, Daniel Henrique Barboza wrote: NVLink2 GPUs are allocated in their own NUMA node, at maximum distance from every other resource in the board. The existing logic makes some assumptions that don't scale well: -

Re: [RFC v4 00/70] support vector extension v1.0

2020-08-26 Thread Alistair Francis
On Wed, Aug 26, 2020 at 11:13 AM Frank Chang wrote: > > On Thu, Aug 27, 2020 at 2:03 AM Alistair Francis wrote: >> >> On Wed, Aug 26, 2020 at 10:39 AM Frank Chang wrote: >> > >> > On Thu, Aug 27, 2020 at 12:56 AM Alistair Francis >> > wrote: >> >> >> >> On Tue, Aug 25, 2020 at 1:29 AM Frank Ch

Re: [PATCH v2 1/1] core/register: Specify instance_size in the TypeInfo

2020-08-26 Thread Alistair Francis
On Wed, Aug 26, 2020 at 12:49 PM Eduardo Habkost wrote: > > On Tue, Aug 25, 2020 at 10:30:59AM -0700, Alistair Francis wrote: > > Reported-by: Eduardo Habkost > > Signed-off-by: Alistair Francis > > --- > > hw/core/register.c | 31 +-- > > 1 file changed, 13 insertio

[REPORT] Nightly Performance Tests - Wednesday, August 26, 2020

2020-08-26 Thread Ahmed Karaman
Host CPU : Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz Host Memory : 15.49 GB Start Time (UTC) : 2020-08-26 21:30:02 End Time (UTC) : 2020-08-26 22:03:25 Execution Time : 0:33:22.684015 Status : SUCCESS Note: Changes denoted by '-' are less than 0.01%. -

[Bug 1892604] Re: qemu-system-arm: ../hw/usb/hcd-dwc2.c:666: dwc2_glbreg_read: Assertion `addr <= GINTSTS2' failed.

2020-08-26 Thread Paul Zimmerman
Hmm, yes agreed. I started a 2-week holiday on Monday, I can work on this after I get back on Sept. 7 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1892604 Title: qemu-system-arm: ../hw/usb/hcd-dwc

Re: [PATCH v2 2/2] linux-user: Add support for utimensat_time64() and semtimedop_time64()

2020-08-26 Thread Laurent Vivier
Le 26/08/2020 à 15:58, Laurent Vivier a écrit : > Le 25/08/2020 à 16:23, Laurent Vivier a écrit : >> Le 25/08/2020 à 09:18, Laurent Vivier a écrit : >>> Le 25/08/2020 à 00:30, Filip Bozuta a écrit : This patch introduces functionality for following time64 syscalls: *utimensat_time64(

RE: [RFC PATCH v3 04/34] Hexagon (target/hexagon) scalar core definition

2020-08-26 Thread Taylor Simpson
Thanks for the feedback, Richard!! > -Original Message- > From: Richard Henderson > Sent: Wednesday, August 26, 2020 7:36 AM > To: Taylor Simpson ; qemu-devel@nongnu.org > Cc: phi...@redhat.com; laur...@vivier.eu; riku.voi...@iki.fi; > aleksandar.m.m...@gmail.com; a...@rev.ng > Subject:

RE: [RFC PATCH v3 06/34] Hexagon (disas) disassembler

2020-08-26 Thread Taylor Simpson
> -Original Message- > From: Richard Henderson > Sent: Wednesday, August 26, 2020 7:52 AM > To: Taylor Simpson ; qemu-devel@nongnu.org > Cc: phi...@redhat.com; laur...@vivier.eu; riku.voi...@iki.fi; > aleksandar.m.m...@gmail.com; a...@rev.ng > Subject: Re: [RFC PATCH v3 06/34] Hexagon (d

RE: [RFC PATCH v3 13/34] Hexagon (target/hexagon) register map

2020-08-26 Thread Taylor Simpson
> -Original Message- > From: Richard Henderson > Sent: Wednesday, August 26, 2020 8:36 AM > To: Taylor Simpson ; qemu-devel@nongnu.org > Cc: phi...@redhat.com; laur...@vivier.eu; riku.voi...@iki.fi; > aleksandar.m.m...@gmail.com; a...@rev.ng > Subject: Re: [RFC PATCH v3 13/34] Hexagon (t

RE: [RFC PATCH v3 11/34] Hexagon (target/hexagon) register fields

2020-08-26 Thread Taylor Simpson
> -Original Message- > From: Richard Henderson > Sent: Wednesday, August 26, 2020 8:30 AM > To: Taylor Simpson ; qemu-devel@nongnu.org > Cc: phi...@redhat.com; laur...@vivier.eu; riku.voi...@iki.fi; > aleksandar.m.m...@gmail.com; a...@rev.ng > Subject: Re: [RFC PATCH v3 11/34] Hexagon (t

RE: [RFC PATCH v3 17/34] Hexagon (target/hexagon/imported) arch import - macro definitions

2020-08-26 Thread Taylor Simpson
> -Original Message- > From: Richard Henderson > Sent: Wednesday, August 26, 2020 9:17 AM > To: Taylor Simpson ; qemu-devel@nongnu.org > Cc: phi...@redhat.com; laur...@vivier.eu; riku.voi...@iki.fi; > aleksandar.m.m...@gmail.com; a...@rev.ng > Subject: Re: [RFC PATCH v3 17/34] Hexagon (t

RE: [RFC PATCH v3 07/34] Hexagon (target/hexagon) scalar core helpers

2020-08-26 Thread Taylor Simpson
> -Original Message- > From: Richard Henderson > Sent: Wednesday, August 26, 2020 8:17 AM > To: Taylor Simpson ; qemu-devel@nongnu.org > Cc: phi...@redhat.com; laur...@vivier.eu; riku.voi...@iki.fi; > aleksandar.m.m...@gmail.com; a...@rev.ng > Subject: Re: [RFC PATCH v3 07/34] Hexagon (t

RE: [RFC PATCH v3 10/34] Hexagon (target/hexagon) instruction and packet types

2020-08-26 Thread Taylor Simpson
> -Original Message- > From: Richard Henderson > Sent: Wednesday, August 26, 2020 8:22 AM > To: Taylor Simpson ; qemu-devel@nongnu.org > Cc: a...@rev.ng; riku.voi...@iki.fi; laur...@vivier.eu; phi...@redhat.com; > aleksandar.m.m...@gmail.com > Subject: Re: [RFC PATCH v3 10/34] Hexagon (t

RE: [RFC PATCH v3 24/34] Hexagon (target/hexagon) opcode data structures

2020-08-26 Thread Taylor Simpson
> -Original Message- > From: Richard Henderson > Sent: Wednesday, August 26, 2020 9:26 AM > To: Taylor Simpson ; qemu-devel@nongnu.org > Cc: phi...@redhat.com; laur...@vivier.eu; riku.voi...@iki.fi; > aleksandar.m.m...@gmail.com; a...@rev.ng > Subject: Re: [RFC PATCH v3 24/34] Hexagon (t

RE: [RFC PATCH v3 14/34] Hexagon (target/hexagon) instruction/packet decode

2020-08-26 Thread Taylor Simpson
> -Original Message- > From: Richard Henderson > Sent: Wednesday, August 26, 2020 9:07 AM > To: Taylor Simpson ; qemu-devel@nongnu.org > Cc: phi...@redhat.com; laur...@vivier.eu; riku.voi...@iki.fi; > aleksandar.m.m...@gmail.com; a...@rev.ng > Subject: Re: [RFC PATCH v3 14/34] Hexagon (t

RE: [RFC PATCH v3 16/34] Hexagon (target/hexagon) utility functions

2020-08-26 Thread Taylor Simpson
> -Original Message- > From: Richard Henderson > Sent: Wednesday, August 26, 2020 9:11 AM > To: Taylor Simpson ; qemu-devel@nongnu.org > Cc: phi...@redhat.com; laur...@vivier.eu; riku.voi...@iki.fi; > aleksandar.m.m...@gmail.com; a...@rev.ng > Subject: Re: [RFC PATCH v3 16/34] Hexagon (t

RE: [RFC PATCH v3 09/34] Hexagon (target/hexagon) architecture types

2020-08-26 Thread Taylor Simpson
> -Original Message- > From: Richard Henderson > Sent: Wednesday, August 26, 2020 8:19 AM > To: Taylor Simpson ; qemu-devel@nongnu.org > Cc: phi...@redhat.com; laur...@vivier.eu; riku.voi...@iki.fi; > aleksandar.m.m...@gmail.com; a...@rev.ng > Subject: Re: [RFC PATCH v3 09/34] Hexagon (t

Re: [PATCH v5] qapi/opts-visitor: Added missing fallthrough annotations

2020-08-26 Thread Rohit Shinde
I am just compiling with cflag set to -Wimplicit-fallthrough. I am using gcc. On Tue, Aug 25, 2020 at 2:03 AM Markus Armbruster wrote: > Rohit Shinde writes: > > > Added fallthrough comment on line 270 to prevent the compiler from > > throwing an error while compiling with the -Wimplicit-fallth

Re: [PATCH 2/8] nios2_iic: Use TYPE_ALTERA_IIC constant

2020-08-26 Thread Li Qiang
Eduardo Habkost 于2020年8月27日周四 上午2:44写道: > > This will make future conversion to use OBJECT_DECLARE* easier. > > Signed-off-by: Eduardo Habkost Reviewed-by: Li Qiang > --- > Cc: Chris Wulff > Cc: Marek Vasut > Cc: qemu-devel@nongnu.org > --- > hw/intc/nios2_iic.c | 2 +- > 1 file changed, 1

Re: [PATCH 4/8] sclpconsole: Use TYPE_* constants

2020-08-26 Thread Li Qiang
Eduardo Habkost 于2020年8月27日周四 上午2:45写道: > > This will make future conversion to use OBJECT_DECLARE* easier. > > Signed-off-by: Eduardo Habkost Reviewed-by: Li Qiang > --- > Cc: Cornelia Huck > Cc: Halil Pasic > Cc: Christian Borntraeger > Cc: Thomas Huth > Cc: "Marc-André Lureau" > Cc: Pa

Re: [PATCH 1/8] etsec: Use TYPE_ETSEC_COMMON constant

2020-08-26 Thread Li Qiang
Eduardo Habkost 于2020年8月27日周四 上午2:46写道: > > This will make future conversion to use OBJECT_DECLARE* easier. > > Signed-off-by: Eduardo Habkost Reviewed-by: Li Qiang > --- > Cc: David Gibson > Cc: Jason Wang > Cc: qemu-...@nongnu.org > Cc: qemu-devel@nongnu.org > --- > hw/net/fsl_etsec/etsec

<    1   2   3   4   5   >