[PATCH v6 00/20] microvm: add acpi support

2020-08-26 Thread Gerd Hoffmann
I know that not supporting ACPI in microvm is intentional. If you still don't want ACPI this is perfectly fine, you can use the usual -no-acpi switch to toggle ACPI support. These are the advantages you are going to loose then: (1) virtio-mmio device discovery without command line hacks (tweak

[PATCH v6 16/20] microvm: wire up hotplug

2020-08-26 Thread Gerd Hoffmann
The cpu hotplug code handles the initialization of coldplugged cpus too, so it is needed even in case cpu hotplug is not supported. Wire cpu hotplug up for microvm. Without this we get a broken MADT table. Signed-off-by: Gerd Hoffmann Reviewed-by: Igor Mammedov --- hw/i386/microvm.c | 42 +

[PATCH v6 17/20] tests/acpi: allow microvm test data updates.

2020-08-26 Thread Gerd Hoffmann
Also add empty test data files. Signed-off-by: Gerd Hoffmann --- tests/qtest/bios-tables-test-allowed-diff.h | 3 +++ tests/data/acpi/microvm/APIC| 0 tests/data/acpi/microvm/DSDT| 0 tests/data/acpi/microvm/FACP| 0 4 files changed, 3 insertions(+

[PATCH v6 18/20] tests/acpi: allow override blkdev

2020-08-26 Thread Gerd Hoffmann
microvm needs virtio-blk instead of ide. Signed-off-by: Gerd Hoffmann Reviewed-by: Igor Mammedov --- tests/qtest/bios-tables-test.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c index d25ff354921f..058ba

[PATCH v6 13/20] x86: constify x86_machine_is_*_enabled

2020-08-26 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/hw/i386/x86.h | 4 ++-- hw/i386/x86.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/include/hw/i386/x86.h b/include/hw/i386/x86.h index b79f24e28545..a350ea3609f5 100644 --- a/include/hw/i386/x86.h +++ b/include/hw/i386/x

Re: [PATCH 04/12] elf2dmp/pdb: Plug memleak in pdb_init_from_file

2020-08-26 Thread Li Qiang
Pan Nengyuan 于2020年8月14日周五 下午6:51写道: > > Missing g_error_free in pdb_init_from_file() error path. Fix that. > > Reported-by: Euler Robot > Signed-off-by: Pan Nengyuan Reviewed-by: Li Qiang > --- > Cc: Viktor Prutyanov > --- > contrib/elf2dmp/pdb.c | 1 + > 1 file changed, 1 insertion(+) > >

[PATCH v6 09/20] microvm/acpi: add acpi_dsdt_add_virtio() for x86

2020-08-26 Thread Gerd Hoffmann
Makes x86 linux kernel find virtio-mmio devices automatically. Signed-off-by: Gerd Hoffmann Reviewed-by: Sergio Lopez Reviewed-by: Igor Mammedov --- hw/i386/acpi-microvm.c | 52 ++ 1 file changed, 52 insertions(+) diff --git a/hw/i386/acpi-microvm.c b/h

[PATCH v6 06/20] acpi: move acpi_dsdt_add_power_button() to ged

2020-08-26 Thread Gerd Hoffmann
Allow reuse for microvm. Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Igor Mammedov --- include/hw/acpi/generic_event_device.h | 1 + hw/acpi/generic_event_device.c | 8 hw/arm/virt-acpi-build.c | 8 3 files changed, 9 in

Re: linux-user static build broken

2020-08-26 Thread Laurent Vivier
Le 26/08/2020 à 11:08, Paolo Bonzini a écrit : > $ORIGIN is a special literal used by ld.so. It's probably fixed by the > same patch that was posted for msys. If I remove the "-Wl,-rpath,RIGIN/" from the command line to build qemu-m68k, it works again. What the patch name or series? Thanks, Laur

Re: [PATCH 05/12] target/i386/sev: Plug memleak in sev_read_file_base64

2020-08-26 Thread Li Qiang
Pan Nengyuan 于2020年8月14日周五 下午6:37写道: > > Missing g_error_free() in sev_read_file_base64() error path. > Fix that. > > Reported-by: Euler Robot > Signed-off-by: Pan Nengyuan Reviewed-by: Li Qiang > --- > Cc: Paolo Bonzini > Cc: Richard Henderson > Cc: Eduardo Habkost > --- > target/i386/se

Re: [PATCH v4 3/6] util: add Error object for qemu_open_internal error reporting

2020-08-26 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Tue, Aug 25, 2020 at 05:14:21PM +0200, Markus Armbruster wrote: >> Daniel P. Berrangé writes: >> >> > Instead of relying on the limited information from errno, we can now >> > also provide detailed error messages. >> >> The more detailed error messages are curre

Re: [PATCH 03/12] elf2dmp/qemu_elf: Plug memleak in QEMU_Elf_init

2020-08-26 Thread Li Qiang
Pan Nengyuan 于2020年8月14日周五 下午6:28写道: > > Missing g_error_free in QEMU_Elf_init() error path. Fix that. > > Reported-by: Euler Robot > Signed-off-by: Pan Nengyuan Reviewed-by: Li Qiang > --- > Cc: Viktor Prutyanov > --- > contrib/elf2dmp/qemu_elf.c | 1 + > 1 file changed, 1 insertion(+) > >

Re: [PATCH 02/12] hw/vfio/ap: Plug memleak in vfio_ap_get_group()

2020-08-26 Thread Li Qiang
Pan Nengyuan 于2020年8月14日周五 下午6:29写道: > > Missing g_error_free() in vfio_ap_get_group() error path. Fix that. > > Reported-by: Euler Robot > Signed-off-by: Pan Nengyuan Reviewed-by: Li Qiang I see Cornelia Huck has merged this in his tree. Don't know whether this series will go separate mainta

[PATCH v3 2/8] configure: always /-seperate directory from qemu_suffix

2020-08-26 Thread marcandre . lureau
From: Marc-André Lureau Otherwise, we may accept very strange directory names... While at it, quote the variables. Signed-off-by: Marc-André Lureau --- configure | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/configure b/configure index 0e04c47722..61216b92

[PATCH v3 0/8] meson: mingw installation fixes & nsis conversion

2020-08-26 Thread marcandre . lureau
From: Marc-André Lureau Hi, The following patches fix installation path when cross-compiling Windows version, and move the NSIS build rule to meson. v3: - change qemu suffix handling, make /-separator implicit - use qemu suffix to build qemu_docdir, as --help says - use / to construct qemu d

[PATCH v3 5/8] meson: use meson datadir instead of qemu_datadir

2020-08-26 Thread marcandre . lureau
From: Marc-André Lureau When cross-compiling, by default qemu_datadir is 'c:\Program Files\QEMU', which is not recognized as being an absolute path, and meson will end up adding the prefix again. Signed-off-by: Marc-André Lureau --- contrib/vhost-user-gpu/meson.build | 2 +- meson.build

[PATCH v3 3/8] configure: build docdir like other suffixed directories

2020-08-26 Thread marcandre . lureau
From: Marc-André Lureau As documented in --help for --docdir. Signed-off-by: Marc-André Lureau --- configure | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/configure b/configure index 61216b9210..e880e5676d 100755 --- a/configure +++ b/configure @@ -1676,14 +1676,14

[PATCH v3 6/8] meson: pass docdir option

2020-08-26 Thread marcandre . lureau
From: Marc-André Lureau When cross-compiling, by default qemu_docdir is 'c:\Program Files\QEMU\' which is not recognized as being an absolute path, and meson will end up adding the prefix again. Add an option to pass docdir location to meson, pre-prefixed like we do with other directories, build

[PATCH v3 1/8] configure: rename confsuffix option

2020-08-26 Thread marcandre . lureau
From: Marc-André Lureau The value is used to construct conf/mod/data directories. Signed-off-by: Marc-André Lureau --- configure | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/configure b/configure index b1e11397a8..0e04c47722 100755 --- a/configure

[PATCH v3 7/8] meson: use meson mandir instead of qemu_mandir

2020-08-26 Thread marcandre . lureau
From: Marc-André Lureau When cross-compiling, by default qemu_mandir is 'c:\Program Files\QEMU', which is not recognized as being an absolute path, and meson will end up adding the prefix again. Use the pre-prefixed meson mandir option instead. Reviewed-by: Daniel P. Berrangé Signed-off-by: Ma

[PATCH v3 4/8] meson: pass qemu_suffix option

2020-08-26 Thread marcandre . lureau
From: Marc-André Lureau The following patches will make use of it to fix installation paths. Signed-off-by: Marc-André Lureau --- configure | 1 + meson_options.txt | 2 ++ 2 files changed, 3 insertions(+) diff --git a/configure b/configure index e880e5676d..05b944fb8e 100755 --- a/co

Re: [PATCH 00/12] Add a General Virtual Device Fuzzer

2020-08-26 Thread Dima Stepanov
Hi Alex, Thanks for the nice general fuzzer implementation, looks pretty exciting. Are there any future plans discussion which i can read or maybe join? I have some ideas about it so it could be great to syncronize. Regards, Dima. On Wed, Jul 22, 2020 at 11:39:21PM -0400, Alexander Bulekov wrote

[PATCH v3 8/8] meson: add NSIS building

2020-08-26 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé --- Makefile| 56 --- meson.build | 25 scripts/nsis.py | 78 + 3 files changed, 103 insertions(

Re: [PATCH v3 00/74] qom: Automated conversion of type checking boilerplate

2020-08-26 Thread Eduardo Habkost
On Wed, Aug 26, 2020 at 01:22:38PM +0300, Roman Bolshakov wrote: > On Tue, Aug 25, 2020 at 03:19:56PM -0400, Eduardo Habkost wrote: > > git tree for this series: > > https://github.com/ehabkost/qemu-hacks/tree/work/qom-macros-autoconvert > > > > Hi Eduardo, > > another assert fires during QEMU s

Re: [PATCH v4 2/6] util: refactor qemu_open_old to split off variadic args handling

2020-08-26 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Tue, Aug 25, 2020 at 04:56:40PM +0200, Markus Armbruster wrote: >> Daniel P. Berrangé writes: >> >> > This simple refactoring prepares for future patches. The variadic args >> > handling is split from the main bulk of the open logic. The duplicated >> > calls to

Re: [PATCH v4 5/6] util: give a specific error message when O_DIRECT doesn't work

2020-08-26 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Tue, Aug 25, 2020 at 05:19:53PM +0200, Markus Armbruster wrote: >> Daniel P. Berrangé writes: >> >> > A common error scenario is to tell QEMU to use O_DIRECT in combination >> > with a filesystem that doesn't support it. To aid users to diagnosing >> > their mist

Re: [PATCH for-4.2 v2 3/3] block/file-posix: Let post-EOF fallocate serialize

2020-08-26 Thread Vladimir Sementsov-Ogievskiy
26.08.2020 11:23, Vladimir Sementsov-Ogievskiy wrote: 22.08.2020 20:04, Vladimir Sementsov-Ogievskiy wrote: 22.08.2020 20:03, Vladimir Sementsov-Ogievskiy wrote: 01.11.2019 18:25, Max Reitz wrote: The XFS kernel driver has a bug that may cause data corruption for qcow2 images as of qemu commit

Re: [PATCH v5 07/10] block: introduce preallocate filter

2020-08-26 Thread Vladimir Sementsov-Ogievskiy
26.08.2020 12:58, Max Reitz wrote: On 26.08.20 11:15, Vladimir Sementsov-Ogievskiy wrote: 26.08.2020 11:52, Max Reitz wrote: On 26.08.20 08:49, Vladimir Sementsov-Ogievskiy wrote: 25.08.2020 18:11, Max Reitz wrote: On 21.08.20 16:11, Vladimir Sementsov-Ogievskiy wrote: It's intended to be in

[[PATCH v3] 2/5] meson: fixes relpath may fail on win32.

2020-08-26 Thread luoyonggang
From: Yonggang Luo On win32, os.path.relpath would raise exception when do the following relpath: C:/msys64/mingw64/x.exe relative to E:/path/qemu-build would fail. So we try catch it for stopping it from raise exception on msys2 Signed-off-by: Yonggang Luo --- scripts/mtest2make.py | 11 +

[[PATCH v3] 1/5] meson: Fixes the ninjatool issue that E$$: are generated in Makefile.ninja

2020-08-26 Thread luoyonggang
From: Yonggang Luo SIMPLE_PATH_RE should match the full path token. Or the $ and : contained in path would not matched if the path are start with C:/ and E:/ Signed-off-by: Yonggang Luo --- scripts/ninjatool.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/ninjat

[[PATCH v3] 4/5] configure: Fix include and linkage issue on msys2

2020-08-26 Thread luoyonggang
From: Yonggang Luo On msys2, the -I/e/path/to/qemu -L/e/path/to/qemu are not recognized by the compiler Cause $PWD are result posix style path such as /e/path/to/qemu that can not be recognized by mingw gcc, and `pwd -W` are result Windows style path such as E:/path/to/qemu that can be recogni

[[PATCH v3] 5/5] meson: Fixes ninjatool can not be recognized as script under Window/MSYS2

2020-08-26 Thread luoyonggang
From: Yonggang Luo use ninja instead ${build_path}/ninjatool Signed-off-by: Yonggang Luo --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 3b9e79923d..2ad0c58492 100755 --- a/configure +++ b/configure @@ -8222,7 +8222,7 @@ fi mv $cro

[[PATCH v3] 3/5] meson: Mingw64 gcc doesn't recognize system include_type for sdl2

2020-08-26 Thread luoyonggang
From: Yonggang Luo Fixes this for msys2/mingw64 by remove the include_type for sdl2 discovery in meson Signed-off-by: Yonggang Luo --- meson.build | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/meson.build b/meson.build index f0fe5f8799..1644bbd83c 100644 --- a/meson.bu

[PATCH v4 2/5] meson: fixes relpath may fail on win32.

2020-08-26 Thread luoyonggang
From: Yonggang Luo On win32, os.path.relpath would raise exception when do the following relpath: C:/msys64/mingw64/x.exe relative to E:/path/qemu-build would fail. So we try catch it for stopping it from raise exception on msys2 Signed-off-by: Yonggang Luo --- scripts/mtest2make.py | 11 +

[PATCH] meson: install pc-bios blobs

2020-08-26 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- Makefile| 31 -- pc-bios/meson.build | 63 + 2 files changed, 63 insertions(+), 31 deletions(-) diff --git a/Makefile b/Makefile index 3ebd6929b4..be5acf10e6

[PATCH v4 3/5] meson: Mingw64 gcc doesn't recognize system include_type for sdl2

2020-08-26 Thread luoyonggang
From: Yonggang Luo Fixes this for msys2/mingw64 by remove the include_type for sdl2 discovery in meson Signed-off-by: Yonggang Luo --- meson.build | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/meson.build b/meson.build index f0fe5f8799..1644bbd83c 100644 --- a/meson.bu

[PATCH v4 1/5] meson: Fixes the ninjatool issue that E$$: are generated in Makefile.ninja

2020-08-26 Thread luoyonggang
From: Yonggang Luo SIMPLE_PATH_RE should match the full path token. Or the $ and : contained in path would not matched if the path are start with C:/ and E:/ Signed-off-by: Yonggang Luo --- scripts/ninjatool.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/ninjat

[PATCH v4 5/5] meson: Fixes ninjatool can not be recognized as script under Window/MSYS2

2020-08-26 Thread luoyonggang
From: Yonggang Luo use ninja instead ${build_path}/ninjatool Signed-off-by: Yonggang Luo --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 3b9e79923d..2ad0c58492 100755 --- a/configure +++ b/configure @@ -8222,7 +8222,7 @@ fi mv $cro

Re: linux-user static build broken

2020-08-26 Thread Paolo Bonzini
Let me take a look tonight as I plan to prepare a pull request. Paolo Il mer 26 ago 2020, 12:53 Laurent Vivier ha scritto: > Le 26/08/2020 à 11:08, Paolo Bonzini a écrit : > > $ORIGIN is a special literal used by ld.so. It's probably fixed by the > > same patch that was posted for msys. > > If

[PATCH v4 4/5] configure: Fix include and linkage issue on msys2

2020-08-26 Thread luoyonggang
From: Yonggang Luo On msys2, the -I/e/path/to/qemu -L/e/path/to/qemu are not recognized by the compiler Cause $PWD are result posix style path such as /e/path/to/qemu that can not be recognized by mingw gcc, and `pwd -W` are result Windows style path such as E:/path/to/qemu that can be recogni

Re: [PATCH v3 0/8] meson: mingw installation fixes & nsis conversion

2020-08-26 Thread Paolo Bonzini
Since behavioral changes should be reviewed separately let's just include v2 first. Paolo Il mer 26 ago 2020, 13:04 ha scritto: > From: Marc-André Lureau > > Hi, > > The following patches fix installation path when cross-compiling Windows > version, and move the NSIS build rule to meson. > > v

Re: [PATCH 02/12] hw/vfio/ap: Plug memleak in vfio_ap_get_group()

2020-08-26 Thread Cornelia Huck
On Wed, 26 Aug 2020 19:03:37 +0800 Li Qiang wrote: > Pan Nengyuan 于2020年8月14日周五 下午6:29写道: > > > > Missing g_error_free() in vfio_ap_get_group() error path. Fix that. > > > > Reported-by: Euler Robot > > Signed-off-by: Pan Nengyuan > > Reviewed-by: Li Qiang > > I see Cornelia Huck has merg

[PATCH v3 11/12] hw/usb: Add U2F device check to passthru mode

2020-08-26 Thread César Belley
This patchs adds a check to verify that the device passed through the hidraw property is a U2F device. The check is done by ensuring that the first values of the report descriptor (USAGE PAGE and USAGE) correspond to those of a U2F device. Signed-off-by: César Belley --- hw/usb/u2f-passthru.c |

[PATCH v3 01/12] hw/usb: Regroup USB HID protocol values

2020-08-26 Thread César Belley
Group some HID values that are used pretty much everywhere when dealing with HID devices. Signed-off-by: César Belley --- hw/usb/dev-hid.c | 26 +++--- hw/usb/dev-wacom.c | 12 +++- include/hw/usb/hid.h | 17 + 3 files changed, 27 insertions(+),

[PATCH v3 03/12] hw/usb: Add U2F key base class

2020-08-26 Thread César Belley
This patch adds the specification for the U2F key base class. Used to group the common characteristics, this device class will be inherited by its two variants, corresponding to the two modes: passthrough and emulated This prepares the U2F devices hierarchy which is as follow: USB device -> u2f-ke

[PATCH v3 00/12] Introduce USB U2F key device

2020-08-26 Thread César Belley
This patch series adds the U2F dedicated support to Qemu through a USB U2F key device that can operate in two modes: pass-through and emulated. This work is also part of the GSoC program of this year and follows the proposal I made for the 'Virtual FIDO2/U2F security key' subject, suggested and me

[PATCH v3 02/12] docs: Add USB U2F key device documentation

2020-08-26 Thread César Belley
Add USB U2F key device documentation: - USB U2F key device - Building - Using u2f-emulated - Using u2f-passthru - Libu2f-emu Signed-off-by: César Belley --- docs/u2f.txt | 101 +++ 1 file changed, 101 insertions(+) create mode 100644 docs/u2f.txt

[PATCH v3 04/12] hw/usb: Add U2F key base class implementation

2020-08-26 Thread César Belley
This patch adds the U2F key base class implementation. The U2F key base mainly takes care of the HID interfacing with guest. On the one hand, it retrieves the guest U2FHID packets and transmits them to the variant associated according to the mode: pass-through or emulated. On the other hand, it pr

[PATCH v3 08/12] docs/system: Add U2F key to the USB devices examples

2020-08-26 Thread César Belley
Signed-off-by: César Belley --- docs/system/usb.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/docs/system/usb.rst b/docs/system/usb.rst index ddfa828d74..9a2f1927c4 100644 --- a/docs/system/usb.rst +++ b/docs/system/usb.rst @@ -81,6 +81,9 @@ option or the ``device_add`` monitor comma

[PATCH v3 05/12] hw/usb: Add U2F key passthru mode

2020-08-26 Thread César Belley
This patch adds the U2F key pass-through mode. The pass-through mode consists of passing all requests made from the guest to the physical security key connected to the host machine and vice versa. In addition, the dedicated pass-through allows to have a U2F security key shared on several guests w

[PATCH v3 10/12] scripts: Add u2f-setup-gen script

2020-08-26 Thread César Belley
This patch adds the script used to generate setup directories, needed for the device u2f-emulated configuration in directory mode: python u2f-setup-gen.py $DIR qemu -usb -device u2f-emulated,dir=$DIR Signed-off-by: César Belley --- scripts/u2f-setup-gen.py | 170

[PATCH v3 07/12] meson: Add U2F key to meson

2020-08-26 Thread César Belley
Signed-off-by: César Belley --- configure | 8 +++- hw/usb/Kconfig | 5 + hw/usb/meson.build | 7 +++ meson.build| 7 +++ meson_options.txt | 1 + 5 files changed, 27 insertions(+), 1 deletion(-) diff --git a/configure b/configure index b1e11397a8..24137d49d

[PATCH v3 06/12] hw/usb: Add U2F key emulated mode

2020-08-26 Thread César Belley
This patch adds the U2F key emulated mode. The emulated mode consists of completely emulating the behavior of a U2F device through software part. Libu2f-emu is used for that. The emulated mode is associated with a device inheriting from u2f-key base. To work, an emulated U2F device must have dif

[PATCH v3 09/12] docs/qdev-device-use.txt: Add USB U2F key to the QDEV devices examples

2020-08-26 Thread César Belley
Signed-off-by: César Belley --- docs/qdev-device-use.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/qdev-device-use.txt b/docs/qdev-device-use.txt index f8d0d2fe29..9889521e3c 100644 --- a/docs/qdev-device-use.txt +++ b/docs/qdev-device-use.txt @@ -325,6 +325,7 @@ The new way is -de

[PATCH v3 12/12] hw/usb: Add U2F device autoscan to passthru mode

2020-08-26 Thread César Belley
This patch adds an autoscan to let u2f-passthru choose the first U2F device it finds. The autoscan is performed using libudev with an enumeration of all the hidraw devices present on the host. The first device which happens to be a U2F device is taken to do the passtru. Signed-off-by: César Bell

Re: [PATCH v5 02/12] migration/dirtyrate: add DirtyRateStatus to denote calculation status

2020-08-26 Thread Dr. David Alan Gilbert
* Chuan Zheng (zhengch...@huawei.com) wrote: > add DirtyRateStatus to denote calculating status. > > Signed-off-by: Chuan Zheng With the minor wording changes from David Edmondson: Reviewed-by: Dr. David Alan Gilbert > --- > migration/dirtyrate.c | 22 ++ > qapi/migratio

Re: [PATCH v3 0/8] meson: mingw installation fixes & nsis conversion

2020-08-26 Thread Marc-André Lureau
Hi On Wed, Aug 26, 2020 at 3:38 PM Paolo Bonzini wrote: > Since behavioral changes should be reviewed separately let's just include > v2 first. > > I am more confident that this version doesn't introduce regressions though.. The use of + qemu_confsuffix was problematic, and I noticed some weird

[Bug 1893040] [NEW] External modules retreval using Go1.15 on s390x appears to have checksum and ECDSA verification issues

2020-08-26 Thread Guirish Salgaonkar
Public bug reported: We are observing issue while building go-runner image and we suspect it is due to QEMU version being used. As referred in below issue: https://github.com/golang/go/issues/40949 We tried to build go-runner image using go1.15 and register QEMU (docker run --rm --privileged mul

Re: [PATCH 02/12] hw/vfio/ap: Plug memleak in vfio_ap_get_group()

2020-08-26 Thread Li Qiang
Cornelia Huck 于2020年8月26日周三 下午7:41写道: > > On Wed, 26 Aug 2020 19:03:37 +0800 > Li Qiang wrote: > > > Pan Nengyuan 于2020年8月14日周五 下午6:29写道: > > > > > > Missing g_error_free() in vfio_ap_get_group() error path. Fix that. > > > > > > Reported-by: Euler Robot > > > Signed-off-by: Pan Nengyuan > > >

Re: [PATCH v2 6/7] x68: acpi: trigger SMI before sending hotplug Notify event to OSPM

2020-08-26 Thread Igor Mammedov
On Wed, 26 Aug 2020 11:24:14 +0200 Laszlo Ersek wrote: > Hi Igor, > > On 08/25/20 19:25, Laszlo Ersek wrote: > > > So I would suggest fetching the CNEW array element back into "uid" > > first, then using "uid" for both the NOTIFY call, and the (currently > > missing) restoration of CSEL. Then w

Re: [PATCH v5 03/12] migration/dirtyrate: Add RamlockDirtyInfo to store sampled page info

2020-08-26 Thread Dr. David Alan Gilbert
* Chuan Zheng (zhengch...@huawei.com) wrote: > Add RamlockDirtyInfo to store sampled page info of each ramblock. Note typo 'RAM*B*lockDirtyInfo' (and in the title. > Signed-off-by: Chuan Zheng > --- > migration/dirtyrate.h | 18 ++ > 1 file changed, 18 insertions(+) > > diff --

Re: [PATCH 01/12] qga/channel-posix: Plug memory leak in ga_channel_write_all()

2020-08-26 Thread Li Qiang
Pan Nengyuan 于2020年8月14日周五 下午6:30写道: > > Missing g_error_free on error path in ga_channel_write_all(). Fix that. > > Reported-by: Euler Robot > Signed-off-by: Pan Nengyuan Reviewed-by: Li Qiang > --- > Cc: Michael Roth > --- > qga/channel-posix.c | 6 +- > 1 file changed, 5 insertions(+

Re: [PATCH V8] Introduce a new flag for i440fx to disable PCI hotplug on the root bus

2020-08-26 Thread Igor Mammedov
On Mon, 24 Aug 2020 20:32:04 +0530 Ani Sinha wrote: > Reminder to kindly review this patch. I'm a bit occupied elsewhere right now, will look into it later when more urgent tasks are dealt with. Maybe Julia can help with review (CCed) (she should be familiar with the pci hotplug code atm) >

Re: [PATCH v5 04/12] migration/dirtyrate: Add dirtyrate statistics series functions

2020-08-26 Thread Dr. David Alan Gilbert
* Chuan Zheng (zhengch...@huawei.com) wrote: > Add dirtyrate statistics to record/update dirtyrate info. > > Signed-off-by: Chuan Zheng > --- > migration/dirtyrate.c | 29 + > migration/dirtyrate.h | 10 ++ > 2 files changed, 39 insertions(+) > > diff --git a

[Bug 1893040] Re: External modules retreval using Go1.15 on s390x appears to have checksum and ECDSA verification issues

2020-08-26 Thread Daniel Berrange
> We are observing issue while building go-runner image and we suspect it is > due to QEMU version > being used. As referred in below issue: > https://github.com/golang/go/issues/40949 This issue says the problem was due to https://bugs.launchpad.net/qemu/+bug/1847232/ which was fixed in QEMU 4.

[PATCH 3/3] backup: initialize bcs bitmap on job create, not start

2020-08-26 Thread Stefan Reiter
After backup_init_bcs_bitmap the copy-before-write behaviour is active. This way, multiple backup jobs created at once but running in a sequential transaction will still represent the same point in time. Signed-off-by: Stefan Reiter --- I'd imagine this was done on job start for a purpose, so th

[PATCH 0/3] Add support for sequential backups

2020-08-26 Thread Stefan Reiter
Backups can already be done for multiple drives in a transaction. However, these jobs will start all at once, potentially hogging a lot of disk IO all at once. This problem is made worse, since IO throttling is only available on a per-job basis. Add a flag to QMP to support sequential transactions

[PATCH 1/3] job: add sequential transaction support

2020-08-26 Thread Stefan Reiter
Jobs in a sequential transaction should never be started with job_start manually. job_txn_start_seq and the sequentially called job_start will take care of it, 'assert'ing in case a job is already running or has finished. Signed-off-by: Stefan Reiter --- include/qemu/job.h | 12 job

[PATCH 2/3] blockdev: add sequential mode to *-backup transactions

2020-08-26 Thread Stefan Reiter
Only supported with completion-mode 'grouped', since it relies on a JobTxn to exist. This means that for now it is only available for {drive,blockdev}-backup transactions. Since only one job will be running at a time, bandwidth-limits can be applied effectively. It can also prevent overloading a h

Re: [PATCH v5 8/8] i386: Simplify CPUID_8000_001E for AMD

2020-08-26 Thread Igor Mammedov
On Fri, 21 Aug 2020 17:13:09 -0500 Babu Moger wrote: > apic_id contains all the information required to build > CPUID_8000_001E. core_id and node_id is already part of > apic_id generated by x86_topo_ids_from_apicid_epyc. > Also remove the restriction on number bits on core_id and > node_id. > >

Re: [PATCH 06/12] ui/gtk-gl-area: Plug memleak in gd_gl_area_create_context()

2020-08-26 Thread Li Qiang
Pan Nengyuan 于2020年8月14日周五 下午6:15写道: > > Receiving error in local variable err, and forgot to free it. > Considering that there is no place to deal with it. Clean up. > > Reported-by: Euler Robot > Signed-off-by: Pan Nengyuan > --- > Cc: Gerd Hoffmann > --- > ui/gtk-gl-area.c | 5 ++--- > 1 fi

Re: [PATCH 07/12] target/i386/cpu: Fix memleak in x86_cpu_class_check_missing_features

2020-08-26 Thread Li Qiang
Pan Nengyuan 于2020年8月14日周五 下午6:38写道: > > 'err' forgot to free in x86_cpu_class_check_missing_features error path. > Fix that. > > Reported-by: Euler Robot > Signed-off-by: Pan Nengyuan Reviewed-by: Li Qiang > --- > Cc: Paolo Bonzini > Cc: Richard Henderson > Cc: Eduardo Habkost > --- > ta

Re: [PATCH v3] virtio-rng: return available data with O_NONBLOCK

2020-08-26 Thread Michael S. Tsirkin
On Tue, Aug 11, 2020 at 04:42:32PM +0200, Laurent Vivier wrote: > On 11/08/2020 16:28, mwi...@suse.com wrote: > > From: Martin Wilck > > > > If a program opens /dev/hwrng with O_NONBLOCK and uses poll() and > > non-blocking read() to retrieve random data, it ends up in a tight > > loop with poll(

Re: [PATCH v5 06/12] migration/dirtyrate: Record hash results for each sampled page

2020-08-26 Thread Dr. David Alan Gilbert
* David Edmondson (d...@dme.org) wrote: > On Monday, 2020-08-24 at 17:14:34 +08, Chuan Zheng wrote: > > > Record hash results for each sampled page, crc32 is taken to calculate > > hash results for each sampled 4K-page. > > > > Signed-off-by: Chuan Zheng > > Signed-off-by: YanYing Zhuang > > ---

[Bug 1883984] Re: QEMU S/390x sqxbr (128-bit IEEE 754 square root) crashes qemu-system-s390x

2020-08-26 Thread Christian Ehrhardt 
old version sudo apt install qemu-system-s390x=1:4.2-3ubuntu6.4 ...test as listed in the test instructions ... ubuntu@focal-sqxbr:~$ ./a.out Segmentation fault (qemu is dead at this point) $ sudo apt install qemu-system-s390x=1:4.2-3ubuntu6.5 Reading package lists... Done Building dependency tre

Re: [PATCH v5 06/12] migration/dirtyrate: Record hash results for each sampled page

2020-08-26 Thread David Edmondson
On Wednesday, 2020-08-26 at 13:30:16 +01, Dr. David Alan Gilbert wrote: > * David Edmondson (d...@dme.org) wrote: >> On Monday, 2020-08-24 at 17:14:34 +08, Chuan Zheng wrote: >> >> > Record hash results for each sampled page, crc32 is taken to calculate >> > hash results for each sampled 4K-page.

Re: [PATCH v5 06/12] migration/dirtyrate: Record hash results for each sampled page

2020-08-26 Thread Dr. David Alan Gilbert
* Chuan Zheng (zhengch...@huawei.com) wrote: > Record hash results for each sampled page, crc32 is taken to calculate > hash results for each sampled 4K-page. > > Signed-off-by: Chuan Zheng > Signed-off-by: YanYing Zhuang > --- > migration/dirtyrate.c | 136 > ++

Re: [PATCH] Simple & stupid coroutine-aware monitor_cur()

2020-08-26 Thread Markus Armbruster
Kevin Wolf writes: > Am 07.08.2020 um 15:27 hat Markus Armbruster geschrieben: >> This is just a sketch. It's incomplete, needs comments and a real >> commit message. >> >> Support for "[PATCH v6 09/12] hmp: Add support for coroutine command >> handlers" is missing. Marked FIXME. >> >> As is,

Re: [PATCH 08/12] migration/colo: Plug memleaks in colo_process_incoming_thread

2020-08-26 Thread Li Qiang
Pan Nengyuan 于2020年8月14日周五 下午6:52写道: > > 'local_err' forgot to free in colo_process_incoming_thread error path. > Fix that. > > Reported-by: Euler Robot > Signed-off-by: Pan Nengyuan > --- > Cc: Hailiang Zhang > Cc: Juan Quintela > Cc: "Dr. David Alan Gilbert" > --- > migration/colo.c | 2 ++

Re: [PATCH] Coroutine-aware monitor_cur() with coroutine-specific data

2020-08-26 Thread Markus Armbruster
Kevin Wolf writes: > Am 07.08.2020 um 15:29 hat Markus Armbruster geschrieben: >> This is just a sketch. It needs comments and a real commit message. >> >> As is, it goes on top of Kevin's series. It is meant to be squashed >> into PATCH 06. >> >> Signed-off-by: Markus Armbruster >> --- >>

Re: [PATCH v5 0/8] Remove EPYC mode apicid decode and use generic decode

2020-08-26 Thread Igor Mammedov
On Fri, 21 Aug 2020 17:12:19 -0500 Babu Moger wrote: > To support some of the complex topology, we introduced EPYC mode apicid > decode. > But, EPYC mode decode is running into problems. Also it can become quite a > maintenance problem in the future. So, it was decided to remove that code and >

Re: [PATCH v5 0/8] Remove EPYC mode apicid decode and use generic decode

2020-08-26 Thread Igor Mammedov
On Tue, 25 Aug 2020 16:25:21 +0100 "Dr. David Alan Gilbert" wrote: > * Igor Mammedov (imamm...@redhat.com) wrote: > > On Tue, 25 Aug 2020 09:15:04 +0100 > > "Dr. David Alan Gilbert" wrote: > > > > > * Babu Moger (babu.mo...@amd.com) wrote: > > > > Hi Dave, > > > > > > > > On 8/24/20 1:41 P

Re: [PATCH v5 0/8] Remove EPYC mode apicid decode and use generic decode

2020-08-26 Thread Daniel P . Berrangé
On Wed, Aug 26, 2020 at 02:38:49PM +0200, Igor Mammedov wrote: > On Fri, 21 Aug 2020 17:12:19 -0500 > Babu Moger wrote: > > > To support some of the complex topology, we introduced EPYC mode apicid > > decode. > > But, EPYC mode decode is running into problems. Also it can become quite a > > mai

[PATCH 3/6] meson: install icons

2020-08-26 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- Makefile | 12 ui/icons/meson.build | 13 + ui/meson.build | 1 + 3 files changed, 14 insertions(+), 12 deletions(-) create mode 100644 ui/icons/meson.build diff --git a/Makefile b/Makefil

[PATCH 0/6] meson: convert the remaining of install target

2020-08-26 Thread marcandre . lureau
From: Marc-André Lureau Hi, A few patches to finish replacing the Makefile install target by meson. Marc-André Lureau (6): meson: install pc-bios blobs meson: install scripts/qemu-trace-stap meson: install icons meson: install desktop file meson: install $localstatedir/run for qga b

[PATCH 2/6] meson: install scripts/qemu-trace-stap

2020-08-26 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- Makefile| 3 --- meson.build | 1 + scripts/meson.build | 3 +++ 3 files changed, 4 insertions(+), 3 deletions(-) create mode 100644 scripts/meson.build diff --git a/Makefile b/Makefile index 16b2ffa7fe..058cf87f

[PATCH 5/6] meson: install $localstatedir/run for qga

2020-08-26 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- Makefile| 10 +- qga/meson.build | 2 ++ 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/Makefile b/Makefile index dc3c20dd5e..9a9e7c0301 100644 --- a/Makefile +++ b/Makefile @@ -232,17 +232,9 @@ distcl

[PATCH 4/6] meson: install desktop file

2020-08-26 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- Makefile | 3 --- ui/meson.build | 2 ++ 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index d1a3cd77a5..dc3c20dd5e 100644 --- a/Makefile +++ b/Makefile @@ -243,9 +243,6 @@ endif # Needed by

[PATCH 1/6] meson: install pc-bios blobs

2020-08-26 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- Makefile| 31 -- pc-bios/meson.build | 63 + 2 files changed, 63 insertions(+), 31 deletions(-) diff --git a/Makefile b/Makefile index 81794d5c34..16b2ffa7fe

[PATCH 6/6] build-sys: remove install target from Makefile

2020-08-26 Thread marcandre . lureau
From: Marc-André Lureau Now covered by meson Signed-off-by: Marc-André Lureau --- Makefile | 5 - 1 file changed, 5 deletions(-) diff --git a/Makefile b/Makefile index 9a9e7c0301..75db8be52e 100644 --- a/Makefile +++ b/Makefile @@ -229,13 +229,8 @@ distclean: clean ninja-distclean

Re: [PATCH] meson: install pc-bios blobs

2020-08-26 Thread Marc-André Lureau
Hi On Wed, Aug 26, 2020 at 3:34 PM wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > --- > Makefile| 31 -- > pc-bios/meson.build | 63 + > 2 files changed, 63 insertions(+), 31 deletions(-) > >

Meson build on macOS: undefined symbol treatment

2020-08-26 Thread Emmanuel Blot
Hi, I’ve noticed that since meson builds have been enabled, on macOS, the build outcome with undefined symbols has changed: - prior to meson introduction (v5.1.0): * referencing an undeclared symbol in source code led to a warning at compile stage * referencing an undeclared symbol at lin

[Bug 1893040] Re: External modules retreval using Go1.15 on s390x appears to have checksum and ECDSA verification issues

2020-08-26 Thread Guirish Salgaonkar
Yes we have observed that the issue persist in later QEMU version too. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1893040 Title: External modules retreval using Go1.15 on s390x appears to have

Re: [PATCH v3] block: Raise an error when backing file parameter is an empty string

2020-08-26 Thread Kevin Wolf
Am 13.08.2020 um 15:47 hat Connor Kuehl geschrieben: > Providing an empty string for the backing file parameter like so: > > qemu-img create -f qcow2 -b '' /tmp/foo > > allows the flow of control to reach and subsequently fail an assert > statement because passing an empty string to > >

[PATCH] block/mirror: fix core when using iothreads

2020-08-26 Thread Peng Liang
We found an issue when doing block-commit with iothreads, which tries to dereference a NULL pointer. | | mirror_start_job | 1. bdrv_ref(mirror_top_bs); | bdrv_drained_begin(bs);| bdrv_append(mirror_to

Re: [PATCH v5 0/8] Remove EPYC mode apicid decode and use generic decode

2020-08-26 Thread Igor Mammedov
On Wed, 26 Aug 2020 13:50:59 +0100 Daniel P. Berrangé wrote: > On Wed, Aug 26, 2020 at 02:38:49PM +0200, Igor Mammedov wrote: > > On Fri, 21 Aug 2020 17:12:19 -0500 > > Babu Moger wrote: > > > > > To support some of the complex topology, we introduced EPYC mode apicid > > > decode. > > > But

Re: [PATCH v2 6/7] x68: acpi: trigger SMI before sending hotplug Notify event to OSPM

2020-08-26 Thread Laszlo Ersek
On 08/26/20 11:24, Laszlo Ersek wrote: > Hi Igor, > > On 08/25/20 19:25, Laszlo Ersek wrote: > >> So I would suggest fetching the CNEW array element back into "uid" >> first, then using "uid" for both the NOTIFY call, and the (currently >> missing) restoration of CSEL. Then we can write 1 to CINS

Re: [PATCH v2 6/7] x68: acpi: trigger SMI before sending hotplug Notify event to OSPM

2020-08-26 Thread Laszlo Ersek
On 08/26/20 15:32, Laszlo Ersek wrote: > On 08/26/20 11:24, Laszlo Ersek wrote: >> Hi Igor, >> >> On 08/25/20 19:25, Laszlo Ersek wrote: >> >>> So I would suggest fetching the CNEW array element back into "uid" >>> first, then using "uid" for both the NOTIFY call, and the (currently >>> missing) re

Re: [RFC PATCH v3 04/34] Hexagon (target/hexagon) scalar core definition

2020-08-26 Thread Richard Henderson
On 8/18/20 8:50 AM, Taylor Simpson wrote: > +#include This should not be in cpu.h. What's up? > +#define TARGET_PAGE_BITS 16 /* 64K pages */ > +#define TARGET_LONG_BITS 32 Belongs in cpu-param.h > +#ifdef CONFIG_USER_ONLY > +#define TOTAL_PER_THREAD_REGS 64 > +#else ... > +target_ulo

Re: [PATCH v5 0/8] Remove EPYC mode apicid decode and use generic decode

2020-08-26 Thread Daniel P . Berrangé
On Wed, Aug 26, 2020 at 03:30:34PM +0200, Igor Mammedov wrote: > On Wed, 26 Aug 2020 13:50:59 +0100 > Daniel P. Berrangé wrote: > > > On Wed, Aug 26, 2020 at 02:38:49PM +0200, Igor Mammedov wrote: > > > On Fri, 21 Aug 2020 17:12:19 -0500 > > > Babu Moger wrote: > > > > > > > To support some o

<    1   2   3   4   5   >