SDL is only used for system emulation; avoid spurious warnings for
static --disable-system emulation by skipping the detection of
the library if there are no system emulation targets.
Reported-by: Peter Maydell
Signed-off-by: Paolo Bonzini
---
meson.build | 27 ---
1 fil
On Windows it is not possible to invoke a Python script as $NINJA.
If ninja is present use it directly, while if it is not we can
keep using ninjatool.
Reported-by: Mark Cave-Ayland
Signed-off-by: Paolo Bonzini
---
configure | 16 +++-
1 file changed, 15 insertions(+), 1 deletion(-)
When pixman is not installed (or too old), but virglrenderer is available
and "configure" has been run with "--disable-system", the build currently
aborts when trying to compile vhost-user-gpu (since it requires pixman).
Let's skip the build of vhost-user-gpu when pixman is not installed or
too ol
24.08.2020 20:52, Vladimir Sementsov-Ogievskiy wrote:
21.08.2020 17:11, Vladimir Sementsov-Ogievskiy wrote:
It's intended to be inserted between format and protocol nodes to
preallocate additional space (expanding protocol file) on writes
crossing EOF. It improves performance for file-systems wi
On Tue, 25 Aug 2020 15:20:44 -0400
Eduardo Habkost wrote:
> Rename it to be consistent with S390_CCW_MACHINE and
> TYPE_S390_CCW_MACHINE.
>
> This will make future conversion to OBJECT_DECLARE* easier.
>
> Signed-off-by: Eduardo Habkost
> ---
> Changes series v2 -> v3: new patch added to serie
Please do not put all of your commit message in the subject line.
https://wiki.qemu.org/Contribute/SubmitAPatch#Write_a_meaningful_commit_message
https://chris.beams.io/posts/git-commit/
I found that there are many spelling errors in the comments of qemu,
so I used the spellcheck tool to check the spelling errors
and finally found some spelling errors in the folder.
Signed-off-by: zhaolichang
Reviewed-by: Alex Bennée
---
Changelog | 2 +-
accel/tcg/user-exec.c
I found that there are many spelling errors in the comments of qemu,
so I used the spellcheck tool to check the spelling errors, this series fixed
this
spelling errors.
v1 -> v2:
address Peter Maydell's comments
address Alex Bennée's comments
add reviewed-by for patch 1,2,3,4,5,6,9,10
zhao
I found that there are many spelling errors in the comments of qemu,
so I used the spellcheck tool to check the spelling errors
and finally found some spelling errors in the scripts folder.
Signed-off-by: zhaolichang
Reviewed-by: Peter Maydell
---
scripts/checkpatch.pl | 2 +-
scripts/cl
I found that there are many spelling errors in the comments of qemu,
so I used the spellcheck tool to check the spelling errors
and finally found some spelling errors in the migration folder.
Signed-off-by: zhaolichang
Reviewed-by: Peter Maydell
---
migration/colo-failover.c | 2 +-
migration/co
I found that there are many spelling errors in the comments of qemu,
so I used the spellcheck tool to check the spelling errors
and finally found some spelling errors in the contrib folder.
Signed-off-by: zhaolichang
Reviewed-by: Alex Bennée
---
contrib/gitdm/filetypes.txt | 6 +++---
I found that there are many spelling errors in the comments of qemu,
so I used the spellcheck tool to check the spelling errors
and finally found some spelling errors in the docs folder.
Signed-off-by: zhaolichang
Reviewed-by: Peter Maydell
---
docs/COLO-FT.txt | 6 +++---
docs/de
I found that there are many spelling errors in the comments of qemu,
so I used the spellcheck tool to check the spelling errors
and finally found some spelling errors in the util folder.
Signed-off-by: zhaolichang
Reviewed-by: Alex Bennée
---
util/osdep.c | 2 +-
util/qemu-progress.c
I found that there are many spelling errors in the comments of qemu,
so I used the spellcheck tool to check the spelling errors
and finally found some spelling errors in the block folder.
Signed-off-by: zhaolichang
---
block/block-copy.c | 2 +-
block/linux-aio.c | 2 +-
block/mirror.c | 2 +-
I found that there are many spelling errors in the comments of qemu,
so I used the spellcheck tool to check the spelling errors
and finally found some spelling errors in the linux-user folder.
Signed-off-by: zhaolichang
Reviewed-by: Alex Bennée
---
linux-user/aarch64/signal.c | 2 +-
I found that there are many spelling errors in the comments of qemu,
so I used the spellcheck tool to check the spelling errors
and finally found some spelling errors in the qapi folder.
Signed-off-by: zhaolichang
Reviewed-by: Markus Armbruster
---
qapi/block-core.json | 4 ++--
qapi/crypto.json
I found that there are many spelling errors in the comments of qemu,
so I used the spellcheck tool to check the spelling errors
and finally found some spelling errors in the disas folder.
Signed-off-by: zhaolichang
---
disas/hppa.c | 2 +-
disas/m68k.c | 8
disas/ppc.c | 2 +-
3 files chan
The following changes since commit 30aa19446d82358a30eac3b556b4d6641e00b7c1:
Merge remote-tracking branch 'remotes/cschoenebeck/tags/pull-9p-20200812'
into staging (2020-08-24 16:39:53 +0100)
are available in the Git repository at:
https://github.com/XanClic/qemu.git tags/pull-block-2020-08
Public bug reported:
When using iovec I/O functions (like `readv`), no data translation
happens. I'm hitting this issue with libevent upon constructing a
bufferevent over an inotify descriptor, and then building for either
ppc64 or s390x (both big-endian) on x86_64 (little-endian) and running
resu
Queued, thanks.
Paolo
On Wed, Aug 26, 2020 at 12:23 AM Mark Cave-Ayland
wrote:
>
> Prevously CONFIG_VTE was not required to build QEMU with GTK UI support as not
> all platforms have VTE available (in particular Windows).
>
> Remove this requirement from the meson build system to enable QEMU to
Eduardo Habkost wrote:
> Rename the macros to make them consistent with the MIGRATION_OBJ
> macro name.
>
> This will make future conversion to OBJECT_DECLARE* easier.
>
> Signed-off-by: Eduardo Habkost
> ---
> Changes series v2 -> v3: new patch added to series v3
>
> ---
> Cc: Juan Quintela
> C
Eduardo Habkost wrote:
> Generated using:
> $ ./scripts/codeconverter/converter.py -i --passes=2 \
> --pattern=TypeRegisterCall,TypeInitMacro $(git grep -l TypeInfo --
> '*.[ch]')
>
> One notable difference is that files declaring multiple types
> will now have multiple separate __construto
Eduardo Habkost wrote:
> Some typedefs and macros are defined after the type check macros.
> This makes it difficult to automatically replace their
> definitions with OBJECT_DECLARE_TYPE.
>
> Patch generated using:
>
> $ ./scripts/codeconverter/converter.py -i \
>--pattern=QOMStructTypedefSpl
[dropped people from CC]
Eduardo Habkost wrote:
> Some typedefs and macros are defined after the type check macros.
> This makes it difficult to automatically replace their
> definitions with OBJECT_DECLARE_TYPE.
>
> Patch generated using:
>
> $ ./scripts/codeconverter/converter.py -i \
>-
On Wed, Aug 26, 2020 at 11:03 AM Paolo Bonzini wrote:
> SDL is only used for system emulation; avoid spurious warnings for
> static --disable-system emulation by skipping the detection of
> the library if there are no system emulation targets.
>
> Reported-by: Peter Maydell
> Signed-off-by: Paol
Eduardo Habkost wrote:
> $ ./scripts/codeconverter/converter.py -i \
>--pattern=TypeCheckMacro $(git grep -l '' -- '*.[ch]')
>
> Signed-off-by: Eduardo Habkost
> ---
> Changes series v2 -> v3: this is a new patch added in series v3
>
> The script was re-run after rebase and after additional
Eduardo Habkost wrote:
> $ ./scripts/codeconverter/converter.py -i \
>--pattern=TypeCheckMacro $(git grep -l '' -- '*.[ch]')
>
> Reviewed-by: Daniel P. Berrangé
> Signed-off-by: Eduardo Habkost
> ---
> Changes v2 -> v3:
> * Removed hunks due to rebase conflicts:
> hw/arm/integratorcp.c hw
Hi, I will post next week a patch to make all searches relative to the
executable path. I will CC you so you can test it.
Thanks!
Paolo
Il mer 26 ago 2020, 10:01 ha scritto:
> Prior to commit 6dd2dacedd83d12328afa8559bffb2b9ec5c89ed (v5.0.0), the
> binary relative path ../share/qemu was search
On Wed, Aug 26, 2020 at 08:48:22AM +0200, Paolo Bonzini wrote:
> On Tue, Aug 25, 2020 at 11:38 PM Mark Cave-Ayland
> wrote:
> > Marc-André had a query about why this is marked as a system include,
> > however I can
> > confirm that it fixes the missing "SDL.h" issue during build.
>
> It was mark
22.08.2020 20:04, Vladimir Sementsov-Ogievskiy wrote:
22.08.2020 20:03, Vladimir Sementsov-Ogievskiy wrote:
01.11.2019 18:25, Max Reitz wrote:
The XFS kernel driver has a bug that may cause data corruption for qcow2
images as of qemu commit c8bb23cbdbe32f. We can work around it by
treating pos
On Tue, Aug 25, 2020 at 09:58:23PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> The following patches will make use of it to fix installation paths.
>
> Signed-off-by: Marc-André Lureau
> ---
> configure | 1 +
> meson_options.txt | 1 +
> 2 files changed, 2
On Tue, Aug 25, 2020 at 09:58:24PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> When cross-compiling, by default qemu_datadir is 'c:\Program
> Files\QEMU', which is not recognized as being an absolute path, and
> meson will end up adding the prefix again.
>
> Signed-of
On Tue, Aug 25, 2020 at 09:58:25PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> When cross-compiling, by default qemu_docdir is 'c:\Program Files\QEMU\'
> which is not recognized as being an absolute path, and meson will end up
> adding the prefix again.
>
> Add an opt
On Tue, Aug 25, 2020 at 09:58:26PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> When cross-compiling, by default qemu_mandir is 'c:\Program
> Files\QEMU', which is not recognized as being an absolute path, and
> meson will end up adding the prefix again.
>
> Use the pr
On 26.08.20 08:26, Vladimir Sementsov-Ogievskiy wrote:
> 25.08.2020 16:10, Max Reitz wrote:
>> On 21.08.20 16:11, Vladimir Sementsov-Ogievskiy wrote:
>>> Add flag to make serialising request no wait: if there are conflicting
>>> requests, just return error immediately. It's will be used in upcoming
Hi
On Wed, Aug 26, 2020 at 12:32 PM Daniel P. Berrangé
wrote:
> On Tue, Aug 25, 2020 at 09:58:25PM +0400, marcandre.lur...@redhat.com
> wrote:
> > From: Marc-André Lureau
> >
> > When cross-compiling, by default qemu_docdir is 'c:\Program Files\QEMU\'
> > which is not recognized as being an abs
On Tue, Aug 25, 2020 at 09:58:27PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Signed-off-by: Marc-André Lureau
> ---
> Makefile| 56 ---
> meson.build | 25
> scripts/nsis.py | 78 +
On Tue, Aug 25, 2020 at 10:36:13PM +0200, Laurent Vivier wrote:
> Hi,
>
> since we have switched to meson, the statically linked binaries of qemu
> linux-user are broken:
>
> cd $OBJ
> $SRC/configure --static --target-list=m68k-linux-user
> make
> ./qemu-m68k
> Segmentation fault (core dumped)
>
Public bug reported:
"Open file description locks (non-POSIX)", as they are described in
fcntl(2) man page, aren't supported by qemu-user and attempting to use
those results in EINVAL. I'm on Gentoo with latest QEMU version
currently available (5.0.0-r2), and trying to emulate ppc64 and s390x on
Le 26/08/2020 à 10:44, Daniel P. Berrangé a écrit :
> On Tue, Aug 25, 2020 at 10:36:13PM +0200, Laurent Vivier wrote:
>> Hi,
>>
>> since we have switched to meson, the statically linked binaries of qemu
>> linux-user are broken:
>>
>> cd $OBJ
>> $SRC/configure --static --target-list=m68k-linux-user
On 26.08.20 08:49, Vladimir Sementsov-Ogievskiy wrote:
> 25.08.2020 18:11, Max Reitz wrote:
>> On 21.08.20 16:11, Vladimir Sementsov-Ogievskiy wrote:
>>> It's intended to be inserted between format and protocol nodes to
>>> preallocate additional space (expanding protocol file) on writes
>>> crossi
Hi
On Wed, Aug 26, 2020 at 12:30 PM Daniel P. Berrangé
wrote:
> On Tue, Aug 25, 2020 at 09:58:24PM +0400, marcandre.lur...@redhat.com
> wrote:
> > From: Marc-André Lureau
> >
> > When cross-compiling, by default qemu_datadir is 'c:\Program
> > Files\QEMU', which is not recognized as being an ab
** Summary changed:
- qemu-user doesn't support OFD fcntl locks
+ qemu linux-user doesn't support OFD fcntl locks
** Tags added: linux-user
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1893010
Tit
** Summary changed:
- qemu-user doesn't translate host/target data for iovec I/O
+ qemu linux-user doesn't translate host/target data for iovec I/O
** Tags added: linux-user
** Tags added: ppc s390x
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subs
26.08.2020 11:36, Max Reitz wrote:
On 26.08.20 08:26, Vladimir Sementsov-Ogievskiy wrote:
25.08.2020 16:10, Max Reitz wrote:
On 21.08.20 16:11, Vladimir Sementsov-Ogievskiy wrote:
Add flag to make serialising request no wait: if there are conflicting
requests, just return error immediately. It
On Thu, Aug 20, 2020 at 02:24:26PM +0100, Sean Mooney wrote:
> On Thu, 2020-08-20 at 14:27 +0800, Yan Zhao wrote:
> > On Thu, Aug 20, 2020 at 06:16:28AM +0100, Sean Mooney wrote:
> > > On Thu, 2020-08-20 at 12:01 +0800, Yan Zhao wrote:
> > > > On Thu, Aug 20, 2020 at 02:29:07AM +0100, Sean Mooney w
$ORIGIN is a special literal used by ld.so. It's probably fixed by the same
patch that was posted for msys.
Paolo
Il mer 26 ago 2020, 10:51 Laurent Vivier ha scritto:
> Le 26/08/2020 à 10:44, Daniel P. Berrangé a écrit :
> > On Tue, Aug 25, 2020 at 10:36:13PM +0200, Laurent Vivier wrote:
> >> H
26.08.2020 11:52, Max Reitz wrote:
On 26.08.20 08:49, Vladimir Sementsov-Ogievskiy wrote:
25.08.2020 18:11, Max Reitz wrote:
On 21.08.20 16:11, Vladimir Sementsov-Ogievskiy wrote:
It's intended to be inserted between format and protocol nodes to
preallocate additional space (expanding protocol
It is still a bug in QEMU -- we shouldn't allow guest behaviour to make
QEMU assert(). If there's unimplemented functionality in the USB
controller model that can be logged with qemu_log_mask(LOG_UNIMP, ...)
--
You received this bug notification because you are a member of qemu-
devel-ml, which i
On Tue, 25 Aug 2020 19:25:48 +0200
Laszlo Ersek wrote:
> On 08/18/20 14:22, Igor Mammedov wrote:
> > In case firmware has negotiated CPU hotplug SMI feature, generate
> > AML to describe SMI IO port region and send SMI to firmware
> > on each CPU hotplug SCI in case new CPUs were hotplugged.
> >
Minor wordsmithing...
On Monday, 2020-08-24 at 17:14:30 +08, Chuan Zheng wrote:
> add DirtyRateStatus to denote calculating status.
>
> Signed-off-by: Chuan Zheng
> ---
> migration/dirtyrate.c | 22 ++
> qapi/migration.json | 17 +
> 2 files changed, 39 ins
Hi Igor,
On 08/25/20 19:25, Laszlo Ersek wrote:
> So I would suggest fetching the CNEW array element back into "uid"
> first, then using "uid" for both the NOTIFY call, and the (currently
> missing) restoration of CSEL. Then we can write 1 to CINS.
>
> Expressed as a patch on top of yours:
>
>> d
On Wed, 26 Aug 2020 at 04:21, Bin Meng wrote:
> On Wed, Aug 26, 2020 at 6:41 AM Alistair Francis wrote:
> > Richard and Philippe review patches and some of the RISC-V patches get
> > reviewed by the RISC-V community. The main problem (which is a common
> > problem in open source) is that large te
On Tue, 25 Aug 2020 at 20:01, Alistair Francis wrote:
>
> The following changes since commit 7774e403f2ac58b3e87bfe8d2f77676501ba893e:
>
> Merge remote-tracking branch
> 'remotes/kraxel/tags/fixes-20200825-pull-request' into staging (2020-08-25
> 10:54:51 +0100)
>
> are available in the Git re
On Monday, 2020-08-24 at 17:14:31 +08, Chuan Zheng wrote:
> Add RamlockDirtyInfo to store sampled page info of each ramblock.
>
> Signed-off-by: Chuan Zheng
> ---
> migration/dirtyrate.h | 18 ++
> 1 file changed, 18 insertions(+)
>
> diff --git a/migration/dirtyrate.h b/migratio
Le mar. 25 août 2020 18:09, Peter Maydell a
écrit :
> It is the responsibility of board code for an armv7m system to set
> system_clock_scale appropriately for the CPU speed of the core.
> If it forgets to do this, then QEMU will hang if the guest tries
> to use the systick timer in the "tick at
On 2020/8/26 17:29, David Edmondson wrote:
> On Monday, 2020-08-24 at 17:14:31 +08, Chuan Zheng wrote:
>
>> Add RamlockDirtyInfo to store sampled page info of each ramblock.
>>
>> Signed-off-by: Chuan Zheng
>> ---
>> migration/dirtyrate.h | 18 ++
>> 1 file changed, 18 inserti
Le mar. 25 août 2020 19:42, Alistair Francis a
écrit :
> Reported-by: Eduardo Habkost
> Signed-off-by: Alistair Francis
> ---
> hw/core/register.c | 31 +--
> 1 file changed, 13 insertions(+), 18 deletions(-)
>
> diff --git a/hw/core/register.c b/hw/core/register.c
You'd need to check first if it works correctly if confsuffix "looks like"
an absolute path ('/qemu'). So + looks correct to me.
(Sorry for top posting).
Paolo
Il mer 26 ago 2020, 10:53 Marc-André Lureau ha
scritto:
> Hi
>
> On Wed, Aug 26, 2020 at 12:30 PM Daniel P. Berrangé
> wrote:
>
>> On
Hi Peter,
Le lun. 24 août 2020 17:20, Peter Maydell a
écrit :
> On Sat, 22 Aug 2020 at 21:00, Philippe Mathieu-Daudé
> wrote:
> >
> > On 8/6/20 3:03 PM, Philippe Mathieu-Daudé wrote:
> > > This series improve tracing of multiple UART device in the same
> > > chipset, and allow to use the Clock
Hi Peter,
Le lun. 24 août 2020 17:01, Peter Maydell a
écrit :
> On Sat, 22 Aug 2020 at 21:02, Philippe Mathieu-Daudé
> wrote:
> >
> > On 8/12/20 9:02 PM, Philippe Mathieu-Daudé wrote:
> > > This series aims to ease looking at the '-d unimp' output reported
> > > by the UnimplementedDevice.
> >
Le mer. 26 août 2020 11:54, Philippe Mathieu-Daudé a
écrit :
> Hi Peter,
>
> Le lun. 24 août 2020 17:01, Peter Maydell a
> écrit :
>
>> On Sat, 22 Aug 2020 at 21:02, Philippe Mathieu-Daudé
>> wrote:
>> >
>> > On 8/12/20 9:02 PM, Philippe Mathieu-Daudé wrote:
>> > > This series aims to ease look
On Monday, 2020-08-24 at 17:14:34 +08, Chuan Zheng wrote:
> Record hash results for each sampled page, crc32 is taken to calculate
> hash results for each sampled 4K-page.
>
> Signed-off-by: Chuan Zheng
> Signed-off-by: YanYing Zhuang
> ---
> migration/dirtyrate.c | 136
> +
On Fri, 21 Aug 2020 17:12:25 -0500
Babu Moger wrote:
> Remove node_id, nr_nodes and nodes_per_pkg from topology. Use
> die_id, nr_dies and dies_per_pkg which is already available.
> Removes the confusion over two variables.
>
> With node_id removed in topology the uninitialized memory issue
> wi
On 26.08.20 11:15, Vladimir Sementsov-Ogievskiy wrote:
> 26.08.2020 11:52, Max Reitz wrote:
>> On 26.08.20 08:49, Vladimir Sementsov-Ogievskiy wrote:
>>> 25.08.2020 18:11, Max Reitz wrote:
On 21.08.20 16:11, Vladimir Sementsov-Ogievskiy wrote:
> It's intended to be inserted between format
On 2020/8/26 17:40, Zheng Chuan wrote:
>
>
> On 2020/8/26 17:29, David Edmondson wrote:
>> On Monday, 2020-08-24 at 17:14:31 +08, Chuan Zheng wrote:
>>
>>> Add RamlockDirtyInfo to store sampled page info of each ramblock.
>>>
>>> Signed-off-by: Chuan Zheng
>>> ---
>>> migration/dirtyrate.h |
Hi Peter,
On Wed, Aug 26, 2020 at 5:25 PM Peter Maydell wrote:
>
> On Wed, 26 Aug 2020 at 04:21, Bin Meng wrote:
> > On Wed, Aug 26, 2020 at 6:41 AM Alistair Francis
> > wrote:
> > > Richard and Philippe review patches and some of the RISC-V patches get
> > > reviewed by the RISC-V community.
On Monday, 2020-08-24 at 17:14:35 +08, Chuan Zheng wrote:
> Compare page hash results for recorded sampled page.
>
> Signed-off-by: Chuan Zheng
> Signed-off-by: YanYing Zhuang
> ---
> migration/dirtyrate.c | 64
> +++
> 1 file changed, 64 inserti
On Monday, 2020-08-24 at 17:14:36 +08, Chuan Zheng wrote:
> In order to sample real RAM, skip ramblock with size below MIN_RAMBLOCK_SIZE
> which is set as 128M.
>
> Signed-off-by: Chuan Zheng
> ---
> migration/dirtyrate.c | 24
> migration/dirtyrate.h | 10 ++
>
From: alexchen
The fd will leak when (a.st_ino == b.st_ino) is true, fix it.
Signed-off-by: AlexChen
---
util/oslib-posix.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/util/oslib-posix.c b/util/oslib-posix.c
index ad8001a4ad..74cf5e9c73 100644
--- a/util/oslib-posix.c
+++ b/util/oslib-
Chenqun (kuhn) 于2020年8月26日周三 上午9:47写道：
>
>
> > > Clang static code analyzer show warning:
> > > hw/vfio/platform.c:239:9: warning: Value stored to 'ret' is never read
> > > ret = event_notifier_test_and_clear(intp->interrupt);
> > > ^ ~~~
From: AlexChen
The 'kdgb' is allocating memory in get_kdbg(), but it is not freed
in both fill_header() and fill_context() failed branches, fix it.
Signed-off-by: AlexChen
---
contrib/elf2dmp/main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/contrib/elf2dmp/main.c
On Monday, 2020-08-24 at 17:14:37 +08, Chuan Zheng wrote:
> Implement get_sample_page_period() and set_sample_page_period() to
> sleep specific time between sample actions.
>
> Signed-off-by: Chuan Zheng
> ---
> migration/dirtyrate.c | 24
> migration/dirtyrate.h | 2 ++
Le 25/08/2020 à 21:20, Eduardo Habkost a écrit :
> Rename the existing class type checking macros to be consistent
> with the type name and instance type checking macro. Use a
> NUBUS_MACFB prefix instead of MACFB_NUBUS.
>
> This will make future conversion to OBJECT_DECLARE* easier.
>
> Signed-
Le 25/08/2020 à 21:20, Eduardo Habkost a écrit :
> Currently we have a SWIM typedef and a SWIM type checking macro,
> but OBJECT_DECLARE* would transform the SWIM macro into a
> function, and the function name would conflict with the SWIM
> typedef name.
>
> Rename the struct and typedef to "Swim"
On Wed, Aug 26, 2020 at 06:14:48PM +0800, AlexChen wrote:
> From: alexchen
>
> The fd will leak when (a.st_ino == b.st_ino) is true, fix it.
That is *INTENTIONAL*. We're holding a lock on the file and the
lock exists only while the FD is open. When QEMU exists, the FD
is closed and the lock is
On Monday, 2020-08-24 at 17:14:38 +08, Chuan Zheng wrote:
> Implement calculate_dirtyrate() function.
>
> Signed-off-by: Chuan Zheng
> Signed-off-by: YanYing Zhuang
> ---
> migration/dirtyrate.c | 45 +++--
> 1 file changed, 43 insertions(+), 2 deletions(
On Tue, Aug 25, 2020 at 03:19:56PM -0400, Eduardo Habkost wrote:
> git tree for this series:
> https://github.com/ehabkost/qemu-hacks/tree/work/qom-macros-autoconvert
>
Hi Eduardo,
another assert fires during QEMU start:
$ lldb -- $QEMU -cpu nahelem -M q35,accel=hvf -cdrom test.iso
(lldb) targe
Chen Qun 于2020年8月25日周二 下午7:28写道：
>
> Clang static code analyzer show warning:
> hw/virtio/vhost-user.c:606:9: warning: Value stored to 'mr' is never read
> mr = vhost_user_get_mr_data(reg->userspace_addr, &offset, &fd);
> ^~~~
On Monday, 2020-08-24 at 17:14:39 +08, Chuan Zheng wrote:
> Implement qmp_cal_dirty_rate()/qmp_get_dirty_rate() function which could be
> called
>
> Signed-off-by: Chuan Zheng
> ---
> migration/dirtyrate.c | 45 +
> qapi/migration.json | 44
* David Edmondson (d...@dme.org) wrote:
> On Monday, 2020-08-24 at 17:14:31 +08, Chuan Zheng wrote:
>
> > Add RamlockDirtyInfo to store sampled page info of each ramblock.
> >
> > Signed-off-by: Chuan Zheng
> > ---
> > migration/dirtyrate.h | 18 ++
> > 1 file changed, 18 inserti
Pan Nengyuan 于2020年8月14日周五 下午6:40写道：
>
> 'addr' forgot to free in vnc_socket_ip_addr_string error path. Fix that.
s/forgot/is forgot, I think the maintainer will do this minor adjustment.
.
>
> Reported-by: Euler Robot
> Signed-off-by: Pan Nengyuan
Reviewed-by: Li Qiang
> ---
> Cc: Gerd
Pan Nengyuan 于2020年8月14日周五 下午6:32写道：
>
> local_err is not initialized to NULL, it will cause a assert error as below:
> qemu/util/error.c:59: error_setv: Assertion `*errp == NULL' failed.
>
> Fixes: c6447510690
> Reported-by: Euler Robot
> Signed-off-by: Pan Nengyuan
Reviewed-by: Li Qiang
> -
Pan Nengyuan 于2020年8月14日周五 下午6:54写道：
>
> 'local_err' seems forgot to propagate in error path, it'll cause
> a memleak. Fix it.
>
> Reported-by: Euler Robot
> Signed-off-by: Pan Nengyuan
Reviewed-by: Li Qiang
> ---
> Cc: Kevin Wolf
> Cc: Max Reitz
> Cc: Markus Armbruster
> Cc: qemu-bl...@no
Your pipeline has failed.
Project: QEMU ( https://gitlab.com/qemu-project/qemu )
Branch: master ( https://gitlab.com/qemu-project/qemu/-/commits/master )
Commit: 78dca230 (
https://gitlab.com/qemu-project/qemu/-/commit/78dca230c97ed0d6e16ae0c96d5407644d991994
)
Commit Message: Merge remote-tr
Add control regs (sleep, reset) for hw-reduced acpi.
Signed-off-by: Gerd Hoffmann
Reviewed-by: Igor Mammedov
---
include/hw/acpi/generic_event_device.h | 12 +++
hw/acpi/generic_event_device.c | 44 ++
2 files changed, 56 insertions(+)
diff --git a/include/h
Set AcpiDeviceIfClass->madt_cpu,
otherwise identical to TYPE_ACPI_GED.
Signed-off-by: Gerd Hoffmann
Reviewed-by: Igor Mammedov
---
include/hw/acpi/generic_event_device.h | 4 +++
hw/i386/generic_event_device_x86.c | 36 ++
hw/i386/meson.build| 1
Signed-off-by: Gerd Hoffmann
---
roms/Makefile | 5 -
roms/config.seabios-microvm | 26 ++
2 files changed, 30 insertions(+), 1 deletion(-)
create mode 100644 roms/config.seabios-microvm
diff --git a/roms/Makefile b/roms/Makefile
index 2673a39f9dc2..f8
qboot isn't a bios and shouldnt be named that way.
Signed-off-by: Gerd Hoffmann
---
hw/i386/microvm.c | 4 ++--
pc-bios/{bios-microvm.bin => qboot.rom} | Bin
roms/Makefile | 6 +++---
3 files changed, 5 insertions(+), 5 deletions(-)
rename pc
... in case we are using ACPI.
Signed-off-by: Gerd Hoffmann
Reviewed-by: Igor Mammedov
---
hw/i386/microvm.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/i386/microvm.c b/hw/i386/microvm.c
index 54510a03f754..04209eb38fbe 100644
--- a/hw/i386/microvm.c
+++ b/hw/i386/
Signed-off-by: Gerd Hoffmann
---
pc-bios/bios-microvm.bin | Bin 0 -> 131072 bytes
1 file changed, 0 insertions(+), 0 deletions(-)
create mode 100644 pc-bios/bios-microvm.bin
diff --git a/pc-bios/bios-microvm.bin b/pc-bios/bios-microvm.bin
new file mode 100644
index
000
On Wednesday, 2020-08-26 at 11:33:30 +01, Dr. David Alan Gilbert wrote:
> * David Edmondson (d...@dme.org) wrote:
>> On Monday, 2020-08-24 at 17:14:31 +08, Chuan Zheng wrote:
>>
>> > Add RamlockDirtyInfo to store sampled page info of each ramblock.
>> >
>> > Signed-off-by: Chuan Zheng
>> > ---
>
The cpu hotplug code handles the initialization of coldplugged cpus
too, so it is needed even in case cpu hotplug is not supported.
Move the code from pc to x86, so microvm can use it.
Move both plug and unplug to keep everything in one place, even
though microvm needs plug only.
Signed-off-by:
Signed-off-by: Gerd Hoffmann
---
tests/qtest/bios-tables-test.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
index 058ba3886659..883532e531d6 100644
--- a/tests/qtest/bios-tables-test.c
+++ b/tests/qtest/bios-
Both pc and microvm machine types have a acpi_dev field.
Move it to the common base type.
Signed-off-by: Gerd Hoffmann
---
include/hw/i386/microvm.h | 1 -
include/hw/i386/pc.h | 1 -
include/hw/i386/x86.h | 1 +
hw/i386/acpi-build.c | 2 +-
hw/i386/acpi-microvm.c| 5 +++--
With ACPI enabled and IO-APIC being properly declared in the ACPI tables
we can use interrupt lines 16-23 for virtio and avoid shared interrupts.
With acpi disabled we continue to use lines 5-12.
Signed-off-by: Gerd Hoffmann
Reviewed-by: Sergio Lopez
Reviewed-by: Igor Mammedov
---
hw/i386/mic
Also clear tests/qtest/bios-tables-test-allowed-diff.h
Signed-off-by: Gerd Hoffmann
---
tests/qtest/bios-tables-test-allowed-diff.h | 3 ---
tests/data/acpi/microvm/APIC| Bin 0 -> 70 bytes
tests/data/acpi/microvm/DSDT| Bin 0 -> 365 bytes
tests/data/acpi/microv
Signed-off-by: Gerd Hoffmann
Reviewed-by: Sergio Lopez
Reviewed-by: Igor Mammedov
---
include/hw/i386/microvm.h | 2 +-
hw/i386/microvm.c | 11 +++
2 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/include/hw/i386/microvm.h b/include/hw/i386/microvm.h
index fd34b78
$subject says all. Can be controlled using -M microvm,acpi=on/off.
Signed-off-by: Gerd Hoffmann
---
hw/i386/acpi-microvm.h| 8 ++
include/hw/i386/microvm.h | 9 ++
hw/i386/acpi-microvm.c| 187 ++
hw/i386/microvm.c | 40
hw/i386/K
With acpi=off continue to use qboot.
Signed-off-by: Gerd Hoffmann
Reviewed-by: Igor Mammedov
---
hw/i386/microvm.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/hw/i386/microvm.c b/hw/i386/microvm.c
index ca0c9983f137..54510a03f754 100644
--- a/hw/i386/microvm.c
+++ b/
1 - 100 of 441 matches
Mail list logo
