[PATCH] .gitignore: add virtiofsd binary

2020-08-21 Thread Li Zhijian
Signed-off-by: Li Zhijian --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 2992d15931..28729241f1 100644 --- a/.gitignore +++ b/.gitignore @@ -57,6 +57,7 @@ /qemu-ga /qemu-bridge-helper /qemu-keymap +/virtiofsd /qemu-monitor.texi /qemu-monitor-

Re: [PATCH v4 4/4] iotests: Test node/bitmap aliases during migration

2020-08-21 Thread Max Reitz
On 20.08.20 17:49, Vladimir Sementsov-Ogievskiy wrote: > # MYPYPATH=../../python/ mypy 300 > 300:154: error: Item "None" of "Optional[Match[Any]]" has no attribute > "group" > Found 1 error in 1 file (checked 1 source file) :( > - the only complain. Suggest a fix: > > diff --git a/tests/qemu-iot

Re: [PATCH] hw: cirrus_vga: mask 'off_begin' in cirrus_invalidate_region()

2020-08-21 Thread Gerd Hoffmann
> This patch fixes this. > --- a/hw/display/cirrus_vga.c > +++ b/hw/display/cirrus_vga.c > @@ -644,7 +644,7 @@ static void cirrus_invalidate_region(CirrusVGAState * s, > int off_begin, > off_cur_end = ((off_cur + bytesperline - 1) & s->cirrus_addr_mask) + > 1; > assert(off_cur_

[PATCH] cirrus: handle wraparound in cirrus_invalidate_region

2020-08-21 Thread Gerd Hoffmann
Code simply asserts that there is no wraparound instead of handling it properly. The assert() can be triggered by the guest (must be privilidged inside the guest though). Fix it. Buglink: https://bugs.launchpad.net/qemu/+bug/1880189 Cc: Li Qiang Reported-by: Alexander Bulekov Signed-off-by: Ge

Re: [PATCH v2] configure: add support for pseudo-"in source tree" builds

2020-08-21 Thread Daniel P . Berrangé
On Thu, Aug 20, 2020 at 04:15:59PM -0500, Eric Blake wrote: > On 8/20/20 12:31 PM, Daniel P. Berrangé wrote: > > Meson requires the build dir to be separate from the source tree. Many > > people are used to just running "./configure && make" though and the > > meson conversion breaks that. > > > >

[PATCH] hw/arm/sbsa-ref: fix typo breaking PCIe IRQs

2020-08-21 Thread Graeme Gregory
Fixing a typo in a previous patch that translated an "i" to a 1 and therefore breaking the allocation of PCIe interrupts. This was discovered when virtio-net-pci devices ceased to function correctly. Fixes: 48ba18e6d3f3 ("hw/arm/sbsa-ref: Simplify by moving the gic in the machine state") Signed-o

[PATCH] virtio-gpu: fix unmap the already mapped items

2020-08-21 Thread Li Zhijian
we go here either (!(*iov)[i].iov_base) or (len != l), so we need to consider to unmap the 'i'th item as well when the 'i'th item is not nil Signed-off-by: Li Zhijian --- hw/display/virtio-gpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/display/virtio-gpu.c b/hw/disp

Re: [PATCH 2/2] libvhost-user: handle endianness as mandated by the spec

2020-08-21 Thread Marc Hartmayer
On Mon, Aug 03, 2020 at 11:26 AM +0200, Cornelia Huck wrote: > On Thu, 30 Jul 2020 16:07:31 +0200 > Marc Hartmayer wrote: > >> Since virtio existed even before it got standardized, the virtio >> standard defines the following types of virtio devices: >> >> + legacy device (pre-virtio 1.0) >> +

Re: [PATCH 02/10] numa: introduce MachineClass::forbid_asymmetrical_numa

2020-08-21 Thread Igor Mammedov
On Thu, 20 Aug 2020 12:51:03 -0400 Eduardo Habkost wrote: > On Thu, Aug 20, 2020 at 02:15:04PM +1000, David Gibson wrote: > > On Wed, Aug 19, 2020 at 10:11:28PM -0400, Eduardo Habkost wrote: > > > On Thu, Aug 20, 2020 at 11:17:26AM +1000, David Gibson wrote: > > > > On Fri, Aug 14, 2020 at 05

Re: [PATCH] hw/arm/sbsa-ref: fix typo breaking PCIe IRQs

2020-08-21 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200821083853.356490-1-gra...@nuviainc.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN =

Re: [PATCH V6] Introduce a new flag for i440fx to disable PCI hotplug on the root bus

2020-08-21 Thread Igor Mammedov
On Thu, 20 Aug 2020 22:11:41 +0530 Ani Sinha wrote: > > On Aug 20, 2020, at 9:11 PM, Ani Sinha wrote: > > > > On Thu, Aug 20, 2020 at 7:37 PM Igor Mammedov wrote: > > > >> > >>> On Thu, 20 Aug 2020 14:51:56 +0530 > >>> Ani Sinha wrote: > >>> > >>> We introduce a new global flag 'acpi-

Re: [PATCH] configure: add support for psuedo-"in source tree" builds

2020-08-21 Thread Daniel P . Berrangé
On Thu, Aug 20, 2020 at 12:42:20PM -0500, Eric Blake wrote: > On 8/20/20 11:55 AM, Daniel P. Berrangé wrote: > > Meson requires the build dir to be separate from the source tree. Many > > people are used to just running "./configure && make" though and the > > meson conversion breaks that. > > > >

Re: [PATCH] configure: add support for psuedo-"in source tree" builds

2020-08-21 Thread Daniel P . Berrangé
On Thu, Aug 20, 2020 at 07:15:03PM +0100, Peter Maydell wrote: > On Thu, 20 Aug 2020 at 17:56, Daniel P. Berrangé wrote: > > > > Meson requires the build dir to be separate from the source tree. Many > > people are used to just running "./configure && make" though and the > > meson conversion brea

Re: Suspicious QOM types without instance/class size

2020-08-21 Thread Peter Maydell
On Thu, 20 Aug 2020 at 22:55, Eduardo Habkost wrote: > > While trying to convert TypeInfo declarations to the new > OBJECT_DECLARE* macros, I've stumbled on a few suspicious cases > where instance_size or class_size is not set, despite having type > checker macros that use a specific type. > > The

Re: [PATCH v5 01/15] block/nvme: Replace magic value by SCALE_MS definition

2020-08-21 Thread Stefano Garzarella
On Thu, Aug 20, 2020 at 06:58:47PM +0200, Philippe Mathieu-Daudé wrote: > Use self-explicit SCALE_MS definition instead of magic value. > > Reviewed-by: Stefan Hajnoczi > Signed-off-by: Philippe Mathieu-Daudé > --- > block/nvme.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Review

Re: Suspicious QOM types without instance/class size

2020-08-21 Thread David Hildenbrand
On 20.08.20 23:55, Eduardo Habkost wrote: > While trying to convert TypeInfo declarations to the new > OBJECT_DECLARE* macros, I've stumbled on a few suspicious cases > where instance_size or class_size is not set, despite having type > checker macros that use a specific type. > > The ones with "W

Re: Suspicious QOM types without instance/class size

2020-08-21 Thread Cornelia Huck
On Thu, 20 Aug 2020 17:55:29 -0400 Eduardo Habkost wrote: > While trying to convert TypeInfo declarations to the new > OBJECT_DECLARE* macros, I've stumbled on a few suspicious cases > where instance_size or class_size is not set, despite having type > checker macros that use a specific type. >

Re: [PATCH v5 03/15] block/nvme: Let nvme_create_queue_pair() fail gracefully

2020-08-21 Thread Stefano Garzarella
On Thu, Aug 20, 2020 at 06:58:49PM +0200, Philippe Mathieu-Daudé wrote: > As nvme_create_queue_pair() is allowed to fail, replace the > alloc() calls by try_alloc() to avoid aborting QEMU. > > Reviewed-by: Stefan Hajnoczi > Signed-off-by: Philippe Mathieu-Daudé > --- > block/nvme.c | 12 +

Re: [PATCH v5 04/15] block/nvme: Define INDEX macros to ease code review

2020-08-21 Thread Stefano Garzarella
On Thu, Aug 20, 2020 at 06:58:50PM +0200, Philippe Mathieu-Daudé wrote: > Use definitions instead of '0' or '1' indexes. Also this will > be useful when using multi-queues later. > > Reviewed-by: Stefan Hajnoczi > Signed-off-by: Philippe Mathieu-Daudé > --- > block/nvme.c | 33 +++

Re: [PATCH v5 05/15] block/nvme: Improve error message when IO queue creation failed

2020-08-21 Thread Stefano Garzarella
On Thu, Aug 20, 2020 at 06:58:51PM +0200, Philippe Mathieu-Daudé wrote: > Do not use the same error message for different failures. > Display a different error whether it is the CQ or the SQ. > > Reviewed-by: Stefan Hajnoczi > Signed-off-by: Philippe Mathieu-Daudé > --- > block/nvme.c | 4 ++-

Re: [PATCH v5 06/15] block/nvme: Use common error path in nvme_add_io_queue()

2020-08-21 Thread Stefano Garzarella
On Thu, Aug 20, 2020 at 06:58:52PM +0200, Philippe Mathieu-Daudé wrote: > Rearrange nvme_add_io_queue() by using a common error path. > This will be proven useful in few commits where we add IRQ > notification to the IO queues. > > Reviewed-by: Stefan Hajnoczi > Signed-off-by: Philippe Mathieu-D

Re: deprecation of in-tree builds

2020-08-21 Thread Gerd Hoffmann
Hi, > If it's a matter of "I don't want my workflow to change too much", I'm > not familiar with everybody's setups and requirements and it's not a > precise-enough requirement for me to write the code (and block the > inclusion of the pull request). It's almost zero change to my workflow. I o

Re: [PATCH v5 07/15] block/nvme: Rename local variable

2020-08-21 Thread Stefano Garzarella
On Thu, Aug 20, 2020 at 06:58:53PM +0200, Philippe Mathieu-Daudé wrote: > We are going to modify the code in the next commit. Renaming > the 'resp' variable to 'id' first makes the next commit easier > to review. No logical changes. > > Reviewed-by: Stefan Hajnoczi > Signed-off-by: Philippe Math

Re: [PATCH] configure: add support for psuedo-"in source tree" builds

2020-08-21 Thread Kevin Wolf
Am 20.08.2020 um 19:42 hat Eric Blake geschrieben: > On 8/20/20 11:55 AM, Daniel P. Berrangé wrote: > > Meson requires the build dir to be separate from the source tree. Many > > people are used to just running "./configure && make" though and the > > meson conversion breaks that. > > > > This in

Re: [PATCH v3 03/10] migration/dirtyrate: Add dirtyrate statistics series functions

2020-08-21 Thread Zheng Chuan
On 2020/8/21 0:28, Dr. David Alan Gilbert wrote: > * Chuan Zheng (zhengch...@huawei.com) wrote: >> Add dirtyrate statistics to record/update dirtyrate info. >> >> Signed-off-by: Chuan Zheng >> Signed-off-by: YanYing Zhuang >> --- >> migration/dirtyrate.c | 30 ++ >>

Re: [PATCH v3 09/10] migration/dirtyrate: Implement calculate_dirtyrate() function

2020-08-21 Thread Zheng Chuan
On 2020/8/21 1:57, Dr. David Alan Gilbert wrote: > * Chuan Zheng (zhengch...@huawei.com) wrote: >> Implement calculate_dirtyrate() function. >> >> Signed-off-by: Chuan Zheng >> Signed-off-by: YanYing Zhuang >> --- >> migration/dirtyrate.c | 46 -- >>

Re: [PATCH v3 01/10] migration/dirtyrate: Add get_dirtyrate_thread() function

2020-08-21 Thread Zheng Chuan
On 2020/8/21 0:11, Dr. David Alan Gilbert wrote: > * Chuan Zheng (zhengch...@huawei.com) wrote: >> Add get_dirtyrate_thread() functions >> >> Signed-off-by: Chuan Zheng >> Signed-off-by: YanYing Zhuang >> --- >> migration/Makefile.objs | 1 + >> migration/dirtyrate.c | 64 >> +

Re: [PATCH v3 10/10] migration/dirtyrate: Implement qmp_cal_dirty_rate()/qmp_get_dirty_rate() function

2020-08-21 Thread Zheng Chuan
On 2020/8/21 2:00, Dr. David Alan Gilbert wrote: > * Eric Blake (ebl...@redhat.com) wrote: >> On 8/16/20 10:20 PM, Chuan Zheng wrote: >>> Implement qmp_cal_dirty_rate()/qmp_get_dirty_rate() function which could be >>> called >>> >>> Signed-off-by: Chuan Zheng >>> --- >> >>> +++ b/qapi/migratio

Re: [PATCH v3 02/10] migration/dirtyrate: Add RamlockDirtyInfo to store sampled page info

2020-08-21 Thread Zheng Chuan
On 2020/8/21 0:20, Dr. David Alan Gilbert wrote: > * Chuan Zheng (zhengch...@huawei.com) wrote: >> Add RamlockDirtyInfo to store sampled page info of each ramblock. >> >> Signed-off-by: Chuan Zheng >> Signed-off-by: YanYing Zhuang >> --- >> migration/dirtyrate.h | 18 ++ >> 1

Re: [PATCH v5 08/15] block/nvme: Use union of NvmeIdCtrl / NvmeIdNs structures

2020-08-21 Thread Stefano Garzarella
On Thu, Aug 20, 2020 at 06:58:54PM +0200, Philippe Mathieu-Daudé wrote: > We allocate an unique chunk of memory then use it for two > different structures. By using an union, we make it clear > the data is overlapping (and we can remove the casts). > > Suggested-by: Stefan Hajnoczi > Reviewed-by

Re: [PATCH v2] configure: add support for pseudo-"in source tree" builds

2020-08-21 Thread Kevin Wolf
Am 20.08.2020 um 23:15 hat Eric Blake geschrieben: > On 8/20/20 12:31 PM, Daniel P. Berrangé wrote: > > Meson requires the build dir to be separate from the source tree. Many > > people are used to just running "./configure && make" though and the > > meson conversion breaks that. > > > > This in

[PATCH] numa: hmat: fix cache size check

2020-08-21 Thread Igor Mammedov
when QEMU is started like: qemu-system-x86_64 -smp 2 -machine hmat=on \ -m 2G \ -object memory-backend-ram,size=1G,id=m0 \ -object memory-backend-ram,size=1G,id=m1 \ -numa node,nodeid=0,memdev=m0 \ -numa node,nodeid=1,memdev=m1,initiator=0 \ -numa cpu,node-id=0,socket-id=0 \ -numa cpu,node-

Re: [PATCH v5 09/15] block/nvme: Replace qemu_try_blockalign0 by qemu_try_blockalign/memset

2020-08-21 Thread Stefano Garzarella
On Thu, Aug 20, 2020 at 06:58:55PM +0200, Philippe Mathieu-Daudé wrote: > In the next commit we'll get rid of qemu_try_blockalign(). > To ease review, first replace qemu_try_blockalign0() by explicit > calls to qemu_try_blockalign() and memset(). > > Reviewed-by: Stefan Hajnoczi > Signed-off-by:

Re: [PATCH 07/18] hw/sd: sd: Fix incorrect populated function switch status data structure

2020-08-21 Thread Bin Meng
Hi Sai, On Fri, Aug 21, 2020 at 6:04 PM Sai Pavan Boddu wrote: > > Hi Philippe, > > First two patch of SD look good. Tested them over zynqmp and versal > platforms. > Thanks for testing. Can I add your Tested-by tag? Regards, Bin

Re: [PATCH] virtio-gpu: fix unmap the already mapped items

2020-08-21 Thread Gerd Hoffmann
On Fri, Aug 21, 2020 at 04:49:45PM +0800, Li Zhijian wrote: > we go here either (!(*iov)[i].iov_base) or (len != l), so we need to consider > to unmap the 'i'th item as well when the 'i'th item is not nil > > Signed-off-by: Li Zhijian > --- > hw/display/virtio-gpu.c | 2 +- > 1 file changed, 1 i

Re: [PATCH v5 10/15] block/nvme: Replace qemu_try_blockalign(bs) by qemu_try_memalign(pg_sz)

2020-08-21 Thread Stefano Garzarella
On Thu, Aug 20, 2020 at 06:58:56PM +0200, Philippe Mathieu-Daudé wrote: > qemu_try_blockalign() is a generic API that call back to the > block driver to return its page alignment. As we call from > within the very same driver, we already know to page alignment > stored in our state. Remove indirec

Re: [PATCH v5 11/15] block/nvme: Simplify nvme_init_queue() arguments

2020-08-21 Thread Stefano Garzarella
On Thu, Aug 20, 2020 at 06:58:57PM +0200, Philippe Mathieu-Daudé wrote: > nvme_init_queue() doesn't require BlockDriverState anymore. > Replace it by BDRVNVMeState to simplify. > > Reviewed-by: Stefan Hajnoczi > Signed-off-by: Philippe Mathieu-Daudé > --- > block/nvme.c | 7 +++ > 1 file

[PATCH 0/2] fdmon-poll: reset npfd when upgrading to fdmon-epoll

2020-08-21 Thread Stefan Hajnoczi
Fix an assertion failure when aio_poll() is called in a aio_disable_external() region. The failure happens when fdmon-poll is first upgraded to fdmon-epoll and then downgraded again due to aio_disable_external(). Stefan Hajnoczi (2): fdmon-poll: reset npfd when upgrading to fdmon-epoll tests:

[PATCH 2/2] tests: add test-fdmon-epoll

2020-08-21 Thread Stefan Hajnoczi
Test aio_disable_external(), which switches from fdmon-epoll back to fdmon-poll. This resulted in an assertion failure that was fixed in the previous patch. Signed-off-by: Stefan Hajnoczi --- MAINTAINERS | 1 + tests/Makefile.include | 4 +++ tests/test-fdmon-epoll.c | 73 ++

Re: [PATCH] configure: add support for psuedo-"in source tree" builds

2020-08-21 Thread Daniel P . Berrangé
On Fri, Aug 21, 2020 at 11:58:21AM +0200, Kevin Wolf wrote: > Am 20.08.2020 um 19:42 hat Eric Blake geschrieben: > > On 8/20/20 11:55 AM, Daniel P. Berrangé wrote: > > > Meson requires the build dir to be separate from the source tree. Many > > > people are used to just running "./configure && m

[PATCH 1/2] fdmon-poll: reset npfd when upgrading to fdmon-epoll

2020-08-21 Thread Stefan Hajnoczi
npfd keeps track of how many pollfds are currently being monitored. It must be reset to 0 when fdmon_poll_wait() returns. When npfd reaches a treshold we switch to fdmon-epoll because it scales better. This patch resets npfd in the case where we switch to fdmon-epoll. Forgetting to do so results

Re: [PATCH v2] configure: add support for pseudo-"in source tree" builds

2020-08-21 Thread Paolo Bonzini
On 21/08/20 12:04, Kevin Wolf wrote: >> So I'm not sure why the first build gets as far as it does, but does NOT >> complete things and yet does not fail make, but my advice is that you should >> NOT try to an incremental build on in-tree build when crossing the meson >> epoch. If you are a fan of

Re: [PATCH v5 12/15] block/nvme: Replace BDRV_POLL_WHILE by AIO_WAIT_WHILE

2020-08-21 Thread Stefano Garzarella
On Thu, Aug 20, 2020 at 06:58:58PM +0200, Philippe Mathieu-Daudé wrote: > BDRV_POLL_WHILE() is defined as: > > #define BDRV_POLL_WHILE(bs, cond) ({ \ > BlockDriverState *bs_ = (bs); \ > AIO_WAIT_WHILE(bdrv_get_aio_context(bs_), \ > cond); })

Re: [PATCH v2] configure: add support for pseudo-"in source tree" builds

2020-08-21 Thread Paolo Bonzini
On 20/08/20 19:31, Daniel P. Berrangé wrote: > Meson requires the build dir to be separate from the source tree. Many > people are used to just running "./configure && make" though and the > meson conversion breaks that. > > This introduces some backcompat support to make it appear as if an > "in

Re: [PATCH v2] configure: add support for pseudo-"in source tree" builds

2020-08-21 Thread Daniel P . Berrangé
On Fri, Aug 21, 2020 at 12:04:26PM +0200, Kevin Wolf wrote: > Am 20.08.2020 um 23:15 hat Eric Blake geschrieben: > > On 8/20/20 12:31 PM, Daniel P. Berrangé wrote: > > > Meson requires the build dir to be separate from the source tree. Many > > > people are used to just running "./configure && make

Re: [PATCH v2] configure: add support for pseudo-"in source tree" builds

2020-08-21 Thread Kevin Wolf
Am 20.08.2020 um 19:31 hat Daniel P. Berrangé geschrieben: > Meson requires the build dir to be separate from the source tree. Many > people are used to just running "./configure && make" though and the > meson conversion breaks that. > > This introduces some backcompat support to make it appear

Re: [PATCH 07/18] hw/sd: sd: Fix incorrect populated function switch status data structure

2020-08-21 Thread Sai Pavan Boddu
Hi Philippe, First two patch of SD look good. Tested them over zynqmp and versal platforms. Thanks, Sai Pavan On Tue, Aug 18, 2020 at 04:30:15PM +, Sai Pavan Boddu wrote: > Thanks Philippe, > > I would test this and get back. > > Regards, > Sai Pavan > > > -Original Message- > > Fr

Re: [PATCH v5 13/15] block/nvme: Simplify nvme_create_queue_pair() arguments

2020-08-21 Thread Stefano Garzarella
On Thu, Aug 20, 2020 at 06:58:59PM +0200, Philippe Mathieu-Daudé wrote: > nvme_create_queue_pair() doesn't require BlockDriverState anymore. > Replace it by BDRVNVMeState and AioContext to simplify. > > Reviewed-by: Stefan Hajnoczi > Signed-off-by: Philippe Mathieu-Daudé > --- > block/nvme.c

[PATCH v3] configure: add support for pseudo-"in source tree" builds

2020-08-21 Thread Daniel P . Berrangé
Meson requires the build dir to be separate from the source tree. Many people are used to just running "./configure && make" though and the meson conversion breaks that. This introduces some backcompat support to make it appear as if an "in source tree" build is being done, but with the results in

[PULL v8 001/152] oss-fuzz/build: remove LIB_FUZZING_ENGINE

2020-08-21 Thread Paolo Bonzini
Meson build scripts will only include qemu-fuzz-TARGET rules if configured with --enable-fuzzing, and that takes care of adding -fsanitize=fuzzer. Therefore we can just specify the configure option and stop modifying the CFLAGS and CONFIG_FUZZ options in the "make" invocation. Signed-off-by: Paolo

[PULL v8 002/152] optionrom: simplify Makefile

2020-08-21 Thread Paolo Bonzini
From: Marc-André Lureau Make it independent from the rules.mak, and clean up to use pattern rules. Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- pc-bios/optionrom/Makefile | 67 +++--- 1 file changed, 41 insertions(+), 26 deletions(-) diff

[PULL v8 016/152] configure: add support for pseudo-"in source tree" builds

2020-08-21 Thread Paolo Bonzini
From: Daniel P. Berrangé Meson requires the build dir to be separate from the source tree. Many people are used to just running "./configure && make" though and the meson conversion breaks that. This introduces some backcompat support to make it appear as if an "in source tree" build is being do

[PULL v8 007/152] build-sys hack: ensure target directory is there

2020-08-21 Thread Paolo Bonzini
From: Marc-André Lureau By removing some unnest-vars calls, we miss some directory creation that may be required by some/dir/object.d. This will go away once everything is converted to Meson. Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- rules.mak | 1 + 1 file changed, 1

[PULL v8 000/152] Meson-based build system

2020-08-21 Thread Paolo Bonzini
The following changes since commit 1d806cef0e38b5db8347a8e12f214d543204a314: Merge remote-tracking branch 'remotes/maxreitz/tags/pull-block-2020-08-11' into staging (2020-08-19 22:19:11 +0100) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for-upstream for

[PULL v8 022/152] meson: enable pie

2020-08-21 Thread Paolo Bonzini
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- configure | 1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index 40c8462539..7c2a46ade0 100755 --- a/configure +++ b/configure @@ -8514,6 +8514,7 @@ NINJA=$PWD/ninjatool $meson se

[PULL v8 010/152] tests/docker: add test script for static linux-user builds

2020-08-21 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- tests/docker/test-static | 24 1 file changed, 24 insertions(+) create mode 100755 tests/docker/test-static diff --git a/tests/docker/test-static b/tests/docker/test-static new file mode 100755 index 00..372ef6fac7 --- /dev/null

[PULL v8 006/152] meson: rename .inc.h files to .h.inc

2020-08-21 Thread Paolo Bonzini
Make it consistent with '.c.inc' and '.rst.inc'. Signed-off-by: Paolo Bonzini --- include/exec/cpu-all.h | 10 +- include/exec/memory.h| 12 ++-- .../exec/{memory_ldst.inc.h => memory_ldst.h.inc}| 0 ...ry_ldst_ca

[PULL v8 003/152] pc-bios/s390-ccw: do not use rules.mak

2020-08-21 Thread Paolo Bonzini
From: Thomas Huth Signed-off-by: Paolo Bonzini --- pc-bios/s390-ccw/Makefile | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/pc-bios/s390-ccw/Makefile b/pc-bios/s390-ccw/Makefile index 50bc880272..cc0f77baa6 100644 --- a/pc-bios/s390-ccw/Makefile +++ b/pc-

[PULL v8 009/152] tests/vm: check for Python YAML parser in the Makefile

2020-08-21 Thread Paolo Bonzini
No need to do it in the configure file if it is only used for a help message. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Paolo Bonzini --- configure | 9 - tests/vm/Makefile.include | 6 +- 2 files changed, 5 insertions(+), 10 deletions(-) diff --git a/confi

[PULL v8 021/152] meson: move summary to meson.build

2020-08-21 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- configure | 237 -- meson.build | 245 2 files changed, 245 insertions(+), 237 deletions(-) diff --git a/configure b/configure index 3360f40a33..40c8462539 1007

[PULL v8 015/152] tests/vm: include setuptools

2020-08-21 Thread Paolo Bonzini
They are a dependency of Meson, so install them. Signed-off-by: Paolo Bonzini --- tests/vm/freebsd | 1 + tests/vm/netbsd | 1 + tests/vm/openbsd | 1 + 3 files changed, 3 insertions(+) diff --git a/tests/vm/freebsd b/tests/vm/freebsd index 29252fa4a6..b34b14fc53 100755 --- a/tests/vm/freebsd

[PULL v8 018/152] configure: generate Meson cross file

2020-08-21 Thread Paolo Bonzini
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- configure | 72 ++--- meson.build | 7 +- 2 files changed, 69 insertions(+), 10 deletions(-) diff --git a/configure b/configure index ce32c568f8..a8

[PULL v8 011/152] nsis: use "make DESTDIR=" instead of "make prefix="

2020-08-21 Thread Paolo Bonzini
The next patch will prevent modifying the prefix on "make install". Adjust the creation of the installer. Signed-off-by: Paolo Bonzini --- Makefile | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/Makefile b/Makefile index 5596482dbd..ec12101a84 100644 --- a/Make

[PULL v8 028/152] meson: add version.o

2020-08-21 Thread Paolo Bonzini
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- meson.build | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 4e9eb5da5c..feb3c8a30c 100644 --- a/meson.build +++ b/meson.build @@ -49,8 +49,14 @@

[PULL v8 008/152] tests/vm: do not pollute configure with --efi-aarch64

2020-08-21 Thread Paolo Bonzini
Just make EFI_AARCH64 a variable in the makefile that defaults to the efi firmware included with QEMU. It can be redefined on the "make" command line. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Paolo Bonzini --- configure | 19 --- tests/vm/Makefile.incl

[PULL v8 013/152] configure: expand path variables for meson configure

2020-08-21 Thread Paolo Bonzini
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- configure | 35 --- 1 file changed, 20 insertions(+), 15 deletions(-) diff --git a/configure b/configure index 606c327cca..373bb22287 100755 --- a/configure +++ b/configur

[PULL v8 004/152] trace: switch position of headers to what Meson requires

2020-08-21 Thread Paolo Bonzini
Meson doesn't enjoy the same flexibility we have with Make in choosing the include path. In particular the tracing headers are using $(build_root)/$( --- .gitignore | 1 - Makefile | 46 ++-- Makefile.objs

[PULL v8 026/152] libqemuutil, qapi, trace: convert to meson

2020-08-21 Thread Paolo Bonzini
This shows how to do some "computations" in meson.build using its array and dictionary data structures, and also a basic usage of the sourceset module for conditional compilation. Notice the new "if have_system" part of util/meson.build, which fixes a bug in the old build system was buggy: util/db

[PULL v8 020/152] build-sys: add meson submodule

2020-08-21 Thread Paolo Bonzini
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- .gitmodules | 3 ++ configure | 71 +++ meson | 1 + scripts/archive-source.sh | 3 +- 4 files changed, 70 insertio

[PULL v8 014/152] configure: prepare CFLAGS/CXXFLAGS/LDFLAGS for Meson

2020-08-21 Thread Paolo Bonzini
Split between CFLAGS/QEMU_CFLAGS and CXXFLAGS/QEMU_CXXFLAGS so that we will use CFLAGS and CXXFLAGS for flags that we do not want to pass to add_project_arguments. Signed-off-by: Paolo Bonzini --- configure | 80 --- rules.mak | 4

[PULL v8 005/152] meson: rename included C source files to .c.inc

2020-08-21 Thread Paolo Bonzini
With Makefiles that have automatically generated dependencies, you generated includes are set as dependencies of the Makefile, so that they are built before everything else and they are available when first building the .c files. Alternatively you can use a fine-grained dependency, e.g. t

[PULL v8 037/152] contrib/ivshmem: convert to meson

2020-08-21 Thread Paolo Bonzini
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- Makefile | 9 - Makefile.objs| 2 -- configure| 3 --- contrib/ivshmem-client/Makefile.objs | 1 - contrib/ivshmem-c

[PULL v8 025/152] meson: add testsuite Makefile generator

2020-08-21 Thread Paolo Bonzini
Rules to execute tests are generated by a simple Python program that integrates into the existing "make check" mechanism. This provides familiarity for developers, and also allows piecewise conversion of the testsuite Makefiles to meson. The generated rules are based on QEMU's existing test harne

[PULL v8 029/152] contrib/libvhost-user: convert to Meson

2020-08-21 Thread Paolo Bonzini
Since libqemuutil.a has been converted to Meson, the conversion is straightforward. Signed-off-by: Paolo Bonzini --- Makefile| 16 +--- Makefile.objs | 1 - contrib/libvhost-user/Makefile.objs | 1 - contrib/libvhost-user/meson.buil

[PULL v8 034/152] contrib/rdmacm-mux: convert to Meson

2020-08-21 Thread Paolo Bonzini
We can use config-host.mak to decide whether the tool has to be built, apart from that the conversion is straightforward. Signed-off-by: Paolo Bonzini --- Makefile | 5 - Makefile.objs| 1 - contrib/rdmacm-mux/Makefile.objs | 3 --- contrib/rdmacm-

[PULL v8 012/152] configure: do not include $(...) variables in config-host.mak

2020-08-21 Thread Paolo Bonzini
This ensures that Meson will be able to reuse the results of the tests that are performed in the configure script. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Paolo Bonzini --- configure | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git

[PULL v8 024/152] meson: add sparse support

2020-08-21 Thread Paolo Bonzini
Do not use cgcc; instead, extract compilation commands from compile_commands.json and invoke sparse directly. Signed-off-by: Paolo Bonzini --- Makefile| 1 + configure | 8 ++-- meson.build | 7 +++ scripts/check_sparse.py | 25 ++

[PULL v8 036/152] contrib/vhost-user-gpu: convert to meson

2020-08-21 Thread Paolo Bonzini
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- Makefile | 18 +- Makefile.objs| 1 - contrib/vhost-user-gpu/Makefile.objs | 10 -- contrib/vhost-user-gpu/meson.build | 13 +

[PULL v8 023/152] meson: use coverage option

2020-08-21 Thread Paolo Bonzini
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- Makefile | 14 -- Makefile.target| 16 configure | 9 ++--- docs/devel/testing.rst | 7 +++ meson.build| 2 +- 5 file

[PULL v8 019/152] build-sys hack: link with whole .fa archives

2020-08-21 Thread Paolo Bonzini
From: Marc-André Lureau In order to link the *-obj-y files into tests, we will make static libraries of them in Meson, and then link them as whole archives into the tests. To separate regular static libraries from link-whole libraries, give them a different file extension. Signed-off-by: Marc-A

[PULL v8 030/152] tools/virtiofsd: convert to Meson

2020-08-21 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- Makefile | 12 Makefile.objs | 1 - configure | 1 + meson.build | 11 +++ tools/meson.build

[PULL v8 027/152] meson: add remaining generated tcg trace helpers

2020-08-21 Thread Paolo Bonzini
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- Makefile | 51 --- trace/meson.build | 14 + 2 files changed, 14 insertions(+), 51 deletions(-) diff --git a/Makefile b/Makefile index e5d

[PULL v8 032/152] vhost-user-scsi: add compatibility for libiscsi 1.9.0

2020-08-21 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- contrib/vhost-user-scsi/vhost-user-scsi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/contrib/vhost-user-scsi/vhost-user-scsi.c b/contrib/vhost-user-scsi/vhost-user-scsi.c index 7a1db164c8..3c912384e9 100644 --- a/contrib/vhost-user-scsi/vhost-user-scsi

[PULL v8 039/152] meson: add macos dependencies

2020-08-21 Thread Paolo Bonzini
From: Marc-André Lureau There is no probing in configure, so no need to pass them as variables to meson. Do a regular meson dependency() instead. Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- meson.build | 9 + 1 file changed, 9 insertions(+) diff --git a/meson.bu

[PULL v8 044/152] meson: convert dummy Windows qga/qemu-ga target

2020-08-21 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- Makefile | 5 - qga/meson.build | 4 qga/vss-win32/meson.build | 2 ++ 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/Makefile b/Makefile index e93ebf6299..8d3c8d8fbd 100644 --- a/Makefile +++ b/Makefile @@ -450,

[PULL v8 041/152] meson: convert qemu-ga

2020-08-21 Thread Paolo Bonzini
Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- Makefile | 53 +-- Makefile.objs | 1 - configure | 14 +++ meson.build | 8 ++ qga/Makefile.objs | 9 --- q

[PULL v8 038/152] contrib/elf2dmp: convert to meson

2020-08-21 Thread Paolo Bonzini
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- Makefile | 4 Makefile.objs | 6 -- configure | 3 --- contrib/elf2dmp/Makefile.objs | 4 contrib/elf2dmp/meson.build | 5 + me

[PULL v8 017/152] configure: integrate Meson in the build system

2020-08-21 Thread Paolo Bonzini
The Meson build system is integrated in the existing configure/make steps by invoking Meson from the configure script and converting Meson's build.ninja rules to an included Makefile. build.ninja already provides tags/ctags/cscope rules, so they are removed. Signed-off-by: Paolo Bonzini --- Mak

[PULL v8 043/152] meson: add msi generation

2020-08-21 Thread Paolo Bonzini
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- Makefile | 18 -- qga/meson.build | 25 + qga/vss-win32/meson.build | 3 ++- 3 files changed, 27 insertions(+), 19 deletions(-) diff --

[PULL v8 047/152] meson: add qemu-edid

2020-08-21 Thread Paolo Bonzini
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Paolo Bonzini --- Makefile| 2 -- configure | 2 +- meson.build | 4 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index b0a261bdc7..da1e

[PULL v8 051/152] meson: generate shader headers

2020-08-21 Thread Paolo Bonzini
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- Makefile | 19 --- meson.build | 1 + ui/meson.build| 2 ++ ui/shader/meson.build | 15 +++ 4 files changed, 18 insertions(+), 19 deletions(-)

[PULL v8 035/152] contrib/vhost-user-input: convert to meson

2020-08-21 Thread Paolo Bonzini
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- Makefile | 11 --- Makefile.objs | 1 - contrib/vhost-user-input/Makefile.objs | 1 - contrib/vhost-user-input/meson.build | 5 + me

[PULL v8 049/152] meson: keymap-gen

2020-08-21 Thread Paolo Bonzini
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- Makefile | 38 -- meson.build| 1 + ui/meson.build | 34 ++ 3 files changed, 35 insertions(+), 38 deletions(-) create mode 1

[PULL v8 052/152] meson: generate hxtool files

2020-08-21 Thread Paolo Bonzini
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- Makefile| 8 +--- Makefile.target | 6 -- meson.build | 22 ++ scripts/hxtool | 2 +- 4 files changed, 24 insertions(+), 14 deletions(-) mode change 100644 =>

Re: [PATCH v5 14/15] block/nvme: Extract nvme_poll_queue()

2020-08-21 Thread Stefano Garzarella
On Thu, Aug 20, 2020 at 06:59:00PM +0200, Philippe Mathieu-Daudé wrote: > As we want to do per-queue polling, extract the nvme_poll_queue() > method which operates on a single queue. > > Reviewed-by: Stefan Hajnoczi > Signed-off-by: Philippe Mathieu-Daudé > --- > block/nvme.c | 44 +++

[PULL v8 031/152] contrib/vhost-user-blk: convert to Meson

2020-08-21 Thread Paolo Bonzini
The GLib pkg-config information is extracted from config-host.mak and used to link vhost-user-blk. Signed-off-by: Paolo Bonzini --- Makefile | 3 --- Makefile.objs| 1 - contrib/vhost-user-blk/Makefile.objs | 1 - contrib/vhost-user-blk/meson.b

[PULL v8 056/152] meson: convert check-qapi-schema

2020-08-21 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- tests/Makefile.include| 218 +--- tests/meson.build | 2 + tests/qapi-schema/meson.build | 225 ++ 3 files changed, 229 insertions(+), 216 deletions(-) create mode 100644 tests/qapi

[PULL v8 033/152] contrib/vhost-user-scsi: convert to Meson

2020-08-21 Thread Paolo Bonzini
The libiscsi pkg-config information is extracted from config-host.mak and used to link vhost-user-blk. Signed-off-by: Paolo Bonzini --- Makefile | 3 --- Makefile.objs | 3 --- contrib/vhost-user-scsi/Makefile.objs | 1 - contrib/vhost-user-sc

Re: [PATCH] configure: add support for psuedo-"in source tree" builds

2020-08-21 Thread Kevin Wolf
Am 21.08.2020 um 12:14 hat Daniel P. Berrangé geschrieben: > On Fri, Aug 21, 2020 at 11:58:21AM +0200, Kevin Wolf wrote: > > Am 20.08.2020 um 19:42 hat Eric Blake geschrieben: > > > On 8/20/20 11:55 AM, Daniel P. Berrangé wrote: > > > > Meson requires the build dir to be separate from the s

[PULL v8 053/152] meson: handle edk2 bios and descriptors

2020-08-21 Thread Paolo Bonzini
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Paolo Bonzini --- Makefile| 29 - meson.build | 1 + pc-bios/descriptors/meson.build | 14 ++ pc-bio

  1   2   3   4   5   6   >