From: Frediano Ziglio
Add support for SIDE and EXTRA buttons.
The constants for buttons in both SPICE and QEMU are defined as
LEFT
MIDDLE
RIGHT
UP
DOWN
SIDE
EXTRA
(same order).
"button_mask" contains for each bit the state of a button. Qemu currently
uses bits 0, 1, 2 respectively
** Changed in: qemu
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1878255
Title:
Assertion failure in bdrv_aio_cancel, through ide
Status in QEMU:
Fi
** Changed in: qemu
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1888728
Title:
Bare chroot in linux-user fails with pgb_reserved_va: Assertion
`gues
On Wed, Aug 19, 2020 at 04:40:16PM +0200, Cornelia Huck wrote:
> Add 5.2 machine types for arm/i440fx/q35/s390x/spapr.
>
> Reviewed-by: Andrew Jones
> Reviewed-by: Michael S. Tsirkin
> Reviewed-by: Greg Kurz
> Acked-by: Christian Borntraeger
> Acked-by: David Gibson
> Acked-by: Thomas Huth
>
** Changed in: qemu
Status: New => Incomplete
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1889411
Title:
RISC-V: Unable to unwind the stack upon signals
Status in QEMU:
Incomplete
Bug
** Changed in: qemu
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1878628
Title:
linux-user/mmap build failure using Clang 10
Status in QEMU:
Fix Rel
** Changed in: qemu
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1877716
Title:
Win10 guest unusable after a few minutes
Status in QEMU:
Fix Release
Patch has been included here:
https://git.qemu.org/?p=qemu.git;a=commitdiff;h=e7e5a9595ab1136845c
** Changed in: qemu
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.n
On Wed, Aug 19, 2020 at 06:03:14PM +0200, Philippe Mathieu-Daudé wrote:
> In preparation of using multiple IRQ (thus multiple eventfds)
> make BDRVNVMeState::irq_notifier an array (for now of a single
> element, the admin queue notifier).
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> block/n
Let wait_migration() return on failure (with the return value indicating
whether the migration was completed or has failed), so we can use it for
migrations that are expected to fail, too.
Signed-off-by: Max Reitz
Reviewed-by: Eric Blake
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu
Le 20/08/2020 à 02:12, Eduardo Habkost a écrit :
> The macro never worked because the NubusBridge typedef doesn't
> exist. Delete it.
>
> Reviewed-by: Philippe Mathieu-Daudé
> Reviewed-by: Daniel P. Berrangé
> Signed-off-by: Eduardo Habkost
> ---
> Changes v1 -> v2: none
>
> ---
> Cc: Laurent
Signed-off-by: Max Reitz
---
tests/qemu-iotests/300 | 595 +
tests/qemu-iotests/300.out | 5 +
tests/qemu-iotests/group | 1 +
3 files changed, 601 insertions(+)
create mode 100755 tests/qemu-iotests/300
create mode 100644 tests/qemu-iotests/300.out
This migration parameter allows mapping block node names and bitmap
names to aliases for the purpose of block dirty bitmap migration.
This way, management tools can use different node and bitmap names on
the source and destination and pass the mapping of how bitmaps are to be
transferred to qemu (
** Changed in: qemu
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1880287
Title:
gcc crashes in hppa emulation
Status in QEMU:
Fix Released
Bug desc
https://git.qemu.org/?p=qemu.git;a=commitdiff;h=3cb3a7720b01830abd5
** Changed in: qemu
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1888165
Title:
lo
RFC v1: https://lists.nongnu.org/archive/html/qemu-block/2020-05/msg00912.html
RFC v2: https://lists.nongnu.org/archive/html/qemu-block/2020-05/msg00915.html
v1: https://lists.nongnu.org/archive/html/qemu-devel/2020-06/msg09792.html
v2: https://lists.nongnu.org/archive/html/qemu-block/2020-07/msg01
Fix has been included here:
https://git.qemu.org/?p=qemu.git;a=commitdiff;h=257a7e212d5e518ac5
** Changed in: qemu
Status: New => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/187
Fix has been included here:
https://git.qemu.org/?p=qemu.git;a=commitdiff;h=ba3c35d9c4026361fd3
** Changed in: qemu
Status: Confirmed => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/b
A difference between sbsa platform and the virt platform is PSCI is
handled by ARM-TF in the sbsa platform. This means that the PSCI code
there needs to communicate some of the platform power changes down
to the qemu code for things like shutdown/reset control.
Space has been left to extend the EC
** Changed in: qemu
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1881552
Title:
potential AArch64 ABI bug wrt handling of 128-bit bit-fields
Status in
** Changed in: qemu
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1882065
Title:
Could this cause OOB bug ?
Status in QEMU:
Fix Released
Bug descrip
Patch has been included here:
https://git.qemu.org/?p=qemu.git;a=commitdiff;h=13557fd392890cbd985
** Changed in: qemu
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.n
Fixed here:
https://git.qemu.org/?p=qemu.git;a=commitdiff;h=250b1da35d579f423
** Changed in: qemu
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1881450
T
** Changed in: qemu
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1882784
Title:
Legacy IGD passthrough in QEMU 5 disabled
Status in QEMU:
Fix Releas
https://git.qemu.org/?p=qemu.git;a=commitdiff;h=a65dabf71a9f9b949
** Changed in: qemu
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1879587
Title:
Regi
** Changed in: qemu
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1881004
Title:
fpu/softfloat.c: error: bitwise negation of a boolean expression
Statu
Fixed here:
https://git.qemu.org/?p=qemu.git;a=commitdiff;h=5c3e87f345ac93de9260f
** Changed in: qemu
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1880225
** Changed in: qemu
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1878627
Title:
audio/mixeng build failure using Clang 10
Status in QEMU:
Fix Releas
** Changed in: qemu
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1878259
Title:
Null-pointer dereference in megasas_handle_frame
Status in QEMU:
Fix
https://git.qemu.org/?p=qemu.git;a=commitdiff;h=13a0c21e64bddf1a36
** Changed in: qemu
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1873898
Title:
arm
On Thu, Aug 20, 2020 at 09:41:14 -0500, Eric Blake wrote:
> On 8/20/20 6:05 AM, Kevin Wolf wrote:
>
> > As long as we can keep the compatibility code local to qmp_nbd_*(), I
> > don't think it's too bad. In particular because it's already written.
> >
> > Instead of adjusting libvirt to changes i
https://git.qemu.org/?p=qemu.git;a=commitdiff;h=c888f7e0fdcc09c8600
** Changed in: qemu
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1877136
Title:
Qe
Patch has been included here:
https://git.qemu.org/?p=qemu.git;a=commitdiff;h=d9b69640391618045
** Changed in: qemu
Status: New => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/18
https://git.qemu.org/?p=qemu.git;a=commitdiff;h=b0588cb51da698671
** Changed in: qemu
Status: New => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1878134
Title:
Assertion fail
In the while loop of cirrus_invalidate_region() the 'off_begin'
increases every loop. It may be greater than 's->cirrus_addr_mask' thus
trigger the assert in the loop.
Following reproducer is provied in:
-->https://bugs.launchpad.net/qemu/+bug/1880189
qemu-system-i386 -M isapc,accel=qtest -vga c
Patch has been included here:
https://git.qemu.org/?p=qemu.git;a=commitdiff;h=257a7e212d5e518ac53b
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1876373
Title:
segfault mremap 4096
Status in QEMU:
On 8/20/20 7:57 AM, Igor Mammedov wrote:
> On Wed, 19 Aug 2020 17:42:58 -0500
> Babu Moger wrote:
>
>> On 8/19/20 7:18 AM, Igor Mammedov wrote:
>>> On Fri, 14 Aug 2020 16:39:40 -0500
>>> Babu Moger wrote:
>>>
Remove node_id, nr_nodes and nodes_per_pkg from topology. Use
die_id, n
** Changed in: qemu
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1886811
Title:
systemd complains Failed to enqueue loopback interface start request:
** Changed in: qemu
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1882817
Title:
Segfault in audio_pcm_sw_write with audio over VNC
Status in QEMU:
F
** Changed in: qemu
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1886343
Title:
configure has non-posix bash syntax
Status in QEMU:
Fix Released
Bu
** Changed in: qemu
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1812451
Title:
In windows host, tftp arbitrary file read vulnerability
Status in QEMU
On Thu, Aug 20, 2020 at 7:37 PM Igor Mammedov wrote:
>
> On Thu, 20 Aug 2020 14:51:56 +0530
> Ani Sinha wrote:
>
> > We introduce a new global flag 'acpi-root-pci-hotplug' for i440fx with which
> > we can turn on or off PCI device hotplug on the root bus. This flag can be
> > used to prevent all
On Wed, Aug 19, 2020 at 08:12:04PM -0400, Eduardo Habkost wrote:
> The typedef was used in the XENBACKEND_DEVICE macro, but it was
> never defined. Define the typedef close to the type checking
> macro.
>
> Signed-off-by: Eduardo Habkost
Acked-by: Anthony PERARD
Thanks,
--
Anthony PERARD
** Changed in: qemu
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1878915
Title:
util/fdmon-io_uring.c:95: get_sqe: Assertion `ret > 1' failed.
Status
** Changed in: qemu
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1859310
Title:
libvirt probing fails due to assertion failure with KVM and 'none'
ma
** Changed in: qemu
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1869497
Title:
x86_cpu_gdb_read_register segfaults when gdb requests registers
Status
** Changed in: qemu
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1861341
Title:
ARM QEMU: Unknown syscall 397
Status in QEMU:
Fix Released
Bug desc
https://git.qemu.org/?p=qemu.git;a=commitdiff;h=9f5a0664187e9411c5c
** Changed in: qemu
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1871250
Title:
Fa
# MYPYPATH=../../python/ mypy 300
300:154: error: Item "None" of "Optional[Match[Any]]" has no attribute "group"
Found 1 error in 1 file (checked 1 source file)
- the only complain. Suggest a fix:
diff --git a/tests/qemu-iotests/300 b/tests/qemu-iotests/300
index c6d86b1dbc..0241903743 100755
--
** Changed in: qemu
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1867519
Title:
qemu 4.2 segfaults on VF detach
Status in QEMU:
Fix Released
Status
** Changed in: qemu
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1872113
Title:
qemu docs fails to build with Sphinx 3.0.x
Status in QEMU:
Fix Relea
Thomas Huth 于2020年8月20日周四 下午10:24写道：
>
> On 19/08/2020 16.15, Li Qiang wrote:
> > Currently the device fuzzer find a more and more issues.
> > For every fuzz case, we need not only the fixes but also
> > the coressponding test case. We can analysis the reproducer
> > for every case and find what h
On 20/08/20 15:30, Kevin Wolf wrote:
> So without that, and also without a mention in deprecated.rst, I don't
> think having mentioned a wish to break things a while ago means that we
> should just follow through with that despite the objections.
>
> At least this isn't how it has worked for other
https://git.qemu.org/?p=qemu.git;a=commitdiff;h=76525114736e8f669766
** Changed in: qemu
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1811533
Title:
U
** Changed in: qemu
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1843254
Title:
arm emulation of HCR.TID3 traps are not implemented
Status in QEMU:
20.08.2020 18:07, Max Reitz wrote:
This migration parameter allows mapping block node names and bitmap
names to aliases for the purpose of block dirty bitmap migration.
This way, management tools can use different node and bitmap names on
the source and destination and pass the mapping of how bi
20.08.2020 18:07, Max Reitz wrote:
Signed-off-by: Max Reitz
Sorry, I missed v5 and answered on v4. Still, the only change is
s/write/discard/ (good change, I'm for), so please refer to my answer on v4 for
other comments.
--
Best regards,
Vladimir
Patchew URL:
https://patchew.org/QEMU/20200820133201.80577-1-gra...@nuviainc.com/
Hi,
This series failed the docker-quick@centos7 build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ==
On 20/08/20 16:54, Peter Maydell wrote:
> Configuring ninjatool using configuration
> Library m found: YES
> Library util found: YES
> Library aio found: YES
> Library rt found: YES
> Found pkg-config: /usr/bin/pkg-config (0.29.1)
> WARNING: Static library 'asound' not found for dependency 'sdl2',
On Tue, Aug 18, 2020 at 08:14:33PM +0100, Peter Maydell wrote:
> On Mon, 23 Mar 2020 at 13:32, Stefan Hajnoczi wrote:
> > On Sat, Mar 21, 2020 at 11:50:23PM +0100, BALATON Zoltan wrote:
> > > This was discussed before. I think instead of annoying people with a
> > > warning, rather configure shoul
Patchew URL:
https://patchew.org/QEMU/20200820133201.80577-1-gra...@nuviainc.com/
Hi,
This series failed the docker-mingw@fedora build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
On Thu, 20 Aug 2020 at 17:02, Paolo Bonzini wrote:
> Meson (just like configure before it) is looking for SDL and other
> dependencies even if you're not building system emulators.
>
> Because you don't have those dependencies installed as static libraries,
> Meson warns that library is marked as
* Chuan Zheng (zhengch...@huawei.com) wrote:
> Add get_dirtyrate_thread() functions
>
> Signed-off-by: Chuan Zheng
> Signed-off-by: YanYing Zhuang
> ---
> migration/Makefile.objs | 1 +
> migration/dirtyrate.c | 64
> +
> migration/dirtyrate.h
Am 20.08.2020 um 17:50 hat Paolo Bonzini geschrieben:
> On 20/08/20 15:30, Kevin Wolf wrote:
> > So without that, and also without a mention in deprecated.rst, I don't
> > think having mentioned a wish to break things a while ago means that we
> > should just follow through with that despite the ob
On Thu, Aug 20, 2020 at 09:36:50AM +0200, Cédric Le Goater wrote:
> The OPAL test suite runs a read-erase-write test on the PNOR :
>
> https://github.com/open-power/op-test/blob/master/testcases/OpTestPNOR.py
>
> which revealed that the IPMI HIOMAP handlers didn't support
> HIOMAP_C_ERASE. Impl
* Chuan Zheng (zhengch...@huawei.com) wrote:
> Add RamlockDirtyInfo to store sampled page info of each ramblock.
>
> Signed-off-by: Chuan Zheng
> Signed-off-by: YanYing Zhuang
> ---
> migration/dirtyrate.h | 18 ++
> 1 file changed, 18 insertions(+)
>
> diff --git a/migration/d
On Wed, Aug 19, 2020 at 10:29 PM Philippe Mathieu-Daudé wrote:
>
> +Eric / Richard for compiler optimizations.
>
> On 8/20/20 3:53 AM, Havard Skinnemoen wrote:
> > On Tue, Aug 11, 2020 at 8:26 PM Havard Skinnemoen
> > wrote:
> >>
> >> On Tue, Aug 11, 2020 at 1:48 AM Philippe Mathieu-Daudé
> >>
* Chuan Zheng (zhengch...@huawei.com) wrote:
> Add dirtyrate statistics to record/update dirtyrate info.
>
> Signed-off-by: Chuan Zheng
> Signed-off-by: YanYing Zhuang
> ---
> migration/dirtyrate.c | 30 ++
> migration/dirtyrate.h | 10 ++
> 2 files changed,
* Chuan Zheng (zhengch...@huawei.com) wrote:
> RAMBLOCK_FOREACH_MIGRATABLE is need in dirtyrate measure,
> move the existing definition up into migration/ram.h
>
> Signed-off-by: Chuan Zheng
> Signed-off-by: YanYing Zhuang
Reviewed-by: Dr. David Alan Gilbert
(I noticed this triggered a few ch
> On Aug 20, 2020, at 9:11 PM, Ani Sinha wrote:
>
> On Thu, Aug 20, 2020 at 7:37 PM Igor Mammedov wrote:
>>
>>> On Thu, 20 Aug 2020 14:51:56 +0530
>>> Ani Sinha wrote:
>>>
>>> We introduce a new global flag 'acpi-root-pci-hotplug' for i440fx with which
>>> we can turn on or off PCI device
On 8/20/20 6:16 PM, Corey Minyard wrote:
> On Thu, Aug 20, 2020 at 09:36:50AM +0200, Cédric Le Goater wrote:
>> The OPAL test suite runs a read-erase-write test on the PNOR :
>>
>> https://github.com/open-power/op-test/blob/master/testcases/OpTestPNOR.py
>>
>> which revealed that the IPMI HIOMAP
The OPAL test suite runs a read-erase-write test on the PNOR :
https://github.com/open-power/op-test/blob/master/testcases/OpTestPNOR.py
which revealed that the IPMI HIOMAP handlers didn't support
HIOMAP_C_ERASE. Implement the sector erase command by writing 0xFF in
the PNOR memory region.
Cc:
On Thu, Aug 20, 2020 at 02:15:04PM +1000, David Gibson wrote:
> On Wed, Aug 19, 2020 at 10:11:28PM -0400, Eduardo Habkost wrote:
> > On Thu, Aug 20, 2020 at 11:17:26AM +1000, David Gibson wrote:
> > > On Fri, Aug 14, 2020 at 05:54:16PM -0300, Daniel Henrique Barboza wrote:
> > > > The pSeries machi
Meson requires the build dir to be separate from the source tree. Many
people are used to just running "./configure && make" though and the
meson conversion breaks that.
This introduces some backcompat support to make it appear as if an
"in source tree" build is being done, but with the the result
Use self-explicit SCALE_MS definition instead of magic value.
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Philippe Mathieu-Daudé
---
block/nvme.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/nvme.c b/block/nvme.c
index 374e2689157..2f5e3c2adfa 100644
--- a/block/nvm
Hi Kevin,
This series is mostly code rearrangement (cleanups) to be
able to split the hardware code from the block driver code,
to be able to use multiple queues on the same hardware, or
multiple block drivers on the same hardware.
All this series is reviewed.
Since v4:
- added 'block/nvme: Use
Avoid further processing if TRACE_NVME_SUBMIT_COMMAND_RAW is
not enabled. This is an untested intend of performance optimization.
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Philippe Mathieu-Daudé
---
block/nvme.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/block/nvme.c b/block/nvme.
As nvme_create_queue_pair() is allowed to fail, replace the
alloc() calls by try_alloc() to avoid aborting QEMU.
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Philippe Mathieu-Daudé
---
block/nvme.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/block/nvme.c b/b
Use definitions instead of '0' or '1' indexes. Also this will
be useful when using multi-queues later.
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Philippe Mathieu-Daudé
---
block/nvme.c | 33 +++--
1 file changed, 19 insertions(+), 14 deletions(-)
diff --git a/bloc
Do not use the same error message for different failures.
Display a different error whether it is the CQ or the SQ.
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Philippe Mathieu-Daudé
---
block/nvme.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/nvme.c b/block/nv
We allocate an unique chunk of memory then use it for two
different structures. By using an union, we make it clear
the data is overlapping (and we can remove the casts).
Suggested-by: Stefan Hajnoczi
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Philippe Mathieu-Daudé
---
block/nvme.c | 31
Rearrange nvme_add_io_queue() by using a common error path.
This will be proven useful in few commits where we add IRQ
notification to the IO queues.
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Philippe Mathieu-Daudé
---
block/nvme.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-
We are going to modify the code in the next commit. Renaming
the 'resp' variable to 'id' first makes the next commit easier
to review. No logical changes.
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Philippe Mathieu-Daudé
---
block/nvme.c | 19 +--
1 file changed, 9 insertions(+
nvme_init_queue() doesn't require BlockDriverState anymore.
Replace it by BDRVNVMeState to simplify.
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Philippe Mathieu-Daudé
---
block/nvme.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/block/nvme.c b/block/nvme.c
index f
qemu_try_blockalign() is a generic API that call back to the
block driver to return its page alignment. As we call from
within the very same driver, we already know to page alignment
stored in our state. Remove indirections and use the value from
BDRVNVMeState.
This change is required to later remo
In the next commit we'll get rid of qemu_try_blockalign().
To ease review, first replace qemu_try_blockalign0() by explicit
calls to qemu_try_blockalign() and memset().
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Philippe Mathieu-Daudé
---
block/nvme.c | 16 +---
1 file changed, 9 i
nvme_create_queue_pair() doesn't require BlockDriverState anymore.
Replace it by BDRVNVMeState and AioContext to simplify.
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Philippe Mathieu-Daudé
---
block/nvme.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/block/
As we want to do per-queue polling, extract the nvme_poll_queue()
method which operates on a single queue.
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Philippe Mathieu-Daudé
---
block/nvme.c | 44 +++-
1 file changed, 27 insertions(+), 17 deletions(-)
di
BDRV_POLL_WHILE() is defined as:
#define BDRV_POLL_WHILE(bs, cond) ({ \
BlockDriverState *bs_ = (bs); \
AIO_WAIT_WHILE(bdrv_get_aio_context(bs_), \
cond); })
As we will remove the BlockDriverState use in the next commit,
start by using the e
In preparation of using multiple IRQ (thus multiple eventfds)
make BDRVNVMeState::irq_notifier an array (for now of a single
element, the admin queue notifier).
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Philippe Mathieu-Daudé
---
block/nvme.c | 31 +--
1 file chang
On Thu, 20 Aug 2020 at 17:56, Daniel P. Berrangé wrote:
> Meson requires the build dir to be separate from the source tree. Many
> people are used to just running "./configure && make" though and the
> meson conversion breaks that.
>
> This introduces some backcompat support to make it appear as i
Some 'qemu_vfio_*' trace events sizes are displayed using
decimal notation, other using hexadecimal notation:
qemu_vfio_ram_block_added s 0xf2448d90 host 0x5bc0 size 0x400
qemu_vfio_dma_map s 0xf2448d90 host 0x5bc0 size 67108864
temporary 0 iova (nil)
qemu_vfio_f
Patchew URL: https://patchew.org/QEMU/20200820164638.2515681-1-...@kaod.org/
Hi,
This series failed the docker-quick@centos7 build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#!/b
On Thu, Aug 20, 2020 at 06:10:34PM +0100, Peter Maydell wrote:
> On Thu, 20 Aug 2020 at 17:56, Daniel P. Berrangé wrote:
> > Meson requires the build dir to be separate from the source tree. Many
> > people are used to just running "./configure && make" though and the
> > meson conversion breaks t
On Thu, 20 Aug 2020 at 17:56, Daniel P. Berrangé wrote:
>
> Meson requires the build dir to be separate from the source tree. Many
> people are used to just running "./configure && make" though and the
> meson conversion breaks that.
>
> This introduces some backcompat support to make it appear as
On 8/16/20 10:20 PM, Chuan Zheng wrote:
Implement qmp_cal_dirty_rate()/qmp_get_dirty_rate() function which could be
called
Signed-off-by: Chuan Zheng
---
+++ b/qapi/migration.json
@@ -1621,3 +1621,45 @@
##
{ 'event': 'UNPLUG_PRIMARY',
'data': { 'device-id': 'str' } }
+
+##
+# @Dirty
Typo "pseudo" in subject.
On 8/20/20 6:55 PM, Daniel P. Berrangé wrote:
> Meson requires the build dir to be separate from the source tree. Many
> people are used to just running "./configure && make" though and the
> meson conversion breaks that.
>
> This introduces some backcompat support to ma
* Chuan Zheng (zhengch...@huawei.com) wrote:
> Record hash results for each sampled page.
>
> Signed-off-by: Chuan Zheng
> Signed-off-by: YanYing Zhuang
> ---
> migration/dirtyrate.c | 144
> ++
> migration/dirtyrate.h | 7 +++
> 2 files change
Meson requires the build dir to be separate from the source tree. Many
people are used to just running "./configure && make" though and the
meson conversion breaks that.
This introduces some backcompat support to make it appear as if an
"in source tree" build is being done, but with the the result
* Chuan Zheng (zhengch...@huawei.com) wrote:
> Compare page hash results for recorded sampled page.
>
> Signed-off-by: Chuan Zheng
> Signed-off-by: YanYing Zhuang
> ---
> migration/dirtyrate.c | 76
> +++
> 1 file changed, 76 insertions(+)
>
> d
101 - 200 of 279 matches
Mail list logo
