Re: [PATCH 3/8] spapr/xive: Query the characteristics of a source in KVM

2020-08-20 Thread Cédric Le Goater
On 8/20/20 3:33 AM, David Gibson wrote: > On Wed, Aug 19, 2020 at 03:08:38PM +0200, Cédric Le Goater wrote: >> When running a guest with a kernel IRQ chip enabled, the XIVE >> characteristics of the interrupts are advertised to the guest in the >> H_INT_GET_SOURCE_INFO hcall. These characteristics

Re: [PATCH 7/8] spapr/xive: Use the xics flag to check for XIVE-only IRQ backends

2020-08-20 Thread Cédric Le Goater
On 8/20/20 3:36 AM, David Gibson wrote: > On Wed, Aug 19, 2020 at 03:08:42PM +0200, Cédric Le Goater wrote: > > I can see why this is a good idea, but it really needs a rationale in > the comment for posterity. yes. I can send this one independently. Thanks, C. > >> Signed-off-by: Cédric Le

Re: [PATCH v2 28/58] s390x: Move typedef SCLPEventFacility to event-facility.h

2020-08-20 Thread Cornelia Huck
On Wed, 19 Aug 2020 20:12:06 -0400 Eduardo Habkost wrote: > This will make future conversion to OBJECT_DECLARE* easier. > > In sclp.h, use "struct SCLPEventFacility" to avoid introducing > unnecessary header dependencies. > > Signed-off-by: Eduardo Habkost > --- > Changes series v1 -> v2: new

[PATCH v2] ide:do nothing for identify cmd if no any device attached

2020-08-20 Thread zhaoxin\RockCuioc
v1 -> v2: fix codestyle checked by checkpatch.pl This patch is for avoiding win7 IDE driver polling 0x1f7 when no any device attached. During Win7 VM boot procedure, if use virtio for disk and there is no any device be attached on hda & hdb, the win7 IDE driver would poll 0x1f7 for a while. Th

[PATCH v2] softfloat: add alternative sNaN propagation for fmax/fmin

2020-08-20 Thread Chih-Min Chao
For "fmax/fmin ft0, ft1, ft2" and if one of the inputs is sNaN, The original logic return NaN and set invalid flag if ft1 == sNaN || ft2 == sNan The alternative path set invalid flag and return the non-NaN value if ft1 == sNaN || ft2 == sNaN return NaN if ft1 == sNaN && ft2 == sNaN

Re: [PATCH v7 0/7] coroutines: generate wrapper code

2020-08-20 Thread Paolo Bonzini
On 20/08/20 03:33, Eric Blake wrote: >>> >> >> OK, will do. Thanks for taking a look! > > As this series touched Makefile to add a generated .c, you'll also need > to rebase that part to apply on top of Paolo's meson conversion (cc'ing > him if you need help figuring it out) It should be trivial

[PATCH] ppc/pnv: Add a HIOMAP erase command

2020-08-20 Thread Cédric Le Goater
The OPAL test suite runs a read-erase-write test on the PNOR : https://github.com/open-power/op-test/blob/master/testcases/OpTestPNOR.py which revealed that the IPMI HIOMAP handlers didn't support HIOMAP_C_ERASE. Implement the sector erase command by writing 0xFF in the PNOR memory region. Rep

Re: [PATCH v2 for 5.2 0/3] block: add logging facility for long standing IO requests

2020-08-20 Thread Denis V. Lunev
On 8/12/20 5:00 PM, Stefan Hajnoczi wrote: > On Mon, Aug 10, 2020 at 01:14:44PM +0300, Denis V. Lunev wrote: >> There are severe delays with IO requests processing if QEMU is running in >> virtual machine or over software defined storage. Such delays potentially >> results in unpredictable guest be

Re: [PATCH v7 4/7] scripts: add coroutine-wrapper.py

2020-08-20 Thread Paolo Bonzini
On 10/06/20 12:03, Vladimir Sementsov-Ogievskiy wrote: > +{struct_name} s = {{ > +.poll_state.bs = {bs}, > +.poll_state.in_progress = true, > + > +{ func.gen_block('.{name} = {name},') } > +}}; > + > +s.poll_state.co = qemu_coroutine_creat

Re: [PATCH v8 0/6] block: seriously improve savevm/loadvm performance

2020-08-20 Thread Denis V. Lunev
On 7/9/20 4:26 PM, Denis V. Lunev wrote: > This series do standard basic things: > - it creates intermediate buffer for all writes from QEMU migration code > to QCOW2 image, > - this buffer is sent to disk asynchronously, allowing several writes to > run in parallel. > > In general, migration c

Re: [PATCH 2/2] target/mips: Add definition of Loongson-3A3000 CPU

2020-08-20 Thread Kaige Li
On 08/14/2020 10:48 AM, Jiaxun Yang wrote: 在 2020/8/14 上午10:43, Kaige Li 写道: On 08/13/2020 06:37 PM, Jiaxun Yang wrote: 在 2020/8/13 下午5:41, Kaige Li 写道: Add definition of the Loongson-3A3000 processor in QEMU. Hi Kaige, We're not defining Loongson-3A3000 in QEMU because we have some

Re: [PATCH 2/3] block: add logging facility for long standing IO requests

2020-08-20 Thread David Edmondson
On Monday, 2020-08-10 at 13:14:46 +03, Denis V. Lunev wrote: > +strftime(buf, sizeof(buf), "%m-%d %H:%M:%S", "%F %T" would include the year, which can be useful. > + localtime_r(&start_time_host_s, &t)); > + > +bs = blk_bs(blk_stats2blk(stats)); > +qemu_log("long %s[%ld]

Re: Difficulty making usb-serial device visible within the guest

2020-08-20 Thread Gerd Hoffmann
Hi, > With auto-attach disabled this effectively prevents the device from > attaching to the USB unless the chardev is opened which feels odd. Why? It's not needed to connect at boot btw, the device will be hotplugged if the chardev is opened. > I would expect that if I add a device to QEMU u

Re: [RFC v3 2/8] cpus: prepare new CpusAccel cpu accelerator interface

2020-08-20 Thread Claudio Fontana
Hi Paolo and all, back in RFC v3 I introduced cpus_get_virtual_clock in this patch. I observed an issue when adding the get_virtual_clock to the CpusAccel interface, ie it seems that qemu_clock_get_ns() is called in some io-tests before the accelerator is initialized, which seems to collide wit

[PATCH V5] Introduce a new flag for i440fx to disable PCI hotplug on the root bus

2020-08-20 Thread Ani Sinha
We introduce a new global flag 'acpi-root-pci-hotplug' for i440fx with which we can turn on or off PCI device hotplug on the root bus. This flag can be used to prevent all PCI devices from getting hotplugged or unplugged from the root PCI bus. This feature is targetted mostly towards Windows VMs. I

Re: hw-display-qxl.so: undefined symbol: qemu_qxl_io_log_semaphore

2020-08-20 Thread Gerd Hoffmann
Hi, > If systemtap won't change, then to fix this, for any foo.c > that will be in a module, we need a separate 'foo.trace' > file that generates a .o that is directly linked to the > foo.so, not the qemu-system-x86_64 binary. I think that is the plan anyway. take care, Gerd

Re: [PATCH v7 14/47] stream: Deal with filters

2020-08-20 Thread Max Reitz
On 19.08.20 17:16, Kevin Wolf wrote: > Am 19.08.2020 um 16:47 hat Max Reitz geschrieben: >> On 18.08.20 16:28, Kevin Wolf wrote: >>> Am 25.06.2020 um 17:21 hat Max Reitz geschrieben: Because of the (not so recent anymore) changes that make the stream job independent of the base node and i

Re: [PULL 0/2] Block patches for 5.1.0-rc4

2020-08-20 Thread Peter Maydell
On Tue, 11 Aug 2020 at 10:35, Max Reitz wrote: > > Hi, > > There is a bug in the backup job that breaks backups from images whose > size is not aligned to the job's cluster size (i.e., qemu crashes > because of a failed assertion). If this bug makes it into the release, > it would be a regression

Re: hw-display-qxl.so: undefined symbol: qemu_qxl_io_log_semaphore

2020-08-20 Thread Daniel P . Berrangé
On Thu, Aug 20, 2020 at 10:29:43AM +0200, Gerd Hoffmann wrote: > Hi, > > > If systemtap won't change, then to fix this, for any foo.c > > that will be in a module, we need a separate 'foo.trace' > > file that generates a .o that is directly linked to the > > foo.so, not the qemu-system-x86_64 bi

Re: [PATCH V5] Introduce a new flag for i440fx to disable PCI hotplug on the root bus

2020-08-20 Thread Philippe Mathieu-Daudé
On 8/20/20 10:16 AM, Ani Sinha wrote: > We introduce a new global flag 'acpi-root-pci-hotplug' for i440fx with which > we can turn on or off PCI device hotplug on the root bus. This flag can be > used to prevent all PCI devices from getting hotplugged or unplugged from the > root PCI bus. > This fe

Re: [PULL v6 000/150] Meson-based build system

2020-08-20 Thread Peter Maydell
On Thu, 20 Aug 2020 at 00:20, Paolo Bonzini wrote: > My complaint was only that, until last week nobody even tried to apply > and make the patches, and therefore some of the input I got surprised > me. I think from my point of view I've been surprised because my impression as somebody not followi

Re: [PATCH] hw/arm/virt: Default to architecture appropriate CPU

2020-08-20 Thread Peter Maydell
On Thu, 20 Aug 2020 at 05:55, Punit Agrawal wrote: > > The default_cpu_type for the Virt machine is set to "cortex-a15" for > both the arm (qemu-system-arm) and aarch64 (qemu-system-aarch64) > targets. > > As a result, starting the aarch64 target with "-machine virt" defaults > to booting with a A

Re: Difficulty making usb-serial device visible within the guest

2020-08-20 Thread Mark Cave-Ayland
On 20/08/2020 09:15, Gerd Hoffmann wrote: >> With auto-attach disabled this effectively prevents the device from >> attaching to the USB unless the chardev is opened which feels odd. > > Why? It's not needed to connect at boot btw, the device will be > hotplugged if the chardev is opened. Yes,

[PATCH V6] Introduce a new flag for i440fx to disable PCI hotplug on the root bus

2020-08-20 Thread Ani Sinha
We introduce a new global flag 'acpi-root-pci-hotplug' for i440fx with which we can turn on or off PCI device hotplug on the root bus. This flag can be used to prevent all PCI devices from getting hotplugged or unplugged from the root PCI bus. This feature is targetted mostly towards Windows VMs. I

Re: [PATCH v7 14/47] stream: Deal with filters

2020-08-20 Thread Max Reitz
On 20.08.20 10:31, Max Reitz wrote: [...] > So all in all, I believe the biggest surprise about what’s written into > the top layer isn’t that it may be a json:{} filename, but the filename > of a node that maybe doesn’t even exist anymore? (Oh, no, please don’t > tell me you can delete it and g

Re: [PATCH V5] Introduce a new flag for i440fx to disable PCI hotplug on the root bus

2020-08-20 Thread Ani Sinha
On Thu, Aug 20, 2020 at 2:21 PM Philippe Mathieu-Daudé wrote: > > On 8/20/20 10:16 AM, Ani Sinha wrote: > > We introduce a new global flag 'acpi-root-pci-hotplug' for i440fx with which > > we can turn on or off PCI device hotplug on the root bus. This flag can be > > used to prevent all PCI device

Re: [PATCH v3 12/12] block/qcow2: automatically insert preallocate filter when on FUSE

2020-08-20 Thread Vladimir Sementsov-Ogievskiy
19.08.2020 18:15, Stefan Hajnoczi wrote: On Mon, Aug 17, 2020 at 12:15:53PM +0300, Vladimir Sementsov-Ogievskiy wrote: vstorage has slow allocation, so this patch detect vstorage (I hope, we don't use other FUSE filesystems) and inserts preallocate filter between qcow2 node and its file child.

[PATCH v1] pc: fix auto_enable_numa_with_memhp/auto_enable_numa_with_memdev for the 5.0 machine

2020-08-20 Thread David Hildenbrand
Unfortunately, a typo sneeked in: we want to set auto_enable_numa_with_memdev to false, not auto_enable_numa_with_memhp. Cc: qemu-sta...@nongnu.org # v5.1 Fixes: 195784a0cfad (numa: Auto-enable NUMA when any memory devices are possible) Reported-by: Dr. David Alan Gilbert Cc: Paolo Bonzini Cc:

Re: [PATCH v1] pc: fix auto_enable_numa_with_memhp/auto_enable_numa_with_memdev for the 5.0 machine

2020-08-20 Thread Dr. David Alan Gilbert
* David Hildenbrand (da...@redhat.com) wrote: > Unfortunately, a typo sneeked in: we want to set > auto_enable_numa_with_memdev to false, not auto_enable_numa_with_memhp. > > Cc: qemu-sta...@nongnu.org # v5.1 > Fixes: 195784a0cfad (numa: Auto-enable NUMA when any memory devices are > possible) >

Re: [PATCH v5 1/1] audio/jack: fix use after free segfault

2020-08-20 Thread Christian Schoenebeck
On Donnerstag, 20. August 2020 07:37:28 CEST Gerd Hoffmann wrote: > Hi, > > > > +qemu_bh_cancel(c->shutdown_bh); > > > > Looks like a potential race. Quote from the API doc of qemu_bh_cancel(): > > "While cancellation itself is also wait-free and thread-safe, it can of > > course ra

Re: [PATCH v3] block/nbd: use non-blocking connect: fix vm hang on connect()

2020-08-20 Thread Vladimir Sementsov-Ogievskiy
19.08.2020 17:46, Eric Blake wrote: On 8/12/20 9:52 AM, Vladimir Sementsov-Ogievskiy wrote: This make nbd connection_co to yield during reconnects, so that s/make nbd connection_co to/makes nbd's connection_co/ reconnect doesn't hang up the main thread. This is very important in s/hang up/

Re: [PATCH v7 33/47] mirror: Deal with filters

2020-08-20 Thread Max Reitz
On 19.08.20 18:50, Kevin Wolf wrote: > Am 25.06.2020 um 17:22 hat Max Reitz geschrieben: >> This includes some permission limiting (for example, we only need to >> take the RESIZE permission for active commits where the base is smaller >> than the top). >> >> Use this opportunity to rename qmp_driv

Re: [PATCH v3] block/nbd: use non-blocking connect: fix vm hang on connect()

2020-08-20 Thread Vladimir Sementsov-Ogievskiy
19.08.2020 20:52, Eric Blake wrote: On 8/12/20 9:52 AM, Vladimir Sementsov-Ogievskiy wrote: This make nbd connection_co to yield during reconnects, so that reconnect doesn't hang up the main thread. This is very important in case of unavailable nbd server host: connect() call may take a long tim

Re: [PATCH 02/10] numa: introduce MachineClass::forbid_asymmetrical_numa

2020-08-20 Thread Daniel Henrique Barboza
On 8/20/20 1:15 AM, David Gibson wrote: On Wed, Aug 19, 2020 at 10:11:28PM -0400, Eduardo Habkost wrote: On Thu, Aug 20, 2020 at 11:17:26AM +1000, David Gibson wrote: On Fri, Aug 14, 2020 at 05:54:16PM -0300, Daniel Henrique Barboza wrote: The pSeries machine does not support asymmetrical N

Re: [PULL v7 000/151] Meson-based build system

2020-08-20 Thread Peter Maydell
On Wed, 19 Aug 2020 at 22:32, Paolo Bonzini wrote: > > The following changes since commit d0ed6a69d399ae193959225cdeaa9382746c91cc: > > Update version for v5.1.0 release (2020-08-11 17:07:03 +0100) > > are available in the Git repository at: > > https://gitlab.com/bonzini/qemu.git tags/for-ups

Re: [PATCH V1 30/32] vfio-pci: save and restore

2020-08-20 Thread Jason Zeng
On Wed, Aug 19, 2020 at 05:15:11PM -0400, Steven Sistare wrote: > On 8/9/2020 11:50 PM, Jason Zeng wrote: > > On Fri, Aug 07, 2020 at 04:38:12PM -0400, Steven Sistare wrote: > >> On 8/6/2020 6:22 AM, Jason Zeng wrote: > >>> Hi Steve, > >>> > >>> On Thu, Jul 30, 2020 at 08:14:34AM -0700, Steve Sista

Re: [PATCH 07/10] spapr: create helper to set ibm,associativity

2020-08-20 Thread Daniel Henrique Barboza
On 8/20/20 12:00 AM, David Gibson wrote: On Fri, Aug 14, 2020 at 05:54:21PM -0300, Daniel Henrique Barboza wrote: We have several places around hw/ppc files where we use the same code to set the ibm,associativity array. This patch creates a helper called spapr_set_associativity() to do that i

Re: [PATCH v7 14/47] stream: Deal with filters

2020-08-20 Thread Vladimir Sementsov-Ogievskiy
20.08.2020 12:22, Max Reitz wrote: On 20.08.20 10:31, Max Reitz wrote: [...] So all in all, I believe the biggest surprise about what’s written into the top layer isn’t that it may be a json:{} filename, but the filename of a node that maybe doesn’t even exist anymore? (Oh, no, please don’t t

Re: deprecation of in-tree builds

2020-08-20 Thread Kevin Wolf
Am 18.08.2020 um 21:14 hat Peter Maydell geschrieben: > On Mon, 23 Mar 2020 at 13:32, Stefan Hajnoczi wrote: > > On Sat, Mar 21, 2020 at 11:50:23PM +0100, BALATON Zoltan wrote: > > > This was discussed before. I think instead of annoying people with a > > > warning, rather configure should be chan

Re: [PATCH v5 1/1] audio/jack: fix use after free segfault

2020-08-20 Thread Paolo Bonzini
On 20/08/20 12:06, Christian Schoenebeck wrote: > Hmmm, as Geoffrey already added a lock today, I noticed that QEMU's main IO > thread mutex is not initialized as 'recursive' lock type. Does that make > sense? I.e. shouldn't there be a > > qemu_rec_mutex_init(&qemu_global_mutex); > > in s

Re: [RFC PATCH 07/22] block/export: Remove magic from block-export-add

2020-08-20 Thread Kevin Wolf
Am 19.08.2020 um 21:50 hat Eric Blake geschrieben: > cc: Peter Krempa > > On 8/13/20 11:29 AM, Kevin Wolf wrote: > > nbd-server-add tries to be convenient and adds two questionable > > features that we don't want to share in block-export-add, even for NBD > > exports: > > > > 1. When requesting a

Re: [RFC PATCH 08/22] nbd: Add max-connections to nbd-server-start

2020-08-20 Thread Kevin Wolf
Am 19.08.2020 um 22:00 hat Eric Blake geschrieben: > On 8/13/20 11:29 AM, Kevin Wolf wrote: > > This is a QMP equivalent of qemu-nbd's --share option, limiting the > > maximum number of clients that can attach at the same time. > > > > Signed-off-by: Kevin Wolf > > --- > > qapi/block-export.jso

Re: deprecation of in-tree builds

2020-08-20 Thread Michael Tokarev
20.08.2020 13:54, Kevin Wolf wrote: [] >> My current plan is to land the Meson series first, because it is >> really painful for Paolo to try to keep rebasing it as other >> changes to the old build system occur. This would break >> in-tree builds temporarily until the "automatic creation and >> us

Re: [PATCH] ppc/pnv: Add a HIOMAP erase command

2020-08-20 Thread David Gibson
On Thu, Aug 20, 2020 at 09:36:50AM +0200, Cédric Le Goater wrote: > The OPAL test suite runs a read-erase-write test on the PNOR : > > https://github.com/open-power/op-test/blob/master/testcases/OpTestPNOR.py > > which revealed that the IPMI HIOMAP handlers didn't support > HIOMAP_C_ERASE. Impl

Re: [PATCH v7 35/47] commit: Deal with filters

2020-08-20 Thread Max Reitz
On 19.08.20 19:58, Kevin Wolf wrote: > Am 25.06.2020 um 17:22 hat Max Reitz geschrieben: >> This includes some permission limiting (for example, we only need to >> take the RESIZE permission if the base is smaller than the top). >> >> Signed-off-by: Max Reitz >> --- >> block/block-backend.c

Re: [PATCH v7 14/47] stream: Deal with filters

2020-08-20 Thread Max Reitz
On 20.08.20 12:49, Vladimir Sementsov-Ogievskiy wrote: > 20.08.2020 12:22, Max Reitz wrote: >> On 20.08.20 10:31, Max Reitz wrote: >> >> [...] >> >>> So all in all, I believe the biggest surprise about what’s written into >>> the top layer isn’t that it may be a json:{} filename, but the filename >

Re: [PULL v7 000/151] Meson-based build system

2020-08-20 Thread Paolo Bonzini
On 20/08/20 12:33, Peter Maydell wrote: > 'make check' still fails for the all-linux-static config, this > time for a different reason: > > make: *** No rule to make target 'check-qtest', needed by 'check'. Stop. Oh, there are two "check:" rules. I pushed again the tag with just this delta: dif

Re: deprecation of in-tree builds

2020-08-20 Thread Paolo Bonzini
On 20/08/20 12:54, Kevin Wolf wrote: >> Paolo's conversion-to-Meson patchseries is about to land, so now >> is the time for people who would like this "automatically create >> a build directory and use it" behaviour to write the necessary >> patches. Any volunteers ? >> >> My current plan is to lan

Re: [PATCH v5 1/1] audio/jack: fix use after free segfault

2020-08-20 Thread Christian Schoenebeck
On Donnerstag, 20. August 2020 12:54:49 CEST Paolo Bonzini wrote: > More on the practical side, recursive mutex are an easy way to get a > deadlock. It's a common idiom to do > > /* Need to take foo->lock outside bar->lock. */ > mutex_unlock(&bar->lock); > mutex_lock(&foo->lock); >

Re: deprecation of in-tree builds

2020-08-20 Thread Peter Maydell
On Thu, 20 Aug 2020 at 12:56, Paolo Bonzini wrote: > > On 20/08/20 12:54, Kevin Wolf wrote: > >> Paolo's conversion-to-Meson patchseries is about to land, so now > >> is the time for people who would like this "automatically create > >> a build directory and use it" behaviour to write the necessar

Re: [ovirt-devel] Re: device compatibility interface for live migration with assigned devices

2020-08-20 Thread Cornelia Huck
On Wed, 19 Aug 2020 17:28:38 +0800 Jason Wang wrote: > On 2020/8/19 下午4:13, Yan Zhao wrote: > > On Wed, Aug 19, 2020 at 03:39:50PM +0800, Jason Wang wrote: > >> On 2020/8/19 下午2:59, Yan Zhao wrote: > >>> On Wed, Aug 19, 2020 at 02:57:34PM +0800, Jason Wang wrote: > On 2020/8/19 上午11:30

[PATCH] hw/arm/virt: Default to architecture appropriate CPU

2020-08-20 Thread Punit Agrawal
The default_cpu_type for the Virt machine is set to "cortex-a15" for both the arm (qemu-system-arm) and aarch64 (qemu-system-aarch64) targets. As a result, starting the aarch64 target with "-machine virt" defaults to booting with a Arm v7 cpu which is counter to expectation. Debugging the issue is

[PATCH] ui: Add more mouse buttons to SPICE

2020-08-20 Thread Frediano Ziglio
Add support for SIDE and EXTRA buttons. Signed-off-by: Frediano Ziglio --- ui/spice-input.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ui/spice-input.c b/ui/spice-input.c index cd4bb0043f..d5bba231c9 100644 --- a/ui/spice-input.c +++ b/ui/spice-input.c @@ -123,6 +123,8 @@ static void

Re: [PATCH v4 1/4] migration: Add block-bitmap-mapping parameter

2020-08-20 Thread Max Reitz
On 20.08.20 03:17, Eric Blake wrote: > On 8/18/20 8:32 AM, Max Reitz wrote: >> This migration parameter allows mapping block node names and bitmap >> names to aliases for the purpose of block dirty bitmap migration. >> >> This way, management tools can use different node and bitmap names on >> the

Re: [PATCH v4 3/3] hw/i386: Remove node_id, nr_nodes and nodes_per_pkg from topology

2020-08-20 Thread Igor Mammedov
On Wed, 19 Aug 2020 17:42:58 -0500 Babu Moger wrote: > On 8/19/20 7:18 AM, Igor Mammedov wrote: > > On Fri, 14 Aug 2020 16:39:40 -0500 > > Babu Moger wrote: > > > >> Remove node_id, nr_nodes and nodes_per_pkg from topology. Use > >> die_id, nr_dies and dies_per_pkg which is already available.

Re: [PATCH v4 1/4] migration: Add block-bitmap-mapping parameter

2020-08-20 Thread Vladimir Sementsov-Ogievskiy
18.08.2020 16:32, Max Reitz wrote: This migration parameter allows mapping block node names and bitmap names to aliases for the purpose of block dirty bitmap migration. This way, management tools can use different node and bitmap names on the source and destination and pass the mapping of how bi

[PATCH] ui: Add more mouse buttons to SPICE

2020-08-20 Thread Frediano Ziglio
From: Frediano Ziglio Add support for SIDE and EXTRA buttons. Signed-off-by: Frediano Ziglio --- ui/spice-input.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ui/spice-input.c b/ui/spice-input.c index cd4bb0043f..d5bba231c9 100644 --- a/ui/spice-input.c +++ b/ui/spice-input.c @@ -123,

Re: [PATCH v2 04/58] pl110: Rename pl110_version enum values

2020-08-20 Thread Philippe Mathieu-Daudé
On 8/20/20 2:11 AM, Eduardo Habkost wrote: > The PL110 enum value name will conflict with the PL110 type cast > checker, when we replace the existing macro with an inline > function. Add a VERSION_ prefix to all pl110_version enum > values, to avoid conflicts. > > Signed-off-by: Eduardo Habkost

Re: [PATCH v2 36/58] piix: Move QOM macros to header

2020-08-20 Thread Philippe Mathieu-Daudé
On 8/20/20 2:12 AM, Eduardo Habkost wrote: > This will make future conversion to OBJECT_DECLARE* easier. > > Signed-off-by: Eduardo Habkost > --- > Changes series v1 -> v2: new patch in series v2 > > Cc: "Michael S. Tsirkin" > Cc: Marcel Apfelbaum > Cc: "Hervé Poussineau" > Cc: "Philippe Math

Re: [PATCH v2 42/58] vfio/pci: Move QOM macros to header

2020-08-20 Thread Philippe Mathieu-Daudé
On 8/20/20 2:12 AM, Eduardo Habkost wrote: > This will make future conversion to OBJECT_DECLARE* easier. > > Signed-off-by: Eduardo Habkost > --- > Changes series v1 -> v2: new patch in series v2 > > Cc: Alex Williamson > Cc: qemu-devel@nongnu.org > --- > hw/vfio/pci.h | 3 +++ > hw/vfio/pci.c

Re: [PATCH v2 42/58] vfio/pci: Move QOM macros to header

2020-08-20 Thread Philippe Mathieu-Daudé
On 8/20/20 2:12 AM, Eduardo Habkost wrote: > This will make future conversion to OBJECT_DECLARE* easier. > > Signed-off-by: Eduardo Habkost > --- > Changes series v1 -> v2: new patch in series v2 > > Cc: Alex Williamson > Cc: qemu-devel@nongnu.org > --- > hw/vfio/pci.h | 3 +++ > hw/vfio/pci.c

Re: [PATCH] audio/jack: fix use after free segfault

2020-08-20 Thread Christian Schoenebeck
On Mittwoch, 19. August 2020 17:57:35 CEST Geoffrey McRae wrote: > > The ringbuffer implementation looks a bit wild: > > > > /* read PCM interleaved */ > > static int qjack_buffer_read(QJackBuffer *buffer, float *dest, int > > size) > > { > > > > assert(buffer->data); > > const int sample

Re: [PATCH v4 4/4] iotests: Test node/bitmap aliases during migration

2020-08-20 Thread Max Reitz
On 20.08.20 03:58, Eric Blake wrote: > On 8/18/20 8:32 AM, Max Reitz wrote: >> Signed-off-by: Max Reitz >> --- >>   tests/qemu-iotests/300 | 595 + >>   tests/qemu-iotests/300.out |   5 + > > Rather sparse output (I hate debugging those sorts of outputs when

Re: device compatibility interface for live migration with assigned devices

2020-08-20 Thread Sean Mooney
On Thu, 2020-08-20 at 14:27 +0800, Yan Zhao wrote: > On Thu, Aug 20, 2020 at 06:16:28AM +0100, Sean Mooney wrote: > > On Thu, 2020-08-20 at 12:01 +0800, Yan Zhao wrote: > > > On Thu, Aug 20, 2020 at 02:29:07AM +0100, Sean Mooney wrote: > > > > On Thu, 2020-08-20 at 08:39 +0800, Yan Zhao wrote: > >

Re: [PATCH] ui: Add more mouse buttons to SPICE

2020-08-20 Thread Marc-André Lureau
Hi On Thu, Aug 20, 2020 at 5:01 PM Frediano Ziglio wrote: > From: Frediano Ziglio > > Add support for SIDE and EXTRA buttons. > > Signed-off-by: Frediano Ziglio > --- > ui/spice-input.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/ui/spice-input.c b/ui/spice-input.c > index cd4b

Re: deprecation of in-tree builds

2020-08-20 Thread Kevin Wolf
Am 20.08.2020 um 13:56 hat Paolo Bonzini geschrieben: > On 20/08/20 12:54, Kevin Wolf wrote: > >> Paolo's conversion-to-Meson patchseries is about to land, so now > >> is the time for people who would like this "automatically create > >> a build directory and use it" behaviour to write the necessar

Re: [PATCH v4 1/4] migration: Add block-bitmap-mapping parameter

2020-08-20 Thread Max Reitz
On 20.08.20 14:58, Vladimir Sementsov-Ogievskiy wrote: > 18.08.2020 16:32, Max Reitz wrote: >> This migration parameter allows mapping block node names and bitmap >> names to aliases for the purpose of block dirty bitmap migration. >> >> This way, management tools can use different node and bitmap

Re: [PATCH v4 2/4] iotests.py: Add wait_for_runstate()

2020-08-20 Thread Vladimir Sementsov-Ogievskiy
18.08.2020 16:32, Max Reitz wrote: Signed-off-by: Max Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH v4 3/4] iotests.py: Let wait_migration() return on failure

2020-08-20 Thread Vladimir Sementsov-Ogievskiy
18.08.2020 16:32, Max Reitz wrote: Let wait_migration() return on failure (with the return value indicating whether the migration was completed or has failed), so we can use it for migrations that are expected to fail, too. Signed-off-by: Max Reitz --- tests/qemu-iotests/iotests.py | 18 +

[PATCH v2 2/4] spapr/xive: Use kvmppc_xive_source_reset() in post_load

2020-08-20 Thread Cédric Le Goater
This is doing an extra loop but should be equivalent. It also differentiate the reset of the sources from the restore of the sources configuration. This will help in allocating the vCPU IPIs independently. Signed-off-by: Cédric Le Goater --- hw/intc/spapr_xive_kvm.c | 20 ++-- 1

[PATCH v2 0/4] spapr/xive: Allocate vCPU IPIs from the vCPU contexts

2020-08-20 Thread Cédric Le Goater
Hello, When QEMU switches to the XIVE interrupt mode, it creates all the guest interrupts at the level of the KVM device. These interrupts are backed by real HW interrupts from the IPI interrupt pool of the XIVE controller. Currently, this is done from the QEMU main thread, which results in allo

[PATCH v2 3/4] spapr/xive: Allocate IPIs independently from the other sources

2020-08-20 Thread Cédric Le Goater
The vCPU IPIs are now allocated in kvmppc_xive_cpu_connect() when the vCPU connects to the KVM device and not when all the sources are reset in kvmppc_xive_source_reset() This requires extra care for hotplug vCPUs and VM restore. Signed-off-by: Cédric Le Goater --- hw/intc/spapr_xive_kvm.c | 47

[PATCH v2 4/4] spapr/xive: Allocate vCPU IPIs from the vCPU contexts

2020-08-20 Thread Cédric Le Goater
When QEMU switches to the XIVE interrupt mode, it creates all the guest interrupts at the level of the KVM device. These interrupts are backed by real HW interrupts from the IPI interrupt pool of the XIVE controller. Currently, this is done from the QEMU main thread, which results in allocating al

[PATCH v2 1/4] spapr/xive: Modify kvm_cpu_is_enabled() interface

2020-08-20 Thread Cédric Le Goater
We will use to check if a vCPU IPI has been created. Signed-off-by: Cédric Le Goater --- hw/intc/spapr_xive_kvm.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/intc/spapr_xive_kvm.c b/hw/intc/spapr_xive_kvm.c index 3eea4cb1c49f..d5fb5b260d5e 100644 --- a/hw/intc/spa

Re: [PATCH v7 35/47] commit: Deal with filters

2020-08-20 Thread Kevin Wolf
Am 20.08.2020 um 13:27 hat Max Reitz geschrieben: > On 19.08.20 19:58, Kevin Wolf wrote: > > Am 25.06.2020 um 17:22 hat Max Reitz geschrieben: > >> This includes some permission limiting (for example, we only need to > >> take the RESIZE permission if the base is smaller than the top). > >> > >> Si

Re: [PATCH] hw/arm/sbsa-ref.c : Add a fake embedded controller

2020-08-20 Thread Graeme Gregory
On Thu, Aug 20, 2020 at 02:32:01PM +0100, Graeme Gregory wrote: > A difference between sbsa platform and the virt platform is PSCI is > handled by ARM-TF in the sbsa platform. This means that the PSCI code > there needs to communicate some of the platform power changes down > to the qemu code for t

Re: [PATCH v4 4/4] iotests: Test node/bitmap aliases during migration

2020-08-20 Thread Vladimir Sementsov-Ogievskiy
20.08.2020 16:17, Max Reitz wrote: On 20.08.20 03:58, Eric Blake wrote: On 8/18/20 8:32 AM, Max Reitz wrote: Signed-off-by: Max Reitz ---   tests/qemu-iotests/300 | 595 +   tests/qemu-iotests/300.out |   5 + Rather sparse output (I hate debugging tho

[PATCH v2] spapr/xive: Use the xics flag to check for XIVE-only IRQ backends

2020-08-20 Thread Cédric Le Goater
The sPAPR machine has four different IRQ backends, each implementing the XICS or XIVE interrupt mode or both in the case of the 'dual' backend. If a machine is started in P8 compat mode, QEMU should necessarily support the XICS interrupt mode and in that case, the XIVE-only IRQ backend is invalid.

Re: [PATCH V6] Introduce a new flag for i440fx to disable PCI hotplug on the root bus

2020-08-20 Thread Igor Mammedov
On Thu, 20 Aug 2020 14:51:56 +0530 Ani Sinha wrote: > We introduce a new global flag 'acpi-root-pci-hotplug' for i440fx with which > we can turn on or off PCI device hotplug on the root bus. This flag can be > used to prevent all PCI devices from getting hotplugged or unplugged from the > root PC

Re: [PATCH v1] pc: fix auto_enable_numa_with_memhp/auto_enable_numa_with_memdev for the 5.0 machine

2020-08-20 Thread Igor Mammedov
On Thu, 20 Aug 2020 11:48:28 +0200 David Hildenbrand wrote: > Unfortunately, a typo sneeked in: we want to set > auto_enable_numa_with_memdev to false, not auto_enable_numa_with_memhp. > > Cc: qemu-sta...@nongnu.org # v5.1 > Fixes: 195784a0cfad (numa: Auto-enable NUMA when any memory devices are

Re: deprecation of in-tree builds

2020-08-20 Thread Peter Maydell
On Thu, 20 Aug 2020 at 14:30, Kevin Wolf wrote: > > Am 20.08.2020 um 13:56 hat Paolo Bonzini geschrieben: > > The Meson conversion was announced in October 2019 as breaking in-tree > > builds, and the deprecation request is from March 2020. So I don't > > think this is a breakage but rather a wid

Re: [PATCH v13 00/11] iotests: Dump QCOW2 dirty bitmaps metadata

2020-08-20 Thread Andrey Shinkevich
On 20.08.2020 03:49, Eric Blake wrote: On 8/14/20 6:56 AM, Andrey Shinkevich wrote: Dear Eric! Vladimir has compeated reviewing this series. I have not received any other responses to it so far. So, is it good for pull request now? Would you please consider taking this series as you did it

Re: [RFC PATCH 13/22] block/export: Move refcount from NBDExport to BlockExport

2020-08-20 Thread Kevin Wolf
Am 19.08.2020 um 22:58 hat Eric Blake geschrieben: > On 8/13/20 11:29 AM, Kevin Wolf wrote: > > Having a refcount makes sense for all types of block exports. It is also > > a prerequisite for keeping a list of all exports at the BlockExport > > level. > > > > Signed-off-by: Kevin Wolf > > --- >

Re: [PATCH v4 2/4] iotests.py: Add wait_for_runstate()

2020-08-20 Thread Dr. David Alan Gilbert
* Eric Blake (ebl...@redhat.com) wrote: > On 8/18/20 8:32 AM, Max Reitz wrote: > > Signed-off-by: Max Reitz > > --- > > tests/qemu-iotests/iotests.py | 4 > > 1 file changed, 4 insertions(+) > > Reviewed-by: Eric Blake > > > > > diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-i

Re: [PATCH] qtest: add fuzz test case

2020-08-20 Thread Thomas Huth
On 19/08/2020 16.15, Li Qiang wrote: > Currently the device fuzzer find a more and more issues. > For every fuzz case, we need not only the fixes but also > the coressponding test case. We can analysis the reproducer > for every case and find what happened in where and write > a beautiful test case

Re: [PATCH 02/10] numa: introduce MachineClass::forbid_asymmetrical_numa

2020-08-20 Thread Igor Mammedov
On Thu, 20 Aug 2020 07:33:00 -0300 Daniel Henrique Barboza wrote: > On 8/20/20 1:15 AM, David Gibson wrote: > > On Wed, Aug 19, 2020 at 10:11:28PM -0400, Eduardo Habkost wrote: > >> On Thu, Aug 20, 2020 at 11:17:26AM +1000, David Gibson wrote: > >>> On Fri, Aug 14, 2020 at 05:54:16PM -0300, D

Re: [PATCH v4 2/4] iotests.py: Add wait_for_runstate()

2020-08-20 Thread Vladimir Sementsov-Ogievskiy
20.08.2020 17:23, Dr. David Alan Gilbert wrote: * Eric Blake (ebl...@redhat.com) wrote: On 8/18/20 8:32 AM, Max Reitz wrote: Signed-off-by: Max Reitz --- tests/qemu-iotests/iotests.py | 4 1 file changed, 4 insertions(+) Reviewed-by: Eric Blake diff --git a/tests/qemu-iotests/i

Re: [PULL 3/3] hw: add compat machines for 5.2

2020-08-20 Thread Igor Mammedov
On Wed, 19 Aug 2020 11:22:58 -0400 Eduardo Habkost wrote: > From: Cornelia Huck > > Add 5.2 machine types for arm/i440fx/q35/s390x/spapr. > > Reviewed-by: Andrew Jones > Reviewed-by: Michael S. Tsirkin > Reviewed-by: Greg Kurz > Acked-by: Christian Borntraeger > Acked-by: David Gibson > A

Re: [PULL 3/3] hw: add compat machines for 5.2

2020-08-20 Thread Cornelia Huck
On Thu, 20 Aug 2020 16:35:08 +0200 Igor Mammedov wrote: > On Wed, 19 Aug 2020 11:22:58 -0400 > Eduardo Habkost wrote: > > > From: Cornelia Huck > > > > Add 5.2 machine types for arm/i440fx/q35/s390x/spapr. > > > > Reviewed-by: Andrew Jones > > Reviewed-by: Michael S. Tsirkin > > Reviewed-b

Re: [RFC PATCH 07/22] block/export: Remove magic from block-export-add

2020-08-20 Thread Eric Blake
On 8/20/20 6:05 AM, Kevin Wolf wrote: As long as we can keep the compatibility code local to qmp_nbd_*(), I don't think it's too bad. In particular because it's already written. Instead of adjusting libvirt to changes in the nbd-* commands, I'd rather have it change over to block-export-*. I wo

Re: [PULL 3/3] hw: add compat machines for 5.2

2020-08-20 Thread Igor Mammedov
On Thu, 20 Aug 2020 16:35:08 +0200 Igor Mammedov wrote: > On Wed, 19 Aug 2020 11:22:58 -0400 > Eduardo Habkost wrote: > > > From: Cornelia Huck > > > > Add 5.2 machine types for arm/i440fx/q35/s390x/spapr. > > > > Reviewed-by: Andrew Jones > > Reviewed-by: Michael S. Tsirkin > > Reviewed-b

[Bug 1883984] Re: QEMU S/390x sqxbr (128-bit IEEE 754 square root) crashes qemu-system-s390x

2020-08-20 Thread Thomas Huth
** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1883984 Title: QEMU S/390x sqxbr (128-bit IEEE 754 square root) crashes qemu-system-

[Bug 1885720] Re: qemu/migration/postcopy-ram.c:387: bad return expression ?

2020-08-20 Thread Thomas Huth
** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1885720 Title: qemu/migration/postcopy-ram.c:387: bad return expression ? Status in Q

[Bug 1886318] Re: Qemu after v5.0.0 breaks macos guests

2020-08-20 Thread Thomas Huth
Patch has been included here: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=dba04c3488c4699f5 ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/18

[Bug 1874073] Re: openrisc_sim.c:87:42: error: 'cpu_irqs[0]' may be used uninitialized in this function [-Werror=maybe-uninitialized]

2020-08-20 Thread Thomas Huth
** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1874073 Title: openrisc_sim.c:87:42: error: 'cpu_irqs[0]' may be used uninitialized

[Bug 1856706] Re: target/mips/op_helper.c:971:duplicated branches ?

2020-08-20 Thread Thomas Huth
Patch has been included here: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=9788e8c9b64e4cebb01 ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/

[Bug 1880822] Re: CVE-2020-13253 QEMU: sd: OOB access could crash the guest resulting in DoS

2020-08-20 Thread Thomas Huth
** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1880822 Title: CVE-2020-13253 QEMU: sd: OOB access could crash the guest resulting in

Re: [PULL v7 000/151] Meson-based build system

2020-08-20 Thread Peter Maydell
On Thu, 20 Aug 2020 at 12:52, Paolo Bonzini wrote: > > On 20/08/20 12:33, Peter Maydell wrote: > > 'make check' still fails for the all-linux-static config, this > > time for a different reason: > > > > make: *** No rule to make target 'check-qtest', needed by 'check'. Stop. > > Oh, there are two

[PATCH v3 1/7] x86: lpc9: let firmware negotiate 'CPU hotplug with SMI' features

2020-08-20 Thread Igor Mammedov
It will allow firmware to notify QEMU that firmware requires SMI being triggered on CPU hot[un]plug, so that it would be able to account for hotplugged CPU and relocate it to new SMM base and/or safely remove CPU on unplug. Using negotiated features, follow up patches will insert SMI upcall into A

Re: [PATCH v4 2/4] iotests.py: Add wait_for_runstate()

2020-08-20 Thread Max Reitz
On 20.08.20 16:34, Vladimir Sementsov-Ogievskiy wrote: > 20.08.2020 17:23, Dr. David Alan Gilbert wrote: >> * Eric Blake (ebl...@redhat.com) wrote: >>> On 8/18/20 8:32 AM, Max Reitz wrote: Signed-off-by: Max Reitz ---    tests/qemu-iotests/iotests.py | 4    1 file changed,

  1   2   3   >