Generated using:
$ ./scripts/codeconverter/converter.py -i \
--pattern=QOMDuplicatedTypedefs $(git grep -l '' -- '*.[ch]')
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Eduardo Habkost
---
Changes v1 -> v2: none
---
include/crypto/secret_keyring.h | 8
1 file changed, 4 insertion
This will make future conversion to OBJECT_DECLARE* easier.
Signed-off-by: Eduardo Habkost
---
Changes series v1 -> v2: new patch in series v2
Cc: Laurent Vivier
Cc: Amit Shah
Cc: "Michael S. Tsirkin"
Cc: "Marc-André Lureau"
Cc: Paolo Bonzini
Cc: qemu-devel@nongnu.org
---
include/hw/virtio
The TYPE_* constants and the typedefs are defined in ahci.h, so
we can move the type checking macros there too.
This will make future conversion to OBJECT_DECLARE* easier.
Signed-off-by: Eduardo Habkost
---
Changes series v1 -> v2: new patch in series v2
Cc: John Snow
Cc: qemu-bl...@nongnu.org
From: Daniel P. Berrangé
This introduces the use of the OBJECT_DEFINE and OBJECT_DECLARE macro
families in the secret types, in order to eliminate boilerplate code.
Signed-off-by: Daniel P. Berrangé
Message-Id: <20200723181410.3145233-4-berra...@redhat.com>
[ehabkost: rebase, update to pass add
This will make future conversion to OBJECT_DECLARE* easier.
Signed-off-by: Eduardo Habkost
---
Changes series v1 -> v2: new patch in series v2
Cc: Jiri Pirko
Cc: Jason Wang
Cc: qemu-devel@nongnu.org
---
hw/net/rocker/rocker.h | 6 +-
hw/net/rocker/rocker.c | 5 -
2 files changed, 5 in
Move the I8042 macro close to the TYPE_I8042 define.
This will make future conversion to OBJECT_DECLARE* easier.
Signed-off-by: Eduardo Habkost
---
Changes series v1 -> v2: new patch in series v2
Cc: "Michael S. Tsirkin"
Cc: Paolo Bonzini
Cc: qemu-devel@nongnu.org
---
include/hw/input/i8042.
Move all declarations related to TYPE_VMBUS to the same place in
vmbus.h.
This will make future conversion to OBJECT_DECLARE* easier.
Signed-off-by: Eduardo Habkost
---
Changes series v1 -> v2: new patch in series v2
Cc: qemu-devel@nongnu.org
---
include/hw/hyperv/vmbus-bridge.h | 3 +--
inclu
Many QOM types don't follow the Type/TypeClass pattern
on the instance/struct names. Let the class struct name
be specified in the OBJECT_DECLARE* macros.
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Eduardo Habkost
---
Changes v1 -> v2: none
---
include/qom/object.h | 35 ++-
This will make future conversion to OBJECT_DECLARE* easier.
Signed-off-by: Eduardo Habkost
---
Changes series v1 -> v2: new patch in series v2
Cc: Andrzej Zaborowski
Cc: Peter Maydell
Cc: qemu-...@nongnu.org
Cc: qemu-devel@nongnu.org
---
include/hw/arm/pxa.h | 13 +
hw/arm/pxa2xx.
Generated using:
$ ./scripts/codeconverter/converter.py -i \
--pattern=ObjectDeclareType $(git grep -l '' -- '*.[ch]')
Signed-off-by: Eduardo Habkost
---
Changes v1 -> v2: none
---
include/authz/list.h| 7 ++-
include/authz/listfile.h| 7 ++-
include/auth
v7:
* removed accidental inclusion of spice-input changes
Geoffrey McRae (1):
audio/jack: fix use after free segfault
audio/jackaudio.c | 51 +--
ui/spice-input.c | 2 ++
2 files changed, 38 insertions(+), 15 deletions(-)
--
2.20.1
This started as a simple script that scanned for regular
expressions, but became more and more complex when exceptions to
the rules were found.
I don't know if this should be maintained in the QEMU source tree
long term (maybe it can be reused for other code transformations
that Coccinelle can't h
The existing type check macros all unconditionally drop const
qualifiers from their arguments. Keep this behavior in the
macros generated by DECLARE_*CHECKER* by now.
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Eduardo Habkost
---
Changes v1 -> v2:
* Remo
This change registers a bottom handler to close the JACK client
connection when a server shutdown signal is recieved. Without this
libjack2 attempts to "clean up" old clients and causes a use after free
segfault.
Signed-off-by: Geoffrey McRae
---
audio/jackaudio.c | 51 ++
Replace DECLARE_OBJ_CHECKERS with OBJECT_DECLARE_TYPE where the
typedefs can be safely removed.
Generated running:
$ ./scripts/codeconverter/converter.py -i \
--pattern=DeclareObjCheckers $(git grep -l '' -- '*.[ch]')
Signed-off-by: Eduardo Habkost
---
Changes v1 -> v2:
* Script re-run after
From: Daniel P. Berrangé
This introduces the use of the OBJECT_DEFINE and OBJECT_DECLARE macro
families in the TLS creds types, in order to eliminate boilerplate code.
Signed-off-by: Daniel P. Berrangé
Message-Id: <20200723181410.3145233-5-berra...@redhat.com>
[ehabkost: rebase, update to pass
Provide a TYPE_INFO macro that can be used to register a TypeInfo
struct declaratively. This will allow QOM type registration to
be 100% declarative.
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Eduardo Habkost
---
Changes v1 -> v2: none
---
include/qom/object.h | 15 +--
1 file
From: Daniel P. Berrangé
When creating new QOM types, there is a lot of boilerplate code that
must be repeated using a standard pattern. This is tedious to write
and liable to suffer from subtle inconsistencies. Thus it would
benefit from some simple automation.
QOM was loosely inspired by GLib'
CCing everybody who replied to the v1 thread. I've CCed people
on individual patches using get_maintainer.pl, but forgot to CC
people from the v1 thread (sorry!).
On Wed, Aug 19, 2020 at 08:11:38PM -0400, Eduardo Habkost wrote:
> This is an extension of the series previously submitted by
> Daniel
This change registers a bottom handler to close the JACK client
connection when a server shutdown signal is recieved. Without this
libjack2 attempts to "clean up" old clients and causes a use after free
segfault.
Signed-off-by: Geoffrey McRae
---
audio/jackaudio.c | 51 ++
On 8/14/20 6:56 AM, Andrey Shinkevich wrote:
Dear Eric!
Vladimir has compeated reviewing this series. I have not received any
other responses to it so far.
So, is it good for pull request now? Would you please consider taking
this series as you did it with the Vladimir's related one?
I've
v6:
* delete the QEMUBH when finished
* fix possible race by taking the iothread mutex
* removed whitespace changes
Geoffrey McRae (1):
audio/jack: fix use after free segfault
audio/jackaudio.c | 51 +--
ui/spice-input.c | 2 ++
2 files chang
Forgot to update this cover letter too, sorry for the spam, there are no
changes to spice-input.c anymore
On 2020-08-20 10:27, Geoffrey McRae wrote:
v7:
* removed accidental inclusion of spice-input changes
Geoffrey McRae (1):
audio/jack: fix use after free segfault
audio/jackaudio.c | 5
On Wed, Aug 19, 2020 at 11:50:21AM -0600, Alex Williamson wrote:
<...>
> > > > > What I care about is that we have a *standard* userspace API for
> > > > > performing device compatibility checking / state migration, for use by
> > > > > QEMU/libvirt/ OpenStack, such that we can write code without c
Patchew URL:
https://patchew.org/QEMU/20200820001236.1284548-1-ehabk...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20200820001236.1284548-1-ehabk...@redhat.com
Subject: [PATCH v2 00/58] qom: Automated c
On Tue, Aug 18, 2020 at 11:36:52AM +0200, Cornelia Huck wrote:
> On Tue, 18 Aug 2020 10:16:28 +0100
> Daniel P. Berrangé wrote:
>
> > On Tue, Aug 18, 2020 at 05:01:51PM +0800, Jason Wang wrote:
> > >On 2020/8/18 下午4:55, Daniel P. Berrangé wrote:
> > >
> > > On Tue, Aug 18, 2020 at 11:24:30A
On Sun, Aug 16, 2020 at 03:38:20PM +0200, Cédric Le Goater wrote:
> On 8/16/20 6:30 AM, David Gibson wrote:
> > On Fri, Aug 14, 2020 at 05:08:13PM +0200, Cédric Le Goater wrote:
> >>
> >> This works as expected with a 128 vCPUs guest with pinned vcpus. The
> >> first 64 IPIs are allocated on the fi
On Wed, Aug 19, 2020 at 03:08:37PM +0200, Cédric Le Goater wrote:
> To be sent with the linux-headers update when support is merged.
Ah, so this isn't ready to go just yet.
>
> Signed-off-by: Cédric Le Goater
> ---
> linux-headers/asm-powerpc/kvm.h | 8
> 1 file changed, 8 insertions(
On Wed, Aug 19, 2020 at 03:08:36PM +0200, Cédric Le Goater wrote:
> On POWER9, the KVM XIVE device uses priority 7 for the escalation
> interrupts. On POWER10, the host can use a reduced set of priorities
> and KVM will configure the escalation priority to a lower number. In
> any case, the guest i
Patchew URL:
https://patchew.org/QEMU/20200820001236.1284548-1-ehabk...@redhat.com/
Hi,
This series failed the docker-mingw@fedora build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN =
Patchew URL:
https://patchew.org/QEMU/20200820001236.1284548-1-ehabk...@redhat.com/
Hi,
This series failed the docker-quick@centos7 build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN
On 8/18/20 8:32 AM, Max Reitz wrote:
This migration parameter allows mapping block node names and bitmap
names to aliases for the purpose of block dirty bitmap migration.
This way, management tools can use different node and bitmap names on
the source and destination and pass the mapping of how
On 8/18/20 8:32 AM, Max Reitz wrote:
Signed-off-by: Max Reitz
---
tests/qemu-iotests/iotests.py | 4
1 file changed, 4 insertions(+)
Reviewed-by: Eric Blake
diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
index 717b5b652c..ee93cf22db 100644
--- a/tests/qe
On 8/18/20 8:32 AM, Max Reitz wrote:
Let wait_migration() return on failure (with the return value indicating
whether the migration was completed or has failed), so we can use it for
migrations that are expected to fail, too.
Signed-off-by: Max Reitz
---
tests/qemu-iotests/iotests.py | 18 +++
Alexander Bulekov 于2020年8月20日周四 上午12:23写道：
>
> On 200819 2250, Li Qiang wrote:
> > Philippe Mathieu-Daudé 于2020年8月19日周三 下午10:38写道：
> >
> > > On 8/19/20 4:15 PM, Li Qiang wrote:
> > > > Currently the device fuzzer find a more and more issues.
> > > > For every fuzz case, we need not only the fixes
Philippe Mathieu-Daudé 于2020年8月19日周三 下午11:07写道：
>
> On 8/19/20 4:43 PM, Li Qiang wrote:
> > If g_malloc fails, the application will be terminated.
>
> Which we don't want... better to use g_try_malloc() instead?
I don't think so. If g_malloc return NULL it means a critical
situation I think termi
On Thu, 2020-08-20 at 08:39 +0800, Yan Zhao wrote:
> On Tue, Aug 18, 2020 at 11:36:52AM +0200, Cornelia Huck wrote:
> > On Tue, 18 Aug 2020 10:16:28 +0100
> > Daniel P. Berrangé wrote:
> >
> > > On Tue, Aug 18, 2020 at 05:01:51PM +0800, Jason Wang wrote:
> > > >On 2020/8/18 下午4:55, Daniel P.
On 7/27/20 7:59 AM, Vladimir Sementsov-Ogievskiy wrote:
27.07.2020 15:48, Stefan Hajnoczi wrote:
On Wed, Jun 10, 2020 at 01:03:29PM +0300, Vladimir Sementsov-Ogievskiy
wrote:
Hi all!
The aim of the series is to reduce code-duplication and writing
parameters structure-packing by hand around cor
On Wed, Aug 19, 2020 at 03:08:42PM +0200, Cédric Le Goater wrote:
I can see why this is a good idea, but it really needs a rationale in
the comment for posterity.
> Signed-off-by: Cédric Le Goater
> ---
> hw/ppc/spapr_irq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
On Fri, Aug 14, 2020 at 05:54:16PM -0300, Daniel Henrique Barboza wrote:
> The pSeries machine does not support asymmetrical NUMA
> configurations.
This seems a bit oddly specific to have as a global machine class
property.
Would it make more sense for machines with specific NUMA constraints
to j
On Wed, Aug 19, 2020 at 03:08:38PM +0200, Cédric Le Goater wrote:
> When running a guest with a kernel IRQ chip enabled, the XIVE
> characteristics of the interrupts are advertised to the guest in the
> H_INT_GET_SOURCE_INFO hcall. These characteristics depend on the
> underlying HW interrupts but
On Wed, Aug 19, 2020 at 01:42:58PM -0300, Thiago Jung Bauermann wrote:
> This version has one small fix in patch 7, and adds Philippe's Reviewed-bys.
>
> Applies cleanly on dgibson/ppc-for-5.2.
>
> Original cover letter below, followed by changelog:
>
>
> The ARM code has a start-powered-off pr
On Tue, Aug 11, 2020 at 8:26 PM Havard Skinnemoen
wrote:
>
> On Tue, Aug 11, 2020 at 1:48 AM Philippe Mathieu-Daudé
> wrote:
> > INTERRUPTED: Test interrupted by SIGTERM
> > Runner error occurred: Timeout reached
> > (240.45 s)
> >
> > Is that expected?
>
> I'm not sure why it only happens when
On 8/18/20 8:32 AM, Max Reitz wrote:
Signed-off-by: Max Reitz
---
tests/qemu-iotests/300 | 595 +
tests/qemu-iotests/300.out | 5 +
Rather sparse output (I hate debugging those sorts of outputs when the
test is failing).
tests/qemu-iotests/grou
David Gibson writes:
> On Wed, Aug 19, 2020 at 01:42:58PM -0300, Thiago Jung Bauermann wrote:
>> This version has one small fix in patch 7, and adds Philippe's Reviewed-bys.
>>
>> Applies cleanly on dgibson/ppc-for-5.2.
>>
>> Original cover letter below, followed by changelog:
>>
>>
>> The
On Thu, Aug 20, 2020 at 11:17:26AM +1000, David Gibson wrote:
> On Fri, Aug 14, 2020 at 05:54:16PM -0300, Daniel Henrique Barboza wrote:
> > The pSeries machine does not support asymmetrical NUMA
> > configurations.
>
> This seems a bit oddly specific to have as a global machine class
> property.
On 2020/8/19 下午11:50, Peter Xu wrote:
On Wed, Aug 19, 2020 at 03:15:26PM +0800, Jason Wang wrote:
Yes, actually, I feel confused after reading the codes. Is notifier->start
IOVA or GPA?
In vfio.c, we did:
iommu_notifier_init(&giommu->n, vfio_iommu_map_notify,
On Thu, 20 Aug 2020 08:18:10 +0800
Yan Zhao wrote:
> On Wed, Aug 19, 2020 at 11:50:21AM -0600, Alex Williamson wrote:
> <...>
> > > > > > What I care about is that we have a *standard* userspace API for
> > > > > > performing device compatibility checking / state migration, for use
> > > > > > b
On Thu, 20 Aug 2020 08:39:22 +0800
Yan Zhao wrote:
> On Tue, Aug 18, 2020 at 11:36:52AM +0200, Cornelia Huck wrote:
> > On Tue, 18 Aug 2020 10:16:28 +0100
> > Daniel P. Berrangé wrote:
> >
> > > On Tue, Aug 18, 2020 at 05:01:51PM +0800, Jason Wang wrote:
> > > >On 2020/8/18 下午4:55, Dani
On Wed, Aug 19, 2020 at 09:13:45PM -0600, Alex Williamson wrote:
> On Thu, 20 Aug 2020 08:18:10 +0800
> Yan Zhao wrote:
>
> > On Wed, Aug 19, 2020 at 11:50:21AM -0600, Alex Williamson wrote:
> > <...>
> > > > > > > What I care about is that we have a *standard* userspace API for
> > > > > > > per
On Wed, Aug 19, 2020 at 09:22:34PM -0600, Alex Williamson wrote:
> On Thu, 20 Aug 2020 08:39:22 +0800
> Yan Zhao wrote:
>
> > On Tue, Aug 18, 2020 at 11:36:52AM +0200, Cornelia Huck wrote:
> > > On Tue, 18 Aug 2020 10:16:28 +0100
> > > Daniel P. Berrangé wrote:
> > >
> > > > On Tue, Aug 18, 2
On Fri, Aug 14, 2020 at 05:54:18PM -0300, Daniel Henrique Barboza wrote:
> The changes to come to NUMA support are all guest visible. In
> theory we could just create a new 5_1 class option flag to
> avoid the changes to cascade to 5.1 and under. The reality is that
> these changes are only relevan
On Fri, Aug 14, 2020 at 05:54:17PM -0300, Daniel Henrique Barboza wrote:
> NVLink2 GPUs are allocated in their own NUMA node, at maximum
> distance from every other resource in the board. The existing
> logic makes some assumptions that don't scale well:
>
> - only NVLink2 GPUs will ever require s
On Fri, Aug 14, 2020 at 05:54:19PM -0300, Daniel Henrique Barboza wrote:
> The ibm,max-associativity-domains is considering that only a single
> associativity domain can exist in the same NUMA level. This is true
> today because we do not support any type of NUMA distance user
> customization, and
On Fri, Aug 14, 2020 at 05:54:21PM -0300, Daniel Henrique Barboza wrote:
> We have several places around hw/ppc files where we use the
> same code to set the ibm,associativity array. This patch
> creates a helper called spapr_set_associativity() to do
> that in a single place. It'll also make it sa
On Thu, Aug 20, 2020 at 02:29:07AM +0100, Sean Mooney wrote:
> On Thu, 2020-08-20 at 08:39 +0800, Yan Zhao wrote:
> > On Tue, Aug 18, 2020 at 11:36:52AM +0200, Cornelia Huck wrote:
> > > On Tue, 18 Aug 2020 10:16:28 +0100
> > > Daniel P. Berrangé wrote:
> > >
> > > > On Tue, Aug 18, 2020 at 05:01
On Fri, Aug 14, 2020 at 05:54:22PM -0300, Daniel Henrique Barboza wrote:
> We can't use the input from machine->numa_state->nodes directly
> in the pSeries machine because PAPR does not work with raw distance
> values, like ACPI SLIT does. We need to determine common
> associativity domains, based
On Wed, Aug 19, 2020 at 10:11:28PM -0400, Eduardo Habkost wrote:
> On Thu, Aug 20, 2020 at 11:17:26AM +1000, David Gibson wrote:
> > On Fri, Aug 14, 2020 at 05:54:16PM -0300, Daniel Henrique Barboza wrote:
> > > The pSeries machine does not support asymmetrical NUMA
> > > configurations.
> >
> > T
On Thu, 2020-08-20 at 12:01 +0800, Yan Zhao wrote:
> On Thu, Aug 20, 2020 at 02:29:07AM +0100, Sean Mooney wrote:
> > On Thu, 2020-08-20 at 08:39 +0800, Yan Zhao wrote:
> > > On Tue, Aug 18, 2020 at 11:36:52AM +0200, Cornelia Huck wrote:
> > > > On Tue, 18 Aug 2020 10:16:28 +0100
> > > > Daniel P.
>> Hi team,
>>
>> Lately, I have been working on QEMU modeling and interfacing it into the
>> existing platform. What actually I wanted to check is; whether QEMU
>> supports library that gives developers a clean interface to develop and
>> integrate peripheral model in to QEMU. I know of the Greens
+Eric / Richard for compiler optimizations.
On 8/20/20 3:53 AM, Havard Skinnemoen wrote:
> On Tue, Aug 11, 2020 at 8:26 PM Havard Skinnemoen
> wrote:
>>
>> On Tue, Aug 11, 2020 at 1:48 AM Philippe Mathieu-Daudé
>> wrote:
>>> INTERRUPTED: Test interrupted by SIGTERM
>>> Runner error occurred: Ti
Hi,
> > +qemu_bh_cancel(c->shutdown_bh);
>
> Looks like a potential race. Quote from the API doc of qemu_bh_cancel():
>
> "While cancellation itself is also wait-free and thread-safe, it can of
>
> course race with the loop that executes bottom halves unless you are
On 8/20/20 7:29 AM, Philippe Mathieu-Daudé wrote:
> +Eric / Richard for compiler optimizations.
>
> On 8/20/20 3:53 AM, Havard Skinnemoen wrote:
>> On Tue, Aug 11, 2020 at 8:26 PM Havard Skinnemoen
>> wrote:
>>>
>>> On Tue, Aug 11, 2020 at 1:48 AM Philippe Mathieu-Daudé
>>> wrote:
INTERRUP
On Wed, Aug 19, 2020 at 08:12:07PM -0400, Eduardo Habkost wrote:
> Move the VHOST_USER_GPU type checking macro to virtio-gpu.h,
> close to the TYPE_VHOST_USER_GPU #define.
>
> This will make future conversion to OBJECT_DECLARE* easier.
>
> Signed-off-by: Eduardo Habkost
Reviewed-by: Gerd Hoffma
On 8/20/20 2:11 AM, Eduardo Habkost wrote:
> Some of the enum constant names conflict with the QOM type check
> macros:
>
> ASPEED_GPIO
> ASPEED_I2C
> ASPEED_RTC
> ASPEED_SCU
> ASPEED_SDHCI
> ASPEED_SDMC
> ASPEED_VIC
> ASPEED_WDT
> ASPEED_XDMA
>
> This needs to be addressed to allow us to transfo
On 8/20/20 2:11 AM, Eduardo Habkost wrote:
> The macro definition had an extra semicolon. This was never
> noticed because the macro was only being used where it didn't
> make a difference.
>
> Reviewed-by: Philippe Mathieu-Daudé
> Reviewed-by: Daniel P. Berrangé
> Signed-off-by: Eduardo Habkos
On Thu, Aug 20, 2020 at 06:16:28AM +0100, Sean Mooney wrote:
> On Thu, 2020-08-20 at 12:01 +0800, Yan Zhao wrote:
> > On Thu, Aug 20, 2020 at 02:29:07AM +0100, Sean Mooney wrote:
> > > On Thu, 2020-08-20 at 08:39 +0800, Yan Zhao wrote:
> > > > On Tue, Aug 18, 2020 at 11:36:52AM +0200, Cornelia Huck
On 8/20/20 2:42 AM, David Gibson wrote:
> On Sun, Aug 16, 2020 at 03:38:20PM +0200, Cédric Le Goater wrote:
>> On 8/16/20 6:30 AM, David Gibson wrote:
>>> On Fri, Aug 14, 2020 at 05:08:13PM +0200, Cédric Le Goater wrote:
This works as expected with a 128 vCPUs guest with pinned vcpus. The
On 8/20/20 2:58 AM, David Gibson wrote:
> On Wed, Aug 19, 2020 at 03:08:37PM +0200, Cédric Le Goater wrote:
>> To be sent with the linux-headers update when support is merged.
>
> Ah, so this isn't ready to go just yet.
No indeed. We should get the QEMU part correct first, and handle
safely the
Hi all,
I've been playing a bit with the usb-serial device recently and found it
surprisingly
difficult to make it visible within the guest. As an example my first test was
to
simply plug the device into the guest USB and verify that the drivers could
identify
the device:
$ ./qemu-system-ppc -
301 - 370 of 370 matches
Mail list logo
