Re: [PATCH] audio/jack: fix use after free segfault

2020-08-19 Thread Christian Schoenebeck
On Mittwoch, 19. August 2020 13:45:33 CEST Geoffrey McRae wrote: > > I still don't quite get how this correlates. So you are forcing a > > restart of > > jackd on host side in between, for what purpose? To simulate the > > Windows > > client being kicked by jackd? > > For many reasons jack may nee

Re: [PATCH] audio/jack: fix use after free segfault

2020-08-19 Thread Geoffrey McRae
On 2020-08-19 22:41, Christian Schoenebeck wrote: On Mittwoch, 19. August 2020 13:45:33 CEST Geoffrey McRae wrote: > I still don't quite get how this correlates. So you are forcing a > restart of > jackd on host side in between, for what purpose? To simulate the > Windows > client being kicke

Re: [PATCH v6 2/7] hw: add 5.2 machine types and 5.1 compat options

2020-08-19 Thread Igor Mammedov
On Tue, 18 Aug 2020 17:11:32 +0200 Cornelia Huck wrote: > On Tue, 18 Aug 2020 15:33:43 +0100 > Stefan Hajnoczi wrote: > > > arm, i386, ppc, and s390x have versioned machine types and associated > > compatibility options. Introduce new ones now that QEMU 5.1 has been > > released. > > > > Signe

[PULL v5 000/150] Meson-based build system

2020-08-19 Thread Paolo Bonzini
The following changes since commit d0ed6a69d399ae193959225cdeaa9382746c91cc: Update version for v5.1.0 release (2020-08-11 17:07:03 +0100) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for-upstream for you to fetch changes up to 216b1454cd639285f13775b0ea9

Re: [PATCH v6 2/7] hw: add 5.2 machine types and 5.1 compat options

2020-08-19 Thread Igor Mammedov
On Tue, 18 Aug 2020 15:33:43 +0100 Stefan Hajnoczi wrote: > arm, i386, ppc, and s390x have versioned machine types and associated > compatibility options. Introduce new ones now that QEMU 5.1 has been > released. > > Signed-off-by: Stefan Hajnoczi Reviewed-by: Igor Mammedov > --- > include/

[PATCH 5/8] spapr/xive: Enforce the load-after-store ordering

2020-08-19 Thread Cédric Le Goater
The XIVE_ESB_SET_PQ_10 load operation is used to disable temporarily an interrupt source. If StoreEOI is active, a source could be left enabled if the load and store operations come out of order. QEMU makes use of this offset to quiesce the sources before a migration. Enforce the load-after-store

[PATCH 0/8] spapr/xive: Activate StoreEOI in P10 compat guests

2020-08-19 Thread Cédric Le Goater
Hello, The first patch is a little improvement on how we deal with priorities reserved by the hypervisor. The rest is about activating StoreEOI safely on a host supporting it, P10 hosts are the target but experimental P9 firmwares activate also StoreEOI. The patchset adds a new KVM device command

[PATCH 1/8] spapr/xive: Add a 'hv-prio' property to represent the KVM escalation priority

2020-08-19 Thread Cédric Le Goater
On POWER9, the KVM XIVE device uses priority 7 for the escalation interrupts. On POWER10, the host can use a reduced set of priorities and KVM will configure the escalation priority to a lower number. In any case, the guest is allowed to use priorities in a single range : [ 0 .. (maxprio - 1)

[PATCH 2/8] linux-headers: Update for KVM_DEV_XIVE_GRP_SOURCE_INFO

2020-08-19 Thread Cédric Le Goater
To be sent with the linux-headers update when support is merged. Signed-off-by: Cédric Le Goater --- linux-headers/asm-powerpc/kvm.h | 8 1 file changed, 8 insertions(+) diff --git a/linux-headers/asm-powerpc/kvm.h b/linux-headers/asm-powerpc/kvm.h index 264e266a85bf..aeb8e8c4633b 1006

[PATCH 3/8] spapr/xive: Query the characteristics of a source in KVM

2020-08-19 Thread Cédric Le Goater
When running a guest with a kernel IRQ chip enabled, the XIVE characteristics of the interrupts are advertised to the guest in the H_INT_GET_SOURCE_INFO hcall. These characteristics depend on the underlying HW interrupts but today, QEMU simply advertises its own without checking what the host suppo

[PATCH 4/8] spapr/xive: Activate StoreEOI for POWER10 only

2020-08-19 Thread Cédric Le Goater
The StoreEOI features is safe to use with a P10 compat machine but not with P9 compat, as it can not be migrated to a P9 host. Introdude a "hw-storeeoi" property in the SpaprXive model to check for the availability of StoreEOI at the HW level when a kernel IRQ chip is in use. XIVE emulated is not

[PATCH 6/8] spapr/xive: Activate StoreEOI by default

2020-08-19 Thread Cédric Le Goater
Now that we check the XIVE characteristics of the sources at the KVM level, we can configure the sources to use StoreEOI by default. This feature will be activated for the emulated mode and possibly for KVM also if compatible. Signed-off-by: Cédric Le Goater --- hw/intc/spapr_xive.c | 2 ++ hw/i

[PATCH 7/8] spapr/xive: Use the xics flag to check for XIVE-only IRQ backends

2020-08-19 Thread Cédric Le Goater
Signed-off-by: Cédric Le Goater --- hw/ppc/spapr_irq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ppc/spapr_irq.c b/hw/ppc/spapr_irq.c index 80cf1c3d6bb2..d036c8fef519 100644 --- a/hw/ppc/spapr_irq.c +++ b/hw/ppc/spapr_irq.c @@ -172,7 +172,7 @@ static int spapr_irq_che

[PATCH 8/8] spapr/xive: Introduce a XIVE StoreEOI IRQ backend

2020-08-19 Thread Cédric Le Goater
As it is still useful to run a P9 compat guest with StoreEOI enabled, introduce a new IRQ backend to allow that. May be we should add a migration blocker. Signed-off-by: Cédric Le Goater --- include/hw/ppc/spapr_irq.h | 1 + hw/ppc/spapr.c | 6 +- hw/ppc/spapr_irq.c | 1

Re: [PATCH v7 14/47] stream: Deal with filters

2020-08-19 Thread Vladimir Sementsov-Ogievskiy
19.08.2020 15:39, Max Reitz wrote: On 10.08.20 13:04, Vladimir Sementsov-Ogievskiy wrote: 10.08.2020 11:12, Max Reitz wrote: On 07.08.20 12:29, Vladimir Sementsov-Ogievskiy wrote: [...] But, with our proposed way (freeze only chain up to base_overlay inclusively, and use backing(base_overla

Re: [PATCH] audio/jack: fix use after free segfault

2020-08-19 Thread Gerd Hoffmann
Hi, > Even still this is clearly a design flaw in the Jack2 library. Agreeing here. Bugs in apps should be fixed in apps. It isn't the libraries business to workaround them. take care, Gerd

How to access structure elements of another Qdev device

2020-08-19 Thread Anirudha Kurhade
Hello, I have two qdev devices: controlDev and uart. Both these devices have an MMIO and corresponding .read and .write callback functions. The enableBit for uart is located in the controlDev device, so I need to check the enable bit before I write anything from the uart tx function. However, I a

Re: [PATCH v5 01/14] cpu-timers, icount: new modules

2020-08-19 Thread Claudio Fontana
Hello Richard, On 8/14/20 10:20 PM, Richard Henderson wrote: > On 8/12/20 11:32 AM, Claudio Fontana wrote: >> +/* >> + * Return the icount enablement state: >> + * >> + * 0 = Disabled - Do not count executed instructions. >> + * 1 = Enabled - Fixed conversion of insn to ns via "shift" option >> +

Re: [PATCH v5 02/14] cpus: prepare new CpusAccel cpu accelerator interface

2020-08-19 Thread Claudio Fontana
Hello Richard, On 8/14/20 10:28 PM, Richard Henderson wrote: > On 8/12/20 11:32 AM, Claudio Fontana wrote: >> uint64_t cpu_get_tsc(CPUX86State *env) >> { >> -return cpu_get_ticks(); >> +return cpus_get_elapsed_ticks(); > > What has this change got to do with creating the interface? > Yo

Re: [PATCH v5 03/14] cpus: extract out TCG-specific code to accel/tcg

2020-08-19 Thread Claudio Fontana
On 8/14/20 10:39 PM, Richard Henderson wrote: > On 8/12/20 11:32 AM, Claudio Fontana wrote: >> +static int64_t tcg_get_virtual_clock(void) >> +{ >> +if (icount_enabled()) { >> +return icount_get(); >> +} >> +return cpu_get_clock(); >> +} >> + >> +static int64_t tcg_get_elapsed_t

Re: [PATCH v5 10/14] cpus: add handle_interrupt to the CpusAccel interface

2020-08-19 Thread Claudio Fontana
On 8/14/20 11:01 PM, Richard Henderson wrote: > On 8/12/20 11:32 AM, Claudio Fontana wrote: >> +static void generic_handle_interrupt(CPUState *cpu, int mask) >> +{ >> +cpu->interrupt_request |= mask; >> + >> +if (!qemu_cpu_is_self(cpu)) { >> +qemu_cpu_kick(cpu); >> +} >> +} >> +

Re: guest agent public ssh key add/remove support?

2020-08-19 Thread David Vossel
On Tue, Aug 18, 2020 at 3:10 PM Christian Schoenebeck < qemu_...@crudebyte.com> wrote: > On Dienstag, 18. August 2020 15:25:56 CEST David Vossel wrote: > > - Guest Agent SSH add/remove Support? > > > > As a PoC, I cobbled together some guest agent exec and file write client > > commands which can

Re: [PATCH-for-5.2] memory: Add trace events to audit MemoryRegionOps fields

2020-08-19 Thread Stefan Hajnoczi
On Wed, Aug 19, 2020 at 12:10:20PM +0200, Philippe Mathieu-Daudé wrote: > But for now I'm not sure the check has to be enforced, because I'm not > sure what we really want to do. First we need to figure out the 'bus' > component of a a MemoryRegion (where it sits), as it affects the > MemoryRegionO

Re: [PATCH v6 2/7] hw: add 5.2 machine types and 5.1 compat options

2020-08-19 Thread Cornelia Huck
On Wed, 19 Aug 2020 14:54:25 +0200 Igor Mammedov wrote: > On Tue, 18 Aug 2020 17:11:32 +0200 > Cornelia Huck wrote: > > > On Tue, 18 Aug 2020 15:33:43 +0100 > > Stefan Hajnoczi wrote: > > > > > arm, i386, ppc, and s390x have versioned machine types and associated > > > compatibility options

Re: [RFC PATCH 0/9] block/curl: Add caching of data downloaded from the remote server

2020-08-19 Thread Stefan Hajnoczi
On Tue, Aug 18, 2020 at 12:08:36PM +0100, David Edmondson wrote: > When using qemu-img to convert an image that is hosted on an HTTP > server to some faster local (or pseudo-local) storage, the overall > performance can be improved by reading data from the HTTP server in > larger blocks and by cach

Re: [PATCH v6 2/7] hw: add 5.2 machine types and 5.1 compat options

2020-08-19 Thread Stefan Hajnoczi
On Tue, Aug 18, 2020 at 05:11:32PM +0200, Cornelia Huck wrote: > On Tue, 18 Aug 2020 15:33:43 +0100 > Stefan Hajnoczi wrote: > > > arm, i386, ppc, and s390x have versioned machine types and associated > > compatibility options. Introduce new ones now that QEMU 5.1 has been > > released. > > > >

Re: [PATCH v6 1/7] Open 5.2 development tree

2020-08-19 Thread Stefan Hajnoczi
On Tue, Aug 18, 2020 at 03:33:42PM +0100, Stefan Hajnoczi wrote: > From: Peter Maydell > > Signed-off-by: Peter Maydell > --- > VERSION | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/VERSION b/VERSION > index 831446cbd2..7d40cb9d36 100644 > --- a/VERSION > +++ b/VERSI

[PATCH] qtest: add fuzz test case

2020-08-19 Thread Li Qiang
Currently the device fuzzer find a more and more issues. For every fuzz case, we need not only the fixes but also the coressponding test case. We can analysis the reproducer for every case and find what happened in where and write a beautiful test case. However the raw data of reproducer is not fri

Re: guest agent public ssh key add/remove support?

2020-08-19 Thread Christian Schoenebeck
On Mittwoch, 19. August 2020 15:49:50 CEST David Vossel wrote: > > There are two pass-through file systems in QEMU: 9pfs and virtiofs. Don't > > you > > think they would be sufficient for the use case? > > probably not entirely. > > Understand this isn't an either/or scenario. Our api has been de

Re: [RFC PATCH 0/9] block/curl: Add caching of data downloaded from the remote server

2020-08-19 Thread David Edmondson
On Wednesday, 2020-08-19 at 15:11:37 +01, Stefan Hajnoczi wrote: > On Tue, Aug 18, 2020 at 12:08:36PM +0100, David Edmondson wrote: >> When using qemu-img to convert an image that is hosted on an HTTP >> server to some faster local (or pseudo-local) storage, the overall >> performance can be impro

Re: [RFC PATCH 19/22] block/export: Move strong user reference to block_exports

2020-08-19 Thread Kevin Wolf
Am 19.08.2020 um 13:56 hat Max Reitz geschrieben: > On 13.08.20 18:29, Kevin Wolf wrote: > > The reference owned by the user/monitor that is created when adding the > > export and dropped when removing it was tied to the 'exports' list in > > nbd/server.c. Every block export will have a user refere

Re: [PATCH 0/1] qcow2: Skip copy-on-write when allocating a zero cluster

2020-08-19 Thread Alberto Garcia
On Mon 17 Aug 2020 05:53:07 PM CEST, Kevin Wolf wrote: >> > Or are you saying that ZERO_RANGE + pwrite on a sparse file (= >> > cluster allocation) is faster for you than just the pwrite alone (= >> > writing to already allocated cluster)? >> >> Yes, 20% faster in my tests (4KB random writes), but

qemu

2020-08-19 Thread 林奕帆
Hello, recently when I was checking the cves for this software, I can not find the patch commit id for these cves: CVE-2019-12247 CVE-2018-5748 CVE-2020-13791 could you please tell whitch commit fix these cve? Thanks.

[PULL v6 000/150] Meson-based build system

2020-08-19 Thread Paolo Bonzini
The following changes since commit d0ed6a69d399ae193959225cdeaa9382746c91cc: Update version for v5.1.0 release (2020-08-11 17:07:03 +0100) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for-upstream for you to fetch changes up to f5b5ef3b9f94d744f514f5469c9

Re: [PATCH] qtest: add fuzz test case

2020-08-19 Thread Philippe Mathieu-Daudé
On 8/19/20 4:15 PM, Li Qiang wrote: > Currently the device fuzzer find a more and more issues. > For every fuzz case, we need not only the fixes but also > the coressponding test case. We can analysis the reproducer Typo "corresponding" > for every case and find what happened in where and write >

Re: [PATCH v6 2/7] hw: add 5.2 machine types and 5.1 compat options

2020-08-19 Thread Laszlo Ersek
On 08/19/20 16:12, Stefan Hajnoczi wrote: > On Tue, Aug 18, 2020 at 05:11:32PM +0200, Cornelia Huck wrote: >> On Tue, 18 Aug 2020 15:33:43 +0100 >> Stefan Hajnoczi wrote: >> >>> arm, i386, ppc, and s390x have versioned machine types and associated >>> compatibility options. Introduce new ones now

[PATCH v2 0/3] vhost-vsock: force virtio version 1

2020-08-19 Thread Stefano Garzarella
v2: - Fixed commit message in patche 1 and 2 [Cornelia] - Added Cornelia's R-b tags in all patches v1: https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg04373.html Recenlty changes in QEMU 5.1 requires to set 'disable-legacy=on' on vhost-vsock-pci and vhost-user-vsock-pci devices:

[PATCH v2 1/3] vhost-vsock-pci: force virtio version 1

2020-08-19 Thread Stefano Garzarella
Commit 9b3a35ec82 ("virtio: verify that legacy support is not accidentally on") added a safety check that requires to set 'disable-legacy=on' on vhost-vsock-pci device: $ ./qemu-system-x86_64 ... -device vhost-vsock-pci,guest-cid=5 qemu-system-x86_64: -device vhost-vsock-pci,guest-cid=

[PATCH v2 3/3] vhost-vsock-ccw: force virtio version 1

2020-08-19 Thread Stefano Garzarella
virtio-vsock was introduced after the release of VIRTIO 1.0 specifications, so it should be 'modern-only'. This patch forces virtio version 1 as done for vhost-vsock-pci. Cc: qemu-sta...@nongnu.org Suggested-by: Cornelia Huck Reviewed-by: Cornelia Huck Signed-off-by: Stefano Garzarella --- hw

[PATCH v2] hw: add compat machines for 5.2

2020-08-19 Thread Cornelia Huck
Add 5.2 machine types for arm/i440fx/q35/s390x/spapr. Reviewed-by: Andrew Jones Reviewed-by: Michael S. Tsirkin Reviewed-by: Greg Kurz Acked-by: Christian Borntraeger Acked-by: David Gibson Acked-by: Thomas Huth Signed-off-by: Cornelia Huck --- v1->v2: rebased on current master For whoeve

[PATCH v2 2/3] vhost-user-vsock-pci: force virtio version 1

2020-08-19 Thread Stefano Garzarella
Commit 9b3a35ec82 ("virtio: verify that legacy support is not accidentally on") added a safety check that requires to set 'disable-legacy=on' on vhost-user-vsock-pci device: $ ./qemu-system-x86_64 ... \ -chardev socket,id=char0,reconnect=0,path=/tmp/vhost4.socket \ -device vhost-user-v

Re: [PATCH v3 05/12] block: bdrv_mark_request_serialising: split non-waiting function

2020-08-19 Thread Stefan Hajnoczi
On Mon, Aug 17, 2020 at 12:15:46PM +0300, Vladimir Sementsov-Ogievskiy wrote: > @@ -882,6 +878,20 @@ static bool coroutine_fn > bdrv_wait_serialising_requests(BdrvTrackedRequest *self > return waited; > } > > +bool bdrv_make_request_serialising(BdrvTrackedRequest *req, uint64_t align) > +{

Re: [PATCH v3 06/12] block: introduce BDRV_REQ_NO_WAIT flag

2020-08-19 Thread Stefan Hajnoczi
On Mon, Aug 17, 2020 at 12:15:47PM +0300, Vladimir Sementsov-Ogievskiy wrote: > diff --git a/block/io.c b/block/io.c > index 96b1b9cf5f..fc6d44d302 100644 > --- a/block/io.c > +++ b/block/io.c > @@ -1911,9 +1911,20 @@ bdrv_co_write_req_prepare(BdrvChild *child, int64_t > offset, uint64_t bytes, >

[PATCH] virtio: vdpa: omit check return of g_malloc

2020-08-19 Thread Li Qiang
If g_malloc fails, the application will be terminated. No need to check the return value of g_malloc. Signed-off-by: Li Qiang --- hw/virtio/vhost-vdpa.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c index 4580f3efd8..403

Re: [PATCH v7 14/47] stream: Deal with filters

2020-08-19 Thread Max Reitz
On 18.08.20 16:28, Kevin Wolf wrote: > Am 25.06.2020 um 17:21 hat Max Reitz geschrieben: >> Because of the (not so recent anymore) changes that make the stream job >> independent of the base node and instead track the node above it, we >> have to split that "bottom" node into two cases: The bottom

Re: [PATCH v3] block/nbd: use non-blocking connect: fix vm hang on connect()

2020-08-19 Thread Eric Blake
On 8/12/20 9:52 AM, Vladimir Sementsov-Ogievskiy wrote: This make nbd connection_co to yield during reconnects, so that s/make nbd connection_co to/makes nbd's connection_co/ reconnect doesn't hang up the main thread. This is very important in s/hang up/block/ case of unavailable nbd serv

Re: [RFC PATCH 19/22] block/export: Move strong user reference to block_exports

2020-08-19 Thread Max Reitz
On 19.08.20 16:23, Kevin Wolf wrote: > Am 19.08.2020 um 13:56 hat Max Reitz geschrieben: >> On 13.08.20 18:29, Kevin Wolf wrote: >>> The reference owned by the user/monitor that is created when adding the >>> export and dropped when removing it was tied to the 'exports' list in >>> nbd/server.c. Ev

Re: [PATCH] qtest: add fuzz test case

2020-08-19 Thread Li Qiang
Philippe Mathieu-Daudé 于2020年8月19日周三 下午10:38写道: > On 8/19/20 4:15 PM, Li Qiang wrote: > > Currently the device fuzzer find a more and more issues. > > For every fuzz case, we need not only the fixes but also > > the coressponding test case. We can analysis the reproducer > > Typo "corresponding"

Re: [PATCH] qtest: add fuzz test case

2020-08-19 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200819141533.66354-1-liq...@163.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/b

Re: [PATCH v3 07/12] block: introduce preallocate filter

2020-08-19 Thread Stefan Hajnoczi
On Mon, Aug 17, 2020 at 12:15:48PM +0300, Vladimir Sementsov-Ogievskiy wrote: > diff --git a/docs/system/qemu-block-drivers.rst.inc > b/docs/system/qemu-block-drivers.rst.inc > index b052a6d14e..5bfa4f4116 100644 > --- a/docs/system/qemu-block-drivers.rst.inc > +++ b/docs/system/qemu-block-drivers

Re: [PATCH v3 03/12] block/io: split out bdrv_find_conflicting_request

2020-08-19 Thread Stefan Hajnoczi
On Mon, Aug 17, 2020 at 12:15:44PM +0300, Vladimir Sementsov-Ogievskiy wrote: > To be reused in separate. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/io.c | 71 +++--- > 1 file changed, 41 insertions(+), 30 deletions(-) Reviewed-

Re: [PATCH v3 04/12] block/io: bdrv_wait_serialising_requests_locked: drop extra bs arg

2020-08-19 Thread Stefan Hajnoczi
On Mon, Aug 17, 2020 at 12:15:45PM +0300, Vladimir Sementsov-Ogievskiy wrote: > bs is linked in req, so no needs to pass it separately. Most of > tracked-requests API doesn't have bs argument. Actually, after this > patch only tracked_request_begin has it, but it's for purpose. > > While being her

Re: [PATCH v3 01/12] block: simplify comment to BDRV_REQ_SERIALISING

2020-08-19 Thread Stefan Hajnoczi
On Mon, Aug 17, 2020 at 12:15:42PM +0300, Vladimir Sementsov-Ogievskiy wrote: > 1. BDRV_REQ_NO_SERIALISING doesn't exist already, don't mention it. > > 2. We are going to add one more user of BDRV_REQ_SERIALISING, so >comment about backup becomes a bit confusing here. The use case in >back

Re: [PATCH v3 10/12] iotests: add 298 to test new preallocate filter driver

2020-08-19 Thread Stefan Hajnoczi
On Mon, Aug 17, 2020 at 12:15:51PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > tests/qemu-iotests/298 | 50 ++ > tests/qemu-iotests/298.out | 6 + > tests/qemu-iotests/group | 1 + > 3 files chang

Re: [PATCH v3 08/12] iotests.py: add verify_o_direct helper

2020-08-19 Thread Stefan Hajnoczi
On Mon, Aug 17, 2020 at 12:15:49PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Add python notrun-helper similar to _check_o_direct for bash tests. > To be used in the following commit. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > tests/qemu-iotests/iotests.py | 6 ++ > 1 file cha

Re: [PATCH v3 09/12] iotests.py: add filter_img_check

2020-08-19 Thread Stefan Hajnoczi
On Mon, Aug 17, 2020 at 12:15:50PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Add analog of bash _filter_qemu_img_check to python framework. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > tests/qemu-iotests/iotests.py | 4 > 1 file changed, 4 insertions(+) Reviewed-by: Stefan Ha

Re: [PATCH 0/1] qcow2: Skip copy-on-write when allocating a zero cluster

2020-08-19 Thread Kevin Wolf
Am 19.08.2020 um 16:25 hat Alberto Garcia geschrieben: > On Mon 17 Aug 2020 05:53:07 PM CEST, Kevin Wolf wrote: > >> > Or are you saying that ZERO_RANGE + pwrite on a sparse file (= > >> > cluster allocation) is faster for you than just the pwrite alone (= > >> > writing to already allocated cluste

Re: [PATCH] virtio: vdpa: omit check return of g_malloc

2020-08-19 Thread Philippe Mathieu-Daudé
On 8/19/20 4:43 PM, Li Qiang wrote: > If g_malloc fails, the application will be terminated. Which we don't want... better to use g_try_malloc() instead? > No need to check the return value of g_malloc. > > Signed-off-by: Li Qiang > --- > hw/virtio/vhost-vdpa.c | 7 +-- > 1 file changed, 1

Re: [PATCH v3 12/12] block/qcow2: automatically insert preallocate filter when on FUSE

2020-08-19 Thread Stefan Hajnoczi
On Mon, Aug 17, 2020 at 12:15:53PM +0300, Vladimir Sementsov-Ogievskiy wrote: > vstorage has slow allocation, so this patch detect vstorage > (I hope, we don't use other FUSE filesystems) and inserts preallocate > filter between qcow2 node and its file child. > > The following test executes more t

Re: [PATCH v7 14/47] stream: Deal with filters

2020-08-19 Thread Kevin Wolf
Am 19.08.2020 um 16:47 hat Max Reitz geschrieben: > On 18.08.20 16:28, Kevin Wolf wrote: > > Am 25.06.2020 um 17:21 hat Max Reitz geschrieben: > >> Because of the (not so recent anymore) changes that make the stream job > >> independent of the base node and instead track the node above it, we > >>

Re: [PATCH v5 1/1] audio/jack: fix use after free segfault

2020-08-19 Thread Christian Schoenebeck
On Mittwoch, 19. August 2020 08:29:39 CEST Geoffrey McRae wrote: > This change registers a bottom handler to close the JACK client > connection when a server shutdown signal is recieved. Without this > libjack2 attempts to "clean up" old clients and causes a use after free > segfault. > > Signed-o

[PULL 0/3] Machine queue 2020-08-19

2020-08-19 Thread Eduardo Habkost
The following changes since commit 672b2f2695891b6d818bddc3ce0df964c7627969: Open 5.2 development tree (2020-08-18 13:44:04 +0100) are available in the Git repository at: git://github.com/ehabkost/qemu.git tags/machine-next-pull-request for you to fetch changes up to 3ff3c5d31740484b0e19007

[PULL 3/3] hw: add compat machines for 5.2

2020-08-19 Thread Eduardo Habkost
From: Cornelia Huck Add 5.2 machine types for arm/i440fx/q35/s390x/spapr. Reviewed-by: Andrew Jones Reviewed-by: Michael S. Tsirkin Reviewed-by: Greg Kurz Acked-by: Christian Borntraeger Acked-by: David Gibson Acked-by: Thomas Huth Signed-off-by: Cornelia Huck Message-Id: <20200819144016.

[PULL 1/3] qdev: Document qdev_prop_set_drive_err() return value

2020-08-19 Thread Eduardo Habkost
From: Philippe Mathieu-Daudé Since commit 73ac1aac39 qdev_prop_set_drive_err() returns a boolean value. Document it. Fixes: 73ac1aac39 "Make functions taking Error ** return bool, not void" Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20200720121659.31886-1-f4...@amsat.org> Signed-off-by:

[PULL 2/3] qmp: Expose MachineClass::default_ram_id

2020-08-19 Thread Eduardo Habkost
From: Michal Privoznik If a management application (like Libvirt) want's to preserve migration ability and switch to '-machine memory-backend' it needs to set exactly the same RAM id as QEMU would. Since the id is machine type dependant, expose it under 'query-machines' result. Some machine types

Re: [PATCH v5 1/1] audio/jack: fix use after free segfault

2020-08-19 Thread Geoffrey McRae
On 2020-08-20 01:21, Christian Schoenebeck wrote: On Mittwoch, 19. August 2020 08:29:39 CEST Geoffrey McRae wrote: This change registers a bottom handler to close the JACK client connection when a server shutdown signal is recieved. Without this libjack2 attempts to "clean up" old clients and

Re: [PATCH v5 7/8] sparc/sun4m: Use start-powered-off CPUState property

2020-08-19 Thread Thiago Jung Bauermann
Hi Philippe, Philippe Mathieu-Daudé writes: > On 8/19/20 4:42 AM, Thiago Jung Bauermann wrote: >> Instead of setting CPUState::halted to 1 in secondary_cpu_reset(), use the >> start-powered-off property which makes cpu_common_reset() initialize it >> to 1 in common code. >> >> This makes secon

Re: [PATCH v6 2/7] hw: add 5.2 machine types and 5.1 compat options

2020-08-19 Thread Philippe Mathieu-Daudé
On 8/19/20 4:38 PM, Laszlo Ersek wrote: > On 08/19/20 16:12, Stefan Hajnoczi wrote: >> On Tue, Aug 18, 2020 at 05:11:32PM +0200, Cornelia Huck wrote: >>> On Tue, 18 Aug 2020 15:33:43 +0100 >>> Stefan Hajnoczi wrote: >>> arm, i386, ppc, and s390x have versioned machine types and associated >>>

Re: [PATCH v3 00/12] preallocate filter

2020-08-19 Thread Stefan Hajnoczi
On Mon, Aug 17, 2020 at 12:15:41PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Here is a filter, which does preallocation on write. Looks quite close to being merged. I have left comments. Stefan signature.asc Description: PGP signature

Re: [PATCH v3 02/12] block/io.c: drop assertion on double waiting for request serialisation

2020-08-19 Thread Stefan Hajnoczi
On Mon, Aug 17, 2020 at 12:15:43PM +0300, Vladimir Sementsov-Ogievskiy wrote: > The comments states, that on misaligned request we should have already > been waiting. But for bdrv_padding_rmw_read, we called > bdrv_mark_request_serialising with align = request_alignment, and now > we serialise with

Re: [PATCH v7 10/47] mirror-top: Support compressed writes

2020-08-19 Thread Max Reitz
On 18.08.20 12:27, Kevin Wolf wrote: > Am 25.06.2020 um 17:21 hat Max Reitz geschrieben: >> Signed-off-by: Max Reitz >> --- >> block/mirror.c | 10 ++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/block/mirror.c b/block/mirror.c >> index e8e8844afc..469acf4600 100644 >> --- a/blo

Re: [PATCH 0/1] qcow2: Skip copy-on-write when allocating a zero cluster

2020-08-19 Thread Alberto Garcia
On Wed 19 Aug 2020 05:07:11 PM CEST, Kevin Wolf wrote: >> I checked with xfs on my computer. I'm not very familiar with that >> filesystem so I was using the default options and I didn't tune >> anything. >> >> What I got with my tests (using fio): >> >> - Using extent_size_hint didn't make any d

Re: [PATCH v3 02/12] block/io.c: drop assertion on double waiting for request serialisation

2020-08-19 Thread Paolo Bonzini
On 19/08/20 17:28, Stefan Hajnoczi wrote: > On Mon, Aug 17, 2020 at 12:15:43PM +0300, Vladimir Sementsov-Ogievskiy wrote: >> The comments states, that on misaligned request we should have already >> been waiting. But for bdrv_padding_rmw_read, we called >> bdrv_mark_request_serialising with align =

Re: [PATCH v7 27/47] blkverify: Use bdrv_sum_allocated_file_size()

2020-08-19 Thread Max Reitz
On 19.08.20 12:46, Kevin Wolf wrote: > Am 25.06.2020 um 17:21 hat Max Reitz geschrieben: >> blkverify is a filter, so bdrv_get_allocated_file_size()'s default >> implementation will return only the size of its filtered child. >> However, because both of its children are disk images, it makes more >

Re: [RFC v3 1/1] memory: Skip bad range assertion if notifier supports arbitrary masks

2020-08-19 Thread Peter Xu
On Wed, Aug 19, 2020 at 03:15:26PM +0800, Jason Wang wrote: > Yes, actually, I feel confused after reading the codes. Is notifier->start > IOVA or GPA? > > In vfio.c, we did: > >     iommu_notifier_init(&giommu->n, vfio_iommu_map_notify, >     IOMMU_NOTIFIER_ALL, >    

Re: [PATCH] audio/jack: fix use after free segfault

2020-08-19 Thread Christian Schoenebeck
On Mittwoch, 19. August 2020 14:51:52 CEST Geoffrey McRae wrote: > >> > What latencies do you achieve BTW with Windows guests? > >> > >> Never tested, it's not the reason why I use jack. > > > > Surpring that you never checked the min. latency there, as you nailed > > quite an > > ambitous jack d

Re: [PATCH 0/1] qcow2: Skip copy-on-write when allocating a zero cluster

2020-08-19 Thread Alberto Garcia
On Wed 19 Aug 2020 05:37:12 PM CEST, Alberto Garcia wrote: > I ran the test again on a newly created filesystem just to make sure, > here are the full results (numbers are IOPS): > > |--+---+---| > | preallocation| ext4 | xfs | > |--+--

Re: [PATCH v7 25/47] block: Def. impl.s for get_allocated_file_size

2020-08-19 Thread Max Reitz
On 19.08.20 12:57, Kevin Wolf wrote: > Am 25.06.2020 um 17:21 hat Max Reitz geschrieben: >> If every BlockDriver were to implement bdrv_get_allocated_file_size(), >> there are basically three ways it would be handled: >> (1) For protocol drivers: Figure out the actual allocated file size in >>

Re: [RFC PATCH v3 1/5] block/nvme: Use an array of EventNotifier

2020-08-19 Thread Philippe Mathieu-Daudé
On 8/19/20 10:08 AM, Stefan Hajnoczi wrote: > On Tue, Aug 18, 2020 at 06:45:05PM +0200, Philippe Mathieu-Daudé wrote: >> In preparation of using multiple IRQ (thus multiple eventfds) >> make BDRVNVMeState::irq_notifier an array (for now of a single >> element, the admin queue notifier). >> >> Sign

Re: [PATCH] audio/jack: fix use after free segfault

2020-08-19 Thread Geoffrey McRae
On 2020-08-20 01:51, Christian Schoenebeck wrote: On Mittwoch, 19. August 2020 14:51:52 CEST Geoffrey McRae wrote: >> > What latencies do you achieve BTW with Windows guests? >> >> Never tested, it's not the reason why I use jack. > > Surpring that you never checked the min. latency there, as yo

Re: [PATCH v7 10/47] mirror-top: Support compressed writes

2020-08-19 Thread Kevin Wolf
Am 19.08.2020 um 17:35 hat Max Reitz geschrieben: > On 18.08.20 12:27, Kevin Wolf wrote: > > Am 25.06.2020 um 17:21 hat Max Reitz geschrieben: > >> Signed-off-by: Max Reitz > >> --- > >> block/mirror.c | 10 ++ > >> 1 file changed, 10 insertions(+) > >> > >> diff --git a/block/mirror.c b/

[RFC PATCH v4 1/5] block/nvme: Use an array of EventNotifier

2020-08-19 Thread Philippe Mathieu-Daudé
In preparation of using multiple IRQ (thus multiple eventfds) make BDRVNVMeState::irq_notifier an array (for now of a single element, the admin queue notifier). Signed-off-by: Philippe Mathieu-Daudé --- block/nvme.c | 31 +-- 1 file changed, 21 insertions(+), 10 delet

[RFC PATCH v4 2/5] util/vfio-helpers: Improve reporting unsupported IOMMU type

2020-08-19 Thread Philippe Mathieu-Daudé
Change the confuse "VFIO IOMMU check failed" error message by the explicit "VFIO IOMMU Type1 is not supported" once. Example on POWER: $ qemu-system-ppc64 -drive if=none,id=nvme0,file=nvme://0001:01:00.0/1,format=raw qemu-system-ppc64: -drive if=none,id=nvme0,file=nvme://0001:01:00.0/1,format

[RFC PATCH v4 0/5] util/vfio-helpers: Add support for multiple IRQs

2020-08-19 Thread Philippe Mathieu-Daudé
This series intends to setup the VFIO helper to allow binding notifiers on different IRQs. For the NVMe use case, we only care about MSIX interrupts. To not disrupt other users, introduce the qemu_vfio_pci_init_msix_irqs function to initialize multiple MSIX IRQs and attach eventfd to them. Since

[RFC PATCH v4 3/5] util/vfio-helpers: Report error when IOMMU page size is not supported

2020-08-19 Thread Philippe Mathieu-Daudé
This driver uses the host page size to align its memory regions, but this size is not always compatible with the IOMMU. Add a check if the size matches, and bails out with listing the sizes the IOMMU supports. Example on Aarch64: $ qemu-system-aarch64 -M virt -drive if=none,id=nvme0,file=nvme:/

[RFC PATCH v4 5/5] block/nvme: Use qemu_vfio_pci_init_msix_irqs() to initialize our IRQ

2020-08-19 Thread Philippe Mathieu-Daudé
Instead of initializing one MSIX IRQ with the generic qemu_vfio_pci_init_irq() function, use the MSIX specific one which ill allow us to use multiple IRQs. For now we provide an array of a single IRQ. Signed-off-by: Philippe Mathieu-Daudé --- block/nvme.c | 9 +++-- 1 file changed, 7 inserti

[RFC PATCH v4 4/5] util/vfio-helpers: Introduce qemu_vfio_pci_init_msix_irqs()

2020-08-19 Thread Philippe Mathieu-Daudé
qemu_vfio_pci_init_irq() allows us to initialize any type of IRQ, but only one. Introduce qemu_vfio_pci_init_msix_irqs() which is specific to MSIX IRQ type, and allow us to use multiple IRQs (thus passing multiple eventfd notifiers). Signed-off-by: Philippe Mathieu-Daudé --- include/qemu/vfio-he

Re: [PATCH] qtest: add fuzz test case

2020-08-19 Thread Alexander Bulekov
On 200819 2250, Li Qiang wrote: > Philippe Mathieu-Daudé 于2020年8月19日周三 下午10:38写道: > > > On 8/19/20 4:15 PM, Li Qiang wrote: > > > Currently the device fuzzer find a more and more issues. > > > For every fuzz case, we need not only the fixes but also > > > the coressponding test case. We can analy

Re: [PATCH v2 00/15] Add a General Virtual Device Fuzzer

2020-08-19 Thread Alexander Bulekov
Oops I forgot to do my checkpatch pass. I'll resend this, shortly. -Alex On 200818 2332, no-re...@patchew.org wrote: > Patchew URL: https://patchew.org/QEMU/20200819061110.1320568-1-alx...@bu.edu/ > > > > Hi, > > This series seems to have some coding style problems. See output below for > more

Re: [RFC v4 1/2] memory: Rename memory_region_notify_one to memory_region_notify_one_iommu

2020-08-19 Thread Peter Xu
On Tue, Aug 18, 2020 at 03:01:50PM +0200, Eugenio Pérez wrote: > Signed-off-by: Eugenio Pérez Reviewed-by: Peter Xu It would be good if there's some commit message, though.. Also, I'd slightly prefer memory_region_notify_iommu_one rather than one_iommu, but I'm fine with either. -- Peter Xu

Re: [RFC v4 2/2] memory: Skip bad range assertion if notifier is DEVIOTLB type

2020-08-19 Thread Peter Xu
On Tue, Aug 18, 2020 at 03:01:51PM +0200, Eugenio Pérez wrote: > Signed-off-by: Eugenio Pérez The changes on the callers of memory_region_notify_one_iommu() seems to be still missing (and, to embed the type into the notification process).. -- Peter Xu

[PATCH v6 2/8] target/arm: Move setting of CPU halted state to generic code

2020-08-19 Thread Thiago Jung Bauermann
This change is in a separate patch because it's not so obvious that it won't cause a regression. Suggested-by: Eduardo Habkost Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: David Gibson Reviewed-by: Greg Kurz Signed-off-by: Thiago Jung Bauermann --- hw/core/cpu.c| 2 +- target/arm/cpu

[PATCH v6 1/8] target/arm: Move start-powered-off property to generic CPUState

2020-08-19 Thread Thiago Jung Bauermann
There are other platforms which also have CPUs that start powered off, so generalize the start-powered-off property so that it can be used by them. Note that ARMv7MState also has a property of the same name but this patch doesn't change it because that class isn't a subclass of CPUState so it woul

[PATCH v6 6/8] sparc/sun4m: Remove main_cpu_reset()

2020-08-19 Thread Thiago Jung Bauermann
We rely on cpu_common_reset() to set cs->halted to 0, so main_cpu_reset() is pointless. Suggested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: David Gibson Signed-off-by: Thiago Jung Bauermann --- hw/sparc/sun4m.c | 13 + 1 file changed, 1 insertion(

[PATCH v6 3/8] ppc/spapr: Use start-powered-off CPUState property

2020-08-19 Thread Thiago Jung Bauermann
PowerPC sPAPR CPUs start in the halted state, and spapr_reset_vcpu() attempts to implement this by setting CPUState::halted to 1. But that's too late for the case of hotplugged CPUs in a machine configure with 2 or more threads per core. By then, other parts of QEMU have already caused the vCPU to

[PATCH v6 0/8] Generalize start-powered-off property from ARM

2020-08-19 Thread Thiago Jung Bauermann
This version has one small fix in patch 7, and adds Philippe's Reviewed-bys. Applies cleanly on dgibson/ppc-for-5.2. Original cover letter below, followed by changelog: The ARM code has a start-powered-off property in ARMCPU, which is a subclass of CPUState. This property causes arm_cpu_reset()

[PATCH v6 4/8] ppc/e500: Use start-powered-off CPUState property

2020-08-19 Thread Thiago Jung Bauermann
Instead of setting CPUState::halted to 1 in ppce500_cpu_reset_sec(), use the start-powered-off property which makes cpu_common_reset() initialize it to 1 in common code. Also change creation of CPU object from cpu_create() to object_new() and qdev_realize_and_unref() because cpu_create() realizes

[PATCH v6 7/8] sparc/sun4m: Use start-powered-off CPUState property

2020-08-19 Thread Thiago Jung Bauermann
Instead of setting CPUState::halted to 1 in secondary_cpu_reset(), use the start-powered-off property which makes cpu_common_reset() initialize it to 1 in common code. This makes secondary_cpu_reset() unnecessary, so remove it. Also remove setting of cs->halted from cpu_devinit(), which seems out

[PATCH v6 8/8] target/s390x: Use start-powered-off CPUState property

2020-08-19 Thread Thiago Jung Bauermann
Instead of setting CPUState::halted to 1 in s390_cpu_initfn(), use the start-powered-off property which makes cpu_common_reset() initialize it to 1 in common code. Note that this changes behavior by setting cs->halted to 1 on reset, which didn't happen before. Acked-by: Cornelia Huck Reviewed-by

[PATCH v6 5/8] mips/cps: Use start-powered-off CPUState property

2020-08-19 Thread Thiago Jung Bauermann
Instead of setting CPUState::halted to 1 in main_cpu_reset(), use the start-powered-off property which makes cpu_common_reset() initialize it to 1 in common code. Also change creation of CPU object from cpu_create() to object_new() and qdev_realize_and_unref() because cpu_create() realizes the CPU

<    1   2   3   4   >