[Bug 1883984] Re: QEMU S/390x sqxbr (128-bit IEEE 754 square root) crashes qemu-system-s390x

2020-08-19 Thread Christian Ehrhardt 
** Description changed: + [Impact] + + * An instruction was described wrong so that on usage the program would +crash. + + [Test Case] + + * Run s390x in emulation and there use this program: +For simplicity and speed you can use KVM guest as usual on s390x, that +after prep&ins

Re: [ovirt-devel] Re: device compatibility interface for live migration with assigned devices

2020-08-19 Thread Yan Zhao
On Wed, Aug 19, 2020 at 02:57:34PM +0800, Jason Wang wrote: > > On 2020/8/19 上午11:30, Yan Zhao wrote: > > hi All, > > could we decide that sysfs is the interface that every VFIO vendor driver > > needs to provide in order to support vfio live migration, otherwise the > > userspace management tool

Re: [RFC v3 1/1] memory: Skip bad range assertion if notifier supports arbitrary masks

2020-08-19 Thread Jason Wang
On 2020/8/18 下午10:24, Eugenio Perez Martin wrote: On Wed, Aug 12, 2020 at 10:49 AM Eugenio Perez Martin wrote: On Wed, Aug 12, 2020 at 4:24 AM Jason Wang wrote: On 2020/8/12 上午1:55, Eugenio Pérez wrote: Signed-off-by: Eugenio Pérez --- hw/virtio/vhost.c | 2 +- include/exec/memo

Re: [ovirt-devel] Re: device compatibility interface for live migration with assigned devices

2020-08-19 Thread Jason Wang
On 2020/8/19 下午2:59, Yan Zhao wrote: On Wed, Aug 19, 2020 at 02:57:34PM +0800, Jason Wang wrote: On 2020/8/19 上午11:30, Yan Zhao wrote: hi All, could we decide that sysfs is the interface that every VFIO vendor driver needs to provide in order to support vfio live migration, otherwise the user

[Bug 1883984] Re: QEMU S/390x sqxbr (128-bit IEEE 754 square root) crashes qemu-system-s390x

2020-08-19 Thread Christian Ehrhardt 
Note: final upstream commit link https://git.qemu.org/?p=qemu.git;a=commit;h=9bf728a09bf7509b27543664f9cca6f4f337f608 ** Changed in: qemu (Ubuntu) Assignee: Christian Ehrhardt  (paelzer) => (unassigned) -- You received this bug notification because you are a member of qemu- devel-ml, which

Re: [PATCH] hw/m68k: QOMify the mcf5206 system integration module

2020-08-19 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200819065201.4045-1-h...@tuxfamily.org/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #

Re: [PATCH v8 17/20] multi-process: heartbeat messages to remote

2020-08-19 Thread Stefan Hajnoczi
On Fri, Aug 14, 2020 at 04:01:47PM -0700, Elena Ufimtseva wrote: > On Tue, Aug 11, 2020 at 03:41:30PM +0100, Stefan Hajnoczi wrote: > > On Fri, Jul 31, 2020 at 02:20:24PM -0400, Jagannathan Raman wrote: > > > @@ -343,3 +349,49 @@ static void probe_pci_info(PCIDevice *dev, Error > > > **errp) > > >

[PATCH] tests: docker: support mxe-based mingw builds

2020-08-19 Thread Paolo Bonzini
This can be run with docker-test-mingw@ubuntu1804-mxe, and is the setup that Peter uses to test cross-compilation. Signed-off-by: Paolo Bonzini --- tests/docker/common.rc| 18 ++- .../docker/dockerfiles/ubuntu1804-mxe.docker | 54 +++ tests/docker/tes

Re: [PULL 147/150] meson: convert po/

2020-08-19 Thread Paolo Bonzini
On 19/08/20 03:56, Brad Smith wrote: > > > This last part is redundant. If glib2 and/or gtk+3 is installed then > gettext > is installed. > > The package name is wrong as well as gettext changed from gettext to > gettext-runtime relatively recently. Are you sure gettext-runtime includes xgettex

Re: [RFC PATCH v3 1/5] block/nvme: Use an array of EventNotifier

2020-08-19 Thread Stefan Hajnoczi
On Tue, Aug 18, 2020 at 06:45:05PM +0200, Philippe Mathieu-Daudé wrote: > In preparation of using multiple IRQ (thus multiple eventfds) > make BDRVNVMeState::irq_notifier an array (for now of a single > element, the admin queue notifier). > > Signed-off-by: Philippe Mathieu-Daudé > --- > block/n

Re: [PATCH] tests: docker: support mxe-based mingw builds

2020-08-19 Thread Marc-André Lureau
Hi On Wed, Aug 19, 2020 at 12:03 PM Paolo Bonzini wrote: > This can be run with docker-test-mingw@ubuntu1804-mxe, and is the setup > that Peter uses to test cross-compilation. > > Signed-off-by: Paolo Bonzini > I wish I had this a few times, thanks! Reviewed-by: Marc-André Lureau > --- >

[Bug 1253563] Re: bad performance with rng-egd backend

2020-08-19 Thread Amos Jianjun Kong
Let's close this bug, it's passed 6 years. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1253563 Title: bad performance with rng-egd backend Status in QEMU: Incomplete Bug description

Re: [PATCH] tests: docker: support mxe-based mingw builds

2020-08-19 Thread Daniel P . Berrangé
On Wed, Aug 19, 2020 at 04:02:06AM -0400, Paolo Bonzini wrote: > This can be run with docker-test-mingw@ubuntu1804-mxe, and is the setup > that Peter uses to test cross-compilation. We already have docker containers with MXE based on Debian: debian-win32-cross.docker debian-win64-cross.docker

Re: [RFC v3 1/1] memory: Skip bad range assertion if notifier supports arbitrary masks

2020-08-19 Thread Eugenio Perez Martin
On Wed, Aug 19, 2020 at 9:15 AM Jason Wang wrote: > > > On 2020/8/18 下午10:24, Eugenio Perez Martin wrote: > > On Wed, Aug 12, 2020 at 10:49 AM Eugenio Perez Martin > > wrote: > >> On Wed, Aug 12, 2020 at 4:24 AM Jason Wang wrote: > >>> On 2020/8/12 上午1:55, Eugenio Pérez wrote: > Signed-off

[PATCH V3] Introduce a new flag for i440fx to disable PCI hotplug on the root bus

2020-08-19 Thread Ani Sinha
We introduce a new global flag 'acpi-root-pci-hotplug' for i440fx with which we can turn on or off PCI device hotplug on the root bus. This flag can be used to prevent all PCI devices from getting hotplugged or unplugged from the root PCI bus. The existing flag 'acpi-pci-hotplug-with-bridge-support

Re: [ovirt-devel] Re: device compatibility interface for live migration with assigned devices

2020-08-19 Thread Yan Zhao
On Wed, Aug 19, 2020 at 03:39:50PM +0800, Jason Wang wrote: > > On 2020/8/19 下午2:59, Yan Zhao wrote: > > On Wed, Aug 19, 2020 at 02:57:34PM +0800, Jason Wang wrote: > > > On 2020/8/19 上午11:30, Yan Zhao wrote: > > > > hi All, > > > > could we decide that sysfs is the interface that every VFIO vendo

Re: [RFC PATCH 19/22] block/export: Move strong user reference to block_exports

2020-08-19 Thread Max Reitz
On 13.08.20 18:29, Kevin Wolf wrote: > The reference owned by the user/monitor that is created when adding the > export and dropped when removing it was tied to the 'exports' list in > nbd/server.c. Every block export will have a user reference, so move it > to the block export level and tie it to

Re: [PATCH v2 1/7] x86: lpc9: let firmware negotiate 'CPU hotplug with SMI' features

2020-08-19 Thread Laszlo Ersek
Hi Igor, (CC'ing Daniel, Cornelia, David, Peter) On 08/18/20 14:22, Igor Mammedov wrote: > It will allow firmware to notify QEMU that firmware requires SMI > being triggered on CPU hot[un]plug, so that it would be able to account > for hotplugged CPU and relocate it to new SMM base and/or safely

Re: [PATCH v2] qemu-img: Explicit number replaced by a constant

2020-08-19 Thread Alberto Garcia
On Wed 19 Aug 2020 03:36:07 AM CEST, Yi Li wrote: > Signed-off-by: Yi Li Reviewed-by: Alberto Garcia Berto

Re: [PATCH v2 1/7] x86: lpc9: let firmware negotiate 'CPU hotplug with SMI' features

2020-08-19 Thread Laszlo Ersek
correcting myself a bit, with Drew and Thomas CC'd as well: On 08/19/20 10:39, Laszlo Ersek wrote: > Hi Igor, > > (CC'ing Daniel, Cornelia, David, Peter) > > On 08/18/20 14:22, Igor Mammedov wrote: >> It will allow firmware to notify QEMU that firmware requires SMI >> being triggered on CPU hot[

Re: [PATCH v2] qemu-img: Explicit number replaced by a constant

2020-08-19 Thread Stefano Garzarella
On Wed, Aug 19, 2020 at 09:36:07AM +0800, Yi Li wrote: > Signed-off-by: Yi Li > --- > qemu-img.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/qemu-img.c b/qemu-img.c > index 5308773811..aa2e31c8ae 100644 > --- a/qemu-img.c > +++ b/qemu-img.c > @@ -1200,10 +

Re: [PATCH v2 1/7] x86: lpc9: let firmware negotiate 'CPU hotplug with SMI' features

2020-08-19 Thread Cornelia Huck
On Wed, 19 Aug 2020 10:39:04 +0200 Laszlo Ersek wrote: > Hi Igor, > > (CC'ing Daniel, Cornelia, David, Peter) > > On 08/18/20 14:22, Igor Mammedov wrote: > > It will allow firmware to notify QEMU that firmware requires SMI > > being triggered on CPU hot[un]plug, so that it would be able to acco

Re: [PATCH] tests: docker: support mxe-based mingw builds

2020-08-19 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200819080206.27423-1-pbonz...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ==

Re: [PATCH-for-5.2] memory: Add trace events to audit MemoryRegionOps fields

2020-08-19 Thread Stefan Hajnoczi
On Tue, Aug 18, 2020 at 09:56:37AM +0200, Philippe Mathieu-Daudé wrote: > On 8/18/20 8:32 AM, Paolo Bonzini wrote: > > On 06/08/20 17:26, Philippe Mathieu-Daudé wrote: > >> Add trace events to audit MemoryRegionOps field such: > >> - are all the valid/impl fields provided? > >> - is the region a

Re: [PATCH v2 1/7] x86: lpc9: let firmware negotiate 'CPU hotplug with SMI' features

2020-08-19 Thread Laszlo Ersek
On 08/19/20 10:58, Cornelia Huck wrote: > I consider any patch that adds compat options without adding all compat > machines first to be buggy. We had that in the past, and it had been > painful to sort it out again later. That's why I usually post a compat > machines patch during hardfreeze, to b

Re: [ovirt-devel] Re: device compatibility interface for live migration with assigned devices

2020-08-19 Thread Jason Wang
On 2020/8/19 下午4:13, Yan Zhao wrote: On Wed, Aug 19, 2020 at 03:39:50PM +0800, Jason Wang wrote: On 2020/8/19 下午2:59, Yan Zhao wrote: On Wed, Aug 19, 2020 at 02:57:34PM +0800, Jason Wang wrote: On 2020/8/19 上午11:30, Yan Zhao wrote: hi All, could we decide that sysfs is the interface that ev

Re: [PATCH] pc-bios: s390x: Only set lowcore iplb address on list-directed IPL

2020-08-19 Thread Janosch Frank
On 8/17/20 7:51 PM, Jason J. Herne wrote: > On 8/17/20 12:30 PM, Cornelia Huck wrote: >> On Mon, 17 Aug 2020 10:17:34 -0400 >> "Jason J. Herne" wrote: >> >>> The POP states that the IPLB location is only written to 0x14 for >>> list-directed IPL. Some operating systems expect 0x14 to not change on

Re: [RFC v3 1/1] memory: Skip bad range assertion if notifier supports arbitrary masks

2020-08-19 Thread Jason Wang
On 2020/8/19 下午4:22, Eugenio Perez Martin wrote: On Wed, Aug 19, 2020 at 9:15 AM Jason Wang wrote: On 2020/8/18 下午10:24, Eugenio Perez Martin wrote: On Wed, Aug 12, 2020 at 10:49 AM Eugenio Perez Martin wrote: On Wed, Aug 12, 2020 at 4:24 AM Jason Wang wrote: On 2020/8/12 上午1:55, Eugen

Re: What is bs->reqs_lock for?

2020-08-19 Thread Vladimir Sementsov-Ogievskiy
18.08.2020 09:16, Paolo Bonzini wrote: On 13/08/20 18:34, Vladimir Sementsov-Ogievskiy wrote: I thought bs is attached to one aio context and aio context attached to one iothread. For now yes, but with multiqueue there would be many iothreads sending requests to the AioContext. The BDS would

Re: device compatibility interface for live migration with assigned devices

2020-08-19 Thread Jason Wang
On 2020/8/19 下午1:58, Parav Pandit wrote: From: Yan Zhao Sent: Wednesday, August 19, 2020 9:01 AM On Tue, Aug 18, 2020 at 09:39:24AM +, Parav Pandit wrote: Please refer to my previous email which has more example and details. hi Parav, the example is based on a new vdpa tool running ove

Re: [PATCH] pc-bios: s390x: Only set lowcore iplb address on list-directed IPL

2020-08-19 Thread Cornelia Huck
On Wed, 19 Aug 2020 11:32:34 +0200 Janosch Frank wrote: > On 8/17/20 7:51 PM, Jason J. Herne wrote: > > On 8/17/20 12:30 PM, Cornelia Huck wrote: > >> On Mon, 17 Aug 2020 10:17:34 -0400 > >> "Jason J. Herne" wrote: > >> > >>> The POP states that the IPLB location is only written to 0x14 for

[PULL v4 000/150] Meson-based build system

2020-08-19 Thread Paolo Bonzini
The following changes since commit d0ed6a69d399ae193959225cdeaa9382746c91cc: Update version for v5.1.0 release (2020-08-11 17:07:03 +0100) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for-upstream for you to fetch changes up to ab7ac9b093f9d6d7878028b87ad

Re: [PATCH v5 1/5] block/io: fix bdrv_co_block_status_above

2020-08-19 Thread Vladimir Sementsov-Ogievskiy
Thanks a lot for reviewing! 18.08.2020 17:15, Alberto Garcia wrote: On Wed 10 Jun 2020 02:04:22 PM CEST, Vladimir Sementsov-Ogievskiy wrote: + * The top layer deferred to this layer, and because this layer is + * short, any zeroes that we synthesize beyond EOF behave as

Re: virtio-vsock requires 'disable-legacy=on' in QEMU 5.1

2020-08-19 Thread Auger Eric
Hi, On 8/13/20 12:37 PM, Cornelia Huck wrote: > On Thu, 13 Aug 2020 12:24:30 +0200 > Stefano Garzarella wrote: > >> On Thu, Aug 13, 2020 at 11:28:20AM +0200, Cornelia Huck wrote: >>> On Thu, 13 Aug 2020 11:16:56 +0200 >>> Stefano Garzarella wrote: >>> Hi, Qinghua discovered tha

Re: [PATCH v6 1/4] copy-on-read: Support preadv/pwritev_part functions

2020-08-19 Thread Vladimir Sementsov-Ogievskiy
19.08.2020 00:24, Andrey Shinkevich wrote: Add support for the recently introduced functions bdrv_co_preadv_part() and bdrv_co_pwritev_part() to the COR-filter driver. Signed-off-by: Andrey Shinkevich Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [RFC PATCH 20/22] block/export: Add block-export-del

2020-08-19 Thread Max Reitz
On 13.08.20 18:29, Kevin Wolf wrote: > Implement a new QMP command block-export-del and make nbd-server-remove > a wrapper around it. > > Signed-off-by: Kevin Wolf > --- > qapi/block-export.json | 30 +++ > include/block/nbd.h| 1 - > block/export/export.c

Re: [PATCH V2] Introduce a new flag for piix to disable root bus PCI hotplug

2020-08-19 Thread Igor Mammedov
On Tue, 11 Aug 2020 18:42:08 +0530 Ani Sinha wrote: > We introduce a new global flag for PIIX with which we can turn on or off PCI > device hotplug on the root bus. This flag can be used to prevent all PCI > devices from getting hotplugged or unplugged from the root PCI bus. Tested-by: Igor Mamm

[PATCH v2 02/21] m25p80: Add support for mx25l25635f

2020-08-19 Thread Cédric Le Goater
The mx25l25635f is an extenstion of the mx25l25635e. It includes QPI support, 4-Byte Address Command Set and faster transfers. See this document for more details : https://www.macronix.com/Lists/ApplicationNote/Attachments/1892/AN0200V1_MGRT_MX25L25635E_25735E%20to%20MX25L25635F_25735F.pdf Both d

[PATCH v2 13/21] ftgmac100: Check for invalid len and address before doing a DMA transfer

2020-08-19 Thread Cédric Le Goater
According to the Aspeed specs, no interrupts are raised in that case but a "Tx-packets lost" status seems like a good modeling choice for all implementations. It is covered by the Linux kernel. Cc: Frederic Konrad Reviewed-by: Joel Stanley Signed-off-by: Cédric Le Goater --- hw/net/ftgmac100.c

[PATCH v2 01/21] m25p80: Return the JEDEC ID twice for mx25l25635e

2020-08-19 Thread Cédric Le Goater
The mx25l25635e returns the JEDEC ID twice when issuing a RDID command : [2.512027] aspeed-smc 1e63.spi: reading JEDEC ID C2:20:19:C2:20:19 This can break some firmware testing for this condition on the supermicrox11-bmc machine. Reported-by: erik-smit Signed-off-by: Cédric Le Goater

[PATCH v2 04/21] aspeed/scu: Fix valid access size on AST2400

2020-08-19 Thread Cédric Le Goater
The read access size of the SCU registers can be 1/2/4 bytes and write is 4 bytes and all Aspeed models would need a .valid.accepts() handler. For the moment, set the min access size to 1 byte to cover both read and write operations on the AST2400 but keep the min access size of the other SoCs to

[PATCH v2 07/21] aspeed/smc: Fix max_slaves of the legacy SMC device

2020-08-19 Thread Cédric Le Goater
The legacy controller only has one slave. Reviewed-by: Joel Stanley Signed-off-by: Cédric Le Goater --- hw/ssi/aspeed_smc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ssi/aspeed_smc.c b/hw/ssi/aspeed_smc.c index 0646e0dca72e..8c79a5552f93 100644 --- a/hw/ssi/aspeed_s

[PATCH v2 18/21] aspeed/sdmc: Simplify calculation of RAM bits

2020-08-19 Thread Cédric Le Goater
Changes in commit 533eb415df2e ("arm/aspeed: actually check RAM size") introduced a 'valid_ram_sizes' array which can be used to compute the associated bit field value encoding the RAM size. The field is simply the index of the array. Reviewed-by: Joel Stanley Signed-off-by: Cédric Le Goater ---

[PATCH v2 16/21] aspeed/sdmc: Perform memory training

2020-08-19 Thread Cédric Le Goater
From: Joel Stanley This allows qemu to run the "normal" power on reset boot path through u-boot, where the DDR is trained. An enhancement would be to have the SCU bit stick across qemu reboots, but be unset on initial boot. Proper modelling would be to discard all writes to the phy setting regs

[PATCH v2 00/21] aspeed: cleanups and some extensions

2020-08-19 Thread Cédric Le Goater
Hello, This series includes various fixes improving the support of Aspeed machines. Extra attention was given to the robustness of the ftgmac100 model. A small kernel module tester was created for this purpose : https://github.com/legoater/ftgmac100-test/ Changes in v2 : - definitions for s

[PATCH v2 03/21] m25p80: Add support for n25q512ax3

2020-08-19 Thread Cédric Le Goater
Datasheet available here : https://www.micron.com/-/media/client/global/Documents/Products/Data%20Sheet/NOR%20Flash/Serial%20NOR/N25Q/n25q_512mb_1ce_3v_65nm.pdf Reviewed-by: Joel Stanley Signed-off-by: Cédric Le Goater --- hw/block/m25p80.c | 1 + 1 file changed, 1 insertion(+) diff --git a/h

[PATCH v2 05/21] hw/arm/aspeed: Add board model for Supermicro X11 BMC

2020-08-19 Thread Cédric Le Goater
From: erik-smit The BMC Firmware can be downloaded from : https://www.supermicro.com/en/products/motherboard/X11SSL-F Signed-off-by: erik-smit Reviewed-by: Joel Stanley Reviewed-by: Cédric Le Goater [ clg: Modified commit log ] Message-Id: <20200715173418.186-1-erik.lucas.s...@gmail.com> S

[PATCH v2 11/21] ftgmac100: Fix interrupt status "Packet moved to RX FIFO"

2020-08-19 Thread Cédric Le Goater
As we don't model the RX or TX FIFO, raise the "Packet moved to RX FIFO" interrupt status bit as soon as we are handling a RX packet. Cc: Frederic Konrad Reviewed-by: Joel Stanley Signed-off-by: Cédric Le Goater --- hw/net/ftgmac100.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) di

[PATCH v2 06/21] aspeed/smc: Fix MemoryRegionOps definition

2020-08-19 Thread Cédric Le Goater
Unaligned access support is a leftover from the initial commit. There is no such need on this device register mapping. Remove it. Cc: Michael S. Tsirkin Reviewed-by: Joel Stanley Signed-off-by: Cédric Le Goater --- hw/ssi/aspeed_smc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/ssi

[PATCH v2 17/21] aspeed/sdmc: Allow writes to unprotected registers

2020-08-19 Thread Cédric Le Goater
From: Joel Stanley A subset of registers are not protected by the lock behaviour, so allow unconditionally writing to those. Signed-off-by: Joel Stanley Signed-off-by: Cédric Le Goater --- hw/misc/aspeed_sdmc.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/h

[PATCH v2 12/21] ftgmac100: Change interrupt status when a DMA error occurs

2020-08-19 Thread Cédric Le Goater
The model uses today the "Normal priority transmit buffer unavailable" interrupt status which it is not appropriate. According to the Aspeed specs, no interrupts are raised in that case. An "AHB error" status seems like a better modeling choice for all implementations since it is covered by the Lin

[PATCH v2 15/21] ftgmac100: Improve software reset

2020-08-19 Thread Cédric Le Goater
The software reset of the MAC needs a finer granularity. Some settings in MACCR are kept. Cc: Frederic Konrad Fixes: bd44300d1afc ("net: add FTGMAC100 support") Signed-off-by: Cédric Le Goater --- hw/net/ftgmac100.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff

[PATCH v2 10/21] ftgmac100: Fix interrupt status "Packet transmitted on ethernet"

2020-08-19 Thread Cédric Le Goater
The second field of the TX descriptor has a set of flags to choose when the transmit interrupt is raised : after the packet has been sent on the ethernet or after it has been moved into the TX FIFO. But we don't model that today. Simply raise the "Packet transmitted on ethernet" interrupt status b

[PATCH v2 14/21] ftgmac100: Fix integer overflow in ftgmac100_do_tx()

2020-08-19 Thread Cédric Le Goater
When inserting the VLAN tag in packets, memmove() can generate an integer overflow for packets whose length is less than 12 bytes. Move the VLAN insertion when the last segment of the frame is reached and check length against the size of the ethernet header (14 bytes) to avoid the crash. Return FT

[PATCH v2 19/21] aspeed/smc: Open AHB window of the second chip of the AST2600 FMC controller

2020-08-19 Thread Cédric Le Goater
This change works around the HW default values to be able to test the Tacoma board with -kernel command line option. This was required when we had both flash chips enabled in the device tree, otherwise Linux would fail to probe the entire controller leaving it with no rootfs. Reviewed-by: Joel Sta

[PATCH v2 08/21] aspeed/sdhci: Fix reset sequence

2020-08-19 Thread Cédric Le Goater
BIT(0) of the ASPEED_SDHCI_INFO register is set by SW and polled until the bit is cleared by HW. Use the number of supported slots to define the default value of this register (The AST2600 eMMC Controller only has one). Fix the reset sequence by clearing automatically the RESET bit. Cc: Eddie Jam

Re: [PATCH-for-5.2] memory: Add trace events to audit MemoryRegionOps fields

2020-08-19 Thread Philippe Mathieu-Daudé
On 8/19/20 11:14 AM, Stefan Hajnoczi wrote: > On Tue, Aug 18, 2020 at 09:56:37AM +0200, Philippe Mathieu-Daudé wrote: >> On 8/18/20 8:32 AM, Paolo Bonzini wrote: >>> On 06/08/20 17:26, Philippe Mathieu-Daudé wrote: Add trace events to audit MemoryRegionOps field such: - are all the val

[PATCH v2 20/21] arm: aspeed: add strap define `25HZ` of AST2500

2020-08-19 Thread Cédric Le Goater
From: Igor Kononenko Provide a definition for the "25Hz reference clock input mode" strap Signed-off-by: Igor Kononenko Reviewed-by: Cédric Le Goater Message-Id: <20200811203502.20382-1-i.konone...@yadro.com> Signed-off-by: Cédric Le Goater --- include/hw/misc/aspeed_scu.h | 1 + 1 file chan

[PATCH v2 09/21] ftgmac100: Fix registers that can be read

2020-08-19 Thread Cédric Le Goater
Receive Ring Base Address Register (RXR_BADR) and the Normal Priority Transmit Receive Ring Base Address Register (NPTXR_BADR) can also be read. Cc: Frederic Konrad Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Joel Stanley Signed-off-by: Cédric Le Goater --- hw/net/ftgmac100.c | 4 1

Re: [PATCH v6 2/4] copy-on-read: add filter append/drop functions

2020-08-19 Thread Vladimir Sementsov-Ogievskiy
19.08.2020 00:24, Andrey Shinkevich wrote: Provide API for the COR-filter insertion/removal. Also, drop the filter child permissions for an inactive state when the filter node is being removed. Signed-off-by: Andrey Shinkevich --- block/copy-on-read.c | 103 +++

[PATCH v2 21/21] hw: add a number of SPI-flash's of m25p80 family

2020-08-19 Thread Cédric Le Goater
From: Igor Kononenko Support a following SPI flashes: * mx66l51235f * mt25ql512ab Signed-off-by: Igor Kononenko Reviewed-by: Cédric Le Goater Message-Id: <20200811203724.20699-1-i.konone...@yadro.com> Signed-off-by: Cédric Le Goater --- hw/block/m25p80.c | 2 ++ 1 file changed, 2 insertions(

Re: [PATCH 00/18] hw/riscv: Add Microchip PolarFire SoC Icicle Kit board support

2020-08-19 Thread via
On 8/19/20 2:34 AM, Bin Meng wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Tue, Aug 18, 2020 at 9:55 PM Anup Patel wrote: >> On Tue, Aug 18, 2020 at 6:39 PM wrote: >>> On 8/18/20 7:17 AM, Anup Patel wrote: EXTERNAL EMAIL: Do not

Re: [PATCH v6 3/4] qapi: add filter-node-name to block-stream

2020-08-19 Thread Vladimir Sementsov-Ogievskiy
19.08.2020 00:24, Andrey Shinkevich wrote: Provide the possibility to pass the 'filter-node-name' parameter to the block-stream job as it is done for the commit block job. That will be needed for further iotests implementations. and for users as well. I think, the last sentence may be dropped.

[PATCH V4] Introduce a new flag for i440fx to disable PCI hotplug on the root bus

2020-08-19 Thread Ani Sinha
We introduce a new global flag 'acpi-root-pci-hotplug' for i440fx with which we can turn on or off PCI device hotplug on the root bus. This flag can be used to prevent all PCI devices from getting hotplugged or unplugged from the root PCI bus. This feature is targetted mostly towards Windows VMs. I

Re: [PATCH V2] Introduce a new flag for piix to disable root bus PCI hotplug

2020-08-19 Thread Ani Sinha
On Wed, Aug 19, 2020 at 3:30 PM Igor Mammedov wrote: > > On Tue, 11 Aug 2020 18:42:08 +0530 > Ani Sinha wrote: > > > We introduce a new global flag for PIIX with which we can turn on or off PCI > > device hotplug on the root bus. This flag can be used to prevent all PCI > > devices from getting h

Re: [PATCH] tests: docker: support mxe-based mingw builds

2020-08-19 Thread Paolo Bonzini
On 19/08/20 10:20, Daniel P. Berrangé wrote: > We already have docker containers with MXE based on Debian: > > debian-win32-cross.docker > debian-win64-cross.docker > > your image uses a different naming convention, and puts both > 32 and 64 bit in the same image. Yeah, that's what test-ming

Re: [PATCH v6 4/4] block: apply COR-filter to block-stream jobs

2020-08-19 Thread Vladimir Sementsov-Ogievskiy
19.08.2020 00:24, Andrey Shinkevich wrote: The patch completes the series with the COR-filter insertion to any block-stream operation. It also makes changes to the iotests 030. The test case 'test_stream_parallel' was deleted due to multiple errors. "case deleted due to errors" is a bad reasoni

Re: [PULL v4 000/150] Meson-based build system

2020-08-19 Thread Peter Maydell
On Wed, 19 Aug 2020 at 10:49, Paolo Bonzini wrote: > > The following changes since commit d0ed6a69d399ae193959225cdeaa9382746c91cc: > > Update version for v5.1.0 release (2020-08-11 17:07:03 +0100) > > are available in the Git repository at: > > https://gitlab.com/bonzini/qemu.git tags/for-ups

Re: [PATCH] pc-bios: s390x: Only set lowcore iplb address on list-directed IPL

2020-08-19 Thread Janosch Frank
On 8/19/20 11:45 AM, Cornelia Huck wrote: > On Wed, 19 Aug 2020 11:32:34 +0200 > Janosch Frank wrote: > >> On 8/17/20 7:51 PM, Jason J. Herne wrote: >>> On 8/17/20 12:30 PM, Cornelia Huck wrote: On Mon, 17 Aug 2020 10:17:34 -0400 "Jason J. Herne" wrote: > The POP states th

Re: [PATCH v7 27/47] blkverify: Use bdrv_sum_allocated_file_size()

2020-08-19 Thread Kevin Wolf
Am 25.06.2020 um 17:21 hat Max Reitz geschrieben: > blkverify is a filter, so bdrv_get_allocated_file_size()'s default > implementation will return only the size of its filtered child. > However, because both of its children are disk images, it makes more > sense to sum both of their allocated size

[Bug 1886155] Re: error: argument 2 of ‘__atomic_load’ discards ‘const’ qualifier

2020-08-19 Thread Jonathan Wakely
Which means that given an argument of type T * const this defines a local variable that is also T * const, and then tries to store the result of the atomic load into that const variable: ``` #define atomic_rcu_read(ptr) \ ({

[Bug 1886155] Re: error: argument 2 of ‘__atomic_load’ discards ‘const’ qualifier

2020-08-19 Thread Jonathan Wakely
It looks like `typeof_strip_qual` doesn't work for pointer types. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1886155 Title: error: argument 2 of ‘__atomic_load’ discards ‘const’ qualifier Statu

[PATCH 0/3] vhost-vsock: force virtio version 1

2020-08-19 Thread Stefano Garzarella
Recenlty changes in QEMU 5.1 requires to set 'disable-legacy=3Don' on vhost-vsock-pci and vhost-user-vsock-pci devices: $ ./qemu-system-x86_64 ... -device vhost-vsock-pci,guest-cid=3D5 qemu-system-x86_64: -device vhost-vsock-pci,guest-cid=3D5: device is modern-only, use disable

[PATCH 2/3] vhost-user-vsock-pci: force virtio version 1

2020-08-19 Thread Stefano Garzarella
Commit 9b3a35ec82 ("virtio: verify that legacy support is not accidentally on") added a safety checks that requires to set 'disable-legacy=on' on vhost-user-vsock-pci device: $ ./qemu-system-x86_64 ... \ -chardev socket,id=char0,reconnect=0,path=/tmp/vhost4.socket \ -device vhost-user-

[PATCH 3/3] vhost-vsock-ccw: force virtio version 1

2020-08-19 Thread Stefano Garzarella
virtio-vsock was introduced after the release of VIRTIO 1.0 specifications, so it should be 'modern-only'. This patch forces virtio version 1 as done for vhost-vsock-pci. Cc: qemu-sta...@nongnu.org Suggested-by: Cornelia Huck Signed-off-by: Stefano Garzarella --- hw/s390x/vhost-vsock-ccw.c | 2

[PATCH 1/3] vhost-vsock-pci: force virtio version 1

2020-08-19 Thread Stefano Garzarella
Commit 9b3a35ec82 ("virtio: verify that legacy support is not accidentally on") added a safety checks that requires to set 'disable-legacy=on' on vhost-vsock-pci device: $ ./qemu-system-x86_64 ... -device vhost-vsock-pci,guest-cid=5 qemu-system-x86_64: -device vhost-vsock-pci,guest-cid

Re: [RFC PATCH 21/22] block/export: Move blk to BlockExport

2020-08-19 Thread Max Reitz
On 13.08.20 18:29, Kevin Wolf wrote: > Every block export has a BlockBackend representing the disk that is > exported. It should live in BlockExport therefore. > > Signed-off-by: Kevin Wolf > --- > include/block/export.h | 3 +++ > block/export/export.c | 3 +++ > nbd/server.c | 44

Re: [PATCH v7 25/47] block: Def. impl.s for get_allocated_file_size

2020-08-19 Thread Kevin Wolf
Am 25.06.2020 um 17:21 hat Max Reitz geschrieben: > If every BlockDriver were to implement bdrv_get_allocated_file_size(), > there are basically three ways it would be handled: > (1) For protocol drivers: Figure out the actual allocated file size in > some protocol-specific way > (2) For protoc

Re: [RFC PATCH 22/22] block/export: Add query-block-exports

2020-08-19 Thread Max Reitz
On 13.08.20 18:29, Kevin Wolf wrote: > This adds a simple QMP command to query the list of block exports. > > Signed-off-by: Kevin Wolf > --- > qapi/block-export.json | 33 + > block/export/export.c | 23 +++ > 2 files changed, 56 insertions(+

Re: [PATCH 01/11] hw/arm/virt-acpi-build:Remove dead assignment in build_madt()

2020-08-19 Thread Igor Mammedov
On Thu, 13 Aug 2020 15:37:02 +0800 Chen Qun wrote: > Clang static code analyzer show warning: > hw/arm/virt-acpi-build.c:641:5: warning: Value stored to 'madt' is never read > madt = acpi_data_push(table_data, sizeof *madt); > ^ Reviewed-by:

Re: [PATCH 0/3] vhost-vsock: force virtio version 1

2020-08-19 Thread David Hildenbrand
On 19.08.20 12:51, Stefano Garzarella wrote: > Recenlty changes in QEMU 5.1 requires to set 'disable-legacy=3Don' > on vhost-vsock-pci and vhost-user-vsock-pci devices: > > $ ./qemu-system-x86_64 ... -device vhost-vsock-pci,guest-cid=3D5 > qemu-system-x86_64: -device vhost-vsock-pci,gu

Re: [PATCH] tests: docker: support mxe-based mingw builds

2020-08-19 Thread Daniel P . Berrangé
On Wed, Aug 19, 2020 at 12:42:44PM +0200, Paolo Bonzini wrote: > On 19/08/20 10:20, Daniel P. Berrangé wrote: > > We already have docker containers with MXE based on Debian: > > > > debian-win32-cross.docker > > debian-win64-cross.docker > > > > your image uses a different naming convention,

Re: [PATCH 0/3] vhost-vsock: force virtio version 1

2020-08-19 Thread Stefano Garzarella
On Wed, Aug 19, 2020 at 01:06:55PM +0200, David Hildenbrand wrote: > On 19.08.20 12:51, Stefano Garzarella wrote: > > Recenlty changes in QEMU 5.1 requires to set 'disable-legacy=3Don' > > on vhost-vsock-pci and vhost-user-vsock-pci devices: > > > > $ ./qemu-system-x86_64 ... -device vhost-vso

Re: [PATCH v4 2/3] hw/i386: Update the EPYC topology to use socket/dies/core/thread model

2020-08-19 Thread Igor Mammedov
On Fri, 14 Aug 2020 16:39:33 -0500 Babu Moger wrote: > Update the EPYC topology to use socket/dies/core/thread model. The EPYC > model does not use the smp dies to build the topology. Instead, it uses > numa nodes to build the topology. Internally both are similar concept > which divides the core

Re: [PATCH] audio/jack: fix use after free segfault

2020-08-19 Thread Christian Schoenebeck
On Mittwoch, 19. August 2020 00:20:07 CEST Geoffrey McRae wrote: > > Could you please describe in more detail how you ran into this > > situation with > > your 2nd audio device? > > Sure. Run a Windows guest with two audio devices, let it boot up, then > restart > the jack service to trigger the r

Re: [PATCH v5 1/5] block/io: fix bdrv_co_block_status_above

2020-08-19 Thread Alberto Garcia
On Wed 19 Aug 2020 11:48:25 AM CEST, Vladimir Sementsov-Ogievskiy wrote: >>> + * The top layer deferred to this layer, and because this >>> layer is >>> + * short, any zeroes that we synthesize beyond EOF behave as >>> if they >>> + * were allocated at this lay

Re: [PATCH] tests: docker: support mxe-based mingw builds

2020-08-19 Thread Paolo Bonzini
On 19/08/20 13:09, Daniel P. Berrangé wrote: > On Wed, Aug 19, 2020 at 12:42:44PM +0200, Paolo Bonzini wrote: >> On 19/08/20 10:20, Daniel P. Berrangé wrote: >>> We already have docker containers with MXE based on Debian: >>> >>> debian-win32-cross.docker >>> debian-win64-cross.docker >>> >>> y

Re: [PATCH] audio/jack: fix use after free segfault

2020-08-19 Thread Geoffrey McRae
On 2020-08-19 21:30, Christian Schoenebeck wrote: On Mittwoch, 19. August 2020 00:20:07 CEST Geoffrey McRae wrote: > Could you please describe in more detail how you ran into this > situation with > your 2nd audio device? Sure. Run a Windows guest with two audio devices, let it boot up, then re

Re: [PATCH 1/3] vhost-vsock-pci: force virtio version 1

2020-08-19 Thread Cornelia Huck
On Wed, 19 Aug 2020 12:51:54 +0200 Stefano Garzarella wrote: > Commit 9b3a35ec82 ("virtio: verify that legacy support is not > accidentally on") added a safety checks that requires to set Nit: s/checks/check/ (also in patch 2) > 'disable-legacy=on' on vhost-vsock-pci device: > > $ ./qemu-s

Re: [RFC PATCH 19/22] block/export: Move strong user reference to block_exports

2020-08-19 Thread Max Reitz
On 13.08.20 18:29, Kevin Wolf wrote: > The reference owned by the user/monitor that is created when adding the > export and dropped when removing it was tied to the 'exports' list in > nbd/server.c. Every block export will have a user reference, so move it > to the block export level and tie it to

Re: [PATCH 2/3] vhost-user-vsock-pci: force virtio version 1

2020-08-19 Thread Cornelia Huck
On Wed, 19 Aug 2020 12:51:55 +0200 Stefano Garzarella wrote: > Commit 9b3a35ec82 ("virtio: verify that legacy support is not > accidentally on") added a safety checks that requires to set > 'disable-legacy=on' on vhost-user-vsock-pci device: > > $ ./qemu-system-x86_64 ... \ > -chardev so

Re: [PATCH 3/3] vhost-vsock-ccw: force virtio version 1

2020-08-19 Thread Cornelia Huck
On Wed, 19 Aug 2020 12:51:56 +0200 Stefano Garzarella wrote: > virtio-vsock was introduced after the release of VIRTIO 1.0 > specifications, so it should be 'modern-only'. > > This patch forces virtio version 1 as done for vhost-vsock-pci. > > Cc: qemu-sta...@nongnu.org > Suggested-by: Cornelia

Re: [PATCH v5 1/5] block/io: fix bdrv_co_block_status_above

2020-08-19 Thread Vladimir Sementsov-Ogievskiy
19.08.2020 14:34, Alberto Garcia wrote: On Wed 19 Aug 2020 11:48:25 AM CEST, Vladimir Sementsov-Ogievskiy wrote: + * The top layer deferred to this layer, and because this layer is + * short, any zeroes that we synthesize beyond EOF behave as if they + * were

Re: [RFC PATCH 22/22] block/export: Add query-block-exports

2020-08-19 Thread Kevin Wolf
Am 19.08.2020 um 13:04 hat Max Reitz geschrieben: > On 13.08.20 18:29, Kevin Wolf wrote: > > This adds a simple QMP command to query the list of block exports. > > > > Signed-off-by: Kevin Wolf > > --- > > qapi/block-export.json | 33 + > > block/export/export.c

Re: [PATCH 1/3] vhost-vsock-pci: force virtio version 1

2020-08-19 Thread Stefano Garzarella
On Wed, Aug 19, 2020 at 01:55:42PM +0200, Cornelia Huck wrote: > On Wed, 19 Aug 2020 12:51:54 +0200 > Stefano Garzarella wrote: > > > Commit 9b3a35ec82 ("virtio: verify that legacy support is not > > accidentally on") added a safety checks that requires to set > > Nit: s/checks/check/ (also in p

Re: [PATCH v4 3/3] hw/i386: Remove node_id, nr_nodes and nodes_per_pkg from topology

2020-08-19 Thread Igor Mammedov
On Fri, 14 Aug 2020 16:39:40 -0500 Babu Moger wrote: > Remove node_id, nr_nodes and nodes_per_pkg from topology. Use > die_id, nr_dies and dies_per_pkg which is already available. > Removes the confusion over two variables. > > With node_id removed in topology the uninitialized memory issue > wi

Re: [PATCH 1/3] vhost-vsock-pci: force virtio version 1

2020-08-19 Thread Cornelia Huck
On Wed, 19 Aug 2020 14:09:10 +0200 Stefano Garzarella wrote: > On Wed, Aug 19, 2020 at 01:55:42PM +0200, Cornelia Huck wrote: > > On Wed, 19 Aug 2020 12:51:54 +0200 > > Stefano Garzarella wrote: > > > > > Commit 9b3a35ec82 ("virtio: verify that legacy support is not > > > accidentally on") ad

Re: [PATCH v2 1/7] x86: lpc9: let firmware negotiate 'CPU hotplug with SMI' features

2020-08-19 Thread Igor Mammedov
On Wed, 19 Aug 2020 11:14:45 +0200 Laszlo Ersek wrote: > On 08/19/20 10:58, Cornelia Huck wrote: > > > I consider any patch that adds compat options without adding all compat > > machines first to be buggy. We had that in the past, and it had been > > painful to sort it out again later. That's w

Re: [PATCH v7 14/47] stream: Deal with filters

2020-08-19 Thread Max Reitz
On 10.08.20 13:04, Vladimir Sementsov-Ogievskiy wrote: > 10.08.2020 11:12, Max Reitz wrote: >> On 07.08.20 12:29, Vladimir Sementsov-Ogievskiy wrote: [...] >>> But, with our proposed way (freeze only chain up to base_overlay >>> inclusively, and use backing(base_overlay) as final backing), all wi

[Bug 1883984] Re: QEMU S/390x sqxbr (128-bit IEEE 754 square root) crashes qemu-system-s390x

2020-08-19 Thread Launchpad Bug Tracker
** Merge proposal linked: https://code.launchpad.net/~paelzer/ubuntu/+source/qemu/+git/qemu/+merge/389527 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1883984 Title: QEMU S/390x sqxbr (128-bit

  1   2   3   4   >