[RFC PATCH v3 04/34] Hexagon (target/hexagon) scalar core definition

2020-08-18 Thread Taylor Simpson
Add target state header, target definitions and initialization routines Signed-off-by: Taylor Simpson --- target/hexagon/cpu-param.h | 26 target/hexagon/cpu.h | 164 +++ target/hexagon/cpu_bits.h | 34 + target/hexagon/internal.h | 40 ++ target/hexag

[RFC PATCH v3 13/34] Hexagon (target/hexagon) register map

2020-08-18 Thread Taylor Simpson
Certain operand types represent a non-contiguous set of values. For example, the compound compare-and-jump instruction can only access registers R0-R7 and R16-23. This table represents the mapping from the encoding to the actual values. Signed-off-by: Taylor Simpson --- target/hexagon/regmap.h |

[RFC PATCH v3 15/34] Hexagon (target/hexagon) instruction printing

2020-08-18 Thread Taylor Simpson
Signed-off-by: Taylor Simpson --- target/hexagon/printinsn.h | 26 + target/hexagon/printinsn.c | 94 ++ 2 files changed, 120 insertions(+) create mode 100644 target/hexagon/printinsn.h create mode 100644 target/hexagon/printinsn.c diff -

[RFC PATCH v3 01/34] Hexagon Update MAINTAINERS file

2020-08-18 Thread Taylor Simpson
Add Taylor Simpson as the Hexagon target maintainer Signed-off-by: Taylor Simpson --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 0886eb3..d85da55 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -184,6 +184,14 @@ F: include/hw/cris/ F: t

Re: [PATCH 2/6] vhost-user-server: drop unused #include

2020-08-18 Thread Stefan Hajnoczi
On Mon, Aug 17, 2020 at 08:49:27PM +0800, Coiby Xu wrote: > On Fri, Jun 19, 2020 at 01:00:42PM +0100, Stefan Hajnoczi wrote: > > Signed-off-by: Stefan Hajnoczi > > --- > > util/vhost-user-server.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/util/vhost-user-server.c b/util/vhost-u

[RFC PATCH v3 14/34] Hexagon (target/hexagon) instruction/packet decode

2020-08-18 Thread Taylor Simpson
Take the words from instruction memory and build a packet_t for TCG code generation The following operations are performed Convert the .new encoded offset to the register number of the producer Reorder the packet so .new producer is before consumer Apply constant extenders Separate

[RFC PATCH v3 06/34] Hexagon (disas) disassembler

2020-08-18 Thread Taylor Simpson
The Hexagon disassembler calls disassemble_hexagon to decode a packet and format it for printing Signed-off-by: Taylor Simpson --- include/disas/dis-asm.h | 1 + disas/hexagon.c | 62 + disas/Makefile.objs | 1 + 3 files changed, 64 i

[RFC PATCH v3 02/34] Hexagon (target/hexagon) README

2020-08-18 Thread Taylor Simpson
Gives an introduction and overview to the Hexagon target Signed-off-by: Taylor Simpson --- target/hexagon/README | 254 ++ 1 file changed, 254 insertions(+) create mode 100644 target/hexagon/README diff --git a/target/hexagon/README b/target/hexa

[RFC PATCH v3 23/34] Hexagon (target/hexagon) generater phase 4 - decode tree

2020-08-18 Thread Taylor Simpson
Python script that emits the decode tree in dectree_generated.h. Signed-off-by: Taylor Simpson --- target/hexagon/dectree.py | 352 ++ 1 file changed, 352 insertions(+) create mode 100755 target/hexagon/dectree.py diff --git a/target/hexagon/dectree.

[RFC PATCH v3 08/34] Hexagon (target/hexagon) GDB Stub

2020-08-18 Thread Taylor Simpson
GDB register read and write routines Signed-off-by: Taylor Simpson --- target/hexagon/internal.h | 2 ++ target/hexagon/cpu.c | 2 ++ target/hexagon/gdbstub.c | 49 +++ 3 files changed, 53 insertions(+) create mode 100644 target/hexagon/gdbstu

Re: Should I delete created coroutines manually?

2020-08-18 Thread Stefan Hajnoczi
On Mon, Aug 17, 2020 at 2:13 PM Coiby Xu wrote: > I'm working on vhost-user block device backend [1]. When I tested my > patches on the latest version of QEMU (commit > d0ed6a69d399ae193959225cdeaa9382746c91cc) with --enable-sanitizer turned > on, the follow error will be thrown out, > > ==46

[RFC PATCH v3 11/34] Hexagon (target/hexagon) register fields

2020-08-18 Thread Taylor Simpson
Declare bitfields within registers such as user status register (USR) Signed-off-by: Taylor Simpson --- target/hexagon/reg_fields.h | 40 + target/hexagon/reg_fields_def.h | 78 + target/hexagon/reg_fields.c | 28 +++

[RFC PATCH v3 00/34] Hexagon patch series

2020-08-18 Thread Taylor Simpson
This series adds support for the Hexagon processor with Linux user support See patch 02/34 Hexagon README for detailed information. Once the series is applied, the Hexagon port will pass "make check-tcg". The series also includes Hexagon-specific tests in tcg/tests/hexagon. We have a parallel ef

[RFC PATCH v3 16/34] Hexagon (target/hexagon) utility functions

2020-08-18 Thread Taylor Simpson
Utility functions called by various instructions Signed-off-by: Taylor Simpson --- target/hexagon/arch.h | 42 +++ target/hexagon/conv_emu.h | 50 +++ target/hexagon/fma_emu.h | 27 ++ target/hexagon/arch.c | 354 + target/hexagon/conv_emu.c | 369

[RFC PATCH v3 26/34] Hexagon (target/hexagon) macros referenced in instruction semantics

2020-08-18 Thread Taylor Simpson
Signed-off-by: Taylor Simpson --- target/hexagon/macros.h| 620 - target/hexagon/op_helper.c | 21 -- 2 files changed, 619 insertions(+), 22 deletions(-) diff --git a/target/hexagon/macros.h b/target/hexagon/macros.h index 5582dcb..9665bc9 100644

[RFC PATCH v3 34/34] Hexagon build infrastructure

2020-08-18 Thread Taylor Simpson
Add file to default-configs Change configure Add target/hexagon/Makefile.objs Change scripts/qemu-binfmt-conf.sh We can build a hexagon-linux-user target and run programs on the Hexagon scalar core. With hexagon-linux-clang installed, "make check-tcg" will pass. Signed-off-by: Taylor Simpson --

[RFC PATCH v3 24/34] Hexagon (target/hexagon) opcode data structures

2020-08-18 Thread Taylor Simpson
Signed-off-by: Taylor Simpson --- target/hexagon/opcodes.h | 66 +++ target/hexagon/opcodes.c | 211 +++ 2 files changed, 277 insertions(+) create mode 100644 target/hexagon/opcodes.h create mode 100644 target/hexagon/opcodes.c diff --gi

[RFC PATCH v3 05/34] Hexagon (target/hexagon) register names

2020-08-18 Thread Taylor Simpson
Signed-off-by: Taylor Simpson --- target/hexagon/hex_regs.h | 83 +++ 1 file changed, 83 insertions(+) create mode 100644 target/hexagon/hex_regs.h diff --git a/target/hexagon/hex_regs.h b/target/hexagon/hex_regs.h new file mode 100644 index 000..

[RFC PATCH v3 31/34] Hexagon (target/hexagon) translation

2020-08-18 Thread Taylor Simpson
Read the instruction memory Create a packet data structure Generate TCG code for the start of the packet Invoke the generate function for each instruction Generate TCG code for the end of the packet Signed-off-by: Taylor Simpson --- target/hexagon/translate.h | 103 +++ target/hexagon/transl

[RFC PATCH v3 20/34] Hexagon (target/hexagon) generator phase 1 - C preprocessor for semantics

2020-08-18 Thread Taylor Simpson
Run the C preprocessor across the instruction definition files and macro definitoin file to expand macros and prepare the semantics_generated.pyinc file. The resulting file contains one entry with the semantics for each instruction and one line with the instruction attributes associated with each

[RFC PATCH v3 12/34] Hexagon (target/hexagon) instruction attributes

2020-08-18 Thread Taylor Simpson
Signed-off-by: Taylor Simpson --- target/hexagon/attribs.h | 32 +++ target/hexagon/attribs_def.h | 98 2 files changed, 130 insertions(+) create mode 100644 target/hexagon/attribs.h create mode 100644 target/hexagon/attribs_def.h di

Re: [PATCH 2/3] linux user: moving is proc functions to separate file

2020-08-18 Thread Laurent Vivier
Le 18/08/2020 à 01:57, Andrew Aladjev a écrit : > Signed-off-by: Andrew Aladjev > --- > linux-user/Makefile.objs | 5 +++-- > linux-user/syscall.c | 33 + > linux-user/syscall_proc.c | 32 > linux-user/syscall_proc.h | 7 +++

[RFC PATCH v3 29/34] Hexagon (target/hexagon) TCG generation

2020-08-18 Thread Taylor Simpson
Include the generated files and set up the data structures Signed-off-by: Taylor Simpson --- target/hexagon/genptr.h | 25 ++ target/hexagon/genptr.c | 55 + 2 files changed, 80 insertions(+) create mode 100644 target/hexagon/g

[RFC PATCH v3 07/34] Hexagon (target/hexagon) scalar core helpers

2020-08-18 Thread Taylor Simpson
The majority of helpers are generated. Define the helper functions needed then include the generated file Signed-off-by: Taylor Simpson --- target/hexagon/helper.h| 33 target/hexagon/op_helper.c | 368 + 2 files changed, 401 insertions(+)

[RFC PATCH v3 25/34] Hexagon (target/hexagon) macros to interface with the generator

2020-08-18 Thread Taylor Simpson
Various forms of declare, read, write, free Signed-off-by: Taylor Simpson --- target/hexagon/macros.h | 364 1 file changed, 364 insertions(+) create mode 100644 target/hexagon/macros.h diff --git a/target/hexagon/macros.h b/target/hexagon/macro

[RFC PATCH v3 09/34] Hexagon (target/hexagon) architecture types

2020-08-18 Thread Taylor Simpson
Define types used in files imported from the Hexagon architecture library Signed-off-by: Taylor Simpson --- target/hexagon/hex_arch_types.h | 43 + 1 file changed, 43 insertions(+) create mode 100644 target/hexagon/hex_arch_types.h diff --git a/target/he

[RFC PATCH v3 21/34] Hexagon (target/hexagon) generator phase 2 - generate header files

2020-08-18 Thread Taylor Simpson
Python scripts generate the following files helper_protos_generated.h For each instruction we create DEF_HELPER function prototype helper_funcs_generated.h For each instruction we create the helper function definition tcg_funcs_generated.h For each instruction we

[RFC PATCH v3 28/34] Hexagon (target/hexagon) TCG generation helpers

2020-08-18 Thread Taylor Simpson
Helpers for reading and writing registers Helpers for load-locked/store-conditional Signed-off-by: Taylor Simpson --- target/hexagon/genptr_helpers.h | 244 target/hexagon/op_helper.c | 18 +++ 2 files changed, 262 insertions(+) create mode 100644

[RFC PATCH v3 27/34] Hexagon (target/hexagon) instruction classes

2020-08-18 Thread Taylor Simpson
Determine legal VLIW slots for each instruction Signed-off-by: Taylor Simpson --- target/hexagon/iclass.h| 46 target/hexagon/iclass.c| 88 ++ target/hexagon/imported/iclass.def | 52 ++ 3 files

[RFC PATCH v3 17/34] Hexagon (target/hexagon/imported) arch import - macro definitions

2020-08-18 Thread Taylor Simpson
The macro definitions specify instruction attributes that are applied to each instruction that references the macro. The generator will recursively apply attributes to each instruction that used the macro. Signed-off-by: Taylor Simpson --- target/hexagon/imported/macros.def | 1529 ++

[RFC PATCH v3 32/34] Hexagon (linux-user/hexagon) Linux user emulation

2020-08-18 Thread Taylor Simpson
Implementation of Linux user emulation for Hexagon Some common files modified in addition to new files in linux-user/hexagon Signed-off-by: Taylor Simpson --- linux-user/hexagon/sockbits.h | 18 ++ linux-user/hexagon/syscall_nr.h | 343 linux-user/

Re: virtio-vsock requires 'disable-legacy=on' in QEMU 5.1

2020-08-18 Thread Cornelia Huck
On Tue, 18 Aug 2020 17:28:07 +0200 Stefano Garzarella wrote: > On Tue, Aug 18, 2020 at 04:31:01PM +0200, Cornelia Huck wrote: > > > Do you prefer to send them? Otherwise I can do that. > > > > If you already have something on your disk, please go ahead :) > > Yes, I have something for pci,

[RFC PATCH v3 22/34] Hexagon (target/hexagon) generator phase 3 - C preprocessor for decode tree

2020-08-18 Thread Taylor Simpson
Run the C preprocessor across the instruction definition and encoding files to expand macros and prepare the iset.py file. The resulting fill contains python data structures used to build the decode tree. Signed-off-by: Taylor Simpson --- target/hexagon/gen_dectree_import.c | 191 ++

[RFC PATCH v3 30/34] Hexagon (target/hexagon) TCG for instructions with multiple definitions

2020-08-18 Thread Taylor Simpson
Helpers won't work if there are multiple definitions, so we override these instructions using #define fGEN_TCG_. Signed-off-by: Taylor Simpson --- target/hexagon/gen_tcg.h | 198 +++ target/hexagon/helper.h | 2 + target/hexagon/genptr.c | 1 + 3

[PULL v3 000/150] Meson-based build system

2020-08-18 Thread Paolo Bonzini
The following changes since commit d0ed6a69d399ae193959225cdeaa9382746c91cc: Update version for v5.1.0 release (2020-08-11 17:07:03 +0100) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for-upstream for you to fetch changes up to ea922aa50b2a86881eb3750d540

Re: [RFC PATCH] os-posix: fix regression for install-less datadir location

2020-08-18 Thread Paolo Bonzini
On 18/08/20 15:10, Peter Maydell wrote: >> So for example all references to CONFIG_QEMU_DATADIR would invoke >> get_relocatable_path(CONFIG_QEMU_DATADIR), which would return something >> like "/usr/bin/../share/qemu". > Unless you have that series ready-to-roll, I think it would > be useful to just

RE: [PATCH 07/18] hw/sd: sd: Fix incorrect populated function switch status data structure

2020-08-18 Thread Sai Pavan Boddu
Thanks Philippe, I would test this and get back. Regards, Sai Pavan > -Original Message- > From: Philippe Mathieu-Daudé On > Behalf Of Philippe Mathieu-Daudé > Sent: Saturday, August 15, 2020 1:29 PM > To: Bin Meng ; Alistair Francis > ; Bastian Koppelmann paderborn.de>; Palmer Dabbelt

Re: [RFC PATCH v3 00/34] Hexagon patch series

2020-08-18 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1597765847-16637-1-git-send-email-tsimp...@quicinc.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1597765847-16637-1-git-send-email-tsimp...@quicinc.com Subject: [RFC PATCH v3

[RFC PATCH v3 1/5] block/nvme: Use an array of EventNotifier

2020-08-18 Thread Philippe Mathieu-Daudé
In preparation of using multiple IRQ (thus multiple eventfds) make BDRVNVMeState::irq_notifier an array (for now of a single element, the admin queue notifier). Signed-off-by: Philippe Mathieu-Daudé --- block/nvme.c | 28 ++-- 1 file changed, 18 insertions(+), 10 deletion

[RFC PATCH v3 0/5] util/vfio-helpers: Add support for multiple IRQs

2020-08-18 Thread Philippe Mathieu-Daudé
This series intends to setup the VFIO helper to allow binding notifiers on different IRQs. For the NVMe use case, we only care about MSIX interrupts. To not disrupt other users, introduce the qemu_vfio_pci_init_msix_irqs function to initialize multiple MSIX IRQs and attach eventfd to them. Since

[RFC PATCH v3 2/5] util/vfio-helpers: Report error on unsupported host architectures

2020-08-18 Thread Philippe Mathieu-Daudé
The vfio-helpers implementation expects a TYPEv1 IOMMU, see qemu_vfio_init_pci: 263 if (!ioctl(s->container, VFIO_CHECK_EXTENSION, VFIO_TYPE1_IOMMU)) { 264 error_setg_errno(errp, errno, "VFIO IOMMU check failed"); Thus POWER SPAPR IOMMU is obviously not supported. The implementat

[RFC PATCH v3 4/5] util/vfio-helpers: Introduce qemu_vfio_pci_init_msix_irqs()

2020-08-18 Thread Philippe Mathieu-Daudé
qemu_vfio_pci_init_irq() allows us to initialize any type of IRQ, but only one. Introduce qemu_vfio_pci_init_msix_irqs() which is specific to MSIX IRQ type, and allow us to use multiple IRQs (thus passing multiple eventfd notifiers). Signed-off-by: Philippe Mathieu-Daudé --- include/qemu/vfio-he

[RFC PATCH v3 3/5] util/vfio-helpers: Store eventfd using int32_t type

2020-08-18 Thread Philippe Mathieu-Daudé
Per the documentation in linux-headers/linux/vfio.h: VFIO_DEVICE_SET_IRQS * DATA_EVENTFD binds the specified ACTION to the provided __s32 eventfd. Replace the 'int' by an 'int32_t' to match the documentation. Fixes: 418026ca43 ("util: Introduce vfio helpers") Signed-off-by: Philippe Mathieu-D

[RFC PATCH v3 5/5] block/nvme: Use qemu_vfio_pci_init_msix_irqs() to initialize our IRQ

2020-08-18 Thread Philippe Mathieu-Daudé
Instead of initializing one MSIX IRQ with the generic qemu_vfio_pci_init_irq() function, use the MSIX specific one which will allow us to use multiple IRQs. For now we provide an array of a single IRQ. Signed-off-by: Philippe Mathieu-Daudé --- block/nvme.c | 4 ++-- 1 file changed, 2 insertions(

[RFC PATCH v3 1/2] hw/riscv: sifive_u: Add backend drive support

2020-08-18 Thread Green Wan
Add '-drive' support to OTP device. Allow users to assign a raw file as OTP image. Signed-off-by: Green Wan --- hw/riscv/sifive_u_otp.c | 50 + include/hw/riscv/sifive_u_otp.h | 2 ++ 2 files changed, 52 insertions(+) diff --git a/hw/riscv/sifive_u_otp.c

[RFC PATCH v3 2/2] hw/riscv: sifive_u: Add write-once protection.

2020-08-18 Thread Green Wan
Add array to store the 'written' status for all bit of OTP to block the write operation to the same bit. Ignore the control register offset from 0x0 to 0x38 of OTP memory mapping. Signed-off-by: Green Wan --- hw/riscv/sifive_u_otp.c | 21 + include/hw/riscv/sifive_u_o

Re: [RFC PATCH v3 2/5] util/vfio-helpers: Report error on unsupported host architectures

2020-08-18 Thread Alex Williamson
On Tue, 18 Aug 2020 18:45:06 +0200 Philippe Mathieu-Daudé wrote: > The vfio-helpers implementation expects a TYPEv1 IOMMU, see > qemu_vfio_init_pci: > > 263 if (!ioctl(s->container, VFIO_CHECK_EXTENSION, VFIO_TYPE1_IOMMU)) { > 264 error_setg_errno(errp, errno, "VFIO IOMMU check f

Re: [RFC PATCH v2 1/2] hw/riscv: sifive_u: Add file-backed OTP.

2020-08-18 Thread Green Wan
Hi Alistair, You're right. I can get drive without -device. Now it looks much better. Sent v3 patch. Thanks a lot, - Green On Fri, Aug 14, 2020 at 5:34 AM Alistair Francis wrote: > On Wed, Aug 12, 2020 at 9:12 PM Green Wan wrote: > > > > Hi Alistair, > > > > Thanks for the feedback and tips.

Re: [PATCH v2 0/3] hw/sd: Add Cadence SDHCI emulation

2020-08-18 Thread Philippe Mathieu-Daudé
Cc'ing Sai Pavan for patches 1 and 2. On 8/17/20 12:05 PM, Bin Meng wrote: > This series is spun off from the following series as it is hw/sd > centric, so that it can be picked up separately by Philippe. > > http://patchwork.ozlabs.org/project/qemu-devel/list/?series=195648 > > This series fixe

[RFC PATCH v3 0/2] Add file-backed and write-once features to OTP

2020-08-18 Thread Green Wan
First patch is to add file-backed implementation to allow users to use '-drive' to assign an OTP raw image file. OTP image file must be bigger than 16K. For example, '-drive if=none,format=raw,file=otp.img' Second patch is to add 'write-once' feature to block second write to the OTP memory. Only

Re: [RFC PATCH v3 2/5] util/vfio-helpers: Report error on unsupported host architectures

2020-08-18 Thread Philippe Mathieu-Daudé
On 8/18/20 7:12 PM, Alex Williamson wrote: > On Tue, 18 Aug 2020 18:45:06 +0200 > Philippe Mathieu-Daudé wrote: > >> The vfio-helpers implementation expects a TYPEv1 IOMMU, see >> qemu_vfio_init_pci: >> >> 263 if (!ioctl(s->container, VFIO_CHECK_EXTENSION, VFIO_TYPE1_IOMMU)) { >> 264

Re: [RFC PATCH v3 4/5] util/vfio-helpers: Introduce qemu_vfio_pci_init_msix_irqs()

2020-08-18 Thread Alex Williamson
On Tue, 18 Aug 2020 18:45:08 +0200 Philippe Mathieu-Daudé wrote: > qemu_vfio_pci_init_irq() allows us to initialize any type of IRQ, > but only one. Introduce qemu_vfio_pci_init_msix_irqs() which is > specific to MSIX IRQ type, and allow us to use multiple IRQs > (thus passing multiple eventfd no

Re: [PULL 000/150] Meson-based build system

2020-08-18 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200818141025.21608-1-pbonz...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20200818141025.21608-1-pbonz...@redhat.com Subject: [PULL 000/150] Meson-based build syst

Re: [PATCH] audio/jack: fix use after free segfault

2020-08-18 Thread Christian Schoenebeck
On Dienstag, 18. August 2020 14:40:36 CEST Geoffrey McRae wrote: > Due to a ridiculous commit in the Jack library, the client may have been > freed already by a secondary audio device recovering its session. > > https://github.com/jackaudio/jack2/issues/627 > > Until there is a proper fix for thi

[PATCH v3] linux-user: Fix 'semop()' and 'semtimedop()' implementation

2020-08-18 Thread Filip Bozuta
The implementations of syscalls 'semop()' and 'semtimedop()' in file 'syscall.c' use function 'target_to_host_sembuf()' to convert values of 'struct sembuf' from host to target. However, before this conversion it should be check whether the number of semaphore operations 'nsops' is not bigger than

Re: guest agent public ssh key add/remove support?

2020-08-18 Thread Christian Schoenebeck
On Dienstag, 18. August 2020 15:25:56 CEST David Vossel wrote: > - Guest Agent SSH add/remove Support? > > As a PoC, I cobbled together some guest agent exec and file write client > commands which can technically achieve the desired result of > adding/removing entries in a /home//.ssh/authorized_k

[Bug 1892081] Re: Performance improvement when using "QEMU_FLATTEN" with softfloat type conversions

2020-08-18 Thread Ahmed Karaman
** Attachment added: "after.png" https://bugs.launchpad.net/qemu/+bug/1892081/+attachment/5402579/+files/after.png -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1892081 Title: Performance impro

[Bug 1892081] [NEW] Performance improvement when using "QEMU_FLATTEN" with softfloat type conversions

2020-08-18 Thread Ahmed Karaman
Public bug reported: Attached below is a matrix multiplication program for double data types. The program performs the casting operation "(double)rand()" when generating random numbers. This operation calls the integer to float softfloat conversion function "int32_to_float_64". Adding the "QEMU_

[Bug 1892081] Re: Performance improvement when using "QEMU_FLATTEN" with softfloat type conversions

2020-08-18 Thread Ahmed Karaman
** Attachment added: "before.png" https://bugs.launchpad.net/qemu/+bug/1892081/+attachment/5402578/+files/before.png -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1892081 Title: Performance imp

Re: deprecation of in-tree builds

2020-08-18 Thread Peter Maydell
On Mon, 23 Mar 2020 at 13:32, Stefan Hajnoczi wrote: > On Sat, Mar 21, 2020 at 11:50:23PM +0100, BALATON Zoltan wrote: > > This was discussed before. I think instead of annoying people with a > > warning, rather configure should be changed to create a build dir if run > > from source and have a Ma

Re: [PULL 000/150] Meson-based build system

2020-08-18 Thread Peter Maydell
On Tue, 18 Aug 2020 at 15:14, Paolo Bonzini wrote: > > The following changes since commit d0ed6a69d399ae193959225cdeaa9382746c91cc: > > Update version for v5.1.0 release (2020-08-11 17:07:03 +0100) > > are available in the Git repository at: > > https://gitlab.com/bonzini/qemu.git tags/for-ups

Re: [PULL 000/150] Meson-based build system

2020-08-18 Thread Paolo Bonzini
Ok I can see the -mms-bitfields here too, hopefully that's enough to debug it. Il mar 18 ago 2020, 21:27 Peter Maydell ha scritto: > On Tue, 18 Aug 2020 at 15:14, Paolo Bonzini wrote: > > > > The following changes since commit > d0ed6a69d399ae193959225cdeaa9382746c91cc: > > > > Update version

Re: [PATCH v3] linux-user: Fix 'semop()' and 'semtimedop()' implementation

2020-08-18 Thread Laurent Vivier
Le 18/08/2020 à 20:07, Filip Bozuta a écrit : > The implementations of syscalls 'semop()' and 'semtimedop()' in > file 'syscall.c' use function 'target_to_host_sembuf()' to convert > values of 'struct sembuf' from host to target. However, before this > conversion it should be check whether the numb

Re: [PULL 000/150] Meson-based build system

2020-08-18 Thread Paolo Bonzini
On 18/08/20 22:10, Paolo Bonzini wrote: > Ok I can see the -mms-bitfields here too, hopefully that's enough to > debug it. Hrm no, I don't see it anymore with ea922aa50b2a8688. Can you send me the config-host.mak, build.ninja and Makefile.ninja files? Here I get: $ make target/s390x/gen-featur

Re: [PATCH v7 14/47] stream: Deal with filters

2020-08-18 Thread Andrey Shinkevich
Reviewed-by: Andrey Shinkevich On 10.08.2020 14:04, Vladimir Sementsov-Ogievskiy wrote: 10.08.2020 11:12, Max Reitz wrote: On 07.08.20 12:29, Vladimir Sementsov-Ogievskiy wrote: 16.07.2020 17:59, Max Reitz wrote: On 10.07.20 19:41, Andrey Shinkevich wrote: On 10.07.2020 18:24, Max Reitz wr

Re: [PATCH 30/41] qom: Make type checker functions accept const pointers

2020-08-18 Thread Eduardo Habkost
On Mon, Aug 17, 2020 at 05:08:41PM +0100, Daniel P. Berrangé wrote: > On Thu, Aug 13, 2020 at 06:26:14PM -0400, Eduardo Habkost wrote: > > The existing type check macros all unconditionally drop const > > qualifiers from their arguments. Keep this behavior in the > > macros generated by DECLARE_*

[REPORT] Nightly Performance Tests - Tuesday, August 18, 2020

2020-08-18 Thread Ahmed Karaman
Host CPU : Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz Host Memory : 15.49 GB Start Time (UTC) : 2020-08-18 21:00:01 End Time (UTC) : 2020-08-18 21:00:11 Execution Time : 0:00:10.419271 Status : FAILURE

[PATCH v6 2/4] copy-on-read: add filter append/drop functions

2020-08-18 Thread Andrey Shinkevich
Provide API for the COR-filter insertion/removal. Also, drop the filter child permissions for an inactive state when the filter node is being removed. Signed-off-by: Andrey Shinkevich --- block/copy-on-read.c | 103 +++ block/copy-on-read.h | 36 +

[PATCH v6 4/4] block: apply COR-filter to block-stream jobs

2020-08-18 Thread Andrey Shinkevich
The patch completes the series with the COR-filter insertion to any block-stream operation. It also makes changes to the iotests 030. The test case 'test_stream_parallel' was deleted due to multiple errors. Signed-off-by: Andrey Shinkevich --- block/stream.c | 76

[PATCH v6 0/4] Apply COR-filter to the block-stream permanently

2020-08-18 Thread Andrey Shinkevich
Note: this series is based on the another one "block: Deal with filters" by Max Reitz that could be found in the branches: https://git.xanclic.moe/XanClic/qemu child-access-functions-v6 https://github.com/XanClic/qemu child-access-functions-v6 v6: Re-based to the series "block:

[PATCH v6 3/4] qapi: add filter-node-name to block-stream

2020-08-18 Thread Andrey Shinkevich
Provide the possibility to pass the 'filter-node-name' parameter to the block-stream job as it is done for the commit block job. That will be needed for further iotests implementations. Signed-off-by: Andrey Shinkevich --- block/monitor/block-hmp-cmds.c | 4 ++-- block/stream.c |

[PATCH v6 1/4] copy-on-read: Support preadv/pwritev_part functions

2020-08-18 Thread Andrey Shinkevich
Add support for the recently introduced functions bdrv_co_preadv_part() and bdrv_co_pwritev_part() to the COR-filter driver. Signed-off-by: Andrey Shinkevich --- block/copy-on-read.c | 28 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/block/copy-on-

Re: [PATCH 01/41] pl1110: Rename PL1110 enum

2020-08-18 Thread Eduardo Habkost
CCing maintainer (pmaydell). On Fri, Aug 14, 2020 at 07:45:40PM +0200, Philippe Mathieu-Daudé wrote: > On 8/14/20 12:25 AM, Eduardo Habkost wrote: > > The PL1110 enum value name will conflict with the PL1110 type > > cast checker, when we replace the existing macro with an inline > > function. R

RE: [EXTERNAL] Re: [PATCH v2 0/3] testing: Build WHPX enabled binaries

2020-08-18 Thread Sunil Muthuswamy
> >> It's still shameful that MS is forcing developers to waste time > >> rewriting API headers, just because the MS legal departments are not > >> able to understand the needs of Open Source development. > > There has be a big switch from Microsoft toward Open Source, I attended > > some of there

Re: [PATCH 1/3] linux user: make execfd global (like exec path) and keep it open

2020-08-18 Thread Андрей Аладьев
Hello. I want to explain situation we have in qemu today. It looks simple, but gives complex problems. Please open "linux-user/main.c": execfd = qemu_getauxval(AT_EXECFD); if (execfd == 0) { execfd = open(exec_path, O_RDONLY); if (execfd < 0) { ... } } ... close(execfd); We may take AT_EXECF

Re: [PATCH 06/41] allwinner-h3: Rename memmap enum constants

2020-08-18 Thread Eduardo Habkost
On Mon, Aug 17, 2020 at 09:07:58PM +0200, Niek Linnenbank wrote: > Hi, > > Interesting suggestion Philippe. I modelled the initial code of the H3 SoC > mostly in-line with the aspeed SoC, > to let it use commonly applied code structures where possible. And it looks > like in this series, aspeed_so

[RFC PATCH v2 0/4] Use ACPI PCI hot-plug for q35

2020-08-18 Thread Julia Suvorova
PCIe native hot-plug has numerous problems with racing events and unpredictable guest behaviour (Windows). Switching to ACPI hot-plug for now. Tested on RHEL 8 and Windows 2019. pxb-pcie is not yet supported. v2: * new ioport range for acpiphp [Gerd] * drop find_pci_host() [Igor] * ex

[RFC PATCH v2 1/4] hw/acpi/ich9: Trace ich9_gpe_readb()/writeb()

2020-08-18 Thread Julia Suvorova
Add trace events similar to piix4_gpe_readb() to check gpe status. Signed-off-by: Julia Suvorova Reviewed-by: Igor Mammedov --- hw/acpi/ich9.c | 7 ++- hw/acpi/trace-events | 4 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c index 6

[RFC PATCH v2 2/4] hw/i386/acpi-build: Add ACPI PCI hot-plug methods to q35

2020-08-18 Thread Julia Suvorova
Implement notifications and gpe to support q35 ACPI PCI hot-plug. Use 0xcc4 - 0xcd7 range for 'acpi-pci-hotplug' io ports. Signed-off-by: Julia Suvorova --- include/hw/acpi/pcihp.h | 3 ++- hw/acpi/pcihp.c | 10 ++ hw/acpi/piix4.c | 2 +- hw/i386/acpi-build.c| 25 ++

[RFC PATCH v2 3/4] hw/i386/acpi-build: Turn off support of PCIe native hot-plug and SHPC in _OSC

2020-08-18 Thread Julia Suvorova
Other methods may be used if the system is capable of this and the _OSC bit is set. Disable them explicitly to force ACPI PCI hot-plug use. The older versions will still use PCIe native. Signed-off-by: Julia Suvorova --- hw/i386/acpi-build.h | 11 +++ hw/i386/acpi-build.c | 21 ++

[RFC PATCH v2 4/4] hw/acpi/ich9: Enable ACPI PCI hot-plug

2020-08-18 Thread Julia Suvorova
Add acpi_pcihp to ich9_pm and use ACPI PCI hot-plug by default. Signed-off-by: Julia Suvorova --- Note: New pc_compats are usually added shortly after release. I will switch to pc_compat_5_1 when it becomes available. hw/i386/acpi-build.h | 1 + include/hw/acpi/ich9.h | 3 +++ hw/acpi

Re: [PATCH 2/3] linux user: moving is proc functions to separate file

2020-08-18 Thread Андрей Аладьев
Ok, we may store these functions in syscall.c. вт, 18 авг. 2020 г. в 18:56, Laurent Vivier : > Le 18/08/2020 à 01:57, Andrew Aladjev a écrit : > > Signed-off-by: Andrew Aladjev > > --- > > linux-user/Makefile.objs | 5 +++-- > > linux-user/syscall.c | 33 +

Re: [PATCH] audio/jack: fix use after free segfault

2020-08-18 Thread Geoffrey McRae
On 2020-08-19 04:11, Christian Schoenebeck wrote: On Dienstag, 18. August 2020 14:40:36 CEST Geoffrey McRae wrote: Due to a ridiculous commit in the Jack library, the client may have been freed already by a secondary audio device recovering its session. https://github.com/jackaudio/jack2/is

Re: [RFC PATCH v2 0/4] Use ACPI PCI hot-plug for q35

2020-08-18 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200818215227.181654-1-jus...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [PATCH v4 4/8] ppc/e500: Use start-powered-off CPUState property

2020-08-18 Thread Thiago Jung Bauermann
Hi Igor, Thank you for reviewing these patches, and the tips you provided here and on other messages on how to fix the refcount issues. Igor Mammedov writes: > On Tue, 18 Aug 2020 00:33:19 -0300 > Thiago Jung Bauermann wrote: > > [...] > >> Also change creation of CPU object from cpu_create(

Re: [PATCH v4 4/8] ppc/e500: Use start-powered-off CPUState property

2020-08-18 Thread Thiago Jung Bauermann
Hello Philippe, Thanks for your review. Philippe Mathieu-Daudé writes: > On 8/18/20 9:22 AM, Philippe Mathieu-Daudé wrote: >> On 8/18/20 5:33 AM, Thiago Jung Bauermann wrote: >>> Instead of setting CPUState::halted to 1 in ppce500_cpu_reset_sec(), use >>> the start-powered-off property which

Re: [PATCH v4 4/8] ppc/e500: Use start-powered-off CPUState property

2020-08-18 Thread Thiago Jung Bauermann
Thiago Jung Bauermann writes: > Hello Philippe, > > Thanks for your review. > > Philippe Mathieu-Daudé writes: > >> On 8/18/20 9:22 AM, Philippe Mathieu-Daudé wrote: @@ -897,6 +895,19 @@ void ppce500_init(MachineState *machine) } else { /* Secondary CPUs */

Re: [PATCH v4 5/8] mips/cps: Use start-powered-off CPUState property

2020-08-18 Thread Thiago Jung Bauermann
Philippe Mathieu-Daudé writes: > On 8/18/20 5:33 AM, Thiago Jung Bauermann wrote: >> Instead of setting CPUState::halted to 1 in main_cpu_reset(), use the >> start-powered-off property which makes cpu_common_reset() initialize it >> to 1 in common code. >> >> Also change creation of CPU object

[PATCH v2] audio/jack: fix use after free segfault

2020-08-18 Thread Geoffrey McRae
The client may have been freed already by a secondary audio device recovering its session as JACK2 has some cleanup code to work around broken clients, which doesn't account for well behaved clients. https://github.com/jackaudio/jack2/issues/627 As JACK1 and JACK2 are interchangeable and JACK2 ha

[PATCH v3 1/1] audio/jack: fix use after free segfault

2020-08-18 Thread Geoffrey McRae
The client may have been freed already by a secondary audio device recovering its session as JACK2 has some cleanup code to work around broken clients, which doesn't account for well behaved clients. https://github.com/jackaudio/jack2/issues/627 As JACK1 and JACK2 are interchangeable and JACK2 ha

[PATCH v3 0/1] audio/jack: fix use after free segfault

2020-08-18 Thread Geoffrey McRae
Fixed accidental eof newline strip from `configure` Geoffrey McRae (1): audio/jack: fix use after free segfault audio/jackaudio.c | 37 - configure | 4 +++- 2 files changed, 39 insertions(+), 2 deletions(-) -- 2.20.1

[Bug 1890545] Re: (ARM64) qemu-x86_64+schroot(Debian bullseye) can't run chrome and can't load HTML

2020-08-18 Thread Tony.LI
Now, I found something new when I use gdb: => 0x400523c858:ud2 0x400523c85a:pushq $0xd 0x400523c85c:mov-0x230(%rbp),%rax 0x400523c863:mov-0x240(%rbp),%rdi 0x400523c86a:mov$0x1,%esi 0x400523c86f:movq $0x0,-0x230(%rbp)

Re: [PATCH 00/18] hw/riscv: Add Microchip PolarFire SoC Icicle Kit board support

2020-08-18 Thread Bin Meng
On Tue, Aug 18, 2020 at 9:55 PM Anup Patel wrote: > > On Tue, Aug 18, 2020 at 6:39 PM wrote: > > > > On 8/18/20 7:17 AM, Anup Patel wrote: > > > EXTERNAL EMAIL: Do not click links or open attachments unless you know > > > the content is safe > > > > > > On Tue, Aug 18, 2020 at 1:23 AM wrote: >

[PATCH v2] qemu-img: Explicit number replaced by a constant

2020-08-18 Thread Yi Li
Signed-off-by: Yi Li --- qemu-img.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 5308773811..aa2e31c8ae 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -1200,10 +1200,10 @@ static int is_allocated_sectors(const uint8_t *buf, int n, int

Re: [PULL 147/150] meson: convert po/

2020-08-18 Thread Brad Smith
On 8/18/2020 10:10 AM, Paolo Bonzini wrote: From: Marc-André Lureau Meson warns if xgettext is not found. In the future we may want to add a required argument to i18n.gettext(); in the meanwhile, I am adding a --enable-gettext/--disable-gettext option and feature detection in configure. This

[Bug 1890545] Re: (ARM64) qemu-x86_64+schroot(Debian bullseye) can't run chrome and can't load HTML

2020-08-18 Thread Tony.LI
This is where the error occurred: (gdb) x/30i 0x40007ff2c0 0x40007ff2c0:xor%al,%dh 0x40007ff2c2:(bad) 0x40007ff2c3:add%al,(%rax) 0x40007ff2c5:add%al,(%rax) 0x40007ff2c7:add%ch,0x0(%rbp) 0x40007ff2cd:add%al,(%rax

Re: device compatibility interface for live migration with assigned devices

2020-08-18 Thread Jason Wang
On 2020/8/18 下午5:16, Daniel P. Berrangé wrote: Your mail came through as HTML-only so all the quoting and attribution is mangled / lost now :-( My bad, sorry. On Tue, Aug 18, 2020 at 05:01:51PM +0800, Jason Wang wrote: On 2020/8/18 下午4:55, Daniel P. Berrangé wrote: On Tue, Aug 18

[PATCH v5 3/8] ppc/spapr: Use start-powered-off CPUState property

2020-08-18 Thread Thiago Jung Bauermann
PowerPC sPAPR CPUs start in the halted state, and spapr_reset_vcpu() attempts to implement this by setting CPUState::halted to 1. But that's too late for the case of hotplugged CPUs in a machine configure with 2 or more threads per core. By then, other parts of QEMU have already caused the vCPU to

[PATCH v5 2/8] target/arm: Move setting of CPU halted state to generic code

2020-08-18 Thread Thiago Jung Bauermann
This change is in a separate patch because it's not so obvious that it won't cause a regression. Suggested-by: Eduardo Habkost Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: David Gibson Reviewed-by: Greg Kurz Signed-off-by: Thiago Jung Bauermann --- hw/core/cpu.c| 2 +- target/arm/cpu

[PATCH v5 8/8] target/s390x: Use start-powered-off CPUState property

2020-08-18 Thread Thiago Jung Bauermann
Instead of setting CPUState::halted to 1 in s390_cpu_initfn(), use the start-powered-off property which makes cpu_common_reset() initialize it to 1 in common code. Note that this changes behavior by setting cs->halted to 1 on reset, which didn't happen before. Acked-by: Cornelia Huck Signed-off-

<    1   2   3   4   5   >