[PATCH 116/150] meson: convert hw/gpio

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- hw/Makefile.objs | 1 - hw/gpio/Makefile.objs | 12 hw/gpio/meson.build | 12 hw/meson.build| 1 + 4 files changed, 13 insertions(+), 13 deletions(-) delete mod

[PATCH 112/150] meson: convert hw/input

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- hw/Makefile.objs | 1 - hw/input/Makefile.objs | 18 -- hw/input/meson.build | 18 ++ hw/meson.build | 1 + 4 files changed, 19 insertions(+), 19 deletion

[PATCH 133/150] meson: link emulators without Makefile.target

The binaries move to the root directory, e.g. qemu-system-i386 or qemu-arm. This requires changes to qtests, CI, etc. Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- .gitlab-ci.yml| 6 +- Makefile | 35 + Mak

[PATCH 110/150] meson: convert hw/ipack

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- hw/Makefile.objs | 1 - hw/ipack/Makefile.objs | 2 -- hw/ipack/meson.build | 1 + hw/meson.build | 1 + 4 files changed, 2 insertions(+), 3 deletions(-) delete mode 100644 hw/ipack/Makef

[PATCH 118/150] meson: convert hw/display

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- Makefile.target | 1 + hw/Makefile.objs | 1 - hw/display/Makefile.objs | 65 --- hw/display/meson.build | 84 hw/

[PATCH 120/150] meson: convert hw/char

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- hw/Makefile.objs | 1 - hw/char/Makefile.objs | 39 --- hw/char/meson.build | 38 ++ hw/meson.build| 1 + 4 files c

[PATCH 124/150] meson: convert hw/acpi

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- hw/Makefile.objs | 1 - hw/acpi/Makefile.objs | 26 -- hw/acpi/meson.build | 25 + hw/meson.build| 1 + 4 files changed, 26 insertions(+),

[PATCH 140/150] meson: convert check-block

Signed-off-by: Paolo Bonzini --- meson.build| 2 ++ tests/Makefile.include | 16 ++-- tests/meson.build | 4 tests/qemu-iotests/meson.build | 10 ++ 4 files changed, 18 insertions(+), 14 deletions(-) create mode 100644 tests/qem

[PATCH 115/150] meson: convert hw/hyperv

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- hw/Makefile.objs| 1 - hw/hyperv/Makefile.objs | 3 --- hw/hyperv/meson.build | 3 +++ hw/meson.build | 1 + 4 files changed, 4 insertions(+), 4 deletions(-) delete mode 100644 hw/hype

[PATCH 127/150] meson: target

Similar to hw_arch, each architecture defines two sourceset which are placed in dictionaries target_arch and target_softmmu_arch. These are then picked up from there when building the per-emulator static_library. Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- Makefile.target

[PATCH 142/150] meson: replace create-config with meson configure_file

Move the create-config logic to meson.build; create a configuration_data object and let meson handle the quoting and output. Signed-off-by: Paolo Bonzini --- Makefile | 2 +- block.c| 2 + configure | 9 +-- meson.build

[PATCH 117/150] meson: convert hw/dma

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- hw/Makefile.objs | 1 - hw/dma/Makefile.objs | 16 hw/dma/meson.build | 15 +++ hw/meson.build | 1 + 4 files changed, 16 insertions(+), 17 deletions(-) delete

[PATCH 123/150] meson: convert hw/adc

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- hw/Makefile.objs | 1 - hw/adc/Makefile.objs | 1 - hw/adc/meson.build | 1 + hw/meson.build | 1 + 4 files changed, 2 insertions(+), 2 deletions(-) delete mode 100644 hw/adc/Makefile.objs c

[PATCH 125/150] meson: convert hw/9pfs, cleanup

From: Marc-André Lureau hw/Makefile.objs is gone so there is more code that can be removed. Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- Makefile | 4 Makefile.objs | 8 Makefile.target | 15 --- hw/9pfs/Kconfig

[PATCH 129/150] meson: linux-user

From: Marc-André Lureau The most interesting or most complicated part here is the syscall_nr.h generators. In order to keep the generation logic all in meson.build, I am adding to config_target the name of the .tbl file, and making the generated file syscall_nr.h for input file syscall.tbl. For

[PATCH 143/150] meson: convert sample plugins

Signed-off-by: Paolo Bonzini --- configure| 4 tests/Makefile.include | 9 tests/meson.build| 3 +++ tests/plugin/Makefile| 46 tests/plugin/meson.build | 7 ++ 5 files changed, 10 insertions(+), 59 delet

[PATCH 119/150] meson: convert hw/cpu

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- hw/Makefile.objs | 1 - hw/cpu/Makefile.objs | 5 - hw/cpu/meson.build | 6 ++ hw/meson.build | 1 + 4 files changed, 7 insertions(+), 6 deletions(-) delete mode 100644 hw/cpu/Makefil

[PATCH 122/150] meson: convert hw/audio

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- hw/Makefile.objs | 1 - hw/audio/Makefile.objs | 18 -- hw/audio/meson.build | 14 ++ hw/meson.build | 1 + 4 files changed, 15 insertions(+), 19 deletions(-)

[PATCH 126/150] meson: convert hw/arch*

From: Marc-André Lureau Each architecture's sourceset is placed in an hw_arch dictionary, and picked up from there when building the per-emulator static_library. Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- Makefile.target | 7 hw/alpha/Makefile.objs

[PATCH 130/150] meson: bsd-user

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- Makefile.target| 3 --- bsd-user/Makefile.objs | 2 -- bsd-user/meson.build | 10 ++ meson.build| 4 4 files changed, 14 insertions(+), 5 deletions(-) delete mode 10

[PATCH 132/150] meson: plugins

For now link arguments end up in Makefile.target, they will move to the right place soon. Signed-off-by: Paolo Bonzini --- Makefile | 8 +--- Makefile.target | 12 ++-- meson.build | 5 + plugins/Makefile.objs | 21 - plugins/mes

[PATCH 136/150] remove Makefile.target

Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- Makefile| 53 - Makefile.target | 12 --- configure | 17 3 files changed, 4 insertions(+), 78 deletions(-) delete mode 100644 Makefile.targe

[PATCH 128/150] meson: accel

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- Makefile.objs | 2 +- Makefile.target | 1 - accel/Makefile.objs | 6 -- accel/kvm/Makefile.objs | 2 -- accel/kvm/meson.build | 5 + accel/meson.build

[PATCH 131/150] meson: cpu-emu

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- Makefile.target | 12 configure | 10 +- meson.build | 37 + scripts/feature_to_c.sh | 24 ---

[PATCH 138/150] docs: automatically track manual dependencies

Signed-off-by: Paolo Bonzini --- docs/conf.py | 2 +- docs/meson.build | 21 ++--- docs/sphinx/depfile.py | 51 ++ 3 files changed, 65 insertions(+), 9 deletions(-) create mode 100644 docs/sphinx/depfile.py diff --git a/docs/c

[PATCH 135/150] rules.mak: remove version.o

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- Makefile | 5 - Makefile.objs | 4 rules.mak | 4 +--- 3 files changed, 1 insertion(+), 12 deletions(-) diff --git a/Makefile b/Makefile index 9c8fb91f45..e6ede40f51 100644 --- a/Makefi

[PULL 2/3] async: always set ctx->notified in aio_notify()

aio_notify() does not set ctx->notified when called with ctx->aio_notify_me disabled. Therefore aio_notify_me needs to be enabled during polling. This is suboptimal since expensive event_notifier_set(&ctx->notifier) and event_notifier_test_and_clear(&ctx->notifier) calls are required when ctx->aio

[PATCH 134/150] meson: convert systemtap files

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- Makefile.target | 85 ++- meson.build | 26 +++ rules.mak | 3 -- trace/meson.build | 14 4 files changed, 35 insertions(+

[PATCH 145/150] meson: convert VNC and dependent libraries to meson

Signed-off-by: Paolo Bonzini --- configure | 122 +- meson.build | 40 +-- meson_options.txt | 4 ++ ui/meson.build| 10 ++-- 4 files changed, 45 insertions(+), 131 deletions(-) diff --git a/configure b/configure index

[PATCH 137/150] meson: sphinx-build

For now, sphinx is run on every invocation of make. The previous mechanism using $(wildcard) is not reproducible in Meson and was also brittle; for example some .rst.inc files were left out. The next patch will introduce a Sphinx extension to emit a depfile. Signed-off-by: Marc-André Lureau Sig

[PATCH 144/150] meson: move SDL and SDL-image detection to meson

Signed-off-by: Paolo Bonzini --- chardev/meson.build | 2 +- configure | 142 +++- meson.build | 26 +--- meson_options.txt | 2 + ui/meson.build | 4 +- 5 files changed, 32 insertions(+), 144 deletions(-) create mode 10

[PATCH 150/150] docs: convert build system documentation to rST

Signed-off-by: Paolo Bonzini --- .../{build-system.txt => build-system.rst}| 310 -- docs/devel/index.rst | 1 + tests/qapi-schema/meson.build | 6 +- 3 files changed, 145 insertions(+), 172 deletions(-) rename docs/devel/{build-sy

Re: [PATCH v1 1/5] target/microblaze: mbar: Transfer dc->rd to mbar_imm

On 8/17/20 7:01 AM, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Transfer dc->rd to mbar_imm to improve the readability when > comparing to the specs. > > No functional change. > > Signed-off-by: Edgar E. Iglesias > --- > target/microblaze/translate.c | 6 -- > 1 file changed,

Re: [PATCH v1 2/5] target/microblaze: mbar: Move LOG_DIS to before sleep

On 8/17/20 7:01 AM, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Move LOG_DIS log to before sleeping handling so that it logs > for sleep instructions aswell. > > Signed-off-by: Edgar E. Iglesias > --- > target/microblaze/translate.c | 3 ++- > 1 file changed, 2 insertions(+), 1 de

[PATCH 139/150] meson: build texi doc

Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- Makefile | 106 ++--- docs/interop/qemu-ga-ref.texi | 2 +- docs/interop/qemu-qmp-ref.texi | 2 +- meson.build| 85 ++ qga/meson.b

[PATCH 141/150] rules.mak: drop unneeded macros

Signed-off-by: Paolo Bonzini --- .gitignore | 1 - Makefile| 7 +- configure | 55 ++--- docs/devel/build-system.txt | 5 +- rules.mak | 231 +--- scripts/create_config | 6

[PATCH 148/150] acceptance: use stable URLs for the Debian and Ubuntu installer

The kernel and initrd hashes seem to have changed for the Bionic aarch64 installer, causing BootLinuxConsole.test_aarch64_xlnx_versal_virt to fail. Correct the paths to use the previous binaries instead of the latest. Do the same for the Lenny alpha installer for consistency, even though those ar

[PATCH 147/150] meson: avoid unstable module warning with Meson 0.56.0 or newer

Signed-off-by: Paolo Bonzini --- meson.build | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 54e92195d6..3a689d2d07 100644 --- a/meson.build +++ b/meson.build @@ -3,7 +3,11 @@ project('qemu', ['c', 'cpp'], meson_version: '>=0.55.0',

Re: [RFC PATCH 14/22] block/export: Move AioContext from NBDExport to BlockExport

On 13.08.20 18:29, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > include/block/export.h | 6 ++ > nbd/server.c | 26 +- > 2 files changed, 19 insertions(+), 13 deletions(-) Reviewed-by: Max Reitz > diff --git a/include/block/export.h b/include/blo

[PATCH 146/150] meson: convert po/

From: Marc-André Lureau Meson warns if xgettext is not found. In the future we may want to add a required argument to i18n.gettext(); in the meanwhile, I am adding a --enable-gettext/--disable-gettext option and feature detection in configure. This preserves QEMU's default behavior of detecting

Re: [RFC PATCH 13/22] block/export: Move refcount from NBDExport to BlockExport

On 13.08.20 18:29, Kevin Wolf wrote: > Having a refcount makes sense for all types of block exports. It is also > a prerequisite for keeping a list of all exports at the BlockExport > level. > > Signed-off-by: Kevin Wolf > --- > include/block/export.h | 10 ++ > include/block/nbd.h| 2 -

Re: [PATCH v1 3/5] target/microblaze: mbar: Add support for data-access barriers

On 8/17/20 7:01 AM, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Add support for data-access barriers. > > Signed-off-by: Edgar E. Iglesias > --- > target/microblaze/translate.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/target/microblaze/translate.c b/target/mi

Re: [RFC PATCH 11/22] qemu-nbd: Use blk_exp_add() to create the export

Am 17.08.2020 um 16:27 hat Max Reitz geschrieben: > On 13.08.20 18:29, Kevin Wolf wrote: > > With this change, NBD exports are only created through the BlockExport > > interface any more. This allows us finally to move things from the NBD > > layer to the BlockExport layer if they make sense for ot

[PATCH 149/150] meson: update build-system documentation

Signed-off-by: Paolo Bonzini --- docs/devel/build-system.txt | 468 ++-- 1 file changed, 240 insertions(+), 228 deletions(-) diff --git a/docs/devel/build-system.txt b/docs/devel/build-system.txt index fea67b207c..2ced8ca474 100644 --- a/docs/devel/build-system.tx

Re: [PATCH v1 4/5] target/microblaze: swx: Use atomic_cmpxchg

On 8/17/20 7:01 AM, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Use atomic_cmpxchg to implement the atomic cmpxchg sequence. > > Signed-off-by: Edgar E. Iglesias > --- > target/microblaze/translate.c | 21 + > 1 file changed, 13 insertions(+), 8 deletions(-) >

Re: [RFC PATCH 15/22] block/export: Move device to BlockExportOptions

On 13.08.20 18:29, Kevin Wolf wrote: > Every block export needs a block node to export, so move the 'device' > option from BlockExportOptionsNbd to BlockExportOptions. > > To maintain compatibility in nbd-server-add, BlockExportOptionsNbd needs > to be wrapped by a new type NbdServerAddOptions tha

Re: [PATCH] fixed proc myself (linux user) for musl

Hi, it seems your patch does several things. Could you split it into several patches? Could you add a description of what the patches do? Could you use a tool like "git send-email" or "git publish" to send your series? For the patch moving code from syscall.c to syscall_proc.c, write a patch tha

Re: [PATCH 0/1] qcow2: Skip copy-on-write when allocating a zero cluster

Am 17.08.2020 um 17:31 hat Alberto Garcia geschrieben: > On Mon 17 Aug 2020 12:10:19 PM CEST, Kevin Wolf wrote: > >> Since commit c8bb23cbdbe / QEMU 4.1.0 (and if the storage backend > >> allows it) writing to an image created with preallocation=metadata > >> can be slower (20% in my tests) than wr

[PULL 1/3] async: rename event_notifier_dummy_cb/poll()

The event_notifier_*() prefix can be confused with the EventNotifier APIs that are also called event_notifier_*(). Rename the functions to aio_context_notifier_*() to make it clear that they relate to the AioContext::notifier field. Signed-off-by: Stefan Hajnoczi Reviewed-by: Philippe Mathieu-Da

Re: [PATCH 04/41] vmw_pvscsi: Rename QOM class cast macros

On Thu, Aug 13, 2020 at 06:25:48PM -0400, Eduardo Habkost wrote: > Rename the PVSCSI_DEVICE_CLASS() and PVSCSI_DEVICE_GET_CLASS() > macros to be consistent with the PVSCSI() instance cast macro. > > This will allow us to register the type cast macros using > OBJECT_DECLARE_TYPE later. > > Signed-

[PULL 3/3] aio-posix: keep aio_notify_me disabled during polling

Polling only monitors the ctx->notified field and does not need the ctx->notifier EventNotifier to be signalled. Keep ctx->aio_notify_me disabled while polling to avoid unnecessary EventNotifier syscalls. This optimization improves virtio-blk 4KB random read performance by 18%. The following resul

[PULL 0/3] Block patches

The following changes since commit d0ed6a69d399ae193959225cdeaa9382746c91cc: Update version for v5.1.0 release (2020-08-11 17:07:03 +0100) are available in the Git repository at: https://github.com/stefanha/qemu.git tags/block-pull-request for you to fetch changes up to 44277bf914471962c9e8

Re: [RFC PATCH 15/22] block/export: Move device to BlockExportOptions

Am 17.08.2020 um 17:13 hat Max Reitz geschrieben: > On 13.08.20 18:29, Kevin Wolf wrote: > > Every block export needs a block node to export, so move the 'device' > > option from BlockExportOptionsNbd to BlockExportOptions. > > > > To maintain compatibility in nbd-server-add, BlockExportOptionsNbd

Re: [PATCH 05/41] aspeed_timer: Fix ASPEED_TIMER macro definition

On Thu, Aug 13, 2020 at 06:25:49PM -0400, Eduardo Habkost wrote: > The macro definition had an extra semicolon. This was never > noticed because the macro was only being used where it didn't > make a difference. > > Signed-off-by: Eduardo Habkost > --- > include/hw/timer/aspeed_timer.h | 2 +- >

Re: [RFC PATCH 14/22] block/export: Move AioContext from NBDExport to BlockExport

Am 17.08.2020 um 16:56 hat Max Reitz geschrieben: > On 13.08.20 18:29, Kevin Wolf wrote: > > Signed-off-by: Kevin Wolf > > --- > > include/block/export.h | 6 ++ > > nbd/server.c | 26 +- > > 2 files changed, 19 insertions(+), 13 deletions(-) > > Reviewed-b

Re: [RFC PATCH 09/22] nbd: Add writethrough to block-export-add

On 17.08.20 16:32, Kevin Wolf wrote: > Am 17.08.2020 um 15:51 hat Max Reitz geschrieben: >> On 17.08.20 15:13, Kevin Wolf wrote: >>> Am 17.08.2020 um 14:56 hat Max Reitz geschrieben: On 13.08.20 18:29, Kevin Wolf wrote: > qemu-nbd allows use of writethrough cache modes, which mean that wri

Re: [PATCH 0/1] qcow2: Skip copy-on-write when allocating a zero cluster

On Mon 17 Aug 2020 12:10:19 PM CEST, Kevin Wolf wrote: >> Since commit c8bb23cbdbe / QEMU 4.1.0 (and if the storage backend >> allows it) writing to an image created with preallocation=metadata >> can be slower (20% in my tests) than writing to an image with no >> preallocation at all. > > A while

Re: [PATCH 15/41] tulip: Move TulipState typedef to header

On Thu, Aug 13, 2020 at 06:25:59PM -0400, Eduardo Habkost wrote: > Move typedef closer to the type check macros, to make it easier > to convert the code to OBJECT_DEFINE_TYPE() in the future. > > Signed-off-by: Eduardo Habkost > --- > hw/net/tulip.h | 1 + > hw/net/tulip.c | 4 ++-- > 2 files ch

[PATCH v2] linux-user: Fix 'semop()' and 'semtimedop()' implementation

The implementations of syscalls 'semop()' and 'semtimedop()' in file 'syscall.c' use function 'target_to_host_sembuf()' to convert values of 'struct sembuf' from host to target. However, before this conversion it should be check whether the number of semaphore operations 'nsops' is not bigger than

Re: [RFC PATCH 14/22] block/export: Move AioContext from NBDExport to BlockExport

On 17.08.20 17:22, Kevin Wolf wrote: > Am 17.08.2020 um 16:56 hat Max Reitz geschrieben: >> On 13.08.20 18:29, Kevin Wolf wrote: >>> Signed-off-by: Kevin Wolf >>> --- >>> include/block/export.h | 6 ++ >>> nbd/server.c | 26 +- >>> 2 files changed, 19 insert

Re: [RFC PATCH 15/22] block/export: Move device to BlockExportOptions

On 17.08.20 17:27, Kevin Wolf wrote: > Am 17.08.2020 um 17:13 hat Max Reitz geschrieben: >> On 13.08.20 18:29, Kevin Wolf wrote: >>> Every block export needs a block node to export, so move the 'device' >>> option from BlockExportOptionsNbd to BlockExportOptions. >>> >>> To maintain compatibility i

Re: [PATCH 02/41] e1000: Rename QOM class cast macros

On Thu, Aug 13, 2020 at 06:25:46PM -0400, Eduardo Habkost wrote: > Rename the E1000_DEVICE_CLASS() and E1000_DEVICE_GET_CLASS() > macros to be consistent with the E1000() instance cast macro. > > This will allow us to register the type cast macros using > OBJECT_DECLARE_TYPE later. > > Signed-off

Re: [PATCH 03/41] megasas: Rename QOM class cast macros

On Thu, Aug 13, 2020 at 06:25:47PM -0400, Eduardo Habkost wrote: > Rename the MEGASAS_DEVICE_CLASS() and MEGASAS_DEVICE_GET_CLASS() > macros to be consistent with the MEGASAS() instance cast macro. > > This will allow us to register the type cast macros using > OBJECT_DECLARE_TYPE later. > > Sign

Re: [PATCH 11/41] versatile: Fix typo in PCI_VPB_HOST definition

On Thu, Aug 13, 2020 at 06:25:55PM -0400, Eduardo Habkost wrote: > Signed-off-by: Eduardo Habkost > --- > hw/pci-host/versatile.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.

Re: [PATCH 0/1] qcow2: Skip copy-on-write when allocating a zero cluster

On Mon 17 Aug 2020 05:53:07 PM CEST, Kevin Wolf wrote: >> > Or are you saying that ZERO_RANGE + pwrite on a sparse file (= >> > cluster allocation) is faster for you than just the pwrite alone (= >> > writing to already allocated cluster)? >> >> Yes, 20% faster in my tests (4KB random writes), but

Re: [PATCH 20/41] mcf_fec: Move mcf_fec_state typedef to header

On Thu, Aug 13, 2020 at 06:26:04PM -0400, Eduardo Habkost wrote: > Move typedef closer to the type check macros, to make it easier > to convert the code to OBJECT_DEFINE_TYPE() in the future. > > Signed-off-by: Eduardo Habkost > --- > include/hw/m68k/mcf_fec.h | 1 + > hw/net/mcf_fec.c

Re: [PATCH 13/41] hvf: Add missing include

On Thu, Aug 13, 2020 at 06:25:57PM -0400, Eduardo Habkost wrote: > The sysemu/accel.h header is needed for the ACCEL_CLASS_NAME > macro. This will be necessary to allow us to use OBJECT_DEFINE*() > for TYPE_HVF_ACCEL. > > Signed-off-by: Eduardo Habkost > --- > include/sysemu/hvf.h | 2 ++ > 1 f

Re: [PATCH 12/41] virtio-ccw: Fix definition of VIRTIO_CCW_BUS_GET_CLASS

On Thu, Aug 13, 2020 at 06:25:56PM -0400, Eduardo Habkost wrote: > The macro was incorrectly defined using OBJECT_CHECK. Nice demonstration of the benefit of removing this boilerplate definition ! > > Signed-off-by: Eduardo Habkost > --- > hw/s390x/virtio-ccw.h | 4 ++-- > 1 file changed, 2 in

Re: [PATCH 14/41] hcd-dwc2: Rename USB_*CLASS macros for consistency

On Thu, Aug 13, 2020 at 06:25:58PM -0400, Eduardo Habkost wrote: > Rename the DWC2_CLASS to DWC2_USB_CLASS and DWC2_GET_CLASS to > DWC2_USB_GET_CLASS, for consistency with the DWC2_USB macro. > > Signed-off-by: Eduardo Habkost > --- > hw/usb/hcd-dwc2.h | 4 ++-- > hw/usb/hcd-dwc2.c | 8

Re: [PATCH 24/41] platform-bus: Delete macros for non-existing typedef

On Thu, Aug 13, 2020 at 06:26:08PM -0400, Eduardo Habkost wrote: > PlatformBusDeviceClass doesn't exist. This will break when we > automatically convert the code to use OBJECT_DEFINE_TYPE(). > Delete the macros that reference the non-existing typedef. > > Signed-off-by: Eduardo Habkost > --- >

Re: [PATCH v1 4/5] target/microblaze: swx: Use atomic_cmpxchg

On Mon, Aug 17, 2020 at 08:52:16AM -0700, Richard Henderson wrote: > On 8/17/20 7:01 AM, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > > > Use atomic_cmpxchg to implement the atomic cmpxchg sequence. > > > > Signed-off-by: Edgar E. Iglesias > > --- > > target/microblaze/translate.

Re: [PATCH 27/41] qom: Fix G_DEFINE_AUTOPTR_CLEANUP_FUNC

On Thu, Aug 13, 2020 at 06:26:11PM -0400, Eduardo Habkost wrote: > ModuleObjName##Class was being used instead of ModuleObjName. > Fix it. > > Signed-off-by: Eduardo Habkost > --- > include/qom/object.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé t

Re: [PATCH 17/41] pci: Move PCIBusClass typedef to pci.h

On Thu, Aug 13, 2020 at 06:26:01PM -0400, Eduardo Habkost wrote: > Move typedef closer to the type check macros, to make it easier > to convert the code to OBJECT_DEFINE_TYPE() in the future. > > Signed-off-by: Eduardo Habkost > --- > include/hw/pci/pci.h | 1 + > include/hw/pci/pci_bus.h |

Re: [PATCH 21/41] s390_flic: Move KVMS390FLICState typedef to header

On Thu, Aug 13, 2020 at 06:26:05PM -0400, Eduardo Habkost wrote: > Move typedef closer to the type check macros, to make it easier > to convert the code to OBJECT_DEFINE_TYPE() in the future. > > Signed-off-by: Eduardo Habkost > --- > include/hw/s390x/s390_flic.h | 1 + > hw/intc/s390_flic_kvm.c

Re: [PATCH 16/41] throttle-groups: Move ThrottleGroup typedef to header

On Thu, Aug 13, 2020 at 06:26:00PM -0400, Eduardo Habkost wrote: > Move typedef closer to the type check macros, to make it easier > to convert the code to OBJECT_DEFINE_TYPE() in the future. > > Signed-off-by: Eduardo Habkost > --- > include/block/throttle-groups.h | 1 + > block/throttle-group

Re: [PATCH 18/41] i8254: Move PITCommonState/PITCommonClass typedefs to i8254.h

On Thu, Aug 13, 2020 at 06:26:02PM -0400, Eduardo Habkost wrote: > Move typedef closer to the type check macros, to make it easier > to convert the code to OBJECT_DEFINE_TYPE() in the future. > > Signed-off-by: Eduardo Habkost > --- > include/hw/timer/i8254.h | 2 ++ > include/hw/timer/

Re: [PATCH 23/41] nubus: Delete unused NUBUS_BRIDGE macro

On Thu, Aug 13, 2020 at 06:26:07PM -0400, Eduardo Habkost wrote: > The macro never worked because the NubusBridge typedef doesn't > exist. Delete it. > > Signed-off-by: Eduardo Habkost > --- > include/hw/nubus/nubus.h | 1 - > 1 file changed, 1 deletion(-) Reviewed-by: Daniel P. Berrangé Re

Re: [PATCH 28/41] qom: Allow class type name to be specified in OBJECT_DECLARE*

On Thu, Aug 13, 2020 at 06:26:12PM -0400, Eduardo Habkost wrote: > Many QOM types don't follow the Type/TypeClass pattern > on the instance/struct names. Let the class struct name > be specified in the OBJECT_DECLARE* macros. > > Signed-off-by: Eduardo Habkost > --- > include/qom/object.h | 35

Re: [PATCH 19/41] hvf: Move HVFState typedef to hvf.h

On Thu, Aug 13, 2020 at 06:26:03PM -0400, Eduardo Habkost wrote: > Move typedef closer to the type check macros, to make it easier > to convert the code to OBJECT_DEFINE_TYPE() in the future. > > Signed-off-by: Eduardo Habkost > --- > include/sysemu/hvf.h | 1 + > target/i386/hvf/hvf-i386.

Re: [PATCH 29/41] qom: DECLARE_*_CHECKERS macros

On Thu, Aug 13, 2020 at 06:26:13PM -0400, Eduardo Habkost wrote: > Sometimes the typedefs are buried inside another header, but > we want to benefit from the automatic definition of type cast > functions. Introduce macros that will let type checkers be > defined when typedefs are already available

Re: [PATCH 31/41] qom: TYPE_INFO macro

On Thu, Aug 13, 2020 at 06:26:15PM -0400, Eduardo Habkost wrote: > Provide a TYPE_INFO macro that can be used to register a TypeInfo > struct declaratively. This will allow QOM type registration to > be 100% declarative. > > Signed-off-by: Eduardo Habkost > --- > include/qom/object.h | 15 +

Re: [PATCH 2/2] scsi-generic: Fix HM-zoned device scan

On Tue, Aug 11, 2020 at 3:52 PM Dmitry Fomichev wrote: > > Several important steps during device scan depend on SCSI type of the > device. For example, max_transfer property is only determined and > assigned if the device has the type of TYPE_DISK. > > Host-managed ZBC disks retain most of the pro

Re: [PATCH 30/41] qom: Make type checker functions accept const pointers

On Thu, Aug 13, 2020 at 06:26:14PM -0400, Eduardo Habkost wrote: > The existing type check macros all unconditionally drop const > qualifiers from their arguments. Keep this behavior in the > macros generated by DECLARE_*CHECKER* by now. > > In the future, we might use _Generic to preserve const-

Re: [PATCH 22/41] can_emu: Delete macros for non-existing typedef

On Thu, Aug 13, 2020 at 06:26:06PM -0400, Eduardo Habkost wrote: > CanBusClass doesn't exist. This will break when we automatically > convert the code to use OBJECT_DEFINE_TYPE(). Delete the macros > that reference the non-existing typedef. > > Signed-off-by: Eduardo Habkost > --- > include/ne

Re: [PATCH 33/41] [automated] Delete duplicate QOM typedefs

On Thu, Aug 13, 2020 at 06:26:17PM -0400, Eduardo Habkost wrote: > Generated using: > > $ ./scripts/codeconverter/converter.py -i \ >--pattern=QOMDuplicatedTypedefs $(git grep -l '' -- '*.[ch]') > > Signed-off-by: Eduardo Habkost > --- > include/crypto/secret_keyring.h | 8 > 1 fi

Re: [PATCH 35/41] [automated] Move QOM typedefs and add missing includes

On Thu, Aug 13, 2020 at 06:26:19PM -0400, Eduardo Habkost wrote: > Some typedefs and macros are defined after the type check macros. > This makes it difficult to automatically replace their > definitions with OBJECT_DECLARE_TYPE. > > Patch generated using: > > $ ./scripts/codeconverter/converter

Re: [PATCH 34/41] [automated] Use TYPE_INFO macro

On Thu, Aug 13, 2020 at 06:26:18PM -0400, Eduardo Habkost wrote: > Generated using: > $ ./scripts/codeconverter/converter.py -i --passes=2 \ > --pattern=TypeRegisterCall,TypeInitMacro $(git grep -l TypeInfo -- > '*.[ch]') > > Signed-off-by: Eduardo Habkost One notable difference is that f

Re: [PATCH 02/12] hw/vfio/ap: Plug memleak in vfio_ap_get_group()

On Fri, 14 Aug 2020 12:02:31 -0400 Pan Nengyuan wrote: > Missing g_error_free() in vfio_ap_get_group() error path. Fix that. > > Reported-by: Euler Robot > Signed-off-by: Pan Nengyuan > --- > Cc: Cornelia Huck > Cc: Thomas Huth > Cc: Christian Borntraeger > Cc: Tony Krowiak > Cc: Halil Pas

[RFC PATCH 2/9] qtest: Add local qtest_mem_as() getter

Refactor the access to the default address space introducing the qtest_mem_as() getter. This will help us to use another address space in the next commit. Signed-off-by: Philippe Mathieu-Daudé --- softmmu/qtest.c | 32 +++- 1 file changed, 19 insertions(+), 13 deletio

Re: [PATCH 36/41] [automated] Use DECLARE_*CHECKER* macros

On Thu, Aug 13, 2020 at 06:26:20PM -0400, Eduardo Habkost wrote: > $ ./scripts/codeconverter/converter.py -i \ >--pattern=TypeCheckMacro $(git grep -l '' -- '*.[ch]') > > Signed-off-by: Eduardo Habkost > --- > chardev/chardev-internal.h | 3 +- > hw/9pfs/virtio-9p.h

Re: [PATCH v1 5/5] configure: microblaze: Enable mttcg

On Mon, Aug 17, 2020 at 7:03 AM Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Alistair Francis Alistair > --- > configure | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/configure b/configure > index 2acc4d1465..2f7adaa6ae

[RFC PATCH 1/9] memory: Initialize MemoryRegionOps for RAM memory regions

There is an issue when using memory_region_dispatch_read() or memory_region_dispatch_write() on RAM memory regions. RAM memory regions are initialized as: memory_region_init_ram() -> memory_region_init_ram_nomigrate() -> memory_region_init_ram_shared_nomigrate() -> memory_region_

[RFC PATCH 3/9] qtest: Directly use global address_space_memory when no CPU available

Currently all qtest MMIO access are dispatched via the first CPU available. This limitation doesn't allow use to use the 'none' machine to run tests. Unleash this limitation by selecting the global address_space_memory when no CPU is available. Signed-off-by: Philippe Mathieu-Daudé --- softmmu/q

[RFC PATCH 5/9] hw/misc: Add MMIO test device

Add a MMIO test device handy to test QEMU internal devices via MMIO accesses. This device is meant to be run by the 'none' machine, thus no CPU is required. So far it is only useful to test the interleaver device. A SRAM region is split into 256B subregions, and these subregions are mapped at dif

Re: [PATCH] target/riscv: Fix bug in getting trap cause name for trace_riscv_trap

On Thu, Aug 13, 2020 at 9:00 PM Yifei Jiang wrote: > > When the cause number is equal to or greater than 23, print "(unknown)" in > trace_riscv_trap. The max valid number of riscv_excp_names is 23, so the last > excpetion "guest_store_page_fault" can not be printed. > > In addition, the current ch

Re: [PATCH v1 1/5] target/microblaze: mbar: Transfer dc->rd to mbar_imm

On Mon, Aug 17, 2020 at 7:04 AM Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > Transfer dc->rd to mbar_imm to improve the readability when > comparing to the specs. > > No functional change. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Alistair Francis Alistair > --- > targ

[RFC PATCH 6/9] hw/core/null-machine: Allow to use the MMIO 'test' device

The MMIO 'test' device (TYPE_MMIO_TESTDEV) can be mapped almost anywhere on the sysbus memory. Allow the 'none' machine to instantiate it from the command line, such: $ qemu-system-sh4 -M none -monitor stdio \ -device mmio-testdev,address=0x -monitor stdio (qemu) info mtree addre

[RFC PATCH 7/9] tests/qtest: Add generic MMIO tests

Add generic MMIO tests (which don't need any particular knowledge about the architecture) and can be run without any CPU (using the 'none' machine). Start testing the interleaved memory accesses. Cross-endianess is not tested (host and target must have the same endianess). Signed-off-by: Philipp

[RFC PATCH 0/9] hw/misc: Add support for interleaved memory accesses

This is a follow up on last year patch from Stephen Checkoway: "block/pflash_cfi02: Implement intereleaved flash devices" https://www.mail-archive.com/qemu-devel@nongnu.org/msg613077.html Instead of making the PFLASH device more complex, I went implementing a generic interleaver device (that can b

[RFC PATCH 9/9] hw/misc/interleaver: Display subregions in 'info mtree'

Implement the MemoryRegion::subregions_description() handler to be able to display the inverleaved memory regions: $ qemu-system-sh4 -M none -monitor stdio \ -device mmio-testdev,address=0x -monitor stdio address-space: memory - (prio 0, i/o): sy

<    1   2   3   4   5   6   >