Re: [PATCH 7/7] hw/scsi/scsi-disk: Replace magic '512' value by BDRV_SECTOR_SIZE

2020-08-14 Thread Richard Henderson
On 8/14/20 1:28 AM, Philippe Mathieu-Daudé wrote: > Use self-explicit definitions instead of magic '512' value. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/scsi/scsi-disk.c | 44 +++- > 1 file changed, 23 insertions(+), 21 deletions(-) Reviewed-b

Re: [PATCH 0/7] hw/sd: Use sdbus_read_data/sdbus_write_data for multiple bytes access

2020-08-14 Thread Richard Henderson
On 8/14/20 2:23 AM, Philippe Mathieu-Daudé wrote: > Introduce sdbus_read_data() and sdbus_write_data() methods to > access multiple bytes on the data line of a SD bus. > > I haven't named then sdbus_access_block() because I expect a > block to be a power of 2, while there is no such restriction >

Re: [PATCH] hw/net/allwinner-sun8i-emac: Use AddressSpace for DMA transfers

2020-08-14 Thread Richard Henderson
On 8/14/20 5:29 AM, Philippe Mathieu-Daudé wrote: > Allow the device to execute the DMA transfers in a different > AddressSpace. > > The H3 SoC keeps using the system_memory address space, > but via the proper dma_memory_access() API. > > Signed-off-by: Philippe Mathieu-Daudé > --- > Tested with

Re: [PATCH] hw/arm/musicpal: Use AddressSpace for DMA transfers

2020-08-14 Thread Richard Henderson
On 8/14/20 5:55 AM, Philippe Mathieu-Daudé wrote: > Allow the device to execute the DMA transfers in a different > AddressSpace. > > We keep using the system_memory address space, but via the > proper dma_memory_access() API. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/arm/musicpal.c |

Re: [PATCH 1/1] include/elf.h: Add EM_RX.

2020-08-14 Thread Richard Henderson
On 8/14/20 6:14 AM, Yoshinori Sato wrote: > RX's ELF machine not defined elf.h. > Added it. > > Signed-off-by: Yoshinori Sato > --- > include/elf.h | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Richard Henderson r~

Re: [PATCH 5/5] hw/char/avr_usart: Trace baudrate changes

2020-08-14 Thread Richard Henderson
On 8/14/20 9:39 AM, Philippe Mathieu-Daudé wrote: > +static void avr_usart_update_baudrate(AVRUsartState *s) > +{ > +unsigned baudrate = (clock_get_hz(s->clkin) / USART_CLOCK_DIVISOR) > +/ (((s->brrh << 8) | s->brrl) + 1); > + > +trace_avr_usart_update_baudrate((s->b

Re: [PATCH 00/18] hw/riscv: Add Microchip PolarFire SoC Icicle Kit board support

2020-08-14 Thread Anup Patel
On Fri, Aug 14, 2020 at 10:12 PM Bin Meng wrote: > > From: Bin Meng > > This adds support for Microchip PolarFire SoC Icicle Kit board. > The Icicle Kit board integrates a PolarFire SoC, with one SiFive's > E51 plus four U54 cores and many on-chip peripherals and an FPGA. Nice Work !!! This is v

Re: [PATCH 01/41] pl1110: Rename PL1110 enum

2020-08-14 Thread Philippe Mathieu-Daudé
On 8/14/20 12:25 AM, Eduardo Habkost wrote: > The PL1110 enum value name will conflict with the PL1110 type > cast checker, when we replace the existing macro with an inline > function. Rename it to PL1110_STOCK. typo s/PL1110/PL110/ in subject and description. > > Signed-off-by: Eduardo Habkos

Re: [PATCH 05/41] aspeed_timer: Fix ASPEED_TIMER macro definition

2020-08-14 Thread Philippe Mathieu-Daudé
On 8/14/20 12:25 AM, Eduardo Habkost wrote: > The macro definition had an extra semicolon. This was never > noticed because the macro was only being used where it didn't > make a difference. > > Signed-off-by: Eduardo Habkost > --- > include/hw/timer/aspeed_timer.h | 2 +- > 1 file changed, 1 i

Re: [PATCH 06/41] allwinner-h3: Rename memmap enum constants

2020-08-14 Thread Philippe Mathieu-Daudé
+Niek as maintainer. On 8/14/20 12:25 AM, Eduardo Habkost wrote: > Some of the enum constant names conflict with the QOM type check > macros. This needs to be addressed to allow us to transform the > QOM type check macros into functions generated by > OBJECT_DECLARE_TYPE(). > > Rename all the co

Re: [PATCH 08/41] opentitan: Rename memmap enum constants

2020-08-14 Thread Philippe Mathieu-Daudé
On 8/14/20 12:25 AM, Eduardo Habkost wrote: > Some of the enum constant names conflict with the QOM type check > macros. This needs to be addressed to allow us to transform the > QOM type check macros into functions generated by > OBJECT_DECLARE_TYPE(). > > Rename all the constants to IBEX_DEV_*,

Re: [PATCH 11/41] versatile: Fix typo in PCI_VPB_HOST definition

2020-08-14 Thread Philippe Mathieu-Daudé
On 8/14/20 12:25 AM, Eduardo Habkost wrote: > Signed-off-by: Eduardo Habkost > --- > hw/pci-host/versatile.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/pci-host/versatile.c b/hw/pci-host/versatile.c > index 616882a80d..7e4aa467a2 100644 > --- a/hw/pci-host/versat

Re: [PATCH 14/41] hcd-dwc2: Rename USB_*CLASS macros for consistency

2020-08-14 Thread Philippe Mathieu-Daudé
On 8/14/20 12:25 AM, Eduardo Habkost wrote: > Rename the DWC2_CLASS to DWC2_USB_CLASS and DWC2_GET_CLASS to > DWC2_USB_GET_CLASS, for consistency with the DWC2_USB macro. > > Signed-off-by: Eduardo Habkost Reviewed-by: Philippe Mathieu-Daudé > --- > hw/usb/hcd-dwc2.h | 4 ++-- > hw/usb/hcd-dw

Re: [PATCH 15/41] tulip: Move TulipState typedef to header

2020-08-14 Thread Philippe Mathieu-Daudé
On 8/14/20 12:25 AM, Eduardo Habkost wrote: > Move typedef closer to the type check macros, to make it easier > to convert the code to OBJECT_DEFINE_TYPE() in the future. > > Signed-off-by: Eduardo Habkost Reviewed-by: Philippe Mathieu-Daudé > --- > hw/net/tulip.h | 1 + > hw/net/tulip.c | 4

Re: [PATCH 16/41] throttle-groups: Move ThrottleGroup typedef to header

2020-08-14 Thread Philippe Mathieu-Daudé
On 8/14/20 12:26 AM, Eduardo Habkost wrote: > Move typedef closer to the type check macros, to make it easier > to convert the code to OBJECT_DEFINE_TYPE() in the future. > > Signed-off-by: Eduardo Habkost Reviewed-by: Philippe Mathieu-Daudé > --- > include/block/throttle-groups.h | 1 + > bl

Re: [PATCH 23/41] nubus: Delete unused NUBUS_BRIDGE macro

2020-08-14 Thread Philippe Mathieu-Daudé
On 8/14/20 12:26 AM, Eduardo Habkost wrote: > The macro never worked because the NubusBridge typedef doesn't > exist. Delete it. > > Signed-off-by: Eduardo Habkost Reviewed-by: Philippe Mathieu-Daudé > --- > include/hw/nubus/nubus.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/in

Re: [PATCH v5 0/5] fix & merge block_status_above and is_allocated_above

2020-08-14 Thread Vladimir Sementsov-Ogievskiy
ping :) 10.06.2020 15:04, Vladimir Sementsov-Ogievskiy wrote: v5: rebase on coroutine-wrappers series, 02 changed correspondingly Based on series "[PATCH v7 0/7] coroutines: generate wrapper code", or in other words: Based-on: <20200610100336.23451-1-vsement...@virtuozzo.com> Hi all! These se

Re: [PATCH 22/41] can_emu: Delete macros for non-existing typedef

2020-08-14 Thread Philippe Mathieu-Daudé
On 8/14/20 12:26 AM, Eduardo Habkost wrote: > CanBusClass doesn't exist. This will break when we automatically > convert the code to use OBJECT_DEFINE_TYPE(). Delete the macros > that reference the non-existing typedef. > > Signed-off-by: Eduardo Habkost Reviewed-by: Philippe Mathieu-Daudé >

Re: [PATCH 18/41] i8254: Move PITCommonState/PITCommonClass typedefs to i8254.h

2020-08-14 Thread Philippe Mathieu-Daudé
On 8/14/20 12:26 AM, Eduardo Habkost wrote: > Move typedef closer to the type check macros, to make it easier > to convert the code to OBJECT_DEFINE_TYPE() in the future. > > Signed-off-by: Eduardo Habkost Reviewed-by: Philippe Mathieu-Daudé > --- > include/hw/timer/i8254.h | 2 ++ >

Re: [PATCH 30/41] qom: Make type checker functions accept const pointers

2020-08-14 Thread Philippe Mathieu-Daudé
On 8/14/20 12:26 AM, Eduardo Habkost wrote: > The existing type check macros all unconditionally drop const > qualifiers from their arguments. Keep this behavior in the > macros generated by DECLARE_*CHECKER* by now. > > In the future, we might use _Generic to preserve const-ness of > the cast fu

Re: [PATCH 0/1] qcow2: Skip copy-on-write when allocating a zero cluster

2020-08-14 Thread Vladimir Sementsov-Ogievskiy
Hi! 14.08.2020 17:57, Alberto Garcia wrote: Hi, the patch is self-explanatory, but I'm using the cover letter to raise a couple of related questions. Since commit c8bb23cbdbe / QEMU 4.1.0 (and if the storage backend allows it) writing to an image created with preallocation=metadata can be slow

Re: [PATCH 1/1] qcow2: Skip copy-on-write when allocating a zero cluster

2020-08-14 Thread Vladimir Sementsov-Ogievskiy
14.08.2020 17:57, Alberto Garcia wrote: Since commit c8bb23cbdbe32f5c326365e0a82e1b0e68cdcd8a when a write request results in a new allocation QEMU first tries to see if the rest of the cluster outside the written area contains only zeroes. In that case, instead of doing a normal copy-on-write o

Re: [PATCH 00/18] hw/riscv: Add Microchip PolarFire SoC Icicle Kit board support

2020-08-14 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1597423256-14847-1-git-send-email-bmeng...@gmail.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIP

DROP Re: [PATCH v2 0/9] preallocate filter

2020-08-14 Thread Vladimir Sementsov-Ogievskiy
v3 will come soon, don't look at this. 14.08.2020 16:03, Vladimir Sementsov-Ogievskiy wrote: Hi all! Here is a filter, which does preallocation on write. In Virtuozzo we have to deal with some custom distributed storage solution, where allocation is relatively expensive operation. We have to w

Re: [RFC v3 26/71] target/riscv: rvv-1.0: update vext_max_elems() for load/store insns

2020-08-14 Thread Richard Henderson
On 8/13/20 7:48 PM, Frank Chang wrote: > esz is passed from e.g. GEN_VEXT_LD_STRIDE() macro: > >> #define GEN_VEXT_LD_STRIDE(NAME, ETYPE, LOAD_FN)        \ >> void HELPER(NAME)(void *vd, void * v0, target_ulong base,  \ >>                   target_ulong stride, CPURISCVState *env, \ >>            

Re: [PATCH v5 03/20] qapi/block-core.json: Fix nbd-server-start docs

2020-08-14 Thread Richard Henderson
On 8/10/20 12:50 PM, Peter Maydell wrote: > Commit eed8b6917832 added some new text to the nbd-server-start > documentation in the wrong place. Since this is after the 'Returns:' > line it's parsed as if it were part of the documentation of the > "Returns:' information. Move it up to join the res

Re: [PATCH v5 02/20] qapi: Fix indentation, again

2020-08-14 Thread Richard Henderson
On 8/10/20 12:50 PM, Peter Maydell wrote: > In commit 26ec4e53f2 and similar commits we fixed the indentation > for doc comments in our qapi json files to follow a new stricter > standard for indentation, which permits only: > @arg: description line 1 > description line 2 > > or: >

Re: [PATCH v5 09/20] docs/sphinx: Add new qapi-doc Sphinx extension

2020-08-14 Thread Richard Henderson
On 8/10/20 12:50 PM, Peter Maydell wrote: > Some of our documentation is auto-generated from documentation > comments in the JSON schema. > > For Sphinx, rather than creating a file to include, the most natural > way to handle this is to have a small custom Sphinx extension which > processes the J

Re: [PATCH 3/7] target/arm/cpu: spe: Add an option to turn on/off vSPE support

2020-08-14 Thread Richard Henderson
On 8/10/20 3:50 AM, Andrew Jones wrote: >> @@ -1959,6 +1961,7 @@ enum arm_features { >> ARM_FEATURE_VBAR, /* has cp15 VBAR */ >> ARM_FEATURE_M_SECURITY, /* M profile Security Extension */ >> ARM_FEATURE_M_MAIN, /* M profile Main Extension */ >> +ARM_FEATURE_SPE, /* has SPE suppor

Re: [PATCH 3/7] target/arm/cpu: spe: Add an option to turn on/off vSPE support

2020-08-14 Thread Richard Henderson
On 8/7/20 1:10 AM, Haibo Xu wrote: > +static void arm_set_spe(Object *obj, bool value, Error **errp) > +{ > +ARMCPU *cpu = ARM_CPU(obj); > + > +if (value) { > +if (kvm_enabled() && !kvm_arm_spe_supported()) { > +error_setg(errp, "'spe' feature not supported by KVM on thi

Re: [PATCH 2/7] target/arm/kvm: spe: Add helper to detect SPE when using KVM

2020-08-14 Thread Richard Henderson
On 8/7/20 1:10 AM, Haibo Xu wrote: > Signed-off-by: Haibo Xu > --- > target/arm/kvm.c | 5 + > target/arm/kvm_arm.h | 13 + > 2 files changed, 18 insertions(+) Reviewed-by: Richard Henderson r~

Re: [PATCH 7/7] target/arm/cpu: spe: Enable spe to work with host cpu

2020-08-14 Thread Richard Henderson
On 8/11/20 9:49 AM, Andrew Jones wrote: > Yes, except you need to drop the ARM_FEATURE_SPE define and use the ID > register bit instead like "sve_supported" does. On a related note, I think we have a latent bug, or at least a mis-feature: sve_supported = ioctl(fdarray[0], KVM_CHECK_EXTENSION,

[Bug 1805256] Re: qemu-img hangs on rcu_call_ready_event logic in Aarch64 when converting images

2020-08-14 Thread dann frazier
** Changed in: kunpeng920/ubuntu-18.04-hwe Status: Triaged => Fix Committed ** Changed in: kunpeng920/ubuntu-18.04 Status: Triaged => Fix Committed ** Changed in: kunpeng920 Status: Triaged => Fix Committed -- You received this bug notification because you are a member of q

Re: [PATCH v3 1/1] cputlb: Make store_helper less fragile to compiler optimizations

2020-08-14 Thread Shu-Chun Weng
Can confirm this fixed the build in our configuration. Thank you. Shu-Chun On Thu, Aug 13, 2020 at 1:40 PM Richard Henderson < richard.hender...@linaro.org> wrote: > This has no functional change. > > The current function structure is: > > inline QEMU_ALWAYSINLINE > store_memop() { >

Re: [PATCH v5 01/14] cpu-timers, icount: new modules

2020-08-14 Thread Richard Henderson
On 8/12/20 11:32 AM, Claudio Fontana wrote: > +/* > + * Return the icount enablement state: > + * > + * 0 = Disabled - Do not count executed instructions. > + * 1 = Enabled - Fixed conversion of insn to ns via "shift" option > + * 2 = Enabled - Runtime adaptive algorithm to compute shift > + */ > +

Re: [PATCH v5 02/14] cpus: prepare new CpusAccel cpu accelerator interface

2020-08-14 Thread Richard Henderson
On 8/12/20 11:32 AM, Claudio Fontana wrote: > uint64_t cpu_get_tsc(CPUX86State *env) > { > -return cpu_get_ticks(); > +return cpus_get_elapsed_ticks(); What has this change got to do with creating the interface? You said the interface wasn't used yet... > diff --git a/stubs/cpu-synchro

Re: [PATCH v5 03/14] cpus: extract out TCG-specific code to accel/tcg

2020-08-14 Thread Richard Henderson
On 8/12/20 11:32 AM, Claudio Fontana wrote: > +static int64_t tcg_get_virtual_clock(void) > +{ > +if (icount_enabled()) { > +return icount_get(); > +} > +return cpu_get_clock(); > +} > + > +static int64_t tcg_get_elapsed_ticks(void) > +{ > +if (icount_enabled()) { > +

Re: [PATCH v5 04/14] cpus: extract out qtest-specific code to accel/qtest

2020-08-14 Thread Richard Henderson
On 8/12/20 11:32 AM, Claudio Fontana wrote: > +CpusAccel qtest_cpus = { > +.create_vcpu_thread = qtest_start_vcpu_thread, > +.get_virtual_clock = qtest_get_virtual_clock, > +}; const. Do you need to fill in the other methods, even if they do nothing but g_assert_not_reached()? > -

Re: [PATCH v5 05/14] cpus: extract out kvm-specific code to accel/kvm

2020-08-14 Thread Richard Henderson
On 8/12/20 11:32 AM, Claudio Fontana wrote: > + > +CpusAccel kvm_cpus = { > +.create_vcpu_thread = kvm_start_vcpu_thread, > + > +.synchronize_post_reset = kvm_cpu_synchronize_post_reset, > +.synchronize_post_init = kvm_cpu_synchronize_post_init, > +.synchronize_state = kvm_cpu_synch

Re: [PATCH v5 06/14] cpus: extract out hax-specific code to target/i386/

2020-08-14 Thread Richard Henderson
On 8/12/20 11:32 AM, Claudio Fontana wrote: > +CpusAccel hax_cpus = { > +.create_vcpu_thread = hax_start_vcpu_thread, > +.kick_vcpu_thread = hax_kick_vcpu_thread, > + > +.synchronize_post_reset = hax_cpu_synchronize_post_reset, > +.synchronize_post_init = hax_cpu_synchronize_post_in

Re: [PATCH v5 07/14] cpus: extract out whpx-specific code to target/i386/

2020-08-14 Thread Richard Henderson
On 8/12/20 11:32 AM, Claudio Fontana wrote: > +CpusAccel whpx_cpus = { > +.create_vcpu_thread = whpx_start_vcpu_thread, > +.kick_vcpu_thread = whpx_kick_vcpu_thread, > + > +.synchronize_post_reset = whpx_cpu_synchronize_post_reset, > +.synchronize_post_init = whpx_cpu_synchronize_po

Re: [PATCH v5 08/14] cpus: extract out hvf-specific code to target/i386/hvf/

2020-08-14 Thread Richard Henderson
On 8/12/20 11:32 AM, Claudio Fontana wrote: > +CpusAccel hvf_cpus = { > +.create_vcpu_thread = hvf_start_vcpu_thread, > + > +.synchronize_post_reset = hvf_cpu_synchronize_post_reset, > +.synchronize_post_init = hvf_cpu_synchronize_post_init, > +.synchronize_state = hvf_cpu_synchroni

Re: [PATCH v5 09/14] cpus: cleanup now unneeded includes

2020-08-14 Thread Richard Henderson
On 8/12/20 11:32 AM, Claudio Fontana wrote: > Signed-off-by: Claudio Fontana > --- > softmmu/cpus.c | 7 --- > 1 file changed, 7 deletions(-) Reviewed-by: Richard Henderson r~

<    1   2   3   4