Re: [PATCH 1/1] os_find_datadir: search as in version 4.2

2020-08-10 Thread Marc-André Lureau
Hi On Sat, Aug 8, 2020 at 7:34 PM Peter Maydell wrote: > > On Sat, 8 Aug 2020 at 02:35, Brian Norris wrote: > > > > Hello! > > > > On Wed, Jul 15, 2020 at 11:57:14PM +0400, Marc-André Lureau wrote: > > > Hi > > > > > > On Wed, Jul 15, 2020 at 11:37 PM Peter Maydell > > > wrote: > > > > > > > >

Re: [PATCH 1/1] os_find_datadir: search as in version 4.2

2020-08-10 Thread Marc-André Lureau
On Tue, Jun 16, 2020 at 2:59 AM Joe Slater wrote: > Always look for ../share/qemu then ../pc-bios when looking for datadir. > > Signed-off-by: Joe Slater > Reviewed-by: Marc-André Lureau --- > os-posix.c | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/os-posi

Re: device compatibility interface for live migration with assigned devices

2020-08-10 Thread Yan Zhao
On Wed, Aug 05, 2020 at 12:53:19PM +0200, Jiri Pirko wrote: > Wed, Aug 05, 2020 at 11:33:38AM CEST, yan.y.z...@intel.com wrote: > >On Wed, Aug 05, 2020 at 04:02:48PM +0800, Jason Wang wrote: > >> > >> On 2020/8/5 下午3:56, Jiri Pirko wrote: > >> > Wed, Aug 05, 2020 at 04:41:54AM CEST, jasow...@redha

Re: [PATCH v7 14/47] stream: Deal with filters

2020-08-10 Thread Max Reitz
On 07.08.20 12:29, Vladimir Sementsov-Ogievskiy wrote: > 16.07.2020 17:59, Max Reitz wrote: >> On 10.07.20 19:41, Andrey Shinkevich wrote: >>> On 10.07.2020 18:24, Max Reitz wrote: On 09.07.20 16:52, Andrey Shinkevich wrote: > On 25.06.2020 18:21, Max Reitz wrote: >> Because of the (no

[Bug 1349722] Re: qemu-io: Exit code is always zero

2020-08-10 Thread Max Reitz
Should be fixed as of 6b3aa8485ca8e. ** Changed in: qemu Status: Incomplete => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1349722 Title: qemu-io: Exit code is always zero S

[PATCH] hw/pci-host: save/restore pci host config register for old ones

2020-08-10 Thread Hogan Wang
The i440fx and q35 machines integrate i440FX or MCH PCI device by default. Refer to i440FX and ICH9-LPC spcifications, there are some reserved configuration registers can used to save/restore PCIHostState.config_reg. It's nasty but friendly to old ones. Reproducer steps: step 1. Make modifications

Re: [PATCH] acceptance: update asset hashes for the Bionic aarch64 installer

2020-08-10 Thread Philippe Mathieu-Daudé
On 8/10/20 12:37 AM, Paolo Bonzini wrote: > The kernel and initrd hashes seem to have changed for the Bionic > aarch64 installer, causing BootLinuxConsole.test_aarch64_xlnx_versal_virt > to fail. Correct them based on the latest. Thanks for reporting the failure. > > Signed-off-by: Paolo Bonzin

[Bug 1407808] Re: virtual console gives strange response to ANSI DSR

2020-08-10 Thread Nadav Har'El
The bug still very much exists (I tested qemu 4.2.1): If you don't use "-serial stdio" (or its newer variants), by default Qemu opens a new black "console" to run the application. It is not clear to me exactly which terminal this console is supposed to emulate, but it does seem to support most A

Re: [PATCH] acceptance: update asset hashes for the Bionic aarch64 installer

2020-08-10 Thread Paolo Bonzini
On 10/08/20 11:06, Philippe Mathieu-Daudé wrote: > The 'bug' is this link is using "current" which will be a problem each > time Ubuntu update the installer (latest update was last Wed, Aug 5). > > Acceptance tests should be stick to a particular set of binary, knew to > have worked once in the pa

[PATCH for-5.1 v2] acceptance: use stable URLs for the Debian and Ubuntu installer

2020-08-10 Thread Paolo Bonzini
The kernel and initrd hashes seem to have changed for the Bionic aarch64 installer, causing BootLinuxConsole.test_aarch64_xlnx_versal_virt to fail. Correct the paths to use the previous binaries instead of the latest. Do the same for the Lenny alpha installer for consistency, even though those ar

[PATCH v2 2/2] tests/acceptance/boot_linux: Use stable URL for xlnx-versal test

2020-08-10 Thread Philippe Mathieu-Daudé
In commit 27dfbafaa7 we added an acceptance test for the xlnx-versal-virt machine but used an unstable URL (no guarantee the files would be updated during the next release, which occured last week on Wednesday, Aug 5). Fix by using the stable directory name containing the release date. Reported-by

[PATCH v2 0/2] acceptance: update asset urls for the Bionic aarch64 installer

2020-08-10 Thread Philippe Mathieu-Daudé
v2 of Paolo's patch: https://www.mail-archive.com/qemu-devel@nongnu.org/msg728610.html Do not update the binaries (and their hash), update the path to the current tested binaries. Supersedes: <20200809223741.56570-1-pbonz...@redhat.com> Philippe Mathieu-Daudé (2): tests/acceptance/boot_linux:

[PATCH v2 1/2] tests/acceptance/boot_linux: Extract common URL from xlnx-versal test

2020-08-10 Thread Philippe Mathieu-Daudé
Both files refer to the same directory. Store the common part in a new variable. Signed-off-by: Philippe Mathieu-Daudé --- tests/acceptance/boot_linux_console.py | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/tests/acceptance/boot_linux_console.py b/tests/accept

Re: [PATCH] acceptance: update asset hashes for the Bionic aarch64 installer

2020-08-10 Thread Philippe Mathieu-Daudé
On 8/10/20 11:24 AM, Paolo Bonzini wrote: > On 10/08/20 11:06, Philippe Mathieu-Daudé wrote: >> The 'bug' is this link is using "current" which will be a problem each >> time Ubuntu update the installer (latest update was last Wed, Aug 5). >> >> Acceptance tests should be stick to a particular set

Re: [PATCH] acceptance: update asset hashes for the Bionic aarch64 installer

2020-08-10 Thread Philippe Mathieu-Daudé
On 8/10/20 12:37 AM, Paolo Bonzini wrote: > The kernel and initrd hashes seem to have changed for the Bionic > aarch64 installer, causing BootLinuxConsole.test_aarch64_xlnx_versal_virt > to fail. Correct them based on the latest. > > Signed-off-by: Paolo Bonzini > --- > tests/acceptance/boot_li

Re: QEMU Library support

2020-08-10 Thread Alex Bennée
Pratik Parvati writes: > Hi team, > > Lately, I have been working on QEMU modeling and interfacing it into the > existing platform. What actually I wanted to check is; whether QEMU > supports library that gives developers a clean interface to develop and > integrate peripheral model in to QEMU.

Re: Any reason VIRTQUEUE_MAX_SIZE is 1024? Can we increase this limit?

2020-08-10 Thread Jason Wang
On 2020/8/7 下午5:59, Stefan Hajnoczi wrote: On Fri, Aug 07, 2020 at 11:35:08AM +0800, Jason Wang wrote: On 2020/8/6 下午8:37, Stefan Hajnoczi wrote: On Wed, Aug 05, 2020 at 08:13:29AM -0400, Michael S. Tsirkin wrote: On Wed, Aug 05, 2020 at 01:11:07PM +0100, Stefan Hajnoczi wrote: On Thu, Jul

Re: [PATCH for-5.1 v2] acceptance: use stable URLs for the Debian and Ubuntu installer

2020-08-10 Thread Philippe Mathieu-Daudé
On 8/10/20 11:29 AM, Paolo Bonzini wrote: > The kernel and initrd hashes seem to have changed for the Bionic > aarch64 installer, causing BootLinuxConsole.test_aarch64_xlnx_versal_virt > to fail. Correct the paths to use the previous binaries instead of > the latest. Do the same for the Lenny alp

[PATCH for-5.1 v2 2/2] iotests: add test for unaligned granularity bitmap backup

2020-08-10 Thread Stefan Reiter
Start a VM with a 4097 byte image attached, add a 4096 byte granularity dirty bitmap, mark it dirty, and then do a backup. This used to run into an assert and fail, check that it works as expected and also check the created image to ensure that misaligned backups in general work correctly. Signed

[PATCH for-5.1 v2 1/2] block/block-copy: always align copied region to cluster size

2020-08-10 Thread Stefan Reiter
Since commit 42ac214406e0 (block/block-copy: refactor task creation) block_copy_task_create calculates the area to be copied via bdrv_dirty_bitmap_next_dirty_area, but that can return an unaligned byte count if the image's last cluster end is not aligned to the bitmap's granularity. Always ALIGN_U

Re: [DRAFT PATCH 000/143] Meson integration for 5.2

2020-08-10 Thread Cornelia Huck
On Fri, 7 Aug 2020 17:18:42 +0200 Paolo Bonzini wrote: > On 07/08/20 14:20, Cornelia Huck wrote: > >> - on an s390x system, it mostly builds, but I end up with a bunch of > >> link errors for libblock.fa, where it fails to find various ZSTD_ > >> symbols > > Still happening after switching

Re: QEMU Library support

2020-08-10 Thread Pratik Parvati
As an experiment, I have modelled non-existing ARM Watchdog model (SP805) interfaced to the versatile PB platform. What actually I was looking is - some sort of QEMU library, where I can model new device outside the QEMU source hierarchy and still be able to compile it using QEMU library and includ

Re: [DRAFT PATCH 000/143] Meson integration for 5.2

2020-08-10 Thread Cornelia Huck
On Mon, 10 Aug 2020 11:58:51 +0200 Cornelia Huck wrote: > On Fri, 7 Aug 2020 17:18:42 +0200 > Paolo Bonzini wrote: > > > On 07/08/20 14:20, Cornelia Huck wrote: > > >> - on an s390x system, it mostly builds, but I end up with a bunch of > > >> link errors for libblock.fa, where it fails to

[Bug 1890545] Re: (ARM64) qemu-x86_64+schroot(Debian bullseye) can't run chrome and can't load HTML

2020-08-10 Thread Tony.LI
When I run some app,like google-chrome: qemu: uncaught target signal 5 (Trace/breakpoint trap) - core dumped -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1890545 Title: (ARM64) qemu-x86_64+schr

Re: [PATCH 3/7] target/arm/cpu: spe: Add an option to turn on/off vSPE support

2020-08-10 Thread Philippe Mathieu-Daudé
On 8/10/20 5:03 AM, Haibo Xu wrote: > On Fri, 7 Aug 2020 at 16:28, Philippe Mathieu-Daudé wrote: >> >> Hi Haibo, >> >> On 8/7/20 10:10 AM, Haibo Xu wrote: >>> Adds a spe=[on/off] option to enable/disable vSPE support in >>> guest vCPU. Note this option is only available for "-cpu host" >>> with KV

[PATCH v2 for 5.2 0/3] block: add logging facility for long standing IO requests

2020-08-10 Thread Denis V. Lunev
There are severe delays with IO requests processing if QEMU is running in virtual machine or over software defined storage. Such delays potentially results in unpredictable guest behavior. For example, guests over IDE or SATA drive could remount filesystem read-only if write is performed longer tha

[PATCH 1/3] block/block-backend: add converter from BlockAcctStats to BlockBackend

2020-08-10 Thread Denis V. Lunev
Right now BlockAcctStats is always reside on BlockBackend. This structure is not used in any other place. Thus we are able to create a converter from one pointer to another. Signed-off-by: Denis V. Lunev Reviewed-by: Vladimir Sementsov-Ogievskiy CC: Stefan Hajnoczi CC: Kevin Wolf CC: Max Reitz

[PATCH 3/3] block: enable long IO requests report by default

2020-08-10 Thread Denis V. Lunev
Latency threshold is set to 10 seconds following guest request timeout on legacy storage controller. Signed-off-by: Denis V. Lunev CC: Vladimir Sementsov-Ogievskiy CC: Stefan Hajnoczi CC: Kevin Wolf CC: Max Reitz --- blockdev.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) dif

[PATCH 2/3] block: add logging facility for long standing IO requests

2020-08-10 Thread Denis V. Lunev
There are severe delays with IO requests processing if QEMU is running in virtual machine or over software defined storage. Such delays potentially results in unpredictable guest behavior. For example, guests over IDE or SATA drive could remount filesystem read-only if write is performed longer tha

Re: [PATCH] docs/system/s390x: Add a chapter about s390x boot devices

2020-08-10 Thread Cornelia Huck
On Thu, 6 Aug 2020 17:05:07 +0200 Thomas Huth wrote: > Booting on s390x is a little bit different compared to other architectures. > Let's add some information for people who are not yet used to this. > > Signed-off-by: Thomas Huth > --- > docs/system/s390x/bootdevices.rst | 82 ++

Re: [PATCH] docs/system/s390x: Add a chapter about s390x boot devices

2020-08-10 Thread Philippe Mathieu-Daudé
On 8/10/20 12:18 PM, Cornelia Huck wrote: > On Thu, 6 Aug 2020 17:05:07 +0200 > Thomas Huth wrote: > >> Booting on s390x is a little bit different compared to other architectures. >> Let's add some information for people who are not yet used to this. >> >> Signed-off-by: Thomas Huth >> --- >>

[Bug 1890545] Re: (ARM64) qemu-x86_64+schroot(Debian bullseye) can't run chrome and can't load HTML

2020-08-10 Thread Peter Maydell
Which QEMU version are you using ? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1890545 Title: (ARM64) qemu-x86_64+schroot(Debian bullseye) can't run chrome and can't load HTML Status in QEMU:

Re: QEMU Library support

2020-08-10 Thread Alex Bennée
Pratik Parvati writes: > As an experiment, I have modelled non-existing ARM Watchdog model (SP805) > interfaced to the versatile PB platform. What actually I was looking is - > some sort of QEMU library, where I can model new device outside the QEMU > source hierarchy and still be able to compi

Re: [PATCH 4/7] target/arm/kvm: spe: Unify device attr operatioin helper

2020-08-10 Thread Andrew Jones
On Mon, Aug 10, 2020 at 10:48:41AM +0800, Haibo Xu wrote: > On Fri, 7 Aug 2020 at 16:19, Philippe Mathieu-Daudé wrote: > > > > On 8/7/20 10:10 AM, Haibo Xu wrote: > > > Rename kvm_arm_pmu_set_attr() to kvm_arm_dev_set_attr(), > > > > Maybe rename kvm_arm_device_set_attr() to match the structure >

Re: [PATCH] docs/system/s390x: Add a chapter about s390x boot devices

2020-08-10 Thread Cornelia Huck
On Mon, 10 Aug 2020 12:20:53 +0200 Philippe Mathieu-Daudé wrote: > On 8/10/20 12:18 PM, Cornelia Huck wrote: > > On Thu, 6 Aug 2020 17:05:07 +0200 > > Thomas Huth wrote: > > > >> Booting on s390x is a little bit different compared to other architectures. > >> Let's add some information for p

Re: [RFC PATCH] CODING_STYLE.rst: flesh out our naming conventions.

2020-08-10 Thread Alex Bennée
Claudio Fontana writes: > On 8/6/20 1:40 PM, Alex Bennée wrote: >> Mention a few of the more common naming conventions we follow in the >> code base including common variable names and function prefix and >> suffix examples. >> >> Signed-off-by: Alex Bennée >> --- >> CODING_STYLE.rst | 23 ++

Re: [DRAFT PATCH 000/143] Meson integration for 5.2

2020-08-10 Thread Philippe Mathieu-Daudé
On 8/7/20 5:58 PM, Daniel P. Berrangé wrote: > On Fri, Aug 07, 2020 at 05:14:06PM +0200, Paolo Bonzini wrote: >> That one exception, the one thing that disappoints me of the whole >> conversion, is the trace.h files. The current solution is one of the >> first parts I did of the conversion and I h

Re: [DRAFT PATCH 000/143] Meson integration for 5.2

2020-08-10 Thread Philippe Mathieu-Daudé
On 8/7/20 5:30 PM, Paolo Bonzini wrote: > On 07/08/20 16:29, Daniel P. Berrangé wrote: >> New binaries have lost a bunch of libraries they previously linked >> to. This isn't neccessarily a bug, if the old make code was incorrectly >> adding too many libraries. > > Yes this is because Meson uses -

[Bug 1890545] Re: (ARM64) qemu-x86_64+schroot(Debian bullseye) can't run chrome and can't load HTML

2020-08-10 Thread Tony.LI
Hi Peter,I use 5.1.0-rc3. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1890545 Title: (ARM64) qemu-x86_64+schroot(Debian bullseye) can't run chrome and can't load HTML Status in QEMU: New Bu

Re: [PATCH] docs/system/s390x: Add a chapter about s390x boot devices

2020-08-10 Thread Philippe Mathieu-Daudé
On 8/10/20 12:29 PM, Cornelia Huck wrote: > On Mon, 10 Aug 2020 12:20:53 +0200 > Philippe Mathieu-Daudé wrote: > >> On 8/10/20 12:18 PM, Cornelia Huck wrote: >>> On Thu, 6 Aug 2020 17:05:07 +0200 >>> Thomas Huth wrote: >>> Booting on s390x is a little bit different compared to other arc

Re: [PATCH 0/7] target/arm: Add vSPE support to KVM guest

2020-08-10 Thread Andrew Jones
On Fri, Aug 07, 2020 at 08:10:30AM +, Haibo Xu wrote: > This series add support for SPE(Statistical Profiling Extension)[1] > in KVM guest. It's based on Andrew Murray's kernel KVM patches V2[2], > and has been tested to ensure that guest can use SPE with valid data. > E.g. > > In host: > $ ./

[Bug 1890545] Re: (ARM64) qemu-x86_64+schroot(Debian bullseye) can't run chrome and can't load HTML

2020-08-10 Thread Tony.LI
It's fine on x86 that I use qemu-x86_64-static.But it's bad on arm.So what is the problem? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1890545 Title: (ARM64) qemu-x86_64+schroot(Debian bullseye)

Re: [PATCH 3/7] target/arm/cpu: spe: Add an option to turn on/off vSPE support

2020-08-10 Thread Andrew Jones
On Fri, Aug 07, 2020 at 08:10:33AM +, Haibo Xu wrote: > Adds a spe=[on/off] option to enable/disable vSPE support in > guest vCPU. Note this option is only available for "-cpu host" > with KVM mode, and default value is on. > > Signed-off-by: Haibo Xu > --- > target/arm/cpu.c | 28 +

[PATCH v2] CODING_STYLE.rst: flesh out our naming conventions.

2020-08-10 Thread Alex Bennée
Mention a few of the more common naming conventions we follow in the code base including common variable names and function prefix and suffix examples. Signed-off-by: Alex Bennée --- v2 - punctuation fixes suggested by Cornelia - re-worded section on qemu_ prefix - expanded on _locked suff

[PATCH v3] fcntl: Add 32bit filesystem mode

2020-08-10 Thread Linus Walleij
It was brought to my attention that this bug from 2018 was still unresolved: 32 bit emulators like QEMU were given 64 bit hashes when running 32 bit emulation on 64 bit systems. This adds a flag to the fcntl() F_GETFD and F_SETFD operations to set the underlying filesystem into 32bit mode even if

Re: [PATCH v7 14/47] stream: Deal with filters

2020-08-10 Thread Vladimir Sementsov-Ogievskiy
10.08.2020 11:12, Max Reitz wrote: On 07.08.20 12:29, Vladimir Sementsov-Ogievskiy wrote: 16.07.2020 17:59, Max Reitz wrote: On 10.07.20 19:41, Andrey Shinkevich wrote: On 10.07.2020 18:24, Max Reitz wrote: On 09.07.20 16:52, Andrey Shinkevich wrote: On 25.06.2020 18:21, Max Reitz wrote: Be

Re: [PATCH 6/7] hw/arm/virt: spe: Add SPE fdt binding for virt machine

2020-08-10 Thread Andrew Jones
On Fri, Aug 07, 2020 at 08:10:36AM +, Haibo Xu wrote: > Add a virtual SPE device for virt machine while using PPI > 5 for SPE overflow interrupt number. Any reason PPI 5 was selected? > > Signed-off-by: Haibo Xu > --- > hw/arm/virt-acpi-build.c| 3 +++ > hw/arm/virt.c

Re: [Bug 1890545] Re: (ARM64) qemu-x86_64+schroot(Debian bullseye) can't run chrome and can't load HTML

2020-08-10 Thread Alex Bennée
Tony.LI <1890...@bugs.launchpad.net> writes: > It's fine on x86 that I use qemu-x86_64-static.But it's bad on arm.So > what is the problem? Could be a number of things - is Chrome using threading alongside it's multiple processes? -- Alex Bennée

Re: [PATCH] acceptance: update asset hashes for the Bionic aarch64 installer

2020-08-10 Thread Paolo Bonzini
On 10/08/20 11:35, Philippe Mathieu-Daudé wrote: >> That seems overkill but yeah the tests should have used >> 20101020ubuntu543.15 instead of current. I think this should get into rc4. > As our CI is not yet gating, I don't think this justifies delaying the > release (except if there is a critica

Re: [DRAFT PATCH 000/143] Meson integration for 5.2

2020-08-10 Thread Paolo Bonzini
On 10/08/20 12:04, Cornelia Huck wrote: > 'make check' is unhappy, however: > > Running test qtest-s390x: device-introspect-test > missing object type 'virtio-gpu-device' > Broken pipe > ../tests/qtest/libqtest.c:175: kill_qemu() detected QEMU death from signal 6 > (Aborted) (core dumped) > ERROR

Re: [PATCH 7/7] target/arm/cpu: spe: Enable spe to work with host cpu

2020-08-10 Thread Andrew Jones
On Fri, Aug 07, 2020 at 08:10:37AM +, Haibo Xu wrote: > Turn on the spe cpu property by default when working with host > cpu type in KVM mode, i.e. we can now do '-cpu host' to add the > vSPE, and '-cpu host,spe=off' to remove it. -cpu max with KVM should also enable it by default > > Sign

Re: [DRAFT PATCH 000/143] Meson integration for 5.2

2020-08-10 Thread Paolo Bonzini
On 10/08/20 12:34, Philippe Mathieu-Daudé wrote: >>> New binaries have lost a bunch of libraries they previously linked >>> to. This isn't neccessarily a bug, if the old make code was incorrectly >>> adding too many libraries. >> Yes this is because Meson uses --as-needed. > Maybe worth a patch at

[PATCH] Introduce global piix flag to disable PCI hotplug

2020-08-10 Thread Ani Sinha
We introduce a new global flag for PIIX with which we can turn on or off PCI device hotplug. This flag can be used to prevent all PCI devices from getting hotplugged/unplugged on the PCI bus. The new options disables all hotpluh HW initialization code as well as the ACPI AMLs. Signed-off-by: Ani S

Re: [PATCH] Introduce global piix flag to disable PCI hotplug

2020-08-10 Thread Ani Sinha
This is related to the discussion we had a few weeks ago: https://www.mail-archive.com/qemu-devel@nongnu.org/msg705212.html Igor, could you please comment if this will do. I have not tested it since I do not have a setup handy. Sending this out for a quick review. thanks ani On Mon, Aug 10, 202

Re: [DRAFT PATCH 000/143] Meson integration for 5.2

2020-08-10 Thread Cornelia Huck
On Mon, 10 Aug 2020 13:16:03 +0200 Paolo Bonzini wrote: > On 10/08/20 12:04, Cornelia Huck wrote: > > 'make check' is unhappy, however: > > > > Running test qtest-s390x: device-introspect-test > > missing object type 'virtio-gpu-device' > > Broken pipe > > ../tests/qtest/libqtest.c:175: kill_qem

Re: [PATCH] Simple & stupid coroutine-aware monitor_cur()

2020-08-10 Thread Kevin Wolf
Am 07.08.2020 um 15:27 hat Markus Armbruster geschrieben: > This is just a sketch. It's incomplete, needs comments and a real > commit message. > > Support for "[PATCH v6 09/12] hmp: Add support for coroutine command > handlers" is missing. Marked FIXME. > > As is, it goes on top of Kevin's ser

[PATCH for 5.2 1/1] qemu-io: add -V flag for read sub-command

2020-08-10 Thread Denis V. Lunev
The problem this patch is trying to address is libguestfs behavior on the appliance startup. It starts supporting to use root=UUID definition in the kernel command line of its root filesystem using file -- /usr/lib64/guestfs/appliance/root This works fine with RAW image, but we are using QCOW2

Re: [PATCH for 5.2 1/1] qemu-io: add -V flag for read sub-command

2020-08-10 Thread Richard W.M. Jones
On Mon, Aug 10, 2020 at 03:35:55PM +0300, Denis V. Lunev wrote: > The problem this patch is trying to address is libguestfs behavior on the > appliance startup. It starts supporting to use root=UUID definition in > the kernel command line of its root filesystem using > file -- /usr/lib64/guest

Re: [PATCH v1 01/21] accel/tcg: Change interrupt/exception handling to remove implied BQL

2020-08-10 Thread Robert Foley
On Sat, 8 Aug 2020 at 08:00, Paolo Bonzini wrote: > > We are thinking that 2) would be a good option. > > Yes, it is. The only slight complication is that you'd have both > ->do_interrupt and ->do_interrupt_locked so you probably should add some > consistency check, for example > > /* >

Re: [PATCH for 5.2 1/1] qemu-io: add -V flag for read sub-command

2020-08-10 Thread Denis V. Lunev
On 8/10/20 3:52 PM, Richard W.M. Jones wrote: > On Mon, Aug 10, 2020 at 03:35:55PM +0300, Denis V. Lunev wrote: >> The problem this patch is trying to address is libguestfs behavior on the >> appliance startup. It starts supporting to use root=UUID definition in >> the kernel command line of its ro

Re: [PATCH] Coroutine-aware monitor_cur() with coroutine-specific data

2020-08-10 Thread Kevin Wolf
Am 07.08.2020 um 15:29 hat Markus Armbruster geschrieben: > This is just a sketch. It needs comments and a real commit message. > > As is, it goes on top of Kevin's series. It is meant to be squashed > into PATCH 06. > > Signed-off-by: Markus Armbruster > --- > include/qemu/coroutine.h |

Re: [PATCH for-5.1 v2] acceptance: use stable URLs for the Debian and Ubuntu installer

2020-08-10 Thread Peter Maydell
On Mon, 10 Aug 2020 at 10:29, Paolo Bonzini wrote: > > The kernel and initrd hashes seem to have changed for the Bionic > aarch64 installer, causing BootLinuxConsole.test_aarch64_xlnx_versal_virt > to fail. Correct the paths to use the previous binaries instead of > the latest. Do the same for t

[PULL v2 10/12] hw/display/artist: Unbreak size mismatch memory accesses

2020-08-10 Thread Helge Deller
Commit 5d971f9e6725 ("memory: Revert "memory: accept mismatching sizes in memory_region_access_valid") broke the artist driver in a way that the dtwm window manager on HP-UX rendered wrong. Fixes: 5d971f9e6725 ("memory: Revert "memory: accept mismatching sizes in memory_region_access_valid") Sign

[PULL v2 00/12] target-hppa fixes pull request v2

2020-08-10 Thread Helge Deller
Please pull from https://github.com/hdeller/qemu-hppa.git target-hppa to fix those bugs in target-hppa: * Fix the SeaBIOS-hppa firmware build with gcc-10 on Debian * Fix the SeaBIOS-hppa firmware to boot NetBSD again * Fix many artist framebuffer out-of-bounds accesses as found by Alexander

[PULL v2 12/12] hw/display/artist: Fix invalidation of lines near screen border

2020-08-10 Thread Helge Deller
From: Sven Schnelle If parts of the invalidated screen lines are outside of the VRAM buffer, the code skips the whole invalidate. This is incorrect when only parts of the buffer are invisble - which is the case when the mouse cursor is located near the screen border. Signed-off-by: Sven Schnelle

[PULL v2 08/12] Revert "hw/display/artist: Avoid drawing line when nothing to display"

2020-08-10 Thread Helge Deller
This reverts commit b0f6455feac97e41045ee394e11c24d92c370f6e. It's wrong. A line could even be a dot. Signed-off-by: Helge Deller --- hw/display/artist.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/hw/display/artist.c b/hw/display/artist.c index 47de17b9e9..f37aa9eb49 100644 --- a/hw/d

[PULL v2 07/12] hw/display/artist: Refactor artist_rop8() to avoid buffer over-run

2020-08-10 Thread Helge Deller
From: Philippe Mathieu-Daudé Invalid I/O writes can craft an offset out of the vram_buffer range. Instead of passing an unsafe pointer to artist_rop8(), pass the vram_buffer and the offset. We can now check if the offset is in range before accessing it. We avoid: Program terminated with signa

[PULL v2 11/12] hw/display/artist: Fix invalidation of lines in artist_draw_line()

2020-08-10 Thread Helge Deller
From: Sven Schnelle The old code didn't invalidate correctly when vertical lines were drawn. Fix this and move the invalidation out of the loop. Signed-off-by: Sven Schnelle Signed-off-by: Helge Deller --- hw/display/artist.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --g

[PULL v2 01/12] hw/hppa: Sync hppa_hardware.h file with SeaBIOS sources

2020-08-10 Thread Helge Deller
The hppa_hardware.h file is shared with SeaBIOS. Sync it. Acked-by: Richard Henderson Signed-off-by: Helge Deller --- hw/hppa/hppa_hardware.h | 6 ++ hw/hppa/lasi.c | 2 -- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/hw/hppa/hppa_hardware.h b/hw/hppa/hppa_hardwar

[PULL v2 04/12] hw/display/artist.c: fix out of bounds check

2020-08-10 Thread Helge Deller
From: Sven Schnelle Fix the following runtime warning with artist framebuffer: "write outside bounds: wants 1256x1023, max size 1280x1024" Reviewed-by: Richard Henderson Signed-off-by: Sven Schnelle Signed-off-by: Helge Deller --- hw/display/artist.c | 24 +++- 1 file cha

[PULL v2 06/12] hw/display/artist: Check offset in draw_line to avoid buffer over-run

2020-08-10 Thread Helge Deller
From: Philippe Mathieu-Daudé Invalid I/O writes can craft an offset out of the vram_buffer range. We avoid: Program terminated with signal SIGSEGV, Segmentation fault. 284 *dst &= ~plane_mask; (gdb) bt #0 0x55d5dccdc5c0 in artist_rop8 (s=0x55d5defee510, dst=0x7f8e84ed82

[PULL v2 09/12] hw/display/artist: Prevent out of VRAM buffer accesses

2020-08-10 Thread Helge Deller
Simplify various bounds checks by changing parameters like row and column numbers to become unsigned instead of signed. With that we can check if the calculated offset is bigger than the size of the VRAM region and bail out if not. Reported-by: LLVM libFuzzer Reported-by: Alexander Bulekov Buglin

Re: QEMU Library support

2020-08-10 Thread Pratik Parvati
Just to hide the core QEMU implementation from the device code. QEMU core source code remains the same for all device; So, was thinking a way of hiding it from the rest of the device code. Regards, Pratik On Mon, Aug 10, 2020 at 3:50 PM Alex Bennée wrote: > > Pratik Parvati writes: > > > As a

Re: [PATCH for-5.2 14/19] ftgmac100: Fix integer overflow in ftgmac100_do_tx()

2020-08-10 Thread Mauro Matteo Cascella
On Thu, Aug 6, 2020 at 3:21 PM Cédric Le Goater wrote: > > When inserting the VLAN tag in packets, memmove() can generate an > integer overflow for packets whose length is less than 12 bytes. > > Check length against the size of the ethernet header (14 bytes) to > avoid the crash and return FTGMAC

[PULL v2 05/12] hw/hppa/lasi: Don't abort on invalid IMR value

2020-08-10 Thread Helge Deller
NetBSD initializes the LASI IMR value with 0x to disable all LASI interrupts. This triggered an assert() and stopped the emulation. By replacing the check with a warning in the guest log we now allow NetBSD to boot again. Signed-off-by: Helge Deller --- hw/hppa/lasi.c | 7 +-- 1 fil

[PULL v2 03/12] hw/hppa: Implement proper SeaBIOS version check

2020-08-10 Thread Helge Deller
It's important that the SeaBIOS hppa firmware is at least at a minimal level to ensure proper interaction between qemu and firmware. Implement a proper firmware version check by telling SeaBIOS via the fw_cfg interface which minimal SeaBIOS version is required by this running qemu instance. If the

Re: [PATCH for 5.2 1/1] qemu-io: add -V flag for read sub-command

2020-08-10 Thread Vladimir Sementsov-Ogievskiy
10.08.2020 15:35, Denis V. Lunev wrote: The problem this patch is trying to address is libguestfs behavior on the appliance startup. It starts supporting to use root=UUID definition in the kernel command line of its root filesystem using file -- /usr/lib64/guestfs/appliance/root This works

Re: [PATCH for 5.2 1/1] qemu-io: add -V flag for read sub-command

2020-08-10 Thread Eric Blake
On 8/10/20 7:35 AM, Denis V. Lunev wrote: The problem this patch is trying to address is libguestfs behavior on the appliance startup. It starts supporting to use root=UUID definition in the kernel command line of its root filesystem using file -- /usr/lib64/guestfs/appliance/root This work

Re: [PATCH v8 1/4] hw/net/can: Introduce Xilinx ZynqMP CAN controller

2020-08-10 Thread Edgar E. Iglesias
On Tue, Aug 04, 2020 at 02:11:42PM -0700, Vikram Garhwal wrote: > The Xilinx ZynqMP CAN controller is developed based on SocketCAN, QEMU CAN bus > implementation. Bus connection and socketCAN connection for each CAN module > can be set through command lines. > > Example for using single CAN: >

Re: [PATCH v8 2/4] xlnx-zynqmp: Connect Xilinx ZynqMP CAN controllers

2020-08-10 Thread Edgar E. Iglesias
On Tue, Aug 04, 2020 at 02:11:43PM -0700, Vikram Garhwal wrote: > Connect CAN0 and CAN1 on the ZynqMP. Reviewed-by: Edgar E. Iglesias > > Signed-off-by: Vikram Garhwal > --- > hw/arm/xlnx-zcu102.c | 20 > hw/arm/xlnx-zynqmp.c | 34

Re: [PATCH for 5.2 1/1] qemu-io: add -V flag for read sub-command

2020-08-10 Thread Kevin Wolf
Am 10.08.2020 um 16:02 hat Vladimir Sementsov-Ogievskiy geschrieben: > 10.08.2020 15:35, Denis V. Lunev wrote: > > The problem this patch is trying to address is libguestfs behavior on the > > appliance startup. It starts supporting to use root=UUID definition in > > the kernel command line of its

Re: [PATCH for 5.2 1/1] qemu-io: add -V flag for read sub-command

2020-08-10 Thread Denis V. Lunev
On 8/10/20 5:40 PM, Kevin Wolf wrote: > Am 10.08.2020 um 16:02 hat Vladimir Sementsov-Ogievskiy geschrieben: >> 10.08.2020 15:35, Denis V. Lunev wrote: >>> The problem this patch is trying to address is libguestfs behavior on the >>> appliance startup. It starts supporting to use root=UUID definiti

Re: Any reason VIRTQUEUE_MAX_SIZE is 1024? Can we increase this limit?

2020-08-10 Thread Michael S. Tsirkin
On Thu, Aug 06, 2020 at 01:37:08PM +0100, Stefan Hajnoczi wrote: > On Wed, Aug 05, 2020 at 08:13:29AM -0400, Michael S. Tsirkin wrote: > > On Wed, Aug 05, 2020 at 01:11:07PM +0100, Stefan Hajnoczi wrote: > > > On Thu, Jul 30, 2020 at 07:46:09AM +, Yajun Wu wrote: > > > > I'm doing iperf test on

Re: [PATCH] Introduce global piix flag to disable PCI hotplug

2020-08-10 Thread Michael S. Tsirkin
On Mon, Aug 10, 2020 at 04:59:41PM +0530, Ani Sinha wrote: > We introduce a new global flag for PIIX with which we can > turn on or off PCI device hotplug. This flag can be used > to prevent all PCI devices from getting hotplugged/unplugged > on the PCI bus. The new options disables all hotpluh HW

[PATCH v1 1/2] util: introduce aio_context_acquire_timeout

2020-08-10 Thread Zhenyu Ye
Currently we only have the aio_context_acquire() to take the ownership of the AioContext. If the mutex is locked by other threads, this function will wait util the mutex is released. Sometimes we may want to get some return values after waiting for some time. So introduce aio_context_acquire_tim

[PATCH v1 2/2] qmp: use aio_context_acquire_timeout replace aio_context_acquire

2020-08-10 Thread Zhenyu Ye
Before doing qmp actions, we need to lock the qemu_global_mutex, so the qmp actions should not take too long time. Unfortunately, some qmp actions need to acquire aio context and this may take a long time. So replace aio_context_acquire() by aio_context_acquire_timeout() and return ETIMEDOUT if t

[PATCH v1 0/2] Add timeout mechanism to qmp actions

2020-08-10 Thread Zhenyu Ye
Before doing qmp actions, we need to lock the qemu_global_mutex, so the qmp actions should not take too long time. Unfortunately, some qmp actions need to acquire aio context and this may take a long time. The vm will soft lockup if this time is too long. So add a timeout mechanism while doing q

Re: [PATCH] Introduce global piix flag to disable PCI hotplug

2020-08-10 Thread Ani Sinha
On Mon, Aug 10, 2020 at 8:17 PM Michael S. Tsirkin wrote: > On Mon, Aug 10, 2020 at 04:59:41PM +0530, Ani Sinha wrote: > > We introduce a new global flag for PIIX with which we can > > turn on or off PCI device hotplug. This flag can be used > > to prevent all PCI devices from getting hotplugged/

Re: [PATCH] Introduce global piix flag to disable PCI hotplug

2020-08-10 Thread Michael S. Tsirkin
On Mon, Aug 10, 2020 at 08:24:53PM +0530, Ani Sinha wrote: > > > On Mon, Aug 10, 2020 at 8:17 PM Michael S. Tsirkin wrote: > > On Mon, Aug 10, 2020 at 04:59:41PM +0530, Ani Sinha wrote: > > We introduce a new global flag for PIIX with which we can > > turn on or off PCI device hotpl

Re: [PATCH-for-5.1? 1/4] hw/arm/xilinx_zynq: Uninline cadence_uart_create()

2020-08-10 Thread Alistair Francis
On Mon, Aug 3, 2020 at 3:57 AM Philippe Mathieu-Daudé wrote: > > As we want to call qdev_connect_clock_in() before the device > is realized, we need to uninline cadence_uart_create() first. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > include/hw/ch

Re: [PATCH] Introduce global piix flag to disable PCI hotplug

2020-08-10 Thread Ani Sinha
Ani On Aug 10, 2020, 20:30 +0530, Michael S. Tsirkin , wrote: > On Mon, Aug 10, 2020 at 08:24:53PM +0530, Ani Sinha wrote: > > > > > > On Mon, Aug 10, 2020 at 8:17 PM Michael S. Tsirkin wrote: > > > > On Mon, Aug 10, 2020 at 04:59:41PM +0530, Ani Sinha wrote: > > > We introduce a new global flag

Re: [PATCH-for-5.1? 2/4] hw/arm/xilinx_zynq: Call qdev_connect_clock_in() before DeviceRealize

2020-08-10 Thread Alistair Francis
On Mon, Aug 3, 2020 at 3:57 AM Philippe Mathieu-Daudé wrote: > > Clock canonical name is set in device_set_realized (see the block > added to hw/core/qdev.c in commit 0e6934f264). > If we connect a clock after the device is realized, this code is > not executed. This is currently not a problem as

Re: [PATCH for 5.2 1/1] qemu-io: add -V flag for read sub-command

2020-08-10 Thread Vladimir Sementsov-Ogievskiy
10.08.2020 17:20, Eric Blake wrote: On 8/10/20 7:35 AM, Denis V. Lunev wrote: The problem this patch is trying to address is libguestfs behavior on the appliance startup. It starts supporting to use root=UUID definition in the kernel command line of its root filesystem using file --  /usr/l

Re: [PATCH-for-5.1? 4/4] hw/qdev-clock: Avoid calling qdev_connect_clock_in after DeviceRealize

2020-08-10 Thread Alistair Francis
On Mon, Aug 3, 2020 at 3:59 AM Philippe Mathieu-Daudé wrote: > > Clock canonical name is set in device_set_realized (see the block > added to hw/core/qdev.c in commit 0e6934f264). > If we connect a clock after the device is realized, this code is > not executed. This is currently not a problem as

Re: [PATCH-for-5.1? 3/4] hw/qdev-clock: Uninline qdev_connect_clock_in()

2020-08-10 Thread Alistair Francis
On Mon, Aug 3, 2020 at 3:57 AM Philippe Mathieu-Daudé wrote: > > We want to assert the device is not realized. To avoid overloading > this header including "hw/qdev-core.h", uninline the function first. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- >

Re: [PATCH for-5.1 v2 2/2] iotests: add test for unaligned granularity bitmap backup

2020-08-10 Thread Max Reitz
(Note: When submitting a patch series with multiple patches, our guidelines require a cover letter: https://wiki.qemu.org/Contribute/SubmitAPatch#Include_a_meaningful_cover_letter But not too important now.) On 10.08.20 11:55, Stefan Reiter wrote: > Start a VM with a 4097 byte image attached, add

Re: [PATCH for-5.1 v2 1/2] block/block-copy: always align copied region to cluster size

2020-08-10 Thread Max Reitz
On 10.08.20 11:55, Stefan Reiter wrote: > Since commit 42ac214406e0 (block/block-copy: refactor task creation) > block_copy_task_create calculates the area to be copied via > bdrv_dirty_bitmap_next_dirty_area, but that can return an unaligned byte > count if the image's last cluster end is not alig

Re: [PULL v2 00/12] target-hppa fixes pull request v2

2020-08-10 Thread Peter Maydell
On Mon, 10 Aug 2020 at 14:24, Helge Deller wrote: > > Please pull from > https://github.com/hdeller/qemu-hppa.git target-hppa > to fix those bugs in target-hppa: > > * Fix the SeaBIOS-hppa firmware build with gcc-10 on Debian > > * Fix the SeaBIOS-hppa firmware to boot NetBSD again > > * Fix m

Re: [PATCH] Introduce global piix flag to disable PCI hotplug

2020-08-10 Thread Michael S. Tsirkin
On Mon, Aug 10, 2020 at 08:35:56PM +0530, Ani Sinha wrote: > > Ani > On Aug 10, 2020, 20:30 +0530, Michael S. Tsirkin , wrote: > > On Mon, Aug 10, 2020 at 08:24:53PM +0530, Ani Sinha wrote: > > > > > > On Mon, Aug 10, 2020 at 8:17 PM Michael S. Tsirkin > wrote: > > >

[Bug 1594394] Re: Using setreuid / setegid crashes x86_64 user-mode target

2020-08-10 Thread Steve Dodd
OK, messing around with https://hub.docker.com/r/multiarch/ubuntu-core for quick testing, it looks like modern versions of qemu do not have this bug - I used the test case from Bug #1815911 (which I think is probably a duplicate) and cannot reproduce with: REPOSITORYTAG

  1   2   3   4   >