Re: [PATCH v5 0/2] add new options to set smbios type 4 fields

On 8/6/2020 2:01 PM, Michael S. Tsirkin wrote: On Thu, Aug 06, 2020 at 11:56:32AM +0800, Ying Fang wrote: From: fangying Hi, this patchset was previously posted by my teamate Heyi Guo several months ago, however we missed the merge window. It is reposted here to make it an end. Thanks. T

Re: [PATCH v2 1/7] target/riscv: Generate nanboxed results from fp helpers

On 2020/8/6 14:09, Chih-Min Chao wrote: On Fri, Jul 24, 2020 at 2:06 PM LIU Zhiwei > wrote: On 2020/7/24 11:55, Richard Henderson wrote: > On 7/23/20 7:35 PM, LIU Zhiwei wrote: >> >> On 2020/7/24 8:28, Richard Henderson wrote: >>> Make sure th

Re: [PATCH] block/vhdx: Support vhdx image only with 512 bytes logical sector size

On 8/5/20 11:30 PM, Swapnil Ingle wrote: > block/vhdx uses qemu block layer where sector size is always 512 byte. "bytes". > This may have issues with 4K logical sector sized vhdx image. > > For e.g qemu-img convert on such images fails with following assert: > > $qemu-img convert -f vhdx -O r

Re: [PATCH] target/arm: Delete unused ARM_FEATURE_CRC

On 8/5/20 11:08 PM, Peter Maydell wrote: > In commit 962fcbf2efe57231a9f5df we converted the uses of the > ARM_FEATURE_CRC bit to use the aa32_crc32 isar_feature test > instead. However we forgot to remove the now-unused definition > of the feature name in the enum. Delete it now. > > Signed-off-b

Re: [PATCH v2 1/3] async: rename event_notifier_dummy_cb/poll()

On 8/5/20 12:00 PM, Stefan Hajnoczi wrote: > The event_notifier_*() prefix can be confused with the EventNotifier > APIs that are also called event_notifier_*(). > > Rename the functions to aio_context_notifier_*() to make it clear that > they relate to the AioContext::notifier field. > > Signed-

Re: [for-5.2 v4 10/10] s390: Recognize host-trust-limitation option

On 06.08.20 08:14, David Gibson wrote: > On Mon, Jul 27, 2020 at 05:50:40PM +0200, Cornelia Huck wrote: >> On Fri, 24 Jul 2020 12:57:44 +1000 >> David Gibson wrote: >> >>> At least some s390 cpu models support "Protected Virtualization" (PV), >>> a mechanism to protect guests from eavesdropping by

Re: [RFC PATCH 1/8] migration/dirtyrate: Add get_dirtyrate_thread() function

On 2020/8/5 0:23, Dr. David Alan Gilbert wrote: > * Chuan Zheng (zhengch...@huawei.com) wrote: >> From: Zheng Chuan >> >> Add get_dirtyrate_thread() functions >> >> Signed-off-by: Zheng Chuan >> Signed-off-by: YanYing Zhang >> --- >> migration/dirtyrate.c | 63 >> +++

Re: [RFC PATCH 0/8] *** A Method for evaluating dirty page rate ***

On 2020/8/5 0:19, Dr. David Alan Gilbert wrote: > * Chuan Zheng (zhengch...@huawei.com) wrote: >> From: Zheng Chuan > > Hi, > >> Sometimes it is neccessary to evaluate dirty page rate before migration. >> Users could decide whether to proceed migration based on the evaluation >> in case of vm

Re: [RFC PATCH 2/8] migration/dirtyrate: Add block_dirty_info to store dirtypage info

On 2020/8/5 0:28, Dr. David Alan Gilbert wrote: > * Chuan Zheng (zhengch...@huawei.com) wrote: >> From: Zheng Chuan >> >> Add block_dirty_info to store dirtypage info for each ramblock >> >> Signed-off-by: Zheng Chuan >> Signed-off-by: YanYing Zhang >> --- >> migration/dirtyrate.h | 13 +

Re: [RFC PATCH 4/8] migration/dirtyrate: Record hash results for each ramblock

On 2020/8/5 1:00, Dr. David Alan Gilbert wrote: > * Chuan Zheng (zhengch...@huawei.com) wrote: >> From: Zheng Chuan >> >> Record hash results for each ramblock. > > Please be careful when talking about 'ramblock' since we already use > that for a chunk of memory in QEMU. > >> Signed-off-by: Z

Re: [RFC PATCH 8/8] migration/dirtyrate: Implement qmp_cal_dirty_rate()/qmp_get_dirty_rate() function

On 2020/8/5 0:28, Eric Blake wrote: > On 7/24/20 10:11 PM, Chuan Zheng wrote: >> From: Zheng Chuan >> >> Implement qmp_cal_dirty_rate()/qmp_get_dirty_rate() function which could be >> called >> by libvirt api. >> >> Signed-off-by: Zheng Chuan >> Signed-off-by: YanYing Zhang >> --- > >> +++

[PATCH 2/2] migration: add vsock as data channel support

The vsock channel is more widely use in some new features, for example, the Nitro/Enclave. It can also be used as the migration channel. Signed-off-by: Longpeng(Mike) --- migration/migration.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/migration/migration.c b/migra

[PATCH 1/2] migration: unify the framework of socket-type channel

Currently, the only difference of tcp channel and unix channel in migration/socket.c is the way to build SocketAddress, but socket_parse() can handle these two types, so use it to instead of tcp_build_address() and unix_build_address(). The socket-type channel can be further unified based on the u

[PATCH 0/2] migration: add vsock channel support

Longpeng (Mike) (2): migration: unify the framework of socket-type channel migration: add vsock as data channel support migration/migration.c | 20 +++--- migration/socket.c| 72 +++ migration/socket.h| 11 +++- 3 files chang

[Bug 1890545] [NEW] (ARM64) qemu-x86_64+schroot(Debian bullseye) can't run chrome and can't load HTML

Public bug reported: First I creat a file system that is debian(bullseye amd64)on arm64 machine，then I download google-chrome，however, when I ran Google browser, some errors occurred. $ google-chrome --no-sandbox or $ qemu-x86_64-static google-chrome --no-sandbox qemu: uncaught target signal 5

[PATCH-for-5.2 0/7] hw/block/fdc: Cleanups trying to make sense of the floppy controllers

Trivial patches while trying to make sense of the floppy controllers code. Philippe Mathieu-Daudé (7): hw/block/fdc: Let sector count be unsigned hw/block/fdc: Let sector offset be unsigned hw/block/fdc: Use warn_report() instead of debug FLOPPY_DPRINTF() calls hw/block/fdc: Convert de

[PATCH-for-5.2 1/7] hw/block/fdc: Let sector count be unsigned

Sectors count can not be negative, make it unsigned. Signed-off-by: Philippe Mathieu-Daudé --- hw/block/fdc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/block/fdc.c b/hw/block/fdc.c index e9ed3eef45..2cec7568c1 100644 --- a/hw/block/fdc.c +++ b/hw/block/fdc.c @@

[PATCH-for-5.2 5/7] hw/block/fdc: Drop pointless FLOPPY_DPRINTF() call

Remove not very helpful debug call. Signed-off-by: Philippe Mathieu-Daudé --- hw/block/fdc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/block/fdc.c b/hw/block/fdc.c index f9f3f3c079..278220ed29 100644 --- a/hw/block/fdc.c +++ b/hw/block/fdc.c @@ -2636,7 +2636,6 @@ static void fdctrl_r

[PATCH-for-5.2 2/7] hw/block/fdc: Let sector offset be unsigned

Sector offset can not be negative, make it unsigned. Signed-off-by: Philippe Mathieu-Daudé --- hw/block/fdc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/block/fdc.c b/hw/block/fdc.c index 2cec7568c1..c91ed7ee2d 100644 --- a/hw/block/fdc.c +++ b/hw/block/fdc.c @@ -259,

[PATCH-for-5.2 3/7] hw/block/fdc: Use warn_report() instead of debug FLOPPY_DPRINTF() calls

Use warn_report() instead of debug FLOPPY_DPRINTF() calls. Signed-off-by: Philippe Mathieu-Daudé --- hw/block/fdc.c | 32 +++- 1 file changed, 15 insertions(+), 17 deletions(-) diff --git a/hw/block/fdc.c b/hw/block/fdc.c index c91ed7ee2d..ee45ec0b27 100644 --- a/hw/

[PATCH-for-5.2 7/7] hw/block/fdc: Add ASCII art schema of QOM relations

Without knowing the QEMU history, it is hard to relate QEMU objects with the hardware datasheet. For example, one naively expects: * a floppy disk is plugged / unplugged on the bus Wrong! QEMU floppy disks always sit on the bus. The block drives are plugged / unplugged on the disks, and the

[PATCH-for-5.2 4/7] hw/block/fdc: Convert debug FLOPPY_DPRINTF() to trace events

Convert debug FLOPPY_DPRINTF() to trace events. Signed-off-by: Philippe Mathieu-Daudé --- hw/block/fdc.c| 6 +++--- hw/block/trace-events | 3 +++ 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/hw/block/fdc.c b/hw/block/fdc.c index ee45ec0b27..f9f3f3c079 100644 --- a/hw/b

[PATCH 0/3] A few doc fixes

If we need -rc4 for some other reason, throwing these in would be nice. Markus Armbruster (3): docs/interop/qmp-spec: Point to the QEMU QMP reference manual qapi: Document event VSERPORT_CHANGE is rate-limited docs/qdev-device-use: Don't suggest -drive and -net can do USB docs/interop/qmp-

[PATCH 2/3] qapi: Document event VSERPORT_CHANGE is rate-limited

Commit e2ae6159de "virtio-serial: report frontend connection state via monitor" neglected to document the new event is rate-limited. Fix that. Cc: Marc-André Lureau Cc: Eric Blake Signed-off-by: Markus Armbruster --- qapi/char.json | 2 ++ 1 file changed, 2 insertions(+) diff --git a/qapi/ch

[PATCH 1/3] docs/interop/qmp-spec: Point to the QEMU QMP reference manual

Commit 4d8bb958fa0..231aaf3a821 integrated the contents of docs/qmp-events.txt into QAPI schema doc comments. It left dangling references to qmp-events.txt behind. Fix to point to the QEMU QMP reference manual generated from the QAPI schema. Add a similar reference for commands. Cc: Marc-André

[PATCH-for-5.2 6/7] hw/block/fdc: Use more descriptive TypeInfo names

Better name TypeInfo structures: - ISA bus - Common floppy controller - Intel 82078 floppy controller - SUN floppy controller Signed-off-by: Philippe Mathieu-Daudé --- hw/block/fdc.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/hw/block/fdc.c b/hw/bloc

[PATCH 3/3] docs/qdev-device-use: Don't suggest -drive and -net can do USB

Commit 480324ec8d "docs/qdev-device-use: Clean up the sentences related to -usbdevice" deleted the information on syntax that no longer works. Unfortunately, the resulting text suggests you can configure USB block devices with -drive, and USB network devices with -net, which is misleading. Instea

Re: [PATCH] docs/qdev-device-use: Clean up the sentences related to -usbdevice

My review came too late, so I turned it into a followup patch: Subject: [PATCH 3/3] docs/qdev-device-use: Don't suggest -drive and -net can do USB Message-Id: <20200806081147.3123652-4-arm...@redhat.com>

Re: [RFC PATCH 2/5] hw/misc/led: Add LED_STATUS_CHANGED QAPI event

Markus Armbruster writes: > Philippe Mathieu-Daudé writes: [...] >> Commits f544d174dfc and 7f1e7b23d5 refers to the qmp-events.txt >> for documentation on rate-limiting QMP events, but I can't find >> it in the codebase. Two files matches 'qmp-events' but don't have >> documentation: qapi/qmp-e

RE: [Virtio-fs] [PATCH] virtiofsd: Disable remote posix locks by default

> Right now we enable remote posix locks by default. That means when guest does > a posix lock it sends request to server > (virtiofsd). But currently we only support non-blocking posix lock and return > -EOPNOTSUPP for blocking version. > > This means that existing applications which are doing

Re: [PATCH] ide: Get rid of IDEDrive struct

On Thu, Aug 06, 2020 at 07:58:06AM +0200, Markus Armbruster wrote: > Eduardo Habkost writes: > > > On Wed, Aug 05, 2020 at 09:41:25PM +0100, Peter Maydell wrote: > >> On Wed, 5 Aug 2020 at 20:49, Eduardo Habkost wrote: > >> > > >> > The struct had a single field (IDEDevice dev), and is only used

Re: [PATCH v2 1/7] target/riscv: Generate nanboxed results from fp helpers

On Thu, Aug 6, 2020 at 3:05 PM LIU Zhiwei wrote: > > > On 2020/8/6 14:09, Chih-Min Chao wrote: > > On Fri, Jul 24, 2020 at 2:06 PM LIU Zhiwei wrote: > >> >> >> On 2020/7/24 11:55, Richard Henderson wrote: >> > On 7/23/20 7:35 PM, LIU Zhiwei wrote: >> >> >> >> On 2020/7/24 8:28, Richard Henderson

Re: [PATCH 2/3] qapi: Document event VSERPORT_CHANGE is rate-limited

Hi On Thu, Aug 6, 2020 at 12:13 PM Markus Armbruster wrote: > Commit e2ae6159de "virtio-serial: report frontend connection state via > monitor" neglected to document the new event is rate-limited. Fix > that. > > Cc: Marc-André Lureau > Cc: Eric Blake > Signed-off-by: Markus Armbruster > ---

Re: [PATCH 1/3] docs/interop/qmp-spec: Point to the QEMU QMP reference manual

On Thu, Aug 6, 2020 at 12:12 PM Markus Armbruster wrote: > Commit 4d8bb958fa0..231aaf3a821 integrated the contents of > docs/qmp-events.txt into QAPI schema doc comments. It left dangling > references to qmp-events.txt behind. Fix to point to the QEMU QMP > reference manual generated from the Q

Re: [PATCH-for-5.2 7/7] hw/block/fdc: Add ASCII art schema of QOM relations

Am 06.08.2020 um 10:08 hat Philippe Mathieu-Daudé geschrieben: > Without knowing the QEMU history, it is hard to relate QEMU objects > with the hardware datasheet. > > For example, one naively expects: > > * a floppy disk is plugged / unplugged on the bus > > Wrong! QEMU floppy disks always s

Re: [PATCH] ide: Get rid of IDEDrive struct

On Wed, 5 Aug 2020 at 23:14, Eduardo Habkost wrote: > On Wed, Aug 05, 2020 at 09:41:25PM +0100, Peter Maydell wrote: > > This is one of those areas where this change works and reduces > > amount of code, but on the other hand it means the QOM type > > doesn't follow the common pattern for a leaf t

Re: vhost-user protocol feature negotiation

"Michael S. Tsirkin" writes: > On Wed, Aug 05, 2020 at 03:13:06PM +, Alyssa Ross wrote: >> Quoting from the definition of VHOST_USER_SET_PROTOCOL_FEATURES in >> vhost-user.rst: >> >> > Only legal if feature bit ``VHOST_USER_F_PROTOCOL_FEATURES`` is present >> > in >> > ``VHOST_USER_GET_

Re: [PATCH] qcow2: flush qcow2 l2 meta for new allocated clusters

On 8/5/2020 10:43 AM, no-re...@patchew.org wrote: Patchew URL: https://patchew.org/QEMU/20200805023826.184-1-fangyi...@huawei.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can pro

Re: [PATCH] qcow2: flush qcow2 l2 meta for new allocated clusters

On Thu, Aug 06, 2020 at 05:01:51PM +0800, Ying Fang wrote: > > > On 8/5/2020 10:43 AM, no-re...@patchew.org wrote: > > Patchew URL: > > https://patchew.org/QEMU/20200805023826.184-1-fangyi...@huawei.com/ > > > > > > > > Hi, > > > > This series failed the docker-quick@centos7 build test. Plea

[PATCH 0/1] qga: add command guest-get-disk

Adds command to list root disks of the VM. The patch does compile on master but to work properly it requires changes to qemu-ga by Thomas Huth in series: Allow guest-get-fsinfo also for non-PCI devices. Tomáš Golembiovský (1): qga: add command guest-get-disks qga/commands-posix.c | 91 +++

[PATCH 1/1] qga: add command guest-get-disks

The command guest-get-fsinfo can be used to list information about disks and partitions but it is limited only to mounted disks with filesystem. This new command allows listing information about attached root disks of the VM. This is usefull for management applications for mapping virtualized devic

Re: [PATCH v1 17/21] target/s390x: add BQL to do_interrupt and cpu_exec_interrupt

On Wed, 5 Aug 2020 14:12:59 -0400 Robert Foley wrote: > This is part of a series of changes to remove the implied BQL > from the common code of cpu_handle_interrupt and > cpu_handle_exception. As part of removing the implied BQL > from the common code, we are pushing the BQL holding > down into

Re: [PATCH v12 09/11] qcow2_format.py: collect fields to dump in JSON format

On 05.08.2020 19:58, Vladimir Sementsov-Ogievskiy wrote: 30.07.2020 17:15, Andrey Shinkevich wrote: As __dict__ is being extended with class members we do not want to print, add the to_dict() method to classes that returns a dictionary with desired fields and their values. Extend it in subclass

Re: [PATCH] qcow2: flush qcow2 l2 meta for new allocated clusters

Am 05.08.2020 um 04:38 hat Ying Fang geschrieben: > From: fangying > > When qemu or qemu-nbd process uses a qcow2 image and configured with > 'cache = none', it will write to the qcow2 image with a cache to cache > L2 tables, however the process will not use L2 tables without explicitly > calling

Re: [PATCH v1 17/21] target/s390x: add BQL to do_interrupt and cpu_exec_interrupt

On 06/08/20 10:59, Cornelia Huck wrote: >> bool stopped = false; >> - >> +bool bql = !qemu_mutex_iothread_locked(); >> +if (bql) { >> +qemu_mutex_lock_iothread(); >> +} > I'm not sure I like that conditional locking. Can we instead create > __s390_cpu_do_interrupt() or so,

Re: [PATCH v3 0/8] Generalize start-powered-off property from ARM

On Thu, 6 Aug 2020 at 06:53, David Gibson wrote: > > On Wed, Aug 05, 2020 at 08:04:11PM +0100, Peter Maydell wrote: > > On Wed, 5 Aug 2020 at 18:01, Thiago Jung Bauermann > > wrote: > > > Any news on this? Is there something I should be doing? I saw -rc3 today > > > but not these patches. > > > >

Re: [PATCH v12 09/11] qcow2_format.py: collect fields to dump in JSON format

06.08.2020 12:08, Andrey Shinkevich wrote: On 05.08.2020 19:58, Vladimir Sementsov-Ogievskiy wrote: 30.07.2020 17:15, Andrey Shinkevich wrote: As __dict__ is being extended with class members we do not want to print, add the to_dict() method to classes that returns a dictionary with desired fie

Re: [PATCH v1 01/21] accel/tcg: Change interrupt/exception handling to remove implied BQL

On 05/08/20 21:18, Richard Henderson wrote: > On 8/5/20 11:12 AM, Robert Foley wrote: >> This change removes the implied BQL from the cpu_handle_interrupt, >> and cpu_handle_exception paths. This BQL acquire is being pushed >> down into the per arch implementation. >> >> Signed-off-by: Robert Foley

Re: [PATCH for-5.2 3/5] ppc/xive: Introduce dedicated kvm_irqchip_in_kernel() wrappers

On Thu, 6 Aug 2020 15:08:35 +1000 David Gibson wrote: > On Wed, Aug 05, 2020 at 07:35:37PM +0200, Greg Kurz wrote: > > Calls to the KVM XIVE device are guarded by kvm_irqchip_in_kernel(). This > > ensures that QEMU won't try to use the device if KVM is disabled or if > > an in-kernel irqchip isn'

[PATCH 3/5] log: Add more details to virtio_report in virtqueue_pop

Add virtio device name and virtqueue info to virtio_report in virtqueue_pop so that we can find out which device's virtqueue is broken. Signed-off-by: Peng Liang --- hw/virtio/virtio.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c

[PATCH 0/5] log: Add logs for some modules

This path serial add some logs for some modeuls to make it easier to debug. Peng Liang (5): log: Add logs for vm start and destroy log: Add log for each modules log: Add more details to virtio_report in virtqueue_pop log: Add log at boot & cpu init for aarch64 log: Add logs during qemu s

[PATCH 4/5] log: Add log at boot & cpu init for aarch64

Add log at boot & cpu init for aarch64. Signed-off-by: Peng Liang --- hw/arm/boot.c | 2 ++ hw/arm/virt.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/hw/arm/boot.c b/hw/arm/boot.c index 3e9816af80..a2d5787807 100644 --- a/hw/arm/boot.c +++ b/hw/arm/boot.c @@ -1292,6 +1292,8 @@ void ar

[PATCH 1/5] log: Add logs for vm start and destroy

Add logs for vm start and destroy. Signed-off-by: Peng Liang --- hw/acpi/core.c | 3 +++ hw/core/reset.c | 2 ++ softmmu/vl.c| 8 3 files changed, 13 insertions(+) diff --git a/hw/acpi/core.c b/hw/acpi/core.c index ac06db3450..0a24f018cf 100644 --- a/hw/acpi/core.c +++ b/hw/acpi/c

Re: [PATCH v8 4/7] 9pfs: add new function v9fs_co_readdir_many()

On Donnerstag, 30. Juli 2020 12:08:33 CEST Christian Schoenebeck wrote: > > @@ -52,6 +56,167 @@ int coroutine_fn v9fs_co_readdir(V9fsPDU *pdu, > > V9fsFidState *fidp, return err; > > > > } > > > > +/* > > + * This is solely executed on a background IO thread. > > + * > > + * See v9fs_co_readdir_

[PATCH 2/5] log: Add log for each modules

Add log for each modules. Signed-off-by: Peng Liang --- accel/kvm/kvm-all.c | 5 - hw/pci/pci.c| 1 + hw/usb/host-libusb.c| 5 + hw/virtio/virtio-pci.c | 2 ++ hw/virtio/virtio-scsi-pci.c | 3 +++ hw/virtio/virtio.c | 13 +++-- m

[PATCH 5/5] log: Add logs during qemu start

Add logs during qemu start. Signed-off-by: Peng Liang --- blockdev.c | 2 ++ softmmu/vl.c | 2 ++ util/oslib-posix.c | 3 +-- 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/blockdev.c b/blockdev.c index 3848a9c8ab..8e3ab8a9b2 100644 --- a/blockdev.c +++ b/blockdev.c

Re: vhost-user protocol feature negotiation

On Thu, Aug 06, 2020 at 08:59:09AM +, Alyssa Ross wrote: > "Michael S. Tsirkin" writes: > > > On Wed, Aug 05, 2020 at 03:13:06PM +, Alyssa Ross wrote: > >> Quoting from the definition of VHOST_USER_SET_PROTOCOL_FEATURES in > >> vhost-user.rst: > >> > >> > Only legal if feature bit ``VH

Re: [PATCH 0/5] log: Add logs for some modules

On Thu, Aug 06, 2020 at 05:37:15PM +0800, Peng Liang wrote: > This path serial add some logs for some modeuls to make it easier to debug. I appreciate the sentiment, but the use of 'info_report' means this debug info is unconditionally printed to stderr. I'm not convinced users in general will be

Re: [PATCH v2 1/7] target/riscv: Generate nanboxed results from fp helpers

On 2020/8/6 16:42, Chih-Min Chao wrote: On Thu, Aug 6, 2020 at 3:05 PM LIU Zhiwei > wrote: On 2020/8/6 14:09, Chih-Min Chao wrote: On Fri, Jul 24, 2020 at 2:06 PM LIU Zhiwei mailto:zhiwei_...@c-sky.com>> wrote: On 2020/7/24 11:55, Richard

Re: [PATCH v1 17/21] target/s390x: add BQL to do_interrupt and cpu_exec_interrupt

Paolo Bonzini writes: > On 06/08/20 10:59, Cornelia Huck wrote: >>> bool stopped = false; >>> - >>> +bool bql = !qemu_mutex_iothread_locked(); >>> +if (bql) { >>> +qemu_mutex_lock_iothread(); >>> +} >> I'm not sure I like that conditional locking. Can we instead create

Re: [PATCH 1/5] log: Add logs for vm start and destroy

On 06/08/2020 11.37, Peng Liang wrote: > Add logs for vm start and destroy. > > Signed-off-by: Peng Liang > --- > hw/acpi/core.c | 3 +++ > hw/core/reset.c | 2 ++ > softmmu/vl.c| 8 > 3 files changed, 13 insertions(+) > > diff --git a/hw/acpi/core.c b/hw/acpi/core.c > index ac06d

Qemu web site down?

Hi Stefan, The link from https://wiki.qemu.org/Documentation pointing to https://qemu.weilnetz.de/doc/qemu-doc.html seems to be dead. Is the problem on your web site, or should the wiki be updated? Thanks Christophe

Re: [PATCH V1 30/32] vfio-pci: save and restore

Hi Steve, On Thu, Jul 30, 2020 at 08:14:34AM -0700, Steve Sistare wrote: > @@ -3182,6 +3207,51 @@ static Property vfio_pci_dev_properties[] = { > DEFINE_PROP_END_OF_LIST(), > }; > > +static int vfio_pci_post_load(void *opaque, int version_id) > +{ > +int vector; > +MSIMessage msg;

Why QEMU should move from C to Rust (clickbait alert ;))

I just posted this on my blog, but my intention is to continue the discussion around moving to Rust in the QEMU community. Thoughts about how to increase safety in QEMU, both for and against moving to Rust are welcome! My KVM Forum 2018 presentation titled Security in QEMU: How Virtual Machines pr

Re: [PATCH-for-5.2 7/7] hw/block/fdc: Add ASCII art schema of QOM relations

On 8/6/20 10:57 AM, Kevin Wolf wrote: > Am 06.08.2020 um 10:08 hat Philippe Mathieu-Daudé geschrieben: >> Without knowing the QEMU history, it is hard to relate QEMU objects >> with the hardware datasheet. >> >> For example, one naively expects: >> >> * a floppy disk is plugged / unplugged o

Re: [PATCH 1/1] qga: add command guest-get-disks

On 8/6/20 11:03 AM, Tomáš Golembiovský wrote: > The command guest-get-fsinfo can be used to list information about disks and > partitions but it is limited only to mounted disks with filesystem. This new > command allows listing information about attached root disks of the VM. This > is > usefull

[PATCH 0/4] Refactor get_fpstatus_ptr() ready for AArch32 fp16

This patchset refactors the existing get_fpstatus_ptr() functions, and fixes a bug where we weren't getting FZ16 right for AArch32 VCMLA, VCADD of fp16 types. We currently have two versions of get_fpstatus_ptr(), which both take an effectively boolean argument: * the one for A64 takes "bool is_f1

[PATCH 3/4] target/arm: Implement FPST_STD_F16 fpstatus

Architecturally, Neon FP16 operations use the "standard FPSCR" like all other Neon operations. However, this is defined in the Arm ARM pseudocode as "a fixed value, except that FZ16 (and AHP) follow the FPSCR bits". In QEMU, the softfloat float_status doesn't include separate flush-to-zero for FP1

[PATCH 1/4] target/arm: Replace A64 get_fpstatus_ptr() with generic fpstatus_ptr()

We currently have two versions of get_fpstatus_ptr(), which both take an effectively boolean argument: * the one for A64 takes "bool is_f16" to distinguish fp16 from other ops * the one for A32/T32 takes "int neon" to distinguish Neon from other ops This is confusing, and to implement ARMv8.2-FP

[PATCH 2/4] target/arm: Make A32/T32 use new fpstatus_ptr() API

Make A32/T32 code use the new fpstatus_ptr() API: get_fpstatus_ptr(0) -> fpstatus_ptr(FPST_FPCR) get_fpstatus_ptr(1) -> fpstatus_ptr(FPST_STD) Signed-off-by: Peter Maydell --- target/arm/translate-neon.inc.c | 28 ++--- target/arm/translate-vfp.inc.c | 44 -

[RFC v3 09/71] target/riscv: rvv-1.0: add vlenb register

From: Greentime Hu Signed-off-by: Greentime Hu Signed-off-by: Frank Chang Reviewed-by: Richard Henderson --- target/riscv/cpu_bits.h | 1 + target/riscv/csr.c | 7 +++ 2 files changed, 8 insertions(+) diff --git a/target/riscv/cpu_bits.h b/target/riscv/cpu_bits.h index 7afdd4814bb..

[RFC v3 00/71] target/riscv: support vector extension v1.0

From: Frank Chang This patchset implements the vector extension v1.0 for RISC-V on QEMU. This patchset is sent as RFC because RVV v1.0 is still in draft state. v2 patchset was sent for RVV v0.9. However, in order to relieve the burden for the community to maintain multi-version of vector drafts.

[PATCH 4/4] target/arm: Use correct FPST for VCMLA, VCADD on fp16

When we implemented the VCMLA and VCADD insns we put in the code to handle fp16, but left it using the standard fp status flags. Correct them to use FPST_STD_F16 for fp16 operations. Signed-off-by: Peter Maydell --- target/arm/translate-neon.inc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 d

[RFC v3 08/71] target/riscv: rvv-1.0: add vcsr register

From: LIU Zhiwei Signed-off-by: LIU Zhiwei Signed-off-by: Frank Chang Reviewed-by: Richard Henderson --- target/riscv/cpu_bits.h | 7 +++ target/riscv/csr.c | 21 + 2 files changed, 28 insertions(+) diff --git a/target/riscv/cpu_bits.h b/target/riscv/cpu_bits.h

[RFC v3 03/71] target/riscv: rvv-1.0: add mstatus VS field

From: LIU Zhiwei Signed-off-by: LIU Zhiwei Signed-off-by: Frank Chang Reviewed-by: Richard Henderson --- target/riscv/cpu.h| 6 ++ target/riscv/cpu_bits.h | 1 + target/riscv/cpu_helper.c | 16 +++- target/riscv/csr.c| 25 - 4 files

[RFC v3 01/71] target/riscv: drop vector 0.7.1 and add 1.0 support

From: Frank Chang Signed-off-by: Frank Chang Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis --- target/riscv/cpu.c | 10 +- target/riscv/cpu.h | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index 228b9bdb5d

[RFC v3 15/71] target/riscv: introduce more imm value modes in translator functions

From: Frank Chang Immediate value in translator function is extended not only zero-extended and sign-extended but with more modes to be applicable with multiple formats of vector instructions. * IMM_ZX: Zero-extended * IMM_SX: Sign-extended * IMM_TRUNC_SEW: Truncate to log(SEW)

[RFC v3 25/71] target/riscv: rvv-1.0: load/store whole register instructions

From: Frank Chang Add the following instructions: * vlre.v * vsr.v Signed-off-by: Frank Chang --- target/riscv/helper.h | 21 +++ target/riscv/insn32.decode | 22 target/riscv/insn_trans/trans_rvv.inc.c | 74 + target/riscv/v

[RFC v3 06/71] target/riscv: rvv-1.0: add translation-time vector context status

From: LIU Zhiwei Signed-off-by: LIU Zhiwei Signed-off-by: Frank Chang Reviewed-by: Richard Henderson --- target/riscv/insn_trans/trans_rvv.inc.c | 69 - target/riscv/translate.c| 33 2 files changed, 90 insertions(+), 12 deletions(-) diff

[RFC v3 11/71] target/riscv: rvv-1.0: remove MLEN calculations

From: Frank Chang As in RVV 1.0 design, MLEN is hardcoded with value 1 (Section 4.5). Thus, remove all MLEN related calculations. Signed-off-by: Frank Chang Reviewed-by: Richard Henderson --- target/riscv/insn_trans/trans_rvv.inc.c | 35 +--- target/riscv/internals.h| 9 +-

[RFC v3 02/71] target/riscv: Use FIELD_EX32() to extract wd field

From: Frank Chang Signed-off-by: Frank Chang Reviewed-by: Richard Henderson --- target/riscv/vector_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/riscv/vector_helper.c b/target/riscv/vector_helper.c index 793af990673..43ba272c09b 100644 --- a/target/riscv/

[RFC v3 17/71] target/riscv: rvv:1.0: add translation-time nan-box helper function

From: Frank Chang Add do_nanbox() helper function to utilize gen_check_nanbox_X() to generate the NaN-boxed floating-point values based on SEW setting. Signed-off-by: Frank Chang --- target/riscv/insn_trans/trans_rvv.inc.c | 27 + 1 file changed, 27 insertions(+) diff

[RFC v3 28/71] target/riscv: rvv-1.0: floating-point square-root instruction

From: Frank Chang Signed-off-by: Frank Chang Reviewed-by: Richard Henderson --- target/riscv/insn32.decode | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/riscv/insn32.decode b/target/riscv/insn32.decode index c99575d1360..f142aa5d073 100644 --- a/target/riscv/insn32

Re: Qemu web site down?

Christophe de Dinechin writes: > Hi Stefan, > > > The link from https://wiki.qemu.org/Documentation pointing to > https://qemu.weilnetz.de/doc/qemu-doc.html seems to be dead. Is the > problem on your web site, or should the wiki be updated? It should be pointing at: https://www.qemu.org/doc

[RFC v3 04/71] target/riscv: rvv-1.0: add sstatus VS field

From: LIU Zhiwei Signed-off-by: LIU Zhiwei Signed-off-by: Frank Chang Reviewed-by: Richard Henderson --- target/riscv/cpu_bits.h | 1 + target/riscv/csr.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/target/riscv/cpu_bits.h b/target/riscv/cpu_bits.h index a8b3120

[RFC v3 10/71] target/riscv: rvv-1.0: check MSTATUS_VS when accessing vector csr registers

From: Frank Chang If VS field is off, accessing vector csr registers should raise an illegal-instruction exception. Signed-off-by: Frank Chang --- target/riscv/csr.c | 5 + 1 file changed, 5 insertions(+) diff --git a/target/riscv/csr.c b/target/riscv/csr.c index 11ce6d4576a..50a178a60d0

[RFC v3 29/71] target/riscv: rvv-1.0: floating-point classify instructions

From: Frank Chang Signed-off-by: Frank Chang Reviewed-by: Richard Henderson --- target/riscv/insn32.decode | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/riscv/insn32.decode b/target/riscv/insn32.decode index f142aa5d073..a800c989050 100644 --- a/target/riscv/insn32

Re: Qemu web site down?

On Thu, Aug 06, 2020 at 12:14:51PM +0200, Christophe de Dinechin wrote: > Hi Stefan, > > > The link from https://wiki.qemu.org/Documentation pointing to > https://qemu.weilnetz.de/doc/qemu-doc.html seems to be dead. > Is the problem on your web site, or should the wiki be updated? Those linked d

[RFC v3 05/71] target/riscv: rvv-1.0: introduce writable misa.v field

From: Frank Chang Implementations may have a writable misa.v field. Analogous to the way in which the floating-point unit is handled, the mstatus.vs field may exist even if misa.v is clear. Signed-off-by: Frank Chang --- target/riscv/csr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[RFC v3 20/71] target/riscv: rvv-1.0: stride load and store instructions

From: Frank Chang Signed-off-by: Frank Chang --- target/riscv/helper.h | 129 +++--- target/riscv/insn32.decode | 43 +++-- target/riscv/insn_trans/trans_rvv.inc.c | 221 +++- target/riscv/vector_helper.c| 188 ++---

[RFC v3 12/71] target/riscv: rvv-1.0: add fractional LMUL

From: Frank Chang Introduce the concepts of fractional LMUL for RVV 1.0. In RVV 1.0, LMUL bits are contiguous in vtype register. Signed-off-by: Frank Chang --- target/riscv/cpu.h | 15 --- target/riscv/insn_trans/trans_rvv.inc.c | 9 ++--- target/riscv/tra

[RFC v3 07/71] target/riscv: rvv-1.0: remove vxrm and vxsat fields from fcsr register

From: Frank Chang Remove VXRM and VXSAT fields from FCSR register as they are only presented in VCSR register. Signed-off-by: Frank Chang --- target/riscv/csr.c | 9 - 1 file changed, 9 deletions(-) diff --git a/target/riscv/csr.c b/target/riscv/csr.c index 7f937e5b9c8..34c951d5d4b 10

[RFC v3 32/71] target/riscv: rvv-1.0: set-X-first mask bit instructions

From: Frank Chang Signed-off-by: Frank Chang Reviewed-by: Richard Henderson --- target/riscv/insn32.decode | 6 +++--- target/riscv/insn_trans/trans_rvv.inc.c | 5 - target/riscv/vector_helper.c| 4 3 files changed, 7 insertions(+), 8 deletions(-) diff --git

[RFC v3 14/71] target/riscv: rvv-1.0: update check functions

From: Frank Chang Update check functions with RVV 0.9 rules. Signed-off-by: Frank Chang --- target/riscv/insn_trans/trans_rvv.inc.c | 706 1 file changed, 474 insertions(+), 232 deletions(-) diff --git a/target/riscv/insn_trans/trans_rvv.inc.c b/target/riscv/insn_tra

[RFC v3 22/71] target/riscv: rvv-1.0: fix address index overflow bug of indexed load/store insns

From: Frank Chang Replace ETYPE from signed int to unsigned int to prevent index overflow issue, which would lead to wrong index address. Signed-off-by: Frank Chang --- target/riscv/vector_helper.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/riscv/vector_

[RFC v3 34/71] target/riscv: rvv-1.0: element index instruction

From: Frank Chang Signed-off-by: Frank Chang Reviewed-by: Richard Henderson --- target/riscv/insn32.decode | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/riscv/insn32.decode b/target/riscv/insn32.decode index 7a10fc27c5f..15afc469cb0 100644 --- a/target/riscv/insn32

[RFC v3 19/71] target/riscv: rvv-1.0: configure instructions

From: Frank Chang Signed-off-by: Frank Chang --- target/riscv/insn_trans/trans_rvv.inc.c | 12 target/riscv/vector_helper.c| 14 +- 2 files changed, 21 insertions(+), 5 deletions(-) diff --git a/target/riscv/insn_trans/trans_rvv.inc.c b/target/riscv/insn_t

[RFC v3 16/71] target/riscv: add fp16 nan-box check generator function

From: Frank Chang If a 16-bit input is not properly nanboxed, then the input is replaced with the default qnan. Signed-off-by: Frank Chang --- target/riscv/translate.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/target/riscv/translate.c b/target/riscv/translate.c index 2402

[RFC v3 24/71] target/riscv: rvv-1.0: amo operations

From: Frank Chang Signed-off-by: Frank Chang --- target/riscv/helper.h | 100 +++--- target/riscv/insn32-64.decode | 18 +- target/riscv/insn32.decode | 36 +++- target/riscv/insn_trans/trans_rvv.inc.c | 220 ++ target/riscv/vec

[RFC v3 35/71] target/riscv: rvv-1.0: allow load element with sign-extended

From: Frank Chang For some vector instructions (e.g. vmv.s.x), the element is loaded with sign-extended. Signed-off-by: Frank Chang Reviewed-by: Richard Henderson --- target/riscv/insn_trans/trans_rvv.inc.c | 26 ++--- 1 file changed, 19 insertions(+), 7 deletions(-) diff

  1   2   3   4   5   6   >