Am 30.07.2020 um 17:11 hat Eric Blake geschrieben:
> > The QAPI schema language has two layers:
> >
> > * JSON, with a lexical and a syntactical sub-layer (both in parser.py)
> >
> > * QAPI, with a context-free and a context-dependend sub-layer (in
> >expr.py and schema.py, respectively)
> >
On 30.07.2020 22:05, Eric Blake wrote:
On 7/30/20 9:15 AM, Andrey Shinkevich wrote:
The simple script creates a QCOW2 image and fills it with some data.
Two bitmaps are created as well. Then the script reads the image header
with extensions from the disk by running the script qcow2.py and dumps
Eric Blake writes:
> On 7/30/20 10:59 AM, Daniel P. Berrangé wrote:
>
>>> Well, I suspect that management-layer code currently has
>>> gone for "assume we're always running on Linux" and was
>>> written by people who knew they were getting a Linux tid...
>>
>> Yes, on the libvirt side, the functi
On 7/28/20 8:37 PM, Thomas Huth wrote:
> The main QEMU code is compiled with -std=gnu99, -fwrapv and -fno-common.
> We should use the same flags for the s390-ccw bios, too, to avoid that
> we get different behavior with different compiler versions that changed
> their default settings in the course
On 31/07/2020 09.46, Janosch Frank wrote:
> On 7/28/20 8:37 PM, Thomas Huth wrote:
>> The main QEMU code is compiled with -std=gnu99, -fwrapv and -fno-common.
>> We should use the same flags for the s390-ccw bios, too, to avoid that
>> we get different behavior with different compiler versions that
On Sun, 21 Jun 2020 10:10:03 +0800
Derek Su wrote:
> This series is to reduce the guest's downtime during colo checkpoint
> by migrating dirty ram pages as many as possible before colo checkpoint.
>
> If the iteration count reaches COLO_RAM_MIGRATE_ITERATION_MAX or
> ram pending size is lower th
This issue has been fixed in HAXM, see:
"save/restore FPU registers in VM entry/exit"
https://github.com/intel/haxm/commit/6c2cd4d79d
** Changed in: qemu
Status: New => Invalid
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
h
On Thu, Jul 30, 2020 at 06:21:34PM -0400, Daniel Walsh wrote:
> On 7/29/20 10:40, Stefan Hajnoczi wrote:
> > On Wed, Jul 29, 2020 at 09:59:01AM +0200, Roman Mohr wrote:
> >> On Tue, Jul 28, 2020 at 3:13 PM Vivek Goyal wrote:
> >>
> >>> On Tue, Jul 28, 2020 at 12:00:20PM +0200, Roman Mohr wrote:
>
James, do you know if this has been fixed in GLib 2.65.0?
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1845185
Title:
Cannot build qemu utils (qemu-img.exe, qemu-edid.exe, qemu-io.exe)
staticall
Hi Justin, Sunil,
On 5/20/20 12:26 PM, Philippe Mathieu-Daudé wrote:
> +launchpad ticket
>
> On 9/20/19 6:53 PM, Justin Terry (VM) wrote:
>> Hey Phil,
>>
>> I have contacted our legal department for guidance on this specific
>> use case and will update you when I hear back. Thank you for your
>>
On 7/31/20 7:06 AM, Lukas Straub wrote:
> s->iothread is checked for NULL on object creation in colo_compare_complete,
> so it's guaranteed not to be NULL.
> This resolves a false alert from Coverity (CID 1429969).
>
> Signed-off-by: Lukas Straub
Reviewed-by: Philippe Mathieu-Daudé
> ---
> n
On Fri, Jul 31, 2020 at 10:26 AM Stefan Hajnoczi
wrote:
> On Thu, Jul 30, 2020 at 06:21:34PM -0400, Daniel Walsh wrote:
> > On 7/29/20 10:40, Stefan Hajnoczi wrote:
> > > On Wed, Jul 29, 2020 at 09:59:01AM +0200, Roman Mohr wrote:
> > >> On Tue, Jul 28, 2020 at 3:13 PM Vivek Goyal
> wrote:
> > >
On Fri, Jul 31, 2020 at 09:15:13AM +0200, Kevin Wolf wrote:
> Am 30.07.2020 um 17:11 hat Eric Blake geschrieben:
> > > The QAPI schema language has two layers:
> > >
> > > * JSON, with a lexical and a syntactical sub-layer (both in parser.py)
> > >
> > > * QAPI, with a context-free and a context-
On Thu, Jul 30, 2020 at 02:48:44PM -0400, Steven Sistare wrote:
> On 7/30/2020 12:52 PM, Daniel P. Berrangé wrote:
> > On Thu, Jul 30, 2020 at 08:14:04AM -0700, Steve Sistare wrote:
> >> Improve and extend the qemu functions that save and restore VM state so a
> >> guest may be suspended and resume
From: Halil Pasic
As pointed out by Peter, g_memdup(ms->loadparm, sizeof(ms->loadparm) + 1)
reads one past of the end of ms->loadparm, so g_memdup() can not be used
here.
Let's use g_strndup instead!
Fixes: d6645483285f ("s390x/s390-virtio-ccw: fix loadparm property getter")
Fixes: Coverity CID
The following changes since commit 5772f2b1fc5d00e7e04e01fa28e9081d6550440a:
Update version for v5.1.0-rc2 release (2020-07-28 21:51:03 +0100)
are available in the Git repository at:
https://github.com/cohuck/qemu tags/s390x-20200731
for you to fetch changes up to
My distribution has not added 2.65.0 yet but it should be fixed now,
yes.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1845185
Title:
Cannot build qemu utils (qemu-img.exe, qemu-edid.exe, qemu-io.
Kevin Wolf writes:
> Am 30.07.2020 um 17:11 hat Eric Blake geschrieben:
>> > JSON is a exceptionally poor choice for a DSL, or even a configuration
>> > language.
>> >
>> > Correcting our mistake involves a flag day and a re-learn. We need to
>> > weigh costs against benefits.
>> >
>> > The QA
Hi Lukas Straub & Derek,
Sorry for the late reply, too busy these days ;)
> -Original Message-
> From: Lukas Straub [mailto:lukasstra...@web.de]
> Sent: Friday, July 31, 2020 3:52 PM
> To: Derek Su
> Cc: qemu-devel@nongnu.org; Zhanghailiang
> ; chy...@qnap.com;
> quint...@redhat.com; dgi
On Thu, Jul 30, 2020 at 08:14:28AM -0700, Steve Sistare wrote:
> From: Mark Kanda
>
> Iterate through the VNC displays and save/restore the socket fds.
This patch doesn't appear to do anything around the client state, so I
can't see how this will work in general. eg QEMU is 1/2 way through
rece
Error log:
/home/LiKaige/qemu/target/arm/translate-a64.c: In function ‘disas_ldst’:
/home/LiKaige/qemu/target/arm/translate-a64.c:3392:5: error: ‘fn’ may be used
uninitialized in this function [-Werror=maybe-uninitialized]
fn(cpu_reg(s, rt), clean_addr, tcg_rs, get_mem_index(s),
^
/home
On Fri, 31 Jul 2020 at 10:07, Kaige Li wrote:
>
> Error log:
>
> /home/LiKaige/qemu/target/arm/translate-a64.c: In function ‘disas_ldst’:
> /home/LiKaige/qemu/target/arm/translate-a64.c:3392:5: error: ‘fn’ may be used
> uninitialized in this function [-Werror=maybe-uninitialized]
> fn(cpu_re
John Snow writes:
> On 7/30/20 9:24 AM, Daniel P. Berrangé wrote:
>> On Thu, Jul 30, 2020 at 01:51:10PM +0200, Markus Armbruster wrote:
>>> Daniel P. Berrangé writes:
>>>
modify them so that we can load the
files straight into the python intepretor as cod
Hello Everyone,
In many cases, if qemu has a network connection (qmp, migration, chardev, etc.)
to some other server and that server dies or hangs, qemu hangs too.
These patches introduce the new 'yank' out-of-band qmp command to recover from
these kinds of hangs. The different subsystems register
The yank feature allows to recover from hanging qemu by "yanking"
at various parts. Other qemu systems can register themselves and
multiple yank functions. Then all yank functions for selected
instances can be called by the 'yank' out-of-band qmp command.
Available instances can be queried by a 'qu
Register a yank function which shuts down the socket and sets
s->state = NBD_CLIENT_QUIT. This is the same behaviour as if an
error occured.
Signed-off-by: Lukas Straub
Acked-by: Stefan Hajnoczi
---
block/nbd.c | 123 +++-
1 file changed, 74 inser
Register yank functions on sockets to shut them down.
Signed-off-by: Lukas Straub
Reviewed-by: Daniel P. Berrangé
Acked-by: Stefan Hajnoczi
---
migration/channel.c | 12
migration/migration.c | 18 +-
migration/multifd.c | 10 ++
A connecting chardev object has an additional reference by the connecting
thread, so if the chardev is still connecting by the end of the test,
then the chardev object won't be freed. This in turn means that the yank
instance won't be unregistered and when running the next test-case
yank_register_i
Register a yank function to shutdown the socket on yank.
Signed-off-by: Lukas Straub
Reviewed-by: Daniel P. Berrangé
Acked-by: Stefan Hajnoczi
---
chardev/char-socket.c | 24
1 file changed, 24 insertions(+)
diff --git a/chardev/char-socket.c b/chardev/char-socket.c
i
yank_register_instance (called when creating the new chardev object)
aborts if the instance already exists. So check for duplicate id before
creating the new chardev to prevent this.
Signed-off-by: Lukas Straub
---
chardev/char.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
Make qio_channel_tls_shutdown thread-safe by using atomics when
accessing tioc->shutdown.
Signed-off-by: Lukas Straub
Reviewed-by: Daniel P. Berrangé
Acked-by: Stefan Hajnoczi
---
io/channel-tls.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/io/channel-tls.c b/io/c
On Thu, 30 Jul 2020 11:58:38 -0400
"Michael S. Tsirkin" wrote:
> macOS uses ACPI UIDs to build the DevicePath for NVRAM boot options,
> while OVMF firmware gets them via an internal channel through QEMU.
> Due to a bug in QEMU ACPI currently UEFI firmware and ACPI have
> different values, and thi
On Thu, 30 Jul 2020 11:58:41 -0400
"Michael S. Tsirkin" wrote:
> On ARM/virt machine type QEMU currently reports an incorrect _UID in
> ACPI.
>
> The particular node in question is the primary PciRoot (PCI0 in ACPI),
> which gets assigned PCI0 in ACPI UID and 0 in the
> DevicePath. This is due t
Migration and yank code assume that qio_channel_shutdown is thread
-safe. Document this after checking the code.
Signed-off-by: Lukas Straub
Reviewed-by: Daniel P. Berrangé
Acked-by: Stefan Hajnoczi
---
include/io/channel.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/io/chann
I'll maintain this for now as the colo usecase is the first user
of this functionality.
Signed-off-by: Lukas Straub
Reviewed-by: Daniel P. Berrangé
Acked-by: Stefan Hajnoczi
---
MAINTAINERS | 6 ++
1 file changed, 6 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 0886eb3d2b..bf
On Fri, Jul 31, 2020 at 11:21:35AM +0200, Markus Armbruster wrote:
> John Snow writes:
>
> > On 7/30/20 9:24 AM, Daniel P. Berrangé wrote:
> >>> Some of the criticism there doesn't matter for our use case.
> >>
> >> Yeah, what matters is whether it can do the job we need in a way that is
> >> bet
Hi Peter,
On 7/30/20 3:38 PM, Peter Maydell wrote:
> On Tue, 28 Jul 2020 at 16:09, Eric Auger wrote:
>>
>> At the moment each entry in the IOTLB corresponds to a page sized
>> mapping (4K, 16K or 64K), even if the page belongs to a mapped
>> block. In case of block mapping this unefficiently cons
On Fri, Jul 31, 2020 at 11:27:04AM +0200, Lukas Straub wrote:
> yank_register_instance (called when creating the new chardev object)
> aborts if the instance already exists. So check for duplicate id before
> creating the new chardev to prevent this.
I feel the right answer here is for yank_regist
On 07/31/2020 05:20 PM, Peter Maydell wrote:
On Fri, 31 Jul 2020 at 10:07, Kaige Li wrote:
Error log:
/home/LiKaige/qemu/target/arm/translate-a64.c: In function ‘disas_ldst’:
/home/LiKaige/qemu/target/arm/translate-a64.c:3392:5: error: ‘fn’ may be used
uninitialized in this function [-Werror
Steven Sistare writes:
> On 7/30/2020 1:03 PM, Alex Bennée wrote:
>>
>> Steve Sistare writes:
>>
>>> Provide the -pause command-line parameter and the QEMU_PAUSE environment
>>> variable to briefly pause QEMU in main and allow a developer to attach gdb.
>>> Useful when the developer does not
> I guess fundamentally th issue is writing 0xXX in IO port 0xB2 should
> trigger SMI handler in all possible core but instead it triggers SMI
> only in Core#0.
For that, the guest needs to negotiate the "broadcast SMI" feature with
QEMU. See commit range 57bb40c9db40..b8bab8eb6934.
--
You recei
Hello Leif,
On 30.7.20. 04:55, Leif N Huhn wrote:
Hi. This is my first time trying to contribute to qemu. This patch
works correctly for architectures with the same bit-width, for example
32bit arm host and i386 user binary. Here is an example with the sg_simple2
executable from https://github.c
On Thu, Jul 30, 2020 at 02:11:19PM -0400, Steven Sistare wrote:
> On 7/30/2020 12:20 PM, Eric Blake wrote:
> > On 7/30/20 10:14 AM, Steve Sistare wrote:
> >> Provide the -pause command-line parameter and the QEMU_PAUSE environment
> >> variable to briefly pause QEMU in main and allow a developer to
On Thu, Jul 30, 2020 at 08:15:12PM +, Pincus, Josh wrote:
> We were looking into a similar enhancement for the Virt I/O MMIO transport
> and came across this project.
> This enhancement would be perfect for us.
>
> Has there been any progress since Feb, 2020? It looks like the effort might
On Fri, Jul 31, 2020 at 4:35 AM Richard Henderson <
richard.hender...@linaro.org> wrote:
> On 7/22/20 2:16 AM, frank.ch...@sifive.com wrote:
> > +static gen_helper_gvec_3_ptr * const fns[6][4] = {
> > +{
> > +NULL, gen_helper_vzext_vf2_h,
> > +gen_helper_vzext_v
On 30.7.20. 04:55, Leif N Huhn wrote:
This patch implements functionalities of following ioctls:
SG_GET_VERSION_NUM - Returns SG driver version number
The sg version numbers are of the form "x.y.z" and the single number given
by the SG_GET_VERSION_NUM ioctl() is calculated by
(
On Wed, Jul 29, 2020 at 02:06:43PM +0300, Denis V. Lunev wrote:
> On 7/29/20 1:30 PM, Stefan Hajnoczi wrote:
> > On Fri, Jul 10, 2020 at 08:27:11PM +0300, Denis V. Lunev wrote:
> >> @@ -3740,6 +3741,10 @@ QemuOptsList qemu_common_drive_opts = {
> >> .type = QEMU_OPT_BOOL,
> >>
Lukas Straub 于2020年7月31日周五 下午1:09写道：
>
> s->iothread is checked for NULL on object creation in colo_compare_complete,
> so it's guaranteed not to be NULL.
> This resolves a false alert from Coverity (CID 1429969).
>
> Signed-off-by: Lukas Straub
Reviewed-by: Li Qiang
> ---
> net/colo-compare.
On Fri, Jul 10, 2020 at 08:27:09PM +0300, Denis V. Lunev wrote:
> There are severe delays with IO requests processing if QEMU is running in
> virtual machine or over software defined storage. Such delays potentially
> results in unpredictable guest behavior. For example, guests over IDE or
> SATA d
m/cohuck/qemu tags/s390x-20200731
>
> for you to fetch changes up to 148d25e0f6ad1dc3bd6aace092d65262d4217ec6:
>
> s390x/s390-virtio-ccw: fix off-by-one in loadparm getter (2020-07-30
> 16:53:34 +0200)
>
> --
On 7/31/20 1:25 PM, Stefan Hajnoczi wrote:
> On Fri, Jul 10, 2020 at 08:27:09PM +0300, Denis V. Lunev wrote:
>> There are severe delays with IO requests processing if QEMU is running in
>> virtual machine or over software defined storage. Such delays potentially
>> results in unpredictable guest be
> -Original Message-
> From: Lukas Straub
> Sent: Friday, July 31, 2020 1:06 PM
> To: qemu-devel
> Cc: Peter Maydell ; Jason Wang
> ; Zhang, Chen
> Subject: [PATCH] colo-compare: Remove superfluous NULL-pointer checks
> for s->iothread
>
> s->iothread is checked for NULL on object cr
On 7/31/20 12:09 AM, Paolo Bonzini wrote:
> On 30/07/20 18:33, Claudio Fontana wrote:
>> One problem I noticed is that qemu_clock_get_ns is util/qemu-timer.c,
>> which is tools _and_ softmmu, while I tried to extract the
>> softmmu-only timer code in softmmu/cpu-timers.c,
>
> Not all of it, only t
Am 31.07.2020 um 11:01 hat Markus Armbruster geschrieben:
> Kevin Wolf writes:
>
> > Am 30.07.2020 um 17:11 hat Eric Blake geschrieben:
> >> > JSON is a exceptionally poor choice for a DSL, or even a configuration
> >> > language.
> >> >
> >> > Correcting our mistake involves a flag day and a re
The purpose of this change is to set the groundwork
so that an arch could move towards removing
the BQL from the cpu_handle_interrupt/exception paths.
The BQL is a bottlneck in scaling to more cores.
And this cpu_handle_interrupt/exception path is one of
the key BQL users as measured by the QEMU s
This change removes the implied BQL from the cpu_handle_interrupt,
and cpu_handle_exception paths. We can now select per-arch if
the BQL is needed or not by using the bql_interrupt flag.
By default, the core code holds the BQL.
One benefit of this change is that it leaves it up to the arch
to make
The new flag bql_interrupt, allows the CPUClass to
determine if the BQL should be held during calls to
cpu_exec_interrupt or do_interrupt.
This is being added in preparation for changes in
cpu_handle_interrupt, which will use this flag.
Signed-off-by: Robert Foley
---
hw/core/cpu.c | 1
Daniel P. Berrangé writes:
> On Thu, Jul 30, 2020 at 01:51:10PM +0200, Markus Armbruster wrote:
>> Daniel P. Berrangé writes:
>>
>> > modify them so that we can load the
>> > files straight into the python intepretor as code, and not parse
>> > them as data. I fe
On Fri, 31 Jul 2020 10:37:34 +0100
Daniel P. Berrangé wrote:
> On Fri, Jul 31, 2020 at 11:27:04AM +0200, Lukas Straub wrote:
> > yank_register_instance (called when creating the new chardev object)
> > aborts if the instance already exists. So check for duplicate id before
> > creating the new ch
On 7/31/20 2:44 AM, Markus Armbruster wrote:
Thread_id should be optional and thus not filled in if we
can't provide a sensible value. Unfortunately we made it
mandatory in QMP.
Normally, converting a mandatory output value to optional is a
back-compatibility risk (we could break apps that dep
On Fri, Jul 31, 2020 at 08:46:40AM -0500, Eric Blake wrote:
> On 7/31/20 2:44 AM, Markus Armbruster wrote:
>
> > > > Thread_id should be optional and thus not filled in if we
> > > > can't provide a sensible value. Unfortunately we made it
> > > > mandatory in QMP.
> > >
> > > Normally, convertin
On Fri, Jul 31, 2020 at 10:39:37AM +0200, Roman Mohr wrote:
> On Fri, Jul 31, 2020 at 10:26 AM Stefan Hajnoczi
> wrote:
>
> > On Thu, Jul 30, 2020 at 06:21:34PM -0400, Daniel Walsh wrote:
> > > On 7/29/20 10:40, Stefan Hajnoczi wrote:
> > > > On Wed, Jul 29, 2020 at 09:59:01AM +0200, Roman Mohr w
qemu (1:5.0-5ubuntu3) groovy; urgency=medium
has the merge with this fix:
- linux-user-add-netlink-RTM_SETLINK-command.patch (Closes: #964289)
** Changed in: qemu (Ubuntu)
Status: New => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml,
On Sat, 11 Jul 2020 at 11:10, Andrew Jones wrote:
> We add the kvm-steal-time CPU property and implement it for machvirt.
> A tiny bit of refactoring was also done to allow pmu and pvtime to
> use the same vcpu device helper functions.
>
> Signed-off-by: Andrew Jones
Hi; I'm forwarding a couple
On Fri, Jul 31, 2020 at 02:55:34PM +0200, Markus Armbruster wrote:
> Daniel P. Berrangé writes:
> >> Some of the criticism there doesn't matter for our use case.
> >
> > Yeah, what matters is whether it can do the job we need in a way that is
> > better than what we have today, and whether there
On 7/22/20 2:16 AM, frank.ch...@sifive.com wrote:
> /* Vector Widening Integer Reduction Instructions */
> /* signed sum reduction into double-width accumulator */
> -GEN_VEXT_RED(vwredsum_vs_b, int16_t, int8_t, H2, H1, DO_ADD, clearh)
> -GEN_VEXT_RED(vwredsum_vs_h, int32_t, int16_t, H4, H2, DO_A
On 7/31/2020 6:07 AM, Daniel P. Berrangé wrote:
> On Thu, Jul 30, 2020 at 02:11:19PM -0400, Steven Sistare wrote:
>> On 7/30/2020 12:20 PM, Eric Blake wrote:
>>> On 7/30/20 10:14 AM, Steve Sistare wrote:
Provide the -pause command-line parameter and the QEMU_PAUSE environment
variable to
On 7/31/20 11:07 AM, Daniel P. Berrangé wrote:
On Fri, Jul 31, 2020 at 02:55:34PM +0200, Markus Armbruster wrote:
Daniel P. Berrangé writes:
Some of the criticism there doesn't matter for our use case.
Yeah, what matters is whether it can do the job we need in a way that is
better than wha
On 7/31/2020 4:53 AM, Daniel P. Berrangé wrote:
> On Thu, Jul 30, 2020 at 02:48:44PM -0400, Steven Sistare wrote:
>> On 7/30/2020 12:52 PM, Daniel P. Berrangé wrote:
>>> On Thu, Jul 30, 2020 at 08:14:04AM -0700, Steve Sistare wrote:
Improve and extend the qemu functions that save and restore V
Pincus, Josh writes:
> Hi,
>
>
>
> We were looking into a similar enhancement for the Virt I/O MMIO transport
> and came across this project.
>
> This enhancement would be perfect for us.
So there is certainly an interest in optimising MMIO based virtio and
the current read/ack cycle adds a
On Fri, Jul 31, 2020 at 11:26:28AM -0400, John Snow wrote:
> > The long answer is that as a general philosophy I'm in favour of agressively
> > eliminating anything that is custom to a project and isn't offering an
> > compelling benefit over a functionally equivalent, commonly used / standard
> >
On Fri, Jul 31, 2020 at 11:27:45AM -0400, Steven Sistare wrote:
> On 7/31/2020 4:53 AM, Daniel P. Berrangé wrote:
> > On Thu, Jul 30, 2020 at 02:48:44PM -0400, Steven Sistare wrote:
> >> On 7/30/2020 12:52 PM, Daniel P. Berrangé wrote:
> >>> On Thu, Jul 30, 2020 at 08:14:04AM -0700, Steve Sistare w
On 7/22/20 2:16 AM, frank.ch...@sifive.com wrote:
> -#define GEN_VEXT_VSLIDEDOWN_VX(NAME, ETYPE, H, CLEAR_FN) \
> +#define GEN_VEXT_VSLIDEDOWN_VX(NAME, ETYPE, H)\
> void HELPER(NAME)(void *vd, void *v0, target_ulong s1, void *vs2, \
>
On 7/22/20 2:16 AM, frank.ch...@sifive.com wrote:
> +DEF_HELPER_6(vfslide1up_vf_h, void, ptr, ptr, i64, ptr, env, i32)
> +DEF_HELPER_6(vfslide1up_vf_w, void, ptr, ptr, i64, ptr, env, i32)
> +DEF_HELPER_6(vfslide1up_vf_d, void, ptr, ptr, i64, ptr, env, i32)
> +DEF_HELPER_6(vfslide1down_vf_h, void, p
On 7/22/20 2:16 AM, frank.ch...@sifive.com wrote:
> From: Frank Chang
>
> Signed-off-by: Frank Chang
> ---
> target/riscv/helper.h | 24 ++--
> target/riscv/insn32.decode | 12 +++---
> target/riscv/insn_trans/trans_rvv.inc.c | 12 +++---
> target/riscv/ve
On 31/07/20 17:07, Daniel P. Berrangé wrote:
> The QAPI JSON-but-not file format is a case where I think we should just
> adopt a standard file format no matter what. A conversion will have some
> short term work, but this is really simple data to deal with and the code
> involved is nicely self co
On 7/22/20 2:16 AM, frank.ch...@sifive.com wrote:
> @@ -994,6 +994,12 @@ DEF_HELPER_5(vfcvt_f_xu_v_d, void, ptr, ptr, ptr, env,
> i32)
> DEF_HELPER_5(vfcvt_f_x_v_h, void, ptr, ptr, ptr, env, i32)
> DEF_HELPER_5(vfcvt_f_x_v_w, void, ptr, ptr, ptr, env, i32)
> DEF_HELPER_5(vfcvt_f_x_v_d, void, pt
On 31/07/20 17:26, John Snow wrote:
> I saw the critique that we still use JSON-ish for the runtime QMP
> protocol, and moving the QAPI IDL to a standard wouldn't remove all
> instances of a custom format from our tree.
Sorry, but "still using JSON" is not a critique that makes any sense.
99% of
Am 31.07.2020 um 17:07 hat Daniel P. Berrangé geschrieben:
> On Fri, Jul 31, 2020 at 02:55:34PM +0200, Markus Armbruster wrote:
> > Daniel P. Berrangé writes:
>
> > >> Some of the criticism there doesn't matter for our use case.
> > >
> > > Yeah, what matters is whether it can do the job we nee
* Paolo Bonzini (pbonz...@redhat.com) wrote:
> On 31/07/20 17:26, John Snow wrote:
> > I saw the critique that we still use JSON-ish for the runtime QMP
> > protocol, and moving the QAPI IDL to a standard wouldn't remove all
> > instances of a custom format from our tree.
>
> Sorry, but "still usi
On 7/22/20 2:16 AM, frank.ch...@sifive.com wrote:
> # Vector ordered and unordered reduction sum
> -vfredsum_vs -1 . . . 001 . 1010111 @r_vm
> +vfredsum_vs 01 . . . 001 . 1010111 @r_vm
> +vfredosum_vs11 . . . 001 . 1010111 @r_vm
"The vfr
On 7/31/2020 5:06 AM, Daniel P. Berrangé wrote:
> On Thu, Jul 30, 2020 at 08:14:28AM -0700, Steve Sistare wrote:
>> From: Mark Kanda
>>
>> Iterate through the VNC displays and save/restore the socket fds.
>
> This patch doesn't appear to do anything around the client state, so I
> can't see how t
On 7/22/20 2:16 AM, frank.ch...@sifive.com wrote:
> GEN_OPIVI_TRANS(vssrl_vi, IMM_ZX, vssrl_vx, opivx_check)
> -GEN_OPIVI_TRANS(vssra_vi, IMM_SX, vssra_vx, opivx_check)
> +GEN_OPIVI_TRANS(vssra_vi, IMM_ZX, vssra_vx, opivx_check)
>
I think both vssrl and vssra should use IMM_TRUNC_SEW.
r~
On 7/22/20 2:16 AM, frank.ch...@sifive.com wrote:
> From: Frank Chang
>
> Signed-off-by: Frank Chang
> ---
> target/riscv/helper.h | 22 ---
> target/riscv/insn32.decode | 7 -
> target/riscv/insn_trans/trans_rvv.inc.c | 9 --
> target/riscv/vector_helper.c
On 7/22/20 2:16 AM, frank.ch...@sifive.com wrote:
> From: Frank Chang
>
> Signed-off-by: Frank Chang
> ---
> target/riscv/helper.h | 6 --
> target/riscv/insn32.decode | 2 --
> target/riscv/insn_trans/trans_rvv.inc.c | 2 --
> target/riscv/vector_helper.c
On 7/22/20 2:16 AM, frank.ch...@sifive.com wrote:
> From: Frank Chang
>
> Signed-off-by: Frank Chang
> ---
> target/riscv/insn32.decode | 1 -
> target/riscv/insn_trans/trans_rvv.inc.c | 23 ---
> 2 files changed, 24 deletions(-)
Reviewed-by: Richard Henderson
On Fri, Jul 31, 2020 at 06:28:06PM +0200, Paolo Bonzini wrote:
> On 31/07/20 17:07, Daniel P. Berrangé wrote:
> > The QAPI JSON-but-not file format is a case where I think we should just
> > adopt a standard file format no matter what. A conversion will have some
> > short term work, but this is re
On 7/22/20 2:16 AM, frank.ch...@sifive.com wrote:
> From: Frank Chang
>
> Signed-off-by: Frank Chang
> ---
> target/riscv/helper.h | 6
> target/riscv/insn32.decode | 13 +---
> target/riscv/insn_trans/trans_rvv.inc.c | 43 +++--
> ta
On 31/07/20 19:05, Daniel P. Berrangé wrote:
> NB our files are not JSON documents, they are a concatenation of a list
> of JSON documents.
This is not something that editors generally have problems with.
> If you use javascript mode, then emacs will highlight all the javascript
> language keywo
On 7/22/20 2:16 AM, frank.ch...@sifive.com wrote:
> +DEF_HELPER_5(vfncvt_rod_f_f_w_h, void, ptr, ptr, ptr, env, i32)
> +DEF_HELPER_5(vfncvt_rod_f_f_w_w, void, ptr, ptr, ptr, env, i32)
> +DEF_HELPER_5(vfncvt_rtz_xu_f_w_b, void, ptr, ptr, ptr, env, i32)
> +DEF_HELPER_5(vfncvt_rtz_xu_f_w_h, void, ptr,
On 7/31/2020 11:52 AM, Daniel P. Berrangé wrote:
> On Fri, Jul 31, 2020 at 11:27:45AM -0400, Steven Sistare wrote:
>> On 7/31/2020 4:53 AM, Daniel P. Berrangé wrote:
>>> On Thu, Jul 30, 2020 at 02:48:44PM -0400, Steven Sistare wrote:
On 7/30/2020 12:52 PM, Daniel P. Berrangé wrote:
> On Th
On Fri, Jul 31, 2020 at 06:35:23PM +0200, Paolo Bonzini wrote:
> On 31/07/20 17:26, John Snow wrote:
> > I saw the critique that we still use JSON-ish for the runtime QMP
> > protocol, and moving the QAPI IDL to a standard wouldn't remove all
> > instances of a custom format from our tree.
>
> Sor
On 7/22/20 2:16 AM, frank.ch...@sifive.com wrote:
> +if (env->misa & RVV) {
> +/* TODO: support vlen other than 128, 256, 512 bits. */
> +const char *vector_xml_name = NULL;
> +switch (cpu->cfg.vlen) {
> +case 128:
> +vector_xml_name = "riscv-64bit-ve
On Fri, Jul 31, 2020 at 07:16:54PM +0200, Paolo Bonzini wrote:
> >>> Another example would be adopting a standard code style and using a
> >>> tool like clang-format to enforce this for entire of existing code
> >>> base and future contributions and throwing away our checkpatch.pl
> >>> which near
On 7/31/20 3:17 AM, Frank Chang wrote:
> On Fri, Jul 31, 2020 at 4:35 AM Richard Henderson
> I don't understand why there aren't more functions in this table. As far
> as I
> can see, the only NULLs should be at [*][0].
>
>
> As source EEW has to be 1/2, 1/4, 1/8 of SEW and the source
On Fri, Jul 31, 2020 at 08:51:26AM -0400, Robert Foley wrote:
> The new flag bql_interrupt, allows the CPUClass to
> determine if the BQL should be held during calls to
> cpu_exec_interrupt or do_interrupt.
>
> This is being added in preparation for changes in
> cpu_handle_interrupt, which will us
On 31/07/20 19:27, Daniel P. Berrangé wrote:
> You say "main feature", I say "biggest flaw" ;-P
>
> Doing checks on patches is the single worst thing about the way
> we do code style validation, at it means the bulk of committed code
> is never in compliance. The need to check patches is precisely
On 31/07/20 19:20, Daniel P. Berrangé wrote:
> It also means QMP isn't easily extensible. eg if we used
> HTTP as our base, then we'd get remote TLS support for free from
> whatever library we used.
... and we would lose events, unless we do something with HTTP/2 and
streaming responses. We would
On 7/31/20 12:35 PM, Paolo Bonzini wrote:
On 31/07/20 17:26, John Snow wrote:
I saw the critique that we still use JSON-ish for the runtime QMP
protocol, and moving the QAPI IDL to a standard wouldn't remove all
instances of a custom format from our tree.
Sorry, but "still using JSON" is not a
On 7/30/20 1:23 PM, Peter Maydell wrote:
> On Thu, 30 Jul 2020 at 21:06, Derrick McKee wrote:
>>
>> Hi Peter,
>>
>> I just got a SIGILL trying to execute a stg instruction with the QEMU
>> version later in this thread, but the same instruction works correctly on
>> the FVP. Are you sure that al
1 - 100 of 146 matches
Mail list logo
