Re: [BUG] vhost-vdpa: qemu-system-s390x crashes with second virtio-net-ccw device

2020-07-24 Thread Michael S. Tsirkin
On Fri, Jul 24, 2020 at 03:27:18PM +0200, Cornelia Huck wrote: > When I start qemu with a second virtio-net-ccw device (i.e. adding > -device virtio-net-ccw in addition to the autogenerated device), I get > a segfault. gdb points to > > #0 0x55d6ab52681d in virtio_net_get_config (vdev=, >

Re: [PATCH v3 06/16] accel/tcg: better handle memory constrained systems

2020-07-24 Thread Robert Foley
Reviewed-by: Robert Foley On Fri, 24 Jul 2020 at 02:49, Alex Bennée wrote: > > It turns out there are some 64 bit systems that have relatively low > amounts of physical memory available to them (typically CI system). > Even with swapping available a 1GB translation buffer that fills up > can pu

Re: [PATCH 0/4] error: Mechanical fixes & cleanups

2020-07-24 Thread Markus Armbruster
Markus Armbruster writes: > Markus Armbruster (4): > coccinelle/err-bad-newline: Fix for Python 3, and add patterns > error: Strip trailing '\n' from error string arguments (again) > error: Remove NULL checks on error_propagate() calls (again) > error: Use error_fatal to simplify obvious

[PULL 4/4] qapi/error: Check format string argument in error_*prepend()

2020-07-24 Thread Markus Armbruster
From: Philippe Mathieu-Daudé error_propagate_prepend() "behaves like error_prepend()", and error_prepend() uses "formatting @fmt, ... like printf()". error_prepend() checks its format string argument, but error_propagate_prepend() does not. Fix by addint the format attribute to error_propagate_pr

[PULL 1/4] coccinelle/err-bad-newline: Fix for Python 3, and add patterns

2020-07-24 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Message-Id: <20200722084048.1726105-2-arm...@redhat.com> Reviewed-by: Eric Blake --- scripts/coccinelle/err-bad-newline.cocci | 24 ++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/scripts/coccinelle/err-bad-newline.cocci b

[PULL 3/4] sd/milkymist-memcard: Fix format string

2020-07-24 Thread Markus Armbruster
From: Stefan Weil Fixes: b98e8d1230ff7023bb34ddeb7194424dfcbaf789 Signed-off-by: Stefan Weil Message-Id: <20200722204054.1400555-1...@weilnetz.de> Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Markus Armbruster Reviewed-by: Li Qiang [Commit message tweaked] Signed-off-by: Markus Armbruster

[PULL 0/4] Error reporting patches patches for 2020-07-24

2020-07-24 Thread Markus Armbruster
The following changes since commit 09e0cd773723219d21655587954da2769f64ba01: Merge remote-tracking branch 'remotes/alistair/tags/pull-riscv-to-apply-20200722-1' into staging (2020-07-23 19:00:42 +0100) are available in the Git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-error

[PULL 2/4] error: Strip trailing '\n' from error string arguments (again)

2020-07-24 Thread Markus Armbruster
Tracked down with scripts/coccinelle/err-bad-newline.cocci. Cc: Peter Xu Cc: David Gibson Signed-off-by: Markus Armbruster Message-Id: <20200722084048.1726105-3-arm...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé Acked-by: David Gibson Reviewed-by: Peter Xu --- hw/i386/intel_iommu.c |

Re: [PATCH-for-5.1] libvhost-user: Report descriptor index on panic

2020-07-24 Thread Stefan Hajnoczi
On Thu, Jul 23, 2020 at 07:19:35PM +0200, Philippe Mathieu-Daudé wrote: > We want to report the index of the descriptor, > not its pointer. > > Fixes: 7b2e5c65f4 ("contrib: add libvhost-user") > Signed-off-by: Philippe Mathieu-Daudé > --- > contrib/libvhost-user/libvhost-user.c | 4 ++-- > 1 fil

Re: [PATCH] linux-user: Use getcwd syscall directly

2020-07-24 Thread Laurent Vivier
Le 23/07/2020 à 12:27, Andreas Schwab a écrit : > The glibc getcwd function returns different errors than the getcwd > syscall, which triggers an assertion failure in the glibc getcwd function > when running under the emulation. > > Signed-off-by: Andreas Schwab > --- > linux-user/syscall.c | 9

[RFC PATCH 0/2] Add write-once and file-backed features to OTP

2020-07-24 Thread Green Wan
Add file-backed implementation to allow users to assign an OTP image file to machine. If '-boot otp-file=filename' is specified, OTP device uses otp image file instead of fuse array. In order to keep data up-to-date due to unexpected crash or CTRL+a-x, every read/write to OTP memory involves file

[RFC PATCH 2/2] hw/riscv: sifive_u: Add write-once protection.

2020-07-24 Thread Green Wan
Add array to store the 'written' status for all bit of OTP to block the write operation to the same bit. Ignore the control register offset from 0x0 to 0x38 of OTP memory mapping. Signed-off-by: Green Wan --- hw/riscv/sifive_u_otp.c | 34 ++--- include/hw/risc

Re: [RFC PATCH] s390x/pci: vfio-pci breakage with disabled mem enforcement

2020-07-24 Thread Niklas Schnelle
On 7/23/20 5:13 PM, Matthew Rosato wrote: > I noticed that after kernel commit abafbc55 'vfio-pci: Invalidate mmaps > and block MMIO access on disabled memory' vfio-pci via qemu on s390x > fails spectacularly, with errors in qemu like: > > qemu-system-s390x: vfio_region_read(0001:00:00.0:region

[RFC PATCH 1/2] hw/riscv: sifive_u: Add file-backed OTP. softmmu/vl: add otp-file to boot option

2020-07-24 Thread Green Wan
Add a file-backed implementation for OTP of sifive_u machine. Use '-boot otp-file=xxx' to enable it. Do file open, mmap and close for every OTP read/write in case keep the update-to-date snapshot of OTP. Signed-off-by: Green Wan --- hw/riscv/sifive_u_otp.c | 88 ++

Re: [PATCH v3 1/4] util: rename qemu_open() to qemu_open_old()

2020-07-24 Thread Eric Blake
On 7/24/20 8:25 AM, Daniel P. Berrangé wrote: We want to introduce a new version of qemu_open() that uses an Error object for reporting problems and make this it the preferred interface. Rename the existing method to release the namespace for the new impl. Signed-off-by: Daniel P. Berrangé ---

Re: [PATCH v1 5/6] hw/net/can: CTU CAN FD IP open hardware core emulation.

2020-07-24 Thread Pavel Pisa
Hello everybody, I have tested Linux kernel and driver build on big-endian system (MIPS MALTA) emulated on x86_64 host. qemu-system-mips -m 256 -M malta \ -kernel vmlinuz-malta \ -initrd ramdisk.cpio \ -append "root=/dev/ram console=ttyS0 nokaslr" \ -object can-bus,id=can

Re: [PATCH] tpm_emulator: Report an error if chardev is missing

2020-07-24 Thread Marc-André Lureau
On Fri, Jul 24, 2020 at 5:30 PM Stefan Berger wrote: > This patch fixes the odd error reporting when trying to send a file > descriptor to the TPM emulator if one has not passed a valid chardev. > > $ x86_64-softmmu/qemu-system-x86_64 -tpmdev emulator,id=tpm0 > qemu-system-x86_64: -tpmdev emulato

Re: [RFC PATCH] s390x/pci: vfio-pci breakage with disabled mem enforcement

2020-07-24 Thread Niklas Schnelle
On 7/24/20 11:46 AM, Niklas Schnelle wrote: > > > On 7/23/20 5:13 PM, Matthew Rosato wrote: >> I noticed that after kernel commit abafbc55 'vfio-pci: Invalidate mmaps >> and block MMIO access on disabled memory' vfio-pci via qemu on s390x >> fails spectacularly, with errors in qemu like: >> >>

Re: [PATCH] tpm_emulator: Report an error if chardev is missing

2020-07-24 Thread Markus Armbruster
Stefan Berger writes: > This patch fixes the odd error reporting when trying to send a file > descriptor to the TPM emulator if one has not passed a valid chardev. > > $ x86_64-softmmu/qemu-system-x86_64 -tpmdev emulator,id=tpm0 > qemu-system-x86_64: -tpmdev emulator,id=tpm0: tpm-emulator: Failed

Re: [PATCH v3 2/4] util: introduce qemu_open and qemu_create with error reporting

2020-07-24 Thread Eric Blake
On 7/24/20 8:25 AM, Daniel P. Berrangé wrote: This introduces two new helper metohds int qemu_open(const char *name, int flags, Error **errp); int qemu_create(const char *name, int flags, mode_t mode, Error **errp); Note that with this design we no longer require or even accept the O_CREA

Re: [PATCH v3 3/4] util: give a specific error message when O_DIRECT doesn't work

2020-07-24 Thread Eric Blake
On 7/24/20 8:25 AM, Daniel P. Berrangé wrote: A common error scenario is to tell QEMU to use O_DIRECT in combination with a filesystem that doesn't support it. To aid users to diagnosing their mistake we want to provide a clear error message when this happens. Signed-off-by: Daniel P. Berrangé

Re: [PULL 4/4] qapi/error: Check format string argument in error_*prepend()

2020-07-24 Thread Daniel P . Berrangé
On Fri, Jul 24, 2020 at 03:47:04PM +0200, Markus Armbruster wrote: > From: Philippe Mathieu-Daudé > > error_propagate_prepend() "behaves like error_prepend()", and > error_prepend() uses "formatting @fmt, ... like printf()". > error_prepend() checks its format string argument, but > error_propaga

Re: [PATCH v3 4/4] block: switch to use qemu_open/qemu_create for improved errors

2020-07-24 Thread Eric Blake
On 7/24/20 8:25 AM, Daniel P. Berrangé wrote: Currently at startup if using cache=none on a filesystem lacking O_DIRECT such as tmpfs, at startup QEMU prints qemu-system-x86_64: -drive file=/tmp/foo.img,cache=none: file system may not support O_DIRECT qemu-system-x86_64: -drive file=/tmp/foo.im

Re: Possible regression with VGA and resolutions in Windows 10?

2020-07-24 Thread Gerd Hoffmann
Hi, > The behavior is similar when setting a custom resolution with the xres > and yres parameters. Setting it the first time works fine and it is > shown along with the short list. Setting it to something different on > the next boot will not be recognized unless the display adapter is > uninst

Re: [PATCH] tpm_emulator: Report an error if chardev is missing

2020-07-24 Thread Stefan Berger
On 7/24/20 10:00 AM, Markus Armbruster wrote: Stefan Berger writes: This patch fixes the odd error reporting when trying to send a file descriptor to the TPM emulator if one has not passed a valid chardev. $ x86_64-softmmu/qemu-system-x86_64 -tpmdev emulator,id=tpm0 qemu-system-x86_64: -tpmde

Re: [PATCH for-5.1] hw: Only compile the usb-dwc2 controller if it is really needed

2020-07-24 Thread Gerd Hoffmann
On Wed, Jul 22, 2020 at 09:36:27PM -0700, Paul Zimmerman wrote: > Gerd, it's OK by me if you take Thomas's patch instead, I agree the > changelog is better. It also has a fixes tag. > > Reviewed-by: Paul Zimmerman Queued. Thanks, Gerd

[PATCH V2] tpm_emulator: Report an error if chardev is missing

2020-07-24 Thread Stefan Berger
This patch fixes the odd error reporting when trying to send a file descriptor to the TPM emulator if one has not passed a valid chardev. $ x86_64-softmmu/qemu-system-x86_64 -tpmdev emulator,id=tpm0 qemu-system-x86_64: -tpmdev emulator,id=tpm0: tpm-emulator: Failed to send CMD_SET_DATAFD: Success

Re: [RFC PATCH] s390x/pci: vfio-pci breakage with disabled mem enforcement

2020-07-24 Thread Niklas Schnelle
On 7/24/20 11:46 AM, Niklas Schnelle wrote: > > > On 7/23/20 5:13 PM, Matthew Rosato wrote: >> I noticed that after kernel commit abafbc55 'vfio-pci: Invalidate mmaps >> and block MMIO access on disabled memory' vfio-pci via qemu on s390x >> fails spectacularly, with errors in qemu like: >> >>

Re: [RFC PATCH 1/2] hw/riscv: sifive_u: Add file-backed OTP. softmmu/vl: add otp-file to boot option

2020-07-24 Thread Bin Meng
Hi Green, On Fri, Jul 24, 2020 at 5:51 PM Green Wan wrote: > > Add a file-backed implementation for OTP of sifive_u machine. Use > '-boot otp-file=xxx' to enable it. Do file open, mmap and close > for every OTP read/write in case keep the update-to-date snapshot > of OTP. > > Signed-off-by: Green

Re: [PATCH v3 1/4] util: rename qemu_open() to qemu_open_old()

2020-07-24 Thread Philippe Mathieu-Daudé
On 7/24/20 3:25 PM, Daniel P. Berrangé wrote: > We want to introduce a new version of qemu_open() that uses an Error > object for reporting problems and make this it the preferred interface. > Rename the existing method to release the namespace for the new impl. > > Signed-off-by: Daniel P. Berran

Re: [PATCH v3 4/4] block: switch to use qemu_open/qemu_create for improved errors

2020-07-24 Thread Daniel P . Berrangé
On Fri, Jul 24, 2020 at 09:10:00AM -0500, Eric Blake wrote: > On 7/24/20 8:25 AM, Daniel P. Berrangé wrote: > > Currently at startup if using cache=none on a filesystem lacking > > O_DIRECT such as tmpfs, at startup QEMU prints > > > > qemu-system-x86_64: -drive file=/tmp/foo.img,cache=none: file

Re: Possible regression with VGA and resolutions in Windows 10?

2020-07-24 Thread Daniel P . Berrangé
On Fri, Jul 24, 2020 at 04:10:32PM +0200, Gerd Hoffmann wrote: > Hi, > > > The behavior is similar when setting a custom resolution with the xres > > and yres parameters. Setting it the first time works fine and it is > > shown along with the short list. Setting it to something different on > >

[PATCH 0/3] Improve FreeBSD and macOS jobs in the Cirrus-CI

2020-07-24 Thread Thomas Huth
Our configure script does not enable -Werror on macOS and FreeBSD by default yet. That's bad in the CI, since we might miss compiler warnings and thus bugs this way. So after fixing a problem in the configure script in the first patch, we now turn on -Werror here in the second patch. The third patc

[PATCH 1/3] configure: Fix atomic64 test for --enable-werror on macOS

2020-07-24 Thread Thomas Huth
When using --enable-werror for the macOS builders in the Cirrus-CI, the atomic64 test is currently failing, and config.log shows a bunch of error messages like this: config-temp/qemu-conf.c:6:7: error: implicit declaration of function '__atomic_load_8' is invalid in C99 [-Werror,-Wimplicit-funct

[PATCH 3/3] cirrus.yml: Update the macOS jobs to Catalina

2020-07-24 Thread Thomas Huth
When looking at the CI jobs on cirrus-ci.com, it seems like the mojave-based images have been decomissioned a while ago already, since apparently all our jobs get automatically upgraded to catalina. So let's update our YML script accordingly to avoid confusion. Signed-off-by: Thomas Huth --- .ci

Re: [PATCH v3 2/4] util: introduce qemu_open and qemu_create with error reporting

2020-07-24 Thread Philippe Mathieu-Daudé
On 7/24/20 3:25 PM, Daniel P. Berrangé wrote: > This introduces two new helper metohds > > int qemu_open(const char *name, int flags, Error **errp); > int qemu_create(const char *name, int flags, mode_t mode, Error **errp); > > Note that with this design we no longer require or even accept th

[PATCH 2/3] cirrus.yml: Compile macOS and FreeBSD with -Werror

2020-07-24 Thread Thomas Huth
Compiler warnings currently go unnoticed in our FreeBSD and macOS builds, since -Werror is only enabled for Linux and MinGW builds by default. So let's enable them here now, too. For macOS, that unfortunately means that we have to disable the vnc-sasl feature, since this is marked as deprecated in

Re: [PATCH v3 4/4] block: switch to use qemu_open/qemu_create for improved errors

2020-07-24 Thread Philippe Mathieu-Daudé
On 7/24/20 3:25 PM, Daniel P. Berrangé wrote: > Currently at startup if using cache=none on a filesystem lacking > O_DIRECT such as tmpfs, at startup QEMU prints > > qemu-system-x86_64: -drive file=/tmp/foo.img,cache=none: file system may not > support O_DIRECT > qemu-system-x86_64: -drive file=/

[PATCH RFCv3 1/9] s390x: move setting of maximum ram size to machine init

2020-07-24 Thread David Hildenbrand
As we no longer fixup the maximum ram size in sclp code, let's move setting the maximum ram size to ccw_init()->s390_memory_init(), which now looks like a better fit. Signed-off-by: David Hildenbrand --- hw/s390x/s390-virtio-ccw.c | 19 --- hw/s390x/sclp.c| 15 +--

[PATCH RFCv3 0/9] s390x: initial support for virtio-mem

2020-07-24 Thread David Hildenbrand
This wires up the initial, basic version of virito-mem for s390x. General information about virtio-mem can be found at [1] and in QEMU commit [2]. Patch #5 contains a short example for s390x. virtio-mem for x86-64 Linux is part of v5.8-rc1. A branch with a s390x prototype can be found at: g...

[PATCH RFCv3 2/9] s390x/diag: no need to check for PGM_PRIVILEGED in diag308

2020-07-24 Thread David Hildenbrand
Whenever we reach this point via KVM or TCG, we already verified that we are running in the supervisor state. TCG checks this via IF_PRIV, KVM checks this directly in the diag instruction handler, before exiting to userspace. Acked-by: Janosch Frank Signed-off-by: David Hildenbrand --- target/

[PATCH RFCv3 8/9] s390x: implement virtio-mem-ccw

2020-07-24 Thread David Hildenbrand
Add a proper CCW proxy device, similar to the PCI variant. Signed-off-by: David Hildenbrand --- hw/s390x/virtio-ccw-mem.c | 167 ++ hw/s390x/virtio-ccw.h | 13 +++ 2 files changed, 180 insertions(+) create mode 100644 hw/s390x/virtio-ccw-mem.c diff --gi

[PATCH RFCv3 3/9] s390x: remove hypercall registration mechanism

2020-07-24 Thread David Hildenbrand
Nowadays, we only have a single machine type in QEMU, everything is based on virtio-ccw and the traditional virtio machine does no longer exist. No need to dynamically register diag500 handlers. Move the two existing handlers into diag500.c. Signed-off-by: David Hildenbrand --- hw/s390x/s390-vir

[PATCH RFCv3 7/9] s390x: prepare device memory address space

2020-07-24 Thread David Hildenbrand
Let's allocate the device memory information and setup the device memory address space. The RAM size returned via SCLP is not modified. Guest OSs which support memory devices (like virtio-mem) are expected to consult diag500(4). Signed-off-by: David Hildenbrand --- hw/s390x/s390-virtio-ccw.c

[PATCH RFCv3 4/9] s390x: prepare for more diag500 hypercalls

2020-07-24 Thread David Hildenbrand
Let's generalize, abstacting the virtio bits. diag500 is now a generic hypercall to handle QEMU/KVM specific things. Explicitly specify all already defined subcodes, including legacy ones (so we know what we can use for new hypercalls). While at it, move exception handling into the handler. We'll

[PATCH RFCv3 5/9] s390x: rename s390-virtio-hcall* to s390-hypercall*

2020-07-24 Thread David Hildenbrand
Let's make it clearer that we are talking about general QEMU/KVM-specific hypercalls. Signed-off-by: David Hildenbrand --- hw/s390x/Makefile.objs | 2 +- hw/s390x/{s390-virtio-hcall.c => s390-hypercall.c} | 2 +- hw/s390x/{s390-virtio-hcall.h => s390-hypercall.h} | 6

Re: [RFC PATCH] buildsys: Only build capstone if softmmu/user mode is enabled

2020-07-24 Thread Philippe Mathieu-Daudé
On 7/24/20 11:59 AM, Peter Maydell wrote: > On Fri, 24 Jul 2020 at 10:47, Philippe Mathieu-Daudé wrote: >> >> On 7/24/20 11:38 AM, Philippe Mathieu-Daudé wrote: >>> On 7/24/20 9:56 AM, Thomas Huth wrote: On 24/07/2020 09.16, Philippe Mathieu-Daudé wrote: > At least one of softmmu or user

[PATCH RFCv3 9/9] s390x: initial support for virtio-mem

2020-07-24 Thread David Hildenbrand
Let's wire up the initial, basic virtio-mem implementation in QEMU. It will have to see some important extensions (esp., resizeable allocations) before it can be considered production ready. Also, the focus on the Linux driver side is on memory hotplug, there are a lot of things optimize in the fut

[PATCH RFCv3 6/9] s390x/diag: subcode to query device memory region

2020-07-24 Thread David Hildenbrand
A guest OS that is aware of memory devices (placed into the device memory region located in guest physical address space) has to know at least the end address of the device memory region during boot, for example, to prepare the kernel virtual address space accordingly (e.g., select page table hiera

Re: [PATCH 2/3] cirrus.yml: Compile macOS and FreeBSD with -Werror

2020-07-24 Thread Daniel P . Berrangé
On Fri, Jul 24, 2020 at 04:32:19PM +0200, Thomas Huth wrote: > Compiler warnings currently go unnoticed in our FreeBSD and macOS builds, > since -Werror is only enabled for Linux and MinGW builds by default. So > let's enable them here now, too. > For macOS, that unfortunately means that we have to

[Bug 1888601] Re: QEMU v5.1.0-rc0/rc1 hang with nested virtualization

2020-07-24 Thread Simon Kaegi
:) Sorry a VSI is a virtual server instance e.g a VM vs. a bare metal server. I'm using IBM Cloud IKS which is a managed Kubernetes Service. I'm installing QEMU 5.1.x on the worker nodes. It is this instance of QEMU -- e.g. /opt/kata/bin/qemu-system-x86_64 -- that is hanging. The Kernel version at

[Bug 1888728] Re: Bare chroot in linux-user fails with pgb_reserved_va: Assertion `guest_base != 0' failed.

2020-07-24 Thread Alex Bennée
Could you point me to a tar.gz with your rootfs? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1888728 Title: Bare chroot in linux-user fails with pgb_reserved_va: Assertion `guest_base != 0' fai

Re: [BUG] vhost-vdpa: qemu-system-s390x crashes with second virtio-net-ccw device

2020-07-24 Thread Cornelia Huck
On Fri, 24 Jul 2020 09:30:58 -0400 "Michael S. Tsirkin" wrote: > On Fri, Jul 24, 2020 at 03:27:18PM +0200, Cornelia Huck wrote: > > When I start qemu with a second virtio-net-ccw device (i.e. adding > > -device virtio-net-ccw in addition to the autogenerated device), I get > > a segfault. gdb poi

Re: [PATCH 2/3] cirrus.yml: Compile macOS and FreeBSD with -Werror

2020-07-24 Thread Peter Maydell
On Fri, 24 Jul 2020 at 15:32, Thomas Huth wrote: > > Compiler warnings currently go unnoticed in our FreeBSD and macOS builds, > since -Werror is only enabled for Linux and MinGW builds by default. So > let's enable them here now, too. > For macOS, that unfortunately means that we have to disable

Re: [PATCH 1/3] configure: Fix atomic64 test for --enable-werror on macOS

2020-07-24 Thread Christian Schoenebeck
On Freitag, 24. Juli 2020 16:32:18 CEST Thomas Huth wrote: > When using --enable-werror for the macOS builders in the Cirrus-CI, > the atomic64 test is currently failing, and config.log shows a bunch > of error messages like this: > > config-temp/qemu-conf.c:6:7: error: implicit declaration of fu

Re: [PATCH v3 01/21] qemu-iotests/199: fix style

2020-07-24 Thread Eric Blake
On 7/24/20 3:43 AM, Vladimir Sementsov-Ogievskiy wrote: Mostly, satisfy pep8 complains. complaints I can touch that up while staging. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Andrey Shinkevich Tested-by: Eric Blake --- tests/qemu-iotests/199 | 13 +++-- 1 file

Re: [PATCH v4 3/8] s390/sclp: rework sclp boundary and length checks

2020-07-24 Thread Collin Walling
On 7/23/20 2:26 AM, Cornelia Huck wrote: > On Tue, 21 Jul 2020 14:40:14 -0400 > Collin Walling wrote: > >> On 7/21/20 4:41 AM, David Hildenbrand wrote: > >>> The options I would support are >>> >>> 1. "sccb_boundary_is_valid" which returns "true" if valid >>> 2. "sccb_boundary_is_invalid" which

Re: [PULL 4/4] qapi/error: Check format string argument in error_*prepend()

2020-07-24 Thread Philippe Mathieu-Daudé
On 7/24/20 4:08 PM, Daniel P. Berrangé wrote: > On Fri, Jul 24, 2020 at 03:47:04PM +0200, Markus Armbruster wrote: >> From: Philippe Mathieu-Daudé >> >> error_propagate_prepend() "behaves like error_prepend()", and >> error_prepend() uses "formatting @fmt, ... like printf()". >> error_prepend() ch

Re: [PULL 0/1] x86 bug fix for -rc2

2020-07-24 Thread Peter Maydell
On Thu, 23 Jul 2020 at 20:14, Eduardo Habkost wrote: > > The following changes since commit 8ffa52c20d5693d454f65f2024a1494edfea65d4: > > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging > (2020-07-23 13:38:21 +0100) > > are available in the Git repository at: > > git

Re: [BUG] vhost-vdpa: qemu-system-s390x crashes with second virtio-net-ccw device

2020-07-24 Thread Michael S. Tsirkin
On Fri, Jul 24, 2020 at 04:56:27PM +0200, Cornelia Huck wrote: > On Fri, 24 Jul 2020 09:30:58 -0400 > "Michael S. Tsirkin" wrote: > > > On Fri, Jul 24, 2020 at 03:27:18PM +0200, Cornelia Huck wrote: > > > When I start qemu with a second virtio-net-ccw device (i.e. adding > > > -device virtio-net-

[Bug 1888728] Re: Bare chroot in linux-user fails with pgb_reserved_va: Assertion `guest_base != 0' failed.

2020-07-24 Thread John Paul Adrian Glaubitz
Here you go: https://people.debian.org/~glaubitz/sid-m68k-sbuild.tgz Thanks for looking into it! -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1888728 Title: Bare chroot in linux-user fails with p

Re: [BUG] vhost-vdpa: qemu-system-s390x crashes with second virtio-net-ccw device

2020-07-24 Thread Cornelia Huck
On Fri, 24 Jul 2020 11:17:57 -0400 "Michael S. Tsirkin" wrote: > On Fri, Jul 24, 2020 at 04:56:27PM +0200, Cornelia Huck wrote: > > On Fri, 24 Jul 2020 09:30:58 -0400 > > "Michael S. Tsirkin" wrote: > > > > > On Fri, Jul 24, 2020 at 03:27:18PM +0200, Cornelia Huck wrote: > > > > When I star

Re: Possible regression with VGA and resolutions in Windows 10?

2020-07-24 Thread Gerd Hoffmann
On Fri, Jul 24, 2020 at 03:31:23PM +0100, Daniel P. Berrangé wrote: > On Fri, Jul 24, 2020 at 04:10:32PM +0200, Gerd Hoffmann wrote: > > Hi, > > > > > The behavior is similar when setting a custom resolution with the xres > > > and yres parameters. Setting it the first time works fine and it is

Re: [PATCH V2] tpm_emulator: Report an error if chardev is missing

2020-07-24 Thread Marc-André Lureau
Hi On Fri, Jul 24, 2020 at 6:16 PM Stefan Berger wrote: > This patch fixes the odd error reporting when trying to send a file > descriptor to the TPM emulator if one has not passed a valid chardev. > > $ x86_64-softmmu/qemu-system-x86_64 -tpmdev emulator,id=tpm0 > qemu-system-x86_64: -tpmdev emu

Re: [PATCH v3 07/21] migration/block-dirty-bitmap: fix dirty_bitmap_mig_before_vm_start

2020-07-24 Thread Eric Blake
On 7/24/20 3:43 AM, Vladimir Sementsov-Ogievskiy wrote: No reason to use _locked version of bdrv_enable_dirty_bitmap, as we don't lock this mutex before. Moreover, the adjacent bdrv_dirty_bitmap_enable_successor do lock the mutex. Grammar suggestion: Using the _locked version of bdrv_enable_di

Re: [PATCH v7 37/47] qemu-img: Use child access functions

2020-07-24 Thread Andrey Shinkevich
On 25.06.2020 18:22, Max Reitz wrote: This changes iotest 204's output, because blkdebug on top of a COW node used to make qemu-img map disregard the rest of the backing chain (the backing chain was broken by the filter). With this patch, the allocation in the base image is reported correctly.

Re: [PATCH v2] gitlab-ci: Fix Avocado cache usage

2020-07-24 Thread Wainer dos Santos Moschetta
Hi Philippe, On 7/24/20 4:42 AM, Philippe Mathieu-Daudé wrote: In commit 6957fd98dc ("gitlab: add avocado asset caching") we tried to save the Avocado cache (as in commit c1073e44b4 with Travis-CI) however it doesn't work as expected. For some reason Avocado uses /root/avocado_cache/ which we ca

Re: [PATCH v7 38/47] block: Drop backing_bs()

2020-07-24 Thread Andrey Shinkevich
On 25.06.2020 18:22, Max Reitz wrote: We want to make it explicit where bs->backing is used, and we have done so. The old role of backing_bs() is now effectively taken by bdrv_cow_bs(). Signed-off-by: Max Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy --- include/block/block_int.h | 5

[Bug 1888601] Re: QEMU v5.1.0-rc0/rc1 hang with nested virtualization

2020-07-24 Thread Simon Kaegi
It hangs (still guessing here) immediately -- before anything is logged. I'll try to get you a calltrace but have to figure out how to do that first ;) Any pointers appreciated. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://

Re: [PATCH v3 13/21] migration/block-dirty-bitmap: simplify dirty_bitmap_load_complete

2020-07-24 Thread Eric Blake
On 7/24/20 3:43 AM, Vladimir Sementsov-Ogievskiy wrote: bdrv_enable_dirty_bitmap_locked() call does nothing, as if we are in postcopy, bitmap successor must be enabled, and reclaim operation will enable the bitmap. So, actually we need just call _reclaim_ in both if branches, and making differen

Re: [ipxe-devel] https booting

2020-07-24 Thread Michael Brown
On 22/07/2020 15:13, Daniel P. Berrangé wrote: We could easily define etc/ipxe/https/{ciphers,cacerts} paths in a different format if better suited for iPXE. Libvirt can set the right path depending on whether its booting a VM with EDK2 vs legacy BIOS The most useful for iPXE would probably be

QEMU | Pipeline #170508500 has failed for master | 7adfbea8

2020-07-24 Thread GitLab via
Your pipeline has failed. Project: QEMU ( https://gitlab.com/qemu-project/qemu ) Branch: master ( https://gitlab.com/qemu-project/qemu/-/commits/master ) Commit: 7adfbea8 ( https://gitlab.com/qemu-project/qemu/-/commit/7adfbea8fd1efce36019a0c2f198ca73be9d3f18 ) Commit Message: Merge remote-tr

Re: [PATCH v0 0/4] background snapshot

2020-07-24 Thread Peter Xu
On Fri, Jul 24, 2020 at 11:06:17AM +0300, Denis Plotnikov wrote: > > > On 23.07.2020 20:39, Peter Xu wrote: > > On Thu, Jul 23, 2020 at 11:03:55AM +0300, Denis Plotnikov wrote: > > > > > > On 22.07.2020 19:30, Peter Xu wrote: > > > > On Wed, Jul 22, 2020 at 06:47:44PM +0300, Denis Plotnikov wrot

Re: [PATCH 1/1] python/machine: Change default timeout to 30 seconds

2020-07-24 Thread John Snow
On 7/20/20 4:20 PM, Eduardo Habkost wrote: On Mon, Jul 20, 2020 at 12:02:52PM -0400, John Snow wrote: 3 seconds is too short for some tests running inside busy VMs. Build it out to a rather generous 30 seconds to find out conclusively if there are more severe problems in the merge/CI tests. Sig

[PATCH 3/3] target/arm: Improve IMPDEF algorithm for IRG

2020-07-24 Thread Richard Henderson
When GCR_EL1.RRND==1, the choosing of the random value is IMPDEF, and the kernel is not expected to have set RGSR_EL1. Force a non-zero value into SEED, so that we do not continually return the same tag. Reported-by: Vincenzo Frascino Signed-off-by: Richard Henderson --- target/arm/mte_helper.

[PATCH 1/3] hw/arm/boot: Fix PAUTH for EL3 direct kernel boot

2020-07-24 Thread Richard Henderson
When booting an EL3 cpu with -kernel, we set up EL3 and then drop down to EL2. We need to enable access to v8.3-PAuth keys and instructions at EL3 before doing so. Signed-off-by: Richard Henderson --- hw/arm/boot.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/arm/boot.c b/hw/arm/bo

Re: [PATCH v2] gitlab-ci: Fix Avocado cache usage

2020-07-24 Thread Philippe Mathieu-Daudé
On 7/24/20 5:52 PM, Wainer dos Santos Moschetta wrote: > Hi Philippe, > > On 7/24/20 4:42 AM, Philippe Mathieu-Daudé wrote: >> In commit 6957fd98dc ("gitlab: add avocado asset caching") we >> tried to save the Avocado cache (as in commit c1073e44b4 with >> Travis-CI) however it doesn't work as exp

[PATCH for-5.1 0/3] target/arm: mte+pauth fixes

2020-07-24 Thread Richard Henderson
A couple of last minute fixes for MTE: (1) Peter pointed out that EL3's SCR.ATA needs to be set when we're booting a kernel directly. Similarly for API & APK. (2) Vincenzo pointed out that with RRND=1, we can't rely on RGSR having being initialized. I suppose the only follow-on

[PATCH 2/3] hw/arm/boot: Fix MTE for EL3 direct kernel boot

2020-07-24 Thread Richard Henderson
When booting an EL3 cpu with -kernel, we set up EL3 and then drop down to EL2. We need to enable access to v8.5-MemTag tag allocation at EL3 before doing so. Reported-by: Peter Maydell Signed-off-by: Richard Henderson --- hw/arm/boot.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/

[PULL 1/3] hw: Only compile the usb-dwc2 controller if it is really needed

2020-07-24 Thread Gerd Hoffmann
From: Thomas Huth The USB_DWC2 switch is currently "default y", so it is included in all qemu-system-* builds, even if it is not needed. Even worse, it does a "select USB", so USB devices are now showing up as available on targets that do not support USB at all. This sysbus device should only be

[PULL 3/3] configure: Allow to build tools without pixman

2020-07-24 Thread Gerd Hoffmann
From: Thomas Huth If pixman is not installed, it is currently not possible to run: .../configure --disable-system --enable-tools Seems like there was a dependency from one of the required source files to pixman in the past, but since commit 1ac0206b2ae1ffaeec56 ("qemu-timer.c: Trim list of in

[PULL 2/3] hw/input/virtio-input-hid.c: Don't undef CONFIG_CURSES

2020-07-24 Thread Gerd Hoffmann
From: Peter Maydell virtio-input-hid.c undefines CONFIG_CURSES before including ui/console.h. However since commits e2f82e924d057935 and b0766612d16da18 that header does not have behaviour dependent on CONFIG_CURSES. Remove the now-unneeded undef. Signed-off-by: Peter Maydell Reviewed-by: Thoma

[PULL 0/3] Fixes 20200724 patches

2020-07-24 Thread Gerd Hoffmann
The following changes since commit 09e0cd773723219d21655587954da2769f64ba01: Merge remote-tracking branch 'remotes/alistair/tags/pull-riscv-to-apply-20200722-1' into staging (2020-07-23 19:00:42 +0100) are available in the Git repository at: git://git.kraxel.org/qemu tags/fixe

Re: [PATCH 2/3] cirrus.yml: Compile macOS and FreeBSD with -Werror

2020-07-24 Thread Philippe Mathieu-Daudé
On 7/24/20 4:46 PM, Daniel P. Berrangé wrote: > On Fri, Jul 24, 2020 at 04:32:19PM +0200, Thomas Huth wrote: >> Compiler warnings currently go unnoticed in our FreeBSD and macOS builds, >> since -Werror is only enabled for Linux and MinGW builds by default. So >> let's enable them here now, too. >>

Re: [PATCH 2/3] cirrus.yml: Compile macOS and FreeBSD with -Werror

2020-07-24 Thread Daniel P . Berrangé
On Fri, Jul 24, 2020 at 06:46:23PM +0200, Philippe Mathieu-Daudé wrote: > On 7/24/20 4:46 PM, Daniel P. Berrangé wrote: > > On Fri, Jul 24, 2020 at 04:32:19PM +0200, Thomas Huth wrote: > >> Compiler warnings currently go unnoticed in our FreeBSD and macOS builds, > >> since -Werror is only enabled

Re: [PATCH 2/3] cirrus.yml: Compile macOS and FreeBSD with -Werror

2020-07-24 Thread Peter Maydell
On Fri, 24 Jul 2020 at 17:46, Philippe Mathieu-Daudé wrote: > I guess we were expecting the distrib to update the pkg. Apple's view is that you shouldn't be using the sasl header at all but instead their proprietary crypto library APIs, so I wouldn't expect them to ever ship something without the

Re: [PATCH 1/3] scripts/qmp/qom-fuse: Unbreak import of QEMUMonitorProtocol

2020-07-24 Thread John Snow
On 7/23/20 10:27 AM, Markus Armbruster wrote: Commit c7b942d7f8 "scripts/qmp: Fix shebang and imports" messed with it for reasons I don't quite understand. I do understand how it fails now: it neglects to import sys. Fix that. Apologies. These scripts didn't appear to work because they don't

Re: [PATCH 0/3] scripts/qmp/qom-fuse: Scrape off the bitrot

2020-07-24 Thread John Snow
On 7/23/20 11:21 AM, Thomas Huth wrote: On 23/07/2020 16.27, Markus Armbruster wrote: Markus Armbruster (3): scripts/qmp/qom-fuse: Unbreak import of QEMUMonitorProtocol scripts/qmp/qom-fuse: Port to current Python module fuse scripts/qmp/qom-fuse: Fix getattr(), read() for files in /

[PATCH-for-5.2] default-configs: Remove ACPI_CPU_HOTPLUG from MIPS machines

2020-07-24 Thread Philippe Mathieu-Daudé
No MIPS machine uses the ACPI cpu-hotplug feature (QEMU implementation is X86 specific). Fixes: 135a67a692 ("ACPI: split CONFIG_ACPI into 4 pieces") Signed-off-by: Philippe Mathieu-Daudé --- default-configs/mips-softmmu-common.mak | 1 - 1 file changed, 1 deletion(-) diff --git a/default-config

Re: [PATCH 2/3] scripts/qmp/qom-fuse: Port to current Python module fuse

2020-07-24 Thread John Snow
On 7/23/20 10:27 AM, Markus Armbruster wrote: Signed-off-by: Markus Armbruster Honestly, benefit of the doubt on this one. The Python looks fine, but I don't know much about the FUSE module. Still, it was broken before, so if you claim it now works for you, that's more useful than it used to

Re: [PATCH v7 12/21] multi-process: Connect Proxy Object with device in the remote process

2020-07-24 Thread Jag Raman
> On Jul 1, 2020, at 5:20 AM, Stefan Hajnoczi wrote: > > On Sat, Jun 27, 2020 at 10:09:34AM -0700, elena.ufimts...@oracle.com wrote: >> From: Jagannathan Raman >> >> Send a message to the remote process to connect PCI device with the >> corresponding Proxy object in QEMU > > I thought the p

Re: [PATCH 3/3] scripts/qmp/qom-fuse: Fix getattr(), read() for files in /

2020-07-24 Thread John Snow
On 7/23/20 10:27 AM, Markus Armbruster wrote: path, prop = "type".rsplit('/', 1) sets path to "", which doesn't work. Correct to "/". BOTD. If it works for you, that's good news. Reviewed-by: John Snow Signed-off-by: Markus Armbruster --- scripts/qmp/qom-fuse | 10 -- 1 file c

Re: [PATCH v2 3/4] build: Don't make object files for dtrace on macOS

2020-07-24 Thread Roman Bolshakov
On Fri, Jul 17, 2020 at 12:35:16PM +0300, Roman Bolshakov wrote: > dtrace on macOS uses unresolved symbols with a special prefix to define > probes [1], only headers should be generated for USDT (dtrace(1)). But > it doesn't support backwards compatible no-op -G flag [2] and implicit > build rules

Re: [PATCH v2 1/3] hw/i386: Initialize topo_ids from CpuInstanceProperties

2020-07-24 Thread Igor Mammedov
On Mon, 13 Jul 2020 14:30:29 -0500 Babu Moger wrote: > > -Original Message- > > From: Igor Mammedov > > Sent: Monday, July 13, 2020 12:32 PM > > To: Moger, Babu > > Cc: pbonz...@redhat.com; r...@twiddle.net; ehabk...@redhat.com; qemu- > > de...@nongnu.org > > Subject: Re: [PATCH v2 1/3]

Re: [PATCH 2/3] cirrus.yml: Compile macOS and FreeBSD with -Werror

2020-07-24 Thread Christian Schoenebeck
On Freitag, 24. Juli 2020 18:50:47 CEST Peter Maydell wrote: > On Fri, 24 Jul 2020 at 17:46, Philippe Mathieu-Daudé > wrote: > > I guess we were expecting the distrib to update the pkg. > > Apple's view is that you shouldn't be using the sasl header > at all but instead their proprietary crypto

Re: roms/seabios-hppa can't be built with gcc-10: -fno-ipa-sra

2020-07-24 Thread Helge Deller
On 22.07.20 21:11, Michael Tokarev wrote: > Switching to gcc-10 makes seabios-hppa unbuildable. > It fails at the final linking step with a lot of > missing references to memcpy & memcmp all over the > places. > > The notable difference between gcc-10 and previous > gcc is that ccode32flat.o does _

Re: [PATCH v3 15/21] migration/block-dirty-bitmap: relax error handling in incoming part

2020-07-24 Thread Eric Blake
On 7/24/20 3:43 AM, Vladimir Sementsov-Ogievskiy wrote: Bitmaps data is not critical, and we should not fail the migration (or use postcopy recovering) because of dirty-bitmaps migration failure. Instead we should just lose unfinished bitmaps. Still we have to report io stream violation errors,

Re: [PATCH v5 1/6] Update PowerPC AT_HWCAP2 definition

2020-07-24 Thread Richard Henderson
On 7/23/20 9:58 PM, Lijun Pan wrote: > Add PPC2_FEATURE2_ARCH_3_10 to the PowerPC AT_HWCAP2 definitions. > > Signed-off-by: Lijun Pan > --- Reviewed-by: Richard Henderson We should add the rest of the bits as well at some point. r~

Re: [PATCH v5 2/6] target/ppc: add vmulld to INDEX_op_mul_vec case

2020-07-24 Thread Richard Henderson
On 7/23/20 9:58 PM, Lijun Pan wrote: > Group vmuluwm and vmulld. Make vmulld-specific > changes since it belongs to new ISA 3.1. > > Signed-off-by: Lijun Pan > --- > v5: no change > v4: add missing changes, and split to 5/11, 6/11, 7/11 > v3: use tcg_gen_gvec_mul() > v2: fix coding style > us

Re: [PATCH v5 3/6] target/ppc: add vmulh{su}w instructions

2020-07-24 Thread Richard Henderson
On 7/23/20 9:58 PM, Lijun Pan wrote: > vmulhsw: Vector Multiply High Signed Word > vmulhuw: Vector Multiply High Unsigned Word > > Signed-off-by: Lijun Pan > --- > v4/v5: no change > Reviewed-by: Richard Henderson > v3: inline the helper_vmulh{su}w multiply directly instead of using macro > v2:

<    1   2   3   >