[Bug 1878043] Re: memcpy param-overlap in Slirp ip_stripoptions through e1000e

2020-07-17 Thread Dr. David Alan Gilbert
Committed in upstream libslirp: commit d620bac888923524f8b8407dbf35f6d2b3b7ddb2 (origin/lp1878043, lp1878043) Author: Dr. David Alan Gilbert Date: Fri Jul 17 18:17:41 2020 +0100 ip_stripoptions use memmove -- You received this bug notification because you are a member of qemu- devel-ml,

[Bug 1878255] Re: Assertion failure in bdrv_aio_cancel, through ide

2020-07-17 Thread Philippe Mathieu-Daudé
Proposed fix: https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg05595.html -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1878255 Title: Assertion failure in bdrv_aio_cancel, through ide Sta

Re: [PATCH v2] virtiofsd: Remove "norace" from cmdline help and docs

2020-07-17 Thread Dr. David Alan Gilbert
* Sergio Lopez (s...@redhat.com) wrote: > Commit 93bb3d8d4cda ("virtiofsd: remove symlink fallbacks") removed > the implementation of the "norace" option, so remove it from the > cmdline help and the documentation too. > > Signed-off-by: Sergio Lopez > Reviewed-by: Philippe Mathieu-Daudé > Revi

Re: [PATCH v1 4/5] util: add qemu_get_host_physmem utility function

2020-07-17 Thread Richard Henderson
On 7/17/20 7:24 AM, Christian Ehrhardt wrote: > > +size_t qemu_get_host_physmem(void) > > +{ > > +#ifdef _SC_PHYS_PAGES > > +    long pages = sysconf(_SC_PHYS_PAGES); > > +    if (pages > 0) { > > +        return pages * qemu_real_host_page_size; > > The Linux man page

Re: device compatibility interface for live migration with assigned devices

2020-07-17 Thread Dr. David Alan Gilbert
* Alex Williamson (alex.william...@redhat.com) wrote: > On Wed, 15 Jul 2020 16:20:41 +0800 > Yan Zhao wrote: > > > On Tue, Jul 14, 2020 at 02:59:48PM -0600, Alex Williamson wrote: > > > On Tue, 14 Jul 2020 18:19:46 +0100 > > > "Dr. David Alan Gilbert" wrote: > > > > > > > * Alex Williamson (a

Re: [PATCH] tcg/cpu-exec: precise single-stepping after an interrupt

2020-07-17 Thread Luc Michel
On 7/17/20 6:30 PM, Richard Henderson wrote: When single-stepping with a debugger attached to QEMU, and when an interrupt is raised, the debugger misses the first instruction after the interrupt. Buglink: https://bugs.launchpad.net/qemu/+bug/757702 Signed-off-by: Richard Henderson Reviewed-by

Re: [PATCH v1 4/5] util: add qemu_get_host_physmem utility function

2020-07-17 Thread Richard Henderson
On 7/17/20 3:51 AM, Alex Bennée wrote: > +size_t qemu_get_host_physmem(void) > +{ > +#ifdef _SC_PHYS_PAGES > +long pages = sysconf(_SC_PHYS_PAGES); > +if (pages > 0) { > +return pages * qemu_real_host_page_size; > +} > +#endif > +return 0; > +} Is it worth examining our own

[PULL for-5.1 2/3] tcg/cpu-exec: precise single-stepping after an exception

2020-07-17 Thread Richard Henderson
From: Luc Michel When single-stepping with a debugger attached to QEMU, and when an exception is raised, the debugger misses the first instruction after the exception: $ qemu-system-aarch64 -M virt -display none -cpu cortex-a53 -s -S $ aarch64-linux-gnu-gdb GNU gdb (GDB) 9.2 [...] (gdb) tar rem

[PULL for-5.1 1/3] tcg: Save/restore vecop_list around minmax fallback

2020-07-17 Thread Richard Henderson
Forgetting this asserts when tcg_gen_cmp_vec is called from within tcg_gen_cmpsel_vec. Fixes: 72b4c792c7a Signed-off-by: Richard Henderson --- tcg/tcg-op-vec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tcg/tcg-op-vec.c b/tcg/tcg-op-vec.c index f784517d84..ed6fb55fe1 100644 --- a/tcg/

[PULL for-5.1 0/3] tcg patch queue

2020-07-17 Thread Richard Henderson
s/pull-tcg-20200717 for you to fetch changes up to ba3c35d9c4026361fd380b269dc6def9510b7166: tcg/cpu-exec: precise single-stepping after an interrupt (2020-07-17 11:09:34 -0700) Fix vector min/max fallback expansion Fix singl

[RFC PATCH-for-5.1] hw/pci-host/q35: Ignore write of reserved PCIEXBAR LENGTH field

2020-07-17 Thread Philippe Mathieu-Daudé
libFuzzer triggered the following assertion: cat << EOF | qemu-system-i386 -M pc-q35-5.0 \ -nographic -monitor none -serial none \ -qtest stdio -d guest_errors -trace pci\* outl 0xcf8 0xf260 outl 0xcfc 0x8400056e EOF pci_cfg_write mch 00:0 @0x60 <- 0x8400056e Aborted (core

[PULL for-5.1 3/3] tcg/cpu-exec: precise single-stepping after an interrupt

2020-07-17 Thread Richard Henderson
When single-stepping with a debugger attached to QEMU, and when an interrupt is raised, the debugger misses the first instruction after the interrupt. Tested-by: Luc Michel Reviewed-by: Luc Michel Buglink: https://bugs.launchpad.net/qemu/+bug/757702 Message-Id: <20200717163029.2737546-1-richard.

Re: [PATCH] target/i386: floatx80: avoid compound literals in static initializers

2020-07-17 Thread Philippe Mathieu-Daudé
On 7/17/20 6:46 PM, Laszlo Ersek wrote: > On 07/17/20 11:26, Laszlo Ersek wrote: >> On 07/16/20 17:09, Philippe Mathieu-Daudé wrote: >>> On 7/16/20 4:42 PM, Laszlo Ersek wrote: Quoting ISO C99 6.7.8p4, "All the expressions in an initializer for an object that has static storage duration s

Re: device compatibility interface for live migration with assigned devices

2020-07-17 Thread Alex Williamson
On Fri, 17 Jul 2020 19:03:44 +0100 "Dr. David Alan Gilbert" wrote: > * Alex Williamson (alex.william...@redhat.com) wrote: > > On Wed, 15 Jul 2020 16:20:41 +0800 > > Yan Zhao wrote: > > > > > On Tue, Jul 14, 2020 at 02:59:48PM -0600, Alex Williamson wrote: > > > > On Tue, 14 Jul 2020 18:19:

Re: [RFC PATCH-for-5.1] hw/pci-host/q35: Ignore write of reserved PCIEXBAR LENGTH field

2020-07-17 Thread Richard Henderson
On 7/17/20 11:17 AM, Philippe Mathieu-Daudé wrote: > case MCH_HOST_BRIDGE_PCIEXBAR_LENGTH_RVD: > -default: > -abort(); > +qemu_log_mask(LOG_GUEST_ERROR, "Q35: Reserved PCIEXBAR LENGTH\n"); > +return; > } Did you really want to remove the default case? I guess

Re: [PATCH v5 10/11] hw/arm: Wire up BMC boot flash for npcm750-evb and quanta-gsj

2020-07-17 Thread Havard Skinnemoen
On Fri, Jul 17, 2020 at 2:00 AM Philippe Mathieu-Daudé wrote: > > On 7/17/20 10:27 AM, Philippe Mathieu-Daudé wrote: > > On 7/17/20 10:03 AM, Thomas Huth wrote: > >> On 17/07/2020 09.48, Philippe Mathieu-Daudé wrote: > >>> +Thomas > >> > >>> On 7/16/20 10:56 PM, Havard Skinnemoen wrote: > On

Re: [RFC PATCH-for-5.1] hw/pci-host/q35: Ignore write of reserved PCIEXBAR LENGTH field

2020-07-17 Thread Philippe Mathieu-Daudé
On 7/17/20 8:38 PM, Richard Henderson wrote: > On 7/17/20 11:17 AM, Philippe Mathieu-Daudé wrote: >> case MCH_HOST_BRIDGE_PCIEXBAR_LENGTH_RVD: >> -default: >> -abort(); >> +qemu_log_mask(LOG_GUEST_ERROR, "Q35: Reserved PCIEXBAR LENGTH\n"); >> +return; >> } > >

[Bug 1878641] Re: Abort() in mch_update_pciexbar

2020-07-17 Thread Philippe Mathieu-Daudé
Proposed fix: https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg05612.html -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1878641 Title: Abort() in mch_update_pciexbar Status in QEMU: New

Re: [PATCH v1 1/5] shippable: add one more qemu to registry url

2020-07-17 Thread Philippe Mathieu-Daudé
On 7/17/20 12:51 PM, Alex Bennée wrote: > The registry url is //qemu/ > > Perhaps we should rationalise that some day but for now. > > Signed-off-by: Alex Bennée > --- > .shippable.yml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/.shippable.yml b/.shippable.yml > in

Re: [PATCH v5 10/11] hw/arm: Wire up BMC boot flash for npcm750-evb and quanta-gsj

2020-07-17 Thread Cédric Le Goater
On 7/17/20 9:18 PM, Havard Skinnemoen wrote: > On Fri, Jul 17, 2020 at 2:00 AM Philippe Mathieu-Daudé > wrote: >> >> On 7/17/20 10:27 AM, Philippe Mathieu-Daudé wrote: >>> On 7/17/20 10:03 AM, Thomas Huth wrote: On 17/07/2020 09.48, Philippe Mathieu-Daudé wrote: > +Thomas > On 7

Re: [PATCH v6 00/13] Add Nuvoton NPCM730/NPCM750 SoCs and two BMC machines

2020-07-17 Thread Cédric Le Goater
On 7/17/20 8:02 AM, Havard Skinnemoen wrote: > I also pushed this and the previous two patchsets to my qemu fork on github. > The branches are named npcm7xx-v[1-6]. > > https://github.com/hskinnemoen/qemu > > This patch series models enough of the Nuvoton NPCM730 and NPCM750 SoCs to > boot > a

[PATCH v1 0/3] python/qemu: follow-up changes for ConsoleSocket

2020-07-17 Thread Robert Foley
For v1, we added a few minor changes, and also added one new patch in tests/vm to add a shutdown timeout. This fixes an issue we saw in testing the aarch64 VMs with TCG. This patch series introduces a few follow-up changes after the introduction of ConsoleSocket. The first patch introduces cl

[PATCH v1 1/3] python/qemu: Cleanup changes to ConsoleSocket

2020-07-17 Thread Robert Foley
The changes to console_socket.py and machine.py are to cleanup for pylint and flake8. Reviewed-by: Alex Bennée Signed-off-by: Robert Foley --- python/qemu/console_socket.py | 57 ++- python/qemu/machine.py| 7 +++-- python/qemu/pylintrc | 2 +-

[PATCH v1 3/3] tests/vm: add shutdown timeout in basevm.py

2020-07-17 Thread Robert Foley
We are adding the shutdown timeout to solve an issue we now see where the aarch64 VMs timeout on shutdown under TCG. There is a new 3 second timeout in machine.py, which we override in basevm.py when shutting down. Signed-off-by: Robert Foley --- tests/vm/basevm.py | 15 ++- 1 file

[PATCH v1 2/3] python/qemu: Change ConsoleSocket to optionally drain socket.

2020-07-17 Thread Robert Foley
The primary purpose of this change is to clean up machine.py's console_socket property to return a single type, a ConsoleSocket. ConsoleSocket now derives from a socket, which means that in the default case (of not draining), machine.py will see the same behavior as it did prior to ConsoleSocket.

Re: [PATCH v5 10/11] hw/arm: Wire up BMC boot flash for npcm750-evb and quanta-gsj

2020-07-17 Thread Philippe Mathieu-Daudé
On 7/17/20 9:18 PM, Havard Skinnemoen wrote: > On Fri, Jul 17, 2020 at 2:00 AM Philippe Mathieu-Daudé > wrote: >> >> On 7/17/20 10:27 AM, Philippe Mathieu-Daudé wrote: >>> On 7/17/20 10:03 AM, Thomas Huth wrote: On 17/07/2020 09.48, Philippe Mathieu-Daudé wrote: > +Thomas > On 7

Re: [PATCH v5 10/11] hw/arm: Wire up BMC boot flash for npcm750-evb and quanta-gsj

2020-07-17 Thread Havard Skinnemoen
On Fri, Jul 17, 2020 at 1:52 PM Philippe Mathieu-Daudé wrote: > > On 7/17/20 9:18 PM, Havard Skinnemoen wrote: > > On Fri, Jul 17, 2020 at 2:00 AM Philippe Mathieu-Daudé > > wrote: > >> > >> On 7/17/20 10:27 AM, Philippe Mathieu-Daudé wrote: > >>> On 7/17/20 10:03 AM, Thomas Huth wrote: > O

[Bug 1880287] Re: gcc crashes in hppa emulation

2020-07-17 Thread Helge Deller
Test still crashes the VM and chroot with up-to-date debian chroot, including updated gcc-9.3.0-14. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1880287 Title: gcc crashes in hppa emulation Statu

Re: [PATCH-for-5.2] hw/vfio: Move some target-independent devices to common-objs

2020-07-17 Thread Alex Williamson
On Wed, 15 Jul 2020 15:13:22 +0200 Philippe Mathieu-Daudé wrote: > These devices do not depend on the target CPU configuration > (32 or 64-bit, big / little endian). Move them to common-obj > to compile them once for all the targets. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/vfio/Ma

Re: tests/vm infrastructure fails to notice that QEMU dying is a failure

2020-07-17 Thread John Snow
On 7/17/20 9:25 AM, Philippe Mathieu-Daudé wrote: On 7/17/20 3:22 PM, Philippe Mathieu-Daudé wrote: Cc'ing John & Cleber. On 7/17/20 3:08 PM, Peter Maydell wrote: If you run vm-build-openbsd, our makefile/scripting infrastructure seems to fail to notice that death of the QEMU process that's ru

[PATCH] goldfish_rtc: Fix non-atomic read behaviour of TIME_LOW/TIME_HIGH

2020-07-17 Thread Jessica Clarke
The specification says: 0x00 TIME_LOW R: Get current time, then return low-order 32-bits. 0x04 TIME_HIGH R: Return high 32-bits from previous TIME_LOW read. ... To read the value, the kernel must perform an IO_READ(TIME_LOW), which returns an unsigned 32-bit value, before an

Re: [PATCH] goldfish_rtc: Fix non-atomic read behaviour of TIME_LOW/TIME_HIGH

2020-07-17 Thread Richard Henderson
On 7/17/20 5:20 PM, Jessica Clarke wrote: > The specification says: > >0x00 TIME_LOW R: Get current time, then return low-order 32-bits. >0x04 TIME_HIGH R: Return high 32-bits from previous TIME_LOW read. > >... > >To read the value, the kernel must perform an IO_READ(TIME_L

[PATCH v2] goldfish_rtc: Fix non-atomic read behaviour of TIME_LOW/TIME_HIGH

2020-07-17 Thread Jessica Clarke
The specification says: 0x00 TIME_LOW R: Get current time, then return low-order 32-bits. 0x04 TIME_HIGH R: Return high 32-bits from previous TIME_LOW read. ... To read the value, the kernel must perform an IO_READ(TIME_LOW), which returns an unsigned 32-bit value, before an

Re: [PATCH v6 00/13] Add Nuvoton NPCM730/NPCM750 SoCs and two BMC machines

2020-07-17 Thread Havard Skinnemoen
On Fri, Jul 17, 2020 at 1:32 PM Cédric Le Goater wrote: > > On 7/17/20 8:02 AM, Havard Skinnemoen wrote: > > I also pushed this and the previous two patchsets to my qemu fork on github. > > The branches are named npcm7xx-v[1-6]. > > > > https://github.com/hskinnemoen/qemu > > > > This patch seri

Re: [PATCH v6 04/13] hw/arm: Add NPCM730 and NPCM750 SoC models

2020-07-17 Thread Philippe Mathieu-Daudé
On 7/17/20 6:59 PM, Havard Skinnemoen wrote: > +Markus Armbruster > > On Fri, Jul 17, 2020 at 5:20 AM Cédric Le Goater wrote: >> >> On 7/17/20 8:02 AM, Havard Skinnemoen wrote: >>> The Nuvoton NPCM7xx SoC family are used to implement Baseboard >>> Management Controllers in servers. While the fami

<    1   2   3