Re: [PATCH v10 06/10] qcow2_format.py: pass cluster size to substructures

2020-07-17 Thread Andrey Shinkevich
On 16.07.2020 12:26, Vladimir Sementsov-Ogievskiy wrote: 14.07.2020 00:36, Andrey Shinkevich wrote: The cluster size of an image is the QcowHeader class member and may be obtained by dependent extension structures such as Qcow2BitmapExt for further bitmap table details print. Signed-off-by: And

[PATCH] scripts/oss-fuzz: Limit target list to i386-softmmu

2020-07-17 Thread Thomas Huth
The build.sh script only copies qemu-fuzz-i386 to the destination folder, so we can speed up the compilation step quite a bit by not compiling the other targets here. Signed-off-by: Thomas Huth --- scripts/oss-fuzz/build.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scri

[RFC PATCH-for-5.1] hw/ide: Cancel pending DMA requests before setting as inactive

2020-07-17 Thread Philippe Mathieu-Daudé
libFuzzer found a case where requests are queued for later in the AIO context, but a command set the bus inactive, then when finally the requests are processed by the DMA it aborts because it is inactive: include/hw/ide/pci.h:59: IDEState *bmdma_active_if(BMDMAState *): Assertion `bmdma->bus->re

Re: [PATCH v5 10/11] hw/arm: Wire up BMC boot flash for npcm750-evb and quanta-gsj

2020-07-17 Thread Philippe Mathieu-Daudé
+Thomas On 7/16/20 10:56 PM, Havard Skinnemoen wrote: > On Wed, Jul 15, 2020 at 1:54 PM Havard Skinnemoen > wrote: >> >> On Wed, Jul 15, 2020 at 3:57 AM Philippe Mathieu-Daudé >> wrote: >>> >>> On 7/15/20 11:00 AM, Markus Armbruster wrote: Now my point. Why first make up user configuratio

Re: [PATCH] usb: only build hcd-dwc2 host controller for RASPI target

2020-07-17 Thread Philippe Mathieu-Daudé
On 7/17/20 3:05 AM, Paul Zimmerman wrote: > The hcd-dwc2 host controller is currently built for all targets. > Since for now hcd-dwc2 is only implemented on RASPI, restrict its > build to that target only. > > Signed-off-by: Paul Zimmerman > --- > > Hi Gerd, > > Do we want to apply this before

Re: [PATCH] gitlab-ci.yml: Add oss-fuzz build tests

2020-07-17 Thread Thomas Huth
On 17/07/2020 07.40, Thomas Huth wrote: > On 16/07/2020 18.33, Alexander Bulekov wrote: >> This tries to build and run the fuzzers with the same build-script used >> by oss-fuzz. This doesn't guarantee that the builds on oss-fuzz will >> also succeed, since oss-fuzz provides its own compiler and fu

Re: [RFC PATCH-for-5.1] hw/ide: Cancel pending DMA requests before setting as inactive

2020-07-17 Thread Philippe Mathieu-Daudé
On 7/17/20 9:47 AM, Philippe Mathieu-Daudé wrote: > libFuzzer found a case where requests are queued for later in the > AIO context, but a command set the bus inactive, then when finally > the requests are processed by the DMA it aborts because it is > inactive: > > include/hw/ide/pci.h:59: IDESt

[RFC PATCH-for-5.1 v2] hw/ide: Cancel pending DMA requests before setting as inactive

2020-07-17 Thread Philippe Mathieu-Daudé
libFuzzer found a case where requests are queued for later in the AIO context, but a command set the bus inactive, then when finally the requests are processed by the DMA it aborts because it is inactive: include/hw/ide/pci.h:59: IDEState *bmdma_active_if(BMDMAState *): Assertion `bmdma->bus->re

Re: [PATCH] scripts/oss-fuzz: Limit target list to i386-softmmu

2020-07-17 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200717073335.25534-1-th...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!

Re: [PATCH v6 01/13] hw/misc: Add NPCM7xx System Global Control Registers device model

2020-07-17 Thread Philippe Mathieu-Daudé
On 7/17/20 8:02 AM, Havard Skinnemoen wrote: > Implement a device model for the System Global Control Registers in the > NPCM730 and NPCM750 BMC SoCs. > > This is primarily used to enable SMP boot (the boot ROM spins reading > the SCRPAD register) and DDR memory initialization; other registers are

Re: [PATCH v5 10/11] hw/arm: Wire up BMC boot flash for npcm750-evb and quanta-gsj

2020-07-17 Thread Thomas Huth
On 17/07/2020 09.48, Philippe Mathieu-Daudé wrote: > +Thomas > On 7/16/20 10:56 PM, Havard Skinnemoen wrote: >> On Wed, Jul 15, 2020 at 1:54 PM Havard Skinnemoen >> wrote: >>> >>> On Wed, Jul 15, 2020 at 3:57 AM Philippe Mathieu-Daudé >>> wrote: On 7/15/20 11:00 AM, Markus Armbruster

Re: [PATCH v6 03/13] hw/timer: Add NPCM7xx Timer device model

2020-07-17 Thread Philippe Mathieu-Daudé
On 7/17/20 8:02 AM, Havard Skinnemoen wrote: > The NPCM730 and NPCM750 SoCs have three timer modules each holding five > timers and some shared registers (e.g. interrupt status). > > Each timer runs at 25 MHz divided by a prescaler, and counts down from a > configurable initial value to zero. When

Re: [PATCH v6 03/13] hw/timer: Add NPCM7xx Timer device model

2020-07-17 Thread Philippe Mathieu-Daudé
On 7/17/20 8:02 AM, Havard Skinnemoen wrote: > The NPCM730 and NPCM750 SoCs have three timer modules each holding five > timers and some shared registers (e.g. interrupt status). > > Each timer runs at 25 MHz divided by a prescaler, and counts down from a > configurable initial value to zero. When

[PATCH v11 10/11] qcow2_format.py: introduce Qcow2HeaderExtensionsDoc class

2020-07-17 Thread Andrey Shinkevich
Per original script design, QcowHeader class may dump the QCOW2 header info separately from the QCOW2 extensions info. To implement the to_dict() method for dumping extensions, let us introduce the class Qcow2HeaderExtensionsDoc. Signed-off-by: Andrey Shinkevich --- tests/qemu-iotests/qcow2_form

[PATCH v11 05/11] qcow2_format.py: Dump bitmap directory information

2020-07-17 Thread Andrey Shinkevich
Read and dump entries from the bitmap directory of QCOW2 image. Header extension: magic 0x23852875 (Bitmaps) ... Bitmap name bitmap-1 bitmap_table_offset 0xf bitmap_table_size 1 flags 0x2 (['auto']) type 1

[PATCH v11 00/11] iotests: Dump QCOW2 dirty bitmaps metadata

2020-07-17 Thread Andrey Shinkevich
Add dirty bitmap information to QCOW2 metadata dump in the qcow2_format.py. v10: 01: Fixing of issues in QCOW2 extension classes noted by Vladimir. 02: Reading bitmap tables was moved into Qcow2BitmapTable class. 03: Handling '-j' key was moved into "if __name__" section. 04: Making copy o

[PATCH v11 08/11] qcow2.py: Introduce '-j' key to dump in JSON format

2020-07-17 Thread Andrey Shinkevich
Add the command key to the qcow2.py arguments list to dump QCOW2 metadata in JSON format. Here is the suggested way to do that. The implementation of the dump in JSON format is in the patch that follows. Signed-off-by: Andrey Shinkevich --- tests/qemu-iotests/qcow2.py| 18 ++-

[PATCH v11 09/11] qcow2_format.py: collect fields to dump in JSON format

2020-07-17 Thread Andrey Shinkevich
As __dict__ is being extended with class members we do not want to print, add the to_dict() method to classes that returns a dictionary with desired fields and their values. Extend it in subclass when necessary to print the final dictionary in the JSON output which follows. Suggested-by: Vladimir

[PATCH v11 01/11] qcow2: Fix capitalization of header extension constant.

2020-07-17 Thread Andrey Shinkevich
Make the capitalization of the hexadecimal numbers consistent for the QCOW2 header extension constants in docs/interop/qcow2.txt. Suggested-by: Eric Blake Signed-off-by: Andrey Shinkevich Reviewed-by: Vladimir Sementsov-Ogievskiy --- block/qcow2.c | 2 +- docs/interop/qcow2.txt | 2 +-

[PATCH v11 02/11] qcow2_format.py: make printable data an extension class member

2020-07-17 Thread Andrey Shinkevich
Let us differ binary data type from string one for the extension data variable and keep the string as the QcowHeaderExtension class member. Signed-off-by: Andrey Shinkevich Reviewed-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/qcow2_format.py | 14 ---

[PATCH v11 06/11] qcow2_format.py: pass cluster size to substructures

2020-07-17 Thread Andrey Shinkevich
The cluster size of an image is the QcowHeader class member and may be obtained by dependent extension structures such as Qcow2BitmapExt for further bitmap table details print. Signed-off-by: Andrey Shinkevich Reviewed-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/qcow2_format.py | 17

[PATCH v11 07/11] qcow2_format.py: Dump bitmap table serialized entries

2020-07-17 Thread Andrey Shinkevich
Add bitmap table information to the QCOW2 metadata dump. Bitmap name bitmap-1 ... Bitmap table typeoffset size 0 serialized 4718592 65536 1 serialized 4294967296 65536 2 se

[PATCH v11 11/11] qcow2_format.py: support dumping metadata in JSON format

2020-07-17 Thread Andrey Shinkevich
Implementation of dumping QCOW2 image metadata. The sample output: { "Header_extensions": [ { "name": "Feature table", "magic": 1745090647, "length": 192, "data_str": "" }, { "name": "Bitmaps", "magi

[PATCH v11 04/11] qcow2_format.py: dump bitmap flags in human readable way.

2020-07-17 Thread Andrey Shinkevich
Introduce the class BitmapFlags that parses a bitmap flags mask. Suggested-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Andrey Shinkevich Reviewed-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/qcow2_format.py | 16 1 file changed, 16 insertions(+) diff --git a/te

[PATCH v11 03/11] qcow2_format.py: change Qcow2BitmapExt initialization method

2020-07-17 Thread Andrey Shinkevich
There are two ways to initialize a class derived from Qcow2Struct: 1. Pass a block of binary data to the constructor. 2. Pass the file descriptor to allow reading the file from constructor. Let's change the Qcow2BitmapExt initialization method from 1 to 2 to support a scattered reading in the initi

Re: [PATCH v5 10/11] hw/arm: Wire up BMC boot flash for npcm750-evb and quanta-gsj

2020-07-17 Thread Philippe Mathieu-Daudé
On 7/17/20 10:03 AM, Thomas Huth wrote: > On 17/07/2020 09.48, Philippe Mathieu-Daudé wrote: >> +Thomas > >> On 7/16/20 10:56 PM, Havard Skinnemoen wrote: >>> On Wed, Jul 15, 2020 at 1:54 PM Havard Skinnemoen >>> wrote: On Wed, Jul 15, 2020 at 3:57 AM Philippe Mathieu-Daudé wrote

Re: [PATCH] gitlab-ci.yml: Add oss-fuzz build tests

2020-07-17 Thread Alex Bennée
Thomas Huth writes: > On 16/07/2020 18.33, Alexander Bulekov wrote: >> This tries to build and run the fuzzers with the same build-script used >> by oss-fuzz. This doesn't guarantee that the builds on oss-fuzz will >> also succeed, since oss-fuzz provides its own compiler and fuzzer vars, >> bu

[Bug 1887303] Re: Assertion failure in *bmdma_active_if `bmdma->bus->retry_unit != (uint8_t)-1' failed.

2020-07-17 Thread Philippe Mathieu-Daudé
Proposed fix: https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg05408.html -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1887303 Title: Assertion failure in *bmdma_active_if `bmdma->bus->ret

Re: Inter-VM device emulation (call on Mon 20th July 2020)

2020-07-17 Thread Nikos Dragazis
On 15/7/20 7:44 μ.μ., Alex Bennée wrote: Stefan Hajnoczi writes: On Wed, Jul 15, 2020 at 01:28:07PM +0200, Jan Kiszka wrote: On 15.07.20 13:23, Stefan Hajnoczi wrote: Let's have a call to figure out: 1. What is unique about these approaches and how do they overlap? 2. Can we focus developm

Re: [PATCH v5 10/11] hw/arm: Wire up BMC boot flash for npcm750-evb and quanta-gsj

2020-07-17 Thread Philippe Mathieu-Daudé
On 7/17/20 10:27 AM, Philippe Mathieu-Daudé wrote: > On 7/17/20 10:03 AM, Thomas Huth wrote: >> On 17/07/2020 09.48, Philippe Mathieu-Daudé wrote: >>> +Thomas >> >>> On 7/16/20 10:56 PM, Havard Skinnemoen wrote: On Wed, Jul 15, 2020 at 1:54 PM Havard Skinnemoen wrote: > > On Wed,

Re: [PATCH] net: check payload length limit for all frames

2020-07-17 Thread P J P
+-- On Fri, 17 Jul 2020, Jason Wang wrote --+ | Thanks but I don't see a direct relation between 64K limit and this | calltrace. Maybe you can elaborate more on this? The use-after-free is not function of the size per say; The reproducer given sends large(>64k) packets via loopback interface wit

Re: [PATCH] virtiofsd: Remove "norace" from cmdline help

2020-07-17 Thread Stefano Garzarella
On Thu, Jul 16, 2020 at 12:14:42PM +0200, Sergio Lopez wrote: > Commit 93bb3d8d4cda ("virtiofsd: remove symlink fallbacks") removed > the implementation of the "norace" option, so remove it from the > cmdline help too. > > Signed-off-by: Sergio Lopez > --- > tools/virtiofsd/helper.c | 2 -- > 1

[PATCH v1] migration: tls: unref creds after used

2020-07-17 Thread Zhenyu Ye
We add the reference of creds in migration_tls_get_creds(), but there was no place to unref it. So the OBJECT(creds) will never be freed and result in memory leak. Unref the creds after creating the tls-channel server/client. Signed-off-by: Zhenyu Ye --- migration/tls.c | 12 +--- 1 fi

Re: [PATCH] target/i386: floatx80: avoid compound literals in static initializers

2020-07-17 Thread Laszlo Ersek
On 07/16/20 17:09, Philippe Mathieu-Daudé wrote: > On 7/16/20 4:42 PM, Laszlo Ersek wrote: >> Quoting ISO C99 6.7.8p4, "All the expressions in an initializer for an >> object that has static storage duration shall be constant expressions or >> string literals". >> >> The compound literal produced b

Re: [PATCH] target/i386: floatx80: avoid compound literals in static initializers

2020-07-17 Thread Laszlo Ersek
On 07/16/20 18:31, Alex Bennée wrote: > > Laszlo Ersek writes: > >> Quoting ISO C99 6.7.8p4, "All the expressions in an initializer for an >> object that has static storage duration shall be constant expressions or >> string literals". >> >> The compound literal produced by the make_floatx80() m

[RFC v2 0/3] Enable virtio-fs on s390x

2020-07-17 Thread Marc Hartmayer
This RFC is about enabling virtio-fs on s390x. For that we need + some shim code (first patch), and we need + libvhost-user to deal with virtio endiannes for non-legacy virtio devices as mandated by the spec. libvhost-access.h is based on hw/virtio/virtio-access.h. How to use? For general i

[RFC v2 3/3] libvhost-user: fence legacy virtio devices

2020-07-17 Thread Marc Hartmayer
libvhost-user has no support for legacy virtio devices therefore let's fence them. Signed-off-by: Marc Hartmayer --- contrib/libvhost-user/libvhost-access.h | 10 ++ contrib/libvhost-user/libvhost-user.c | 6 ++ 2 files changed, 16 insertions(+) diff --git a/contrib/libvhost-user

[RFC v2 1/3] virtio: add vhost-user-fs-ccw device

2020-07-17 Thread Marc Hartmayer
From: Halil Pasic Wire up the CCW device for vhost-user-fs. Signed-off-by: Halil Pasic --- hw/s390x/Makefile.objs | 1 + hw/s390x/vhost-user-fs-ccw.c | 73 2 files changed, 74 insertions(+) create mode 100644 hw/s390x/vhost-user-fs-ccw.c diff --git

[RFC v2 2/3] libvhost-user: handle endianness as mandated by the spec

2020-07-17 Thread Marc Hartmayer
Since virtio existed even before it got standardized, the virtio standard defines the following types of virtio devices: + legacy device (pre-virtio 1.0) + non-legacy or VIRTIO 1.0 device + transitional device (which can act both as legacy and non-legacy) Virtio 1.0 defines the fields of the v

[PATCH v2 1/4] scripts/tracetool: Fix dtrace generation for macOS

2020-07-17 Thread Roman Bolshakov
dtrace USDT is fully supported since OS X 10.6. There are a few peculiarities compared to other dtrace flavors. 1. It doesn't accept empty files. 2. It doesn't recognize bool type but accepts C99 _Bool. 3. It converts int8_t * in probe points to char * in header files and introduces [-Wpointer-

[PATCH v2 0/4] Add dtrace support on macOS

2020-07-17 Thread Roman Bolshakov
Hi, This is a small series that enables dtrace tracing backend on macOS. Whether or not it should go to 5.1 is up to discretion of tracing maintainers. Thanks, Roman Changes since v1: - Fixed a typo ANSI C to C99, wrt to _Bool in the first patch. - Prevented a few [-Wpointer-sign] warnings by

[PATCH v2 4/4] net/colo: Match is-enabled probe to tracepoint

2020-07-17 Thread Roman Bolshakov
Build of QEMU with dtrace fails on macOS: LINKx86_64-softmmu/qemu-system-x86_64 error: probe colo_compare_miscompare doesn't exist error: Could not register probes ld: error creating dtrace DOF section for architecture x86_64 The reason of the error is explained by Adam Leventhal [1]: No

[PATCH v2 2/4] scripts/tracetool: Use void pointer for vcpu

2020-07-17 Thread Roman Bolshakov
dtrace on macOS complains that CPUState * is used for a few probes: dtrace: failed to compile script trace-dtrace-root.dtrace: line 130: syntax error near "CPUState" A comment in scripts/tracetool/__init__.py mentions that: We only want to allow standard C types or fixed sized integer typ

[PATCH v2 3/4] build: Don't make object files for dtrace on macOS

2020-07-17 Thread Roman Bolshakov
dtrace on macOS uses unresolved symbols with a special prefix to define probes [1], only headers should be generated for USDT (dtrace(1)). But it doesn't support backwards compatible no-op -G flag [2] and implicit build rules fail. 1. https://markmail.org/message/6grq2ygr5nwdwsnb 2. https://markma

Re: [PULL 0/6] x86 fixes for -rc1

2020-07-17 Thread Peter Maydell
On Thu, 16 Jul 2020 at 19:19, Eduardo Habkost wrote: > > The following changes since commit ee5128bb00f90dd301991d80d1db5224ce924c84: > > Merge remote-tracking branch 'remotes/jasowang/tags/net-pull-request' into > staging (2020-07-16 13:12:05 +0100) > > are available in the Git repository at:

[PULL 3/6] fuzz: Expect the cmdline in a freeable GString

2020-07-17 Thread Thomas Huth
From: Alexander Bulekov In the initial FuzzTarget, get_init_cmdline returned a char *. With this API, we had no guarantee about where the string came from. For example, i440fx-qtest-reboot-fuzz simply returned a pointer to a string literal, while the QOS-based targets build the arguments out in a

[PULL 0/6] Leak fixes for qtests + fuzzer CI

2020-07-17 Thread Thomas Huth
Hi Peter, the following changes since commit 95d1fbabae0cd44156ac4b96d512d143ca7dfd5e: Merge remote-tracking branch 'remotes/kraxel/tags/fixes-20200716-pull-request' into staging (2020-07-16 18:50:51 +0100) are available in the Git repository at: https://gitlab.com/huth/qemu.git tags/pul

[PULL 2/6] tests: qmp-cmd-test: fix memory leak

2020-07-17 Thread Thomas Huth
From: Li Qiang Properly free each test response to avoid memory leak and separate qtest_qmp() calls with spare lines, in a consistent manner. Fixes: 5b88849e7b9("tests/qmp-cmd-test: Add qmp/object-add-failure-modes") Reviewed-by: Eric Auger Signed-off-by: Li Qiang Message-Id: <20200715154117.1

[PULL 4/6] configure: Fix for running with --enable-werror on macOS

2020-07-17 Thread Thomas Huth
The configure script currently refuses to succeed when run on macOS with --enable-werror: ERROR: configure test passed without -Werror but failed with -Werror. The information in config.log indicates: config-temp/qemu-conf.c:3:55: error: control reaches end of non-void function [-Werror,-Wret

[PULL 1/6] qtest: bios-tables-test: fix a memory leak

2020-07-17 Thread Thomas Huth
From: Li Qiang Fixes: 5da7c35e25a("bios-tables-test: Add Q35/TPM-TIS test") Signed-off-by: Li Qiang Message-Id: <20200714153536.66060-1-liq...@163.com> Reviewed-by: Eric Auger Reviewed-by: Igor Mammedov Signed-off-by: Thomas Huth --- tests/qtest/bios-tables-test.c | 1 + 1 file changed, 1 in

[PULL 5/6] qom: Plug memory leak in "info qom-tree"

2020-07-17 Thread Thomas Huth
From: Markus Armbruster Commit e8c9e65816 "qom: Make "info qom-tree" show children sorted" created a memory leak, because I didn't realize object_get_canonical_path_component()'s value needs to be freed. Reproducer: $ qemu-system-x86_64 -nodefaults -display none -S -monitor stdio QEMU 5

[PULL 6/6] gitlab-ci.yml: Add fuzzer tests

2020-07-17 Thread Thomas Huth
So far we neither compile-tested nor run any of the new fuzzers in our CI, which led to some build failures of the fuzzer code in the past weeks. To avoid this problem, add a job to compile the fuzzer code and run some loops (which likely don't find any new bugs via fuzzing, but at least we know th

Re: [PATCH] net: check payload length limit for all frames

2020-07-17 Thread Li Qiang
P J P 于2020年7月17日周五 下午5:09写道: > > +-- On Fri, 17 Jul 2020, Jason Wang wrote --+ > | Thanks but I don't see a direct relation between 64K limit and this > | calltrace. Maybe you can elaborate more on this? > > The use-after-free is not function of the size per say; The reproducer given > sends larg

Re: [RFC PATCH-for-5.1 v2] hw/ide: Cancel pending DMA requests before setting as inactive

2020-07-17 Thread Philippe Mathieu-Daudé
On 7/17/20 9:53 AM, Philippe Mathieu-Daudé wrote: > libFuzzer found a case where requests are queued for later in the > AIO context, but a command set the bus inactive, then when finally > the requests are processed by the DMA it aborts because it is > inactive: > > include/hw/ide/pci.h:59: IDESt

Re: [RFC PATCH-for-5.1 v2] hw/ide: Cancel pending DMA requests before setting as inactive

2020-07-17 Thread Philippe Mathieu-Daudé
On 7/17/20 12:08 PM, Philippe Mathieu-Daudé wrote: > On 7/17/20 9:53 AM, Philippe Mathieu-Daudé wrote: >> libFuzzer found a case where requests are queued for later in the >> AIO context, but a command set the bus inactive, then when finally >> the requests are processed by the DMA it aborts becaus

Re: [PATCH] docs/s390x: fix vfio-ccw type

2020-07-17 Thread Eric Farman
On 7/16/20 10:50 AM, Cornelia Huck wrote: > Fix the type name in the mdevctl example. > > Signed-off-by: Cornelia Huck Yup, that is backwards. Reviewed-by: Eric Farman > --- > > I always seem to get this one wrong, and mdevctl does not complain until > it wants to start the device... > >

[RFC PATCH-for-5.1] hw/ide: Avoid #DIV/0! FPU exception by setting CD-ROM sector count

2020-07-17 Thread Philippe Mathieu-Daudé
libFuzzer found an undefined behavior (#DIV/0!) in ide_set_sector() when using a CD-ROM (reproducer available on the BugLink): UndefinedBehaviorSanitizer:DEADLYSIGNAL ==12163==ERROR: UndefinedBehaviorSanitizer: FPE on unknown address 0x5616279cffdc (pc 0x5616279cffdc bp 0x7ffcdaabae90 sp 0x7f

[PATCH v2] introduce VFIO-over-socket protocol specificaion

2020-07-17 Thread Thanos Makatos
This patch introduces the VFIO-over-socket protocol specification, which is designed to allow devices to be emulated outside QEMU, in a separate process. VFIO-over-socket reuses the existing VFIO defines, structs and concepts. It has been earlier discussed as an RFC in: "RFC: use VFIO over a UNIX

Re: [RFC v2 0/3] Enable virtio-fs on s390x

2020-07-17 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200717092929.19453-1-mhart...@linux.ibm.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20200717092929.19453-1-mhart...@linux.ibm.com Subject: [RFC v2 0/3] Enable virtio-fs o

Re: [RFC v2 0/3] Enable virtio-fs on s390x

2020-07-17 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200717092929.19453-1-mhart...@linux.ibm.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN

Re: [RFC PATCH-for-5.1] hw/ide: Avoid #DIV/0! FPU exception by setting CD-ROM sector count

2020-07-17 Thread Philippe Mathieu-Daudé
On 7/17/20 12:16 PM, Philippe Mathieu-Daudé wrote: > libFuzzer found an undefined behavior (#DIV/0!) in ide_set_sector() > when using a CD-ROM (reproducer available on the BugLink): > > UndefinedBehaviorSanitizer:DEADLYSIGNAL > ==12163==ERROR: UndefinedBehaviorSanitizer: FPE on unknown address

[PATCH v1 1/5] shippable: add one more qemu to registry url

2020-07-17 Thread Alex Bennée
The registry url is //qemu/ Perhaps we should rationalise that some day but for now. Signed-off-by: Alex Bennée --- .shippable.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.shippable.yml b/.shippable.yml index f6b742432e5..89d8be4291b 100644 --- a/.shippable.yml +++ b

Re: [GIT PULL] I2C updates

2020-07-17 Thread Peter Maydell
On Thu, 16 Jul 2020 at 23:26, Corey Minyard wrote: > > On Thu, Jul 16, 2020 at 09:45:41PM +0100, Peter Maydell wrote: > > Hi; this failed to build on x86-64 Linux (incremental build): > > Hmm, I did test this, and I just rebuilt, then rebased on the end of > master and rebuilt, without issue. > >

[PATCH v1 2/5] semihosting: defer connect_chardevs a little more to use serialx

2020-07-17 Thread Alex Bennée
From: KONRAD Frederic With that we can just use -semihosting-config chardev=serial0. Signed-off-by: KONRAD Frederic Message-Id: <1592215252-26742-1-git-send-email-frederic.kon...@adacore.com> [AJB: tweak commit message] Signed-off-by: Alex Bennée --- softmmu/vl.c | 5 +++-- 1 file changed, 3

[PATCH v1 4/5] util: add qemu_get_host_physmem utility function

2020-07-17 Thread Alex Bennée
This will be used in a future patch. For POSIX systems _SC_PHYS_PAGES isn't standardised but at least appears in the man pages for Open/FreeBSD. The result is advisory so any users of it shouldn't just fail if we can't work it out. The win32 stub currently returns 0 until someone with a Windows sy

[PATCH v1 0/5] candidate fixes for 5.1-rc1 (shippable, semihosting, OOM tcg)

2020-07-17 Thread Alex Bennée
Hi, These are some candidate patches for rc1. The first is a quick fix that finally gets shippable up and running again. We may want to consider a grand renaming of our docker scheme but I don't think thats something worth dropping in while we are stabilising - especially if we change the projec

[PATCH v1 5/5] accel/tcg: better handle memory constrained systems

2020-07-17 Thread Alex Bennée
It turns out there are some 64 bit systems that have relatively low amounts of physical memory available to them (typically CI system). Even with swapping available a 1GB translation buffer that fills up can put the machine under increased memory pressure. Detect these low memory situations and red

[PATCH for-5.1 0/3] file-posix: Fix check_hdev_writable() with auto-read-only

2020-07-17 Thread Kevin Wolf
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1828252 Kevin Wolf (3): file-posix: Move check_hdev_writable() up file-posix: Fix check_hdev_writable() with auto-read-only file-posix: Fix leaked fd in raw_open_common() error path block/file-posix.c | 96 ++---

[PATCH v1 3/5] semihosting: don't send the trailing '\0'

2020-07-17 Thread Alex Bennée
From: KONRAD Frederic Don't send the trailing 0 from the string. Signed-off-by: KONRAD Frederic Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Message-Id: <1592215252-26742-2-git-send-email-frederic.kon...@adacore.com> --- hw/semihosting/console.c | 4 +++- 1 file changed, 3

[PATCH for-5.1 1/3] file-posix: Move check_hdev_writable() up

2020-07-17 Thread Kevin Wolf
We'll need to call it in raw_open_common(), so move the function to avoid a forward declaration. Signed-off-by: Kevin Wolf --- block/file-posix.c | 66 +++--- 1 file changed, 33 insertions(+), 33 deletions(-) diff --git a/block/file-posix.c b/block/file-p

[PATCH for-5.1 3/3] file-posix: Fix leaked fd in raw_open_common() error path

2020-07-17 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- block/file-posix.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/block/file-posix.c b/block/file-posix.c index 659f780570..b2ed9d7eb2 100644 --- a/block/file-posix.c +++ b/block/file-posix.c @@ -749,6 +749,9 @@ static int raw_open_common(BlockDriverState *bs

[PATCH for-5.1 2/3] file-posix: Fix check_hdev_writable() with auto-read-only

2020-07-17 Thread Kevin Wolf
For Linux block devices, being able to open the device read-write doesn't necessarily mean that the device is actually writable (one example is a read-only LV, as you get with lvchange -pr ). We have check_hdev_writable() to check this condition and fail opening the image read-write if it's not act

Re: [RFC PATCH] tcg/cpu-exec: precise single-stepping after an exception

2020-07-17 Thread Luc Michel
On 7/16/20 11:08 PM, Richard Henderson wrote: > On 7/16/20 1:12 PM, Peter Maydell wrote: >> On Thu, 16 Jul 2020 at 11:08, Luc Michel wrote: >>> >>> When single-stepping with a debugger attached to QEMU, and when an >>> exception is raised, the debugger misses the first instruction after the >>>

Re: [PATCH for-5.1 v2 1/2] block: Require aligned image size to avoid assertion failure

2020-07-17 Thread Max Reitz
On 16.07.20 16:26, Kevin Wolf wrote: > Unaligned requests will automatically be aligned to bl.request_alignment > and we can't extend write requests to access space beyond the end of the > image without resizing the image, so if we have the WRITE permission, > but not the RESIZE one, it's required

Re: [PULL 28/53] Makefile: simplify MINIKCONF rules

2020-07-17 Thread Peter Maydell
On Mon, 6 Jul 2020 at 18:03, Paolo Bonzini wrote: > > There is no reason to write MINIKCONF_DEPS manually, since minikconf.py > emits a dependency file, and also no reason to list multiple Kconfig > files on the command line since they can be included from a master file > in the top-level source d

Re: [PATCH v2] introduce VFIO-over-socket protocol specificaion

2020-07-17 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1594981096-58580-1-git-send-email-thanos.maka...@nutanix.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1594981096-58580-1-git-send-email-thanos.maka...@nutanix.com Subject: [

Re: [PATCH for-5.1 v2 2/2] file-posix: Allow byte-aligned O_DIRECT with NFS

2020-07-17 Thread Max Reitz
On 16.07.20 16:26, Kevin Wolf wrote: > Since commit a6b257a08e3 ('file-posix: Handle undetectable alignment'), > we assume that if we open a file with O_DIRECT and alignment probing > returns 1, we just couldn't find out the real alignment requirement > because some filesystems make the requirement

Re: [PULL 28/53] Makefile: simplify MINIKCONF rules

2020-07-17 Thread Paolo Bonzini
Il ven 17 lug 2020, 13:03 Peter Maydell ha scritto: > On Mon, 6 Jul 2020 at 18:03, Paolo Bonzini wrote: > > > > There is no reason to write MINIKCONF_DEPS manually, since minikconf.py > > emits a dependency file, and also no reason to list multiple Kconfig > > files on the command line since the

[PATCH v3] introduce VFIO-over-socket protocol specificaion

2020-07-17 Thread Thanos Makatos
This patch introduces the VFIO-over-socket protocol specification, which is designed to allow devices to be emulated outside QEMU, in a separate process. VFIO-over-socket reuses the existing VFIO defines, structs and concepts. It has been earlier discussed as an RFC in: "RFC: use VFIO over a UNIX

Re: [GIT PULL] I2C updates

2020-07-17 Thread Philippe Mathieu-Daudé
On 7/17/20 12:50 PM, Peter Maydell wrote: > On Thu, 16 Jul 2020 at 23:26, Corey Minyard wrote: >> >> On Thu, Jul 16, 2020 at 09:45:41PM +0100, Peter Maydell wrote: >>> Hi; this failed to build on x86-64 Linux (incremental build): >> >> Hmm, I did test this, and I just rebuilt, then rebased on the

Re: [PATCH for-5.1 v2 1/2] block: Require aligned image size to avoid assertion failure

2020-07-17 Thread Kevin Wolf
Am 17.07.2020 um 13:02 hat Max Reitz geschrieben: > On 16.07.20 16:26, Kevin Wolf wrote: > > Unaligned requests will automatically be aligned to bl.request_alignment > > and we can't extend write requests to access space beyond the end of the > > image without resizing the image, so if we have the

Re: [PATCH for-5.1 v2 1/2] block: Require aligned image size to avoid assertion failure

2020-07-17 Thread Max Reitz
On 17.07.20 13:32, Kevin Wolf wrote: > Am 17.07.2020 um 13:02 hat Max Reitz geschrieben: >> On 16.07.20 16:26, Kevin Wolf wrote: >>> Unaligned requests will automatically be aligned to bl.request_alignment >>> and we can't extend write requests to access space beyond the end of the >>> image withou

Re: [PATCH] virtiofsd: Remove "norace" from cmdline help

2020-07-17 Thread Sergio Lopez
On Fri, Jul 17, 2020 at 11:14:14AM +0200, Stefano Garzarella wrote: > On Thu, Jul 16, 2020 at 12:14:42PM +0200, Sergio Lopez wrote: > > Commit 93bb3d8d4cda ("virtiofsd: remove symlink fallbacks") removed > > the implementation of the "norace" option, so remove it from the > > cmdline help too. > >

Re: [PATCH for-5.1 1/3] file-posix: Move check_hdev_writable() up

2020-07-17 Thread Max Reitz
On 17.07.20 12:54, Kevin Wolf wrote: > We'll need to call it in raw_open_common(), so move the function to > avoid a forward declaration. > > Signed-off-by: Kevin Wolf > --- > block/file-posix.c | 66 +++--- > 1 file changed, 33 insertions(+), 33 deletions

Re: [PATCH for-5.1 0/3] file-posix: Fix check_hdev_writable() with auto-read-only

2020-07-17 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200717105426.51134-1-kw...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!

Re: [PATCH for-5.1 2/3] file-posix: Fix check_hdev_writable() with auto-read-only

2020-07-17 Thread Max Reitz
On 17.07.20 12:54, Kevin Wolf wrote: > For Linux block devices, being able to open the device read-write > doesn't necessarily mean that the device is actually writable (one > example is a read-only LV, as you get with lvchange -pr ). We > have check_hdev_writable() to check this condition and fail

Re: [PATCH for-5.1 3/3] file-posix: Fix leaked fd in raw_open_common() error path

2020-07-17 Thread Max Reitz
On 17.07.20 12:54, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > block/file-posix.c | 3 +++ > 1 file changed, 3 insertions(+) Reviewed-by: Max Reitz signature.asc Description: OpenPGP digital signature

[Bug 1887854] Re: Spurious Data Abort on qemu-system-aarch64

2020-07-17 Thread K
I would have thought that TLB considerations would not apply when the MMU is disabled (RTEMS runs in a completely flat memory space). I'll try to reproduce on more modern QEMU today. Thanks for taking a look at this. -- You received this bug notification because you are a member of qemu- devel-ml

Re: [PATCH v3 for-5.1 0/2] Fix crash due to NBD export leak

2020-07-17 Thread Kevin Wolf
Am 14.07.2020 um 18:22 hat Vladimir Sementsov-Ogievskiy geschrieben: > Hi all! > > We've faced crash bug, which is reproducing on master branch as well. > The case is described in 01, where fix is suggested. > New iotest in 02 crashes without that fix. > > v3: resend for convenience, as all prepa

[PATCH v2] virtiofsd: Remove "norace" from cmdline help and docs

2020-07-17 Thread Sergio Lopez
Commit 93bb3d8d4cda ("virtiofsd: remove symlink fallbacks") removed the implementation of the "norace" option, so remove it from the cmdline help and the documentation too. Signed-off-by: Sergio Lopez Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Stefano Garzarella --- v2: * Drop "norace" f

Re: [PATCH] slirp: update to v4.3.1

2020-07-17 Thread Marc-André Lureau
Hi On Mon, Jul 13, 2020 at 12:33 PM Marc-André Lureau < marcandre.lur...@redhat.com> wrote: > Switch from stable-4.2 branch back to master (which is actually > maintained, I think we tend to forget about stable...). > > git shortlog 2faae0f7..a62d3673: > > 5eraph (2): > disable_dns option >

Re: [PATCH v6 07/13] hw/arm: Load -bios image as a boot ROM for npcm7xx

2020-07-17 Thread Cédric Le Goater
On 7/17/20 8:02 AM, Havard Skinnemoen wrote: > If a -bios option is specified on the command line, load the image into > the internal ROM memory region, which contains the first instructions > run by the CPU after reset. > > If -bios is not specified, the vbootrom included with qemu is loaded by >

Re: [PATCH] introduce VFIO-over-socket protocol specificaion

2020-07-17 Thread Stefan Hajnoczi
On Thu, Jul 16, 2020 at 08:31:43AM -0700, Thanos Makatos wrote: > This patch introduces the VFIO-over-socket protocol specification, which > is designed to allow devices to be emulated outside QEMU, in a separate > process. VFIO-over-socket reuses the existing VFIO defines, structs and > concepts.

Re: [PATCH v6 04/13] hw/arm: Add NPCM730 and NPCM750 SoC models

2020-07-17 Thread Cédric Le Goater
On 7/17/20 8:02 AM, Havard Skinnemoen wrote: > The Nuvoton NPCM7xx SoC family are used to implement Baseboard > Management Controllers in servers. While the family includes four SoCs, > this patch implements limited support for two of them: NPCM730 (targeted > for Data Center applications) and NPCM

Re: [PATCH v6 06/13] roms: Add virtual Boot ROM for NPCM7xx SoCs

2020-07-17 Thread Cédric Le Goater
On 7/17/20 8:02 AM, Havard Skinnemoen wrote: > This is a minimalistic boot ROM written specifically for use with QEMU. > It supports loading the second-stage loader from SPI flash into RAM, SMP > boot, and not much else. > > Signed-off-by: Havard Skinnemoen > --- > Makefile|

Re: [GIT PULL] I2C updates

2020-07-17 Thread Corey Minyard
On Fri, Jul 17, 2020 at 01:30:35PM +0200, Philippe Mathieu-Daudé wrote: > On 7/17/20 12:50 PM, Peter Maydell wrote: > > On Thu, 16 Jul 2020 at 23:26, Corey Minyard wrote: > >> > >> On Thu, Jul 16, 2020 at 09:45:41PM +0100, Peter Maydell wrote: > >>> Hi; this failed to build on x86-64 Linux (increm

Re: [PATCH v6 13/13] tests/acceptance: console boot tests for quanta-gsj

2020-07-17 Thread Cédric Le Goater
On 7/17/20 8:02 AM, Havard Skinnemoen wrote: > This adds two acceptance tests for the quanta-gsj machine. > > One test downloads a lightly patched openbmc flash image from github and > verifies that it boots all the way to the login prompt. > > The other test downloads a kernel, initrd and dtb bu

[Bug 1887854] Re: Spurious Data Abort on qemu-system-aarch64

2020-07-17 Thread Peter Maydell
It does still crash on current QEMU. The proximate cause of the crash is that you are trying to read from an address which is way outside RAM: Trace 0: 0x7f8d50054340 [/400195d8/0x82104000] strcmp PC=400195d8 X00=00104010ca28 X01=4001ec28 X02=00

[PULL 02/12] Remove VXHS block device

2020-07-17 Thread Kevin Wolf
From: Marc-André Lureau The vxhs code doesn't compile since v2.12.0. There's no point in fixing and then adding CI for a config that our users have demonstrated that they do not use; better to just remove it. Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster Message-Id: <20200711

[PULL 01/12] vvfat: set status to odd fixes

2020-07-17 Thread Kevin Wolf
From: Prasad J Pandit Virtual VFAT driver is quite old and rarely used. Set its status to Odd Fixes. Signed-off-by: Prasad J Pandit Message-Id: <20200710190451.761286-1-ppan...@redhat.com> Signed-off-by: Kevin Wolf --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

  1   2   3   >