Re: [virtio-dev] [RFC for Linux v4 0/2] virtio_balloon: Add VIRTIO_BALLOON_F_CONT_PAGES to report continuous pages

2020-07-16 Thread teawater
> 2020年7月16日 14:38,Michael S. Tsirkin 写道: > > On Thu, Jul 16, 2020 at 10:41:50AM +0800, Hui Zhu wrote: >> The first, second and third version are in [1], [2] and [3]. >> Code of current version for Linux and qemu is available in [4] and [5]. >> Update of this version: >> 1. Report continuous p

Re: [PATCH] configure: Fix for running with --enable-werror on macOS

2020-07-16 Thread Philippe Mathieu-Daudé
On 7/16/20 7:56 AM, Thomas Huth wrote: > The configure script currently refuses to succeed when run on macOS > with --enable-werror: > > ERROR: configure test passed without -Werror but failed with -Werror. > > The information in config.log indicates: > > config-temp/qemu-conf.c:3:55: error: c

Re: [virtio-dev] [RFC for qemu v4 2/2] virtio_balloon: Add dcvq to deflate continuous pages

2020-07-16 Thread teawater
> 2020年7月16日 14:39,Michael S. Tsirkin 写道: > > On Thu, Jul 16, 2020 at 10:41:55AM +0800, Hui Zhu wrote: >> This commit adds a vq dcvq to deflate continuous pages. >> When VIRTIO_BALLOON_F_CONT_PAGES is set, try to get continuous pages >> from icvq and use madvise MADV_WILLNEED with the pages. >

Re: [PATCH] configure: Fix for running with --enable-werror on macOS

2020-07-16 Thread Philippe Mathieu-Daudé
On Thu, Jul 16, 2020 at 9:32 AM Philippe Mathieu-Daudé wrote: > > On 7/16/20 7:56 AM, Thomas Huth wrote: > > The configure script currently refuses to succeed when run on macOS > > with --enable-werror: > > > > ERROR: configure test passed without -Werror but failed with -Werror. > > > > The info

Re: [PATCH for-5.1 1/2] msf2: Unbreak device-list-properties for "msf-soc"

2020-07-16 Thread Philippe Mathieu-Daudé
On 7/16/20 8:07 AM, Thomas Huth wrote: > On 16/07/2020 04.59, sundeep subbaraya wrote: >> On Wed, Jul 15, 2020 at 8:12 PM Markus Armbruster wrote: >>> >>> Philippe Mathieu-Daudé writes: >>> On 7/15/20 4:04 PM, Markus Armbruster wrote: > Watch this: > > $ qemu-system-aarch64 -

Re: [PATCH for-5.1 1/2] msf2: Unbreak device-list-properties for "msf-soc"

2020-07-16 Thread sundeep subbaraya
Yep I will rework on this soon. Thanks guys, Sundeep On Thu, Jul 16, 2020 at 1:06 PM Philippe Mathieu-Daudé wrote: > > On 7/16/20 8:07 AM, Thomas Huth wrote: > > On 16/07/2020 04.59, sundeep subbaraya wrote: > >> On Wed, Jul 15, 2020 at 8:12 PM Markus Armbruster > >> wrote: > >>> > >>> Philipp

Re: [PATCH v2] tests: qmp-cmd-test: fix memory leak

2020-07-16 Thread Thomas Huth
On 15/07/2020 17.41, Li Qiang wrote: > Properly free each test response to avoid memory leak and separate > qtest_qmp() calls with spare lines, in a consistent manner. > > Fixes: 5b88849e7b9("tests/qmp-cmd-test: Add > qmp/object-add-failure-modes" > > Reviewed-by: Eric Auger > Signed-off-by: Li

Re: Implement standard file operation with QEMU

2020-07-16 Thread Philippe Mathieu-Daudé
Hi Xiaolei, +Laurent (user-mode) +Alex (semihosting) +Marc-André (chardev) On 7/16/20 2:51 AM, casmac wrote: > Hi all, >   I am trying to implment standard file operation (stdio) with QEMU for > DSP architecture. The manufacture (TI) provides a runtime library that > support posix standard IO, bu

Re: [PATCH v5 03/11] hw/timer: Add NPCM7xx Timer device model

2020-07-16 Thread Philippe Mathieu-Daudé
On 7/16/20 1:04 AM, Havard Skinnemoen wrote: > On Wed, Jul 15, 2020 at 12:25 AM Philippe Mathieu-Daudé > wrote: >> On 7/9/20 2:36 AM, Havard Skinnemoen wrote: >>> The NPCM730 and NPCM750 SoCs have three timer modules each holding five >>> timers and some shared registers (e.g. interrupt status).

[PATCH 2/4] scripts/tracetool: Use void pointer for vcpu

2020-07-16 Thread Roman Bolshakov
dtrace on macOS complains that CPUState * is used for a few probes: dtrace: failed to compile script trace-dtrace-root.dtrace: line 130: syntax error near "CPUState" A comment in scripts/tracetool/__init__.py mentions that: We only want to allow standard C types or fixed sized integer typ

[PATCH 1/4] scripts/tracetool: Fix dtrace generation for macOS

2020-07-16 Thread Roman Bolshakov
dtrace USDT is fully supported since OS X 10.6. There are a few peculiarities compared to other dtrace flavors. 1. It doesn't accept empty files. 2. It doesn't recognize bool type but accepts ANSI C _Bool. Cc: Cameron Esfahani Signed-off-by: Roman Bolshakov --- scripts/tracetool/format/d.py |

[PATCH 0/4] Add dtrace support on macOS

2020-07-16 Thread Roman Bolshakov
Hi, This is a small series that enables dtrace tracing backend on macOS. Whether or not it should go to 5.1 is up to discretion of tracing maintainers. Thanks, Roman Roman Bolshakov (4): scripts/tracetool: Fix dtrace generation for macOS scripts/tracetool: Use void pointer for vcpu build:

[PATCH 4/4] net/colo: Match is-enabled probe to tracepoint

2020-07-16 Thread Roman Bolshakov
Build of QEMU with dtrace fails on macOS: LINKx86_64-softmmu/qemu-system-x86_64 error: probe colo_compare_miscompare doesn't exist error: Could not register probes ld: error creating dtrace DOF section for architecture x86_64 The reason of the error is explained by Adam Leventhal [1]: No

[PATCH 1/2] i386/cpu: Clear FEAT_XSAVE_COMP_{LO, HI} when XSAVE is not available

2020-07-16 Thread Xiaoyao Li
Per Intel SDM vol 1, 13.2, if CPUID.1:ECX.XSAVE[bit 26] is 0, the processor provides no further enumeration through CPUID function 0DH. Signed-off-by: Xiaoyao Li --- target/i386/cpu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 1e5123251d74..

[PATCH 3/4] build: Don't make object files for dtrace on macOS

2020-07-16 Thread Roman Bolshakov
dtrace on macOS uses unresolved symbols with a special prefix to define probes [1], only headers should be generated for USDT (dtrace(1)). But it doesn't support backwards compatible no-op -G flag [2] and implicit build rules fail. 1. https://markmail.org/message/6grq2ygr5nwdwsnb 2. https://markma

[PATCH 2/2] i386/cpu: Mask off unsupported XSAVE components

2020-07-16 Thread Xiaoyao Li
When setting up XSAVE components, it needs to mask off those unsupported by KVM. Signed-off-by: Xiaoyao Li --- target/i386/cpu.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index f5f11603e805..efc92334b7b1 100644 --- a/target/i3

Re: [PATCH v2] crypto: use a stronger private key for tests

2020-07-16 Thread Kashyap Chamarthy
On Wed, Jul 15, 2020 at 04:47:01PM +0100, Daniel P. Berrangé wrote: > The unit tests using the x509 crypto functionality have started > failing in Fedora 33 rawhide with a message like > > The certificate uses an insecure algorithm > > This is result of Fedora changes to support strong cry

[PATCH 0/2] Two Fixes for xsave compoent features

2020-07-16 Thread Xiaoyao Li
Two simple fixes for XSAVE component features, please see each one for details. Xiaoyao Li (2): i386/cpu: Clear FEAT_XSAVE_COMP_{LO,HI} when XSAVE is not available i386/cpu: Mask off unsupported XSAVE components target/i386/cpu.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-)

Re: [RFC for Linux v4 1/2] virtio_balloon: Add VIRTIO_BALLOON_F_CONT_PAGES and inflate_cont_vq

2020-07-16 Thread teawater
> 2020年7月16日 14:43,Michael S. Tsirkin 写道: > > On Thu, Jul 16, 2020 at 10:41:51AM +0800, Hui Zhu wrote: >> diff --git a/include/uapi/linux/virtio_balloon.h >> b/include/uapi/linux/virtio_balloon.h >> index dc3e656..4d0151a 100644 >> --- a/include/uapi/linux/virtio_balloon.h >> +++ b/include/ua

Re: [RFC PATCH-for-5.2 0/5] qom: Let ObjectPropertyGet functions return a boolean value

2020-07-16 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > RFC series to follow Markus direction to simplify error > propagation. Not sure it is worth it yet. It starts to > be interesting when using the QEMU_WARN_UNUSED_RESULT > attribute in the visitors, such: > > -- >8 -- > @@ -525,6 +533,7 @@ bool visit_type_uint8(Vis

Re: [PATCH-for-5.2 1/5] hw/core/qdev-properties: Simplify get_reserved_region()

2020-07-16 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > Use the safer g_strdup_printf() over snprintf() + abort(). > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/core/qdev-properties.c | 9 +++-- > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-prop

Re: [PATCH 1/1] MAINTAINERS: introduce cve or security quotient field

2020-07-16 Thread Daniel P . Berrangé
On Thu, Jul 16, 2020 at 08:55:43AM +0200, Cornelia Huck wrote: > On Tue, 14 Jul 2020 18:40:11 +0530 (IST) > P J P wrote: > > > > > * QEMU would abort(3), if a user attempts to start QEMU with insecure > > options > >like say -virtfs OR -fda fat:floopy OR -netdev user OR -device tulip ?

Re: [PATCH-for-5.2 1/5] hw/core/qdev-properties: Simplify get_reserved_region()

2020-07-16 Thread Philippe Mathieu-Daudé
On 7/16/20 10:29 AM, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > >> Use the safer g_strdup_printf() over snprintf() + abort(). >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> hw/core/qdev-properties.c | 9 +++-- >> 1 file changed, 3 insertions(+), 6 deletions(-) >> >>

Re: device compatibility interface for live migration with assigned devices

2020-07-16 Thread Yan Zhao
On Thu, Jul 16, 2020 at 12:16:26PM +0800, Jason Wang wrote: > > On 2020/7/14 上午7:29, Yan Zhao wrote: > > hi folks, > > we are defining a device migration compatibility interface that helps upper > > layer stack like openstack/ovirt/libvirt to check if two devices are > > live migration compatible.

Re: [PATCH v10 03/10] qcow2_format.py: change Qcow2BitmapExt initialization method

2020-07-16 Thread Vladimir Sementsov-Ogievskiy
14.07.2020 00:36, Andrey Shinkevich wrote: There are two ways to initialize a class derived from Qcow2Struct: 1. Pass a block of binary data to the constructor. 2. Pass the file descriptor to allow reading the file from constructor. Let's change the Qcow2BitmapExt initialization method from 1 to

Re: [PATCH v10 04/10] qcow2_format.py: dump bitmap flags in human readable way.

2020-07-16 Thread Vladimir Sementsov-Ogievskiy
14.07.2020 00:36, Andrey Shinkevich wrote: Introduce the class BitmapFlags that parses a bitmap flags mask. Suggested-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Andrey Shinkevich Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH 4/4] net/colo: Match is-enabled probe to tracepoint

2020-07-16 Thread Daniel P . Berrangé
Adding Stefan to CC as the trace maintainer. On Thu, Jul 16, 2020 at 11:17:54AM +0300, Roman Bolshakov wrote: > Build of QEMU with dtrace fails on macOS: > > LINKx86_64-softmmu/qemu-system-x86_64 > error: probe colo_compare_miscompare doesn't exist > error: Could not register probes > ld: e

Re: [PATCH v5 08/20] microvm/acpi: add minimal acpi support

2020-07-16 Thread Gerd Hoffmann
Hi, > > References to ACPI 2.0 are almost useless. ACPI 5.0 is the oldest > > version uefi.org offers for download. > all versions are at (starting from 1.0) > https://uefi.org/acpi/specs Ah, there are the old ones hidden. Thanks for the pointer. Fetched latest errata of each version (assumin

Re: [PATCH 3/4] build: Don't make object files for dtrace on macOS

2020-07-16 Thread Daniel P . Berrangé
On Thu, Jul 16, 2020 at 11:17:53AM +0300, Roman Bolshakov wrote: > dtrace on macOS uses unresolved symbols with a special prefix to define > probes [1], only headers should be generated for USDT (dtrace(1)). But > it doesn't support backwards compatible no-op -G flag [2] and implicit > build rules

Re: [PATCH 0/4] Add dtrace support on macOS

2020-07-16 Thread Daniel P . Berrangé
Adding Stefan as the trace maintainer. On Thu, Jul 16, 2020 at 11:17:50AM +0300, Roman Bolshakov wrote: > Hi, > > This is a small series that enables dtrace tracing backend on macOS. > Whether or not it should go to 5.1 is up to discretion of tracing > maintainers. > > Thanks, > Roman > > Roman

Re: [PATCH 2/4] scripts/tracetool: Use void pointer for vcpu

2020-07-16 Thread Daniel P . Berrangé
On Thu, Jul 16, 2020 at 11:17:52AM +0300, Roman Bolshakov wrote: > dtrace on macOS complains that CPUState * is used for a few probes: > > dtrace: failed to compile script trace-dtrace-root.dtrace: line 130: syntax > error near "CPUState" > > A comment in scripts/tracetool/__init__.py mentions

Re: [PATCH 1/1] MAINTAINERS: introduce cve or security quotient field

2020-07-16 Thread Dr. David Alan Gilbert
* P J P (ppan...@redhat.com) wrote: > From: Prasad J Pandit > > QEMU supports numerous virtualisation and emulation use cases. > It also offers many features to support guest's function(s). > > All of these use cases and features are not always security relevant. > Because some maybe used in tru

Re: [PATCH 1/4] scripts/tracetool: Fix dtrace generation for macOS

2020-07-16 Thread Daniel P . Berrangé
On Thu, Jul 16, 2020 at 11:17:51AM +0300, Roman Bolshakov wrote: > dtrace USDT is fully supported since OS X 10.6. There are a few > peculiarities compared to other dtrace flavors. > > 1. It doesn't accept empty files. > 2. It doesn't recognize bool type but accepts ANSI C _Bool. > > Cc: Cameron

Re: [PATCH qemu v9] spapr: Implement Open Firmware client interface

2020-07-16 Thread Alexey Kardashevskiy
Ping? I kinda realize it is not going to replace SLOF any time soon but still... On 07/07/2020 10:34, Alexey Kardashevskiy wrote: > Ping? > > > On 24/06/2020 10:28, Alexey Kardashevskiy wrote: >> Ping? >> >> On 02/06/2020 21:40, Alexey Kardashevskiy wrote: >>> Ping? >>> >>> On 13/05/2020 13:58,

Re: [PATCH] acpi: Fix access to PM1 control and status registers

2020-07-16 Thread Cédric Le Goater
On 7/2/20 1:12 PM, Michael S. Tsirkin wrote: > On Wed, Jul 01, 2020 at 01:48:36PM +0100, Anthony PERARD wrote: >> On Wed, Jul 01, 2020 at 08:01:55AM -0400, Michael S. Tsirkin wrote: >>> On Wed, Jul 01, 2020 at 12:05:49PM +0100, Anthony PERARD wrote: The ACPI spec state that "Accesses to PM1 co

Re: [PATCH for-5.1 2/5] qom: Plug memory leak in "info qom-tree"

2020-07-16 Thread Thomas Huth
On 15/07/2020 17.19, Li Qiang wrote: > Markus Armbruster 于2020年7月15日周三 上午12:05写道: >> >> Commit e8c9e65816 "qom: Make "info qom-tree" show children sorted" >> created a memory leak, because I didn't realize >> object_get_canonical_path_component()'s value needs to be freed. >> >> Reproducer: >> >>

Re: [RFC PATCH-for-5.2 4/5] qom: Let ObjectPropertyGet functions return a boolean value

2020-07-16 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > Commits 1c94a35164..7b3cb8037c simplified the error propagation. The complete series is b6d7e9b66f..a43770df5d. The part you quoted omits half of the transformation for qemu-option and QAPI. The other half is in a5f9b9df25 error: Reduce unnecessary error p

Re: [PATCH v5 19/20] tests/acpi: add microvm test

2020-07-16 Thread Gerd Hoffmann
Hi, > > +data.required_struct_types = base_required_struct_types; > > +data.required_struct_types_len = > > ARRAY_SIZE(base_required_struct_types); > I vaguely recall this belongs to smbios tables, does actually microvm provide > them? Checked. Yes, it tests smbios tables. seabios g

Re: [PATCH v8 05/10] qcow2_format.py: Dump bitmap directory information

2020-07-16 Thread Vladimir Sementsov-Ogievskiy
03.07.2020 16:13, Andrey Shinkevich wrote: Read and dump entries from the bitmap directory of QCOW2 image. It extends the output in the test case #291. Header extension: magic 0x23852875 (Bitmaps) ... Bitmap name bitmap-1 bitmap_table_offset 0xf bitma

Re: [RFC PATCH-for-5.2 5/5] hw/virtio: Simplify virtio_mem_set_requested_size()

2020-07-16 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > Simplify by directly using visit_type_size() return value. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/virtio/virtio-mem.c | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/hw/virtio/virtio-mem.c b/hw/virtio/virtio-mem.c > ind

Re: [PATCH v10 05/10] qcow2_format.py: Dump bitmap directory information

2020-07-16 Thread Vladimir Sementsov-Ogievskiy
14.07.2020 00:36, Andrey Shinkevich wrote: Read and dump entries from the bitmap directory of QCOW2 image. Header extension: magic 0x23852875 (Bitmaps) ... Bitmap name bitmap-1 bitmap_table_offset 0xf bitmap_table_size 1 flags

Re: [PATCH v8 05/10] qcow2_format.py: Dump bitmap directory information

2020-07-16 Thread Vladimir Sementsov-Ogievskiy
16.07.2020 12:13, Vladimir Sementsov-Ogievskiy wrote: Reviewed-by: Vladimir Sementsov-Ogievskiy Oops, sorry, I wanted to answer v10 patch. Ignore this. -- Best regards, Vladimir

Re: [PATCH 01/18] migration/vmstate: Document vmstate_dummy

2020-07-16 Thread Dr. David Alan Gilbert
* Philippe Mathieu-Daudé (f4...@amsat.org) wrote: > vmstate_dummy is special and restricted to linux-user. See commit > c71c3e99b8 ("Add a vmstate_dummy struct for CONFIG_USER_ONLY"). > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/migration/vmstate.h | 2 +- > 1 file changed, 1 inse

Re: [PATCH 1/1] MAINTAINERS: introduce cve or security quotient field

2020-07-16 Thread P J P
+-- On Thu, 16 Jul 2020, Daniel P. Berrangé wrote --+ | > Failing to start (with a message that explains why) if one of the command | > line options is not covered by a specified security policy is not | > unreasonable (after all, we fail to start for other cases of incompatible | > command lin

Re: [PATCH v10 06/10] qcow2_format.py: pass cluster size to substructures

2020-07-16 Thread Vladimir Sementsov-Ogievskiy
14.07.2020 00:36, Andrey Shinkevich wrote: The cluster size of an image is the QcowHeader class member and may be obtained by dependent extension structures such as Qcow2BitmapExt for further bitmap table details print. Signed-off-by: Andrey Shinkevich --- tests/qemu-iotests/qcow2_format.py |

[PATCH] hw/riscv: sifive_e: Correct debug block size

2020-07-16 Thread Bin Meng
Currently the debug region size is set to 0x100, but according to FE310-G000 and FE310-G002 manuals: FE310-G000: 0x100 - 0xFFF FE310-G002: 0x0 - 0xFFF Change the size to 0x1000 that applies to both. Signed-off-by: Bin Meng --- hw/riscv/sifive_e.c | 2 +- 1 file changed, 1 insertion(+),

Re: device compatibility interface for live migration with assigned devices

2020-07-16 Thread Jason Wang
On 2020/7/16 下午4:32, Yan Zhao wrote: On Thu, Jul 16, 2020 at 12:16:26PM +0800, Jason Wang wrote: On 2020/7/14 上午7:29, Yan Zhao wrote: hi folks, we are defining a device migration compatibility interface that helps upper layer stack like openstack/ovirt/libvirt to check if two devices are live

[PULL 2/2] usb: fix storage regression

2020-07-16 Thread Gerd Hoffmann
Fix the contition to figure whenever we need to wait for more data or not. Simply check the mode, if we are not in DATAIN state any more we are done already and don't need to go ASYNC. Fixes: 7ad3d51ebb8a ("usb: add short-packet handling to usb-storage driver") Reported-by: Sai Pavan Boddu Teste

[PULL 0/2] Fixes 20200716 patches

2020-07-16 Thread Gerd Hoffmann
The following changes since commit 8746309137ba470d1b2e8f5ce86ac228625db940: Update version for v5.1.0-rc0 release (2020-07-15 19:08:07 +0100) are available in the Git repository at: git://git.kraxel.org/qemu tags/fixes-20200716-pull-request for you to fetch changes up to

[PULL 1/2] vfio: fix use-after-free in display

2020-07-16 Thread Gerd Hoffmann
Calling ramfb_display_update() might replace the DisplaySurface with the boot display, which in turn will free the currently active DisplaySurface. So clear our DisplaySurface pinter (dpy->region.surface pointer) to (a) avoid use-after-free and (b) force replacing the boot display with the real di

Re: [PATCH-for-5.2 1/5] hw/core/qdev-properties: Simplify get_reserved_region()

2020-07-16 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 7/16/20 10:29 AM, Markus Armbruster wrote: >> Philippe Mathieu-Daudé writes: >> >>> Use the safer g_strdup_printf() over snprintf() + abort(). >>> >>> Signed-off-by: Philippe Mathieu-Daudé >>> --- >>> hw/core/qdev-properties.c | 9 +++-- >>> 1 file chan

Re: [PATCH v10 07/10] qcow2_format.py: Dump bitmap table serialized entries

2020-07-16 Thread Vladimir Sementsov-Ogievskiy
14.07.2020 00:36, Andrey Shinkevich wrote: Add bitmap table information to the QCOW2 metadata dump. Bitmap name bitmap-1 ... Bitmap table typeoffset size 0 serialized 4718592 65536 1 serialized 429

Re: [PATCH 1/1] MAINTAINERS: introduce cve or security quotient field

2020-07-16 Thread Daniel P . Berrangé
On Thu, Jul 16, 2020 at 02:51:55PM +0530, P J P wrote: > +-- On Thu, 16 Jul 2020, Daniel P. Berrangé wrote --+ > | > Failing to start (with a message that explains why) if one of the command > | > line options is not covered by a specified security policy is not > | > unreasonable (after all, we

Re: [PATCH v3] spapr: Add a new level of NUMA for GPUs

2020-07-16 Thread Daniel Henrique Barboza
On 7/16/20 2:04 AM, David Gibson wrote: On Mon, May 25, 2020 at 12:49:27PM -0500, Reza Arbab wrote: On Mon, May 25, 2020 at 03:05:50PM +1000, David Gibson wrote: On Fri, May 22, 2020 at 02:53:33PM -0500, Reza Arbab wrote: --- a/hw/ppc/spapr_pci_nvlink2.c +++ b/hw/ppc/spapr_pci_nvlink2.c @@

Re: [PATCH 1/1] MAINTAINERS: introduce cve or security quotient field

2020-07-16 Thread P J P
+-- On Thu, 16 Jul 2020, Dr. David Alan Gilbert wrote --+ | > + C: CVE/Security/Trust Quotient | > + H:High - Feature (or code) is meant to be safe and used by untrusted | > + guests. So any potential security issue must be processed with | > + due care and be co

Re: [PATCH 1/1] MAINTAINERS: introduce cve or security quotient field

2020-07-16 Thread Christian Schoenebeck
On Donnerstag, 16. Juli 2020 11:21:55 CEST P J P wrote: > +-- On Thu, 16 Jul 2020, Daniel P. Berrangé wrote --+ > > | > Failing to start (with a message that explains why) if one of the > | > command > | > line options is not covered by a specified security policy is not > | > unreasonable (after

Re: [PATCH v2] tests: qmp-cmd-test: fix memory leak

2020-07-16 Thread Markus Armbruster
Li Qiang writes: > Markus Armbruster 于2020年7月16日周四 下午1:59写道: >> >> Li Qiang writes: >> >> > Properly free each test response to avoid memory leak and separate >> > qtest_qmp() calls with spare lines, in a consistent manner. >> > >> > Fixes: 5b88849e7b9("tests/qmp-cmd-test: Add >> > qmp/object-a

Re: [PATCH] hw/riscv: sifive_e: Correct debug block size

2020-07-16 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1594891856-15474-1-git-send-email-bmeng...@gmail.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIP

Re: [PATCH 01/18] migration/vmstate: Document vmstate_dummy

2020-07-16 Thread Daniel P . Berrangé
On Fri, Jul 03, 2020 at 10:18:54PM +0200, Philippe Mathieu-Daudé wrote: > vmstate_dummy is special and restricted to linux-user. See commit > c71c3e99b8 ("Add a vmstate_dummy struct for CONFIG_USER_ONLY"). > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/migration/vmstate.h | 2 +- > 1

Re: [PULL 2/2] usb: fix storage regression

2020-07-16 Thread BALATON Zoltan
On Thu, 16 Jul 2020, Gerd Hoffmann wrote: Fix the contition to figure whenever we need to wait for more data or Typo: contition -> condition Regards, BALATON Zoltan not. Simply check the mode, if we are not in DATAIN state any more we are done already and don't need to go ASYNC. Fixes: 7ad

Re: [PATCH 01/18] migration/vmstate: Document vmstate_dummy

2020-07-16 Thread Philippe Mathieu-Daudé
On 7/16/20 11:52 AM, Daniel P. Berrangé wrote: > On Fri, Jul 03, 2020 at 10:18:54PM +0200, Philippe Mathieu-Daudé wrote: >> vmstate_dummy is special and restricted to linux-user. See commit >> c71c3e99b8 ("Add a vmstate_dummy struct for CONFIG_USER_ONLY"). >> >> Signed-off-by: Philippe Mathieu-Daud

[RFC PATCH] tcg/cpu-exec: precise single-stepping after an exception

2020-07-16 Thread Luc Michel
When single-stepping with a debugger attached to QEMU, and when an exception is raised, the debugger misses the first instruction after the exception: $ qemu-system-aarch64 -M virt -display none -cpu cortex-a53 -s -S $ aarch64-linux-gnu-gdb GNU gdb (GDB) 9.2 [...] (gdb) tar rem :1234 Remote debug

Re: [PATCH v1 1/2] semihosting: defer connect_chardevs a little more to use serialx

2020-07-16 Thread Alex Bennée
Fred Konrad writes: > Le 6/26/20 à 12:06 PM, Fred Konrad a écrit : >> >> >> Le 6/16/20 à 4:52 PM, Alex Bennée a écrit : >>> >>> kon...@adacore.com writes: >>> From: KONRAD Frederic With that we can just use chardev=serial0. >>> >>> I don't quite follow what this means. >>> >>>

Re: [PATCH 1/1] MAINTAINERS: introduce cve or security quotient field

2020-07-16 Thread Daniel P . Berrangé
On Thu, Jul 16, 2020 at 03:14:51PM +0530, P J P wrote: > +-- On Thu, 16 Jul 2020, Dr. David Alan Gilbert wrote --+ > | > + C: CVE/Security/Trust Quotient > | > +H:High - Feature (or code) is meant to be safe and used by untrusted > | > + guests. So any potential security issue must

[PATCH] virtiofsd: Remove "norace" from cmdline help

2020-07-16 Thread Sergio Lopez
Commit 93bb3d8d4cda ("virtiofsd: remove symlink fallbacks") removed the implementation of the "norace" option, so remove it from the cmdline help too. Signed-off-by: Sergio Lopez --- tools/virtiofsd/helper.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/tools/virtiofsd/helper.c b/tools/vi

Re: [PATCH v10 08/10] qcow2.py: Introduce '-j' key to dump in JSON format

2020-07-16 Thread Vladimir Sementsov-Ogievskiy
14.07.2020 00:36, Andrey Shinkevich wrote: Add the command key to the qcow2.py arguments list to dump QCOW2 metadata in JSON format. Here is the suggested way to do that. The implementation of the dump in JSON format is in the patch that follows. Signed-off-by: Andrey Shinkevich --- tests/qem

Re: unable to boot windows with 256 cpus

2020-07-16 Thread Igor Mammedov
On Wed, 15 Jul 2020 14:28:19 -0400 Peter Xu wrote: > On Wed, Jul 15, 2020 at 07:45:13PM +0200, Igor Mammedov wrote: > > While testing ACPI cpu hotplug changes I stumbled on BSOD in case > > QEMU is configured with 256 CPUs, Windows Server 2012R2x64 fails to boot > > with bugcheck 5C > > > > > >

Re: [PATCH v10 09/10] qcow2_format.py: collect fields to dump in JSON format

2020-07-16 Thread Vladimir Sementsov-Ogievskiy
14.07.2020 00:36, Andrey Shinkevich wrote: As __dict__ is being extended with class members we do not want to print, make a light copy of the initial __dict__ and extend the copy by adding lists we have to print in the JSON output. Signed-off-by: Andrey Shinkevich --- tests/qemu-iotests/qcow2

Re: [PATCH 1/1] MAINTAINERS: introduce cve or security quotient field

2020-07-16 Thread Daniel P . Berrangé
On Thu, Jul 16, 2020 at 11:45:50AM +0200, Christian Schoenebeck wrote: > On Donnerstag, 16. Juli 2020 11:21:55 CEST P J P wrote: > > +-- On Thu, 16 Jul 2020, Daniel P. Berrangé wrote --+ > > > > | > Failing to start (with a message that explains why) if one of the > > | > command > > | > line opt

[PATCH] gitlab-ci.yml: Add fuzzer tests

2020-07-16 Thread Thomas Huth
So far we neither compile-tested nor run any of the new fuzzers in our CI, which led to some build failures of the fuzzer code in the past weeks. To avoid this problem, add a job to compile the fuzzer code and run some loops (which likely don't find any new bugs via fuzzing, but at least we know th

Re: [PATCH] gitlab-ci.yml: Add fuzzer tests

2020-07-16 Thread Thomas Huth
On 16/07/2020 12.09, Thomas Huth wrote: > So far we neither compile-tested nor run any of the new fuzzers in our CI, > which led to some build failures of the fuzzer code in the past weeks. > To avoid this problem, add a job to compile the fuzzer code and run some > loops (which likely don't find a

Re: [PATCH] spapr_pci: Robustify support of PCI bridges

2020-07-16 Thread Greg Kurz
On Thu, 16 Jul 2020 14:45:40 +1000 David Gibson wrote: > On Thu, Jul 09, 2020 at 07:12:47PM +0200, Greg Kurz wrote: > > Some recent error handling cleanups unveiled issues with our support of > > PCI bridges: > > > > 1) QEMU aborts when using non-standard PCI bridge types, > >unveiled by com

Re: [PATCH v2] tests: qmp-cmd-test: fix memory leak

2020-07-16 Thread Li Qiang
Markus Armbruster 于2020年7月16日周四 下午5:52写道: > > Li Qiang writes: > > > Markus Armbruster 于2020年7月16日周四 下午1:59写道: > >> > >> Li Qiang writes: > >> > >> > Properly free each test response to avoid memory leak and separate > >> > qtest_qmp() calls with spare lines, in a consistent manner. > >> > > >>

Re: [PATCH] spapr_pci: Robustify support of PCI bridges

2020-07-16 Thread Greg Kurz
On Thu, 16 Jul 2020 02:53:07 -0400 "Michael S. Tsirkin" wrote: > On Thu, Jul 09, 2020 at 07:12:47PM +0200, Greg Kurz wrote: > > Some recent error handling cleanups unveiled issues with our support of > > PCI bridges: > > > > 1) QEMU aborts when using non-standard PCI bridge types, > >unveile

Re: [PATCH v10 10/10] qcow2_format.py: support dumping metadata in JSON format

2020-07-16 Thread Vladimir Sementsov-Ogievskiy
14.07.2020 00:36, Andrey Shinkevich wrote: Implementation of dumping QCOW2 image metadata. The sample output: { "Header_extensions": [ { "name": "Feature table", "magic": 1745090647, "length": 192, "data_str": "" },

Re: [PATCH] virtiofsd: Remove "norace" from cmdline help

2020-07-16 Thread Philippe Mathieu-Daudé
On 7/16/20 12:14 PM, Sergio Lopez wrote: > Commit 93bb3d8d4cda ("virtiofsd: remove symlink fallbacks") removed > the implementation of the "norace" option, so remove it from the > cmdline help too. > > Signed-off-by: Sergio Lopez > --- > tools/virtiofsd/helper.c | 2 -- > 1 file changed, 2 delet

[PATCH v2 1/2] scripts/performance: Add list_fn_callees.py script

2020-07-16 Thread Ahmed Karaman
Python script that prints the callees of a given list of QEMU functions. Syntax: list_fn_callees.py [-h] -f FUNCTION [FUNCTION ...] -- \ [] \ [] [-h] - Print the script arguments help message. -f FUNCTION [FUNCTION ...] - List of function names Example of usage: l

[PATCH v2 0/2] Add list_fn_callees.py and list_helpers.py scripts

2020-07-16 Thread Ahmed Karaman
Hi, This series adds the two new scripts introduced in report 4 of the "TCG Continuous Benchmarking" GSoC project. "list_fn_callees.py" is used for printing the callees of a given list of QEMU functions. "list_helpers.py" is used for printing the executed helpers of a QEMU invocation. To learn

[PATCH v2 2/2] scripts/performance: Add list_helpers.py script

2020-07-16 Thread Ahmed Karaman
Python script that prints executed helpers of a QEMU invocation. Syntax: list_helpers.py [-h] -- \ [] \ [] [-h] - Print the script arguments help message. Example of usage: list_helpers.py -- qemu-mips coulomb_double-mips -n10 Example output: Total number of ins

Re: [PATCH 4/5] linux-user: Support CLONE_VM and extended clone options

2020-07-16 Thread Alex Bennée
Josh Kunz writes: > Sorry for the late reply, response inline. Also I noticed a couple > mails ago I seemed to have removed the devel list and maintainers. > I've re-added them to the CC line. > > On Wed, Jun 24, 2020 at 3:17 AM Alex Bennée wrote: >> >> >> Josh Kunz writes: >> >> > On Tue, Ju

Re: [PATCH 1/1] MAINTAINERS: introduce cve or security quotient field

2020-07-16 Thread Markus Armbruster
Daniel P. Berrangé writes: [...] > NB, the build time classification won't be perfect, but that's largely > because we don't have sufficient granularity in what we build. For > example, although we only care about QMP, IIUC, we can't turn off HMP > at build time. It could be made compile-time op

Re: [virtio-dev] [RFC for Linux v4 0/2] virtio_balloon: Add VIRTIO_BALLOON_F_CONT_PAGES to report continuous pages

2020-07-16 Thread Michael S. Tsirkin
On Thu, Jul 16, 2020 at 03:01:18PM +0800, teawater wrote: > > > > 2020年7月16日 14:38,Michael S. Tsirkin 写道: > > > > On Thu, Jul 16, 2020 at 10:41:50AM +0800, Hui Zhu wrote: > >> The first, second and third version are in [1], [2] and [3]. > >> Code of current version for Linux and qemu is availab

Re: [PATCH v2] tests: qmp-cmd-test: fix memory leak

2020-07-16 Thread Thomas Huth
On 16/07/2020 12.33, Li Qiang wrote: > Markus Armbruster 于2020年7月16日周四 下午5:52写道: >> >> Li Qiang writes: >> >>> Markus Armbruster 于2020年7月16日周四 下午1:59写道: Li Qiang writes: > Properly free each test response to avoid memory leak and separate > qtest_qmp() calls with spare li

qemu test-qga failure on mergebuild after VERSION file change: dependency issues??

2020-07-16 Thread Peter Maydell
The first merge I tried to process after bumping VERSION for rc0 failed on test-qga like this: MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} tests/test-qga -m=quick -k --tap < /dev/null | ./scripts/tap-driv er.pl --test-name="test-qga" PASS 1 test-qga /qga/sync-delimited PASS 2

Re: [PATCH 4/4] net/colo: Match is-enabled probe to tracepoint

2020-07-16 Thread Roman Bolshakov
On Thu, Jul 16, 2020 at 09:51:27AM +0100, Daniel P. Berrangé wrote: > Adding Stefan to CC as the trace maintainer. > > On Thu, Jul 16, 2020 at 11:17:54AM +0300, Roman Bolshakov wrote: > > Build of QEMU with dtrace fails on macOS: > > > > LINKx86_64-softmmu/qemu-system-x86_64 > > error: prob

Re: [PATCH 1/2] python/qemu: Cleanup changes to ConsoleSocket

2020-07-16 Thread Alex Bennée
Robert Foley writes: > The changes to console_socket.py and machine.py are to > cleanup for pylint and flake8. > > Signed-off-by: Robert Foley > --- > python/qemu/console_socket.py | 58 +-- > python/qemu/machine.py| 7 +++-- > python/qemu/pylintrc

Re: [PATCH-for-5.2] hw/s390x: Move S390_ADAPTER_SUPPRESSIBLE from 'css.h' to 's390_flic.h'

2020-07-16 Thread Cornelia Huck
On Wed, 15 Jul 2020 15:18:45 +0200 Philippe Mathieu-Daudé wrote: > Not all s390x devices require to have access to the CPU internals. > > To reduce the include dependencies on "s390x/css.h", move the > S390_ADAPTER_SUPPRESSIBLE definition to "s390x/s390_flic.h". But css.h is not 'CPU internals'

[PATCH] qcow2: cleanup created file when qcow2_co_create

2020-07-16 Thread Maxim Levitsky
This is basically the same thing as commit 'crypto.c: cleanup created file when block_crypto_co_create_opts_luks fails' does but for qcow2 files to ensure that we don't leave qcow2 files when creation fails. Signed-off-by: Maxim Levitsky --- block/qcow2.c | 11 +++ 1 file changed, 11 ins

Re: [PATCH v4 0/8] s390: Extended-Length SCCB & DIAGNOSE 0x318

2020-07-16 Thread Cornelia Huck
On Wed, 15 Jul 2020 12:26:20 -0400 Collin Walling wrote: > On 7/15/20 12:04 PM, Cornelia Huck wrote: > > On Wed, 15 Jul 2020 11:36:35 -0400 > > Collin Walling wrote: > > > >> Polite ping. Patches have been sitting on the list for a few weeks now, > >> and it doesn't look like any further chan

Re: qemu test-qga failure on mergebuild after VERSION file change: dependency issues??

2020-07-16 Thread Philippe Mathieu-Daudé
On 7/16/20 12:53 PM, Peter Maydell wrote: > The first merge I tried to process after bumping VERSION for rc0 > failed on test-qga like this: > > MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} > tests/test-qga -m=quick -k --tap < /dev/null | ./scripts/tap-driv > er.pl --test-name=

Re: [PATCH 1/1] MAINTAINERS: introduce cve or security quotient field

2020-07-16 Thread Christian Schoenebeck
On Donnerstag, 16. Juli 2020 12:01:57 CEST Daniel P. Berrangé wrote: > > My concern here is that just distinguishing between either 'low' or 'high' > > is a far too rough classification. > > > > In our preceding communication regarding 9pfs, I made clear that a) we do > > care about security relev

Re: [RFC 3/3] x68: acpi: trigger SMI before scanning for hotplugged CPUs

2020-07-16 Thread Laszlo Ersek
On 07/15/20 15:43, Igor Mammedov wrote: > On Wed, 15 Jul 2020 14:38:00 +0200 > Laszlo Ersek wrote: > >> On 07/14/20 17:19, Igor Mammedov wrote: >>> On Tue, 14 Jul 2020 14:41:28 +0200 >>> Laszlo Ersek wrote: >>> On 07/14/20 14:28, Laszlo Ersek wrote: > (CC'ing Peter Krempa due to vi

[PATCH-for-5.2 v2 1/2] block/block-backend: Trace blk_attach_dev()

2020-07-16 Thread Philippe Mathieu-Daudé
Add a trace event to follow devices attaching block drives: $ qemu-system-arm -M n800 -trace blk_\* 9513@1594040428.738162:blk_attach_dev attaching blk 'sd0' to device 'omap2-mmc' 9513@1594040428.738189:blk_attach_dev attaching blk 'sd0' to device 'sd-card' qemu-system-arm: sd_init failed

[RFC PATCH-for-5.2 v2 2/2] block/block-backend: Let blk_attach_dev() provide helpful error

2020-07-16 Thread Philippe Mathieu-Daudé
Let blk_attach_dev() take an Error* object to return helpful information. Adapt the callers. $ qemu-system-arm -M n800 qemu-system-arm: sd_init failed: cannot attach blk 'sd0' to device 'sd-card' blk 'sd0' is already attached by device 'omap2-mmc' Drive 'sd0' is already in use because it h

[PATCH-for-5.2 v2 0/2] block/block-backend: Let blk_attach_dev() provide helpful error

2020-07-16 Thread Philippe Mathieu-Daudé
A pair of patches which helps me debug an issue with block drive already attached. Suggestions to correctly/better use the Error API welcome, in particular in qdev-properties-system::set_drive_helper(). Since v1: - Rebased after 668f62ec62 ("error: Eliminate error_propagate()") Philippe Mathieu-

Re: [PULL 00/12] Block patches

2020-07-16 Thread Peter Maydell
On Thu, 9 Jul 2020 at 16:02, Kevin Wolf wrote: > > We can "fix" it for probably all realistic cases by lowering the speed > of the block job significantly. It's still not fully fixed for all > theoretical cases, but the pattern of starting a block job that is > throttled to a low speed so it will

Re: [PATCH-for-5.2 v2 1/2] block/block-backend: Trace blk_attach_dev()

2020-07-16 Thread Philippe Mathieu-Daudé
On 7/16/20 2:37 PM, Philippe Mathieu-Daudé wrote: > Add a trace event to follow devices attaching block drives: > > $ qemu-system-arm -M n800 -trace blk_\* > 9513@1594040428.738162:blk_attach_dev attaching blk 'sd0' to device > 'omap2-mmc' > 9513@1594040428.738189:blk_attach_dev attaching b

Re: [PATCH] qapi: record the last element in order to avoid memory leak

2020-07-16 Thread Markus Armbruster
Li Qiang writes: > While executing 'tests/test-qobject-input-visitor'. I got > following error: > > /visitor/input/fail/alternate: OK > /visitor/input/fail/union-list: OK > > = > ==4353==ERROR: LeakSanitizer: detected memory leaks >

Re: [PATCH 1/2] python/qemu: Cleanup changes to ConsoleSocket

2020-07-16 Thread Robert Foley
On Thu, 16 Jul 2020 at 07:07, Alex Bennée wrote: > > > Robert Foley writes: > > > The changes to console_socket.py and machine.py are to > > cleanup for pylint and flake8. > > > > Signed-off-by: Robert Foley > > --- > > python/qemu/console_socket.py | 58 +-- > >

Re: [PATCH 1/1] MAINTAINERS: introduce cve or security quotient field

2020-07-16 Thread Daniel P . Berrangé
On Thu, Jul 16, 2020 at 02:22:14PM +0200, Christian Schoenebeck wrote: > On Donnerstag, 16. Juli 2020 12:01:57 CEST Daniel P. Berrangé wrote: > > > My concern here is that just distinguishing between either 'low' or 'high' > > > is a far too rough classification. > > > > > > In our preceding commu

  1   2   3   >