On Thu, 9 Jul 2020 00:46:12 +0200
Julia Suvorova wrote:
> Add trace events similar to piix4_gpe_readb() to check gpe status.
>
> Signed-off-by: Julia Suvorova
Reviewed-by: Igor Mammedov
> ---
> hw/acpi/ich9.c | 7 ++-
> hw/acpi/trace-events | 4
> 2 files changed, 10 inserti
On 13/07/2020 11.05, Yi Wang wrote:
> From: Liao Pingfang
>
> Remove superfluous breaks, as there is a "return" before them.
>
> Signed-off-by: Liao Pingfang
> Signed-off-by: Yi Wang
> Reviewed-by: Philippe Mathieu-Daudé
> ---
> hw/block/pflash_cfi01.c | 1 -
> hw/display/cirrus_vga.c
On Fri, Jul 10, 2020 at 08:55:20AM +0200, Thomas Huth wrote:
> Most of the -usbdevice paramaters have been removed already. Update
> the doc accordingly.
Queued up for 5.1
thanks,
Gerd
On 13/07/2020 11.05, Yi Wang wrote:
> From: Liao Pingfang
>
> Remove superfluous breaks, as there is a "return" before them.
>
> Signed-off-by: Liao Pingfang
> Signed-off-by: Yi Wang
> Reviewed-by: Philippe Mathieu-Daudé
> ---
> target/sh4/translate.c | 3 ---
> 1 file changed, 3 deletions(-
On Thu, Jul 02, 2020 at 02:42:45PM +0200, Paolo Bonzini wrote:
> On 02/07/20 12:57, Roman Bolshakov wrote:
> > There's still a small chance of kick loss, on user-to-kernel border
> > between atomic_mb_set's just before the entry to hv_vcpu_run and just
> > after it.
>
> Good point, but we can fix
On Sat, Jul 04, 2020 at 04:49:17PM +0200, Philippe Mathieu-Daudé wrote:
> Hi,
>
> This is the second time I try to replace a magic typename string
> by a constant, and Zoltan warns me this is counter productive as
> "hw/usb.h" pulls in an insane amount of code.
>
> Time to give the usb subsystem
Variable "cpu_env" is used in file "syscall.c" to store
the information about the cpu environment. This variable
is used because values of some syscalls can vary between
cpu architectures. This patch makes the "cpu_env" accessible
in "strace.c" so it can enable aproppriate "-strace" argument
printi
This patch implements strace argument printing functionality for following
syscalls:
* truncate, ftruncate - truncate a file to a specified length
int truncate/truncate64(const char *path, off_t length)
int ftruncate/ftruncate64(int fd, off_t length)
man page: https:/
This patch implements strace argument printing functionality for following
syscalls:
* mlock, munlock, mlockall, munlockall - lock and unlock memory
int mlock(const void *addr, size_t len)
int munlock(const void *addr, size_t len)
int mlockall(int flags)
int munlo
This patch implements strace argument printing functionality for following
syscalls:
* clock_getres, clock_gettime, clock_settime - clock and time functions
int clock_getres(clockid_t clockid, struct timespec *res)
int clock_gettime(clockid_t clockid, struct timespec *tp)
On 7/10/20 7:06 AM, John Snow wrote:
> This is done primarily to avoid the 'bare except' pattern, which
> suppresses all exceptions during shutdown and can obscure errors.
>
> Replace this with a pattern that isolates the different kind of shutdown
> paradigms (_hard_shutdown and _soft_shutdown),
On 7/10/20 7:06 AM, John Snow wrote:
> When issuing 'reboot' to a VM with the no-reboot option, that VM will
> exit. When then issuing a shutdown command, the cleanup may race.
>
> Add calls to vm.wait() which will gracefully mark the VM as having
> exited. Subsequent vm.shutdown() calls in generi
On 7/10/20 7:06 AM, John Snow wrote:
> cubieboard does not have a functioning reboot, it halts and QEMU does
> not exit.
>
> vm.shutdown() is modified in a forthcoming patch that makes it less tolerant
> of race conditions on shutdown; tests should consciously decide to WAIT
> or to SHUTDOWN qemu.
25.06.2020 18:21, Max Reitz wrote:
There are BDS children that the general block layer code can access,
namely bs->file and bs->backing. Since the introduction of filters and
external data files, their meaning is not quite clear. bs->backing can
be a COW source, or it can be a filtered child; b
On Apr 29 2020, Laurent Vivier wrote:
> "Since the extended-precision data format has an explicit integer bit, a
> number can be formatted with a nonzero exponent, less than the maximum
> value, and a zero integer bit. The IEEE 754 standard does not define a
> zero integer bit. Such a number is an
Yi Wang wrote:
> From: Liao Pingfang
>
> Remove the superfluous break, as there is a "return" before.
>
> Signed-off-by: Liao Pingfang a
> Signed-off-by: Yi Wang
> Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Juan Quintela
Signed-off-by: Andreas Schwab
---
linux-user/syscall.c | 32 +++-
1 file changed, 27 insertions(+), 5 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 9ec03a889d..7c0f5b83ff 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -38
On Mon, 13 Jul 2020 at 09:57, Philippe Mathieu-Daudé wrote:
> Why not make it a generic container in the MachineState and create
> the container in hw/core/machine.c::machine_initfn()?
I don't think we create containers like that for any other
machine, do we?
thanks
-- PMM
This series covers strace support for following syscalls:
*truncate() *munlock() *clock_gettimeofday()
*ftruncate()*munlockall() *clock_getitimer()
*getsid() *clock_getres() *clock_setitimer()
*mlock()*clock_gettime()
*mlockall() *clock_s
On 17.06.20 20:27,
Sorry :/
Connor Kuehl wrote:
> Providing an empty string for the backing file parameter like so:
>
> qemu-img create -f qcow2 -b '' /tmp/foo
>
> allows the flow of control to reach and subsequently fail an assert
> statement because passing an empty string to
>
>
Le ven. 10 juil. 2020 à 22:35, Alistair Francis a écrit :
>
> On Mon, Jul 6, 2020 at 2:45 AM Alexandre Mergnat
> wrote:
> >
> > The end address calculation for NA4 mode is wrong because the address
> > used isn't shifted.
> >
> > That imply all NA4 setup are not applied by the PMP.
>
> I'm not s
On 10/07/2020 21.30, Richard Henderson wrote:
> On 7/9/20 6:07 AM, Philippe Mathieu-Daudé wrote:
>> I remember you had a series related to capstone, but eventually there
>> was a problem so you postponed it until some patches were merged
>> upstream, do you remember?
>
> I do.
>
> My biggest prob
25.06.2020 18:21, Max Reitz wrote:
Add some helper functions for skipping filters in a chain of block
nodes.
Signed-off-by: Max Reitz
---
include/block/block_int.h | 3 +++
block.c | 55 +++
2 files changed, 58 insertions(+)
diff --git
On 7/13/20 12:05 PM, Peter Maydell wrote:
> On Mon, 13 Jul 2020 at 09:57, Philippe Mathieu-Daudé wrote:
>> Why not make it a generic container in the MachineState and create
>> the container in hw/core/machine.c::machine_initfn()?
>
> I don't think we create containers like that for any other
> m
On Wed, Jul 08, 2020 at 06:50:12PM +0200, Cornelia Huck wrote:
> On Wed, 8 Jul 2020 14:05:26 +0100
> Stefan Hajnoczi wrote:
>
> > On Tue, Jul 07, 2020 at 05:44:53PM +0200, Cornelia Huck wrote:
> > > On Mon, 6 Jul 2020 14:56:48 +0100
> > > Stefan Hajnoczi wrote:
>
> > > > diff --git a/hw/virtio
On Jul 12, 2020, at 10:02 PM, qemu-devel-requ...@nongnu.org wrote:
Message: 6
Date: Mon, 13 Jul 2020 00:17:30 -
From: JuanPabloCuervo <1887...@bugs.launchpad.net>
To: qemu-devel@nongnu.org
Subject: [Bug 1887318] [NEW] impossible to install in OSX Yosemite
10.10.5
Message-ID:
<159
On 13.07.2020 11:43, Vladimir Sementsov-Ogievskiy wrote:
12.07.2020 19:07, Andrey Shinkevich wrote:
On 11.07.2020 16:05, Vladimir Sementsov-Ogievskiy wrote:
26.06.2020 17:31, Andrey Shinkevich wrote:
The script 'bench_write_req.py' allows comparing performances of write
request for two qemu-im
> Am 13.07.2020 um 11:12 schrieb Heiko Carstens :
>
> On Fri, Jul 10, 2020 at 05:24:07PM +0200, David Hildenbrand wrote:
>>> On 10.07.20 17:18, Heiko Carstens wrote:
>>> On Fri, Jul 10, 2020 at 02:12:33PM +0200, David Hildenbrand wrote:
> Note: Reading about diag260 subcode 0xc, we could m
On Mon, 13 Jul 2020 at 11:21, Philippe Mathieu-Daudé wrote:
>
> On 7/13/20 12:05 PM, Peter Maydell wrote:
> > On Mon, 13 Jul 2020 at 09:57, Philippe Mathieu-Daudé
> > wrote:
> >> Why not make it a generic container in the MachineState and create
> >> the container in hw/core/machine.c::machine_i
On 13.07.2020 11:43, Vladimir Sementsov-Ogievskiy wrote:
12.07.2020 19:07, Andrey Shinkevich wrote:
On 11.07.2020 16:05, Vladimir Sementsov-Ogievskiy wrote:
26.06.2020 17:31, Andrey Shinkevich wrote:
The script 'bench_write_req.py' allows comparing performances of write
request for two qemu-im
On 7/13/20 11:05 AM, Yi Wang wrote:
> From: Liao Pingfang
>
> Remove superfluous breaks, as there is a "return" before them.
>
> Signed-off-by: Liao Pingfang
> Signed-off-by: Yi Wang
> Reviewed-by: Philippe Mathieu-Daudé
I hadn't reviewed this patch, but now I did.
> ---
> target/sh4/trans
On 7/13/20 11:04 AM, Yi Wang wrote:
> From: Liao Pingfang
>
> Remove superfluous breaks, as there is a "return" before them.
>
> Signed-off-by: Liao Pingfang
> Signed-off-by: Yi Wang
> Reviewed-by: Philippe Mathieu-Daudé
I hadn't reviewed this patch, but now I did.
> ---
> tcg/riscv/tcg-t
On 7/13/20 11:03 AM, Yi Wang wrote:
> From: Liao Pingfang
>
> Remove superfluous breaks, as there is a "return" before them.
>
> Signed-off-by: Liao Pingfang
> Signed-off-by: Yi Wang
> Reviewed-by: Philippe Mathieu-Daudé
I hadn't reviewed this patch, but now I did (you can strip the space
a
Patchew URL:
https://patchew.org/QEMU/20200713095058.106624-1-filip.boz...@syrmia.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20200713095058.106624-1-filip.boz...@syrmia.com
Subject: [PATCH v2 0/4] Add strace s
On Fri, 10 Jul 2020 21:20:08 +0200
Claudio Fontana wrote:
> >>> In short this goes away if I again set icount to enabled for qtest,
> >>> basically ensuring that --enable-tcg is there and then reenabling icount.
> >>>
> >>> qtest was forcing icount and shift=0 by creating qemu options, in order
On 6/28/20 11:42 PM, Peter Maydell wrote:
> Remove hard-tabs from palm.c.
>
> Signed-off-by: Peter Maydell
> ---
> hw/arm/palm.c | 64 +--
> 1 file changed, 32 insertions(+), 32 deletions(-)
Using 'git-diff -w':
Reviewed-by: Philippe Mathieu-Daudé
On Sat, 11 Jul 2020 13:40:50 +0200
Claudio Fontana wrote:
> I found out something that for me shows that more investigation here is
> warranted.
>
>
> Here is my latest workaround for the problem:
>
>
>
> diff --git a/hw/s390x/s390-skeys.c b/hw/s390x/s390-skeys.c
> index 1e036cc602..47c9a01
On 7/13/20 12:31 PM, Peter Maydell wrote:
> On Mon, 13 Jul 2020 at 11:21, Philippe Mathieu-Daudé wrote:
>>
>> On 7/13/20 12:05 PM, Peter Maydell wrote:
>>> On Mon, 13 Jul 2020 at 09:57, Philippe Mathieu-Daudé
>>> wrote:
Why not make it a generic container in the MachineState and create
On 6/29/20 2:14 PM, Peter Maydell wrote:
> On Mon, 29 Jun 2020 at 10:39, Philippe Mathieu-Daudé wrote:
>>
>> Hi Peter,
>>
>> On 6/28/20 10:37 PM, Peter Maydell wrote:
>>> Currently we have a free-floating set of IRQs and a function
>>> tosa_out_switch() which handle the GPIO lines on the tosa boar
From: Alexander Bulekov
When configuring with --enable-fuzzing, we overwrote the CFLAGS
added by all the preceding checks. Instead of overwriting CFLAGS, append
the ones we need.
Fixes: adc28027ff ("fuzz: add configure flag --enable-fuzzing")
Reported-by: Li Qiang
Signed-off-by: Alexander Bulek
Hi Peter,
the following changes since commit 9f526fce49c6ac48114ed04914b5a76e4db75785:
Merge remote-tracking branch
'remotes/stsquad/tags/pull-testing-and-misc-110720-2' into staging (2020-07-12
15:32:05 +0100)
are available in the Git repository at:
https://gitlab.com/huth/qemu.git tags
There should be a space between "forking" and "for".
Message-Id: <20200709083719.1-1-th...@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Alexander Bulekov
Signed-off-by: Thomas Huth
---
tests/qtest/fuzz/virtio_scsi_fuzz.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletion
Fix typo - the option is called "--fuzz-target" and not "--fuzz_taget".
Also use a different fuzzer in the example, since "virtio-net-fork-fuzz"
does not seem to be a valid fuzzer target (anymore?).
Signed-off-by: Thomas Huth
Message-Id: <20200709084059.22539-1-th...@redhat.com>
---
docs/devel/f
GCC supports "#pragma GCC diagnostic" since version 4.6, and
Clang seems to support it, too, since its early versions 3.x.
That means that our minimum required compiler versions all support
this pragma already and we can remove the test from configure and
all the related #ifdefs in the code.
Revie
From: Olaf Hering
Avoid random return value.
Fixes commit f2dfe54c74f768a5bf78c9e5918918727f9d9459
Signed-off-by: Olaf Hering
Message-Id: <20200707171326.16422-1-o...@aepfle.de>
Reviewed-by: Richard Henderson
Signed-off-by: Thomas Huth
---
configure | 1 +
1 file changed, 1 insertion(+)
di
From: Alexander Bulekov
In 45222b9a90, I fixed a broken check for rcu_enable_atfork introduced
in d6919e4cb6. I added a call to rcu_enable_atfork after the
call to qemu_init in fuzz.c, but forgot to include the corresponding
header, breaking --enable-fuzzing --enable-werror builds.
Fixes: 45222b
Greetings,
The fourth report of the TCG Continuous Benchmarking series builds
upon the previous report by presenting two new Python scripts that
facilitate the process of displaying the executed QEMU helpers and
function callees without the need of setting up KCachegrind.
The ppc performance degr
Ping^2?
On 7/10/20 11:43 AM, Michal Privoznik wrote:
> On 6/22/20 8:19 PM, Michal Privoznik wrote:
>> v3 of:
>>
>> https://lists.nongnu.org/archive/html/qemu-devel/2020-06/msg06913.html
>>
>> diff to v2:
>> - don't leak @hostname in util/oslib-posix.c:qemu_get_host_name()
>> - document why we are
From: Cleber Rosa
This script is intended to be used right after a push to a branch.
By default, it will look for the pipeline associated with the commit
that is the HEAD of the *local* staging branch. It can be used as a
one time check, or with the `--wait` option to wait until the pipeline
co
Add fallthrough annotations to be able to compile the code without
warnings with -Wimplicit-fallthrough. Looking at the code, it seems
like the fallthrough is indeed intended here, so the comments should
be appropriate.
Message-Id: <20200630055953.9309-1-th...@redhat.com>
Reviewed-by: Richard Hend
There is some additional information about the 3270 support in our Wiki
at https://wiki.qemu.org/Features/3270 - so let's include this information
into the main documentation now to have one single source of information
(the Wiki page could later be removed).
While at it, I also shortened the line
On Mon, Jul 13, 2020 at 10:43:19AM +0300, Michael Tokarev wrote:
> 13.07.2020 10:20, Michael Tokarev пишет:
> > 12.07.2020 15:00, Simon John wrote:
> >> macos guests no longer boot after commit
> >> 5d971f9e672507210e77d020d89e0e89165c8fc9
> >>
> >> acpi-tmr needs 2 byte memory accesses, so breaks
* Claudio Fontana (cfont...@suse.de) wrote:
> Hello all,
>
> during unrelated work for splitting QTest from the TCG instruction counting
> module,
>
> I encountered what seems to be a migration stream issue, which is apparent
> only on s390, and only shows in block test 267.
>
> ./check -qcow2
On 13.07.20 12:27, David Hildenbrand wrote:
>
>
>> Am 13.07.2020 um 11:12 schrieb Heiko Carstens :
>>
>> On Fri, Jul 10, 2020 at 05:24:07PM +0200, David Hildenbrand wrote:
On 10.07.20 17:18, Heiko Carstens wrote:
On Fri, Jul 10, 2020 at 02:12:33PM +0200, David Hildenbrand wrote:
>>
On Mon, Jul 13, 2020 at 10:20:12AM +0300, Michael Tokarev wrote:
> 12.07.2020 15:00, Simon John wrote:
> > macos guests no longer boot after commit
> > 5d971f9e672507210e77d020d89e0e89165c8fc9
> >
> > acpi-tmr needs 2 byte memory accesses, so breaks as that commit only allows
> > 4 bytes.
> >
>
On 10.07.20 16:21, Kevin Wolf wrote:
> Unaligned requests will automatically be aligned to bl.request_alignment
> and we don't want to extend requests to access space beyond the end of
> the image, so it's required that the image size is aligned.
>
> With write requests, this could cause assertion
On Thu, Jul 09, 2020 at 10:16:31AM -0400, Jag Raman wrote:
> > On Jul 2, 2020, at 9:40 AM, Stefan Hajnoczi wrote:
> > On Sat, Jun 27, 2020 at 10:09:22AM -0700, elena.ufimts...@oracle.com wrote:
> > makes sense to me and I see how it forms the base on which
> > VFIO-over-socket and smaller remote p
Max noticed that I didn't run iotests on -luks...
Signed-off-by: Eric Blake
---
tests/qemu-iotests/282.out | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tests/qemu-iotests/282.out b/tests/qemu-iotests/282.out
index 5d079dabce1d..67db7ab15aff 100644
--- a/tests/qemu-io
On Wed, Jul 08, 2020 at 06:51:18PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> 07.07.2020 18:56, Stefan Hajnoczi wrote:
> > On Sat, Jun 20, 2020 at 05:36:45PM +0300, Vladimir Sementsov-Ogievskiy
> > wrote:
> > > Introduce a function to mark the request serialising only if there are
> > > no confl
On Wed, Jul 08, 2020 at 06:56:53PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> 07.07.2020 19:10, Stefan Hajnoczi wrote:
> > On Sat, Jun 20, 2020 at 05:36:46PM +0300, Vladimir Sementsov-Ogievskiy
> > wrote:
> > > +int coroutine_fn bdrv_co_pwrite_zeroes_locked(BdrvChild *child, int64_t
> > > offse
On 7/13/20 12:51 PM, Cornelia Huck wrote:
> On Sat, 11 Jul 2020 13:40:50 +0200
> Claudio Fontana wrote:
>
>> I found out something that for me shows that more investigation here is
>> warranted.
>>
>>
>> Here is my latest workaround for the problem:
>>
>>
>>
>> diff --git a/hw/s390x/s390-skeys.c
On Wed, Jul 08, 2020 at 07:17:52PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> 08.07.2020 15:07, Stefan Hajnoczi wrote:
> > On Sat, Jun 20, 2020 at 05:36:47PM +0300, Vladimir Sementsov-Ogievskiy
> > wrote:
> > > It may be used for file-systems with slow allocation.
> > >
> > > Signed-off-by: Vla
Patchew URL: https://patchew.org/QEMU/20200713105534.10872-1-th...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20200713105534.10872-1-th...@redhat.com
Subject: [PULL 0/9] Fuzzer, configure, gitlab and mis
Hello,
On 7/13/20 1:03 PM, Dr. David Alan Gilbert wrote:
> * Claudio Fontana (cfont...@suse.de) wrote:
>> Hello all,
>>
>> during unrelated work for splitting QTest from the TCG instruction counting
>> module,
>>
>> I encountered what seems to be a migration stream issue, which is apparent
>> on
Max spotted that I didn't test -qed...
Signed-off-by: Eric Blake
---
tests/qemu-iotests/024 | 2 +-
tests/qemu-iotests/024.out | 1 -
tests/qemu-iotests/043 | 5 +++--
tests/qemu-iotests/043.out | 4
4 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/tests/qemu-iotests/0
On Mon, 13 Jul 2020 12:03:33 +0100
"Dr. David Alan Gilbert" wrote:
> * Claudio Fontana (cfont...@suse.de) wrote:
> > The following workarounds hide the problem (make the test pass):
> >
> > 1) always including the icount field in the (unrelated) timers field that
> > are sent before in the mig
On Thu, Jul 09, 2020 at 07:48:55PM -0400, Alexander Bulekov wrote:
> On 200623 1514, Stefan Hajnoczi wrote:
> > On Thu, Jun 11, 2020 at 01:56:51AM -0400, Alexander Bulekov wrote:
> > > Signed-off-by: Alexander Bulekov
> > > ---
> > > exec.c| 17 -
>
On 7/13/20 1:39 PM, Claudio Fontana wrote:
> Hello,
>
> On 7/13/20 1:03 PM, Dr. David Alan Gilbert wrote:
>> * Claudio Fontana (cfont...@suse.de) wrote:
>>> Hello all,
>>>
>>> during unrelated work for splitting QTest from the TCG instruction counting
>>> module,
>>>
>>> I encountered what seems
On 13.07.20 13:19, Max Reitz wrote:
> On 10.07.20 16:21, Kevin Wolf wrote:
>> Unaligned requests will automatically be aligned to bl.request_alignment
>> and we don't want to extend requests to access space beyond the end of
>> the image, so it's required that the image size is aligned.
>>
>> With
On 200713 1241, Stefan Hajnoczi wrote:
> On Thu, Jul 09, 2020 at 07:48:55PM -0400, Alexander Bulekov wrote:
> > On 200623 1514, Stefan Hajnoczi wrote:
> > > On Thu, Jun 11, 2020 at 01:56:51AM -0400, Alexander Bulekov wrote:
> > > > Signed-off-by: Alexander Bulekov
> > > > ---
> > > > exec.c
On 10.07.20 10:32, David Hildenbrand wrote:
>>> --- a/target/s390x/misc_helper.c
>>> +++ b/target/s390x/misc_helper.c
>>> @@ -116,6 +116,12 @@ void HELPER(diag)(CPUS390XState *env, uint32_t r1,
>>> uint32_t r3, uint32_t num)
>>> uint64_t r;
>>>
>>> switch (num) {
>>> +case 0x26
On Mon, 13 Jul 2020 at 09:25, Marc-André Lureau
wrote:
>
> The following changes since commit d34498309cff7560ac90c422c56e3137e6a64b19:
>
> Merge remote-tracking branch 'remotes/philmd-gitlab/tags/avr-port-20200711'
> into staging (2020-07-11 19:27:59 +0100)
>
> are available in the Git reposit
On 7/7/20 9:42 AM, Erik Smit wrote:
> Hi Andrew,
>
> On Mon, 6 Jul 2020 at 03:59, Andrew Jeffery wrote:
>> On Sun, 28 Jun 2020, at 23:56, erik-smit wrote:
>>> The test of the write of the dblac register was testing the old value
>>> instead of the new value. This would accept the write of an inva
On Mon, 13 Jul 2020 13:54:41 +0200
Christian Borntraeger wrote:
> On 10.07.20 10:32, David Hildenbrand wrote:
>
> >>> --- a/target/s390x/misc_helper.c
> >>> +++ b/target/s390x/misc_helper.c
> >>> @@ -116,6 +116,12 @@ void HELPER(diag)(CPUS390XState *env, uint32_t r1,
> >>> uint32_t r3, uint32_t
On 13.07.20 14:11, Cornelia Huck wrote:
> On Mon, 13 Jul 2020 13:54:41 +0200
> Christian Borntraeger wrote:
>
>> On 10.07.20 10:32, David Hildenbrand wrote:
>>
> --- a/target/s390x/misc_helper.c
> +++ b/target/s390x/misc_helper.c
> @@ -116,6 +116,12 @@ void HELPER(diag)(CPUS390XSta
On Mon, Jul 13, 2020 at 12:46:00PM +0100, Simon John wrote:
> I don't profess to understand most of this, I am just a user who found
> something didn't work and tracked down the cause with help from the people
> on the bugtracker.
>
> the min=1 and max=4 was chosen as it seems to be set that way i
On 7/5/20 7:34 PM, Philippe Mathieu-Daudé wrote:
> Since added in commit 2bea128c3d, each SDHCI is wired with a SD
> card, using empty card when no block drive provided. This is not
> the desired behavior. The SDHCI exposes a SD bus to plug cards
> on, if no card available, it is fine to have an un
From: "Denis V. Lunev"
qemu_fclose() could return error, f.e. if bdrv_co_flush() will return
the error.
This validation will become more important once we will start waiting of
asynchronous IO operations, started from bdrv_write_vmstate(), which are
coming soon.
Signed-off-by: Denis V. Lunev
R
From: Liao Pingfang
Remove superfluous breaks, as there is a "return" before them.
Signed-off-by: Liao Pingfang
Signed-off-by: Yi Wang
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Juan Quintela
Reviewed-by: Thomas Huth
Signed-off-by: Juan Quintela
---
migration/migration.c | 2 --
1 f
On 6/29/20 7:38 PM, Philippe Mathieu-Daudé wrote:
> Simplify aspeed_i2c_get_bus() by using a AspeedI2CState argument.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Cédric Le Goater
> ---
> include/hw/i2c/aspeed_i2c.h | 2 +-
> hw/arm/aspeed.c | 70 ++-
Hello all,
Thank you Philippe for looping me in.
On Monday, 13 July, 2020, 1:46:45 pm IST, Philippe Mathieu-Daudé
wrote:
7/11/20 2:28 PM, 林奕帆 wrote:
> I am a student from Fudan University in China. I am doing research on
> CVE patch recently. But i can not find the PATCH COMMIT of
> CVE-201
It includes several fixes:
- fix qemu_fclose(denis)
- remove superfluous breaks (liao)
- fix memory leak (zheng)
Please apply
Denis V. Lunev (1):
migration/savevm: respect qemu_fclose() error code in save_snapshot()
Liao Pingfang (1):
migration/migration.c: Remove superfluous breaks
Zheng
On Mon, 13 Jul 2020 at 13:20, Cédric Le Goater wrote:
>
> On 7/5/20 7:34 PM, Philippe Mathieu-Daudé wrote:
> > Since added in commit 2bea128c3d, each SDHCI is wired with a SD
> > card, using empty card when no block drive provided. This is not
> > the desired behavior. The SDHCI exposes a SD bus t
12.07.2020 20:49, Andrey Shinkevich wrote:
The script 'bench_write_req.py' allows comparing performances of write
request for two qemu-img binary files.
An example with (qemu-img binary 1) and without (qemu-img binary 2) the
applied patch "qcow2: skip writing zero buffers to empty COW areas"
(git
On 7/13/20 2:23 PM, Juan Quintela wrote:
> From: Liao Pingfang
>
> Remove superfluous breaks, as there is a "return" before them.
>
> Signed-off-by: Liao Pingfang
> Signed-off-by: Yi Wang
> Reviewed-by: Philippe Mathieu-Daudé
I hadn't reviewed this patch, but now I did ¯\_(ツ)_/¯
> Reviewed-
13.07.2020 13:26, Andrey Shinkevich wrote:
On 13.07.2020 11:43, Vladimir Sementsov-Ogievskiy wrote:
12.07.2020 19:07, Andrey Shinkevich wrote:
On 11.07.2020 16:05, Vladimir Sementsov-Ogievskiy wrote:
26.06.2020 17:31, Andrey Shinkevich wrote:
The script 'bench_write_req.py' allows comparing p
On Tue, 7 Jul 2020 at 19:31, Philippe Mathieu-Daudé wrote:
>
> Add avr_load_firmware() function to load firmware in ELF or
> raw binary format.
Hi; Coverity points out a memory leak (CID 1430449) in this function:
> +bool avr_load_firmware(AVRCPU *cpu, MachineState *ms,
> +
On 7/13/20 2:27 AM, Andrey Shinkevich wrote:
Add dirty bitmap information to QCOW2 metadata dump in the qcow2_format.py.
v9:
01: In patch 0003, removed explicit constructor in the class Qcow2BitmapExt.
02: In patch 0004, the format string was changed.
Andrey Shinkevich (10):
qcow2:
Calling ramfb_display_update() might replace the DisplaySurface with the
boot display, which in turn will free the currently active
DisplaySurface.
So clear our DisplaySurface pinter (dpy->region.surface pointer) to (a)
avoid use-after-free and (b) force replacing the boot display with the
real di
Am 13.07.2020 um 13:40 hat Eric Blake geschrieben:
> Max spotted that I didn't test -qed...
>
> Signed-off-by: Eric Blake
I guess I have a new name now... :-)
Kevin^WMax
On 7/13/20 2:45 PM, Gerd Hoffmann wrote:
> Calling ramfb_display_update() might replace the DisplaySurface with the
> boot display, which in turn will free the currently active
> DisplaySurface.
>
> So clear our DisplaySurface pinter (dpy->region.surface pointer) to (a)
> avoid use-after-free and
On 13.07.2020 15:41, Eric Blake wrote:
On 7/13/20 2:27 AM, Andrey Shinkevich wrote:
Add dirty bitmap information to QCOW2 metadata dump in the
qcow2_format.py.
v9:
01: In patch 0003, removed explicit constructor in the class
Qcow2BitmapExt.
02: In patch 0004, the format string was chan
On 7/1/20 5:53 AM, Vladimir Sementsov-Ogievskiy wrote:
Consider nbd_export_close_all(). The call-stack looks like this:
nbd_export_close_all() -> nbd_export_close -> call client_close() for
each client.
client_close() doesn't guarantee that client is closed: nbd_trip()
keeps reference to it. S
On Fri, 10 Jul 2020 at 14:31, Markus Armbruster wrote:
>
> The previous commit enables conversion of
>
> foo(..., &err);
> if (err) {
> ...
> }
>
> to
>
> if (!foo(..., &err)) {
> ...
> }
>
> for QemuOpts functions that now return true / false on success /
> err
On 7/1/20 5:53 AM, Vladimir Sementsov-Ogievskiy wrote:
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/iotests.py | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
Reviewed-by: Eric Blake
diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests
I don't profess to understand most of this, I am just a user who found
something didn't work and tracked down the cause with help from the
people on the bugtracker.
the min=1 and max=4 was chosen as it seems to be set that way in most
other places in the source, and 2 fits in that range.
so
Built the latest QEMU, the issue goes away
$ bin/debug/native/s390x-linux-user/qemu-s390x --version
qemu-s390x version 5.0.50 (v5.0.0-2358-g6c87d9f311-dirty)
Copyright (c) 2003-2020 Fabrice Bellard and the QEMU Project developers
$ bin/debug/native/s390x-linux-user/qemu-s390x ../njs/njs-s390 -c
Am 13.07.2020 um 11:08 hat Max Reitz geschrieben:
> On 10.07.20 18:12, Max Reitz wrote:
> > On 07.07.20 18:17, Kevin Wolf wrote:
> >> Am 07.07.2020 um 16:23 hat Kevin Wolf geschrieben:
> >>> Espeically when O_DIRECT is used with image files so that the page cache
> >>> indirection can't cause a mer
On Sat, 4 Jul 2020 at 17:41, Philippe Mathieu-Daudé wrote:
>
> The 'gen_id' argument refers to a QOM object able to produce
> data consumable by the fw_cfg device. The producer object must
> implement the FW_CFG_DATA_GENERATOR interface.
>
> Reviewed-by: Laszlo Ersek
> Signed-off-by: Philippe Mat
John Snow writes:
> I'm proposing that I split the actual Python library off from the other
> miscellaneous python scripts we have and declare it maintained. Add
> myself as a maintainer of this folder, along with Cleber.
>
> Signed-off-by: John Snow
> ---
> MAINTAINERS | 9 -
> 1 fil
101 - 200 of 480 matches
Mail list logo
