Re: Delete some Wiki pages (was: Migrating custom qemu.org infrastructure to GitLab)

2020-07-09 Thread Daniel P . Berrangé
On Thu, Jul 09, 2020 at 03:10:44PM +0200, Thomas Huth wrote: > On 09/07/2020 12.33, Paolo Bonzini wrote: > > On 09/07/20 12:22, Thomas Huth wrote: > >> FWIW, seems like we could use the "pandoc" tool to convert Mediawiki > >> (our old Wiki) to Markdown (Gitlab wiki). I've done a quick test and > >>

Re: [PATCH v2 0/3] Add ability to choose MDIO phy number to i.MX processors

2020-07-09 Thread Peter Maydell
On Sat, 4 Jul 2020 at 20:12, Jean-Christophe Dubois wrote: > > This patch set adds the ability to select the Ethernet PHY device number > for the i.MX25 processor, the i.MX6 processor and the i.MX7 processor. > > Note: the i.MX6UL processor was addressed in a previous patch. > > Jean-Christophe D

Re: [PATCH] cpu: Add starts_halted() method

2020-07-09 Thread Philippe Mathieu-Daudé
On 7/9/20 3:13 PM, Greg Kurz wrote: > On Thu, 9 Jul 2020 14:21:04 +0200 > Philippe Mathieu-Daudé wrote: > >> On 7/9/20 12:55 PM, Greg Kurz wrote: >>> On Thu, 9 Jul 2020 12:18:06 +0200 >>> Philippe Mathieu-Daudé wrote: >>> > > [...] > > > FYI, PAPR requires all vCPUs to be "stopped" by

Re: [PATCH v10 34/34] iotests: Add tests for qcow2 images with extended L2 entries

2020-07-09 Thread Max Reitz
On 03.07.20 17:58, Alberto Garcia wrote: > Signed-off-by: Alberto Garcia > --- > tests/qemu-iotests/271 | 901 + > tests/qemu-iotests/271.out | 724 + > tests/qemu-iotests/group | 1 + > 3 files changed, 1626 insertions(+) >

Re: Delete some Wiki pages (was: Migrating custom qemu.org infrastructure to GitLab)

2020-07-09 Thread Paolo Bonzini
On 09/07/20 15:10, Thomas Huth wrote: > - https://wiki.qemu.org/Features/40p : > - https://wiki.qemu.org/Features/PRePCleanup : > - https://wiki.qemu.org/Features/BeBox > - https://wiki.qemu.org/Features/DriveRefactoring > - https://wiki.qemu.org/Features/LegacyRemoval > - https://wiki.qemu.org/Fea

[PATCH 4/6] block, migration: add bdrv_finalize_vmstate helper

2020-07-09 Thread Denis V. Lunev
Right now bdrv_fclose() is just calling bdrv_flush(). The problem is that migration code is working inefficiently from block layer terms and are frequently called for very small pieces of unaligned data. Block layer is capable to work this way, but this is very slow. This patch is a preparation f

[PATCH 3/6] block/block-backend: remove always true check from blk_save_vmstate

2020-07-09 Thread Denis V. Lunev
bdrv_save_vmstate() returns either error with negative return value or size. Thus this check is useless. Signed-off-by: Denis V. Lunev Suggested-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy CC: Kevin Wolf CC: Max Reitz CC: Stefan Hajnoczi CC: Fam Zheng CC: Juan Quintela CC: "Dr

[PATCH 2/6] block/aio_task: drop aio_task_pool_wait_one() helper

2020-07-09 Thread Denis V. Lunev
It is not used outside the module. Actually there are 2 kind of waiters: - for a slot and - for all tasks to finish This patch limits external API to listed types. Signed-off-by: Denis V. Lunev Suggested-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Vladimir Sementsov-Ogievskiy CC: Kevin Wolf

[PATCH 1/6] block/aio_task: allow start/wait task from any coroutine

2020-07-09 Thread Denis V. Lunev
From: Vladimir Sementsov-Ogievskiy Currently, aio task pool assumes that there is a main coroutine, which creates tasks and wait for them. Let's remove the restriction by using CoQueue. Code becomes clearer, interface more obvious. Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Deni

[PATCH v8 0/6] block: seriously improve savevm/loadvm performance

2020-07-09 Thread Denis V. Lunev
This series do standard basic things: - it creates intermediate buffer for all writes from QEMU migration code to QCOW2 image, - this buffer is sent to disk asynchronously, allowing several writes to run in parallel. In general, migration code is fantastically inefficent (by observation), buff

[PATCH 6/6] block/io: improve loadvm performance

2020-07-09 Thread Denis V. Lunev
This patch creates intermediate buffer for reading from block driver state and performs read-ahead to this buffer. Snapshot code performs reads sequentially and thus we know what offsets will be required and when they will become not needed. Results are fantastic. Switch to snapshot times of 2GB F

[PATCH 5/6] block/io: improve savevm performance

2020-07-09 Thread Denis V. Lunev
This patch does 2 standard basic things: - it creates intermediate buffer for all writes from QEMU migration code to block driver, - this buffer is sent to disk asynchronously, allowing several writes to run in parallel. Thus bdrv_vmstate_write() is becoming asynchronous. All pending operation

[PATCH] softmmu/vl: Include "qemu/rcu.h" for rcu_disable_atfork()

2020-07-09 Thread Philippe Mathieu-Daudé
In commit 73c6e4013b we let vl.c use rcu_disable_atfork() which is declared in "qemu/rcu.h", but forgot to include this header. Fortunately has never been a problem since vl.c includes "exec/memory.h" which includes "qemu/rcu.h". Include the missing header now in case we split vl.c later. Fixes:

Re: [PATCH] Fix MIPS add.s after 1ace099f2acb952eaaef0ba7725879949a7e4406

2020-07-09 Thread Philippe Mathieu-Daudé
Hi Aleksandar, On 7/7/20 6:26 PM, Aleksandar Markovic wrote: > On Fri, Jul 3, 2020 at 6:33 PM Alex Richardson > wrote: >> >> After merging latest QEMU upstream into our CHERI fork, I noticed that >> some of the FPU tests in our MIPS baremetal testsuite >> (https://github.com/CTSRD-CHERI/cheritest

Re: [PATCH-for-5.1 2/2] fuzz: add missing header for rcu_enable_atfork

2020-07-09 Thread Alexander Bulekov
On 200709 0718, Thomas Huth wrote: > On 08/07/2020 22.01, Alexander Bulekov wrote: > > In 45222b9a90, I fixed a broken check for rcu_enable_atfork introduced > > in d6919e4cb6. I added a call to rcu_enable_atfork after the > > call to qemu_init in fuzz.c, but forgot to include the corresponding > >

Re: [PATCH v10 31/34] qcow2: Add the 'extended_l2' option and the QCOW2_INCOMPAT_EXTL2 bit

2020-07-09 Thread Alberto Garcia
On Thu 09 Jul 2020 03:07:29 PM CEST, Max Reitz wrote: > On 03.07.20 17:58, Alberto Garcia wrote: >> Now that the implementation of subclusters is complete we can finally >> add the necessary options to create and read images with this feature, >> which we call "extended L2 entries". >> >> Signed-o

Re: [PATCH] cpu: Add starts_halted() method

2020-07-09 Thread Peter Maydell
On Thu, 9 Jul 2020 at 14:13, Greg Kurz wrote: > On Thu, 9 Jul 2020 14:21:04 +0200 > Philippe Mathieu-Daudé wrote: > > The machine simply has to set the 'start-powered-off' flag on > > all vCPUS except the 1st one. > > > > We only want the first vCPU to start when the platform is > fully configure

Re: [PATCH] tests/qtest/fuzz: Add missing spaces in description

2020-07-09 Thread Alexander Bulekov
On 200709 1228, Philippe Mathieu-Daudé wrote: > On 7/9/20 10:37 AM, Thomas Huth wrote: > > There should be a space between "forking" and "for". > > > > Signed-off-by: Thomas Huth > > --- > > tests/qtest/fuzz/virtio_scsi_fuzz.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > >

[Bug 1886811] Re: systemd complains Failed to enqueue loopback interface start request: Operation not supported

2020-07-09 Thread Bug Watch Updater
** Changed in: qemu (Debian) Status: Unknown => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1886811 Title: systemd complains Failed to enqueue loopback interface start request:

Re: [Bug 1885827] Re: building plugin failed on Windows with mingw

2020-07-09 Thread Alex Bennée
Emilio G. Cota <1885...@bugs.launchpad.net> writes: > You should then find out why libqemu_plugin.dll.a is not working. It is > possible though that your linked is calling the import library something > else, for instance adding a .dll extension to it. > > You will have to run a few tests with y

[PATCH] block: Avoid stale pointer dereference in blk_get_aio_context()

2020-07-09 Thread Greg Kurz
It is possible for blk_remove_bs() to race with blk_drain_all(), causing the latter to dereference a stale blk->root pointer: blk_remove_bs(blk) bdrv_root_unref_child(blk->root) child_bs = blk->root->bs bdrv_detach_child(blk->root) ... g_free(blk->root) <== blk-

Re: [PATCH 2/2] hw/sd/sdcard: Do not allow invalid SD card sizes

2020-07-09 Thread Philippe Mathieu-Daudé
On 7/7/20 10:29 PM, Niek Linnenbank wrote: > Hi Philippe, > > Just tried out your patch on latest master, and I noticed I couldn't > apply it without getting this error: > > $ git am ~/Downloads/patches/\[PATCH\ 2_2\]\ hw_sd_sdcard\:\ Do\ not\ > allow\ invalid\ SD\ card\ sizes\ -\ Philippe\ Mathi

Re: [PATCH-for-5.1 2/2] fuzz: add missing header for rcu_enable_atfork

2020-07-09 Thread Thomas Huth
On 09/07/2020 15.38, Alexander Bulekov wrote: > On 200709 0718, Thomas Huth wrote: >> On 08/07/2020 22.01, Alexander Bulekov wrote: >>> In 45222b9a90, I fixed a broken check for rcu_enable_atfork introduced >>> in d6919e4cb6. I added a call to rcu_enable_atfork after the >>> call to qemu_init in fu

Re: [PATCH v10 31/34] qcow2: Add the 'extended_l2' option and the QCOW2_INCOMPAT_EXTL2 bit

2020-07-09 Thread Max Reitz
On 03.07.20 17:58, Alberto Garcia wrote: > Now that the implementation of subclusters is complete we can finally > add the necessary options to create and read images with this feature, > which we call "extended L2 entries". > > Signed-off-by: Alberto Garcia > Reviewed-by: Eric Blake > Reviewed-

Re: [RFC v2 1/1] memory: Delete assertion in memory_region_unregister_iommu_notifier

2020-07-09 Thread Peter Xu
On Thu, Jul 09, 2020 at 01:58:33PM +0800, Jason Wang wrote: > > > - If we care the performance, it's better to implement the MAP event for > > > vhost, otherwise it could be a lot of IOTLB miss > > I feel like these are two things. > > > > So far what we are talking about is whether vt-d should ha

[PATCH v1 00/13] misc rc0 fixes (docs, plugins, docker)

2020-07-09 Thread Alex Bennée
Hi, These are some candidate patches for rc0 along with a few plugin patches that haven't yet gotten review. The new functionality won't get added to the PR but I'd like to get the cputlb fix in. Alongside the plugin stuff there are some documentation updates which are worth adding and some tweak

[PATCH v1 01/13] docs/devel: convert and update MTTCG design document

2020-07-09 Thread Alex Bennée
Do a light conversion to .rst and clean-up some of the language at the start now MTTCG has been merged for a while. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- docs/devel/index.rst | 1 + ...ti-thread-tcg.txt => multi-thread-tcg.rst} | 52

[PATCH v1 02/13] docs/devel: add some notes on tcg-icount for developers

2020-07-09 Thread Alex Bennée
This attempts to bring together my understanding of the requirements for icount behaviour into one reference document for our developer notes. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Cc: Paolo Bonzini Cc: Pavel Dovgalyuk Cc: Peter Maydell Message-Id: <20200619135844.23307-1-

[PATCH v1 03/13] docs: Add to gdbstub documentation the PhyMemMode

2020-07-09 Thread Alex Bennée
From: Jon Doron The PhyMemMode gdb extension command was missing from the gdb.rst document. Signed-off-by: Jon Doron Signed-off-by: Alex Bennée Message-Id: <20200601171609.1665397-1-ari...@gmail.com> --- docs/system/gdb.rst | 20 1 file changed, 20 insertions(+) diff --g

[PATCH v1 08/13] plugins: expand the bb plugin to be thread safe and track per-cpu

2020-07-09 Thread Alex Bennée
While there isn't any easy way to make the inline counts thread safe we can ensure the callback based ones are. While we are at it we can reduce introduce a new option ("idle") to dump a report of the current bb and insn count each time a vCPU enters the idle state. Signed-off-by: Alex Bennée Cc:

[PATCH v1 04/13] cputlb: ensure we save the IOTLB data in case of reset

2020-07-09 Thread Alex Bennée
Any write to a device might cause a re-arrangement of memory triggering a TLB flush and potential re-size of the TLB invalidating previous entries. This would cause users of qemu_plugin_get_hwaddr() to see the warning: invalid use of qemu_plugin_get_hwaddr because of the failed tlb_lookup which

[PATCH v1 06/13] plugins: add API to return a name for a IO device

2020-07-09 Thread Alex Bennée
This may well end up being anonymous but it should always be unique. Signed-off-by: Alex Bennée [r-b provisional given change to g_intern_string] Reviewed-by: Clement Deschamps Reviewed-by: Emilio G. Cota --- v3 - return a non-freeable const g_intern_string() - checkpatch cleanups --- inc

[PATCH v1 05/13] hw/virtio/pci: include vdev name in registered PCI sections

2020-07-09 Thread Alex Bennée
When viewing/debugging memory regions it is sometimes hard to figure out which PCI device something belongs to. Make the names unique by including the vdev name in the name string. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Michael S. Tsirkin --- v2 - swap ()

[PATCH v1 10/13] tests/plugins: add -Wno-unknown-warning-option to handle -Wpsabi

2020-07-09 Thread Alex Bennée
Not all compilers support the -Wpsabi (clang-9 in my case). Fixes: bac8d222a Signed-off-by: Alex Bennée --- tests/plugin/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/plugin/Makefile b/tests/plugin/Makefile index 0cb8e35ae407..dcfbd99b15b8 100644 --- a/tests/

[PATCH v1 11/13] tests/docker: fall back more gracefully when pull fails

2020-07-09 Thread Alex Bennée
I only spotted this in the small window between my testing with my registry while waiting for the gitlab PR to go in. As we pre-pull the registry image we know if that fails there isn't any point attempting to use the cache. Fall back to the way we used to do it at that point. Signed-off-by: Alex

[PATCH v1 09/13] target/sh4: revert to using cpu_lduw_code to decode gusa

2020-07-09 Thread Alex Bennée
The translator_ld* functions very much expect us to be decoding one instruction at a time. Otherwise we will see weirdness such as: qemu-sh4: warning: plugin_disas: 6 bytes left over when we use the disas functions. For what SH4 is doing here (scanning ahead in the instruction stream) this is t

[PATCH v1 13/13] configure: remove all dependencies on a (re)configure

2020-07-09 Thread Alex Bennée
The previous code was brittle and missed cases such as the mipn32 variants which for some reason has the 64 bit syscalls. This leads to a number of binary targets having deps lines like: all.clang-sanitizer/mipsn32el-linux-user/linux-user/signal.d 140: /home/alex/lsrc/qemu.git/linux-user/mips

Re: [PATCH 2/2] hw/sd/sdcard: Do not allow invalid SD card sizes

2020-07-09 Thread Peter Maydell
On Thu, 9 Jul 2020 at 14:56, Philippe Mathieu-Daudé wrote: > > On 7/7/20 10:29 PM, Niek Linnenbank wrote: > > So I manually copy & pasted the change into hw/sd/sd.c to test it. > > It looks like the check works, but my concern is that with this change, > > we will be getting this error on 'off-the

[PATCH v1 07/13] plugins: new hwprofile plugin

2020-07-09 Thread Alex Bennée
This is a plugin intended to help with profiling access to various bits of system hardware. It only really makes sense for system emulation. It takes advantage of the recently exposed helper API that allows us to see the device name (memory region name) associated with a device. You can specify a

[PATCH v1 12/13] tests/docker: update toolchain set in debian-xtensa-cross

2020-07-09 Thread Alex Bennée
From: Max Filippov Switch to the prebuilt xtensa toolchains release 2020.07. Drop csp toolchain as the csp core is not a part of QEMU. Add de233_fpu and dsp3400 toolchains to enable DFPU and FPU2000 tests. Signed-off-by: Max Filippov Signed-off-by: Alex Bennée Message-Id: <20200708082347.27318

Re: [PATCH] virtio-iommu: Fix coverity issue in virtio_iommu_handle_command()

2020-07-09 Thread Peter Maydell
On Wed, 8 Jul 2020 at 17:02, Eric Auger wrote: > > Coverity points out (CID 1430180) that the new case is missing > break or a /* fallthrough */ comment. Break is the right thing to > do as in that case, tail is not used. > > Fixes 1733eebb9e ("virtio-iommu: Implement RESV_MEM probe request") > Si

Re: [PATCH] target/arm: Don't do raw writes for PMINTENCLR

2020-07-09 Thread Peter Maydell
On Tue, 7 Jul 2020 at 16:26, Aaron Lindsay wrote: > > Raw writes to this register when in KVM mode can cause interrupts to be > raised (even when the PMU is disabled). Because the underlying state is > already aliased to PMINTENSET (which already provides raw write > functions), we can safely disa

Re: [PATCH v7 00/21] Initial support for multi-process qemu

2020-07-09 Thread Jag Raman
> On Jul 2, 2020, at 9:40 AM, Stefan Hajnoczi wrote: > > On Sat, Jun 27, 2020 at 10:09:22AM -0700, elena.ufimts...@oracle.com wrote: >> From: Elena Ufimtseva >> >> This is the v7 of the patchset. > > I have completed the review and left comments on the patches. > > I'm glad it was possible

Re: [PATCH v7 03/21] multi-process: setup PCI host bridge for remote device

2020-07-09 Thread Jag Raman
> On Jun 30, 2020, at 11:17 AM, Stefan Hajnoczi wrote: > > On Sat, Jun 27, 2020 at 10:09:25AM -0700, elena.ufimts...@oracle.com wrote: >> diff --git a/hw/pci-host/remote.c b/hw/pci-host/remote.c >> new file mode 100644 >> index 00..5ea9af4154 >> --- /dev/null >> +++ b/hw/pci-host/remot

Re: [PATCH 2/2] hw/sd/sdcard: Do not allow invalid SD card sizes

2020-07-09 Thread Philippe Mathieu-Daudé
On 7/9/20 4:15 PM, Peter Maydell wrote: > On Thu, 9 Jul 2020 at 14:56, Philippe Mathieu-Daudé wrote: >> >> On 7/7/20 10:29 PM, Niek Linnenbank wrote: >>> So I manually copy & pasted the change into hw/sd/sd.c to test it. >>> It looks like the check works, but my concern is that with this change, >

Re: [PATCH v1 03/13] docs: Add to gdbstub documentation the PhyMemMode

2020-07-09 Thread Philippe Mathieu-Daudé
On 7/9/20 4:13 PM, Alex Bennée wrote: > From: Jon Doron > > The PhyMemMode gdb extension command was missing from the gdb.rst > document. > > Signed-off-by: Jon Doron > Signed-off-by: Alex Bennée > Message-Id: <20200601171609.1665397-1-ari...@gmail.com> > --- > docs/system/gdb.rst | 20 ++

Re: [REPORT] [GSoC - TCG Continuous Benchmarking] [#3] QEMU 5.0 and 5.1-pre-soft-freeze Dissect Comparison

2020-07-09 Thread Alex Bennée
Ahmed Karaman writes: > Hi, > > The third report of the TCG Continuous Benchmarking series utilizes > the tools presented in the previous report for comparing the > performance of 17 different targets across two versions of QEMU. The > two versions addressed are 5.0 and 5.1-pre-soft-freeze (cur

Re: [PATCH v1 09/13] target/sh4: revert to using cpu_lduw_code to decode gusa

2020-07-09 Thread Philippe Mathieu-Daudé
On 7/9/20 4:13 PM, Alex Bennée wrote: > The translator_ld* functions very much expect us to be decoding one > instruction at a time. Otherwise we will see weirdness such as: > > qemu-sh4: warning: plugin_disas: 6 bytes left over > > when we use the disas functions. For what SH4 is doing here (s

Re: [PATCH v1 11/13] tests/docker: fall back more gracefully when pull fails

2020-07-09 Thread Philippe Mathieu-Daudé
On 7/9/20 4:13 PM, Alex Bennée wrote: > I only spotted this in the small window between my testing with my > registry while waiting for the gitlab PR to go in. As we pre-pull the > registry image we know if that fails there isn't any point attempting > to use the cache. Fall back to the way we used

Re: [PATCH v7 14/47] stream: Deal with filters

2020-07-09 Thread Andrey Shinkevich
On 25.06.2020 18:21, Max Reitz wrote: Because of the (not so recent anymore) changes that make the stream job independent of the base node and instead track the node above it, we have to split that "bottom" node into two cases: The bottom COW node, and the node directly above the base node (which

Re: [PATCH v1 12/13] tests/docker: update toolchain set in debian-xtensa-cross

2020-07-09 Thread Philippe Mathieu-Daudé
On 7/9/20 4:13 PM, Alex Bennée wrote: > From: Max Filippov > > Switch to the prebuilt xtensa toolchains release 2020.07. > Drop csp toolchain as the csp core is not a part of QEMU. > Add de233_fpu and dsp3400 toolchains to enable DFPU and FPU2000 tests. Yay thanks Max! Reviewed-by: Philippe Mat

Re: [PULL 00/12] Block patches

2020-07-09 Thread Kevin Wolf
Am 08.07.2020 um 00:05 hat Eduardo Habkost geschrieben: > On Tue, Jul 07, 2020 at 05:28:21PM +0200, Philippe Mathieu-Daudé wrote: > > On 6/26/20 12:25 PM, Stefan Hajnoczi wrote: > > > On Thu, Jun 25, 2020 at 02:31:14PM +0100, Peter Maydell wrote: > > >> On Wed, 24 Jun 2020 at 11:02, Stefan Hajnocz

Re: [PATCH v1 06/13] plugins: add API to return a name for a IO device

2020-07-09 Thread Philippe Mathieu-Daudé
On 7/9/20 4:13 PM, Alex Bennée wrote: > This may well end up being anonymous but it should always be unique. > > Signed-off-by: Alex Bennée > [r-b provisional given change to g_intern_string] > Reviewed-by: Clement Deschamps > Reviewed-by: Emilio G. Cota > > --- > v3 > - return a non-freeabl

Re: [PULL 18/31] block/core: add generic infrastructure for x-blockdev-amend qmp command

2020-07-09 Thread Peter Maydell
On Mon, 6 Jul 2020 at 11:05, Max Reitz wrote: > > From: Maxim Levitsky > > blockdev-amend will be used similiar to blockdev-create > to allow on the fly changes of the structure of the format based block > devices. > > Current plan is to first support encryption keyslot management for luks > bas

Is VXHS actually maintained?

2020-07-09 Thread Marc-André Lureau
Hi, VXHS block device was added ~3y ago in commit da92c3ff60b (block/vxhs.c: Add support for a new block device type called "vxhs"), but it doesn't compile anymore, at least since v5.0 (I haven't checked earlier). The upstream repository (https://github.com/VeritasHyperScale/libqnio) hasn't recei

Re: [PATCH v3 1/1] scripts/performance: Add dissect.py script

2020-07-09 Thread Philippe Mathieu-Daudé
On 7/9/20 7:20 AM, Ahmed Karaman wrote: > Python script that dissects QEMU execution into three main phases: > code generation, JIT execution and helpers execution. > > Syntax: > dissect.py [-h] -- [] \ > [] > > [-h] - Print the script arguments help message. > > Example of us

Re: [PULL v2 40/41] vhost-vdpa: introduce vhost-vdpa backend

2020-07-09 Thread Peter Maydell
On Sat, 4 Jul 2020 at 19:31, Michael S. Tsirkin wrote: > > From: Cindy Lu > > Currently we have 2 types of vhost backends in QEMU: vhost kernel and > vhost-user. The above patch provides a generic device for vDPA purpose, > this vDPA device exposes to user space a non-vendor-specific configuratio

Re: [PATCH v7 14/47] stream: Deal with filters

2020-07-09 Thread Andrey Shinkevich
On 25.06.2020 18:21, Max Reitz wrote: Because of the (not so recent anymore) changes that make the stream job independent of the base node and instead track the node above it, we have to split that "bottom" node into two cases: The bottom COW node, and the node directly above the base node (which

Re: [PULL 11/12] linux-user: Add strace support for printing arguments of ioctl()

2020-07-09 Thread Peter Maydell
On Sat, 4 Jul 2020 at 17:36, Laurent Vivier wrote: > > From: Filip Bozuta > > This patch implements functionality for strace argument printing for ioctls. Hi; Coverity points out some issues in this change: > +#ifdef TARGET_NR_ioctl > +static void > +print_syscall_ret_ioctl(const struct syscal

Re: Is VXHS actually maintained?

2020-07-09 Thread Thomas Huth
On 09/07/2020 17.10, Marc-André Lureau wrote: > Hi, > > VXHS block device was added ~3y ago in commit da92c3ff60b (block/vxhs.c: > Add support for a new block device type called "vxhs"), but it doesn't > compile anymore, at least since v5.0 (I haven't checked earlier). > > The upstream repository

[PATCH] hw/cpu/a9mpcore: Verify the machine use Cortex-A9 cores

2020-07-09 Thread Philippe Mathieu-Daudé
The 'Cortex-A9MPCore internal peripheral' block can only be used with Cortex A5 and A9 cores. As we don't model the A5 yet, simply check the machine cpu core is a Cortex A9. If not return an error. Signed-off-by: Philippe Mathieu-Daudé --- hw/cpu/a9mpcore.c | 12 +++- 1 file changed, 11

Re: [PATCH v2 2/3] virtio-balloon: Add locking to prevent possible race when starting hinting

2020-07-09 Thread Peter Maydell
On Mon, 6 Jul 2020 at 22:15, Alexander Duyck wrote: > > From: Alexander Duyck > > There is already locking in place when we are stopping free page hinting > but there is not similar protections in place when we start. I can only > assume this was overlooked as in most cases the page hinting shoul

Re: Is VXHS actually maintained?

2020-07-09 Thread Philippe Mathieu-Daudé
On 7/9/20 5:20 PM, Thomas Huth wrote: > On 09/07/2020 17.10, Marc-André Lureau wrote: >> Hi, >> >> VXHS block device was added ~3y ago in commit da92c3ff60b (block/vxhs.c: >> Add support for a new block device type called "vxhs"), but it doesn't >> compile anymore, at least since v5.0 (I haven't ch

Re: [PATCH] softmmu/vl: Include "qemu/rcu.h" for rcu_disable_atfork()

2020-07-09 Thread Alexander Bulekov
Reviewed-by: Alexander Bulekov If rcu.h should be explicitly included, should any of these other files that reference the rcu but do not explicitly #include qemu/rcu.h also get such includes? util/qht.c 166:struct rcu_head rcu; migration/savevm.c 1822:rcu_register_thread(); util/log.c

Re: Is VXHS actually maintained?

2020-07-09 Thread Daniel P . Berrangé
On Thu, Jul 09, 2020 at 05:20:58PM +0200, Thomas Huth wrote: > On 09/07/2020 17.10, Marc-André Lureau wrote: > > Hi, > > > > VXHS block device was added ~3y ago in commit da92c3ff60b (block/vxhs.c: > > Add support for a new block device type called "vxhs"), but it doesn't > > compile anymore, at l

Re: [PATCH v7 14/47] stream: Deal with filters

2020-07-09 Thread Andrey Shinkevich
On 09.07.2020 17:52, Andrey Shinkevich wrote: On 25.06.2020 18:21, Max Reitz wrote: Because of the (not so recent anymore) changes that make the stream job independent of the base node and instead track the node above it, we have to split that "bottom" node into two cases: The bottom COW node, a

Re: [PULL 11/12] linux-user: Add strace support for printing arguments of ioctl()

2020-07-09 Thread Laurent Vivier
Le 09/07/2020 à 17:20, Peter Maydell a écrit : > On Sat, 4 Jul 2020 at 17:36, Laurent Vivier wrote: >> >> From: Filip Bozuta >> >> This patch implements functionality for strace argument printing for ioctls. > > Hi; Coverity points out some issues in this change: > > >> +#ifdef TARGET_NR_ioctl

Re: [PATCH v2 2/3] virtio-balloon: Add locking to prevent possible race when starting hinting

2020-07-09 Thread Peter Maydell
On Thu, 9 Jul 2020 at 16:23, Peter Maydell wrote: Side note: the virtio-dev mailing list produces an error including a random mysqldb related failure if you try to post to it as a non-list-member, which makes it awkward to cross-post to it and to a public list like qemu-devel: : permission denie

Re: Is VXHS actually maintained?

2020-07-09 Thread Peter Maydell
On Thu, 9 Jul 2020 at 16:27, Daniel P. Berrangé wrote: > If it doesn't even compile, do we even need to go through the full > deprecation cycle ? I tend to feel like the release where it first > fails to compile automatically starts the deprecation countdown. Mmm, assuming that it's "couldn't pos

Re: [PATCH 0/2] keepalive default

2020-07-09 Thread Eric Blake
On 7/9/20 3:35 AM, Daniel P. Berrangé wrote: On Wed, Jul 08, 2020 at 10:15:37PM +0300, Vladimir Sementsov-Ogievskiy wrote: Hi all! We understood, that keepalive is almost superfluous with default 2 hours in /proc/tcp_keepalive_time. Forcing user to setup keepalive for the whole system doesn't s

Re: Is VXHS actually maintained?

2020-07-09 Thread Marc-André Lureau
Hi On Thu, Jul 9, 2020 at 7:30 PM Peter Maydell wrote: > On Thu, 9 Jul 2020 at 16:27, Daniel P. Berrangé > wrote: > > If it doesn't even compile, do we even need to go through the full > > deprecation cycle ? I tend to feel like the release where it first > > fails to compile automatically star

Re: [PULL 00/41] testing updates (vm, gitlab, misc build fixes)

2020-07-09 Thread Alex Bennée
Peter Maydell writes: > On Tue, 7 Jul 2020 at 08:09, Alex Bennée wrote: >> >> There will be some docker failures until the official repository has >> seeded but local builds should continue to work. >> >> >> >> The following changes since commit eb6490f544388dd24c0d054a96dd304bc7284450: >

Re: Is VXHS actually maintained?

2020-07-09 Thread Peter Maydell
On Thu, 9 Jul 2020 at 16:42, Marc-André Lureau wrote: > > Hi > > On Thu, Jul 9, 2020 at 7:30 PM Peter Maydell wrote: >> >> On Thu, 9 Jul 2020 at 16:27, Daniel P. Berrangé wrote: >> > If it doesn't even compile, do we even need to go through the full >> > deprecation cycle ? I tend to feel like t

Re: [PATCH] hw/cpu/a9mpcore: Verify the machine use Cortex-A9 cores

2020-07-09 Thread Alistair Francis
On Thu, Jul 9, 2020 at 8:23 AM Philippe Mathieu-Daudé wrote: > > The 'Cortex-A9MPCore internal peripheral' block can only be > used with Cortex A5 and A9 cores. As we don't model the A5 > yet, simply check the machine cpu core is a Cortex A9. If > not return an error. > > Signed-off-by: Philippe M

Re: Is VXHS actually maintained?

2020-07-09 Thread Alex Bennée
Marc-André Lureau writes: > Hi > > On Thu, Jul 9, 2020 at 7:30 PM Peter Maydell wrote: > > On Thu, 9 Jul 2020 at 16:27, Daniel P. Berrangé wrote: > > If it doesn't even compile, do we even need to go through the full > > deprecation cycle ? I tend to feel like the release where it first > >

Re: [PULL 0/7] Trivial branch for 5.1 patches

2020-07-09 Thread Peter Maydell
On Tue, 7 Jul 2020 at 11:54, Laurent Vivier wrote: > > The following changes since commit eb6490f544388dd24c0d054a96dd304bc7284450: > > Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-2020070= > 3' into staging (2020-07-04 16:08:41 +0100) > > are available in the Git reposito

Re: [PATCH] softmmu/vl: Include "qemu/rcu.h" for rcu_disable_atfork()

2020-07-09 Thread Philippe Mathieu-Daudé
On 7/9/20 5:25 PM, Alexander Bulekov wrote: > Reviewed-by: Alexander Bulekov > > If rcu.h should be explicitly included, should any of these other files > that reference the rcu but do not explicitly #include qemu/rcu.h also > get such includes? Personally I think so, yes. > > util/qht.c > 166

Re: Is VXHS actually maintained?

2020-07-09 Thread Peter Maydell
On Thu, 9 Jul 2020 at 16:50, Alex Bennée wrote: > That looks more like it got missed in a clean-up series because we don't > have coverage in our typical builds and CI? Yes, very likely. But there's no point in fixing and then adding CI for a config that our users have demonstrated that they do n

[PATCH 2/4] linux-user: Add support for a group of btrfs ioctls used for snapshots

2020-07-09 Thread Filip Bozuta
This patch implements functionality for following ioctls: BTRFS_IOC_SNAP_CREATE - Creating a subvolume snapshot Create a snapshot of a btrfs subvolume. The snapshot is created using the ioctl's third argument that is a pointer to a 'struct btrfs_ioctl_vol_args' (which was mentioned in

Re: [Bug 1886362] [NEW] Heap use-after-free in lduw_he_p through e1000e_write_to_rx_buffers

2020-07-09 Thread Li Qiang
Alexander Bulekov <1886...@bugs.launchpad.net> 于2020年7月6日周一 上午10:51写道: > > Public bug reported: > > Hello, > This reproducer causes a heap-use-after free. QEMU Built with > --enable-sanitizers: > cat << EOF | ./i386-softmmu/qemu-system-i386 -M q35,accel=qtest \ > -qtest stdio -nographic -monitor n

[PATCH 4/4] linux-user: Add support for a group of btrfs ioctls used to get/set features

2020-07-09 Thread Filip Bozuta
This patch implements functionality for following ioctls: BTRFS_IOC_GET_FEATURES - Getting feature flags Read feature flags for a btrfs filesystem. The feature flags are returned inside the ioctl's third argument which represents a pointer to a following structure type: struct bt

[PATCH 3/4] linux-user: Add support for a group of btrfs ioctls used to manipulate with devices

2020-07-09 Thread Filip Bozuta
This patch implements functionality for following ioctls: BTRFS_IOC_SCAN_DEV - Scanning device for a btrfs filesystem Scan a device for a btrfs filesystem. The device that is to be scanned is passed in the ioctl's third argument which represents a pointer to a 'struct ioc_vol_args' (w

[PATCH 1/4] linux-user: Add support for a group of btrfs ioctls used for subvolumes

2020-07-09 Thread Filip Bozuta
This patch implements functionality of following ioctls: BTRFS_IOC_SUBVOL_CREATE - Creating a btrfs subvolume Create a btrfs subvolume. The subvolume is created using the ioctl's third argument which represents a pointer to a following structure type: struct btrfs_ioctl_vol_args

[PATCH] docs/system/s390x: Improve the 3270 documentation

2020-07-09 Thread Thomas Huth
There is some additional information about the 3270 support in our Wiki at https://wiki.qemu.org/Features/3270 - so let's include this information into the main documentation now to have one single source of information (the Wiki page could later be removed). Signed-off-by: Thomas Huth --- docs/

Re: Is VXHS actually maintained?

2020-07-09 Thread Marc-André Lureau
Hi On Thu, Jul 9, 2020 at 7:52 PM Peter Maydell wrote: > On Thu, 9 Jul 2020 at 16:50, Alex Bennée wrote: > > That looks more like it got missed in a clean-up series because we don't > > have coverage in our typical builds and CI? > > Yes, very likely. But there's no point in fixing and then add

[PATCH 0/4] Add support for a group of btrfs filesystem ioctl

2020-07-09 Thread Filip Bozuta
This series covers support for following btrfs ioctls *BTRFS_SUBVOL_CREATE *BTRFS_IOC_ADD_DEV *BTRFS_SUBVOL_SETFLAGS*BTRFS_IOC_RM_DEV *BTRFS_SUBVOL_GETFLAGS*BTRFS_IOC_DEV_INFO *BTRFS_GET_SUBVOL_INFO*BTRFS_IOC_GET_DEV_STATS *BTRFS_IOC_SNAP_CREATE*BTRFS_IOC_G

[Bug 1883984] Re: QEMU S/390x sqxbr (128-bit IEEE 754 square root) crashes qemu-system-s390x

2020-07-09 Thread Richard Henderson
** Changed in: qemu Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1883984 Title: QEMU S/390x sqxbr (128-bit IEEE 754 square root) crashes qemu-system- s3

Re: [PATCH] disas/sh4: Add missing fallthrough annotations

2020-07-09 Thread Richard Henderson
On 6/29/20 10:59 PM, Thomas Huth wrote: > Add fallthrough annotations to be able to compile the code without > warnings with -Wimplicit-fallthrough. Looking at the code, it seems > like the fallthrough is indeed intended here, so the comments should > be appropriate. > > Signed-off-by: Thomas Huth

Re: [PATCH] tests: improve performance of device-introspect-test

2020-07-09 Thread Markus Armbruster
Laurent Vivier writes: > On 09/07/2020 13:59, Daniel P. Berrangé wrote: >> On Thu, Jul 09, 2020 at 01:44:45PM +0200, Laurent Vivier wrote: >>> On 09/07/2020 13:28, Daniel P. Berrangé wrote: Total execution time with "-m slow" and x86_64 QEMU, drops from 3 minutes 15 seconds, down to 54

Re: [PATCH v5 01/11] hw/misc: Add NPCM7xx System Global Control Registers device model

2020-07-09 Thread Philippe Mathieu-Daudé
On 7/9/20 8:43 AM, Havard Skinnemoen wrote: > On Wed, Jul 8, 2020 at 11:04 PM Philippe Mathieu-Daudé > wrote: >> On 7/9/20 2:35 AM, Havard Skinnemoen wrote: >>> Implement a device model for the System Global Control Registers in the >>> NPCM730 and NPCM750 BMC SoCs. >>> >>> This is primarily used

Re: Is VXHS actually maintained?

2020-07-09 Thread Alex Bennée
Peter Maydell writes: > On Thu, 9 Jul 2020 at 16:50, Alex Bennée wrote: >> That looks more like it got missed in a clean-up series because we don't >> have coverage in our typical builds and CI? > > Yes, very likely. But there's no point in fixing and then adding CI > for a config that our use

Re: [PATCH 2/2] hw/sd/sdcard: Do not allow invalid SD card sizes

2020-07-09 Thread Alistair Francis
On Thu, Jul 9, 2020 at 7:35 AM Philippe Mathieu-Daudé wrote: > > On 7/9/20 4:15 PM, Peter Maydell wrote: > > On Thu, 9 Jul 2020 at 14:56, Philippe Mathieu-Daudé wrote: > >> > >> On 7/7/20 10:29 PM, Niek Linnenbank wrote: > >>> So I manually copy & pasted the change into hw/sd/sd.c to test it. > >

Re: [PATCH v5 08/11] hw/mem: Stubbed out NPCM7xx Memory Controller model

2020-07-09 Thread Philippe Mathieu-Daudé
On 7/9/20 2:36 AM, Havard Skinnemoen wrote: > This just implements the bare minimum to cause the boot block to skip > memory initialization. > > Reviewed-by: Tyrone Ting > Reviewed-by: Cédric Le Goater > Signed-off-by: Havard Skinnemoen > --- > include/hw/arm/npcm7xx.h| 2 + > include/hw/

Re: [PATCH v1 06/13] plugins: add API to return a name for a IO device

2020-07-09 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > On 7/9/20 4:13 PM, Alex Bennée wrote: >> This may well end up being anonymous but it should always be unique. >> >> Signed-off-by: Alex Bennée >> [r-b provisional given change to g_intern_string] >> Reviewed-by: Clement Deschamps >> Reviewed-by: Emilio G. Cot

Re: [PATCH v5 09/11] hw/ssi: NPCM7xx Flash Interface Unit device model

2020-07-09 Thread Philippe Mathieu-Daudé
On 7/9/20 2:36 AM, Havard Skinnemoen wrote: > This implements a device model for the NPCM7xx SPI flash controller. > > Direct reads and writes, and user-mode transactions have been tested in > various modes. Protection features are not implemented yet. > > All the FIU instances are available in t

Re: [PATCH 2/2] x86/cpu: Handle GUEST_MAXPHYADDR < HOST_MAXPHYADDR for hosts that don't support it

2020-07-09 Thread Jim Mattson
On Thu, Jul 9, 2020 at 2:44 AM Gerd Hoffmann wrote: > (2) GUEST_MAXPHYADDR < HOST_MAXPHYADDR > > Mostly fine. Some edge cases, like different page fault errors for > addresses above GUEST_MAXPHYADDR and below HOST_MAXPHYADDR. Which I > think Mohammed fixed in the kernel recently. D

Re: [PATCH v5 01/11] hw/misc: Add NPCM7xx System Global Control Registers device model

2020-07-09 Thread Havard Skinnemoen
On Thu, Jul 9, 2020 at 9:23 AM Philippe Mathieu-Daudé wrote: > > On 7/9/20 8:43 AM, Havard Skinnemoen wrote: > > On Wed, Jul 8, 2020 at 11:04 PM Philippe Mathieu-Daudé > > wrote: > >> On 7/9/20 2:35 AM, Havard Skinnemoen wrote: > >>> Implement a device model for the System Global Control Registe

QEMU | Pipeline #164899134 has failed for master | 3d7cad3c

2020-07-09 Thread GitLab via
Your pipeline has failed. Project: QEMU ( https://gitlab.com/qemu-project/qemu ) Branch: master ( https://gitlab.com/qemu-project/qemu/-/commits/master ) Commit: 3d7cad3c ( https://gitlab.com/qemu-project/qemu/-/commit/3d7cad3c2388cb74451d50cf455a42d349236161 ) Commit Message: Merge remote-tr

[PATCH] spapr_pci: Robustify support of PCI bridges

2020-07-09 Thread Greg Kurz
Some recent error handling cleanups unveiled issues with our support of PCI bridges: 1) QEMU aborts when using non-standard PCI bridge types, unveiled by commit 7ef1553dac "spapr_pci: Drop some dead error handling" $ qemu-system-ppc64 -M pseries -device pcie-pci-bridge Unexpected error in obje

Re: [PATCH v1 08/13] plugins: expand the bb plugin to be thread safe and track per-cpu

2020-07-09 Thread Robert Foley
Reviewed-by: Robert Foley On Thu, 9 Jul 2020 at 10:13, Alex Bennée wrote: > > While there isn't any easy way to make the inline counts thread safe > we can ensure the callback based ones are. While we are at it we can > reduce introduce a new option ("idle") to dump a report of the current > bb

<    1   2   3   4   >