Eric Blake writes:
> On 7/2/20 10:49 AM, Markus Armbruster wrote:
>> When all we do with an Error we receive into a local variable is
>> propagating to somewhere else, we can just as well receive it there
>> right away. The previous commit did that with a Coccinelle script I
>> consider fairly t
Eric Blake writes:
> On 7/2/20 10:49 AM, Markus Armbruster wrote:
>> When all we do with an Error we receive into a local variable is
>> propagating to somewhere else, we can just as well receive it there
>> right away. The previous two commits did that for sufficiently simple
>> cases with Cocc
Eric Blake writes:
> On 7/2/20 10:49 AM, Markus Armbruster wrote:
>> When all we do with an Error we receive into a local variable is
>> propagating to somewhere else, we can just as well receive it there
>> right away, even when we need to keep error_propagate() for other
>> error paths.
>>
>> S
On 03.07.20 00:00, Alberto Garcia wrote:
> On Thu 02 Jul 2020 11:57:46 AM CEST, Max Reitz wrote:
>>> The reason why we would want to check it is, of course, because that
>>> bit does have a meaning in regular L2 entries.
>>>
>>> But that bit is ignored in images with subclusters so the only reason
On 03.07.20 00:40, Alberto Garcia wrote:
> On Thu 02 Jul 2020 04:28:57 PM CEST, Max Reitz wrote:
>>> +/* For full clusters use zero_in_l2_slice() instead */
>>> +assert(nb_subclusters > 0 && nb_subclusters <
>>> s->subclusters_per_cluster);
>>> +assert(sc + nb_subclusters <= s->subclus
On 03.07.20 01:05, Alberto Garcia wrote:
> On Thu 02 Jul 2020 05:09:47 PM CEST, Max Reitz wrote:
>>> Without a backing file, there is no read required - writing to an
>>> unallocated subcluster within a preallocated cluster merely has to
>>> provide zeros to the rest of the write. And depending on
On 2020/7/2 下午11:45, Peter Xu wrote:
On Thu, Jul 02, 2020 at 11:01:54AM +0800, Jason Wang wrote:
So I think we agree that a new notifier is needed?
Good to me, or a new flag should be easier (IOMMU_NOTIFIER_DEV_IOTLB)?
That should work but I wonder something as following is better.
Instea
On 7/3/20 7:34 AM, Thomas Huth wrote:
> On 18/06/2020 09.40, Thomas Huth wrote:
>> The new -accel option does not accept colons in the parameters anymore
>> (since it does not convert the parameters to -machine accel=... parameters
>> anymore). Thus we can now remove the check for colons in -accel:
On 2020/7/1 下午10:55, Cindy Lu wrote:
vDPA device is a device that uses a datapath which complies with the
virtio specifications with vendor specific control path. vDPA devices
can be both physically located on the hardware or emulated by software.
This PATCH introduce the vDPA support in qemu
T
Markus Armbruster writes:
> Vladimir Sementsov-Ogievskiy writes:
>
>> 28.04.2020 08:20, Vladimir Sementsov-Ogievskiy wrote:
>>> 27.04.2020 18:36, Markus Armbruster wrote:
FYI, I'm working on converting QemuOpts, QAPI visitors and QOM. I keep
running into bugs. So far:
[...]
I go
On Mon, Jun 29, 2020 at 5:05 PM Paolo Bonzini wrote:
>
> On 26/06/20 08:41, Eugenio Pérez wrote:
> > If we examinate *entry in frame 4 of backtrace:
> > *entry = {target_as = 0x56f6c050, iova = 0x0, translated_addr = 0x0,
> > addr_mask = 0x, perm = 0x0}
> >
> > Which (I think)
+Damien
On 6/30/20 10:12 PM, Alistair Francis wrote:
> Conver the Ibex UART to use the recently added qdev-clock functions.
Yeah! This is our first user \o/
>
> Signed-off-by: Alistair Francis
> ---
> include/hw/char/ibex_uart.h | 2 ++
> hw/char/ibex_uart.c | 19 ++-
On 6/30/20 10:12 PM, Alistair Francis wrote:
> Commit 5d971f9e672507210e77d020d89e0e89165c8fc9
> "memory: Revert "memory: accept mismatching sizes in
> memory_region_access_valid"" broke most RISC-V boards as they do 64 bit
> accesses to the CLINT and QEMU would trigger a fault. Fix this failure
>
On 28.06.20 13:02, Alberto Garcia wrote:
> Traditional qcow2 images don't allow preallocation if a backing file
> is set. This is because once a cluster is allocated there is no way to
> tell that its data should be read from the backing file.
>
> Extended L2 entries have individual allocation bit
On 28.06.20 13:02, Alberto Garcia wrote:
> This function is only used by qcow2_expand_zero_clusters() to
> downgrade a qcow2 image to a previous version. This would require
> transforming all extended L2 entries into normal L2 entries but this
> is not a simple task and there are no plans to implem
Am 01.07.2020 um 14:58 hat Philippe Mathieu-Daudé geschrieben:
> On 6/29/20 11:34 PM, Klaus Jensen wrote:
> > On Jun 29 14:07, no-re...@patchew.org wrote:
> >> Patchew URL:
> >> https://patchew.org/QEMU/20200629202053.1223342-1-...@irrelevant.dk/
>
> >> --- /tmp/qemu-test/src/tests/qemu-iotests/
On 7/3/20 9:50 AM, Kevin Wolf wrote:
> Am 01.07.2020 um 14:58 hat Philippe Mathieu-Daudé geschrieben:
>> On 6/29/20 11:34 PM, Klaus Jensen wrote:
>>> On Jun 29 14:07, no-re...@patchew.org wrote:
Patchew URL:
https://patchew.org/QEMU/20200629202053.1223342-1-...@irrelevant.dk/
>>
--
Am 30.06.2020 um 10:37 hat Max Reitz geschrieben:
> Waiting on a process for which we have a pipe will stall if the process
> outputs more data than fits into the OS-provided buffer. We must use
> communicate() before wait(), and in fact, communicate() perfectly
> replaces wait() already.
>
> We
On 02/07/2020 21.42, Stefan Brankovic wrote:
Add disassembler for Loongson 2F instruction set.
Testing is done by comparing qemu disassembly output, obtained by
using -d in_asm command line option, with appropriate objdump output.
Signed-off-by: Stefan Brankovic
---
MAINTAINERS |
On 7/3/20 8:34 AM, Klaus Jensen wrote:
> From: Klaus Jensen
>
> Add various additional tracing and streamline nvme_identify_ns and
> nvme_identify_nslist (they do not need to repeat the command, it is
> already in the trace name).
>
> Signed-off-by: Klaus Jensen
> Reviewed-by: Dmitry Fomichev
Am 24.06.2020 um 16:04 hat Alex Bennée geschrieben:
> From: Philippe Mathieu-Daudé
>
> Commit 96927c744 replaced qdev_init_nofail() call by
> isa_realize_and_unref() which has a different error
> message. Update the test output accordingly.
>
> Gitlab CI error after merging b77b5b3dc7:
> https
On Donnerstag, 2. Juli 2020 19:23:35 CEST Christian Schoenebeck wrote:
> > > Back to the actual topic: so what do we do about the mutex then? CoMutex
> > > for 9p2000.u and Mutex for 9p2000.L? I know you find that ugly, but it
> > > would just be a transitional measure.
> >
> > That would ruin my
On 7/3/20 8:34 AM, Klaus Jensen wrote:
> From: Klaus Jensen
>
> It might seem weird to implement this feature for an emulated device,
> but it is mandatory to support and the feature is useful for testing
> asynchronous event request support, which will be added in a later
> patch.
It might be i
On Jul 3 10:03, Philippe Mathieu-Daudé wrote:
> On 7/3/20 8:34 AM, Klaus Jensen wrote:
> > From: Klaus Jensen
> >
> > Add various additional tracing and streamline nvme_identify_ns and
> > nvme_identify_nslist (they do not need to repeat the command, it is
> > already in the trace name).
> >
>
Public bug reported:
GCC 11 reports the following errors:
[ 125s] In file included from
/home/abuild/rpmbuild/BUILD/qemu-5.0.0/include/qemu/seqlock.h:17,
[ 125s] from
/home/abuild/rpmbuild/BUILD/qemu-5.0.0/include/qemu/qht.h:10,
[ 125s] from
/home/abuild/rp
On 7/3/20 8:34 AM, Klaus Jensen wrote:
> From: Klaus Jensen
>
> The SUBNQN field is mandatory in NVM Express 1.3.
>
> Signed-off-by: Klaus Jensen
> Reviewed-by: Maxim Levitsky
> Reviewed-by: Dmitry Fomichev
> ---
> hw/block/nvme.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/
On Jul 3 10:08, Philippe Mathieu-Daudé wrote:
> On 7/3/20 8:34 AM, Klaus Jensen wrote:
> > From: Klaus Jensen
> >
> > It might seem weird to implement this feature for an emulated device,
> > but it is mandatory to support and the feature is useful for testing
> > asynchronous event request supp
On 7/3/20 8:34 AM, Klaus Jensen wrote:
> From: Klaus Jensen
>
> Reject the nsid broadcast value (0x) and 0xfffe in the
> Active Namespace ID list.
Can we have a definition instead of this 0xfffe magic value please?
>
> Signed-off-by: Klaus Jensen
> ---
> hw/block/nvme.c | 4 +
On Jul 3 10:18, Philippe Mathieu-Daudé wrote:
> On 7/3/20 8:34 AM, Klaus Jensen wrote:
> > From: Klaus Jensen
> >
> > The SUBNQN field is mandatory in NVM Express 1.3.
> >
> > Signed-off-by: Klaus Jensen
> > Reviewed-by: Maxim Levitsky
> > Reviewed-by: Dmitry Fomichev
> > ---
> > hw/block/n
On 7/3/20 8:34 AM, Klaus Jensen wrote:
> From: Klaus Jensen
>
> Since we are not providing the NGUID or EUI64 fields, we must support
> the Namespace UUID. We do not have any way of storing a persistent
> unique identifier, so conjure up a UUID that is just the namespace id.
>
> Signed-off-by: K
On 7/3/20 8:34 AM, Klaus Jensen wrote:
> From: Klaus Jensen
>
> Add support for any remaining mandatory controller operating parameters
> (features).
>
> Signed-off-by: Klaus Jensen
> Reviewed-by: Dmitry Fomichev
> ---
> hw/block/nvme.c | 39 +--
> hw
On 7/3/20 8:34 AM, Klaus Jensen wrote:
> From: Klaus Jensen
>
> Fix a missing cpu_to conversion.
>
> Signed-off-by: Klaus Jensen
> Reviewed-by: Dmitry Fomichev
> ---
> hw/block/nvme.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/block/nvme.c b/hw/block/nvme.c
>
On Jul 3 10:20, Philippe Mathieu-Daudé wrote:
> On 7/3/20 8:34 AM, Klaus Jensen wrote:
> > From: Klaus Jensen
> >
> > Reject the nsid broadcast value (0x) and 0xfffe in the
> > Active Namespace ID list.
>
> Can we have a definition instead of this 0xfffe magic value please?
>
On Thu, Jul 02, 2020 at 01:19:43PM -0500, Eric Blake wrote:
> On 7/2/20 12:57 PM, Daniel P. Berrangé wrote:
> > This wires up support for a new "vmstate" parameter to the QMP commands
> > for snapshots (savevm, loadvm). This parameter accepts block driver
> > state node name.
> >
> > One use case
On Jul 3 10:31, Philippe Mathieu-Daudé wrote:
> On 7/3/20 8:34 AM, Klaus Jensen wrote:
> > From: Klaus Jensen
> >
> > Add support for any remaining mandatory controller operating parameters
> > (features).
> >
> > Signed-off-by: Klaus Jensen
> > Reviewed-by: Dmitry Fomichev
> > ---
> > hw/bl
On Thu, 2 Jul 2020 at 13:23, Gerd Hoffmann wrote:
>
> The following changes since commit fc1bff958998910ec8d25db86cd2f53ff125f7ab:
>
> hw/misc/pca9552: Add missing TypeInfo::class_size field (2020-06-29
> 21:16:10 +0100)
>
> are available in the Git repository at:
>
> git://git.kraxel.org/qem
On 7/2/20 2:20 PM, Gerd Hoffmann wrote:
> See comment. Feels quite hackish. Better ideas anyone?
>
A better idea could be to investigate what and why gets into the variable.
I guess at this point we will need to revisit this later on.
CLaudio
> Signed-off-by: Gerd Hoffmann
> Message-id: 20
The following changes since commit fc1bff958998910ec8d25db86cd2f53ff125f7ab:
hw/misc/pca9552: Add missing TypeInfo::class_size field (2020-06-29 21:16:10
+0100)
are available in the Git repository at:
git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream
for you to fetch cha
From: David Hildenbrand
If something goes wrong during precopy, before stopping the VM, we will
never send a S_DONE indication to the VM, resulting in the hinted pages
not getting released to be used by the guest OS (e.g., Linux).
Easy to reproduce:
1. Start migration (e.g., HMP "migrate -d 'exe
This reverts commit 6d1da867e65f ("tests/migration: Reduce autoconverge initial
bandwidth")
since that change makes unit tests much slower for all developers, while it's
not
a robust way to fix migration tests. Migration tests need to find
a more robust way to discover a reasonable bandwidth with
On systems where the IASL tool exists, we can convert
extected ACPI tables to ASL format, which is useful
for debugging and documentation purposes.
This script does this for all ACPI tables under tests/data/acpi/.
Signed-off-by: Michael S. Tsirkin
---
tests/data/acpi/disassemle-aml.sh | 52
From: David Hildenbrand
RDMA will pin all guest memory (as documented in docs/rdma.txt). We want
to disable RAM block discards - however, to keep it simple use
ram_block_discard_is_required() instead of inhibiting.
Note: It is not sufficient to limit disabling to pin_all. Even when only
conditio
From: David Hildenbrand
E.g., with "pc-q35-4.2", trying to coldplug a virtio-pmem-pci devices
results in
"virtio-pmem-pci not supported on this bus"
Reasons is, that the bus does not support hotplug and, therefore, does
not have a hotplug handler. Let's allow coldplugging virtio-pmem devices
From: David Hildenbrand
Discarding memory does not work as expected. At the time this is called,
we cannot have anyone active that relies on discards to work properly.
Reviewed-by: Dr. David Alan Gilbert
Cc: Paolo Bonzini
Signed-off-by: David Hildenbrand
Message-Id: <20200626072248.78761-5-da
From: David Hildenbrand
VFIO is (except devices without a physical IOMMU or some mediated devices)
incompatible with discarding of RAM. The kernel will pin basically all VM
memory. Let's convert to ram_block_discard_disable(), which can now
fail, in contrast to qemu_balloon_inhibit().
Leave "x-b
From: David Hildenbrand
We want to replace qemu_balloon_inhibit() by something more generic.
Especially, we want to make sure that technologies that really rely on
RAM block discards to work reliably to run mutual exclusive with
technologies that effectively break it.
E.g., vfio will usually pin
From: David Hildenbrand
The only remaining special case is postcopy. It cannot handle
concurrent discards yet, which would result in requesting already sent
pages from the source. Special-case it in virtio-balloon instead.
Introduce migration_in_incoming_postcopy(), to find out if incoming
postc
From: David Hildenbrand
Discarding RAM does not work as expected with protected VMs. Let's
switch to ram_block_discard_disable() for now, as we want to get rid
of qemu_balloon_inhibit(). Note that it will currently never fail, but
might fail in the future with new technologies (e.g., virtio-mem).
From: David Hildenbrand
Account the memory to the configured nid.
Reviewed-by: Pankaj Gupta
Cc: Eduardo Habkost
Cc: Marcel Apfelbaum
Cc: "Michael S. Tsirkin"
Signed-off-by: David Hildenbrand
Message-Id: <20200626072248.78761-15-da...@redhat.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-b
From: David Hildenbrand
AMD SEV will pin all guest memory, mark discarding of RAM broken. At the
time this is called, we cannot have anyone active that relies on discards
to work properly - let's still implement error handling.
Reviewed-by: Dr. David Alan Gilbert
Cc: "Michael S. Tsirkin"
Cc: P
From: David Hildenbrand
Print the memory device info just like for other memory devices.
Reviewed-by: Dr. David Alan Gilbert
Cc: "Dr. David Alan Gilbert"
Cc: "Michael S. Tsirkin"
Signed-off-by: David Hildenbrand
Message-Id: <20200626072248.78761-14-da...@redhat.com>
Reviewed-by: Michael S. T
From: David Hildenbrand
Let's add a proxy for virtio-mem, make it a memory device, and
pass-through the properties.
Reviewed-by: Pankaj Gupta
Cc: "Michael S. Tsirkin"
Cc: Marcel Apfelbaum
Cc: "Dr. David Alan Gilbert"
Cc: Igor Mammedov
Signed-off-by: David Hildenbrand
Message-Id: <202006260
From: David Hildenbrand
Let's wire it up similar to virtio-pmem. Also disallow unplug, so it's
harder for users to shoot themselves into the foot.
Reviewed-by: Pankaj Gupta
Cc: "Michael S. Tsirkin"
Cc: Marcel Apfelbaum
Cc: Paolo Bonzini
Cc: Richard Henderson
Cc: Eduardo Habkost
Cc: Eric Bl
From: David Hildenbrand
This is the very basic/initial version of virtio-mem. An introduction to
virtio-mem can be found in the Linux kernel driver [1]. While it can be
used in the current state for hotplug of a smaller amount of memory, it
will heavily benefit from resizeable memory regions in t
From: David Hildenbrand
Let's make sure patches/bug reports find the right person.
Reviewed-by: Dr. David Alan Gilbert
Cc: "Michael S. Tsirkin"
Cc: Peter Maydell
Cc: Markus Armbruster
Signed-off-by: David Hildenbrand
Message-Id: <20200626072248.78761-13-da...@redhat.com>
Reviewed-by: Michae
From: Andrew Jones
Fixes: 93dd625f8bf7 ("tests/acpi: update expected data files")
Signed-off-by: Andrew Jones
Message-Id: <20200629140938.17566-2-drjo...@redhat.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
tests/qtest/bios-tables-test-allowed-diff.h | 18
From: David Hildenbrand
Let's register the notifier and trigger the qapi event with the right
device id.
MEMORY_DEVICE_SIZE_CHANGE is similar to BALLOON_CHANGE, however on a
memory device level.
Don't unregister the notifier (we neither have finalize() nor unrealize()
for VirtIOPCIProxy, so it'
From: David Hildenbrand
Let's auto-enable it also when maxmem is specified but no slots are
defined. This will result in us properly creating ACPI srat tables,
indicating the maximum possible PFN to the guest OS. Based on this, e.g.,
Linux will enable the swiotlb properly.
This avoids having to
From: David Hildenbrand
The content of unplugged memory is undefined and should not be migrated,
ever. Exclude all unplugged memory during precopy using the precopy notifier
infrastructure introduced for free page hinting in virtio-balloon.
Unplugged memory is marked as "not dirty", meaning it w
From: Peter Xu
Add this entry as suggested by Jason and Michael.
CC: Jason Wang
CC: Michael S. Tsirkin
CC: Paolo Bonzini
Signed-off-by: Peter Xu
Message-Id: <20200701124418.63060-1-pet...@redhat.com>
Acked-by: Jason Wang
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
--
From: David Hildenbrand
We want to make sure that certain properties don't change during
migration, especially to catch user errors in a nice way. Let's migrate
a temporary structure and validate that the properties didn't change.
Reviewed-by: Dr. David Alan Gilbert
Cc: "Michael S. Tsirkin"
Cc
03.07.2020 10:38, Markus Armbruster wrote:
Markus Armbruster writes:
Vladimir Sementsov-Ogievskiy writes:
28.04.2020 08:20, Vladimir Sementsov-Ogievskiy wrote:
27.04.2020 18:36, Markus Armbruster wrote:
FYI, I'm working on converting QemuOpts, QAPI visitors and QOM. I keep
running into b
From: Maxime Coquelin
This patch specifies the VHOST_USER_SET_STATUS and
VHOST_USER_GET_STATUS requests, which are sent by
the master to update and query the Virtio status
in the backend.
Signed-off-by: Maxime Coquelin
Message-Id: <20200618134501.145747-1-maxime.coque...@redhat.com>
Acked-by: J
From: Jason Wang
This patch introduces queue_enabled() method which allows the
transport to implement its own way to report whether or not a queue is
enabled.
Signed-off-by: Jason Wang
Signed-off-by: Cindy Lu
Message-Id: <20200701145538.22333-4-l...@redhat.com>
Reviewed-by: Michael S. Tsirkin
From: David Hildenbrand
Let's add some trace events that might come in handy later.
Cc: "Michael S. Tsirkin"
Cc: "Dr. David Alan Gilbert"
Signed-off-by: David Hildenbrand
Message-Id: <20200626072248.78761-20-da...@redhat.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
From: Jason Wang
Add the check of vhost_set_iotlb_callback
before calling
Signed-off-by: Jason Wang
Signed-off-by: Cindy Lu
Message-Id: <20200701145538.22333-6-l...@redhat.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
Acked-by: Jason Wang
---
hw/virtio/vhost.c | 9
From: Cindy Lu
This is a small function that can get the peer
from given NetClientState and queue_index
Signed-off-by: Cindy Lu
Message-Id: <20200701145538.22333-2-l...@redhat.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
Acked-by: Jason Wang
---
include/net/net.h |
From: Cindy Lu
user the qemu_get_peer to replace the old process
Signed-off-by: Cindy Lu
Reviewed-by: Laurent Vivier
Message-Id: <20200701145538.22333-3-l...@redhat.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
Acked-by: Jason Wang
---
hw/net/vhost_net.c | 16 +
If we want to add some info to errp (by error_prepend() or
error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro.
Otherwise, this info will not be added when errp == &error_fatal
(the program will exit prior to the error_append_hint() or
error_prepend() call). Fix such cases.
If we want
From: Cindy Lu
use the vhost_dev_start callback to send the status to backend
Signed-off-by: Cindy Lu
Message-Id: <20200701145538.22333-8-l...@redhat.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
Acked-by: Jason Wang
---
hw/virtio/vhost.c | 10 +-
1 file cha
From: Cindy Lu
This patch introduces new VhostOps vhost_dev_start callback which allows the
vhost_net set the start/stop status to backend
Signed-off-by: Cindy Lu
Message-Id: <20200701145538.22333-7-l...@redhat.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
Acked-by: J
From: Jason Wang
With version 1, we can detect whether a queue is enabled via
queue_enabled.
Signed-off-by: Jason Wang
Signed-off-by: Cindy Lu
Message-Id: <20200701145538.22333-5-l...@redhat.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
Acked-by: Jason Wang
---
hw/
From: Cindy Lu
This patch introduces new VhostOps vhost_vq_get_addr_op callback to get
the vring addr from the backend
Signed-off-by: Cindy Lu
Message-Id: <20200701145538.22333-9-l...@redhat.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
Acked-by: Jason Wang
---
incl
From: Cindy Lu
use vhost_vq_get_addr callback to get the vq address from backend
Signed-off-by: Cindy Lu
Message-Id: <20200701145538.22333-10-l...@redhat.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
Acked-by: Jason Wang
---
include/hw/virtio/vhost-backend.h | 4 ++
From: David Hildenbrand
We want to send qapi events in case the size of a virtio-mem device
changes. This allows upper layers to always know how much memory is
actually currently consumed via a virtio-mem device.
Unfortuantely, we have to report the id of our proxy device. Let's provide
an easy
From: Cindy Lu
This patch introduces new VhostOps vhost_force_iommu callback
to force enable features bit VIRTIO_F_IOMMU_PLATFORM.
Signed-off-by: Cindy Lu
Message-Id: <20200701145538.22333-11-l...@redhat.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
Acked-by: Jason Wa
From: Cindy Lu
This patch introduces set_config & get_config method which allows
vhost_net set/get the config to backend
Signed-off-by: Cindy Lu
Message-Id: <20200701145538.22333-13-l...@redhat.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
Acked-by: Jason Wang
---
On 7/3/20 10:46 AM, Klaus Jensen wrote:
> On Jul 3 10:31, Philippe Mathieu-Daudé wrote:
>> On 7/3/20 8:34 AM, Klaus Jensen wrote:
>>> From: Klaus Jensen
>>>
>>> Add support for any remaining mandatory controller operating parameters
>>> (features).
>>>
>>> Signed-off-by: Klaus Jensen
>>> Reviewe
From: Cindy Lu
use the vhost_force_iommu callback to force enable feature bit
VIRTIO_F_IOMMU_PLATFORM
Signed-off-by: Cindy Lu
Message-Id: <20200701145538.22333-12-l...@redhat.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
Acked-by: Jason Wang
---
hw/virtio/vhost.c |
From: Cindy Lu
Currently we have 2 types of vhost backends in QEMU: vhost kernel and
vhost-user. The above patch provides a generic device for vDPA purpose,
this vDPA device exposes to user space a non-vendor-specific configuration
interface for setting up a vhost HW accelerator, this patch set i
From: David Hildenbrand
COLO will copy all memory in a RAM block, disable discarding of RAM.
Reviewed-by: Dr. David Alan Gilbert
Tested-by: Lukas Straub
Cc: "Michael S. Tsirkin"
Cc: Hailiang Zhang
Cc: Juan Quintela
Cc: "Dr. David Alan Gilbert"
Signed-off-by: David Hildenbrand
Message-Id:
array_remove_slice() calls array_roll() with array->next - 1 as the
destination index. This is only correct for count == 1, otherwise we're
writing past the end of the array. array->next - count would be correct.
However, this is the only place ever calling array_roll(), so this
rather complicated
Based-on: <20200702155000.3455325-1-arm...@redhat.com>
v11: (based-on "[PATCH v2 00/44] Less clumsy error checking")
01: minor rebase of documentation, keep r-bs
02: - minor comment tweaks [Markus]
- use explicit file name in MAINTAINERS instead of pattern
- add Markus's r-b
03,07,08: raba
From: Cindy Lu
This patch set introduces a new net client type: vhost-vdpa.
vhost-vdpa net client will set up a vDPA device which is specified
by a "vhostdev" parameter.
Signed-off-by: Lingshan Zhu
Signed-off-by: Tiwei Bie
Signed-off-by: Cindy Lu
Signed-off-by: Jason Wang
Message-Id: <202007
Introduce a new ERRP_AUTO_PROPAGATE macro, to be used at start of
functions with an errp OUT parameter.
It has three goals:
1. Fix issue with error_fatal and error_prepend/error_append_hint: user
can't see this additional information, because exit() happens in
error_setg earlier than information
FAT allows only a restricted set of characters in file names, and for
some of the illegal characters, it's actually important that we catch
them: If filenames can contain '/', the guest can construct filenames
containing "../" and escape from the assigned vvfat directory. The same
problem could ari
On 7/3/20 10:37 AM, Klaus Jensen wrote:
> On Jul 3 10:20, Philippe Mathieu-Daudé wrote:
>> On 7/3/20 8:34 AM, Klaus Jensen wrote:
>>> From: Klaus Jensen
>>>
>>> Reject the nsid broadcast value (0x) and 0xfffe in the
>>> Active Namespace ID list.
>>
>> Can we have a definition instead
Script adds ERRP_AUTO_PROPAGATE macro invocation where appropriate and
does corresponding changes in code (look for details in
include/qapi/error.h)
Usage example:
spatch --sp-file scripts/coccinelle/auto-propagated-errp.cocci \
--macro-file scripts/cocci-macro-file.h --in-place --no-show-diff \
If we want to add some info to errp (by error_prepend() or
error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro.
Otherwise, this info will not be added when errp == &error_fatal
(the program will exit prior to the error_append_hint() or
error_prepend() call). Fix such cases.
If we want
On Jul 3 11:14, Philippe Mathieu-Daudé wrote:
> On 7/3/20 10:37 AM, Klaus Jensen wrote:
> > On Jul 3 10:20, Philippe Mathieu-Daudé wrote:
> >> On 7/3/20 8:34 AM, Klaus Jensen wrote:
> >>> From: Klaus Jensen
> >>>
> >>> Reject the nsid broadcast value (0x) and 0xfffe in the
> >>> Acti
If we want to add some info to errp (by error_prepend() or
error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro.
Otherwise, this info will not be added when errp == &error_fatal
(the program will exit prior to the error_append_hint() or
error_prepend() call). Fix such cases.
If we want
The following changes since commit 64f0ad8ad8e13257e7c912df470d46784b55c3fd:
Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2020-07-02' into
staging (2020-07-02 15:54:09 +0100)
are available in the Git repository at:
git://repo.or.cz/qemu/kevin.git tags/for-upstream
for you t
If we want to add some info to errp (by error_prepend() or
error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro.
Otherwise, this info will not be added when errp == &error_fatal
(the program will exit prior to the error_append_hint() or
error_prepend() call). Fix such cases.
If we want
If we want to add some info to errp (by error_prepend() or
error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro.
Otherwise, this info will not be added when errp == &error_fatal
(the program will exit prior to the error_append_hint() or
error_prepend() call). Fix such cases.
If we want
From: Stefan Hajnoczi
The --object option is supported by qemu-storage-daemon but the
qemu_object_opts QemuOptsList wasn't being added. As a result calls to
qemu_find_opts("object") failed with "There is no option group
'object'".
This patch fixes the object-del QMP command.
Signed-off-by: Stef
If we want to add some info to errp (by error_prepend() or
error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro.
Otherwise, this info will not be added when errp == &error_fatal
(the program will exit prior to the error_append_hint() or
error_prepend() call). Fix such cases.
If we want
On 2020/7/3 下午5:27, Zhang, Chen wrote:
Hi Jason,
Maybe missed this updated series?
Thanks
Zhang Chen
Nope :)
It's in my queue. Since I only have those two patches so I don't plan to
send pull request this week.
(Anyway it's not a feature, so we don't need to worry about soft freeze).
From: Max Reitz
Waiting on a process for which we have a pipe will stall if the process
outputs more data than fits into the OS-provided buffer. We must use
communicate() before wait(), and in fact, communicate() perfectly
replaces wait() already.
We have to drop the stderr=subprocess.STDOUT pa
Hello Gerd,
I think in general the idea to make it easier to modularize things is great,
is this thought for devices only, or could I rework my changes to support
modularizing per-target AccelClass types and all the related code on top of
your design?
Thanks,
Claudio
On 7/2/20 2:20 PM, Gerd H
Patchew URL: https://patchew.org/QEMU/20200703090252.368694-1-...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PULL 00/41] virtio,acpi: features, fixes, cleanups.
Type: series
Message-id: 20200703090252.368694-1-...@redh
1 - 100 of 477 matches
Mail list logo
