RE: [PATCH 2/2] xen: cleanup unrealized flash devices

> -Original Message- > From: Philippe Mathieu-Daudé > Sent: 30 June 2020 18:27 > To: p...@xen.org; xen-de...@lists.xenproject.org; qemu-devel@nongnu.org > Cc: 'Eduardo Habkost' ; 'Michael S. Tsirkin' > ; 'Paul Durrant' > ; 'Jason Andryuk' ; 'Paolo Bonzini' > ; > 'Richard Henderson' > Su

Re: [PATCH v2] chardev/tcp: fix error message double free error

lichun writes: > Signed-off-by: lichun > --- > chardev/char-socket.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/chardev/char-socket.c b/chardev/char-socket.c > index afebeec5c3..569d54c144 100644 > --- a/chardev/char-socket.c > +++ b/chardev/char-socket.c > @@ -1

Re: [PATCH] hw/virtio/virtio-iommu-pci.c: Fix typo in error message

Peter Maydell writes: > Fix a typo in an error message in virtio_iommu_pci_realize(): > "Check you machine" should be "Check your machine". > > Reported-by: Markus Armbruster > Signed-off-by: Peter Maydell > --- > hw/virtio/virtio-iommu-pci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletio

[Bug 1805256] Re: qemu-img hangs on rcu_call_ready_event logic in Aarch64 when converting images

Re-open for bionic due to regression found ** Changed in: kunpeng920/ubuntu-18.04 Status: Fix Released => Triaged ** Changed in: kunpeng920/ubuntu-18.04-hwe Status: Fix Released => Triaged ** Changed in: kunpeng920 Status: Fix Released => Triaged -- You received this bug n

Re: [PATCH 1/2] hw/arm/tosa.c: Detabify

On 6/28/20 10:37 PM, Peter Maydell wrote: > Remove the hardcoded tabs from hw/arm/tosa.c. There aren't > many, but since they're all in constant #defines they're not > going to go away with our usual "only when we touch a function" > policy on reformatting. > > Signed-off-by: Peter Maydell No ch

Re: [PATCH v3 22/26] arm/stm32f205 arm/stm32f405: Fix realize error API violation

Philippe Mathieu-Daudé writes: > On 6/30/20 11:03 AM, Markus Armbruster wrote: >> The Error ** argument must be NULL, &error_abort, &error_fatal, or a >> pointer to a variable containing NULL. Passing an argument of the >> latter kind twice without clearing it in between is wrong: if the >> firs

Re: [PATCH] pc: fix leak in pc_system_flash_cleanup_unused

On 7/1/20 3:58 AM, Alexander Bulekov wrote: > fix a leak detected when building with --enable-sanitizers: > ./i386-softmmu/qemu-system-i386 > Upon exit: > ==13576==ERROR: LeakSanitizer: detected memory leaks > > Direct leak of 1216 byte(s) in 1 object(s) allocated from: > #0 0x7f9d2ed5c628 in

Re: [PATCH] migration: Assign current_migration as NULL after migration

Please ignore this patch :-) If we shutdown VM during migration, the migration thread may still ref current_migration at this point. On 2020/6/28 14:49, Keqian Zhu wrote: > In migration_shutdown, global var current_migration is freed but not > assigned to NULL, which may cause heap-use-after-free

Re: [PATCH v7 10/21] multi-process: setup memory manager for remote device

On Sat, Jun 27, 2020 at 10:09:32AM -0700, elena.ufimts...@oracle.com wrote: > +void remote_sysmem_reconfig(MPQemuMsg *msg, Error **errp) > +{ > +SyncSysmemMsg *sysmem_info = &msg->data1.sync_sysmem; > +MemoryRegion *sysmem, *subregion, *next; > +static unsigned int suffix; > +Error

Re: [PATCH v2 2/2] MAINTAINERS: Adjust MIPS maintainership

On 6/30/20 7:19 PM, Philippe Mathieu-Daudé wrote: > On 6/30/20 6:46 PM, Aleksandar Markovic wrote: >> Paul Burton and Aurelien Jarno removed for not being present. >> >> Huacai Chen and Jiaxun Yang step in as new energy. >> >> CC: Paul Burton >> CC: Aurelien Jarno >> Signed-off-by: Aleksandar Mar

Re: [PATCH 10/46] qemu-option: Check return value instead of @err where convenient

Vladimir Sementsov-Ogievskiy writes: > 24.06.2020 19:43, Markus Armbruster wrote: >> Convert uses like >> >> opts = qemu_opts_create(..., &err); >> if (err) { >> ... >> } >> >> to >> >> opts = qemu_opts_create(..., &err); >> if (!opts) { >> ... >> }

Re: [PATCH 11/46] qemu-option: Make uses of find_desc_by_name() more similar

Vladimir Sementsov-Ogievskiy writes: > 29.06.2020 12:36, Vladimir Sementsov-Ogievskiy wrote: >> 24.06.2020 19:43, Markus Armbruster wrote: >>> This is to make the next commit easier to review. >>> >>> Signed-off-by: Markus Armbruster >>> --- >>>   util/qemu-option.c | 32 ++--

Re: [RFC v2 1/1] memory: Delete assertion in memory_region_unregister_iommu_notifier

On 2020/6/30 下午11:39, Peter Xu wrote: On Tue, Jun 30, 2020 at 10:41:10AM +0800, Jason Wang wrote: /* According to ATS spec table 2.4: * S = 0, bits 15:12 = range size: 4K * S = 1, bits 15:12 = xxx0 range size: 8K * S = 1, bits 15:12 = xx01 range size

Re: [RFC v2 1/1] memory: Delete assertion in memory_region_unregister_iommu_notifier

On 2020/6/30 下午11:20, Peter Xu wrote: On Tue, Jun 30, 2020 at 05:23:31PM +0800, Jason Wang wrote: Ok, we had a dedicated mr for interrupt: memory_region_add_subregion_overlap(MEMORY_REGION(&vtd_dev_as->iommu), VTD_INTERRUPT_ADDR_FIRST, &vtd_dev_as->iommu_ir, 1); So it should be fine. I guess

Re: [PATCH 14/46] qemu-option: Factor out helper opt_create()

Vladimir Sementsov-Ogievskiy writes: > 24.06.2020 19:43, Markus Armbruster wrote: >> There is just one use so far. The next commit will add more. >> >> Signed-off-by: Markus Armbruster >> --- >> util/qemu-option.c | 27 ++- >> 1 file changed, 18 insertions(+), 9 delet

[Bug 1885720] Re: qemu/migration/postcopy-ram.c:387: bad return expression ?

That looks like a bug, indeed! ** Changed in: qemu Status: New => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1885720 Title: qemu/migration/postcopy-ram.c:387: bad return expres

[Bug 1885719] Re: qemu/target/nios2/helper.c:261:20: style:inconclusive: Found duplicate branches for 'if' and 'else'

Which version of QEMU did you use here? Apparently it was an older version, since that code has been removed more than a year ago already: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=0137c93ff8cbcebf Please make sure to use the latest release of QEMU when reporting bugs. Thanks! ** Changed

[Bug 1885720] Re: qemu/migration/postcopy-ram.c:387: bad return expression ?

Yes, I think a goto out; there makes sense; nearly 5 years old that error :-) ** Changed in: qemu Assignee: (unassigned) => Dr. David Alan Gilbert (dgilbert-h) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launch

Re: [PATCH v3 1/1] tricore: added triboard with tc27x_soc

Hi Andreas, On Tue, Jun 30, 2020 at 10:28:57AM +, Konopik, Andreas (EFS-GH2) wrote: > Hi Bastian, > > > On Mon, Jun 22, 2020 at 03:19:34PM +0200, David Brenken wrote: > > > From: Andreas Konopik > > > +const MemmapEntry tc27x_soc_memmap[] = { > > > +[TC27XD_DSPR2] = { 0x5000, 0

Re: [PATCH v2 2/2] MAINTAINERS: Adjust MIPS maintainership

On 7/1/20 10:00 AM, Philippe Mathieu-Daudé wrote: > On 6/30/20 7:19 PM, Philippe Mathieu-Daudé wrote: >> On 6/30/20 6:46 PM, Aleksandar Markovic wrote: >>> Paul Burton and Aurelien Jarno removed for not being present. >>> >>> Huacai Chen and Jiaxun Yang step in as new energy. >>> >>> CC: Paul Burto

Re: [PATCH v7 11/21] multi-process: introduce proxy object

On Sat, Jun 27, 2020 at 10:09:33AM -0700, elena.ufimts...@oracle.com wrote: > From: Elena Ufimtseva > > Defines a PCI Device proxy object as a child of TYPE_PCI_DEVICE. > > Signed-off-by: Elena Ufimtseva > Signed-off-by: Jagannathan Raman > Signed-off-by: John G Johnson > --- > MAINTAINERS

[Bug 1885719] Re: qemu/target/nios2/helper.c:261:20: style:inconclusive: Found duplicate branches for 'if' and 'else'

>Which version of QEMU did you use here? git trunk. I have no idea why Richard's patch isn't in my current version and I am disinclined to find out why. Any further work by me on qemu looks somewhat doubtful. Have fun ! -- You received this bug notification because you are a member of qemu- dev

Re: [PATCH 15/46] qemu-option: Tidy up opt_set() not to free arguments on failure

Vladimir Sementsov-Ogievskiy writes: > 24.06.2020 19:43, Markus Armbruster wrote: >> opt_set() frees its argument @value on failure. Slightly unclean; >> functions ideally do nothing on failure. >> >> To tidy this up, move opt_create() from opt_set() into its callers, >> along with the cleanup.

Re: [PATCH] Makefile: Compute libraries for libqemuutil.a and libvhost-user.a

On 2020-06-23 at 16:44 CEST, Stefan Hajnoczi wrote... > On Tue, Jun 16, 2020 at 06:18:14PM +0200, Christophe de Dinechin wrote: >> In util/Makefile.objs, there is a setting for dbus.o-libs. >> Trying to copy-paste that to add a library for module.o that was was >> not otherwise linked yields link

Re: [PATCH 34/46] qom: Don't handle impossible object_property_get_link() failure

Philippe Mathieu-Daudé writes: > On 6/25/20 5:09 PM, Markus Armbruster wrote: >> Philippe Mathieu-Daudé writes: >> >>> On 6/24/20 6:43 PM, Markus Armbruster wrote: Don't handle object_property_get_link() failure that can't happen unless the programmer screwed up, pass &error_abort. >>

Re: [PATCH v2 11/12] vhost-vdpa: introduce vhost-vdpa backend

Thanks Jason, will fix all these and send the new version soon On Wed, Jul 1, 2020 at 12:22 PM Jason Wang wrote: > > > On 2020/7/1 上午1:49, Cindy Lu wrote: > > Currently we have 2 types of vhost backends in QEMU: vhost kernel and > > vhost-user. The above patch provides a generic device for vDPA p

Re: [PATCH v7 12/21] multi-process: Connect Proxy Object with device in the remote process

On Sat, Jun 27, 2020 at 10:09:34AM -0700, elena.ufimts...@oracle.com wrote: > From: Jagannathan Raman > > Send a message to the remote process to connect PCI device with the > corresponding Proxy object in QEMU I thought the protocol was simplified to a 1:1 device:socket model, but this patch se

[Bug 1885889] [NEW] ERROR: core-image-minimal-1.0-r0 do_rootfs: The postinstall intercept hook 'update_font_cache' failed,

Public bug reported: Hello, I am trying to build bitbake core-image-minimal getting following error. santhosh@santhosh-VirtualBox:~/Denverton/Source/BSP/poky/build$ bitbake core-image-minimal Loading cache: 100% |#

[PATCH v3 00/13] vDPA support in qemu

vDPA device is a device that uses a datapath which complies with the virtio specifications with vendor specific control path. vDPA devices can be both physically located on the hardware or emulated by software. This PATCH introduce the vDPA support in qemu TODO 1) vIOMMU support 2) live migration

[PATCH v3 01/13] net: introduce qemu_get_peer

This is a small function that can get the peer from given NetClientState and queue_index Signed-off-by: Cindy Lu --- include/net/net.h | 1 + net/net.c | 7 +++ 2 files changed, 8 insertions(+) diff --git a/include/net/net.h b/include/net/net.h index 39085d9444..e7ef42d62b 100644 --

[PATCH v3 03/13] virtio-bus: introduce queue_enabled method

From: Jason Wang This patch introduces queue_enabled() method which allows the transport to implement its own way to report whether or not a queue is enabled. Signed-off-by: Jason Wang Signed-off-by: Cindy Lu --- hw/virtio/virtio.c | 6 ++ include/hw/virtio/virtio-bus.h | 4 ++

[PATCH v3 02/13] vhost_net: use the function qemu_get_peer

user the qemu_get_peer to replace the old process Signed-off-by: Cindy Lu Reviewed-by: Laurent Vivier --- hw/net/vhost_net.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c index 6b82803fa7..4096d64aaf 100644 --- a/hw

[PATCH v3 05/13] vhost: check the existence of vhost_set_iotlb_callback

From: Jason Wang Add the check of vhost_set_iotlb_callback before calling Signed-off-by: Jason Wang Signed-off-by: Cindy Lu --- hw/virtio/vhost.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index 5fd25fe520..10304b583e 100

[PATCH v3 04/13] virtio-pci: implement queue_enabled method

From: Jason Wang With version 1, we can detect whether a queue is enabled via queue_enabled. Signed-off-by: Jason Wang Signed-off-by: Cindy Lu --- hw/virtio/virtio-pci.c | 13 + 1 file changed, 13 insertions(+) diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c index 7b

[PATCH v3 06/13] vhost: introduce new VhostOps vhost_dev_start

This patch introduces new VhostOps vhost_dev_start callback which allows the vhost_net set the start/stop status to backend Signed-off-by: Cindy Lu --- include/hw/virtio/vhost-backend.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/hw/virtio/vhost-backend.h b/include/hw/virtio/v

[PATCH v3 07/13] vhost: implement vhost_dev_start method

use the vhost_dev_start callback to send the status to backend Signed-off-by: Cindy Lu --- hw/virtio/vhost.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index 10304b583e..32809e54b5 100644 --- a/hw/virtio/vhost.c +++ b/hw/vi

[PATCH v3 08/13] vhost: introduce new VhostOps vhost_vq_get_addr

This patch introduces new VhostOps vhost_vq_get_addr_op callback to get the vring addr from the backend Signed-off-by: Cindy Lu --- include/hw/virtio/vhost-backend.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/hw/virtio/vhost-backend.h b/include/hw/virtio/vhost-backend.h i

[PATCH v3 09/13] vhost: implement vhost_vq_get_addr method

use vhost_vq_get_addr callback to get the vq address from backend Signed-off-by: Cindy Lu --- hw/virtio/vhost.c | 28 +++- include/hw/virtio/vhost-backend.h | 4 2 files changed, 23 insertions(+), 9 deletions(-) diff --git a/hw/virtio/vhost.c b/hw/v

[PATCH v3 11/13] vhost: implement vhost_force_iommu method

use the vhost_force_iommu callback to force enable feature bit VIRTIO_F_IOMMU_PLATFORM Signed-off-by: Cindy Lu --- hw/virtio/vhost.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index 1e083a8976..1a1384e7a6 100644 --- a/hw/virtio/vhost.c +++ b/h

[PATCH v3 13/13] vhost-vdpa: introduce vhost-vdpa net client

This patch set introduces a new net client type: vhost-vdpa. vhost-vdpa net client will set up a vDPA device which is specified by a "vhostdev" parameter. Signed-off-by: Lingshan Zhu Signed-off-by: Tiwei Bie Signed-off-by: Cindy Lu Signed-off-by: Jason Wang --- include/net/vhost-vdpa.h | 22

[PATCH v3 10/13] vhost: introduce new VhostOps vhost_force_iommu

This patch introduces new VhostOps vhost_force_iommu callback to force enable features bit VIRTIO_F_IOMMU_PLATFORM. Signed-off-by: Cindy Lu --- include/hw/virtio/vhost-backend.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/hw/virtio/vhost-backend.h b/include/hw/virtio/vhost-ba

[PATCH v3 12/13] vhost-vdpa: introduce vhost-vdpa backend

Currently we have 2 types of vhost backends in QEMU: vhost kernel and vhost-user. The above patch provides a generic device for vDPA purpose, this vDPA device exposes to user space a non-vendor-specific configuration interface for setting up a vhost HW accelerator, this patch set introduces a third

Re: [PATCH v2 1/2] net: tap: check if the file descriptor is valid before using it

On 01/07/2020 07:50, Markus Armbruster wrote: > Laurent Vivier writes: > >> qemu_set_nonblock() checks that the file descriptor can be used and, if >> not, crashes QEMU. An assert() is used for that. The use of assert() is >> used to detect programming error and the coredump will allow to debug >

Re: [PATCH] migration: postcopy take proper error return

On 01/07/2020 11.35, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" This function returns a boolean success and we're returning -1; lets just use the 'out' error path. Signed-off-by: Dr. David Alan Gilbert Fixes: 58b7c17e226 ("Disable mlock around incoming postcopy") Bugli

[PATCH] migration: postcopy take proper error return

From: "Dr. David Alan Gilbert" This function returns a boolean success and we're returning -1; lets just use the 'out' error path. Signed-off-by: Dr. David Alan Gilbert Fixes: 58b7c17e226 ("Disable mlock around incoming postcopy") Buglink: https://bugs.launchpad.net/qemu/+bug/1885720 --- migra

Re: [PATCH v7 13/21] multi-process: Forward PCI config space acceses to the remote process

On Sat, Jun 27, 2020 at 10:09:35AM -0700, elena.ufimts...@oracle.com wrote: > @@ -42,6 +48,12 @@ gboolean mpqemu_process_msg(QIOChannel *ioc, GIOCondition > cond, > case CONNECT_DEV: > process_connect_dev_msg(&msg, ioc, &local_err); > break; > +case PCI_CONFIG_WRITE: > +

[Bug 1885889] Re: ERROR: core-image-minimal-1.0-r0 do_rootfs: The postinstall intercept hook 'update_font_cache' failed,

I am running this under below ubuntu environment. santhosh@santhosh-VirtualBox:~/Denverton/Source/BSP/poky$ uname -a Linux santhosh-VirtualBox 4.15.0-108-generic #109-Ubuntu SMP Fri Jun 19 11:33:10 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux santhosh@santhosh-VirtualBox:~/Denverton/Source/BSP/poky$ -

[Bug 1885889] Re: ERROR: core-image-minimal-1.0-r0 do_rootfs: The postinstall intercept hook 'update_font_cache' failed,

Why do you file this under the upstream "QEMU" component? This does not seem to be related to QEMU at all? ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/b

Re: [PATCH v3 00/13] vDPA support in qemu

Patchew URL: https://patchew.org/QEMU/20200701092449.17451-1-l...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/

[Bug 1885720] Re: qemu/migration/postcopy-ram.c:387: bad return expression ?

Posted: migration: postcopy take proper error return ** Changed in: qemu Status: Confirmed => In Progress -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1885720 Title: qemu/migration/postcop

Re: [PATCH v6 4/5] 9pfs: T_readdir latency optimization

On Tue, 30 Jun 2020 20:00:08 +0200 Christian Schoenebeck wrote: > On Dienstag, 30. Juni 2020 18:39:57 CEST Greg Kurz wrote: > > On Tue, 30 Jun 2020 17:16:40 +0200 > > > > Christian Schoenebeck wrote: > > > On Montag, 29. Juni 2020 18:39:02 CEST Greg Kurz wrote: > > > > On Wed, 03 Jun 2020 19:16

Re: [PATCH 3/4] nbd: make client_close synchronous

29.06.2020 16:56, Stefan Hajnoczi wrote: On Mon, Jun 29, 2020 at 10:55:06AM +0300, Vladimir Sementsov-Ogievskiy wrote: Also, why in block/io.c we kick the main context, but not bs->aio_context? From AIO_WAIT_WHILE(): * The caller's thread must be the IOThread that owns @ctx or the main loo

Re: [PULL 3/6] MAINTAINERS: Add Loongson-3 maintainer and reviewer

On 6/29/20 11:56 AM, Aleksandar Markovic wrote: > понедељак, 29. јун 2020., Philippe Mathieu-Daudé > је написао/ла: > > On 6/27/20 9:51 PM, Aleksandar Markovic wrote: > > From: Huacai Chen > > > > > Add myself as the maint

Re: [PULL 6/6] MAINTAINERS: Add 'Performance Tools and Tests' subsection

On 6/29/20 12:28 PM, Aleksandar Markovic wrote: > понедељак, 29. јун 2020., Philippe Mathieu-Daudé > је написао/ла: > > On 6/27/20 9:51 PM, Aleksandar Markovic wrote: > > This commit creates a new 'Miscellaneous' section which hosts a new > > 'Performance Tools

Re: [PATCH v10 0/5] fw_cfg: Add FW_CFG_DATA_GENERATOR; crypto: Add tls-cipher-suites

On Tue, Jun 23, 2020 at 07:27:21PM +0200, Philippe Mathieu-Daudé wrote: > Hi, > > This series has 3 parts: > > - First we add the tls-cipher-suites object > > - We add the ability to QOM objects to produce data > consumable by the fw_cfg device, > > - Then we let the tls-cipher-suites object

Re: [PATCH v10 0/5] fw_cfg: Add FW_CFG_DATA_GENERATOR; crypto: Add tls-cipher-suites

On 7/1/20 12:31 PM, Daniel P. Berrangé wrote: > On Tue, Jun 23, 2020 at 07:27:21PM +0200, Philippe Mathieu-Daudé wrote: >> Hi, >> >> This series has 3 parts: >> >> - First we add the tls-cipher-suites object >> >> - We add the ability to QOM objects to produce data >> consumable by the fw_cfg dev

nvme emulation merge process (was: Re: [PATCH 00/10] hw/block/nvme: namespace types and zoned namespaces)

Am 30.06.2020 um 22:36 hat Klaus Jensen geschrieben: > On Jun 30 08:42, Keith Busch wrote: > > On Tue, Jun 30, 2020 at 04:09:46PM +0200, Philippe Mathieu-Daudé wrote: > > > What I see doable for the following days is: > > > - hw/block/nvme: Fix I/O BAR structure [3] > > > - hw/block/nvme: handle t

Re: [PATCH 2/4] migration: Add block-bitmap-mapping parameter

On 30.06.20 12:51, Dr. David Alan Gilbert wrote: > * Max Reitz (mre...@redhat.com) wrote: >> This migration parameter allows mapping block node names and bitmap >> names to aliases for the purpose of block dirty bitmap migration. >> >> This way, management tools can use different node and bitmap na

Re: [PATCH v7 14/21] multi-process: PCI BAR read/write handling for proxy & remote endpoints

On Sat, Jun 27, 2020 at 10:09:36AM -0700, elena.ufimts...@oracle.com wrote: > @@ -54,6 +57,12 @@ gboolean mpqemu_process_msg(QIOChannel *ioc, GIOCondition > cond, > case PCI_CONFIG_READ: > process_config_read(ioc, pci_dev, &msg); > break; > +case BAR_WRITE: > +pr

Re: [PATCH v2 0/6] hw/mips/malta: Add the 'malta-strict' machine, matching Malta hardware

On Tue, Jun 30, 2020 at 05:38:25PM +0200, Aleksandar Markovic wrote: > уто, 30. јун 2020. у 16:52 Philippe Mathieu-Daudé је > написао/ла: > > > > Hi, > > > > This series add a new 'malta-strict' machine, that aims to properly > > model the real hardware (which is not what the current 'malta' > > m

Re: [PULL 6/6] MAINTAINERS: Add 'Performance Tools and Tests' subsection

On 7/1/20 12:32 PM, Philippe Mathieu-Daudé wrote: > On 6/29/20 12:28 PM, Aleksandar Markovic wrote: >> понедељак, 29. јун 2020., Philippe Mathieu-Daudé > > је написао/ла: >> >> On 6/27/20 9:51 PM, Aleksandar Markovic wrote: >> > This commit creates a new 'Miscellaneo

[PATCH v2 0/5] Fix crash due to NBD export leak

Hi all! We've faced crash bug, which is reproducing on master branch as well. The case is described in 03, where fix is suggested. New iotest in 05 crashes without that fix. v2: 01: reword commit msg, add Eric's r-b 02: fix type in commit msg, add Eric's r-b 03: rewrite v1:04 split into 04 (iotes

Re: [PATCH] pc-bios/s390-ccw: Generate and include dependency files in the Makefile

On Tue, 30 Jun 2020 16:29:55 +0200 Thomas Huth wrote: > The Makefile of the s390-ccw bios does not handle dependencies of the > *.c files from the headers yet, so that you often have to run a "make > clean" to get the build right when one of the headers has been changed. > Let's make sure that we

[PATCH v2 2/5] iotests.py: QemuIoInteractive: print output on failure

Make it simpler to debug when qemu-io fails due to wrong arguments or environment. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- tests/qemu-iotests/iotests.py | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotests/iotests.py b/tes

[PATCH v2 1/5] iotests: QemuIoInteractive: use qemu_io_args_no_fmt

The only user (iotest 205) of QemuIoInteractive provides -f argument, so it's a bit inefficient to use qemu_io_args, which contains -f too. And we are going to add one more test, which wants to specify -f by hand. Let's use qemu_io_args_no_fmt. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed

[PATCH v2 5/5] iotests: test shutdown when bitmap is exported through NBD

Test shutdown when bitmap is exported through NBD and active client exists. The previous patch fixes a crash, provoked by this scenario. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/299 | 65 ++ tests/qemu-iotests/299.out | 10 ++

[PATCH v2 3/5] nbd: make nbd_export_close_all() synchronous

Consider nbd_export_close_all(). The call-stack looks like this: nbd_export_close_all() -> nbd_export_close -> call client_close() for each client. client_close() doesn't guarantee that client is closed: nbd_trip() keeps reference to it. So, nbd_export_close_all() just reduce reference counter on

[PATCH v2 4/5] iotests.py: filter_testfiles(): filter SOCK_DIR too

Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/iotests.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index ac9d199a1e..31d4b105ca 100644 --- a/tests/qemu-iotests/iotests.py +++ b/tests/

Re: [PATCH v7 15/21] multi-process: Synchronize remote memory

On Sat, Jun 27, 2020 at 10:09:37AM -0700, elena.ufimts...@oracle.com wrote: > +static bool try_merge(RemoteMemSync *sync, MemoryRegionSection *section) > +{ > +uint64_t mrs_size, mrs_gpa, mrs_page; > +MemoryRegionSection *prev_sec; > +bool merged = false; > +uintptr_t mrs_host; > +

Re: [PATCH v2 6/6] hw/mips/malta: Introduce the 'malta-unleashed' 64-bit machine

On Tue, Jun 30, 2020 at 04:52:36PM +0200, Philippe Mathieu-Daudé wrote: > Introduce the 'malta-unleashed' machine. This machine does not > model any existing hardware (as the default 'malta' neither model > a real hardware). The purpose of this machine is to allow user > of the current 'malta' mach

Race with atexit functions in system emulation

Hi, While running some TSAN tests I ran into the following race condition: WARNING: ThreadSanitizer: data race (pid=1605) Write of size 4 at 0x55c437814d98 by thread T2 (mutexes: write M619): #0 replay_finish /home/alex.bennee/lsrc/qemu.git/replay/replay.c:393:17 (qemu-system-aarch64

Re: [PATCH v2 2/2] MAINTAINERS: Adjust MIPS maintainership

Hi, Philippe and Alexandar, On Wed, Jul 1, 2020 at 4:49 PM Philippe Mathieu-Daudé wrote: > > On 7/1/20 10:00 AM, Philippe Mathieu-Daudé wrote: > > On 6/30/20 7:19 PM, Philippe Mathieu-Daudé wrote: > >> On 6/30/20 6:46 PM, Aleksandar Markovic wrote: > >>> Paul Burton and Aurelien Jarno removed for

[PATCH] acpi: Fix access to PM1 control and status registers

The ACPI spec state that "Accesses to PM1 control registers are accessed through byte and word accesses." (In section 4.7.3.2.1 PM1 Control Registers of my old spec copy rev 4.0a). With commit 5d971f9e6725 ("memory: Revert "memory: accept mismatching sizes in memory_region_access_valid""), it wasn

Re: [PATCH 1/4] migration: Prevent memleak by ...params_test_apply

30.06.2020 11:45, Max Reitz wrote: The created structure is not really a proper QAPI object, so we cannot and will not free its members. Strings therein should therefore not be duplicated, or we will leak them. Signed-off-by: Max Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regar

Re: Race with atexit functions in system emulation

On 01/07/20 13:05, Alex Bennée wrote: > Should we maybe defer the exit to once the main loop has been exited > with a some sort of vmstop? Or could we have an atexit handler that > kills the main thread? Yes, I think the way to do "exit" is to use qemu_system_shutdown_request. Possibly halt the C

Re: [PATCH 2/2] iscsi: return -EIO when sense fields are meaningless

On 01/07/20 12:54, Xie Yongji wrote: > When an I/O request failed, now we only return correct > value on scsi check condition. We should also have a > default errno such as -EIO in other case. > > Signed-off-by: Xie Yongji > --- > block/iscsi.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff

Re: [PATCH v2 14/18] hw/block/nvme: Generate zone AENs

On Jun 18 06:34, Dmitry Fomichev wrote: > Added an optional Boolean "zone_async_events" property to the driver. > Once it's turned on, the namespace will be sending "Zone Descriptor > Changed" asynchronous events to the host in particular situations > defined by the protocol. In order to clear thes

Re: [PATCH v6 4/5] 9pfs: T_readdir latency optimization

On Mittwoch, 1. Juli 2020 12:09:24 CEST Greg Kurz wrote: > No I'm talking about code that isn't changed by this series: > > if (initial_offset == 0) { > v9fs_co_rewinddir(pdu, fidp); > } else { > v9fs_co_seekdir(pdu, fidp, initial_offset); > } > count = v9fs_do_read

Re: [PATCH v3 0/9] Generalize memory encryption models

On Fri, 26 Jun 2020 14:49:37 +0200 Janosch Frank wrote: > On 6/26/20 12:58 PM, Daniel P. Berrangé wrote: > > On Fri, Jun 26, 2020 at 11:29:03AM +0100, Dr. David Alan Gilbert wrote: > >> * Janosch Frank (fran...@linux.ibm.com) wrote: > >>> On 6/26/20 11:32 AM, Daniel P. Berrangé wrote: > On

Re: [PATCH 0/2] two atomic_cmpxchg() related fixes

On Tue, 16 Jun 2020 06:50:33 +0200 Halil Pasic wrote: > The story short: compiler can generate code that does two > distinct fetches of *ind_addr for old and _old. If that happens we can > not figure out if we had the desired xchg or not. > > Halil Pasic (2): > virtio-ccw: fix virtio_set_ind_a

Re: [PATCH] acpi: Fix access to PM1 control and status registers

On Wed, Jul 01, 2020 at 12:05:49PM +0100, Anthony PERARD wrote: > The ACPI spec state that "Accesses to PM1 control registers are > accessed through byte and word accesses." (In section 4.7.3.2.1 PM1 > Control Registers of my old spec copy rev 4.0a). > > With commit 5d971f9e6725 ("memory: Revert "

Re: [PATCH 0/2] two atomic_cmpxchg() related fixes

On 01.07.20 14:01, Cornelia Huck wrote: > On Tue, 16 Jun 2020 06:50:33 +0200 > Halil Pasic wrote: > >> The story short: compiler can generate code that does two >> distinct fetches of *ind_addr for old and _old. If that happens we can >> not figure out if we had the desired xchg or not. >> >>

[PATCH v2] tests: disassemble-aml.sh: generate AML in readable format

On systems where the IASL tool exists, we can convert extected ACPI tables to ASL format, which is useful for debugging and documentation purposes. This script does this for all ACPI tables under tests/data/acpi/. Signed-off-by: Michael S. Tsirkin --- changes from v1: - suggest the script fr

Re: [RFC v2 1/1] memory: Delete assertion in memory_region_unregister_iommu_notifier

On Wed, Jul 01, 2020 at 04:11:49PM +0800, Jason Wang wrote: > > On 2020/6/30 下午11:20, Peter Xu wrote: > > On Tue, Jun 30, 2020 at 05:23:31PM +0800, Jason Wang wrote: > > > > > Ok, we had a dedicated mr for interrupt: > > > > > > > > > > memory_region_add_subregion_overlap(MEMORY_REGION(&vtd_dev_a

Re: [PATCH v4 0/3] Avoid abort on QMP attempt to add an object with duplicate id

On 01/07/20 08:51, Auger Eric wrote: >> Very nice. I see a failure reported by Patchew, I'll look into it as >> well if you don't have time. > > So "[PATCH v5 0/3] Avoid abort on QMP attempt to add an object with > duplicate id" seems to have fixed the Patchew error (I decreased the > size of the

Re: [PATCH 1/2] pci: pass along the return value of dma_memory_rw

On Mon, Jun 29, 2020 at 10:20:52PM +0200, Klaus Jensen wrote: > From: Klaus Jensen > > Some devices might want to know the return value of dma_memory_rw, so > pass it along instead of ignoring it. > > There are no existing users of the return value, so this patch should be > safe. > > Signed-of

Re: [PATCH v9 11/34] qcow2: Add offset_into_subcluster() and size_to_subclusters()

On 28.06.20 13:02, Alberto Garcia wrote: > Like offset_into_cluster() and size_to_clusters(), but for > subclusters. > > Signed-off-by: Alberto Garcia > Reviewed-by: Eric Blake > --- > block/qcow2.h | 10 ++ > 1 file changed, 10 insertions(+) Reviewed-by: Max Reitz signature.asc De

Re: [PATCH 2/2] xen: cleanup unrealized flash devices

On Wed, Jul 1, 2020 at 3:03 AM Paul Durrant wrote: > > > -Original Message- > > From: Philippe Mathieu-Daudé > > Sent: 30 June 2020 18:27 > > To: p...@xen.org; xen-de...@lists.xenproject.org; qemu-devel@nongnu.org > > Cc: 'Eduardo Habkost' ; 'Michael S. Tsirkin' > > ; 'Paul Durrant' > >

Re: [PATCH v9 13/34] qcow2: Update get/set_l2_entry() and add get/set_l2_bitmap()

On 28.06.20 13:02, Alberto Garcia wrote: > Extended L2 entries are 128-bit wide: 64 bits for the entry itself and > 64 bits for the subcluster allocation bitmap. > > In order to support them correctly get/set_l2_entry() need to be > updated so they take the entry width into account in order to > c

Re: [RFC v2 1/1] memory: Delete assertion in memory_region_unregister_iommu_notifier

On 2020/7/1 下午8:16, Peter Xu wrote: On Wed, Jul 01, 2020 at 04:11:49PM +0800, Jason Wang wrote: On 2020/6/30 下午11:20, Peter Xu wrote: On Tue, Jun 30, 2020 at 05:23:31PM +0800, Jason Wang wrote: Ok, we had a dedicated mr for interrupt: memory_region_add_subregion_overlap(MEMORY_REGION(&vtd_d

Re: [PATCH 2/2] xen: cleanup unrealized flash devices

On 7/1/20 2:25 PM, Jason Andryuk wrote: > On Wed, Jul 1, 2020 at 3:03 AM Paul Durrant wrote: >> >>> -Original Message- >>> From: Philippe Mathieu-Daudé >>> Sent: 30 June 2020 18:27 >>> To: p...@xen.org; xen-de...@lists.xenproject.org; qemu-devel@nongnu.org >>> Cc: 'Eduardo Habkost' ; 'Mic

Re: [RFC v2 1/1] memory: Delete assertion in memory_region_unregister_iommu_notifier

On Wed, Jul 01, 2020 at 08:30:07PM +0800, Jason Wang wrote: > > I overlooked myself that the IR region will be there even if ir=off. > > > Yes, but the point stands still but the issue is still if ir=off. > > > >So I > > think the assert should stand. > > > Do you mean vhost can't trigger

[PATCH] MAINTAINERS: add VT-d entry

Add this entry as suggested by Jason and Michael. CC: Jason Wang CC: Michael S. Tsirkin CC: Paolo Bonzini Signed-off-by: Peter Xu --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index dec252f38b..569cfc1fcd 100644 --- a/MAINTAINERS +++ b/

Re: [PATCH] acpi: Fix access to PM1 control and status registers

On Wed, Jul 01, 2020 at 08:01:55AM -0400, Michael S. Tsirkin wrote: > On Wed, Jul 01, 2020 at 12:05:49PM +0100, Anthony PERARD wrote: > > The ACPI spec state that "Accesses to PM1 control registers are > > accessed through byte and word accesses." (In section 4.7.3.2.1 PM1 > > Control Registers of

Re: [PATCH v9 14/34] qcow2: Add QCow2SubclusterType and qcow2_get_subcluster_type()

On 28.06.20 13:02, Alberto Garcia wrote: > This patch adds QCow2SubclusterType, which is the subcluster-level > version of QCow2ClusterType. All QCOW2_SUBCLUSTER_* values have the > the same meaning as their QCOW2_CLUSTER_* equivalents (when they > exist). See below for details and caveats. > > In

Re: [PATCH 2/2] xen: cleanup unrealized flash devices

On 7/1/20 2:40 PM, Philippe Mathieu-Daudé wrote: > On 7/1/20 2:25 PM, Jason Andryuk wrote: >> On Wed, Jul 1, 2020 at 3:03 AM Paul Durrant wrote: >>> -Original Message- From: Philippe Mathieu-Daudé Sent: 30 June 2020 18:27 To: p...@xen.org; xen-de...@lists.xenproject.or

Re: [PATCH 2/2] checkpatch: Change occurences of 'kernel' to 'qemu' in user messages

On Sat, Jun 20, 2020 at 9:32 AM Aleksandar Markovic wrote: > > It is odd that we inform user that, for example, his current working > directory is not kernel root, when, in face, we mean qemu root. > > Replace that and few other similar odd user messages. > > Signed-off-by: Aleksandar Markovic >

Re: [PATCH 0/2] hw/block/nvme: handle transient dma errors

On 6/29/20 11:34 PM, Klaus Jensen wrote: > On Jun 29 14:07, no-re...@patchew.org wrote: >> Patchew URL: >> https://patchew.org/QEMU/20200629202053.1223342-1-...@irrelevant.dk/ >> --- /tmp/qemu-test/src/tests/qemu-iotests/040.out 2020-06-29 >> 20:12:10.0 + >> +++ /tmp/qemu-test/

[PATCH 0/1] Add Script for Dissecting QEMU Execution

Hi, This series adds the dissect.py script which breaks down the execution of QEMU into three main phases: code generation, JIT execution, and helpers execution. It prints the number of instructions executed by QEMU in each of these three phases, plus the total number of executed instructions. T

[PATCH 1/1] scripts/performance: Add dissect.py script

Python script that dissects QEMU execution into three main phases: code generation, JIT execution and helpers execution. Syntax: dissect.py [-h] -- [] \ [] [-h] - Print the script arguments help message. Example of usage: dissect.py -- qemu-arm coulomb_double-arm Example outp

  1   2   3   4   5   >