Re: [PATCH 1/3] virtiofsd: Terminate capability list

2020-06-26 Thread Stefan Hajnoczi
On Thu, Jun 25, 2020 at 05:29:27PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > capng_updatev is a varargs function that needs a -1 to terminate it, > but it was missing. > > In practice what seems to have been happening is that it's added the > capabilities we

Re: [PATCH 01/17] block/nvme: Avoid further processing if trace event not enabled

2020-06-26 Thread Stefan Hajnoczi
On Thu, Jun 25, 2020 at 08:48:22PM +0200, Philippe Mathieu-Daudé wrote: > Avoid further processing if TRACE_NVME_SUBMIT_COMMAND_RAW is > not enabled. Why? This saves 8 trace events, each with 8 arguments. I guess the intent is to improve performance. Did you measure an improvement? signature.as

Re: [PATCH 2/3] virtiofsd: Check capability calls

2020-06-26 Thread Stefan Hajnoczi
On Thu, Jun 25, 2020 at 05:29:28PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Check the capability calls worked. > > Signed-off-by: Dr. David Alan Gilbert > --- > tools/virtiofsd/passthrough_ll.c | 16 +--- > 1 file changed, 13 insertions(+), 3

Re: [RFC PATCH 0/3] Use object_get_canonical_path_component to get child description

2020-06-26 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200626102744.15053-1-f4...@amsat.org/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/

[PATCH v6 4/5] virtio-iommu-pci: Add array of Interval properties

2020-06-26 Thread Eric Auger
The machine may need to pass reserved regions to the virtio-iommu-pci device (such as the MSI window on x86 or the MSI doorbells on ARM). So let's add an array of Interval properties. Note: if some reserved regions are already set by the machine code - which should be the case in general -, the l

Re: [RFC PATCH 0/3] Use object_get_canonical_path_component to get child description

2020-06-26 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200626102744.15053-1-f4...@amsat.org/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #! /

Re: [PATCH v3 8/9] spapr: PEF: block migration

2020-06-26 Thread Dr. David Alan Gilbert
* David Gibson (da...@gibson.dropbear.id.au) wrote: > We haven't yet implemented the fairly involved handshaking that will be > needed to migrate PEF protected guests. For now, just use a migration > blocker so we get a meaningful error if someone attempts this (this is the > same approach used by

[PATCH] target/i386: implement undocumented "smsw r32" behavior

2020-06-26 Thread Paolo Bonzini
In 32-bit mode, the higher 16 bits of the destination register are undefined. In practice CR0[31:0] is stored, just like in 64-bit mode, so just remove the "if" that currently differentiates the behavior. Signed-off-by: Paolo Bonzini --- target/i386/translate.c | 13 +++-- 1 file change

[PATCH] target-i386: remove gen_io_end

2020-06-26 Thread Paolo Bonzini
Force the end of a translation block after an I/O instruction in icount mode. For consistency, all CF_USE_ICOUNT code is kept in disas_insn instead of having it in gen_ins and gen_outs. Signed-off-by: Paolo Bonzini --- target/i386/translate.c | 22 +- 1 file changed, 9 inser

Re: [RFC PATCH 1/3] hw/i2c/smbus_eeprom: Set QOM parent

2020-06-26 Thread BALATON Zoltan
On Fri, 26 Jun 2020, Philippe Mathieu-Daudé wrote: Suggested-by: Markus Armbruster Signed-off-by: Philippe Mathieu-Daudé --- Aspeed change pending latest ARM pull-request, so meanwhile sending as RFC. --- include/hw/i2c/smbus_eeprom.h | 9 ++--- hw/i2c/smbus_eeprom.c | 13 ++

Re: [PULL 00/12] Block patches

2020-06-26 Thread Peter Maydell
On Fri, 26 Jun 2020 at 11:25, Stefan Hajnoczi wrote: > > On Thu, Jun 25, 2020 at 02:31:14PM +0100, Peter Maydell wrote: > > On Wed, 24 Jun 2020 at 11:02, Stefan Hajnoczi wrote: > > > > > > The following changes since commit > > > 171199f56f5f9bdf1e5d670d09ef1351d8f01bae: > > > > > > Merge remo

Re: [Bug 1885247] [NEW] Build error in Intel 32-bit hosts

2020-06-26 Thread Jon Doron
Is there a container I can download which has your build environment? On Fri, Jun 26, 2020 at 12:27 PM Philippe Mathieu-Daudé wrote: > > On 6/26/20 11:20 AM, Thomas Huth wrote: > > On 26/06/2020 11.13, Philippe Mathieu-Daudé wrote: > >> On 6/26/20 9:37 AM, Aleksandar Markovic wrote: > >>> пет, 26

Re: [RFC PATCH 1/3] hw/i2c/smbus_eeprom: Set QOM parent

2020-06-26 Thread BALATON Zoltan
On Fri, 26 Jun 2020, BALATON Zoltan wrote: On Fri, 26 Jun 2020, Philippe Mathieu-Daudé wrote: Suggested-by: Markus Armbruster Signed-off-by: Philippe Mathieu-Daudé --- Aspeed change pending latest ARM pull-request, so meanwhile sending as RFC. --- include/hw/i2c/smbus_eeprom.h | 9 ++--- h

Re: [PATCH 1/5] haiku build fix

2020-06-26 Thread Peter Maydell
On Fri, 26 Jun 2020 at 11:08, David CARLIER wrote: > > From 4d0933384d2bfcd0fc8c4c06eed2d07f3f1b7f8b Mon Sep 17 00:00:00 2001 > From: David Carlier > Date: Fri, 26 Jun 2020 10:35:40 + > Subject: [PATCH 1/5] Haiku build fix enabling BSD symbols. > > Signed-off-by: David Carlier > --- > confi

Re: [ PATCH 2/5] haiku build fix

2020-06-26 Thread Peter Maydell
On Fri, 26 Jun 2020 at 11:10, David CARLIER wrote: > > From 19a41d406eda976001827d248398d7fb172d140b Mon Sep 17 00:00:00 2001 > From: David Carlier > Date: Fri, 26 Jun 2020 10:38:17 + > Subject: [PATCH 2/5] Enable *pty API. > > Signed-off-by: David Carlier > --- > configure | 9 ++

Re: [PATCH 3/5] haiku build fix

2020-06-26 Thread Peter Maydell
On Fri, 26 Jun 2020 at 11:11, David CARLIER wrote: > > From 56890fa5728d11c72232348b3f3273e2df31c197 Mon Sep 17 00:00:00 2001 > From: David Carlier > Date: Fri, 26 Jun 2020 10:40:58 + > Subject: [PATCH 3/5] Checking mlockall symbol presence > > Signed-off-by: David Carlier Reviewed-by: Pete

Re: [PATCH v3 0/9] Generalize memory encryption models

2020-06-26 Thread Daniel P . Berrangé
On Fri, Jun 26, 2020 at 11:29:03AM +0100, Dr. David Alan Gilbert wrote: > * Janosch Frank (fran...@linux.ibm.com) wrote: > > On 6/26/20 11:32 AM, Daniel P. Berrangé wrote: > > > On Fri, Jun 26, 2020 at 11:01:58AM +0200, Janosch Frank wrote: > > >> On 6/26/20 8:53 AM, David Hildenbrand wrote: > > >

Re: [RFC PATCH 2/3] hw/i2c/smbus_eeprom: Add description based on child name

2020-06-26 Thread BALATON Zoltan
On Fri, 26 Jun 2020, Philippe Mathieu-Daudé wrote: Suggested-by: Markus Armbruster Signed-off-by: Philippe Mathieu-Daudé --- hw/i2c/smbus_eeprom.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/i2c/smbus_eeprom.c b/hw/i2c/smbus_eeprom.c index 879fd7c416..22ba7b20d4 100644 --- a/hw/i2c

Re: [PATCH 0/2] target/i386: SSE floating-point fixes

2020-06-26 Thread Paolo Bonzini
On 26/06/20 01:57, Joseph Myers wrote: > Fix some issues relating to SSE floating-point emulation. The first > patch fixes a problem with the handling of the FTZ bit that was found > through the testcase written for the second patch. Rather than > writing a separate standalone test for that bug,

Re: [PATCH v3 1/9] host trust limitation: Introduce new host trust limitation interface

2020-06-26 Thread Dr. David Alan Gilbert
* David Gibson (da...@gibson.dropbear.id.au) wrote: > Several architectures have mechanisms which are designed to protect guest > memory from interference or eavesdropping by a compromised hypervisor. AMD > SEV does this with in-chip memory encryption and Intel has a similar > mechanism. POWER's

Re: [PATCH 02/17] block/nvme: Let nvme_create_queue_pair() fail gracefully

2020-06-26 Thread Stefan Hajnoczi
On Thu, Jun 25, 2020 at 08:48:23PM +0200, Philippe Mathieu-Daudé wrote: > As nvme_create_queue_pair() is allowed to fail, replace the > alloc() calls by try_alloc() to avoid aborting QEMU. > > Signed-off-by: Philippe Mathieu-Daudé > --- > block/nvme.c | 12 ++-- > 1 file changed, 10 inse

Re: [PATCH 4/5] haiku build fix

2020-06-26 Thread Peter Maydell
On Fri, 26 Jun 2020 at 11:09, David CARLIER wrote: > > From 775173ded5657de4d4b467f2f68e747f6a9c0750 Mon Sep 17 00:00:00 2001 > From: David Carlier > Date: Fri, 26 Jun 2020 10:44:36 + > Subject: [PATCH 4/5] Platform specific changes qemu_exec_dir implementation If you could provide more deta

Re: [PATCH 5/5] haiku build fix

2020-06-26 Thread Peter Maydell
On Fri, 26 Jun 2020 at 11:10, David CARLIER wrote: > > From 68d4d4312eccd212b4d2484e09425816ebd2346a Mon Sep 17 00:00:00 2001 > From: David Carlier > Date: Fri, 26 Jun 2020 11:01:54 + > Subject: [PATCH 5/5] Last chunk of build fix > > Signed-off-by: David Carlier > --- > include/qemu/bswap.

Re: [PATCH 03/17] block/nvme: Define QUEUE_INDEX macros to ease code review

2020-06-26 Thread Stefan Hajnoczi
On Thu, Jun 25, 2020 at 08:48:24PM +0200, Philippe Mathieu-Daudé wrote: > Use definitions instead of '0' or '1' indexes. Also this will > be useful when using multi-queues later. > > Signed-off-by: Philippe Mathieu-Daudé > --- > block/nvme.c | 33 +++-- > 1 file chang

Re: [PULL 0/4] ppc-for-5.1 queue 20200626

2020-06-26 Thread Peter Maydell
he Git repository at: > > git://github.com/dgibson/qemu.git tags/ppc-for-5.1-20200626 > > for you to fetch changes up to 737ef968d442cb287b1fcc7da94b53284b0ad1e9: > > target/ppc: Remove TIDR from POWER10 processor (2020-06-26 09:22:30 +1000) > > ---

Re: [PATCH 04/17] block/nvme: Be explicit we share NvmeIdCtrl / NvmeIdNs structures

2020-06-26 Thread Stefan Hajnoczi
On Thu, Jun 25, 2020 at 08:48:25PM +0200, Philippe Mathieu-Daudé wrote: > We allocate an unique chunk of memory then use it for two > different structures. Introduce the 'idsz_max' variable to > hold the maximum size, to make it clearer the size is enough > to hold the two structures. > > Signed-o

Re: [Bug 1885247] [NEW] Build error in Intel 32-bit hosts

2020-06-26 Thread Aleksandar Markovic
пет, 26. јун 2020. у 12:54 Jon Doron је написао/ла: > > Is there a container I can download which has your build environment? > Hello, Jon. I don't know about the container, but, as Peter noted, the following (non-beautiful) diff fixes the build problem on the real host: diff --git a/hw/hyperv/

Re: [Virtio-fs] [PATCH 0/2] virtiofsd: drop Linux capabilities(7)

2020-06-26 Thread Dr. David Alan Gilbert
* Vivek Goyal (vgo...@redhat.com) wrote: > On Fri, Jun 19, 2020 at 12:39:14PM +0100, Daniel P. Berrangé wrote: > [..] > > The CAP_SYS_ADMIN requirement for 'trusted.' xattrs is simply a useful > > mechanism for applications to control access. The host kernel doesn' > > tuse this namespace itself. L

Re: [PATCH V6 3/4] hw/mips: Add Loongson-3 machine support (with KVM)

2020-06-26 Thread Huacai Chen
Hi, Aleksandar, On Wed, Jun 24, 2020 at 7:50 PM Aleksandar Markovic wrote: > > сре, 24. јун 2020. у 12:45 Huacai Chen је написао/ла: > > > > Add Loongson-3 based machine support, it use liointc as the interrupt > > controler and use GPEX as the pci controller. Currently it can only work > > with

Re: [PATCH v2 2/4] smbus: Fix spd_data_generate() error API violation

2020-06-26 Thread BALATON Zoltan
On Wed, 22 Apr 2020, BALATON Zoltan wrote: On Wed, 22 Apr 2020, Philippe Mathieu-Daudé wrote: On 4/22/20 4:27 PM, BALATON Zoltan wrote: On Wed, 22 Apr 2020, Markus Armbruster wrote: The Error ** argument must be NULL, &error_abort, &error_fatal, or a pointer to a variable containing NULL.  Pas

Re: [PATCH v3 2/3] RISC-V: Copy the fdt in dram instead of ROM

2020-06-26 Thread Bin Meng
Hi Atish, On Fri, Jun 26, 2020 at 8:33 AM Atish Patra wrote: > > Currently, the fdt is copied to the ROM after the reset vector. The firmware > has to copy it to DRAM. Instead of this, directly copy the device tree to a > pre-computed dram address. The device tree load address should be as far as

Re: [PATCH QEMU v25 03/17] vfio: Add save and load functions for VFIO PCI devices

2020-06-26 Thread Dr. David Alan Gilbert
* Alex Williamson (alex.william...@redhat.com) wrote: > On Wed, 24 Jun 2020 19:59:39 +0530 > Kirti Wankhede wrote: > > > On 6/23/2020 1:58 AM, Alex Williamson wrote: > > > On Sun, 21 Jun 2020 01:51:12 +0530 > > > Kirti Wankhede wrote: > > > > > >> These functions save and restore PCI device s

Re: [PATCH v3 3/3] riscv: Add opensbi firmware dynamic support

2020-06-26 Thread Bin Meng
Hi Atish, On Fri, Jun 26, 2020 at 8:33 AM Atish Patra wrote: > > OpenSBI is the default firmware in Qemu and has various firmware loading > options. Currently, qemu loader uses fw_jump which has a compile time > pre-defined address where fdt & kernel image must reside. This puts a > constraint on

Re: [PATCH 05/17] block/nvme: Replace qemu_try_blockalign0 by qemu_try_blockalign/memset

2020-06-26 Thread Stefan Hajnoczi
On Thu, Jun 25, 2020 at 08:48:26PM +0200, Philippe Mathieu-Daudé wrote: > In the next commit we'll get ride of qemu_try_blockalign(). s/ride/rid/ Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [PATCH v5 00/11] Mac Old World ROM experiment

2020-06-26 Thread Mark Cave-Ayland
On 26/06/2020 11:21, BALATON Zoltan wrote: > What about these patches? At least those that are finished (up to patch 9) > could be > merged. I've seen you sent a pull request but not including any of these. > Will this > need another rebase after your patches? If I rebase them will you consider

Re: [PATCH 06/17] block/nvme: Replace qemu_try_blockalign(bs) by qemu_try_memalign(pg_sz)

2020-06-26 Thread Stefan Hajnoczi
On Thu, Jun 25, 2020 at 08:48:27PM +0200, Philippe Mathieu-Daudé wrote: > qemu_try_blockalign() is a generic API that call back to the > block driver to return its page alignment. As we call from > within the very same driver, we already know to page alignment > stored in our state. Remove indirect

Re: [PATCH 07/17] block/nvme: Move code around

2020-06-26 Thread Stefan Hajnoczi
On Thu, Jun 25, 2020 at 08:48:28PM +0200, Philippe Mathieu-Daudé wrote: > Move assignments previous to where the assigned variable is used, > to make the nvme_identify() body easier to review. No logical change. > > Signed-off-by: Philippe Mathieu-Daudé > --- > block/nvme.c | 10 -- > 1

QEMU | Pipeline #160439005 has failed for master | 611ac633

2020-06-26 Thread GitLab via
Your pipeline has failed. Project: QEMU ( https://gitlab.com/qemu-project/qemu ) Branch: master ( https://gitlab.com/qemu-project/qemu/-/commits/master ) Commit: 611ac633 ( https://gitlab.com/qemu-project/qemu/-/commit/611ac63305ff577604e2a7bacf4f204568e08bef ) Commit Message: Merge remote-tr

Re: [PATCH 08/17] block/nvme: Use correct type void*

2020-06-26 Thread Stefan Hajnoczi
On Thu, Jun 25, 2020 at 08:48:29PM +0200, Philippe Mathieu-Daudé wrote: > qemu_try_memalign() returns a void*, qemu_vfio_dma_map() consumes > a void*. Drop the confusing uint8_t* type. > > Signed-off-by: Philippe Mathieu-Daudé > --- > block/nvme.c | 2 +- > 1 file changed, 1 insertion(+), 1 dele

Re: [PATCH 09/17] block/nvme: Remove unused argument from nvme_free_queue_pair()

2020-06-26 Thread Stefan Hajnoczi
On Thu, Jun 25, 2020 at 08:48:30PM +0200, Philippe Mathieu-Daudé wrote: > nvme_free_queue_pair() doesn't use BlockDriverState, remove it. > > Signed-off-by: Philippe Mathieu-Daudé > --- > block/nvme.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) Reviewed-by: Stefan Hajnocz

Re: [PATCH 10/17] block/nvme: Simplify nvme_init_queue() arguments

2020-06-26 Thread Stefan Hajnoczi
On Thu, Jun 25, 2020 at 08:48:31PM +0200, Philippe Mathieu-Daudé wrote: > nvme_init_queue() doesn't require BlockDriverState anymore. > Replace it by BDRVNVMeState to simplify. > > Signed-off-by: Philippe Mathieu-Daudé > --- > block/nvme.c | 7 +++ > 1 file changed, 3 insertions(+), 4 deleti

Re: [PATCH 12/17] block/nvme: Simplify nvme_kick trace event

2020-06-26 Thread Stefan Hajnoczi
On Thu, Jun 25, 2020 at 08:48:33PM +0200, Philippe Mathieu-Daudé wrote: > The queues are tied to the hardware, logging the block > driver using them is irrelevant. > > Signed-off-by: Philippe Mathieu-Daudé > --- > block/nvme.c | 2 +- > block/trace-events | 2 +- > 2 files changed, 2 inser

Re: [PATCH 13/17] block/nvme: Simplify completion trace events

2020-06-26 Thread Stefan Hajnoczi
On Thu, Jun 25, 2020 at 08:48:34PM +0200, Philippe Mathieu-Daudé wrote: > The queues are tied to the hardware, logging the block > driver using them is irrelevant. > > Signed-off-by: Philippe Mathieu-Daudé > --- > block/nvme.c | 6 +++--- > block/trace-events | 6 +++--- > 2 files changed,

Re: [PATCH 11/17] block/nvme: Simplify nvme_create_queue_pair() arguments

2020-06-26 Thread Stefan Hajnoczi
On Thu, Jun 25, 2020 at 08:48:32PM +0200, Philippe Mathieu-Daudé wrote: > nvme_create_queue_pair() doesn't require BlockDriverState anymore. > Replace it by BDRVNVMeState to simplify. > > Signed-off-by: Philippe Mathieu-Daudé > --- > block/nvme.c | 7 +++ > 1 file changed, 3 insertions(+), 4

Re: [PATCH 14/17] block/nvme: Replace BDRV_POLL_WHILE by AIO_WAIT_WHILE

2020-06-26 Thread Stefan Hajnoczi
On Thu, Jun 25, 2020 at 08:48:35PM +0200, Philippe Mathieu-Daudé wrote: > BDRV_POLL_WHILE() is defined as: > > #define BDRV_POLL_WHILE(bs, cond) ({ \ > BlockDriverState *bs_ = (bs); \ > AIO_WAIT_WHILE(bdrv_get_aio_context(bs_), \ > cond); })

Re: [PATCH v5 01/11] mac_oldworld: Allow loading binary ROM image

2020-06-26 Thread Mark Cave-Ayland
On 16/06/2020 14:47, BALATON Zoltan wrote: > The beige G3 Power Macintosh has a 4MB firmware ROM. Fix the size of > the rom region and fall back to loading a binary image with -bios if > loading ELF image failed. This allows testing emulation with a ROM > image from real hardware as well as using

Re: [RFC PATCH 1/3] hw/i2c/smbus_eeprom: Set QOM parent

2020-06-26 Thread Philippe Mathieu-Daudé
+ Eduardo / Mark / Edgard / Alistair / Fred for QOM design. On 6/26/20 12:54 PM, BALATON Zoltan wrote: > On Fri, 26 Jun 2020, BALATON Zoltan wrote: >> On Fri, 26 Jun 2020, Philippe Mathieu-Daudé wrote: >>> Suggested-by: Markus Armbruster >>> Signed-off-by: Philippe Mathieu-Daudé >>> --- >>> Aspe

Re: [PATCH v5 02/11] mac_newworld: Allow loading binary ROM image

2020-06-26 Thread Mark Cave-Ayland
On 16/06/2020 14:47, BALATON Zoltan wrote: > Fall back to load binary ROM image if loading ELF fails. This also > moves PROM_BASE and PROM_SIZE defines to board as these are matching > the ROM size and address on this board. Probably worth a quick mention here that you are removing BIOS_SIZE and

Re: [RFC PATCH 15/17] block/nvme: Use per-queue AIO context

2020-06-26 Thread Stefan Hajnoczi
On Thu, Jun 25, 2020 at 08:48:36PM +0200, Philippe Mathieu-Daudé wrote: > To be able to use multiple queues on the same hardware, > we need to have each queue able to receive IRQ notifications > in the correct AIO context. > The context has to be proper to each queue, not to the block > driver. Mov

Re: [PATCH v5 03/11] mac_oldworld: Drop a variable, use get_system_memory() directly

2020-06-26 Thread Mark Cave-Ayland
On 16/06/2020 14:47, BALATON Zoltan wrote: > Half of the occurances already use get_system_memory() directly > instead of sysmem variable, convert the two other uses to > get_system_memory() tii which seems to be more common and drop the > variable. > > Signed-off-by: BALATON Zoltan > --- > hw/

Re: [PATCH 16/17] block/nvme: Check BDRVNVMeState::plugged out of nvme_kick()

2020-06-26 Thread Stefan Hajnoczi
On Thu, Jun 25, 2020 at 08:48:37PM +0200, Philippe Mathieu-Daudé wrote: > The queues are tied to the hardware, not to the block driver. > As this function doesn't need to know about the BDRVNVMeState, > move the 'plugged' check to the caller. > Since in nvme_aio_unplug() we know that s->plugged is

Re: [RFC PATCH 0/3] Use object_get_canonical_path_component to get child description

2020-06-26 Thread Philippe Mathieu-Daudé
On 6/26/20 12:37 PM, no-re...@patchew.org wrote: > Patchew URL: https://patchew.org/QEMU/20200626102744.15053-1-f4...@amsat.org/ > > > > Hi, > > This series failed the docker-quick@centos7 build test. Please find the > testing commands and > their output below. If you have Docker installed, yo

Re: [PATCH 04/17] block/nvme: Be explicit we share NvmeIdCtrl / NvmeIdNs structures

2020-06-26 Thread Philippe Mathieu-Daudé
On 6/26/20 1:19 PM, Stefan Hajnoczi wrote: > On Thu, Jun 25, 2020 at 08:48:25PM +0200, Philippe Mathieu-Daudé wrote: >> We allocate an unique chunk of memory then use it for two >> different structures. Introduce the 'idsz_max' variable to >> hold the maximum size, to make it clearer the size is e

Re: [PATCH v5 04/11] mac_oldworld: Drop some variables

2020-06-26 Thread Mark Cave-Ayland
On 16/06/2020 14:47, BALATON Zoltan wrote: > Values not used frequently enough may not worth putting in a local > variable, especially with names almost as long as the original value > because that does not improve readability, to the contrary it makes it > harder to see what value is used. Drop a

Re: [PATCH 17/17] block/nvme: Check BDRVNVMeState::plugged out of nvme_process_completion

2020-06-26 Thread Stefan Hajnoczi
On Thu, Jun 25, 2020 at 08:48:38PM +0200, Philippe Mathieu-Daudé wrote: > @@ -529,10 +529,13 @@ static bool nvme_poll_queues(BDRVNVMeState *s) > bool progress = false; > int i; > > +if (s->plugged) { > +return false; > +} > for (i = 0; i < s->nr_queues; i++) { >

Re: [PULL 00/22] qemu-macppc queue 20200626

2020-06-26 Thread Peter Maydell
ilable in the Git repository at: > > git://github.com/mcayland/qemu.git tags/qemu-macppc-20200626 > > for you to fetch changes up to e590e7f01479a1d4544aac062fe9fdb986502294: > > adb: add ADB bus trace events (2020-06-26 10:13:52 +0100) > > ---

Re: [PATCH 06/17] block/nvme: Replace qemu_try_blockalign(bs) by qemu_try_memalign(pg_sz)

2020-06-26 Thread Philippe Mathieu-Daudé
On 6/26/20 2:24 PM, Stefan Hajnoczi wrote: > On Thu, Jun 25, 2020 at 08:48:27PM +0200, Philippe Mathieu-Daudé wrote: >> qemu_try_blockalign() is a generic API that call back to the >> block driver to return its page alignment. As we call from >> within the very same driver, we already know to page

Re: [PATCH v3 0/9] Generalize memory encryption models

2020-06-26 Thread Janosch Frank
On 6/26/20 12:58 PM, Daniel P. Berrangé wrote: > On Fri, Jun 26, 2020 at 11:29:03AM +0100, Dr. David Alan Gilbert wrote: >> * Janosch Frank (fran...@linux.ibm.com) wrote: >>> On 6/26/20 11:32 AM, Daniel P. Berrangé wrote: On Fri, Jun 26, 2020 at 11:01:58AM +0200, Janosch Frank wrote: > On

Re: [PATCH v5 05/11] grackle: Set revision in PCI config to match hardware

2020-06-26 Thread Mark Cave-Ayland
On 16/06/2020 14:47, BALATON Zoltan wrote: > Signed-off-by: BALATON Zoltan > --- > hw/pci-host/grackle.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/pci-host/grackle.c b/hw/pci-host/grackle.c > index 4b3af0c704..48d11f13ab 100644 > --- a/hw/pci-host/grackle.c > +

[PATCH 4/5] haiku build fix

2020-06-26 Thread David CARLIER
>From a4dfa918e6eea7a5ccc4375d83d1f0162e3bb122 Mon Sep 17 00:00:00 2001 From: David Carlier Date: Fri, 26 Jun 2020 13:43:59 + Subject: [PATCH 1/3] check sys/signal.h presence Signed-off-by: David Carlier --- configure | 8 hw/xen/xen-legacy-backend.c | 1 - includ

Re: [PATCH v2 20/25] x86: Fix x86_cpu_new() error API violations

2020-06-26 Thread Markus Armbruster
Igor Mammedov writes: > On Wed, 24 Jun 2020 10:37:32 +0200 > Markus Armbruster wrote: > >> The Error ** argument must be NULL, &error_abort, &error_fatal, or a >> pointer to a variable containing NULL. Passing an argument of the >> latter kind twice without clearing it in between is wrong: if t

[PATCH 5/5] haiku build fix

2020-06-26 Thread David CARLIER
>From 6fa7a4108236f513201192654e07c7044a3d7e58 Mon Sep 17 00:00:00 2001 From: David Carlier Date: Fri, 26 Jun 2020 13:51:37 + Subject: [PATCH 3/3] qemu_init_exec_dir Haiku implementation Signed-off-by: David Carlier --- util/oslib-posix.c | 19 +++ 1 file changed, 19 inserti

[PATCH 5/5] Haiku build fix

2020-06-26 Thread David CARLIER
>From d36aba6190152c626f668fef3704ee6b61bfc323 Mon Sep 17 00:00:00 2001 From: David Carlier Date: Fri, 26 Jun 2020 13:45:04 + Subject: [PATCH 2/3] define SIGIO for haiku Signed-off-by: David Carlier --- include/qemu/osdep.h | 4 1 file changed, 4 insertions(+) diff --git a/include/qem

Re: [PATCH v5 06/11] mac_oldworld: Rename ppc_heathrow_reset to ppc_heathrow_cpu_reset

2020-06-26 Thread Mark Cave-Ayland
On 16/06/2020 14:47, BALATON Zoltan wrote: > This function resets a CPU not the whole machine so reflect that in > its name. > > Signed-off-by: BALATON Zoltan > Reviewed-by: Philippe Mathieu-Daudé > --- > hw/ppc/mac_oldworld.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > di

[PATCH v3 0/2] linux-user: support of semtimedop syscall

2020-06-26 Thread Matus Kysel
Updated version according Laurent's comments. v3: split patch and add some arch specific modification

[PATCH v3 1/2] linux-user: refactor ipc syscall

2020-06-26 Thread Matus Kysel
Refactoring ipc syscall for s390x and SPARC, so it matches glibc implementation Signed-off-by: Matus Kysel --- linux-user/syscall.c | 26 +- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 97de9fb5c9..9904127

[PATCH v3 2/2] linux-user: support of semtimedop syscall

2020-06-26 Thread Matus Kysel
We should add support of semtimedop syscall as new version of glibc 2.31 uses semop based on semtimedop (commit: https://gitlab.com/freedesktop-sdk/mirrors/sourceware/glibc/-/commit/765cdd0bffd77960ae852104fc4ea5edcdb8aed3 ). Signed-off-by: Matus Kysel --- linux-user/syscall.c | 58 +++

Re: [RFC PATCH 15/17] block/nvme: Use per-queue AIO context

2020-06-26 Thread Stefan Hajnoczi
On Thu, Jun 25, 2020 at 08:48:36PM +0200, Philippe Mathieu-Daudé wrote: > To be able to use multiple queues on the same hardware, > we need to have each queue able to receive IRQ notifications > in the correct AIO context. > The context has to be proper to each queue, not to the block > driver. Mov

Re: [PATCH v6 1/2] target/arm: kvm: Handle DABT with no valid ISS

2020-06-26 Thread Peter Maydell
On Fri, 26 Jun 2020 at 10:01, Andrew Jones wrote: > nit: How about using '= {0}' when declaring the variable, rather than this > memset? We prefer "= {}" -- although "= {0}" is the C standard approved version, some compiler versions produce spurious warnings for it in some situations. (cf commit

[PATCH 1/3] haiku build fix second batch

2020-06-26 Thread David CARLIER
>From 95ef79ddff73eebd1f1bec6673c2c68209fab107 Mon Sep 17 00:00:00 2001 From: David Carlier Date: Fri, 26 Jun 2020 13:56:14 + Subject: [PATCH 1/3] Include endian.h for Haiku to solve bswap* macros build failure. Signed-off-by: David Carlier --- include/qemu/bswap.h | 2 ++ 1 file changed,

[PATCH 2/3] haiku build fix second batch

2020-06-26 Thread David CARLIER
>From 338a25285d945c891eb4fa34a18cb45b8b05dbb1 Mon Sep 17 00:00:00 2001 From: David Carlier Date: Fri, 26 Jun 2020 13:57:08 + Subject: [PATCH 2/3] drm build ignored for Haiku. Signed-off-by: David Carlier --- util/Makefile.objs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

Re: [PATCH v5 07/11] mac_oldworld: Map macio to expected address at reset

2020-06-26 Thread Mark Cave-Ayland
On 16/06/2020 14:47, BALATON Zoltan wrote: > Add a reset function that maps macio to the address expected by the > firmware of the board at startup. > > Signed-off-by: BALATON Zoltan > --- > hw/ppc/mac.h | 12 > hw/ppc/mac_oldworld.c | 15 ++- > 2 files changed

Re: [PULL 00/12] Block patches

2020-06-26 Thread Stefan Hajnoczi
On Fri, Jun 26, 2020 at 11:49 AM Peter Maydell wrote: > > On Fri, 26 Jun 2020 at 11:25, Stefan Hajnoczi wrote: > > > > On Thu, Jun 25, 2020 at 02:31:14PM +0100, Peter Maydell wrote: > > > On Wed, 24 Jun 2020 at 11:02, Stefan Hajnoczi wrote: > > > > > > > > The following changes since commit > >

Re: [PATCH] gitlab-ci: Fix the change rules after moving the YML files

2020-06-26 Thread Bin Meng
Hi Philippe, On Thu, Jun 25, 2020 at 11:28 PM Philippe Mathieu-Daudé wrote: > > On 6/25/20 5:16 PM, Thomas Huth wrote: > > The edk2.yml and opensbi.yml files have recently been moved/renamed, > > but the change has not been reflected in the rules in the YML files > > yet. > > > > Fixes: 922febe2a

[PATCH 3/3] haiku build fix

2020-06-26 Thread David CARLIER
>From a548479cab82200d9df33a70f24aeebb00eb70ad Mon Sep 17 00:00:00 2001 From: David Carlier Date: Fri, 26 Jun 2020 13:58:34 + Subject: [PATCH 3/3] syscall skipped for haiku used only in qemu_signalfd anyway Signed-off-by: David Carlier --- util/compatfd.c | 2 ++ 1 file changed, 2 insertio

[PATCH] migration/block-dirty-bitmap: fix add_bitmaps_to_list

2020-06-26 Thread Vladimir Sementsov-Ogievskiy
We shouldn't fail, if found unnamed bitmap in a unnamed node or node with auto-generated node name, as bitmap migration ignores such bitmaps at all. Fixes: 82640edb88faa Fixes: 4ff5cc121b089 Signed-off-by: Vladimir Sementsov-Ogievskiy --- migration/block-dirty-bitmap.c | 6 +- 1 file changed

Re: [PATCH v5 08/11] mac_oldworld: Add machine ID register

2020-06-26 Thread Mark Cave-Ayland
On 16/06/2020 14:47, BALATON Zoltan wrote: > The G3 beige machine has a machine ID register that is accessed by the > firmware to deternine the board config. Add basic emulation of it. > > Signed-off-by: BALATON Zoltan > --- > v4: Move MermoryRegion to MachineState, use constants > > hw/ppc/ma

Re: [PATCH] timer: Handle decrements of PIT counter

2020-06-26 Thread Roman Bolshakov
On Tue, Jun 23, 2020 at 11:00:24PM -0400, Kevin O'Connor wrote: > On Sat, Jun 13, 2020 at 02:19:12PM +0300, Roman Bolshakov wrote: > > There's a fallback to PIT if TSC is not present but it doesn't work > > properly. It prevents boot from floppy on isapc and 486 cpu [1][2]. > > > > SeaBIOS configu

Re: [PATCH v5 09/11] macio: Add dummy screamer register area

2020-06-26 Thread Mark Cave-Ayland
On 16/06/2020 14:47, BALATON Zoltan wrote: > The only thing this returns is an idle status so the firmware > continues, otherwise just ignores and logs access for debugging. This > is a stop gap until proper implementation of this device lands. > > Signed-off-by: BALATON Zoltan > --- > hw/misc/

Re: [PATCH v9 43/46] target/arm: Create tagged ram when MTE is enabled

2020-06-26 Thread Peter Maydell
On Fri, 26 Jun 2020 at 04:32, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > v5: Assign cs->num_ases to the final value first. > Downgrade to ID_AA64PFR1.MTE=1 if tag memory is not available. > v6: Add secure tag memory for EL3. > v8: Add arm,armv8.5-memtag. > v9: Split

[PATCH] MAINTAINERS: Add an entry for OpenSBI firmware

2020-06-26 Thread Bin Meng
List me as the maintainer for OpenSBI firmware related files. Signed-off-by: Bin Meng --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 1b40446..b0e2dd2 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2609,6 +2609,13 @@ F: tests/uefi-test-

Re: [PATCH v3 0/2] linux-user: support of semtimedop syscall

2020-06-26 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200626124612.58593-1-mky...@tachyum.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v3 0/2] linux-user: support of semtimedop syscall Type: series Message-id: 20200626124612.58593-1-m

Re: [PATCH v9 44/46] target/arm: Add allocation tag storage for system mode

2020-06-26 Thread Peter Maydell
On Fri, 26 Jun 2020 at 04:32, Richard Henderson wrote: > > Look up the physical address for the given virtual address, > convert that to a tag physical address, and finally return > the host address that backs it. > > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v9 46/46] target/arm: Add arm,armv8.5-memtag to dtb

2020-06-26 Thread Peter Maydell
On Fri, 26 Jun 2020 at 04:32, Richard Henderson wrote: > > The mte-v4 linux arm kernel development branch requires these tags. > It is still an open question as to whether they will be required > for the final commit. > > Signed-off-by: Richard Henderson > --- > v9: Split from patch creating the

Re: RFC: use VFIO over a UNIX domain socket to implement device offloading

2020-06-26 Thread Stefan Hajnoczi
On Thu, Jun 25, 2020 at 08:54:25PM -0700, John G Johnson wrote: > > > > On Jun 23, 2020, at 5:27 AM, Stefan Hajnoczi wrote: > > > > On Thu, Jun 18, 2020 at 02:38:04PM -0700, John G Johnson wrote: > >>> On Jun 15, 2020, at 3:49 AM, Stefan Hajnoczi wrote: > >>> An issue with file descriptor pass

Re: [PATCH 5/5] haiku build fix

2020-06-26 Thread Thomas Huth
On 26/06/2020 12.07, David CARLIER wrote: From 68d4d4312eccd212b4d2484e09425816ebd2346a Mon Sep 17 00:00:00 2001 From: David Carlier Date: Fri, 26 Jun 2020 11:01:54 + Subject: [PATCH 5/5] Last chunk of build fix Signed-off-by: David Carlier --- include/qemu/bswap.h | 2 ++ util/Makefil

Re: [PATCH 1/3] haiku build fix second batch

2020-06-26 Thread Peter Maydell
On Fri, 26 Jun 2020 at 14:02, David CARLIER wrote: > > From 95ef79ddff73eebd1f1bec6673c2c68209fab107 Mon Sep 17 00:00:00 2001 > From: David Carlier > Date: Fri, 26 Jun 2020 13:56:14 + > Subject: [PATCH 1/3] Include endian.h for Haiku to solve bswap* macros build > failure. > > Signed-off-by:

[PATCH 12/13] replay: describe reverse debugging in docs/replay.txt

2020-06-26 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk This patch updates the documentation and describes usage of the reverse debugging in QEMU+GDB. Signed-off-by: Pavel Dovgalyuk --- 0 files changed diff --git a/docs/replay.txt b/docs/replay.txt index 70c27edb36..18d6169f3b 100644 --- a/docs/replay.txt +++ b/docs/replay.tx

[PATCH 06/13] replay: introduce info hmp/qmp command

2020-06-26 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk This patch introduces 'info replay' monitor command and corresponding qmp request. These commands request the current record/replay mode, replay log file name, and the instruction count (number of recorded/replayed instructions). The instruction count can be used with the r

[PATCH 13/13] tests/acceptance: add reverse debugging test

2020-06-26 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk This is a test for GDB reverse debugging commands: reverse step and reverse continue. Every test in this suite consists of two phases: record and replay. Recording saves the execution of some instructions and makes an initial VM snapshot to allow reverse execution. Replay s

[PATCH 08/13] replay: implement replay-seek command

2020-06-26 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk This patch adds hmp/qmp commands replay_seek/replay-seek that proceed the execution to the specified instruction count. The command automatically loads nearest snapshot and replays the execution to find the desired instruction count. Signed-off-by: Pavel Dovgalyuk Acked-by

[PATCH 00/13] Reverse debugging

2020-06-26 Thread Pavel Dovgalyuk
GDB remote protocol supports reverse debugging of the targets. It includes 'reverse step' and 'reverse continue' operations. The first one finds the previous step of the execution, and the second one is intended to stop at the last breakpoint that would happen when the program is executed normally.

[PATCH 09/13] replay: flush rr queue before loading the vmstate

2020-06-26 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk Non-empty record/replay queue prevents saving and loading the VM state, because it includes pending bottom halves and block coroutines. But when the new VM state is loaded, we don't have to preserve the consistency of the current state anymore. Therefore this patch just flus

[PATCH 07/13] replay: introduce breakpoint at the specified step

2020-06-26 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk This patch introduces replay_break, replay_delete_break qmp and hmp commands. These commands allow stopping at the specified instruction. It may be useful for debugging when there are some known events that should be investigated. replay_break command has one argument - numb

[PATCH 01/13] replay: provide an accessor for rr filename

2020-06-26 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk This patch adds an accessor function for the name of the record/replay log file. Adding an accessor instead of making variable global, prevents accidental modification of this variable by other modules. Signed-off-by: Pavel Dovgalyuk --- 0 files changed diff --git a/incl

[PATCH 10/13] gdbstub: add reverse step support in replay mode

2020-06-26 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk GDB remote protocol supports two reverse debugging commands: reverse step and reverse continue. This patch adds support of the first one to the gdbstub. Reverse step is intended to step one instruction in the backwards direction. This is not possible in regular execution. Bu

[PATCH 02/13] qcow2: introduce icount field for snapshots

2020-06-26 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk This patch introduces the icount field for saving within the snapshot. It is required for navigation between the snapshots in record/replay mode. Signed-off-by: Pavel Dovgalyuk Acked-by: Kevin Wolf --- 0 files changed diff --git a/block/qcow2-snapshot.c b/block/qcow2-sn

[PATCH 05/13] qapi: introduce replay.json for record/replay-related stuff

2020-06-26 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk This patch adds replay.json file. It will be used for adding record/replay-related data structures and commands. Signed-off-by: Pavel Dovgalyuk Reviewed-by: Markus Armbruster --- 0 files changed diff --git a/MAINTAINERS b/MAINTAINERS index 5dd86c7f94..ca5b1cf7f1 100644

[PATCH 11/13] gdbstub: add reverse continue support in replay mode

2020-06-26 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk This patch adds support of the reverse continue operation for gdbstub. Reverse continue finds the last breakpoint that would happen in normal execution from the beginning to the current moment. Implementation of the reverse continue replays the execution twice: to find the b

[PATCH 03/13] migration: introduce icount field for snapshots

2020-06-26 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk Saving icount as a parameters of the snapshot allows navigation between them in the execution replay scenario. This information can be used for finding a specific snapshot for proceeding the recorded execution to the specific moment of the time. E.g., 'reverse step' action (

<    1   2   3   4   5   6   >