Re: [PATCH v2 4/9] prep: add ppc-parity write method

2020-06-24 Thread Philippe Mathieu-Daudé
On 6/24/20 8:55 PM, P J P wrote: > From: Prasad J Pandit > > Add ppc-parity mmio write method to avoid NULL pointer dereference > issue. > > Reported-by: Lei Sun > Signed-off-by: Prasad J Pandit > --- > hw/ppc/prep_systemio.c | 8 > 1 file changed, 8 insertions(+) > > Update v2: use

Re: [PATCH v2 7/9] tz-ppc: add dummy read/write methods

2020-06-24 Thread Philippe Mathieu-Daudé
On 6/24/20 8:55 PM, P J P wrote: > From: Prasad J Pandit > > Add tz-ppc-dummy mmio read/write methods to avoid assert failure > during initialisation. > > Signed-off-by: Prasad J Pandit > --- > hw/misc/tz-ppc.c | 15 +++ > 1 file changed, 15 insertions(+) > > diff --git a/hw/misc/

Re: [PATCH v4 3/8] s390/sclp: rework sclp boundary and length checks

2020-06-24 Thread Thomas Huth
On 24/06/2020 22.23, Collin Walling wrote: Rework the SCLP boundary check to account for different SCLP commands (eventually) allowing different boundary sizes. Move the length check code into a separate function, and introduce a new function to determine the length of the read SCP data (i.e. th

Re: [PATCH 32/46] qom: Rename qdev_get_type() to object_get_type()

2020-06-24 Thread Philippe Mathieu-Daudé
On 6/24/20 6:43 PM, Markus Armbruster wrote: > Commit 2f262e06f0 lifted qdev_get_type() from qdev to object without > renaming it accordingly. Do that now. > > Signed-off-by: Markus Armbruster > --- > qom/object.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/qom

Re: [PATCH 34/46] qom: Don't handle impossible object_property_get_link() failure

2020-06-24 Thread Philippe Mathieu-Daudé
On 6/24/20 6:43 PM, Markus Armbruster wrote: > Don't handle object_property_get_link() failure that can't happen > unless the programmer screwed up, pass &error_abort. > > Signed-off-by: Markus Armbruster > --- > hw/arm/bcm2835_peripherals.c | 7 +-- > hw/arm/bcm2836.c | 7 +---

Re: [PATCH v4 4/8] hw/misc/pca9552: Add a 'description' property for debugging purpose

2020-06-24 Thread Markus Armbruster
Cédric Le Goater writes: > On 6/22/20 10:31 AM, Philippe Mathieu-Daudé wrote: >> On 6/22/20 8:27 AM, Cédric Le Goater wrote: >>> On 6/21/20 12:58 AM, Philippe Mathieu-Daudé wrote: Add a description field to distinguish between multiple devices. Pardon my lack of imagination: how does this h

Re: [PATCH v2 03/25] Clean up some calls to ignore Error objects the right way

2020-06-24 Thread Markus Armbruster
Greg Kurz writes: > On Wed, 24 Jun 2020 10:37:15 +0200 > Markus Armbruster wrote: > >> Receiving the error in a local variable only to free it is less clear >> (and also less efficient) than passing NULL. Clean up. >> >> Cc: Daniel P. Berrange >> Cc: Jerome Forissier >> CC: Greg Kurz >> Sig

Re: [PATCH v2 20/25] x86: Fix x86_cpu_new() error API violations

2020-06-24 Thread Markus Armbruster
Paolo Bonzini writes: > On 24/06/20 16:17, Igor Mammedov wrote: >>> -cpu = object_new(MACHINE(x86ms)->cpu_type); >>> - >>> -object_property_set_uint(cpu, apic_id, "apic-id", &local_err); >>> -qdev_realize(DEVICE(cpu), NULL, &local_err); >>> - >>> -object_unref(cpu); >>> -error

Re: [PATCH v2] chardev/tcp: fix error message double free error

2020-06-24 Thread Markus Armbruster
lichun writes: > Signed-off-by: lichun > --- > chardev/char-socket.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/chardev/char-socket.c b/chardev/char-socket.c > index afebeec5c3..569d54c144 100644 > --- a/chardev/char-socket.c > +++ b/chardev/char-socket.c > @@ -1

Re: [PULL 00/19] virtio,acpi,pci: fixes, cleanups, tools.

2020-06-24 Thread Michael S. Tsirkin
On Thu, Jun 25, 2020 at 07:47:41AM +0200, Thomas Huth wrote: > On 25/06/2020 01.06, Michael S. Tsirkin wrote: > > The following changes since commit d4b78317b7cf8c0c635b70086503813f79ff21ec: > > > >Merge remote-tracking branch > > 'remotes/pmaydell/tags/pull-target-arm-20200623' into staging

<    1   2   3   4   5   6