[PATCH for-5.1 V5 1/4] hw/mips: Implement the kvm_type() hook in MachineClass

2020-06-23 Thread Huacai Chen
MIPS has two types of KVM: TE & VZ, and TE is the default type. Now we can't create a VZ guest in QEMU because it lacks the kvm_type() hook in MachineClass. This patch add the the kvm_type() hook to support both of the two types. Reviewed-by: Aleksandar Markovic Signed-off-by: Huacai Chen Co-dev

[PULL 42/42] arm/virt: Add memory hot remove support

2020-06-23 Thread Peter Maydell
From: Shameer Kolothum This adds support for memory(pc-dimm) hot remove on arm/virt that uses acpi ged device. NVDIMM hot removal is not yet supported. Signed-off-by: Shameer Kolothum Message-id: 20200622124157.20360-1-shameerali.kolothum.th...@huawei.com Reviewed-by: Eric Auger Tested-by: Er

[PATCH for-5.1 V5 2/4] hw/intc: Add Loongson liointc support

2020-06-23 Thread Huacai Chen
Loongson-3 has an integrated liointc (Local I/O interrupt controller). It is similar to goldfish interrupt controller, but more powerful (e.g., it can route external interrupt to multi-cores). Signed-off-by: Huacai Chen Signed-off-by: Jiaxun Yang --- hw/intc/Kconfig| 3 + hw/intc/

[PULL v1 01/12] docs/specs/tpm: Correct header path name

2020-06-23 Thread Stefan Berger
From: Philippe Mathieu-Daudé Commit 8dc6701722 introduce the documentation but an incorrect path name was used. Fix that. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Berger Message-id: 20200612085444.8362-2-phi...@redhat.com Signed-off-by: Stefan Berger --- docs/specs/tpm.rst |

[PULL v1 05/12] hw/tpm: Include missing 'qemu/option.h' header

2020-06-23 Thread Stefan Berger
From: Philippe Mathieu-Daudé Files using the TPM_STANDARD_CMDLINE_OPTS macro declared in "tpm_int.h" will use QEMU_OPT_STRING definition declared in "qemu/option.h". Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Berger Message-id: 20200612085444.8362-6-phi...@redhat.com Signed-off-

Re: [PATCH v3 1/6] block: add bitmap-populate job

2020-06-23 Thread Kevin Wolf
Am 19.06.2020 um 21:56 hat Eric Blake geschrieben: > From: John Snow > > This job copies the allocation map into a bitmap. It's a job because > there's no guarantee that allocation interrogation will be quick (or > won't hang), so it cannot be retrofitted into block-dirty-bitmap-merge. > > It wa

Re: [PULL 00/42] target-arm queue

2020-06-23 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200623113904.28805-1-peter.mayd...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PULL 00/42] target-arm queue Type: series Message-id: 20200623113904.28805-1-peter.mayd...@linaro.o

[PATCH for-5.1 V5 0/4] mips: Add Loongson-3 machine support (with KVM)

2020-06-23 Thread Huacai Chen
Loongson-3 CPU family include Loongson-3A R1/R2/R3/R4 and Loongson-3B R1/R2. Loongson-3A R1 is the oldest and its ISA is the smallest, while Loongson-3A R4 is the newest and its ISA is almost the superset of all others. To reduce complexity, in QEMU we just define two CPU types: 1, "Loongson-3A100

Re: RFC: use VFIO over a UNIX domain socket to implement device offloading

2020-06-23 Thread Stefan Hajnoczi
On Thu, Jun 18, 2020 at 02:38:04PM -0700, John G Johnson wrote: > > On Jun 15, 2020, at 3:49 AM, Stefan Hajnoczi wrote: > > An issue with file descriptor passing is that it's hard to revoke access > > once the file descriptor has been passed. memfd supports sealing with > > fnctl(F_ADD_SEALS) it d

[PATCH for-5.1 V5 4/4] MAINTAINERS: Add Loongson-3 maintainer and reviewer

2020-06-23 Thread Huacai Chen
Add myself as a maintainer of Loongson-3 virtual platform, and also add Jiaxun Yang as a reviewer. Signed-off-by: Huacai Chen Co-developed-by: Jiaxun Yang --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index f0cb1fd..293188e 100644 --- a/MAIN

Re: [PATCH] virtiofsd: Use clone() and not unshare(), support non-root

2020-06-23 Thread Stefan Hajnoczi
On Wed, Jun 17, 2020 at 08:55:36AM -0400, Colin Walters wrote: > On Wed, Jun 17, 2020, at 8:50 AM, Stefan Hajnoczi wrote: > > > Something along these lines should work. Hopefully seccomp can be > > retained. It would also be necessary to check how not having the shared > > directory as / in the mo

Re: [PATCH] configure: Don't warn about lack of PIE on macOS

2020-06-23 Thread Stefan Hajnoczi
On Mon, Jun 01, 2020 at 03:42:57PM +0300, Roman Bolshakov wrote: > ld64 is making PIE executables for 10.7 and above by default, as > documented in ld(1). > > Signed-off-by: Roman Bolshakov > --- > configure | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/configure b/configure > inde

Re: [PULL 00/18] Block patches

2020-06-23 Thread Peter Maydell
On Mon, 22 Jun 2020 at 16:11, Max Reitz wrote: > > The following changes since commit bae31bfa48b9caecee25da3d5333901a126a06b4: > > Merge remote-tracking branch > 'remotes/kraxel/tags/audio-20200619-pull-request' into staging (2020-06-19 > 22:56:59 +0100) > > are available in the Git repositor

Re: [Bug 1882241] Re: file transfer over cifs to 64bit guest corrupts large files

2020-06-23 Thread Stefan Hajnoczi
On Wed, Jun 17, 2020 at 02:55:55PM -, timsoft wrote: > thanks for the suggestion. I tried using netcat (nc) to transfer a large file > from host to guest, and also from fileserver to guest with the problematic > i82551 emulated network adapter on the host and the files transfered > reliably.

Re: sysbus failed assert for xen_sysdev

2020-06-23 Thread Jason Andryuk
On Tue, Jun 23, 2020 at 4:41 AM Markus Armbruster wrote: > > Jason Andryuk writes: > > > On Mon, Jun 22, 2020 at 5:17 PM Mark Cave-Ayland > > wrote: > >> > >> On 22/06/2020 21:33, Jason Andryuk wrote: > >> > >> > Hi, > >> > > >> > Running qemu devel for a Xen VM is failing an assert after the re

Re: [PATCH for-5.1 V5 0/4] mips: Add Loongson-3 machine support (with KVM)

2020-06-23 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1592914438-30317-1-git-send-email-che...@lemote.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH for-5.1 V5 0/4] mips: Add Loongson-3 machine support (with KVM) Type: series Message-id:

Re: [PATCH v4 5/8] acpi: Enable TPM IRQ

2020-06-23 Thread Igor Mammedov
On Wed, 17 Jun 2020 10:23:02 -0400 Stefan Berger wrote: > From: Stefan Berger > > Move the TPM TIS IRQ to unused IRQ 13, which is the only one accepted by > Windows. Query for the TPM's irq number and enable the TPM IRQ unless > TPM_IRQ_DISABLED is returned. > > Signed-off-by: Stefan Berger >

Re: [PATCH v4 6/8] tests: Add updated DSDT

2020-06-23 Thread Igor Mammedov
On Wed, 17 Jun 2020 10:23:03 -0400 Stefan Berger wrote: > Add the updated DSDT following the interrupt enablement. > > @@ -5,13 +5,13 @@ > * > * Disassembling to symbolic ASL+ operators > * > - * Disassembly of tests/data/acpi/q35/DSDT.tis, Mon Jun 15 09:57:05 2020 > + * Disassembly of /tm

Re: what is the difference to transfer elf execute file or binary file on "-kernel" paramter?

2020-06-23 Thread Stefan Hajnoczi
On Wed, Jun 10, 2020 at 10:42:01PM +0800, tugouxp wrote: > what is the difference to transfer elf execute file or binary file on > "-kernel" paramter? is it the same and all be reconganized rightly for qemu? The -kernel option supports several file formats depending on the machine being emulated.

Re: [PATCH v4 0/8] tpm: Enable usage of TPM TIS with interrupts

2020-06-23 Thread Michael S. Tsirkin
On Wed, Jun 17, 2020 at 10:22:57AM -0400, Stefan Berger wrote: > This series of patches enables the usage of the TPM TIS with interrupts. > We use the unused IRQ 13, which is the only one accepted by Windows. > > Stefan ACPI parts: Reviewed-by: Michael S. Tsirkin How do we want this merge

Re: [PATCH] configure: Don't warn about lack of PIE on macOS

2020-06-23 Thread Roman Bolshakov
On Tue, Jun 23, 2020 at 01:48:57PM +0100, Stefan Hajnoczi wrote: > On Mon, Jun 01, 2020 at 03:42:57PM +0300, Roman Bolshakov wrote: > > ld64 is making PIE executables for 10.7 and above by default, as > > documented in ld(1). > > > > Signed-off-by: Roman Bolshakov > > --- > > configure | 2 ++ >

Re: [PATCH v9 04/10] configure: Generate rule to calculate the base architecture of a target

2020-06-23 Thread Philippe Mathieu-Daudé
On 6/23/20 10:45 AM, Philippe Mathieu-Daudé wrote: > On 6/23/20 10:01 AM, Claudio Fontana wrote: >> Hi Philippe, Alex, >> >> On 6/18/20 2:33 PM, Philippe Mathieu-Daudé wrote: >>> From: Alex Bennée >>> >>> As we encode the base architecture in configure.sh, we can emit >>> the base-arch() function

Re: [PATCH for-5.1 V5 3/4] hw/mips: Add Loongson-3 machine support (with KVM)

2020-06-23 Thread Aleksandar Markovic
уторак, 23. јун 2020., Huacai Chen је написао/ла: > Add Loongson-3 based machine support, it use i8259 as the interrupt > controler and use GPEX as the pci controller. Currently it can only > work with KVM, but we will add TCG support in future. > > As the machine model is not based on any exitin

RE: sysbus failed assert for xen_sysdev

2020-06-23 Thread Paul Durrant
> -Original Message- > From: Jason Andryuk > Sent: 23 June 2020 13:57 > To: Markus Armbruster > Cc: Mark Cave-Ayland ; Anthony PERARD > ; xen- > devel ; Paul Durrant ; QEMU > > Subject: Re: sysbus failed assert for xen_sysdev > > On Tue, Jun 23, 2020 at 4:41 AM Markus Armbruster wrot

Re: [PATCH v4 0/8] tpm: Enable usage of TPM TIS with interrupts

2020-06-23 Thread Stefan Berger
On 6/23/20 9:09 AM, Michael S. Tsirkin wrote: On Wed, Jun 17, 2020 at 10:22:57AM -0400, Stefan Berger wrote: This series of patches enables the usage of the TPM TIS with interrupts. We use the unused IRQ 13, which is the only one accepted by Windows. Stefan ACPI parts: Reviewed-by: Mich

Re: [PATCH v5 1/9] hw/i2c/core: Add i2c_try_create_slave() and i2c_realize_and_unref()

2020-06-23 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 6/23/20 10:01 AM, Markus Armbruster wrote: [...] >> Ideally with my naming suggestions considered: >> Reviewed-by: Markus Armbruster > > If you don't mind, as this series is already fully reviewed, > I'll correct/improve on top of it. Up to you!

Re: [PATCH v3 00/25] risu cleanups and improvements

2020-06-23 Thread Alex Bennée
Alex Bennée writes: > Richard Henderson writes: > >> Version 3 changes the --dump option to --fulldump and --diffdump, >> after an off-hand suggestion by Alex. >> >> These are now mode options, similar to --master. Which means that >> dumping is an orthogonal apprentice type, which means that

Re: [PATCH for-5.1 V5 3/4] hw/mips: Add Loongson-3 machine support (with KVM)

2020-06-23 Thread Aleksandar Markovic
уторак, 23. јун 2020., Huacai Chen је написао/ла: > Add Loongson-3 based machine support, it use i8259 as the interrupt > controler > 8259 or LIOINTC? > > > and use GPEX as the pci controller. Currently it can only work with KVM, but we will add TCG support in future. > > As the machine mode

Re: [PATCH for-5.1 V5 4/4] MAINTAINERS: Add Loongson-3 maintainer and reviewer

2020-06-23 Thread Aleksandar Markovic
уторак, 23. јун 2020., Huacai Chen је написао/ла: > Add myself as a maintainer of Loongson-3 virtual platform, and also add > Jiaxun Yang as a reviewer. > > Signed-off-by: Huacai Chen > Co-developed-by: Jiaxun Yang > --- > MAINTAINERS | 6 ++ > 1 file changed, 6 insertions(+) > > diff --gi

Re: [PATCH for-5.1 V5 0/4] mips: Add Loongson-3 machine support (with KVM)

2020-06-23 Thread Aleksandar Markovic
уторак, 23. јун 2020., је написао/ла: > Patchew URL: https://patchew.org/QEMU/1592914438-30317-1-git-send- > email-che...@lemote.com/ > > > > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Hi, Huacai. Please fix all checkpatch warnings

Re: [PATCH for-5.1 V5 2/4] hw/intc: Add Loongson liointc support

2020-06-23 Thread Aleksandar Markovic
уторак, 23. јун 2020., Huacai Chen је написао/ла: > Loongson-3 has an integrated liointc (Local I/O interrupt controller). > It is similar to goldfish interrupt controller, but more powerful (e.g., > it can route external interrupt to multi-cores). > > Signed-off-by: Huacai Chen > Signed-off-by:

Re: [PATCH for-5.1 V5 3/4] hw/mips: Add Loongson-3 machine support (with KVM)

2020-06-23 Thread Aleksandar Markovic
уторак, 23. јун 2020., Huacai Chen је написао/ла: > Add Loongson-3 based machine support, it use i8259 as the interrupt > controler and use GPEX as the pci controller. Currently it can only > work with KVM, but we will add TCG support in future. > > As the machine model is not based on any exitin

Re: [PATCH v2] qcow2: Fix preallocation on images with unaligned sizes

2020-06-23 Thread Alberto Garcia
ping On Wed 17 Jun 2020 04:00:36 PM CEST, Alberto Garcia wrote: > When resizing an image with qcow2_co_truncate() using the falloc or > full preallocation modes the code assumes that both the old and new > sizes are cluster-aligned. > > There are two problems with this: > > 1) The calculation of

Re: [RFC PATCH 3/3] fuzz: Add callbacks for dma-access functions

2020-06-23 Thread Stefan Hajnoczi
On Thu, Jun 11, 2020 at 01:56:51AM -0400, Alexander Bulekov wrote: > Signed-off-by: Alexander Bulekov > --- > exec.c| 17 - > include/exec/memory.h | 8 > include/exec/memory_ldst_cached.inc.h | 9 + > include/syse

Re: [RFC PATCH 0/3] fuzz: add generic fuzzer

2020-06-23 Thread Stefan Hajnoczi
On Thu, Jun 11, 2020 at 01:56:48AM -0400, Alexander Bulekov wrote: > These patches add a generic fuzzer for virtual devices. This should > allow us to fuzz devices that accept inputs over MMIO, PIO and DMA > without any device-specific code. > > Example: > QEMU_FUZZ_ARGS="-device virtio-net" \ > F

Re: [PATCH v2] target/i386: reimplement fpatan using floatx80 operations

2020-06-23 Thread Joseph Myers
On Tue, 23 Jun 2020, Paolo Bonzini wrote: > On 23/06/20 02:01, Joseph Myers wrote: > > The x87 fpatan emulation is currently based around conversion to > > double. This is inherently unsuitable for a good emulation of any > > floatx80 operation. Reimplement using the soft-float operations, as >

[PULL 08/16] blockdev: Deprecate -drive with bogus interface type

2020-06-23 Thread Markus Armbruster
Drives with interface types other than if=none are for onboard devices. Unfortunately, any such drives the board doesn't pick up can still be used with -device, like this: $ qemu-system-x86_64 -nodefaults -display none -S -drive if=floppy,id=bogus,unit=7 -device ide-cd,drive=bogus -monitor s

[PULL 09/16] qdev: Eliminate get_pointer(), set_pointer()

2020-06-23 Thread Markus Armbruster
We stopped using get_pointer() and set_pointer() for netdev in commit 23120b13c6 "net: don't use set/get_pointer() in set/get_netdev()" (v2.3.0), and for chardev in commit becdfa00cf "char: replace PROP_CHR with CharBackend" (v2.8.0). With only the drive user left, they're not helpful anymore. El

[PULL 00/16] Qdev patches for 2020-06-23

2020-06-23 Thread Markus Armbruster
The following changes since commit 61fee7f45955cd0bf9b79be9fa9c7ebabb5e6a85: Merge remote-tracking branch 'remotes/philmd-gitlab/tags/acceptance-testing-20200622' into staging (2020-06-22 20:50:10 +0100) are available in the Git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-qde

[PULL 07/16] docs/qdev-device-use.txt: Update section "Default Devices"

2020-06-23 Thread Markus Armbruster
Resynchronize the table of default device suppressions with vl.c's default_list[]. Signed-off-by: Markus Armbruster Message-Id: <20200622094227.1271650-8-arm...@redhat.com> --- docs/qdev-device-use.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/qdev-device-use.t

[PULL 01/16] iotests/172: Include "info block" in test output

2020-06-23 Thread Markus Armbruster
The additional output demonstrates we screw up when -global isa-fdc clashes with -drive if=floppy or its sugared forms: according to "info qtree", only the latter backend is attached, but according to "info block", both are. For instance: Testing: -fda TEST_DIR/t.qcow2 -drive if=none,file=TES

[PULL 14/16] arm/aspeed: Drop aspeed_board_init_flashes() parameter @errp

2020-06-23 Thread Markus Armbruster
We always pass &error_abort. Drop the parameter, use &error_abort directly. Cc: Cédric Le Goater Cc: Peter Maydell Cc: Andrew Jeffery Cc: Joel Stanley Cc: qemu-...@nongnu.org Signed-off-by: Markus Armbruster Reviewed-by: Cédric Le Goater Reviewed-by: Philippe Mathieu-Daudé Message-Id: <202

[PULL 15/16] sd/pxa2xx_mmci: Don't crash on pxa2xx_mmci_init() error

2020-06-23 Thread Markus Armbruster
On error, pxa2xx_mmci_init() reports to stderr and returns NULL. Callers don't check for errors. Machines akita, borzoi, mainstone, spitz, terrier, tosa, and z2 crash shortly after, like this: $ qemu-system-aarch64 -M akita -drive if=sd,readonly=on qemu-system-aarch64: failed to init SD c

[PULL 05/16] fdc: Open-code fdctrl_init_isa()

2020-06-23 Thread Markus Armbruster
Helper function fdctrl_init_isa() is less than helpful: one of three places creating "isa-fdc" devices use it. Open-code it there, and drop the function. Signed-off-by: Markus Armbruster Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20200622094227.1271650-6-arm...@redhat.com> --- include/hw

[PULL 10/16] qdev: Improve netdev property override error a bit

2020-06-23 Thread Markus Armbruster
qdev_prop_set_netdev() fails when the property already has a non-null value. Seems to go back to commit 30c367ed44 "qdev-properties-system.c: Allow vlan or netdev for -device, not both", v1.7.0. Board code doesn't expect failure, and crashes: $ qemu-system-x86_64 --nodefaults -nic user -netd

[PULL 04/16] fdc: Reject clash between -drive if=floppy and -global isa-fdc

2020-06-23 Thread Markus Armbruster
The floppy controller devices desugar their drive properties into floppy devices (since commit a92bd191a4 "fdc: Move qdev properties to FloppyDrive", v2.8.0). This involves some bad magic in fdctrl_connect_drives(), and exists for backward compatibility. The functions for boards to create floppy

[PULL 03/16] iotests/172: Cover -global floppy.drive=...

2020-06-23 Thread Markus Armbruster
Use of -global to set a default backend for non-singleton devices is a bad idea. But as long as we permit it, we better test it. Test output demonstrates we screw up when -global floppy clashes with -fda or with -device floppy: according to "info qtree", only the latter backend is attached, but a

[PULL 16/16] sd/milkymist-memcard: Fix error API violation

2020-06-23 Thread Markus Armbruster
The Error ** argument must be NULL, &error_abort, &error_fatal, or a pointer to a variable containing NULL. Passing an argument of the latter kind twice without clearing it in between is wrong: if the first call sets an error, it no longer points to NULL for the second call. milkymist_memcard_rea

[PULL 11/16] qdev: Reject drive property override

2020-06-23 Thread Markus Armbruster
qdev_prop_set_drive() screws up when the property already has a non-null value: it neglects to release the old value. Both the old and the new backend become attached to the same device. Example (taken from iotest 172): -fda ... -drive if=none,... -global floppy.drive=none0. Special case: attemp

[PULL 06/16] fdc: Deprecate configuring floppies with -global isa-fdc

2020-06-23 Thread Markus Armbruster
Deprecate -global isa-fdc.driveA=... -global isa-fdc.driveB=... in favour of -device floppy,unit=0,drive=... -device floppy,unit=1,drive=... Same for the other floppy controller devices. Signed-off-by: Markus Armbruster Acked-by: John Snow Message-Id: <20200622094227.1271650-

[PULL 02/16] iotests/172: Cover empty filename and multiple use of drives

2020-06-23 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Message-Id: <20200622094227.1271650-3-arm...@redhat.com> --- tests/qemu-iotests/172 | 12 + tests/qemu-iotests/172.out | 50 ++ 2 files changed, 62 insertions(+) diff --git a/tests/qemu-iotests/172 b/tests/qemu-iote

[PULL 13/16] qdev: Make qdev_prop_set_drive() match the other helpers

2020-06-23 Thread Markus Armbruster
qdev_prop_set_drive() can fail. None of the other qdev_prop_set_FOO() can; they abort on error. To clean up this inconsistency, rename qdev_prop_set_drive() to qdev_prop_set_drive_err(), and create a qdev_prop_set_drive() that aborts on error. Coccinelle script to update callers: @ depends

[PULL 12/16] qdev: Reject chardev property override

2020-06-23 Thread Markus Armbruster
qdev_prop_set_chr() screws up when the property already has a non-null value: it neglects to release the old value. Both the old and the new backend become attached to the same device. Unlike for block devices (see previous commit), this can't be observed from the monitor (I think). Example: -se

Re: [Bug 1883400] [NEW] Windows 10 extremely slow and unresponsive

2020-06-23 Thread Stefan Hajnoczi
On Sun, Jun 14, 2020 at 01:30:07AM -, Toddandmargo-n wrote: > Public bug reported: > > Hi, > > Fedora 32, x64 > qemu-5.0.0-2.fc32.x86_64 > > https://www.microsoft.com/en-us/software-download/windows10ISO > Win10_2004_English_x64.iso > > Windows 10 is excruciatingly slow since upgrading to 5

Re: qemu win10 host winxp quest very slow

2020-06-23 Thread Stefan Hajnoczi
On Mon, Jun 15, 2020 at 11:03:40AM +0200, Dario Ciriminna wrote: > Hello folks, > > i need to compile and run qemu under Windows 10 host (Pentium G860, very > bad)  with a Windows XP guest. > Precompiled downloaded binary run smoothly, but my compiled version is very > very slow (I NEED to compile

Re: [PULL 00/16] Qdev patches for 2020-06-23

2020-06-23 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200623142326.2349416-1-arm...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PULL 00/16] Qdev patches for 2020-06-23 Type: series Message-id: 20200623142326.2349416-1-arm...@redhat.

[PATCH v5 0/7] Introduce 'yank' oob qmp command to recover from hanging qemu

2020-06-23 Thread Lukas Straub
Hello Everyone, In many cases, if qemu has a network connection (qmp, migration, chardev, etc.) to some other server and that server dies or hangs, qemu hangs too. These patches introduce the new 'yank' out-of-band qmp command to recover from these kinds of hangs. The different subsystems register

[PATCH v5 1/7] Introduce yank feature

2020-06-23 Thread Lukas Straub
The yank feature allows to recover from hanging qemu by "yanking" at various parts. Other qemu systems can register themselves and multiple yank functions. Then all yank functions for selected instances can be called by the 'yank' out-of-band qmp command. Available instances can be queried by a 'qu

[PATCH v5 2/7] block/nbd.c: Add yank feature

2020-06-23 Thread Lukas Straub
Register a yank function which shuts down the socket and sets s->state = NBD_CLIENT_QUIT. This is the same behaviour as if an error occured. Signed-off-by: Lukas Straub --- block/nbd.c | 101 +--- 1 file changed, 64 insertions(+), 37 deletions(-)

[PATCH v5 4/7] migration: Add yank feature

2020-06-23 Thread Lukas Straub
Register yank functions on sockets to shut them down. Signed-off-by: Lukas Straub --- migration/channel.c | 12 migration/migration.c | 18 +- migration/multifd.c | 10 ++ migration/qemu-file-channel.c | 6 ++ migration/savevm

[PATCH v5 3/7] chardev/char-socket.c: Add yank feature

2020-06-23 Thread Lukas Straub
Register a yank function to shutdown the socket on yank. Signed-off-by: Lukas Straub --- chardev/char-socket.c | 24 1 file changed, 24 insertions(+) diff --git a/chardev/char-socket.c b/chardev/char-socket.c index afebeec5c3..4e7a7e9ae4 100644 --- a/chardev/char-socket

[PATCH v5 5/7] io/channel-tls.c: make qio_channel_tls_shutdown thread-safe

2020-06-23 Thread Lukas Straub
Make qio_channel_tls_shutdown thread-safe by using atomics when accessing tioc->shutdown. Signed-off-by: Lukas Straub --- io/channel-tls.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/io/channel-tls.c b/io/channel-tls.c index 7ec8ceff2f..b350c84640 100644 --- a/io/ch

Re: [PATCH for-5.1 V5 2/4] hw/intc: Add Loongson liointc support

2020-06-23 Thread Aleksandar Markovic
уто, 23. јун 2020. у 14:13 Huacai Chen је написао/ла: > Loongson-3 has an integrated liointc (Local I/O interrupt controller). > It is similar to goldfish interrupt controller, but more powerful (e.g., > Any pointers to documentation? Thanks, Aleksandar > it can route external interrupt to m

[PATCH v5 7/7] MAINTAINERS: Add myself as maintainer for yank feature

2020-06-23 Thread Lukas Straub
I'll maintain this for now as the colo usecase is the first user of this functionality. Signed-off-by: Lukas Straub --- MAINTAINERS | 13 + 1 file changed, 13 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 955cc8dd5c..a403d59190 100644 --- a/MAINTAINERS +++ b/MAINTAINERS

[PATCH v5 6/7] io: Document thread-safety of qio_channel_shutdown

2020-06-23 Thread Lukas Straub
Migration and yank code assume that qio_channel_shutdown is thread -safe. Document this after checking the code. Signed-off-by: Lukas Straub --- include/io/channel.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/io/channel.h b/include/io/channel.h index d4557f0930..6b8a2b87b8 100

Re: [RFC PATCH v2] linux-user: Use FD_32BIT_MODE fd flag for 32-bit guests

2020-06-23 Thread Laurent Vivier
Le 23/06/2020 à 12:01, Peter Maydell a écrit : > If the guest is 32 bit then there is a potential problem if the > host gives us back a 64-bit sized value that we can't fit into > the ABI the guest requires. This is a theoretical issue for many > syscalls, but a real issue for directory reads where

Re: [PATCH v2 0/3] hyperv: vmbus: ACPI various corrections

2020-06-23 Thread Igor Mammedov
On Tue, 23 Jun 2020 12:02:40 +0200 Paolo Bonzini wrote: > On 17/06/20 18:09, Jon Doron wrote: > > After doing further tests and looking at the latest HyperV ACPI DSDT. > > Do minor fix to our VMBus ACPI entry. > > > > v2: > > Renamed irq0 to irq now that there is a single IRQ required > > > > J

Re: [PATCH v3 1/3] hyperv: vmbus: Remove the 2nd IRQ

2020-06-23 Thread Igor Mammedov
On Thu, 18 Jun 2020 06:00:25 +0300 Jon Doron wrote: > It seems like Windows does not really require 2 IRQs to have a > functioning VMBus. > > Signed-off-by: Jon Doron Reviewed-by: Igor Mammedov > --- > hw/hyperv/vmbus.c| 3 +-- > hw/i386/acpi-build.c | 4 +--- >

Re: [PATCH v2 0/7] block/nvme: support nested aio_poll()

2020-06-23 Thread Stefan Hajnoczi
On Wed, Jun 17, 2020 at 02:21:54PM +0100, Stefan Hajnoczi wrote: > v2: > * Reword comment in Patch 1 explainin why its safe not to hold q->lock > [Sergio] > * Fix s/unwiedly/unwieldy/ typo in the Patch 6 commit description [Philippe] > > This series allows aio_poll() to work from I/O request co

Re: Overriding PCI Vendor/Device IDs

2020-06-23 Thread Stefan Hajnoczi
On Sun, Jun 21, 2020 at 09:31:30AM +0200, Antonio Raffaele wrote: > Hi I'm trying to create a qemu virtual machine that runs windows 10. I > would like to try to make it almost indistinguishable from a real computer > (I know it's impossible, but at least I get close). I have already changed > any

Re: [PATCH] Makefile: Compute libraries for libqemuutil.a and libvhost-user.a

2020-06-23 Thread Stefan Hajnoczi
On Tue, Jun 16, 2020 at 06:18:14PM +0200, Christophe de Dinechin wrote: > In util/Makefile.objs, there is a setting for dbus.o-libs. > Trying to copy-paste that to add a library for module.o that was was > not otherwise linked yields link errors on a number of binaries, > e.g. qemu-ga, with unsatis

[PATCH] Revert "tests/migration: Reduce autoconverge initial bandwidth"

2020-06-23 Thread Michael S. Tsirkin
This reverts commit 6d1da867e65f ("tests/migration: Reduce autoconverge initial bandwidth") since that change makes unit tests much slower for all developers, while it's not a robust way to fix migration tests. Migration tests need to find a more robust way to discover a reasonable bandwidth with

Re: [PATCH v4 0/7] build some devices as modules.

2020-06-23 Thread Stefan Hajnoczi
On Mon, Jun 22, 2020 at 03:55:54PM +0200, Gerd Hoffmann wrote: > Specifically devices which depend on shared libraries, > to reduce the runtime dependencies of core qemu. Just wanted to say great that you are doing this! Nice that progress is being made on QEMU modularization. Stefan signature.

[PATCH] risu: don't do a full register compare for OP_SIGILL

2020-06-23 Thread Alex Bennée
OP_SIGILL means we have an unexpected invalid operation. If this is a load or store the register state may be un-rectified pointing at the memblock so would be invalid. In this case just compare the PC and make sure the other end also faulted at the same place. Signed-off-by: Alex Bennée --- ris

Re: [PATCH v2 1/3] hyperv: vmbus: Remove the 2nd IRQ

2020-06-23 Thread Igor Mammedov
On Wed, 17 Jun 2020 19:09:02 +0300 Jon Doron wrote: > It seems like Windows does not really require 2 IRQs to have a > functioning VMBus. > > Signed-off-by: Jon Doron > --- > dtc | 2 +- > hw/hyperv/vmbus.c| 3 +-- > hw/i386/acpi-build.c

Re: [PATCH v3 2/3] i386: acpi: vmbus: Add _ADR definition

2020-06-23 Thread Igor Mammedov
On Thu, 18 Jun 2020 06:00:26 +0300 Jon Doron wrote: > It seems like latest HyperV sets _ADR to 0 in the ACPI for the VMBS that's a hardly a good reason to add this. To me looks like a pointless addition, _ADR mostly is used when device resides on a bus with standard ennumeration algorithm (i.e.

Re: [PATCH 2/2] scripts/tracetool: Add plainlog backend

2020-06-23 Thread Stefan Hajnoczi
On Thu, Jun 18, 2020 at 04:43:23PM +0100, Daniel P. Berrangé wrote: > On Thu, Jun 18, 2020 at 04:35:16PM +0100, Stefan Hajnoczi wrote: > > On Thu, Jun 18, 2020 at 10:07:41AM +0100, Daniel P. Berrangé wrote: > > > On Thu, Jun 18, 2020 at 08:31:24AM +0100, Stefan Hajnoczi wrote: > > > > On Wed, Jun 1

Re: [PATCH v3 3/3] acpi: i386: Move VMBus DSDT entry to SB

2020-06-23 Thread Igor Mammedov
On Thu, 18 Jun 2020 06:00:27 +0300 Jon Doron wrote: > Signed-off-by: Jon Doron > --- > hw/i386/acpi-build.c | 12 +++- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c > index 6d9df38e31..38be9e5a58 100644 > --- a/hw/i386/ac

Re: [PATCH v4 1/5] qdev: Introduce DEFINE_PROP_RESERVED_REGION

2020-06-23 Thread Markus Armbruster
Eric Auger writes: > Introduce a new property defining a reserved region: > ::. > > This will be used to encode reserved IOVA regions. > > For instance, in virtio-iommu use case, reserved IOVA regions > will be passed by the machine code to the virtio-iommu-pci > device (an array of those). The t

Re: [PATCH v3] docs: vhost-user: add Virtio status protocol feature

2020-06-23 Thread Stefan Hajnoczi
On Thu, Jun 18, 2020 at 03:45:01PM +0200, Maxime Coquelin wrote: > This patch specifies the VHOST_USER_SET_STATUS and > VHOST_USER_GET_STATUS requests, which are sent by > the master to update and query the Virtio status > in the backend. > > Signed-off-by: Maxime Coquelin > --- > Changes since v

Re: [PATCH v3 1/5] qdev: Introduce DEFINE_PROP_RESERVED_REGION

2020-06-23 Thread Markus Armbruster
Auger Eric writes: > Hi Markus, > > On 6/22/20 1:22 PM, Markus Armbruster wrote: >> Eric Auger writes: >> >>> Introduce a new property defining a reserved region: >>> , , . [...] >> I dimly remember discussing the wisdom of numeric type here, dig, dig, >> ..., aha: >> >> Subject: Re: [PATC

Re: [PATCH v3 17/25] Add magic and size to the trace header

2020-06-23 Thread Alex Bennée
Richard Henderson writes: > Sanity check that we're not getting out of sync with > the trace stream. This will be especially bad with > the change in size of the sve save data. > > Signed-off-by: Richard Henderson > --- > risu.h | 10 +++- > risu.c | 162

Re: [PATCH v3 18/25] Compute reginfo_size based on the reginfo

2020-06-23 Thread Alex Bennée
Richard Henderson writes: > This will allow dumping of SVE frames without having > to know the SVE vector length beforehand. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée

Re: [RFC PATCH 3/3] fuzz: Add callbacks for dma-access functions

2020-06-23 Thread Alexander Bulekov
On 200623 1514, Stefan Hajnoczi wrote: > On Thu, Jun 11, 2020 at 01:56:51AM -0400, Alexander Bulekov wrote: > > Signed-off-by: Alexander Bulekov > > --- > > exec.c| 17 - > > include/exec/memory.h | 8 > > include/exec/memo

Re: [PATCH v2] Stop vhost-user sending uninitialized mmap_offsets

2020-06-23 Thread Stefan Hajnoczi
On Mon, Jun 22, 2020 at 11:50:44PM +, Raphael Norwitz wrote: > Prior to this change, the vhost_user_fill_msg_region function filled out > all elements of the VhostUserMemoryRegion struct except the mmap_offset. > > This function is often called on uninitialized structs, which are then > copied

Re: [PATCH v3 1/5] qdev: Introduce DEFINE_PROP_RESERVED_REGION

2020-06-23 Thread Auger Eric
Hi Markus, On 6/23/20 5:15 PM, Markus Armbruster wrote: > Auger Eric writes: > >> Hi Markus, >> >> On 6/22/20 1:22 PM, Markus Armbruster wrote: >>> Eric Auger writes: >>> Introduce a new property defining a reserved region: , , . > [...] >>> I dimly remember discussing the wisdom of n

Re: [PATCH v3 0/3] hyperv: vmbus: ACPI various corrections

2020-06-23 Thread Igor Mammedov
On Thu, 18 Jun 2020 06:00:24 +0300 Jon Doron wrote: > After doing further tests and looking at the latest HyperV ACPI DSDT. > Do minor fix to our VMBus ACPI entry. > > v3: > Removed accidental change for the dct submodule head > > v2: > Renamed irq0 to irq now that there is a single IRQ require

Re: [PATCH] risu: don't do a full register compare for OP_SIGILL

2020-06-23 Thread Richard Henderson
On 6/23/20 7:44 AM, Alex Bennée wrote: > +} else if (header.pc != get_pc(&ri[APPRENTICE])) { > +res = RES_MISMATCH_REG; You need a new MISMATCH code, because this one implies that you have a reginfo struct to compare. But thanks, I'll incorporate this. r~

[Bug 1883400] Re: Windows 10 extremely slow and unresponsive

2020-06-23 Thread Toddandmargo-n
1877716 sounds exactly like what I experienced. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1883400 Title: Windows 10 extremely slow and unresponsive Status in QEMU: New Bug description: Hi

Re: [PATCH 1/7] accel/kvm: Let kvm_check_extension use global KVM state

2020-06-23 Thread Cornelia Huck
On Tue, 23 Jun 2020 12:50:46 +0200 Philippe Mathieu-Daudé wrote: > As KVM supported extentions those should be the same for > all VMs, it is safe to directly use the global kvm_state > in kvm_check_extension(). > > Suggested-by: Paolo Bonzini > Signed-off-by: Philippe Mathieu-Daudé > --- > ac

Re: [PATCH v4 3/7] ccid: build smartcard as module

2020-06-23 Thread Philippe Mathieu-Daudé
Hi Gerd, On 6/22/20 3:55 PM, Gerd Hoffmann wrote: > Drops libcacard.so dependency from core qemu. > > Signed-off-by: Gerd Hoffmann > --- > Makefile.objs| 1 + > hw/core/qdev.c | 2 ++ > hw/Makefile.objs | 1 + > hw/usb/Makefile.objs | 4 +++- > 4 files changed, 7 insertions(+)

Re: [PATCH] Revert "tests/migration: Reduce autoconverge initial bandwidth"

2020-06-23 Thread Philippe Mathieu-Daudé
On 6/23/20 4:56 PM, Michael S. Tsirkin wrote: > This reverts commit 6d1da867e65f ("tests/migration: Reduce autoconverge > initial bandwidth") > since that change makes unit tests much slower for all developers, while it's > not > a robust way to fix migration tests. Migration tests need to find >

[Bug 1878067] Re: Assertion failure in eth_get_gso_type through the e1000e

2020-06-23 Thread Alexander Bulekov
Here is a shorter reporoducer: cat << EOF | ./i386-softmmu/qemu-system-i386 -qtest stdio -monitor none -serial none -M pc-q35-5.0 -nographic outl 0xcf8 0x80001010 outl 0xcfc 0xe102 outl 0xcf8 0x80001014 outl 0xcf8 0x80001004 outw 0xcfc 0x7 outl 0xcf8 0x800010a2 write 0xe1020420 0x4 0x

Re: [PATCH 2/7] accel/kvm: Simplify kvm_check_extension()

2020-06-23 Thread Cornelia Huck
On Tue, 23 Jun 2020 12:50:47 +0200 Philippe Mathieu-Daudé wrote: > In previous commit we let kvm_check_extension() use the > global kvm_state. Since the KVMState* argument is now > unused, drop it. > > Convert callers with this Coccinelle script: > > @@ > expression kvm_state, extension; >

Re: [PATCH v3 0/3] hyperv: vmbus: ACPI various corrections

2020-06-23 Thread Paolo Bonzini
On 23/06/20 17:11, Igor Mammedov wrote: > On Thu, 18 Jun 2020 06:00:24 +0300 > Jon Doron wrote: > >> After doing further tests and looking at the latest HyperV ACPI DSDT. >> Do minor fix to our VMBus ACPI entry. >> >> v3: >> Removed accidental change for the dct submodule head >> >> v2: >> Rename

Re: [PATCH v2 0/3] hyperv: vmbus: ACPI various corrections

2020-06-23 Thread Paolo Bonzini
On 23/06/20 16:57, Igor Mammedov wrote: >>> >>> dtc | 2 +- >>> hw/hyperv/vmbus.c| 3 +-- >>> hw/i386/acpi-build.c | 17 + >>> include/hw/hyperv/vmbus-bridge.h | 3 +-- >>> 4 files changed, 12 insertions(+), 13 deletions(-

[PATCH] target/ppc: Remove TIDR from POWER10 processor

2020-06-23 Thread Cédric Le Goater
It is not part of Power ISA Version 3.1. Signed-off-by: Cédric Le Goater --- target/ppc/translate_init.inc.c | 5 - 1 file changed, 5 deletions(-) diff --git a/target/ppc/translate_init.inc.c b/target/ppc/translate_init.inc.c index a40888411c1a..49212bfd90f2 100644 --- a/target/ppc/translat

Re: [PATCH 3/7] accel/kvm: Simplify kvm_check_extension_list()

2020-06-23 Thread Cornelia Huck
On Tue, 23 Jun 2020 12:50:48 +0200 Philippe Mathieu-Daudé wrote: > The KVMState* argument is now unused, drop it. > > Signed-off-by: Philippe Mathieu-Daudé > --- > accel/kvm/kvm-all.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Cornelia Huck

Re: [PATCH] risu: don't do a full register compare for OP_SIGILL

2020-06-23 Thread Peter Maydell
On Tue, 23 Jun 2020 at 16:07, Alex Bennée wrote: > > OP_SIGILL means we have an unexpected invalid operation. If this is a > load or store the register state may be un-rectified pointing at the > memblock so would be invalid. In this case just compare the PC and > make sure the other end also faul

Re: [Bug 1878067] [NEW] Assertion failure in eth_get_gso_type through the e1000e

2020-06-23 Thread Philippe Mathieu-Daudé
Cc'ing Dmitry On 5/11/20 8:04 PM, Alexander Bulekov wrote: > Public bug reported: > > Hello, > While fuzzing, I found an input that triggers an assertion failure in > eth_get_gso_type through the e1000e: > > #1 0x7685755b in __GI_abort () at abort.c:79 > #2 0x77c75dc3 in () at

<    1   2   3   4   5   6   >