On 6/21/20 12:58 AM, Philippe Mathieu-Daudé wrote:
> Emit a trace event when a GPIO change its state.
I understand now why you need 'pin_status'.
We could compute 'pin_status' and 'pin_changed' in routine
pca9552_update_pin_input() when updating the PCA9552_INPUT0/1
register values and pass th
On 6/21/20 12:58 AM, Philippe Mathieu-Daudé wrote:
> The PCA9552 has 16 GPIOs which can be used as input,
> output or PWM mode. QEMU models the output GPIO with
> the qemu_irq type. Let the device expose the 16 GPIOs
> to allow us to later connect LEDs to these outputs.
>
> Signed-off-by: Philippe
On 6/19/20 8:02 PM, Philippe Mathieu-Daudé wrote:
> Hi,
>
> On Tue, Apr 7, 2020 at 6:42 AM David Gibson
> wrote:
>>
>> From: Cédric Le Goater
>>
>> Commit e2392d4395dd ("ppc/pnv: Create BMC devices at machine init")
>> introduced default BMC devices which can be a problem when the same
>> devic
On 6/22/20 8:57 AM, Greg Kurz wrote:
> The device introspect test in qtest emits some warnings with the
> the pnv machine types during the "nodefaults" phase:
>
> TEST check-qtest-ppc64: tests/qtest/device-introspect-test
> qemu-system-ppc64: warning: machine has no BMC device. Use '-device
> ipmi
On 19.06.2020 20:03, Peter Maydell wrote:
Since commit ba3e7926691ed3 it has been unnecessary for target code
to call gen_io_end() after an IO instruction in icount mode; it is
sufficient to call gen_io_start() before it and to force the end of
the TB.
Many now-unnecessary calls to gen_io_end()
On 20.06.20 06:21, Richard Henderson wrote:
> The output is 128-bit, and thus requires a pair of 64-bit temps.
>
> Buglink: https://bugs.launchpad.net/bugs/1883984
> Signed-off-by: Richard Henderson
> ---
> target/s390x/insn-data.def | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> d
Let's initialize the structs at the beginning to ease reading and also
zeroing all other fields. This also makes the compiler stop
complaining about sense_id_ccw.flags being ored into when it's not
initialized.
Signed-off-by: Janosch Frank
Reviewed-by: Pierre Morel
Reviewed-by: Thomas Huth
Revi
If we have a lowcore struct that has members for offsets that we want
to touch, why not use it?
Signed-off-by: Janosch Frank
Reviewed-by: David Hildenbrand
---
pc-bios/s390-ccw/cio.h | 17 +++--
pc-bios/s390-ccw/main.c | 8 +++-
2 files changed, 14 insertions(+), 11 deletions(
The bios is in dire need for a cleanup as there are still a lot of
magic constants being used throughout as well as duplicated code.
In the first part of this series we consolidate constants and
functions, as well as doing some minor cleanups and fixes.
The patches are available here:
https://git
Let's consolidate timing related functions into one header.
Signed-off-by: Janosch Frank
---
pc-bios/s390-ccw/menu.c| 1 +
pc-bios/s390-ccw/netmain.c | 15 +++
pc-bios/s390-ccw/s390-ccw.h| 8
pc-bios/s390-ccw/s390-time.h | 23 +++
pc-b
Let's make it a bit more clear that we check the full 64 bits to fit
into the 32 we return.
Signed-off-by: Janosch Frank
Suggested-by: David Hildenbrand
Reviewed-by: David Hildenbrand
Reviewed-by: Thomas Huth
---
pc-bios/s390-ccw/helper.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Let's move some of the PSW mask defines into s390-arch.h and use them
in jump2ipl.c. Also let's introduce a new constant for the address
mask of 8 byte (short) PSWs.
Signed-off-by: Janosch Frank
Reviewed-by: David Hildenbrand
---
pc-bios/s390-ccw/jump2ipl.c | 10 --
pc-bios/s390-ccw/s3
They are definitely helper functions.
Signed-off-by: Janosch Frank
Reviewed-by: Christian Borntraeger
---
pc-bios/s390-ccw/helper.h | 17 +
pc-bios/s390-ccw/s390-ccw.h| 18 --
pc-bios/s390-ccw/virtio-net.c | 1 +
pc-bios/s390-ccw/virtio-scsi.c | 1 +
On 21.06.2020 02:36, Philippe Mathieu-Daudé wrote:
Hi Pavel,
On 5/31/20 5:09 PM, Philippe Mathieu-Daudé wrote:
On 5/29/20 9:04 AM, Pavel Dovgalyuk wrote:
The following series adds record/replay tests to the acceptance group.
Test pass successfully with the latest submitted record/replay fixes:
ZMODE has a lot of ambiguity with the ESAME architecture mode, but is
actually 64 bit addressing.
As PSW_MASK_64 is now effectively 33 bit long and the PSWLegacy struct
has 2 32 bit members, let's also use a unsigned long pointer in
dasd-ipl.c instead when oring the constant into a 8 byte PSW.
Si
panic() was defined for the ccw and net bios, i.e. twice, so it's
cleaner to rather put it into the header.
Also let's add an infinite loop into the assembly of disabled_wait() so
the caller doesn't need to take care of it.
Signed-off-by: Janosch Frank
Reviewed-by: Pierre Morel
Reviewed-by: Dav
Why should we do conversion of a ebcdic value if we have a handy table
where we could look up the ascii value instead?
Signed-off-by: Janosch Frank
Reviewed-by: David Hildenbrand
Reviewed-by: Thomas Huth
---
pc-bios/s390-ccw/bootmap.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
d
On 22.06.2020 08:24, Max Filippov wrote:
On Fri, Jun 19, 2020 at 10:05 AM Peter Maydell wrote:
I've just sent a patch that removes the target/arm gen_io_end() calls.
I had a quick look at sparc, xtensa and ppc, but they were too complicated
for a quick look to be sufficient :-)
I've checked t
You need to reset the state from Incomplete to New after you've provided
the information.
** Changed in: qemu
Status: Expired => New
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1873338
Titl
On Mon, 22 Jun 2020 09:13:46 +0200
Cédric Le Goater wrote:
> On 6/22/20 8:57 AM, Greg Kurz wrote:
> > The device introspect test in qtest emits some warnings with the
> > the pnv machine types during the "nodefaults" phase:
> >
> > TEST check-qtest-ppc64: tests/qtest/device-introspect-test
> > q
Hi Pavel,
On 5/29/20 9:05 AM, Pavel Dovgalyuk wrote:
> This patch adds a test for record/replay, which boots Linux
> image from the disk and interacts with the network.
> The idea and code of this test is borrowed from boot_linux.py
> However, currently record/replay works only for x86_64,
> there
David Hildenbrand writes:
> On 15.06.20 08:17, Markus Armbruster wrote:
>> David Hildenbrand writes:
>>
>>> Commit 7d2ef6dcc1cf ("hmp: Simplify qom-set") switched to the json
>>> parser, making it possible to specify complex types. However, with this
>>> change it is no longer possible to speci
Patchew URL:
https://patchew.org/QEMU/20200622074235.32528-1-fran...@linux.ibm.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PATCH v4 0/9] pc-bios: s390x: Cleanup part 1
Type: series
Message-id: 20200622074235.32528-1-fran...@l
On 19.06.20 23:53, Alexander Duyck wrote:
> From: Alexander Duyck
>
> Based on code review it appears possible for the driver to force the device
> out of a stopped state when hinting by repeating the last ID it was
> provided.
Indeed, thanks for noticing.
>
> Prevent this by only allowing a t
On Mon, Jun 22, 2020 at 08:57:18AM +0200, Greg Kurz wrote:
> The device introspect test in qtest emits some warnings with the
> the pnv machine types during the "nodefaults" phase:
>
> TEST check-qtest-ppc64: tests/qtest/device-introspect-test
> qemu-system-ppc64: warning: machine has no BMC devic
Michal Privoznik writes:
> On 6/15/20 10:02 AM, Markus Armbruster wrote:
>> Michal Privoznik writes:
>>
>>> To simplify internal implementation the hmat-cache parsing code
>>> expects hmat-lb to be already parsed. This means, that hmat-lb
>>> arguments must come before hmat-cache. Document this
David Gibson writes:
> On Thu, Jun 18, 2020 at 08:55:53AM +0200, Markus Armbruster wrote:
>> Either I'm confused (quite possible), or kvmppc_check_papr_resize_hpt()
>> can leak an Error object on failure. Please walk through the code with
>> me:
>>
>> kvmppc_check_papr_resize_hpt(&resiz
On 6/21/20 8:05 PM, Philippe Mathieu-Daudé wrote:
> On 6/21/20 2:47 PM, Alex Bennée wrote:
>>
>> Philippe Mathieu-Daudé writes:
>>
>>> On 6/21/20 1:29 AM, Philippe Mathieu-Daudé wrote:
As we just want the tests to succeed, build them with compiler
optimizations enabled to run the tests f
Zhanghailiang writes:
>> -Original Message-
>> From: Markus Armbruster [mailto:arm...@redhat.com]
>> Sent: Thursday, June 18, 2020 1:36 PM
>> To: Zhanghailiang
>> Cc: qemu-devel@nongnu.org; Michael Roth
>> Subject: Memory leak in transfer_memory_block()?
>>
>> We appear to leak an Erro
On 6/22/20 9:53 AM, Greg Kurz wrote:
> On Mon, 22 Jun 2020 09:13:46 +0200
> Cédric Le Goater wrote:
>
>> On 6/22/20 8:57 AM, Greg Kurz wrote:
>>> The device introspect test in qtest emits some warnings with the
>>> the pnv machine types during the "nodefaults" phase:
>>>
>>> TEST check-qtest-ppc6
On 6/22/20 9:09 AM, Cédric Le Goater wrote:
> On 6/19/20 8:02 PM, Philippe Mathieu-Daudé wrote:
>> Hi,
>>
>> On Tue, Apr 7, 2020 at 6:42 AM David Gibson
>> wrote:
>>>
>>> From: Cédric Le Goater
>>>
>>> Commit e2392d4395dd ("ppc/pnv: Create BMC devices at machine init")
>>> introduced default BMC
+Markus
On 6/21/20 12:58 AM, Philippe Mathieu-Daudé wrote:
> Extract i2c_try_create_slave() and i2c_realize_and_unref()
> from i2c_create_slave().
> We can now set properties on a I2CSlave before it is realized.
>
> This is in line with the recent qdev/QOM changes merged
> in commit 6675a653d2e.
Paolo Bonzini writes:
> On 18/06/20 07:32, Markus Armbruster wrote:
>> prh_co_entry() reports reports errors reading requests / writing
>> responses only when @verbose (command line -v); relevant code appended
>> for you convenience.
>>
>> Sure these are *errors*? The program recovers and conti
On 6/22/20 8:27 AM, Cédric Le Goater wrote:
> On 6/21/20 12:58 AM, Philippe Mathieu-Daudé wrote:
>> Add a description field to distinguish between multiple devices.
>
> Reviewed-by: Cédric Le Goater
>
> Could it be a QOM attribute ?
What do you call a 'QOM attribute'?
Is it what qdev propertie
This patch creates intermediate buffer for reading from block driver
state and performs read-ahead to this buffer. Snapshot code performs
reads sequentially and thus we know what offsets will be required
and when they will become not needed.
Results are fantastic. Switch to snapshot times of 2GB F
On 6/19/20 2:02 PM, no-re...@patchew.org wrote:
> Patchew URL: https://patchew.org/QEMU/20200619100708.30440-1-...@openvz.org/
>
>
>
> Hi,
>
> This series failed the asan build test. Please find the testing commands and
> their output below. If you have Docker installed, you can probably reproduce
+Markus
On 6/22/20 8:49 AM, Cédric Le Goater wrote:
> On 6/21/20 12:58 AM, Philippe Mathieu-Daudé wrote:
>> We have 2 distinct PCA9552 devices. Set their description
>> to distinguish them when looking at the trace events.
>
> It's nice and usefull but couldn't we do the same with a QOM object na
On 6/22/20 8:25 AM, Cédric Le Goater wrote:
> On 6/21/20 12:58 AM, Philippe Mathieu-Daudé wrote:
>> The current code models the PCA9552, but there are comments
>> saying the code could be easily adapted for the rest of the
>> PCA955x family.
>> Since we assume we have at most 16 pins (for the PCA95
On 6/22/20 2:21 AM, Andrew Jeffery wrote:
> On Wed, 17 Jun 2020, at 13:11, Philippe Mathieu-Daudé wrote:
>> Hi Andrew,
>>
>> On 6/17/20 3:18 AM, Andrew Jeffery wrote:
>>> On Tue, 16 Jun 2020, at 17:21, Philippe Mathieu-Daudé wrote:
The current implementation uses nano-second precision, while
>
On 22/06/2020 10.24, Philippe Mathieu-Daudé wrote:
> On 6/22/20 9:53 AM, Greg Kurz wrote:
>> On Mon, 22 Jun 2020 09:13:46 +0200
>> Cédric Le Goater wrote:
>>
>>> On 6/22/20 8:57 AM, Greg Kurz wrote:
The device introspect test in qtest emits some warnings with the
the pnv machine types du
On 6/18/20 7:47 AM, Markus Armbruster wrote:
> Philippe Mathieu-Daudé writes:
>
>> It is not obvious that the qemu_timedate_diff() and
>> qemu_ref_timedate() functions return seconds. Briefly
>> document it.
>>
>> Signed-off-by: Philippe Mathieu-Daudé
>> ---
>> include/qemu-common.h | 1 +
>> s
On 6/22/20 10:03 AM, Philippe Mathieu-Daudé wrote:
> Hi Pavel,
>
> On 5/29/20 9:05 AM, Pavel Dovgalyuk wrote:
>> This patch adds a test for record/replay, which boots Linux
>> image from the disk and interacts with the network.
>> The idea and code of this test is borrowed from boot_linux.py
>> Ho
Alex Bennée writes:
> This attempts to bring together my understanding of the requirements
> for icount behaviour into one reference document for our developer
> notes. It currently make one piece of conjecture which I think is true
> that we don't need gen_io_start/end statements for non-MMIO
The following changes since commit 06c4cc3660b366278bdc7bc8b6677032d7b1118c:
qht: Fix threshold rate calculation (2020-06-19 18:29:11 +0100)
are available in the Git repository at:
https://gitlab.com/philmd/qemu.git tags/acceptance-testing-20200622
for you to fetch changes up to
From: Pavel Dovgalyuk
This patch adds a base for testing kernel boot recording and replaying.
Each test has the phase of recording and phase of replaying.
Virtual machines just boot the kernel and do not interact with
the network.
Structure and image links for the tests are borrowed from boot_lin
Acceptance tests can test any piece of the QEMU codebase.
As such, the directory holding them does not belong to a specific
subsystem with designated maintainers.
Each subsystem covered by a test is welcomed to add the test path
to its section.
See for example commits 71b29
From: Pavel Dovgalyuk
This patch adds a test for record/replay of the kernel
image boot for two different arm platforms.
Signed-off-by: Pavel Dovgalyuk
Tested-by: Philippe Mathieu-Daude
Message-Id: <159073590785.20809.17654573764167037499.stgit@pasha-ThinkPad-X280>
Reviewed-by: Philippe Mathie
From: Pavel Dovgalyuk
This patch adds a test for record/replay of the kernel
image boot for aarch64 platform.
Signed-off-by: Pavel Dovgalyuk
Tested-by: Philippe Mathieu-Daude
Message-Id: <159073590231.20809.9842179251741585482.stgit@pasha-ThinkPad-X280>
Reviewed-by: Philippe Mathieu-Daudé
Sig
From: Pavel Dovgalyuk
This patch adds a test for record/replay an execution of x86_64 machine.
Execution scenario includes simple kernel boot, which allows testing
basic hardware interaction in RR mode.
Signed-off-by: Pavel Dovgalyuk
Tested-by: Philippe Mathieu-Daude
Message-Id: <159073589656.
From: Pavel Dovgalyuk
This patch adds a test for record/replay of the kernel
image boot for ppc64 platform.
Signed-off-by: Pavel Dovgalyuk
Tested-by: Philippe Mathieu-Daude
Message-Id: <159073591363.20809.15658672985367330140.stgit@pasha-ThinkPad-X280>
Reviewed-by: Philippe Mathieu-Daudé
Sign
From: Pavel Dovgalyuk
This patch adds a test for record/replay of the kernel
image boot for m68k platform.
Signed-off-by: Pavel Dovgalyuk
Tested-by: Philippe Mathieu-Daude
Reviewed-by: Laurent Vivier
Message-Id: <159073592033.20809.1838967871297177313.stgit@pasha-ThinkPad-X280>
Signed-off-by:
On Sun, Jun 21, 2020 at 02:06:25PM +1000, Geoffrey McRae wrote:
>
> > Can you stop the stream without closing the connection?
>
> Not as far as I can tell, it seems the JACK API doesn't allow for this in a
> way that is useful to us.
What happens if you don't feed data to jack? The cracking you
From: Pavel Dovgalyuk
This patch adds more record/replay tests with kernel images.
Signed-off-by: Pavel Dovgalyuk
Tested-by: Philippe Mathieu-Daude
Message-Id: <159073592589.20809.5156301499042635614.stgit@pasha-ThinkPad-X280>
Reviewed-by: Philippe Mathieu-Daudé
[PMD: Use os.path.join(), add
Emilio G. Cota writes:
> On Wed, Jun 10, 2020 at 16:55:06 +0100, Alex Bennée wrote:
>> Any write to a device might cause a re-arrangement of memory
>> triggering a TLB flush and potential re-size of the TLB invalidating
>> previous entries. This would cause users of qemu_plugin_get_hwaddr()
>>
On Sat, Jun 20, 2020 at 06:24:27PM +1000, David Gibson wrote:
> On Fri, Jun 19, 2020 at 04:05:56PM +0100, Daniel P. Berrangé wrote:
> > On Sat, Jun 20, 2020 at 12:45:41AM +1000, David Gibson wrote:
> > > On Fri, Jun 19, 2020 at 11:12:45AM +0100, Daniel P. Berrangé wrote:
> > > > On Fri, Jun 19, 202
Public bug reported:
As the 'none' machine doesn't have any peripheral (except CPU cores)
it is pointless to start a display.
'-M none' should imply '-display none'.
** Affects: qemu
Importance: Undecided
Status: New
--
You received this bug notification because you are a member
On 07/03/2020 10.48, Mark Cave-Ayland wrote:
> Hi all,
>
> After a recent rebase I've started seeing iotest 267 after running "make
> check" on
> qemu-system-sparc64. The diff output looks similar to this:
>
> --- /home/build/src/qemu/git/qemu/tests/qemu-iotests/267.out2020-01-22
> 17:57:54.
On 2020-06-22 19:05, Gerd Hoffmann wrote:
On Sun, Jun 21, 2020 at 02:06:25PM +1000, Geoffrey McRae wrote:
> Can you stop the stream without closing the connection?
Not as far as I can tell, it seems the JACK API doesn't allow for this
in a
way that is useful to us.
What happens if you do
FYI: The gtk ui has support for that. Try "-display gtk,grab-on-
hover=off". You can also toggle it in the "view" menu.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1884302
Title:
disable autom
On 19.06.20 18:47, Alberto Garcia wrote:
> On Fri 19 Jun 2020 12:40:11 PM CEST, Max Reitz wrote:
>> +if (qcow2_opts->data_file_raw &&
>> +qcow2_opts->preallocation == PREALLOC_MODE_OFF)
>> +{
>> +/*
>> + * data-file-raw means that "the external data file can be
>> +
On Fri, 19 Jun 2020 07:19:51 -0400
Stefan Berger wrote:
> On 6/19/20 5:43 AM, Auger Eric wrote:
> > Hi Laszlo,
> >
> > On 6/19/20 11:38 AM, Laszlo Ersek wrote:
> >> On 06/18/20 09:50, Auger Eric wrote:
> >>> Hi Stefan, Igor,
> >>>
> >>> On 6/16/20 4:11 PM, Stefan Berger wrote:
> On 6/1
There are three ways to configure backends:
* -nic, -serial, -drive, ... (onboard devices)
* Set the property with -device, or, if you feel masochistic, with
-set device (pluggable devices)
* Set the property with -global (both)
The trouble is -global is terrible.
It gets applied in object_n
Resynchronize the table of default device suppressions with vl.c's
default_list[].
Signed-off-by: Markus Armbruster
---
docs/qdev-device-use.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/qdev-device-use.txt b/docs/qdev-device-use.txt
index 3d781be547..4bbbcf561
Signed-off-by: Markus Armbruster
---
tests/qemu-iotests/172 | 12 +
tests/qemu-iotests/172.out | 50 ++
2 files changed, 62 insertions(+)
diff --git a/tests/qemu-iotests/172 b/tests/qemu-iotests/172
index 19c2516cf8..714c7527b4 100755
--- a/tests/q
We always pass &error_abort. Drop the parameter, use &error_abort
directly.
Cc: Cédric Le Goater
Cc: Peter Maydell
Cc: Andrew Jeffery
Cc: Joel Stanley
Cc: qemu-...@nongnu.org
Signed-off-by: Markus Armbruster
Reviewed-by: Cédric Le Goater
Reviewed-by: Philippe Mathieu-Daudé
---
hw/arm/aspe
Helper function fdctrl_init_isa() is less than helpful: one of three
places creating "isa-fdc" devices use it. Open-code it there, and
drop the function.
Signed-off-by: Markus Armbruster
Reviewed-by: Philippe Mathieu-Daudé
---
include/hw/block/fdc.h | 1 -
hw/block/fdc.c | 14
Drives with interface types other than if=none are for onboard
devices. Unfortunately, any such drives the board doesn't pick up can
still be used with -device, like this:
$ qemu-system-x86_64 -nodefaults -display none -S -drive
if=floppy,id=bogus,unit=7 -device ide-cd,drive=bogus -monitor s
The Error ** argument must be NULL, &error_abort, &error_fatal, or a
pointer to a variable containing NULL. Passing an argument of the
latter kind twice without clearing it in between is wrong: if the
first call sets an error, it no longer points to NULL for the second
call.
milkymist_memcard_rea
The additional output demonstrates we screw up when -global isa-fdc
clashes with -drive if=floppy or its sugared forms: according to "info
qtree", only the latter backend is attached, but according to "info
block", both are. For instance:
Testing: -fda TEST_DIR/t.qcow2 -drive if=none,file=TES
Use of -global to set a default backend for non-singleton devices is a
bad idea. But as long as we permit it, we better test it.
Test output demonstrates we screw up when -global floppy clashes with
-fda or with -device floppy: according to "info qtree", only the
latter backend is attached, but a
qdev_prop_set_netdev() fails when the property already has a non-null
value. Seems to go back to commit 30c367ed44
"qdev-properties-system.c: Allow vlan or netdev for -device, not
both", v1.7.0. Board code doesn't expect failure, and crashes:
$ qemu-system-x86_64 --nodefaults -nic user -netd
qdev_prop_set_drive() screws up when the property already has a
non-null value: it neglects to release the old value. Both the old
and the new backend become attached to the same device.
Example (taken from iotest 172): -fda ... -drive if=none,... -global
floppy.drive=none0.
Special case: attemp
On 22.06.20 11:35, Max Reitz wrote:
> On 19.06.20 18:47, Alberto Garcia wrote:
>> On Fri 19 Jun 2020 12:40:11 PM CEST, Max Reitz wrote:
>>> +if (qcow2_opts->data_file_raw &&
>>> +qcow2_opts->preallocation == PREALLOC_MODE_OFF)
>>> +{
>>> +/*
>>> + * data-file-raw mea
We stopped using get_pointer() and set_pointer() for netdev in commit
23120b13c6 "net: don't use set/get_pointer() in set/get_netdev()"
(v2.3.0), and for chardev in commit becdfa00cf "char: replace PROP_CHR
with CharBackend" (v2.8.0). With only the drive user left, they're
not helpful anymore. El
qdev_prop_set_chr() screws up when the property already has a non-null
value: it neglects to release the old value. Both the old and the new
backend become attached to the same device. Unlike for block devices
(see previous commit), this can't be observed from the monitor (I
think).
Example: -se
Deprecate
-global isa-fdc.driveA=...
-global isa-fdc.driveB=...
in favour of
-device floppy,unit=0,drive=...
-device floppy,unit=1,drive=...
Same for the other floppy controller devices.
Signed-off-by: Markus Armbruster
Acked-by: John Snow
---
docs/qdev-device-use.txt | 13
On 22.06.20 00:25, Nir Soffer wrote:
> On Fri, Jun 19, 2020 at 1:40 PM Max Reitz wrote:
>>
>> Hi,
>>
>> As discussed here:
>>
>> https://lists.nongnu.org/archive/html/qemu-block/2020-02/msg00644.html
>> https://lists.nongnu.org/archive/html/qemu-block/2020-04/msg00329.html
>> https://lists.nongnu.
The floppy controller devices desugar their drive properties into
floppy devices (since commit a92bd191a4 "fdc: Move qdev properties to
FloppyDrive", v2.8.0). This involves some bad magic in
fdctrl_connect_drives(), and exists for backward compatibility.
The functions for boards to create floppy
Hi Igor,
On 6/22/20 11:39 AM, Igor Mammedov wrote:
> On Fri, 19 Jun 2020 07:19:51 -0400
> Stefan Berger wrote:
>
>> On 6/19/20 5:43 AM, Auger Eric wrote:
>>> Hi Laszlo,
>>>
>>> On 6/19/20 11:38 AM, Laszlo Ersek wrote:
On 06/18/20 09:50, Auger Eric wrote:
> Hi Stefan, Igor,
>
>>>
qdev_prop_set_drive() can fail. None of the other qdev_prop_set_FOO()
can; they abort on error.
To clean up this inconsistency, rename qdev_prop_set_drive() to
qdev_prop_set_drive_err(), and create a qdev_prop_set_drive() that
aborts on error.
Coccinelle script to update callers:
@ depends
On error, pxa2xx_mmci_init() reports to stderr and returns NULL.
Callers don't check for errors. Machines akita, borzoi, mainstone,
spitz, terrier, tosa, and z2 crash shortly after, like this:
$ qemu-system-aarch64 -M akita -drive if=sd,readonly=on
qemu-system-aarch64: failed to init SD c
On 6/22/20 9:01 AM, Cédric Le Goater wrote:
> On 6/21/20 12:58 AM, Philippe Mathieu-Daudé wrote:
>> Emit a trace event when a GPIO change its state.
>
> I understand now why you need 'pin_status'.
>
> We could compute 'pin_status' and 'pin_changed' in routine
> pca9552_update_pin_input() when u
On 6/22/20 11:42 AM, Markus Armbruster wrote:
> The Error ** argument must be NULL, &error_abort, &error_fatal, or a
> pointer to a variable containing NULL. Passing an argument of the
> latter kind twice without clearing it in between is wrong: if the
> first call sets an error, it no longer poin
On 22/06/2020 09.42, Janosch Frank wrote:
> Let's consolidate timing related functions into one header.
>
> Signed-off-by: Janosch Frank
> ---
> pc-bios/s390-ccw/menu.c| 1 +
> pc-bios/s390-ccw/netmain.c | 15 +++
> pc-bios/s390-ccw/s390-ccw.h| 8
> pc-bios
On 22/06/2020 12.02, Thomas Huth wrote:
> On 22/06/2020 09.42, Janosch Frank wrote:
>> Let's consolidate timing related functions into one header.
>>
>> Signed-off-by: Janosch Frank
>> ---
>> pc-bios/s390-ccw/menu.c| 1 +
>> pc-bios/s390-ccw/netmain.c | 15 +++
>> pc-bios
On 22/06/2020 09.42, Janosch Frank wrote:
> They are definitely helper functions.
>
> Signed-off-by: Janosch Frank
> Reviewed-by: Christian Borntraeger
> ---
> pc-bios/s390-ccw/helper.h | 17 +
> pc-bios/s390-ccw/s390-ccw.h| 18 --
> pc-bios/s390-ccw/vir
On 6/19/20 11:54 PM, Richard Henderson wrote:
On 6/16/20 1:34 AM, Michal Privoznik wrote:
+#ifndef G_OS_WIN32
Nit: positive tests are easier to reason with and extend than negative tests.
I would reverse these two blocks and use a positive test for windows.
Also, CONFIG_WIN32 is what we use e
Patchew URL:
https://patchew.org/QEMU/20200622094227.1271650-1-arm...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PATCH v2 00/16] Crazy shit around -global (pardon my french)
Type: series
Message-id: 20200622094227.127
> -Original Message-
> From: Qemu-riscv bounces+anup.patel=wdc@nongnu.org> On Behalf Of Bin Meng
> Sent: 22 June 2020 12:03
> To: Alistair Francis ; Bastian Koppelmann
> ; Palmer Dabbelt
> ; Sagar Karandikar
> ; qemu-devel@nongnu.org; qemu-
> ri...@nongnu.org
> Cc: Anup Patel ; Bin
Your pipeline has failed.
Project: QEMU ( https://gitlab.com/qemu-project/qemu )
Branch: master ( https://gitlab.com/qemu-project/qemu/-/commits/master )
Commit: 06c4cc36 (
https://gitlab.com/qemu-project/qemu/-/commit/06c4cc3660b366278bdc7bc8b6677032d7b1118c
)
Commit Message: qht: Fix thresh
Hi Michal,
On 6/16/20 10:34 AM, Michal Privoznik wrote:
> Problem with g_get_host_name() is that on the first call it saves
> the hostname into a global variable and from then on, every
> subsequent call returns the saved hostname. Even if the hostname
> changes. This doesn't play nicely with gues
Am 20.06.2020 um 10:20 hat Philippe Mathieu-Daudé geschrieben:
> On Sat, Jun 20, 2020 at 10:14 AM Philippe Mathieu-Daudé
> wrote:
> >
> > On 6/4/20 10:22 PM, John Snow wrote:
> > > Like many other Optional[] types, it's not always a given that this
> > > object will be set. Wrap it in a type-shi
On Mon, 22 Jun 2020 at 06:36, Max Filippov wrote:
>
> Since commit
> ba3e7926691e ("icount: clean up cpu_can_io at the entry to the block")
> it has been unnecessary for target code to call gen_io_end() after an IO
> instruction in icount mode; it is sufficient to call gen_io_start()
> before it a
On Wed, Jun 17, 2020 at 06:30:16PM +0800, Lin Ma wrote:
> The get lba status wrapper based on the bdrv_block_status. The following
> patches will add GET LBA STATUS 16 support for scsi emulation layer.
>
> Signed-off-by: Lin Ma
> ---
> block/io.c| 43 +
On Thu, 18 Jun 2020 18:22:51 -0400
Collin Walling wrote:
> Functions within read scp/cpu info will need access to the machine
> state. Let's make a call to retrieve the machine state once and
> pass the appropriate data to the respective functions.
>
> Signed-off-by: Collin Walling
> Reviewed-b
Greetings,
Welcome to the TCG Continuous Benchmarking GSoC project!
This is the first report in a series that will be posted here on the
mailing list as part of the project.
During the project, multiple Linux profiling tools will be used.
These tools will help you profile your different QEMU exec
On Thu, 18 Jun 2020 18:22:52 -0400
Collin Walling wrote:
> The SCCB must be checked for a sufficient length before it is filled
> with any data. If the length is insufficient, then the SCLP command
> is suppressed and the proper response code is set in the SCCB header.
>
> Fixes: 832be0d8a3bb ("
This series addresses a number of error handling issues I found while
working on error handling improvements. It's based on my "[PATCH v2
00/16] Crazy shit around -global (pardon my french)".
Based-on: <20200622094227.1271650-1-arm...@redhat.com>
Markus Armbruster (22):
net/virtio: Fix failove
Receiving the error in a local variable only to assert there is none
is less clear than passing &error_abort. Clean up.
Signed-off-by: Markus Armbruster
---
tests/check-qobject.c | 5 +-
tests/test-logging.c | 12 +---
tests/test-qemu-opts.c | 22 ++---
milkymist_memcard_realize() leaks an Error object when realization of
its "sd-card" device fails. Quite harmless, since we only ever
realize this once, in milkymist_init() via milkymist_memcard_create().
Plug the leak.
Fixes: 3d0369ba499866cc6a839f71212d97876500762d
Cc: Philippe Mathieu-Daudé
C
1 - 100 of 427 matches
Mail list logo
