Re: [PATCH 0/6] audio/jack: fixes to overall jack behaviour

2020-06-12 Thread Gerd Hoffmann
On Fri, Jun 12, 2020 at 10:12:37AM +1000, Geoffrey McRae wrote: > Sorry for the spam, resubmitted due to missing subject on this cover > letter. Seems patchew.org can't find the associated patches without it. Alot of tools (patchew probably included) depend on "git send-email --thread" which sends

Re: [PATCH 1/1] util/getauxval: Porting to FreeBSD getauxval feature

2020-06-12 Thread Laurent Vivier
Le 11/06/2020 à 23:10, David CARLIER a écrit : > Hi, please don't put your patch in attachements, you can use "git send-email" if your emailer doesn't allow it. https://wiki.qemu.org/Contribute/SubmitAPatch#Do_not_send_as_an_attachment I think your patch is not correct, you put a "#if defined(_

Re: [PATCH 0/6] audio/jack: fixes to overall jack behaviour

2020-06-12 Thread Geoffrey McRae
Thanks, still learning how best to submit these things :) Is it worth re-sending this again as per the below? On 2020-06-12 17:11, Gerd Hoffmann wrote: On Fri, Jun 12, 2020 at 10:12:37AM +1000, Geoffrey McRae wrote: Sorry for the spam, resubmitted due to missing subject on this cover letter. Se

[Bug 1840719] Re: win98se floppy fails to boot with isapc machine

2020-06-12 Thread Roman Bolshakov
** Changed in: qemu Status: New => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1840719 Title: win98se floppy fails to boot with isapc machine Status in QEMU: Confirmed Bug de

Re: [PATCH 1/2] softfloat: m68k: infinity is a valid encoding

2020-06-12 Thread Laurent Vivier
Le 28/04/2020 à 19:17, KONRAD Frederic a écrit : > The MC68881 say about infinities (3.2.4): > > "*For the extended precision format, the most significant bit of the > mantissa (the integer bit) is a don't care." > > https://www.nxp.com/docs/en/reference-manual/MC68881UM.pdf > > The m68k extende

Re: [PATCH 1/1] util/getauxval: Porting to FreeBSD getauxval feature

2020-06-12 Thread David CARLIER
>From d7f9d40777d1ed7c9450b0be4f957da2993dfc72 Mon Sep 17 00:00:00 2001 From: David Carlier Date: Fri, 12 Jun 2020 09:39:17 +0100 Subject: [PATCH] util/getauxval: Porting to FreeBSD getauxval feature FreeBSD has a similar API for auxiliary vector. Signed-off-by: David Carlier --- util/getauxva

[PATCH v3 02/12] backends: Add TPM files into their own directory

2020-06-12 Thread Philippe Mathieu-Daudé
As we will have various TPM backend files, it is cleaner to use a single directory. Suggested-by: Stefan Berger Reviewed-by: Stefan Berger Signed-off-by: Philippe Mathieu-Daudé --- backends/{tpm.c => tpm/tpm_backend.c} | 0 MAINTAINERS | 2 +- backends/Makefile.objs

[PATCH v3 01/12] docs/specs/tpm: Correct header path name

2020-06-12 Thread Philippe Mathieu-Daudé
Commit 8dc6701722 introduce the documentation but an incorrect path name was used. Fix that. Reviewed-by: Stefan Berger Signed-off-by: Philippe Mathieu-Daudé --- docs/specs/tpm.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/specs/tpm.rst b/docs/specs/tpm.rst index

[PATCH v3 00/12] tpm: Split hw/ vs backends/

2020-06-12 Thread Philippe Mathieu-Daudé
Missing review: last patch - #12 "tpm: Move backend code under the 'backends/' directory" Hi, Yesterday I started to review some vTPM patches and got very confused by the files under hw/tpm/. In particular after running: $ git grep TYPE_TPM_BACKEND backends/tpm.c:188:.name = TYPE_TPM_BAC

[PATCH v3 04/12] hw/tpm: Do not include 'qemu/osdep.h' in header

2020-06-12 Thread Philippe Mathieu-Daudé
>From CODING_STYLE.rst: Do not include "qemu/osdep.h" from header files since the .c file will have already included it. Remove "qemu/osdep.h" from "tpm_tis.h". Reviewed-by: Stefan Berger Signed-off-by: Philippe Mathieu-Daudé --- hw/tpm/tpm_tis.h | 1 - 1 file changed, 1 deletion(-) diff

[PATCH v3 05/12] hw/tpm: Include missing 'qemu/option.h' header

2020-06-12 Thread Philippe Mathieu-Daudé
Files using the TPM_STANDARD_CMDLINE_OPTS macro declared in "tpm_int.h" will use QEMU_OPT_STRING definition declared in "qemu/option.h". Reviewed-by: Stefan Berger Signed-off-by: Philippe Mathieu-Daudé --- hw/tpm/tpm_int.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/tpm/tpm_int.h b

[PATCH v3 03/12] hw/tpm: Rename TPMDEV as TPM_BACKEND in Kconfig

2020-06-12 Thread Philippe Mathieu-Daudé
The TPMDEV describe TPM backends. Use the TPM_BACKEND config name which is self-explicit. Reviewed-by: Stefan Berger Signed-off-by: Philippe Mathieu-Daudé --- hw/tpm/Kconfig | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/tpm/Kconfig b/hw/tpm/Kconfig index 47

[PATCH v3 08/12] hw/tpm: Make TRACE_TPM_UTIL_SHOW_BUFFER check local to tpm_util.c

2020-06-12 Thread Philippe Mathieu-Daudé
The trace_event_get_state_backends() call is useful to avoid making extensive calls (usually preparing arguments passed to the tracing framework. In this case, the extensive work is done in tpm_util_show_buffer(), and the arguments used to call it don't involve extra processing. Simplify by moving

[PATCH v3 06/12] hw/tpm: Move 'hw/acpi/tpm.h' inclusion from header to sources

2020-06-12 Thread Philippe Mathieu-Daudé
Nothing in "tpm_ppi.h" require declarations from "hw/acpi/tpm.h". Reduce dependencies and include it only in the files requiring it. Reviewed-by: Stefan Berger Signed-off-by: Philippe Mathieu-Daudé --- hw/tpm/tpm_ppi.h| 1 - hw/tpm/tpm_ppi.c| 1 + hw/tpm/tpm_tis_isa.c| 1 +

[PATCH v3 07/12] hw/tpm: Remove unnecessary 'tpm_int.h' header inclusion

2020-06-12 Thread Philippe Mathieu-Daudé
Remove unnecessary 'tpm_int.h' header inclusion. Reviewed-by: Stefan Berger Signed-off-by: Philippe Mathieu-Daudé --- hw/tpm/tpm_crb.c| 1 - hw/tpm/tpm_spapr.c | 1 - hw/tpm/tpm_tis_common.c | 1 - 3 files changed, 3 deletions(-) diff --git a/hw/tpm/tpm_crb.c b/hw/tpm/tpm_crb.c in

[PATCH v3 09/12] hw/tpm: Move few declarations from 'tpm_util.h' to 'tpm_int.h'

2020-06-12 Thread Philippe Mathieu-Daudé
We are going to make "tpm_util.h" publicly accessible by moving it to the include/ directory in a pair of commits. Keep declarations internals to hw/tpm/ in "tpm_int.h". Reviewed-by: Stefan Berger Signed-off-by: Philippe Mathieu-Daudé --- hw/tpm/tpm_int.h | 11 +++ hw/tpm/tpm_util.h |

[Bug 1856335] Re: Cache Layout wrong on many Zen Arch CPUs

2020-06-12 Thread Jan Klos
The problem is caused by the fact that with Ryzen CPUs with disabled cores, the APIC IDs are not sequential on host - in order for cache topology to be configured properly, there is a 'hole' in APIC ID and core ID numbering (I have added full output of cpuid for my 3900X). Unfortunately, adding hol

[PATCH v3 10/12] hw/tpm: Move DEFINE_PROP_TPMBE() macro to 'tmp_prop.h' local header

2020-06-12 Thread Philippe Mathieu-Daudé
We are going to make "tpm_util.h" publicly accessible by moving it to the include/ directory in the next commit. The DEFINE_PROP_TPMBE() macro is only meaningful for the TPM hardware files (in hw/tpm/), so keep this macro in a local header. Reviewed-by: Stefan Berger Signed-off-by: Philippe Mathi

[PATCH v3 11/12] hw/tpm: Make 'tpm_util.h' publicly accessible as "sysemu/tpm_util.h"

2020-06-12 Thread Philippe Mathieu-Daudé
We are going to split the TPM backends from the TPM emulated hardware in the next commit. Make the TPM util helpers accessible by moving local "tpm_util.h" to global "sysemu/tpm_util.h". Reviewed-by: Stefan Berger Signed-off-by: Philippe Mathieu-Daudé --- docs/specs/tpm.rst|

[PATCH v3 12/12] tpm: Move backend code under the 'backends/' directory

2020-06-12 Thread Philippe Mathieu-Daudé
TPM subsytem is split into backends (see commit f4ede81eed2) and frontends (see i.e. 3676bc69b35). Keep the emulated hardware 'frontends' under hw/tpm/, but move the backends in the backends/tpm/ directory. Suggested-by: Marc-André Lureau Signed-off-by: Philippe Mathieu-Daudé --- docs/specs/tpm

Re: [PATCH 1/1] util/getauxval: Porting to FreeBSD getauxval feature

2020-06-12 Thread Laurent Vivier
Le 12/06/2020 à 10:46, David CARLIER a écrit : > From d7f9d40777d1ed7c9450b0be4f957da2993dfc72 Mon Sep 17 00:00:00 2001 > From: David Carlier > Date: Fri, 12 Jun 2020 09:39:17 +0100 > Subject: [PATCH] util/getauxval: Porting to FreeBSD getauxval feature > > FreeBSD has a similar API for auxiliary

Re: [PATCH] kvm: support to get/set dirty log initial-all-set capability

2020-06-12 Thread Paolo Bonzini
On 12/06/20 05:01, Zhoujian (jay) wrote: > > >> -Original Message- >> From: Paolo Bonzini [mailto:pbonz...@redhat.com] >> Sent: Wednesday, March 18, 2020 6:48 PM >> To: Zhoujian (jay) ; qemu-devel@nongnu.org; >> k...@vger.kernel.org >> Cc: m...@redhat.com; coh...@redhat.com; pet...@redhat

[Bug 1840719] Re: win98se floppy fails to boot with isapc machine

2020-06-12 Thread Laurent Vivier
** Project changed: qemu => seabios -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1840719 Title: win98se floppy fails to boot with isapc machine Status in Seabios: Confirmed Bug description:

RE: [PATCH] kvm: support to get/set dirty log initial-all-set capability

2020-06-12 Thread Zhoujian (jay)
> -Original Message- > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Friday, June 12, 2020 5:28 PM > To: Zhoujian (jay) ; qemu-devel@nongnu.org; > k...@vger.kernel.org > Cc: m...@redhat.com; coh...@redhat.com; pet...@redhat.com; Wangxin > (Alexander, Cloud Infrastructure Servic

Re: [PATCH 1/1] util/getauxval: Porting to FreeBSD getauxval feature

2020-06-12 Thread Paolo Bonzini
On 12/06/20 10:46, David CARLIER wrote: > From d7f9d40777d1ed7c9450b0be4f957da2993dfc72 Mon Sep 17 00:00:00 2001 > From: David Carlier > Date: Fri, 12 Jun 2020 09:39:17 +0100 > Subject: [PATCH] util/getauxval: Porting to FreeBSD getauxval feature > > FreeBSD has a similar API for auxiliary vector

Re: [PATCH 0/6] audio/jack: fixes to overall jack behaviour

2020-06-12 Thread Gerd Hoffmann
On Fri, Jun 12, 2020 at 06:05:48PM +1000, Geoffrey McRae wrote: > Thanks, still learning how best to submit these things :) > Is it worth re-sending this again as per the below? Most commit messages are rather brief (just the subject line). For really simple changes ("remove unused state") this i

Re: [PATCH v3 1/4] spapr: Simplify some warning printing paths in spapr_caps.c

2020-06-12 Thread David Gibson
On Thu, Jun 11, 2020 at 03:40:11PM +0200, Greg Kurz wrote: > We obviously only want to print a warning in these cases, but this is done > in a rather convoluted manner. Just use warn_report() instead. > > Signed-off-by: Greg Kurz Applied to ppc-for-5.1, thanks. > --- > hw/ppc/spapr_caps.c |

Re: [PULL 0/2] VFIO update 2020-06-11

2020-06-12 Thread Peter Maydell
On Thu, 11 Jun 2020 at 20:06, Alex Williamson wrote: > > The following changes since commit 3666f684761a3cccd86d13c752273be207ecade4: > > Merge remote-tracking branch 'remotes/ericb/tags/pull-bitmaps-2020-06-09' > into staging (2020-06-11 15:35:44 +0100) > > are available in the Git repository

[PATCH] .gitignore: Ignore storage-daemon files

2020-06-12 Thread Roman Bolshakov
The files are generated. Fixes: 2af282ec51a ("qemu-storage-daemon: Add --monitor option") Cc: Kevin Wolf Signed-off-by: Roman Bolshakov --- .gitignore | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/.gitignore b/.gitignore index 0c5af83aa7..90acb4347d 10064

[Bug 1882851] [PATCH] drm/virtio: fix unblank

2020-06-12 Thread Gerd Hoffmann
When going through a disable/enable cycle without changing the framebuffer the optimization added by commit 3954ff10e06e causes the screen stay blank. Add a bool to force an update to fix that. Cc: 1882...@bugs.launchpad.net Fixes: 3954ff10e06e ("drm/virtio: skip set_scanout if framebuffer didn't

Re: [PATCH v3 08/12] hw/tpm: Make TRACE_TPM_UTIL_SHOW_BUFFER check local to tpm_util.c

2020-06-12 Thread Stefan Berger
On 6/12/20 4:54 AM, Philippe Mathieu-Daudé wrote: The trace_event_get_state_backends() call is useful to avoid making extensive calls (usually preparing arguments passed to the tracing framework. In this case, the extensive work is done in tpm_util_show_buffer(), and the arguments used to call it

Re: [PULL 000/115] Huge miscellaneous pull request for 2020-06-11

2020-06-12 Thread Peter Maydell
On Thu, 11 Jun 2020 at 21:19, Paolo Bonzini wrote: > > The following changes since commit 31d321c2b3574dcc74e9f6411af06bca6b5d10f4: > > Merge remote-tracking branch > 'remotes/philmd-gitlab/tags/sparc-next-20200609' into staging (2020-06-09 > 17:29:47 +0100) > > are available in the Git reposi

Re: [PATCH 0/4] More sm501 fixes and optimisations

2020-06-12 Thread BALATON Zoltan
On Sat, 6 Jun 2020, BALATON Zoltan wrote: Some small fixes and optimisations for hw/display/sm501.c. Ping? Regards, BALATON Zoltan BALATON Zoltan (4): sm501: Fix bounds checks sm501: Drop unneded variable sm501: Ignore no-op blits sm501: Optimise 1 pixel 2d ops hw/display/sm501.c | 58 +

Re: [PATCH] .gitignore: Ignore storage-daemon files

2020-06-12 Thread Philippe Mathieu-Daudé
+Markus (qapi) On 6/12/20 12:58 PM, Roman Bolshakov wrote: > The files are generated. > > Fixes: 2af282ec51a ("qemu-storage-daemon: Add --monitor option") > Cc: Kevin Wolf > Signed-off-by: Roman Bolshakov > --- > .gitignore | 17 + > 1 file changed, 9 insertions(+), 8 deletions

Re: [PULL 000/115] Huge miscellaneous pull request for 2020-06-11

2020-06-12 Thread Paolo Bonzini
On 12/06/20 15:09, Peter Maydell wrote: > Hi; I'm afraid this fails to build on OSX, and has a check-tcg > failure on x86-64 Linux. > > OSX: > > In file included from > /Users/pm215/src/qemu-for-merges/target/i386/hvf/hvf.c:53: > In file included from > /Users/pm215/src/qemu-for-merges/include/

Re: [PATCH v2 01/12] npcm7xx: Add config symbol

2020-06-12 Thread Philippe Mathieu-Daudé
Hi Havard On 6/12/20 12:30 AM, Havard Skinnemoen wrote: > Add a config symbol for the NPCM7xx BMC SoC family that subsequent > patches can use in Makefiles. > > Change-Id: I6e4d5c58716cb6fe4ea5d06f148beeafda55f9a5 What it this Change-Id tag used for? > Reviewed-by: Tyrone Ting > Acked-by: Joel

RE: [PATCH] hw/nios2: Update interrupt request when CR_STATUS_PIE disabled

2020-06-12 Thread Wu, Wentong
Hi, Can any body help review this patch ? Thanks in advance! BR -Original Message- From: Wu, Wentong Sent: Thursday, June 11, 2020 4:13 PM To: qemu-devel@nongnu.org Cc: qemu-triv...@nongnu.org; crwu...@gmail.com; ma...@denx.de; th...@redhat.com; Wu, Wentong Subject: [PATCH] hw/nios2:

Re: [PULL 000/115] Huge miscellaneous pull request for 2020-06-11

2020-06-12 Thread Roman Bolshakov
On Fri, Jun 12, 2020 at 03:33:38PM +0200, Paolo Bonzini wrote: > On 12/06/20 15:09, Peter Maydell wrote: > > Hi; I'm afraid this fails to build on OSX, and has a check-tcg > > failure on x86-64 Linux. > > > > OSX: > > > > In file included from > > /Users/pm215/src/qemu-for-merges/target/i386/hvf

[PATCH v2] target/i386: correct fix for pcmpxstrx substring search

2020-06-12 Thread Joseph Myers
This corrects a bug introduced in my previous fix for SSE4.2 pcmpestri / pcmpestrm / pcmpistri / pcmpistrm substring search, commit ae35eea7e4a9f21dd147406dfbcd0c4c6aaf2a60. That commit fixed a bug that showed up in four GCC tests with one libc implementation. The tests in question generate rando

Re: [PATCH v3 1/2] PCI: vmd: Filter resource type bits from shadow register

2020-06-12 Thread Lorenzo Pieralisi
On Thu, Jun 11, 2020 at 09:16:48PM +, Derrick, Jonathan wrote: [...] > > > > Hi Jon, > > > > > > > > it looks like I can take this patch for v5.8 whereas patch 2 depends > > > > on the QEMU changes acceptance and should probably wait. > > > > > > > > Please let me know your thoughts asap an

[PATCH] softfloat,m68k: disable floatx80_invalid_encoding() for m68k

2020-06-12 Thread Laurent Vivier
According to the comment, this definition of invalid encoding is given by intel developer's manual, and doesn't comply with 680x0 FPU. With m68k, the explicit integer bit can be zero in the case of: - zeros(exp == 0, mantissa == 0) - denormalized numbers (exp == 0, mantissa != 0)

[Bug 1883268] Re: random errors on aarch64 when executing __aarch64_cas8_acq_rel

2020-06-12 Thread Christophe Lyon
** Attachment added: "Binary" https://bugs.launchpad.net/qemu/+bug/1883268/+attachment/5383273/+files/sync-4.exe -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1883268 Title: random errors on aa

[Bug 1883268] [NEW] random errors on aarch64 when executing __aarch64_cas8_acq_rel

2020-06-12 Thread Christophe Lyon
Public bug reported: Hello, Since I upgraded to qemu-5.0 when executing the GCC testsuite, I've noticed random failures of g++.dg/ext/sync-4.C. I'm attaching the source of the testcase, the binary executable and the qemu traces (huge, 111MB!) starting at main (with qemu-aarch64 -cpu cortex-a57 -

[Bug 1883268] Re: random errors on aarch64 when executing __aarch64_cas8_acq_rel

2020-06-12 Thread Christophe Lyon
** Attachment added: "QEMU traces" https://bugs.launchpad.net/qemu/+bug/1883268/+attachment/5383274/+files/sync-4.qemu.log.xz -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1883268 Title: random

[PULL v2 07/58] acpi: rtc: use a single crs range

2020-06-12 Thread Michael S. Tsirkin
From: Gerd Hoffmann Use a single io range for _CRS instead of two, following what real hardware does. Signed-off-by: Gerd Hoffmann Reviewed-by: Igor Mammedov Message-Id: <20200515150421.25479-4-kra...@redhat.com> --- hw/rtc/mc146818rtc.c | 8 +--- 1 file changed, 5 insertions(+), 3 deleti

[PULL v2 03/58] hw/acpi/nvdimm: add a helper to augment SRAT generation

2020-06-12 Thread Michael S. Tsirkin
From: Vishal Verma NVDIMMs can belong to their own proximity domains, as described by the NFIT. In such cases, the SRAT needs to have Memory Affinity structures in the SRAT for these NVDIMMs, otherwise Linux doesn't populate node data structures properly during NUMA initialization. See the follow

[PULL v2 00/58] virtio,acpi,pci: features, fixes, cleanups, tests

2020-06-12 Thread Michael S. Tsirkin
changes from v1: - printf format fixed for 32 bit hosts - a couple of bugfixes added The following changes since commit 49ee11555262a256afec592dfed7c5902d5eefd2: Merge remote-tracking branch 'remotes/vivier2/tags/linux-user-for-5.1-pull-request' into staging (2020-06-08 11:04:57 +0100) are a

[PULL v2 06/58] acpi: move aml builder code for rtc device

2020-06-12 Thread Michael S. Tsirkin
From: Gerd Hoffmann Signed-off-by: Gerd Hoffmann Reviewed-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20200515150421.25479-3-kra...@redhat.com> --- hw/i386/acpi-build.c | 17 - hw/rtc/mc146818rtc.c | 22 ++ 2 files changed, 22 inserti

[PULL v2 01/58] msix: allow qword MSI-X table accesses

2020-06-12 Thread Michael S. Tsirkin
PCI spec says: For all accesses to MSI-X Table and MSI-X PBA fields, software must use aligned full DWORD or aligned full QWORD transactions; otherwise, the result is undefined. However, since MSI-X was converted to use memory API, QEMU started blocking qword transactions, only allowing DWORD one

[PULL v2 09/58] acpi: move aml builder code for serial device

2020-06-12 Thread Michael S. Tsirkin
From: Gerd Hoffmann The code uses the isa_serial_io array to figure what the device uid is. Side effect is that acpi antries are not limited to port 1+2 any more, we'll also get entries for ports 3+4. Signed-off-by: Gerd Hoffmann Reviewed-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé

[PULL v2 08/58] acpi: serial: don't use _STA method

2020-06-12 Thread Michael S. Tsirkin
From: Gerd Hoffmann The _STA method dates back to the days where we had a static DSDT. The device is listed in the DSDT table unconditionally and the _STA method checks a bit in the isa bridge pci config space to figure whenever a given is isa device is present or not, then evaluates to 0x0f (pr

[PULL v2 13/58] acpi: tpm: Do not build TCPA table for TPM 2

2020-06-12 Thread Michael S. Tsirkin
From: Stefan Berger Do not build a TCPA table for TPM 2 anymore but create the log area when building the TPM2 table. The TCPA table is only needed for TPM 1.2. Signed-off-by: Stefan Berger Reviewed-by: Marc-André Lureau Reviewed-by: Eric Auger Reviewed-by: Igor Mammedov Signed-off-by: Micha

[PULL v2 22/58] virtio-balloon: fix free page hinting without an iothread

2020-06-12 Thread Michael S. Tsirkin
From: David Hildenbrand In case we don't have an iothread, we mark the feature as abscent but still add the queue. 'free_page_bh' remains set to NULL. qemu-system-i386 \ -M microvm \ -nographic \ -device virtio-balloon-device,free-page-hint=true \ -nographic \

[PULL v2 10/58] acpi: parallel: don't use _STA method

2020-06-12 Thread Michael S. Tsirkin
From: Gerd Hoffmann The _STA method dates back to the days where we had a static DSDT. The device is listed in the DSDT table unconditionally and the _STA method checks a bit in the isa bridge pci config space to figure whenever a given is isa device is present or not, then evaluates to 0x0f (pr

[PULL v2 16/58] arm/acpi: TPM2 ACPI table support

2020-06-12 Thread Michael S. Tsirkin
From: Eric Auger Add a TPM2 ACPI table if a TPM2.0 sysbus device has been dynamically instantiated. Signed-off-by: Eric Auger Message-Id: <20200601095737.32671-4-eric.au...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/sysemu/tpm.h | 2 ++ hw/

[PULL v2 19/58] tests: tpm-emu: Remove assert on TPM2_ST_NO_SESSIONS

2020-06-12 Thread Michael S. Tsirkin
From: Eric Auger bios-tables-test executes SeaBIOS. Indeed FW is needed to fetch tables from QEMU and put them into the guest RAM. Also the FW patches cross table pointers. At some point, SeaBIOS ends up calling the TPM2_CC_HierarchyControl command with TPM2_ST_SESSIONS tag, most probably steming

[PULL v2 11/58] acpi: move aml builder code for parallel device

2020-06-12 Thread Michael S. Tsirkin
From: Gerd Hoffmann Also adds support for multiple LPT devices. Signed-off-by: Gerd Hoffmann Reviewed-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20200515150421.25479-8-kra...@redhat.com> --- hw/char/parallel.c | 22 ++ hw/i386/acpi-build.c | 23 -

[PULL v2 12/58] tests/acpi: update DSDT expected files

2020-06-12 Thread Michael S. Tsirkin
Update DSDT after CRS changes and _STA methods dropped. Signed-off-by: Michael S. Tsirkin --- tests/qtest/bios-tables-test-allowed-diff.h | 17 - tests/data/acpi/pc/DSDT | Bin 5125 -> 5014 bytes tests/data/acpi/pc/DSDT.acpihmat| Bin 6449 -> 6338

[PULL v2 21/58] bios-tables-test: Generate reference tables for Q35/TPM-TIS

2020-06-12 Thread Michael S. Tsirkin
From: Eric Auger TPM2, DSDT tables were generated using tests/data/acpi/rebuild-expected-aml.sh Signed-off-by: Eric Auger Reviewed-by: Stefan Berger Message-Id: <20200609125409.24179-6-eric.au...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- tests/qtest/

[PULL v2 23/58] virtio-balloon: fix free page hinting check on unrealize

2020-06-12 Thread Michael S. Tsirkin
From: David Hildenbrand Checking against guest features is wrong. We allocated data structures based on host features. We can rely on "free_page_bh" as an indicator whether to un-do stuff instead. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alexander Duyck Fixes: c13c4153f76d ("virtio-bal

[PULL v2 15/58] acpi: Move build_tpm2() in the generic part

2020-06-12 Thread Michael S. Tsirkin
From: Eric Auger We plan to build the TPM2 table on ARM too. In order to reuse the generation code, let's move build_tpm2() to aml-build.c. No change in the implementation. Signed-off-by: Eric Auger Message-Id: <20200601095737.32671-3-eric.au...@redhat.com> Reviewed-by: Michael S. Tsirkin Sig

[PULL v2 20/58] bios-tables-test: Add Q35/TPM-TIS test

2020-06-12 Thread Michael S. Tsirkin
From: Eric Auger Test tables specific to the TPM-TIS instantiation. The TPM2 is added in the framework. Also the DSDT is updated with the TPM. The new function should be be usable for CRB as well, later one. Signed-off-by: Eric Auger Message-Id: <20200609125409.24179-5-eric.au...@redhat.com> R

[PULL v2 28/58] hw/pci/pcie: Move hot plug capability check to pre_plug callback

2020-06-12 Thread Michael S. Tsirkin
From: Julia Suvorova Check for hot plug capability earlier to avoid removing devices attached during the initialization process. Run qemu with an unattached drive: -drive file=$FILE,if=none,id=drive0 \ -device pcie-root-port,id=rp0,slot=3,bus=pcie.0,hotplug=off Hotplug a block device: devi

[PULL v2 27/58] MAINTAINERS: Fix the classification of bios-tables-test-allowed-diff.h

2020-06-12 Thread Michael S. Tsirkin
From: Thomas Huth The file tests/qtest/bios-tables-test-allowed-diff.h is currently only assigned to the qtest section according MAINTAINERS. However, this file normally only gets updated when the ACPI tables changed - something the qtest maintainers don't have much clue of. Thus this file should

[PULL v2 24/58] virtio-balloon: unref the iothread when unrealizing

2020-06-12 Thread Michael S. Tsirkin
From: David Hildenbrand We took a reference when realizing, so let's drop that reference when unrealizing. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alexander Duyck Fixes: c13c4153f76d ("virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT") Cc: qemu-sta...@nongnu.org Cc: Wei Wang Cc: Alexa

[PULL v2 29/58] pci: assert configuration access is within bounds

2020-06-12 Thread Michael S. Tsirkin
From: Prasad J Pandit While accessing PCI configuration bytes, assert that 'address + len' is within PCI configuration space. Generally it is within bounds. This is more of a defensive assert, in case a buggy device was to send 'address' which may go out of bounds. Suggested-by: Philippe Mathie

[PULL v2 36/58] Add helper to populate vhost-user message regions

2020-06-12 Thread Michael S. Tsirkin
From: Raphael Norwitz When setting vhost-user memory tables, memory region descriptors must be copied from the vhost_dev struct to the vhost-user message. To avoid duplicating code in setting the memory tables, we should use a helper to populate this field. This change adds this helper. Signed-o

[PULL v2 33/58] hw/pci-host: Use the IEC binary prefix definitions

2020-06-12 Thread Michael S. Tsirkin
From: Philippe Mathieu-Daudé IEC binary prefixes ease code review: the unit is explicit. Reviewed-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20200601142930.29408-6-f4...@amsat.org> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Richar

[PULL v2 37/58] Add vhost-user helper to get MemoryRegion data

2020-06-12 Thread Michael S. Tsirkin
From: Raphael Norwitz When setting the memory tables, qemu uses a memory region's userspace address to look up the region's MemoryRegion struct. Among other things, the MemoryRegion contains the region's offset and associated file descriptor, all of which need to be sent to the backend. With VHO

[PULL v2 26/58] virtio-balloon: Provide an interface for free page reporting

2020-06-12 Thread Michael S. Tsirkin
From: Alexander Duyck Add support for free page reporting. The idea is to function very similar to how the balloon works in that we basically end up madvising the page as not being used. However we don't really need to bother with any deflate type logic since the page will be faulted back into th

[PULL v2 40/58] Lift max memory slots limit imposed by vhost-user

2020-06-12 Thread Michael S. Tsirkin
From: Raphael Norwitz Historically, sending all memory regions to vhost-user backends in a single message imposed a limitation on the number of times memory could be hot-added to a VM with a vhost-user device. Now that backends which support the VHOST_USER_PROTOCOL_F_CONFIGURE_SLOTS send memory r

[PULL v2 43/58] Support adding individual regions in libvhost-user

2020-06-12 Thread Michael S. Tsirkin
From: Raphael Norwitz When the VHOST_USER_PROTOCOL_F_CONFIGURE_MEM_SLOTS is enabled, qemu will transmit memory regions to a backend individually using the new message VHOST_USER_ADD_MEM_REG. With this change vhost-user backends built with libvhost-user can now map in new memory regions when VHOST

[PULL v2 38/58] Add VHOST_USER_PROTOCOL_F_CONFIGURE_MEM_SLOTS

2020-06-12 Thread Michael S. Tsirkin
From: Raphael Norwitz This change introduces a new feature to the vhost-user protocol allowing a backend device to specify the maximum number of ram slots it supports. At this point, the value returned by the backend will be capped at the maximum number of ram slots which can be supported by vho

[PULL v2 34/58] char-socket: return -1 in case of disconnect during tcp_chr_write

2020-06-12 Thread Michael S. Tsirkin
From: Dima Stepanov During testing of the vhost-user-blk reconnect functionality the qemu SIGSEGV was triggered: start qemu as: x86_64-softmmu/qemu-system-x86_64 -m 1024M -M q35 \ -object memory-backend-file,id=ram-node0,size=1024M,mem-path=/dev/shm/qemu,share=on \ -numa node,cpus=0,memd

[PULL v2 44/58] Support individual region unmap in libvhost-user

2020-06-12 Thread Michael S. Tsirkin
From: Raphael Norwitz When the VHOST_USER_PROTOCOL_F_CONFIGURE_MEM_SLOTS protocol feature is enabled, on memory hot-unplug qemu will transmit memory regions to remove individually using the new message VHOST_USER_REM_MEM_REG message. With this change, vhost-user backends build with libvhost-user

[PULL v2 55/58] acpi: ged: rename event memory region

2020-06-12 Thread Michael S. Tsirkin
From: Gerd Hoffmann Rename memory region and callbacks and ops to carry "evt" in the name because a second region will be added shortly. Signed-off-by: Gerd Hoffmann Message-Id: <20200520132003.9492-10-kra...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Igor Mammedow Reviewed-

[PULL v2 42/58] Support ram slot configuration in libvhost-user

2020-06-12 Thread Michael S. Tsirkin
From: Raphael Norwitz The VHOST_USER_GET_MAX_MEM_SLOTS message allows a vhost-user backend to specify a maximum number of ram slots it is willing to support. This change adds support for libvhost-user to process this message. For now the backend will reply with 8 as the maximum number of regions

[PULL v2 35/58] vhost-user-blk: delay vhost_user_blk_disconnect

2020-06-12 Thread Michael S. Tsirkin
From: Dima Stepanov A socket write during vhost-user communication may trigger a disconnect event, calling vhost_user_blk_disconnect() and clearing all the vhost_dev structures holding data that vhost-user functions expect to remain valid to roll back initialization correctly. Delay the cleanup t

[PULL v2 45/58] Lift max ram slots limit in libvhost-user

2020-06-12 Thread Michael S. Tsirkin
From: Raphael Norwitz Historically, VMs with vhost-user devices could hot-add memory a maximum of 8 times. Now that the VHOST_USER_PROTOCOL_F_CONFIGURE_MEM_SLOTS protocol feature has been added, VMs with vhost-user backends which support this new feature can support a configurable number of ram s

[PULL v2 54/58] acpi: fadt: add hw-reduced sleep register support

2020-06-12 Thread Michael S. Tsirkin
From: Gerd Hoffmann Add fields to struct AcpiFadtData and update build_fadt() to properly generate sleep register entries. Signed-off-by: Gerd Hoffmann Reviewed-by: Igor Mammedov Message-Id: <20200520132003.9492-9-kra...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Ts

[PULL v2 46/58] libvhost-user: advertise vring features

2020-06-12 Thread Michael S. Tsirkin
From: Stefan Hajnoczi libvhost-user implements several vring features without advertising them. There is no way for the vhost-user master to detect support for these features. Things more or less work today because QEMU assumes the vhost-user backend always implements certain feature bits like V

[PULL v2 39/58] Transmit vhost-user memory regions individually

2020-06-12 Thread Michael S. Tsirkin
From: Raphael Norwitz With this change, when the VHOST_USER_PROTOCOL_F_CONFIGURE_MEM_SLOTS protocol feature has been negotiated, Qemu no longer sends the backend all the memory regions in a single message. Rather, when the memory tables are set or updated, a series of VHOST_USER_ADD_MEM_REG and V

[PULL v2 56/58] Fix parameter type in vhost migration log path

2020-06-12 Thread Michael S. Tsirkin
From: Raphael Norwitz The ‘enable’ parameter to the vhost_migration_log() function is given as an int, but "true"/"false" values are passed in wherever it is invoked. Inside the function itself it is only ever compared with bool values. Therefore the parameter value itself should be changed to bo

[PULL v2 52/58] acpi: create acpi-common.c and move madt code

2020-06-12 Thread Michael S. Tsirkin
From: Gerd Hoffmann We'll need madt support for microvm. Signed-off-by: Gerd Hoffmann Reviewed-by: Igor Mammedov Message-Id: <20200520132003.9492-7-kra...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/i386/acpi-comm

[PULL v2 47/58] hw/pci: Fix crash when running QEMU with "-nic model=rocker"

2020-06-12 Thread Michael S. Tsirkin
From: Thomas Huth QEMU currently aborts when being started with "-nic model=rocker" or with "-net nic,model=rocker". This happens because the "rocker" device is not a normal NIC but a switch, which has different properties. Thus we should only consider real NIC devices for "-nic" and "-net". Thes

[PULL v2 05/58] qtest: allow DSDT acpi table changes

2020-06-12 Thread Michael S. Tsirkin
From: Gerd Hoffmann Signed-off-by: Gerd Hoffmann Message-Id: <20200515150421.25479-2-kra...@redhat.com> --- tests/qtest/bios-tables-test-allowed-diff.h | 17 + 1 file changed, 17 insertions(+) diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-t

[PULL v2 41/58] Refactor out libvhost-user fault generation logic

2020-06-12 Thread Michael S. Tsirkin
From: Raphael Norwitz In libvhost-user, the incoming postcopy migration path for setting the backend's memory tables has become convolued. In particular, moving the logic which starts generating faults, having received the final ACK from qemu can be moved to a separate function. This simplifies t

[PULL v2 51/58] acpi: make build_madt() more generic.

2020-06-12 Thread Michael S. Tsirkin
From: Gerd Hoffmann Remove PCMachineState dependency from build_madt(). Pass AcpiDeviceIf as separate argument instead of depending on PCMachineState->acpi_dev. Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Igor Mammedov Message-Id: <20200520132003.9492-6-kra..

[PULL v2 31/58] hw/pci/pci_bridge: Correct pci_bridge_io memory region size

2020-06-12 Thread Michael S. Tsirkin
From: Philippe Mathieu-Daudé memory_region_set_size() handle the 16 Exabytes limit by special-casing the UINT64_MAX value. This is not a problem for the 32-bit maximum, 4 GiB. By using the UINT32_MAX value, the pci_bridge_io MemoryRegion ends up missing 1 byte: (qemu) info mtree memory-regio

[PULL v2 53/58] acpi: madt: skip pci override on pci-less systems.

2020-06-12 Thread Michael S. Tsirkin
From: Gerd Hoffmann Needed for microvm. Signed-off-by: Gerd Hoffmann Reviewed-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20200520132003.9492-8-kra...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/i386/acpi-common.h | 3 ++- hw

[PULL v2 04/58] tests/acpi: update expected SRAT files

2020-06-12 Thread Michael S. Tsirkin
From: Vishal Verma Update expected SRAT files for the change to account for NVDIMM NUMA nodes in the SRAT. AML diffs: tests/data/acpi/pc/SRAT.dimmpxm: Message-Id: <20200606000911.9896-4-vishal.l.ve...@intel.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- tests/qtes

[PULL v2 14/58] acpi: Convert build_tpm2() to build_append* API

2020-06-12 Thread Michael S. Tsirkin
From: Eric Auger In preparation of its move to the generic acpi code, let's convert build_tpm2() to use build_append API. This latter now is prefered in place of direct ACPI struct field settings with manual endianness conversion. Signed-off-by: Eric Auger Message-Id: <20200601095737.32671-2-er

Re: [PULL 000/115] Huge miscellaneous pull request for 2020-06-11

2020-06-12 Thread Roman Bolshakov
On Fri, Jun 12, 2020 at 03:33:38PM +0200, Paolo Bonzini wrote: > On 12/06/20 15:09, Peter Maydell wrote: > > Hi; I'm afraid this fails to build on OSX, and has a check-tcg > > failure on x86-64 Linux. > > > > OSX: > > > > In file included from > > /Users/pm215/src/qemu-for-merges/target/i386/hvf

[PULL v2 57/58] pci: Display PCI IRQ pin in "info pci"

2020-06-12 Thread Michael S. Tsirkin
From: Peter Xu Sometimes it would be good to be able to read the pin number along with the IRQ number allocated. Since we'll dump the IRQ number, no reason to not dump the pin information. For example, the vfio-pci device will overwrite the pin with the hardware pin number. It would be nice to

[PULL v2 02/58] diffs-allowed: add the SRAT AML to diffs-allowed

2020-06-12 Thread Michael S. Tsirkin
From: Vishal Verma In anticipation of a change to the SRAT generation in qemu, add the AML file to diffs-allowed. Signed-off-by: Vishal Verma Message-Id: <20200606000911.9896-2-vishal.l.ve...@intel.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- tests/qtest/bios-ta

[PULL v2 58/58] virtio-pci: fix queue_enable write

2020-06-12 Thread Michael S. Tsirkin
From: Jason Wang Spec said: The driver uses this to selectively prevent the device from executing requests from this virtqueue. 1 - enabled; 0 - disabled. Though write 0 to queue_enable is forbidden by the spec, we should not assume that the value is 1. Fix this by ignore the write value other

[PULL v2 18/58] tests/acpi: Add void tables for Q35/TPM-TIS bios-tables-test

2020-06-12 Thread Michael S. Tsirkin
From: Eric Auger Add placeholders for TPM and DSDT reference tables for Q35 TPM-TIS tests and ignore them for the time being. Signed-off-by: Eric Auger Reviewed-by: Stefan Berger Reviewed-by: Igor Mammedov Message-Id: <20200609125409.24179-3-eric.au...@redhat.com> Reviewed-by: Michael S. Tsi

[PULL v2 49/58] virtio: add vhost-user-vsock base device

2020-06-12 Thread Michael S. Tsirkin
From: Stefano Garzarella This patch introduces a vhost-user device for vsock, using the vhost-vsock-common parent class. The vhost-user-vsock device can be used to implement the virtio-vsock device emulation in user-space. Signed-off-by: Stefano Garzarella Message-Id: <20200522122512.87413-3-s

[PULL v2 25/58] virtio-balloon: Implement support for page poison reporting feature

2020-06-12 Thread Michael S. Tsirkin
From: Alexander Duyck We need to make certain to advertise support for page poison reporting if we want to actually get data on if the guest will be poisoning pages. Add a value for reporting the poison value being used if page poisoning is enabled in the guest. With this we can determine if we

[PULL v2 17/58] test/tpm-emu: include sockets and channel headers in tpm-emu header

2020-06-12 Thread Michael S. Tsirkin
From: Eric Auger Include sockets and channel headers to that the header is self-contained. Signed-off-by: Eric Auger Reviewed-by: Stefan Berger Message-Id: <20200609125409.24179-2-eric.au...@redhat.com> --- tests/qtest/tpm-emu.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/qte

  1   2   >