Re: [PATCH v2 09/24] macio: Fix to realize "mos6522-cuda" and "mos6522-pmu" devices

Peter Maydell writes: > On Thu, 28 May 2020 at 12:13, Markus Armbruster wrote: >> >> cuda_init() creates a "mos6522-cuda" device, but it's never realized. >> Affects machines mac99 with via=cuda (default) and g3beige. >> >> pmu_init() creates a "mos6522-pmu" device, but it's never realized. >> A

Re: [PATCH v2 21/24] sparc/leon3: Fix to put grlib,* devices on sysbus

On 6/9/20 7:15 AM, Philippe Mathieu-Daudé wrote: > On 5/28/20 1:04 PM, Markus Armbruster wrote: >> leon3_generic_hw_init() creates a "grlib,ahbpnp" and a "grlib,apbpnp" >> sysbus device in a way that leaves them unplugged. >> >> Create them the common way that puts them into the main system bus. >>

Re: [PATCH 5/6] hw/arm: Add NPCM730 and NPCM750 SoC models

On 5/21/20 9:21 PM, Havard Skinnemoen wrote: > The Nuvoton NPCM7xx SoC family are used to implement Baseboard > Management Controllers in servers. While the family includes four SoCs, > this patch implements limited support for two of them: NPCM730 (targeted > for Data Center applications) and NPCM

Re: [PATCH 2/6] hw/misc: Add NPCM7xx System Global Control Registers device model

On 5/21/20 9:21 PM, Havard Skinnemoen wrote: > Implement a device model for the System Global Control Registers in the > NPCM730 and NPCM750 BMC SoCs. > > This is primarily used to enable SMP boot (the boot ROM spins reading > the SCRPAD register); other registers are best effort for now. > > The

Re: [PATCH 6/6] hw/arm: Add two NPCM7xx-based machines

On 5/21/20 9:21 PM, Havard Skinnemoen wrote: > This adds two new machines: > > - npcm750-evb: Nuvoton NPCM750 Evaluation Board. > - quanta-gsj: A board with a NPCM730 chip. > > They rely on the NPCM7xx SoC device to do the heavy lifting. They are > almost completely identical at the moment, a

Re: [PATCH v5 13/13] qcow2_format.py: dump bitmaps header extension

09.06.2020 01:00, Eric Blake wrote: On 6/6/20 3:18 AM, Vladimir Sementsov-Ogievskiy wrote: Add class for bitmap extension and dump its fields. Further work is to dump bitmap directory. Test new functionality inside 291 iotest. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Andrey Sh

Re: [PATCH 3/6] hw/misc: Add NPCM7xx Clock Controller device model

On 5/21/20 9:21 PM, Havard Skinnemoen wrote: > Enough functionality to boot the Linux kernel has been implemented. This > includes: > > - Correct power-on reset values so the various clock rates can be > accurately calculated. > - Clock enables stick around when written. > > In addition,

[PATCH] rbd: Use RBD fast-diff for querying actual allocation

Since Ceph version Infernalis (9.2.0) the new fast-diff mechanism of RBD allows for querying actual rbd image usage. Prior to this version there was no easy and fast way to query how much allocation a RBD image had inside a Ceph cluster. To use the fast-diff feature it needs to be enabled per RBD

Re: [PATCH 0/6] Add Nuvoton NPCM730/NPCM750 SoCs and two BMC machines

On 6/9/20 12:14 AM, Havard Skinnemoen wrote: > On Thu, May 21, 2020 at 12:21 PM Havard Skinnemoen > wrote: > > This patch series models enough of the Nuvoton NPCM730 and NPCM750 SoCs > to boot > a minimal Linux kernel. This includes device models for: > >

[PULL 00/16] SPARC patches for 2020-06-09

re available in the Git repository at: https://gitlab.com/philmd/qemu.git tags/sparc-next-20200609 for you to fetch changes up to 86e8c353f705f14f2f2fd7a6195cefa431aa24d9: target/sparc/int32_helper: Extract and use excp_name_str() (2020-06-09 0

[PULL 02/16] hw/misc/empty_slot: Lower address space priority

Empty slots model RAZ/WI access on a bus. Since we can still (hot) plug devices on the bus, lower the slot priority, so device added later is accessed first. Signed-off-by: Philippe Mathieu-Daudé Acked-by: Artyom Tarasenko Message-Id: <20200510152840.13558-3-f4...@amsat.org> --- hw/core/empty_s

[PULL 03/16] hw/misc/empty_slot: Convert 'size' field as qdev property

Signed-off-by: Philippe Mathieu-Daudé Acked-by: Artyom Tarasenko Message-Id: <20200510152840.13558-4-f4...@amsat.org> --- hw/core/empty_slot.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/hw/core/empty_slot.c b/hw/core/empty_slot.c index 5ab426e965..0df086f

[PULL 01/16] hw/sparc/sun4m: Use UnimplementedDevice for I/O devices

These devices are not slots on a bus, but real I/O devices that we do not implement. As the ISDN ROM would be a ROMD device, also model it as UnimplementedDevice. Reviewed-by: Artyom Tarasenko Message-Id: <20200510152840.13558-2-f4...@amsat.org> Signed-off-by: Philippe Mathieu-Daudé --- hw/spar

[PULL 04/16] hw/misc/empty_slot: Add a 'name' qdev property

Add a 'name' qdev property so when multiple slots are accessed, we can notice which one is accessed. Signed-off-by: Philippe Mathieu-Daudé Acked-by: Artyom Tarasenko Message-Id: <20200510152840.13558-5-f4...@amsat.org> --- hw/core/empty_slot.c | 7 ++- 1 file changed, 6 insertions(+), 1 del

[PULL 13/16] hw/misc/grlib_ahb_apb_pnp: Add trace events on read accesses

Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: KONRAD Frederic Message-Id: <20200331105048.27989-5-f4...@amsat.org> --- hw/misc/grlib_ahb_apb_pnp.c | 13 +++-- hw/misc/trace-events| 4 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/hw/misc/grlib_ahb_apb

[PULL 05/16] hw/misc/empty_slot: Convert debug printf() to trace event

Signed-off-by: Philippe Mathieu-Daudé Acked-by: Artyom Tarasenko Message-Id: <20200510152840.13558-6-f4...@amsat.org> --- hw/core/empty_slot.c | 19 --- hw/core/trace-events | 4 2 files changed, 12 insertions(+), 11 deletions(-) diff --git a/hw/core/empty_slot.c b/hw/core

[PULL 06/16] hw/misc/empty_slot: Move the 'hw/misc' and cover in MAINTAINERS

Add an entry for the 'empty_slot' device. Signed-off-by: Philippe Mathieu-Daudé Acked-by: Artyom Tarasenko Message-Id: <20200510152840.13558-7-f4...@amsat.org> --- include/hw/empty_slot.h| 9 - include/hw/misc/empty_slot.h | 19 +++ hw/mips/malta.c

[PULL 08/16] hw/sparc/leon3: Map the UART device unconditionally

The UART is present on the chipset regardless there is a character device connected to it. Map it unconditionally. Signed-off-by: Philippe Mathieu-Daudé Acked-by: Artyom Tarasenko Reviewed-by: KONRAD Frederic Message-Id: <20200608172144.20461-2-f4...@amsat.org> --- hw/sparc/leon3.c | 18 ++

[PULL 16/16] target/sparc/int32_helper: Extract and use excp_name_str()

Improve exception error report: Before: qemu: fatal: Trap 0x06 while interrupts disabled, Error state After: qemu: fatal: Trap 0x06 (Window Underflow) while interrupts disabled, Error state Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: KONRAD Frederic Message-Id: <20200331105048.27

[PULL 10/16] hw/sparc64/niagara: Remove duplicated NIAGARA_UART_BASE definition

NIAGARA_UART_BASE is already defined few lines earlier. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Artyom Tarasenko Message-Id: <20200608172144.20461-3-f4...@amsat.org> --- hw/sparc64/niagara.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/sparc64/niagara.c b/hw/sparc64/niagara.

Re: [PATCH v2 23/24] sd: Hide the qdev-but-not-quite thing created by sd_init()

On 6/9/20 8:39 AM, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > >> On 5/28/20 1:04 PM, Markus Armbruster wrote: >>> Commit 260bc9d8aa "hw/sd/sd.c: QOMify" QOMified only the device >>> itself, not its users. It kept sd_init() around for non-QOMified >>> users. >>> >>> More than fou

[PULL 07/16] hw/misc/empty_slot: Name the slots when created

Directly set the slot name when creating the device, to display the device name in trace events. Signed-off-by: Philippe Mathieu-Daudé Acked-by: Artyom Tarasenko Message-Id: <20200510152840.13558-8-f4...@amsat.org> --- include/hw/misc/empty_slot.h | 2 +- hw/mips/malta.c | 2 +-

[PULL 12/16] hw/misc/grlib_ahb_apb_pnp: Fix AHB PnP 8-bit accesses

The Plug & Play region of the AHB/APB bridge can be accessed by various word size, however the implementation is clearly restricted to 32-bit: static uint64_t grlib_ahb_pnp_read(void *opaque, hwaddr offset, unsigned size) { AHBPnp *ahb_pnp = GRLIB_AHB_PNP(opaque); return ahb_pnp->

[PULL 14/16] hw/timer/grlib_gptimer: Display frequency in decimal

Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: KONRAD Frederic Message-Id: <20200331105048.27989-6-f4...@amsat.org> --- hw/timer/trace-events | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/timer/trace-events b/hw/timer/trace-events index 80ea197594..866c9f546a 100644

[PULL 09/16] hw/sparc64/niagara: Map the UART device unconditionally

The UART is present on the machine regardless there is a character device connected to it. Map it unconditionally. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Artyom Tarasenko Message-Id: <20200608172144.20461-4-f4...@amsat.org> --- hw/sparc64/niagara.c | 6 ++ 1 file changed, 2 inse

[PULL 11/16] hw/misc/grlib_ahb_apb_pnp: Avoid crash when writing to AHB PnP registers

Similarly to commit 158b659451 with the APB PnP registers, guests can crash QEMU when writting to the AHB PnP registers: $ echo 'writeb 0xf042 69' | qemu-system-sparc -M leon3_generic -S -bios /etc/magic -qtest stdio [I 1571938309.932255] OPENED [R +0.063474] writeb 0xf042 69 Segm

Re: [PATCH v2 02/24] display/xlnx_dp: Fix to realize "i2c-ddc" and "aux-to-i2c-bridge"

On 6/9/20 7:38 AM, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > >> On 5/28/20 1:04 PM, Markus Armbruster wrote: >>> xlnx_dp_init() creates these two devices, but they're never realized. >>> Affects machine xlnx-zcu102. >>> >>> In theory, a device becomes real only on realize. In p

[PULL 15/16] target/sparc/int32_helper: Remove DEBUG_PCALL definition

We define DEBUG_PCALL since b884fc5e (2012-10-06). 7.5 years later it is safe to assume we can remove it :) Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: KONRAD Frederic Message-Id: <20200331105048.27989-7-f4...@amsat.org> --- target/sparc/int32_helper.c | 5 - 1 file changed, 5 deleti

Re: [PATCH v2 05/58] qdev: Put qdev_new() to use with Coccinelle

On 5/29/20 3:44 PM, Markus Armbruster wrote: > Let's start simple and put qdev_new() to use. Coccinelle script: > > @ depends on !(file in "hw/core/qdev.c")@ > expression type_name; > @@ > -DEVICE(object_new(type_name)) > +qdev_new(type_name) > > Signed-off-by: Markus

Re: [PATCH v2 04/58] qdev: New qdev_new(), qdev_realize(), etc.

On 5/29/20 3:44 PM, Markus Armbruster wrote: > We commonly plug devices into their bus right when we create them, > like this: > > dev = qdev_create(bus, type_name); > > Note that @dev is a weak reference. The reference from @bus to @dev > is the only strong one. > > We realize at some late

Re: [PATCH v2 07/58] qdev: Convert to qdev_unrealize() with Coccinelle

On 5/29/20 3:44 PM, Markus Armbruster wrote: > For readability, and consistency with qbus_realize(). > > Coccinelle script: > > @ depends on !(file in "hw/core/qdev.c")@ > typedef DeviceState; > DeviceState *dev; > symbol false, error_abort; > @@ > -object_property_set

Re: [PATCH v2 08/58] qdev: Convert to qdev_unrealize() manually

On 5/29/20 3:44 PM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > include/hw/qdev-core.h | 1 - > hw/core/qdev.c | 4 ++-- > 2 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h > index fba29308f7..be6f7c4

Re: [PATCH v2 11/58] qdev: Convert uses of qdev_set_parent_bus() with Coccinelle

On 5/29/20 3:44 PM, Markus Armbruster wrote: > In addition to the qdev_create() patterns converted so far, we have a > qdev_set_parent_bus() pattern. Mostly when we embed a device in a > parent device rather than allocating it on the heap. > > This pattern also puts devices in the dangerous "no Q

Re: [PATCH v2 12/58] qdev: Convert uses of qdev_set_parent_bus() manually

On 5/29/20 3:44 PM, Markus Armbruster wrote: > Same transformation as in the previous commit. Manual, because > convincing Coccinelle to transform these cases is somewhere between > not worthwhile and infeasible (at least for me). > > Signed-off-by: Markus Armbruster > --- > hw/pci-host/prep.c

Re: [PATCH v2 06/58] qdev: Convert to qbus_realize(), qbus_unrealize()

On 5/29/20 3:44 PM, Markus Armbruster wrote: > I'm going to convert device realization to qdev_realize() with the > help of Coccinelle. Convert bus realization to qbus_realize() first, > to get it out of Coccinelle's way. Readability improves. > > Signed-off-by: Markus Armbruster > --- > hw/co

Re: [PATCH v2 18/58] isa: New isa_new(), isa_realize_and_unref() etc.

On 5/29/20 3:44 PM, Markus Armbruster wrote: > I'm converting from qdev_create()/qdev_init_nofail() to > qdev_new()/qdev_realize_and_unref(); recent commit "qdev: New > qdev_new(), qdev_realize(), etc." explains why. > > ISA devices use qdev_create() through isa_create() and > isa_try_create(). >

Re: [PATCH v2 26/58] usb: New usb_new(), usb_realize_and_unref()

On 5/29/20 3:44 PM, Markus Armbruster wrote: > I'm converting from qdev_create()/qdev_init_nofail() to > qdev_new()/qdev_realize_and_unref(); recent commit "qdev: New > qdev_new(), qdev_realize(), etc." explains why. > > USB devices use qdev_create() through usb_create(). > > Provide usb_new() an

Re: [PATCH v2 18/58] isa: New isa_new(), isa_realize_and_unref() etc.

On 6/9/20 10:19 AM, Philippe Mathieu-Daudé wrote: > On 5/29/20 3:44 PM, Markus Armbruster wrote: >> I'm converting from qdev_create()/qdev_init_nofail() to >> qdev_new()/qdev_realize_and_unref(); recent commit "qdev: New >> qdev_new(), qdev_realize(), etc." explains why. >> >> ISA devices use qdev_

Re: [PATCH v2 33/58] auxbus: Convert a use of qdev_set_parent_bus()

On 5/29/20 3:44 PM, Markus Armbruster wrote: > Convert qdev_set_parent_bus()/qdev_init_nofail() to qdev_realize(); > recent commit "qdev: New qdev_new(), qdev_realize(), etc." explains > why. > > Signed-off-by: Markus Armbruster > --- > hw/display/xlnx_dp.c | 2 +- > hw/misc/auxbus.c | 4 +--

Re: [PATCH v2 37/58] macio: Convert use of qdev_set_parent_bus()

On 5/29/20 3:45 PM, Markus Armbruster wrote: > Convert qdev_set_parent_bus()/realize to qdev_realize(); recent commit If you send the pull request yourself, can you add the commit sha1 instead here please? Reviewed-by: Philippe Mathieu-Daudé > "qdev: New qdev_new(), qdev_realize(), etc." explai

Re: [PATCH v2 44/58] sysbus: New sysbus_realize(), sysbus_realize_and_unref()

On 5/29/20 3:45 PM, Markus Armbruster wrote: > Sysbus devices almost always plug into the main system bus. > qdev_create() even has a convenience feature to make that easy: a null > bus argument gets replaced by the main system bus. qdev_realize() and > qdev_realize_and_unref() do the same. > > W

RE: [RFC] hw: nios2: update interrupt_request when STATUS_PIE disabled

Hi @Thomas Huth, It's my first time to send patch in qemu community, not sure if there is something wrong sending patch like below and I'm happy to receive any suggestions. And by the way, could you please help review the patch? Thanks -Original Message- From: Thomas Huth Sent: Frida

Re: [PATCH v2 2/8] MAINTAINERS: Mark SH4 based R2D & Shix machines orphan

Thomas Huth writes: > On 08/06/2020 11.01, Philippe Mathieu-Daudé wrote: >> Last commit from Magnus Damm is fc8e320ef583, which date is >> Fri Nov 13 2009. As nobody else seems to care about the patches >> posted [*] related to the R2D and Shix machines, mark them orphan. >> >> Many thanks to M

Re: [PATCH v2 45/58] sysbus: Convert to sysbus_realize() etc. with Coccinelle

On 5/29/20 3:45 PM, Markus Armbruster wrote: > Convert from qdev_realize(), qdev_realize_and_unref() with null @bus > argument to sysbus_realize(), sysbus_realize_and_unref(). > > Coccinelle script: > > @@ > expression dev, errp; > @@ > -qdev_realize(DEVICE(dev), NULL, errp);

Re: [PATCH v2 46/58] qdev: Drop qdev_realize() support for null bus

On 5/29/20 3:45 PM, Markus Armbruster wrote: > The "null @bus means main system bus" convenience feature is no longer > used. Drop it. > > Signed-off-by: Markus Armbruster > --- > hw/core/qdev.c | 16 ++-- > 1 file changed, 2 insertions(+), 14 deletions(-) > > diff --git a/hw/core/

Re: [PATCH v3 00/16] python: add mypy support to python/qemu

Philippe Mathieu-Daudé writes: > On 6/8/20 5:33 PM, Kevin Wolf wrote: >> Am 08.06.2020 um 17:19 hat John Snow geschrieben: >>> >>> >>> On 6/5/20 5:26 AM, Kevin Wolf wrote: Am 04.06.2020 um 22:22 hat John Snow geschrieben: > Based-on: 20200604195252.20739-1-js...@redhat.com > > Th

Re: [PATCH v2 2/8] MAINTAINERS: Mark SH4 based R2D & Shix machines orphan

Hi Markus and Thomas, On Tue, Jun 9, 2020 at 5:41 PM Markus Armbruster wrote: > > Thomas Huth writes: > > > On 08/06/2020 11.01, Philippe Mathieu-Daudé wrote: > >> Last commit from Magnus Damm is fc8e320ef583, which date is > >> Fri Nov 13 2009. As nobody else seems to care about the patches >

Re: [PATCH v2 2/8] MAINTAINERS: Mark SH4 based R2D & Shix machines orphan

Hi Magnus, On 6/9/20 10:59 AM, Magnus Damm wrote: > Hi Markus and Thomas, > > On Tue, Jun 9, 2020 at 5:41 PM Markus Armbruster wrote: >> >> Thomas Huth writes: >> >>> On 08/06/2020 11.01, Philippe Mathieu-Daudé wrote: Last commit from Magnus Damm is fc8e320ef583, which date is Fri Nov

Re: [PATCH 1/1] qga-win: fix "guest-get-fsinfo" wrong filesystem type

Ping On Thu, Apr 30, 2020 at 3:11 PM Basil Salman wrote: > From: Basil Salman > > This patch handles the case where unmounted volumes exist, > where in that case GetVolumePathNamesForVolumeName returns > empty path, GetVolumeInformation will use the current working > directory instead. > This p

Re: [PATCH v3 8/9] decodetree: Drop check for less than 2 patterns in a group

On Mon, 8 Jun 2020 at 19:37, Richard Henderson wrote: > > While it makes little sense for the end product to have a group > containing only a single pattern, avoiding this case within an > incremental patch set is troublesome. > > Because this is expected to be a transient condition, do not > both

[RFC PATCH] softfloat: partially convert float32_to_floatx80 to new style (HACK)

This is just an experimental conversion of one of the float to x80 conversions to use the "new style" decomposition code. Of course it elides over any potential fraction loss you may get doing actual calculation but it may allow us to eliminate some more old code. Of course the ideal would still t

Re: [PATCH v3 0/9] decodetree: Add non-overlapping groups

On Mon, 8 Jun 2020 at 19:36, Richard Henderson wrote: > > This is a feature that Peter requested for completing the > neon decodetree conversion. > > Changes for v3: > - Remove check for less than 2 patterns in a group. > > Changes for v2: > - Rebase on master, which includes some generic pyth

Re: [PATCH 00/55] qdev: Rework how we plug into the parent bus

Paolo Bonzini writes: > All of it this time. Awesome, thanks!

Re: [PATCH v2 02/24] display/xlnx_dp: Fix to realize "i2c-ddc" and "aux-to-i2c-bridge"

Philippe Mathieu-Daudé writes: > On 6/9/20 7:38 AM, Markus Armbruster wrote: >> Philippe Mathieu-Daudé writes: >> >>> On 5/28/20 1:04 PM, Markus Armbruster wrote: xlnx_dp_init() creates these two devices, but they're never realized. Affects machine xlnx-zcu102. In theory, a

Re: [PATCH 0/6] Add Nuvoton NPCM730/NPCM750 SoCs and two BMC machines

On Tue, 9 Jun 2020 at 08:31, Cédric Le Goater wrote: > The first series was nicely presented I think, but you can extend it in v2. > Documentation needs an update in : > > docs/system/target-arm.rst To expand on that: the new boards should have at least some basic documentation in a new docs/sy

Re: [PATCH v2 1/1] virtio-ccw: auto-manage VIRTIO_F_IOMMU_PLATFORM if PV

On Tue, 9 Jun 2020 08:44:02 +0200 Cornelia Huck wrote: > On Mon, 8 Jun 2020 19:00:45 +0200 > Halil Pasic wrote: > > > > > I'm also not 100% sure about migration... would it make sense to > > > discuss all of this in the context of the cross-arch patchset? It seems > > > power has similar issue

Re: fpu/softfloat: a question on BFloat 16 support on QEMU

LIU Zhiwei writes: > On 2020/6/8 23:50, Alex Bennée wrote: >> LIU Zhiwei writes: >> >>> Hi Richard, >>> >>> I am doing bfloat16 support on QEMU. >>> >>> Once I tried to reuse float32 interface, but I couldn't properly process >>> rounding in some insns like fadd. >> What do you mean by re-use

[PATCH 0/1] hw/block/nvme: fix assert on invalid irq vector

From: Klaus Jensen I goofed up with commit c09794fe40e3 ("hw/block/nvme: allow use of any valid msix vector"). This fixes the goof by adding a new msix_qsize parameter. As a nice side-effect this allows a device with less interrupt vectors available than supported queues. Also, improve the error

[PATCH 1/2] hw/block/nvme: add msix_qsize parameter

From: Klaus Jensen Commit 4eb9f5217a16 ("hw/block/nvme: allow use of any valid msix vector") erronously allows any valid MSI-X vector to be used when creating completion queues. This is bad because MSI-X is initialized with max_ioqpairs + 1 vectors, which defaults to 64 + 1. And since commit ccd5

[PATCH 2/2] hw/block/nvme: verify msix_init_exclusive_bar() return value

From: Klaus Jensen Pass an Error to msix_init_exclusive_bar() and check it. Signed-off-by: Klaus Jensen --- hw/block/nvme.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index acc6dbc900e2..2a2e43f681f9 100644 --- a/hw/bloc

Re: [PATCH v1 2/2] nvme: allow cmb and pmr to be enabled on same device

On Jun 8 12:44, Andrzej Jakowski wrote: > On 6/8/20 1:08 AM, Klaus Jensen wrote: > > On Jun 5 11:10, Andrzej Jakowski wrote: > >> So far it was not possible to have CMB and PMR emulated on the same > >> device, because BAR2 was used exclusively either of PMR or CMB. This > >> patch places CMB at

Re: [PATCH v2 04/58] qdev: New qdev_new(), qdev_realize(), etc.

Philippe Mathieu-Daudé writes: > On 5/29/20 3:44 PM, Markus Armbruster wrote: >> We commonly plug devices into their bus right when we create them, >> like this: >> >> dev = qdev_create(bus, type_name); >> >> Note that @dev is a weak reference. The reference from @bus to @dev >> is the onl

Re: [PATCH v2 12/58] qdev: Convert uses of qdev_set_parent_bus() manually

Philippe Mathieu-Daudé writes: > On 5/29/20 3:44 PM, Markus Armbruster wrote: >> Same transformation as in the previous commit. Manual, because >> convincing Coccinelle to transform these cases is somewhere between >> not worthwhile and infeasible (at least for me). >> >> Signed-off-by: Markus

Re: [PATCH v2 46/58] qdev: Drop qdev_realize() support for null bus

Philippe Mathieu-Daudé writes: > On 5/29/20 3:45 PM, Markus Armbruster wrote: >> The "null @bus means main system bus" convenience feature is no longer >> used. Drop it. >> >> Signed-off-by: Markus Armbruster >> --- >> hw/core/qdev.c | 16 ++-- >> 1 file changed, 2 insertions(+),

Re: [PATCH v2] riscv: Add helper to make NaN-boxing for FP register

ping ? Could this be merged ? Chih-Min Chao On Wed, Jan 29, 2020 at 3:43 AM Richard Henderson < richard.hender...@linaro.org> wrote: > On 1/27/20 4:37 PM, Ian Jiang wrote: > > The function that makes NaN-boxing when a 32-bit value is assigned > > to a 64-bit FP register is split out to a hel

Re: [RFC v2 00/18] Refactor configuration of guest memory protection

On Sat, 6 Jun 2020 18:44:09 +1000 David Gibson wrote: > On Fri, Jun 05, 2020 at 12:55:05PM +0200, Cornelia Huck wrote: > > On Thu, 21 May 2020 13:42:46 +1000 > > David Gibson wrote: > > > > > A number of hardware platforms are implementing mechanisms whereby the > > > hypervisor does not have u

Re: [RFC v2 18/18] guest memory protection: Alter virtio default properties for protected guests

On Sun, 7 Jun 2020 13:07:35 +1000 David Gibson wrote: > On Sat, Jun 06, 2020 at 04:21:31PM -0400, Michael S. Tsirkin wrote: > > On Thu, May 21, 2020 at 01:43:04PM +1000, David Gibson wrote: > > > The default behaviour for virtio devices is not to use the platforms > > > normal > > > DMA paths,

Re: [PATCH v2] fuzz: add oss-fuzz build.sh script

On Fri, Jun 05, 2020 at 01:50:28PM -0400, Alexander Bulekov wrote: > It is neater to keep this in the QEMU repo, since any change that > requires an update to the oss-fuzz build configuration, can make the > necessary changes in the same series. > > Suggested-by: Philippe Mathieu-Daude > Signed-o

[PULL 15/17] tests/vm: Remove flex/bison packages

From: Philippe Mathieu-Daudé QEMU does not use flex/bison packages. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Claudio Fontana Signed-off-by: Alex Bennée Message-Id: <20200515163029.12917-3-phi...@redhat.com> diff --git a/tests/vm/fedora b/tests/vm/fedora index bd9c6cf295c..a9195670f

[PULL 02/17] scripts/clean-includes: Mark 'qemu/qemu-plugin.h' as special header

From: Philippe Mathieu-Daudé "qemu/qemu-plugin.h" isn't meant to be include by QEMU codebase, but by 3rd party plugins that QEMU can use. These plugins can be built out of QEMU and don't include "qemu/osdep.h". Mark "qemu/qemu-plugin.h" as a special header that doesn't need to be cleaned for "qem

[PULL 01/17] qemu-plugin.h: add missing include to define size_t

From: "Emilio G. Cota" Signed-off-by: Emilio G. Cota Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée Message-Id: <20200524202427.951784-1-c...@braap.org> Message-Id: <20200605154929.26910-2-alex.ben...@linaro.org> diff --git a/include/qemu/qemu-plugin.h b/include/qemu/qemu-plug

[PULL 00/17] testing and misc fixes

The following changes since commit 49ee11555262a256afec592dfed7c5902d5eefd2: Merge remote-tracking branch 'remotes/vivier2/tags/linux-user-for-5.1-pull-request' into staging (2020-06-08 11:04:57 +0100) are available in the Git repository at: https://github.com/stsquad/qemu.git tags/pull-te

[PULL 04/17] exec: flush the whole TLB if a watchpoint crosses a page boundary

There is no particular reason why you can't have a watchpoint in TCG that covers a large chunk of the address space. We could be clever about it but these cases are pretty rare and we can assume the user will expect a little performance degradation. NB: In my testing gdb will silently squash a wat

[PULL 06/17] .shippable: temporaily disable some cross builds

These currently fail due to Debian bug #960271 as the linux-libc-library has a user-space build breaking symbol in it. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Message-Id: <20200605154929.26910-7-alex.ben...@linaro.org> diff --git a/.ship

[PULL 09/17] hw/virtio/vhost: re-factor vhost-section and allow DIRTY_MEMORY_CODE

The purpose of vhost_section is to identify RAM regions that need to be made available to a vhost client. However when running under TCG all RAM sections have DIRTY_MEMORY_CODE set which leads to problems down the line. Re-factor the code so: - steps are clearer to follow - reason for rejecti

[PULL 03/17] tests/plugin: correctly honour io_count

Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20200605154929.26910-4-alex.ben...@linaro.org> diff --git a/tests/plugin/mem.c b/tests/plugin/mem.c index 878abf09d19..4725bd851d8 100644 --- a/tests/plugin/mem.c +++ b/tests/plugin/mem.c @@ -28,7 +28,7 @@ static void pl

[PULL 10/17] linux-user: provide fallback pgd_find_hole for bare chroots

When running QEMU out of a chroot environment we may not have access to /proc/self/maps. As there is no other "official" way to introspect our memory map we need to fall back to the original technique of repeatedly trying to mmap an address range until we find one that works. Fortunately it's not

[PULL 08/17] docker: update Ubuntu to 20.04

From: Paolo Bonzini Signed-off-by: Paolo Bonzini Tested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée Message-Id: <20200604231716.11354-1-pbonz...@redhat.com> Message-Id: <20200605154929.26910-10-alex.ben...@linaro.org> diff --git a/tests/docker/do

[PULL 13/17] linux-user: detect overflow of MAP_FIXED mmap

Relaxing the restrictions on 64 bit guests leads to the user being able to attempt to map right at the edge of addressable memory. This in turn lead to address overflow tripping the assert in page_set_flags when the end address wrapped around. Detect the wrap earlier and correctly -ENOMEM the gues

[PULL 16/17] cirrus-ci: Remove flex/bison packages

From: Philippe Mathieu-Daudé QEMU does not use flex/bison packages. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Li-Wen Hsu Signed-off-by: Alex Bennée Message-Id: <20200515163029.12917-5-phi...@redhat.com> diff --git a/.cirrus.yml b/.cirrus.yml index de0727cb097..ce7850a320e 100644 ---

[PULL 07/17] tests/docker: fix pre-requisite for debian-tricore-cross

Reported-by: Bastian Koppelmann Signed-off-by: Alex Bennée Message-Id: <20200605154929.26910-9-alex.ben...@linaro.org> diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include index ed46bd98eb5..981b7fcf2a5 100644 --- a/tests/docker/Makefile.include +++ b/tests/docker/Makefile.

[PULL 05/17] .travis.yml: allow failure for unreliable hosts

They will still run but they won't get in the way of the result. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Message-Id: <20200605154929.26910-6-alex.ben...@linaro.org> diff --git a/.travis.yml b/.travis.yml index 564be50a3c1..ec6367af1f0 10

[PULL 17/17] scripts/coverity-scan: Remove flex/bison packages

From: Philippe Mathieu-Daudé QEMU does not use flex/bison packages. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Claudio Fontana Signed-off-by: Alex Bennée Message-Id: <20200515163029.12917-6-phi...@redhat.com> diff --git a/scripts/coverity-scan/coverity-scan.docker b/scripts/coverity

[PULL 12/17] tests/tcg: add simple commpage test case

The COMMPAGE are a number of kernel provided user-space routines for 32 bit ARM systems. Add a basic series of smoke tests to ensure it is working as it should. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Message-Id: <20200605154929.26910-14-alex.ben...@linaro.org> diff --git a/te

[PULL 14/17] tests/docker: Remove flex/bison packages

From: Philippe Mathieu-Daudé QEMU does not use flex/bison packages. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Claudio Fontana Signed-off-by: Alex Bennée Message-Id: <20200515163029.12917-2-phi...@redhat.com> diff --git a/tests/docker/dockerfiles/centos7.docker b/tests/docker/docker

[PULL 11/17] linux-user: deal with address wrap for ARM_COMMPAGE on 32 bit

We rely on the pointer to wrap when accessing the high address of the COMMPAGE so it lands somewhere reasonable. However on 32 bit hosts we cannot afford just to map the entire 4gb address range. The old mmap trial and error code handled this by just checking we could map both the guest_base and th

[Bug 1882671] [NEW] qemu-system-x86_64 (ver 4.2) stuck at boot with OVMF bios

Public bug reported: The version of QEMU (4.2.0) packaged for Ubuntu 20.04 hangs indefinitely at boot if an OVMF bios is used. This happens ONLY with qemu-system- x86_64. qemu-system-i386 works fine with the latest ia32 OVMF bios. NOTE[1]: the same identical OVMF bios works fine on QEMU 2.x packa

Re: [PULL 15/17] tests/vm: Remove flex/bison packages

This series incidentally removes the build warnings when not having flex/bison, could someone queue it? Thanks, Claudio https://lists.gnu.org/archive/html/qemu-devel/2020-06/msg01851.html On 6/9/20 12:38 PM, Alex Bennée wrote: > From: Philippe Mathieu-Daudé > > QEMU does not use flex/bison

Re: [RFC PATCH 33/35] hw/timer/slavio_timer: Emit warning when old code is used

On 08/06/20 18:00, Philippe Mathieu-Daudé wrote: > This code hasn't been QOM'ified yet. Warn the user. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/timer/slavio_timer.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/hw/timer/slavio_timer.c b/hw/timer/slavio_timer.c > index

Re: [RFC PATCH 32/35] hw/riscv: Emit warning when old code is used

On 08/06/20 18:00, Philippe Mathieu-Daudé wrote: > This code hasn't been QOM'ified yet. Warn the user. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/riscv/riscv_htif.c | 4 > hw/riscv/sifive_uart.c | 4 > 2 files changed, 8 insertions(+) > > diff --git a/hw/riscv/riscv_htif.c

Re: [RFC PATCH 23/35] hw/misc/applesmc: Emit warning when old code is used

On 08/06/20 18:00, Philippe Mathieu-Daudé wrote: > This code hasn't been QOM'ified yet. Warn the user. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/misc/applesmc.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/hw/misc/applesmc.c b/hw/misc/applesmc.c > index 1c4addb201..d63

Re: [RFC PATCH 18/35] hw/input/ps2: Emit warning when old code is used

On 08/06/20 18:00, Philippe Mathieu-Daudé wrote: > This code hasn't been QOM'ified yet. Warn the user. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/input/ps2.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/hw/input/ps2.c b/hw/input/ps2.c > index f8746d2f5

Re: [RFC PATCH 14/35] hw/i386/pc: Emit warning when old code is used

On 08/06/20 18:00, Philippe Mathieu-Daudé wrote: > This code hasn't been QOM'ified yet. Warn the user. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/i386/pc.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/hw/i386/pc.c b/hw/i386/pc.c > index 2128f3d6fe..c71809fd28 100644 > -

Re: [RFC PATCH 17/35] hw/input/pckbd: Emit warning when old code is used

On 08/06/20 18:00, Philippe Mathieu-Daudé wrote: > This code hasn't been QOM'ified yet. Warn the user. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/input/pckbd.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/hw/input/pckbd.c b/hw/input/pckbd.c > index 60a41

Re: [PULL 15/17] tests/vm: Remove flex/bison packages

Claudio Fontana writes: > This series incidentally removes the build warnings when not having > flex/bison, > > could someone queue it? > > Thanks, > > Claudio > > https://lists.gnu.org/archive/html/qemu-devel/2020-06/msg01851.html If it is all reviewed I can pick it up in the next testing/ne

Re: [PATCH v2] hw/virtio/vhost: re-factor vhost-section and allow DIRTY_MEMORY_CODE

On Fri, Jun 05, 2020 at 11:19:30AM +0100, Alex Bennée wrote: > > Stefan Hajnoczi writes: > > > On Thu, Jun 04, 2020 at 02:40:22PM +0100, Alex Bennée wrote: > >> The purpose of vhost_section is to identify RAM regions that need to > >> be made available to a vhost client. However when running und

Re: [PATCH v1 7/9] plugins: add API to return a name for a IO device

Emilio G. Cota writes: > On Mon, Jun 08, 2020 at 09:06:17 +0100, Alex Bennée wrote: >> Emilio G. Cota writes: >> > I'd rather use asprintf(3) and strdup(3) here, so that plugins don't >> > have to worry about glib, and on the QEMU side we don't have to worry >> > about plugins calling free() i

Re: [RFC PATCH 06/35] hw/timer/arm_timer: Emit warning when old code is used

On 08/06/20 18:00, Philippe Mathieu-Daudé wrote: > This code hasn't been QOM'ified yet. Warn the user. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/timer/arm_timer.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/hw/timer/arm_timer.c b/hw/timer/arm_timer.c > index 9607366d7

Re: [RFC PATCH 21/35] hw/lm32/lm32_hwsetup: Emit warning when old code is used

On 08/06/20 18:00, Philippe Mathieu-Daudé wrote: > This code hasn't been QOM'ified yet. Warn the user. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/lm32/lm32_hwsetup.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/hw/lm32/lm32_hwsetup.h b/hw/lm32/lm32_hwsetup.h > index de9

Re: [RFC PATCH 29/35] hw/ppc/ppc_booke: Emit warning when old code is used

On 08/06/20 18:00, Philippe Mathieu-Daudé wrote: > This code hasn't been QOM'ified yet. Warn the user. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/ppc/ppc_booke.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/hw/ppc/ppc_booke.c b/hw/ppc/ppc_booke.c > index

  1   2   3   4   5   6   7   >