RE: [PATCH 3/3] migration/colo: Merge multi checkpoint request into one.

2020-06-02 Thread Zhanghailiang
> -Original Message- > From: Zhang Chen [mailto:chen.zh...@intel.com] > Sent: Friday, May 15, 2020 12:28 PM > To: Dr . David Alan Gilbert ; Juan Quintela > ; Zhanghailiang ; > qemu-dev > Cc: Zhang Chen ; Jason Wang > ; Zhang Chen > Subject: [PATCH 3/3] migration/colo: Merge multi check

Re: [PATCH 1/6] target/s390x/mmu_helper: Use address_space_rw() in place

2020-06-02 Thread David Hildenbrand
On 31.05.20 19:54, Philippe Mathieu-Daudé wrote: > In an effort to remove the cpu_physical_memory_rw() API, > update s390_cpu_virt_mem_rw() to use a more recent > address_space_rw() API. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/s390x/mmu_helper.c | 6 -- > 1 file changed, 4 i

Re: [PATCH] hw/pci/pcie: Move hot plug capability check to pre_plug callback

2020-06-02 Thread Julia Suvorova
On Tue, Jun 2, 2020 at 5:54 AM Michael S. Tsirkin wrote: > > On Mon, Jun 01, 2020 at 06:29:34PM +0200, Julia Suvorova wrote: > > Check for hot plug capability earlier to avoid removing devices attached > > during the initialization process. > > > > Run qemu with an unattached drive: > > -drive f

Re: [PATCH] MAINTAINERS: Volunteer for maintaining the Renesas hardware

2020-06-02 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > I don't have much clue about the Renesas hardware, but at least > I know now the source files a little bit, so I volunteer to pick > up patches and send pull-requests for them during my scarce > hobbyist time, until someone else with more knowledge steps up > to d

Re: Sam460Ex screen mode, audio and network

2020-06-02 Thread Philippe Mathieu-Daudé
Cc'ing the sam460ex maintainer. On 6/1/20 8:01 PM, Andrea Palmatè wrote: > Hello, i've successfully configured AmigaOS4 on Qemu 5 and i've > installed it without any problem. > It is working on an i5 laptop. I've tried to use the native screen mode > 1366x768 but it has some problems. It seems a s

Re: [PATCH] checkpatch: reversed logic with acpi test checks

2020-06-02 Thread Philippe Mathieu-Daudé
On 6/2/20 7:36 AM, Michael S. Tsirkin wrote: > Logic reversed: allowed list should just be ignored. Instead we > only take that into account :( > > Fixes: e11b06a880ca ("checkpatch: ignore allowed diff list") > Signed-off-by: Michael S. Tsirkin > --- > scripts/checkpatch.pl | 2 +- > 1 file chan

[PATCH 1/4] block: Add bdrv_co_get_lba_status

2020-06-02 Thread Lin Ma
The get lba status wrapper based on the bdrv_block_status. The following patches will add GET LBA STATUS 16 support for scsi emulation layer. Signed-off-by: Lin Ma --- block/io.c | 43 +++ 1 file changed, 43 insertions(+) diff --git a/block/io.c b/block/i

[PATCH 0/4] Add Support for GET LBA STATUS 16 command in scsi emulation

2020-06-02 Thread Lin Ma
In this current design, The GET LBA STATUS parameter data only contains an eight-byte header + one LBA status descriptor. How to test: host:~ # qemu-system-x86_64 \ ... -drive file=/vm0/disk0.raw,format=raw,if=none,id=drive0,discard=unmap \ -device scsi-hd,id=scsi0,drive=drive0 \ ... guest:~ # d

[PATCH 3/4] block: Add block accounting code for GET LBA STATUS

2020-06-02 Thread Lin Ma
Signed-off-by: Lin Ma --- include/block/accounting.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/block/accounting.h b/include/block/accounting.h index 878b4c3581..645014fb0b 100644 --- a/include/block/accounting.h +++ b/include/block/accounting.h @@ -38,6 +38,7 @@ enum BlockAcctTy

[PATCH 4/4] scsi-disk: Add support for the GET LBA STATUS 16 command

2020-06-02 Thread Lin Ma
Signed-off-by: Lin Ma --- hw/scsi/scsi-disk.c | 92 include/scsi/constants.h | 1 + 2 files changed, 93 insertions(+) diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c index 387503e11b..2d2c6b4b82 100644 --- a/hw/scsi/scsi-disk.c +++ b/hw/scsi/

[PATCH 2/4] block: Add GET LBA STATUS support

2020-06-02 Thread Lin Ma
Signed-off-by: Lin Ma --- block/block-backend.c | 38 ++ include/sysemu/block-backend.h | 2 ++ 2 files changed, 40 insertions(+) diff --git a/block/block-backend.c b/block/block-backend.c index 6936b25c83..feb1f38b98 100644 --- a/block/block-backend.c +

Re: [PATCH] or1k: Fix compilation hiccup

2020-06-02 Thread Markus Armbruster
Peter Maydell writes: > On Fri, 29 May 2020 at 17:23, Christophe de Dinechin > wrote: >> On 2020-05-26 at 20:51 CEST, Eric Blake wrote... >> > diff --git a/hw/openrisc/openrisc_sim.c b/hw/openrisc/openrisc_sim.c >> > index d08ce6181199..95011a8015b4 100644 >> > --- a/hw/openrisc/openrisc_sim.c >

[question] Partial sector issue while discard in qcow2 image

2020-06-02 Thread Lin Ma
Hi all, During woring to add GET LBA STATUS support in qemu scsi emulation layer, I encountered an unmap issue with qcow2 image, It's likely about how to unmap partial clusters. e.g.: With these default values: * the default value of s->qdev.blocksize: 512 * the default value of s->cluster_siz

Re: About the kvm-no-adjvtime CPU property

2020-06-02 Thread Ying Fang
On 2020/6/1 20:29, Andrew Jones wrote: On Mon, Jun 01, 2020 at 08:07:31PM +0800, Ying Fang wrote: On 2020/6/1 16:07, Andrew Jones wrote: On Sat, May 30, 2020 at 04:56:26PM +0800, Ying Fang wrote: About the kvm-no-adjvtime CPU property Hi Andrew, To adjust virutal time, a new kvm cpu prop

Re: [PATCH 0/4] Add Support for GET LBA STATUS 16 command in scsi emulation

2020-06-02 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200602074201.10879-1-...@suse.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin

Re: [PATCH 0/4] Add Support for GET LBA STATUS 16 command in scsi emulation

2020-06-02 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200602074201.10879-1-...@suse.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200602074201.10879-1-...@suse.com Subject: [PATCH 0/4] Add Support for GET LBA STATUS 16 command in scsi emu

Re: [PATCH 0/4] Add Support for GET LBA STATUS 16 command in scsi emulation

2020-06-02 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200602074201.10879-1-...@suse.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash export ARCH

Re: [PATCH 0/4] Add Support for GET LBA STATUS 16 command in scsi emulation

2020-06-02 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200602074201.10879-1-...@suse.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #! /bin

Re: [PATCH 3/3] numa: Initialize node initiator with respect to .has_cpu

2020-06-02 Thread Tao Xu
On 6/1/2020 4:10 PM, Michal Privoznik wrote: On 5/29/20 5:09 PM, Igor Mammedov wrote: On Fri, 29 May 2020 15:33:48 +0200 Michal Privoznik wrote: The initiator attribute of a NUMA node is documented as the 'NUMA node that has best performance to given NUMA node'. If a NUMA node has at least

Re: [PATCH] MAINTAINERS: Volunteer for maintaining the Renesas hardware

2020-06-02 Thread Philippe Mathieu-Daudé
On 6/2/20 9:23 AM, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > >> I don't have much clue about the Renesas hardware, but at least >> I know now the source files a little bit, so I volunteer to pick >> up patches and send pull-requests for them during my scarce >> hobbyist time, un

[PATCH] virtio-blk: Disable request queuing while switching contexts

2020-06-02 Thread Sergio Lopez
Disable request queuing while switching contexts on virtio_blk_data_plane_[start|stop](), preventing requests from getting queued on the wrong context. Placing requests on the wrong context may lead to them being wrongly accessed in parallel from different threads, potentially leading to multiple

Re: [PATCH for-5.1 V4 4/4] MAINTAINERS: Add myself as Loongson-3 maintainer

2020-06-02 Thread Philippe Mathieu-Daudé
On 6/2/20 4:39 AM, Huacai Chen wrote: > Signed-off-by: Huacai Chen > Co-developed-by: Jiaxun Yang > --- > MAINTAINERS | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 0944d9c..c42a218 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1092,6 +109

Re: [PATCH v2 11/20] qapi: backup: add x-max-chunk and x-max-workers parameters

2020-06-02 Thread Vladimir Sementsov-Ogievskiy
01.06.2020 21:11, Vladimir Sementsov-Ogievskiy wrote: Add new parameters to configure future backup features. The patch doesn't introduce aio backup requests (so we actually have only one worker) neither requests larger than one cluster. Still, formally we satisfy these maximums anyway, so add th

Re: [PATCH v2 00/20] backup performance: block_status + async

2020-06-02 Thread Vladimir Sementsov-Ogievskiy
01.06.2020 21:59, no-re...@patchew.org wrote: Patchew URL: https://patchew.org/QEMU/20200601181118.579-1-vsement...@virtuozzo.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can proba

Re: [PATCH v4 2/2] vhost-user-blk: delay vhost_user_blk_disconnect

2020-06-02 Thread Dima Stepanov
On Sat, May 30, 2020 at 08:55:30PM -0400, Raphael Norwitz wrote: > On Thu, May 28, 2020 at 5:13 AM Dima Stepanov wrote: > > > > A socket write during vhost-user communication may trigger a disconnect > > event, calling vhost_user_blk_disconnect() and clearing all the > > vhost_dev structures holdi

[PATCH] numa: forbid '-numa node, mem' for 5.1 and newer machine types

2020-06-02 Thread Igor Mammedov
Deprecation period is run out and it's a time to flip the switch introduced by cd5ff8333a. Disable legacy option for new machine types (since 5.1) and amend documentation. '-numa node,memdev' shall be used instead of disabled option with new machine types. Signed-off-by: Igor Mammedov --- - re

[PATCH 0/2] mailmap: change email addresses of two contributors

2020-06-02 Thread Aleksandar Markovic
Two contributors want to switch to using their new email addresses. Aleksandar Markovic (2): mailmap: Change email address of Filip Bozuta mailmap: Change email address of Stefan Brankovic .mailmap | 2 ++ 1 file changed, 2 insertions(+) -- 2.20.1

[PATCH 1/2] mailmap: Change email address of Filip Bozuta

2020-06-02 Thread Aleksandar Markovic
Filip Buzuta wants to use his new email address for his future work in QEMU. CC: Filip Bozuta Signed-off-by: Aleksandar Markovic --- .mailmap | 1 + 1 file changed, 1 insertion(+) diff --git a/.mailmap b/.mailmap index e3628c7a66..9f2a3a55f9 100644 --- a/.mailmap +++ b/.mailmap @@ -45,6 +45,7

[PATCH 2/2] mailmap: Change email address of Stefan Brankovic

2020-06-02 Thread Aleksandar Markovic
Stefan Brankovic wants to use his new email address for his future work in QEMU. CC: Stefan Brankovic Signed-off-by: Aleksandar Markovic --- .mailmap | 1 + 1 file changed, 1 insertion(+) diff --git a/.mailmap b/.mailmap index 9f2a3a55f9..84f36592ba 100644 --- a/.mailmap +++ b/.mailmap @@ -52,

Re: [PATCH v2 9/9] target/arm: Convert Neon one-register-and-immediate insns to decodetree

2020-06-02 Thread Peter Maydell
On Tue, 2 Jun 2020 at 00:32, Richard Henderson wrote: > It might be clearer to use dup_const for each case, which would more closely > match the pseudocode. E.g. here, > > return dup_const(MO_16, imm << 8); > > > +imm |= (imm << 8) | (imm << 16) | (imm << 24); > > return dup_const

[Bug 1881729] [NEW] target_read_memory in disas.c ignores possible errors

2020-06-02 Thread Nickie S.
Public bug reported: `target_read_memory` in `disas.c` ignores (possible) errors. This leads to disassembler possibly disassembling garbage. ** Affects: qemu Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which i

Re: [PULL 00/12] migration/virtiofs/hmp queue

2020-06-02 Thread Peter Maydell
On Mon, 1 Jun 2020 at 19:43, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > The following changes since commit 7ea32024c6b3ad9c88d6200e73dbf76c8e160024: > > Merge remote-tracking branch > 'remotes/amarkovic/tags/mips-queue-june-01-2020' into staging (2020-06-01 > 1

Re: [PULL 04/12] hmp: Simplify qom-set

2020-06-02 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > "Dr. David Alan Gilbert (git)" writes: > > > From: "Dr. David Alan Gilbert" > > > > Simplify qom_set by making it use qmp_qom_set and the JSON parser. > > > > (qemu) qom-get /machine smm > > "auto" > > (qemu) qom-set /machine smm "auto" > > > > Si

Re: [PULL 00/21] Vga 20200528 patches

2020-06-02 Thread Gerd Hoffmann
Hi, > Some days I wonder whether we should just do a bulk detabify > of the QEMU sources. git & patch utils have switches to ignore whitespace changes, so I'd expect such a bulk change shouldn't be too disruptive in terms of conflicts. A one-time "git rebase --ignore-whitespace" for WIP patche

Re: [PATCH] virtiofsd: Use clone() and not unshare(), support non-root

2020-06-02 Thread Stefan Hajnoczi
On Fri, May 01, 2020 at 02:25:48PM -0400, Colin Walters wrote: > I'd like to make use of virtiofs as part of our tooling in > https://github.com/coreos/coreos-assembler > Most of the code runs as non-root today; qemu also runs as non-root. > We use 9p right now. > > virtiofsd's builtin sandboxing

Re: [PATCH RFC 01/32] python/qemu: create qemu.lib module

2020-06-02 Thread Kevin Wolf
Am 14.05.2020 um 07:53 hat John Snow geschrieben: > move python/qemu/*.py to python/qemu/lib/*.py. > > To create a namespace package, the 'qemu' directory itself shouldn't > have module files in it. Thus, these files will go under a 'lib' package > directory instead. > > Bolster the lib/__init__.

Re: [PATCH RFC 26/32] python//machine.py: use qmp.command

2020-06-02 Thread Kevin Wolf
Am 29.05.2020 um 02:18 hat John Snow geschrieben: > > [...] > > > > > -def qmp(self, cmd, conv_keys=True, **args): > > -""" > > -Invoke a QMP command and return the response dict > > -""" > > +@classmethod > > +def _qmp_args(cls, _conv_keys: bool = True, **ar

Re: [PATCH RFC 26/32] python//machine.py: use qmp.command

2020-06-02 Thread Kevin Wolf
Am 02.06.2020 um 12:18 hat Kevin Wolf geschrieben: > Am 29.05.2020 um 02:18 hat John Snow geschrieben: > > > > [...] > > > > > > > > -def qmp(self, cmd, conv_keys=True, **args): > > > -""" > > > -Invoke a QMP command and return the response dict > > > -""" > > > +

Re: [RFC v2] migration: Add migrate-set-bitmap-node-mapping

2020-06-02 Thread Max Reitz
On 18.05.20 18:26, Peter Krempa wrote: > On Wed, May 13, 2020 at 16:56:10 +0200, Max Reitz wrote: >> This command allows mapping block node names to aliases for the purpose >> of block dirty bitmap migration. >> >> This way, management tools can use different node names on the source >> and destina

Re: [PATCH RFC 03/32] python//machine.py: remove bare except

2020-06-02 Thread Kevin Wolf
Am 14.05.2020 um 07:53 hat John Snow geschrieben: > Catch only the timeout error; if there are other problems, allow the > stack trace to be visible. > > Signed-off-by: John Snow Having a visible stack trace is nice, but don't we still want to kill the qemu process to be sure that it's gone even

Re: [question] Partial sector issue while discard in qcow2 image

2020-06-02 Thread Kevin Wolf
Am 02.06.2020 um 09:45 hat Lin Ma geschrieben: > Hi all, > > During woring to add GET LBA STATUS support in qemu scsi emulation > layer, I encountered an unmap issue with qcow2 image, It's likely > about how to unmap partial clusters. e.g.: > > With these default values: > * the default value of

Re: [PATCH 1/5] block/quorum.c: stable children names

2020-06-02 Thread Alberto Garcia
On Mon 11 May 2020 02:26:54 PM CEST, Lukas Straub wrote: > If we remove the child with the highest index from the quorum, > decrement s->next_child_index. This way we get stable children > names as long as we only remove the last child. > > Signed-off-by: Lukas Straub Reviewed-by: Alberto Garcia

Re: [RFC v2] migration: Add migrate-set-bitmap-node-mapping

2020-06-02 Thread Peter Krempa
On Tue, Jun 02, 2020 at 12:56:32 +0200, Max Reitz wrote: > On 18.05.20 18:26, Peter Krempa wrote: > > On Wed, May 13, 2020 at 16:56:10 +0200, Max Reitz wrote: > >> This command allows mapping block node names to aliases for the purpose > >> of block dirty bitmap migration. > >> > >> This way, manag

Re: [PATCH RFC 01/32] python/qemu: create qemu.lib module

2020-06-02 Thread Vladimir Sementsov-Ogievskiy
26.05.2020 18:07, Philippe Mathieu-Daudé wrote: On 5/19/20 12:54 PM, Vladimir Sementsov-Ogievskiy wrote: 19.05.2020 03:27, John Snow wrote: On 5/18/20 3:33 PM, Vladimir Sementsov-Ogievskiy wrote: 18.05.2020 21:23, John Snow wrote: On 5/18/20 2:14 PM, Vladimir Sementsov-Ogievskiy wrote: 1

Re: [PATCH v5 07/11] hw/char: Initial commit of Ibex UART

2020-06-02 Thread LIU Zhiwei
On 2020/5/29 6:14, Alistair Francis wrote: This is the initial commit of the Ibex UART device. Serial TX is working, while RX has been implemeneted but untested. This is based on the documentation from: https://docs.opentitan.org/hw/ip/uart/doc/ Signed-off-by: Alistair Francis --- include

Re: [PATCH] virtio-blk: Disable request queuing while switching contexts

2020-06-02 Thread Kevin Wolf
Am 02.06.2020 um 10:11 hat Sergio Lopez geschrieben: > Disable request queuing while switching contexts on > virtio_blk_data_plane_[start|stop](), preventing requests from getting > queued on the wrong context. > > Placing requests on the wrong context may lead to them being wrongly > accessed in

[PATCH] .travis.yml: Temporarily disable the aarch64 job

2020-06-02 Thread Philippe Mathieu-Daudé
Travis-CI Aarch64 runners are currently broken, the build fails because the filesystem quota is full [1]: AR libqemuutil.a nm: qemu-sockets.o: Bad value LINKqemu-ga qga/main.o: In function `main': /home/travis/build/qemu/qemu/qga/main.c:1494: undefined reference to `socket_

Re: [PATCH] checkpatch: reversed logic with acpi test checks

2020-06-02 Thread Auger Eric
Hi, On 6/2/20 7:36 AM, Michael S. Tsirkin wrote: > Logic reversed: allowed list should just be ignored. Instead we > only take that into account :( > > Fixes: e11b06a880ca ("checkpatch: ignore allowed diff list") > Signed-off-by: Michael S. Tsirkin Fixes issues reported in "[RFC 0/6] TPM-TIS bi

Re: [PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

2020-06-02 Thread Alexey Kardashevskiy
Ping? On 13/05/2020 12:43, Alexey Kardashevskiy wrote: > The following changes since commit 83b700a441ef8303983eed16c244adde8e40e808: > > target/ppc: Fix arguments to ppc_radix64_partition_scoped_xlate() > (2020-05-11 11:44:03 +1000) > > are available in the Git repository at: > > g...@git

Re: [PATCH qemu v9] spapr: Implement Open Firmware client interface

2020-06-02 Thread Alexey Kardashevskiy
Ping? On 13/05/2020 13:58, Alexey Kardashevskiy wrote: > The PAPR platform which describes an OS environment that's presented by > a combination of a hypervisor and firmware. The features it specifies > require collaboration between the firmware and the hypervisor. > > Since the beginning, the ru

Re: [PATCH v8 2/8] block: consolidate blocksize properties consistency checks

2020-06-02 Thread Kevin Wolf
Am 29.05.2020 um 12:56 hat Roman Kagan geschrieben: > On Fri, May 29, 2020 at 11:53:26AM +0200, Markus Armbruster wrote: > > Roman Kagan writes: > > > > > Several block device properties related to blocksize configuration must > > > be in certain relationship WRT each other: physical block must b

Re: [RFC 0/6] TPM-TIS bios-tables-test

2020-06-02 Thread Auger Eric
Hi, On 6/1/20 12:21 PM, Eric Auger wrote: > This series adds the test of the TPM2 and DSDT tables when the > TPM-TIS device gets instantiated. > > The series also allows to validate changes in the TPM2 table > generation done in "[PATCH v3 0/4] vTPM/aarch64 ACPI support", > sent separately. > >

Re: [PATCH for-5.1 V4 4/4] MAINTAINERS: Add myself as Loongson-3 maintainer

2020-06-02 Thread chen huacai
On Tue, Jun 2, 2020 at 4:12 AM Philippe Mathieu-Daudé wrote: > > On 6/2/20 4:39 AM, Huacai Chen wrote: > > Signed-off-by: Huacai Chen > > Co-developed-by: Jiaxun Yang > > --- > > MAINTAINERS | 5 + > > 1 file changed, 5 insertions(+) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index

[PATCH v4] linux-user: syscall: ioctls: support DRM_IOCTL_VERSION

2020-06-02 Thread chengang
From: Chen Gang Another DRM_IOCTL_* commands will be done later. Signed-off-by: Chen Gang --- configure | 10 ++ linux-user/ioctls.h| 5 +++ linux-user/syscall.c | 67 ++ linux-user/syscall_defs.h | 15 + linux-us

Re: [PATCH v8 5/8] qdev-properties: make blocksize accept size suffixes

2020-06-02 Thread Philippe Mathieu-Daudé
On 5/29/20 12:55 AM, Roman Kagan wrote: > It appears convenient to be able to specify physical_block_size and > logical_block_size using common size suffixes. > > Teach the blocksize property setter to interpret them. Also express the > upper and lower limits in the respective units. > > Signed-

Re: [PATCH] virtio-blk: Disable request queuing while switching contexts

2020-06-02 Thread Sergio Lopez
On Tue, Jun 02, 2020 at 01:23:14PM +0200, Kevin Wolf wrote: > Am 02.06.2020 um 10:11 hat Sergio Lopez geschrieben: > > Disable request queuing while switching contexts on > > virtio_blk_data_plane_[start|stop](), preventing requests from getting > > queued on the wrong context. > > > > Placing requ

Re: [PATCH 3/5] colo: Introduce high-level test suite

2020-06-02 Thread Philippe Mathieu-Daudé
+Cleber/Wainer On 5/11/20 2:27 PM, Lukas Straub wrote: > Add high-level test relying on the colo resource-agent to test > all failover cases while checking guest network connectivity. > > Signed-off-by: Lukas Straub > --- > scripts/colo-resource-agent/crm_master | 44 ++ > scripts/colo-resou

Re: [PULL 0/1] machine queue, 2020-05-13

2020-06-02 Thread Peter Maydell
On Wed, 13 May 2020 at 15:01, Eduardo Habkost wrote: > > The following changes since commit de2f658b6bb422ec0e0fa94a49e476018602eeea: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20200511' into staging (2020-05-11 > 14:34:27 +0100) > > are available in the Git repo

Re: [PATCH v5 07/11] hw/char: Initial commit of Ibex UART

2020-06-02 Thread LIU Zhiwei
Hi Alistair, There are still some questions I don't understand. 1. Is the baud rate  or fifo a necessary feature to simulate? As you can see, qemu_chr_fe_write will send the byte as soon as possible. When you want to transmit a byte through WDATA,  you can call qemu_chr_fe_write directly. 2. 

[PATCH 5/5] linux-user: Add strace support for printing arguments of fallocate()

2020-06-02 Thread Filip Bozuta
From: Filip Bozuta This patch implements strace argument printing functionality for following syscall: *fallocate - manipulate file space int fallocate(int fd, int mode, off_t offset, off_t len) man page: https://www.man7.org/linux/man-pages/man2/fallocate.2.html Implement

Re: [PATCH 1/2] mailmap: Change email address of Filip Bozuta

2020-06-02 Thread Filip Bozuta
On 2.6.20. 10:52, Aleksandar Markovic wrote: > Filip Buzuta wants to use his new email address for his future > work in QEMU. > > CC: Filip Bozuta > Signed-off-by: Aleksandar Markovic Reviewed-by: Filip Bozuta > --- > .mailmap | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/.mailmap

[PATCH 2/5] linux-user: Add strace support for printing argument of syscalls used for extend attributes

2020-06-02 Thread Filip Bozuta
From: Filip Bozuta This patch implements strace argument printing functionality for following syscalls: *getxattr, lgetxattr, fgetxattr - retrieve an extended attribute value ssize_t getxattr(const char *path, const char *name, void *value, size_t size) ssize_t lgetxattr(c

[PATCH 3/5] linux-user: Add strace support for printing arguments of lseek()

2020-06-02 Thread Filip Bozuta
From: Filip Bozuta This patch implements strace argument printing functionality for syscall: *lseek - reposition read/write file offset off_t lseek(int fd, off_t offset, int whence) man page: https://www.man7.org/linux/man-pages/man2/lseek.2.html Implementation notes:

Re: [PATCH 2/2] mailmap: Change email address of Stefan Brankovic

2020-06-02 Thread Stefan Brankovic
On 2.6.20. 10:52, Aleksandar Markovic wrote: Stefan Brankovic wants to use his new email address for his future work in QEMU. CC: Stefan Brankovic Signed-off-by: Aleksandar Markovic Reviewed-by: Stefan Brankovic --- .mailmap | 1 + 1 file changed, 1 insertion(+) diff --git a/.mailmap

Re: [PATCH] virtio-blk: Disable request queuing while switching contexts

2020-06-02 Thread Kevin Wolf
Am 02.06.2020 um 14:18 hat Sergio Lopez geschrieben: > On Tue, Jun 02, 2020 at 01:23:14PM +0200, Kevin Wolf wrote: > > Am 02.06.2020 um 10:11 hat Sergio Lopez geschrieben: > > > Disable request queuing while switching contexts on > > > virtio_blk_data_plane_[start|stop](), preventing requests from

[PATCH 0/5] Add strace support for printing arguments of selected syscalls

2020-06-02 Thread Filip Bozuta
From: Filip Bozuta This series covers strace support for printing arguments of following syscalls: *acct() *lgetxattr()*lseek() *fsync()*fgetxattr()*chown() *fdatasync()*listxattr()*lchown() *listen() *llistxattr() *fallocat

[PATCH 1/5] linux-user: Add strace support for a group of syscalls

2020-06-02 Thread Filip Bozuta
From: Filip Bozuta This patch implements strace argument printing functionality for following syscalls: *acct - switch process accounting on or off int acct(const char *filename) man page: https://www.man7.org/linux/man-pages/man2/acct.2.html *fsync, fdatasync - synchr

[PATCH 4/5] linux-user: Add strace support for printing arguments of chown()/lchown()

2020-06-02 Thread Filip Bozuta
From: Filip Bozuta This patch implements strace argument printing functionality for syscalls: *chown, lchown - change ownership of a file int chown(const char *pathname, uid_t owner, gid_t group) int lchown(const char *pathname, uid_t owner, gid_t group) man page: ht

what is the symbole "leul" mean on this code?

2020-06-02 Thread tugouxp
HI guys: i am stucked by the following code,and i can find document illustrations this nowhere. what does the "leul" stands for? and the postfix 10 means what? thank you! 10 6001 11 movi_i32 tmp3,$0x60010020pref=all 12 mo

Re: what is the symbole "leul" mean on this code?

2020-06-02 Thread Laurent Desnogues
On Tue, Jun 2, 2020 at 3:13 PM tugouxp <13824125...@163.com> wrote: > > HI guys: >i am stucked by the following code,and i can find document illustrations > this nowhere. >what does the "leul" stands for? and the postfix 10 means what? That should be little-endian unsigned long (where lon

Re: Sam460Ex screen mode, audio and network

2020-06-02 Thread BALATON Zoltan
Hello, On Tue, 2 Jun 2020, Philippe Mathieu-Daudé wrote: Cc'ing the sam460ex maintainer. On 6/1/20 8:01 PM, Andrea Palmatè wrote: Hello, i've successfully configured AmigaOS4 on Qemu 5 and i've installed it without any problem. I assume you're aware of this page where you may find info and an

Re: [PATCH v3 0/2] fuzz: Skip QTest serialization

2020-06-02 Thread Darren Kenny
Hi Alex, In general the series looks good, so: Reviewed-by: Darren Kenny But not sure how to handle the patchew output though, not sure if it is really a concern or not, since do/while won't work that context. Thanks, Darren. On Friday, 2020-05-29 at 18:14:48 -04, Alexander Bulekov wrote:

Re: [PATCH v3 1/4] acpi: Convert build_tpm2() to build_append* API

2020-06-02 Thread Stefan Berger
On 6/1/20 5:57 AM, Eric Auger wrote: In preparation of its move to the generic acpi code, let's convert build_tpm2() to use build_append API. This latter now is prefered in place of direct ACPI struct field settings with manual endianness conversion. Signed-off-by: Eric Auger --- hw/i386/acpi

Re: [PATCH v6 02/12] monitor: Use getter/setter functions for cur_mon

2020-06-02 Thread Kevin Wolf
Am 28.05.2020 um 20:31 hat Eric Blake geschrieben: > On 5/28/20 10:37 AM, Kevin Wolf wrote: > > cur_mon really needs to be coroutine-local as soon as we move monitor > > command handlers to coroutines and let them yield. As a first step, just > > remove all direct accesses to cur_mon so that we can

Re: [RFC 4/6] tests: tpm-emu: Remove assert on TPM2_ST_NO_SESSIONS

2020-06-02 Thread Stefan Berger
On 6/1/20 6:21 AM, Eric Auger wrote: While writing tests for checking the content of TPM2 and DSDT along with TPM-TIS instantiation I attempted to reuse the framework used for TPM-TIS tests. However While dumping the ACPI tables I get an assert on TPM2_ST_NO_SESSIONS. My assumption is maybe the o

Re: [PATCH v4] linux-user: syscall: ioctls: support DRM_IOCTL_VERSION

2020-06-02 Thread Laurent Vivier
Le 02/06/2020 à 14:00, cheng...@emindsoft.com.cn a écrit : > From: Chen Gang > > Another DRM_IOCTL_* commands will be done later. > > Signed-off-by: Chen Gang > --- > configure | 10 ++ > linux-user/ioctls.h| 5 +++ > linux-user/syscall.c | 67 ++

Re: [PATCH v3 0/2] fuzz: Skip QTest serialization

2020-06-02 Thread Alexander Bulekov
Thank you Darren. On 200602 1428, Darren Kenny wrote: > > Hi Alex, > > In general the series looks good, so: > > Reviewed-by: Darren Kenny > > But not sure how to handle the patchew output though, not sure if it is > really a concern or not, since do/while won't work that context. > Yes - I

Re: [PATCH 0/5] Add strace support for printing arguments of selected syscalls

2020-06-02 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200602115331.1659-1-filip.boz...@syrmia.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200602115331.1659-1-filip.boz...@syrmia.com Subject: [PATCH 0/5] Add strace support for printing

[PATCH] docs/system: Document Aspeed boards

2020-06-02 Thread Cédric Le Goater
Signed-off-by: Cédric Le Goater --- docs/system/arm/aspeed.rst | 85 ++ docs/system/target-arm.rst | 1 + 2 files changed, 86 insertions(+) create mode 100644 docs/system/arm/aspeed.rst diff --git a/docs/system/arm/aspeed.rst b/docs/system/arm/aspeed.rst new

Re: [PATCH v3 1/4] acpi: Convert build_tpm2() to build_append* API

2020-06-02 Thread Auger Eric
Hi Stefan, On 6/2/20 3:30 PM, Stefan Berger wrote: > On 6/1/20 5:57 AM, Eric Auger wrote: >> In preparation of its move to the generic acpi code, >> let's convert build_tpm2() to use build_append API. This >> latter now is prefered in place of direct ACPI struct field >> settings with manual endian

Re: [RFC 2/6] tests/acpi: Add void tables for Q35/TPM-TIS bios-tables-test

2020-06-02 Thread Stefan Berger
On 6/1/20 6:21 AM, Eric Auger wrote: Add placeholders for TPM and DSDT reference tables for Q35 TPM-TIS tests. Signed-off-by: Eric Auger Reviewed-by: Stefan Berger --- tests/data/acpi/q35/DSDT.tis | Bin tests/data/acpi/q35/TPM2.tis | Bin 2 files changed, 0 insertions(+), 0 deletions

Re: [RFC 1/6] test/tpm-emu: include sockets and channel headers in tpm-emu header

2020-06-02 Thread Stefan Berger
On 6/1/20 6:21 AM, Eric Auger wrote: Include sockets and channel headers to that the header is self-contained. Signed-off-by: Eric Auger Reviewed-by: Stefan Berger --- tests/qtest/tpm-emu.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/qtest/tpm-emu.h b/tests/qtest/tpm-e

Re: [RFC 3/6] tests/acpi: Ignore TPM2.tis and DSDT.tis

2020-06-02 Thread Stefan Berger
On 6/1/20 6:21 AM, Eric Auger wrote: Subsequent patches will alter the content of TPM2.tis and DSDT.tis so let's ignore them until the references are generated. Signed-off-by: Eric Auger Reviewed-by: Stefan Berger --- tests/qtest/bios-tables-test-allowed-diff.h | 2 ++ 1 file changed,

Re: [PATCH v4] linux-user: syscall: ioctls: support DRM_IOCTL_VERSION

2020-06-02 Thread Chen Gang
On 2020/6/2 下午9:40, Laurent Vivier wrote: >> +static inline abi_long target_to_host_drmversion(struct drm_version >> *host_ver, >> +abi_long target_addr) >> +{ >> +struct target_drm_version *target_ver; >> + >> +if (!lock_user_struct(VERIFY_R

Re: [PATCH v3 1/4] acpi: Convert build_tpm2() to build_append* API

2020-06-02 Thread Stefan Berger
On 6/2/20 9:55 AM, Auger Eric wrote: Hi Stefan, On 6/2/20 3:30 PM, Stefan Berger wrote: On 6/1/20 5:57 AM, Eric Auger wrote: In preparation of its move to the generic acpi code, let's convert build_tpm2() to use build_append API. This latter now is prefered in place of direct ACPI struct field

Re: [PATCH 2/8] decodetree: Tidy error_with_file

2020-06-02 Thread Peter Maydell
On Mon, 18 May 2020 at 17:40, Richard Henderson wrote: > > Use proper varargs to print the arguments. > > Signed-off-by: Richard Henderson > --- > scripts/decodetree.py | 24 ++-- > 1 file changed, 14 insertions(+), 10 deletions(-) Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH 5/8] decodetree: Allow group covering the entire insn space

2020-06-02 Thread Peter Maydell
On Mon, 18 May 2020 at 17:41, Richard Henderson wrote: > > This is an edge case for sure, but the logic that disallowed > this case was faulty. Further, a few fixes scattered about > can allow this to work. > > Signed-off-by: Richard Henderson > --- > ...est1.decode => succ_pattern_group_nest2.

Re: [RFC 6/6] bios-tables-test: Generate reference tables for Q35/TPM-TIS

2020-06-02 Thread Stefan Berger
On 6/1/20 6:21 AM, Eric Auger wrote: TPM2, DSDT tables were generated using tests/data/acpi/rebuild-expected-aml.sh Signed-off-by: Eric Auger Reviewed-by: Stefan Berger --- tests/qtest/bios-tables-test-allowed-diff.h | 2 -- tests/data/acpi/q35/DSDT.tis| Bin 0 -> 8468

Re: [RFC 5/6] bios-tables-test: Add Q35/TPM-TIS test

2020-06-02 Thread Stefan Berger
On 6/1/20 6:21 AM, Eric Auger wrote: Test tables specific to the TPM-TIS instantiation. The TPM2 is added in the framework. Also the DSDT is updated with the TPM. The new function should be be usable for CRB as well, later one. Signed-off-by: Eric Auger --- tests/qtest/bios-tables-test.c | 60

Re: [RFC 4/6] tests: tpm-emu: Remove assert on TPM2_ST_NO_SESSIONS

2020-06-02 Thread Stefan Berger
On 6/2/20 9:39 AM, Stefan Berger wrote: On 6/1/20 6:21 AM, Eric Auger wrote: While writing tests for checking the content of TPM2 and DSDT along with TPM-TIS instantiation I attempted to reuse the framework used for TPM-TIS tests. However While dumping the ACPI tables I get an assert on TPM2_ST_

Re: [PATCH for-4.2 v2 3/3] block/file-posix: Let post-EOF fallocate serialize

2020-06-02 Thread Vladimir Sementsov-Ogievskiy
01.11.2019 18:25, Max Reitz wrote: Sorry for being late, I have some comments The XFS kernel driver has a bug that may cause data corruption for qcow2 images as of qemu commit c8bb23cbdbe32f. We can work around it by treating post-EOF fallocates as serializing up until infinity (INT64_MAX in p

Re: [PATCH v4 00/13] user-mode: Prune build dependencies (part 1)

2020-06-02 Thread Philippe Mathieu-Daudé
This series is now fully reviewed. Laurent, as Paolo's misc-tree is already full, can it go via your linux-user tree (as it improve linux-user at the end)? Thanks, Phil. On 5/22/20 7:24 PM, Philippe Mathieu-Daudé wrote: > This is the first part of a series reducing user-mode > dependencies. By

Re: [PATCH] virtio-blk: Disable request queuing while switching contexts

2020-06-02 Thread Sergio Lopez
On Tue, Jun 02, 2020 at 03:04:33PM +0200, Kevin Wolf wrote: > Am 02.06.2020 um 14:18 hat Sergio Lopez geschrieben: > > On Tue, Jun 02, 2020 at 01:23:14PM +0200, Kevin Wolf wrote: > > > Am 02.06.2020 um 10:11 hat Sergio Lopez geschrieben: > > > > Disable request queuing while switching contexts on >

Re: Sam460Ex screen mode, audio and network

2020-06-02 Thread BALATON Zoltan
On Tue, 2 Jun 2020, BALATON Zoltan wrote: On Tue, 2 Jun 2020, Philippe Mathieu-Daudé wrote: Cc'ing the sam460ex maintainer. On 6/1/20 8:01 PM, Andrea Palmatè wrote: It is working on an i5 laptop. I've tried to use the native screen mode 1366x768 but it has some problems. It seems a stride probl

Re: [PATCH] docs/system: Document Aspeed boards

2020-06-02 Thread Philippe Mathieu-Daudé
On 6/2/20 3:50 PM, Cédric Le Goater wrote: > Signed-off-by: Cédric Le Goater > --- > docs/system/arm/aspeed.rst | 85 ++ > docs/system/target-arm.rst | 1 + > 2 files changed, 86 insertions(+) > create mode 100644 docs/system/arm/aspeed.rst > > diff --git a/

Re: RFC: use VFIO over a UNIX domain socket to implement device offloading

2020-06-02 Thread Alex Williamson
On Wed, 20 May 2020 17:45:13 -0700 John G Johnson wrote: > > I'm confused by VFIO_USER_ADD_MEMORY_REGION vs VFIO_USER_IOMMU_MAP_DMA. > > The former seems intended to provide the server with access to the > > entire GPA space, while the latter indicates an IOVA to GPA mapping of > > those regions.

Re: [PATCH 5/8] decodetree: Allow group covering the entire insn space

2020-06-02 Thread Richard Henderson
On 6/2/20 7:35 AM, Peter Maydell wrote: > On Mon, 18 May 2020 at 17:41, Richard Henderson > wrote: >> >> This is an edge case for sure, but the logic that disallowed >> this case was faulty. Further, a few fixes scattered about >> can allow this to work. >> >> Signed-off-by: Richard Henderson >>

Re: [PATCH v3 1/4] acpi: Convert build_tpm2() to build_append* API

2020-06-02 Thread Auger Eric
Hi Stefan, On 6/2/20 4:24 PM, Stefan Berger wrote: > On 6/2/20 9:55 AM, Auger Eric wrote: >> Hi Stefan, >> On 6/2/20 3:30 PM, Stefan Berger wrote: >>> On 6/1/20 5:57 AM, Eric Auger wrote: In preparation of its move to the generic acpi code, let's convert build_tpm2() to use build_append

[PULL 1/2] target/m68k: implement fmove.l #,FPCR

2020-06-02 Thread Laurent Vivier
The immediate value mode was ignored and instruction execution ends to an invalid access mode. This was found running 'R' that set FPSR to 0 at startup with a 'fmove.l #0,FPSR' in qemu-system-m68k emulation and triggers a kernel crash: [ 56.64] *** ADDRESS ERROR *** FORMAT=2 [ 56.64

[PULL 0/2] M68k for 5.1 patches

2020-06-02 Thread Laurent Vivier
The following changes since commit 853a60b87024b2f5d7c0c54a432d7798cb679900: Merge remote-tracking branch 'remotes/dgilbert/tags/pull-migration-20200601a' into staging (2020-06-01 21:34:47 +0100) are available in the Git repository at: git://github.com/vivier/qemu-m68k.git tags/m68k-for-5.1

  1   2   3   4   >