Patchew URL: https://patchew.org/QEMU/20200518051945.8621-1-arm...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20200518051945.8621-1-arm...@redhat.com
Subject: [PATCH not-for-merge 0/5] Instrumentation for "Fixes arou
On Mon, May 18, 2020 at 06:59:01AM +0200, Markus Armbruster wrote:
> Gerd Hoffmann writes:
>
> > On Fri, May 15, 2020 at 09:06:20AM +0200, Markus Armbruster wrote:
> >> Watch this:
> >>
> >> $ aarch64-softmmu/qemu-system-aarch64 -S -nodefaults -accel qtest
> >> -display none -M vexpress-a15
Patchew URL: https://patchew.org/QEMU/20200518051945.8621-1-arm...@redhat.com/
Hi,
This series failed the asan build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#!/bin/bash
export
Patchew URL:
https://patchew.org/QEMU/1589782398-24406-1-git-send-email-kwankh...@nvidia.com/
Hi,
This series failed the docker-quick@centos7 build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCR
On 16.05.20 13:35, Philippe Mathieu-Daudé wrote:
> +David (virtio-balloon maintainer)
>
> On Mon, May 11, 2020 at 6:42 AM Alexander Bulekov wrote:
>>
>> Hello,
>> While fuzzing, I found an input that triggers a null-ptr dereference in
>> aio_bh_enqueue, through virtio-balloon. Based on the stackt
Patchew URL:
https://patchew.org/QEMU/1589782398-24406-1-git-send-email-kwankh...@nvidia.com/
Hi,
This series failed the docker-mingw@fedora build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRI
The '\n' sneaked in by accident here, an "id" string should really
not contain a newline character at the end.
Fixes: 78cd6f7bf6b ('net: Add a new convenience option "--nic" ...')
Signed-off-by: Thomas Huth
---
net/net.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/net
On Fri, 15 May 2020 17:15:15 +0200
Cornelia Huck wrote:
> The documentation for the s390x system emulation target still has quite
> a bit of room for improvement, so I started adding some device documentation.
>
> v1->v2:
> - css.rst: added example for cssid == 0 (Thomas)
> - css.rst: mention wh
Add a basic example for passing a dasd via vfio-ccw.
Signed-off-by: Cornelia Huck
---
v2->v3: moved uuid generation (Thomas)
---
docs/system/s390x/vfio-ccw.rst | 77 ++
docs/system/target-s390x.rst | 1 +
2 files changed, 78 insertions(+)
create mode 100644
On 5/18/20 9:43 AM, Thomas Huth wrote:
The '\n' sneaked in by accident here, an "id" string should really
not contain a newline character at the end.
Fixes: 78cd6f7bf6b ('net: Add a new convenience option "--nic" ...')
Signed-off-by: Thomas Huth
---
net/net.c | 2 +-
1 file changed, 1 insert
Hi Jason,
On 5/18/20 5:34 AM, Jason Wang wrote:
On 2020/5/11 下午12:21, Alexander Bulekov wrote:
On 200511 1204, Jason Wang wrote:
The sender of packet will be checked in the qemu_net_queue_purge() but
we use NetClientState not its peer when trying to purge the incoming
queue in qemu_flush_or_pu
Le 5/18/20 à 7:04 AM, Markus Armbruster a écrit :
leon3_generic_hw_init() creates a "grlib,ahbpnp" and a "grlib,apbpnp"
sysbus device in a way that leaves them unplugged.
Create them the common way that puts them into the main system bus.
Affects machine leon3_generic. Visible in "info qtree
Hi Geert,
I have queued this v7 patch set in an immutable branch for testing and also
merged to my "devel" branch for testing.
If all goes well it also hits linux-next soon.
Yours,
Linus Walleij
Gerd Hoffmann writes:
> On Mon, May 18, 2020 at 06:59:01AM +0200, Markus Armbruster wrote:
>> Gerd Hoffmann writes:
>>
>> > On Fri, May 15, 2020 at 09:06:20AM +0200, Markus Armbruster wrote:
>> >> Watch this:
>> >>
>> >> $ aarch64-softmmu/qemu-system-aarch64 -S -nodefaults -accel qtest
>>
Le 5/18/20 à 7:03 AM, Markus Armbruster a écrit :
xlnx_dp_init() creates these two devices, but they're never realized.
Affects machine xlnx-zcu102.
I wonder how this ever worked. If the "device becomes real only on
realize" thing actually works, then we've always been missing these
two devi
On Mon, May 11, 2020 at 4:53 PM Geert Uytterhoeven
wrote:
> Currently a GPIO lookup table can only refer to a specific GPIO by a
> tuple, consisting of a GPIO controller label and a GPIO offset inside
> the controller.
>
> However, a GPIO may also carry a line name, defined by DT or ACPI.
> If pr
I apologize for not understanding this bug was a security issue, and not
insisting on it.
It has been fixed in SLiRP by "Fix use-afte-free in ip_reass() (CVE-2020-1983)":
https://gitlab.freedesktop.org/slirp/libslirp/commit/9bd6c591
And in QEMU by commit 7769c23774 "slirp: update to fix CVE-2020-
Fixed in QEMU release v5.0.0
** Changed in: qemu
Status: New => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1837094
Title:
UndefinedBehaviorSanitizer crash around slirp::ip_r
The implementation could be similar to the temperature sensor interface
proposed here:
https://www.mail-archive.com/qemu-block@nongnu.org/msg65192.html
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1
** Changed in: qemu
Importance: Undecided => Wishlist
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1874678
Title:
[Feature request] python-qemu package
Status in QEMU:
New
Bug description:
** Changed in: qemu
Importance: Undecided => Wishlist
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1874674
Title:
[Feature request] acceptance test class to run user-mode binaries
Status in QE
** Changed in: qemu
Importance: Undecided => Wishlist
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1874676
Title:
[Feature request] MDIO bus
Status in QEMU:
New
Bug description:
Various n
Our configure script does not look for clang++ automatically, so we
should use --cxx=clang++ to make sure that we test our C++ code with
Clang, too. And while we're at it, also use --host-cc=clang here
to avoid that we use the normal "cc" as host C compiler.
Signed-off-by: Thomas Huth
---
.travi
Our configure script does not look for clang++ automatically, so we
should use --cxx=clang++ to make sure that we test our C++ code with
Clang, too. And while we're at it, also use --host-cc=clang here
to avoid that we use the normal "cc" as host C compiler.
Signed-off-by: Thomas Huth
---
.travi
Some fixes for VIRTIO_BALLOON_F_FREE_PAGE_HINT. First issue was reported by
Alexander Bulekov [1], the other ones were discovered by me when digging
into the details.
[1] https://lkml.kernel.org/r/20200511044121.eihns2tdimdzg...@mozz.bu.edu
David Hildenbrand (3):
virtio-balloon: fix free page h
On 5/16/20 12:20 AM, Collin Walling wrote:
> The SCCB must be checked for a sufficient length before it is filled
> with any data. If the length is insufficient, then the SCLP command
> is suppressed and the proper response code is set in the SCCB header.
>
> Fixes: 832be0d8a3bb ("s390x: sclp: Rep
In case we don't have an iothread, we mark the feature as abscent but
still add the queue. 'free_page_bh' remains set to NULL.
qemu-system-i386 \
-M microvm \
-nographic \
-device virtio-balloon-device,free-page-hint=true \
-nographic \
-display none \
We took a reference when realizing, so let's drop that reference when
unrealizing.
Fixes: c13c4153f76d ("virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT")
Cc: Wei Wang
Cc: Alexander Duyck
Cc: Michael S. Tsirkin
Cc: Philippe Mathieu-Daudé
Signed-off-by: David Hildenbrand
---
hw/virtio/virtio-
Checking against guest features is wrong. We allocated data structures
based on host features. We can rely on "free_page_bh" as an indicator
whether to un-do stuff instead.
Fixes: c13c4153f76d ("virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT")
Cc: Wei Wang
Cc: Michael S. Tsirkin
Cc: Philippe Ma
On 16.05.20 00:20, Collin Walling wrote:
> Functions within read scp/cpu info will need access to the machine
> state. Let's make a call to retrieve the machine state once and
> pass the appropriate data to the respective functions.
>
> Signed-off-by: Collin Walling
> ---
> hw/s390x/sclp.c | 8 +
On 2020/5/18 下午4:00, Philippe Mathieu-Daudé wrote:
Hi Jason,
On 5/18/20 5:34 AM, Jason Wang wrote:
On 2020/5/11 下午12:21, Alexander Bulekov wrote:
On 200511 1204, Jason Wang wrote:
The sender of packet will be checked in the qemu_net_queue_purge() but
we use NetClientState not its peer when
On Mon, 18 May 2020 07:03:55 +0200
Markus Armbruster wrote:
> The number of stacks is controlled by property "num-stacks".
> pnv_pec_instance_init() creates the maximum supported number, because
> the property has not been set then. pnv_pec_realize() realizes only
> the wanted number. Works, al
On 5/16/20 12:20 AM, Collin Walling wrote:
> Rework the SCLP boundary check to account for different SCLP commands
> (eventually) allowing different boundary sizes.
>
> Move the length check code into a separate function, and introduce a
> new function to determine the length of the read SCP data
On 5/18/20 7:03 AM, Markus Armbruster wrote:
We plug aux-to-i2c-bridge into the aux-bus, even though its
DeviceClass member bus_type is null, not TYPE_AUX_BUS. Fix that by
deriving it from TYPE_AUX_SLAVE instead of TYPE_DEVICE.
Cc: KONRAD Frederic
Signed-off-by: Markus Armbruster
---
hw/mis
On 5/18/20 7:03 AM, Markus Armbruster wrote:
object_property_set_bool(OBJECT(dev), true, "realized", ...) right
after qdev_init_nofail(dev) does nothing, because qdev_init_nofail()
already realizes. Drop.
Cc: BALATON Zoltan
Signed-off-by: Markus Armbruster
---
hw/ppc/ppc440_uc.c | 2 --
1
On 5/18/20 7:03 AM, Markus Armbruster wrote:
The devices we plug into the macio-bus are all sysbus devices
(DeviceClass member bus_type is TYPE_SYSTEM_BUS), but macio-bus does
not derive from TYPE_SYSTEM_BUS. Fix that.
"info qtree" now shows the devices' mmio ranges, as it should
Cc: Mark Cave
On 5/16/20 12:20 AM, Collin Walling wrote:
> As more features and facilities are added to the Read SCP Info (RSCPI)
> response, more space is required to store them. The space used to store
> these new features intrudes on the space originally used to store CPU
> entries. This means as more feature
Hi
On Mon, May 18, 2020 at 3:37 AM Raphael Norwitz
wrote:
> Hey Marc-Andre,
>
> I'm working on a patchset with changes to libvhost-user. I'm hitting the
> following checkpatch error:
>
> Checking 0011-Lift-max-ram-slots-limit-in-libvhost-user.patch...
> WARNING: architecture specific defines sho
On 5/18/20 7:04 AM, Markus Armbruster wrote:
Device "riscv.sifive.e.soc" is a direct subtype of TYPE_DEVICE, but
its instance struct SiFiveESoCState's member @parent_obj is
SysBusDevice instead of DeviceState. Correct that.
Same for "riscv.sifive.u.soc"'s instance struct SiFiveUSoCState.
Cc: P
On 5/18/20 7:04 AM, Markus Armbruster wrote:
leon3_generic_hw_init() creates a "grlib,ahbpnp" and a "grlib,apbpnp"
sysbus device in a way that leaves them unplugged.
Create them the common way that puts them into the main system bus.
Affects machine leon3_generic. Visible in "info qtree":
On 5/18/20 7:04 AM, Markus Armbruster wrote:
This would have caught some of the bugs I just fixed.
Signed-off-by: Markus Armbruster
---
hw/core/qdev.c | 16
1 file changed, 16 insertions(+)
diff --git a/hw/core/qdev.c b/hw/core/qdev.c
index 0df995eb94..fe2dea8968 100644
---
On 5/18/20 10:33 AM, Thomas Huth wrote:
Our configure script does not look for clang++ automatically, so we
should use --cxx=clang++ to make sure that we test our C++ code with
Clang, too. And while we're at it, also use --host-cc=clang here
to avoid that we use the normal "cc" as host C compiler
On 5/18/20 10:37 AM, David Hildenbrand wrote:
In case we don't have an iothread, we mark the feature as abscent but
still add the queue. 'free_page_bh' remains set to NULL.
qemu-system-i386 \
-M microvm \
-nographic \
-device virtio-balloon-device,free-page-hint=true \
On 5/18/20 10:37 AM, David Hildenbrand wrote:
We took a reference when realizing, so let's drop that reference when
unrealizing.
Fixes: c13c4153f76d ("virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT")
Cc: Wei Wang
Cc: Alexander Duyck
Cc: Michael S. Tsirkin
Cc: Philippe Mathieu-Daudé
Signed-o
On 5/18/20 10:37 AM, David Hildenbrand wrote:
Checking against guest features is wrong. We allocated data structures
based on host features. We can rely on "free_page_bh" as an indicator
whether to un-do stuff instead.
Fixes: c13c4153f76d ("virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT")
Cc: W
On 5/18/20 10:37 AM, David Hildenbrand wrote:
Some fixes for VIRTIO_BALLOON_F_FREE_PAGE_HINT. First issue was reported by
Alexander Bulekov [1], the other ones were discovered by me when digging
into the details.
[1] https://lkml.kernel.org/r/20200511044121.eihns2tdimdzg...@mozz.bu.edu
David Hi
Hi Linus,
On Mon, May 18, 2020 at 10:17 AM Linus Walleij wrote:
> I have queued this v7 patch set in an immutable branch for testing and also
> merged to my "devel" branch for testing.
>
> If all goes well it also hits linux-next soon.
Thank a lot!
Back to the QEMU side...
Gr{oetje,eeting}s,
On Sat, May 16, 2020 at 11:20:03AM +0800, Li Feng wrote:
> Hi, Dima.
> This abort is what I have mentioned in my previous email.
Yes, i understood it and this abort() message was fixed by the previous
patch. But since we try new postphone approach this patch isn't working
and we need to get the dev
> -Original Message-
> From: Lukas Straub
> Sent: Friday, May 15, 2020 7:11 PM
> To: qemu-devel
> Cc: Zhang, Chen ; Li Zhijian
> ; Jason Wang ; Marc-
> André Lureau ; Paolo Bonzini
>
> Subject: [PATCH v5 0/6] colo-compare bugfixes
>
> Hello Everyone,
> Here are fixes for bugs that I
On Mon, May 18, 2020 at 10:52:08AM +0800, Jason Wang wrote:
>
> On 2020/5/16 上午11:20, Li Feng wrote:
> >Hi, Dima.
> >This abort is what I have mentioned in my previous email.
> >I have triggered this crash without any fix a week ago.
> >And I have written a test patch to let vhost_log_global_start
On 18.05.20 11:20, Philippe Mathieu-Daudé wrote:
> On 5/18/20 10:37 AM, David Hildenbrand wrote:
>> Some fixes for VIRTIO_BALLOON_F_FREE_PAGE_HINT. First issue was reported by
>> Alexander Bulekov [1], the other ones were discovered by me when digging
>> into the details.
>>
>> [1] https://lkml.ker
> -Original Message-
> From: Lukas Straub
> Sent: Monday, May 11, 2020 8:27 PM
> To: qemu-devel
> Cc: Alberto Garcia ; Dr. David Alan Gilbert
> ; Zhang, Chen
> Subject: [PATCH 0/5] colo: Introduce resource agent and test suite/CI
>
> Hello Everyone,
> These patches introduce a resour
On Mon, May 18, 2020 at 10:50:39AM +0800, Jason Wang wrote:
>
> On 2020/5/16 上午12:54, Dima Stepanov wrote:
> >On Thu, May 14, 2020 at 03:34:24PM +0800, Jason Wang wrote:
> >>On 2020/5/13 下午5:47, Dima Stepanov wrote:
> > case CHR_EVENT_CLOSED:
> > /* a close event may happen dur
On Sun, 17 May 2020 at 17:48, Philippe Mathieu-Daudé wrote:
>
> Various places ignore the MemTxResult indicator of
> transaction failed. Some cases might be justified
> (DMA?) while other are probably bugs. To avoid
> ignoring transaction errors, suggestion is to mark
> functions returning MemTxRe
hw_error() calls exit(). This a bit overkill when we can log
the accesses as unimplemented or guest error.
When fuzzing the devices, we don't want the whole process to
exit. Replace some hw_error() calls by qemu_log_mask().
Signed-off-by: Philippe Mathieu-Daudé
---
hw/m68k/mcf5206.c | 7 +
On Sat, May 16, 2020 at 02:42:47PM +, Victor Lavaud via wrote:
>
>
>
> Sent with ProtonMail Secure Email.
>
> From 207a1a34accdc5b563d29484292829a4193c35f8 Mon Sep 17 00:00:00 2001
> From: Victor Lavaud
> Date: Sat, 16 May 2020 16:33:00 +0200
> Subject: [PATCH] Fix missing Exec field in q
When fuzzing the devices, we don't want the whole process to
exit calling hw_error().
Replace these calls by qemu_log_mask LOG_GUEST_ERROR/LOG_UNIMP
when possible.
Philippe Mathieu-Daudé (4):
hw/arm/integratorcp: Replace hw_error() by qemu_log_mask()
hw/arm/pxa2xx: Replace hw_error() by qemu_l
hw_error() calls exit(). This a bit overkill when we can log
the accesses as unimplemented or guest error.
When fuzzing the devices, we don't want the whole process to
exit. Replace some hw_error() calls by qemu_log_mask().
Signed-off-by: Philippe Mathieu-Daudé
---
hw/arm/pxa2xx_gpio.c| 7
hw_error() calls exit(). This a bit overkill when we can log
the accesses as unimplemented or guest error.
When fuzzing the devices, we don't want the whole process to
exit. Replace some hw_error() calls by qemu_log_mask().
Signed-off-by: Philippe Mathieu-Daudé
---
hw/arm/integratorcp.c | 23 ++
hw_error() calls exit(). This a bit overkill when we can log
the accesses as unimplemented or guest error.
When fuzzing the devices, we don't want the whole process to
exit. Replace some hw_error() calls by qemu_log_mask().
Signed-off-by: Philippe Mathieu-Daudé
---
hw/char/xilinx_uartlite.c | 5
hw_error() calls exit(). This a bit overkill when we can log
the accesses as unimplemented or guest error.
When fuzzing the devices, we don't want the whole process to
exit. Replace some hw_error() calls by qemu_log_mask().
Signed-off-by: Philippe Mathieu-Daudé
---
hw/timer/exynos4210_mct.c | 1
* Dima Stepanov (dimas...@yandex-team.ru) wrote:
> On Mon, May 18, 2020 at 10:50:39AM +0800, Jason Wang wrote:
> >
> > On 2020/5/16 上午12:54, Dima Stepanov wrote:
> > >On Thu, May 14, 2020 at 03:34:24PM +0800, Jason Wang wrote:
> > >>On 2020/5/13 下午5:47, Dima Stepanov wrote:
> > > case CHR_
On Mon, May 18, 2020 at 07:03:46AM +0200, Markus Armbruster wrote:
> xlnx_dp_init() creates these two devices, but they're never realized.
> Affects machine xlnx-zcu102.
>
> I wonder how this ever worked. If the "device becomes real only on
> realize" thing actually works, then we've always been
On Mon, May 18, 2020 at 11:52:02AM +0200, Philippe Mathieu-Daudé wrote:
> hw_error() calls exit(). This a bit overkill when we can log
> the accesses as unimplemented or guest error.
>
> When fuzzing the devices, we don't want the whole process to
> exit. Replace some hw_error() calls by qemu_log_
mizz,
I'm worked on it and got a working draft on pre-5.0 codebase. It can
react on QMP property changes to trigger ACPI events on x86 and arm-
virt.
However i've stuck on frontend/backend split. Keep calm, i'm still
working on the task and will complete this soon.
Philippe, thanks for advice!
On Fri, May 15, 2020 at 05:08:23PM +0200, Ján Tomko wrote:
> On a Friday in 2020, Gerd Hoffmann wrote:
> > Add deprecation message to the audio init function.
> >
> > Factor out audio initialization and call that from
> > both audio init and realize, so setting audiodev via
> > -global is enough
On Mon, 18 May 2020 at 00:23, Catherine A. Frederick
wrote:
> Hi, I've been patching TCG for my own purposes recently and I was
> wondering a few things. That being:
>
> - Is the TCG backend expected to handle bad cases for instructions? I
> was wondering as I found a situation where a very large
From: Philippe Mathieu-Daudé
Trying libFuzzer on the vmport device, we get:
AddressSanitizer:DEADLYSIGNAL
=
==29476==ERROR: AddressSanitizer: SEGV on unknown address 0x8840 (pc
0x56448bec4d79 bp 0x7ffeec9741b0 sp 0x7f
On Mon, 18 May 2020, Markus Armbruster wrote:
object_property_set_bool(OBJECT(dev), true, "realized", ...) right
after qdev_init_nofail(dev) does nothing, because qdev_init_nofail()
already realizes. Drop.
Cc: BALATON Zoltan
Shouldn't this Cc line come after the --- so it's not included in t
On Mon, May 18, 2020 at 12:16:28PM +0200, Gerd Hoffmann wrote:
> On Fri, May 15, 2020 at 05:08:23PM +0200, Ján Tomko wrote:
> > On a Friday in 2020, Gerd Hoffmann wrote:
> > > Add deprecation message to the audio init function.
> > >
> > > Factor out audio initialization and call that from
> > > b
On 5/18/20 12:25 PM, Philippe Mathieu-Daudé wrote:
From: Philippe Mathieu-Daudé
Bah, wrong cherry-pick, as it was done during hobby time ¯\_(ツ)_/¯
Trying libFuzzer on the vmport device, we get:
AddressSanitizer:DEADLYSIGNAL
On Mon, 18 May 2020 at 06:04, Markus Armbruster wrote:
>
> xlnx_dp_init() creates these two devices, but they're never realized.
> Affects machine xlnx-zcu102.
>
> I wonder how this ever worked. If the "device becomes real only on
> realize" thing actually works, then we've always been missing th
Trying libFuzzer on the vmport device, we get:
AddressSanitizer:DEADLYSIGNAL
=
==29476==ERROR: AddressSanitizer: SEGV on unknown address 0x8840 (pc
0x56448bec4d79 bp 0x7ffeec9741b0 sp 0x7ffeec9740e0 T0)
==29476==The s
On Mon, 18 May 2020, Markus Armbruster wrote:
sm501_init() and ati_vga_realize() create an "i2c-ddc" device, but
neglect to realize it. Affects machines sam460ex, shix, r2d, and
fulong2e.
I wonder how this ever worked. If the "device becomes real only on
realize" thing actually works, then we'
On Mon, 18 May 2020, Markus Armbruster wrote:
sm501_init() and ati_vga_realize() create an "i2c-ddc" device, but
neglect to realize it. Affects machines sam460ex, shix, r2d, and
fulong2e.
I wonder how this ever worked. If the "device becomes real only on
realize" thing actually works, then we'
Update Fred Konrad email address to avoid emails bouncing.
Signed-off-by: Philippe Mathieu-Daudé
---
.mailmap | 1 +
1 file changed, 1 insertion(+)
diff --git a/.mailmap b/.mailmap
index 6412067bde..4c7f4b7d03 100644
--- a/.mailmap
+++ b/.mailmap
@@ -44,6 +44,7 @@ Aleksandar Markovic
Aleks
On 15/05/20 16:35, Gerd Hoffmann wrote:
> v2:
> - use g_assert_not_reached() for stubs.
> - add deprecation notice.
If I understand it, the deprecation message suggests "-device ac97"
instead of "-soundhw ac97", but that in turn relies on the deprecated
default audiodev feature.
So I'm not sure
On 5/18/20 12:39 PM, BALATON Zoltan wrote:
On Mon, 18 May 2020, Markus Armbruster wrote:
sm501_init() and ati_vga_realize() create an "i2c-ddc" device, but
neglect to realize it. Affects machines sam460ex, shix, r2d, and
fulong2e.
I wonder how this ever worked. If the "device becomes real onl
On Thu, 2020-05-14 at 17:47 +0200, Max Reitz wrote:
> On 10.05.20 15:40, Maxim Levitsky wrote:
> > blockdev-amend will be used similiar to blockdev-create
> > to allow on the fly changes of the structure of the format based block
> > devices.
> >
> > Current plan is to first support encryption ke
Peter Maydell writes:
> On Mon, 18 May 2020 at 00:23, Catherine A. Frederick
> wrote:
>> Hi, I've been patching TCG for my own purposes recently and I was
>> wondering a few things. That being:
>>
>> - I've been implementing an instruction scheduler(list scheduler, with
>> priority given to m
On a Monday in 2020, Daniel P. Berrangé wrote:
On Mon, May 18, 2020 at 12:16:28PM +0200, Gerd Hoffmann wrote:
On Fri, May 15, 2020 at 05:08:23PM +0200, Ján Tomko wrote:
> On a Friday in 2020, Gerd Hoffmann wrote:
> > Add deprecation message to the audio init function.
> >
> > Factor out audio in
ping
On 06.05.2020 10:52, Pavel Dovgalyuk wrote:
This patch fixes shift=auto when record/replay is enabled.
Now user does not need to guess the best shift value.
Signed-off-by: Pavel Dovgalyuk
---
cpus.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/cpus.c b/cpu
ping
On 06.05.2020 11:17, Pavel Dovgalyuk wrote:
Sometimes virtual timer callbacks depend on order
of virtual timer processing and warping of virtual clock.
Therefore every callback should be logged to make replay deterministic.
This patch creates a checkpoint before every virtual timer callbac
On 5/18/20 12:30 PM, Peter Maydell wrote:
On Mon, 18 May 2020 at 06:04, Markus Armbruster wrote:
xlnx_dp_init() creates these two devices, but they're never realized.
Affects machine xlnx-zcu102.
I wonder how this ever worked. If the "device becomes real only on
realize" thing actually works
On 5/18/20 11:46 AM, Peter Maydell wrote:
On Sun, 17 May 2020 at 17:48, Philippe Mathieu-Daudé wrote:
Various places ignore the MemTxResult indicator of
transaction failed. Some cases might be justified
(DMA?) while other are probably bugs. To avoid
ignoring transaction errors, suggestion is
+ Alex
On 5/6/20 10:17 AM, Pavel Dovgalyuk wrote:
Sometimes virtual timer callbacks depend on order
of virtual timer processing and warping of virtual clock.
Therefore every callback should be logged to make replay deterministic.
This patch creates a checkpoint before every virtual timer callbac
+Alex
On 5/6/20 9:52 AM, Pavel Dovgalyuk wrote:
This patch fixes shift=auto when record/replay is enabled.
Now user does not need to guess the best shift value.
Signed-off-by: Pavel Dovgalyuk
---
cpus.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/cpus.c b/cpus.
On Mon, May 18, 2020 at 11:26:50AM +0100, Daniel P. Berrangé wrote:
> On Mon, May 18, 2020 at 12:16:28PM +0200, Gerd Hoffmann wrote:
> > On Fri, May 15, 2020 at 05:08:23PM +0200, Ján Tomko wrote:
> > > On a Friday in 2020, Gerd Hoffmann wrote:
> > > > Add deprecation message to the audio init fun
13.05.2020 04:16, Eric Blake wrote:
Include actions for --add, --remove, --clear, --enable, --disable, and
--merge (note that --clear is a bit of fluff, because the same can be
accomplished by removing a bitmap and then adding a new one in its
place, but it matches what QMP commands exist). List
On 09.05.20 01:08, Collin Walling wrote:
> The SCCB must be checked for a sufficient length before it is filled
> with any data. If the length is insufficient, then the SCLP command
> is suppressed and the proper response code is set in the SCCB header.
>
> Signed-off-by: Collin Walling
> ---
>
On 16.05.20 00:20, Collin Walling wrote:
> The SCCB must be checked for a sufficient length before it is filled
> with any data. If the length is insufficient, then the SCLP command
> is suppressed and the proper response code is set in the SCCB header.
>
> Fixes: 832be0d8a3bb ("s390x: sclp: Repor
On 14.05.20 14:37, Janosch Frank wrote:
> Let's initialize the structs at the beginning to ease reading and also
> zeroing all other fields. This also makes the compiler stop
> compalining about sense_id_ccw.flags being ored into when it's not
s/compalining/complaining/
> initialized.
>
> Signed
* Zhanghailiang (zhang.zhanghaili...@huawei.com) wrote:
> > This causes the migration thread to hang if we failover during checkpoint. A
> > shutdown fd won't cause network traffic anyway.
> >
>
> I'm not quite sure if this modification can take side effect on normal
> migration process or not,
[...]
>
> -static inline void yield(void)
> -{
> -asm volatile ("diag 0,0,0x44"
> - : :
> - : "memory", "cc");
> -}
> -
Nit: Looks weird that yield() is moved to time.h
Wonder if there is a better fit for this function.
> #define MAX_SECTOR_SIZE 4096
>
On 5/18/20 1:52 PM, David Hildenbrand wrote:
> On 14.05.20 14:37, Janosch Frank wrote:
>> Let's initialize the structs at the beginning to ease reading and also
>> zeroing all other fields. This also makes the compiler stop
>> compalining about sense_id_ccw.flags being ored into when it's not
>
>
On 5/18/20 2:01 PM, David Hildenbrand wrote:
> [...]
>
>>
>> -static inline void yield(void)
>> -{
>> -asm volatile ("diag 0,0,0x44"
>> - : :
>> - : "memory", "cc");
>> -}
>> -
>
> Nit: Looks weird that yield() is moved to time.h
>
> Wonder if there is a b
* Philippe Mathieu-Daudé (phi...@redhat.com) wrote:
> Do not build the virtiofsd helper when configured with
> --disable-system.
>
> Reviewed-by: Richard Henderson
> Signed-off-by: Philippe Mathieu-Daudé
Yeh that seems reasonable; although virtiofsd is self-contained enough
that perhaps it sh
On 5/18/20 7:03 AM, Markus Armbruster wrote:
> These devices are optional, and controlled by @nb_nics.
> aspeed_soc_ast2600_init() and aspeed_soc_init() create the maximum
> supported number. aspeed_soc_ast2600_realize() and
> aspeed_soc_realize() realize only the wanted number. Works, although
>
Hi!
Here is the updated series of my patches, incorporating all the feedback I
received.
This implements the API interface that we agreed upon except that I merged the
LUKSKeyslotActive/LUKSKeyslotInactive union into a struct because otherwise
I need nested unions which are not supported currentl
Signed-off-by: Maxim Levitsky
Reviewed-by: Daniel P. Berrangé
Reviewed-by: Max Reitz
---
block/crypto.c | 72
qapi/block-core.json | 14 -
2 files changed, 66 insertions(+), 20 deletions(-)
diff --git a/block/crypto.c b/block/crypto.c
1 - 100 of 432 matches
Mail list logo
