Re: Assertion failure through vring_split_desc_read

2020-05-12 Thread Laurent Vivier
On 12/05/2020 15:49, Laurent Vivier wrote: > On 11/05/2020 05:51, Alexander Bulekov wrote: >> Hello, >> While fuzzing, I found an input that triggers an assertion failure >> through virtio-rng -> vring_split_desc_read. Maybe this is related to: >> Message-ID: <20200511033001.dzvtbdhl3oz5p...@mozz.b

[PATCH v5 01/12] net: cadence_gem: Fix debug statements

2020-05-12 Thread Sai Pavan Boddu
Enabling debug breaks the build, Fix them and make debug statements always compilable. Fix few statements to use sized integer casting. Signed-off-by: Sai Pavan Boddu Reviewed-by: Edgar E. Iglesias --- hw/net/cadence_gem.c | 27 +-- 1 file changed, 13 insertions(+), 14 d

Re: [PATCH v5 07/12] net: cadence_gem: Fix up code style

2020-05-12 Thread Edgar E. Iglesias
On Tue, May 12, 2020 at 08:24:49PM +0530, Sai Pavan Boddu wrote: > Fix the code style for register definitions. > Reviewed-by: Edgar E. Iglesias > Signed-off-by: Sai Pavan Boddu > --- > hw/net/cadence_gem.c | 204 > ++- > 1 file changed, 103 i

[PATCH v5 02/12] net: cadence_gem: Fix the queue address update during wrap around

2020-05-12 Thread Sai Pavan Boddu
During wrap around and reset, queues are pointing to initial base address of queue 0, irrespective of what queue we are dealing with. Fix it by assigning proper base address every time. Signed-off-by: Sai Pavan Boddu Reviewed-by: Edgar E. Iglesias --- hw/net/cadence_gem.c | 37 +

[PATCH v5 06/12] net: cadence_gem: Move tx/rx packet buffert to CadenceGEMState

2020-05-12 Thread Sai Pavan Boddu
Moving this buffers to CadenceGEMState, as their size will be increased more when JUMBO frames support is added. Signed-off-by: Sai Pavan Boddu Reviewed-by: Edgar E. Iglesias --- hw/net/cadence_gem.c | 38 +- include/hw/net/cadence_gem.h | 4 2

[PATCH v5 00/12] Cadence GEM Fixes

2020-05-12 Thread Sai Pavan Boddu
Hi, Following patch series fixes issues with priority queues, Adds JUMBO Frame support, Makes Debug statements compilable & Fixes related to multicast frames. Changes for V2: Fixed build failure on fedora docker machine Fix buggy debug print to use sized integer casting Changes fo

[PATCH v5 10/12] net: cadence_gem: Update the reset value for interrupt mask register

2020-05-12 Thread Sai Pavan Boddu
Mask all interrupt on reset. Signed-off-by: Sai Pavan Boddu Reviewed-by: Edgar E. Iglesias --- hw/net/cadence_gem.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/net/cadence_gem.c b/hw/net/cadence_gem.c index 3e7b32f..ddb8938 100644 --- a/hw/net/cadence_gem.c +++ b/hw/net/cadence_gem.c

[Bug 1877716] Re: Win10 guest unusable after a few minutes

2020-05-12 Thread zkrx
Hi Stefan, I applied your series on top of master with io_uring enabled and I no longer experience the issue. Let me know if you need additional testing. Thank you for fixing this so promptly. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed

[PATCH v5 09/12] net: cadnece_gem: Update irq_read_clear field of designcfg_debug1 reg

2020-05-12 Thread Sai Pavan Boddu
Advertise support of clear-on-read for ISR registers. Signed-off-by: Sai Pavan Boddu Reviewed-by: Edgar E. Iglesias --- hw/net/cadence_gem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/cadence_gem.c b/hw/net/cadence_gem.c index eb02946..3e7b32f 100644 --- a/hw/net

[PATCH v5 08/12] net: cadence_gem: Add support for jumbo frames

2020-05-12 Thread Sai Pavan Boddu
Add a property "jumbo-max-len", which sets default value of jumbo frames up to 16,383 bytes. Add Frame length checks for standard and jumbo frames. Signed-off-by: Sai Pavan Boddu --- hw/net/cadence_gem.c | 51 +++- include/hw/net/cadence_gem.h | 4

Re: [PATCH RESEND v6 22/36] multi-process: Synchronize remote memory

2020-05-12 Thread Stefan Hajnoczi
On Wed, Apr 22, 2020 at 09:13:57PM -0700, elena.ufimts...@oracle.com wrote: > diff --git a/hw/proxy/memory-sync.c b/hw/proxy/memory-sync.c > new file mode 100644 > index 00..b3f57747f3 > --- /dev/null > +++ b/hw/proxy/memory-sync.c > @@ -0,0 +1,217 @@ > +/* > + * Copyright © 2018, 2020 Orac

Re: [PATCH v5 13/15] acpi: drop build_piix4_pm()

2020-05-12 Thread Igor Mammedov
On Tue, 12 May 2020 13:16:05 +0200 Gerd Hoffmann wrote: > On Mon, May 11, 2020 at 09:37:32PM +0200, Igor Mammedov wrote: > > On Thu, 7 May 2020 15:16:38 +0200 > > Gerd Hoffmann wrote: > > > > > The _SB.PCI0.PX13.P13C opregion (holds isa device enable bits) > > > is not used any more, remove

Re: [PATCH v2 2/2] net: Drop the NetLegacy structure, always use Netdev instead

2020-05-12 Thread Thomas Huth
On 12/05/2020 16.32, Eric Blake wrote: > On 5/12/20 7:31 AM, Thomas Huth wrote: >> Now that the "name" parameter is gone, there is hardly any difference >> between NetLegacy and Netdev anymore. Drop NetLegacy and always use >> Netdev to simplify the code quite a bit. >> >> Signed-off-by: Thomas Hut

Re: [RFC PATCH 1/3] block: Factor out bdrv_run_co()

2020-05-12 Thread Eric Blake
On 5/12/20 9:43 AM, Kevin Wolf wrote: We have a few bdrv_*() functions that can either spawn a new coroutine and wait for it with BDRV_POLL_WHILE() or use a fastpath if they are alreeady running in a coroutine. All of them duplicate basically the already same code. Factor the common code int

Re: [PATCH v5 08/12] net: cadence_gem: Add support for jumbo frames

2020-05-12 Thread Edgar E. Iglesias
On Tue, May 12, 2020 at 08:24:50PM +0530, Sai Pavan Boddu wrote: > Add a property "jumbo-max-len", which sets default value of jumbo frames > up to 16,383 bytes. Add Frame length checks for standard and jumbo > frames. Reviewed-by: Edgar E. Iglesias > > Signed-off-by: Sai Pavan Boddu > --- >

Re: [PATCH RESEND v6 22/36] multi-process: Synchronize remote memory

2020-05-12 Thread Dr. David Alan Gilbert
* Stefan Hajnoczi (stefa...@redhat.com) wrote: > On Wed, Apr 22, 2020 at 09:13:57PM -0700, elena.ufimts...@oracle.com wrote: > > diff --git a/hw/proxy/memory-sync.c b/hw/proxy/memory-sync.c > > new file mode 100644 > > index 00..b3f57747f3 > > --- /dev/null > > +++ b/hw/proxy/memory-sync.c

Re: [PATCH v2 2/2] net: Drop the NetLegacy structure, always use Netdev instead

2020-05-12 Thread Eric Blake
On 5/12/20 10:13 AM, Thomas Huth wrote: +++ b/qapi/net.json @@ -453,7 +453,7 @@   #    'l2tpv3' - since 2.1   ##   { 'union': 'Netdev', -  'base': { 'id': 'str', 'type': 'NetClientDriver' }, +  'base': { '*id': 'str', 'type': 'NetClientDriver' }, I don't think we need to make 'id' optio

Re: [PATCH v2 2/4] iotests/229: Use blkdebug to inject an error

2020-05-12 Thread Vladimir Sementsov-Ogievskiy
11.05.2020 16:58, Kevin Wolf wrote: 229 relies on the mirror running into an I/O error when the target is smaller than the source. After changing mirror to catch this condition while starting the job, this test case won't get a job that is paused for an I/O error any more. Use blkdebug instead to

[PULL v3 0/1] Merge tpm 2020/05/08 v3

2020-05-12 Thread Stefan Berger
This PR submits a fix that changes improperly used 'FALSE' to 'false'. Stefan The following changes since commit c88f1ffc19e38008a1c33ae039482a860aa7418c: Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2020-05-08 14:29:18 +0100) are available in the Git repos

[PULL v3 1/1] hw/tpm: fix usage of bool in tpm-tis.c

2020-05-12 Thread Stefan Berger
From: Jafar Abdi Clean up wrong usage of FALSE and TRUE in places that use "bool" from stdbool.h. FALSE and TRUE (with capital letters) are the constants defined by glib for being used with the "gboolean" type of glib. But some parts of the code also use TRUE and FALSE for variables that are dec

Re: [PATCH RESEND v6 23/36] multi-process: create IOHUB object to handle irq

2020-05-12 Thread Stefan Hajnoczi
On Wed, Apr 22, 2020 at 09:13:58PM -0700, elena.ufimts...@oracle.com wrote: > diff --git a/include/remote/iohub.h b/include/remote/iohub.h > new file mode 100644 > index 00..7a488a8c38 > --- /dev/null > +++ b/include/remote/iohub.h > @@ -0,0 +1,50 @@ > +/* > + * IO Hub for remote device > +

Re: Infinite loop in bus_unparent(), qdev bug or qdev misuse?

2020-05-12 Thread Markus Armbruster
Markus Armbruster writes: > Paolo Bonzini writes: > >> On 05/05/20 18:03, Markus Armbruster wrote: That's a good one, and especially a safe one, since it matches qdev_device_add. It has the disadvantage of having to touch all qdev_create() calls. >>> >>> Also, it moves onboard d

Re: [PATCH v2 1/3] acpi: Move build_tpm2() in the generic part

2020-05-12 Thread Auger Eric
Hi Igor, On 5/12/20 4:14 PM, Igor Mammedov wrote: > On Wed, 6 May 2020 05:58:25 -0400 > "Michael S. Tsirkin" wrote: > >> On Wed, May 06, 2020 at 08:33:14AM +0200, Andrew Jones wrote: >>> I realize this function is just getting moved, but maybe it should get >>> converted to the build_append* API

Re: [PATCH v1 2/8] s390/sclp: check sccb len before filling in data

2020-05-12 Thread Cornelia Huck
On Mon, 11 May 2020 17:02:06 +0200 David Hildenbrand wrote: > On 11.05.20 16:50, Janosch Frank wrote: > > On 5/11/20 4:44 PM, David Hildenbrand wrote: > >> On 11.05.20 16:36, Janosch Frank wrote: > >>> On 5/9/20 1:08 AM, Collin Walling wrote: > The SCCB must be checked for a sufficient

Re: [PATCH v2 2/3] arm/acpi: TPM2 ACPI table support

2020-05-12 Thread Auger Eric
Hi Igor, On 5/12/20 4:27 PM, Igor Mammedov wrote: > On Tue, 5 May 2020 16:44:18 +0200 > Eric Auger wrote: > >> Add a TPM2 ACPI table if a TPM2.0 sysbus device has been >> dynamically instantiated. >> >> Signed-off-by: Eric Auger > > on x86 we also do: > > fw_cfg_add_file(x86ms->fw_cfg, ACP

Re: [PATCH RESEND v6 24/36] multi-process: Retrieve PCI info from remote process

2020-05-12 Thread Stefan Hajnoczi
On Wed, Apr 22, 2020 at 09:13:59PM -0700, elena.ufimts...@oracle.com wrote: > @@ -291,3 +299,79 @@ const MemoryRegionOps proxy_default_ops = { > .max_access_size = 1, > }, > }; > + > +static void probe_pci_info(PCIDevice *dev) > +{ > +PCIDeviceClass *pc = PCI_DEVICE_GET_CLASS(dev

Re: [PATCH v1 0/8] s390: Extended-Length SCCB & DIAGNOSE 0x318

2020-05-12 Thread Cornelia Huck
On Fri, 8 May 2020 19:08:15 -0400 Collin Walling wrote: > Collin L. Walling (8): > s390/sclp: remove SCLPDevice param from prepare_cpu_entries This looks like a simple cleanup... > s390/sclp: check sccb len before filling in data ...and that like a simple fix (for a problem that currently

Re: [RFC PATCH 2/3] block: Allow bdrv_run_co() from different AioContext

2020-05-12 Thread Thomas Lamprecht
On 5/12/20 4:43 PM, Kevin Wolf wrote: > Coroutine functions that are entered through bdrv_run_co() are already > safe to call from synchronous code in a different AioContext because > bdrv_coroutine_enter() will schedule them in the context of the node. > > However, the coroutine fastpath still re

Re: [PATCH RESEND v6 23/36] multi-process: create IOHUB object to handle irq

2020-05-12 Thread Stefan Hajnoczi
On Wed, Apr 22, 2020 at 09:13:58PM -0700, elena.ufimts...@oracle.com wrote: > From: Jagannathan Raman > > IOHUB object is added to manage PCI IRQs. It uses KVM_IRQFD > ioctl to create irqfd to injecting PCI interrupts to the guest. > IOHUB object forwards the irqfd to the remote process. Remote p

Re: [PATCH RESEND v6 00/36] Initial support for multi-process qemu

2020-05-12 Thread Stefan Hajnoczi
On Mon, May 11, 2020 at 03:30:50PM -0400, Jag Raman wrote: > > On May 11, 2020, at 10:40 AM, Stefan Hajnoczi wrote: > > > > Hi, > > Have you decided whether to drop the remote device program in favor of > > using a softmmu make target? > > > > Is there anything in this series you'd like me to re

Re: [PATCH v1 2/8] s390/sclp: check sccb len before filling in data

2020-05-12 Thread Collin Walling
On 5/12/20 12:01 PM, Cornelia Huck wrote: On Mon, 11 May 2020 17:02:06 +0200 David Hildenbrand wrote: On 11.05.20 16:50, Janosch Frank wrote: On 5/11/20 4:44 PM, David Hildenbrand wrote: On 11.05.20 16:36, Janosch Frank wrote: On 5/9/20 1:08 AM, Collin Walling wrote: The SCCB must be check

Re: [PATCH v1 0/8] s390: Extended-Length SCCB & DIAGNOSE 0x318

2020-05-12 Thread Collin Walling
On 5/12/20 12:08 PM, Cornelia Huck wrote: On Fri, 8 May 2020 19:08:15 -0400 Collin Walling wrote: Collin L. Walling (8): s390/sclp: remove SCLPDevice param from prepare_cpu_entries This looks like a simple cleanup... s390/sclp: check sccb len before filling in data ...and that lik

Re: [PATCH v1 2/8] s390/sclp: check sccb len before filling in data

2020-05-12 Thread Cornelia Huck
On Tue, 12 May 2020 12:16:45 -0400 Collin Walling wrote: > On 5/12/20 12:01 PM, Cornelia Huck wrote: > > On Mon, 11 May 2020 17:02:06 +0200 > > David Hildenbrand wrote: > > > >> On 11.05.20 16:50, Janosch Frank wrote: > >>> On 5/11/20 4:44 PM, David Hildenbrand wrote: > On 11.05.20 1

Re: [PATCH v1 2/8] s390/sclp: check sccb len before filling in data

2020-05-12 Thread Collin Walling
On 5/12/20 12:24 PM, Cornelia Huck wrote: On Tue, 12 May 2020 12:16:45 -0400 Collin Walling wrote: On 5/12/20 12:01 PM, Cornelia Huck wrote: On Mon, 11 May 2020 17:02:06 +0200 David Hildenbrand wrote: On 11.05.20 16:50, Janosch Frank wrote: On 5/11/20 4:44 PM, David Hildenbrand wrote:

Re: [PATCH v8 74/74] cputlb: queue async flush jobs without the BQL

2020-05-12 Thread Alex Bennée
Robert Foley writes: > From: "Emilio G. Cota" > > This yields sizable scalability improvements, as the below results show. > > Host: Two Intel E5-2683 v3 14-core CPUs at 2.00 GHz (Haswell) > > Workload: Ubuntu 18.04 ppc64 compiling the linux kernel with > "make -j N", where N is the number of

Re: [PATCH v8 00/74] per-CPU locks

2020-05-12 Thread Alex Bennée
Robert Foley writes: > V7: https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg00786.html > > This is a continuation of the series created by Emilio Cota. > We are picking up this patch set with the goal to apply > any fixes or updates needed to get this accepted. > > Quoting an earlier p

Re: [Bug 1877716] Re: Win10 guest unusable after a few minutes

2020-05-12 Thread Stefan Hajnoczi
On Tue, May 12, 2020, 16:25 zkrx <1877...@bugs.launchpad.net> wrote: > Hi Stefan, > > I applied your series on top of master with io_uring enabled and I no > longer experience the issue. Let me know if you need additional testing. > > Thank you for fixing this so promptly. > That's great! Thanks

Re: Qemu, VNC and non-US keymaps

2020-05-12 Thread B3r3n
Dear all, VNC == RFB - they're two different terms of the same thing. The core RFB/VNC protocol only knows about keysyms. Ok, so RFB is not the keyword to track :-( AFAIK, TightVNC doesn't support the scancode extension, only TigerVNC. Confirmed, I replaced TightVNC viewer by TigerVNC, solv

[PATCH v2 00/17] target/arm: Convert rest of Neon 3-reg-same to decodetree

2020-05-12 Thread Peter Maydell
This patchset is v2 of the Neon decodetree conversion. The first half of v1 is in master already, so we're left just with patches converting the rest of the 3-reg-same Neon dp insn group. Based-on: <20200508152200.6547-1-richard.hender...@linaro.org> ("[PATCH v3 00/16] target/arm: partial vector c

[PATCH v2 10/17] target/arm: Convert Neon VQDMULH/VQRDMULH 3-reg-same to decodetree

2020-05-12 Thread Peter Maydell
Convert the Neon VQDMULH and VQRDMULH 3-reg-same insns to decodetree. These are the last integer operations in the 3-reg-same group. Signed-off-by: Peter Maydell --- target/arm/neon-dp.decode | 3 +++ target/arm/translate-neon.inc.c | 24 target/arm/translate.c

[PATCH v2 04/17] target/arm: Convert Neon VHADD 3-reg-same insns

2020-05-12 Thread Peter Maydell
Convert the Neon VHADD insns in the 3-reg-same group to decodetree. Signed-off-by: Peter Maydell --- target/arm/neon-dp.decode | 2 ++ target/arm/translate-neon.inc.c | 24 target/arm/translate.c | 4 +--- 3 files changed, 27 insertions(+), 3 deletions(-

[PATCH v2 02/17] target/arm: Convert Neon 3-reg-same SHA to decodetree

2020-05-12 Thread Peter Maydell
Convert the Neon SHA instructions in the 3-reg-same group to decodetree. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson --- target/arm/neon-dp.decode | 10 +++ target/arm/translate-neon.inc.c | 139 target/arm/translate.c | 46 +

[PATCH v2 01/17] target/arm: Convert Neon 3-reg-same VQRDMLAH/VQRDMLSH to decodetree

2020-05-12 Thread Peter Maydell
Convert the Neon VQRDMLAH and VQRDMLSH insns in the 3-reg-same group to decodetree. These don't use do_3same() because they want to operate on VFP double registers, whose offsets are different from the neon_reg_offset() calculations do_3same does. Signed-off-by: Peter Maydell --- v1->v2: use do_

[PATCH v2 03/17] target/arm: Convert Neon 64-bit element 3-reg-same insns

2020-05-12 Thread Peter Maydell
Convert the 64-bit element insns in the 3-reg-same group to decodetree. This covers VQSHL, VRSHL and VQRSHL where size==0b11. Signed-off-by: Peter Maydell --- target/arm/neon-dp.decode | 21 ++ target/arm/translate-neon.inc.c | 24 + target/arm/translate

[PATCH v2 05/17] target/arm: Convert Neon VABA/VABD 3-reg-same to decodetree

2020-05-12 Thread Peter Maydell
Convert the Neon VABA and VABD insns in the 3-reg-same group to decodetree. Signed-off-by: Peter Maydell --- target/arm/neon-dp.decode | 6 ++ target/arm/translate-neon.inc.c | 4 target/arm/translate.c | 22 ++ 3 files changed, 12 insertions(+), 20

[PATCH v2 08/17] target/arm: Convert Neon VPMAX/VPMIN 3-reg-same insns to decodetree

2020-05-12 Thread Peter Maydell
Convert the Neon integer VPMAX and VPMIN 3-reg-same insns to decodetree. These are 'pairwise' operations. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson --- target/arm/neon-dp.decode | 9 + target/arm/translate-neon.inc.c | 71 + target/ar

[PATCH v2 12/17] target/arm: Convert Neon VPMIN/VPMAX/VPADD float 3-reg-same insns to decodetree

2020-05-12 Thread Peter Maydell
Convert the Neon float VPMIN, VPMAX and VPADD 3-reg-same insns to decodetree. These are the only remaining 'pairwise' operations, so we can delete the pairwise-specific bits of the old decoder's for-each-element loop now. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson --- target/ar

[PATCH v2 06/17] target/arm: Convert Neon VRHADD, VHSUB 3-reg-same insns to decodetree

2020-05-12 Thread Peter Maydell
Convert the Neon VRHADD and VHSUB 3-reg-same insns to decodetree. (These are all the other insns in 3-reg-same which were using GEN_NEON_INTEGER_OP() and which are not pairwise or reversed-operands.) Signed-off-by: Peter Maydell --- target/arm/neon-dp.decode | 6 ++ target/arm/translat

[PATCH v2 09/17] target/arm: Convert Neon VPADD 3-reg-same insns to decodetree

2020-05-12 Thread Peter Maydell
Convert the Neon integer VPADD 3-reg-same insns to decodetree. These are 'pairwise' operations. (Note that VQRDMLAH, which shares the same primary opcode but has U=1, has already been converted.) Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson --- target/arm/neon-dp.decode |

[PATCH v2 13/17] target/arm: Convert Neon fp VMUL, VMLA, VMLS 3-reg-same insns to decodetree

2020-05-12 Thread Peter Maydell
Convert the Neon integer VMUL, VMLA, and VMLS 3-reg-same inssn to decodetree. We don't have a gvec helper for multiply-accumulate, so VMLA and VMLS need a loop function do_3same_fp(). This takes a reads_vd parameter to do_3same_fp() which tells it to load the old value into vd before calling the

[PATCH v2 07/17] target/arm: Convert Neon VQSHL, VRSHL, VQRSHL 3-reg-same insns to decodetree

2020-05-12 Thread Peter Maydell
Convert the VQSHL, VRSHL and VQRSHL insns in the 3-reg-same group to decodetree. We have already implemented the size==0b11 case of these insns; this commit handles the remaining sizes. Signed-off-by: Peter Maydell --- target/arm/neon-dp.decode | 47 +++-- targe

[PATCH v2 11/17] target/arm: Convert Neon VADD, VSUB, VABD 3-reg-same insns to decodetree

2020-05-12 Thread Peter Maydell
Convert the Neon VADD, VSUB, VABD 3-reg-same insns to decodetree. We already have gvec helpers for addition and subtraction, but must add one for fabd. Signed-off-by: Peter Maydell --- target/arm/helper.h | 3 ++- target/arm/neon-dp.decode | 8 target/arm/neon_helper

[PATCH v4 14/15] iotests: prepare 245 for using filter in block-stream

2020-05-12 Thread Andrey Shinkevich
The preliminary patch modifies the test 245 to prepare the block-stream job for using COR-filter. The filter breaks the backing chain being connected to the underlying node by file child link. Signed-off-by: Andrey Shinkevich --- tests/qemu-iotests/245 | 10 +++--- 1 file changed, 7 insertio

[PATCH v2 15/17] target/arm: Move 'env' argument of recps_f32 and rsqrts_f32 helpers to usual place

2020-05-12 Thread Peter Maydell
The usual location for the env argument in the argument list of a TCG helper is immediately after the return-value argument. recps_f32 and rsqrts_f32 differ in that they put it at the end. Move the env argument to its usual place; this will allow us to more easily use these helper functions with t

[PATCH v2 16/17] target/arm: Convert Neon fp VMAX/VMIN/VMAXNM/VMINNM/VRECPS/VRSQRTS to decodetree

2020-05-12 Thread Peter Maydell
Convert the Neon fp VMAX/VMIN/VMAXNM/VMINNM/VRECPS/VRSQRTS 3-reg-same insns to decodetree. (These are all the remaining non-accumulation instructions in this group.) Signed-off-by: Peter Maydell --- target/arm/neon-dp.decode | 6 +++ target/arm/translate-neon.inc.c | 70 ++

[PATCH v2 14/17] target/arm: Convert Neon 3-reg-same compare insns to decodetree

2020-05-12 Thread Peter Maydell
Convert the Neon integer 3-reg-same compare insns VCGE, VCGT, VCEQ, VACGE and VACGT to decodetree. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson --- target/arm/neon-dp.decode | 5 + target/arm/translate-neon.inc.c | 6 + target/arm/translate.c | 39 ++-

[PATCH v4 00/15] Apply COR-filter to the block-stream permanently

2020-05-12 Thread Andrey Shinkevich
With this series, all the block-stream COR operations pass through the COR-filter. The patches 01-08/15 are taken from the series "block: Deal with filters" by Max Reitz, the full version of that can be found in the branches: https://git.xanclic.moe/XanClic/qemu child-access-functions-v6

[PATCH v2 17/17] target/arm: Convert NEON VFMA, VFMS 3-reg-same insns to decodetree

2020-05-12 Thread Peter Maydell
Convert the Neon floating point VFMA and VFMS insn to decodetree. These are the last insns in the 3-reg-same group so we can remove all the support/loop code from the old decoder. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson --- target/arm/neon-dp.decode | 3 + target/arm

[PATCH v4 11/15] copy-on-read: Support preadv/pwritev_part functions

2020-05-12 Thread Andrey Shinkevich
Add support for the recently introduced functions bdrv_co_preadv_part() and bdrv_co_pwritev_part() to the COR-filter driver. Signed-off-by: Andrey Shinkevich --- block/copy-on-read.c | 28 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/block/copy-on-

[PATCH v4 10/15] copy-on-read: Support change filename functions

2020-05-12 Thread Andrey Shinkevich
The COR-filter driver should support a redirecting function to refresh filenames. Otherwise, a file name of the filter will be copied instead of the one of a data node. It is also true for the function bdrv_change_backing_file(). Signed-off-by: Andrey Shinkevich --- block/copy-on-read.c | 18 +++

[PATCH v4 02/15] copy-on-read: Support compressed writes

2020-05-12 Thread Andrey Shinkevich
From: Max Reitz Signed-off-by: Max Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy --- block/copy-on-read.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/block/copy-on-read.c b/block/copy-on-read.c index 242d3ff..c4fa468 100644 --- a/block/copy-on-read.c +++ b/block/copy-on-

[PATCH v4 03/15] block: Add child access functions

2020-05-12 Thread Andrey Shinkevich
From: Max Reitz There are BDS children that the general block layer code can access, namely bs->file and bs->backing. Since the introduction of filters and external data files, their meaning is not quite clear. bs->backing can be a COW source, or it can be an R/W-filtered child; bs->file can be

[PATCH v4 15/15] block: apply COR-filter to block-stream jobs

2020-05-12 Thread Andrey Shinkevich
The patch completes the series with the COR-filter insertion to any block-stream operation. It also makes changes to the iotests 030 and 141.out. Signed-off-by: Andrey Shinkevich --- block/stream.c | 83 -- tests/qemu-iotests/030 | 8 +

[PATCH v4 01/15] block: Mark commit and mirror as filter drivers

2020-05-12 Thread Andrey Shinkevich
From: Max Reitz The commit and mirror block nodes are filters, so they should be marked as such. (Strictly speaking, BDS.is_filter's documentation states that a filter's child must be bs->file. The following patch will relax this restriction, however.) Signed-off-by: Max Reitz Reviewed-by: Al

[PATCH v4 12/15] copy-on-read: add filter append/drop functions

2020-05-12 Thread Andrey Shinkevich
Provide API for the COR-filter insertion/removal. Also, drop the filter child permissions for an inactive state when the filter node is being removed. Signed-off-by: Andrey Shinkevich --- block/copy-on-read.c | 102 +++ 1 file changed, 102 insertio

[PATCH v4 07/15] commit: Deal with filters when blocking intermediate nodes

2020-05-12 Thread Andrey Shinkevich
From: Max Reitz This includes some permission limiting (for example, we only need to take the RESIZE permission if the base is smaller than the top). Signed-off-by: Max Reitz Signed-off-by: Andrey Shinkevich --- block/commit.c | 75 ++ 1

[PATCH v4 09/15] block: prepare block-stream for using COR-filter

2020-05-12 Thread Andrey Shinkevich
This patch is the first one in the series where the COR-filter node will be hard-coded for using in the block-stream job. The block jobs may be run in parallel. Exclude conflicts with filter nodes used for a concurrent job while checking for the blocked operations. It incurs changes in the iotests

[PATCH v4 06/15] block: Use CAFs in block status functions

2020-05-12 Thread Andrey Shinkevich
From: Max Reitz Use the child access functions in the block status inquiry functions as appropriate. Signed-off-by: Max Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy --- block/io.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/block/io.c b/block/io

[PATCH v4 13/15] qapi: add filter-node-name to block-stream

2020-05-12 Thread Andrey Shinkevich
Provide the possibility to pass the 'filter-node-name' parameter to the block-stream job as it is done for the commit block job. That will be needed for further iotests implementations. Signed-off-by: Andrey Shinkevich --- block/monitor/block-hmp-cmds.c | 4 ++-- block/stream.c |

[PATCH v4 04/15] block: Add chain helper functions

2020-05-12 Thread Andrey Shinkevich
From: Max Reitz Add some helper functions for skipping filters in a chain of block nodes. Signed-off-by: Max Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy --- block.c | 55 +++ include/block/block_int.h | 3 +++ 2 files changed,

[PATCH v4 08/15] block: Use CAFs when working with backing chains

2020-05-12 Thread Andrey Shinkevich
From: Max Reitz Use child access functions when iterating through backing chains so filters do not break the chain. Signed-off-by: Max Reitz --- block.c | 40 1 file changed, 28 insertions(+), 12 deletions(-) diff --git a/block.c b/block.c index 459412

Re: [PATCH RESEND v6 00/36] Initial support for multi-process qemu

2020-05-12 Thread Jag Raman
> On May 12, 2020, at 12:13 PM, Stefan Hajnoczi wrote: > > On Mon, May 11, 2020 at 03:30:50PM -0400, Jag Raman wrote: >>> On May 11, 2020, at 10:40 AM, Stefan Hajnoczi wrote: >>> >>> Hi, >>> Have you decided whether to drop the remote device program in favor of >>> using a softmmu make targe

[PATCH v4 05/15] block: Include filters when freezing backing chain

2020-05-12 Thread Andrey Shinkevich
From: Max Reitz In order to make filters work in backing chains, the associated functions must be able to deal with them and freeze all filter links, be they COW or R/W filter links. In the process, rename these functions to reflect that they now act on generalized chains of filter nodes instead

Re: [PATCH] travis.yml: Improve the --disable-tcg test on s390x

2020-05-12 Thread Alex Bennée
Thomas Huth writes: > Since the s390x containers do not allow KVM, we only compile-test > the --disable-tcg build on s390x and do not run the qtests. Thus, > it does not make sense to install genisoimage here, and it also does > not make sense to build the s390-ccw.img here again - it is simply

Re: [PATCH v2 3/4] mirror: Make sure that source and target size match

2020-05-12 Thread Vladimir Sementsov-Ogievskiy
11.05.2020 16:58, Kevin Wolf wrote: If the target is shorter than the source, mirror would copy data until it reaches the end of the target and then fail with an I/O error when trying to write past the end. If the target is longer than the source, the mirror job would complete successfully, but

Re: [PATCH v2 3/4] mirror: Make sure that source and target size match

2020-05-12 Thread Vladimir Sementsov-Ogievskiy
12.05.2020 20:15, Vladimir Sementsov-Ogievskiy wrote: +    } else if (s->bdev_length != target_length) { +    error_setg(errp, "Source and target image have different sizes"); +    ret = -EINVAL; Seems, the only case, when mirror_run() sets errp. And, therefore, the only correct one..

Re: [PATCH] MAINTAINERS: Update Radoslaw Biernacki email address

2020-05-12 Thread Leif Lindholm
On Tue, May 12, 2020 at 19:07:04 +0200, Radoslaw Biernacki wrote: > My Linaro account is no longer active and stop forwarding emails to me. > Changing it to my current employer domain. > > Signed-off-by: Radoslaw Biernacki Acked-by: Leif Lindholm > --- > .mailmap| 1 + > MAINTAINERS | 2 +

[PATCH] qom/object: factor out the initialization of hash table of properties

2020-05-12 Thread Masahiro Yamada
Properties are not related to the initialization of interfaces. The initialization of the hash table can be moved after the if-block, and unified. Signed-off-by: Masahiro Yamada --- qom/object.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/qom/object.c b/qom/obje

Re: [PATCH v4 5/6] net/colo-compare.c, softmmu/vl.c: Check that colo-compare is active

2020-05-12 Thread Dr. David Alan Gilbert
* Zhang, Chen (chen.zh...@intel.com) wrote: > > > > -Original Message- > > From: Lukas Straub > > Sent: Friday, May 8, 2020 2:11 PM > > To: Zhang, Chen > > Cc: qemu-devel ; Li Zhijian > > ; Jason Wang ; Marc- > > André Lureau ; Paolo Bonzini > > > > Subject: Re: [PATCH v4 5/6] net/col

[Bug 1878250] [NEW] Assertion failure in iov_from_buf_full through the e1000e

2020-05-12 Thread Alexander Bulekov
Public bug reported: Hello, While fuzzing, I found an input that triggers an assertion failure in iov_from_buf_full through the e1000e: size_t iov_from_buf_full(const struct iovec *, unsigned int, size_t, const void *, size_t): Assertion `offset == 0' failed. #3 0x76866092 in __GI___as

[PATCH] qom/object: pass (Object *) to object_initialize_with_type()

2020-05-12 Thread Masahiro Yamada
object_new_with_type() already passes (Object *) pointer. Avoid casting back and forth. Signed-off-by: Masahiro Yamada --- qom/object.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/qom/object.c b/qom/object.c index e4085d8ae2..9d1a918e42 100644 --- a/qom/object.c +++ b

Re: [PATCH v4 00/15] Apply COR-filter to the block-stream permanently

2020-05-12 Thread Vladimir Sementsov-Ogievskiy
12.05.2020 19:50, Andrey Shinkevich wrote: With this series, all the block-stream COR operations pass through the COR-filter. The patches 01-08/15 are taken from the series "block: Deal with filters" by Max Reitz, the full version of that can be found in the branches: https://git.xanclic.

[PATCH] MAINTAINERS: Update Radoslaw Biernacki email address

2020-05-12 Thread Radoslaw Biernacki
My Linaro account is no longer active and stop forwarding emails to me. Changing it to my current employer domain. Signed-off-by: Radoslaw Biernacki --- .mailmap| 1 + MAINTAINERS | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.mailmap b/.mailmap index 6412067bde..668d

[PATCH v2 0/1] vfio-ccw: Enable transparent CCW IPL from DASD [QEMU]

2020-05-12 Thread Jared Rossi
Remove the explicit prefetch check when using vfio-ccw devices. This check does not trigger in practice as all Linux channel programs are intended to use prefetch. QEMU part to make use of the corresponding kernel patch posted here: https://lore.kernel.org/kvm/20200506212440.31323-1-jro...@linux.

[PATCH v2 1/1] vfio-ccw: allow non-prefetch ORBs

2020-05-12 Thread Jared Rossi
Remove the explicit prefetch check when using vfio-ccw devices. This check does not trigger in practice as all Linux channel programs are intended to use prefetch. It is no longer required to force the PFCH flag when using vfio-ccw devices. Signed-off-by: Jared Rossi --- hw/vfio/ccw.c | 13 +++-

Problem with QEMU usermode + jemalloc

2020-05-12 Thread Michael Goffioul
Hi, I'm running into a problem using QEMU in usermode and jemalloc (this is in the context of an ARM-to-x86 translation layer for Android). The issue is discussed here: https://github.com/jemalloc/jemalloc/issues/1844 In a nutshell, the lack of madvise implementation is making jemalloc return no

Re: [PATCH] qom/object: pass (Object *) to object_initialize_with_type()

2020-05-12 Thread Philippe Mathieu-Daudé
On 5/12/20 7:31 PM, Masahiro Yamada wrote: object_new_with_type() already passes (Object *) pointer. Avoid casting back and forth. But object_initialize() doesn't... Signed-off-by: Masahiro Yamada --- qom/object.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/qo

Re: [PATCH] MAINTAINERS: Update Radoslaw Biernacki email address

2020-05-12 Thread Philippe Mathieu-Daudé
On 5/12/20 7:07 PM, Radoslaw Biernacki wrote: My Linaro account is no longer active and stop forwarding emails to me. Changing it to my current employer domain. Signed-off-by: Radoslaw Biernacki --- .mailmap| 1 + MAINTAINERS | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff

Re: [PATCH] MAINTAINERS: Update Radoslaw Biernacki email address

2020-05-12 Thread Philippe Mathieu-Daudé
On Tue, May 12, 2020 at 8:18 PM Philippe Mathieu-Daudé wrote: > > On 5/12/20 7:07 PM, Radoslaw Biernacki wrote: > > My Linaro account is no longer active and stop forwarding emails to me. > > Changing it to my current employer domain. > > > > Signed-off-by: Radoslaw Biernacki > > --- > > .mailm

Re: [PATCH v3 00/15] Apply COR-filter to the block-stream permanently

2020-05-12 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1589295196-773454-1-git-send-email-andrey.shinkev...@virtuozzo.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally.

[Bug 1878253] [NEW] null-ptr dereference in address_space_to_flatview through ide

2020-05-12 Thread Alexander Bulekov
Public bug reported: Hello, While fuzzing, I found an input that triggers a null-ptr dereference in address_space_to_flatview through ide: ==31699==ERROR: AddressSanitizer: SEGV on unknown address 0x0020 (pc 0x55e0f562bafd bp 0x7ffee92355b0 sp 0x7ffee92354e0 T0) ==31699==The signal is ca

Re: [PATCH v3 00/15] Apply COR-filter to the block-stream permanently

2020-05-12 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1589295196-773454-1-git-send-email-andrey.shinkev...@virtuozzo.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT B

Re: [PATCH v3 00/15] Apply COR-filter to the block-stream permanently

2020-05-12 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1589295196-773454-1-git-send-email-andrey.shinkev...@virtuozzo.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. =

[PATCH] qom/object: simplify type_initialize_interface()

2020-05-12 Thread Masahiro Yamada
iface_impl->class is the same as new_iface. Make it more readable. Signed-off-by: Masahiro Yamada --- qom/object.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/qom/object.c b/qom/object.c index 9d1a918e42..75c628591d 100644 --- a/qom/object.c +++ b/qom/object.c @@ -262,

Re: [PULL v3 0/1] Merge tpm 2020/05/08 v3

2020-05-12 Thread Peter Maydell
On Tue, 12 May 2020 at 16:55, Stefan Berger wrote: > > This PR submits a fix that changes improperly used 'FALSE' to 'false'. > >Stefan > > The following changes since commit c88f1ffc19e38008a1c33ae039482a860aa7418c: > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into sta

[Bug 1878255] [NEW] Assertion failure in bdrv_aio_cancel, through ide

2020-05-12 Thread Alexander Bulekov
Public bug reported: Hello, While fuzzing, I found an input that triggers an assertion failure in bdrv_aio_cancel, through ide: #1 0x7685755b in __GI_abort () at abort.c:79 #2 0x56a8d396 in bdrv_aio_cancel (acb=0x60761290) at /home/alxndr/Development/qemu/block/io.c:2746 #

Re: [PATCH] qom/object: pass (Object *) to object_initialize_with_type()

2020-05-12 Thread Masahiro Yamada
On Wed, May 13, 2020 at 3:17 AM Philippe Mathieu-Daudé wrote: > > On 5/12/20 7:31 PM, Masahiro Yamada wrote: > > object_new_with_type() already passes (Object *) pointer. > > Avoid casting back and forth. > > But object_initialize() doesn't... That is no problem. A caller can pass an opaque poin

Re: [PATCH 0/2] use unsigned type for MegasasState fields

2020-05-12 Thread P J P
+-- On Tue, 12 May 2020, Philippe Mathieu-Daudé wrote --+ | Cc'ing Marc-André our signed/unsigned conversion expert (with Paolo). megasas_init_firmware pa_lo = le32_to_cpu(initq->pi_addr_lo); pa_hi = le32_to_cpu(initq->pi_addr_hi); s->producer_pa = ((uint64_t) pa_hi << 32) | pa_lo;

Re: [PATCH v8 74/74] cputlb: queue async flush jobs without the BQL

2020-05-12 Thread Alex Bennée
Robert Foley writes: > From: "Emilio G. Cota" > > This yields sizable scalability improvements, as the below results show. > > Host: Two Intel E5-2683 v3 14-core CPUs at 2.00 GHz (Haswell) > > Workload: Ubuntu 18.04 ppc64 compiling the linux kernel with > "make -j N", where N is the number of

Re: Problem with QEMU usermode + jemalloc

2020-05-12 Thread Peter Maydell
On Tue, 12 May 2020 at 19:16, Michael Goffioul wrote: > I'm running into a problem using QEMU in usermode and jemalloc (this is in > the context of an ARM-to-x86 translation layer for Android). The issue is > discussed here: > > https://github.com/jemalloc/jemalloc/issues/1844 > > In a nutshell,

<    1   2   3   4   >