Re: [PATCH v4 09/13] migration/ram: Consolidate variable reset after placement in ram_load_postcopy()

On 07.05.20 21:00, Dr. David Alan Gilbert wrote: > * David Hildenbrand (da...@redhat.com) wrote: >> On 07.05.20 17:42, Dr. David Alan Gilbert wrote: >>> * Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: * David Hildenbrand (da...@redhat.com) wrote: > Let's consolidate resetting the var

[Bug 1877526] [NEW] KVM internal crash

Public bug reported: Hi, I am new to this. (apologies if I miss something) I see the following error on my host mc when I run an application on my QEMU based VM running ubuntu linux: Code=4d 39 c8 7f 64 0f 1f 40 00 4d 8d 40 80 49 81 f8 80 00 00 00 <66> 0f 7f 07 66 0f 7f 47 10 66 0f 7f 47 20 66

Re: [PATCH] block/block-copy: fix use-after-free of task pointer

On 07.05.20 20:38, Vladimir Sementsov-Ogievskiy wrote: > Obviously, we should g_free the task after trace point and offset > update. > > Reported-by: Coverity > Fixes: 4ce5dd3e9b5ee0fac18625860eb3727399ee965e > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > > Be free to add Coverity number

Re: [PATCH 1/2] migration/rdma: fix potential nullptr access in rdma_start_incoming_migration

Pan Nengyuan wrote: > 'rdma' is NULL when taking the first error branch in > rdma_start_incoming_migration. > And it will cause a null pointer access in label 'err'. Fix that. > > Fixes: 59c59c67ee6b0327ae932deb303caa47919aeb1e > Signed-off-by: Pan Nengyuan Reviewed-by: Juan Quintela good cat

Re: [PATCH 2/2] migration/rdma: cleanup rdma context before g_free to avoid memleaks

Pan Nengyuan wrote: > When error happen in initializing 'rdma_return_path', we should cleanup rdma > context > before g_free(rdma) to avoid some memleaks. This patch fix that. > > Reported-by: Euler Robot > Signed-off-by: Pan Nengyuan Reviewed-by: Juan Quintela Another good catch.

Re: [PATCH v4 3/6] net/colo-compare.c: Fix deadlock in compare_chr_send

On Fri, 8 May 2020 06:28:45 + "Zhang, Chen" wrote: > > -Original Message- > > From: Lukas Straub > > Sent: Friday, May 8, 2020 2:08 PM > > To: Zhang, Chen > > Cc: qemu-devel ; Li Zhijian > > ; Jason Wang ; Marc- > > André Lureau ; Paolo Bonzini > > > > Subject: Re: [PATCH v4 3/6] n

Re: [PATCH 01/10] exec: Rename qemu_ram_writeback() as qemu_ram_msync()

Philippe Mathieu-Daudé wrote: > Rename qemu_ram_writeback() as qemu_ram_msync() to better > match what it does. > > Suggested-by: Stefan Hajnoczi > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Juan Quintela if block people preffers that name, who I am to complain.

Re: [PATCH 04/10] exec/memory-internal: Check CONFIG_SOFTMMU instead of CONFIG_USER_ONLY

Philippe Mathieu-Daudé wrote: > The CONFIG_SOFTMMU definition is poisoned in "exec/poison.h". > As this header is internal, check for poisoned CONFIG_SOFTMMU > instead of CONFIG_USER_ONLY to make this include harder to use. > > Signed-off-by: Philippe Mathieu-Daudé > Reviewed-by: Juan Quintela

Re: [PATCH 02/10] exec/ramblock: Add missing 'qemu/rcu.h' include

Philippe Mathieu-Daudé wrote: > The first field of RAMBlock is a rcu_head structure. > We need to include the "qemu/rcu.h" to avoid errors when > including "exec/ramblock.h" without "qemu/rcu.h": > > include/exec/ramblock.h:27:21: error: field ‘rcu’ has incomplete type > 27 | struct rcu

Re: [PATCH 05/10] exec: Move qemu_minrampagesize/qemu_maxrampagesize to 'qemu-common.h'

Philippe Mathieu-Daudé wrote: > Move these generic functions to a more common place, with other > functions related to host page size. Document a little. > > Cc: Alexey Kardashevskiy > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Juan Quintela

[PATCH v2 0/2] accel: Move Xen accelerator code under accel/xen/

Supersedes: <20200507155813.16169-1-phi...@redhat.com> Philippe Mathieu-Daudé (2): exec: Check Xen is enabled before calling the Xen API accel: Move Xen accelerator code under accel/xen/ include/exec/ram_addr.h| 10 -- include/hw/xen/xen.h | 11 -

Re: [PATCH 06/10] exec: Move ramblock_recv_bitmap_offset() to migration/ram.c

Philippe Mathieu-Daudé wrote: > The ramblock_recv_bitmap_offset() function is only used once > in migration/ram.c, move it there. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Juan Quintela But, if you are in the mood: > } > > +static inline unsigned long int ramblock_recv_bitmap_

[PATCH v2 1/2] exec: Check Xen is enabled before calling the Xen API

Signed-off-by: Philippe Mathieu-Daudé --- include/exec/ram_addr.h | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/include/exec/ram_addr.h b/include/exec/ram_addr.h index 5e59a3d8d7..dd8713179e 100644 --- a/include/exec/ram_addr.h +++ b/include/exec/ram_addr.h @@ -330,7

[PATCH v2 2/2] accel: Move Xen accelerator code under accel/xen/

This code is not related to hardware emulation. Move it under accel/ with the other hypervisors. Reviewed-by: Paul Durrant Signed-off-by: Philippe Mathieu-Daudé --- We could also move the memory management functions from hw/i386/xen/xen-hvm.c but it is not trivial. v2: Use g_assert_not_reached(

Re: [PATCH 07/10] exec: Move all RAMBlock functions to 'exec/ramblock.h'

Philippe Mathieu-Daudé wrote: > The RAMBlock API was dispersed in 3 different headers. > One of these headers, "exec/ram_addr.h", is restricted > to target dependent code. However these functions are > not target specific. Move all functions into a single > place. Now all these functions can be a

Re: [PATCH 08/10] hw/block: Let the NVMe emulated device be target-agnostic

Philippe Mathieu-Daudé wrote: > Now than qemu_ram_msync() has been ... > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Juan Quintela

Re: [PATCH 10/10] exec: Move cpu_physical_memory_* functions to 'exec/memory-internal.h'

Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé Once here, can someone give a test that meassures if it makes sense that this functions are inline? They are relatively big, and I would preffer them to be in a .c file, but I have no clue about how performance critical they a

Re: [PATCH 5/5] hw/arm/virt: Let the virtio-iommu bypass MSIs

On Thu, May 07, 2020 at 04:32:01PM +0200, Eric Auger wrote: > At the moment the virtio-iommu translates MSI transactions. > This behavior is inherited from ARM SMMU. The virt machine > code knows where the guest MSI doorbells are so we can easily > declare those regions as VIRTIO_IOMMU_RESV_MEM_T_M

Re: [PATCH 00/10] exec: Shear 'exec/ram_addr.h' and make NVMe device target-agnostic

Paolo Bonzini wrote: > On 07/05/20 19:39, Philippe Mathieu-Daudé wrote: >> Stefan suggested to make qemu_ram_writeback() target agnostic, >> Paolo to add memory_region_msync(), and Peter to remove >> "exec/ram_addr.h" [*]. >> >> I let a single function in this file, >> cpu_physical_memory_sync_di

Re: [PATCH v2 1/2] exec: Check Xen is enabled before calling the Xen API

Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > include/exec/ram_addr.h | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/include/exec/ram_addr.h b/include/exec/ram_addr.h > index 5e59a3d8d7..dd8713179e 100644 > --- a/include/exec/ram_

Re: [PATCH 5/5] hw/arm/virt: Let the virtio-iommu bypass MSIs

Hi Jean-Philippe, On 5/8/20 10:21 AM, Jean-Philippe Brucker wrote: > On Thu, May 07, 2020 at 04:32:01PM +0200, Eric Auger wrote: >> At the moment the virtio-iommu translates MSI transactions. >> This behavior is inherited from ARM SMMU. The virt machine >> code knows where the guest MSI doorbells

Re: [PATCH] ppc/pnv: Fix NMI system reset SRR1 value

On Thu, 7 May 2020 23:51:54 +1000 David Gibson wrote: > On Thu, May 07, 2020 at 09:48:24PM +1000, Nicholas Piggin wrote: > > Commit a77fed5bd926 ("ppc/pnv: Add support for NMI interface") got the Please note that the culprit patch was merged with a different SHA1: https://git.qemu.org/?p=qemu.g

Re: [PATCH v3 06/10] iotests: add testfinder.py

Am 07.05.2020 um 19:43 hat Vladimir Sementsov-Ogievskiy geschrieben: > 21.04.2020 19:56, Kevin Wolf wrote: > > Am 21.04.2020 um 09:35 hat Vladimir Sementsov-Ogievskiy geschrieben: > > > Add python script with new logic of searching for tests: > > > > > > Current ./check behavior: > > > - tests a

Re: Emulating Solaris 10 on SPARC64 sun4u

I see the same behaviour as reported here when booting current SPARC illumos (illumos is the ongoing fork of OpenSolaris) under qemu - looks like it's booted up fine, but I can't type anything on the console. While I'm an illumos developer, and maintain it on SPARC, I'm unfamiliar with most of the

Re: [PATCH 09/10] exec: Update coding style to make checkpatch.pl happy

Philippe Mathieu-Daudé wrote: > We will move this code in the next commit. Clean it up > first to avoid checkpatch.pl errors. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Juan Quintela

Re: [PATCH V3 04/14] KVM: MIPS: Add EVENTFD support which is needed by VHOST

нед, 3. мај 2020. у 12:09 Huacai Chen је написао/ла: > > Add EVENTFD support for KVM/MIPS, which is needed by VHOST. Tested on > Loongson-3 platform. > > Signed-off-by: Huacai Chen > Co-developed-by: Jiaxun Yang > --- Perhaps this patch needs rebasing to land cleanly into master. But, in gener

Re: [PATCH 05/10] exec: Move qemu_minrampagesize/qemu_maxrampagesize to 'qemu-common.h'

On Thu, 7 May 2020 19:39:53 +0200 Philippe Mathieu-Daudé wrote: > Move these generic functions to a more common place, with other > functions related to host page size. Document a little. > > Cc: Alexey Kardashevskiy > Signed-off-by: Philippe Mathieu-Daudé > --- > include/exec/ram_addr.h

Re: [PATCH 2/5] virtio-iommu: Implement RESV_MEM probe request

On Thu, May 07, 2020 at 04:31:58PM +0200, Eric Auger wrote: > +static ssize_t virtio_iommu_fill_resv_mem_prop(VirtIOIOMMU *s, uint32_t ep, > + uint8_t *buf, size_t free) > +{ > +struct virtio_iommu_probe_resv_mem prop = {}; > +size_t size = size

Re: [PATCH 06/10] exec: Move ramblock_recv_bitmap_offset() to migration/ram.c

On 5/8/20 10:07 AM, Juan Quintela wrote: Philippe Mathieu-Daudé wrote: The ramblock_recv_bitmap_offset() function is only used once in migration/ram.c, move it there. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Juan Quintela But, if you are in the mood: } +static inline unsi

Re: [PATCH v2 1/2] exec: Check Xen is enabled before calling the Xen API

Hi Juan, On 5/8/20 10:39 AM, Juan Quintela wrote: Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- include/exec/ram_addr.h | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/include/exec/ram_addr.h b/include/exec/ram_addr.h index 5e59a3d8d7..

Re: [PATCH 07/10] exec: Move all RAMBlock functions to 'exec/ramblock.h'

On Thu, 7 May 2020 19:39:55 +0200 Philippe Mathieu-Daudé wrote: > The RAMBlock API was dispersed in 3 different headers. > One of these headers, "exec/ram_addr.h", is restricted > to target dependent code. However these functions are > not target specific. Move all functions into a single > plac

Re: [PATCH v3 06/10] iotests: add testfinder.py

08.05.2020 11:49, Kevin Wolf wrote: Am 07.05.2020 um 19:43 hat Vladimir Sementsov-Ogievskiy geschrieben: 21.04.2020 19:56, Kevin Wolf wrote: Am 21.04.2020 um 09:35 hat Vladimir Sementsov-Ogievskiy geschrieben: Add python script with new logic of searching for tests: Current ./check behavior:

how to run qemu test

Hi all,    I am having trouble running qemu tests. basically ,can not run check-tcg and check-unit.   Before executing the tests, I did the configuration?? configure --target-list=sparc-softmmu --cross-prefix=x86_64-w64-mingw32- --enable-gtk --enable-sdl --enable-debug   The source code is built

[PATCH v3] accel: Move Xen accelerator code under accel/xen/

This code is not related to hardware emulation. Move it under accel/ with the other hypervisors. Reviewed-by: Paul Durrant Signed-off-by: Philippe Mathieu-Daudé --- We could also move the memory management functions from hw/i386/xen/xen-hvm.c but it is not trivial. v2: Use g_assert_not_reached(

qemu-devel@nongnu.org

нед, 3. мај 2020. у 12:06 Huacai Chen је написао/ла: > > From: Xing Li > > The code in decode_config4() of arch/mips/kernel/cpu-probe.c > > asid_mask = MIPS_ENTRYHI_ASID; > if (config4 & MIPS_CONF4_AE) > asid_mask |= MIPS_ENTRYHI_ASIDX; > set_cpu_asid_mask(

Re: [PATCH V3 04/14] KVM: MIPS: Add EVENTFD support which is needed by VHOST

пет, 8. мај 2020. у 11:08 Aleksandar Markovic је написао/ла: > > нед, 3. мај 2020. у 12:09 Huacai Chen је написао/ла: > > > > Add EVENTFD support for KVM/MIPS, which is needed by VHOST. Tested on > > Loongson-3 platform. > > > > Signed-off-by: Huacai Chen > > Co-developed-by: Jiaxun Yang > > --

Re: [PATCH V3 02/14] KVM: MIPS: Fix VPN2_MASK definition for variable cpu_vmbits

нед, 3. мај 2020. у 12:07 Huacai Chen је написао/ла: > > From: Xing Li > > If a CPU support more than 32bit vmbits (which is true for 64bit CPUs), > VPN2_MASK set to fixed 0xe000 will lead to a wrong EntryHi in some > functions such as _kvm_mips_host_tlb_inv(). > > The cpu_vmbits definition o

Re: [PATCH V3 03/14] KVM: MIPS: Increase KVM_MAX_VCPUS and KVM_USER_MEM_SLOTS to 16

нед, 3. мај 2020. у 12:08 Huacai Chen је написао/ла: > > Loongson-3 based machines can have as many as 16 CPUs, and so does > memory slots, so increase KVM_MAX_VCPUS and KVM_USER_MEM_SLOTS to 16. > > Signed-off-by: Huacai Chen > Co-developed-by: Jiaxun Yang > --- > arch/mips/include/asm/kvm_hos

Re: [PATCH V3 05/14] KVM: MIPS: Use lddir/ldpte instructions to lookup gpa_mm.pgd

нед, 3. мај 2020. у 12:11 Huacai Chen је написао/ла: > > Loongson-3 can use lddir/ldpte instuctions to accelerate page table > walking, so use them to lookup gpa_mm.pgd. > > Signed-off-by: Huacai Chen > Co-developed-by: Jiaxun Yang > --- > arch/mips/kvm/entry.c | 19 ++- > 1 fil

[PATCH] cpus: Fix botched configure_icount() error API violation fix

Fixes: abc9bf69a66a11499a801ff545b8fe7adbb3a04c Fixes: Coverity CID 1428754 Signed-off-by: Markus Armbruster --- cpus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpus.c b/cpus.c index 5670c96bcf..b9275c672d 100644 --- a/cpus.c +++ b/cpus.c @@ -813,7 +813,7 @@ void config

Re: [PATCH V3 06/14] KVM: MIPS: Introduce and use cpu_guest_has_ldpte

нед, 3. мај 2020. у 12:11 Huacai Chen је написао/ла: > > Loongson-3 has lddir/ldpte instructions and their related CP0 registers > are the same as HTW. So we introduce a cpu_guest_has_ldpte flag and use > it to indicate whether we need to save/restore HTW related CP0 registers > (PWBase, PWSize, P

Re: [PATCH V3 07/14] KVM: MIPS: Use root tlb to control guest's CCA for Loongson-3

нед, 3. мај 2020. у 12:12 Huacai Chen је написао/ла: > > KVM guest has two levels of address translation: guest tlb translates > GVA to GPA, and root tlb translates GPA to HPA. By default guest's CCA > is controlled by guest tlb, but Loongson-3 maintains all cache coherency > by hardware (includin

Re: [PATCH V3 08/14] KVM: MIPS: Let indexed cacheops cause guest exit on Loongson-3

нед, 3. мај 2020. у 12:13 Huacai Chen је написао/ла: > > Loongson-3's indexed cache operations need a node-id in the address, > but in KVM guest the node-id may be incorrect. So, let indexed cache > operations cause guest exit on Loongson-3. > > Signed-off-by: Huacai Chen > Co-developed-by: Jiaxu

Re: [PATCH v3] accel: Move Xen accelerator code under accel/xen/

Philippe Mathieu-Daudé wrote: > This code is not related to hardware emulation. > Move it under accel/ with the other hypervisors. > > Reviewed-by: Paul Durrant > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Juan Quintela

Re: [PATCH v3 2/2] char-socket: initialize reconnect timer only when the timer doesn't start

On Fri, May 8, 2020 at 7:14 AM Li Feng wrote: > > When the disconnect event is triggered in the connecting stage, > the tcp_chr_disconnect_locked may be called twice. > > The first call: > #0 qemu_chr_socket_restart_timer (chr=0x5582ee90) at > chardev/char-socket.c:120 > #1 0x55

[PATCH v3 02/11] net: cadence_gem: Fix the queue address update during wrap around

During wrap around and reset, queues are pointing to initial base address of queue 0, irrespective of what queue we are dealing with. Fix it by assigning proper base address every time. Signed-off-by: Sai Pavan Boddu --- hw/net/cadence_gem.c | 37 + 1 file cha

[PATCH v3 01/11] net: cadence_gem: Fix debug statements

Enabling debug breaks the build, Fix them and make debug statements always compilable. Fix few statements to use sized integer casting. Signed-off-by: Sai Pavan Boddu --- hw/net/cadence_gem.c | 27 +-- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/hw/net

[PATCH v3 09/11] net: cadence_gem: Update the reset value for interrupt mask register

Mask all interrupt on reset. Signed-off-by: Sai Pavan Boddu Reviewed-by: Edgar E. Iglesias --- hw/net/cadence_gem.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/net/cadence_gem.c b/hw/net/cadence_gem.c index 65b29cc..45c7390 100644 --- a/hw/net/cadence_gem.c +++ b/hw/net/cadence_gem.c

[PATCH v3 04/11] net: cadence_gem: Define access permission for interrupt registers

Q1 to Q7 ISR's are clear-on-read, IER/IDR registers are write-only, mask reg are read-only. Signed-off-by: Sai Pavan Boddu Reviewed-by: Edgar E. Iglesias --- hw/net/cadence_gem.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/hw/net/cadence_gem.c b/hw/net/cadence_gem.c inde

[PATCH v3 07/11] net: cadence_gem: Add support for jumbo frames

Add a property "jumbo-max-len", which can be configured for jumbo frame size up to 16,383 bytes, and also introduce new register GEM_JUMBO_MAX_LEN. Signed-off-by: Sai Pavan Boddu --- hw/net/cadence_gem.c | 21 +++-- include/hw/net/cadence_gem.h | 1 + 2 files changed, 20

[PATCH v3 03/11] net: cadence_gem: Fix irq update w.r.t queue

Set irq's specific to a queue, present implementation is setting q1 irq based on q0 status. Signed-off-by: Sai Pavan Boddu Reviewed-by: Edgar E. Iglesias --- hw/net/cadence_gem.c | 25 +++-- 1 file changed, 3 insertions(+), 22 deletions(-) diff --git a/hw/net/cadence_gem.c

[PATCH v3 05/11] net: cadence_gem: Set ISR according to queue in use

Set ISR according to queue in use, added interrupt support for all queues. Signed-off-by: Sai Pavan Boddu Reviewed-by: Edgar E. Iglesias --- hw/net/cadence_gem.c | 27 +-- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git a/hw/net/cadence_gem.c b/hw/net/caden

[PATCH v3 10/11] net: cadence_gem: TX_LAST bit should be set by guest

TX_LAST bit should not be set by hardware, its set by guest to inform the last bd of the frame. Signed-off-by: Sai Pavan Boddu Signed-off-by: Edgar E. Iglesias Reviewed-by: Edgar E. Iglesias --- hw/net/cadence_gem.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/hw/net/cadence_gem.c

[PATCH v3 06/11] net: cadence_gem: Move tx/rx packet buffert to CadenceGEMState

Moving this buffers to CadenceGEMState, as their size will be increased more when JUMBO frames support is added. Signed-off-by: Sai Pavan Boddu --- hw/net/cadence_gem.c | 52 ++-- include/hw/net/cadence_gem.h | 2 ++ 2 files changed, 33 insertions

[PATCH v3 08/11] net: cadnece_gem: Update irq_read_clear field of designcfg_debug1 reg

Advertise support of clear-on-read for ISR registers. Signed-off-by: Sai Pavan Boddu Reviewed-by: Edgar E. Iglesias --- hw/net/cadence_gem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/cadence_gem.c b/hw/net/cadence_gem.c index 45c50ab..65b29cc 100644 --- a/hw/net

[PATCH v3 11/11] net: cadence_gem: Fix RX address filtering

From: Tong Ho Two defects are fixed: 1/ Detection of multicast frames 2/ Treating drop of mis-addressed frames as non-error Signed-off-by: Tong Ho Signed-off-by: Edgar E. Iglesias Signed-off-by: Sai Pavan Boddu Reviewed-by: Edgar E. Iglesias --- hw/net/cadence_gem.c | 26 +++---

Re: [PATCH V3 10/14] KVM: MIPS: Add Loongson-3 Virtual IPI interrupt support

нед, 3. мај 2020. у 12:14 Huacai Chen је написао/ла: > > This patch add Loongson-3 Virtual IPI interrupt support in the kernel, > because emulate it in QEMU is too expensive for performance. > Huacei, hi! While, in principle, I support this patch, could you please, just for the sake of everybody

[PATCH v3 00/11] Cadence GEM Fixes

Hi, Following patch series fixes issues with priority queues, Adds JUMBO Frame support, Makes Debug statements compilable & Fixes related to multicast frames. Changes for V2: Fixed build failure on fedora docker machine Fix buggy debug print to use sized integer casting Changes fo

Re: [PATCH v3 01/11] net: cadence_gem: Fix debug statements

On Fri, May 08, 2020 at 04:30:35PM +0530, Sai Pavan Boddu wrote: > Enabling debug breaks the build, Fix them and make debug statements > always compilable. Fix few statements to use sized integer casting. Reviewed-by: Edgar E. Iglesias > > Signed-off-by: Sai Pavan Boddu > --- > hw/net/caden

Re: [PATCH v3 02/11] net: cadence_gem: Fix the queue address update during wrap around

On Fri, May 08, 2020 at 04:30:36PM +0530, Sai Pavan Boddu wrote: > During wrap around and reset, queues are pointing to initial base > address of queue 0, irrespective of what queue we are dealing with. > Fix it by assigning proper base address every time. Reviewed-by: Edgar E. Iglesias > > S

Re: [PATCH v3 06/11] net: cadence_gem: Move tx/rx packet buffert to CadenceGEMState

On Fri, May 08, 2020 at 04:30:40PM +0530, Sai Pavan Boddu wrote: > Moving this buffers to CadenceGEMState, as their size will be increased > more when JUMBO frames support is added. > > Signed-off-by: Sai Pavan Boddu > --- > hw/net/cadence_gem.c | 52 > ++

Re: [PATCH v2 2/6] blockdev: Split off basic bitmap operations for qemu-img

Am 30.04.2020 um 16:50 hat Eric Blake geschrieben: > On 4/30/20 8:59 AM, Max Reitz wrote: > > On 21.04.20 23:20, Eric Blake wrote: > > > Upcoming patches want to add some basic bitmap manipulation abilities > > > to qemu-img. But blockdev.o is too heavyweight to link into qemu-img > > > (among oth

Re: how to run qemu test

casmac <1482995...@qq.com> writes: > Hi all, >    I am having trouble running qemu tests. basically ,can not run > check-tcg and check-unit. >   Before executing the tests, I did the configuration： configure > --target-list=sparc-softmmu --cross-prefix=x86_64-w64-mingw32- --enable-gtk > --ena

Re: [PATCH V3 00/14] KVM: MIPS: Add Loongson-3 support (Host Side)

нед, 3. мај 2020. у 12:06 Huacai Chen је написао/ла: > > We are preparing to add KVM support for Loongson-3. VZ extension is > fully supported in Loongson-3A R4+, and we will not care about old CPUs > (at least now). We already have a full functional Linux kernel (based > on Linux-5.4.x LTS) and Q

Re: [PATCH v3 07/11] net: cadence_gem: Add support for jumbo frames

On Fri, May 08, 2020 at 04:30:41PM +0530, Sai Pavan Boddu wrote: > Add a property "jumbo-max-len", which can be configured for jumbo frame size > up to 16,383 bytes, and also introduce new register GEM_JUMBO_MAX_LEN. > > Signed-off-by: Sai Pavan Boddu > --- > hw/net/cadence_gem.c | 21 ++

Re: [PATCH v5 20/31] qcow2: Add subcluster support to qcow2_get_host_offset()

On Wed 06 May 2020 07:55:29 PM CEST, Eric Blake wrote: > On 5/5/20 12:38 PM, Alberto Garcia wrote: >> The logic of this function remains pretty much the same, except that >> it uses count_contiguous_subclusters(), which combines the logic of >> count_contiguous_clusters() / count_contiguous_cluster

Re: [PATCH V3 13/14] KVM: MIPS: Add more MMIO load/store instructions emulation

нед, 3. мај 2020. у 12:16 Huacai Chen је написао/ла: > > This patch add more MMIO load/store instructions emulation, which can > be observed in QXL and some other device drivers: > > 1, LWL, LWR, LDW, LDR, SWL, SWR, SDL and SDR for all MIPS; > 2, GSLBX, GSLHX, GSLWX, GSLDX, GSSBX, GSSHX, GSSWX and

Re: [PATCH V3 09/14] KVM: MIPS: Add more types of virtual interrupts

нед, 3. мај 2020. у 12:13 Huacai Chen је написао/ла: > > In current implementation, MIPS KVM uses IP2, IP3, IP4 and IP7 for > external interrupt, two kinds of IPIs and timer interrupt respectively, > but Loongson-3 based machines prefer to use IP2, IP3, IP6 and IP7 for > two kinds of external inte

Re: [PATCH v2 09/18] s390x/cpumodel: Fix UI to CPU features pcc-cmac-{aes, eaes}-256

David Hildenbrand writes: > On 05.05.20 17:29, Markus Armbruster wrote: >> Both s390_features[S390_FEAT_PCC_CMAC_AES_256].name and >> s390_features[S390_FEAT_PCC_CMAC_EAES_256].name is >> "pcc-cmac-eaes-256". The former is obviously a pasto. >> >> Impact: >> >> * s390_feat_bitmap_to_ascii() mi

Re: [PATCH v2 09/18] s390x/cpumodel: Fix UI to CPU features pcc-cmac-{aes, eaes}-256

Cornelia Huck writes: > On Tue, 5 May 2020 17:29:17 +0200 > Markus Armbruster wrote: > >> Both s390_features[S390_FEAT_PCC_CMAC_AES_256].name and >> s390_features[S390_FEAT_PCC_CMAC_EAES_256].name is >> "pcc-cmac-eaes-256". The former is obviously a pasto. >> >> Impact: >> >> * s390_feat_bit

Re: [PATCH v3 2/2] char-socket: initialize reconnect timer only when the timer doesn't start

Have you applied the first one? io/channel: fix crash when qio_channel_readv_all return 0 Thanks, Feng Li Marc-André Lureau 于2020年5月8日周五 下午7:01写道： > > On Fri, May 8, 2020 at 7:14 AM Li Feng wrote: > > > > When the disconnect event is triggered in the connecting stage, > > the tcp_chr_disconn

Re: [PATCH v3 2/2] char-socket: initialize reconnect timer only when the timer doesn't start

Hi On Fri, May 8, 2020 at 2:16 PM Li Feng wrote: > > Have you applied the first one? > io/channel: fix crash when qio_channel_readv_all return 0 > Sorry, I missed that one. With that it passes. thanks > Thanks, > > Feng Li > > Marc-André Lureau 于2020年5月8日周五 下午7:01写道： > > > > > On Fri, May 8,

Re: [PATCH v3 2/2] char-socket: initialize reconnect timer only when the timer doesn't start

Thanks! Feng Li Marc-André Lureau 于2020年5月8日周五 下午8:29写道： > > Hi > > On Fri, May 8, 2020 at 2:16 PM Li Feng wrote: > > > > Have you applied the first one? > > io/channel: fix crash when qio_channel_readv_all return 0 > > > > Sorry, I missed that one. With that it passes. thanks > > > Thanks, >

Re: [PATCH v3 1/2] io/channel: fix crash when qio_channel_readv_all return 0

Hi On Fri, May 8, 2020 at 7:14 AM Li Feng wrote: > > Root cause: > From `man recvmsg`, the RETURN VALUE says: > These calls return the number of bytes received, or -1 if an error occurred. > In the event of an error, errno is set to indicate the error. > The return value will be 0 when the peer

Re: [PATCH v2 00/18] qom: Spring cleaning

Paolo, would you like me to do the pull request myself?

[PULL 00/30] Block layer patches

The following changes since commit 1b8c45899715d292398152ba97ef755ccaf84680: Merge remote-tracking branch 'remotes/dgilbert/tags/pull-migration-20200507a' into staging (2020-05-07 18:43:20 +0100) are available in the Git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for

[PULL 01/30] iotests: handle tmpfs

From: Vladimir Sementsov-Ogievskiy Some tests requires O_DIRECT, or want it by default. Introduce smarter O_DIRECT handling: - Check O_DIRECT in common.rc, if it is requested by selected cache-mode. - Support second fall-through argument in _default_cache_mode Inspired-by: Max's 23e1d054112cec

[PULL 03/30] iotests/148: use skip_if_unsupported

From: Vladimir Sementsov-Ogievskiy Skip test-case with quorum if quorum is not whitelisted. Signed-off-by: Vladimir Sementsov-Ogievskiy Message-Id: <20200430124713.3067-4-vsement...@virtuozzo.com> Signed-off-by: Kevin Wolf --- tests/qemu-iotests/148 | 1 + 1 file changed, 1 insertion(+) diff

[PULL 02/30] iotests/082: require bochs

From: Vladimir Sementsov-Ogievskiy Test fails if bochs not whitelisted, so, skip it in this case. Signed-off-by: Vladimir Sementsov-Ogievskiy Message-Id: <20200430124713.3067-3-vsement...@virtuozzo.com> Signed-off-by: Kevin Wolf --- tests/qemu-iotests/082 | 1 + 1 file changed, 1 insertion(+)

[PULL 05/30] iotests/055: refactor compressed backup to vmdk

From: Vladimir Sementsov-Ogievskiy Instead of looping in each test, let's better refactor vmdk target case as a subclass. Signed-off-by: Vladimir Sementsov-Ogievskiy Message-Id: <20200430124713.3067-6-vsement...@virtuozzo.com> Signed-off-by: Kevin Wolf --- tests/qemu-iotests/055 | 70

[PULL 06/30] iotests/055: skip vmdk target tests if vmdk is not whitelisted

From: Vladimir Sementsov-Ogievskiy Signed-off-by: Vladimir Sementsov-Ogievskiy Message-Id: <20200430124713.3067-7-vsement...@virtuozzo.com> Signed-off-by: Kevin Wolf --- tests/qemu-iotests/055 | 4 1 file changed, 4 insertions(+) diff --git a/tests/qemu-iotests/055 b/tests/qemu-iotests/0

[PULL 10/30] vmdk: Rename VmdkMetaData.valid to new_allocation

m_data is used for zero clusters even though valid == 0. It really only means that a new cluster was allocated in the image file. Rename it to reflect this. While at it, change it from int to bool, too. Signed-off-by: Kevin Wolf Message-Id: <20200430133007.170335-2-kw...@redhat.com> Reviewed-by:

[PULL 04/30] iotests/041: drop self.assert_no_active_block_jobs()

From: Vladimir Sementsov-Ogievskiy Drop check for no block-jobs: it's obvious that there no jobs immediately after vm.launch(). Signed-off-by: Vladimir Sementsov-Ogievskiy Message-Id: <20200430124713.3067-5-vsement...@virtuozzo.com> Signed-off-by: Kevin Wolf --- tests/qemu-iotests/041 | 8 ---

[PULL 07/30] iotests/109: mark required formats as required to support whitelisting

From: Vladimir Sementsov-Ogievskiy Signed-off-by: Vladimir Sementsov-Ogievskiy Message-Id: <20200430124713.3067-8-vsement...@virtuozzo.com> Signed-off-by: Kevin Wolf --- tests/qemu-iotests/109 | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/qemu-iotests/109 b/tests/qemu-iotests/109 i

[PULL 11/30] vmdk: Fix zero cluster allocation

m_data must contain valid data even for zero clusters when no cluster was allocated in the image file. Without this, zero writes segfault with images that have zeroed_grain=on. For zero writes, we don't want to allocate a cluster in the image file even in compressed files. Fixes: 524089bce43fd1cd

[PULL 09/30] qcow2: Avoid integer wraparound in qcow2_co_truncate()

From: Alberto Garcia After commit f01643fb8b47e8a70c04bbf45e0f12a9e5bc54de when an image is extended and BDRV_REQ_ZERO_WRITE is set then the new clusters are zeroized. The code however does not detect correctly situations when the old and the new end of the image are within the same cluster. The

[PULL 22/30] gluster: Drop useless has_zero_init callback

From: Eric Blake block.c already defaults to 0 if we don't provide a callback; there's no need to write a callback that always fails. Signed-off-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Alberto Garcia Message-Id: <20200428202905.770727-2-ebl...@redhat.com> Signed-

[PULL 16/30] iotests/283: Use consistent size for source and target

The test case forgot to specify the null-co size for the target node. When adding a check to backup that both sizes match, this would fail because of the size mismatch and not the behaviour that the test really wanted to test. Fixes: a541fcc27c98b96da187c7d4573f3270f3ddd283 Signed-off-by: Kevin Wo

[PULL 08/30] iotests/113: mark bochs as required to support whitelisting

From: Vladimir Sementsov-Ogievskiy Signed-off-by: Vladimir Sementsov-Ogievskiy Message-Id: <20200430124713.3067-9-vsement...@virtuozzo.com> Signed-off-by: Kevin Wolf --- tests/qemu-iotests/113 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/qemu-iotests/113 b/test

[PULL 24/30] nfs: Support BDRV_REQ_ZERO_WRITE for truncate

From: Eric Blake Our .bdrv_has_zero_init_truncate returns 1 if we detect that the OS always 0-fills; we can use that same knowledge to implement BDRV_REQ_ZERO_WRITE by ignoring it when the OS gives it to us for free. Signed-off-by: Eric Blake Message-Id: <20200428202905.770727-4-ebl...@redhat.c

[PULL 23/30] file-win32: Support BDRV_REQ_ZERO_WRITE for truncate

From: Eric Blake When using bdrv_file, .bdrv_has_zero_init_truncate always returns 1; therefore, we can behave just like file-posix, and always implement BDRV_REQ_ZERO_WRITE by ignoring it since the OS gives it to us for free (note that file-posix.c had to use an 'if' because it shared code betwe

[PULL 17/30] backup: Improve error for bdrv_getlength() failure

bdrv_get_device_name() will be an empty string with modern management tools that don't use -drive. Use bdrv_get_device_or_node_name() instead so that the node name is used if the BlockBackend is anonymous. While at it, start with upper case to make the message consistent with the rest of the funct

[PULL 12/30] vmdk: Fix partial overwrite of zero cluster

When overwriting a zero cluster, we must not perform copy-on-write from the backing file, but from a zeroed buffer. Signed-off-by: Kevin Wolf Message-Id: <20200430133007.170335-4-kw...@redhat.com> Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- block/vmdk.c | 18 -- 1 fil

[PULL 25/30] rbd: Support BDRV_REQ_ZERO_WRITE for truncate

From: Eric Blake Our .bdrv_has_zero_init_truncate always returns 1 because rbd always 0-fills; we can use that same knowledge to implement BDRV_REQ_ZERO_WRITE by ignoring it. Signed-off-by: Eric Blake Message-Id: <20200428202905.770727-5-ebl...@redhat.com> Signed-off-by: Kevin Wolf --- block/

[PULL 28/30] parallels: Rework truncation logic

From: Eric Blake The parallels driver tries to use truncation for image growth, but can only do so when reads are guaranteed as zero. Now that we have a way to request zero contents from truncation, we can defer the decision to actual allocation attempts rather than up front, reducing the number

[PULL 20/30] iotests/055: Use cache.no-flush for vmdk target

055 uses the backup block job to create a compressed backup of an $IMGFMT image with both qcow2 and vmdk targets. However, cluster allocation in vmdk is very slow because it flushes the image file after each L2 update. There is no reason why we need this level of safety in this test, so let's disa

[PULL 26/30] sheepdog: Support BDRV_REQ_ZERO_WRITE for truncate

From: Eric Blake Our .bdrv_has_zero_init_truncate always returns 1 because sheepdog always 0-fills; we can use that same knowledge to implement BDRV_REQ_ZERO_WRITE by ignoring it. Signed-off-by: Eric Blake Message-Id: <20200428202905.770727-6-ebl...@redhat.com> Signed-off-by: Kevin Wolf --- b

[PULL 13/30] vmdk: Don't update L2 table for zero write on zero cluster

If a cluster is already zeroed, we don't have to call vmdk_L2update(), which is rather slow because it flushes the image file. Signed-off-by: Kevin Wolf Message-Id: <20200430133007.170335-5-kw...@redhat.com> Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- block/vmdk.c | 2 +- 1 file chan

[PULL 30/30] block: Drop unused .bdrv_has_zero_init_truncate

From: Eric Blake Now that there are no clients of bdrv_has_zero_init_truncate, none of the drivers need to worry about providing it. What's more, this eliminates a source of some confusion: a literal reading of the documentation as written in ceaca56f and implemented in commit 1dcaf527 claims th

[PULL 15/30] iotests: vmdk: Enable zeroed_grained=on by default

In order to avoid bitrot in the zero cluster code in VMDK, enable zeroed_grain=on by default for the tests. 059 now unsets the default options because zeroed_grain=on works only with some subformats and the test case tests many different subformats, including those for which it doesn't work. Sign

  1   2   3   4   >