Patchew URL:
https://patchew.org/QEMU/20200429061054.348b23c0...@aeryn.lan.ktmba/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PATCH] audio/jack: add JACK client audiodev
Message-id: 20200429061054.348b23c0...@aeryn.lan.ktmba
Type:
Hi Christian,
On 4/28/20 8:31 PM, Christian Borntraeger wrote:
We need some little help in the code to reduce the valgrind noise.
- some designated initializers for the cpu model features and subfunctions
^ This could go as trivial patch while we discuss the rest.
- mark memory as defined fo
> On Apr 29, 2020, at 12:27 PM, Michael S. Tsirkin wrote:
>
> On Wed, Apr 29, 2020 at 06:54:52AM +, Ani Sinha wrote:
>>
>>
>>> On Apr 29, 2020, at 12:22 PM, Michael S. Tsirkin wrote:
>>>
>>> On Wed, Apr 29, 2020 at 06:11:20AM +, Ani Sinha wrote:
> On Apr 29, 2020, a
On 4/29/2020 12:23 AM, Joao Martins wrote:
On 4/15/20 4:35 AM, Jingqi Liu wrote:
Add a pair of configure options --{enable,disable}-libdaxctl to control
whether QEMU is compiled with libdaxctl [1]. Libdaxctl is a utility
library for managing the device dax subsystem.
QEMU uses mmap(2) to maps v
On Tue, 28 Apr 2020 18:34:18 +0200
Markus Armbruster wrote:
> chassis_from_bus() uses object_property_get_uint() to get property
> "chassis_nr" of the bridge device. Failure would be a programming
> error. Pass &error_abort, and simplify its callers.
>
> Cc: David Gibson
> Cc: qemu-...@nongnu
+Peter for crediting his advice.
On 4/29/20 7:59 AM, Markus Armbruster wrote:
Philippe Mathieu-Daudé writes:
On 4/24/20 9:20 PM, Markus Armbruster wrote:
The Error ** argument must be NULL, &error_abort, &error_fatal, or a
pointer to a variable containing NULL. Passing an argument of the
la
Queued.
Queued.
Queued.
Markus Armbruster writes:
> ... the comment next to qos_set_machines_devices_available() wonders.
> Yup, there is!
Queued.
qemu-img create, convert, amend, and measure use accumulate_options()
to merge multiple -o options. This is broken for -o "":
$ qemu-img create -f qcow2 -o backing_file=a -o "" -o
backing_fmt=raw,size=1M new.qcow2
qemu-img: warning: Could not verify backing image. This may become an erro
The next commits will put it to use.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Reviewed-by: Kevin Wolf
Message-Id: <20200415074927.19897-3-arm...@redhat.com>
---
util/qemu-option.c | 102 +
1 file changed, 56 insertions(+), 46 deletion
The following changes since commit fdd76fecdde1ad444ff4deb7f1c4f7e4a1ef97d6:
Update version for v5.0.0 release (2020-04-28 17:46:57 +0100)
are available in the Git repository at:
git://repo.or.cz/qemu/armbru.git tags/pull-misc-2020-04-29
for you to fetch changes up to 8ef3a4be27efccd791d05e
When opts_parse() sets @invalidp to true, qemu_opts_parse_noisily()
uses has_help_option() to decide whether to print help. This parses
the input string a second time.
Easy to avoid: replace @invalidp by @help_wanted.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Message-Id: <202004
The Error ** argument must be NULL, &error_abort, &error_fatal, or a
pointer to a variable containing NULL. Passing an argument of the
latter kind twice without clearing it in between is wrong: if the
first call sets an error, it no longer points to NULL for the second
qmp_guest_suspend_disk() an
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Reviewed-by: Kevin Wolf
Message-Id: <20200415074927.19897-8-arm...@redhat.com>
---
qemu-img.c | 59 +-
1 file changed, 23 insertions(+), 36 deletions(-)
diff --git a/qemu-img.c b/qemu-i
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Reviewed-by: Kevin Wolf
Message-Id: <20200415074927.19897-4-arm...@redhat.com>
---
tests/test-qemu-opts.c | 4 ++--
util/qemu-option.c | 27 +++
2 files changed, 21 insertions(+), 10 deletions(-)
diff --git a
has_help_option() uses its own parser. It's inconsistent with
qemu_opts_parse(), as demonstrated by test-qemu-opts case
/qemu-opts/has_help_option. Fix by reusing the common parser.
Signed-off-by: Markus Armbruster
Message-Id: <20200415074927.19897-5-arm...@redhat.com>
Reviewed-by: Eric Blake
Requesting 32 or 64 MiB of RAM with the sam460ex machine type produces
a useless warning:
qemu-system-ppc: warning: Memory size is too small for SDRAM type,
adjusting type
This is because sam460ex_init() asks spd_data_generate() for DDR2,
which is impossible, so spd_data_generate() corrects
The two turn out to be inconsistent for "a,b,,help". Test case
marked /* BUG */.
Signed-off-by: Markus Armbruster
Message-Id: <20200415074927.19897-2-arm...@redhat.com>
Reviewed-by: Eric Blake
---
tests/test-qemu-opts.c | 44 ++
1 file changed, 44 insert
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Reviewed-by: Kevin Wolf
Message-Id: <20200415074927.19897-6-arm...@redhat.com>
---
tests/test-qemu-opts.c | 36 +---
1 file changed, 17 insertions(+), 19 deletions(-)
diff --git a/tests/test-qemu-opts.c b/
Signed-off-by: Markus Armbruster
Message-Id: <20200424071142.3525-4-arm...@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé
---
tests/qtest/libqos/qos_external.h | 2 --
tests/qtest/libqos/qos_external.c | 2 +-
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/tests/qtest/libqos/qos_
Improve
$ ppc-softmmu/qemu-system-ppc -M sam460ex -m 4096
qemu-system-ppc: Max 1 banks of 2048 ,1024 ,512 ,256 ,128 ,64 ,32 MB
DIMM/bank supported
qemu-system-ppc: Possible valid RAM size: 2048
to
qemu-system-ppc: at most 1 bank of 2048, 1024, 512, 256, 128, 64, 32 MiB
each sup
The Error ** argument must be NULL, &error_abort, &error_fatal, or a
pointer to a variable containing NULL. Passing an argument of the
latter kind twice without clearing it in between is wrong: if the
first call sets an error, it no longer points to NULL for the second
call.
qio_channel_socket_cl
fdctrl_realize_common() rejects fallback=auto. Used by devices
"isa-fdc", "sysbus-fdc", "SUNW,fdtwo". The error handling is broken:
$ qemu-system-x86_64 -nodefaults -device isa-fdc,fallback=auto,driveA=fd0
-drive if=none,id=fd0
**
ERROR:/work/armbru/qemu/hw/block/fdc.c:434:pick_driv
is_valid_option_list()'s purpose is ensuring qemu-img.c's can safely
join multiple parameter strings separated by ',' like this:
g_strdup_printf("%s,%s", params1, params2);
How it does that is anything but obvious. A close reading of the code
reveals that it fails exactly when its argume
The conversion of xen_pt_initfn() to xen_pt_realize() blindly replaced
XEN_PT_ERR() by error_setg(). Several error conditions that did not
fail xen_pt_initfn() now fail xen_pt_realize(). Unsurprisingly, the
cleanup on these errors looks highly suspicious.
Revert the inappropriate replacements.
From: Masahiro Yamada
The second argument 'id' is a pointer. Pass NULL rather than 0.
Signed-off-by: Masahiro Yamada
Message-Id: <20200427005704.2475782-1-masahi...@kernel.org>
Reviewed-by: Markus Armbruster
Signed-off-by: Markus Armbruster
---
softmmu/vl.c | 10 +-
1 file changed, 5
From: Philippe Mathieu-Daudé
Fixes the following coccinelle warnings:
$ spatch --sp-file --verbose-parsing ... \
scripts/coccinelle/remove_local_err.cocci
...
SUSPICIOUS: a \ character appears outside of a #define at
./target/ppc/translate_init.inc.c:5213
SUSPICIOUS: a \ characte
The Error ** argument must be NULL, &error_abort, &error_fatal, or a
pointer to a variable containing NULL. Passing an argument of the
latter kind twice without clearing it in between is wrong: if the
first call sets an error, it no longer points to NULL for the second
call.
virt_machine_device_p
spd_data_generate() splits @ram_size bytes into @nbanks RAM banks of
1 << sz_log2 MiB each, like this:
size = ram_size >> 20; /* work in terms of megabytes */
[...]
nbanks = 1;
while (sz_log2 > max_log2 && nbanks < 8) {
sz_log2--;
nbanks++;
}
Each iteration hal
The Error ** argument must be NULL, &error_abort, &error_fatal, or a
pointer to a variable containing NULL. Passing an argument of the
latter kind twice without clearing it in between is wrong: if the
first call sets an error, it no longer points to NULL for the second
call.
cryptodev_builtin_cle
The Error ** argument must be NULL, &error_abort, &error_fatal, or a
pointer to a variable containing NULL. Passing an argument of the
latter kind twice without clearing it in between is wrong: if the
first call sets an error, it no longer points to NULL for the second
call.
configure_icount() is
The Error ** argument must be NULL, &error_abort, &error_fatal, or a
pointer to a variable containing NULL. Passing an argument of the
latter kind twice without clearing it in between is wrong: if the
first call sets an error, it no longer points to NULL for the second
call.
spd_data_generate() c
The Error ** argument must be NULL, &error_abort, &error_fatal, or a
pointer to a variable containing NULL. Passing an argument of the
latter kind twice without clearing it in between is wrong: if the
first call sets an error, it no longer points to NULL for the second
call.
qmp_guest_get_memory_
Target recurse-fuzz depends on pc-bios/optionrom/fuzz, which can't be
made. It's not used anywhere. Added in commit c621dc3e01c, looks
like cargo cult. Delete.
Signed-off-by: Markus Armbruster
Message-Id: <20200424071142.3525-2-arm...@redhat.com>
Reviewed-by: Alexander Bulekov
---
Makefile |
On 29.04.20 09:00, Philippe Mathieu-Daudé wrote:
> Hi Christian,
>
> On 4/28/20 8:31 PM, Christian Borntraeger wrote:
>> We need some little help in the code to reduce the valgrind noise.
>> - some designated initializers for the cpu model features and subfunctions
>
> ^ This could go as trivi
bochs_display_realize() rejects out-of-range vgamem. The error
handling is broken:
$ qemu-system-x86_64 -S -display none -monitor stdio
QEMU 4.2.93 monitor - type 'help' for more information
(qemu) device_add bochs-display,vgamem=1
Error: bochs-display: video memory too small
apply_to_qlist(), apply_to_node() work with QObjects. This is
designed for use by tests/qtest/qos-test.c, which gets the data in
that form via QMP. Goes back to commit fc281c8020 "tests: qgraph API
for the qtest driver framework".
Commit 275ab39d86 "fuzz: add support for qos-assisted fuzz target
virtio_net_device_realize() rejects invalid duplex and speed values.
The error handling is broken:
$ ../qemu/bld-sani/x86_64-softmmu/qemu-system-x86_64 -S -display none
-monitor stdio
QEMU 4.2.93 monitor - type 'help' for more information
(qemu) device_add virtio-net,duplex=x
Erro
Fixes: 58e19e6e7914354242a67442d0006f9e31684d1a
Signed-off-by: Markus Armbruster
Message-Id: <20200422130719.28225-13-arm...@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé
---
tests/test-logging.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/test-logging.c b/tes
The Error ** argument must be NULL, &error_abort, &error_fatal, or a
pointer to a variable containing NULL. Passing an argument of the
latter kind twice without clearing it in between is wrong: if the
first call sets an error, it no longer points to NULL for the second
call.
qmp_xen_colo_do_check
On 4/27/20 8:16 PM, Edgar E. Iglesias wrote:
> From: "Edgar E. Iglesias"
>
> Move misplaced comment.
>
> Signed-off-by: Edgar E. Iglesias
Reviewed-by: Luc Michel
> ---
> hw/arm/xlnx-versal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/arm/xlnx-versal.c b/hw/
On Tue, Apr 28, 2020 at 10:14:37PM +0800, Dr. David Alan Gilbert wrote:
> * Yan Zhao (yan.y.z...@intel.com) wrote:
> > On Mon, Apr 27, 2020 at 11:37:43PM +0800, Dr. David Alan Gilbert wrote:
> > > * Yan Zhao (yan.y.z...@intel.com) wrote:
> > > > On Sat, Apr 25, 2020 at 03:10:49AM +0800, Dr. David A
On 4/27/20 8:16 PM, Edgar E. Iglesias wrote:
> From: "Edgar E. Iglesias"
>
> Fix typo xlnx-ve -> xlnx-versal.
>
> Signed-off-by: Edgar E. Iglesias
Reviewed-by: Luc Michel
> ---
> hw/arm/xlnx-versal-virt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/arm/xlnx-
On 4/27/20 8:16 PM, Edgar E. Iglesias wrote:
> From: "Edgar E. Iglesias"
>
> Add support for SD.
>
> Signed-off-by: Edgar E. Iglesias
Reviewed-by: Luc Michel
> ---
> hw/arm/xlnx-versal-virt.c | 46 +++
> 1 file changed, 46 insertions(+)
>
> diff --git a/
timers_state.icount_time_shift must be in [0,63] to avoid undefined
behavior when shifting by it, e.g. in cpu_icount_to_ns().
icount_adjust() clamps it to [0,MAX_ICOUNT_SHIFT], with
MAX_ICOUNT_SHIFT = 10. configure_icount() doesn't. Fix that.
Fixes: a8bfac37085c3372366d722f131a7e18d664ee4d
Cc: P
The Error ** argument must be NULL, &error_abort, &error_fatal, or a
pointer to a variable containing NULL. Passing an argument of the
latter kind twice without clearing it in between is wrong: if the
first call sets an error, it no longer points to NULL for the second
call.
check_cache_dropped()
This commit adds a new audiodev backend to allow QEMU to use JACK as
both an audio sink and source.
Signed-off-by: Geoffrey McRae
---
audio/Makefile.objs| 5 +
audio/audio.c | 1 +
audio/audio_template.h | 2 +
audio/jackaudio.c | 583 +
On 4/27/20 8:16 PM, Edgar E. Iglesias wrote:
> From: "Edgar E. Iglesias"
>
> Embedd the GEMs into the SoC type.
>
> Suggested-by: Peter Maydell
> Signed-off-by: Edgar E. Iglesias
Reviewed-by: Luc Michel
> ---
> hw/arm/xlnx-versal.c | 15 ---
> include/hw/arm/xlnx-versal
On 4/27/20 8:16 PM, Edgar E. Iglesias wrote:
> From: "Edgar E. Iglesias"
>
> Remove inclusion of arm_gicv3_common.h, this already gets
> included via xlnx-versal.h.
>
> Signed-off-by: Edgar E. Iglesias
Reviewed-by: Luc Michel
> ---
> hw/arm/xlnx-versal.c | 1 -
> 1 file changed, 1 deletion(
On 4/27/20 8:16 PM, Edgar E. Iglesias wrote:
> From: "Edgar E. Iglesias"
>
> Embedd the UARTs into the SoC type.
>
> Suggested-by: Peter Maydell
> Signed-off-by: Edgar E. Iglesias
Hi Edgar,
Just a small thing, I find it easier to review when you have
[diff]
orderFile = scripts/git.order
We need some little help in the code to reduce the valgrind noise.
This patch does this with some designated initializers for the cpu
model features and subfunctions.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Christian Borntraeger
---
target/s390x/kvm.c | 4 ++--
1 file changed, 2 inse
> On Apr 29, 2020, at 1:08 PM, Michael S. Tsirkin wrote:
>
> On Wed, Apr 29, 2020 at 07:02:56AM +, Ani Sinha wrote:
>>
>>
>>> On Apr 29, 2020, at 12:27 PM, Michael S. Tsirkin wrote:
>>>
>>> On Wed, Apr 29, 2020 at 06:54:52AM +, Ani Sinha wrote:
> On Apr 29, 2020, at
On 28.04.20 16:21, Kevin Wolf wrote:
> Am 28.04.2020 um 15:26 hat Max Reitz geschrieben:
>> Right now, all users of bdrv_make_empty() call the BlockDriver method
>> directly. That is not only bad style, it is also wrong, unless the
>> caller has a BdrvChild with a WRITE permission.
>>
>> Introduce
Philippe Mathieu-Daudé writes:
> +Peter for crediting his advice.
>
> On 4/29/20 7:59 AM, Markus Armbruster wrote:
>> Philippe Mathieu-Daudé writes:
>>
>>> On 4/24/20 9:20 PM, Markus Armbruster wrote:
The Error ** argument must be NULL, &error_abort, &error_fatal, or a
pointer to a var
On 4/27/20 8:16 PM, Edgar E. Iglesias wrote:
> From: "Edgar E. Iglesias"
>
> Embedd the APUs into the SoC type.
>
> Suggested-by: Peter Maydell
> Signed-off-by: Edgar E. Iglesias
Reviewed-by: Luc Michel
> ---
> hw/arm/xlnx-versal-virt.c| 4 ++--
> hw/arm/xlnx-versal.c | 19 +++
On 29.04.20 09:42, Christian Borntraeger wrote:
> We need some little help in the code to reduce the valgrind noise.
> This patch does this with some designated initializers for the cpu
> model features and subfunctions.
>
> Reviewed-by: Philippe Mathieu-Daudé
> Signed-off-by: Christian Borntraeg
Queued.
On 4/27/20 8:16 PM, Edgar E. Iglesias wrote:
> From: "Edgar E. Iglesias"
>
> Embedd the ADMAs into the SoC type.
>
> Suggested-by: Peter Maydell
> Signed-off-by: Edgar E. Iglesias
Reviewed-by: Luc Michel
> ---
> hw/arm/xlnx-versal.c | 14 +++---
> include/hw/arm/xlnx-versal
On 4/27/20 8:16 PM, Edgar E. Iglesias wrote:
> From: "Edgar E. Iglesias"
>
> hw/arm: versal: Add support for the RTC.
>
> Signed-off-by: Edgar E. Iglesias
Reviewed-by: Luc Michel
> ---
> hw/arm/xlnx-versal.c | 21 +
> include/hw/arm/xlnx-versal.h | 8
>
On 4/27/20 8:16 PM, Edgar E. Iglesias wrote:
> From: "Edgar E. Iglesias"
>
> Add support for SD.
>
> Signed-off-by: Edgar E. Iglesias
Reviewed-by: Luc Michel
> ---
> hw/arm/xlnx-versal.c | 31 +++
> include/hw/arm/xlnx-versal.h | 12
> 2 file
On Wed, 29 Apr 2020 05:37:17 +
"Zhang, Chen" wrote:
> > -Original Message-
> > From: Lukas Straub
> > Sent: Monday, April 27, 2020 3:22 PM
> > To: Zhang, Chen
> > Cc: qemu-devel ; Li Zhijian
> > ; Jason Wang ; Marc-
> > André Lureau ; Paolo Bonzini
> >
> > Subject: Re: [PATCH v3 3/
On Wed, Apr 29, 2020 at 07:02:56AM +, Ani Sinha wrote:
>
>
> > On Apr 29, 2020, at 12:27 PM, Michael S. Tsirkin wrote:
> >
> > On Wed, Apr 29, 2020 at 06:54:52AM +, Ani Sinha wrote:
> >>
> >>
> >>> On Apr 29, 2020, at 12:22 PM, Michael S. Tsirkin wrote:
> >>>
> >>> On Wed, Apr 29, 2
This commit adds a new audiodev backend to allow QEMU to use JACK as
both an audio sink and source.
Signed-off-by: Geoffrey McRae
---
audio/Makefile.objs| 5 +
audio/audio.c | 1 +
audio/audio_template.h | 2 +
audio/jackaudio.c | 615 +
+Paolo
On 4/29/20 9:21 AM, Christian Borntraeger wrote:
On 29.04.20 09:00, Philippe Mathieu-Daudé wrote:
Hi Christian,
On 4/28/20 8:31 PM, Christian Borntraeger wrote:
We need some little help in the code to reduce the valgrind noise.
- some designated initializers for the cpu model features
On Tue, Apr 28, 2020 at 9:15 PM Dr. David Alan Gilbert
wrote:
> So our current sequence is:
>
>(new namespace)
> 1)if (mount(NULL, "/", NULL, MS_REC | MS_SLAVE, NULL) < 0) {
> 2) if (mount("proc", "/proc", "proc",
>
> 3) if (mount(source, source, NULL, MS_BIND | MS_
On 4/28/20 6:34 PM, Markus Armbruster wrote:
chassis_from_bus() uses object_property_get_uint() to get property
"chassis_nr" of the bridge device. Failure would be a programming
error. Pass &error_abort, and simplify its callers.
Cc: David Gibson
Cc: qemu-...@nongnu.org
Signed-off-by: Markus
On 28.04.20 16:07, Eric Blake wrote:
> On 4/28/20 8:26 AM, Max Reitz wrote:
>> bdrv_commit() already has a BlockBackend pointing to the BDS that we
>> want to empty, it just has the wrong permissions.
>>
>> qemu-img commit has no BlockBackend pointing to the old backing file
>> yet, but introducing
On 28.04.20 17:03, Kevin Wolf wrote:
> Am 28.04.2020 um 15:26 hat Max Reitz geschrieben:
>> bdrv_commit() already has a BlockBackend pointing to the BDS that we
>> want to empty, it just has the wrong permissions.
>>
>> qemu-img commit has no BlockBackend pointing to the old backing file
>> yet, bu
On 28.04.20 16:47, Kevin Wolf wrote:
> Am 28.04.2020 um 15:26 hat Max Reitz geschrieben:
>> Two callers of BlockDriver.bdrv_make_empty() remain that should not call
>> this method directly. Both do not have access to a BdrvChild, but they
>> can use a BlockBackend, so we add this function that let
On 4/27/20 9:19 PM, Dr. David Alan Gilbert wrote:
> * Cédric Le Goater (c...@kaod.org) wrote:
>> From: "Dr. David Alan Gilbert"
>>
>> Reimplement it based on qmp_qom_get() to avoid converting QObjects back
>> to strings.
>
>
> I'd love to see this or something similar in; what does it's output
On 4/27/20 8:16 PM, Edgar E. Iglesias wrote:
> From: "Edgar E. Iglesias"
>
> Add support for the RTC.
>
> Signed-off-by: Edgar E. Iglesias
Reviewed-by: Luc Michel
> ---
> hw/arm/xlnx-versal-virt.c | 22 ++
> 1 file changed, 22 insertions(+)
>
> diff --git a/hw/arm/xlnx-
On Wed, Apr 29, 2020 at 07:43:04AM +, Ani Sinha wrote:
>
>
> > On Apr 29, 2020, at 1:08 PM, Michael S. Tsirkin wrote:
> >
> > On Wed, Apr 29, 2020 at 07:02:56AM +, Ani Sinha wrote:
> >>
> >>
> >>> On Apr 29, 2020, at 12:27 PM, Michael S. Tsirkin wrote:
> >>>
> >>> On Wed, Apr 29, 20
Queued.
Public bug reported:
Instead of building qemu:docker images locally, we should pull the one
built from Travis/Shippable/GitLab by default, and build it only when
manually requested.
** Affects: qemu
Importance: Undecided
Status: New
--
You received this bug notification because yo
On 28.04.20 19:36, John Snow wrote:
>
>
> On 4/28/20 8:21 AM, Kevin Wolf wrote:
>> Am 28.04.2020 um 13:46 hat Max Reitz geschrieben:
>>> On 31.03.20 02:00, John Snow wrote:
This series uses python logging to enable output conditionally on
iotests.log(). We unify an initialization call (
On 4/29/20 5:51 AM, Huacai Chen wrote:
Hi, Aleksandar,
I've tried translate.google.com, and documents are available here:
Loongson-3A R1 (Loongson-3A1000)
User Manual Part 1:
http://ftp.godson.ac.cn/lemote/3A1000_p1.pdf
http://ftp.godson.ac.cn/lemote/Loongson3A1000_processor_user_manual_P1.pdf
(
> -Original Message-
> From: Grzegorz Uriasz
> Sent: 29 April 2020 04:04
> To: qemu-devel@nongnu.org
> Cc: Grzegorz Uriasz ; marma...@invisiblethingslab.com;
> ar...@puzio.waw.pl;
> ja...@bartmin.ski; j.nowa...@student.uw.edu.pl; Stefano Stabellini
> ; Anthony
> Perard ; Paul Durrant ;
> On Apr 29, 2020, at 1:39 PM, Michael S. Tsirkin wrote:
>
> On Wed, Apr 29, 2020 at 07:43:04AM +, Ani Sinha wrote:
>>
>>
>>> On Apr 29, 2020, at 1:08 PM, Michael S. Tsirkin wrote:
>>>
>>> On Wed, Apr 29, 2020 at 07:02:56AM +, Ani Sinha wrote:
> On Apr 29, 2020, at 1
Hi, Philippe,
The major differences of R3 and R4 are:
1, R4 has complete MIPS VZ ASE (while R3 is incomplete), so very
usable for KVM host;
2, R4 has MSA ASE while R3 hasn't;
3, R4 has cpucfg, rdcsr and wrcsr instructions (similar to cpuid,
rdmsr and wrmsr in X86).
On Wed, Apr 29, 2020 at 4:09 PM
* Yan Zhao (yan.y.z...@intel.com) wrote:
> On Tue, Apr 28, 2020 at 10:14:37PM +0800, Dr. David Alan Gilbert wrote:
> > * Yan Zhao (yan.y.z...@intel.com) wrote:
> > > On Mon, Apr 27, 2020 at 11:37:43PM +0800, Dr. David Alan Gilbert wrote:
> > > > * Yan Zhao (yan.y.z...@intel.com) wrote:
> > > > > On
> -Original Message-
> From: Grzegorz Uriasz
> Sent: 29 April 2020 04:04
> To: qemu-devel@nongnu.org
> Cc: Grzegorz Uriasz ; marma...@invisiblethingslab.com;
> ar...@puzio.waw.pl;
> ja...@bartmin.ski; j.nowa...@student.uw.edu.pl; Stefano Stabellini
> ; Anthony
> Perard ; Paul Durrant ;
This code must not be used outside of KVM. Abort if it is.
Signed-off-by: Philippe Mathieu-Daudé
---
target/mips/kvm.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/target/mips/kvm.c b/target/mips/kvm.c
index de3e26ef1f..050bfbd7fa 100644
--- a/target/mips/kvm.c
+++
Refactor duplicated code in a single place.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/mips/mips_int.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/hw/mips/mips_int.c b/hw/mips/mips_int.c
index 796730b11d..4a1bf846da 100644
--- a/hw/mips/mips_int.c
+++ b/hw/m
A pair of trivial patches while reviewing Huacai's
"KVM target support for MIPS64" series.
Philippe Mathieu-Daudé (2):
hw/mips/mips_int: De-duplicate KVM interrupt delivery
target/mips/kvm: Assert unreachable code is not used
hw/mips/mips_int.c | 11 +++
target/mips/kvm.c | 8 ++---
On 28.04.20 21:15, Dr. David Alan Gilbert wrote:
> * Miklos Szeredi (mszer...@redhat.com) wrote:
>> On Tue, Apr 28, 2020 at 4:52 PM Stefan Hajnoczi wrote:
>>>
>>> On Mon, Apr 27, 2020 at 06:59:02PM +0100, Dr. David Alan Gilbert wrote:
* Max Reitz (mre...@redhat.com) wrote:
> Currently, se
Hi, Philippe,
On Wed, Apr 29, 2020 at 4:30 PM Philippe Mathieu-Daudé wrote:
>
> Refactor duplicated code in a single place.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/mips/mips_int.c | 11 +++
> 1 file changed, 3 insertions(+), 8 deletions(-)
>
> diff --git a/hw/mips/mips_int.
Le 28/04/2020 à 19:17, KONRAD Frederic a écrit :
> The MC68881 say about infinities (3.2.4):
>
> "*For the extended precision format, the most significant bit of the
> mantissa (the integer bit) is a don't care."
>
> https://www.nxp.com/docs/en/reference-manual/MC68881UM.pdf
As we use 68040 I re
Le 28/04/2020 à 20:43, Alex Bennée a écrit :
>
> KONRAD Frederic writes:
>
>> The MC68881 say about infinities (3.2.4):
>>
>> "*For the extended precision format, the most significant bit of the
>> mantissa (the integer bit) is a don't care."
>>
>> https://www.nxp.com/docs/en/reference-manual/MC
Hi,
> > Not fully sure we can do that without breaking something, might be a
> > negative stride is used for upside down images (last scanline comes
> > first in memory).
>
> Ugh... Upside down images???... Well, OK, I guess. :)
Well, in the unix world (x11, wayland) x=0,y=0 is the upper left
On Wed, Apr 29, 2020 at 10:31 AM Max Reitz wrote:
>
> On 28.04.20 21:15, Dr. David Alan Gilbert wrote:
> > So are you saying we need a:
> >if (mount(NULL, "/", NULL, MS_REC | MS_SHARED, NULL) < 0) {
> >
> > and can this go straight after (1) ?
>
> Isn’t MS_SHARED and MS_SLAVE mutually e
This series adds libdaxctl support and fetchs the alignment of
device dax through libdaxctl [1] APIs.
QEMU uses mmap(2) to maps vNVDIMM backends and aligns the mapping
address to the page size (getpagesize(2)) by default. However, some
types of backends may require an alignment different than the
On 28.04.20 19:13, David Hildenbrand wrote:
> On 28.04.20 18:34, Markus Armbruster wrote:
>> Both s390_features[S390_FEAT_PCC_CMAC_AES_256].name and
>> s390_features[S390_FEAT_PCC_CMAC_EAES_256].name is
>> "pcc-cmac-eaes-256". The former is obviously a pasto.
>>
>> Impact:
>>
>> * s390_feat_bit
On 2020/4/29 上午12:34, Markus Armbruster wrote:
QOM object initialization runs .instance_init() for the type and all
its supertypes; see object_init_with_type().
Both TYPE_E1000_BASE and its concrete subtypes set .instance_init() to
e1000_instance_init(). For the concrete subtypes, it duly get
If the backend file is devdax pmem character device, the alignment
specified by the option 'align=NUM' in the '-object memory-backend-file'
needs to match the alignment requirement of the devdax pmem character device.
This patch uses the interfaces of libdaxctl to fetch the devdax pmem file
'align
Patchew URL: https://patchew.org/QEMU/20200429072048.29963-1-arm...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20200429072048.29963-1-arm...@redhat.com
Subject: [PULL 00/32] Miscellaneous patches for 2020-04-29
Type:
For device dax (e.g., /dev/dax0.0), the NUM of 'align=NUM' option
needs to match the alignment requirement of the device dax.
It must be larger than or equal to the 'align' of device dax.
Reviewed-by: Joao Martins
Signed-off-by: Jingqi Liu
---
docs/nvdimm.txt | 10 ++
1 file changed, 10
Add a pair of configure options --{enable,disable}-libdaxctl to control
whether QEMU is compiled with libdaxctl [1]. Libdaxctl is a utility
library for managing the device dax subsystem.
QEMU uses mmap(2) to maps vNVDIMM backends and aligns the mapping
address to the page size (getpagesize(2)) by
On 28.04.20 21:26, Eric Blake wrote:
> Re-posting this to make Max' life easier when rebasing on top of Kevin's work.
>
> Based-on: <20200424125448.63318-1-kw...@redhat.com>
> [PATCH v7 00/10] block: Fix resize (extending) of short overlays
>
> In v4:
> - patch 1: fold in Max's touchups to my v3
1 - 100 of 398 matches
Mail list logo
