Re: [PATCH v2 00/17] 64bit block-layer

2020-04-28 Thread Vladimir Sementsov-Ogievskiy
29.04.2020 0:33, Eric Blake wrote: On 4/27/20 3:23 AM, Vladimir Sementsov-Ogievskiy wrote: Hi all! v1 was "[RFC 0/3] 64bit block-layer part I", please refer to initial cover-letter   https://lists.gnu.org/archive/html/qemu-devel/2020-03/msg08723.html for motivation. v2: patch 02 is unchanged,

Re: [PATCH V2] Add a new PIIX option to control PCI hot unplugging of devices on non-root buses

2020-04-28 Thread Michael S. Tsirkin
On Wed, Apr 29, 2020 at 06:28:46AM +0530, Ani Sinha wrote: > Well there were several discussions in the other thread around how PCIE > behaves > and how we can't change the slot features without a HW reset. Those were > useful > inputs. OK so I'd expect these to be addressed in some way. If we c

RE: [PATCH v3 3/6] net/colo-compare.c: Fix deadlock in compare_chr_send

2020-04-28 Thread Zhang, Chen
> -Original Message- > From: Lukas Straub > Sent: Monday, April 27, 2020 3:22 PM > To: Zhang, Chen > Cc: qemu-devel ; Li Zhijian > ; Jason Wang ; Marc- > André Lureau ; Paolo Bonzini > > Subject: Re: [PATCH v3 3/6] net/colo-compare.c: Fix deadlock in > compare_chr_send > > On Mon, 27

Re: [PATCH v4 00/18] nvme: factor out cmb/pmr setup

2020-04-28 Thread Klaus Jensen
On Apr 22 13:01, Klaus Jensen wrote: > From: Klaus Jensen > > Changes since v3 > > * Remove the addition of a new PROPERTIES macro in "nvme: move device > parameters to separate struct" (Philippe) > > * Add NVME_PMR_BIR constant and use it in PMR setup. > > * Split "nvme: fac

Re: [PATCH 2/4] smbus: Fix spd_data_generate() error API violation

2020-04-28 Thread Markus Armbruster
BALATON Zoltan writes: > On Fri, 24 Apr 2020, Markus Armbruster wrote: >> BALATON Zoltan writes: >>> On Tue, 21 Apr 2020, Markus Armbruster wrote: BALATON Zoltan writes: > On Mon, 20 Apr 2020, Markus Armbruster wrote: >> The Error ** argument must be NULL, &error_abort, &error_fata

Re: [PATCH 02/11] xen: Fix and improve handling of device_add usb-host errors

2020-04-28 Thread Markus Armbruster
Paul Durrant writes: >> -Original Message- >> From: Markus Armbruster >> Sent: 24 April 2020 20:20 >> To: qemu-devel@nongnu.org >> Cc: Stefano Stabellini ; Anthony Perard >> ; Paul >> Durrant ; Gerd Hoffmann ; >> xen-de...@lists.xenproject.org >> Subject: [PATCH 02/11] xen: Fix and imp

Re: [PATCH 03/11] s390x/cpumodel: Fix harmless misuse of visit_check_struct()

2020-04-28 Thread Markus Armbruster
David Hildenbrand writes: > On 24.04.20 21:20, Markus Armbruster wrote: >> Commit e47970f51d "s390x/cpumodel: Fix query-cpu-model-FOO error API >> violations" neglected to change visit_end_struct()'s Error ** argument >> along with the others. If visit_end_struct() failed, we'd take the > > s/vi

Re: [PATCH 07/11] mips/malta: Fix create_cps() error handling

2020-04-28 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 4/24/20 9:20 PM, Markus Armbruster wrote: >> The Error ** argument must be NULL, &error_abort, &error_fatal, or a >> pointer to a variable containing NULL. Passing an argument of the >> latter kind twice without clearing it in between is wrong: if the >> first

Re: [PATCH V2] Add a new PIIX option to control PCI hot unplugging of devices on non-root buses

2020-04-28 Thread Ani Sinha
> On Apr 29, 2020, at 10:58 AM, Michael S. Tsirkin wrote: > > For example, how about hot-plugging a bridge which doesn't > support hotplug itself? So now for every device we want to hot plug, we will add a new bridge? Sounds not a scalable and elegant idea. > Would that happen to make windo

Re: [PATCH-for-5.1 v3 01/24] various: Remove suspicious '\' character outside of #define in C code

2020-04-28 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > Fixes the following coccinelle warnings: > > $ spatch --sp-file --verbose-parsing ... \ > scripts/coccinelle/remove_local_err.cocci > ... > SUSPICIOUS: a \ character appears outside of a #define at > ./target/ppc/translate_init.inc.c:5213 [...] > S

[PATCH] audio/jack: add JACK client audiodev

2020-04-28 Thread Geoffrey McRae
This commit adds a new audiodev backend to allow QEMU to use JACK as both an audio sink and source. Signed-off-by: Geoffrey McRae --- audio/Makefile.objs| 5 + audio/audio.c | 1 + audio/audio_template.h | 2 + audio/jackaudio.c | 583 +

[PATCH v3 5/5] block/block-copy: use aio-task-pool API

2020-04-28 Thread Vladimir Sementsov-Ogievskiy
Run block_copy iterations in parallel in aio tasks. Changes: - BlockCopyTask becomes aio task structure. Add zeroes field to pass it to block_copy_do_copy - add call state - it's a state of one call of block_copy(), shared between parallel tasks. For now used only to keep information a

[PATCH v3 1/5] block/block-copy: rename in-flight requests to tasks

2020-04-28 Thread Vladimir Sementsov-Ogievskiy
We are going to use aio-task-pool API and extend in-flight request structure to be a successor of AioTask, so rename things appropriately. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/block-copy.c | 98 +++--- 1 file changed, 48 insertions(+), 50

[PATCH v3 0/5] block-copy: use aio-task-pool

2020-04-28 Thread Vladimir Sementsov-Ogievskiy
Hi all! v3: 01: drop extra line "+s->in_flight_bytes -= task->bytes - new_bytes;" 02: add Max's r-b 03: rebased on 01 fix (dropped line not updated now). keep Max's r-b 04: more refactoring: don't require offset argument of block_copy_task_create being dirty, use !bdrv_dirty_bitmap_n

[PATCH v3 2/5] block/block-copy: alloc task on each iteration

2020-04-28 Thread Vladimir Sementsov-Ogievskiy
We are going to use aio-task-pool API, so tasks will be handled in parallel. We need therefore separate allocated task on each iteration. Introduce this logic now. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- block/block-copy.c | 18 +++--- 1 file changed,

Re: [PATCH v2 2/3] docs/nvdimm: add description of alignment requirement of device dax

2020-04-28 Thread Liu, Jingqi
On 4/29/2020 12:22 AM, Joao Martins wrote: On 4/15/20 4:35 AM, Jingqi Liu wrote: For device dax (e.g., /dev/dax0.0), the NUM of 'align=NUM' option needs to match the alignment requirement of the device dax. It must be larger than or equal to the 'align' of device dax. Signed-off-by: Jingqi Liu

[PATCH v3 3/5] block/block-copy: add state pointer to BlockCopyTask

2020-04-28 Thread Vladimir Sementsov-Ogievskiy
We are going to use aio-task-pool API, so we'll need state pointer in BlockCopyTask anyway. Add it now and use where possible. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- block/block-copy.c | 28 +++- 1 file changed, 15 insertions(+), 13 deleti

[PATCH v3 4/5] block/block-copy: refactor task creation

2020-04-28 Thread Vladimir Sementsov-Ogievskiy
Instead of just relying on the comment "Called only on full-dirty region" in block_copy_task_create() let's move initial dirty area search directly to block_copy_task_create(). Let's also use effective bdrv_dirty_bitmap_next_dirty_area instead of looping through all non-dirty clusters. Signed-off-

Re: [PATCH V2] Add a new PIIX option to control PCI hot unplugging of devices on non-root buses

2020-04-28 Thread Ani Sinha
> On Apr 29, 2020, at 10:58 AM, Michael S. Tsirkin wrote: > > o if there's a need to disable > just one of these, commit log needs to do a better job documenting the > usecase. The use case is simple. With this feature admins will be able to do what they were forced to do from Windows driver

Re: [PATCH 0/2] virt: Set tpm-tis-device ppi property to off by default

2020-04-28 Thread Cornelia Huck
On Tue, 28 Apr 2020 16:13:05 -0400 Stefan Berger wrote: > On 4/28/20 6:38 AM, Cornelia Huck wrote: > > On Mon, 27 Apr 2020 16:31:43 +0200 > > Eric Auger wrote: > > > >> Instead of using a compat in the mach-virt machine to force > >> PPI off for all virt machines (PPI not supported by the > >>

Re: [PATCH-for-5.1 v3 2/7] various: Use &error_abort in instance_init()

2020-04-28 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > Patch created mechanically by running: > > $ spatch \ > --macro-file scripts/cocci-macro-file.h \ > --include-headers --keep-comments --in-place \ > --sp-file \ > scripts/coccinelle/use-error_abort-in-instance_init.cocci > > Reviewed-by: Cédric

Re: [PATCH v3] target/arm: Use correct variable for setting 'max' cpu's MIDR_EL1

2020-04-28 Thread Laurent Desnogues
On Tue, Apr 28, 2020 at 7:26 PM Philippe Mathieu-Daudé wrote: > > MIDR_EL1 a 64-bit system register with the top 32-bit being RES0. > > This fixes when compiling with -Werror=conversion: > > target/arm/cpu64.c: In function ‘aarch64_max_initfn’: > target/arm/cpu64.c:628:21: error: conversion fr

Re: [PATCH 08/11] mips/boston: Fix boston_mach_init() error handling

2020-04-28 Thread Markus Armbruster
Markus Armbruster writes: > The Error ** argument must be NULL, &error_abort, &error_fatal, or a > pointer to a variable containing NULL. Passing an argument of the > latter kind twice without clearing it in between is wrong: if the > first call sets an error, it no longer points to NULL for the

Re: [PATCH-for-5.1 v3 5/7] hw/mips/boston: Add missing error-propagation code

2020-04-28 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > Running the coccinelle script produced: > > $ spatch \ > --macro-file scripts/cocci-macro-file.h --include-headers \ > --sp-file scripts/coccinelle/find-missing-error_propagate.cocci \ > --keep-comments --smpl-spacing --dir . > HANDLING: ./hw/mips/

Re: [PATCH V2] Add a new PIIX option to control PCI hot unplugging of devices on non-root buses

2020-04-28 Thread Ani Sinha
> On Apr 29, 2020, at 12:22 PM, Michael S. Tsirkin wrote: > > On Wed, Apr 29, 2020 at 06:11:20AM +, Ani Sinha wrote: >> >> >>> On Apr 29, 2020, at 10:58 AM, Michael S. Tsirkin wrote: >>> >>> o if there's a need to disable >>> just one of these, commit log needs to do a better job docum

Re: [PATCH V2] Add a new PIIX option to control PCI hot unplugging of devices on non-root buses

2020-04-28 Thread Michael S. Tsirkin
On Wed, Apr 29, 2020 at 06:11:20AM +, Ani Sinha wrote: > > > > On Apr 29, 2020, at 10:58 AM, Michael S. Tsirkin wrote: > > > > o if there's a need to disable > > just one of these, commit log needs to do a better job documenting the > > usecase. > > The use case is simple. With this featur

Re: [PATCH V2] Add a new PIIX option to control PCI hot unplugging of devices on non-root buses

2020-04-28 Thread Michael S. Tsirkin
On Wed, Apr 29, 2020 at 06:54:52AM +, Ani Sinha wrote: > > > > On Apr 29, 2020, at 12:22 PM, Michael S. Tsirkin wrote: > > > > On Wed, Apr 29, 2020 at 06:11:20AM +, Ani Sinha wrote: > >> > >> > >>> On Apr 29, 2020, at 10:58 AM, Michael S. Tsirkin wrote: > >>> > >>> o if there's a ne

<    1   2   3   4