Patchew URL:
https://patchew.org/QEMU/20200423170557.31106-1-alex.ben...@linaro.org/
Hi,
This series failed the docker-quick@centos7 build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN
On 4/23/20 1:06 PM, Eric Blake wrote:
On 4/23/20 11:00 AM, Markus Armbruster wrote:
An alternate type's visit_type_FOO() fails when it runs into an
invalid ->type. If it's an input visit, we then need to free the the
object we got from visit_start_alternate(). We do that with
qapi_free_FOO(),
On 4/23/20 11:00 AM, Markus Armbruster wrote:
The previous few commits have made this more obvious, and removed the
one exception. Time to clarify the documentation, and drop dead error
checking.
Signed-off-by: Markus Armbruster
---
I guess the only other failures an output visitor might enc
During vhost-user reconnect functionality we hit several issues, if
vhost-user-blk daemon is "crashed" or made disconnect during vhost
initialization. The general scenario is as follows:
- vhost start routine is called
- vhost write failed due to SIGPIPE
- this call the disconnect routine and
During vhost-user reconnect functionality testing the following assert
was hit:
qemu-system-x86_64: chardev/char-socket.c:125:
qemu_chr_socket_restart_timer: Assertion `!s->reconnect_timer' failed.
Aborted (core dumped)
This is observed only if the connection is closed by the vhost-user-blk
d
In case of the vhost-user devices the daemon can be killed at any
moment. Since QEMU supports the reconnet functionality the guest
notifiers should be reset and disabled after "disconnect" event. The
most issues were found if the "disconnect" event happened during vhost
device initialization step.
Add "--simulate-disconnect-stage" option for the testing purposes.
This option can be used to test the vhost-user reconnect functionality:
./vhost-user-blk ... --simulate-disconnect-stage=
In this case the daemon will "crash" in the middle of the VHOST comands
communication. Case nums are as foll
Introduce new wrappers to set/reset guest notifiers for the virtio
device in the vhost device module:
vhost_dev_assign_guest_notifiers
->set_guest_notifiers(..., ..., true);
vhost_dev_drop_guest_notifiers
->set_guest_notifiers(..., ..., false);
This is a preliminary step to refactor cod
During testing of the vhost-user-blk reconnect functionality the qemu
SIGSEGV was triggered:
start qemu as:
x86_64-softmmu/qemu-system-x86_64 -m 1024M -M q35 \
-object
memory-backend-file,id=ram-node0,size=1024M,mem-path=/dev/shm/qemu,share=on \
-numa node,cpus=0,memdev=ram-node0 \
-cha
On 4/23/20 11:00 AM, Markus Armbruster wrote:
Signed-off-by: Markus Armbruster
---
qom/object.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org |
If vhost-user daemon is used as a backend for the vhost device, then we
should consider a possibility of disconnect at any moment. If such
disconnect happened in the vhost_migration_log() routine the vhost
device structure will be clean up.
At the start of the vhost_migration_log() function there i
Since disconnect can happen at any time during initialization not all
vring buffers (for instance used vring) can be intialized successfully.
If the buffer was not initialized then vhost_memory_unmap call will lead
to SIGSEGV. Add checks for the vring address value before calling unmap.
Also add as
Hi
On Thu, Apr 23, 2020 at 8:41 PM Dima Stepanov wrote:
>
> During vhost-user reconnect functionality testing the following assert
> was hit:
> qemu-system-x86_64: chardev/char-socket.c:125:
> qemu_chr_socket_restart_timer: Assertion `!s->reconnect_timer' failed.
> Aborted (core dumped)
Th
On 4/22/20 6:55 PM, LIU Zhiwei wrote:
> As far as I know, Guo Ren and Greentime are supporting RVV on Linux, based on
> the v0.7.1 QEMU implementation.
> The main problem is that VLEN is not a fixed number.
Neither is the SVE vector length fixed.
That's one of the reasons I pointed you at the AA
Hi
On Thu, Apr 23, 2020 at 8:43 PM Dima Stepanov wrote:
>
> During testing of the vhost-user-blk reconnect functionality the qemu
> SIGSEGV was triggered:
> start qemu as:
> x86_64-softmmu/qemu-system-x86_64 -m 1024M -M q35 \
>-object
> memory-backend-file,id=ram-node0,size=1024M,mem-path=
Calling g_mapped_file_unref() on a NULL pointer is not valid, and
glib will assert if you try it.
$ qemu-system-arm -M virt -display none -device loader,file=/tmp/bad.elf
qemu-system-arm: -device loader,file=/tmp/bad.elf: GLib: g_mapped_file_unref:
assertion 'file != NULL' failed
(One way to pro
This test never required "chardev/char-mux.h", remove it.
Signed-off-by: Philippe Mathieu-Daudé
---
tests/test-char.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tests/test-char.c b/tests/test-char.c
index 3afc9b1b8d..f08a39790e 100644
--- a/tests/test-char.c
+++ b/tests/test-char.c
@@ -6
chardev cleanup while reviewing 'Refactor machine_init and exit
notifiers' from the multi-process series:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg697510.html
Elena Ufimtseva (1):
multi-process: Refactor machine_init and exit notifiers
Philippe Mathieu-Daudé (6):
monitor/misc: Re
The msmouse / wctablet / testdev character devices are only
used by system emulation. Remove them from user mode and tools.
Signed-off-by: Philippe Mathieu-Daudé
---
chardev/Makefile.objs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/chardev/Makefile.objs b/chardev/Makefile
As the machine notify handlers are only used in system emulation,
split the current file in two, and only build the notifier when
system emulation is used.
Signed-off-by: Philippe Mathieu-Daudé
---
stubs/machine-init.c| 4
stubs/{machine-init-done.c => machine-no
monitor/misc.c never required "chardev/char-mux.h", remove it.
Signed-off-by: Philippe Mathieu-Daudé
---
monitor/misc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/monitor/misc.c b/monitor/misc.c
index 6c45fa490f..5d68026a7f 100644
--- a/monitor/misc.c
+++ b/monitor/misc.c
@@ -33,7 +33,6
No file out of chardev/ requires access to this header,
restrict its scope.
Signed-off-by: Philippe Mathieu-Daudé
---
include/chardev/char-mux.h => chardev/chardev-internal.h | 7 ---
chardev/char-fe.c| 2 +-
chardev/char-mux.c
From: Elena Ufimtseva
Relocate machine_int and exit notifiers into common code
Signed-off-by: Elena Ufimtseva
Signed-off-by: John G Johnson
Signed-off-by: Jagannathan Raman
[PMD: Removed NotifierList machine_init_done_notifiers stub]
Signed-off-by: Philippe Mathieu-Daudé
---
Makefile.objs
Split out code only used during system emulation,
to reduce code pulled in user emulation and tools.
Signed-off-by: Philippe Mathieu-Daudé
---
chardev/chardev-internal.h | 3 ++
chardev/char.c | 35 +--
chardev/chardev-sysemu.c | 69
On 4/23/20 10:20 PM, Peter Maydell wrote:
Calling g_mapped_file_unref() on a NULL pointer is not valid, and
glib will assert if you try it.
$ qemu-system-arm -M virt -display none -device loader,file=/tmp/bad.elf
qemu-system-arm: -device loader,file=/tmp/bad.elf: GLib: g_mapped_file_unref:
asse
On 4/23/20 7:05 PM, Alex Bennée wrote:
Signed-off-by: Alex Bennée
---
.travis.yml | 1 +
1 file changed, 1 insertion(+)
diff --git a/.travis.yml b/.travis.yml
index 2fd63eceaa..a4c3c6c805 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -113,6 +113,7 @@ script:
$(exit $BUILD_RC);
On 4/23/20 7:05 PM, Alex Bennée wrote:
As gdb will generally be talking to "foreign" guests lets use that if
we can. Otherwise the chances of gdb barfing are considerably higher.
Signed-off-by: Alex Bennée
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/conf
On 4/23/20 7:05 PM, Alex Bennée wrote:
This keeps breaking on Travis so lets just fall back to the Cirrus CI
builds which seem to be better maintained. Fix up the comments while
we are doing this as we never had a windows build.
I certainly vouch this.
Reviewed-by: Philippe Mathieu-Daudé
S
On 4/23/20 7:05 PM, Alex Bennée wrote:
We don't really need to track this fd beyond the initial creation of
the socket. We already know if the system has been initialised by
virtue of the gdbserver_state so lets remove it. This makes the later
re-factoring easier.
Signed-off-by: Alex Bennée
---
Public bug reported:
In a qemu-system-hppa system, qemu release v5.0.0-rc, the tulip nic driver is
broken.
The tulip nic is detected, even getting DHCP info does work.
But when trying to download bigger files via network, the tulip driver gets
stuck.
For example when trying to download a 100MB
On 4/23/20 4:40 PM, Dan Christian wrote:
> I'm new to trying to use qemu+bt (via btproxy) and haven't managed to
> get anything working.
>
> btproxy is launched first, then Zephyr launches qemu via it's west
> tool. The commands look like:
> sudo tools/btproxy -u -i 0 -d # in a separate window
>
On Thu, Apr 23, 2020 at 10:23 PM Philippe Mathieu-Daudé
wrote:
>
> monitor/misc.c never required "chardev/char-mux.h", remove it.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Marc-André Lureau
> ---
> monitor/misc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/monitor/mi
On Thu, Apr 23, 2020 at 10:22 PM Philippe Mathieu-Daudé
wrote:
>
> As the machine notify handlers are only used in system emulation,
> split the current file in two, and only build the notifier when
> system emulation is used.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Marc-André Lur
On Thu, Apr 23, 2020 at 10:22 PM Philippe Mathieu-Daudé
wrote:
>
> The msmouse / wctablet / testdev character devices are only
> used by system emulation. Remove them from user mode and tools.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Marc-André Lureau
> ---
> chardev/Makefile.o
On Thu, Apr 23, 2020 at 10:22 PM Philippe Mathieu-Daudé
wrote:
>
> This test never required "chardev/char-mux.h", remove it.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Marc-André Lureau
> ---
> tests/test-char.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tests/test-c
On Thu, 23 Apr 2020 at 21:25, Philippe Mathieu-Daudé wrote:
>
> On 4/23/20 10:20 PM, Peter Maydell wrote:
> > This will fix the assertion; for the specific case of the generic
> > loader it will then fall back from "guess this is an ELF file" to
> > "maybe it's a uImage or a hex file" and eventual
On 4/23/20 7:13 PM, Daniel P. Berrangé wrote:
On Thu, Apr 23, 2020 at 01:04:13PM -0400, Cleber Rosa wrote:
- Original Message -
From: "Peter Maydell"
To: "Markus Armbruster"
Cc: "Fam Zheng" , "Thomas Huth" , "Beraldo Leal"
, "Erik
Skultety" , "Alex Bennée" , "Wainer
Moschetta" ,
"QE
On Thu, Apr 23, 2020 at 10:24 PM Philippe Mathieu-Daudé
wrote:
>
> Split out code only used during system emulation,
> to reduce code pulled in user emulation and tools.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Marc-André Lureau
> ---
> chardev/chardev-internal.h | 3 ++
> cha
On Thu, Apr 23, 2020 at 10:24 PM Philippe Mathieu-Daudé
wrote:
>
> No file out of chardev/ requires access to this header,
> restrict its scope.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Marc-André Lureau
> ---
> include/chardev/char-mux.h => chardev/chardev-internal.h | 7 -
Commit 8ffb7265af does make the code safer, but broke the device model.
Instead of setting the error bits when the frame length is incorrect (too big),
it simply discards it. The guest is not notified of the error and keeps waiting.
--
You received this bug notification because you are a member
Our comment did not actually match the code. Rewrite the comment to
be less sensitive to any future changes to qcow2-bitmap.c that might
implement scenarios that we currently reject.
Signed-off-by: Eric Blake
---
block/qcow2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/
In v2:
- new patch 1 [Max]
- split off and reword unrelated change into patch 3 [Max]
- improve the test: grep for items of interest, check $? [Max]
- improve commit message explaining partial failure [Max]
Eric Blake (3):
block: Add blk_new_with_bs() helper
qcow2: Allow resize of images with
There are several callers that need to create a new block backend from
an existing BDS; make the task slightly easier with a common helper
routine.
Suggested-by: Max Reitz
Signed-off-by: Eric Blake
---
include/sysemu/block-backend.h | 2 ++
block/block-backend.c | 23 +
We originally refused to allow resize of images with internal
snapshots because the v2 image format did not require the tracking of
snapshot size, making it impossible to safely revert to a snapshot
with a different size than the current view of the image. But the
snapshot size tracking was rectif
Patchew URL: https://patchew.org/QEMU/20200423221707.477404-1-ebl...@redhat.com/
Hi,
This series failed the asan build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#!/bin/bash
expor
Patchew URL: https://patchew.org/QEMU/20200423221707.477404-1-ebl...@redhat.com/
Hi,
This series failed the docker-quick@centos7 build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
Patchew URL: https://patchew.org/QEMU/20200423221707.477404-1-ebl...@redhat.com/
Hi,
This series failed the docker-mingw@fedora build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#
Signed-off-by: Stephen Long
---
target/arm/helper-sve.h| 3 +++
target/arm/sve.decode | 10 ++
target/arm/sve_helper.c| 13 +
target/arm/translate-sve.c | 18 ++
4 files changed, 44 insertions(+)
diff --git a/target/arm/helper-sve.h b/target/arm/
Used the helper functions in crypto_helper.c to implement the helper
functions for the crypto insns.
Stephen Long (3):
target/arm: Implement SVE2 AESMC, AESIMC
target/arm: Implement SVE2 AESE, AESD, SM4E
target/arm: Implement SVE2 SM4EKEY, RAX1
target/arm/cpu.h | 5 +++
target/a
Signed-off-by: Stephen Long
---
target/arm/helper-sve.h| 3 +++
target/arm/sve.decode | 4
target/arm/sve_helper.c| 21 +
target/arm/translate-sve.c | 30 ++
4 files changed, 58 insertions(+)
diff --git a/target/arm/helper-sve.h
Signed-off-by: Stephen Long
---
target/arm/cpu.h | 5 +
target/arm/helper-sve.h| 4
target/arm/sve.decode | 6 ++
target/arm/sve_helper.c| 25 +
target/arm/translate-sve.c | 16
5 files changed, 56 insertions(+)
diff
On Thu, Apr 23, 2020 at 11:03 PM Jag Raman wrote:
>
>
> > On Apr 23, 2020, at 9:54 AM, 罗勇刚(Yonggang Luo)
> wrote:
> >
> > Does multi-process support on Windows?
> > I found it use mmap and unix socket for inter-process communication,
> that may not support under Windows.
>
> Hi Yonggang,
>
> We
On 4/23/20 10:24 AM, Daniel P. Berrangé wrote:
> On Thu, Apr 23, 2020 at 08:40:10AM -0700, Richard Henderson wrote:
>> On 4/23/20 2:00 AM, Philippe Mathieu-Daudé wrote:
> @@ -1885,12 +1896,17 @@ static char *tcg_get_arg_str_ptr(TCGContext *s,
> char *buf, int buf_size,
> {
>
On 4/22/20 1:04 PM, Alex Bennée wrote:
>
> Richard Henderson writes:
>
>> Signed-off-by: Richard Henderson
>
> We have a regression. Setting up a build dir with:
>
> ../../configure --disable-tools --disable-docs
> --target-list=sparc-softmmu,sparc64-softmmu
> make -j30 && make check-acc
Bit #14 is "DE" for 'Descriptor Error':
When set, indicates a frame truncation caused by a frame
that does not fit within the current descriptor buffers,
and that the 21143 does not own the next descriptor.
[Table 4-1. RDES0 Bit Fields Description]
Signed-off-by: Philippe Mathieu-Daudé
Log with GUEST_ERROR what the guest is doing wrong.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/net/tulip.c | 16
1 file changed, 16 insertions(+)
diff --git a/hw/net/tulip.c b/hw/net/tulip.c
index 1295f51d07..470f635acb 100644
--- a/hw/net/tulip.c
+++ b/hw/net/tulip.c
@@ -172
When a frame lenght is incorrect, set the RDES0 'Error Summary'
and 'Frame too long' bits. Then stop the receive process and
trigger an abnormal interrupt. See [4.3.5 Receive Process].
Cc: Li Qiang
Cc: Li Qiang
Cc: Ziming Zhang
Cc: Jason Wang
Cc: Prasad J Pandit
Fixes: 8ffb7265af ("check fram
Attempt to fix the launchpad bug filled by Helge:
In a qemu-system-hppa system, qemu release v5.0.0-rc,
the tulip nic driver is broken. The tulip nic is detected,
even getting DHCP info does work. But when trying to
download bigger files via network, the tulip driver gets
stuck.
Phili
On Thu, Apr 23, 2020 at 11:03 PM Jag Raman wrote:
>
>
> > On Apr 23, 2020, at 9:54 AM, 罗勇刚(Yonggang Luo)
> wrote:
> >
> > Does multi-process support on Windows?
> > I found it use mmap and unix socket for inter-process communication,
> that may not support under Windows.
>
> Hi Yonggang,
>
> We
> -Original Message-
> From: Jason Wang
> Sent: Thursday, April 23, 2020 5:07 PM
> To: Zhang, Chen ; qemu-dev de...@nongnu.org>
> Cc: Zhang Chen
> Subject: Re: [PATCH 0/2] net/colo-compare.c: Expose "max_queue_size" to
> users and clean up
>
>
> On 2020/4/23 下午4:59, Zhang, Chen wrote
On Mon, Apr 13, 2020 at 05:36:28PM -0300, Daniel Henrique Barboza wrote:
> The pseries machine does not support NVDIMM modules without label.
> Attempting to do so, even if the overall block size is aligned with
> 256MB, will seg fault the guest kernel during NVDIMM probe. This
> can be avoided by
On Tue, Apr 14, 2020 at 08:04:29AM -0300, Daniel Henrique Barboza wrote:
>
>
> On 4/13/20 11:01 PM, David Gibson wrote:
> > CCing Xiao, Michael and Igor for generic NVDIMM perspective.
> >
> > On Mon, Apr 13, 2020 at 05:36:28PM -0300, Daniel Henrique Barboza wrote:
> > > The pseries machine does
On 2020/4/24 上午7:16, Philippe Mathieu-Daudé wrote:
When a frame lenght is incorrect, set the RDES0 'Error Summary'
and 'Frame too long' bits. Then stop the receive process and
trigger an abnormal interrupt. See [4.3.5 Receive Process].
Cc: Li Qiang
Cc: Li Qiang
Cc: Ziming Zhang
Cc: Jason Wa
On 2020/4/11 上午11:38, Zhang Chen wrote:
From: Zhang Chen
This series make a way to config COLO "max_queue_size" parameters according to
user's scenarios and environments and do some clean up for descriptions.
Zhang Chen (2):
net/colo-compare.c: Expose compare "max_queue_size" to users
There are some problems with this patch. It doesn't apply cleanly.
Are you sure you’re developing on an up to date master branch?
On Thu, Apr 23, 2020 at 09:39:36PM +0300, Dima Stepanov wrote:
>
> In case of the vhost-user devices the daemon can be killed at any
> moment. Since QEMU supports the
I’m not opposed to adding this kind of debugging functionality to the
vhost-user-blk sample. It could be helpful to easily test these cases
in the future.
That said, I'm not sure how others will feel about adding these kind
of debugging capabilities to libvhost-user. Marc-Andre, thoughts?
If we g
On 4/23/20 1:21 PM, Philippe Mathieu-Daudé wrote:
> chardev cleanup while reviewing 'Refactor machine_init and exit
> notifiers' from the multi-process series:
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg697510.html
>
> Elena Ufimtseva (1):
> multi-process: Refactor machine_init and
On 2020/4/23 下午3:29, Zhang, Chen wrote:
-Original Message-
From: Lukas Straub
Sent: Wednesday, April 22, 2020 5:40 PM
To: Zhang, Chen
Cc: qemu-devel ; Li Zhijian
; Jason Wang ; Marc-
André Lureau ; Paolo Bonzini
Subject: Re: [PATCH 1/3] net/colo-compare.c: Create event_bh with the r
23.04.2020 18:01, Kevin Wolf wrote:
If BDRV_REQ_ZERO_WRITE is set and we're extending the image, calling
qcow2_cluster_zeroize() with flags=0 does the right thing: It doesn't
undo any previous preallocation, but just adds the zero flag to all
relevant L2 entries. If an external data file is in us
23.04.2020 18:01, Kevin Wolf wrote:
The raw format driver can simply forward the flag and let its bs->file
child take care of actually providing the zeros.
Signed-off-by: Kevin Wolf
Reviewed-by: Max Reitz
Reviewed-by: Eric Blake
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vlad
23.04.2020 18:01, Kevin Wolf wrote:
When extending the size of an image that has a backing file larger than
its old size, make sure that the backing file data doesn't become
visible in the guest, but the added area is properly zeroed out.
Consider the following scenario where the overlay is shor
23.04.2020 18:01, Kevin Wolf wrote:
We want to keep TEST_IMG for the full path of the main test image, but
filter_testfiles() must be called for other test images before replacing
other things like the image format because the test directory path could
contain the format as a substring.
Insert a
On Thu, Apr 23, 2020 at 11:28:21PM +0200, Philippe Mathieu-Daudé wrote:
> On 4/23/20 7:13 PM, Daniel P. Berrangé wrote:
> > On Thu, Apr 23, 2020 at 01:04:13PM -0400, Cleber Rosa wrote:
> > > - Original Message -
> > > > From: "Peter Maydell"
> > > > To: "Markus Armbruster"
> > > > Cc: "Fa
201 - 273 of 273 matches
Mail list logo
