Re: [PATCH] linux-user/syscall.c: add target-to-host mapping for epoll_create1()

2020-04-16 Thread Laurent Vivier
Le 16/04/2020 à 00:05, Sergei Trofimovich a écrit : > Noticed by Barnabás Virágh as a python-3.7 failue on qemu-alpha. > > The bug shows up on alpha as it's one of the targets where > EPOLL_CLOEXEC differs from other targets: > sysdeps/unix/sysv/linux/alpha/bits/epoll.h: EPOLL_CLOEXEC = 01000

Re: [PATCH] linux-user/syscall.c: add target-to-host mapping for epoll_create1()

2020-04-16 Thread Laurent Vivier
Le 16/04/2020 à 00:05, Sergei Trofimovich a écrit : > Noticed by Barnabás Virágh as a python-3.7 failue on qemu-alpha. > > The bug shows up on alpha as it's one of the targets where > EPOLL_CLOEXEC differs from other targets: > sysdeps/unix/sysv/linux/alpha/bits/epoll.h: EPOLL_CLOEXEC = 01000

Re: Integration of qemu-img

2020-04-16 Thread Markus Armbruster
Cc: qemu-block writes: > Dear Sir or Madam, > > > > I am a PhD student at the Friedrich-Alexander-University Erlangen-Nürnberg > in Bavaria Germany and I am currently working on an open-source forensic > analysis tool. I would like to use qemu-img for converting virtual discs to > raw files an

Re: [EXTERNAL] [PATCH] target/ppc: Fix mtmsr(d) L=1 variant that loses interrupts

2020-04-16 Thread Nicholas Piggin
Excerpts from Cédric Le Goater's message of April 15, 2020 4:49 pm: > On 4/14/20 1:11 PM, Nicholas Piggin wrote: >> >> The confusion arises from L=0 being "context synchronizing" whereas L=1 >> is "execution synchronizing", which is a weaker semantic. However this >> is not a relaxation of the req

qemu_coroutine_yield switches thread?

2020-04-16 Thread Stefan Reiter
Hi list, quick question: Can a resume from a qemu_coroutine_yield happen in a different thread? Well, it can, since I'm seeing it happen, but is that okay or a bug? I.e. in a backup-job the following can sporadically trip: unsigned long tid = pthread_self(); qemu_get_current_aio_context(

Re: [PATCH v19 QEMU 1/4] virtio-balloon: Implement support for page poison tracking feature

2020-04-16 Thread David Hildenbrand
>> >> Postcopy is a very good point, bought! >> >> But (what you wrote above) it sounds like that this is really what we *have >> to* do, not an optimization. I‘ll double check the spec tomorrow (hopefully >> it was documented). We should rephrase the comment then. > > Do you have a link to the

Re: qemu_coroutine_yield switches thread?

2020-04-16 Thread Kevin Wolf
Am 16.04.2020 um 10:06 hat Stefan Reiter geschrieben: > Hi list, > > quick question: Can a resume from a qemu_coroutine_yield happen in a > different thread? > > Well, it can, since I'm seeing it happen, but is that okay or a bug? Yes, it can happen. At least for devices like IDE where a request

Re: [PATCH v19 QEMU 1/4] virtio-balloon: Implement support for page poison tracking feature

2020-04-16 Thread David Hildenbrand
On 16.04.20 10:18, David Hildenbrand wrote: >>> >>> Postcopy is a very good point, bought! >>> >>> But (what you wrote above) it sounds like that this is really what we *have >>> to* do, not an optimization. I‘ll double check the spec tomorrow (hopefully >>> it was documented). We should rephrase

[PATCH] Cadence: gem: fix wraparound in 64bit descriptors

2020-04-16 Thread Ramon Fried
Wraparound of TX descriptor cyclic buffer only updated the low 32 bits of the descriptor. Fix that by checking if we're working with 64bit descriptors. Signed-off-by: Ramon Fried --- hw/net/cadence_gem.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/hw/net/cadence_g

Re: [PATCH] Cadence: gem: fix wraparound in 64bit descriptors

2020-04-16 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200416090247.353414-1-rfried@gmail.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash e

[PATCH 0/1] LUKS: Fix error message when underlying fs don't support large enough files

2020-04-16 Thread Maxim Levitsky
This is a repost of the same trivial patch I already, which fell through the cracks. Could someone queue it up so I close the bugzilla I have for this? Best regards, Maxim Levitsky Maxim Levitsky (1): block/crypto: better error message when creating too large files block/crypto.c | 2

[PATCH 1/1] block/crypto: better error message when creating too large files

2020-04-16 Thread Maxim Levitsky
Currently if you attampt to create too large file with luks you get the following error message: Formatting 'test.luks', fmt=luks size=17592186044416 key-secret=sec0 qemu-img: test.luks: Could not resize file: File too large While for raw format the error message is qemu-img: test.img: The image

Re: [PATCH 0/1] LUKS: Fix error message when underlying fs don't support large enough files

2020-04-16 Thread Maxim Levitsky
On Thu, 2020-04-16 at 12:50 +0300, Maxim Levitsky wrote: > This is a repost of the same trivial patch I already, which fell through the > cracks. > Could someone queue it up so I close the bugzilla I have for this? I a word - need more coffee :-) I mean I already posted this patch few months ago

Re: qemu_coroutine_yield switches thread?

2020-04-16 Thread Dietmar Maurer
> > quick question: Can a resume from a qemu_coroutine_yield happen in a > > different thread? > > > > Well, it can, since I'm seeing it happen, but is that okay or a bug? > > Yes, it can happen. At least for devices like IDE where a request is > started during a vmexit (MMIO or I/O port write),

Re: qemu_coroutine_yield switches thread?

2020-04-16 Thread Kevin Wolf
Am 16.04.2020 um 12:09 hat Dietmar Maurer geschrieben: > > > quick question: Can a resume from a qemu_coroutine_yield happen in a > > > different thread? > > > > > > Well, it can, since I'm seeing it happen, but is that okay or a bug? > > > > Yes, it can happen. At least for devices like IDE wher

[Bug 1871267] Re: Multiple (Repeating) Keystrokes in macOS

2020-04-16 Thread Alex
Issues with time emulation. MacOS runs on qemu with a specific cpu option: -cpu Penryn,vendor=GenuineIntel,+invtsc,vmware-cpuid-freq=on. The code of cpu_x86_cpuid has no handler for 0x4010, so vmware-cpuid-freq is ignored. Another solution is to modify tsc_increment_by_tick value in MSR_IA32

[Bug 1829242] Re: qemu on windows host exits after savevm command

2020-04-16 Thread Alex
** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1829242 Title: qemu on windows host exits after savevm command Status in QEMU: Fix

Re: [PATCH] Cadence: gem: fix wraparound in 64bit descriptors

2020-04-16 Thread Philippe Mathieu-Daudé
On 4/16/20 11:39 AM, no-re...@patchew.org wrote: Patchew URL: https://patchew.org/QEMU/20200416090247.353414-1-rfried@gmail.com/ [...] ERROR:/tmp/qemu-test/src/tests/qtest/migration-test.c:1229:test_migrate_auto_converge: 'got_stop' should be FALSE ERROR - Bail out! ERROR:/tmp/qemu-test

Re: m68k: gdbstub crashing setting float register on cfv4e cpu

2020-04-16 Thread Laurent Vivier
Le 14/04/2020 à 18:56, Alex Bennée a écrit : > > Philippe Mathieu-Daudé writes: > >> gdbstub/m68k seems broken with floats, previous to refactor commit >> a010bdbe719 ("extend GByteArray to read register helpers"). >> >> HEAD at 6fb1603aa2: >> >> $ qemu-system-m68k -s -S -cpu cfv4e >> >> ---[GUE

Re: [PATCH 01/16] accel/tcg: Add block comment for probe_access

2020-04-16 Thread Peter Maydell
On Wed, 11 Mar 2020 at 06:44, Richard Henderson wrote: > > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v2 02/16] accel/tcg: Add probe_access_flags

2020-04-16 Thread Peter Maydell
On Thu, 12 Mar 2020 at 04:34, Richard Henderson wrote: > > This new interface will allow targets to probe for a page > and then handle watchpoints themselves. This will be most > useful for vector predicated memory operations, where one > page lookup can be used for many operations, and one test

Re: [PATCH 03/16] exec: Add cpu_probe_watchpoint

2020-04-16 Thread Peter Maydell
On Wed, 11 Mar 2020 at 06:44, Richard Henderson wrote: > > Allow probing of a watchpoint *without* raising an exception. > This is of most use for no-fault loads, which should indicate > via some architectural means that the load did not occur. > > Signed-off-by: Richard Henderson > --- > includ

Re: [PATCH 04/16] target/arm: Use cpu_*_data_ra for sve_ldst_tlb_fn

2020-04-16 Thread Peter Maydell
On Wed, 11 Mar 2020 at 06:44, Richard Henderson wrote: > > Use the "normal" memory access functions, rather than the > softmmu internal helper functions directly. > > Since fb901c905dc3, cpu_mem_index is now a simple extract > from env->hflags and not a large computation. Which means > that it's

Re: [PATCH 05/16] target/arm: Drop manual handling of set/clear_helper_retaddr

2020-04-16 Thread Peter Maydell
On Wed, 11 Mar 2020 at 06:44, Richard Henderson wrote: > > Since we converted back to cpu_*_data_ra, we do not need to > do this ourselves. > > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell thanks -- PMM

Re: [EXTERNAL] [PATCH] target/ppc: Fix mtmsr(d) L=1 variant that loses interrupts

2020-04-16 Thread Alex Bennée
Cédric Le Goater writes: > On 4/14/20 1:11 PM, Nicholas Piggin wrote: >> If mtmsr L=1 sets MSR[EE] while there is a maskable exception pending, >> it does not cause an interrupt. This causes the test case to hang: >> >> https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.gnu.org_archive

Re: [PATCH RFC] configure: prefer sphinx-build to sphinx-build-3

2020-04-16 Thread Alex Bennée
John Snow writes: > On 4/15/20 1:55 PM, Peter Maydell wrote: >> On Wed, 15 Apr 2020 at 18:33, John Snow wrote: >>> >>> sphinx-build is the name of the script entry point from the sphinx >>> package itself. sphinx-build-3 is a pacakging convention by Linux >>> distributions. Prefer, where possi

Re: [PATCH v18 3/4] qcow2: add zstd cluster compression

2020-04-16 Thread Alberto Garcia
On Thu 02 Apr 2020 08:36:44 AM CEST, Denis Plotnikov wrote: > +static ssize_t qcow2_zstd_compress(void *dest, size_t dest_size, > + const void *src, size_t src_size) > +{ > +ssize_t ret; > +ZSTD_outBuffer output = { dest, dest_size, 0 }; > +ZSTD_inBuffe

Re: [PATCH 06/16] target/arm: Add sve infrastructure for page lookup

2020-04-16 Thread Peter Maydell
On Wed, 11 Mar 2020 at 06:44, Richard Henderson wrote: > > For contiguous predicated memory operations, we want to > minimize the number of tlb lookups performed. We have > open-coded this for sve_ld1_r, but for correctness with > MTE we will need this for all of the memory operations. > > Create

Re: [PATCH v18 3/4] qcow2: add zstd cluster compression

2020-04-16 Thread Denis Plotnikov
On 16.04.2020 15:55, Alberto Garcia wrote: On Thu 02 Apr 2020 08:36:44 AM CEST, Denis Plotnikov wrote: +static ssize_t qcow2_zstd_compress(void *dest, size_t dest_size, + const void *src, size_t src_size) +{ +ssize_t ret; +ZSTD_outBuffer output = { de

Re: [PATCH 07/16] target/arm: Adjust interface of sve_ld1_host_fn

2020-04-16 Thread Peter Maydell
On Wed, 11 Mar 2020 at 06:44, Richard Henderson wrote: > > The current interface includes a loop; change it to load a > single element. We will then be able to use the function > for ld{2,3,4} where individual vector elements are not adjacent. > > Replace each call with the simplest possible loop

Re: [PATCH 08/16] target/arm: Use SVEContLdSt in sve_ld1_r

2020-04-16 Thread Peter Maydell
On Wed, 11 Mar 2020 at 06:44, Richard Henderson wrote: > > First use of the new helper functions, so we can remove the > unused markup. No longer need a scratch for user-only, as > we completely probe the page set before reading; system mode > still requires a scratch for MMIO. > > Signed-off-by:

Re: [PATCH 09/16] target/arm: Handle watchpoints in sve_ld1_r

2020-04-16 Thread Peter Maydell
On Wed, 11 Mar 2020 at 06:44, Richard Henderson wrote: > > Handle all of the watchpoints for active elements all at once, > before we've modified the vector register. This removes the > TLB_WATCHPOINT bit from page[].flags, which means that we can > use the normal fast path via RAM. > > Signed-of

[PATCH RFC v2] target/arm: Implement SVE2 HISTCNT, HISTSEG

2020-04-16 Thread Stephen Long
Signed-off-by: Stephen Long --- Whoops, I was mistaken on what HISTSEG was doing. target/arm/helper-sve.h| 7 +++ target/arm/sve.decode | 6 +++ target/arm/sve_helper.c| 90 ++ target/arm/translate-sve.c | 29 4 files changed, 132 i

Re: [PATCH 10/16] target/arm: Use SVEContLdSt for multi-register contiguous loads

2020-04-16 Thread Peter Maydell
On Wed, 11 Mar 2020 at 06:44, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/sve_helper.c | 223 ++-- > 1 file changed, 79 insertions(+), 144 deletions(-) > #define DO_LDN_1(N) \ > -void QEMU_FLATTEN HELPER(sve_ld##N##bb_r)

[PATCH RFC v3] target/arm: Implement SVE2 HISTCNT, HISTSEG

2020-04-16 Thread Stephen Long
Signed-off-by: Stephen Long --- Disregard my previous patch. There was a mistake in translate_HISTCNT(). target/arm/helper-sve.h| 7 +++ target/arm/sve.decode | 6 +++ target/arm/sve_helper.c| 90 ++ target/arm/translate-sve.c | 29

RE: [PATCH v25 00/10] Add ARMv8 RAS virtualization support in QEMU

2020-04-16 Thread gengdongjiu
ping 发件人:gengdongjiu 收件人:imammedo ;mst ;xiaoguangrong.eric ;Peter Maydell ;shannon.zhaosl ;fam ;rth ;Eduardo Habkost ;mtosatti ;qemu-devel ;kvm ;qemu-arm ;pbonzini 抄 送:gengdongjiu ;zhengxiang (A) ;Jonathan Cameron ;Linuxarm 时 间:2020-04-10 19:45:28 主 题:[PATCH v25 00/10] Add ARMv8 RAS

Re: [PATCH v25 00/10] Add ARMv8 RAS virtualization support in QEMU

2020-04-16 Thread Peter Maydell
On Thu, 16 Apr 2020 at 14:54, gengdongjiu wrote: > > ping Hi; this is on my to-review queue, but so are 25 other patchsets. (I've built up a bit of a backlog due to concentrating on work for the 5.0 release while we're in the freeze period.) I will get to it eventually if nobody else does fir

RE: [PATCH v25 00/10] Add ARMv8 RAS virtualization support in QEMU

2020-04-16 Thread gengdongjiu
ok,thanks very much for peter's time and reply 发件人:Peter Maydell 收件人:gengdongjiu 抄 送:imammedo ;mst ;xiaoguangrong.eric ;shannon.zhaosl ;fam ;rth ;Eduardo Habkost ;mtosatti ;qemu-devel ;kvm ;qemu-arm ;pbonzini ;zhengxiang (A) ;Linuxarm ;Jonathan Cameron 时 间:2020-04-16 22:02:34 主 题:Re:

Re: [edk2-discuss] Load Option passing. Either bugs or my confusion.

2020-04-16 Thread Laszlo Ersek
On 04/16/20 06:38, Hou Qiming wrote: > Very good point, I did neglect ramfb resolution changes... But there is one > important thing: it *can* cause a QEMU crash, a potentially exploitable > one, not always a guest crash. That's what motivated my heavy-handed > approach since allowing resolution ch

Re: [PATCH 11/16] target/arm: Update contiguous first-fault and no-fault loads

2020-04-16 Thread Peter Maydell
On Wed, 11 Mar 2020 at 06:44, Richard Henderson wrote: > > With sve_cont_ldst_pages, the differences between first-fault and no-fault > are minimal, so unify the routines. With cpu_probe_watchpoint, we are able > to make progress through pages with TLB_WATCHPOINT set when the watchpoint > does no

Re: [PATCH 12/16] target/arm: Use SVEContLdSt for contiguous stores

2020-04-16 Thread Peter Maydell
On Wed, 11 Mar 2020 at 06:44, Richard Henderson wrote: > > Follow the model set up for contiguous loads. This handles > watchpoints correctly for contiguous stores, recognizing the > exception before any changes to memory. > > Signed-off-by: Richard Henderson > --- > target/arm/sve_helper.c | 2

Re: [PATCH 15/16] target/arm: Reuse sve_probe_page for gather loads

2020-04-16 Thread Peter Maydell
On Wed, 11 Mar 2020 at 06:44, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/sve_helper.c | 208 +--- > 1 file changed, 109 insertions(+), 99 deletions(-) > Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH 13/16] target/arm: Reuse sve_probe_page for gather first-fault loads

2020-04-16 Thread Peter Maydell
On Wed, 11 Mar 2020 at 06:44, Richard Henderson wrote: > > This avoids the need for a separate set of helpers to implement > no-fault semantics, and will enable MTE in the future. > > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH 14/16] target/arm: Reuse sve_probe_page for scatter stores

2020-04-16 Thread Peter Maydell
On Wed, 11 Mar 2020 at 06:44, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/sve_helper.c | 182 > 1 file changed, 111 insertions(+), 71 deletions(-) > Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH 16/16] target/arm: Remove sve_memopidx

2020-04-16 Thread Peter Maydell
On Wed, 11 Mar 2020 at 06:44, Richard Henderson wrote: > > None of the sve helpers use TCGMemOpIdx any longer, so we can > stop passing it. > > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH 00/16] target/arm: sve load/store improvements

2020-04-16 Thread Peter Maydell
On Wed, 11 Mar 2020 at 06:44, Richard Henderson wrote: > > The goal here is to support MTE, but there's some cleanup to do. > > Technically, we have sufficient interfaces in cputlb.c now, but it > requires multiple tlb lookups on different interfaces to do so. > > Adding probe_access_flags() allow

Re: [PATCH v19 QEMU 1/4] virtio-balloon: Implement support for page poison tracking feature

2020-04-16 Thread Michael S. Tsirkin
On Thu, Apr 16, 2020 at 10:18:49AM +0200, David Hildenbrand wrote: > >> > >> Postcopy is a very good point, bought! > >> > >> But (what you wrote above) it sounds like that this is really what we > >> *have to* do, not an optimization. I‘ll double check the spec tomorrow > >> (hopefully it was do

[PATCH RFC v4] target/arm: Implement SVE2 HISTCNT, HISTSEG

2020-04-16 Thread Stephen Long
Signed-off-by: Stephen Long --- Fix error in the helper function for HISTSEG target/arm/helper-sve.h| 7 +++ target/arm/sve.decode | 6 +++ target/arm/sve_helper.c| 94 ++ target/arm/translate-sve.c | 29 4 files changed, 136 insert

[PATCH 0/3] qemu-img: Add convert --bitmaps

2020-04-16 Thread Eric Blake
Without this series, the process for copying one qcow2 image to another including all of its bitmaps involves running qemu and doing the copying by hand with a series of QMP commands. This makes the process a bit more convenient. I still think that someday we will need a 'qemu-img bitmap' with va

[PATCH 1/3] blockdev: Split off basic bitmap operations for qemu-img

2020-04-16 Thread Eric Blake
The next patch wants to teach qemu how to copy a bitmap from one qcow2 file to another. But blockdev.o is too heavyweight to link into qemu-img, so it's time to split off the bare bones of what we will need into a new file blockbitmaps.o. Transactions are not needed in qemu-img (if things fail wh

[PATCH 3/3] iotests: Add test 291 to for qemu-img convert --bitmaps

2020-04-16 Thread Eric Blake
Add a new test covering the feature added in the previous patch. Signed-off-by: Eric Blake --- tests/qemu-iotests/291 | 143 + tests/qemu-iotests/291.out | 56 +++ tests/qemu-iotests/group | 1 + 3 files changed, 200 insertions(+) create

[PATCH 2/3] qemu-img: Add convert --bitmaps option

2020-04-16 Thread Eric Blake
Make it easier to copy all the persistent bitmaps of a source image along with the contents, by adding a boolean flag for use with qemu-img convert. See also https://bugzilla.redhat.com/show_bug.cgi?id=1779893 Signed-off-by: Eric Blake --- docs/tools/qemu-img.rst | 6 ++- qemu-img.c

[Qemu devel PATCH v6 2/3] msf2: Add EMAC block to SmartFusion2 SoC

2020-04-16 Thread sundeep . lkml
From: Subbaraya Sundeep With SmartFusion2 Ethernet MAC model in place this patch adds the same to SoC. Signed-off-by: Subbaraya Sundeep Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- hw/arm/msf2-soc.c | 26 -- include/hw/arm/msf2-soc

[Qemu devel PATCH v6 0/3] Add SmartFusion2 EMAC block

2020-04-16 Thread sundeep . lkml
From: Subbaraya Sundeep This patch set emulates Ethernet MAC block present in Microsemi SmartFusion2 SoC. v6: Fixed destination address matching logic Added missing break in emac_write v5: As per Philippe comments: Returned size in receive function Added link property to pass

[Qemu devel PATCH v6 3/3] tests/boot_linux_console: Add ethernet test to SmartFusion2

2020-04-16 Thread sundeep . lkml
From: Subbaraya Sundeep In addition to simple serial test this patch uses ping to test the ethernet block modelled in SmartFusion2 SoC. Signed-off-by: Subbaraya Sundeep Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- tests/acceptance/boot_linux_console.py | 15 +

[Qemu devel PATCH v6 1/3] hw/net: Add Smartfusion2 emac block

2020-04-16 Thread sundeep . lkml
From: Subbaraya Sundeep Modelled Ethernet MAC of Smartfusion2 SoC. Micrel KSZ8051 PHY is present on Emcraft's SOM kit hence same PHY is emulated. Signed-off-by: Subbaraya Sundeep Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- MAINTAINERS| 2 + hw/

Re: [PATCH v19 QEMU 1/4] virtio-balloon: Implement support for page poison tracking feature

2020-04-16 Thread David Hildenbrand
>> We should document our result of page poisoning, free page hinting, and >> free page reporting there as well. I hope you'll have time for the latter. >> >> - >> Semantics of VIRTIO_BALLOON_F_PAGE_POISON >> --

Re: [PATCH] 9pfs: local: ignore O_NOATIME if we don't have permissions

2020-04-16 Thread Christian Schoenebeck
On Donnerstag, 16. April 2020 02:44:33 CEST Omar Sandoval wrote: > From: Omar Sandoval > > QEMU's local 9pfs server passes through O_NOATIME from the client. If > the QEMU process doesn't have permissions to use O_NOATIME (namely, it > does not own the file nor have the CAP_FOWNER capability), th

Re: [PATCH v2 2/8] hw/watchdog: Implement full i.MX watchdog support

2020-04-16 Thread Peter Maydell
On Sun, 22 Mar 2020 at 21:19, Guenter Roeck wrote: > > Implement full support for the watchdog in i.MX systems. > Pretimeout support is optional because the watchdog hardware on i.MX31 > does not support pretimeouts. > > Signed-off-by: Guenter Roeck > --- > v2: Fixup of CONFIG_WDT_IMX -> CONFIG_W

Re: [PATCH v2 7/8] hw/arm/fsl-imx7: Instantiate various unimplemented devices

2020-04-16 Thread Peter Maydell
On Sun, 22 Mar 2020 at 21:19, Guenter Roeck wrote: > > Instantiating PWM, CAN, CAAM, and OCOTP devices is necessary to avoid > crashes when booting mainline Linux. > > Signed-off-by: Guenter Roeck Reviewed-by: Peter Maydell thanks -- PMM

[PULL 0/1] Linux user for 5.0 patches

2020-04-16 Thread Laurent Vivier
The following changes since commit 20038cd7a8412feeb49c01f6ede89e36c8995472: Update version for v5.0.0-rc3 release (2020-04-15 20:51:54 +0100) are available in the Git repository at: git://github.com/vivier/qemu.git tags/linux-user-for-5.0-pull-request for you to fetch changes up to 386d386

[PULL 1/1] linux-user/syscall.c: add target-to-host mapping for epoll_create1()

2020-04-16 Thread Laurent Vivier
From: Sergei Trofimovich Noticed by Barnabás Virágh as a python-3.7 failue on qemu-alpha. The bug shows up on alpha as it's one of the targets where EPOLL_CLOEXEC differs from other targets: sysdeps/unix/sysv/linux/alpha/bits/epoll.h: EPOLL_CLOEXEC = 0100 sysdeps/unix/sysv/linux/bit

Re: [PATCH v2 8/8] hw/arm/fsl-imx7: Connect watchdog interrupts

2020-04-16 Thread Peter Maydell
On Sun, 22 Mar 2020 at 21:19, Guenter Roeck wrote: > > i.MX7 supports watchdog pretimeout interupts. With this commit, > the watchdog in mcimx7d-sabre is fully operational, including > pretimeout support. > > Signed-off-by: Guenter Roeck > diff --git a/include/hw/arm/fsl-imx7.h b/include/hw/arm/

[PATCH 2/2] qemu-storage-daemon: Fix non-string --object properties

2020-04-16 Thread Kevin Wolf
After processing the option string with the keyval parser, we get a QDict that contains only strings. This QDict must be fed to a keyval visitor which converts the strings into the right data types. qmp_object_add(), however, uses the normal QObject input visitor, which expects a QDict where all p

[PATCH 0/2] qemu-storage-daemon: Fix non-string --object properties

2020-04-16 Thread Kevin Wolf
Kevin Wolf (2): qom: Factor out user_creatable_add_dict() qemu-storage-daemon: Fix non-string --object properties include/qom/object_interfaces.h | 16 qemu-storage-daemon.c | 4 +--- qom/object_interfaces.c | 31 +++ qom/qom-qmp

[PATCH 1/2] qom: Factor out user_creatable_add_dict()

2020-04-16 Thread Kevin Wolf
The QMP handler qmp_object_add() and the implementation of --object in qemu-storage-daemon can share most of the code. Currently, qemu-storage-daemon calls qmp_object_add(), but this is not correct because different visitors need to be used. As a first step towards a fix, make qmp_object_add() a w

Re: [PATCH v2 4/6] dwc-hsotg USB host controller emulation

2020-04-16 Thread Peter Maydell
On Sun, 29 Mar 2020 at 00:18, Paul Zimmerman wrote: > > Add the dwc-hsotg (dwc2) USB host controller emulation code. > Based on hw/usb/hcd-ehci.c and hw/usb/hcd-ohci.c. > > Note that to use this with the dwc-otg driver in the Raspbian > kernel, you must pass the option "dwc_otg.fiq_fsm_enable=0" o

Re: [PATCH v2 4/6] dwc-hsotg USB host controller emulation

2020-04-16 Thread Peter Maydell
On Thu, 16 Apr 2020 at 16:45, Peter Maydell wrote: > > On Sun, 29 Mar 2020 at 00:18, Paul Zimmerman wrote: > > +s->as = &address_space_memory; > > Ideally this should be a device property. (hw/dma/pl080.c > has an example of how to declare a TYPE_MEMORY_REGION > property and then create an A

Re: [PULL 0/1] Linux user for 5.0 patches

2020-04-16 Thread Peter Maydell
On Thu, 16 Apr 2020 at 16:29, Laurent Vivier wrote: > > The following changes since commit 20038cd7a8412feeb49c01f6ede89e36c8995472: > > Update version for v5.0.0-rc3 release (2020-04-15 20:51:54 +0100) > > are available in the Git repository at: > > git://github.com/vivier/qemu.git tags/linux

Re: [PATCH RFC v4] target/arm: Implement SVE2 HISTCNT, HISTSEG

2020-04-16 Thread Richard Henderson
On 4/16/20 7:42 AM, Stephen Long wrote: > +static inline uint8_t do_histseg_cnt(uint8_t n, uint64_t m0, uint64_t m1) > +{ > +int esz = 0; Clearer to use MO_8. > +int bits = 8 << esz; > +uint64_t ones = dup_const(esz, 1); > +uint64_t signs = ones << (bits - 1); > +uint64_t cmp0

Re: [PATCH v2 4/6] dwc-hsotg USB host controller emulation

2020-04-16 Thread Philippe Mathieu-Daudé
On 4/16/20 5:47 PM, Peter Maydell wrote: On Thu, 16 Apr 2020 at 16:45, Peter Maydell wrote: On Sun, 29 Mar 2020 at 00:18, Paul Zimmerman wrote: +s->as = &address_space_memory; Ideally this should be a device property. (hw/dma/pl080.c has an example of how to declare a TYPE_MEMORY_REG

Re: [PATCH v1 0/2] dma/xlnx-zdma: Fix descriptor loading wrt host endianness

2020-04-16 Thread Peter Maydell
On Sat, 4 Apr 2020 at 13:26, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > Hi, > > This fixes the endinannes related bugs with descriptor loading > that Peter pointed out. > > Cheers, > Edgar > > Edgar E. Iglesias (2): > dma/xlnx-zdma: Fix descriptor loading (MEM) wrt endianness >

Re: [PATCH v2] aspeed: Add boot stub for smp booting

2020-04-16 Thread Peter Maydell
On Thu, 9 Apr 2020 at 07:31, Joel Stanley wrote: > > This is a boot stub that is similar to the code u-boot runs, allowing > the kernel to boot the secondary CPU. > +static void aspeed_write_smpboot(ARMCPU *cpu, > + const struct arm_boot_info *info) > +{ > +sta

[PATCH 0/2] virtiofsd: drop Linux capabilities(7)

2020-04-16 Thread Stefan Hajnoczi
virtiofsd doesn't need of all Linux capabilities(7) available to root. Keep a whitelisted set of capabilities that we require. This improves security in case virtiofsd is compromised by making it hard for an attacker to gain further access to the system. Stefan Hajnoczi (2): virtiofsd: only re

[PATCH 1/2] virtiofsd: only retain file system capabilities

2020-04-16 Thread Stefan Hajnoczi
virtiofsd runs as root but only needs a subset of root's Linux capabilities(7). As a file server its purpose is to create and access files on behalf of a client. It needs to be able to access files with arbitrary uid/gid owners. It also needs to be create device nodes. Introduce a Linux capabil

[PATCH 2/2] virtiofsd: drop all capabilities in the wait parent process

2020-04-16 Thread Stefan Hajnoczi
All this process does is wait for its child. No capabilities are needed. Signed-off-by: Stefan Hajnoczi --- tools/virtiofsd/passthrough_ll.c | 13 + 1 file changed, 13 insertions(+) diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough_ll.c index af97ba1c41..0

Re: [PATCH v2] nrf51: Fix last GPIO CNF address

2020-04-16 Thread Peter Maydell
On Wed, 15 Apr 2020 at 05:37, Cameron Esfahani wrote: > > NRF51_GPIO_REG_CNF_END doesn't actually refer to the start of the last > valid CNF register: it's referring to the last byte of the last valid > CNF register. > > This hasn't been a problem up to now, as current implementation in > memory.c

Re: [PULL 0/1] Linux user for 5.0 patches

2020-04-16 Thread Laurent Vivier
Le 16/04/2020 à 18:03, Peter Maydell a écrit : > On Thu, 16 Apr 2020 at 16:29, Laurent Vivier wrote: >> >> The following changes since commit 20038cd7a8412feeb49c01f6ede89e36c8995472: >> >> Update version for v5.0.0-rc3 release (2020-04-15 20:51:54 +0100) >> >> are available in the Git repositor

[PATCH RFC v5] target/arm: Implement SVE2 HISTCNT, HISTSEG

2020-04-16 Thread Stephen Long
Signed-off-by: Stephen Long --- Made the fixes Richard noted. target/arm/helper-sve.h| 7 +++ target/arm/sve.decode | 6 +++ target/arm/sve_helper.c| 104 + target/arm/translate-sve.c | 29 +++ 4 files changed, 146 insertions(+) diff

Re: [PATCH 2/2] virtiofsd: drop all capabilities in the wait parent process

2020-04-16 Thread Philippe Mathieu-Daudé
On 4/16/20 6:49 PM, Stefan Hajnoczi wrote: All this process does is wait for its child. No capabilities are needed. Signed-off-by: Stefan Hajnoczi --- tools/virtiofsd/passthrough_ll.c | 13 + 1 file changed, 13 insertions(+) diff --git a/tools/virtiofsd/passthrough_ll.c b/tools

[PATCH] linux-user/strace.list: fix epoll_create{,1} -strace output

2020-04-16 Thread Sergei Trofimovich
Fix syscall name and parameters priinter. Before the change: ``` $ alpha-linux-user/qemu-alpha -strace -L /usr/alpha-unknown-linux-gnu/ /tmp/a ... 1274697 %s(%d)(2097152,274903156744,274903156760,274905840712,274877908880,274903235616) = 3 1274697 exit_group(0) ``` After the change: ``` $ alp

Re: [PATCH v19 QEMU 1/4] virtio-balloon: Implement support for page poison tracking feature

2020-04-16 Thread Alexander Duyck
On Thu, Apr 16, 2020 at 7:55 AM David Hildenbrand wrote: > > >> We should document our result of page poisoning, free page hinting, and > >> free page reporting there as well. I hope you'll have time for the latter. > >> > >>

Re: [PATCH 0/3] qemu-img: Add convert --bitmaps

2020-04-16 Thread Nir Soffer
On Thu, Apr 16, 2020 at 5:51 PM Eric Blake wrote: > > Without this series, the process for copying one qcow2 image to > another including all of its bitmaps involves running qemu and doing > the copying by hand with a series of QMP commands. This makes the > process a bit more convenient. This s

Re: [PATCH RFC] configure: prefer sphinx-build to sphinx-build-3

2020-04-16 Thread John Snow
On 4/16/20 8:31 AM, Alex Bennée wrote: > > John Snow writes: > >> On 4/15/20 1:55 PM, Peter Maydell wrote: >>> On Wed, 15 Apr 2020 at 18:33, John Snow wrote: sphinx-build is the name of the script entry point from the sphinx package itself. sphinx-build-3 is a pacakging conven

Re: [PATCH v19 QEMU 1/4] virtio-balloon: Implement support for page poison tracking feature

2020-04-16 Thread David Hildenbrand
> The other thing to keep in mind is that the poison value only really > comes into play with hinting/reporting. In the case of the standard > balloon the pages are considered allocated from the guest's Currently just as free page hinting IMHO. They are temporarily considered allocated. > perspec

Re: [PATCH] 9pfs: local: ignore O_NOATIME if we don't have permissions

2020-04-16 Thread Omar Sandoval
On Thu, Apr 16, 2020 at 04:58:31PM +0200, Christian Schoenebeck wrote: > On Donnerstag, 16. April 2020 02:44:33 CEST Omar Sandoval wrote: > > From: Omar Sandoval > > > > QEMU's local 9pfs server passes through O_NOATIME from the client. If > > the QEMU process doesn't have permissions to use O_NO

Re: [PULL 0/1] Linux user for 5.0 patches

2020-04-16 Thread Peter Maydell
On Thu, 16 Apr 2020 at 18:16, Laurent Vivier wrote: > > Le 16/04/2020 à 18:03, Peter Maydell a écrit : > > On Thu, 16 Apr 2020 at 16:29, Laurent Vivier wrote: > >> > >> The following changes since commit > >> 20038cd7a8412feeb49c01f6ede89e36c8995472: > >> > >> Update version for v5.0.0-rc3 rel

Re: [PULL 0/1] Linux user for 5.0 patches

2020-04-16 Thread Laurent Vivier
Le 16/04/2020 à 21:08, Peter Maydell a écrit : > On Thu, 16 Apr 2020 at 18:16, Laurent Vivier wrote: >> >> Le 16/04/2020 à 18:03, Peter Maydell a écrit : >>> On Thu, 16 Apr 2020 at 16:29, Laurent Vivier wrote: The following changes since commit 20038cd7a8412feeb49c01f6ede89e36c899

Re: [PATCH RFC] configure: prefer sphinx-build to sphinx-build-3

2020-04-16 Thread Peter Maydell
On Thu, 16 Apr 2020 at 19:22, John Snow wrote: > My goal is to make virtual environments work out of the box. > > I.e., if you run ./configure from inside a VENV, it should "just work." Yeah, this seems reasonable to me. If I understand your patch correctly it ought to work without breaking the s

Re: [PATCH 0/3] qemu-img: Add convert --bitmaps

2020-04-16 Thread Eric Blake
(adding Markus for a CLI question, look for [*]) On 4/16/20 1:20 PM, Nir Soffer wrote: On Thu, Apr 16, 2020 at 5:51 PM Eric Blake wrote: Without this series, the process for copying one qcow2 image to another including all of its bitmaps involves running qemu and doing the copying by hand wit

[PATCH v1 PATCH v1 1/1] tests: machine-none-test: Enable MicroBlaze testing

2020-04-16 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Enable MicroBlaze testing. Signed-off-by: Edgar E. Iglesias --- tests/qtest/machine-none-test.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/tests/qtest/machine-none-test.c b/tests/qtest/machine-none-test.c index 8bb54a6360..209d86eb5

[PATCH v1 PATCH v1 0/1] tests: machine-none-test: Enable MicroBlaze testing

2020-04-16 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" This is to re-enable machine-none MicroBlaze testing. Cheers, Edgar Edgar E. Iglesias (1): tests: machine-none-test: Enable MicroBlaze testing tests/qtest/machine-none-test.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) -- 2.20.1

[Bug 1873335] [NEW] Dos Keypad is not working for numbers - numlock is not working

2020-04-16 Thread ruthan
Public bug reported: Hello, i tried to use Qemu 4.2 for Dos, but there is problem what in Dos is not possible turn on Numlock for input numbers, so games need it.. Numlock only working as arrow keys.   I tested bough Windows and Linux builds. With same setting, when i use Windows 98 or later os

[Bug 1873339] [NEW] Qemu DOS Quake - 640x480 and above resolutions - Unable to load VESA palette in dos prompt and game crashing are not working

2020-04-16 Thread ruthan
Public bug reported: I have problem make Quake Demo working with 640x480+, with 320x200 working fine. I tried 3 virtual videocards settings: -vga cirrus 640x480 is not available, probably emulated GPU has not enough VRAM or some Vesa2 utility is needed. For -vga std and -vga vmware // 640x480 is

[Bug 1873338] [NEW] Dos on the fly CD image replacement is not Working with DOS

2020-04-16 Thread ruthan
Public bug reported: Im not able to exchange CD image on the fly (needed for some games). I messed with command like - in console(ATL+CRTL+2) eject ide1-cd0 and change ide-cd0 D:/Games/!Emulators/Dos-QEMU/ISOs/TestChangeISO.iso , but system so never able to find new CD data.. simply drive so empty

[Bug 1873337] [NEW] Arrow keys press is double in some programs in Dos

2020-04-16 Thread ruthan
Public bug reported: Hello, im trying to use Qemu for Dos machines. But there is problem with some programs that arrow key press is double in some problems. As advanced Filemanagers - Dos Navigator or File Wizard, same Scandisk. There is gif: https://www.vogons.org/download/file.php?id=77141&mo

[Bug 1873340] [NEW] KVM Old ATI(pre) AMD card passthrough is not working

2020-04-16 Thread ruthan
Public bug reported: Hello, tried to passthroug old ATI pre AMD PCI / PCI-E cards, on machine where anything else is working - Nvidia /Matrox / 3dfx cards.. Here are results: ATI Mach 64 PCI - videocard - machine start segfault ATI Rage XL PCI - videocard - machine start segfault ATI Radeon 7000

Re: [PATCH v2 4/6] dwc-hsotg USB host controller emulation

2020-04-16 Thread Paul Zimmerman
On 4/16/20 9:30 AM, Philippe Mathieu-Daudé wrote: On 4/16/20 5:47 PM, Peter Maydell wrote: On Thu, 16 Apr 2020 at 16:45, Peter Maydell wrote: On Sun, 29 Mar 2020 at 00:18, Paul Zimmerman wrote: +    s->as = &address_space_memory; Ideally this should be a device property. (hw/dma/pl080.c

[Bug 1873341] [NEW] Qemu Win98 VM with KVM videocard passthrough DOS mode video is not working for most of games..

2020-04-16 Thread ruthan
Public bug reported: Hello, im using Win98 machine with KVM videocards passthrough which is working fine, but when i try Windows 98 - Dosbox mode, there is something work with all videocards which i tried PCI-E/PCI - Nvidia, 3Dfx, Matrox. Often is framerate is very slow, as slideshow: Doom 2,

[PATCH v20 QEMU 1/5] linux-headers: Update to allow renaming of free_page_report_cmd_id

2020-04-16 Thread Alexander Duyck
From: Alexander Duyck Sync to the latest upstream changes for free page hinting. To be replaced by a full linux header sync. Signed-off-by: Alexander Duyck --- include/standard-headers/linux/virtio_balloon.h | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/incl

  1   2   >