Re: [PATCH v3 0/4] modify CPU model info

2020-04-10 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200410063555.2309-1-chenyi.qi...@intel.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash e

Re: [PATCH v6 16/36] multi-process: remote process initialization

2020-04-10 Thread Elena Ufimtseva
On Thu, Apr 09, 2020 at 07:00:02PM +0100, Dr. David Alan Gilbert wrote: > * elena.ufimts...@oracle.com (elena.ufimts...@oracle.com) wrote: > > From: Jagannathan Raman > > > > Adds the handler to process message from QEMU, > > Initialize remote process main loop, handles SYNC_SYSMEM > > message by

Re: [PATCH v4 06/30] qcow2: Add get_l2_entry() and set_l2_entry()

2020-04-10 Thread Vladimir Sementsov-Ogievskiy
17.03.2020 21:16, Alberto Garcia wrote: The size of an L2 entry is 64 bits, but if we want to have subclusters we need extended L2 entries. This means that we have to access L2 tables and slices differently depending on whether an image has extended L2 entries or not. This patch replaces all l2_

Re: [PATCH] Fixed IPv6 payload lenght without jumbo option

2020-04-10 Thread Andrew Melnichenko
Ok, later - I'll prepare a new patch with length fix, segmentation and checks. For now, the current patch can be discarded. On Fri, Apr 10, 2020 at 5:28 AM Jason Wang wrote: > > On 2020/4/9 下午9:35, Andrew Melnichenko wrote: > > > Do we support ipv6 segmentation then? > > No, but - if the backend

Re: [PATCH v4 08/30] qcow2: Add dummy has_subclusters() function

2020-04-10 Thread Vladimir Sementsov-Ogievskiy
17.03.2020 21:16, Alberto Garcia wrote: This function will be used by the qcow2 code to check if an image has subclusters or not. At the moment this simply returns false. Once all patches needed for subcluster support are ready then QEMU will be able to create and read images with subclusters an

Re: [PATCH] hax: Windows doesn't like posix device names

2020-04-10 Thread Volker Rümelin
> Is this relevant? Or should we drop HAX support for Windows? Personally > I have no experience with hardware acceleration for QEMU on macOS. There's another reason to keep hax for Windows. You can't enable the Hyper-V role on Windows 10 Home. Without hax and whpx there's no usable hypervisor

Re: [PATCH v4 07/30] qcow2: Document the Extended L2 Entries feature

2020-04-10 Thread Vladimir Sementsov-Ogievskiy
09.04.2020 18:12, Eric Blake wrote: On 3/17/20 1:16 PM, Alberto Garcia wrote: Subcluster allocation in qcow2 is implemented by extending the existing L2 table entries and adding additional information to indicate the allocation status of each subcluster. This patch documents the changes to the

Re: [PULL 08/13] softfloat: Fix BAD_SHIFT from normalizeFloatx80Subnormal

2020-04-10 Thread Aleksandar Markovic
17:55 Uto, 07.04.2020. Alex Bennée је написао/ла: > > From: Richard Henderson > > All other calls to normalize*Subnormal detect zero input before > the call -- this is the only outlier. This case can happen with > +0.0 + +0.0 = +0.0 or -0.0 + -0.0 = -0.0, so return a zero of > the correct sign.

Re: [PATCH v4 09/30] qcow2: Add subcluster-related fields to BDRVQcow2State

2020-04-10 Thread Vladimir Sementsov-Ogievskiy
17.03.2020 21:16, Alberto Garcia wrote: This patch adds the following new fields to BDRVQcow2State: - subclusters_per_cluster: Number of subclusters in a cluster - subcluster_size: The size of each subcluster, in bytes - subcluster_bits: No. of bits so 1 << subcluster_bits = subcluster_size Ima

Re: [PATCH v19 QEMU 4/4] memory: Do not allow direct write access to rom_device regions

2020-04-10 Thread Paolo Bonzini
On 10/04/20 05:41, Alexander Duyck wrote: > From: Alexander Duyck > > According to the documentation in memory.h a ROM memory region will be > backed by RAM for reads, but is supposed to go through a callback for > writes. Currently we were not checking for the existence of the rom_device > flag

Re: [PATCH v1 07/11] configure: disable PIE for Windows builds

2020-04-10 Thread Philippe Mathieu-Daudé
On 4/9/20 11:15 PM, Alex Bennée wrote: It seems on some compilers the test can pass but still give you broken binaries. [AJB untested - please could windows users test] Fixes: d2cd29e30736 Fixes: https://bugs.launchpad.net/qemu/+bug/1871798 Cc: Bug 1871798 <1871...@bugs.launchpad.net> Cc: James

Re: [PATCH v1 06/11] configure: redirect sphinx-build check to config.log

2020-04-10 Thread Philippe Mathieu-Daudé
On 4/9/20 11:15 PM, Alex Bennée wrote: Otherwise it's hard to debug whats going on. Signed-off-by: Alex Bennée --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 233c671aaa9..a207cce82bc 100755 --- a/configure +++ b/configure @@ -493

Re: [PATCH v1 05/11] tests/docker: add docs FEATURE flag and use for test-misc

2020-04-10 Thread Philippe Mathieu-Daudé
On 4/9/20 11:15 PM, Alex Bennée wrote: The test-misc docker test fails on a number of images which don't have the prerequisites to build the docs. Use the FEATURES flag so we can skip those tests. As the sphinx test fails to detect whatever feature we need to get hxtool to work we drop them from

Re: [PATCH v1 02/11] exec/cpu-all: Use bool for have_guest_base

2020-04-10 Thread Philippe Mathieu-Daudé
On 4/9/20 11:15 PM, Alex Bennée wrote: From: Richard Henderson Signed-off-by: Richard Henderson Signed-off-by: Alex Bennée --- include/exec/cpu-all.h | 2 +- bsd-user/main.c| 4 ++-- linux-user/main.c | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/i

Re: [PATCH v1 10/11] linux-user: fix /proc/self/stat handling

2020-04-10 Thread Philippe Mathieu-Daudé
Cc'ing Ludovic in case he can test with Guix-HPC. On 4/9/20 11:15 PM, Alex Bennée wrote: In the original bug report long files names in Guix caused /proc/self/stat be truncated without the trailing ") " as specified in proc manpage which says: (2) comm %s The filename of the e

Re: [PATCH v12 2/3] qcow2: Allow writing compressed data of multiple clusters

2020-04-10 Thread Alberto Garcia
On Thu 09 Apr 2020 08:39:12 PM CEST, Vladimir Sementsov-Ogievskiy wrote: >> Because of this a test cannot expect that running the same commands on >> an empty image produces always the same results. >> >> Is this something that we should be concerned about? > > Parallel writing compressed clusters

Re: [PATCH v12 2/3] qcow2: Allow writing compressed data of multiple clusters

2020-04-10 Thread Vladimir Sementsov-Ogievskiy
10.04.2020 14:12, Alberto Garcia wrote: On Thu 09 Apr 2020 08:39:12 PM CEST, Vladimir Sementsov-Ogievskiy wrote: Because of this a test cannot expect that running the same commands on an empty image produces always the same results. Is this something that we should be concerned about? Paralle

[PATCH v25 04/10] ACPI: Build related register address fields via hardware error fw_cfg blob

2020-04-10 Thread Dongjiu Geng
This patch builds error_block_address and read_ack_register fields in hardware errors table , the error_block_address points to Generic Error Status Block(GESB) via bios_linker. The max size for one GESB is 1kb, For more detailed information, please refer to document: docs/specs/acpi_hest_ghes.rst

[PATCH v25 01/10] acpi: nvdimm: change NVDIMM_UUID_LE to a common macro

2020-04-10 Thread Dongjiu Geng
The little end UUID is used in many places, so make NVDIMM_UUID_LE to a common macro to convert the UUID to a little end array. Reviewed-by: Xiang Zheng Signed-off-by: Dongjiu Geng --- hw/acpi/nvdimm.c| 10 +++--- include/qemu/uuid.h | 9 + 2 files changed, 12 insertions(+), 7

[PATCH v25 10/10] MAINTAINERS: Add ACPI/HEST/GHES entries

2020-04-10 Thread Dongjiu Geng
I and Xiang are willing to review the APEI-related patches and volunteer as the reviewers for the HEST/GHES part. Signed-off-by: Dongjiu Geng Signed-off-by: Xiang Zheng Reviewed-by: Philippe Mathieu-Daudé Acked-by: Michael S. Tsirkin --- MAINTAINERS | 9 + 1 file changed, 9 insertions

[PATCH v25 02/10] hw/arm/virt: Introduce a RAS machine option

2020-04-10 Thread Dongjiu Geng
RAS Virtualization feature is not supported now, so add a RAS machine option and disable it by default. Reviewed-by: Peter Maydell Signed-off-by: Dongjiu Geng Signed-off-by: Xiang Zheng Reviewed-by: Jonathan Cameron --- hw/arm/virt.c | 23 +++ include/hw/arm/virt.h

[PATCH v25 00/10] Add ARMv8 RAS virtualization support in QEMU

2020-04-10 Thread Dongjiu Geng
In the ARMv8 platform, the CPU error types includes synchronous external abort(SEA) and SError Interrupt (SEI). If exception happens in guest, host does not know the detailed information of guest, so it is expected that guest can do the recovery. For example, if an exception happens in a guest u

[PATCH v25 06/10] ACPI: Record the Generic Error Status Block address

2020-04-10 Thread Dongjiu Geng
Record the GHEB address via fw_cfg file, when recording a error to CPER, it will use this address to find out Generic Error Data Entries and write the error. In order to avoid migration failure, make hardware error table address to a part of GED device instead of global variable, then this address

[PATCH v25 05/10] ACPI: Build Hardware Error Source Table

2020-04-10 Thread Dongjiu Geng
This patch builds Hardware Error Source Table(HEST) via fw_cfg blobs. Now it only supports ARMv8 SEA, a type of Generic Hardware Error Source version 2(GHESv2) error source. Afterwards, we can extend the supported types if needed. For the CPER section, currently it is memory section because kernel

[PATCH v25 09/10] target-arm: kvm64: handle SIGBUS signal from kernel or KVM

2020-04-10 Thread Dongjiu Geng
Add a SIGBUS signal handler. In this handler, it checks the SIGBUS type, translates the host VA delivered by host to guest PA, then fills this PA to guest APEI GHES memory, then notifies guest according to the SIGBUS type. When guest accesses the poisoned memory, it will generate a Synchronous Ext

[PATCH v25 08/10] ACPI: Record Generic Error Status Block(GESB) table

2020-04-10 Thread Dongjiu Geng
kvm_arch_on_sigbus_vcpu() error injection uses source_id as index in etc/hardware_errors to find out Error Status Data Block entry corresponding to error source. So supported source_id values should be assigned here and not be changed afterwards to make sure that guest will write error into expecte

[PATCH v25 07/10] KVM: Move hwpoison page related functions into kvm-all.c

2020-04-10 Thread Dongjiu Geng
kvm_hwpoison_page_add() and kvm_unpoison_all() will both be used by X86 and ARM platforms, so moving them into "accel/kvm/kvm-all.c" to avoid duplicate code. For architectures that don't use the poison-list functionality the reset handler will harmlessly do nothing, so let's register the kvm_unpoi

[PATCH v25 03/10] docs: APEI GHES generation and CPER record description

2020-04-10 Thread Dongjiu Geng
Add APEI/GHES detailed design document Signed-off-by: Dongjiu Geng Signed-off-by: Xiang Zheng Reviewed-by: Michael S. Tsirkin Reviewed-by: Igor Mammedov --- docs/specs/acpi_hest_ghes.rst | 110 ++ docs/specs/index.rst | 1 + 2 files changed,

Re: [PATCH v4 07/30] qcow2: Document the Extended L2 Entries feature

2020-04-10 Thread Alberto Garcia
On Thu 09 Apr 2020 05:12:16 PM CEST, Eric Blake wrote: > Hmm - raw external files are incompatible with backing files. Should > we also document that extended L2 entries are incompatible with raw > external files? Ok, I can also add additional checks to forbid creating such images. Berto

[PATCH for-5.0] qcow2: Add incompatibility note between backing files and raw external data files

2020-04-10 Thread Alberto Garcia
Backing files and raw external data files are mutually exclusive. The documentation of the raw external data bit (in autoclear_features) already indicates that, but we should also mention it on the other side. Suggested-by: Eric Blake Signed-off-by: Alberto Garcia --- docs/interop/qcow2.txt | 3

Re: [PATCH v1] nrf51: Fix last GPIO CNF address

2020-04-10 Thread Peter Maydell
On Fri, 10 Apr 2020 at 04:42, Andrew Jeffery wrote: > IIRC Phil wanted to enable sub-word accesses to the sample value > registers but I didn't want to spread logic dealing with different access > widths through the model. We already had a mechanism to describe the > model's supported access size

Re: [PATCH v1 10/11] linux-user: fix /proc/self/stat handling

2020-04-10 Thread Alex Bennée
That was by inspection on my system which seems to truncate a lot earlier. It would be nice to find where in the Linux kernel it is output but I failed to grep the relevant function last night. On Fri, 10 Apr 2020, 12:11 Philippe Mathieu-Daudé, wrote: > Cc'ing Ludovic in case he can test with Gu

Re: [Qemu-devel] Should memory hotplug work with vhost-user backends?

2020-04-10 Thread Raphael Norwitz
On Wed, Jul 03, 2019 at 11:04:31AM +0100, Stefan Hajnoczi wrote: > On Tue, Jul 02, 2019 at 10:08:54PM +, Raphael Norwitz wrote: > > For background I am trying to work around a ram slot limit imposed by the > > vhost-user protocol. We are having trouble reconciling the comment here: > > https:

Re: [PATCH] MAINTAINERS: Add myself as vhost-user-blk maintainer

2020-04-10 Thread Raphael Norwitz
Ping On Thu, Mar 26, 2020 at 04:47:35AM -0400, Raphael Norwitz wrote: > As suggested by Michael, let's add me as a maintainer of > vhost-user-blk and vhost-user-scsi. > > CC: Michael S. Tsirkin > CC Peter Maydell > Signed-off-by: Raphael Norwitz > --- > MAINTAINERS | 12 > 1 file

Re: [PATCH v1 10/11] linux-user: fix /proc/self/stat handling

2020-04-10 Thread Philippe Mathieu-Daudé
On 4/10/20 2:33 PM, Alex Bennée wrote: That was by inspection on my system which seems to truncate a lot earlier. It would be nice to find where in the Linux kernel it is output but I failed to grep the relevant function last night. OK. Patch is correct with this value, so: Reviewed-by: Philip

Re: [PATCH v4 20/30] qcow2: Add subcluster support to discard_in_l2_slice()

2020-04-10 Thread Alberto Garcia
On Thu 09 Apr 2020 12:05:12 PM CEST, Max Reitz wrote: >> switch (qcow2_get_cluster_type(bs, old_l2_entry)) { >> case QCOW2_CLUSTER_UNALLOCATED: >> -if (full_discard || !bs->backing) { >> +if (full_discard) { >> +/* If the image has extended

Feature and message numbers missing in vhost-user.c

2020-04-10 Thread Raphael Norwitz
Hi MST, I see that a new feature, VHOST_USER_PROTOCOL_F_INBAND_NOTIFICATIONS (https://git.qemu.org/?p=qemu.git;a=blob;f=docs/interop/vhost-user.rst;h=3b1b6602c77932101e1e3b098e35c2497f5b0260;hb=HEAD#l817), and corresponding VHOST_USER_VRING_KICK (https://git.qemu.org/?p=qemu.git;a=blob;f=docs/inte

Re: [PATCH v2] Makefile: libfdt: build only the strict necessary

2020-04-10 Thread Philippe Mathieu-Daudé
On 4/9/20 6:33 PM, Philippe Mathieu-Daudé wrote: Hi Claudio, On 4/9/20 2:43 PM, Claudio Fontana wrote: when building dtc/libfdt, we were previously using dtc/Makefile, which tries to build some artifacts that are not needed, and can complain on stderr about the absence of tools that are not req

Re: [PATCH v1 09/11] gdbstub: i386: Fix gdb_get_reg16() parameter to unbreak gdb

2020-04-10 Thread Stefano Garzarella
On Thu, Apr 09, 2020 at 10:15:27PM +0100, Alex Bennée wrote: > From: Peter Xu > > We should only pass in gdb_get_reg16() with the GByteArray* object > itself, no need to shift. Without this patch, gdb remote attach will > crash QEMU. > > Fixes: a010bdbe719 ("extend GByteArray to read register h

Re: [PATCH v1 10/11] linux-user: fix /proc/self/stat handling

2020-04-10 Thread Brice Goglin
Le 10/04/2020 à 14:33, Alex Bennée a écrit : > That was by inspection on my system which seems to truncate a lot > earlier. It would be nice to find where in the Linux kernel it is > output but I failed to grep the relevant function last night. It's in proc/array.c, do_task_stat() calls proc_task

Re: [PATCH v1] nrf51: Fix last GPIO CNF address

2020-04-10 Thread Andrew Jeffery
On Fri, 10 Apr 2020, at 21:56, Peter Maydell wrote: > On Fri, 10 Apr 2020 at 04:42, Andrew Jeffery wrote: > > IIRC Phil wanted to enable sub-word accesses to the sample value > > registers but I didn't want to spread logic dealing with different access > > widths through the model. We already h

Re: [Qemu devel PATCH v3 1/3] hw/net: Add Smartfusion2 emac block

2020-04-10 Thread sundeep subbaraya
Hi Jason, On Thu, Apr 9, 2020 at 9:40 AM Jason Wang wrote: > > > On 2020/4/7 下午7:15, sundeep.l...@gmail.com wrote: > > From: Subbaraya Sundeep > > > > Modelled Ethernet MAC of Smartfusion2 SoC. > > Micrel KSZ8051 PHY is present on Emcraft's > > SOM kit hence same PHY is emulated. > > > > Signed-

Re: [RFC PATCH v2] target/ppc: Enable hardfloat for PPC

2020-04-10 Thread Yonggang Luo
Are this stable now? I'd like to see hard float to be landed:) On Wed, Feb 19, 2020 at 1:19 AM BALATON Zoltan wrote: > While other targets take advantage of using host FPU to do floating > point computations, this was disabled for PPC target because always > clearing exception flags before every

Re: [PATCH v2] Makefile: libfdt: build only the strict necessary

2020-04-10 Thread Claudio Fontana
Hello Philippe, Markus, On 4/10/20 3:00 PM, Philippe Mathieu-Daudé wrote: > On 4/9/20 6:33 PM, Philippe Mathieu-Daudé wrote: >> Hi Claudio, >> >> On 4/9/20 2:43 PM, Claudio Fontana wrote: >>> when building dtc/libfdt, we were previously using dtc/Makefile, >>> which tries to build some artifacts t

Re: [PATCH v1 06/11] configure: redirect sphinx-build check to config.log

2020-04-10 Thread Richard Henderson
On 4/9/20 2:15 PM, Alex Bennée wrote: > Otherwise it's hard to debug whats going on. > > Signed-off-by: Alex Bennée > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson r~

Re: [PATCH 3/3] MAINTAINERS: Add myself as fulong2e co-maintainer

2020-04-10 Thread Aleksandar Markovic
04:39 Čet, 09.04.2020. Jiaxun Yang је написао/ла: > > On Thu, 9 Apr 2020 10:17:46 +0800 > Huacai Chen wrote: > > > Hi, Aleksandar, > > > > On Wed, Apr 8, 2020 at 11:30 PM Aleksandar Markovic > > wrote: > > > > > > 11:08 Sre, 08.04.2020. Huacai Chen је > > > написао/ла: > > > > > > > > I submitt

Re: [PATCH v1 05/11] tests/docker: add docs FEATURE flag and use for test-misc

2020-04-10 Thread Richard Henderson
On 4/9/20 2:15 PM, Alex Bennée wrote: > The test-misc docker test fails on a number of images which don't have > the prerequisites to build the docs. Use the FEATURES flag so we can > skip those tests. > > As the sphinx test fails to detect whatever feature we need to get > hxtool to work we drop

Re: [PATCH v1 07/11] configure: disable PIE for Windows builds

2020-04-10 Thread Richard Henderson
On 4/9/20 2:15 PM, Alex Bennée wrote: > It seems on some compilers the test can pass but still give you > broken binaries. > > [AJB untested - please could windows users test] > > Fixes: d2cd29e30736 > Fixes: https://bugs.launchpad.net/qemu/+bug/1871798 > Cc: Bug 1871798 <1871...@bugs.launchpad.n

Re: [PATCH v1 09/11] gdbstub: i386: Fix gdb_get_reg16() parameter to unbreak gdb

2020-04-10 Thread Richard Henderson
On 4/9/20 2:15 PM, Alex Bennée wrote: > From: Peter Xu > > We should only pass in gdb_get_reg16() with the GByteArray* object > itself, no need to shift. Without this patch, gdb remote attach will > crash QEMU. > > Fixes: a010bdbe719 ("extend GByteArray to read register helpers") > Signed-off-b

Re: [PATCH v1 08/11] target/m68k/helper: Fix m68k_fpu_gdb_get_reg() use of GByteArray

2020-04-10 Thread Richard Henderson
On 4/9/20 2:15 PM, Alex Bennée wrote: > From: Philippe Mathieu-Daudé > > Since a010bdbe719 the gdbstub API takes a GByteArray*. Unfortunately > we forgot to update the gdb_get_reg*() calls. Do it now. > > Fixes: a010bdbe719 ("extend GByteArray to read register helpers") > Reported-by: Peter Xu

[Qemu devel PATCH v4 1/3] hw/net: Add Smartfusion2 emac block

2020-04-10 Thread sundeep . lkml
From: Subbaraya Sundeep Modelled Ethernet MAC of Smartfusion2 SoC. Micrel KSZ8051 PHY is present on Emcraft's SOM kit hence same PHY is emulated. Signed-off-by: Subbaraya Sundeep --- MAINTAINERS| 2 + hw/net/Makefile.objs | 1 + hw/net/msf2-emac.c | 562 ++

[Qemu devel PATCH v4 2/3] msf2: Add EMAC block to SmartFusion2 SoC

2020-04-10 Thread sundeep . lkml
From: Subbaraya Sundeep With SmartFusion2 Ethernet MAC model in place this patch adds the same to SoC. Signed-off-by: Subbaraya Sundeep --- hw/arm/msf2-soc.c | 21 - include/hw/arm/msf2-soc.h | 3 +++ 2 files changed, 23 insertions(+), 1 deletion(-) diff --git a/h

[Qemu devel PATCH v4 3/3] tests/boot_linux_console: Add ethernet test to SmartFusion2

2020-04-10 Thread sundeep . lkml
From: Subbaraya Sundeep In addition to simple serial test this patch uses ping to test the ethernet block modelled in SmartFusion2 SoC. Signed-off-by: Subbaraya Sundeep --- tests/acceptance/boot_linux_console.py | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git

[Qemu devel PATCH v4 0/3] Add SmartFusion2 EMAC block

2020-04-10 Thread sundeep . lkml
From: Subbaraya Sundeep This patch set emulates Ethernet MAC block present in Microsemi SmartFusion2 SoC. v4: Added loop back as per Jason's comment v3: Added SmartFusion2 ethernet test to tests/acceptance v2: No changes. Fixed Signed-off mail id in patch 2/2 Testing: 1. Download u-boot

Re: [PATCH v1 10/11] linux-user: fix /proc/self/stat handling

2020-04-10 Thread Richard Henderson
On 4/9/20 2:15 PM, Alex Bennée wrote: > In the original bug report long files names in Guix caused > /proc/self/stat be truncated without the trailing ") " as specified in > proc manpage which says: > (2) comm %s >The filename of the executable, in parentheses. This >

Re: [PULL 08/13] softfloat: Fix BAD_SHIFT from normalizeFloatx80Subnormal

2020-04-10 Thread Richard Henderson
On 4/10/20 2:38 AM, Aleksandar Markovic wrote: > 17:55 Uto, 07.04.2020. Alex Bennée > је написао/ла: >> >> From: Richard Henderson > >> >> All other calls to normalize*Subnormal detect zero input before >> the call -- this is the

Re: [PULL 08/13] softfloat: Fix BAD_SHIFT from normalizeFloatx80Subnormal

2020-04-10 Thread Aleksandar Markovic
17:17 Pet, 10.04.2020. Richard Henderson је написао/ла: > > On 4/10/20 2:38 AM, Aleksandar Markovic wrote: > > 17:55 Uto, 07.04.2020. Alex Bennée > > је написао/ла: > >> > >> From: Richard Henderson > > > >> > >> All other calls

Re: [PULL 08/13] softfloat: Fix BAD_SHIFT from normalizeFloatx80Subnormal

2020-04-10 Thread Peter Maydell
On Fri, 10 Apr 2020 at 16:17, Richard Henderson wrote: > Although why Alex didn't add his own R-b to my patch when merging it to his > branch, I don't know. I think this is one of those areas where different submaintainers have different work practices. Personally I distinguish "did I actually re

Re: [PATCH v4 27/30] qcow2: Assert that expand_zero_clusters_in_l1() does not support subclusters

2020-04-10 Thread Alberto Garcia
On Thu 09 Apr 2020 12:27:36 PM CEST, Max Reitz wrote: >> +=== Testing version downgrade with extended L2 entries === >> + >> +Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=67108864 >> +qemu-img: Cannot downgrade an image with incompatible features 0x10 set > > This test fails in this commit, beca

[PATCH] hw/arm/virt: Add DT property /secure-chosen/kaslr-seed

2020-04-10 Thread Jerome Forissier
This commit generates a random seed to be used by the secure OS for ASLR when the machine is secure. The seed is a 64-bit random value exported via the DT in /secure-chosen/kaslr-seed. This interface is used by OP-TEE [1]. [1] https://github.com/OP-TEE/optee_os/commit/ef262691fe0e Signed-off-by:

[PATCH] hw/arm/virt: Add DT property /secure-chosen/kaslr-seed

2020-04-10 Thread Jerome Forissier
This commit generates a random seed to be used by the secure OS for ASLR when the machine is secure. The seed is a 64-bit random value exported via the DT in /secure-chosen/kaslr-seed. This interface is used by OP-TEE [1]. [1] https://github.com/OP-TEE/optee_os/commit/ef262691fe0e Signed-off-by:

[Bug 1872113] [NEW] qemu docs fails to build with Sphinx 3.0.x

2020-04-10 Thread Stig-Ørjan Smelror
Public bug reported: We've just updated Sphinx to version 3.0.1 and qemu fails to build the docs with this version. Here's the relevant section in the build log. CONFDIR="/etc/qemu" /usr/bin/sphinx-build-3 -W -b html -D version=4.2.92 -D release="4.2.92 (qemu-5.0.0-0.rc2.0.1.mga8)" -d .doctree

Re: [RFC PATCH v2] target/ppc: Enable hardfloat for PPC

2020-04-10 Thread BALATON Zoltan
On Fri, 10 Apr 2020, 罗勇刚(Yonggang Luo) wrote: Are this stable now? I'd like to see hard float to be landed:) If you want to see hardfloat for PPC then you should read the replies to this patch which can be found here: http://patchwork.ozlabs.org/patch/1240235/ to understand what's needed th

[Bug 1872113] Re: qemu docs fails to build with Sphinx 3.0.x

2020-04-10 Thread Peter Maydell
Hmm, that's not ideal. The C is valid C which the compiler accepts, so I'm not sure what Sphinx is complaining about, and I don't have a system with that new a version of Sphinx. It does suggest that we ought to make our configure --enable-werror /--disable-werror (and the code that makes the defa

Re: [PULL 08/13] softfloat: Fix BAD_SHIFT from normalizeFloatx80Subnormal

2020-04-10 Thread Aleksandar Markovic
18:14 Pet, 10.04.2020. Peter Maydell је написао/ла: > But I think some submaintainers don't bother to add r-by tags > for things they review in the process of assembling their > tree because they see it as implicit in the process. > I think that was precisely the case in this patch. May I wish

[Bug 1872113] Re: qemu docs fails to build with Sphinx 3.0.x

2020-04-10 Thread Stig-Ørjan Smelror
One of our packaging gurus make a small change that removed the error fails option. # Don't treat warnings as errors when building docs with sphinx sed -i -e '/SPHINX_BUILD/s/-W//' Makefile The build completes now, however there are still errors. CONFDIR="/etc/qemu" /usr/bin/sphinx-build-3 -b

[PATCH] linux-user/sparc64: Translate flushw opcode

2020-04-10 Thread LemonBoy
>From 11d0cfe58d12e0f191b435ade88622cfceb2098a Mon Sep 17 00:00:00 2001 From: LemonBoy Date: Fri, 10 Apr 2020 22:55:26 +0200 Subject: [PATCH] linux-user/sparc64: Translate flushw opcode The ifdef logic should unconditionally compile in the `xop == 0x2b` case when targeting sparc64. Fix the handl

[PATCH] module: increase dirs array size by one

2020-04-10 Thread Bruce Rogers
With the module upgrades code change, the statically sized dirs array can now overflow. Increase it's size by one, according to the new maximum possible usage. Fixes: bd83c861c0 ("modules: load modules from versioned /var/run dir") Signed-off-by: Bruce Rogers --- util/module.c | 2 +- 1 file cha

[PATCH 1/2] net/colo-compare.c: Expose compare "max_queue_size" to users

2020-04-10 Thread Zhang Chen
From: Zhang Chen This patch allow users to set the "max_queue_size" according to their environment. Signed-off-by: Zhang Chen --- net/colo-compare.c | 43 ++- qemu-options.hx| 5 +++-- 2 files changed, 45 insertions(+), 3 deletions(-) diff --git a/

[PATCH 0/2] net/colo-compare.c: Expose "max_queue_size" to users and clean up

2020-04-10 Thread Zhang Chen
From: Zhang Chen This series make a way to config COLO "max_queue_size" parameters according to user's scenarios and environments and do some clean up for descriptions. Zhang Chen (2): net/colo-compare.c: Expose compare "max_queue_size" to users qemu-options.hx: Clean up and fix typo for col

[PATCH 2/2] qemu-options.hx: Clean up and fix typo for colo-compare

2020-04-10 Thread Zhang Chen
From: Zhang Chen Fix some typo and optimized some descriptions. Signed-off-by: Zhang Chen --- qemu-options.hx | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index 107ff3e71b..84368f15be 100644 --- a/qemu-

RE: [PATCH v5 1/1] colo-compare: Fix memory leak in packet_enqueue()

2020-04-10 Thread Zhang, Chen
> -Original Message- > From: Derek Su > Sent: Friday, April 10, 2020 10:01 AM > To: qemu-devel@nongnu.org > Cc: Zhang, Chen ; lizhij...@cn.fujitsu.com; > jasow...@redhat.com; ctch...@qnap.com; chy...@qnap.com; > jwsu1...@gmail.com; Derek Su > Subject: [PATCH v5 1/1] colo-compare: Fix m

RE: [PATCH RFC 2/9] target/riscv: Add target/riscv/kvm.c to place the public kvm interface

2020-04-10 Thread Jiangyifei
> -Original Message- > From: Anup Patel [mailto:a...@brainfault.org] > Sent: Tuesday, March 31, 2020 7:19 PM > To: Jiangyifei > Cc: QEMU Developers ; open list:RISC-V > ; Anup Patel ; > Zhanghailiang ; Sagar Karandikar > ; Bastian Koppelmann > ; Zhangxiaofeng (F) > ; Alistair Francis > ;

[PATCH RFC v2 4/9] target/riscv: Implement kvm_arch_get_registers

2020-04-10 Thread Yifei Jiang
Get GPR CSR and FP registers from kvm by KVM_GET_ONE_REG ioctl. Signed-off-by: Yifei Jiang Signed-off-by: Yipeng Yin --- target/riscv/kvm.c | 144 - 1 file changed, 143 insertions(+), 1 deletion(-) diff --git a/target/riscv/kvm.c b/target/riscv/kvm.c

[PATCH RFC v2 0/9] Add riscv kvm accel support

2020-04-10 Thread Yifei Jiang
This series adds both riscv32 and riscv64 kvm support, It is based on riscv_kvm_master branch at https://github.com/kvm-riscv/linux. This series depends on above pending changes which haven't yet been accepted, so this QEMU patch series is blocked until that dependency has been dealt with, but is

[PATCH RFC v2 3/9] target/riscv: Implement function kvm_arch_init_vcpu

2020-04-10 Thread Yifei Jiang
Get isa info from kvm while kvm init. Signed-off-by: Yifei Jiang Signed-off-by: Yipeng Yin --- target/riscv/kvm.c | 26 +- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/target/riscv/kvm.c b/target/riscv/kvm.c index 8c386d9acf..3e8f8e7185 100644 --- a/targ

[PATCH RFC v2 2/9] target/riscv: Add target/riscv/kvm.c to place the public kvm interface

2020-04-10 Thread Yifei Jiang
Add target/riscv/kvm.c to place kvm_arch_* function needed by kvm/kvm-all.c. Meanwhile, add kvm support in configure file. Signed-off-by: Yifei Jiang Signed-off-by: Yipeng Yin --- configure | 1 + target/riscv/Makefile.objs | 1 + target/riscv/kvm.c | 128 ++

[PATCH RFC v2 5/9] target/riscv: Implement kvm_arch_put_registers

2020-04-10 Thread Yifei Jiang
Put GPR CSR and FP registers to kvm by KVM_SET_ONE_REG ioctl Signed-off-by: Yifei Jiang Signed-off-by: Yipeng Yin --- target/riscv/kvm.c | 136 - 1 file changed, 135 insertions(+), 1 deletion(-) diff --git a/target/riscv/kvm.c b/target/riscv/kvm.c in

[PATCH RFC v2 9/9] target/riscv: add host cpu type

2020-04-10 Thread Yifei Jiang
Currently, host cpu is inherited simply. Signed-off-by: Yifei Jiang Signed-off-by: Yipeng Yin --- target/riscv/cpu.c | 6 ++ target/riscv/cpu.h | 1 + 2 files changed, 7 insertions(+) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index 6a6af13ab9..e5b42c3a54 100644 --- a/target/risc

[PATCH RFC v2 7/9] hw/riscv: PLIC update external interrupt by KVM when kvm enabled

2020-04-10 Thread Yifei Jiang
Only support supervisor external interrupt currently. Signed-off-by: Yifei Jiang Signed-off-by: Yipeng Yin --- hw/riscv/sifive_plic.c | 31 ++- target/riscv/kvm.c | 19 +++ target/riscv/kvm_riscv.h | 1 + 3 files changed, 42 insertions(+), 9

[PATCH RFC v2 6/9] target/riscv: Support start kernel directly by KVM

2020-04-10 Thread Yifei Jiang
Get kernel and fdt start address in virt.c, and pass them to KVM when cpu reset. In addition, add kvm_riscv.h to place riscv specific interface. Signed-off-by: Yifei Jiang Signed-off-by: Yipeng Yin --- hw/riscv/virt.c | 16 +--- target/riscv/cpu.c | 4 target/ri

[PATCH RFC v2 8/9] target/riscv: Handler KVM_EXIT_RISCV_SBI exit

2020-04-10 Thread Yifei Jiang
Use char-fe handler console sbi call, which implement early console io while apply 'earlycon=sbi' into kernel parameters. The common SBI interface sbi_ecall_interface.h is introduced from https://github.com/riscv/opensbi/blob/master/include/sbi/sbi_ecall_interface.h. Signed-off-by: Yifei Jiang S

[PATCH RFC v2 1/9] linux-header: Update linux/kvm.h

2020-04-10 Thread Yifei Jiang
Update linux/kvm.h to commit b9a6e4cd9 on https://github.com/kvm-riscv/linux. Only use this header file, so do not update all linux headers. Signed-off-by: Yifei Jiang Signed-off-by: Yipeng Yin --- linux-headers/linux/kvm.h | 8 1 file changed, 8 insertions(+) diff --git a/linux-heade

Re: [PATCH RFC v2 0/9] Add riscv kvm accel support

2020-04-10 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200411041427.14828-1-jiangyi...@huawei.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH RFC v2 0/9] Add riscv kvm accel support Message-id: 20200411041427.14828-1-jiangyi...@huawei.com

Re: [PATCH] module: increase dirs array size by one

2020-04-10 Thread Paolo Bonzini
On 11/04/20 03:07, Bruce Rogers wrote: > With the module upgrades code change, the statically sized dirs array > can now overflow. Increase it's size by one, according to the new > maximum possible usage. > > Fixes: bd83c861c0 ("modules: load modules from versioned /var/run dir") > Signed-off-by:

[PATCH] virtiofsd/passthrough_ll: don't remove O_DIRECT when cache=none

2020-04-10 Thread Catherine Ho
cache=none means to bypass host cache. So we can't remove O_DIRECT flag in unconditionally in update_open_flags(); Signed-off-by: Catherine Ho --- tools/virtiofsd/passthrough_ll.c | 16 ++-- 1 files changed, 10 insertions(+), 6 deletions(-) diff --git a/tools/virtiofsd/passthrough