Re: [PATCH v3] piix: fix xenfv regression, add compat machine xenfv-qemu4

2020-03-25 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200325064736.22416-1-o...@aepfle.de/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/b

Re: [PATCH v5 2/3] display/blizzard: use extract16() for fix clang analyzer warning in blizzard_draw_line16_32()

2020-03-25 Thread Laurent Vivier
Le 25/03/2020 à 03:59, Chen Qun a écrit : > Clang static code analyzer show warning: > hw/display/blizzard.c:940:9: warning: Value stored to 'data' is never read > data >>= 5; > ^~ > Reported-by: Euler Robot > Signed-off-by: Chen Qun > --- > Cc: Andrzej Zaborowski > Cc:

Re: [PATCH v3] piix: fix xenfv regression, add compat machine xenfv-qemu4

2020-03-25 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200325064736.22416-1-o...@aepfle.de/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash export AR

Re: [PULL v2 0/5] Linux user for 5.0 patches

2020-03-25 Thread Laurent Vivier
Le 24/03/2020 à 23:10, Laurent Vivier a écrit : > Le 24/03/2020 à 14:14, Peter Maydell a écrit : >> On Tue, 24 Mar 2020 at 12:32, Laurent Vivier wrote: >>> OK, I think there is an existing problem in the build dependencies. >>> >>> Do you use enable all targets ("configure" without parameters)? >>

[PATCH] linux-user, configure: fix (again) syscall_nr.h dependencies cleanup

2020-03-25 Thread Laurent Vivier
This patch fixes two problems: - it cleanups linux-user variants (for instance ppc64-linux-user and ppc64le-linux-user) - it removes the .o file when it removes the .d file, otherwise the .o file is never updated Fixes: 5f29856b852d ("linux-user, configure: improve syscall_nr.h dependencies c

Re: [kvm-unit-tests PATCH v7 08/13] arm/arm64: ITS: Device and collection Initialization

2020-03-25 Thread Zenghui Yu
Hi Eric, On 2020/3/20 17:24, Eric Auger wrote: Introduce an helper functions to register - a new device, characterized by its device id and the max number of event IDs that dimension its ITT (Interrupt Translation Table). The function allocates the ITT. - a new collection, characterized

Re: backup transaction with io-thread core dumps

2020-03-25 Thread Sergio Lopez
On Tue, Mar 24, 2020 at 02:47:43PM +0100, Max Reitz wrote: > Hi Dietmar, > > I assume this is with master and has popped up only recently? > > Maybe it has something to do with the recent mutex patches by Stefan, so > I’m Cc-ing him. > Hi, I was able to reproduce the issue with a build after the

[Bug 1868116] Re: QEMU monitor no longer works

2020-03-25 Thread Christian Ehrhardt 
Thank you Egmont for the bug for VTE in the gnome tracker! Graphics isn't something I'm usually at home - the related qemu code is mostly in ui/gtk.c per Maintainers file Gerd Hoffmann is the expert. I subscribed him to the bug here to raise visibility for him. -- You received this bug notificat

Re: [PATCH] nvme: Print 'cqid' for nvme_del_cq

2020-03-25 Thread Stefano Garzarella
On Tue, Mar 24, 2020 at 11:06:46PM +0900, Minwoo Im wrote: > The given argument for this trace should be cqid, not sqid. > > Signed-off-by: Minwoo Im > --- > hw/block/trace-events | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Stefano Garzarella > > diff --git a/hw/bloc

[Bug 1868116] Re: QEMU monitor no longer works

2020-03-25 Thread Christian Ehrhardt 
For a bit of reverse-confirmation of the findings so far. If I build qemu without VTE, like (configure) GTK support yes (3.24.14) VTE support no It works, due to the fallback implemented by [1][2]. But obviously without all the VTE features, I'd prefer a more fine grained fix than dis

[PATCH] qemu: Do not include file if not exists

2020-03-25 Thread Oleksiy Obitotskyy
Script configure checks for if_alg.h and check failed but if_alg.h still included. Signed-off-by: Oleksiy Obitotskyy --- linux-user/syscall.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 35f4146662..819774af0d 100644 --- a/linux-user/sys

Re: [PATCH 04/13] microvm: add minimal acpi support.

2020-03-25 Thread Gerd Hoffmann
Hi, > > +{ > > +AcpiRsdpData rsdp_data = { > > +.revision = 0, > > +.oem_id = ACPI_BUILD_APPNAME6, > > +.xsdt_tbl_offset = NULL, > > +.rsdt_tbl_offset = &rsdt, > are we interested in 32-bit guests? Well, sort-of. seabios runs in 32bit

Re: [PATCH v6 2/8] i2c: i801: Use GPIO_LOOKUP() helper macro

2020-03-25 Thread Jean Delvare
On Tue, 24 Mar 2020 14:56:47 +0100, Geert Uytterhoeven wrote: > i801_add_mux() fills in the GPIO lookup table by manually populating an > array of gpiod_lookup structures. Use the existing GPIO_LOOKUP() helper > macro instead, to relax a dependency on the gpiod_lookup structure's > member names. >

Re: [PATCH 00/13] microvm: add acpi support

2020-03-25 Thread Gerd Hoffmann
> > mounted. Decided to use the "i8042: PNP: No PS/2 controller found." > > line instead for a simple test (just check the kernel log timestamps, > > three runs each). The ACPI initialization is already done at that > > point, so it should be useful nevertheless. Here we go: > > > > Without acp

RE: [PATCH v1 21/22] intel_iommu: process PASID-based Device-TLB invalidation

2020-03-25 Thread Liu, Yi L
> From: Peter Xu > Sent: Wednesday, March 25, 2020 2:36 AM > To: Liu, Yi L > Subject: Re: [PATCH v1 21/22] intel_iommu: process PASID-based Device-TLB > invalidation > > On Sun, Mar 22, 2020 at 05:36:18AM -0700, Liu Yi L wrote: > > This patch adds an empty handling for PASID-based Device-TLB > >

[Bug 1866892] Re: guest OS catches a page fault bug when running dotnet

2020-03-25 Thread Peter Maydell
That function is for "do a guest memory load as if from the kernel" (ie with the permissions and page table settings that guest kernel-mode accesses would use). We'd need to look at what the required semantics for the instruction are for user-mode iretq: are the loads supposed to be done with only

[PATCH 3/3] crypto: Redundant type conversion for AES_KEY pointer

2020-03-25 Thread Chen Qun
Fix: eaec903c5b8 Reported-by: Euler Robot Signed-off-by: Chen Qun --- Cc: "Daniel P. Berrangé" --- crypto/cipher-builtin.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/crypto/cipher-builtin.c b/crypto/cipher-builtin.c index bf8413e71a..99d6280a16 100644 --- a/crypt

[PATCH 0/3] Three trivial patchs

2020-03-25 Thread Chen Qun
Patch1: For g_autofree type initialized. Patch2: Juest 80-char limit for virtio-crypto. Patch3: Redundant type conversion for crypto. Chen Qun (3): gdbstub: prevent uninitialized warning virtio-crypto: fix 80-char limit violations in virtio_crypto_device_realize() crypto: Redundant type

[PATCH 1/3] gdbstub: prevent uninitialized warning

2020-03-25 Thread Chen Qun
According to the glib function requirements, we need initialise the variable. Otherwise there will be compilation warnings: qemu/gdbstub.c: In function ‘handle_query_thread_extra’: /usr/include/glib-2.0/glib/glib-autocleanups.h:28:3: warning: ‘cpu_name’ may be used uninitialized in this func

[PATCH 2/3] virtio-crypto: fix 80-char limit violations in virtio_crypto_device_realize()

2020-03-25 Thread Chen Qun
Fix: aa8f057e74ae Reported-by: Euler Robot Signed-off-by: Chen Qun --- hw/virtio/virtio-crypto.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/virtio/virtio-crypto.c b/hw/virtio/virtio-crypto.c index 4c65114de5..eb4a9e4e85 100644 --- a/hw/virtio/virtio-crypto.c +++ b/

[Bug 1868116] Re: QEMU monitor no longer works

2020-03-25 Thread Christian Ehrhardt 
I'm not really a UI guy, so I was checking what I might have lost by disabling VTE and found the very old [1]. That list of features really seems to make disabling VTE not an real option: "It's also screen reader accessible, supports copy/paste, proper scrolling and most of the other feature

RE: [PATCH v1 08/22] vfio: init HostIOMMUContext per-container

2020-03-25 Thread Liu, Yi L
> From: Peter Xu > Sent: Tuesday, March 24, 2020 10:46 PM > To: Liu, Yi L > Subject: Re: [PATCH v1 08/22] vfio: init HostIOMMUContext per-container > > On Tue, Mar 24, 2020 at 01:03:28PM +, Liu, Yi L wrote: > > > From: Peter Xu > > > Sent: Tuesday, March 24, 2020 5:40 AM > > > To: Liu, Yi L

RE: [PATCH v1 07/22] intel_iommu: add set/unset_iommu_context callback

2020-03-25 Thread Liu, Yi L
> From: Peter Xu > Sent: Tuesday, March 24, 2020 11:24 PM > To: Liu, Yi L > Subject: Re: [PATCH v1 07/22] intel_iommu: add set/unset_iommu_context > callback > > On Tue, Mar 24, 2020 at 11:15:24AM +, Liu, Yi L wrote: > > [...] > > > > > struct VTDIOTLBEntry { > > > > @@ -271,6 +282,8 @@

[PATCH v3 0/2] COLO: handling of the full primary or secondary queue

2020-03-25 Thread Derek Su
The series is to handle the full primary or secondary queue in colo-compare. (1) fix the "pkt" memory leak in packet_enqueue(). Reproduce steps: 1. Setup PVM and SVM both with NIC e1000 by the steps descripted in the wiki qemu/COLO 2. Run "iperf3 -s" in PVM 3. Run "iperf3 -c

[PATCH for-5.0 0/2] fix qemu crash with memory-backend-* prealloc=yes

2020-03-25 Thread Igor Mammedov
Igor Mammedov (2): hostmem: set default prealloc_threads to valid value tests: numa: test one backend with prealloc enabled backends/hostmem.c | 1 + tests/qtest/numa-test.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) -- 2.18.1

Re: [PATCH 3/3] crypto: Redundant type conversion for AES_KEY pointer

2020-03-25 Thread Laurent Vivier
Le 25/03/2020 à 10:21, Chen Qun a écrit : > Fix: eaec903c5b8 > Did you run the coccinelle script scripts/coccinelle/typecast.cocci ? Thanks, Laurent > Reported-by: Euler Robot > Signed-off-by: Chen Qun > --- > Cc: "Daniel P. Berrangé" > --- > crypto/cipher-builtin.c | 6 ++ > 1 file chan

[PATCH for-5.0 1/2] hostmem: set default prealloc_threads to valid value

2020-03-25 Thread Igor Mammedov
Commit 4ebc74dbbf removed default prealloc_threads initialization by mistake, and that makes QEMU crash with division on zero at numpages_per_thread = numpages / memset_num_threads; when QEMU is started with following backend -object memory-backend-ram,id=ram-node0,prealloc=yes,size=128M Retur

[PATCH v3 1/2] net/colo-compare.c: Fix memory leak in packet_enqueue()

2020-03-25 Thread Derek Su
The patch is to fix the "pkt" memory leak in packet_enqueue(). The allocated "pkt" needs to be freed if the colo compare primary or secondary queue is too big. Signed-off-by: Derek Su --- net/colo-compare.c | 23 +++ 1 file changed, 15 insertions(+), 8 deletions(-) diff --gi

Re: [PATCH 3/3] crypto: Redundant type conversion for AES_KEY pointer

2020-03-25 Thread Daniel P . Berrangé
On Wed, Mar 25, 2020 at 05:21:37PM +0800, Chen Qun wrote: > Fix: eaec903c5b8 > > Reported-by: Euler Robot > Signed-off-by: Chen Qun > --- > Cc: "Daniel P. Berrangé" > --- > crypto/cipher-builtin.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) Acked-by: Daniel P. Berrangé >

[PATCH for-5.0 2/2] tests: numa: test one backend with prealloc enabled

2020-03-25 Thread Igor Mammedov
canbalize one backend in hmat test to make sure that prealloc=y is tested Signed-off-by: Igor Mammedov --- tests/qtest/numa-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qtest/numa-test.c b/tests/qtest/numa-test.c index 2f9b7f663a..e1ed6d4322 100644 --- a/tests

[PATCH v3 2/2] net/colo-compare.c: handling of the full primary or secondary queue

2020-03-25 Thread Derek Su
The pervious handling of the full primary or queue is only dropping the packet. If there are lots of clients to the guest VM, the "drop" will lead to the lost of the networking connection until next checkpoint. To address the issue, this patch drops the packet firstly. Then, send all queued primar

Re: Qemu master crashing on boot when using file backend for memory

2020-03-25 Thread Igor Mammedov
On Tue, 24 Mar 2020 22:50:46 -0400 Raphael Norwitz wrote: > On Thu, Mar 12, 2020 at 11:54:50AM +0100, Igor Mammedov wrote: > > > > On Thu, 12 Mar 2020 01:36:48 -0400 > > Raphael Norwitz wrote: > > > > > When I try run master qemu I am hitting a divide by zero error. It seems > > > to be comi

RE: [PATCH v1 13/22] vfio: add bind stage-1 page table support

2020-03-25 Thread Liu, Yi L
> From: Peter Xu > Sent: Wednesday, March 25, 2020 1:41 AM > To: Liu, Yi L > Subject: Re: [PATCH v1 13/22] vfio: add bind stage-1 page table support > > On Sun, Mar 22, 2020 at 05:36:10AM -0700, Liu Yi L wrote: > > This patch adds bind_stage1_pgtbl() definition in > > HostIOMMUContextClass, also

Re: [RFC] hw/usb/xen-usb.c: Pass struct usbback_req* to usbback_packet_complete()

2020-03-25 Thread Gerd Hoffmann
On Mon, Mar 23, 2020 at 04:43:18PM +, Peter Maydell wrote: > The function usbback_packet_complete() currently takes a USBPacket*, > which must be a pointer to the packet field within a struct > usbback_req; the function uses container_of() to get the struct > usbback_req* given the USBPacket*.

Re: [PATCH 00/13] microvm: add acpi support

2020-03-25 Thread Igor Mammedov
On Wed, 25 Mar 2020 10:16:36 +0100 Gerd Hoffmann wrote: > > > mounted. Decided to use the "i8042: PNP: No PS/2 controller found." > > > line instead for a simple test (just check the kernel log timestamps, > > > three runs each). The ACPI initialization is already done at that > > > point, so i

Re: [PATCH for-5.0 1/2] hostmem: set default prealloc_threads to valid value

2020-03-25 Thread Laurent Vivier
On 25/03/2020 10:44, Igor Mammedov wrote: > Commit 4ebc74dbbf removed default prealloc_threads initialization > by mistake, and that makes QEMU crash with division on zero at > numpages_per_thread = numpages / memset_num_threads; > when QEMU is started with following backend > -object memory-ba

[PATCH 2/3] target/mips: Add loongson ext lsdc2 instrustions

2020-03-25 Thread Jiaxun Yang
LDC2/SDC2 opcodes have been rewritten as "load & store with offset" instructions by loongson-ext ASE. Signed-off-by: Jiaxun Yang --- target/mips/translate.c | 157 1 file changed, 157 insertions(+) diff --git a/target/mips/translate.c b/target/mips/trans

[PATCH 3/3] target/mips: Add loongson gs464 core

2020-03-25 Thread Jiaxun Yang
GS464 is the core we can found in Loongson-3A1000 processor with MIPS64R2 as baseline ISA and Loongson self defined MMI & EXT ASE. Signed-off-by: Jiaxun Yang --- target/mips/translate_init.inc.c | 25 - 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/target/

[PATCH 1/3] target/mips: Introduce loongson ext & mmi ASE flags

2020-03-25 Thread Jiaxun Yang
Start from Loongson-3A, loongson treat their extension instructions as ASE and implemented mips64r2 as their baseline ISA. Here we simply identify instructions shared between 2F and 3A and mark them with MMI or EXT flag. Signed-off-by: Jiaxun Yang --- target/mips/mips-defs.h | 2 ++ target/mips/

RE: [PATCH 3/3] crypto: Redundant type conversion for AES_KEY pointer

2020-03-25 Thread Chenqun (kuhn)
>-Original Message- >From: Laurent Vivier [mailto:laur...@vivier.eu] >Sent: Wednesday, March 25, 2020 5:45 PM >To: Chenqun (kuhn) ; qemu-devel@nongnu.org; >qemu-triv...@nongnu.org >Cc: Zhanghailiang ; Euler Robot >; Daniel P. Berrangé >Subject: Re: [PATCH 3/3] crypto: Redundant type conver

[PATCH 0/3] target/mips: Add loongson gs464 core

2020-03-25 Thread Jiaxun Yang
Loongson gs464 core can be found in Loongson-3A1000 processor. This patchset add minimal support for that core. There are still some instructions missing, I'm going to work on them later. The corresponding hw board is also missing. I'm using modified kernel for malta for testing purpose and planin

Re: [PATCH 3/3] crypto: Redundant type conversion for AES_KEY pointer

2020-03-25 Thread Laurent Vivier
Le 25/03/2020 à 11:06, Chenqun (kuhn) a écrit : >> -Original Message- >> From: Laurent Vivier [mailto:laur...@vivier.eu] >> Sent: Wednesday, March 25, 2020 5:45 PM >> To: Chenqun (kuhn) ; qemu-devel@nongnu.org; >> qemu-triv...@nongnu.org >> Cc: Zhanghailiang ; Euler Robot >> ; Daniel P. Ber

Re: [PATCH v5 08/26] nvme: refactor device realization

2020-03-25 Thread Maxim Levitsky
On Mon, 2020-03-16 at 00:43 -0700, Klaus Birkelund Jensen wrote: > On Feb 12 11:27, Maxim Levitsky wrote: > > On Tue, 2020-02-04 at 10:51 +0100, Klaus Jensen wrote: > > > This patch splits up nvme_realize into multiple individual functions, > > > each initializing a different subset of the device.

Re: [PATCH v5 09/26] nvme: add temperature threshold feature

2020-03-25 Thread Maxim Levitsky
On Mon, 2020-03-16 at 00:44 -0700, Klaus Birkelund Jensen wrote: > On Feb 12 11:31, Maxim Levitsky wrote: > > On Tue, 2020-02-04 at 10:51 +0100, Klaus Jensen wrote: > > > It might seem wierd to implement this feature for an emulated device, > > > but it is mandatory to support and the feature is us

[PATCH v2 0/2] Rework iotests finding

2020-03-25 Thread Vladimir Sementsov-Ogievskiy
Hi all! When sending iotests to upstream or do patch porting from one branch to another we very often have to resolve conflicts in group file, as many absolutely independent features are intersecting by this file. These conflicts are simple, but imagine how much time we all have already spent on r

[PATCH v2 1/2] iotests: define group in each iotests

2020-03-25 Thread Vladimir Sementsov-Ogievskiy
We are going to drop group file. Define group in tests as a preparatory step. The patch is generated by cd tests/qemu-iotests grep '^[0-9]\{3\} ' group | while read line; do file=$(awk '{print $1}' <<< "$line"); groups=$(sed -e 's/^... //' <<< "$line"); awk "NR==2

Re: [PATCH v5 12/26] nvme: add missing mandatory features

2020-03-25 Thread Maxim Levitsky
On Mon, 2020-03-16 at 00:47 -0700, Klaus Birkelund Jensen wrote: > On Feb 12 12:27, Maxim Levitsky wrote: > > On Tue, 2020-02-04 at 10:51 +0100, Klaus Jensen wrote: > > > Add support for returning a resonable response to Get/Set Features of > > > mandatory features. > > > > > > Signed-off-by: Klau

[PATCH v2 2/2] iotests: rework test finding

2020-03-25 Thread Vladimir Sementsov-Ogievskiy
Add python script with new logic of searching for tests: Old behavior: - tests are named [0-9][0-9][0-9] - tests must be registered in group file (even if test doesn't belong to any group, like 142) New behavior: - group file is dropped - tests are searched by file-name instead of group fi

Re: [PATCH v5 10/26] nvme: add support for the get log page command

2020-03-25 Thread Maxim Levitsky
On Mon, 2020-03-16 at 00:45 -0700, Klaus Birkelund Jensen wrote: > On Feb 12 11:35, Maxim Levitsky wrote: > > On Tue, 2020-02-04 at 10:51 +0100, Klaus Jensen wrote: > > > Add support for the Get Log Page command and basic implementations of > > > the mandatory Error Information, SMART / Health Info

Re: [PATCH v5 17/26] nvme: allow multiple aios per command

2020-03-25 Thread Maxim Levitsky
On Mon, 2020-03-16 at 00:53 -0700, Klaus Birkelund Jensen wrote: > On Feb 12 13:48, Maxim Levitsky wrote: > > On Tue, 2020-02-04 at 10:51 +0100, Klaus Jensen wrote: > > > This refactors how the device issues asynchronous block backend > > > requests. The NvmeRequest now holds a queue of NvmeAIOs th

Re: [PATCH v5 20/26] nvme: handle dma errors

2020-03-25 Thread Maxim Levitsky
On Mon, 2020-03-16 at 00:53 -0700, Klaus Birkelund Jensen wrote: > On Feb 12 13:52, Maxim Levitsky wrote: > > On Tue, 2020-02-04 at 10:52 +0100, Klaus Jensen wrote: > > > Handling DMA errors gracefully is required for the device to pass the > > > block/011 test ("disable PCI device while doing I/O"

Re: [PATCH v5 14/26] nvme: make sure ncqr and nsqr is valid

2020-03-25 Thread Maxim Levitsky
On Mon, 2020-03-16 at 00:48 -0700, Klaus Birkelund Jensen wrote: > On Feb 12 12:30, Maxim Levitsky wrote: > > On Tue, 2020-02-04 at 10:51 +0100, Klaus Jensen wrote: > > > 0x is not an allowed value for NCQR and NSQR in Set Features on > > > Number of Queues. > > > > > > Signed-off-by: Klaus Je

Re: [PATCH v5 16/26] nvme: refactor prp mapping

2020-03-25 Thread Maxim Levitsky
On Mon, 2020-03-16 at 00:51 -0700, Klaus Birkelund Jensen wrote: > On Feb 12 13:44, Maxim Levitsky wrote: > > On Tue, 2020-02-04 at 10:51 +0100, Klaus Jensen wrote: > > > Refactor nvme_map_prp and allow PRPs to be located in the CMB. The logic > > > ensures that if some of the PRP is in the CMB, al

Re: [PATCH v5 15/26] nvme: bump supported specification to 1.3

2020-03-25 Thread Maxim Levitsky
On Mon, 2020-03-16 at 00:50 -0700, Klaus Birkelund Jensen wrote: > On Feb 12 12:35, Maxim Levitsky wrote: > > On Tue, 2020-02-04 at 10:51 +0100, Klaus Jensen wrote: > > > Add new fields to the Identify Controller and Identify Namespace data > > > structures accoding to NVM Express 1.3d. > > > > >

Re: [PATCH v5 22/26] nvme: support multiple namespaces

2020-03-25 Thread Maxim Levitsky
On Mon, 2020-03-16 at 00:55 -0700, Klaus Birkelund Jensen wrote: > On Feb 12 14:34, Maxim Levitsky wrote: > > On Tue, 2020-02-04 at 10:52 +0100, Klaus Jensen wrote: > > > This adds support for multiple namespaces by introducing a new 'nvme-ns' > > > device model. The nvme device creates a bus named

Re: [PATCH v5 21/26] nvme: add support for scatter gather lists

2020-03-25 Thread Maxim Levitsky
On Mon, 2020-03-16 at 00:54 -0700, Klaus Birkelund Jensen wrote: > On Feb 12 14:07, Maxim Levitsky wrote: > > On Tue, 2020-02-04 at 10:52 +0100, Klaus Jensen wrote: > > > For now, support the Data Block, Segment and Last Segment descriptor > > > types. > > > > > > See NVM Express 1.3d, Section 4.4

Re: [PATCH v5 10/26] nvme: add support for the get log page command

2020-03-25 Thread Maxim Levitsky
On Mon, 2020-03-16 at 00:45 -0700, Klaus Birkelund Jensen wrote: > On Feb 12 11:35, Maxim Levitsky wrote: > > On Tue, 2020-02-04 at 10:51 +0100, Klaus Jensen wrote: > > > Add support for the Get Log Page command and basic implementations of > > > the mandatory Error Information, SMART / Health Info

Re: [PATCH v6 00/42] nvme: support NVMe v1.3d, SGLs and multiple namespaces

2020-03-25 Thread Maxim Levitsky
On Mon, 2020-03-16 at 07:28 -0700, Klaus Jensen wrote: > From: Klaus Jensen > > Hi, > > So this patchset kinda blew up in size (wrt. number of patches) after > Maxim's comments (26 -> 42), but Maxim's comments about splitting up a > bunch of the patches made a lot of sense. I don't think this is

Re: [PATCH v6 03/42] nvme: move device parameters to separate struct

2020-03-25 Thread Maxim Levitsky
On Mon, 2020-03-16 at 07:28 -0700, Klaus Jensen wrote: > From: Klaus Jensen > > Move device configuration parameters to separate struct to make it > explicit what is configurable and what is set internally. > > Signed-off-by: Klaus Jensen > Acked-by: Keith Busch > Reviewed-by: Maxim Levitsky

Re: [PATCH v6 05/42] nvme: use constant for identify data size

2020-03-25 Thread Maxim Levitsky
On Mon, 2020-03-16 at 07:28 -0700, Klaus Jensen wrote: > From: Klaus Jensen > > Signed-off-by: Klaus Jensen > --- > hw/block/nvme.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/block/nvme.c b/hw/block/nvme.c > index 40cb176dea3c..f716f690a594 100644 > --- a/hw/bl

Re: [PATCH v6 04/42] nvme: bump spec data structures to v1.3

2020-03-25 Thread Maxim Levitsky
On Mon, 2020-03-16 at 07:28 -0700, Klaus Jensen wrote: > From: Klaus Jensen > > Add missing fields in the Identify Controller and Identify Namespace > data structures to bring them in line with NVMe v1.3. > > This also adds data structures and defines for SGL support which > requires a couple of

Re: [PATCH v6 01/42] nvme: rename trace events to nvme_dev

2020-03-25 Thread Maxim Levitsky
On Mon, 2020-03-16 at 07:28 -0700, Klaus Jensen wrote: > From: Klaus Jensen > > Change the prefix of all nvme device related trace events to 'nvme_dev' > to not clash with trace events from the nvme block driver. > > Signed-off-by: Klaus Jensen > Acked-by: Keith Busch > Reviewed-by: Maxim Levi

Re: [PATCH v6 07/42] nvme: refactor nvme_addr_read

2020-03-25 Thread Maxim Levitsky
On Mon, 2020-03-16 at 07:28 -0700, Klaus Jensen wrote: > From: Klaus Jensen > > Pull the controller memory buffer check to its own function. The check > will be used on its own in later patches. > > Signed-off-by: Klaus Jensen > Acked-by: Keith Busch > --- > hw/block/nvme.c | 16 -

Re: [PATCH v6 08/42] nvme: add support for the abort command

2020-03-25 Thread Maxim Levitsky
On Mon, 2020-03-16 at 07:28 -0700, Klaus Jensen wrote: > From: Klaus Jensen > > Required for compliance with NVMe revision 1.2.1. See NVM Express 1.2.1, > Section 5.1 ("Abort command"). > > The Abort command is a best effort command; for now, the device always > fails to abort the given command.

Re: [PATCH v6 10/42] nvme: refactor device realization

2020-03-25 Thread Maxim Levitsky
On Mon, 2020-03-16 at 07:28 -0700, Klaus Jensen wrote: > From: Klaus Jensen > > This patch splits up nvme_realize into multiple individual functions, > each initializing a different subset of the device. > > Signed-off-by: Klaus Jensen > Acked-by: Keith Busch > --- > hw/block/nvme.c | 178 +++

Re: [PATCH v6 06/42] nvme: add identify cns values in header

2020-03-25 Thread Maxim Levitsky
On Mon, 2020-03-16 at 07:28 -0700, Klaus Jensen wrote: > From: Klaus Jensen > > Signed-off-by: Klaus Jensen > --- > hw/block/nvme.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/hw/block/nvme.c b/hw/block/nvme.c > index f716f690a594..b38d7e548a60 100644 > --- a

Re: [PATCH v6 11/42] nvme: add temperature threshold feature

2020-03-25 Thread Maxim Levitsky
On Mon, 2020-03-16 at 07:28 -0700, Klaus Jensen wrote: > From: Klaus Jensen > > It might seem wierd to implement this feature for an emulated device, > but it is mandatory to support and the feature is useful for testing > asynchronous event request support, which will be added in a later > patch

Re: [PATCH v6 12/42] nvme: add support for the get log page command

2020-03-25 Thread Maxim Levitsky
On Mon, 2020-03-16 at 07:28 -0700, Klaus Jensen wrote: > From: Klaus Jensen > > Add support for the Get Log Page command and basic implementations of > the mandatory Error Information, SMART / Health Information and Firmware > Slot Information log pages. > > In violation of the specification, th

Re: [PATCH v6 13/42] nvme: add support for the asynchronous event request command

2020-03-25 Thread Maxim Levitsky
On Mon, 2020-03-16 at 07:28 -0700, Klaus Jensen wrote: > From: Klaus Jensen > > Required for compliance with NVMe revision 1.2.1. See NVM Express 1.2.1, > Section 5.2 ("Asynchronous Event Request command"). > > Mostly imported from Keith's qemu-nvme tree. Modified with a max number > of queued e

Re: [PATCH v6 09/42] nvme: add max_ioqpairs device parameter

2020-03-25 Thread Maxim Levitsky
On Mon, 2020-03-16 at 07:28 -0700, Klaus Jensen wrote: > From: Klaus Jensen > > The num_queues device paramater has a slightly confusing meaning because > it accounts for the admin queue pair which is not really optional. > Secondly, it is really a maximum value of queues allowed. > > Add a new

Re: [PATCH v6 18/42] nvme: support identify namespace descriptor list

2020-03-25 Thread Maxim Levitsky
On Mon, 2020-03-16 at 07:29 -0700, Klaus Jensen wrote: > From: Klaus Jensen > > Since we are not providing the NGUID or EUI64 fields, we must support > the Namespace UUID. We do not have any way of storing a persistent > unique identifier, so conjure up a UUID that is just the namespace id. > >

Re: [PATCH v6 15/42] nvme: additional tracing

2020-03-25 Thread Maxim Levitsky
On Mon, 2020-03-16 at 07:29 -0700, Klaus Jensen wrote: > From: Klaus Jensen > > Add additional trace calls for nvme_enqueue_req_completion, mmio and > doorbell writes. > > Also, streamline nvme_identify_ns and nvme_identify_ns_list. They do not > need to repeat the command, it is already in the

RE: [PATCH v1 18/22] vfio: add support for flush iommu stage-1 cache

2020-03-25 Thread Liu, Yi L
> From: Peter Xu > Sent: Wednesday, March 25, 2020 2:19 AM > To: Liu, Yi L > Subject: Re: [PATCH v1 18/22] vfio: add support for flush iommu stage-1 cache > > On Sun, Mar 22, 2020 at 05:36:15AM -0700, Liu Yi L wrote: > > This patch adds flush_stage1_cache() definition in HostIOMUContextClass. >

Re: [PATCH v6 17/42] nvme: add log specific field to trace events

2020-03-25 Thread Maxim Levitsky
On Mon, 2020-03-16 at 07:29 -0700, Klaus Jensen wrote: > From: Klaus Jensen > > The LSP field is not used directly now, but include it in the trace. > > Signed-off-by: Klaus Jensen > --- > hw/block/nvme.c | 3 ++- > hw/block/trace-events | 2 +- > 2 files changed, 3 insertions(+), 2 dele

Re: [PATCH v6 19/42] nvme: enforce valid queue creation sequence

2020-03-25 Thread Maxim Levitsky
On Mon, 2020-03-16 at 07:29 -0700, Klaus Jensen wrote: > From: Klaus Jensen > > Support returning Command Sequence Error if Set Features on Number of > Queues is called after queues have been created. > > Signed-off-by: Klaus Jensen > --- > hw/block/nvme.c | 7 +++ > hw/block/nvme.h | 1 +

Re: [PATCH v3] migration: use "" instead of (null) for tls-authz

2020-03-25 Thread Dr. David Alan Gilbert
* Mao Zhongyi (maozhon...@cmss.chinamobile.com) wrote: > run: > (qemu) info migrate_parameters > announce-initial: 50 ms > ... > announce-max: 550 ms > multifd-compression: none > xbzrle-cache-size: 4194304 > max-postcopy-bandwidth: 0 > tls-authz: '(null)' > > Migration parameter 'tls-authz' is u

Re: [PATCH v6 16/42] nvme: make sure ncqr and nsqr is valid

2020-03-25 Thread Maxim Levitsky
On Mon, 2020-03-16 at 07:29 -0700, Klaus Jensen wrote: > From: Klaus Jensen > > 0x is not an allowed value for NCQR and NSQR in Set Features on > Number of Queues. > > Signed-off-by: Klaus Jensen > Acked-by: Keith Busch > Reviewed-by: Maxim Levitsky > --- > hw/block/nvme.c | 8 >

Re: [PATCH v6 14/42] nvme: add missing mandatory features

2020-03-25 Thread Maxim Levitsky
On Mon, 2020-03-16 at 07:29 -0700, Klaus Jensen wrote: > From: Klaus Jensen > > Add support for returning a resonable response to Get/Set Features of > mandatory features. > > Signed-off-by: Klaus Jensen > Acked-by: Keith Busch > --- > hw/block/nvme.c | 60 ++

Re: [PATCH for-5.0, v1] target/mips: Fix loongson multimedia condition instructions

2020-03-25 Thread Aleksandar Markovic
16:59 Uto, 24.03.2020. Richard Henderson је написао/ла: > > On 3/24/20 5:22 AM, Jiaxun Yang wrote: > > Loongson multimedia condition instructions were previously implemented as > > write 0 to rd due to lack of documentation. So I just confirmed with Loongson > > about their encoding and implemente

Re: [PATCH v6 20/42] nvme: provide the mandatory subnqn field

2020-03-25 Thread Maxim Levitsky
On Mon, 2020-03-16 at 07:29 -0700, Klaus Jensen wrote: > From: Klaus Jensen > > Signed-off-by: Klaus Jensen > --- > hw/block/nvme.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/hw/block/nvme.c b/hw/block/nvme.c > index b40d27cddc46..74061d08fd2e 100644 > --- a/hw/block/nvme.c >

RE: [PATCH v1 17/22] intel_iommu: do not pass down pasid bind for PASID #0

2020-03-25 Thread Liu, Yi L
> From: Peter Xu < pet...@redhat.com> > Sent: Wednesday, March 25, 2020 2:13 AM > To: Liu, Yi L > Subject: Re: [PATCH v1 17/22] intel_iommu: do not pass down pasid bind for > PASID > #0 > > On Sun, Mar 22, 2020 at 05:36:14AM -0700, Liu Yi L wrote: > > RID_PASID field was introduced in VT-d 3.0 s

Re: [PATCH for-5.0, v1] target/mips: Fix loongson multimedia condition instructions

2020-03-25 Thread Aleksandar Markovic
12:44 Sre, 25.03.2020. Aleksandar Markovic је написао/ла: > > 16:59 Uto, 24.03.2020. Richard Henderson је написао/ла: > > > > On 3/24/20 5:22 AM, Jiaxun Yang wrote: > > > Loongson multimedia condition instructions were previously implemented as > > > write 0 to rd due to lack of documentation. So

Re: [PATCH v6 21/42] nvme: bump supported version to v1.3

2020-03-25 Thread Maxim Levitsky
On Mon, 2020-03-16 at 07:29 -0700, Klaus Jensen wrote: > From: Klaus Jensen > > Signed-off-by: Klaus Jensen > --- > hw/block/nvme.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/hw/block/nvme.c b/hw/block/nvme.c > index 74061d08fd2e..26c4b6e69f72 100644 > --- a/hw

Re: [PATCH v1 06/11] configure: disable MTTCG for MIPS guests

2020-03-25 Thread Aleksandar Markovic
20:17 Pon, 23.03.2020. Richard Henderson је написао/ла: > > On 3/23/20 9:15 AM, Alex Bennée wrote: > > While debugging check-acceptance failures I found an instability in > > the mips64el test case. Briefly the test case: > > > > retry.py -n 100 -c -- ./mips64el-softmmu/qemu-system-mips64el \ >

Re: [PATCH v6 22/42] nvme: memset preallocated requests structures

2020-03-25 Thread Maxim Levitsky
On Mon, 2020-03-16 at 07:29 -0700, Klaus Jensen wrote: > From: Klaus Jensen > > This is preparatory to subsequent patches that change how QSGs/IOVs are > handled. It is important that the qsg and iov members of the NvmeRequest > are initially zeroed. > > Signed-off-by: Klaus Jensen > --- > hw/

Re: [PATCH v6 26/42] nvme: pass request along for tracing

2020-03-25 Thread Maxim Levitsky
On Mon, 2020-03-16 at 07:29 -0700, Klaus Jensen wrote: > From: Klaus Jensen > > Signed-off-by: Klaus Jensen > --- > hw/block/nvme.c | 67 +-- > hw/block/trace-events | 2 +- > 2 files changed, 40 insertions(+), 29 deletions(-) > > diff --git a/hw/

Re: [PATCH v6 23/42] nvme: add mapping helpers

2020-03-25 Thread Maxim Levitsky
On Mon, 2020-03-16 at 07:29 -0700, Klaus Jensen wrote: > From: Klaus Jensen > > Add nvme_map_addr, nvme_map_addr_cmb and nvme_addr_to_cmb helpers and > use them in nvme_map_prp. > > This fixes a bug where in the case of a CMB transfer, the device would > map to the buffer with a wrong length. >

Re: [PATCH v6 28/42] nvme: verify validity of prp lists in the cmb

2020-03-25 Thread Maxim Levitsky
On Mon, 2020-03-16 at 07:29 -0700, Klaus Jensen wrote: > From: Klaus Jensen > > Before this patch the device already supported this, but it did not > check for the validity of it nor announced the support in the LISTS > field. > > If some of the PRPs in a PRP list are in the CMB, then ALL entrie

Re: [PATCH v6 24/42] nvme: remove redundant has_sg member

2020-03-25 Thread Maxim Levitsky
On Mon, 2020-03-16 at 07:29 -0700, Klaus Jensen wrote: > From: Klaus Jensen > > Remove the has_sg member from NvmeRequest since it's redundant. To be honest this patch also replaces the dma_acct_start with block_acct_start which looks right to me, and IMHO its OK to have both in the same patch,

Re: [PATCH v6 29/42] nvme: refactor request bounds checking

2020-03-25 Thread Maxim Levitsky
On Mon, 2020-03-16 at 07:29 -0700, Klaus Jensen wrote: > From: Klaus Jensen > > Signed-off-by: Klaus Jensen > --- > hw/block/nvme.c | 28 ++-- > 1 file changed, 22 insertions(+), 6 deletions(-) > > diff --git a/hw/block/nvme.c b/hw/block/nvme.c > index eecfad694bf8..ba5

Re: [PATCH v6 30/42] nvme: add check for mdts

2020-03-25 Thread Maxim Levitsky
On Mon, 2020-03-16 at 07:29 -0700, Klaus Jensen wrote: > From: Klaus Jensen > > Add 'mdts' device parameter to control the Maximum Data Transfer Size of > the controller and check that it is respected. > > Signed-off-by: Klaus Jensen > --- > hw/block/nvme.c | 29 +

Re: [PATCH v6 31/42] nvme: add check for prinfo

2020-03-25 Thread Maxim Levitsky
On Mon, 2020-03-16 at 07:29 -0700, Klaus Jensen wrote: > From: Klaus Jensen > > Check the validity of the PRINFO field. > > Signed-off-by: Klaus Jensen > --- > hw/block/nvme.c | 50 --- > hw/block/trace-events | 1 + > include/block/nvme.h | 1 +

Re: [PATCH v6 25/42] nvme: refactor dma read/write

2020-03-25 Thread Maxim Levitsky
On Mon, 2020-03-16 at 07:29 -0700, Klaus Jensen wrote: > From: Klaus Jensen > > Refactor the nvme_dma_{read,write}_prp functions into a common function > taking a DMADirection parameter. > > Signed-off-by: Klaus Jensen > --- > hw/block/nvme.c | 89 --

[PULL 2/2] hw/audio/fmopl: fix segmentation fault

2020-03-25 Thread Gerd Hoffmann
From: Volker Rümelin Current code allocates the memory for ENV_CURVE too late. Move allocation to OPLOpenTable() and deallocation to OPLCloseTable(). To reproduce the bug start qemu with -soundhw adlib. Fixes 2eea51bd01 "hw/audio/fmopl: Move ENV_CURVE to .heap to save 32KiB of .bss" Signed-off

Re: [PATCH v6 35/42] nvme: handle dma errors

2020-03-25 Thread Maxim Levitsky
On Mon, 2020-03-16 at 07:29 -0700, Klaus Jensen wrote: > From: Klaus Jensen > > Handling DMA errors gracefully is required for the device to pass the > block/011 test ("disable PCI device while doing I/O") in the blktests > suite. > > With this patch the device passes the test by retrying "criti

Re: [PATCH v6 36/42] nvme: add support for scatter gather lists

2020-03-25 Thread Maxim Levitsky
On Mon, 2020-03-16 at 07:29 -0700, Klaus Jensen wrote: > From: Klaus Jensen > > For now, support the Data Block, Segment and Last Segment descriptor > types. > > See NVM Express 1.3d, Section 4.4 ("Scatter Gather List (SGL)"). > > Signed-off-by: Klaus Jensen > Acked-by: Keith Busch > --- > h

Re: [PATCH v6 27/42] nvme: add request mapping helper

2020-03-25 Thread Maxim Levitsky
On Mon, 2020-03-16 at 07:29 -0700, Klaus Jensen wrote: > From: Klaus Jensen > > Introduce the nvme_map helper to remove some noise in the main nvme_rw > function. > > Signed-off-by: Klaus Jensen > --- > hw/block/nvme.c | 13 ++--- > 1 file changed, 10 insertions(+), 3 deletions(-) > >

Re: [PATCH v6 37/42] nvme: refactor identify active namespace id list

2020-03-25 Thread Maxim Levitsky
On Mon, 2020-03-16 at 07:29 -0700, Klaus Jensen wrote: > From: Klaus Jensen > > Prepare to support inactive namespaces. > > Signed-off-by: Klaus Jensen > --- > hw/block/nvme.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/hw/block/nvme.c b/hw/block/nvme.c >

[PULL 0/2] Fixes 20200325 patches

2020-03-25 Thread Gerd Hoffmann
The following changes since commit 736cf607e40674776d752acc201f565723e86045: Update version for v5.0.0-rc0 release (2020-03-24 17:50:00 +) are available in the Git repository at: git://git.kraxel.org/qemu tags/fixes-20200325-pull-request for you to fetch changes up to

Re: [PATCH v6 38/42] nvme: support multiple namespaces

2020-03-25 Thread Maxim Levitsky
On Mon, 2020-03-16 at 07:29 -0700, Klaus Jensen wrote: > From: Klaus Jensen > > This adds support for multiple namespaces by introducing a new 'nvme-ns' > device model. The nvme device creates a bus named from the device name > ('id'). The nvme-ns devices then connect to this and registers > them

  1   2   3   4   >