[PULL 1/1] compat: disable edid on correct virtio-gpu device

2020-03-20 Thread Gerd Hoffmann
From: Cornelia Huck Commit bb15791166c1 ("compat: disable edid on virtio-gpu base device") tried to disable 'edid' on the virtio-gpu base device. However, that device is not 'virtio-gpu', but 'virtio-gpu-device'. Fix it. Fixes: bb15791166c1 ("compat: disable edid on virtio-gpu base device") Repo

[PULL 0/1] Vga 20200320 patches

2020-03-20 Thread Gerd Hoffmann
The following changes since commit e6d567db23219fe9979f16d74e13f27145f07f84: Merge remote-tracking branch 'remotes/jnsnow/tags/bitmaps-pull-request' into staging (2020-03-19 15:31:09 +) are available in the Git repository at: git://git.kraxel.org/qemu tags/vga-20200320-pu

[Bug 1868221] Re: /usr/share/applications/qemu.desktop should have an "Exec=" key.

2020-03-20 Thread Lockywolf
The specification can be seen here: https://specifications.freedesktop.org/desktop-entry-spec/desktop-entry- spec-latest.html#exec-variables -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1868221 Tit

[Bug 1868221] [NEW] /usr/share/applications/qemu.desktop should have an "Exec=" key.

2020-03-20 Thread Lockywolf
Public bug reported: According to the www.freedesktop.org .desktop-file specification, all "Application" desktop files should have an "Exec=" key. The one in qemu doesn't. This can be easily verified by running kbuildsycoca4 if KDE4 is present, but the issue is not DE-dependent. Which binary exa

Re: [PULL 0/1] Slirp patches

2020-03-20 Thread Aleksandar Markovic
четвртак, 19. март 2020., Marc-André Lureau је написао/ла: > The following changes since commit f57587c7d47b35b2d9b31def3a74d8 > 1bdb5475d7: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2020-03-17' > into staging (2020-03-19 10:18:07 +) > > are available in the Git reposi

Re: [PATCH 05/13] microvm: add acpi_dsdt_add_virtio() for x86

2020-03-20 Thread Gerd Hoffmann
Hi, > > +uint32_t irq = VIRTIO_IRQ_BASE + index; > > +hwaddr base = VIRTIO_MMIO_BASE + index * 512; > > +hwaddr size = 512; > is it possible to fish these values out from device without poking in its guts > like using sysbus_get_connected_irq() and make up som

Re: [PULL v3 00/16] Linux user for 5.0 patches

2020-03-20 Thread Laurent Vivier
Le 19/03/2020 à 21:45, Peter Maydell a écrit : > On Thu, 19 Mar 2020 at 09:29, Laurent Vivier wrote: >> >> The following changes since commit 373c7068dd610e97f0b551b5a6d0a27cd6da4506: >> >> qemu.nsi: Install Sphinx documentation (2020-03-09 16:45:00 +) >> >> are available in the Git reposito

Re: [PATCH 03/13] microvm: add isa-acpi device

2020-03-20 Thread Gerd Hoffmann
On Thu, Mar 19, 2020 at 02:42:18PM +0100, Igor Mammedov wrote: > On Thu, 19 Mar 2020 09:01:07 +0100 > Gerd Hoffmann wrote: > > > Minimal ACPI device for PCI-less machines like microvm. > it seems that x86 kernel is able to boot on hw-reduced acpi systems > (but I haven't really tested any distro

Re: [PATCH 00/13] microvm: add acpi support

2020-03-20 Thread Gerd Hoffmann
On Thu, Mar 19, 2020 at 06:34:40PM +0100, Paolo Bonzini wrote: > On 19/03/20 14:40, Gerd Hoffmann wrote: > >> Also, can you confirm that it builds without CONFIG_I440FX and > >> CONFIG_Q35? You probably need to add "imply ACPI" and possibly some > >> '#include "config-devices.h"' and '#ifdef CONFI

Re: [PATCH v14 Kernel 5/7] vfio iommu: Update UNMAP_DMA ioctl to get dirty bitmap before unmap

2020-03-20 Thread Yan Zhao
On Thu, Mar 19, 2020 at 03:41:12AM +0800, Kirti Wankhede wrote: > DMA mapped pages, including those pinned by mdev vendor drivers, might > get unpinned and unmapped while migration is active and device is still > running. For example, in pre-copy phase while guest driver could access > those pages,

Re: [PATCH v2] target/ppc: Fix ISA v3.0 (POWER9) slbia implementation

2020-03-20 Thread David Gibson
On Thu, Mar 19, 2020 at 04:44:39PM +1000, Nicholas Piggin wrote: > The new ISA v3.0 slbia variants have not been implemented for TCG, > which can lead to crashing when a POWER9 machine boots Linux using > the hash MMU, for example ("disable_radix" kernel command line). > > Add them. > > Signed-of

Re: [PATCH v3 1/1] target/ppc: don't byte swap ELFv2 signal handler

2020-03-20 Thread David Gibson
On Thu, Mar 19, 2020 at 08:32:44AM -0500, Vincent Fazio wrote: > From: Vincent Fazio > > Previously, the signal handler would be byte swapped if the target and > host CPU used different endianness. This would cause a SIGSEGV when > attempting to translate the opcode pointed to by the swapped addr

Re: Qemu API documentation

2020-03-20 Thread Alex Bennée
Priyamvad Acharya writes: > Thanks Alex, I will check it out. > Have you look at below issue which I mention in my previous email? Without seeing the full code changes it's hard to make a determination. But it looks like you haven't followed the template of defining the device type. Also have

Re: [PATCH v2 1/1] device_tree: Add info message when dumping dtb to file

2020-03-20 Thread David Gibson
On Thu, Mar 19, 2020 at 01:03:26AM -0300, Leonardo Bras wrote: > When dumping dtb to a file, qemu exits silently before starting the VM. > > Add info message so user can easily track why the proccess exits. > Add error message if dtb dump failed. > > Signed-off-by: Leonardo Bras Reviewed-by: Da

[PATCH 1/2] qapi: Reject section markup in definition documentation

2020-03-20 Thread Markus Armbruster
Section markup in definition documentation makes no sense and can produce invalid Texinfo. Reject. Signed-off-by: Markus Armbruster --- docs/devel/qapi-code-gen.txt | 2 ++ scripts/qapi/parser.py | 5 + tests/qapi-schema/doc-bad-section.err | 1 + tests/qapi-sc

Re: [PATCH] gdbstub: add support to Xfer:auxv:read: packet

2020-03-20 Thread Alex Bennée
Lirong Yuan writes: > On Fri, Mar 6, 2020 at 5:01 PM Lirong Yuan wrote: > >> This allows gdb to access the target’s auxiliary vector, >> which can be helpful for telling system libraries important details >> about the hardware, operating system, and process. >> >> Signed-off-by: Lirong Yuan >

[PATCH RFC 2/2] qapi: Make section headings start a new doc comment block

2020-03-20 Thread Markus Armbruster
Our current QAPI doc-comment markup allows section headers (introduced with a leading '=' or '==') anywhere in a free-form documentation comment. This works for Texinfo because the generator simply prints a Texinfo section command at that point in the output stream. For rST generation, since we'r

[PATCH 0/2] qapi: A section heading bug fix, and maybe an improvement

2020-03-20 Thread Markus Armbruster
PATCH 1 fixes an old defect in the doc comment parser. I figure it'll simplify the rST generator's job. PATCH 2 might simplify it further. It's RFC because I'm not sure it does. Peter, you tell me :) Markus Armbruster (2): qapi: Reject section markup in definition documentation [RFC] qapi

Re: [PATCH v3] block/iscsi:use the flags in iscsi_open() prevent Clang warning

2020-03-20 Thread Laurent Vivier
Le 20/03/2020 à 03:25, Chenqun (kuhn) a écrit : > Gentle ping. > > Any other suggestions about this? I will not take that via the trivial queue as it is not trivial for me. Could it go via block queue? Thanks, Laurent > Thanks. > >> -Original Message- >> From: Chenqun (kuhn) >> Sent:

Re: [PULL 3/4] s390/ipl: sync back loadparm

2020-03-20 Thread Christian Borntraeger
On 19.03.20 21:31, Peter Maydell wrote: > On Tue, 10 Mar 2020 at 15:09, Christian Borntraeger > wrote: >> >> From: Halil Pasic >> >> We expose loadparm as a r/w machine property, but if loadparm is set by >> the guest via DIAG 308, we don't update the property. Having a >> disconnect between t

[kvm-unit-tests PATCH v7 03/13] arm/arm64: gic: Introduce setup_irq() helper

2020-03-20 Thread Eric Auger
ipi_enable() code would be reusable for other interrupts than IPI. Let's rename it setup_irq() and pass an interrupt handler pointer. Signed-off-by: Eric Auger --- v4 -> v5: - s/handler_t/irq_handler_t - also add irq_handler_fn in lib/arm/asm/processor.h v2 -> v3: - do not export setup_irq any

[kvm-unit-tests PATCH v7 01/13] libcflat: Add other size defines

2020-03-20 Thread Eric Auger
Introduce additional SZ_256, SZ_8K, SZ_16K macros that will be used by ITS tests. Signed-off-by: Eric Auger Reviewed-by: Thomas Huth --- lib/libcflat.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/libcflat.h b/lib/libcflat.h index ea19f61..7092af2 100644 --- a/lib/libcflat.h +++ b

[kvm-unit-tests PATCH v7 04/13] arm/arm64: gicv3: Add some re-distributor defines

2020-03-20 Thread Eric Auger
PROPBASER, PENDBASE and GICR_CTRL will be used for LPI management. Signed-off-by: Eric Auger Reviewed-by: Zenghui Yu --- v3 -> v4: - replace some spaces by tabs and added Zenghui's R-b --- lib/arm/asm/gic-v3.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/arm/asm/gic-v3.h b/li

[kvm-unit-tests PATCH v7 00/13] arm/arm64: Add ITS tests

2020-03-20 Thread Eric Auger
This series is a revival of an RFC series sent in Dec 2016 [1]. Given the amount of code and the lack of traction at that time, I haven't respinned until now. However a recent bug found related to the ITS migration convinced me that this work may deserve to be respinned and enhanced. Tests exercis

[kvm-unit-tests PATCH v7 02/13] page_alloc: Introduce get_order()

2020-03-20 Thread Eric Auger
Compute the power of 2 order of a size. Use it in page_memalign. Other users are looming. Signed-off-by: Eric Auger --- lib/alloc_page.c | 7 ++- lib/alloc_page.h | 1 + 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/lib/alloc_page.c b/lib/alloc_page.c index ed23638..7c8461a 1

[kvm-unit-tests PATCH v7 08/13] arm/arm64: ITS: Device and collection Initialization

2020-03-20 Thread Eric Auger
Introduce an helper functions to register - a new device, characterized by its device id and the max number of event IDs that dimension its ITT (Interrupt Translation Table). The function allocates the ITT. - a new collection, characterized by its ID and the target processing engine (PE).

[kvm-unit-tests PATCH v7 11/13] arm/run: Allow Migration tests

2020-03-20 Thread Eric Auger
Let's link getchar.o to use puts and getchar from the tests. Then allow tests belonging to the migration group to trigger the migration from the test code by putting "migrate" into the uart. Then the code can wait for the migration completion by using getchar(). The __getchar implement is minimal

[kvm-unit-tests PATCH v7 07/13] arm/arm64: ITS: its_enable_defaults

2020-03-20 Thread Eric Auger
its_enable_defaults() enable LPIs at redistributor level and ITS level. gicv3_enable_defaults must be called before. Signed-off-by: Eric Auger Reviewed-by: Zenghui Yu --- v6 -> v7: - use for_each_present_cpu in its_enable_defaults v5 -> v6: - gicv3_lpi_set/get_config introduced before this pa

[kvm-unit-tests PATCH v7 09/13] arm/arm64: ITS: Commands

2020-03-20 Thread Eric Auger
Implement main ITS commands. The code is largely inherited from the ITS driver. Signed-off-by: Eric Auger --- v6 -> v7: - remove #include v5 -> v6: - fix 2 printfs - removed GITS_CMD_MAPVI v3 -> v4: - device's itt now is a VGA - pass verbose to choose whether we shall print the cmd - use pri

[kvm-unit-tests PATCH v7 12/13] arm/arm64: ITS: migration tests

2020-03-20 Thread Eric Auger
This test maps LPIs (populates the device table, the collection table, interrupt translation tables, configuration table), migrates and make sure the translation is correct on the destination. Signed-off-by: Eric Auger --- v4 -> v5: - move stub from header to arm/gic.c v3 -> v4: - assert in its

[kvm-unit-tests PATCH v7 05/13] arm/arm64: gicv3: Set the LPI config and pending tables

2020-03-20 Thread Eric Auger
Allocate the LPI configuration and per re-distributor pending table. Set redistributor's PROPBASER and PENDBASER. The LPIs are enabled by default in the config table. Also introduce a helper routine that allows to set the pending table bit for a given LPI and macros to set/get its configuration.

[kvm-unit-tests PATCH v7 06/13] arm/arm64: ITS: Introspection tests

2020-03-20 Thread Eric Auger
Detect the presence of an ITS as part of the GICv3 init routine, initialize its base address and read few registers the IIDR, the TYPER to store its dimensioning parameters. Parse the BASER registers. As part of the init sequence we also init all the requested tables. This is our first ITS test, b

[kvm-unit-tests PATCH v7 10/13] arm/arm64: ITS: INT functional tests

2020-03-20 Thread Eric Auger
Triggers LPIs through the INT command. the test checks the LPI hits the right CPU and triggers the right LPI intid, ie. the translation is correct. Updates to the config table also are tested, along with inv and invall commands. Signed-off-by: Eric Auger --- v5 -> v6: - removed collection-unma

Re: [PATCH] aio-posix: fix io_uring with external events

2020-03-20 Thread Stefano Garzarella
On Thu, Mar 19, 2020 at 04:35:59PM +, Stefan Hajnoczi wrote: > When external event sources are disabled fdmon-io_uring falls back to > fdmon-poll. The ->need_wait() callback needs to watch for this so it > can return true when external event sources are disabled. > > It is also necessary to c

[kvm-unit-tests PATCH v7 13/13] arm/arm64: ITS: pending table migration test

2020-03-20 Thread Eric Auger
Add two new migration tests. One testing the migration of a topology where collection were unmapped. The second test checks the migration of the pending table. Signed-off-by: Eric Auger --- v6 -> v7: - test_migrate_unmapped_collection now uses pe0=0. Otherwise, depending on SMP value it colli

Re: [PULL 0/1] Slirp patches

2020-03-20 Thread Peter Maydell
On Fri, 20 Mar 2020 at 08:19, Aleksandar Markovic wrote: > This pull request has a very unusual form to me. In its cover letter, it > appears as if only one > line of code is changed, while the patch 1/1 strangely suggests that there > are number of > underlying patches. I am really puzzled how

Re: [PATCH v5 07/18] s390x: protvirt: Inhibit balloon when switching to protected mode

2020-03-20 Thread David Hildenbrand
On 19.03.20 18:45, Michael S. Tsirkin wrote: > On Thu, Mar 19, 2020 at 02:54:11PM +0100, David Hildenbrand wrote: >> Why does the balloon driver not support VIRTIO_F_IOMMU_PLATFORM? It is >> absolutely not clear to me. The introducing commit mentioned that it >> "bypasses DMA". I fail to see that.

Re: Qemu API documentation

2020-03-20 Thread Priyamvad Acharya
Thansk, I will check it out. To make my device I have used following link as reference https://devkail.wordpress.com/2014/12/16/emulation-of-des-encryption-device-in-qemu/ Also I have shared all the necessary files in previous mails involved in the development and testing process of device. Ple

Re: [PATCH v4 02/18] qapi/qapi-schema.json: Put headers in their own doc-comment blocks

2020-03-20 Thread Markus Armbruster
Peter Maydell writes: > Our current QAPI doc-comment markup allows section headers > (introduced with a leading '=' or '==') anywhere in any documentation > comment. This works for texinfo because the texi generator simply > prints a texinfo heading directive at that point in the output > stream

[Bug 1868221] Re: /usr/share/applications/qemu.desktop should have an "Exec=" key.

2020-03-20 Thread Daniel Berrange
Adding an exec field would not be right, because QEMU can't simply be launched from the desktop without any arguments. There needs to be a long string of arguments given that are different for every QEMU that is launched. The only viable way to actually launch QEMU is interactively from the termina

[PATCH] acpi: add acpi=OnOffAuto machine property to x86 and arm virt

2020-03-20 Thread Gerd Hoffmann
Remove the global acpi_enabled bool and replace it with an acpi OnOffAuto machine property. qemu throws an error now if you use -no-acpi while the machine type you are using doesn't support acpi in the first place. Signed-off-by: Gerd Hoffmann --- include/hw/acpi/acpi.h | 1 - include/hw/arm

Re: [QUESTION] Getting configure options for a given QEMU executable?

2020-03-20 Thread Daniel P . Berrangé
On Fri, Mar 20, 2020 at 07:11:03AM +0100, Aleksandar Markovic wrote: > Hi, > > Given a QEMU executable, is there a way to find out the configure options > it was built with? No, you need to get the original build logs. The binary should contain the full build version (ie the QEMU version and the

Re: [PATCH 0/3] iotests: Fix intermittent 030 hang

2020-03-20 Thread Philippe Mathieu-Daudé
On 3/13/20 9:36 AM, Kevin Wolf wrote: Peter ran into a 030 hang while testing a pull request. This turned out to be two bugs in the test suite at once: First was the test failing because a timeout was apparently too short, second was that the timeout would actually cause the test to hang instead

Re: [PULL 0/1] Slirp patches

2020-03-20 Thread Peter Maydell
On Thu, 19 Mar 2020 at 11:33, Marc-André Lureau wrote: > > The following changes since commit f57587c7d47b35b2d9b31def3a74d81bdb5475d7: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2020-03-17' > into staging (2020-03-19 10:18:07 +) > > are available in the Git repository

Re: [PATCH 2/3] python/qemu: Kill QEMU process if 'quit' doesn't work

2020-03-20 Thread Philippe Mathieu-Daudé
On 3/13/20 9:36 AM, Kevin Wolf wrote: With a QEMU bug, it can happen that the QEMU process doesn't react to a 'quit' QMP command. If we got an exception during previous QMP communication (e.g. iotests Timeout expiring), we could also be in an inconsistent state where after sending 'quit' we immed

Re: Qemu API documentation

2020-03-20 Thread Peter Maydell
On Fri, 20 Mar 2020 at 09:39, Priyamvad Acharya wrote: > > Thansk, I will check it out. > > To make my device I have used following link as reference > > https://devkail.wordpress.com/2014/12/16/emulation-of-des-encryption-device-in-qemu/ Watch out, because that blog is six years old. Much of QEM

Re: [PATCH 3/3] iotests: Increase pause_wait() timeout

2020-03-20 Thread Philippe Mathieu-Daudé
On 3/13/20 9:36 AM, Kevin Wolf wrote: Waiting for only 1 second proved to be too short on a loaded system, resulting in false positives when testing pull requests. Increase the timeout a bit to make this less likely. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/iotests.py | 2 +- 1 file

Re: Qemu API documentation

2020-03-20 Thread Priyamvad Acharya
So, is there any up to date blog from where I can get a reference about device modelling development On Fri, 20 Mar 2020 at 15:46, Peter Maydell wrote: > On Fri, 20 Mar 2020 at 09:39, Priyamvad Acharya > wrote: > > > > Thansk, I will check it out. > > > > To make my device I have used following

[PATCH RESEND v3 0/4] virtio-pci: enable blk and scsi multi-queue by default

2020-03-20 Thread Stefan Hajnoczi
v3: * Add new performance results that demonstrate the scalability * Mention that this is PCI-specific [Cornelia] v2: * Let the virtio-DEVICE-pci device select num-queues because the optimal multi-queue configuration may differ between virtio-pci, virtio-mmio, and virtio-ccw [Cornelia] En

[PATCH RESEND v3 2/4] virtio-scsi: default num_queues to -smp N

2020-03-20 Thread Stefan Hajnoczi
Automatically size the number of virtio-scsi-pci, vhost-scsi-pci, and vhost-user-scsi-pci request virtqueues to match the number of vCPUs. Other transports continue to default to 1 request virtqueue. A 1:1 virtqueue:vCPU mapping ensures that completion interrupts are handled on the same vCPU that

[PATCH RESEND v3 1/4] virtio-scsi: introduce a constant for fixed virtqueues

2020-03-20 Thread Stefan Hajnoczi
The event and control virtqueues are always present, regardless of the multi-queue configuration. Define a constant so that virtqueue number calculations are easier to read. Signed-off-by: Stefan Hajnoczi Reviewed-by: Cornelia Huck --- hw/scsi/vhost-user-scsi.c | 2 +- hw/scsi/virtio-scs

[PATCH RESEND v3 3/4] virtio-blk: default num_queues to -smp N

2020-03-20 Thread Stefan Hajnoczi
Automatically size the number of virtio-blk-pci request virtqueues to match the number of vCPUs. Other transports continue to default to 1 request virtqueue. A 1:1 virtqueue:vCPU mapping ensures that completion interrupts are handled on the same vCPU that submitted the request. No IPI is necessa

Re: [PATCH v5 1/4] s390x: fix memleaks in cpu_finalize

2020-03-20 Thread Cornelia Huck
On Sat, 14 Mar 2020 16:47:27 +0800 Pan Nengyuan wrote: > This patch fix memleaks when we call tests/qtest/cpu-plug-test on s390x. The > leak stack is as follow: > > Direct leak of 48 byte(s) in 1 object(s) allocated from: > #0 0x7fb43c7cd970 in __interceptor_calloc (/lib64/libasan.so.5+0xef

[PATCH RESEND v3 4/4] vhost-user-blk: default num_queues to -smp N

2020-03-20 Thread Stefan Hajnoczi
Automatically size the number of request virtqueues to match the number of vCPUs. This ensures that completion interrupts are handled on the same vCPU that submitted the request. No IPI is necessary to complete an I/O request and performance is improved. Signed-off-by: Stefan Hajnoczi Reviewed-

[PULL v2 00/13] target: Add the Renesas RX architecture

2020-03-20 Thread Philippe Mathieu-Daudé
commit 4dd6517e369828171290b65e11f6a45aeeed15af: Merge remote-tracking branch 'remotes/ehabkost/tags/x86-and-machine-pull-request' into staging (2020-03-19 14:22:46 +) are available in the Git repository at: https://gitlab.com/philmd/qemu.git tags/target_renesas_rx-20200320

[PULL v2 05/13] target/rx: CPU definitions

2020-03-20 Thread Philippe Mathieu-Daudé
From: Yoshinori Sato Reviewed-by: Richard Henderson Signed-off-by: Yoshinori Sato Signed-off-by: Richard Henderson [PMD: Use newer QOM style, split cpu-qom.h, restrict access to extable array, use rx_cpu_tlb_fill() extracted from patch of Yoshinori Sato 'Convert to CPUClass::tlb_fill', call

[PATCH] virtio-iommu: depend on PCI

2020-03-20 Thread Paolo Bonzini
The virtio-iommu device attaches itself to a PCI bus, so it makes no sense to include it unless PCI is supported---and in fact compilation fails without this change. Reported-by: Gerd Hoffmann Signed-off-by: Paolo Bonzini --- hw/virtio/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(

Re: [PATCH 00/13] microvm: add acpi support

2020-03-20 Thread Paolo Bonzini
On 20/03/20 09:32, Gerd Hoffmann wrote: > Hmm, seems we should have that for better regression testing. > master branch doesn't build with pc+q35+isapc turned off: > > LINKx86_64-softmmu/qemu-system-x86_64 > hw/virtio/virtio-iommu.o: In function `virtio_iommu_get_bdf': > /home/kraxel/project

Re: [QUESTION] Getting configure options for a given QEMU executable?

2020-03-20 Thread Philippe Mathieu-Daudé
On 3/20/20 11:03 AM, Daniel P. Berrangé wrote: On Fri, Mar 20, 2020 at 07:11:03AM +0100, Aleksandar Markovic wrote: Hi, Given a QEMU executable, is there a way to find out the configure options it was built with? No, you need to get the original build logs. The binary should contain the full

Re: [PATCH] virtio-iommu: depend on PCI

2020-03-20 Thread Auger Eric
Hi Paolo On 3/20/20 11:41 AM, Paolo Bonzini wrote: > The virtio-iommu device attaches itself to a PCI bus, so it makes > no sense to include it unless PCI is supported---and in fact > compilation fails without this change. with the --- cleanup (?) Acked-by: Eric Auger Thanks Eric > > Repor

Re: [PATCH RESEND v3 2/4] virtio-scsi: default num_queues to -smp N

2020-03-20 Thread Cornelia Huck
On Fri, 20 Mar 2020 10:30:39 + Stefan Hajnoczi wrote: > Automatically size the number of virtio-scsi-pci, vhost-scsi-pci, and > vhost-user-scsi-pci request virtqueues to match the number of vCPUs. > Other transports continue to default to 1 request virtqueue. > > A 1:1 virtqueue:vCPU mapping

Re: [PATCH] acpi: add acpi=OnOffAuto machine property to x86 and arm virt

2020-03-20 Thread Philippe Mathieu-Daudé
On 3/20/20 11:01 AM, Gerd Hoffmann wrote: Remove the global acpi_enabled bool and replace it with an acpi OnOffAuto machine property. qemu throws an error now if you use -no-acpi while the machine type you are using doesn't support acpi in the first place. Suggested-by: Paolo Bonzini Signe

Re: [PATCH] misc: fix __COUNTER__ macro to be referenced properly

2020-03-20 Thread Stefan Hajnoczi
On Thu, Mar 19, 2020 at 09:19:24AM -0700, dnbrd...@gmail.com wrote: > From: danbrodsky > > - __COUNTER__ doesn't work with ## concat > - replaced ## with glue() macro so __COUNTER__ is evaluated > > Signed-off-by: danbrodsky > --- > include/qemu/lockable.h | 2 +- > include/qemu/rcu.h | 2

Re: [PATCH] acpi: add acpi=OnOffAuto machine property to x86 and arm virt

2020-03-20 Thread Paolo Bonzini
On 20/03/20 11:01, Gerd Hoffmann wrote: > Remove the global acpi_enabled bool and replace it with an > acpi OnOffAuto machine property. > > qemu throws an error now if you use -no-acpi while the machine > type you are using doesn't support acpi in the first place. > > Signed-off-by: Gerd Hoffmann

Re: [PATCH] virtio-iommu: depend on PCI

2020-03-20 Thread Paolo Bonzini
On 20/03/20 11:54, Auger Eric wrote: >> The virtio-iommu device attaches itself to a PCI bus, so it makes >> no sense to include it unless PCI is supported---and in fact >> compilation fails without this change. > with the --- cleanup (?) Fails if PCI is not included but virtio-iommu is. Paolo >

Re: Qemu API documentation

2020-03-20 Thread Alex Bennée
Priyamvad Acharya writes: > Thansk, I will check it out. > > To make my device I have used following link as reference > > https://devkail.wordpress.com/2014/12/16/emulation-of-des-encryption-device-in-qemu/ > > Also I have shared all the necessary files > in previous mails involved in the deve

Re: [PATCH] virtio-iommu: depend on PCI

2020-03-20 Thread Philippe Mathieu-Daudé
On 3/20/20 11:41 AM, Paolo Bonzini wrote: The virtio-iommu device attaches itself to a PCI bus, so it makes no sense to include it unless PCI is supported---and in fact compilation fails without this change. Reported-by: Gerd Hoffmann Signed-off-by: Paolo Bonzini --- hw/virtio/Kconfig | 2 +-

Re: [PATCH] virtio-iommu: depend on PCI

2020-03-20 Thread Auger Eric
Hi Philippe, On 3/20/20 12:26 PM, Philippe Mathieu-Daudé wrote: > On 3/20/20 11:41 AM, Paolo Bonzini wrote: >> The virtio-iommu device attaches itself to a PCI bus, so it makes >> no sense to include it unless PCI is supported---and in fact >> compilation fails without this change. >> >> Reported-

Re: [PATCH-for-5.0 v2 2/4] tests/test-util-sockets: Skip test on non-x86 Travis containers

2020-03-20 Thread Cornelia Huck
On Wed, 18 Mar 2020 23:27:15 +0100 Philippe Mathieu-Daudé wrote: > Similarly to commit 4f370b1098, test-util-sockets fails in > restricted non-x86 Travis containers since they apparently > blacklisted some required system calls there. Is "they" == "Travis admins"? Can we get them to remove those

Re: [PATCH v2 4/4] .travis.yml: Add a KVM-only s390x job

2020-03-20 Thread Cornelia Huck
On Wed, 18 Mar 2020 23:27:17 +0100 Philippe Mathieu-Daudé wrote: > Add a job to build QEMU on s390x with TCG disabled, so > this configuration won't bitrot over time. > > This job is quick, running check-unit: Ran for 4 min 48 sec > https://travis-ci.org/github/philmd/qemu/jobs/663659486 > > Si

[RFC PATCH for 5.0] configure: disable MTTCG for MIPS guests

2020-03-20 Thread Alex Bennée
While debugging check-acceptance failures I found an instability in the mips64el test case. Briefly the test case: retry.py -n 100 -c -- ./mips64el-softmmu/qemu-system-mips64el \ -display none -vga none -serial mon:stdio \ -machine malta -kernel ./vmlinux-4.7.0-rc1.I6400 \ -cpu I6400

Re: [PATCH] hw/rdma/vmw/pvrdma_dev_ring: Replace strncpy with pstrcpy

2020-03-20 Thread Yuval Shaia
Thanks, Reviewed-by: Yuval Shaia On Wed, 18 Mar 2020 at 15:49, Julia Suvorova wrote: > ring->name is defined as 'char name[MAX_RING_NAME_SZ]'. Replace untruncated > strncpy with QEMU function. > This case prevented QEMU from compiling with --enable-sanitizers. > > Signed-off-by: Julia Suvorova

Re: [PATCH v4 0/2] add new options to set smbios type 4 fields

2020-03-20 Thread Paolo Bonzini
On 20/03/20 02:29, Heyi Guo wrote: > > On 2020/3/19 22:46, Igor Mammedov wrote: >> On Wed, 18 Mar 2020 14:48:18 +0800 >> Heyi Guo wrote: >> >>> Common VM users sometimes care about CPU speed, so we add two new >>> options to allow VM vendors to present CPU speed to their users. >>> Normally these

RE: [PATCH v3 02/10] fw_cfg: Migrate ACPI table mr sizes separately

2020-03-20 Thread Shameerali Kolothum Thodi
> -Original Message- > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: 19 March 2020 17:51 > To: Shameerali Kolothum Thodi > Cc: qemu-devel@nongnu.org; qemu-...@nongnu.org; > eric.au...@redhat.com; imamm...@redhat.com; peter.mayd...@linaro.org; > shannon.zha...@gmail.com; xiao

Re: [PATCH 2/2] hw/rdma: avoid suspicious strncpy() use

2020-03-20 Thread Yuval Shaia
On Mon, 16 Mar 2020 at 18:07, Stefan Hajnoczi wrote: > gcc (GCC) 9.2.1 20190827 (Red Hat 9.2.1-1) with sanitizers enabled > reports the following error: > > CC x86_64-softmmu/hw/rdma/vmw/pvrdma_dev_ring.o > In file included from /usr/include/string.h:495, > from include/qe

[Bug 1868221] Re: /usr/share/applications/qemu.desktop should have an "Exec=" key.

2020-03-20 Thread Daniel Berrange
Note that QEMU sets the NoDisplay=true property to tell desktops not to display this entry. I don't think KDE should be warning about missing Exec entry in this case. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launc

[PATCH v6 0/7] reference implementation of RSS and hash report

2020-03-20 Thread Yuri Benditovich
Support for VIRTIO_NET_F_RSS and VIRTIO_NET_F_HASH_REPORT features in QEMU for reference purpose. Implements Toeplitz hash calculation for incoming packets according to configuration provided by driver. Uses calculated hash for decision on receive virtqueue and/or reports the hash in the virtio hea

[PATCH v6 4/7] tap: allow extended virtio header with hash info

2020-03-20 Thread Yuri Benditovich
Signed-off-by: Yuri Benditovich --- net/tap.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/net/tap.c b/net/tap.c index 6207f61f84..47de7fdeb6 100644 --- a/net/tap.c +++ b/net/tap.c @@ -63,6 +63,14 @@ typedef struct TAPState { Notifier exit; } TAPState; +

[PATCH v6 7/7] virtio-net: add migration support for RSS and hash report

2020-03-20 Thread Yuri Benditovich
Save and restore RSS/hash report configuration. Signed-off-by: Yuri Benditovich --- hw/net/virtio-net.c | 37 + 1 file changed, 37 insertions(+) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index a0614ad4e6..7de7587abd 100644 --- a/hw/net/virtio-net

[PATCH v6 2/7] virtio-net: implement RSS configuration command

2020-03-20 Thread Yuri Benditovich
Optionally report RSS feature. Handle RSS configuration command and keep RSS parameters in virtio-net device context. Signed-off-by: Yuri Benditovich --- hw/net/trace-events| 3 + hw/net/virtio-net.c| 189 + include/hw/virtio/virtio-net.h

[PATCH v6 1/7] virtio-net: introduce RSS and hash report features

2020-03-20 Thread Yuri Benditovich
Signed-off-by: Yuri Benditovich --- hw/net/virtio-net.c | 65 + 1 file changed, 65 insertions(+) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index 3627bb1717..90b01221e9 100644 --- a/hw/net/virtio-net.c +++ b/hw/net/virtio-net.c @@ -71,6 +71

[PATCH v6 3/7] virtio-net: implement RX RSS processing

2020-03-20 Thread Yuri Benditovich
If VIRTIO_NET_F_RSS negotiated and RSS is enabled, process incoming packets, calculate packet's hash and place the packet into respective RX virtqueue. Signed-off-by: Yuri Benditovich --- hw/net/virtio-net.c| 88 +- include/hw/virtio/virtio-net.h | 1

[PATCH v6 6/7] vmstate.h: provide VMSTATE_VARRAY_UINT16_ALLOC macro

2020-03-20 Thread Yuri Benditovich
Similar to VMSTATE_VARRAY_UINT32_ALLOC, but the size is 16-bit field. Signed-off-by: Michael S. Tsirkin Signed-off-by: Yuri Benditovich --- include/migration/vmstate.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index

[PATCH v6 5/7] virtio-net: reference implementation of hash report

2020-03-20 Thread Yuri Benditovich
Suggest VIRTIO_NET_F_HASH_REPORT if specified in device parameters. If the VIRTIO_NET_F_HASH_REPORT is set, the device extends configuration space. If the feature is negotiated, the packet layout is extended to accomodate the hash information. In this case deliver packet's hash value and report typ

[PATCH v3 0/2] Replaced locks with lock guard macros

2020-03-20 Thread dnbrdsky
From: Daniel Brodsky This patch set adds: - a fix for lock guard macros so they can be used multiple times in the same function - replacement of locks with lock guards where appropriate v2 -> v3: - added __COUNTER__ fix for additional lock guard macro - added missing include header in platform.c

[PATCH v3 1/2] lockable: fix __COUNTER__ macro to be referenced properly

2020-03-20 Thread dnbrdsky
From: Daniel Brodsky - __COUNTER__ doesn't work with ## concat - replaced ## with glue() macro so __COUNTER__ is evaluated Fixes: 3284c3ddc4 Signed-off-by: Daniel Brodsky --- include/qemu/lockable.h | 4 ++-- include/qemu/rcu.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) di

Re: [PATCH v2 2/2] lockable: replaced locks with lock guard macros where appropriate

2020-03-20 Thread Paolo Bonzini
On 20/03/20 00:34, dnbrd...@gmail.com wrote: > index 682abd8e09..89f8a656a4 100644 > --- a/block/iscsi.c > +++ b/block/iscsi.c > @@ -1086,7 +1086,7 @@ static BlockAIOCB *iscsi_aio_ioctl(BlockDriverState *bs, > acb->task->expxferlen = acb->ioh->dxfer_len; > > data.size = 0; > -qemu_m

[PATCH v3 2/2] lockable: replaced locks with lock guard macros where appropriate

2020-03-20 Thread dnbrdsky
From: Daniel Brodsky - ran regexp "qemu_mutex_lock\(.*\).*\n.*if" to find targets - replaced result with QEMU_LOCK_GUARD if all unlocks at function end - replaced result with WITH_QEMU_LOCK_GUARD if unlock not at end Signed-off-by: Daniel Brodsky --- block/iscsi.c | 11 +++--- bloc

Re: [PULL 21/36] hw/arm/allwinner-h3: add Boot ROM support

2020-03-20 Thread Peter Maydell
On Thu, 12 Mar 2020 at 16:45, Peter Maydell wrote: > > From: Niek Linnenbank > > A real Allwinner H3 SoC contains a Boot ROM which is the > first code that runs right after the SoC is powered on. > The Boot ROM is responsible for loading user code (e.g. a bootloader) > from any of the supported e

Re: [PULL 0/1] Vga 20200320 patches

2020-03-20 Thread Peter Maydell
ilable in the Git repository at: > > git://git.kraxel.org/qemu tags/vga-20200320-pull-request > > for you to fetch changes up to 02501fc39381c4dabaf6becdd12c2a4754c3847c: > > compat: disable edid on correc

Re: [PATCH v2 2/2] lockable: replaced locks with lock guard macros where appropriate

2020-03-20 Thread Daniel Brodsky
On Fri, Mar 20, 2020 at 5:06 AM Paolo Bonzini wrote: > > On 20/03/20 00:34, dnbrd...@gmail.com wrote: > > index 682abd8e09..89f8a656a4 100644 > > --- a/block/iscsi.c > > +++ b/block/iscsi.c > > @@ -1086,7 +1086,7 @@ static BlockAIOCB *iscsi_aio_ioctl(BlockDriverState > > *bs, > > acb->task->

Re: [PATCH 1/2] hw/rdma: Cosmetic change - no need for two sge arrays

2020-03-20 Thread Yuval Shaia
On Mon, 16 Mar 2020 at 15:30, Marcel Apfelbaum wrote: > Hi Yuval, > > On 3/7/20 2:56 PM, Yuval Shaia wrote: > > The function build_host_sge_array uses two sge arrays, one for input and > > one for output. > > Since the size of the two arrays is the same, the function can write > > directly to the

[PATCH v4 2/2] lockable: replaced locks with lock guard macros where appropriate

2020-03-20 Thread dnbrdsky
From: Daniel Brodsky - ran regexp "qemu_mutex_lock\(.*\).*\n.*if" to find targets - replaced result with QEMU_LOCK_GUARD if all unlocks at function end - replaced result with WITH_QEMU_LOCK_GUARD if unlock not at end Signed-off-by: Daniel Brodsky --- block/iscsi.c | 7 ++ block/nf

[PATCH v4 1/2] lockable: fix __COUNTER__ macro to be referenced properly

2020-03-20 Thread dnbrdsky
From: Daniel Brodsky - __COUNTER__ doesn't work with ## concat - replaced ## with glue() macro so __COUNTER__ is evaluated Fixes: 3284c3ddc4 Signed-off-by: Daniel Brodsky --- include/qemu/lockable.h | 4 ++-- include/qemu/rcu.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) di

[PATCH v4 0/2] Replaced locks with lock guard macros

2020-03-20 Thread dnbrdsky
From: Daniel Brodsky This patch set adds: - a fix for lock guard macros so they can be used multiple times in the same function - replacement of locks with lock guards where appropriate v3 -> v4: - removed unneeded unlocks from areas where lock guards are now used - dropped change to lock guard

Re: [PATCH v3 2/2] lockable: replaced locks with lock guard macros where appropriate

2020-03-20 Thread Dr. David Alan Gilbert
* dnbrd...@gmail.com (dnbrd...@gmail.com) wrote: > From: Daniel Brodsky > > - ran regexp "qemu_mutex_lock\(.*\).*\n.*if" to find targets > - replaced result with QEMU_LOCK_GUARD if all unlocks at function end > - replaced result with WITH_QEMU_LOCK_GUARD if unlock not at end > > Signed-off-by: D

Re: [PATCH v3 2/2] lockable: replaced locks with lock guard macros where appropriate

2020-03-20 Thread Daniel Brodsky
On Fri, Mar 20, 2020 at 5:34 AM Dr. David Alan Gilbert wrote: > > * dnbrd...@gmail.com (dnbrd...@gmail.com) wrote: > > From: Daniel Brodsky > > > > - ran regexp "qemu_mutex_lock\(.*\).*\n.*if" to find targets > > - replaced result with QEMU_LOCK_GUARD if all unlocks at function end > > - replaced

Re: [PATCH v3 2/2] lockable: replaced locks with lock guard macros where appropriate

2020-03-20 Thread Dr. David Alan Gilbert
* Daniel Brodsky (dnbrd...@gmail.com) wrote: > On Fri, Mar 20, 2020 at 5:34 AM Dr. David Alan Gilbert > wrote: > > > > * dnbrd...@gmail.com (dnbrd...@gmail.com) wrote: > > > From: Daniel Brodsky > > > > > > - ran regexp "qemu_mutex_lock\(.*\).*\n.*if" to find targets > > > - replaced result with

[PATCH] monitor/hmp-cmds: fix bad indentation in 'info migrate_parameters' cmd output

2020-03-20 Thread Mao Zhongyi
run: (qemu) info migrate_parameters announce-initial: 50 ms ... announce-max: 550 ms multifd-compression: none xbzrle-cache-size: 4194304 max-postcopy-bandwidth: 0 tls-authz: '(null)' The last line seems a bit out of place, fix it. Signed-off-by: Mao Zhongyi --- monitor/hmp-cmds.c | 2 +- 1 fi

Re: [PULL 037/108] virtiofsd: passthrough_ll: add dirp_map to hide lo_dirp pointers

2020-03-20 Thread Peter Maydell
On Thu, 23 Jan 2020 at 19:41, Dr. David Alan Gilbert (git) wrote: > > From: Stefan Hajnoczi > > Do not expose lo_dirp pointers to clients. > > Signed-off-by: Stefan Hajnoczi > Reviewed-by: Philippe Mathieu-Daudé > Signed-off-by: Dr. David Alan Gilbert > --- > tools/virtiofsd/passthrough_ll.c

  1   2   3   >