Re: [PATCH v3 1/6] virtio-net: introduce RSS and hash report features

2020-03-12 Thread Yuri Benditovich
On Wed, Mar 11, 2020 at 10:19 PM Michael S. Tsirkin wrote: > On Wed, Mar 11, 2020 at 03:57:58PM +0200, Yuri Benditovich wrote: > > > > > > On Wed, Mar 11, 2020 at 3:47 PM Michael S. Tsirkin > wrote: > > > > On Wed, Mar 11, 2020 at 02:35:13PM +0200, Yuri Benditovich wrote: > > > Signed-of

Re: [PATCH v4 3/4] Introduce the NVMM impl

2020-03-12 Thread Maxime Villard
Le 11/03/2020 à 22:44, Paolo Bonzini a écrit : > On 11/03/20 22:21, Maxime Villard wrote: >>> Yes, you don't know how long that run would take. I don't know about >>> NVMM but for KVM it may even never leave if the guest is in HLT state. >> Ok, I see, thanks. >> >> In NVMM the runs are short > >

Re: [PATCH v3 1/6] virtio-net: introduce RSS and hash report features

2020-03-12 Thread Michael S. Tsirkin
On Thu, Mar 12, 2020 at 09:02:38AM +0200, Yuri Benditovich wrote: > >     > +#define virtio_net_config virtio_net_config_with_rss > > > >     Do we have to? Let's just tweak code to do the right thing... > > > > > > Are we going to update the virtio_net some time? > > If

Re: [PATCH v8 02/10] scripts: add coccinelle script to use auto propagated errp

2020-03-12 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 11.03.2020 17:41, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy writes: >> >>> 11.03.2020 12:38, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: > 09.03.2020 12:56, Markus Armbruster wrote: >> Suggest >> >

Re: [PATCH v3 5/6] virtio-net: add migration support for RSS and hast report

2020-03-12 Thread Yuri Benditovich
On Wed, Mar 11, 2020 at 10:21 PM Michael S. Tsirkin wrote: > On Wed, Mar 11, 2020 at 04:00:44PM +0200, Yuri Benditovich wrote: > > > > > > On Wed, Mar 11, 2020 at 3:48 PM Michael S. Tsirkin > wrote: > > > > On Wed, Mar 11, 2020 at 02:35:17PM +0200, Yuri Benditovich wrote: > > > Save and

Re: [PATCH v8 02/10] scripts: add coccinelle script to use auto propagated errp

2020-03-12 Thread Vladimir Sementsov-Ogievskiy
12.03.2020 10:23, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: 11.03.2020 17:41, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: 11.03.2020 12:38, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: 09.03.2020 12:56, Markus Armbruster wrote: Su

Re: [PATCH v3 1/6] virtio-net: introduce RSS and hash report features

2020-03-12 Thread Yuri Benditovich
On Thu, Mar 12, 2020 at 9:21 AM Michael S. Tsirkin wrote: > On Thu, Mar 12, 2020 at 09:02:38AM +0200, Yuri Benditovich wrote: > > > > +#define virtio_net_config virtio_net_config_with_rss > > > > > > Do we have to? Let's just tweak code to do the right thing... > > > > >

[RFC for Linux] virtio_balloon: Add VIRTIO_BALLOON_F_THP_ORDER to handle THP spilt issue

2020-03-12 Thread Hui Zhu
If the guest kernel has many fragmentation pages, use virtio_balloon will split THP of QEMU when it calls MADV_DONTNEED madvise to release the balloon pages. This is an example in a VM with 1G memory 1CPU: cat /proc/meminfo | grep AnonHugePages: AnonHugePages: 0 kB usemem --punch-holes -s

[RFC for QEMU] virtio-balloon: Add option thp-order to set VIRTIO_BALLOON_F_THP_ORDER

2020-03-12 Thread Hui Zhu
If the guest kernel has many fragmentation pages, use virtio_balloon will split THP of QEMU when it calls MADV_DONTNEED madvise to release the balloon pages. Set option thp-order to on will open flags VIRTIO_BALLOON_F_THP_ORDER. It will set balloon size to THP size to handle the THP split issue. S

Re: [PATCH v3 2/2] spapr: Enable virtio iommu_platform=on by default

2020-03-12 Thread Greg Kurz
On Thu, 12 Mar 2020 15:14:06 +1100 Alexey Kardashevskiy wrote: > > > On 10/03/2020 21:43, Greg Kurz wrote: > > On Thu, 5 Mar 2020 12:59:03 +0100 > > Greg Kurz wrote: > > > >> On Thu, 5 Mar 2020 15:30:09 +1100 > >> David Gibson wrote: > >> > >>> Traditionally, virtio devices don't do DMA by

Re: [RFC for Linux] virtio_balloon: Add VIRTIO_BALLOON_F_THP_ORDER to handle THP spilt issue

2020-03-12 Thread Michael S. Tsirkin
On Thu, Mar 12, 2020 at 03:49:54PM +0800, Hui Zhu wrote: > If the guest kernel has many fragmentation pages, use virtio_balloon > will split THP of QEMU when it calls MADV_DONTNEED madvise to release > the balloon pages. > This is an example in a VM with 1G memory 1CPU: > cat /proc/meminfo | grep A

[PATCH] block/io: fix bdrv_co_do_copy_on_readv

2020-03-12 Thread Vladimir Sementsov-Ogievskiy
Prior to 1143ec5ebf4 it was OK to qemu_iovec_from_buf() from aligned-up buffer to original qiov, as qemu_iovec_from_buf() will stop at qiov end anyway. But after 1143ec5ebf4 we assume that bdrv_co_do_copy_on_readv works on part of original qiov, defined by qiov_offset and bytes. So we must not tou

Re: [PATCH v3 5/6] virtio-net: add migration support for RSS and hast report

2020-03-12 Thread Michael S. Tsirkin
On Thu, Mar 12, 2020 at 09:37:06AM +0200, Yuri Benditovich wrote: > > > On Wed, Mar 11, 2020 at 10:21 PM Michael S. Tsirkin wrote: > > On Wed, Mar 11, 2020 at 04:00:44PM +0200, Yuri Benditovich wrote: > > > > > > On Wed, Mar 11, 2020 at 3:48 PM Michael S. Tsirkin > wrote: >

Re: [RFC for QEMU] virtio-balloon: Add option thp-order to set VIRTIO_BALLOON_F_THP_ORDER

2020-03-12 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1583999395-9131-2-git-send-email-teawa...@gmail.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin

Re: [PATCH v3 1/6] virtio-net: introduce RSS and hash report features

2020-03-12 Thread Michael S. Tsirkin
On Thu, Mar 12, 2020 at 09:42:20AM +0200, Yuri Benditovich wrote: > > > On Thu, Mar 12, 2020 at 9:21 AM Michael S. Tsirkin wrote: > > On Thu, Mar 12, 2020 at 09:02:38AM +0200, Yuri Benditovich wrote: > >     >     > +#define virtio_net_config virtio_net_config_with_rss > >     > >

Re: [RFC for QEMU] virtio-balloon: Add option thp-order to set VIRTIO_BALLOON_F_THP_ORDER

2020-03-12 Thread Michael S. Tsirkin
On Thu, Mar 12, 2020 at 03:49:55PM +0800, Hui Zhu wrote: > If the guest kernel has many fragmentation pages, use virtio_balloon > will split THP of QEMU when it calls MADV_DONTNEED madvise to release > the balloon pages. > Set option thp-order to on will open flags VIRTIO_BALLOON_F_THP_ORDER. > It

Re: [PATCH] linux-user: syscall: ioctls: support DRM_IOCTL_VERSION

2020-03-12 Thread Chen Gang
Thank you very much for your reply. :) DRM_IOCTL_VERSION has to be a special one, but my patch really need be improved. The string pointers should be translated, but the new string buffers need not be allocated. I will try to send patch v2 within this week end. DRM_IOCTL_* really have many comma

Re: [PATCH v9 02/15] s390x: protvirt: Support unpack facility

2020-03-12 Thread Christian Borntraeger
On 11.03.20 14:21, Janosch Frank wrote: [...] > diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c > index b81942e1e6f9002e..98df89e62c25f583 100644 > --- a/hw/s390x/ipl.c > +++ b/hw/s390x/ipl.c > @@ -27,6 +27,7 @@ > #include "hw/s390x/vfio-ccw.h" > #include "hw/s390x/css.h" > #include "hw/s390x/eb

Re: [RFC for Linux] virtio_balloon: Add VIRTIO_BALLOON_F_THP_ORDER to handle THP spilt issue

2020-03-12 Thread David Hildenbrand
On 12.03.20 08:49, Hui Zhu wrote: > If the guest kernel has many fragmentation pages, use virtio_balloon > will split THP of QEMU when it calls MADV_DONTNEED madvise to release > the balloon pages. > This is an example in a VM with 1G memory 1CPU: > cat /proc/meminfo | grep AnonHugePages: > AnonHug

[Bug 1866870] Re: KVM Guest pauses after upgrade to Ubuntu 20.04

2020-03-12 Thread Christian Ehrhardt 
Thank you @tstrike: In your logs I see a bunch of qemu warnings right at the beginning: 2020-02-12T15:09:37.773025Z qemu-system-x86_64: warning: host doesn't support requested feature: MSR(48FH).vmx-exit-load-perf-global-ctrl [bit 12] 2020-02-12T15:09:37.773107Z qemu-system-x86_64: warning: host

Re: [PATCH] linux-user: Add an argument QEMU_MMAP_BASE to set custom mmap base address in qemu user mode

2020-03-12 Thread Laurent Vivier
Le 09/03/2020 à 19:07, Lirong Yuan a écrit : > > On Mon, Mar 2, 2020 at 11:51 AM Lirong Yuan > wrote: > > On Mon, Mar 2, 2020 at 10:39 AM Laurent Vivier > wrote: > > > > Le 02/03/2020 à 18:53, Lirong Yuan a écrit : > > > On

Re: [PATCH v9 03/15] s390x: protvirt: Add migration blocker

2020-03-12 Thread Christian Borntraeger
On 11.03.20 14:21, Janosch Frank wrote: > Migration is not yet supported. > > Signed-off-by: Janosch Frank > Reviewed-by: David Hildenbrand > --- > hw/s390x/s390-virtio-ccw.c | 18 ++ > 1 file changed, 18 insertions(+) > > diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s

Re: [RFC for Linux] virtio_balloon: Add VIRTIO_BALLOON_F_THP_ORDER to handle THP spilt issue

2020-03-12 Thread Michael S. Tsirkin
On Thu, Mar 12, 2020 at 09:37:32AM +0100, David Hildenbrand wrote: > 2. You are essentially stealing THPs in the guest. So the fastest > mapping (THP in guest and host) is gone. The guest won't be able to make > use of THP where it previously was able to. I can imagine this implies a > performance

[PATCH v2] target/i386: set the CPUID level to 0x14 on old machine-type

2020-03-12 Thread Luwei Kang
The CPUID level need to be set to 0x14 manually on old machine-type if Intel PT is enabled in guest. E.g. the CPUID[0].EAX(level)=7 and CPUID[7].EBX[25](intel-pt)=1 when the Qemu with "-machine pc-i440fx-3.1 -cpu qemu64,+intel-pt" parameter. Some Intel PT capabilities are exposed by leaf 0x14 and

Re: [RFC for Linux] virtio_balloon: Add VIRTIO_BALLOON_F_THP_ORDER to handle THP spilt issue

2020-03-12 Thread David Hildenbrand
On 12.03.20 09:47, Michael S. Tsirkin wrote: > On Thu, Mar 12, 2020 at 09:37:32AM +0100, David Hildenbrand wrote: >> 2. You are essentially stealing THPs in the guest. So the fastest >> mapping (THP in guest and host) is gone. The guest won't be able to make >> use of THP where it previously was ab

[PATCH v9 08/10] TPM: introduce ERRP_AUTO_PROPAGATE

2020-03-12 Thread Vladimir Sementsov-Ogievskiy
If we want to add some info to errp (by error_prepend() or error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro. Otherwise, this info will not be added when errp == &error_fatal (the program will exit prior to the error_append_hint() or error_prepend() call). Fix such cases. If we want

[PATCH v9 06/10] fw_cfg: introduce ERRP_AUTO_PROPAGATE

2020-03-12 Thread Vladimir Sementsov-Ogievskiy
If we want to add some info to errp (by error_prepend() or error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro. Otherwise, this info will not be added when errp == &error_fatal (the program will exit prior to the error_append_hint() or error_prepend() call). Fix such cases. If we want

[PATCH v9 07/10] virtio-9p: introduce ERRP_AUTO_PROPAGATE

2020-03-12 Thread Vladimir Sementsov-Ogievskiy
If we want to add some info to errp (by error_prepend() or error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro. Otherwise, this info will not be added when errp == &error_fatal (the program will exit prior to the error_append_hint() or error_prepend() call). Fix such cases. If we want

[PATCH v9 04/10] SD (Secure Card): introduce ERRP_AUTO_PROPAGATE

2020-03-12 Thread Vladimir Sementsov-Ogievskiy
If we want to add some info to errp (by error_prepend() or error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro. Otherwise, this info will not be added when errp == &error_fatal (the program will exit prior to the error_append_hint() or error_prepend() call). Fix such cases. If we want

[PATCH v9 01/10] error: auto propagated local_err

2020-03-12 Thread Vladimir Sementsov-Ogievskiy
Introduce a new ERRP_AUTO_PROPAGATE macro, to be used at start of functions with an errp OUT parameter. It has three goals: 1. Fix issue with error_fatal and error_prepend/error_append_hint: user can't see this additional information, because exit() happens in error_setg earlier than information

[PATCH v9 05/10] pflash: introduce ERRP_AUTO_PROPAGATE

2020-03-12 Thread Vladimir Sementsov-Ogievskiy
If we want to add some info to errp (by error_prepend() or error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro. Otherwise, this info will not be added when errp == &error_fatal (the program will exit prior to the error_append_hint() or error_prepend() call). Fix such cases. If we want

[PATCH v9 00/10] error: auto propagated local_err part I

2020-03-12 Thread Vladimir Sementsov-Ogievskiy
v9 01: A lot of rewordings [thanks to Eric] Still, keep all r-b marks, assuming that they are mostly about macro definition 02: significant changes are: 1. Do not match double propagation pattern in ERRP_AUTO_PROPAGATE-adding rule 2. Introduce errp->->errp scheme to match only fun

[PATCH v9 03/10] hw/sd/ssi-sd: fix error handling in ssi_sd_realize

2020-03-12 Thread Vladimir Sementsov-Ogievskiy
It's wrong to use same err object as errp parameter for several function calls without intermediate checking for error: we'll crash if try to set err object twice. Fix that, using new ERRP_AUTO_PROPAGATE macro. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- hw/sd/ssi-s

[PATCH v9 10/10] xen: introduce ERRP_AUTO_PROPAGATE

2020-03-12 Thread Vladimir Sementsov-Ogievskiy
If we want to add some info to errp (by error_prepend() or error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro. Otherwise, this info will not be added when errp == &error_fatal (the program will exit prior to the error_append_hint() or error_prepend() call). Fix such cases. If we want

[PATCH v9 02/10] scripts: Coccinelle script to use ERRP_AUTO_PROPAGATE()

2020-03-12 Thread Vladimir Sementsov-Ogievskiy
Script adds ERRP_AUTO_PROPAGATE macro invocation where appropriate and does corresponding changes in code (look for details in include/qapi/error.h) Usage example: spatch --sp-file scripts/coccinelle/auto-propagated-errp.cocci \ --macro-file scripts/cocci-macro-file.h --in-place --no-show-diff \

Re: [PATCH v9 02/15] s390x: protvirt: Support unpack facility

2020-03-12 Thread Janosch Frank
On 3/11/20 5:07 PM, David Hildenbrand wrote: > >> +++ b/include/hw/s390x/pv.h >> @@ -0,0 +1,57 @@ >> +/* >> + * Protected Virtualization header >> + * >> + * Copyright IBM Corp. 2020 >> + * Author(s): >> + * Janosch Frank >> + * >> + * This work is licensed under the terms of the GNU GPL, versio

[PATCH v9 09/10] nbd: introduce ERRP_AUTO_PROPAGATE

2020-03-12 Thread Vladimir Sementsov-Ogievskiy
If we want to add some info to errp (by error_prepend() or error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro. Otherwise, this info will not be added when errp == &error_fatal (the program will exit prior to the error_append_hint() or error_prepend() call). Fix such cases. If we want

Re: [PATCH v9 06/15] s390x: Add SIDA memory ops

2020-03-12 Thread Christian Borntraeger
On 11.03.20 14:21, Janosch Frank wrote: > Protected guests save the instruction control blocks in the SIDA > instead of QEMU/KVM directly accessing the guest's memory. > > Let's introduce new functions to access the SIDA. > > Also the new memops are available with KVM_CAP_S390_PROTECTED, so > let

Re: [PATCH 3/3] block: fail on open when file size is unaligned to request_alignment

2020-03-12 Thread Vladimir Sementsov-Ogievskiy
11.03.2020 15:29, Eric Blake wrote: On 3/11/20 6:06 AM, Max Reitz wrote: On 30.01.20 16:22, Vladimir Sementsov-Ogievskiy wrote: Prior to the commit the following command lead to crash:    ./qemu-io --image-opts -c 'write 0 512' \    driver=blkdebug,align=4096,image.driver=null-co,image.size=51

Re: [PATCH v3 1/6] virtio-net: introduce RSS and hash report features

2020-03-12 Thread Yuri Benditovich
On Thu, Mar 12, 2020 at 10:23 AM Michael S. Tsirkin wrote: > On Thu, Mar 12, 2020 at 09:42:20AM +0200, Yuri Benditovich wrote: > > > > > > On Thu, Mar 12, 2020 at 9:21 AM Michael S. Tsirkin > wrote: > > > > On Thu, Mar 12, 2020 at 09:02:38AM +0200, Yuri Benditovich wrote: > > > >

Re: [kvm-unit-tests PATCH v5 10/13] arm/arm64: ITS: INT functional tests

2020-03-12 Thread Zenghui Yu
On 2020/3/11 22:00, Marc Zyngier wrote: That is still a problem with the ITS. There is no architectural way to report an error, even if the error numbers are architected... One thing we could do though is to implement the stall model (as described in 5.3.2). It still doesn't give us the error, b

Re: [PATCH v2] target/i386: set the CPUID level to 0x14 on old machine-type

2020-03-12 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1584031686-16444-1-git-send-email-luwei.k...@intel.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/

[Bug 1866870] Re: KVM Guest pauses after upgrade to Ubuntu 20.04

2020-03-12 Thread Boris Derzhavets
Reproduced via attempt to install KVM Guest F31 Server on Ubuntu 20.04 (bare metal) ** Attachment added: "/var/log/libvirt/qemu/fedora31.log - attempt to launch F31 Server VM via Virt-manager on Ubuntu 20.04" https://bugs.launchpad.net/qemu/+bug/1866870/+attachment/5336017/+files/fedora31.lo

[PATCH v6 4/4] iotests: 287: add qcow2 compression type test

2020-03-12 Thread Denis Plotnikov
The test checks fulfilling qcow2 requiriements for the compression type feature and zstd compression type operability. Signed-off-by: Denis Plotnikov Reviewed-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/287 | 128 + tests/qemu-iotests/287.out

[PATCH v6 0/4] qcow2: Implement zstd cluster compression method

2020-03-12 Thread Denis Plotnikov
v6: * "block/qcow2-threads: fix qcow2_decompress" is removed from the series since it has been accepted by Max already * add compile time checking for Qcow2Header to be a multiple of 8 [Max, Alberto] * report error on qcow2 amending when the compression type is actually chnged [Max

[PATCH v6 2/4] qcow2: rework the cluster compression routine

2020-03-12 Thread Denis Plotnikov
The patch enables processing the image compression type defined for the image and chooses an appropriate method for image clusters (de)compression. Signed-off-by: Denis Plotnikov Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Alberto Garcia --- block/qcow2-threads.c | 71 ++

[PATCH v6 3/4] qcow2: add zstd cluster compression

2020-03-12 Thread Denis Plotnikov
zstd significantly reduces cluster compression time. It provides better compression performance maintaining the same level of the compression ratio in comparison with zlib, which, at the moment, is the only compression method available. The performance test results: Test compresses and decompresse

[PATCH v6 1/4] qcow2: introduce compression type feature

2020-03-12 Thread Denis Plotnikov
The patch adds some preparation parts for incompatible compression type feature to qcow2 allowing the use different compression methods for image clusters (de)compressing. It is implied that the compression type is set on the image creation and can be changed only later by image conversion, thus c

RE: [PATCH v3 02/10] fw_cfg: Migrate ACPI table mr sizes separately

2020-03-12 Thread Shameerali Kolothum Thodi
> -Original Message- > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: 11 March 2020 21:10 > To: Shameerali Kolothum Thodi > Cc: qemu-devel@nongnu.org; qemu-...@nongnu.org; > eric.au...@redhat.com; imamm...@redhat.com; peter.mayd...@linaro.org; > shannon.zha...@gmail.com; xiao

Re: [PATCH v9 03/15] s390x: protvirt: Add migration blocker

2020-03-12 Thread Janosch Frank
On 3/12/20 9:42 AM, Christian Borntraeger wrote: > > > On 11.03.20 14:21, Janosch Frank wrote: >> Migration is not yet supported. >> >> Signed-off-by: Janosch Frank >> Reviewed-by: David Hildenbrand >> --- >> hw/s390x/s390-virtio-ccw.c | 18 ++ >> 1 file changed, 18 insertions(

Re: Upstream QEMU guest support policy ? Re: [PATCH v3 0/2] spapr: Use vIOMMU translation for virtio by default

2020-03-12 Thread Daniel P . Berrangé
On Thu, Mar 12, 2020 at 12:08:47PM +1100, David Gibson wrote: > On Wed, Mar 11, 2020 at 10:01:27AM +, Daniel P. Berrangé wrote: > 65;5803;1c> On Wed, Mar 11, 2020 at 12:12:47PM +1100, David Gibson wrote: > > > On Tue, Mar 10, 2020 at 11:43:43AM +, Daniel P. Berrangé wrote: > > > > On Thu, M

Re: [PATCH v3 1/2] target/arm: kvm: Inject events at the last stage of sync

2020-03-12 Thread Andrew Jones
On Thu, Mar 12, 2020 at 12:34:00AM +, Beata Michalska wrote: > KVM_SET_VCPU_EVENTS might actually lead to vcpu registers being modified. > As such this should be the last step of sync to avoid potential overwriting > of whatever changes KVM might have done. > > Signed-off-by: Beata Michalska

[Bug 1866870] Re: KVM Guest pauses after upgrade to Ubuntu 20.04

2020-03-12 Thread Christian Ehrhardt 
I tried with a guest XML matching yours (other than disk setup). I didn't get those errors you reported even when using your config. Notable differences to my default - your guest has: - a rather old chip type (Penryn is a 2007 chip) - a rather old machine type (uses xenial which matches ~pc-i440

[Bug 1866870] Re: KVM Guest pauses after upgrade to Ubuntu 20.04

2020-03-12 Thread Christian Ehrhardt 
Thanks Boris for chiming in! Maybe it is something in the guest (or the way virt-manager sets things up) after all - will install an F31 via virt-manager as well ... -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launch

Re: [PATCH v2 0/2] tests/tcg/multiarch: Add tests for implemented real

2020-03-12 Thread Alex Bennée
Filip Bozuta writes: > This series covers tests for implemented rtc and alsa timer ioctls. The names > of ioctls that are covered by these tests can be found in patch descriptions. > The functionalities of each ioctl that is tested can be found in patches that > implement them. > > Some of the

Re: [kvm-unit-tests PATCH v5 10/13] arm/arm64: ITS: INT functional tests

2020-03-12 Thread Auger Eric
Hi Zenghui, On 3/12/20 10:19 AM, Zenghui Yu wrote: > On 2020/3/11 22:00, Marc Zyngier wrote: >> That is still a problem with the ITS. There is no architectural way >> to report an error, even if the error numbers are architected... >> >> One thing we could do though is to implement the stall model

KVM call for 2020-03-24

2020-03-12 Thread Juan Quintela
Hi Please, send any topic that you are interested in covering. At the end of Monday I will send an email with the agenda or the cancellation of the call, so hurry up. After discussions on the QEMU Summit, we are going to have always open a KVM call where you can add topics. Call details: B

Re: [PATCH v3 31/33] docs: Stop building qemu-doc

2020-03-12 Thread Peter Maydell
On Thu, 12 Mar 2020 at 06:06, Markus Armbruster wrote: > Would it be possible to additionally render a complete manual as one > humongous .html? Without an index, there's only search, and the > ergonomics of searching within a single page are so much better. There is a "build one big fat HTML pa

[Bug 1866870] Re: KVM Guest pauses after upgrade to Ubuntu 20.04

2020-03-12 Thread Boris Derzhavets
I've got the same issue starting guest via virt-install even with serial console. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1866870 Title: KVM Guest pauses after upgrade to Ubuntu 20.04 Status

Re: [PATCH v2 1/2] Use -isystem for linux-headers dir

2020-03-12 Thread Peter Maydell
On Wed, 11 Mar 2020 at 23:23, Eduardo Habkost wrote: > > glibc and Linux-provided headers are known to generate macro > redefinition warnings when used together. For example: > and duplicate some macro definitions. > > We normally never see those warnings because GCC suppresses > warnings gener

Re: [PATCH v3 2/2] target/arm: kvm: Handle DABT with no valid ISS

2020-03-12 Thread Andrew Jones
On Thu, Mar 12, 2020 at 12:34:01AM +, Beata Michalska wrote: > On ARMv7 & ARMv8 some load/store instructions might trigger a data abort > exception with no valid ISS info to be decoded. The lack of decode info > makes it at least tricky to emulate those instruction which is one of the > (many)

[Bug 1866870] Re: KVM Guest pauses after upgrade to Ubuntu 20.04

2020-03-12 Thread Christian Ehrhardt 
I fetched https://download.fedoraproject.org/pub/fedora/linux/releases/31/Workstation/x86_64/iso/Fedora-Workstation-Live-x86_64-31-1.9.iso And installed it on Ubuntu 20.04 via virt-manager (keeping all things on its default). - New - Local Media - select ISO (Autodetects F31) - Forward, Forward,

[Bug 1866870] Re: KVM Guest pauses after upgrade to Ubuntu 20.04

2020-03-12 Thread Christian Ehrhardt 
@Boris - in your log I've seen that you also got the Penryn cpu which I find odd. "-cpu Penryn,vme=on,vmx=on,x2apic=on,tsc-deadline=on,xsave=on,hypervisor=on,arat=on,tsc-adjust=on,arch-capabilities=on,skip-l1dfl-vmentry=on \" Assuming you also only used default I wonder how it got to that, maybe

[PATCH] tools/virtiofsd: add support for --socket-group

2020-03-12 Thread Alex Bennée
If you like running QEMU as a normal user (very common for TCG runs) but you have to run virtiofsd as a root user you run into connection problems. Adding support for an optional --socket-group allows the users to keep using the command line. Signed-off-by: Alex Bennée --- v1 - tweak documenta

Re: [PATCH v9 07/15] s390x: protvirt: Move STSI data over SIDAD

2020-03-12 Thread Christian Borntraeger
On 11.03.20 14:21, Janosch Frank wrote: > For protected guests, we need to put the STSI emulation results into > the SIDA, so SIE will write them into the guest at the next entry. > > Signed-off-by: Janosch Frank > Reviewed-by: David Hildenbrand > --- > target/s390x/kvm.c | 11 +-- >

Re: [PATCH] tools/virtiofsd: add support for --socket-group

2020-03-12 Thread Daniel P . Berrangé
On Thu, Mar 12, 2020 at 10:41:42AM +, Alex Bennée wrote: > If you like running QEMU as a normal user (very common for TCG runs) > but you have to run virtiofsd as a root user you run into connection > problems. Adding support for an optional --socket-group allows the > users to keep using the c

Re: Qemu master crashing on boot when using file backend for memory

2020-03-12 Thread Igor Mammedov
On Thu, 12 Mar 2020 01:36:48 -0400 Raphael Norwitz wrote: > When I try run master qemu I am hitting a divide by zero error. It seems > to be coming from util/oslib-posix.c in touch_all_pages(). see line 477: > > numpages_per_thread = numpages / memset_num_threads; > > Poking around the crash du

[PATCH] virtio_balloon: Add option mprotect to handle guest kernel cheat issue

2020-03-12 Thread Hui Zhu
QEMU virtio_balloon decreases the memory usage of VM depends on the cooperation of the guest kernel. If the guest kernel cheats with the virtio_balloon, it can break the limit. [1] is a Linux kernel with a cheat code. This is an example in a VM with 1G memory 1CPU that use this kernel: // Start V

Re: [PATCH v2] configure: Improve zstd test

2020-03-12 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > There were one error on the test (missing an s for --exists). > But we really need a recent zstd (1.4.0). > Thanks to Michal Privoznik to provide the right vension. > > Signed-off-by: Juan Quintela > Reported-by: Richard Henderson Queued for migrat

Re: [PULL 00/19] Block patches

2020-03-12 Thread Peter Maydell
On Wed, 11 Mar 2020 at 13:52, Max Reitz wrote: > > The following changes since commit ba29883206d92a29ad5a466e679ccfc2ee6132ef: > > Merge remote-tracking branch 'remotes/borntraeger/tags/s390x-20200310' into > staging (2020-03-10 16:50:28 +) > > are available in the Git repository at: > >

Re: [PATCH v7 01/13] hw/i386: Introduce X86CPUTopoInfo to contain topology info

2020-03-12 Thread Igor Mammedov
On Wed, 11 Mar 2020 17:52:52 -0500 Babu Moger wrote: > This is an effort to re-arrange few data structure for better readability. > > 1. Add X86CPUTopoInfo which will have all the topology informations >required to build the cpu topology. There is no functional changes. > > 2. Introduce ini

Re: [kvm-unit-tests PATCH v2 5/9] arm: pmu: Basic event counter Tests

2020-03-12 Thread Auger Eric
Hi Drew, On 3/5/20 10:42 AM, Andrew Jones wrote: > On Thu, Jan 30, 2020 at 12:25:06PM +0100, Eric Auger wrote: >> Adds the following tests: >> - event-counter-config: test event counter configuration >> - basic-event-count: >> - programs counters #0 and #1 to count 2 required events >> (resp.

Re: [kvm-unit-tests PATCH v2 5/9] arm: pmu: Basic event counter Tests

2020-03-12 Thread Auger Eric
Hi Drew, On 3/5/20 10:33 AM, Andrew Jones wrote: > On Thu, Jan 30, 2020 at 12:25:06PM +0100, Eric Auger wrote: >> Adds the following tests: >> - event-counter-config: test event counter configuration >> - basic-event-count: >> - programs counters #0 and #1 to count 2 required events >> (resp.

[Bug 1866870] Re: KVM Guest pauses after upgrade to Ubuntu 20.04

2020-03-12 Thread tstrike
** Attachment added: "virshcapabilities.txt" https://bugs.launchpad.net/qemu/+bug/1866870/+attachment/5336030/+files/virshcapabilities.txt -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1866870 Ti

[Bug 1866870] Re: KVM Guest pauses after upgrade to Ubuntu 20.04

2020-03-12 Thread tstrike
** Attachment added: "virshdomcapabilities.txt" https://bugs.launchpad.net/qemu/+bug/1866870/+attachment/5336031/+files/virshdomcapabilities.txt -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/18668

[Bug 1866870] Re: KVM Guest pauses after upgrade to Ubuntu 20.04

2020-03-12 Thread tstrike
This particular command seems to hang on: qemu-system-x86_64: warning: host doesn't support requested feature: CPUID.01H:ECX.vmx [bit 5] qemu-system-x86_64: warning: host doesn't support requested feature: CPUID.8001H:ECX.svm [bit 2] I tried to execute (thinking I was in a shell): {"execut

Re: [PATCH v9 07/15] s390x: protvirt: Move STSI data over SIDAD

2020-03-12 Thread Janosch Frank
On 3/12/20 11:42 AM, Christian Borntraeger wrote: > > > On 11.03.20 14:21, Janosch Frank wrote: >> For protected guests, we need to put the STSI emulation results into >> the SIDA, so SIE will write them into the guest at the next entry. >> >> Signed-off-by: Janosch Frank >> Reviewed-by: David H

Re: [PATCH] acpi: Add Windows ACPI Emulated Device Table (WAET)

2020-03-12 Thread Liran Alon
On 12/03/2020 8:12, Michael S. Tsirkin wrote: On Thu, Mar 12, 2020 at 01:20:02AM +0200, Liran Alon wrote: On 11/03/2020 22:36, Michael S. Tsirkin wrote: Thanks for the patch! Some questions/comments: On Wed, Mar 11, 2020 at 07:08:26PM +0200, Liran Alon wrote: From: Elad Gabay Microsoft in

[Bug 1866870] Re: KVM Guest pauses after upgrade to Ubuntu 20.04

2020-03-12 Thread Boris Derzhavets
Thanks a lot . I will do it at my earliest convenience this night. Haswell i4770 is installed on small server 32 GB. Department's policy doesn't allow me to test Ubuntu whichever release on bare metal. I could test only on outdated CPU's box and it seems to be a core reason. -- You received this

Re: [PATCH 3/3] block: fail on open when file size is unaligned to request_alignment

2020-03-12 Thread Eric Blake
On 3/12/20 4:06 AM, Vladimir Sementsov-Ogievskiy wrote: So the real solution would probably...  Be to align the file size up to the alignment? Or to bite the bullet and finally implement byte-accurate size everywhere (instead of our current insistence on rounding size up to 512-byte multiple

Re: [PATCH] virtio_balloon: Add option mprotect to handle guest kernel cheat issue

2020-03-12 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1584010572-10308-1-git-send-email-teawa...@gmail.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bi

[PULL 01/12] Makefile: Remove redundant Texinfo related code

2020-03-12 Thread Peter Maydell
The recent conversion of qemu-doc.texi to rST forgot a few stray bits of makefile code that are now redundant. Remove them. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Message-id: 20200306171749.10756-2-peter.mayd...@linaro.org --- Makefile | 11 +-- 1 file changed, 1 in

[PULL 00/12] docs queue

2020-03-12 Thread Peter Maydell
/tags/pull-block-2020-03-11' into staging (2020-03-11 17:06:40 +) are available in the Git repository at: https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-docs-20200312 for you to fetch changes up to 6fe6d6c9a953901251e1a85088f0a61ff5caf648: docs: Be consis

[PULL 02/12] Update comments in .hx files that mention Texinfo

2020-03-12 Thread Peter Maydell
Update the header comments in .hx files that mention STEXI/ETEXI markup; this is now SRST/ERST as all these files have been converted to rST. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Message-id: 20200306171749.10756-3-peter.mayd...@linaro.org --- hmp-commands-info.hx | 8

[PULL 05/12] Makefile: Make all Sphinx documentation depend on the extensions

2020-03-12 Thread Peter Maydell
Add the Python source files of our Sphinx extensions to the dependencies of the Sphinx manuals, so that if we edit the extension source code the manuals get rebuilt. Adding this dependency unconditionally means that we'll rebuild a manual even if it happens to not use the extension whose source fi

[PULL 03/12] hxtool: Remove Texinfo generation support

2020-03-12 Thread Peter Maydell
All the STEXI/ETEXI blocks and the Makfile rules that use them have now been removed from the codebase. We can remove the code from the hxtool script which handles the STEXI/ETEXI directives and the '-t' option. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Message-id: 202003061717

[PULL 04/12] docs/sphinx/hxtool.py: Remove STEXI/ETEXI support

2020-03-12 Thread Peter Maydell
Now that none of our input .hx files have STEXI/ETEXI blocks, we can remove the code in the Sphinx hxtool extension that supported parsing them. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Message-id: 20200306171749.10756-5-peter.mayd...@linaro.org --- docs/sphinx/hxtool.py | 28

[PULL 07/12] docs/qemu-option-trace.rst.inc: Remove redundant comment

2020-03-12 Thread Peter Maydell
The Texinfo version of the tracing options documentation has now been deleted, so we can remove the now-redundant comment at the top of the rST version that was reminding us that the two should be kept in sync. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Message-id: 2020030617174

[PULL 10/12] docs/system/target-arm.rst: Add some introductory text

2020-03-12 Thread Peter Maydell
Now we've moved the various bits of per-board documentation into their own files, the top level document is a little bare. Add some introductory information, including a note that many of the board models we support are currently undocumented. (Most sections of this new text were originally writte

[PULL 06/12] docs/index.rst, docs/index.html.in: Reorder manuals

2020-03-12 Thread Peter Maydell
Now that qemu-doc.html is no longer present, the ordering of manuals within the top-level index page looks a bit odd. Reshuffle so that the manuals the user is most likely to be interested in are at the top of the list, and the reference material is at the bottom. Similarly, we reorder the index.r

[PULL 11/12] docs: Move arm-cpu-features.rst into the system manual

2020-03-12 Thread Peter Maydell
Now we have somewhere to put arm-specific rst documentation, we can move arm-cpu-features.rst from the docs/ top level directory into docs/system/arm/. Signed-off-by: Peter Maydell Reviewed-by: Alex Bennée Reviewed-by: Niek Linnenbank Message-id: 20200309215818.2021-5-peter.mayd...@linaro.org -

[PULL 08/12] Makefile: Allow for subdirectories in Sphinx manual dependencies

2020-03-12 Thread Peter Maydell
Currently we put 'docs/foo/*.rst' in the Make list of dependencies for the Sphinx 'foo' manual, which means all the files must be in the top level of that manual's directory. We'd like to be able to have subdirectories inside some of the manuals, so add 'docs/foo/*/*.rst' to the dependencies too.

[PULL 12/12] docs: Be consistent about capitalization of 'Arm'

2020-03-12 Thread Peter Maydell
The company 'Arm' went through a rebranding some years back involving a recapitalization from 'ARM' to 'Arm'. As a result our documentation is a bit inconsistent between the two forms. It's not worth trying to update everywhere in QEMU, but it's easy enough to make docs/ consistent. Note that "ARM

[Bug 1866870] Re: KVM Guest pauses after upgrade to Ubuntu 20.04

2020-03-12 Thread Boris Derzhavets
Done on Penryn's box ** Attachment added: "Requested reporting submitted" https://bugs.launchpad.net/qemu/+bug/1866870/+attachment/5336044/+files/Penryn.txt -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.n

[PULL 09/12] docs/system: Split target-arm.rst into sub-documents

2020-03-12 Thread Peter Maydell
Currently the documentation for Arm system emulator targets is in a single target-arm.rst. This describes only some of the boards and often in a fairly abbreviated fashion. Restructure it so that each board has its own documentation file in the docs/system/arm/ subdirectory. This will hopefully e

Re: [PATCH v2 00/14] LUKS: encryption slot management using amend interface

2020-03-12 Thread Eric Blake
On 3/8/20 10:18 AM, Maxim Levitsky wrote: Hi! Here is the updated series of my patches, incorporating all the feedback I received. Patches are strictly divided by topic to 3 groups, and each group depends on former groups. * Patches 1,2 implement qcrypto generic amend interface, including

Re: [PATCH 3/3] block: fail on open when file size is unaligned to request_alignment

2020-03-12 Thread Vladimir Sementsov-Ogievskiy
11.03.2020 14:06, Max Reitz wrote: On 30.01.20 16:22, Vladimir Sementsov-Ogievskiy wrote: Prior to the commit the following command lead to crash: ./qemu-io --image-opts -c 'write 0 512' \ driver=blkdebug,align=4096,image.driver=null-co,image.size=512 It failes on assertion in bdrv_align

Re: [PATCH] hw/arm/cubieboard: make sure SOC object isn't leaked

2020-03-12 Thread Peter Maydell
On Tue, 3 Mar 2020 at 09:13, Igor Mammedov wrote: > > SOC object returned by object_new() is leaked in current code. > Set SOC parent explicitly to board and then unref to SOC object > to make sure that refererence returned by object_new() is taken > care of. > > The SOC object will be kept alive

Re: [PATCH v3 0/2] target/arm: Misc cleanups surrounding TBI

2020-03-12 Thread Peter Maydell
On Sun, 8 Mar 2020 at 01:29, Richard Henderson wrote: > > Changes for v3: > * All but 2 patches are now merged. > * Use regime_el to determine aa64-ness of physical memory addressing. > Applied to target-arm.next, thanks. -- PMM

Re: [PATCH 3/3] block: fail on open when file size is unaligned to request_alignment

2020-03-12 Thread Vladimir Sementsov-Ogievskiy
12.03.2020 14:59, Vladimir Sementsov-Ogievskiy wrote: 11.03.2020 14:06, Max Reitz wrote: On 30.01.20 16:22, Vladimir Sementsov-Ogievskiy wrote: Prior to the commit the following command lead to crash:    ./qemu-io --image-opts -c 'write 0 512' \    driver=blkdebug,align=4096,image.driver=null-

  1   2   3   4   5   >