Re: Re: [PATCH] mem-prealloc: initialize cond and mutex(Internet mail)

oh ,yes.Thanks I want to know if I submit a new fixed patch or just a patch fixed current problem?? if a new fixed patch, maybe need a revert ? bauerchen(陈蒙蒙) From: Igor Mammedov Date: 2020-03-09 21:19 To: bauerchen(陈蒙蒙)

Re: [PATCH v1 5/5] tests/acceptance: disable two more tests while in CI

Alex Bennée writes: > These keep timing out on Travis. The reason is unknown so add a FIXME > for those who want to track down exactly why this is happening. In the > meantime you can still run check-acceptance manually without change. > > Signed-off-by: Alex Bennée > --- > tests/acceptance/m

Re: [PATCH v8 02/10] scripts: add coccinelle script to use auto propagated errp

09.03.2020 12:56, Markus Armbruster wrote: Suggest scripts: Coccinelle script to use auto-propagated errp or scripts: Coccinelle script to use ERRP_AUTO_PROPAGATE() Vladimir Sementsov-Ogievskiy writes: Script adds ERRP_AUTO_PROPAGATE macro invocation where appropriate and does co

Re: [PULL 00/33] Trivial branch patches

Le 09/03/2020 à 20:30, Philippe Mathieu-Daudé a écrit : > On 3/9/20 8:17 PM, Michael S. Tsirkin wrote: >> On Mon, Mar 09, 2020 at 04:08:04PM +0100, Laurent Vivier wrote: >>> The following changes since commit >>> 7a5853cec479a448edae0fb2aaf4e2f78c9c774d: >>> >>>    Merge remote-tracking branch 'rem

Re: [PATCH RESEND 2/3] vhost: fix a null pointer reference of vhost_log

On 2020/3/10 13:57, Michael S. Tsirkin wrote: > On Mon, Feb 24, 2020 at 02:42:18PM +0800, Longpeng(Mike) wrote: >> From: Longpeng >> >> vhost_log_alloc() may fails and returned pointer of log is null. >> However there're two places derefernce the return pointer without >> check. >> >> Signed-of

RE: [PATCH v2] hw/net/imx_fec: write TGSR and TCSR3 in imx_enet_write()

>-Original Message- >From: Peter Maydell [mailto:peter.mayd...@linaro.org] >Sent: Monday, March 9, 2020 7:36 PM >To: Chenqun (kuhn) >Cc: QEMU Developers ; QEMU Trivial triv...@nongnu.org>; Zhanghailiang ; >Jason Wang ; Peter Chubb >; qemu-arm ; Euler >Robot >Subject: Re: [PATCH v2] hw/net

Re: [PATCH v6 18/18] docs: add Orange Pi PC document

Niek Linnenbank writes: > Hi Alex, > > On Wed, Mar 4, 2020 at 9:55 PM Niek Linnenbank > wrote: > >> Hello Alex, >> >> On Wed, Mar 4, 2020 at 11:35 AM Alex Bennée >> wrote: >> >>> >>> Niek Linnenbank writes: >>> >>> > The Xunlong Orange Pi PC machine is a functional ARM machine >>> > based on

Re: [PATCH v10 04/10] qemu-binfmt-conf.sh: add QEMU_CREDENTIAL and QEMU_PERSISTENT

Le 09/03/2020 à 20:20, Unai Martinez-Corral a écrit : > Allow to set options '--persistent' and/or '--credential' through > environment variables. If not defined, defaults are used ('no'). > Anyway, command-line arguments have priority over environment variables. If variable are set to 'yes', how

Re: [PATCH v2] qom-qmp-cmds: fix two memleaks in qmp_object_add

On Tue, 10 Mar 2020 14:46:40 +0800 Pan Nengyuan wrote: > 'type/id' forgot to free in qmp_object_add, this patch fix that. > > The leak stack: > Direct leak of 84 byte(s) in 6 object(s) allocated from: > #0 0x7fe2a5ebf768 in __interceptor_malloc (/lib64/libasan.so.5+0xef768) > #1 0x7fe2a5

[PULL 0/2] Usb 20200310 patches

The following changes since commit 67f17e23baca5dd545fe98b01169cc351a70fe35: Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2020-03-06 17:15:36 +) are available in the Git repository at: git://git.kraxel.org/qemu tags/usb-20200310-pull-request

[PULL 2/2] usb/hcd-ehci: Remove redundant statements

From: Chen Qun The "again" assignment is meaningless before g_assert_not_reached. In addition, the break statements no longer needs to be after g_assert_not_reached. Clang static code analyzer show warning: hw/usb/hcd-ehci.c:2108:13: warning: Value stored to 'again' is never read aga

Re: [PATCH RESEND 2/3] vhost: fix a null pointer reference of vhost_log

On Tue, Mar 10, 2020 at 04:04:35PM +0800, Longpeng (Mike, Cloud Infrastructure Service Product Dept.) wrote: > > > On 2020/3/10 13:57, Michael S. Tsirkin wrote: > > On Mon, Feb 24, 2020 at 02:42:18PM +0800, Longpeng(Mike) wrote: > >> From: Longpeng > >> > >> vhost_log_alloc() may fails and retu

Re: [PATCH v5 13/16] target/i386: Add EPYC model specific handlers

On Mon, 9 Mar 2020 14:12:10 -0500 Babu Moger wrote: > On 3/9/20 10:03 AM, Igor Mammedov wrote: > > On Tue, 03 Mar 2020 13:58:16 -0600 > > Babu Moger wrote: > > > >> Add the new EPYC model specific handlers to fix the apicid decoding. > >> > >> The APIC ID is decoded based on the sequence sock

[PULL 1/2] usb-serial: wakeup device on input

From: Jason Andryuk Currently usb-serial devices are unable to send data into guests with the xhci controller. Data is copied into the usb-serial's buffer, but it is not sent into the guest. Data coming out of the guest works properly. usb-serial devices work properly with ehci. Have usb-seri

Re: [PATCH v5 11/16] target/i386: Load apicid model specific handlers from X86CPUDefinition

On Mon, 9 Mar 2020 14:04:39 -0500 Babu Moger wrote: > On 3/9/20 9:49 AM, Igor Mammedov wrote: > > On Tue, 03 Mar 2020 13:58:03 -0600 > > Babu Moger wrote: > > > >> Load the model specific handlers if available or else default handlers > >> will be loaded. Add the model specific handlers if ap

Re: [PATCH v10 02/10] qemu-binfmt-conf.sh: enforce safe tests

Le 09/03/2020 à 20:19, Unai Martinez-Corral a écrit : > All the tests are prefixed with 'x', in order to avoid risky comparisons > (i.e. a user deliberately trying to provoke a syntax error). With the quotes I don't see how we can provoke a syntax error. Could you provide an example? Thanks, Laur

Re: [PATCH v5 12/16] hw/i386: Use the apicid handlers from X86MachineState

On Mon, 9 Mar 2020 14:08:53 -0500 Babu Moger wrote: > On 3/9/20 10:01 AM, Igor Mammedov wrote: > > On Tue, 03 Mar 2020 13:58:10 -0600 > > Babu Moger wrote: > > > >> Check and Load the apicid handlers from X86CPUDefinition if available. > >> Update the calling convention for the apicid handler

[PATCH 2/4] tests/vm: move vga setup

Move '-device VGA' from basevm.py to the guests, so they have the chance to opt out and run without display device. Signed-off-by: Gerd Hoffmann --- tests/vm/basevm.py | 1 - tests/vm/fedora | 1 + tests/vm/freebsd | 1 + tests/vm/netbsd | 1 + tests/vm/openbsd | 1 + tests/v

[PATCH 3/4] tests/vm: update FreeBSD to 12.1

Signed-off-by: Gerd Hoffmann --- tests/vm/freebsd | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/vm/freebsd b/tests/vm/freebsd index 58166766d915..298967fe9cf4 100755 --- a/tests/vm/freebsd +++ b/tests/vm/freebsd @@ -24,8 +24,8 @@ class FreeBSDVM(basevm.BaseVM):

[PATCH 1/4] tests/vm: write raw console log

Run "tail -f /var/tmp/*/qemu*console.raw" in another terminal to watch the install console. Signed-off-by: Gerd Hoffmann --- tests/vm/basevm.py | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py index 8400b0e07f65..c53fd354d955 100644 --- a/tests/vm

[PATCH 0/4] tests/vm: minor install tweaks, update netbsd & freebsd

Gerd Hoffmann (4): tests/vm: write raw console log tests/vm: move vga setup tests/vm: update FreeBSD to 12.1 tests/vm: update NetBSD to 9.0 tests/vm/basevm.py | 7 ++- tests/vm/fedora | 1 + tests/vm/freebsd | 5 +++-- tests/vm/netbsd | 24 +++

[PATCH v8 2/2] s390x: protvirt: Support unpack facility

The unpack facility provides the means to setup a protected guest. A protected guest can not be introspected by the hypervisor or any user/administrator of the machine it is running on. Protected guests are encrypted at rest and need a special boot mechanism via diag308 subcode 8 and 10. Code 8 s

[PATCH v8 1/2] s390x: ipl: Consolidate iplb validity check into one function

It's nicer to just call one function than calling a function for each possible iplb type. Signed-off-by: Janosch Frank --- hw/s390x/ipl.h | 20 +++- target/s390x/diag.c | 2 +- 2 files changed, 12 insertions(+), 10 deletions(-) diff --git a/hw/s390x/ipl.h b/hw/s390x/ipl.h

[PATCH 4/4] tests/vm: update NetBSD to 9.0

The installer supports GPT now, so the install workflow has changed a bit. Also: run without VGA device. This works around a bug in the seabios sercon code and makes the bootloader menu show up on the serial line, so we can drop the quirk for that. Signed-off-by: Gerd Hoffmann --- tests/vm/net

Re: [PATCH v5 14/16] hw/i386: Move arch_id decode inside x86_cpus_init

On Mon, 9 Mar 2020 14:31:31 -0500 Babu Moger wrote: > On 3/9/20 10:21 AM, Igor Mammedov wrote: > > On Tue, 03 Mar 2020 13:58:24 -0600 > > Babu Moger wrote: > > > >> Apicid calculation depends on knowing the total number of numa nodes > >> for EPYC cpu models. Right now, we are calculating the

Re: [PATCH v8 1/2] s390x: ipl: Consolidate iplb validity check into one function

On 10.03.20 09:32, Janosch Frank wrote: > It's nicer to just call one function than calling a function for each > possible iplb type. > > Signed-off-by: Janosch Frank > --- > hw/s390x/ipl.h | 20 +++- > target/s390x/diag.c | 2 +- > 2 files changed, 12 insertions(+), 10 del

Re: [PATCH v10 01/10] qemu-binfmt-conf.sh: enforce style consistency

Le 09/03/2020 à 20:36, Unai Martinez Corral a écrit : > 2020/3/9 20:30, Eric Blake: > > On 3/9/20 2:18 PM, Unai Martinez-Corral wrote: > > Spaces are removed before '; then', for consistency with other scripts > > in the project. > > > > Signed-off-by: Unai Martinez-Corral >

Re: [PATCH v5 00/16] APIC ID fixes for AMD EPYC CPU model

On Tue, 03 Mar 2020 13:56:51 -0600 Babu Moger wrote: > This series fixes APIC ID encoding problem reported on AMD EPYC cpu models. > https://bugzilla.redhat.com/show_bug.cgi?id=1728166 > > Currently, the APIC ID is decoded based on the sequence > sockets->dies->cores->threads. This works for mos

Re: [PATCH v2 1/1] s390/ipl: sync back loadparm

On 09.03.20 14:32, Halil Pasic wrote: > We expose loadparm as a r/w machine property, but if loadparm is set by > the guest via DIAG 308, we don't update the property. Having a > disconnect between the guest view and the QEMU property is not nice in > itself, but things get even worse for SCSI, whe

[PATCH v8] s390x: protvirt: SCLP interpretation

SCLP for a protected guest is done over the SIDAD, so we need to use the s390_cpu_pv_mem_* functions to access the SIDAD instead of guest memory when reading/writing SCBs. To not confuse the sclp emulation, we set 0x4000 as the SCCB address, since the function that injects the sclp external interr

Re: [PATCH] tests/acceptance/ppc_prep_40p: Use cdn.netbsd.org hostname

On 3/10/20 3:32 AM, Cleber Rosa wrote: - Original Message - From: "David Gibson" To: "Alex Bennée" Cc: qemu-devel@nongnu.org, "Wainer dos Santos Moschetta" , "Kamil Rytarowski" , "Hervé Poussineau" , "Cleber Rosa" , qemu-...@nongnu.org, "Philippe Mathieu-Daudé" Sent: Monday, March 9

Re: [PATCH 2/4] tests/vm: move vga setup

On 3/10/20 9:32 AM, Gerd Hoffmann wrote: Move '-device VGA' from basevm.py to the guests, so they have the chance to opt out and run without display device. Signed-off-by: Gerd Hoffmann --- tests/vm/basevm.py | 1 - tests/vm/fedora | 1 + tests/vm/freebsd | 1 + tests/vm/netbsd

Re: [PATCH 1/4] tests/vm: write raw console log

Hi Gerd, On 3/10/20 9:32 AM, Gerd Hoffmann wrote: Run "tail -f /var/tmp/*/qemu*console.raw" in another terminal to watch the install console. Better to document that in the code/documentation rather than this commit description. Can you send a patch Alex can squash in? Reviewed-by: Philippe

[Bug 1813165] Re: KVM internal error. Suberror: 1 emulation failure

With Win10 you need to make sure it is not running Hyper-V under the hood (e.g. when you enable Hyper-V role Windows will put itself in a VM -- and thus you will get a nested environment). To be 100% sure do the following: # rmmod kvm_intel # modprobe kvm_intel nested=0 And see if the issue repro

[Bug 1829779] Re: qemu-system-arm and qemu-system-aarch64 QMP hangs after kernel boots

** Changed in: qemu Status: Confirmed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1829779 Title: qemu-system-arm and qemu-system-aarch64 QMP hangs after kernel boots Statu

[Bug 1841442] Re: floating point emulation can fail to set FE_INEXACT

Fixed by 16ce2fffa660 ("target/ppc: Fix do_float_check_status vs inexact") ** Changed in: qemu Status: Confirmed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1841442 Title:

[Bug 1836558] Re: Qemu-ppc Memory leak creating threads

** Changed in: qemu Status: Confirmed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1836558 Title: Qemu-ppc Memory leak creating threads Status in QEMU: Fix Released Bug

Re: [PATCH] util: fix to get configuration macros in util/mmap-alloc.c

On 3/9/2020 9:35 PM, Peter Maydell wrote: On Mon, 9 Mar 2020 at 13:23, Liu, Jingqi wrote: On 3/6/2020 12:40 AM, Peter Maydell wrote: On Thu, 5 Mar 2020 at 16:11, Ján Tomko wrote: On a Thursday in 2020, Jingqi Liu wrote: The CONFIG_LINUX symbol is always not defined in this file. This fixes

Re: [PULL 0/2] Usb 20200310 patches

Patchew URL: https://patchew.org/QEMU/20200310082402.22839-1-kra...@redhat.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash export

Re: [PATCH v8 2/2] s390x: protvirt: Support unpack facility

On 10.03.20 09:32, Janosch Frank wrote: > The unpack facility provides the means to setup a protected guest. A > protected guest can not be introspected by the hypervisor or any > user/administrator of the machine it is running on. > > Protected guests are encrypted at rest and need a special boot

Re: [PATCH v8] s390x: protvirt: SCLP interpretation

On 10.03.20 09:42, Janosch Frank wrote: > SCLP for a protected guest is done over the SIDAD, so we need to use > the s390_cpu_pv_mem_* functions to access the SIDAD instead of guest > memory when reading/writing SCBs. > > To not confuse the sclp emulation, we set 0x4000 as the SCCB address, > sinc

Re: [PATCH v8 1/2] s390x: ipl: Consolidate iplb validity check into one function

On 10.03.20 09:32, Janosch Frank wrote: > It's nicer to just call one function than calling a function for each > possible iplb type. > > Signed-off-by: Janosch Frank > --- > hw/s390x/ipl.h | 20 +++- > target/s390x/diag.c | 2 +- > 2 files changed, 12 insertions(+), 10 de

Re: [PATCH v4 2/3] mac_via: fix incorrect creation of mos6522 device in mac_via

Widespread QOM usage anti-pattern ahead; cc: QOM maintainers. Peter Maydell writes: > On Mon, 9 Mar 2020 at 10:02, Pan Nengyuan wrote: >> On 3/9/2020 5:21 PM, Peter Maydell wrote: >> > Could you explain more? My thought is that we should be using >> > sysbus_init_child_obj() and we should be do

[PATCH v8] s390x: ipl: Consolidate iplb validity check into one function

It's nicer to just call one function than calling a function for each possible iplb type. Signed-off-by: Janosch Frank Reviewed-by: David Hildenbrand --- hw/s390x/ipl.h | 18 +- target/s390x/diag.c | 2 +- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/hw

Re: [PATCH v8] s390x: ipl: Consolidate iplb validity check into one function

On 10.03.20 10:09, Janosch Frank wrote: > It's nicer to just call one function than calling a function for each > possible iplb type. > > Signed-off-by: Janosch Frank > Reviewed-by: David Hildenbrand David, still ok? If yes I will pick this one. Reviewed-by: Christian Borntraeger > ---

Re: [PATCH] util: fix to get configuration macros in util/mmap-alloc.c

On Tue, Mar 10, 2020 at 04:58:38PM +0800, Liu, Jingqi wrote: > On 3/9/2020 9:35 PM, Peter Maydell wrote: > > On Mon, 9 Mar 2020 at 13:23, Liu, Jingqi wrote: > > > On 3/6/2020 12:40 AM, Peter Maydell wrote: > > > > On Thu, 5 Mar 2020 at 16:11, Ján Tomko wrote: > > > > > On a Thursday in 2020, Jing

[RFC] cpus: avoid get stuck in pause_all_vcpus

From: Longpeng We find an issue when repeat reboot in guest during migration, it cause the migration thread never be waken up again. | | LOCK BQL | ...| main_loop_should_exit

[Bug 1856549] Re: qemu-4.2.0/hw/misc/mac_via.c: 2 * bad test ?

Fixed here: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=b2619c158ab5 ** Changed in: qemu Status: In Progress => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1856549 Title:

[Bug 1863685] Re: ARM: HCR.TSW traps are not implemented

Fixed here: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=1803d2713b29 ** Changed in: qemu Status: In Progress => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1863685 Title:

[Bug 1855072] Re: ARM: HCR.TVM traps are not implemented

Fixed here: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=84929218512c ** Changed in: qemu Status: In Progress => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1855072 Title:

[Bug 1849644] Re: QEMU VNC websocket proxy requires non-standard 'binary' subprotocol

Fixed here: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=c64e1e75381d -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1849644 Title: QEMU VNC websocket proxy requires non-standard 'binary' subprot

[Bug 1863247] Re: AArch64 EXT instruction for V register does not clear MSB side bits

Fixed here: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=78cedfabd53b ** Changed in: qemu Status: In Progress => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1863247 Title:

[Bug 1749393] Re: sbrk() not working under qemu-user with a PIE-compiled binary?

Fixed here: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=6fd5944980f4 ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1749393 Title: sbrk()

[PATCH v2 0/2] Some optimization in dirty bitmap sync

This patch series including code style change and performace fix about dirty bitmap sync. --- changelogs: v2: - split code style change and performace fix. Keqian Zhu (2): memory: Introduce start_global variable in dirty bitmap sync migration: not require length align when choose fast dirty

[PATCH v2 1/2] memory: Introduce start_global variable in dirty bitmap sync

In the cpu_physical_memory_sync_dirty_bitmap func, use start_global variable to make code more clear. And the addr variable is only used in slow path, so move it to slow path. Signed-off-by: Keqian Zhu --- include/exec/ram_addr.h | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-)

[PATCH v2 2/2] migration: not require length align when choose fast dirty sync path

In commit aa777e297c84 ("cpu_physical_memory_sync_dirty_bitmap: Another alignment fix"), ramblock length is required to align word pages when we choose the fast dirty sync path. The reason is that "If the Ramblock is less than 64 pages in length that long can contain bits representing two different

Re: [PATCH v8] s390x: ipl: Consolidate iplb validity check into one function

On 10.03.20 10:09, Janosch Frank wrote: > It's nicer to just call one function than calling a function for each > possible iplb type. > > Signed-off-by: Janosch Frank > Reviewed-by: David Hildenbrand thanks applied.

Re: [PATCH 05/14] hw/i386/vmport: Report VMX type in CMD_GETVERSION

On Tue, Mar 10, 2020 at 01:54:02AM +0200, Liran Alon wrote: > As can be seen from VmCheck_GetVersion() in open-vm-tools code, > CMD_GETVERSION should return VMX type in ECX register. > > Default is to fake host as VMware ESX server. But user can control > this value by "-global vmport.vmx-type=X".

Re: [PATCH v8] s390x: ipl: Consolidate iplb validity check into one function

On 10.03.20 10:11, Christian Borntraeger wrote: > > > On 10.03.20 10:09, Janosch Frank wrote: >> It's nicer to just call one function than calling a function for each >> possible iplb type. >> >> Signed-off-by: Janosch Frank >> Reviewed-by: David Hildenbrand > > David, still ok? If yes I will

Re: [PATCH v8 2/2] s390x: protvirt: Support unpack facility

On 3/10/20 10:00 AM, David Hildenbrand wrote: > On 10.03.20 09:32, Janosch Frank wrote: >> The unpack facility provides the means to setup a protected guest. A >> protected guest can not be introspected by the hypervisor or any >> user/administrator of the machine it is running on. >> >> Protected

Re: [PATCH 07/14] hw/i386/vmport: Add support for CMD_GETBIOSUUID

On Tue, Mar 10, 2020 at 01:54:04AM +0200, Liran Alon wrote: > This is VMware documented functionallity that some guests rely on. > Returns the BIOS UUID of the current virtual machine. > > Reviewed-by: Nikita Leshenko > Signed-off-by: Liran Alon > --- > hw/i386/vmport.c | 14 ++

Re: [Question] About GET LBA STATUS(16) support in qemu scsi emulation layer

On Tue, Mar 10, 2020 at 06:18:00AM +, Lin Ma wrote: > First of all, Thanks for your reply, Stefan. > > We know that the GET LBA STATUS works well under scsi lun passthrough due to > the vm directly talks to the scsi target. > I'm curious that if I use file backend image(say qcow2) + qemu scsi

[Bug 1859989] Re: qemu-img has broken output with large snapshot names

Fixed here: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=804359b8b90f ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1859989 Title: qemu-i

[Bug 1860920] Re: qemu-s390x-softmmu: crash

Fixed here: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=0bab189c96c7 ** Changed in: qemu Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1860920 Title:

Re: [PATCH v8 2/2] s390x: protvirt: Support unpack facility

On 10.03.20 10:00, David Hildenbrand wrote: > > Now that we talked about cached values, what about > > #if !defined(CONFIG_USER_ONLY) > static bool s390_is_pv(void) > { > static S390CcwMachineState *ccw; > Object *obj; > > if (ccw) { > return ccw->pv; > } > > /*

[Bug 1863025] Re: Use-after-free after flush in TCG accelerator

Fixed here: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=886cc68943eb ** Changed in: qemu Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1863025 Title:

[Bug 1857640] Re: qemu-system-i386 registers clobbered after gdb set due to k_gs_base bug in gdbstub

Fixed here: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=5a07192a042e ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1857640 Title: qemu-s

[Bug 1858488] Re: qemu git && 4.2: timed audio issues with sb16, gus not working?

Fixed here: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=fdc8c5f4717f ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1858488 Title: qemu g

Re: Any interest in dwc-otg (aka dwc2) device emulation? For Raspi 3 and below.

On Sat, 7 Mar 2020 at 00:34, Paul Zimmerman wrote: > > Hi Folks, > > I have been working on an emulation of the dwc-otg USB controller > (host mode only for now), as implemented on the Raspberry Pi 3 and > below, and on numerous other embedded platforms. I have it to a point > where it works prett

Re: [PATCH 12/14] i386/cpu: Store LAPIC bus frequency in CPU structure

On Tue, Mar 10, 2020 at 01:54:09AM +0200, Liran Alon wrote: > No functional change. > This information will be used by following patches. > > Reviewed-by: Nikita Leshenko > Signed-off-by: Liran Alon > --- > linux-headers/asm-x86/kvm.h | 4 > target/i386/cpu.h | 1 + > target/i386

Re: [PATCH v7 02/15] s390x: protvirt: Support unpack facility

On 09.03.20 15:40, Christian Borntraeger wrote: > something like the following? > > > diff --git a/target/s390x/cpu.c b/target/s390x/cpu.c > index c513f8efe0..cd12c29b9a 100644 > --- a/target/s390x/cpu.c > +++ b/target/s390x/cpu.c > @@ -185,13 +185,18 @@ static void s390_cpu_disas_set_info(CPU

Re: [PATCH 14/14] hw/i386/vmport: Assert vmport initialized before registering commands

On Tue, Mar 10, 2020 at 01:54:11AM +0200, Liran Alon wrote: > vmport_register() is also called from other modules such as vmmouse. > Therefore, these modules rely that vmport is realized before those call > sites. If this is violated, vmport_register() will NULL-deref. > > To make such issues easi

Re: [PATCH v8 2/2] s390x: protvirt: Support unpack facility

>>> +case S390_RESET_PV: /* Subcode 10 */ >>> +subsystem_reset(); >>> +s390_crypto_reset(); >>> + >>> +CPU_FOREACH(t) { >>> +if (t == cs) { >>> +continue; >>> +} >>> +run_on_cpu(t, s390_do_cpu_full_reset, RUN_ON_CPU_NUL

Re: [PATCH 06/14] hw/i386/vmport: Define enum for all commands

On Tue, Mar 10, 2020 at 01:54:03AM +0200, Liran Alon wrote: > No functional change. > > Defining an enum for all VMPort commands have the following advantages: > * It gets rid of the error-prone requirement to update VMPORT_ENTRIES > when new VMPort commands are added to QEMU. > * It makes it clea

Re: [RFC PATCH 2/2] GitLab CI: crude mapping of PMM's scripts to jobs

On Tue, 10 Mar 2020 at 05:01, Cleber Rosa wrote: > Thanks for the very straight answers here. I'll work > on those two remaining points (windows cross builds, and > incremental builds). I did wonder if incremental build was going to be awkward to test in a CI setup. Anyway, I think it would be

Re: [PATCH 04/14] hw/i386/vmport: Introduce vmx-version property

On Tue, Mar 10, 2020 at 01:54:01AM +0200, Liran Alon wrote: > Instead of hard-coding the VMX version, make it a VMPORT object property. > This would allow user to control it's value via "-global > vmport.vmx-version=X". > > Reviewed-by: Nikita Leshenko > Signed-off-by: Liran Alon More detail o

Re: [PATCH 07/14] hw/i386/vmport: Add support for CMD_GETBIOSUUID

On Tue, Mar 10, 2020 at 01:54:04AM +0200, Liran Alon wrote: > This is VMware documented functionallity that some guests rely on. > Returns the BIOS UUID of the current virtual machine. > > Reviewed-by: Nikita Leshenko > Signed-off-by: Liran Alon So this at least seems guest-visible. So I suspe

Re: [PATCH] modules: load modules from versioned /var/run dir

On Fri, Mar 06, 2020 at 02:26:48PM +0100, Christian Ehrhardt wrote: > On upgrades the old .so files usually are replaced. But on the other > hand since a qemu process represents a guest instance it is usually kept > around. > > That makes late addition of dynamic features e.g. 'hot-attach of a cep

Re: [PATCH v4 2/3] mac_via: fix incorrect creation of mos6522 device in mac_via

On Tue, 10 Mar 2020 at 09:08, Markus Armbruster wrote: > We have >200 calls of sysbus_init_child_obj() in some 40 files. I'm > arbitrarily picking hw/arm/allwinner-a10.c for a closer look. > > It calls it from device allwinner-a10's .instance_init() method > aw_a10_init(). Side effect, clearly w

Re: [PATCH v3 1/2] spapr: Disable legacy virtio devices for pseries-5.0 and later

On Thu, 5 Mar 2020 11:31:46 +0100 Greg Kurz wrote: > On Thu, 5 Mar 2020 15:30:08 +1100 > David Gibson wrote: > > > PAPR specifies a kind of odd, paravirtualized PCI bus, which looks to > > the guess mostly like classic PCI, even if some of the individual > > devices on the bus are PCI Express.

Re: [PATCH v2] qom-qmp-cmds: fix two memleaks in qmp_object_add

On Tue, Mar 10, 2020 at 02:46:40PM +0800, Pan Nengyuan wrote: > 'type/id' forgot to free in qmp_object_add, this patch fix that. > > The leak stack: > Direct leak of 84 byte(s) in 6 object(s) allocated from: > #0 0x7fe2a5ebf768 in __interceptor_malloc (/lib64/libasan.so.5+0xef768) > #1 0x7

Re: [PATCH v3 4/4] qemu-img: Deprecate use of -b without -F

On Mon, Mar 09, 2020 at 10:42:25AM -0500, Eric Blake wrote: > On 3/9/20 10:31 AM, Kashyap Chamarthy wrote: > > > After (with the patch series applied to QEMU Git): > > > > $> git describe > > v4.2.0-2204-gd6c7830114 > > > > # Create; *without* specifying "-F raw" > > $> ~/bui

Re: [PATCH RESEND v2] block/nvme: introduce PMR support from NVMe 1.4 spec

On Fri, Mar 06, 2020 at 03:38:53PM -0700, Andrzej Jakowski wrote: > diff --git a/hw/block/nvme.c b/hw/block/nvme.c > index d28335cbf3..ff7e74d765 100644 > --- a/hw/block/nvme.c > +++ b/hw/block/nvme.c > @@ -19,10 +19,14 @@ > * -drive file=,if=none,id= > * -device nvme,drive=,serial=,i

Re: Any interest in dwc-otg (aka dwc2) device emulation? For Raspi 3 and below.

On Mon, Mar 09, 2020 at 08:15:33PM -0700, Paul Zimmerman wrote: > Hi John, > > Thanks for the tips! I found an issue when testing with the usb-storage > device, so I will work on fixing that, and then think about how best to > split up the patches. Please CC Gerd Hoffmann (QEMU USB maintainer) wh

Re: [PATCH v3 1/2] spapr: Disable legacy virtio devices for pseries-5.0 and later

On Tue, Mar 10, 2020 at 10:43:29AM +0100, Greg Kurz wrote: > On Thu, 5 Mar 2020 11:31:46 +0100 > Greg Kurz wrote: > > > On Thu, 5 Mar 2020 15:30:08 +1100 > > David Gibson wrote: > > > > > PAPR specifies a kind of odd, paravirtualized PCI bus, which looks to > > > the guess mostly like classic

Re: I am trying to fixes a issue with QEMU with VxWorks.

On Mon, Mar 09, 2020 at 11:26:07AM +0800, 罗勇刚(Yonggang Luo) wrote: > When I am running QEMU to simulating PowerPC. > And after running the following powerpc code: > 00e2b5dc : > intUnlock(): > e2b5dc: 54 63 04 20 rlwinm r3,r3,0,16,16 > e2b5e0: 7c 80 00 a6 mfmsr r4 > e2b5e4: 7c 83 1b 78 or r3,

[Bug 1866792] [NEW] formating vdi-disk over nbd fails

Public bug reported: Hi, after creating a vdi-image with qemu-vdi and attaching it with qemu-nbd partitioning works fine, but the system hangs up during formating with mkfs.ext4. Same procedure with qcow2-image works fine Tested on Fedora 31 kernel 5.5.7-200.fc31.x86_64 - #!

Re: [PATCH v7 07/17] target/ppc: Use class fields to simplify LPCR masking

On 3/3/20 4:43 AM, David Gibson wrote: > When we store the Logical Partitioning Control Register (LPCR) we have a > big switch statement to work out which are valid bits for the cpu model > we're emulating. > > As well as being ugly, this isn't really conceptually correct, since it is > based on t

Re: Wiki account creation request

On Mon, Mar 09, 2020 at 11:29:34PM +0600, Adema Yergara wrote: > I understand that I subscribed to your mailing lit now but what about the > point > - To create an account in the QEMU wiki, you must ask on the mailing list > for someone else to do it on your behalf (self-creation is prohibited to >

Re: [PATCH v4 3/4] Introduce the NVMM impl

On 10.03.2020 07:45, Maxime Villard wrote: > Le 02/03/2020 à 20:35, Paolo Bonzini a écrit : >> >> >> Il lun 2 mar 2020, 20:28 Maxime Villard > > ha scritto: >> >> >> >> +        nvmm_vcpu_pre_run(cpu); >> >> + >> >> +        if (atomic_read(&cpu->exit_request))

Re: [PATCH v2 3/4] virtio-net: implement RX RSS processing

On Tue, Mar 10, 2020 at 5:10 AM Jason Wang wrote: > > > On 2020/3/9 下午4:34, Yuri Benditovich wrote: > > If VIRTIO_NET_F_RSS negotiated and RSS is enabled, process > > incoming packets, calculate packet's hash and place the > > packet into respective RX virtqueue. > > > > Signed-off-by: Yuri Bendit

Re: [kvm-unit-tests PATCH v4 00/13] arm/arm64: Add ITS tests

On 2020/3/9 20:00, Andrew Jones wrote: On Mon, Mar 09, 2020 at 12:57:51PM +0100, Andrew Jones wrote: This looks pretty good to me. It just needs some resquashing cleanups. Does Andre plan to review? I've only been reviewing with respect to the framework, not ITS. If no other reviews are expected

Re: [RFC] cpus: avoid get stuck in pause_all_vcpus

Patchew URL: https://patchew.org/QEMU/20200310091443.1326-1-longpe...@huawei.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash exp

Re: [PATCH v2 4/4] virtio-net: block migration if RSS feature negotiated

IMO, this does not depend on features of vhost as soon as we're not able to provide parameters to it. On Tue, Mar 10, 2020 at 8:17 AM Michael S. Tsirkin wrote: > On Tue, Mar 10, 2020 at 11:12:05AM +0800, Jason Wang wrote: > > > > On 2020/3/9 下午4:34, Yuri Benditovich wrote: > > > Block migration

Re: [PATCH v2 2/4] virtio-net: implement RSS configuration command

On Tue, Mar 10, 2020 at 5:02 AM Jason Wang wrote: > > On 2020/3/9 下午4:34, Yuri Benditovich wrote: > > Optionally report RSS feature. > > Handle RSS configuration command and keep RSS parameters > > in virtio-net device context. > > > > Signed-off-by: Yuri Benditovich > > --- > > hw/net/trace-e

[PATCH v4 01/21] linux-user: introduce parameters to generate syscall_nr.h

This will be used when we'll import syscall.tbl from the kernel Add a script to remove all the dependencies to syscall_nr.h that point to source directory and not to the build directory. The list of arch will be update while the generated files are added. Signed-off-by: Laurent Vivier Reviewed-b

[PATCH v4 00/21] linux-user: generate syscall_nr.sh

This series copies the files syscall.tbl from linux v5.5 and generates the file syscall_nr.h from them. This is done for all the QEMU targets that have a syscall.tbl in the linux source tree: mips, mips64, i386, x86_64, sparc, s390x, ppc, arm, microblaze, sh4, xtensa, m68k, hppa and alpha. tilegx

[PATCH v4 18/21] linux-user, scripts: add a script to update syscall.tbl

scripts/update-syscalltbl.sh has the list of syscall.tbl to update and can copy them from the linux source directory Signed-off-by: Laurent Vivier Reviewed-by: Taylor Simpson --- MAINTAINERS | 1 + scripts/update-syscalltbl.sh | 49 2 files

[PATCH v4 06/21] linux-user, sh4: add syscall table generation support

Copy syscall.tbl and syscallhdr.sh from linux/arch/sh/kernel/syscalls v5.5 Update syscallhdr.sh to generate QEMU syscall_nr.h Signed-off-by: Laurent Vivier Reviewed-by: Taylor Simpson --- configure| 3 +- linux-user/Makefile.objs | 1 + linux-user/sh4/Makefile.objs |

[PATCH v4 13/21] linux-user, x86_64, i386: cleanup TARGET_NR_arch_prctl

Define do_arch_prctl() for i386 and x86_64, but return -TARGET_ENOSYS for i386. Signed-off-by: Laurent Vivier Reviewed-by: Taylor Simpson --- linux-user/i386/target_cpu.h | 4 ++-- linux-user/syscall.c | 19 +++ 2 files changed, 13 insertions(+), 10 deletions(-) diff -

  1   2   3   4   5   6   >