From: Chen Qun
Clang static code analyzer show warning:
monitor/hmp-cmds.c:2867:17: warning: Value stored to 'set' is never read
set = true;
^
Reported-by: Euler Robot
Signed-off-by: Chen Qun
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Laurent Viv
From: Pan Nengyuan
Fix a memory leak in qdev_get_gpio_out_connector().
Reported-by: Euler Robot
Signed-off-by: Pan Nengyuan
Reviewed-by: Marc-André Lureau
Message-Id: <20200307030756.5913-1-pannengy...@huawei.com>
Signed-off-by: Laurent Vivier
---
hw/core/qdev.c | 2 +-
1 file changed, 1 in
From: Philippe Mathieu-Daudé
hw/hppa/machine.c uses NICInfo variables which are declared in
"net/net.h". Include it.
This fixes (when modifying unrelated headers):
hw/hppa/machine.c:126:21: error: use of undeclared identifier 'nb_nics'
for (i = 0; i < nb_nics; i++) {
From: Chen Qun
Clang static code analyzer show warning:
hw/dma/xlnx-zdma.c:399:13: warning: Value stored to 'dst_type' is never read
dst_type = FIELD_EX32(s->dsc_dst.words[3], ZDMA_CH_DST_DSCR_WORD3,
^ ~~~
Repor
From: Finn Thain
A portion of a recent patch got lost due to a merge snafu. That patch is
now commit 88f632fbb1 ("dp8393x: Mask EOL bit from descriptor addresses").
This patch restores the portion that got lost.
Signed-off-by: Finn Thain
Reviewed-by: Laurent Vivier
Reviewed-by: Philippe Mathie
From: Chen Qun
Clang static code analyzer show warning:
block/file-posix.c:891:9: warning: Value stored to 'op' is never read
op = RAW_PL_ABORT;
^
Reported-by: Euler Robot
Signed-off-by: Chen Qun
Reviewed-by: Kevin Wolf
Message-Id: <20200302130715.29440-5-kuh
From: Chen Qun
Clang static code analyzer show warning:
scsi/scsi-disk.c:1918:5: warning: Value stored to 'buflen' is never read
buflen = req->cmd.xfer;
^~
Reported-by: Euler Robot
Signed-off-by: Chen Qun
Reviewed-by: Laurent Vivier
Message-Id: <20200302130715.2944
Patchew URL:
https://patchew.org/QEMU/20200309145155.168942-1-marcandre.lur...@redhat.com/
Hi,
This series failed the docker-clang@ubuntu build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT
From: Chen Qun
Clang static code analyzer show warning:
hw/display/exynos4210_fimd.c:1313:17: warning: Value stored to 'is_dirty' is
never read
is_dirty = false;
Reported-by: Euler Robot
Signed-off-by: Chen Qun
Reviewed-by: Laurent Vivier
Message-Id: <20200302130715.29440-9-k
On Mon, 9 Mar 2020 15:51:55 +0100
Marc-André Lureau wrote:
> Fixes: fe64d06afc1c5d895f220c268cfe4d5f1e65d44e ("vl.c: ensure that
> ram_size matches size of machine.memory-backend")
> Signed-off-by: Marc-André Lureau
Reviewed-by: Igor Mammedov
> ---
> softmmu/vl.c | 5 +
> 1 file changed
From: Philippe Mathieu-Daudé
The "ioapic_internal.h" does not use anything from
"hw/i386/ioapic.h", remove it.
Acked-by: John Snow
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
Message-Id: <20200228114649.12818-4-phi...@redhat.com>
Signed-off-by: Laurent Vivier
---
in
From: Chen Qun
Clang static code analyzer show warning:
hw/display/pxa2xx_lcd.c:596:9: warning: Value stored to 'format' is never read
format = 0;
^~
Reported-by: Euler Robot
Signed-off-by: Chen Qun
Reviewed-by: Laurent Vivier
Message-Id: <20200302130715.29440-8-kuhn.c
Am 06.03.2020 um 23:51 hat Eric Blake geschrieben:
> For qcow2 and qed, we want to encourage the use of -F always, as these
> formats can suffer from data corruption or security holes if backing
> format is probed. But for other formats, the backing format cannot be
> recorded. Making the user de
From: Philippe Mathieu-Daudé
hw/timer/hpet.c calls address_space_stl_le() declared in
"exec/address-spaces.h". Include it.
This fixes (when modifying unrelated headers):
hw/timer/hpet.c:210:31: error: use of undeclared identifier
'address_space_memory'
address_space_stl_le(&address
On 3/9/20 2:10 PM, Peter Maydell wrote:
On Mon, 9 Mar 2020 at 12:11, Philippe Mathieu-Daudé wrote:
cpu_reset() might modify architecture-specific fields allocated
by qemu_init_vcpu(). To avoid bugs similar to the one fixed in
commit 00d0f7cb66 when introducing new architectures, assert a
vCPU
On Tue, 03 Mar 2020 13:58:24 -0600
Babu Moger wrote:
> Apicid calculation depends on knowing the total number of numa nodes
> for EPYC cpu models. Right now, we are calculating the arch_id while
> parsing the numa(parse_numa). At this time, it is not known how many
> total numa nodes are configur
On Mon, Mar 09, 2020 at 04:21:12PM +0100, Kevin Wolf wrote:
> Am 06.03.2020 um 23:51 hat Eric Blake geschrieben:
> > For qcow2 and qed, we want to encourage the use of -F always, as these
> > formats can suffer from data corruption or security holes if backing
> > format is probed. But for other f
Hi
On Wed, Mar 4, 2020 at 6:28 PM Igor Mammedov wrote:
>
> Migration from QEMU(v4.0) fails when using 3.1 or older machine
> type. For example if one attempts to migrate
> QEMU-2.12 started as
> qemu-system-ppc64 -nodefaults -M pseries-2.12 -m 4096 -mem-path /tmp/
> to current master, it will f
From: Philippe Mathieu-Daudé
All this files use methods/definitions declared in the NVDIMM
device header. Include it.
This fixes (when modifying unrelated headers):
hw/i386/acpi-build.c:2733:9: error: implicit declaration of function
'nvdimm_build_acpi' is invalid in C99 [-Werror,-Wimplicit-
On 3/9/20 10:21 AM, Kevin Wolf wrote:
Am 06.03.2020 um 23:51 hat Eric Blake geschrieben:
For qcow2 and qed, we want to encourage the use of -F always, as these
formats can suffer from data corruption or security holes if backing
format is probed. But for other formats, the backing format cannot
On 3/9/20 3:48 PM, Peter Maydell wrote:
On Mon, 9 Mar 2020 at 14:45, Philippe Mathieu-Daudé wrote:
We must not write more data than the memory region size.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/core/loader.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/hw
On 3/9/20 10:31 AM, Kashyap Chamarthy wrote:
After (with the patch series applied to QEMU Git):
$> git describe
v4.2.0-2204-gd6c7830114
# Create; *without* specifying "-F raw"
$> ~/build/qemu/qemu-img create -f qcow2 -b ./base.raw ./overlay2.qcow2
qemu-img: warning: De
From: Chen Qun
Clang static code analyzer show warning:
block/stream.c:186:9: warning: Value stored to 'ret' is never read
ret = 0;
^ ~
Reported-by: Euler Robot
Signed-off-by: Chen Qun
Reviewed-by: John Snow
Reviewed-by: Kevin Wolf
Message-Id: <20200302130715.29440-3-kuh
On 3/9/20 2:37 PM, David Hildenbrand wrote:
> On 09.03.20 12:21, Janosch Frank wrote:
>> The unpack facility provides the means to setup a protected guest. A
>> protected guest can not be introspected by the hypervisor or any
>> user/administrator of the machine it is running on.
>>
>> Protected gu
Our current QAPI doc-comment markup allows section headers
(introduced with a leading '=' or '==') anywhere in any documentation
comment. This works for texinfo because the texi generator simply
prints a texinfo heading directive at that point in the output
stream. For rST generation, since we're
On Mon, 09 Mar 2020 15:09:21 +0100
Christian Schoenebeck wrote:
> On Dienstag, 21. Januar 2020 01:30:10 CET Christian Schoenebeck wrote:
> > Make top half really top half and bottom half really bottom half:
> >
> > Each T_readdir request handling is hopping between threads (main
> > I/O thread a
On Tue, 03 Mar 2020 13:58:30 -0600
Babu Moger wrote:
> If the system is numa configured the pkg_offset needs
> to be adjusted for EPYC cpu models. Fix it calling the
> model specific handler.
>
> Signed-off-by: Babu Moger
Reviewed-by: Igor Mammedov
> ---
> hw/i386/pc.c |1 +
> targ
As we accumulate lines from doc comments when parsing the JSON, the
QAPIDoc class generally strips leading and trailing whitespace using
line.strip() when it calls _append_freeform(). This is fine for
texinfo, but for rST leading whitespace is significant. We'd like to
move to having the text in
Convert qemu-ga-ref to rST format. This includes dropping
the plain-text, pdf and info format outputs for this document;
as with all our other Sphinx-based documentation, we provide
HTML and manpage only.
The qemu-ga-ref.rst is somewhat more stripped down than
the .texi was, because we do not (cur
On 09.03.20 12:21, Janosch Frank wrote:
> SCLP for a protected guest is done over the SIDAD, so we need to use
> the s390_cpu_pv_mem_* functions to access the SIDAD instead of guest
> memory when reading/writing SCBs.
>
> To not confuse the sclp emulation, we set 0x4000 as the SCCB address,
> sinc
Some of our documentation is auto-generated from documentation
comments in the JSON schema.
For Sphinx, rather than creating a file to include, the most natural
way to handle this is to have a small custom Sphinx extension which
processes the JSON file and inserts documentation into the rST
file b
Make the handling of indentation in doc comments more sophisticated,
so that when we see a section like:
Notes: some text
some more text
indented line 3
we save it for the doc-comment processing code as:
some text
some more text
indented line 3
and when we see a section with
Convert qemu-qmp-ref to rST format. This includes dropping
the plain-text, pdf and info format outputs for this document;
as with all our other Sphinx-based documentation, we provide
HTML and manpage only.
The qemu-qmp-ref.rst is somewhat more stripped down than
the .texi was, because we do not (c
Update the documentation of QAPI document comment syntax to match
the new rST backend requirements. The principal changes are:
* whitespace is now significant, and multiline definitions
must have their second and subsequent lines indented to
match the first line
* general rST format markup
We no longer use the generated texinfo format documentation,
so delete the code that generates it, and the test case for
the generation.
Signed-off-by: Peter Maydell
---
Makefile| 1 -
tests/Makefile.include | 15 +-
scripts/qapi-gen.py | 2 -
sc
On Fri, Mar 06, 2020 at 04:51:21PM -0600, Eric Blake wrote:
> Creating an image that requires format probing of the backing image is
> inherently unsafe (we've had several CVEs over the years based on
> probes leaking information to the guest on a subsequent boot, although
> these days tools like l
We now don't build anything from Texinfo, so we can remove
some redundant Makefile pattern rules and the rule for
generating the version.texi file that used to be included
from many Texinfo source files.
Signed-off-by: Peter Maydell
---
Makefile | 31 +--
rules.mak |
We don't need the texinfo and pod2man programs to build our documentation
any more, so remove them from configure's tests.
Signed-off-by: Peter Maydell
---
configure | 12 ++--
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/configure b/configure
index fab6281eb70..3b64213
On Mon, 9 Mar 2020 at 12:51, Markus Armbruster wrote:
>
> The following changes since commit 67f17e23baca5dd545fe98b01169cc351a70fe35:
>
> Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging
> (2020-03-06 17:15:36 +)
>
> are available in the Git repository at:
>
>
We no longer need the texi2pod script, so we can delete it, and
the special-casing it had in the checkpatch script.
Signed-off-by: Peter Maydell
---
scripts/checkpatch.pl | 2 +-
scripts/texi2pod.pl | 536 --
2 files changed, 1 insertion(+), 537 deleti
On 3/9/20 12:43 PM, Roman Kapl wrote:
On 3/5/20 11:37 PM, Alex Williamson wrote:
On Fri, 28 Feb 2020 13:08:00 +0100
Roman Kapl wrote:
For MSI-X interrupts, remember what the last used eventfd was (KVM
bypass vs QEMU) and only call vfio_set_irq_signaling if it has changed.
This not only hel
We don't use Texinfo any more; we can remove the references to the
.texi source files and the generated output files from our
.gitignore and git.orderfile.
Signed-off-by: Peter Maydell
---
.gitignore| 15 ---
scripts/git.orderfile | 1 -
2 files changed, 16 deletions(-)
We don't need texinfo to build the docs any more, so we can
drop that dependency from our docker and other CI configs.
Signed-off-by: Peter Maydell
---
.travis.yml| 1 -
tests/docker/dockerfiles/debian10.docker | 1 -
tests/docker/dockerfiles/debian9.docker|
Commits 6a9ad1542065ca0bd54c6 and 9004db48c080632aef23 added some
new text to qapi/migration.json which doesn't fit the stricter
indentation requirements imposed by the rST documentation generator.
Reindent those lines to the new standard.
Signed-off-by: Peter Maydell
---
qapi/migration.json | 6
This series switches all our QAPI doc comments over from
texinfo format to rST. It then removes all the texinfo
machinery, because this was the last user of texinfo.
I would ideally like to get this into the release, though
the softfreeze date is now approaching rapidly...
Based-on: 2020030617174
On 3/9/20 10:48 AM, Kevin Wolf wrote:
Still, the point of this patch is that I want to add -F into all the
iotests, and without something along the lines of this patch, all of those
iotests are broken for these image formats. Patch 2 is a lot harder to
write if we have to make our use of -F con
Am 09.03.2020 um 16:32 hat Eric Blake geschrieben:
> On 3/9/20 10:21 AM, Kevin Wolf wrote:
> > Am 06.03.2020 um 23:51 hat Eric Blake geschrieben:
> > > For qcow2 and qed, we want to encourage the use of -F always, as these
> > > formats can suffer from data corruption or security holes if backing
>
For rST, '*' is a kind of inline markup (for emphasis), so
"*-softmmu" is a syntax error because of the missing closing '*'.
Escape the '*' with a '\'.
The texinfo document generator will leave the '\' in the
output, which is not ideal, but that generator is going to
go away in a subsequent commit
On 3/9/20 10:36 AM, Daniel P. Berrangé wrote:
On Mon, Mar 09, 2020 at 04:21:12PM +0100, Kevin Wolf wrote:
Am 06.03.2020 um 23:51 hat Eric Blake geschrieben:
For qcow2 and qed, we want to encourage the use of -F always, as these
formats can suffer from data corruption or security holes if backin
doc-good.json tests some oddities of markup that we don't want to
accept. Make them match the more restrictive rST syntax:
* in a single list the bullet types must all match
* lists must have leading and following blank lines
* indentation is important
* the '|' example syntax is going to go
On 3/9/20 10:44 AM, Daniel P. Berrangé wrote:
Consider the user creates an image with "-F raw". We can validate the backing
image is raw, and so our check succeeds. Later the malicious can
write a qcow header into this raw file and QEMU will thereafter probe the
image as qcow, not raw.
IOW, i
There are exactly two places in our json doc comments where we
use the markup accepted by the texi doc generator where a '|' in
the first line of a doc comment means the line should be emitted
as a literal block (fixed-width font, whitespace preserved).
Since we use this syntax so rarely, instead
Add some section headings to the QGA json; this is purely so that we
have some H1 headings, as otherwise each command ends up being
visible in the interop/ manual's table of contents. In an ideal
world there might be a proper 'Introduction' section the way there is
in qapi/qapi-schema.json.
Signe
On Mon, Mar 09, 2020 at 10:32:52AM -0500, Eric Blake wrote:
> On 3/9/20 10:21 AM, Kevin Wolf wrote:
> > Am 06.03.2020 um 23:51 hat Eric Blake geschrieben:
> > > For qcow2 and qed, we want to encourage the use of -F always, as these
> > > formats can suffer from data corruption or security holes if
>>
>>> +CPUS390XState *env;
>>>
>>> /* get the reset parameters, reset them once done */
>>> s390_ipl_get_reset_request(&cs, &reset_type);
>>> @@ -327,9 +411,16 @@ static void s390_machine_reset(MachineState *machine)
>>> /* all CPUs are paused and synchronized at this point
Am 09.03.2020 um 16:44 hat Daniel P. Berrangé geschrieben:
> We could support "-F ..." and validate any non-raw formats, while raising a
> runtime error in the case of "-F raw", as only the "raw" backing format has
> the probing security risk.
>
> Users who need to use qcow, with a backing file,
On 09/03/2020 14:14, Markus Armbruster wrote:
> Pan Nengyuan writes:
>
>> On 3/9/2020 8:34 PM, Markus Armbruster wrote:
>>> Peter Maydell writes:
>>>
On Mon, 9 Mar 2020 at 10:02, Pan Nengyuan wrote:
> On 3/9/2020 5:21 PM, Peter Maydell wrote:
>> Could you explain more? My thought
On 3/9/20 4:27 PM, David Hildenbrand wrote:
> On 09.03.20 12:21, Janosch Frank wrote:
>> SCLP for a protected guest is done over the SIDAD, so we need to use
>> the s390_cpu_pv_mem_* functions to access the SIDAD instead of guest
>> memory when reading/writing SCBs.
>>
>> To not confuse the sclp em
On 08/03/2020 13:39, Peter Maydell wrote:
> On Sun, 8 Mar 2020 at 11:58, Mark Cave-Ayland
> wrote:
>> I just tried this patchset applied on top of git master and it causes
>> qemu-system-ppc
>> to segfault on startup:
>>
>> $ gdb --args ./qemu-system-ppc
>> ...
>> ...
>> Thread 1 "qemu-system-pp
On Thu, Mar 05, 2020 at 06:32:07AM +0100, Markus Armbruster wrote:
> Cc'ing people listed by "scripts/get_maintainer.pl -f target/i386/hax*".
>
Thanks! get_maintainer.pl output here is a bit misleading. We
have no maintainers listed for the hax accel. CCing the original
authors, hoping they ca
* Maxim Levitsky (mlevi...@redhat.com) wrote:
>
> I see that I have the same issue of long subject line here.
> Its because I forgot the space after first line, when adding this.
> If I need to resend another version of this patchset I'll fix this,
> but otherwise maybe that can be fixed when appl
On 05/03/20 06:32, Markus Armbruster wrote:
> Cc'ing people listed by "scripts/get_maintainer.pl -f target/i386/hax*".
>
> Rui Prior writes:
>
>> Dear qemu developers,
>>
>> I found a bug/limitation of qemu on windows (qemu-w64-setup-20200201.exe
>> from https://qemu.weilnetz.de/w64/ ) that make
On 2/6/20 12:26 PM, Cédric Le Goater wrote:
> Hello,
>
> We have been seeing a squashfs corruption on the witherspoon-bmc
> machine for quite some time. It boots but quickly after boot
> corruption errors start to fill the console. This machine has two BMC
> chips with UBIfs on them. The romulus-b
Patchew URL:
https://patchew.org/QEMU/20200309150837.3193387-1-laur...@vivier.eu/
Hi,
This series failed the docker-clang@ubuntu build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
On Mon, 2020-03-09 at 16:31 +, Dr. David Alan Gilbert wrote:
> * Maxim Levitsky (mlevi...@redhat.com) wrote:
> >
> > I see that I have the same issue of long subject line here.
> > Its because I forgot the space after first line, when adding this.
> > If I need to resend another version of thi
On 3/9/20 3:51 PM, Marc-André Lureau wrote:
Fixes: fe64d06afc1c5d895f220c268cfe4d5f1e65d44e ("vl.c: ensure that
ram_size matches size of machine.memory-backend")
Signed-off-by: Marc-André Lureau
Reviewed-by: Philippe Mathieu-Daudé
---
softmmu/vl.c | 5 +
1 file changed, 5 insert
On Fri, Mar 06, 2020 at 03:17:40PM +0100, Paolo Bonzini wrote:
> On 06/03/20 14:50, Stefan Hajnoczi wrote:
> >> Not sure I understand the "almost" part. If it's accessed only from
> >> aio_poll() it is protected via either AIO_WAIT_WHILE or the BQL, not by
> >> ctx->list_lock; if it's protected by
On Mon, Feb 24, 2020 at 10:34:04AM +, Stefan Hajnoczi wrote:
> QLIST_REMOVE() and friends leave dangling linked list pointers in the node
> that
> was removed. This makes it impossible to decide whether a node is currently
> in
> a list or not. It also makes debugging harder.
>
> Based-on:
On Mon, 9 Mar 2020 at 15:09, Laurent Vivier wrote:
>
> The following changes since commit 7a5853cec479a448edae0fb2aaf4e2f78c9c774d:
>
> Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging
> (2020-03-09 10:32:53 +)
>
> are available in the Git repository at:
>
> git:/
On Thu, Mar 05, 2020 at 05:07:59PM +, Stefan Hajnoczi wrote:
> A guest with 100 virtio-blk-pci,num-queues=32 devices only reaches 10k IOPS
> while a guest with a single device reaches 105k IOPS
> (rw=randread,bs=4k,iodepth=1,ioengine=libaio).
>
> The bottleneck is that aio_poll() userspace pol
On 09/03/2020 00:42, BALATON Zoltan wrote:
> Some machines operate in "non 100% native mode" where interrupts are
> fixed at legacy IDE interrupts and some guests expect this behaviour
> without checking based on knowledge about hardware. Even Linux has
> arch specific workarounds for this that ar
On Mon, 9 Mar 2020 at 16:32, Cédric Le Goater wrote:
>
> On 2/6/20 12:26 PM, Cédric Le Goater wrote:
> > Hello,
> >
> > We have been seeing a squashfs corruption on the witherspoon-bmc
> > machine for quite some time. It boots but quickly after boot
> > corruption errors start to fill the console.
On Sun, 1 Mar 2020 at 17:04, Guenter Roeck wrote:
>
> This patch series wires up the USB controllers on fsl-imx6 and fsl-imx6ul
> emulations.
>
> The first patch is a prerequisite for the following patches. It provides
> a dummy implementation of a register widely used on i.MX systems, and
> speci
On Sat, Mar 7, 2020 at 4:49 AM Bin Meng wrote:
>
> 32-bit machine should have its CPU's "mmu-type" set to "riscv,sv32".
>
> Signed-off-by: Bin Meng
Reviewed-by: Alistair Francis
Alistair
> ---
>
> hw/riscv/sifive_u.c | 4
> hw/riscv/spike.c| 4
> hw/riscv/virt.c | 4
>
Hi,
This is regarding the new VMDK format of SESparse snapshots which is
available since ESXi 6.5 (for disks > 2TB) and is default since ESXi
6.7 (for all disks).
Unlike the previous format (VMFSSparse), SESparse's format is not
disclosed by VMware.
Even though, I believe that the format itself i
On Fri, 6 Mar 2020 at 15:02, Philippe Mathieu-Daudé wrote:
>
> On 3/6/20 3:54 PM, Peter Maydell wrote:
> > On Fri, 6 Mar 2020 at 14:32, Philippe Mathieu-Daudé
> > wrote:
> >>
> >> On 3/6/20 2:47 PM, Peter Maydell wrote:
> >>> The old qemu-doc.html is no longer built, so update the Windows
> >>>
On Mon, Mar 09, 2020 at 05:09:21PM +, Peter Maydell wrote:
> On Sun, 1 Mar 2020 at 17:04, Guenter Roeck wrote:
> >
> > This patch series wires up the USB controllers on fsl-imx6 and fsl-imx6ul
> > emulations.
> >
> > The first patch is a prerequisite for the following patches. It provides
> >
I understand that I subscribed to your mailing lit now but what about the
point
- To create an account in the QEMU wiki, you must ask on the mailing list
for someone else to do it on your behalf (self-creation is prohibited to
cut down on spam accounts)
Who can create this for me?
On Mon, 9 Mar 2020 at 17:27, Guenter Roeck wrote:
> Sure, no problem; I don't really have a preference. What would be
> the best place for such a dummy phy ?
hw/usb, I guess. hw/usb/imx-usb-phy.c ?
thanks
-- PMM
> -Original Message-
> From: Qemu-devel bounces+tsimpson=quicinc@nongnu.org> On Behalf Of Philippe
> Mathieu-Daudé
> Sent: Monday, March 9, 2020 9:44 AM
> To: qemu-devel@nongnu.org
> Cc: Eduardo Habkost ; Michael S. Tsirkin
> ; Alistair Francis ; Mark Cave-
> Ayland ; qemu-...@nongnu
On 3/8/20 8:25 AM, Michael S. Tsirkin wrote:
> On Tue, Mar 03, 2020 at 01:56:51PM -0600, Babu Moger wrote:
>> This series fixes APIC ID encoding problem reported on AMD EPYC cpu models.
>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.redhat.com%2Fshow_bug.cgi%3Fid%3
The QCowL2Meta **m parameter is not used
Signed-off-by: Yi Li
---
block/qcow2-cluster.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
index 17f1363..db9efa5 100644
--- a/block/qcow2-cluster.c
+++ b/block/qcow2-cluster.c
@@ -
On 3/9/20 9:17 AM, Igor Mammedov wrote:
> On Tue, 03 Mar 2020 13:57:18 -0600
> Babu Moger wrote:
>
>> Store the smp sockets in CpuTopology. The socket information required to
>> build the apic id in EPYC mode. Right now socket information is not passed
>> to down when decoding the apic id. Ad
On Mon, Mar 2, 2020 at 11:51 AM Lirong Yuan wrote:
> On Mon, Mar 2, 2020 at 10:39 AM Laurent Vivier wrote:
> >
> > Le 02/03/2020 à 18:53, Lirong Yuan a écrit :
> > > On Mon, Mar 2, 2020 at 6:56 AM Laurent Vivier
> wrote:
> > >>
> > >> Le 29/02/2020 à 01:43, Lirong Yuan a écrit :
> > >>> On Fri,
2020/03/09 16:01, Eric Blake:
> On 3/7/20 11:22 AM, Unai Martinez-Corral wrote:
> > Spaces are added before '; then', for consistency.
>
> For consistency with what? This is not our prevailing style; as
> evidenced by this pre-patch search:
>
> $ git grep 'if \[.*\];' | wc
> 2742186 1
* Maxim Levitsky (mlevi...@redhat.com) wrote:
> This patch series is bunch of cleanups to the hmp monitor code.
> It mostly moves the blockdev related hmp handlers to its own file,
> and does some minor refactoring.
>
> No functional changes expected.
Queued for HMP, with the commit message fix u
On 3/9/20 1:20 PM, Unai Martinez Corral wrote:
2020/03/09 16:01, Eric Blake:
On 3/7/20 11:22 AM, Unai Martinez-Corral wrote:
Spaces are added before '; then', for consistency.
For consistency with what? This is not our prevailing style; as
evidenced by this pre-patch search:
$ git grep '
Hi,
This series reworks qemu-binfmt-conf.sh:
* Argument from option '--systemd' is generalized to , and it is
accepted for any mode (default, debian or systemd). It can be a single target
arch or a list of them.
* Option '-r|--clear' is added, which allows to remove an already registered
t
On Mon, 2020-03-09 at 18:30 +, Dr. David Alan Gilbert wrote:
> * Maxim Levitsky (mlevi...@redhat.com) wrote:
> > This patch series is bunch of cleanups to the hmp monitor code.
> > It mostly moves the blockdev related hmp handlers to its own file,
> > and does some minor refactoring.
> >
> > N
Hello,
On 200202 2038, Kővágó, Zoltán wrote:
> -void conv_natural_float_to_stereo(struct st_sample *dst, const void *src,
> - int samples)
> +#ifdef FLOAT_MIXENG
> +#define FLOAT_CONV_TO(x) (x)
> +#define FLOAT_CONV_FROM(x) (x)
> +#else
> +static const float float_s
Spaces are removed before '; then', for consistency.
All the tests are prefixed with 'x', in order to avoid risky comparisons
(i.e. a user deliberately trying to provoke a syntax error).
Signed-off-by: umarcor
Reviewed-by: Laurent Vivier
---
scripts/qemu-binfmt-conf.sh | 34 +--
This patch breaks backward compatibility.
Both '--persistent' and '--credential' default to 'no'. Hence, '-p no'
or '-c no' are redundant. Overall, accepting an argument might be
misleading because options are, indeed, boolean. This patch makes both
options boolean in getopt, so if any of them is
Allow to set options '--persistent' and/or '--credential' through
environment variables. If not defined, defaults are used ('no').
Anyway, command-line arguments have priority over environment variables.
Signed-off-by: umarcor
Reviewed-by: Laurent Vivier
---
scripts/qemu-binfmt-conf.sh | 18 +++
On Mon, Mar 9, 2020 at 6:08 AM Gerd Hoffmann wrote:
>
> On Fri, Mar 06, 2020 at 09:09:17AM -0500, Jason Andryuk wrote:
> > Currently usb-serial devices are unable to send data into guests with
> > the xhci controller. Data is copied into the usb-serial's buffer, but
> > it is not sent into the gu
This breaks brackward compatibility.
Option '--systemd CPU' allows to register binfmt interpreters for a
single target architecture or for 'ALL' (of them). This patch
generalizes the approach to support it in any mode (default, '--debian'
or '--systemd'). To do so, option 'systemd' is changed to b
Allow to set 'path' or 'suffix' through environment variables,
consistently with 'persistent' and 'credential'.
Signed-off-by: umarcor
Reviewed-by: Laurent Vivier
---
scripts/qemu-binfmt-conf.sh | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/scripts/qemu-binfmt-con
Signed-off-by: umarcor
Reviewed-by: Laurent Vivier
---
scripts/qemu-binfmt-conf.sh | 63 +++--
1 file changed, 32 insertions(+), 31 deletions(-)
diff --git a/scripts/qemu-binfmt-conf.sh b/scripts/qemu-binfmt-conf.sh
index 0c28db5ca4..870815fb22 100755
--- a/scrip
This breaks backward compatibility.
Options 'qemu-path' and 'qemu-suffix' have the 'qemu-' prefix, which is
not present in other option names ('debian', 'systemd', 'persistent',
'credential'...). In order to keep consistency, the prefix is removed.
Signed-off-by: umarcor
Reviewed-by: Laurent Viv
On 02.03.20 16:09, Vladimir Sementsov-Ogievskiy wrote:
> On success path we return what inflate() returns instead of 0. And it
> most probably works for Z_STREAM_END as it is positive, but is
> definitely broken for Z_BUF_ERROR.
>
> While being here, switch to errno return code, to be closer to
>
This is a partial implementation.
Allows to remove a single or a list of already registered binfmt
interpreters. Valid values are those in qemu_target_list.
If TARGETS is empty, all the existing 'qemu-*' interpreters are
removed.
This is partial because 'debian' and 'systemd' configurations are n
301 - 400 of 548 matches
Mail list logo
