Re: [PULL 000/136] Misc patches for 2020-02-25 (refactoring and Coccinelle edition)

2020-03-06 Thread Christian Borntraeger
On 25.02.20 12:48, Paolo Bonzini wrote: > The following changes since commit c1e667d2598b9b3ce62b8e89ed22dd38dfe9f57f: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' > into staging (2020-02-24 11:38:54 +) > > are available in the git repository at: > > >

Re: [PATCH v3 00/21] linux-user: generate syscall_nr.sh

2020-03-06 Thread Laurent Vivier
Le 06/03/2020 à 01:24, Taylor Simpson a écrit : > Reviewed-by: Taylor Simpson > > FWIW, the Hexagon Linux port does not use this mechanism. I can work with > our kernel maintainer and in the meantime create something suitable for qemu. Not needed, syscall.tbl are for the old archs that don't u

Re: [PATCH] audio: Add sndio backend

2020-03-06 Thread Gerd Hoffmann
> > > ERROR: g_free(NULL) is safe this check is probably not required > > > #381: FILE: audio/sndioaudio.c:318: > > > +if (self->pfds) { > > > +g_free(self->pfds); > > Reasonable too. > > Not clear to me. Leave as is or needs a change? Just use "g_free(self->pfds)". cheers, Gerd

Re: [PATCH qemu v7 0/5] spapr: Kill SLOF

2020-03-06 Thread Paolo Bonzini
On 06/03/20 02:17, Alexey Kardashevskiy wrote: >> Okay, that's great! I'll take a look next week. > > Any luck with this? Not really, perhaps today. But I don't object to already including a minimal version of this in 5.0 as long as: - it doesn't implement read and write - it is called x-

Re: [PATCH v3 0/7] hw/scsi/spapr_vscsi: Fix time bomb buffer overflow

2020-03-06 Thread Philippe Mathieu-Daudé
On 3/6/20 12:03 AM, David Gibson wrote: On Thu, Mar 05, 2020 at 01:12:46PM +0100, Philippe Mathieu-Daudé wrote: This series fixes a possible buffer overflow. Simples patches first (dissociate the buffer holding DMA requests with pointer to SRP Information Unit packets) to clean the issue in the

Re: [PULL 000/136] Misc patches for 2020-02-25 (refactoring and Coccinelle edition)

2020-03-06 Thread Christian Borntraeger
On 06.03.20 09:02, Christian Borntraeger wrote: > > On 25.02.20 12:48, Paolo Bonzini wrote: >> The following changes since commit c1e667d2598b9b3ce62b8e89ed22dd38dfe9f57f: >> >> Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' >> into staging (2020-02-24 11:38:54 +

Re: [PATCH] tests/docker: Install tools to cross-debug and build Linux kernels

2020-03-06 Thread Stefano Garzarella
On Wed, Feb 12, 2020 at 09:27:38PM +0100, Philippe Mathieu-Daudé wrote: > From: Philippe Mathieu-Daudé > > We often run Linux kernels to test QEMU. We sometimes need > to build them manually to use non-default features. We only > miss the tiny 'bc' tool. > > The ncurses library is helpful to run

Re: [PATCH v4 0/2] Add AVX512F optimization option and buffer_zero_avx512()

2020-03-06 Thread Paolo Bonzini
On 29/02/20 13:34, Robert Hoo wrote: > 1) Introduce {enable,disable}-avx512f configure option > > 2) Implement new buffer_zero_avx512() with AVX512F instructions > > Changes in v4: > In init_cpuid_cache(), stringently test AVX512F OS level enablement. > > Changes in v3: > In init_accel(), init l

Re: [PATCH 1/6] hw/net/e1000e_core: Let e1000e_can_receive() return a boolean

2020-03-06 Thread Paolo Bonzini
On 05/03/20 18:56, Philippe Mathieu-Daudé wrote: > The e1000e_can_receive() function simply returns a boolean value. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/net/e1000e_core.h | 2 +- > hw/net/e1000e_core.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/

[Bug 1813165] Re: KVM internal error. Suberror: 1 emulation failure

2020-03-06 Thread Vitaly Kuznetsov
If you're seeing "KVM internal error. Suberror: 1" it can be multiple things, not necessarily the same bug. Could you please confirm that: - You are running a nested configuration - The issue is observed with a UEFI booted guest BTW, kernel 5.4 you have has the patch fixing the original bug. --

Re: [PULL 000/136] Misc patches for 2020-02-25 (refactoring and Coccinelle edition)

2020-03-06 Thread Christian Borntraeger
And with diff --git a/util/oslib-posix.c b/util/oslib-posix.c index 897e8f3ba6..5d95a2049b 100644 --- a/util/oslib-posix.c +++ b/util/oslib-posix.c @@ -470,6 +470,7 @@ static bool touch_all_pages(char *area, size_t hpagesize, size_t numpages, char *addr = area; int i = 0; +qemu_con

Re: [PATCH] console: make QMP screendump use coroutine

2020-03-06 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Tue, Mar 3, 2020 at 8:41 AM Markus Armbruster wrote: [...] >> >> Let's take a step back. >> >> >> >> The actual problem is to find the coroutine in graphic_hw_update_done(), >> >> so you can wake it. >> >> >> >> Your solution stores the coroutine in the Qemu

Re: [kvm-unit-tests PATCH v3 09/14] arm/arm64: ITS: Device and collection Initialization

2020-03-06 Thread Auger Eric
Hi Drew, On 2/7/20 1:51 PM, Andrew Jones wrote: > On Tue, Jan 28, 2020 at 11:34:54AM +0100, Eric Auger wrote: >> Introduce an helper functions to register >> - a new device, characterized by its device id and the >> max number of event IDs that dimension its ITT (Interrupt >> Translation Table

Re: [PATCH] configure: Improve zstd test

2020-03-06 Thread Michal Prívozník
On 5. 3. 2020 16:27, Juan Quintela wrote: > Alex Bennée wrote: >> Juan Quintela writes: >> >>> There were one error on the test (missing an s for --exists). >>> But we really need a recent zstd (0.8.1). >>> That version was released in 2016, so it is newer that some of our travis >>> images. Jus

[PATCH] mem-prealloc: initialize cond and mutex

2020-03-06 Thread Christian Borntraeger
Guests with mem-prealloc do fail with qemu-system-s390x: /home/cborntra/REPOS/qemu/util/qemu-thread-posix.c:76: qemu_mutex_lock_impl: Assertion `mutex->initialized' failed. qemu-system-s390x: /home/cborntra/REPOS/qemu/util/qemu-thread-posix.c:161: qemu_cond_broadcast: Assertion `cond->initialized

Re: [PATCH v2] virtio-serial-bus: do cleanup on the error path in realize() to avoid memleaks

2020-03-06 Thread Markus Armbruster
Pan Nengyuan writes: > port->bh forgot to delete on the error path, this patch add it to fix > memleaks. It's easy to reproduce as follow(add a same nr port): Long line. Suggest: virtio-serial-bus: Plug memory leak on realize() error paths We neglect to free port->bh on the error pat

[Bug 1743191] Re: Interacting with NetBSD serial console boot blocks no longer works

2020-03-06 Thread Philippe Mathieu-Daudé
Possibly related thread: "Do we need a cpu with TSC support to run SeaBIOS?" https://www.mail-archive.com/seabios@seabios.org/msg11726.html -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1743191 Title

[PATCH] sercon: vbe modeset is int 10h function 4f02 not 4f00

2020-03-06 Thread Gerd Hoffmann
Fixes console redirection for NetBSD primary bootloader. https://bugs.launchpad.net/bugs/1743191 Signed-off-by: Gerd Hoffmann --- src/sercon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/sercon.c b/src/sercon.c index a5dadb7261af..66a1f2412e77 100644 --- a/src/sercon.

Re: [PATCH] mem-prealloc: initialize cond and mutex

2020-03-06 Thread Paolo Bonzini
On 06/03/20 09:50, Christian Borntraeger wrote: > Guests with mem-prealloc do fail with > qemu-system-s390x: /home/cborntra/REPOS/qemu/util/qemu-thread-posix.c:76: > qemu_mutex_lock_impl: Assertion `mutex->initialized' failed. > qemu-system-s390x: /home/cborntra/REPOS/qemu/util/qemu-thread-posix.c

[Bug 1743191] Re: Interacting with NetBSD serial console boot blocks no longer works

2020-03-06 Thread Gerd Hoffmann
Workaround: add "-vga none" to the qemu command line. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1743191 Title: Interacting with NetBSD serial console boot blocks no longer works Status in QEMU

Re: [PATCH] configure: Improve zstd test

2020-03-06 Thread Juan Quintela
Michal Prívozník wrote: > On 5. 3. 2020 16:27, Juan Quintela wrote: >> Alex Bennée wrote: >>> Juan Quintela writes: >>> There were one error on the test (missing an s for --exists). But we really need a recent zstd (0.8.1). That version was released in 2016, so it is newer that so

Re: [kvm-unit-tests PATCH v3 10/14] arm/arm64: ITS: commands

2020-03-06 Thread Auger Eric
Hi Drew, On 2/7/20 2:37 PM, Andrew Jones wrote: > On Tue, Jan 28, 2020 at 11:34:55AM +0100, Eric Auger wrote: >> Implement main ITS commands. The code is largely inherited from >> the ITS driver. >> >> Signed-off-by: Eric Auger >> >> --- >> >> v2 -> v3: >> - do not use report() anymore >> - asser

Re: [PATCH v8 10/10] xen: introduce ERRP_AUTO_PROPAGATE

2020-03-06 Thread Vladimir Sementsov-Ogievskiy
06.03.2020 12:12, Paul Durrant wrote: On Fri, 6 Mar 2020 at 05:16, Vladimir Sementsov-Ogievskiy wrote: If we want to add some info to errp (by error_prepend() or error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro. Otherwise, this info will not be added when errp == &error_fatal (t

[Bug 1859106] Re: 4.2 regression: ReactOS crashes on boot

2020-03-06 Thread Philippe Mathieu-Daudé
Possibly related thread: "Do we need a cpu with TSC support to run SeaBIOS?" https://www.mail-archive.com/seabios@seabios.org/msg11726.html -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1859106 Title

[Bug 1860056] Re: mips binaries segfault

2020-03-06 Thread Philippe Mathieu-Daudé
** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1860056 Title: mips binaries segfault Status in QEMU: Incomplete Bug description: Hello Worl

Re: [PATCH 0/2] Makefile: Re-indent 'help' target and list tools

2020-03-06 Thread Paolo Bonzini
On 05/03/20 01:48, Philippe Mathieu-Daudé wrote: > This series improves the 'make help' output: > - re-indent current output > - list tools targets: > > $ make help > [...] > > Architecture specific targets: > x86_64-softmmu/all - Build for x86_64-softmmu > > To

Re: [PATCH 0/3] hw/net,virtfs-proxy-helper: Reduce .data footprint

2020-03-06 Thread Paolo Bonzini
On 05/03/20 02:04, Philippe Mathieu-Daudé wrote: > More memory footprint reduction, similar to: > https://lists.gnu.org/archive/html/qemu-devel/2020-03/msg00984.html > > The elf-dissector tool [1] [2] helped to notice the big array. > > [1] https://phabricator.kde.org/source/elf-dissector/ > [2]

Re: [PATCH 0/3] reference implementation of RSS

2020-03-06 Thread Jason Wang
On 2020/2/27 上午1:48, Yuri Benditovich wrote: Support for VIRTIO_NET_F_RSS feature in QEMU for reference purpose. Implements Toeplitz hash calculation for incoming packets according to configuration provided by driver. This series requires previously submitted and accepted patch to be applied:

Re: [PATCH 1/3] virtio-net: introduce RSS RX steering feature

2020-03-06 Thread Yuri Benditovich
On Thu, Mar 5, 2020 at 3:21 PM Michael S. Tsirkin wrote: > On Wed, Feb 26, 2020 at 07:48:07PM +0200, Yuri Benditovich wrote: > > Signed-off-by: Yuri Benditovich > > --- > > include/standard-headers/linux/virtio_net.h | 37 +++-- > > 1 file changed, 35 insertions(+), 2 deletions(

[Bug 1743191] Re: Interacting with NetBSD serial console boot blocks no longer works

2020-03-06 Thread Ottavio Caruso
@kraxel-redhat, I guess "-vga none" is implicit when using -nographic? However, for the sake of trying, I've added "-vga none" and it won't solve it for me (when using default bios). -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. h

[Bug 1743191] Re: Interacting with NetBSD serial console boot blocks no longer works

2020-03-06 Thread Andreas Gustafsson
Gerd Hommann wrote: > Workaround: add "-vga none" to the qemu command line. This supposed workaround does not work for me. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1743191 Title: Interacting

Re: [PATCH v2] virtio-serial-bus: do cleanup on the error path in realize() to avoid memleaks

2020-03-06 Thread Pan Nengyuan
On 3/6/2020 4:51 PM, Markus Armbruster wrote: > Pan Nengyuan writes: > >> port->bh forgot to delete on the error path, this patch add it to fix >> memleaks. It's easy to reproduce as follow(add a same nr port): > > Long line. Suggest: > > virtio-serial-bus: Plug memory leak on realize(

[PATCH] vfio/migration: fix dirty pages lost bug for ram beyond 3G

2020-03-06 Thread Yan Zhao
the start address passing to cpu_physical_memory_set_dirty_range() and cpu_physical_memory_set_dirty_lebitmap() is the address within the ram block plus ram block offset. it's safe to set this start address to gpa if total memory is less than 3G, as ram block offset for pc.ram is 0. But if memory

Re: [PATCH] hw/arm/stm32f405: Add preliminary flash interface emulation support

2020-03-06 Thread Philippe Mathieu-Daudé
On 3/1/20 9:45 AM, Stephanos Ioannidis wrote: The flash interface (FLASHIF) peripheral provides a control interface for the SoC embedded flash memory on the STM32F4xx series devices. This commit adds preliminary support for the flash interface peripheral emulation, in order to support proper emu

Re: [PATCH RFC 4/4] kvm: Implement atomic memory region resizes via region_resize()

2020-03-06 Thread Paolo Bonzini
On 03/03/20 15:19, David Hildenbrand wrote: > virtio-mem wants to resize (esp. grow) ram memory regions while the guest > is already aware of them and makes use of them. Resizing a KVM slot can > only currently be done by removing it and re-adding it. While the kvm slot > is temporarily removed, VC

Re: [PATCH 0/3] reference implementation of RSS

2020-03-06 Thread Yuri Benditovich
On Fri, Mar 6, 2020 at 11:27 AM Jason Wang wrote: > > On 2020/2/27 上午1:48, Yuri Benditovich wrote: > > Support for VIRTIO_NET_F_RSS feature in QEMU for reference > > purpose. Implements Toeplitz hash calculation for incoming > > packets according to configuration provided by driver. > > > > This

Re: [PATCH v4 1/4] qapi: Add a 'coroutine' flag for commands

2020-03-06 Thread Kevin Wolf
Am 06.03.2020 um 08:25 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 05.03.2020 um 16:30 hat Markus Armbruster geschrieben: > >> Kevin Wolf writes: > >> > >> > Am 22.01.2020 um 07:32 hat Markus Armbruster geschrieben: > >> >> Kevin Wolf writes: > >> >> > >> >> > This patch

Re: [PULL] A single RISC-V fixup

2020-03-06 Thread Peter Maydell
On Thu, 5 Mar 2020 at 20:06, Palmer Dabbelt wrote: > > merged tag 'pull-target-arm-20200305' > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20200305' into staging (2020-03-05 > 16:47:37 +) > > are available in the Git repository at: > > g...@github.com:palmer-d

回复: [PATCH] mem-prealloc: initialize cond and mutex(Internet mail)

2020-03-06 Thread 陈蒙蒙
Very sorry for my fault, in fact,I test  in a old qemu version ,and patch generated based a new one ;  All in all,its my fault, and I will check and test patch carefully In the future If I  need to  submit the patch again ?     发件人: Christian Borntraeger 发送时间: 2020-03-06 16:50 收件人: qemu-devel 抄送

Re: [PATCH v6 02/18] s390x: protvirt: Add diag308 subcodes 8 - 10

2020-03-06 Thread Janosch Frank
On 3/4/20 6:06 PM, David Hildenbrand wrote: > On 04.03.20 12:42, Janosch Frank wrote: >> For diag308 subcodes 8 - 10 we have a new ipib of type 5. The ipib >> holds the address and length of the secure execution header, as well >> as a list of guest components. >> >> Each component is a block of me

[Bug 1743191] Re: Interacting with NetBSD serial console boot blocks no longer works

2020-03-06 Thread Stefan Hajnoczi
@kraxel-redhat: This issue bisects to commit d6728f301d7e6e31ba0ee2fa51ed4a24feab8860 ("add serial console support"). seabios.git/master + "[PATCH] sercon: vbe modeset is int 10h function 4f02 not 4f00" still has the issue. I'm using the following command-line: qemu-system-x86_64 -M accel=kvm -

Re: [PATCH] console: make QMP screendump use coroutine

2020-03-06 Thread Marc-André Lureau
Hi On Fri, Mar 6, 2020 at 9:44 AM Markus Armbruster wrote: > > Marc-André Lureau writes: > > > Hi > > > > On Tue, Mar 3, 2020 at 8:41 AM Markus Armbruster wrote: > [...] > >> >> Let's take a step back. > >> >> > >> >> The actual problem is to find the coroutine in graphic_hw_update_done(), > >>

Re: [PATCH] hw/arm/cubieboard: make sure SOC object isn't leaked

2020-03-06 Thread Igor Mammedov
On Thu, 5 Mar 2020 21:07:08 +0100 Niek Linnenbank wrote: > Hi Igor, > [...] > > +a10 = AW_A10(object_new(TYPE_AW_A10)); > > +object_property_add_child(OBJECT(machine), "soc", OBJECT(a10), > > + &error_abort); > > +object_unref(OBJECT(a10)); > > > > I

Re: [PATCH v7 06/10] iotests: limit line length to 79 chars

2020-03-06 Thread Kevin Wolf
Am 05.03.2020 um 19:25 hat John Snow geschrieben: > On 3/5/20 6:55 AM, Kevin Wolf wrote: > > Am 05.03.2020 um 00:14 hat John Snow geschrieben: > >> > >> > >> On 3/4/20 4:58 PM, Philippe Mathieu-Daudé wrote: > > > > Adding back the context: > > > >> -sys.stderr.write('qemu-img received sig

Re: [PATCH v6 16/18] s390x: Add unpack facility feature to GA1

2020-03-06 Thread Janosch Frank
On 3/4/20 12:42 PM, Janosch Frank wrote: > From: Christian Borntraeger > > The unpack facility is an indication that diagnose 308 subcodes 8-10 > are available to the guest. That means, that the guest can put itself > into protected mode. > > Once it is in protected mode, the hardware stops any

Re: [PATCH RFC 4/4] kvm: Implement atomic memory region resizes via region_resize()

2020-03-06 Thread David Hildenbrand
On 06.03.20 10:50, Paolo Bonzini wrote: > On 03/03/20 15:19, David Hildenbrand wrote: >> virtio-mem wants to resize (esp. grow) ram memory regions while the guest >> is already aware of them and makes use of them. Resizing a KVM slot can >> only currently be done by removing it and re-adding it. Wh

Re: [PATCH v6 16/18] s390x: Add unpack facility feature to GA1

2020-03-06 Thread David Hildenbrand
On 06.03.20 11:14, Janosch Frank wrote: > On 3/4/20 12:42 PM, Janosch Frank wrote: >> From: Christian Borntraeger >> >> The unpack facility is an indication that diagnose 308 subcodes 8-10 >> are available to the guest. That means, that the guest can put itself >> into protected mode. >> >> Once i

Re: [PATCH 1/3] virtio-net: introduce RSS RX steering feature

2020-03-06 Thread Michael S. Tsirkin
On Fri, Mar 06, 2020 at 11:29:50AM +0200, Yuri Benditovich wrote: > > > On Thu, Mar 5, 2020 at 3:21 PM Michael S. Tsirkin wrote: > > On Wed, Feb 26, 2020 at 07:48:07PM +0200, Yuri Benditovich wrote: > > Signed-off-by: Yuri Benditovich > > --- > >  include/standard-headers/linux

Re: [PATCH v8 01/10] error: auto propagated local_err

2020-03-06 Thread Greg Kurz
On Fri, 6 Mar 2020 08:15:27 +0300 Vladimir Sementsov-Ogievskiy wrote: > Here is introduced ERRP_AUTO_PROPAGATE macro, to be used at start of > functions with an errp OUT parameter. > > It has three goals: > > 1. Fix issue with error_fatal and error_prepend/error_append_hint: user > can't see t

Re: [PATCH v5 3/5] qcow2: rework the cluster compression routine

2020-03-06 Thread Alberto Garcia
On Wed 04 Mar 2020 02:35:36 PM CET, Denis Plotnikov wrote: > The patch enables processing the image compression type defined > for the image and chooses an appropriate method for image clusters > (de)compression. > > Signed-off-by: Denis Plotnikov > Reviewed-by: Vladimir Sementsov-Ogievskiy Revi

Re: [PATCH] hw/arm/cubieboard: make sure SOC object isn't leaked

2020-03-06 Thread Philippe Mathieu-Daudé
On 3/3/20 10:12 AM, Igor Mammedov wrote: SOC object returned by object_new() is leaked in current code. Set SOC parent explicitly to board and then unref to SOC object to make sure that refererence returned by object_new() is taken care of. The SOC object will be kept alive by its parent (machin

Re: [PATCH] hw/arm/cubieboard: make sure SOC object isn't leaked

2020-03-06 Thread Igor Mammedov
On Fri, 6 Mar 2020 11:33:07 +0100 Philippe Mathieu-Daudé wrote: > On 3/3/20 10:12 AM, Igor Mammedov wrote: > > SOC object returned by object_new() is leaked in current code. > > Set SOC parent explicitly to board and then unref to SOC object > > to make sure that refererence returned by object_ne

Re: [PATCH v5 4/5] qcow2: add zstd cluster compression

2020-03-06 Thread Alberto Garcia
On Wed 04 Mar 2020 02:35:37 PM CET, Denis Plotnikov wrote: > +#ifdef CONFIG_ZSTD > + > +#define ZSTD_LEN_BUF 4 I think it's worth adding a comment explaining what this is. I know it's quite clear once you read the code, but still... > +/* > + * qcow2_zstd_decompress() > + * > + * Decompress some

Re: [PATCH] tests: Fix a bug with count variables

2020-03-06 Thread Stefan Hajnoczi
On Fri, Feb 07, 2020 at 07:54:33PM +0800, Tianjia Zhang wrote: > The counting code here should use the local variable n_nodes_local. > Otherwise, the variable n_nodes is counting incorrectly, causing the > counting logic of the code to be wrong. > > Signed-off-by: Tianjia Zhang > --- > tests/tes

Re: [PATCH] modules: load modules from versioned /var/run dir

2020-03-06 Thread Stefan Hajnoczi
On Wed, Mar 04, 2020 at 10:39:46AM +0100, Christian Ehrhardt wrote: Please start a new email thread. Patches sent as replies to existing email threads are easily missed by humans and tooling also doesn't recognize them. signature.asc Description: PGP signature

Re: [PATCH] tests: Fix a bug with count variables

2020-03-06 Thread Tianjia Zhang
On 2020/3/6 18:22, Tianjia Zhang wrote: On 2020/2/12 21:59, Stefan Hajnoczi wrote: On Fri, Feb 07, 2020 at 07:54:33PM +0800, Tianjia Zhang wrote: The counting code here should use the local variable n_nodes_local. Otherwise, the variable n_nodes is counting incorrectly, causing the counting

Re: [PATCH v8 01/10] error: auto propagated local_err

2020-03-06 Thread Alberto Garcia
On Fri 06 Mar 2020 06:15:27 AM CET, Vladimir Sementsov-Ogievskiy wrote: Sorry I just gave a quick look at these patches and noticed this: > + * Function may use error system to return errors. In this case function > + * defines Error **errp parameter, which should be the last one (except for > +

[PULL 00/33] docs queue

2020-03-06 Thread Peter Maydell
/tags/riscv-for-master-5.0-sf4' into staging (2020-03-05 20:53:53 +) are available in the Git repository at: https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-docs-20200306 for you to fetch changes up to 29f9dff79073cfdc336466a950294be91b90f514: *.hx: Remove all the STEXI/E

[PULL 04/33] qemu-doc: split CPU models doc between MIPS and x86 parts

2020-03-06 Thread Peter Maydell
From: Paolo Bonzini The MIPS CPU models end up in the middle of the PC documentation. Move them to a separate file so that they can be placed in the right section. The man page still includes both x86 and MIPS content. Signed-off-by: Paolo Bonzini Reviewed-by: Peter Maydell Reviewed-by: Alex

[PULL 02/33] qemu-doc: remove target OS documentation

2020-03-06 Thread Peter Maydell
From: Paolo Bonzini This section covers OSes up to Windows 2000, and as such it is mostly obsolete. Zap it. Reviewed-by: Peter Maydell Signed-off-by: Paolo Bonzini Reviewed-by: Alex Bennée Tested-by: Alex Bennée Signed-off-by: Peter Maydell Message-id: 20200228153619.9906-3-peter.mayd...@l

[PULL 03/33] texi2pod: parse @include directives outside "@c man" blocks

2020-03-06 Thread Peter Maydell
From: Paolo Bonzini This enables splitting the huge qemu-doc.texi file and keeping parallel Texinfo and rST versions of the documentation. texi2pod is not going to live much longer and hardly anyone cares about its upstream status, so the temporary fork should be acceptable. Signed-off-by: Paol

[PULL 07/33] qemu-doc: move system requirements chapter inside PC section

2020-03-06 Thread Peter Maydell
From: Paolo Bonzini The system requirements documented in this chapter are limited to x86 KVM targets. Clean them up and move them to the target section. Signed-off-by: Paolo Bonzini Reviewed-by: Peter Maydell Tested-by: Alex Bennée Signed-off-by: Peter Maydell Message-id: 20200228153619.99

[PULL 11/33] qemu-doc: move included files to docs/system

2020-03-06 Thread Peter Maydell
From: Paolo Bonzini Since qemu-doc.texi is mostly including files from docs/system, move the existing include files there for consistency. Signed-off-by: Paolo Bonzini Reviewed-by: Peter Maydell Reviewed-by: Alex Bennée Tested-by: Alex Bennée Signed-off-by: Peter Maydell Message-id: 2020022

[PULL 01/33] qemu-doc: convert user-mode emulation to a separate Sphinx manual

2020-03-06 Thread Peter Maydell
From: Paolo Bonzini The final addition to the set of QEMU manuals is the user-mode emulation manual, which right now is included in qemu-doc.texi. Extract it and convert it to rST, so that qemu-doc.texi covers only full system emulation. Signed-off-by: Paolo Bonzini Reviewed-by: Peter Maydell

[PULL 14/33] docs: Create defs.rst.inc as a place to define substitutions

2020-03-06 Thread Peter Maydell
Rather than accumulating generally useful rST substitution definitions in individual rST files, create a defs.rst.inc where we can define these. To start with it has the |qemu_system| definition from qemu-block-drivers.rst. Add a comment noting a pitfall where putting literal markup in the defini

[PULL 12/33] qemu-doc: remove indices other than findex

2020-03-06 Thread Peter Maydell
From: Paolo Bonzini These indices are not well-maintained, and pandoc also chokes on the directives. Just nuke them. Signed-off-by: Paolo Bonzini Reviewed-by: Peter Maydell Reviewed-by: Alex Bennée Tested-by: Alex Bennée Signed-off-by: Peter Maydell Message-id: 20200228153619.9906-13-peter

[PULL 06/33] qemu-doc: extract common system emulator documentation from the PC section

2020-03-06 Thread Peter Maydell
From: Paolo Bonzini Move the section on PC peripherals together with other targets. While some x86-specific information remains in the main system emulation chapter, it can be tackled more easily a section at a time. Signed-off-by: Paolo Bonzini Reviewed-by: Peter Maydell Reviewed-by: Alex Ben

[PULL 16/33] docs/system: Convert security.texi to rST format

2020-03-06 Thread Peter Maydell
security.texi is included from qemu-doc.texi but is not used in the qemu.1 manpage. So we can do a straightforward conversion of the contents, which go into the system manual. Signed-off-by: Peter Maydell Signed-off-by: Paolo Bonzini Reviewed-by: Alex Bennée Tested-by: Alex Bennée Message-id:

[PULL 17/33] docs/system: convert managed startup to rST.

2020-03-06 Thread Peter Maydell
Fix one typo in the process and format more option and command names as literal text, but make no significant changes to the content. Signed-off-by: Peter Maydell Signed-off-by: Paolo Bonzini Reviewed-by: Alex Bennée Tested-by: Alex Bennée Message-id: 20200228153619.9906-18-peter.mayd...@linar

[PULL 09/33] qemu-doc: Remove the "CPU emulation" part of the "Implementation notes"

2020-03-06 Thread Peter Maydell
The "CPU emulation" part of the "Implementation notes" in qemu-tech.texi looks like it is documenting what features of various CPUs we do or don't emulate. However: * it covers only six of our 21 guest architectures * the last time anybody updated it for actual content was in 2011/2012 for Xt

[PULL 13/33] docs/system: put qemu-block-drivers body in an included file

2020-03-06 Thread Peter Maydell
From: Paolo Bonzini This removes the "only" directives, and lets us use the conventional "DESCRIPTION" section in the manpage. This temporarily drops the qemu-block-drivers documentation from the system manual, but it will be put back (in the right place in the toctree) in a later commit. Signe

[PULL 22/33] doc/scripts/hxtool.py: Strip trailing ':' from DEFHEADING/ARCHHEADING

2020-03-06 Thread Peter Maydell
In hxtool files, section headings defined with the DEFHEADING and ARCHHEADING macros have a trailing ':' DEFHEADING(Standard options:) This is for the benefit of the --help output. For consistency with the rest of the rST documentation, strip any trailing ':' when we construct headings with the

[PULL 21/33] hmp-commands-info.hx: Add rST documentation fragments

2020-03-06 Thread Peter Maydell
Add the rST versions of the documentation fragments. Once we've converted fully from Texinfo to rST we can remove the ETEXI fragments; for the moment we need both. Note that most of the SRST fragments are 2-space indented so that the 'info foo' documentation entries appear as a sublist under the

[PULL 28/33] docs: Split out sections for the manpage into .rst.inc files

2020-03-06 Thread Peter Maydell
Sphinx doesn't have very good facilities for marking chunks of documentation as "put this in the manpage only". So instead we move the parts we want to put into both the HTML manuals and the manpage into their own .rst.inc files, which we can include from both the main manual rst files and a new to

[PULL 18/33] docs/system: convert the documentation of deprecated features to rST.

2020-03-06 Thread Peter Maydell
We put the whole of this document into the system manual, though technically a few parts of it apply to qemu-img or qemu-nbd which are otherwise documented in tools/. We only make formatting fixes, except for one use of 'appendix' which we change to 'section' because this isn't an appendix in the

[PULL 10/33] qemu-doc: move qemu-tech.texi into main section

2020-03-06 Thread Peter Maydell
From: Paolo Bonzini The only remaining content in qemu-tech.texi is a few paragraphs about managed start up options. Move them in the main section about full system emulation. Signed-off-by: Paolo Bonzini Reviewed-by: Peter Maydell Reviewed-by: Alex Bennée Tested-by: Alex Bennée Signed-off-

[PULL 05/33] qemu-doc: split qemu-doc.texi in multiple files

2020-03-06 Thread Peter Maydell
From: Paolo Bonzini In order to facilitate the reorganization of qemu-doc.texi content, as well as the conversion to rST/Sphinx, split it in multiple .texi files that are included from docs/system. The "other devices" section is renamed to ivshmem and placed last. Signed-off-by: Paolo Bonzini

[PULL 08/33] qemu-doc: split target sections to separate files

2020-03-06 Thread Peter Maydell
From: Paolo Bonzini Signed-off-by: Paolo Bonzini Reviewed-by: Peter Maydell Reviewed-by: Alex Bennée Tested-by: Alex Bennée Signed-off-by: Peter Maydell Message-id: 20200228153619.9906-9-peter.mayd...@linaro.org Message-id: 20200226113034.6741-9-pbonz...@redhat.com Reviewed-by: Peter Maydell

[PULL 27/33] qemu-options.hx: Fix up the autogenerated rST

2020-03-06 Thread Peter Maydell
This commit contains hand-written fixes for some issues with the autogenerated rST fragments in qemu-options.hx: * Sphinx complains about the UTF-8 art table in the documentation of the -drive option. Replace it with a proper rST format table. * rST does not like definition list entries wit

[PULL 23/33] docs: Roll semihosting option information into qemu-options.hx

2020-03-06 Thread Peter Maydell
Currently the per-target documentation for those targets that implement semihosting includes a bit of text that goes into both the manual and the manpage about options specific to the target. This text is redundant with the earlier generic option description of the semihosting option produced from

[PULL 15/33] docs/system: Convert qemu-cpu-models.texi to rST

2020-03-06 Thread Peter Maydell
From: Kashyap Chamarthy This doc was originally written by Daniel P. Berrangé , introduced via commit[1]: 2544e9e4aa (docs: add guidance on configuring CPU models for x86, 2018-06-27). In this patch: - 1-1 conversion of Texinfo to rST, besides a couple of minor tweaks that are too trivial

Re: [PATCH 0/2] misc: Replace zero-length arrays with flexible array member

2020-03-06 Thread Igor Mammedov
On Wed, 4 Mar 2020 16:35:59 +0100 Philippe Mathieu-Daudé wrote: > v2: > - do not modify qed.h (structure with single member) > - based on hw/scsi/spapr_vscsi fix series > > This is a tree-wide cleanup inspired by a Linux kernel commit > (from Gustavo A. R. Silva). > > --v-- description start -

[PULL 29/33] docs: Generate qemu.1 manpage with Sphinx

2020-03-06 Thread Peter Maydell
Generate the qemu.1 manpage using Sphinx; we do this with a new top-level rst source file which is just the skeleton of the manpage and which includes .rst.inc fragments where it needs to incorporate sections from the larger HTML manuals. Signed-off-by: Peter Maydell Reviewed-by: Alex Bennée Tes

[PULL 24/33] docs: Roll -prom-env and -g target-specific info into qemu-options.hx

2020-03-06 Thread Peter Maydell
The SPARC and PPC targets currently have a fragment of target-specific information about the -g and -prom options which would be better placed as part of the general documentation of those options in qemu-options.hx. Move the relevant information to those locations. SPARC also has a bit of text ab

[Bug 1862874] Re: java may stuck for a long time in system mode with "-cpu max"

2020-03-06 Thread Stefan Hajnoczi
Have you tried with KVM ("-M accel=kvm")? Please try "strace -o /var/tmp/java.log -f java -version" and upload the strace. If the strace is very large, it's probably safe to remove everything after around 10 seconds. -- You received this bug notification because you are a member of qemu- devel-

[PULL 25/33] scripts/hxtool-conv: Archive script used in qemu-options.hx conversion

2020-03-06 Thread Peter Maydell
This commit archives the perl script used to do conversion of the STEXI/ETEXI blocks in qemu-options.hx. (The other .hx files were manually converted, but qemu-options.hx is complicated enough that I felt I needed some scripting.) Signed-off-by: Peter Maydell Reviewed-by: Alex Bennée Tested-by:

Re: [PATCH v2] hw/char/pl011: Enable TxFIFO and async transmission

2020-03-06 Thread Marc-André Lureau
Hi On Mon, Feb 24, 2020 at 4:13 AM Gavin Shan wrote: > > The depth of TxFIFO can be 1 or 16 depending on LCR[4]. The TxFIFO is > disabled when its depth is 1. It's nice to have TxFIFO enabled if > possible because more characters can be piled and transmitted at once, > which would have less overh

[PULL 19/33] docs/system: convert Texinfo documentation to rST

2020-03-06 Thread Peter Maydell
From: Paolo Bonzini Apart from targets.rst, which was written by hand, this is an automated conversion obtained with the following command: makeinfo --force -o - --docbook \ -D 'qemu_system_x86 QEMU_SYSTEM_X86_MACRO' \ -D 'qemu_system QEMU_SYSTEM_MACRO' \ $texi | pandoc -f docb

[PULL 20/33] hmp-commands.hx: Add rST documentation fragments

2020-03-06 Thread Peter Maydell
Add the rST versions of the documentation fragments. Once we've converted fully from Texinfo to rST we can remove the ETEXI fragments; for the moment we need both. Since the only consumer of the hmp-commands hxtool documentation is the HTML manual, all we need to do for the monitor command docume

[PULL 30/33] ui/cocoa.m: Update documentation file and pathname

2020-03-06 Thread Peter Maydell
We want to stop generating the old qemu-doc.html; first we must update places that refer to it so they instead go to our top level index.html documentation landing page. The Cocoa UI has a menu option to bring up the documentation; make it point to the new top level index.html instead. Signed-off-

[PULL 31/33] docs: Stop building qemu-doc

2020-03-06 Thread Peter Maydell
Stop building the old texinfo qemu-doc; all its contents are now available in the Sphinx-generated manuals and manpages. Signed-off-by: Peter Maydell Reviewed-by: Alex Bennée Tested-by: Alex Bennée Message-id: 20200228153619.9906-32-peter.mayd...@linaro.org --- docs/specs/ivshmem-spec.txt | 4

[PULL 32/33] docs: Remove old texinfo sources

2020-03-06 Thread Peter Maydell
We can now delete the old .texi files, which we have been keeping in the tree as a parallel set of documentation to the new rST sources. The only remaining use of Texinfo is the autogenerated manuals and HTML documents created from the QAPI JSON doc comments. Signed-off-by: Peter Maydell Reviewed

Re: [PULL 00/33] docs queue

2020-03-06 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200306110959.29461-1-peter.mayd...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PULL 00/33] docs queue Message-id: 20200306110959.29461-1-peter.mayd...@linaro.org Type: series ==

Re: [PATCH RFC 4/4] kvm: Implement atomic memory region resizes via region_resize()

2020-03-06 Thread Paolo Bonzini
On 06/03/20 11:20, David Hildenbrand wrote: > Yeah, rwlocks are not optimal and I am still looking for better > alternatives (suggestions welcome :) ). Using RCU might not work, > because the rcu_read region might be too big (esp. while in KVM_RUN). > > I had a prototype which used a bunch of atom

Re: [PATCH] tests: Fix a bug with count variables

2020-03-06 Thread Tianjia Zhang
On 2020/3/6 18:53, Stefan Hajnoczi wrote: On Fri, Feb 07, 2020 at 07:54:33PM +0800, Tianjia Zhang wrote: The counting code here should use the local variable n_nodes_local. Otherwise, the variable n_nodes is counting incorrectly, causing the counting logic of the code to be wrong. Signed-off

Re: [PATCH] contrib/elf2dmp: prevent uninitialized warning

2020-03-06 Thread Viktor Prutyanov
On Fri, 6 Mar 2020 02:18:07 + "Chenqun (kuhn)" wrote: > >-Original Message- > >From: Viktor Prutyanov [mailto:viktor.prutya...@phystech.edu] > >Sent: Friday, March 6, 2020 2:59 AM > >To: Chenqun (kuhn) > >Cc: qemu-devel@nongnu.org; pbonz...@redhat.com; Zhanghailiang > >; qemu-triv...

Re: [PATCH v6 03/18] s390x: protvirt: Support unpack facility

2020-03-06 Thread Christian Borntraeger
On 04.03.20 12:42, Janosch Frank wrote: [...] > diff --git a/target/s390x/cpu.c b/target/s390x/cpu.c > index 3dd396e870..69b1cc5dfc 100644 > --- a/target/s390x/cpu.c > +++ b/target/s390x/cpu.c > @@ -37,6 +37,8 @@ > #include "sysemu/hw_accel.h" > #include "hw/qdev-properties.h" > #ifndef CONFI

Re: [PATCH] tests/docker: Install tools to cross-debug and build Linux kernels

2020-03-06 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > ping ping? Queued to testing/next, thanks. Sorry for the delay. > > On 2/24/20 1:20 PM, Philippe Mathieu-Daudé wrote: >> On 2/12/20 9:27 PM, Philippe Mathieu-Daudé wrote: >>> From: Philippe Mathieu-Daudé >>> >>> We often run Linux kernels to test QEMU. We som

Re: [PATCH 0/3] tests/docker: Fix linking with VirGL

2020-03-06 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > ping ping? Queued to testing/next, thanks. > > On 2/24/20 1:20 PM, Philippe Mathieu-Daudé wrote: >> On 2/12/20 9:27 PM, Philippe Mathieu-Daudé wrote: >>> We link with VirGL in our debian-amd64 (cross-host) docker image. >>> >>> This series includes few fixes t

Re: [PULL 00/33] docs queue

2020-03-06 Thread Peter Maydell
On Fri, 6 Mar 2020 at 11:10, Peter Maydell wrote: > > As promised, here's a pull request with the patches which do the > qemu-doc rST conversion. > > Minor changes since the patchset was posted: > * rebased > * the two auto-generated patches have been regenerated, to account >for the qemu-op

  1   2   3   >