Re: [PATCH v4 2/3] linux-user/syscall: Add support for clock_gettime64/clock_settime64

2020-03-04 Thread Aleksandar Markovic
1:53 AM Sre, 04.03.2020. Alistair Francis је написао/ла: > > Add support for the clock_gettime64/clock_settime64 syscalls. Currently > we only support these syscalls when running on 64-bit hosts. > For clarity, "Currently we only support" should be replaced with "This patch supports only". > Sig

Re: [PATCH 4/4] qapi: Brush off some (py)lint

2020-03-04 Thread Markus Armbruster
John Snow writes: > On 2/27/20 9:45 AM, Markus Armbruster wrote: >> Signed-off-by: Markus Armbruster > > I wrote some pylint cleanup for iotests recently, too. Are you targeting > a subset of pylint errors to clean here? > > (Do any files pass 100%?) Surely you're joking, Mr. Snow! I'm chippin

RE: [PATCH 0/2] net/colo-compare.c: Expose more COLO internal

2020-03-04 Thread Zhang, Chen
Hi all, Please give me some comments, this patch need by users(QNAP...). Thanks Zhang Chen > -Original Message- > From: Zhang, Chen > Sent: Monday, February 24, 2020 4:58 AM > To: Jason Wang ; qemu-dev de...@nongnu.org> > Cc: Zhang Chen ; Dr . David Alan Gilbert > ; Daniel Cho ; Zhang,

RE: [PATCH V4 0/5] Introduce Advanced Watch Dog module

2020-03-04 Thread Zhang, Chen
> >>> Subject: Re: [PATCH V4 0/5] Introduce Advanced Watch Dog module > >>> > >>> > >>> On 2020/1/19 下午5:10, Zhang, Chen wrote: > Hi~ > > Anyone have comments about this module? > >>> Hi Chen: > >>> > >>> I will take a look at this series. > >> Sorry for slow reply due to CNY and ext

Re: [PATCH v4 02/11] monitor/hmp: uninline add_init_drive

2020-03-04 Thread Maxim Levitsky
On Tue, 2020-03-03 at 18:10 +0100, Kevin Wolf wrote: > Am 30.01.2020 um 13:34 hat Maxim Levitsky geschrieben: > > This is only used by hmp_drive_add. > > The code is just a bit shorter this way. > > > > No functional changes > > > > Signed-off-by: Maxim Levitsky > > Reviewed-by: Markus Armbruste

Re: [PATCH] vhost-vsock: fix error message output

2020-03-04 Thread Stefano Garzarella
On Sun, Mar 01, 2020 at 01:03:06PM +0100, Nick Erdmann wrote: > error_setg_errno takes a positive error number, so we should not invert > errno's sign. > > Signed-off-by: Nick Erdmann > --- > hw/virtio/vhost-vsock.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/vir

Re: [PATCH v4 07/11] monitor/hmp: move hmp_snapshot_* to block-hmp-cmds.c hmp_snapshot_blkdev is from GPLv2 version of the hmp-cmds.c thus have to change the licence to GPLv2

2020-03-04 Thread Maxim Levitsky
On Tue, 2020-03-03 at 18:15 +0100, Kevin Wolf wrote: > Am 30.01.2020 um 13:34 hat Maxim Levitsky geschrieben: > > Signed-off-by: Maxim Levitsky > > Reviewed-by: Dr. David Alan Gilbert > > Very long subject line. I suppose the license notice should be in the > body instead. > > > block/monitor/

Re: [PATCH v2 00/30] Configurable policy for handling deprecated interfaces

2020-03-04 Thread Markus Armbruster
Peter Maydell writes: > On Tue, 3 Mar 2020 at 16:37, Markus Armbruster wrote: >> >> Based-on: <20200227144531.24309-1-arm...@redhat.com> >> >> This series extends QMP introspection to cover deprecation. >> Additionally, new option -compat lets you configure what to do when >> deprecated interfac

Re: [PATCH 1/2] misc: Replace zero-length arrays with flexible array member (automatic)

2020-03-04 Thread David Hildenbrand
On 04.03.20 01:51, Philippe Mathieu-Daudé wrote: > Description copied from Linux kernel commit from Gustavo A. R. Silva > (see [3]): > > --v-- description start --v-- > > The current codebase makes use of the zero-length array language > extension to the C90 standard, but the preferred mechan

Re: [PATCH 2/2] misc: Replace zero-length arrays with flexible array member (manual)

2020-03-04 Thread David Hildenbrand
On 04.03.20 01:58, Philippe Mathieu-Daudé wrote: > Description copied from Linux kernel commit from Gustavo A. R. Silva > (see [3]): > > --v-- description start --v-- > > The current codebase makes use of the zero-length array language > extension to the C90 standard, but the preferred mechan

Re: [PATCH RFC 2/4] intc/s390_flic_kvm.c: Use kvm_device_ioctl() instead of ioctl()

2020-03-04 Thread Christian Borntraeger
On 03.03.20 15:19, David Hildenbrand wrote: > Let's use the official variant, which will e.g., trace the call. > > Cc: Cornelia Huck > Cc: Halil Pasic > Cc: Christian Borntraeger > Cc: qemu-s3...@nongnu.org > Signed-off-by: David Hildenbrand > --- > hw/intc/s390_flic_kvm.c | 22 +++

Re: [PATCH RFC 2/4] intc/s390_flic_kvm.c: Use kvm_device_ioctl() instead of ioctl()

2020-03-04 Thread David Hildenbrand
On 04.03.20 09:22, Christian Borntraeger wrote: > > > On 03.03.20 15:19, David Hildenbrand wrote: >> Let's use the official variant, which will e.g., trace the call. >> >> Cc: Cornelia Huck >> Cc: Halil Pasic >> Cc: Christian Borntraeger >> Cc: qemu-s3...@nongnu.org >> Signed-off-by: David Hil

Re: [PATCH v16 00/10] VIRTIO-IOMMU device

2020-03-04 Thread Auger Eric
Hi Zhangfei, On 3/4/20 7:08 AM, Zhangfei Gao wrote: > On Tue, Mar 3, 2020 at 5:41 PM Auger Eric wrote: >> >> Hi Zhangfei, >> On 3/3/20 4:23 AM, Zhangfei Gao wrote: >>> Hi Eric >>> >>> On Thu, Feb 27, 2020 at 9:50 PM Auger Eric wrote: Hi Daniel, On 2/27/20 12:17 PM, Daniel P.

Re: [PATCH] hw/ide: Remove status register read side effect

2020-03-04 Thread BALATON Zoltan
On Wed, 4 Mar 2020, jasper.low...@bt.com wrote: cmd646_update_irq() only seems to raise PCI interrupt, should it also have an option to use INT 14 and 15 in legacy mode similar to what my patch does for via-ide? Looking through /qemu/hw/ide/cmd646.c it doesn't look like QEMU has support for leg

Re: [PATCH] optionrom/pvh: scan entire RSDP Area

2020-03-04 Thread Stefano Garzarella
CCing Paolo On Tue, Mar 03, 2020 at 02:52:47AM -0800, Joe Richey wrote: > From: Joe Richey > > Right now the PVH option rom scans for the RSDP from 0xE to > 0xE1FFF. This is probobly a typo, it should scan from 0xE to > 0xF. > > This is actually an issue on some QEMU versions/machin

Re: [PATCH] pc-bios: s390x: Save iplb location in lowcore

2020-03-04 Thread Janosch Frank
On 3/3/20 5:13 PM, David Hildenbrand wrote: > On 03.03.20 16:50, Janosch Frank wrote: >> The POP states that for a list directed IPL the IPLB is stored into >> memory by the machine loader and its address is stored at offset 0x14 >> of the lowcore. >> >> ZIPL currently uses the address in offset 0x

Re: [PATCH 2/2] misc: Replace zero-length arrays with flexible array member (manual)

2020-03-04 Thread Philippe Mathieu-Daudé
On 3/4/20 1:58 AM, Philippe Mathieu-Daudé wrote: Description copied from Linux kernel commit from Gustavo A. R. Silva (see [3]): --v-- description start --v-- The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to

Re: [PATCH v2 00/30] Configurable policy for handling deprecated interfaces

2020-03-04 Thread Peter Maydell
On Wed, 4 Mar 2020 at 08:18, Markus Armbruster wrote: > Peter Maydell writes: > > How much do you think this is likely to affect the > > generate-rst-from-qapi-docs series? I'd really like > > that to go in for this release, but this looks like > > it's shaping up to be a big conflict :-( > > I p

Re: [PATCH] pc-bios: s390x: Save iplb location in lowcore

2020-03-04 Thread David Hildenbrand
On 04.03.20 09:59, Janosch Frank wrote: > On 3/3/20 5:13 PM, David Hildenbrand wrote: >> On 03.03.20 16:50, Janosch Frank wrote: >>> The POP states that for a list directed IPL the IPLB is stored into >>> memory by the machine loader and its address is stored at offset 0x14 >>> of the lowcore. >>>

Re: [PATCH v3 00/33] Convert qemu-doc to rST

2020-03-04 Thread Kashyap Chamarthy
On Tue, Mar 03, 2020 at 05:35:01PM +, Peter Maydell wrote: > On Fri, 28 Feb 2020 at 15:36, Peter Maydell wrote: > > > > Hi; this series does a complete conversion of qemu-doc from > > Texinfo to rST, including the hxtool-generated parts and > > creation of the qemu.1 manpage from rST. > > > >

Re: [PATCH] virtio-serial-bus: do cleanup on the error path in realize() to avoid memleaks

2020-03-04 Thread Markus Armbruster
Pan Nengyuan writes: > port->bh forgot to delete on the error path, this patch add it to fix > memleaks. It's easy to reproduce as follow(add a same nr port): > {'execute': 'device_add', 'arguments': {'id': 'virtio_serial_pci0', > 'driver': 'virtio-serial-pci', 'bus': 'pci.0', 'addr': '0x5'

Re: [PATCH v2 00/30] Configurable policy for handling deprecated interfaces

2020-03-04 Thread Markus Armbruster
Peter Maydell writes: > On Wed, 4 Mar 2020 at 08:18, Markus Armbruster wrote: >> Peter Maydell writes: >> > How much do you think this is likely to affect the >> > generate-rst-from-qapi-docs series? I'd really like >> > that to go in for this release, but this looks like >> > it's shaping up t

Re: [PATCH 0/2] block: bdrv_reopen() with backing file in different AioContext

2020-03-04 Thread Peter Krempa
On Thu, Feb 27, 2020 at 19:18:02 +0100, Kevin Wolf wrote: > Kevin Wolf (2): > iotests: Refactor blockdev-reopen test for iothreads > block: bdrv_reopen() with backing file in different AioContext Thanks for the patches. It fixes the problem we've talked about: Tested-by: Peter Krempa

Re: [PATCH] dp8393x: Mask EOL bit from descriptor addresses, take 2

2020-03-04 Thread Laurent Vivier
Le 04/03/2020 à 04:23, Finn Thain a écrit : > A portion of a recent patch got lost due to a merge snafu. That patch is > now commit 88f632fbb1 ("dp8393x: Mask EOL bit from descriptor addresses"). > This patch restores the portion that got lost. > > Signed-off-by: Finn Thain > --- > hw/net/dp8393

Re: Best practices to handle shared objects through qemu upgrades?

2020-03-04 Thread Christian Ehrhardt
On Fri, Nov 1, 2019 at 10:34 AM Daniel P. Berrangé wrote: > On Fri, Nov 01, 2019 at 08:14:08AM +0100, Christian Ehrhardt wrote: > > Hi everyone, > > we've got a bug report recently - on handling qemu .so's through > > upgrades - that got me wondering how to best handle it. > > After checking with

[PATCH] modules: load modules from versioned /var/run dir

2020-03-04 Thread Christian Ehrhardt
On upgrades the old .so files usually are replaced. But on the other hand since a qemu process represents a guest instance it is usually kept around. That makes late addition of dynamic features e.g. 'hot-attach of a ceph disk' fail by trying to load a new version of e.f. block-rbd.so into an old

Re: [PATCH 0/2] block: bdrv_reopen() with backing file in different AioContext

2020-03-04 Thread Kevin Wolf
Am 04.03.2020 um 10:29 hat Peter Krempa geschrieben: > On Thu, Feb 27, 2020 at 19:18:02 +0100, Kevin Wolf wrote: > > Kevin Wolf (2): > > iotests: Refactor blockdev-reopen test for iothreads > > block: bdrv_reopen() with backing file in different AioContext > > Thanks for the patches. It fixes

Re: [PATCH v4 2/3] linux-user/syscall: Add support for clock_gettime64/clock_settime64

2020-03-04 Thread Laurent Vivier
Le 04/03/2020 à 01:44, Alistair Francis a écrit : > Add support for the clock_gettime64/clock_settime64 syscalls. Currently > we only support these syscalls when running on 64-bit hosts. > > Signed-off-by: Alistair Francis > --- > linux-user/syscall.c | 43 +++

[PULL 1/9] tests/vm: use $(PYTHON) consistently

2020-03-04 Thread Alex Bennée
From: Robert Foley Change Makefile.include to use $(PYTHON) so for vm-boot-ssh to be consistent with other cases like vm-build. Signed-off-by: Robert Foley Reviewed-by: Alex Bennée Reviewed-by: Peter Puhov Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Message-Id: <202002191

[PULL 6/9] travis: enable tools build on OS X

2020-03-04 Thread Alex Bennée
From: Laurent Vivier As we can build tools on OS X we should check we don't break build when we submit new codes. Signed-off-by: Laurent Vivier Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Message-Id: <20200302154630.45620-3-lviv...@redhat.

[PULL 0/9] testing updates (tests/vm and acceptance tweaks)

2020-03-04 Thread Alex Bennée
The following changes since commit abfa865014ab17941eb1fcb7cc2fa293a25843c4: Merge remote-tracking branch 'remotes/dgilbert-gitlab/tags/pull-virtiofs-20200303' into staging (2020-03-03 15:20:12 +) are available in the Git repository at: https://github.com/stsquad/qemu.git tags/pull-tes

[PULL 2/9] tests/vm: Debug mode shows ssh output.

2020-03-04 Thread Alex Bennée
From: Robert Foley Add changes to tests/vm/basevm.py so that during debug mode we show ssh output. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov Reviewed-by: Alex Bennée Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20200219163537.22098-3-robert.fo...@li

[PULL 3/9] tests/vm: increased max timeout for vm boot.

2020-03-04 Thread Alex Bennée
From: Robert Foley Add change to increase timeout waiting for VM to boot. Needed for some emulation cases where it can take longer than 5 minutes to boot. Signed-off-by: Robert Foley Reviewed-by: Alex Bennée Reviewed-by: Peter Puhov Signed-off-by: Alex Bennée Message-Id: <20200219163537.2209

[PULL 5/9] tests/vm: Added gen_cloud_init_iso() to basevm.py

2020-03-04 Thread Alex Bennée
From: Robert Foley This method was located in both centos and ubuntu.i386. Signed-off-by: Robert Foley Reviewed-by: Alex Bennée Reviewed-by: Peter Puhov Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20200219163537.22098-6-robert.fo...@linaro.org> Message-Id: <2

[PULL 4/9] tests/vm: give wait_ssh() option to wait for root

2020-03-04 Thread Alex Bennée
From: Robert Foley Allow wait_ssh to wait for root user to be ready. This solves the issue where we perform a wait_ssh() successfully, but the root user is not yet ready to be logged in. Signed-off-by: Robert Foley Reviewed-by: Alex Bennée Reviewed-by: Peter Puhov Signed-off-by: Alex Bennée

[PULL 8/9] tests/acceptance: bump avocado requirements to 76.0

2020-03-04 Thread Alex Bennée
If we want to use @skipUnless decorations on the class we need a newer version of avocado. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Message-Id: <20200303150622.20133-9-alex.ben...@linaro.org> diff --git a/tests/requirements.txt b/tests/requirements.txt index a2a587223a9..f4f173

[PULL 7/9] configure: detect and report genisoimage

2020-03-04 Thread Alex Bennée
This is used for some of the vm-build tests so lets detect it and behave sanely when it is not installed. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Message-Id: <20200303150622.20133-8-alex.ben...@linaro.org> diff --git a/configure b/configure index 7b373bc0bb8..fab6281eb70 10075

[PATCH] python/qemu/qmp.py: QMP debug with VM label

2020-03-04 Thread Oksana Vohchana
QEMUMachine writes some messages to the default logger. But it sometimes to hard the read the output if we have requested to more than one VM. This patch adds name in QMP command if it needs and labels with it in debug mode. Signed-off-by: Oksana Vohchana --- python/qemu/machine.py | 8

[PULL 9/9] travis.yml: install python3 numpy and opencv libraries

2020-03-04 Thread Alex Bennée
These are used for the acceptance framebuffer tests to count Tux. As we need slightly newer python3 for opencv we bump up to bionic. Signed-off-by: Alex Bennée Message-Id: <20200303150622.20133-10-alex.ben...@linaro.org> diff --git a/.travis.yml b/.travis.yml index 70a24bf2fc8..b92798ac3b9 1006

Re: [PATCH v5 14/50] mutli-process: build remote command line args

2020-03-04 Thread Dr. David Alan Gilbert
* Jagannathan Raman (jag.ra...@oracle.com) wrote: > From: Elena Ufimtseva > > Signed-off-by: Elena Ufimtseva > Signed-off-by: Jagannathan Raman > Signed-off-by: John G Johnson > --- > v4 -> v5: > - Added "exec" suboption to get the executable's name > - Addressed feedback about variable n

Re: [PATCH v5 12/50] multi-process: remote process initialization

2020-03-04 Thread Dr. David Alan Gilbert
* Jagannathan Raman (jag.ra...@oracle.com) wrote: > Adds the handler to process message from QEMU, > Initialize remote process main loop, handles SYNC_SYSMEM > message by updating its "system_memory" container using > shared file descriptors received from QEMU. > > Signed-off-by: John G Johnson >

Re: [PATCH v6 18/18] docs: add Orange Pi PC document

2020-03-04 Thread Alex Bennée
Niek Linnenbank writes: > The Xunlong Orange Pi PC machine is a functional ARM machine > based on the Allwinner H3 System-on-Chip. It supports mainline > Linux, U-Boot, NetBSD and is covered by acceptance tests. > > This commit adds a documentation text file with a description > of the machine

Re: [PATCH v5 15/50] multi-process: PCI BAR read/write handling for proxy & remote endpoints

2020-03-04 Thread Dr. David Alan Gilbert
* Jagannathan Raman (jag.ra...@oracle.com) wrote: > Proxy device object implements handler for PCI BAR writes and reads. The > handler > uses BAR_WRITE/BAR_READ message to communicate to the remote process with the > BAR address and > value to be written/read. > The remote process implements hand

Re: [PATCH v5 14/50] mutli-process: build remote command line args

2020-03-04 Thread Daniel P . Berrangé
On Mon, Mar 02, 2020 at 02:39:37PM -0800, Elena Ufimtseva wrote: > On Mon, Mar 02, 2020 at 05:47:45PM +, Daniel P. Berrangé wrote: > > On Mon, Mar 02, 2020 at 06:36:13PM +0100, Philippe Mathieu-Daudé wrote: > > > typo "multi" in patch subject. > > > > Thank Philippe, will fix. > > > > On 2/24

Re: [PATCH v6 1/9] iotests: do a light delinting

2020-03-04 Thread Kevin Wolf
Am 03.03.2020 um 22:25 hat John Snow geschrieben: > > > On 2/27/20 7:59 AM, Max Reitz wrote: > > On 27.02.20 01:06, John Snow wrote: > >> This doesn't fix everything in here, but it does help clean up the > >> pylint report considerably. > >> > >> This should be 100% style changes only; the inten

Re: [PATCH 0/2] misc: Replace zero-length arrays with flexible array member

2020-03-04 Thread Paolo Bonzini
On 04/03/20 01:51, Philippe Mathieu-Daudé wrote: > This is a tree-wide cleanup inspired by a Linux kernel commit > (from Gustavo A. R. Silva). > > --v-- description start --v-- > > The current codebase makes use of the zero-length array language > extension to the C90 standard, but the prefer

Re: New Hardware model emulation

2020-03-04 Thread Priyamvad Acharya
Hi, I have commented all the lines of other hardware models except custom device line *" common-obj-$(CONFIG_TESTPCI) += testpci.o "*. But when I run *make* I get errors similar to error shown in file which I have shared with you in previous replies. Thanks, Priyamvad On Wed, 4 Mar 2020 at 02:05

Re: New Hardware model emulation

2020-03-04 Thread Stefan Hajnoczi
On Wed, Mar 4, 2020 at 11:16 AM Priyamvad Acharya wrote: > I have commented all the lines of other hardware models except custom device > line " common-obj-$(CONFIG_TESTPCI) += testpci.o ". > But when I run make I get errors similar to error shown in file which I have > shared with you in previ

Re: New Hardware model emulation

2020-03-04 Thread Priyamvad Acharya
> I have commented all the lines of other hardware models except custom device line *" common-obj-$(CONFIG_TESTPCI) += testpci.o "*. > But when I run *make* I get errors similar to error shown in file which I have shared with you in previous replies. Above custom device I am building for Qemu ARM

Re: [PATCH v4 5/5] iotests: 287: add qcow2 compression type test

2020-03-04 Thread Vladimir Sementsov-Ogievskiy
03.03.2020 16:34, Denis Plotnikov wrote: The test checks fulfilling qcow2 requiriements for the compression type feature and zstd compression type operability. Signed-off-by: Denis Plotnikov --- tests/qemu-iotests/287 | 127 + tests/qemu-iotests/287.ou

[PATCH v6 00/18] s390x: Protected Virtualization support

2020-03-04 Thread Janosch Frank
Most of the QEMU changes for PV are related to the new IPL type with subcodes 8 - 10 and the execution of the necessary Ultravisor calls to IPL secure guests. Note that we can only boot into secure mode from normal mode, i.e. stfle 161 is not active in secure mode. The other changes related to dat

[PATCH v6 06/18] s390x: protvirt: Inhibit balloon when switching to protected mode

2020-03-04 Thread Janosch Frank
Ballooning in protected VMs can only be done when the guest shares the pages it gives to the host. If pages are not shared, the integrity checks will fail once those pages have been altered and are given back to the guest. Hence, until we have a solution for this in the guest kernel, we inhibit ba

[PATCH v6 01/18] Sync pv

2020-03-04 Thread Janosch Frank
Signed-off-by: Janosch Frank --- linux-headers/linux/kvm.h | 43 +-- 1 file changed, 41 insertions(+), 2 deletions(-) diff --git a/linux-headers/linux/kvm.h b/linux-headers/linux/kvm.h index 265099100e..e36f761194 100644 --- a/linux-headers/linux/kvm.h +++ b/l

[PATCH v6 11/18] s390x: protvirt: Set guest IPL PSW

2020-03-04 Thread Janosch Frank
Handling of CPU reset and setting of the IPL psw from guest storage at offset 0 is done by a Ultravisor call. Let's only fetch it if necessary. Signed-off-by: Janosch Frank Reviewed-by: Thomas Huth --- target/s390x/cpu.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletion

[PATCH v6 03/18] s390x: protvirt: Support unpack facility

2020-03-04 Thread Janosch Frank
When a guest has saved a ipib of type 5 and calls diagnose308 with subcode 10, we have to setup the protected processing environment via Ultravisor calls. The calls are done by KVM and are exposed via an API. The following steps are necessary: 1. Enable protected mode for the VM (register it and i

[PATCH v6 02/18] s390x: protvirt: Add diag308 subcodes 8 - 10

2020-03-04 Thread Janosch Frank
For diag308 subcodes 8 - 10 we have a new ipib of type 5. The ipib holds the address and length of the secure execution header, as well as a list of guest components. Each component is a block of memory, for example kernel or initrd, which needs to be decrypted by the Ultravisor in order to run a

[PATCH v6 04/18] s390x: protvirt: Add migration blocker

2020-03-04 Thread Janosch Frank
Migration is not yet supported. Signed-off-by: Janosch Frank --- hw/s390x/s390-virtio-ccw.c | 33 - 1 file changed, 24 insertions(+), 9 deletions(-) diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c index dd39890f89..272531a9ee 100644 --- a/hw/

[PATCH v6 08/18] s390x: Add SIDA memory ops

2020-03-04 Thread Janosch Frank
Protected guests save the instruction control blocks in the SIDA instead of QEMU/KVM directly accessing the guest's memory. Let's introduce new functions to access the SIDA. Signed-off-by: Janosch Frank --- linux-headers/linux/kvm.h | 2 ++ target/s390x/cpu.h| 7 ++- target/s390x/

[PATCH v6 07/18] s390x: protvirt: KVM intercept changes

2020-03-04 Thread Janosch Frank
Secure guests no longer intercept with code 4 for an instruction interception. Instead they have codes 104 and 108 for secure instruction interception and secure instruction notification respectively. The 104 mirrors the 4 interception. The 108 is a notification interception to let KVM and QEMU k

[PATCH v6 05/18] s390x: protvirt: Handle diag 308 subcodes 0,1,3,4

2020-03-04 Thread Janosch Frank
As we now have access to the protection state of the cpus, we can implement special handling of diag 308 subcodes for cpus in the protected state. For subcodes 0 and 1 we need to unshare all pages before continuing, so the guest doesn't accidentally expose data when dumping. For subcode 3/4 we te

[PATCH v6 14/18] s390x: protvirt: Move IO control structures over SIDA

2020-03-04 Thread Janosch Frank
For protected guests, we need to put the IO emulation results into the SIDA, so SIE will write them into the guest at the next entry. Signed-off-by: Janosch Frank --- target/s390x/ioinst.c | 87 ++- 1 file changed, 61 insertions(+), 26 deletions(-) diff -

[PATCH v6 17/18] docs: Add protvirt docs

2020-03-04 Thread Janosch Frank
Lets add some documentation for the Protected VM functionality. Signed-off-by: Janosch Frank --- docs/system/index.rst| 1 + docs/system/protvirt.rst | 57 2 files changed, 58 insertions(+) create mode 100644 docs/system/protvirt.rst diff --git a/d

[PATCH v6 10/18] s390x: protvirt: SCLP interpretation

2020-03-04 Thread Janosch Frank
SCLP for a protected guest is done over the SIDAD, so we need to use the s390_cpu_virt_mem_* functions to access the SIDAD instead of guest memory when reading/writing SCBs. To not confuse the sclp emulation, we set 0x4000 as the SCCB address, since the function that injects the sclp external inte

[PATCH v6 16/18] s390x: Add unpack facility feature to GA1

2020-03-04 Thread Janosch Frank
From: Christian Borntraeger The unpack facility is an indication that diagnose 308 subcodes 8-10 are available to the guest. That means, that the guest can put itself into protected mode. Once it is in protected mode, the hardware stops any attempt of VM introspection by the hypervisor. Some fe

[PATCH v6 18/18] pc-bios: s390x: Save iplb location in lowcore

2020-03-04 Thread Janosch Frank
The POP states that for a list directed IPL the IPLB is stored into memory by the machine loader and its address is stored at offset 0x14 of the lowcore. ZIPL currently uses the address in offset 0x14 to access the IPLB and acquire flags about secure boot. If the IPLB address points into memory wh

[PATCH v6 12/18] s390x: protvirt: Move diag 308 data over SIDAD

2020-03-04 Thread Janosch Frank
For protected guests the IPIB is written/read to/from the satellite block, so we need those accesses to go through s390_cpu_pv_mem_read/write(). Signed-off-by: Janosch Frank --- target/s390x/diag.c | 30 +++--- 1 file changed, 23 insertions(+), 7 deletions(-) diff --git

[PATCH v6 09/18] s390x: protvirt: Move STSI data over SIDAD

2020-03-04 Thread Janosch Frank
For protected guests, we need to put the STSI emulation results into the SIDA, so SIE will write them into the guest at the next entry. Signed-off-by: Janosch Frank Acked-by: David Hildenbrand --- target/s390x/kvm.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --

[PATCH v6 13/18] s390x: protvirt: Disable address checks for PV guest IO emulation

2020-03-04 Thread Janosch Frank
IO instruction data is routed through SIDAD for protected guests, so adresses do not need to be checked, as this is kernel memory. Signed-off-by: Janosch Frank Reviewed-by: Thomas Huth --- target/s390x/ioinst.c | 26 +++--- 1 file changed, 19 insertions(+), 7 deletions(-) d

[PATCH v6 15/18] s390x: protvirt: Handle SIGP store status correctly

2020-03-04 Thread Janosch Frank
Status storing is not done by QEMU anymore, but is handled by SIE. Signed-off-by: Janosch Frank Reviewed-by: Thomas Huth --- target/s390x/helper.c | 4 target/s390x/sigp.c | 1 + 2 files changed, 5 insertions(+) diff --git a/target/s390x/helper.c b/target/s390x/helper.c index ed72684911

Re: [PATCH v5 16/50] multi-process: Synchronize remote memory

2020-03-04 Thread Dr. David Alan Gilbert
* Jagannathan Raman (jag.ra...@oracle.com) wrote: > Add memory-listener object which is used to keep the view of the RAM > in sync between QEMU and remote process. > A MemoryListener is registered for system-memory AddressSpace. The > listener sends SYNC_SYSMEM message to the remote process when me

Re: [PATCH v2 00/30] Configurable policy for handling deprecated interfaces

2020-03-04 Thread Peter Krempa
On Tue, Mar 03, 2020 at 17:34:35 +0100, Markus Armbruster wrote: > Based-on: <20200227144531.24309-1-arm...@redhat.com> > > This series extends QMP introspection to cover deprecation. > Additionally, new option -compat lets you configure what to do when > deprecated interfaces get used. This is i

Re: Wiki user request

2020-03-04 Thread Philippe Mathieu-Daudé
Ping? Le jeu. 27 févr. 2020 10:29, Joaquin de Andres a écrit : > Hi! > > I wonder if I can get write access to the wiki page. I'm working with > Philippe Mathieu-Daudé in the GSoC Arduino Visualization project ([1]) > and I need to modify and add pages. > > Thanks! > --joa > > [1] https://wiki.q

Re: [PATCH] optionrom/pvh: scan entire RSDP Area

2020-03-04 Thread Paolo Bonzini
On 04/03/20 09:55, Stefano Garzarella wrote: > CCing Paolo > > On Tue, Mar 03, 2020 at 02:52:47AM -0800, Joe Richey wrote: >> From: Joe Richey >> >> Right now the PVH option rom scans for the RSDP from 0xE to >> 0xE1FFF. This is probobly a typo, it should scan from 0xE to >> 0xF. >> >

Re: [PATCH v6 18/18] pc-bios: s390x: Save iplb location in lowcore

2020-03-04 Thread David Hildenbrand
On 04.03.20 12:42, Janosch Frank wrote: > The POP states that for a list directed IPL the IPLB is stored into > memory by the machine loader and its address is stored at offset 0x14 > of the lowcore. > > ZIPL currently uses the address in offset 0x14 to access the IPLB and > acquire flags about se

Re: [PATCH v4 4/5] qcow2: add zstd cluster compression

2020-03-04 Thread Denis Plotnikov
On 04.03.2020 10:49, Vladimir Sementsov-Ogievskiy wrote: 03.03.2020 16:34, Denis Plotnikov wrote: zstd significantly reduces cluster compression time. It provides better compression performance maintaining the same level of the compression ratio in comparison with zlib, which, at the moment,

Re: [PATCH v4 5/5] iotests: 287: add qcow2 compression type test

2020-03-04 Thread Denis Plotnikov
On 04.03.2020 14:27, Vladimir Sementsov-Ogievskiy wrote: 03.03.2020 16:34, Denis Plotnikov wrote: The test checks fulfilling qcow2 requiriements for the compression type feature and zstd compression type operability. Signed-off-by: Denis Plotnikov ---   tests/qemu-iotests/287 | 127

[PATCH v2 0/4] Introducing QMP query-netdevs command

2020-03-04 Thread Alexey Kirillov
This patch series introduces a new QMP command "query-netdevs" to get information about currently attached network devices. Also, since the "info_str" field of "NetClientState" is now deprecated, it has been completely removed. The HMP command "info network" now also uses the new QMP command inside

[PATCH v2 1/4] qapi: net: Add query-netdevs command

2020-03-04 Thread Alexey Kirillov
Add a qmp command that provides information about currently attached network devices and their configuration. Signed-off-by: Alexey Kirillov --- include/net/net.h | 1 + net/hub.c | 8 +++ net/l2tpv3.c | 19 +++ net/net.c | 91 + net

[PATCH v2 3/4] hmp: Use QMP query-netdevs in hmp_info_network

2020-03-04 Thread Alexey Kirillov
Replace legacy field info_str of NetClientState with result of QMP command query-netdevs. Signed-off-by: Alexey Kirillov --- include/net/net.h | 3 +- net/clients.h | 1 + net/hub.c | 4 +- net/hub.h | 2 +- net/net.c | 175

[PATCH v2 2/4] tests: Add tests for query-netdevs command

2020-03-04 Thread Alexey Kirillov
Signed-off-by: Alexey Kirillov --- tests/qtest/Makefile.include | 2 + tests/qtest/test-query-netdevs.c | 120 +++ 2 files changed, 122 insertions(+) create mode 100644 tests/qtest/test-query-netdevs.c diff --git a/tests/qtest/Makefile.include b/tests/qtest/Mak

[PATCH v2 4/4] net: Remove field info_str of NetClientState

2020-03-04 Thread Alexey Kirillov
Completely remove the info_str field of struct NetClientState because it is no longer required due to the addition of the QMP query-netdevs command. Signed-off-by: Alexey Kirillov --- hw/net/allwinner_emac.c | 2 +- hw/net/dp8393x.c| 2 +- hw/net/e1000.c | 4 ++--

[PULL v1 07/10] docs/specs/tpm: Document TPM_TIS sysbus device for ARM

2020-03-04 Thread Stefan Berger
From: Eric Auger Update the documentation with recent changes related to the sysbus TPM_TIS device addition and add the command line to be used with arm VIRT. Signed-off-by: Eric Auger Reviewed-by: Stefan Berger Message-id: 20200226205942.11424-8-eric.au...@redhat.com Signed-off-by: Stefan Ber

[PULL v1 10/10] test: tpm-tis: Add Sysbus TPM-TIS device test

2020-03-04 Thread Stefan Berger
From: Eric Auger The tests themselves are the same as the ISA device ones. Only the main() changes as the "tpm-tis-device" device gets instantiated. Also the base address of the device is not 0xFED4 anymore but matches the base address of the ARM virt platform bus. Signed-off-by: Eric Auger

[PULL v1 03/10] tpm: Separate tpm_tis common functions from isa code

2020-03-04 Thread Stefan Berger
From: Eric Auger Move the device agnostic code into tpm_tis_common.c and put the ISA device specific code into tpm_tis_isa.c Signed-off-by: Eric Auger Reviewed-by: Stefan Berger Tested-by: Ard Biesheuvel Acked-by: Ard Biesheuvel Message-id: 20200226205942.11424-4-eric.au...@redhat.com Signed

[PULL v1 08/10] test: tpm: pass optional machine options to swtpm test functions

2020-03-04 Thread Stefan Berger
From: Eric Auger We plan to use swtpm test functions on ARM for testing the sysbus TPM-TIS device. However on ARM there is no default machine type. So we need to explictly pass some machine options on startup. Let's allow this by adding a new parameter to both swtpm test functions and update all

[PULL v1 05/10] tpm: Add the SysBus TPM TIS device

2020-03-04 Thread Stefan Berger
From: Eric Auger Introduce the tpm-tis-device which is a sysbus device and is bound to be used on ARM. Signed-off-by: Eric Auger Reviewed-by: Stefan Berger Tested-by: Ard Biesheuvel Acked-by: Ard Biesheuvel Message-id: 20200226205942.11424-6-eric.au...@redhat.com Signed-off-by: Stefan Berger

[PULL v1 06/10] hw/arm/virt: vTPM support

2020-03-04 Thread Stefan Berger
From: Eric Auger Let the TPM TIS SYSBUS device be dynamically instantiable in ARM virt. A device tree node is dynamically created (TPM via MMIO). The TPM Physical Presence interface (PPI) is not supported. To run with the swtmp TPM emulator, the qemu command line must be augmented with:

[PULL v1 09/10] test: tpm-tis: Get prepared to share tests between ISA and sysbus devices

2020-03-04 Thread Stefan Berger
From: Eric Auger ISA and sysbus TPM-TIS devices will share their tests. Only the main() will change (instantiation option is different). Also the base address of the TPM-TIS device is going to be different. on x86 it is located at 0xFED4 while on ARM it can be located at any location, discove

[PULL v1 00/10] Merge TPM 2020/03/04

2020-03-04 Thread Stefan Berger
This series of patches adds support for TPM on ARM. Regards, Stefan The following changes since commit 2ac031d171ccd18c973014d9978b4a63f0ad5fb0: Merge remote-tracking branch 'remotes/palmer/tags/riscv-for-master-5.0-sf3' into staging (2020-03-03 11:06:39 +) are available in the Git r

[PULL v1 04/10] tpm: Separate TPM_TIS and TPM_TIS_ISA configs

2020-03-04 Thread Stefan Berger
From: Eric Auger Let's separate the compilation of tpm_tis_common.c from the compilation of tpm_tis_isa.c The common part will be also compiled along with the tpm_tis_sysbus device. Signed-off-by: Eric Auger Reviewed-by: Philippe Mathieu-Daudé Tested-by: Ard Biesheuvel Acked-by: Ard Biesheuv

Re: [PATCH 1/2] misc: Replace zero-length arrays with flexible array member (automatic)

2020-03-04 Thread Philippe Mathieu-Daudé
On 3/4/20 1:51 AM, Philippe Mathieu-Daudé wrote: Description copied from Linux kernel commit from Gustavo A. R. Silva (see [3]): --v-- description start --v-- The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to

[PULL v1 01/10] tpm: rename TPM_TIS into TPM_TIS_ISA

2020-03-04 Thread Stefan Berger
From: Eric Auger As we plan to introduce a sysbus TPM_TIS, let's rename TPM_TIS into TPM_TIS_ISA. Signed-off-by: Eric Auger Reviewed-by: Stefan Berger Reviewed-by: Philippe Mathieu-Daudé Tested-by: Ard Biesheuvel Acked-by: Ard Biesheuvel Message-id: 20200226205942.11424-2-eric.au...@redhat.

[PULL v1 02/10] tpm: Use TPMState as a common struct

2020-03-04 Thread Stefan Berger
From: Eric Auger As we plan to introduce a SysBus TPM TIS device, let's make the TPMState a common struct usable by both the ISADevice and the SysBusDevice. TPMStateISA embeds the struct and inherits from the ISADevice. The prototype of functions bound to be used by both the ISA and SysBus devic

Re: [PATCH v6 18/18] pc-bios: s390x: Save iplb location in lowcore

2020-03-04 Thread Christian Borntraeger
On 04.03.20 12:42, Janosch Frank wrote: > The POP states that for a list directed IPL the IPLB is stored into > memory by the machine loader and its address is stored at offset 0x14 > of the lowcore. > > ZIPL currently uses the address in offset 0x14 to access the IPLB and > acquire flags about se

Re: [PATCH] dp8393x: Mask EOL bit from descriptor addresses, take 2

2020-03-04 Thread Philippe Mathieu-Daudé
On 3/4/20 4:23 AM, Finn Thain wrote: A portion of a recent patch got lost due to a merge snafu. That patch is now commit 88f632fbb1 ("dp8393x: Mask EOL bit from descriptor addresses"). This patch restores the portion that got lost. Signed-off-by: Finn Thain --- hw/net/dp8393x.c | 4 ++-- 1 f

[PATCH v5 1/5] block/qcow2-threads: fix qcow2_decompress

2020-03-04 Thread Denis Plotnikov
From: Vladimir Sementsov-Ogievskiy On success path we return what inflate() returns instead of 0. And it most probably works for Z_STREAM_END as it is positive, but is definitely broken for Z_BUF_ERROR. While being here, switch to errno return code, to be closer to qcow2_compress API (and usual

[PATCH v5 0/5] qcow2: Implement zstd cluster compression method

2020-03-04 Thread Denis Plotnikov
v5: * replace -ENOTSUP with abort in qcow2_co_decompress [Vladimir] * set cluster size for all test cases in the beginning of the 287 test v4: * the series is rebased on top of 01 "block/qcow2-threads: fix qcow2_decompress" * 01 is just a no-change resend to avoid extra dependencies.

[PATCH v5 3/5] qcow2: rework the cluster compression routine

2020-03-04 Thread Denis Plotnikov
The patch enables processing the image compression type defined for the image and chooses an appropriate method for image clusters (de)compression. Signed-off-by: Denis Plotnikov Reviewed-by: Vladimir Sementsov-Ogievskiy --- block/qcow2-threads.c | 71 ---

[PATCH v5 4/5] qcow2: add zstd cluster compression

2020-03-04 Thread Denis Plotnikov
zstd significantly reduces cluster compression time. It provides better compression performance maintaining the same level of the compression ratio in comparison with zlib, which, at the moment, is the only compression method available. The performance test results: Test compresses and decompresse

Re: [PATCH v6 18/18] pc-bios: s390x: Save iplb location in lowcore

2020-03-04 Thread David Hildenbrand
On 04.03.20 14:25, Christian Borntraeger wrote: > On 04.03.20 12:42, Janosch Frank wrote: >> The POP states that for a list directed IPL the IPLB is stored into >> memory by the machine loader and its address is stored at offset 0x14 >> of the lowcore. >> >> ZIPL currently uses the address in offse

  1   2   3   >