Re: [PATCH v7 00/11] error: auto propagated local_err part I

2020-03-03 Thread Markus Armbruster
Hi Vladimir, I've come to rather like your ERRP_AUTO_PROPAGATE() idea. What I wouldn't like is a protracted conversion. Once we're happy with PATCH 1-3, it's a matter of running Coccinelle and reviewing its output. I'm confident we can converge on PATCH 1-3. It's two weeks until soft freeze.

Re: [PATCH v6 0/4] Improve default object property_add uint helpers

2020-03-03 Thread Felipe Franciosi
Hi Marc/Paolo, > On Feb 4, 2020, at 1:41 PM, Marc-André Lureau > wrote: > > Hi > > On Tue, Feb 4, 2020 at 2:16 PM Felipe Franciosi wrote: >> >> This improves the family of object_property_add_uintXX_ptr helpers by >> enabling >> a default getter/setter only when desired. To prevent an API b

Re: [PATCH v5 1/4] qapi: Add a 'coroutine' flag for commands

2020-03-03 Thread Markus Armbruster
Kevin Wolf writes: > This patch adds a new 'coroutine' flag to QMP command definitions that > tells the QMP dispatcher that the command handler is safe to be run in a > coroutine. > > The documentation of the new flag pretends that this flag is already > used as intended, which it isn't yet after

Re: [PATCH v7 00/11] error: auto propagated local_err part I

2020-03-03 Thread Vladimir Sementsov-Ogievskiy
03.03.2020 11:01, Markus Armbruster wrote: Hi Vladimir, I've come to rather like your ERRP_AUTO_PROPAGATE() idea. What I wouldn't like is a protracted conversion. Once we're happy with PATCH 1-3, it's a matter of running Coccinelle and reviewing its output. I'm confident we can converge on PA

Re: [PATCH v6 0/4] Improve default object property_add uint helpers

2020-03-03 Thread Paolo Bonzini
On 03/03/20 09:05, Felipe Franciosi wrote: >> >> Paolo, would you queue it? > Ping: did this get lost? Yes, I have queued it now and fixed the conflicts. Paolo

Re: [PATCH v6 0/4] Improve default object property_add uint helpers

2020-03-03 Thread Felipe Franciosi
> On Mar 3, 2020, at 8:25 AM, Paolo Bonzini wrote: > > On 03/03/20 09:05, Felipe Franciosi wrote: >>> >>> Paolo, would you queue it? >> Ping: did this get lost? > > Yes, I have queued it now and fixed the conflicts. > > Paolo > Thanks! Sorry for conflicts, I should have pinged sooner. F.

Re: [PATCH v3] hw/smbios: add options for type 4 max-speed and current-speed

2020-03-03 Thread Igor Mammedov
On Tue, 3 Mar 2020 11:18:56 +0800 Heyi Guo wrote: > One comment from myself after going through the code... > > On 2020/3/3 9:01, Heyi Guo wrote: > > Common VM users sometimes care about CPU speed, so we add two new > > options to allow VM vendors to present CPU speed to their users. > > Normall

Re: [PATCH v3 09/15] util/mmap-alloc: Factor out populating of memory to mmap_populate()

2020-03-03 Thread David Hildenbrand
On 27.02.20 11:11, David Hildenbrand wrote: > We want to populate memory within a reserved memory region. Let's factor > that out. > > Reviewed-by: Richard Henderson > Acked-by: Murilo Opsfelder Araujo > Reviewed-by: Peter Xu > Cc: Igor Kotrasinski > Cc: "Michael S. Tsirkin" > Cc: Greg Kurz

Re: [PATCH v4 09/16] target/i386: Cleanup and use the EPYC mode topology functions

2020-03-03 Thread Igor Mammedov
On Mon, 2 Mar 2020 11:09:14 -0600 Babu Moger wrote: > On 2/25/20 1:49 AM, Igor Mammedov wrote: > > On Mon, 24 Feb 2020 11:29:37 -0600 > > Babu Moger wrote: > > > >> On 2/24/20 2:52 AM, Igor Mammedov wrote: > >>> On Thu, 13 Feb 2020 12:17:25 -0600 > >>> Babu Moger wrote: > >>> > U

Re: [PATCH v5 3/4] qmp: Move dispatcher to a coroutine

2020-03-03 Thread Markus Armbruster
Kevin Wolf writes: > This moves the QMP dispatcher to a coroutine and runs all QMP command > handlers that declare 'coroutine': true in coroutine context so they > can avoid blocking the main loop while doing I/O or waiting for other > events. > > For commands that are not declared safe to run in

Re: [PATCH v7 10/17] target/ppc: Only calculate RMLS derived RMA limit on demand

2020-03-03 Thread Greg Kurz
On Tue, 3 Mar 2020 14:43:44 +1100 David Gibson wrote: > When the LPCR is written, we update the env->rmls field with the RMA limit > it implies. Simplify things by just calculating the value directly from > the LPCR value when we need it. > > It's possible this is a little slower, but it's unl

Re: Implementing IOMMU support for SDHCI

2020-03-03 Thread Peter Maydell
On Tue, 3 Mar 2020 at 06:05, Sai Pavan Boddu wrote: > > From: Peter Maydell > > I don't think any of those scenarios are ones where you'd want the board > > model to be passing in a MemTxAttr at device creation time. > [Sai Pavan Boddu] Yeah ok, this makes sense. Only things which me might need

[PATCH] hw/arm/cubieboard: make sure SOC object isn't leaked

2020-03-03 Thread Igor Mammedov
SOC object returned by object_new() is leaked in current code. Set SOC parent explicitly to board and then unref to SOC object to make sure that refererence returned by object_new() is taken care of. The SOC object will be kept alive by its parent (machine) and will be automatically freed when Mac

Re: QAPI schema for desired state of LUKS keyslots (was: [PATCH 02/13] qcrypto-luks: implement encryption key management)

2020-03-03 Thread Maxim Levitsky
On Sat, 2020-02-15 at 15:51 +0100, Markus Armbruster wrote: > Review of this patch led to a lengthy QAPI schema design discussion. > Let me try to condense it into a concrete proposal. > > This is about the QAPI schema, and therefore about QMP. The > human-friendly interface is out of scope. Not

Re: [PATCH v2] riscv: sifive_u: Add a "serial" property for board serial number

2020-03-03 Thread Bin Meng
Hi Alistair, On Tue, Mar 3, 2020 at 8:07 AM Alistair Francis wrote: > > On Mon, Feb 24, 2020 at 9:02 PM Bin Meng wrote: > > > > Hi Alistair, > > > > On Tue, Feb 25, 2020 at 5:14 AM Alistair Francis > > wrote: > > > > > > On Sun, Feb 16, 2020 at 5:56 AM Bin Meng wrote: > > > > > > > > At prese

Re: [PATCH v7 11/17] target/ppc: Don't store VRMA SLBE persistently

2020-03-03 Thread Greg Kurz
On Tue, 3 Mar 2020 14:43:45 +1100 David Gibson wrote: > Currently, we construct the SLBE used for VRMA translations when the LPCR > is written (which controls some bits in the SLBE), then use it later for > translations. > > This is a bit complex and confusing - simplify it by simply constructi

Re: [PATCH v2] linux-user: Add AT_EXECFN auxval

2020-03-03 Thread Laurent Vivier
Le 02/03/2020 à 20:31, Lirong Yuan a écrit : > This change adds the support for AT_EXECFN auxval. > > Signed-off-by: Lirong Yuan > --- > Changelog since v1: > - remove implementation for AT_EXECFD auxval. > > linux-user/elfload.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > di

Re: [PATCH v16 00/10] VIRTIO-IOMMU device

2020-03-03 Thread Auger Eric
Hi Zhangfei, On 3/3/20 4:23 AM, Zhangfei Gao wrote: > Hi Eric > > On Thu, Feb 27, 2020 at 9:50 PM Auger Eric wrote: >> >> Hi Daniel, >> >> On 2/27/20 12:17 PM, Daniel P. Berrangé wrote: >>> On Fri, Feb 14, 2020 at 02:27:35PM +0100, Eric Auger wrote: This series implements the QEMU virtio-iom

Re: [PATCH] tests/acceptance: move @skipUnless decoration to test itself

2020-03-03 Thread Aleksandar Markovic
12:22 AM Uto, 03.03.2020. Philippe Mathieu-Daudé је написао/ла: > > From: Alex Bennée > > It appears ignore the decoration if just applied to the class. > > Fixes: 0484d9d4fbe9beacd > Signed-off-by: Alex Bennée > [PMD: Move decorations to each test function] > Signed-off-by: Philippe Mathieu-Dau

Re: [PATCH] hw/unicore32/puv3: Simplify puv3_soc_init()

2020-03-03 Thread Laurent Vivier
Le 21/02/2020 à 17:23, Philippe Mathieu-Daudé a écrit : > Since commit d8ed887bdc, the puv3_intc_cpu_handler handler takes > a pointer to UniCore32CPU in its opaque argument. Directly pass > the cpu pointer. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/unicore32/puv3.c | 7 +++ > 1

Re: [PATCH v7 14/17] spapr: Don't attempt to clamp RMA to VRMA constraint

2020-03-03 Thread Greg Kurz
On Tue, 3 Mar 2020 14:43:48 +1100 David Gibson wrote: > The Real Mode Area (RMA) is the part of memory which a guest can access > when in real (MMU off) mode. Of course, for a guest under KVM, the MMU > isn't really turned off, it's just in a special translation mode - Virtual > Real Mode Area

Re: [PATCH] hw/nios2/boot: Remove dead code (big endian check)

2020-03-03 Thread Laurent Vivier
Le 25/02/2020 à 12:51, Philippe Mathieu-Daudé a écrit : > We only build the little-endian softmmu configuration (all > Nios II processors are only little endian). Checking for > big endian is pointless, remove the unused code. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/nios2/boot.c | 9

Re: [PATCH v7 15/17] spapr: Don't clamp RMA to 16GiB on new machine types

2020-03-03 Thread Greg Kurz
On Tue, 3 Mar 2020 14:43:49 +1100 David Gibson wrote: > In spapr_machine_init() we clamp the size of the RMA to 16GiB and the > comment saying why doesn't make a whole lot of sense. In fact, this was > done because the real mode handling code elsewhere limited the RMA in TCG > mode to the maxim

[PATCH] cpu: Use DeviceClass reset instead of a special CPUClass reset

2020-03-03 Thread Peter Maydell
The CPUClass has a 'reset' method. This is a legacy from when TYPE_CPU used not to inherit from TYPE_DEVICE. We don't need it any more, as we can simply use the TYPE_DEVICE reset. The 'cpu_reset()' function is kept as the API which most places use to reset a CPU; it is now a wrapper which calls

[PULL V2 12/23] dp8393x: Always update RRA pointers and sequence numbers

2020-03-03 Thread Jason Wang
From: Finn Thain These operations need to take place regardless of whether or not rx descriptors have been used up (that is, EOL flag was observed). The algorithm is now the same for a packet that was withheld as for a packet that was not. Signed-off-by: Finn Thain Tested-by: Laurent Vivier S

[PULL V2 00/23] Net patches

2020-03-03 Thread Jason Wang
The following changes since commit e0175b71638cf4398903c0d25f93fe62e0606389: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20200228' into staging (2020-02-28 16:39:27 +) are available in the git repository at: https://github.com/jasowang/qemu.git tags/net-pull-requ

[PULL V2 01/23] dp8393x: Mask EOL bit from descriptor addresses

2020-03-03 Thread Jason Wang
From: Finn Thain The Least Significant bit of a descriptor address register is used as an EOL flag. It has to be masked when the register value is to be used as an actual address for copying memory around. But when the registers are to be updated the EOL bit should not be masked. Signed-off-by:

Re: [PATCH] cpu: Use DeviceClass reset instead of a special CPUClass reset

2020-03-03 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200303100511.5498-1-peter.mayd...@linaro.org/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN

[PULL V2 06/23] dp8393x: Clear RRRA command register bit only when appropriate

2020-03-03 Thread Jason Wang
From: Finn Thain It doesn't make sense to clear the command register bit unless the command was actually issued. Signed-off-by: Finn Thain Reviewed-by: Philippe Mathieu-Daudé Tested-by: Laurent Vivier Signed-off-by: Jason Wang --- hw/net/dp8393x.c | 7 +++ 1 file changed, 3 insertions(+

[PULL V2 03/23] dp8393x: Clean up endianness hacks

2020-03-03 Thread Jason Wang
From: Finn Thain According to the datasheet, section 3.4.4, "in 32-bit mode ... the SONIC always writes long words". Therefore, use the same technique for the 'in_use' field that is used everywhere else, and write the full long word. Signed-off-by: Finn Thain Tested-by: Laurent Vivier Reviewe

[PULL V2 02/23] dp8393x: Always use 32-bit accesses

2020-03-03 Thread Jason Wang
From: Finn Thain The DP83932 and DP83934 have 32 data lines. The datasheet says, Data Bus: These bidirectional lines are used to transfer data on the system bus. When the SONIC is a bus master, 16-bit data is transferred on D15-D0 and 32-bit data is transferred on D31-D0. When the SO

[PULL V2 05/23] dp8393x: Update LLFA and CRDA registers from rx descriptor

2020-03-03 Thread Jason Wang
From: Finn Thain Follow the algorithm given in the National Semiconductor DP83932C datasheet in section 3.4.7: At the next reception, the SONIC re-reads the last RXpkt.link field, and updates its CRDA register to point to the next descriptor. The chip is designed to allow the host to pr

[PULL V2 11/23] dp8393x: Clear descriptor in_use field to release packet

2020-03-03 Thread Jason Wang
From: Finn Thain When the SONIC receives a packet into the last available descriptor, it retains ownership of that descriptor for as long as necessary. Section 3.4.7 of the datasheet says, When the system appends more descriptors, the SONIC releases ownership of the descriptor after wri

[PULL V2 04/23] dp8393x: Have dp8393x_receive() return the packet size

2020-03-03 Thread Jason Wang
From: Finn Thain This function re-uses its 'size' argument as a scratch variable. Instead, declare a local 'size' variable for that purpose so that the function result doesn't get messed up. Signed-off-by: Finn Thain Reviewed-by: Philippe Mathieu-Daudé Tested-by: Laurent Vivier Signed-off-by:

[PULL V2 07/23] dp8393x: Implement packet size limit and RBAE interrupt

2020-03-03 Thread Jason Wang
From: Finn Thain Add a bounds check to prevent a large packet from causing a buffer overflow. This is defensive programming -- I haven't actually tried sending an oversized packet or a jumbo ethernet frame. The SONIC handles packets that are too big for the buffer by raising the RBAE interrupt a

[PULL V2 10/23] dp8393x: Pad frames to word or long word boundary

2020-03-03 Thread Jason Wang
From: Finn Thain The existing code has a bug where the Remaining Buffer Word Count (RBWC) is calculated with a truncating division, which gives the wrong result for odd-sized packets. Section 1.4.1 of the datasheet says, Once the end of the packet has been reached, the serializer will f

[PULL V2 09/23] dp8393x: Use long-word-aligned RRA pointers in 32-bit mode

2020-03-03 Thread Jason Wang
From: Finn Thain Section 3.4.1 of the datasheet says, The alignment of the RRA is confined to either word or long word boundaries, depending upon the data width mode. In 16-bit mode, the RRA must be aligned to a word boundary (A0 is always zero) and in 32-bit mode, the RRA is ali

[PULL V2 13/23] dp8393x: Don't reset Silicon Revision register

2020-03-03 Thread Jason Wang
From: Finn Thain The jazzsonic driver in Linux uses the Silicon Revision register value to probe the chip. The driver fails unless the SR register contains 4. Unfortunately, reading this register in QEMU usually returns 0 because the s->regs[] array gets wiped after a software reset. Fixes: bd8f

[PULL V2 08/23] dp8393x: Don't clobber packet checksum

2020-03-03 Thread Jason Wang
From: Finn Thain A received packet consumes pkt_size bytes in the buffer and the frame checksum that's appended to it consumes another 4 bytes. The Receive Buffer Address register takes the former quantity into account but not the latter. So the next packet written to the buffer overwrites the fr

[PULL V2 18/23] hw: net: cadence_gem: Fix build errors in DB_PRINT()

2020-03-03 Thread Jason Wang
From: Bin Meng When CADENCE_GEM_ERR_DEBUG is turned on, there are several compilation errors in DB_PRINT(). Fix them. While we are here, update to use appropriate modifiers in the same DB_PRINT() call. Signed-off-by: Bin Meng Reviewed-by: Alistair Francis Signed-off-by: Jason Wang --- hw/ne

[PULL V2 17/23] NetRxPkt: fix hash calculation of IPV6 TCP

2020-03-03 Thread Jason Wang
From: Yuri Benditovich When requested to calculate the hash for TCPV6 packet, ignore overrides of source and destination addresses in in extension headers. Use these overrides when new hash type NetPktRssIpV6TcpEx requested. Use this type in e1000e hash calculation for IPv6 TCP, which should take

Re: [PATCH] cpu: Use DeviceClass reset instead of a special CPUClass reset

2020-03-03 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200303100511.5498-1-peter.mayd...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH] cpu: Use DeviceClass reset instead of a special CPUClass reset Message-id: 20200303100511.549

[PULL V2 14/23] dp8393x: Don't stop reception upon RBE interrupt assertion

2020-03-03 Thread Jason Wang
From: Finn Thain Section 3.4.7 of the datasheet explains that, The RBE bit in the Interrupt Status register is set when the SONIC finishes using the second to last receive buffer and reads the last RRA descriptor. Actually, the SONIC is not truly out of resources, but gives the s

Re: [PATCH] target/i386/hax-posix: fix two 'format-truncation' compile warnings

2020-03-03 Thread Laurent Vivier
Le 24/02/2020 à 07:51, pannengy...@huawei.com a écrit : > From: Pan Nengyuan > > Fix compile warnings: > /mnt/sdb/qemu-new/qemu_test/qemu/target/i386/hax-posix.c:124:56: error: > ‘%02d’ directive output may be truncated writing between 2 and 11 bytes into > a region of size 3 [-Werror=format-tr

Re: [PATCH 1/3] usb/hcd-xhci: Make dma read/writes hooks pci free

2020-03-03 Thread Gerd Hoffmann
Hi, > @@ -189,6 +191,7 @@ struct XHCIState { > > USBBus bus; > MemoryRegion mem; > +AddressSpace *as; > MemoryRegion mem_cap; > MemoryRegion mem_oper; > MemoryRegion mem_runtime; as is not initialized ... I guess the patch was never tested? cheers, Gerd

[PULL V2 22/23] colo: Update Documentation for continuous replication

2020-03-03 Thread Jason Wang
From: Lukas Straub Document the qemu command-line and qmp commands for continuous replication Signed-off-by: Lukas Straub Signed-off-by: Jason Wang --- docs/COLO-FT.txt | 224 + docs/block-replication.txt | 28 -- 2 files changed, 184

[PULL V2 16/23] NetRxPkt: Introduce support for additional hash types

2020-03-03 Thread Jason Wang
From: Yuri Benditovich Add support for following hash types: IPV6 TCP with extension headers IPV4 UDP IPV6 UDP IPV6 UDP with extension headers Signed-off-by: Yuri Benditovich Acked-by: Dmitry Fleytman Signed-off-by: Jason Wang --- hw/net/net_rx_pkt.c | 42

[PULL V2 21/23] net/filter.c: Add Options to insert filters anywhere in the filter list

2020-03-03 Thread Jason Wang
From: Lukas Straub To switch the Secondary to Primary, we need to insert new filters before the filter-rewriter. Add the options insert= and position= to be able to insert filters anywhere in the filter list. position should be "head" or "tail" to insert at the head or tail of the filter list o

Re: [PATCH] cpu: Use DeviceClass reset instead of a special CPUClass reset

2020-03-03 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200303100511.5498-1-peter.mayd...@linaro.org/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGI

[PULL V2 19/23] block/replication.c: Ignore requests after failover

2020-03-03 Thread Jason Wang
From: Lukas Straub After failover the Secondary side of replication shouldn't change state, because it now functions as our primary disk. In replication_start, replication_do_checkpoint, replication_stop, ignore the request if current state is BLOCK_REPLICATION_DONE (sucessful failover) or BLOCK

[PULL V2 15/23] e1000e: Avoid hw_error if legacy mode used

2020-03-03 Thread Jason Wang
From: Yuri Benditovich https://bugzilla.redhat.com/show_bug.cgi?id=1787142 The emulation issues hw_error if PSRCTL register is written, for example, with zero value. Such configuration does not present any problem when DTYP bits of RCTL register define legacy format of transfer descriptors. Curre

Re: [PULL 00/23] Net patches

2020-03-03 Thread Jason Wang
On 2020/3/2 下午10:11, Peter Maydell wrote: On Mon, 2 Mar 2020 at 07:40, Jason Wang wrote: The following changes since commit e0175b71638cf4398903c0d25f93fe62e0606389: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20200228' into staging (2020-02-28 16:39:27 +) a

[PULL V2 20/23] tests/test-replication.c: Add test for for secondary node continuing replication

2020-03-03 Thread Jason Wang
From: Lukas Straub This simulates the case that happens when we resume COLO after failover. Signed-off-by: Lukas Straub Signed-off-by: Jason Wang --- tests/test-replication.c | 52 1 file changed, 52 insertions(+) diff --git a/tests/test-repli

[PULL V2 23/23] l2tpv3: fix RFC number typo in qemu-options.hx

2020-03-03 Thread Jason Wang
From: Stefan Hajnoczi The L2TPv3 RFC number is 3931: https://tools.ietf.org/html/rfc3931 Reported-by: Henrik Johansson Reviewed-by: Stefan Weil Signed-off-by: Stefan Hajnoczi Signed-off-by: Jason Wang --- qemu-options.hx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH] cpu: Use DeviceClass reset instead of a special CPUClass reset

2020-03-03 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200303100511.5498-1-peter.mayd...@linaro.org/ Hi, This series failed build test on FreeBSD host. Please find the details below. === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the git checkout with # HEAD pointing to a commi

Re: [PATCH 3/3] usb/hcd-xhci: Split pci wrapper for xhci base model

2020-03-03 Thread Gerd Hoffmann
On Mon, Mar 02, 2020 at 03:05:24PM +0530, Sai Pavan Boddu wrote: > This patch sets the base to use xhci as sysbus model, for which pci > specific hooks are moved to hcd-xhci-pci.c. As a part of this requirment > msi/msix interrupts handling is moved under XHCIPCIState. Made required > changes for q

Re: [PATCH v4] i386: Fix GCC warning with snprintf when HAX is enabled

2020-03-03 Thread Paolo Bonzini
On 02/03/20 21:13, Julio Faracco wrote: > When HAX is enabled (--enable-hax), GCC 9.2.1 reports issues with > snprintf(). Replacing old snprintf() by g_strdup_printf() fixes the > problem with boundary checks of vm_id and vcpu_id and finally the > warnings produced by GCC. > > For more details, on

Re: [PATCH] vhost-vsock: fix error message output

2020-03-03 Thread Laurent Vivier
Le 01/03/2020 à 13:03, Nick Erdmann a écrit : > error_setg_errno takes a positive error number, so we should not invert > errno's sign. > > Signed-off-by: Nick Erdmann > --- >  hw/virtio/vhost-vsock.c | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/virtio/vhost-vsock.

Re: [PATCH v3 11/12] usb/hcd-ehci: Remove redundant statements

2020-03-03 Thread Gerd Hoffmann
On Mon, Mar 02, 2020 at 09:07:14PM +0800, Chen Qun wrote: > The "again" assignment is meaningless before g_assert_not_reached. > In addition, the break statements no longer needs to be after > g_assert_not_reached. > > Clang static code analyzer show warning: > hw/usb/hcd-ehci.c:2108:13: warning:

Re: [PATCH] WHPX: Use proper synchronization primitives while processing

2020-03-03 Thread Paolo Bonzini
On 24/02/20 20:27, Sunil Muthuswamy wrote: > WHPX wasn't using the proper synchronization primitives while > processing async events, which can cause issues with SMP. > > Signed-off-by: Sunil Muthuswamy > --- > target/i386/whpx-all.c | 17 +++-- > 1 file changed, 7 insertions(+), 10

Re: [PATCH v7 16/17] spapr: Clean up RMA size calculation

2020-03-03 Thread Greg Kurz
On Tue, 3 Mar 2020 14:43:50 +1100 David Gibson wrote: > Move the calculation of the Real Mode Area (RMA) size into a helper > function. While we're there clean it up and correct it in a few ways: > * Add comments making it clearer where the various constraints come from > * Remove a pointle

Re: [PATCH v2 00/14] tests/vm: Add support for aarch64 VMs

2020-03-03 Thread Alex Bennée
Robert Foley writes: > On Mon, 2 Mar 2020 at 11:38, Alex Bennée wrote: >> >> >> Robert Foley writes: >> >> > This is version 2 of the patch series to >> > add support for aarch64 VMs. >> > - Ubuntu 18.04 aarch64 VM >> > - CentOS 8 aarch64 VM >> >> For now I've pulled the first 5 patches int

Re: [PATCH] tests/acceptance: move @skipUnless decoration to test itself

2020-03-03 Thread Alex Bennée
Aleksandar Markovic writes: > 12:22 AM Uto, 03.03.2020. Philippe Mathieu-Daudé је > написао/ла: >> >> From: Alex Bennée >> >> It appears ignore the decoration if just applied to the class. >> >> Fixes: 0484d9d4fbe9beacd >> Signed-off-by: Alex Bennée >> [PMD: Move decorations to each test fun

Re: [PATCH 3/3] usb/hcd-xhci: Split pci wrapper for xhci base model

2020-03-03 Thread Gerd Hoffmann
> +typedef struct XHCIPciState { > +/*< private >*/ > +PCIDevice parent_obj; > +/*< public >*/ > +XHCIState *xhci; Better embed the struct instead of storing a pointer. > struct XHCIState { > -/*< private >*/ > -PCIDevice parent_obj; > -/*< public >*/ > - > +Devic

Re: [PATCH v7 17/17] spapr: Fold spapr_node0_size() into its only caller

2020-03-03 Thread Greg Kurz
On Tue, 3 Mar 2020 14:43:51 +1100 David Gibson wrote: > The Real Mode Area (RMA) needs to fit within the NUMA node owning memory > at address 0. That's usually node 0, but can be a later one if there are > some nodes which have no memory (only CPUs). > > This is currently handled by the spapr_

Re: qemu-system-x86_64: warning: Unknown X11 keycode mapping ''.

2020-03-03 Thread Daniel P . Berrangé
On Mon, Mar 02, 2020 at 01:43:12PM +0100, Thorsten Glaser wrote: > On Mon, 2 Mar 2020, Daniel P. Berrangé wrote: > > > "x11vnc" suggests you had a regular X11 desktop session, and are > > exporting it via VNC ? > > No, x11vnc is a standalone VNC server. AFAICT, this is not the case. On both my F

Re: New Hardware model emulation

2020-03-03 Thread Stefan Hajnoczi
On Tue, Mar 3, 2020 at 7:45 AM Priyamvad Acharya wrote: Please use Reply-All when replying to mailing list emails so that qemu-devel@nongnu.org is included in the CC list. That way the discussion stays on the mailing list. > Hi, > I have written code to emulate a custom PCI device. > Now I want

Re: qemu-system-x86_64: warning: Unknown X11 keycode mapping ''.

2020-03-03 Thread Daniel P . Berrangé
On Mon, Mar 02, 2020 at 07:19:04PM +0100, Thorsten Glaser wrote: > On Mon, 2 Mar 2020, Daniel P. Berrangé wrote: > > > There's two translations happening > > > > * The scancode emitted by the kernel and/or hardware device, > >and then translated/mangled by X11 and reported as the > >hard

Re: [PATCH] target/i386/hax-posix: fix two 'format-truncation' compile warnings

2020-03-03 Thread Paolo Bonzini
On 24/02/20 07:51, pannengy...@huawei.com wrote: > diff --git a/target/i386/hax-posix.c b/target/i386/hax-posix.c > index a5426a6dac..197d5bc0f9 100644 > --- a/target/i386/hax-posix.c > +++ b/target/i386/hax-posix.c > @@ -121,7 +121,8 @@ static char *hax_vm_devfs_string(int vm_id) > return

[PATCH v3 0/2] net: tulip: add checks to avoid OOB access

2020-03-03 Thread P J P
From: Prasad J Pandit Hello, * This series adds checks to avoid potential OOB access and infinite loop issues while processing rx/tx data. * Tulip tx descriptors are capped at 128 to avoid infinite loop in tulip_xmit_list_update(), wrt Tulip kernel driver -> https://git.kernel.org/pub/sc

[PATCH v3 2/2] net: tulip: add .can_recieve routine

2020-03-03 Thread P J P
From: Prasad J Pandit Define .can_receive routine to do sanity checks before receiving packet data. Signed-off-by: Prasad J Pandit --- hw/net/tulip.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) Update v3: define .can_receive routine -> https://lists.gnu.org/archive

[PATCH v3 1/2] net: tulip: check frame size and r/w data length

2020-03-03 Thread P J P
From: Prasad J Pandit Tulip network driver while copying tx/rx buffers does not check frame size against r/w data length. This may lead to OOB buffer access. Add check to avoid it. Limit iterations over descriptors to avoid potential infinite loop issue in tulip_xmit_list_update. Reported-by: L

Re: [PATCH v6 01/18] hw/arm: add Allwinner H3 System-on-Chip

2020-03-03 Thread Alex Bennée
Niek Linnenbank writes: > The Allwinner H3 is a System on Chip containing four ARM Cortex A7 > processor cores. Features and specifications include DDR2/DDR3 memory, > SD/MMC storage cards, 10/100/1000Mbit Ethernet, USB 2.0, HDMI and > various I/O modules. This commit adds support for the Allwi

Re: [PATCH v3 0/2] net: tulip: add checks to avoid OOB access

2020-03-03 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200303104724.233375-1-ppan...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v3 0/2] net: tulip: add checks to avoid OOB access Message-id: 20200303104724.233375-1-ppan...@red

Re: [PATCH v3 0/2] net: tulip: add checks to avoid OOB access

2020-03-03 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200303104724.233375-1-ppan...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [PATCH v3 0/2] net: tulip: add checks to avoid OOB access

2020-03-03 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200303104724.233375-1-ppan...@redhat.com/ Hi, This series failed build test on FreeBSD host. Please find the details below. === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the git checkout with # HEAD pointing to a commit th

[PATCH] optionrom/pvh: scan entire RSDP Area

2020-03-03 Thread Joe Richey
From: Joe Richey Right now the PVH option rom scans for the RSDP from 0xE to 0xE1FFF. This is probobly a typo, it should scan from 0xE to 0xF. This is actually an issue on some QEMU versions/machines. For example, when I run QEMU the RSDP is placed at 0xf5ad0 which will not be picked

Re: [PATCH] console: make QMP screendump use coroutine

2020-03-03 Thread Marc-André Lureau
Hi On Tue, Mar 3, 2020 at 8:41 AM Markus Armbruster wrote: > > Kevin Wolf writes: > > > Am 02.03.2020 um 15:22 hat Markus Armbruster geschrieben: > >> Marc-André Lureau writes: > >> > >> > Hi > >> > > >> > On Fri, Feb 21, 2020 at 5:50 PM Markus Armbruster > >> > wrote: > >> >> > >> >> Kevin W

Re: [PATCH v3 0/2] net: tulip: add checks to avoid OOB access

2020-03-03 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200303104724.233375-1-ppan...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ==

Re: [PATCH v2] net: tulip: check frame size and r/w data length

2020-03-03 Thread P J P
+-- On Mon, 24 Feb 2020, Jason Wang wrote --+ | > +if (s->rx_frame_len + len >= sizeof(s->rx_frame)) { | > +return; | > +} | What's the goal of this checking? To avoid potential OOB access while in pci_dma_write(). | > pci_dma_write(&s->dev, desc->buf_addr2

Re: [PATCH] target/i386/hax-posix: fix two 'format-truncation' compile warnings

2020-03-03 Thread Pan Nengyuan
On 3/3/2020 6:47 PM, Paolo Bonzini wrote: > On 24/02/20 07:51, pannengy...@huawei.com wrote: >> diff --git a/target/i386/hax-posix.c b/target/i386/hax-posix.c >> index a5426a6dac..197d5bc0f9 100644 >> --- a/target/i386/hax-posix.c >> +++ b/target/i386/hax-posix.c >> @@ -121,7 +121,8 @@ static ch

[PATCH v3 2/4] qcow2: rework the cluster compression routine

2020-03-03 Thread Denis Plotnikov
The patch enables processing the image compression type defined for the image and chooses an appropriate method for image clusters (de)compression. Signed-off-by: Denis Plotnikov --- block/qcow2-threads.c | 77 +++ 1 file changed, 63 insertions(+), 14 dele

[PATCH v3 3/4] qcow2: add zstd cluster compression

2020-03-03 Thread Denis Plotnikov
zstd significantly reduces cluster compression time. It provides better compression performance maintaining the same level of the compression ratio in comparison with zlib, which, at the moment, is the only compression method available. The performance test results: Test compresses and decompresse

[PATCH v3 4/4] iotests: 287: add qcow2 compression type test

2020-03-03 Thread Denis Plotnikov
The test checks fulfilling qcow2 requiriements for the compression type feature and zstd compression type operability. Signed-off-by: Denis Plotnikov --- tests/qemu-iotests/287 | 127 + tests/qemu-iotests/287.out | 43 + tests/qemu-iotests/gro

[PATCH v3 0/4] qcow2: Implement zstd cluster compression method

2020-03-03 Thread Denis Plotnikov
v3: * remove redundant max compression type value check [Vladimir, Eric] (the switch below checks everything) * prevent compression type changing on "qemu-img amend" [Vladimir] * remove zstd config setting, since it has been added already by "migration" patches [Vladimir] * ch

Re: [PATCH v6 02/18] hw/arm: add Xunlong Orange Pi PC machine

2020-03-03 Thread Alex Bennée
Niek Linnenbank writes: > The Xunlong Orange Pi PC is an Allwinner H3 System on Chip > based embedded computer with mainline support in both U-Boot > and Linux. The board comes with a Quad Core Cortex A7 @ 1.3GHz, > 1GiB RAM, 100Mbit ethernet, USB, SD/MMC, USB, HDMI and > various other I/O. Thi

[PATCH v3 1/4] qcow2: introduce compression type feature

2020-03-03 Thread Denis Plotnikov
The patch adds some preparation parts for incompatible compression type feature to qcow2 allowing the use different compression methods for image clusters (de)compressing. It is implied that the compression type is set on the image creation and can be changed only later by image conversion, thus c

Re: [PATCH v6 03/18] hw/arm/allwinner-h3: add Clock Control Unit

2020-03-03 Thread Alex Bennée
Niek Linnenbank writes: > The Clock Control Unit is responsible for clock signal generation, > configuration and distribution in the Allwinner H3 System on Chip. > This commit adds support for the Clock Control Unit which emulates > a simple read/write register interface. > > Signed-off-by: Nie

Re: [PATCH v6 04/18] hw/arm/allwinner-h3: add USB host controller

2020-03-03 Thread Alex Bennée
Niek Linnenbank writes: > The Allwinner H3 System on Chip contains multiple USB 2.0 bus > connections which provide software access using the Enhanced > Host Controller Interface (EHCI) and Open Host Controller > Interface (OHCI) interfaces. This commit adds support for > both interfaces in the

Re: [PATCH v5 3/4] qmp: Move dispatcher to a coroutine

2020-03-03 Thread Kevin Wolf
Am 03.03.2020 um 09:49 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > This moves the QMP dispatcher to a coroutine and runs all QMP command > > handlers that declare 'coroutine': true in coroutine context so they > > can avoid blocking the main loop while doing I/O or waiting for o

Re: [Virtio-fs] [PATCH v4 0/2] virtiofsd: Fix xattr operations

2020-03-03 Thread Dr. David Alan Gilbert
* Misono Tomohiro (misono.tomoh...@jp.fujitsu.com) wrote: > Currently xattr operations on virtiofs does not work properly in some case: > - directory ... cannot set > - special files (pipe) ... cause hang > > This fixes these problems and now xfstests generic/062 passes on virtiofs > with -o xat

Re: [PATCH v3] hw/smbios: add options for type 4 max-speed and current-speed

2020-03-03 Thread Heyi Guo
On 2020/3/3 16:33, Igor Mammedov wrote: On Tue, 3 Mar 2020 11:18:56 +0800 Heyi Guo wrote: One comment from myself after going through the code... On 2020/3/3 9:01, Heyi Guo wrote: Common VM users sometimes care about CPU speed, so we add two new options to allow VM vendors to present CPU s

Re: [PATCH v5 1/4] qapi: Add a 'coroutine' flag for commands

2020-03-03 Thread Kevin Wolf
Am 03.03.2020 um 09:10 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > This patch adds a new 'coroutine' flag to QMP command definitions that > > tells the QMP dispatcher that the command handler is safe to be run in a > > coroutine. > > > > The documentation of the new flag pretend

Re: [PATCH v6 05/18] hw/arm/allwinner-h3: add System Control module

2020-03-03 Thread Alex Bennée
Niek Linnenbank writes: > The Allwinner H3 System on Chip has an System Control > module that provides system wide generic controls and > device information. This commit adds support for the > Allwinner H3 System Control module. > > Signed-off-by: Niek Linnenbank > Reviewed-by: Philippe Mathie

Re: [PULL] RISC-V Patches for the 5.0 Soft Freeze, Part 3

2020-03-03 Thread Peter Maydell
On Tue, 3 Mar 2020 at 00:48, Palmer Dabbelt wrote: > > The following changes since commit 8b6b68e05b43f976714ca1d2afe01a64e1d82cba: > > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging > (2020-02-27 19:15:15 +) > > are available in the Git repository at: > > g...@

Re: [PATCH v6 06/18] hw/arm/allwinner: add CPU Configuration module

2020-03-03 Thread Alex Bennée
Niek Linnenbank writes: > Various Allwinner System on Chip designs contain multiple processors > that can be configured and reset using the generic CPU Configuration > module interface. This commit adds support for the Allwinner CPU > configuration interface which emulates the following feature

[PATCH v2] icount: make dma reads deterministic

2020-03-03 Thread Pavel Dovgalyuk
Windows guest sometimes makes DMA requests with overlapping target addresses. This leads to the following structure of iov for the block driver: addr size1 addr size2 addr size3 It means that three adjacent disk blocks should be read into the same memory buffer. Windows does not expects anything

Re: [PATCH] icount: make dma reads deterministic

2020-03-03 Thread dovgaluk
Kevin Wolf писал 2020-03-02 19:19: Am 02.03.2020 um 13:59 hat Pavel Dovgalyuk geschrieben: Windows guest sometimes makes DMA requests with overlapping target addresses. This leads to the following structure of iov for the block driver: addr size1 addr size2 addr size3 It means that three adjac

Re: [PATCH v6 08/18] hw/arm/allwinner: add SD/MMC host controller

2020-03-03 Thread Alex Bennée
Niek Linnenbank writes: > The Allwinner System on Chip families sun4i and above contain > an integrated storage controller for Secure Digital (SD) and > Multi Media Card (MMC) interfaces. This commit adds support > for the Allwinner SD/MMC storage controller with the following > emulated featur

Re: [PATCH v5 07/18] s390x: protvirt: Inhibit balloon when switching to protected mode

2020-03-03 Thread Christian Borntraeger
On 26.02.20 19:24, Cornelia Huck wrote: > On Wed, 26 Feb 2020 16:30:32 +0100 > Janosch Frank wrote: > >> On 2/26/20 4:16 PM, David Hildenbrand wrote: >>> On 26.02.20 16:06, Christian Borntraeger wrote: On 26.02.20 15:59, David Hildenbrand wrote: > On 26.02.20 13:20, Jano

  1   2   3   >