Re: [PATCH v1 4/4] hw/arm/cubieboard: report error when using unsupported -bios argument

On 3/2/20 4:44 PM, Peter Maydell wrote: On Thu, 27 Feb 2020 at 22:02, Niek Linnenbank wrote: The Cubieboard machine does not support the -bios argument. Report an error when -bios is used and exit immediately. Signed-off-by: Niek Linnenbank --- hw/arm/cubieboard.c | 7 +++ 1 file chan

Re: [PATCH v1 0/4] hw/arm/cubieboard: correct CPU type and add machine argument checks

On 2/27/20 11:01 PM, Niek Linnenbank wrote: These patches change the Cubieboard machine definition to use the correct CPU type, which is ARM Cortex-A8 instead of ARM Cortex-A9. Additionally, add some sanity checks for the machine input arguments in the initialization function. Niek Linnenbank (

Re: [PATCH v2 2/4] Add the NetBSD Virtual Machine Monitor accelerator.

On 02.03.2020 18:12, Paolo Bonzini wrote: > On 03/02/20 12:56, Kamil Rytarowski wrote: >> On 03.02.2020 12:41, Philippe Mathieu-Daudé wrote: @@ -1768,6 +1785,7 @@ disabled with --disable-FEATURE, default is enabled if available:     hax HAX acceleration support     h

[PATCH] tests/acceptance: move @skipUnless decoration to test itself

It appears ignore the decoration if just applied to the class. Signed-off-by: Alex Bennée --- tests/acceptance/machine_mips_malta.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/acceptance/machine_mips_malta.py b/tests/acceptance/machine_mips_malta.py index 92b4

Re: [PATCH v2 2/4] Add the NetBSD Virtual Machine Monitor accelerator.

On 02.03.2020 18:11, Paolo Bonzini wrote: > On 03/02/20 12:41, Philippe Mathieu-Daudé wrote: >> >> Maybe you can add something like: >> >> if test "$targetos" = "NetBSD"; then >>     nvmm="check" >> fi > > You could do just nvmm="" and, below, > > if test "$nvmm" != "no" && test "$targetos" = "NetB

Re: [PATCH v4 3/4] Introduce the NVMM impl

On 06/02/20 22:32, Kamil Rytarowski wrote: > +get_qemu_vcpu(CPUState *cpu) > +{ > +return (struct qemu_vcpu *)cpu->hax_vcpu; > +} Please make hax_vcpu a void * and rename it to "accel_data". > +nseg->attrib.g = __SHIFTOUT(attrib, DESC_G_MASK); > +__SHIFTIN((uint32_t)nseg->attrib.

Re: [PATCH] tests/acceptance: move @skipUnless decoration to test itself

On 3/2/20 7:09 PM, Alex Bennée wrote: It appears ignore the decoration if just applied to the class. Odd I remember testing this, this might be a feature supported by a newer Avocado version than the one available on Travis-CI. Signed-off-by: Alex Bennée --- tests/acceptance/machine_mip

Re: [PATCH] linux-user: Add AT_EXECFN and AT_EXECFD auxval

On Mon, Mar 2, 2020 at 6:39 AM Laurent Vivier wrote: > > Le 21/02/2020 à 21:28, Lirong Yuan a écrit : > > This change adds the support for AT_EXECFN and AT_EXECFD auxval. > > Why do we need AT_EXECFD? > > AT_EXECFD is normally only used with binfmt_misc so I don't see any use > cases for it with Q

Re: qemu-system-x86_64: warning: Unknown X11 keycode mapping ''.

On Mon, 2 Mar 2020, Daniel P. Berrangé wrote: > There's two translations happening > > * The scancode emitted by the kernel and/or hardware device, >and then translated/mangled by X11 and reported as the >hardware keycode > > * The keysym which is the mapping from the hardware keycode

[PATCH v1 01/10] tests/vm: use $(PYTHON) consistently

From: Robert Foley Change Makefile.include to use $(PYTHON) so for vm-boot-ssh to be consistent with other cases like vm-build. Signed-off-by: Robert Foley Reviewed-by: Alex Bennée Reviewed-by: Peter Puhov Signed-off-by: Alex Bennée Message-Id: <20200219163537.22098-2-robert.fo...@linaro.org

[PATCH v1 06/10] travis: enable tools build on OS X

From: Laurent Vivier As we can build tools on OS X we should check we don't break build when we submit new codes. Signed-off-by: Laurent Vivier Signed-off-by: Alex Bennée Message-Id: <20200302154630.45620-3-lviv...@redhat.com> --- .travis.yml | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v1 08/10] configure: detect and report genisoimage

This is used for some of the vm-build tests so lets detect it and behave sanely when it is not installed. Signed-off-by: Alex Bennée --- configure | 13 + tests/vm/Makefile.include | 14 +++--- 2 files changed, 24 insertions(+), 3 deletions(-) diff --git a/co

[PATCH v1 00/10] testing/next updates (tweaks and re-greening)

Hi, I was reviewing Roberts vm-build.aarch64 patches when I ran into some problems with testing. Then I noticed the CI had turned red again so I went to fix those problems and here we are. The following patches are mine and need review: - travis.yml: install python3 numpy and opencv libraries

[PATCH v1 03/10] tests/vm: increased max timeout for vm boot.

From: Robert Foley Add change to increase timeout waiting for VM to boot. Needed for some emulation cases where it can take longer than 5 minutes to boot. Signed-off-by: Robert Foley Reviewed-by: Alex Bennée Reviewed-by: Peter Puhov Signed-off-by: Alex Bennée Message-Id: <20200219163537.2209

[PATCH v1 02/10] tests/vm: Debug mode shows ssh output.

From: Robert Foley Add changes to tests/vm/basevm.py so that during debug mode we show ssh output. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov Reviewed-by: Alex Bennée Signed-off-by: Alex Bennée Message-Id: <20200219163537.22098-3-robert.fo...@linaro.org> --- tests/vm/basevm.py | 7

[PATCH v1 07/10] configure: fix check for libzstd

Fixes: 3a67848134d0 Signed-off-by: Alex Bennée --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 7b373bc0bb8..caa65f58831 100755 --- a/configure +++ b/configure @@ -2464,7 +2464,7 @@ fi # zstd check if test "$zstd" != "no" ; then -

Re: CPU reset vs DeviceState reset

On 3/2/20 6:45 PM, Eduardo Habkost wrote: My impression is that this is just historical legacy, but I'm not sure how much work a conversion to the new system would require. I see lots of cpu_reset() calls scattered around the code. To make it worse, TYPE_CPU do have a DeviceClass::reset method i

[PATCH v1 05/10] tests/vm: Added gen_cloud_init_iso() to basevm.py

From: Robert Foley This method was located in both centos and ubuntu.i386. Signed-off-by: Robert Foley Reviewed-by: Alex Bennée Reviewed-by: Peter Puhov Signed-off-by: Alex Bennée Message-Id: <20200219163537.22098-6-robert.fo...@linaro.org> --- tests/vm/basevm.py | 40

[PATCH v1 10/10] travis.yml: install python3 numpy and opencv libraries

These are used for the acceptance framebuffer tests to count Tux. Signed-off-by: Alex Bennée --- .travis.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.travis.yml b/.travis.yml index 70a24bf2fc8..9db6c1557f1 100644 --- a/.travis.yml +++ b/.travis.yml @@ -323,6 +323,8 @@ jobs:

[PATCH v1 09/10] tests/acceptance: move @skipUnless decoration to test itself

It appears ignore the decoration if just applied to the class. Signed-off-by: Alex Bennée --- tests/acceptance/machine_mips_malta.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/acceptance/machine_mips_malta.py b/tests/acceptance/machine_mips_malta.py index 92b4

[PATCH v1 04/10] tests/vm: give wait_ssh() option to wait for root

From: Robert Foley Allow wait_ssh to wait for root user to be ready. This solves the issue where we perform a wait_ssh() successfully, but the root user is not yet ready to be logged in. Signed-off-by: Robert Foley Reviewed-by: Alex Bennée Reviewed-by: Peter Puhov Signed-off-by: Alex Bennée

Re: [PATCH v1 08/10] configure: detect and report genisoimage

Cc'ing Wainer On 3/2/20 7:19 PM, Alex Bennée wrote: This is used for some of the vm-build tests so lets detect it and behave sanely when it is not installed. Signed-off-by: Alex Bennée --- configure | 13 + tests/vm/Makefile.include | 14 +++--- 2 files

Re: [PATCH v1 01/10] tests/vm: use $(PYTHON) consistently

On 3/2/20 7:18 PM, Alex Bennée wrote: From: Robert Foley Change Makefile.include to use $(PYTHON) so for vm-boot-ssh to be consistent with other cases like vm-build. So what you are trying to fix here is when you have two python3 installed (one from the distribution and one manually built),

Re: [PATCH v1 02/10] tests/vm: Debug mode shows ssh output.

On 3/2/20 7:18 PM, Alex Bennée wrote: From: Robert Foley Add changes to tests/vm/basevm.py so that during debug mode we show ssh output. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov Reviewed-by: Alex Bennée Signed-off-by: Alex Bennée Message-Id: <20200219163537.22098-3-robert.fo...

Re: [PATCH] linux-user: Add AT_EXECFN and AT_EXECFD auxval

Le 02/03/2020 à 19:18, Lirong Yuan a écrit : > On Mon, Mar 2, 2020 at 6:39 AM Laurent Vivier wrote: >> >> Le 21/02/2020 à 21:28, Lirong Yuan a écrit : >>> This change adds the support for AT_EXECFN and AT_EXECFD auxval. >> >> Why do we need AT_EXECFD? >> >> AT_EXECFD is normally only used with bin

Re: [PATCH v1 03/10] tests/vm: increased max timeout for vm boot.

On 3/2/20 7:19 PM, Alex Bennée wrote: From: Robert Foley Add change to increase timeout waiting for VM to boot. Needed for some emulation cases where it can take longer than 5 minutes to boot. Signed-off-by: Robert Foley Reviewed-by: Alex Bennée Reviewed-by: Peter Puhov Signed-off-by: Alex

Re: [PATCH v1 05/10] tests/vm: Added gen_cloud_init_iso() to basevm.py

On 3/2/20 7:19 PM, Alex Bennée wrote: From: Robert Foley This method was located in both centos and ubuntu.i386. Signed-off-by: Robert Foley Reviewed-by: Alex Bennée Reviewed-by: Peter Puhov Signed-off-by: Alex Bennée Message-Id: <20200219163537.22098-6-robert.fo...@linaro.org> --- tests

Re: [PATCH] linux-user: Add an argument QEMU_MMAP_BASE to set custom mmap base address in qemu user mode

Le 02/03/2020 à 18:53, Lirong Yuan a écrit : > On Mon, Mar 2, 2020 at 6:56 AM Laurent Vivier wrote: >> >> Le 29/02/2020 à 01:43, Lirong Yuan a écrit : >>> On Fri, Feb 21, 2020 at 5:09 PM Lirong Yuan wrote: This change allows us to set custom base address for guest programs. It is

Re: [PATCH v1 01/10] tests/vm: use $(PYTHON) consistently

Philippe Mathieu-Daudé writes: > On 3/2/20 7:18 PM, Alex Bennée wrote: >> From: Robert Foley >> Change Makefile.include to use $(PYTHON) so for vm-boot-ssh to be >> consistent with other cases like vm-build. > > So what you are trying to fix here is when you have two python3 > installed (one f

Re: CPU reset vs DeviceState reset

On Mon, 2 Mar 2020 at 17:45, Eduardo Habkost wrote: > > My impression is that this is just historical legacy, but I'm not > sure how much work a conversion to the new system would require. > I see lots of cpu_reset() calls scattered around the code. I think we can just make the cpu_reset() functi

Re: CPU reset vs DeviceState reset

On Mon, 2 Mar 2020 at 18:19, Philippe Mathieu-Daudé wrote: > Without verifying the code base/commits, my understanding is that was > required to use cpu object with linux-user before Markus added support > for anonymous object container for QOM objects on linux-user. So now we > could make CPUClas

Re: [PATCH v1 06/10] travis: enable tools build on OS X

On 3/2/20 7:19 PM, Alex Bennée wrote: From: Laurent Vivier As we can build tools on OS X we should check we don't break build when we submit new codes. Signed-off-by: Laurent Vivier Signed-off-by: Alex Bennée Message-Id: <20200302154630.45620-3-lviv...@redhat.com> --- .travis.yml | 1 + 1

Re: [PATCH v1 01/10] tests/vm: use $(PYTHON) consistently

On 3/2/20 7:41 PM, Alex Bennée wrote: Philippe Mathieu-Daudé writes: On 3/2/20 7:18 PM, Alex Bennée wrote: From: Robert Foley Change Makefile.include to use $(PYTHON) so for vm-boot-ssh to be consistent with other cases like vm-build. So what you are trying to fix here is when you have tw

Re: [PATCH 2/2] via-ide: Also emulate non 100% native mode

On 01/03/2020 21:30, BALATON Zoltan wrote: > On Sun, 1 Mar 2020, Mark Cave-Ayland wrote: >> On 01/03/2020 18:53, BALATON Zoltan wrote: >>> On Sun, 1 Mar 2020, BALATON Zoltan wrote: is not legacy mode but "not 100% native mode". The prog-if is set to 0x8a which corresponds to native

[PATCH 0/5] mostly changes related to audio float samples

Patch "audio: change naming scheme of FLOAT_CONV macros" and patch "audio: consistency changes" should have been a review for ed2a4a7941 "audio: proper support for float samples in mixeng", but I was too slow. Patch "audio: change mixing engine float range to [-1.f, 1.f]" definitely needs to be te

[PATCH 2/5] audio: change naming scheme of FLOAT_CONV macros

This patch changes the naming scheme of the FLOAT_CONV_TO and FLOAT_CONV_FROM macros to the scheme used in mixeng_template.h. Signed-off-by: Volker Rümelin --- audio/mixeng.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/audio/mixeng.c b/audio/mixen

[PATCH 1/5] qapi/audio: add documentation for AudioFormat

The review for patch ed2a4a7941 "audio: proper support for float samples in mixeng" suggested this would be a good idea. Signed-off-by: Volker Rümelin --- qapi/audio.json | 14 ++ 1 file changed, 14 insertions(+) diff --git a/qapi/audio.json b/qapi/audio.json index d8c507cced..07e7b

[PATCH 4/5] audio: change mixing engine float range to [-1.f, 1.f]

Currently the internal float range of the mixing engine is [-.5f, .5f]. PulseAudio, SDL2 and libasound use a [-1.f, 1.f] range. This means with float samples the audio playback volume is 6dB too low and audio recording signals will be clipped in most cases. To avoid another scaling factor in the c

[PATCH 5/5] audio: fix saturation nonlinearity in clip_* functions

The current positive limit for the saturation nonlinearity is only correct if the type of the result has 8 bits or less. Signed-off-by: Volker Rümelin --- audio/mixeng_template.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/audio/mixeng_template.h b/audio/mixeng_templ

[PATCH 3/5] audio: consistency changes

Change the clip_natural_float_from_mono() function in audio/mixeng.c to be consistent with the clip_*_from_mono() functions in audio/mixeng_template.h. Signed-off-by: Volker Rümelin --- audio/mixeng.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/audio/mixeng.c b/audio/mixe

Re: [PATCH 1/2] ide: Make room for flags in PCIIDEState and add one for legacy IRQ routing

On 02/03/2020 08:10, Markus Armbruster wrote: > BALATON Zoltan writes: > >> On Sun, 1 Mar 2020, Mark Cave-Ayland wrote: >>> On 29/02/2020 23:02, BALATON Zoltan wrote: We'll need a flag for implementing some device specific behaviour in via-ide but we already have a currently CMD646 spe

[PATCH] hw/artist: Reduce default artist screen size to 800x600 pixel

Reduce the default emulated screen size to 800x600 pixel instead of 1280x1024 pixel. With the bigger screen size the emulated graphic card isn't fully visible on my laptop display, and if people want bigger sizes it's possible to define it on the command line. Signed-off-by: Helge Deller diff --

Re: [PATCH v3 5/6] hw/misc/mos6522: move timer_new from init() into realize() to avoid memleaks

On 02/03/2020 13:21, Peter Maydell wrote: > On Thu, 27 Feb 2020 at 02:35, Pan Nengyuan wrote: >> >> There are some memleaks when we call 'device_list_properties'. This patch >> move timer_new from init into realize to fix it. >> Meanwhile, add calls to mos6522_realize() in mac_via_realize to mak

Re: [PATCH v2 2/4] Add the NetBSD Virtual Machine Monitor accelerator.

Le 02/03/2020 à 19:05, Kamil Rytarowski a écrit : > On 02.03.2020 18:12, Paolo Bonzini wrote: >> On 03/02/20 12:56, Kamil Rytarowski wrote: >>> On 03.02.2020 12:41, Philippe Mathieu-Daudé wrote: > @@ -1768,6 +1785,7 @@ disabled with --disable-FEATURE, default is > enabled if available:

Re: [PULL v3 02/11] hppa: Add support for LASI chip with i82596 NIC

On 17.02.20 18:56, Peter Maydell wrote: > On Fri, 24 Jan 2020 at 23:20, Richard Henderson > wrote: >> >> From: Helge Deller >> >> LASI is a built-in multi-I/O chip which supports serial, parallel, >> network (Intel i82596 Apricot), sound and other functionalities. >> LASI has been used in many HP

Re: [PATCH v4 3/4] Introduce the NVMM impl

Le 02/03/2020 à 19:13, Paolo Bonzini a écrit : > On 06/02/20 22:32, Kamil Rytarowski wrote: >> +get_qemu_vcpu(CPUState *cpu) >> +{ >> +return (struct qemu_vcpu *)cpu->hax_vcpu; >> +} > > Please make hax_vcpu a void * and rename it to "accel_data". NVMM reproduces the existing logic in the oth

Re: [PATCH v5 47/50] multi-process: Enable support for multiple devices in remote

On 2/28/2020 11:44 AM, Stefan Hajnoczi wrote: On Mon, Feb 24, 2020 at 03:55:38PM -0500, Jagannathan Raman wrote: From: Elena Ufimtseva Add support to allow multiple devices to be configured in the remote process This patch allows multiple devices to be addressed over a single UNIX domain

Re: [PULL v3 02/11] hppa: Add support for LASI chip with i82596 NIC

On Mon, 2 Mar 2020 at 19:23, Helge Deller wrote: > > On 17.02.20 18:56, Peter Maydell wrote: > > On Fri, 24 Jan 2020 at 23:20, Richard Henderson > > wrote: > >> > >> From: Helge Deller > >> > >> LASI is a built-in multi-I/O chip which supports serial, parallel, > >> network (Intel i82596 Apricot

[PATCH v2] linux-user: Add AT_EXECFN auxval

This change adds the support for AT_EXECFN auxval. Signed-off-by: Lirong Yuan --- Changelog since v1: - remove implementation for AT_EXECFD auxval. linux-user/elfload.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/linux-user/elfload.c b/linux-user/elfload.c index db748c

Re: [PATCH v4 3/4] Introduce the NVMM impl

Il lun 2 mar 2020, 20:28 Maxime Villard ha scritto: > > >> +nvmm_vcpu_pre_run(cpu); > >> + > >> +if (atomic_read(&cpu->exit_request)) { > >> +qemu_cpu_kick_self(); > >> +} > >> + > > > > This is racy without something like KVM's immediate_exit mechanism. > > Th

Re: [PATCH v2 2/4] Add the NetBSD Virtual Machine Monitor accelerator.

Il lun 2 mar 2020, 20:14 Maxime Villard ha scritto: > Le 02/03/2020 à 19:05, Kamil Rytarowski a écrit : > > On 02.03.2020 18:12, Paolo Bonzini wrote: > >> On 03/02/20 12:56, Kamil Rytarowski wrote: > >>> On 03.02.2020 12:41, Philippe Mathieu-Daudé wrote: > > @@ -1768,6 +1785,7 @@ disabled wit

Re: [PATCH] linux-user: Add an argument QEMU_MMAP_BASE to set custom mmap base address in qemu user mode

On Mon, Mar 2, 2020 at 10:39 AM Laurent Vivier wrote: > > Le 02/03/2020 à 18:53, Lirong Yuan a écrit : > > On Mon, Mar 2, 2020 at 6:56 AM Laurent Vivier wrote: > >> > >> Le 29/02/2020 à 01:43, Lirong Yuan a écrit : > >>> On Fri, Feb 21, 2020 at 5:09 PM Lirong Yuan wrote: > > This chang

Re: [PATCH] linux-user: Add AT_EXECFN and AT_EXECFD auxval

On Mon, Mar 2, 2020 at 10:31 AM Laurent Vivier wrote: > > Le 02/03/2020 à 19:18, Lirong Yuan a écrit : > > On Mon, Mar 2, 2020 at 6:39 AM Laurent Vivier wrote: > >> > >> Le 21/02/2020 à 21:28, Lirong Yuan a écrit : > >>> This change adds the support for AT_EXECFN and AT_EXECFD auxval. > >> > >> W

RE: [EXTERNAL] Re: PATCH] WHPX: TSC get and set should be dependent on VM state

> >> Looks good. Do you want me to queue this until you can have your GPG > >> key signed? (And also, I can help you sign it of course). > >> > > > > Yes, please. Thanks. > > > > I haven't used GPG keys before. What would I be using it for? > > You'd be using it to include a signed tags in a pul

RE: [PATCH] WHPX: Use proper synchronization primitives while processing

> -Original Message- > From: Sunil Muthuswamy > Sent: Monday, February 24, 2020 11:28 AM > To: Paolo Bonzini ; Richard Henderson > ; Eduardo Habkost > Cc: qemu-devel@nongnu.org; Stefan Weil ; Justin Terry (SF) > > Subject: [PATCH] WHPX: Use proper synchronization primitives while proces

[PATCH v4] i386: Fix GCC warning with snprintf when HAX is enabled

When HAX is enabled (--enable-hax), GCC 9.2.1 reports issues with snprintf(). Replacing old snprintf() by g_strdup_printf() fixes the problem with boundary checks of vm_id and vcpu_id and finally the warnings produced by GCC. For more details, one example of warning: CC i386-softmmu/target/

Re: [PATCH v4] i386: Fix GCC warning with snprintf when HAX is enabled

Em seg., 2 de mar. de 2020 às 17:13, Julio Faracco escreveu: > > When HAX is enabled (--enable-hax), GCC 9.2.1 reports issues with > snprintf(). Replacing old snprintf() by g_strdup_printf() fixes the > problem with boundary checks of vm_id and vcpu_id and finally the > warnings produced by GCC. >

Re: [PULL 5/5] tests/acceptance: Count multiple Tux logos displayed on framebuffer

On Thu, 27 Feb 2020 at 13:28, Aleksandar Markovic wrote: > > From: Philippe Mathieu-Daudé > > Add a test that verifies that each core properly displays the Tux > logo on the framebuffer device. > > We simply follow the OpenCV "Template Matching with Multiple Objects" > tutorial, replacing Lionel

Re: [PULL v3 02/11] hppa: Add support for LASI chip with i82596 NIC

* Peter Maydell : > On Mon, 2 Mar 2020 at 19:23, Helge Deller wrote: > > > > On 17.02.20 18:56, Peter Maydell wrote: > > > On Fri, 24 Jan 2020 at 23:20, Richard Henderson > > > wrote: > > >> > > >> From: Helge Deller > > >> > > >> LASI is a built-in multi-I/O chip which supports serial, parallel

Re: [PATCH 1/5] block/nbd-client: drop max_block restriction from block_status

On 3/2/20 4:05 AM, Vladimir Sementsov-Ogievskiy wrote: NBD spec is updated, so that max_block doesn't relate to NBD_CMD_BLOCK_STATUS. So, drop the restriction. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/nbd.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/b

Re: [PATCH 2/5] block/nbd-client: drop max_block restriction from discard

On 3/2/20 4:05 AM, Vladimir Sementsov-Ogievskiy wrote: NBD spec is updated, so that max_block doesn't relate to NBD_CMD_TRIM. So, drop the restriction. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/nbd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/block/nbd.c b/block/nbd.c ind

Re: [EXTERNAL]Re: [PULL 5/5] tests/acceptance: Count multiple Tux logos displayed on framebuffer

> From: Peter Maydell > Sent: Monday, March 2, 2020 9:26 PM > To: Aleksandar Markovic > Cc: QEMU Developers; Aleksandar Markovic; Philippe Mathieu-Daudé > Subject: [EXTERNAL]Re: [PULL 5/5] tests/acceptance: Count multiple Tux logos > displayed on framebuffer > > On Thu, 27 Feb 2020 at 13:28, Ale

Re: [PATCH v3 1/4] scripts/simplebench: add simplebench.py

> >> + > >> + > >> +def ascii_one(result): > >> +"""Return ASCII representation of bench_one() returned dict.""" > >> +if 'average' in result: > >> +s = '{:.2f} +- {:.2f}'.format(result['average'], result['delta']) > >> +if 'n-failed' in result: > >> +s += '\n({}

Re: [PATCH v2 2/4] Add the NetBSD Virtual Machine Monitor accelerator.

On 02.03.2020 20:40, Paolo Bonzini wrote: > > > Il lun 2 mar 2020, 20:14 Maxime Villard > ha scritto: > > Le 02/03/2020 à 19:05, Kamil Rytarowski a écrit : > > On 02.03.2020 18:12, Paolo Bonzini wrote: > >> On 03/02/20 12:56, Kamil Rytarowski wrote: > >>> O

Re: [EXTERNAL]Re: [PULL 5/5] tests/acceptance: Count multiple Tux logos displayed on framebuffer

From: Aleksandar Markovic Sent: Monday, March 2, 2020 9:58 PM To: Peter Maydell; Aleksandar Markovic Cc: QEMU Developers; Philippe Mathieu-Daudé Subject: Re: [EXTERNAL]Re: [PULL 5/5] tests/acceptance: Count multiple Tux logos displayed on framebuffer >

Re: [EXTERNAL][PATCH] mips/mips_malta: Allow more than 2G RAM

Forwarding this to Igor. Can you please give us your opinion, Igor, on this proposal? From: Jiaxun Yang Sent: Friday, February 28, 2020 4:26 AM To: qemu-devel@nongnu.org Cc: phi...@redhat.com; Aleksandar Markovic; Jiaxun Yang; Yunqiang Su Subject: [EXTERN

Re: [PATCH v2 00/14] tests/vm: Add support for aarch64 VMs

On Mon, 2 Mar 2020 at 11:38, Alex Bennée wrote: > > > Robert Foley writes: > > > This is version 2 of the patch series to > > add support for aarch64 VMs. > > - Ubuntu 18.04 aarch64 VM > > - CentOS 8 aarch64 VM > > For now I've pulled the first 5 patches into testing/next as they are > obvious

Re: [PATCH 2/2] via-ide: Also emulate non 100% native mode

On Mon, 2 Mar 2020, Mark Cave-Ayland wrote: On 01/03/2020 21:30, BALATON Zoltan wrote: On Sun, 1 Mar 2020, Mark Cave-Ayland wrote: On 01/03/2020 18:53, BALATON Zoltan wrote: On Sun, 1 Mar 2020, BALATON Zoltan wrote: is not legacy mode but "not 100% native mode". The prog-if is set to 0x8a whi

Re: CPU reset vs DeviceState reset

On Mon, Mar 02, 2020 at 06:41:31PM +, Peter Maydell wrote: > On Mon, 2 Mar 2020 at 17:45, Eduardo Habkost wrote: > > > > My impression is that this is just historical legacy, but I'm not > > sure how much work a conversion to the new system would require. > > I see lots of cpu_reset() calls sc

Re: CPU reset vs DeviceState reset

On Mon, Mar 02, 2020 at 06:42:18PM +, Peter Maydell wrote: > On Mon, 2 Mar 2020 at 18:19, Philippe Mathieu-Daudé wrote: > > Without verifying the code base/commits, my understanding is that was > > required to use cpu object with linux-user before Markus added support > > for anonymous object

Re: CPU reset vs DeviceState reset

On Mon, 2 Mar 2020 at 21:40, Eduardo Habkost wrote: > > On Mon, Mar 02, 2020 at 06:41:31PM +, Peter Maydell wrote: > > On Mon, 2 Mar 2020 at 17:45, Eduardo Habkost wrote: > > > > > > My impression is that this is just historical legacy, but I'm not > > > sure how much work a conversion to the

Re: [PATCH v1 07/10] configure: fix check for libzstd

Alex Bennée writes: > Fixes: 3a67848134d0 > Signed-off-by: Alex Bennée > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure b/configure > index 7b373bc0bb8..caa65f58831 100755 > --- a/configure > +++ b/configure > @@ -2464,7 +2464,7 @@ fi > # z

Re: CPU reset vs DeviceState reset

On Mon, Mar 02, 2020 at 09:55:42PM +, Peter Maydell wrote: > On Mon, 2 Mar 2020 at 21:40, Eduardo Habkost wrote: > > > > On Mon, Mar 02, 2020 at 06:41:31PM +, Peter Maydell wrote: > > > On Mon, 2 Mar 2020 at 17:45, Eduardo Habkost wrote: > > > > > > > > My impression is that this is just

Re: [PATCH v1 0/4] hw/arm/cubieboard: correct CPU type and add machine argument checks

Hi Peter, Philippe, On Mon, Mar 2, 2020 at 5:06 PM Peter Maydell wrote: > On Thu, 27 Feb 2020 at 22:01, Niek Linnenbank > wrote: > > > > These patches change the Cubieboard machine definition to use the > > correct CPU type, which is ARM Cortex-A8 instead of ARM Cortex-A9. > > > > Additionally,

Re: [PATCH v1 4/4] hw/arm/cubieboard: report error when using unsupported -bios argument

Hi Philippe, On Mon, Mar 2, 2020 at 7:04 PM Philippe Mathieu-Daudé wrote: > On 3/2/20 4:44 PM, Peter Maydell wrote: > > On Thu, 27 Feb 2020 at 22:02, Niek Linnenbank > wrote: > >> > >> The Cubieboard machine does not support the -bios argument. > >> Report an error when -bios is used and exit i

Re: [PATCH v5 14/50] mutli-process: build remote command line args

On Mon, Mar 02, 2020 at 05:47:45PM +, Daniel P. Berrangé wrote: > On Mon, Mar 02, 2020 at 06:36:13PM +0100, Philippe Mathieu-Daudé wrote: > > typo "multi" in patch subject. > > Thank Philippe, will fix. > > On 2/24/20 9:55 PM, Jagannathan Raman wrote: > > > From: Elena Ufimtseva > > > > > >

Re: [PATCH v2 2/4] Add the NetBSD Virtual Machine Monitor accelerator.

Il lun 2 mar 2020, 22:11 Kamil Rytarowski ha scritto: > > The difference is that KVM for example does not need external includes > > or libraries. > We don't support this scenario What scenario? and after a year there might be no > supported release without NVMM. > > The only concern is about

Re: [RFC PATCH v2] target/ppc: Enable hardfloat for PPC

On Mon, 2 Mar 2020, Alex Bennée wrote: BALATON Zoltan writes: On Sun, 1 Mar 2020, Richard Henderson wrote: On 3/1/20 4:13 PM, Programmingkid wrote: Ok, I was just looking at Intel's x87 chip documentation. It supports IEEE 754 floating point operations and exception flags. This leads me to th

Re: [RFC PATCH v2] target/ppc: Enable hardfloat for PPC

On Mon, 2 Mar 2020, Richard Henderson wrote: On 3/2/20 3:42 AM, BALATON Zoltan wrote: The "hardfloat" option works (with other targets) only with ieee745 accumulative exceptions, when the most common of those exceptions, inexact, has already been raised.  And thus need not be raised a second tim

[PATCH] tests/acceptance: move @skipUnless decoration to test itself

From: Alex Bennée It appears ignore the decoration if just applied to the class. Fixes: 0484d9d4fbe9beacd Signed-off-by: Alex Bennée [PMD: Move decorations to each test function] Signed-off-by: Philippe Mathieu-Daudé --- tests/acceptance/machine_mips_malta.py | 8 ++-- 1 file changed, 6 i

Re: [PULL v3 02/11] hppa: Add support for LASI chip with i82596 NIC

On 3/2/20 9:34 PM, Helge Deller wrote: * Peter Maydell : On Mon, 2 Mar 2020 at 19:23, Helge Deller wrote: On 17.02.20 18:56, Peter Maydell wrote: On Fri, 24 Jan 2020 at 23:20, Richard Henderson wrote: From: Helge Deller LASI is a built-in multi-I/O chip which supports serial, parallel,

Re: [PATCH] hw/artist: Reduce default artist screen size to 800x600 pixel

On 3/2/20 8:14 PM, Helge Deller wrote: Reduce the default emulated screen size to 800x600 pixel instead of 1280x1024 pixel. With the bigger screen size the emulated graphic card isn't fully visible on my laptop display, and if people want bigger sizes it's possible to define it on the command lin

Re: [PATCH 1/2] ide: Make room for flags in PCIIDEState and add one for legacy IRQ routing

On Mon, 2 Mar 2020, Mark Cave-Ayland wrote: On 02/03/2020 08:10, Markus Armbruster wrote: BALATON Zoltan writes: On Sun, 1 Mar 2020, Mark Cave-Ayland wrote: On 29/02/2020 23:02, BALATON Zoltan wrote: We'll need a flag for implementing some device specific behaviour in via-ide but we already

Re: [PATCH 0/5] mostly changes related to audio float samples

On Mon, Mar 2, 2020 at 8:08 PM Volker Rümelin wrote: > Patch "audio: change naming scheme of FLOAT_CONV macros" and > patch "audio: consistency changes" should have been a review > for ed2a4a7941 "audio: proper support for float samples in > mixeng", but I was too slow. > > Patch "audio: change m

Re: [EXTERNAL]Re: [PULL 5/5] tests/acceptance: Count multiple Tux logos displayed on framebuffer

On 3/2/20 9:58 PM, Aleksandar Markovic wrote: From: Peter Maydell Sent: Monday, March 2, 2020 9:26 PM To: Aleksandar Markovic Cc: QEMU Developers; Aleksandar Markovic; Philippe Mathieu-Daudé Subject: [EXTERNAL]Re: [PULL 5/5] tests/acceptance: Count multiple Tux logos displayed on framebuffer O

Re: [PATCH v2 1/9] target/arm: Replicate TBI/TBID bits for single range regimes

On 3/2/20 6:58 PM, Richard Henderson wrote: Replicate the single TBI bit from TCR_EL2 and TCR_EL3 so that we can unconditionally use pointer bit 55 to index into our composite TBI1:TBI0 field. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/helper.c | 6 -- 1

Re: [PATCH v2 3/9] target/arm: Introduce core_to_aa64_mmu_idx

On 3/2/20 6:58 PM, Richard Henderson wrote: If by context we know that we're in AArch64 mode, we need not test for M-profile when reconstructing the full ARMMMUIdx. Signed-off-by: Richard Henderson --- target/arm/internals.h | 6 ++ target/arm/translate-a64.c | 2 +- 2 files changed

Re: [PATCH v2 5/9] target/arm: Move helper_dc_zva to helper-a64.c

On 3/2/20 6:58 PM, Richard Henderson wrote: This is an aarch64-only function. Move it out of the shared file. This patch is code movement only. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/helper-a64.h | 1 + target/arm/helper.h | 1 - target/arm/helper

Re: [PATCH v2 6/9] target/arm: Use DEF_HELPER_FLAGS for helper_dc_zva

On 3/2/20 6:58 PM, Richard Henderson wrote: The function does not write registers, and only reads them by implication via the exception path. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/helper-a64.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

Re: [EXTERNAL][PATCH] mips/mips_malta: Allow more than 2G RAM

On 3/2/20 10:22 PM, Aleksandar Markovic wrote: Forwarding this to Igor. Can you please give us your opinion, Igor, on this proposal? I'm not sure it is Igor area. What need to be reviewed here is the GT64120 north bridge, which works very well with the default config, but is fragile when mod

[Bug 1865626] [NEW] qemu hang when ipl boot from a mdev dasd

Public bug reported: qemu latest kernel 5.3.18 I am using a passthrough dasd as boot device, the installment looks fine and gets into reboot process. However VM could not boot and just hang as below after that. I have been checking on "s390: vfio-ccw dasd ipl support" series right now but no clue

[Bug 1865626] Re: qemu hang when ipl boot from a mdev dasd

s390zp12:~ # cat test.sh /root/qemu/s390x-softmmu/qemu-system-s390x \ -machine s390-ccw-virtio,accel=kvm \ -nographic \ -bios /root/qemu/pc-bios/s390-ccw/s390-ccw.img \ -device vfio-ccw,id=hostdev0,sysfsdev=/sys/bus/mdev/devices/08e8c006-146d-48d3-b21a-c005f9d3a04b,devno=fe.0.1234,bootindex=1 \ -

Re: [PATCH v2] riscv: sifive_u: Add a "serial" property for board serial number

On Mon, Feb 24, 2020 at 9:02 PM Bin Meng wrote: > > Hi Alistair, > > On Tue, Feb 25, 2020 at 5:14 AM Alistair Francis wrote: > > > > On Sun, Feb 16, 2020 at 5:56 AM Bin Meng wrote: > > > > > > At present the board serial number is hard-coded to 1, and passed > > > to OTP model during initializat

Re: [RFC PATCH v2] target/ppc: Enable hardfloat for PPC

On 3/2/20 3:16 PM, BALATON Zoltan wrote: >> (2) IEEE has a number of implementation choices for corner cases, and we need >> to implement the target's choices, not the host's choices. > > But how is that related to inexact flag and float_round_nearest_even rounding > mode which are the only two th

Re: [PATCH v3 2/4] target/i386: Remove monitor from some CPU models

On 3/3/2020 1:19 AM, Eduardo Habkost wrote: On Mon, Mar 02, 2020 at 07:47:28PM +0800, Tao Xu wrote: On 2/29/2020 5:39 AM, Eduardo Habkost wrote: On Wed, Feb 12, 2020 at 04:13:26PM +0800, Tao Xu wrote: Add new version of Snowridge, Denverton, Opteron_G3, EPYC, and Dhyana CPU model to uremove MO

[PATCH v1] mips/mips_malta: Allow more than 2G RAM

When malta is coupled with MIPS64 cpu which have 64bit address space, it is possible to have more than 2G RAM. So we removed ram_size check and overwrite memory layout for these targets. Signed-off-by: Jiaxun Yang Suggested-by: Yunqiang Su -- v1: Do not overwrite cmdline when we don't have high

[PULL] RISC-V Patches for the 5.0 Soft Freeze, Part 3

The following changes since commit 8b6b68e05b43f976714ca1d2afe01a64e1d82cba: Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2020-02-27 19:15:15 +) are available in the Git repository at: g...@github.com:palmer-dabbelt/qemu.git tags/riscv-for-master-5.0-sf3 f

[PULL 09/38] target/riscv: Print priv and virt in disas log

From: Alistair Francis Signed-off-by: Alistair Francis Reviewed-by: Palmer Dabbelt Signed-off-by: Palmer Dabbelt --- target/riscv/translate.c | 8 1 file changed, 8 insertions(+) diff --git a/target/riscv/translate.c b/target/riscv/translate.c index d5de7f468a..eff064dc44 100644 ---

[PULL 04/38] target/riscv: Add support for the new execption numbers

From: Alistair Francis The v0.5 Hypervisor spec add new execption numbers, let's add support for those. Signed-off-by: Alistair Francis Reviewed-by: Palmer Dabbelt Signed-off-by: Palmer Dabbelt --- target/riscv/cpu.c| 8 target/riscv/cpu_bits.h | 35 +++---

[PULL 01/38] target/riscv: Convert MIP CSR to target_ulong

From: Alistair Francis The MIP CSR is a xlen CSR, it was only 32-bits to allow atomic access. Now that we don't use atomics for MIP we can change this back to a xlen CSR. Signed-off-by: Alistair Francis Reviewed-by: Palmer Dabbelt Signed-off-by: Palmer Dabbelt --- target/riscv/cpu.c | 2 +-

<    1   2   3   4   >