Re: [PATCH v1 3/8] qcow2: add zstd cluster compression

2020-02-28 Thread Denis Plotnikov
On 27.02.2020 17:01, Eric Blake wrote: On 2/27/20 1:29 AM, Denis Plotnikov wrote: zstd significantly reduces cluster compression time. It provides better compression performance maintaining the same level of the compression ratio in comparison with zlib, which, at the moment, is the only comp

Re: Strange data corruption issue with gluster (libgfapi) and ZFS

2020-02-28 Thread Stefan Ring
On Fri, Feb 28, 2020 at 12:10 PM Kevin Wolf wrote: > > This sounds almost like two other bugs we got fixed recently (in the > QEMU file-posix driver and in the XFS kernel driver) where two write > extending the file size were in flight in parallel, but if the shorter > one completed last, instead

[PATCH v2 01/18] vl: Add missing "hw/boards.h" include

2020-02-28 Thread Philippe Mathieu-Daudé
vl.c calls machine_usb() declared in "hw/boards.h". Include it. This fixes (when modifying unrelated headers): vl.c:1283:10: error: implicit declaration of function 'machine_usb' is invalid in C99 [-Werror,-Wimplicit-function-declaration] if (!machine_usb(current_machine)) { ^

[PATCH v2 02/18] hw/southbridge/ich9: Removed unused headers

2020-02-28 Thread Philippe Mathieu-Daudé
The ICH9 chipset is not X86/PC specific. These files don't use anything declared by the "hw/i386/pc.h" or "hw/i386/ioapic.h" headers. Remove them. Reviewed-by: John Snow Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i386/ich9.h | 1 - hw/acpi/ich9.c | 1 - hw/isa/lpc_ich9.c

[PATCH v2 00/18] hw: Clean up hw/i386 headers (and few alpha/hppa)

2020-02-28 Thread Philippe Mathieu-Daudé
[Rebased since v1]: https://www.mail-archive.com/qemu-block@nongnu.org/msg57485.html This is a follow-up of Markus's cleanup series: Tame a few "touch this, recompile the world" https://www.mail-archive.com/qemu-devel@nongnu.org/msg635748.html This part is mostly restricted to X86, but since some

Re: [edk2-devel] A problem with live migration of UEFI virtual machines

2020-02-28 Thread Laszlo Ersek
On 02/28/20 05:04, Andrew Fish wrote: > Maybe I was overcomplicating this. Given your explanation I think the part > I'm missing is OVMF is implying FLASH layout, in this split model, based on > the size of the OVMF_CODE.fd and OVMF_VARS.fd. Given that if OVMF_CODE.fd > gets bigger the variabl

[PATCH v2 03/18] hw/i386/ioapic_internal: Remove unused "hw/i386/ioapic.h" header

2020-02-28 Thread Philippe Mathieu-Daudé
The "ioapic_internal.h" does not use anything from "hw/i386/ioapic.h", remove it. Acked-by: John Snow Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i386/ioapic_internal.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/hw/i386/ioapic_internal.h b/include/hw/i386/ioapic_intern

[PATCH v2 04/18] hw/timer: Remove unused "ui/console.h" header

2020-02-28 Thread Philippe Mathieu-Daudé
The timer models don't need anything from "ui/console.h". Remove it. Acked-by: John Snow Signed-off-by: Philippe Mathieu-Daudé --- hw/rtc/twl92230.c | 1 - hw/timer/hpet.c | 1 - 2 files changed, 2 deletions(-) diff --git a/hw/rtc/twl92230.c b/hw/rtc/twl92230.c index 63bd13d2ca..d0011be89e 1

[PATCH v2 05/18] hw/usb/dev-storage: Remove unused "ui/console.h" header

2020-02-28 Thread Philippe Mathieu-Daudé
The USB models related to storage don't need anything from "ui/console.h". Remove it. Acked-by: John Snow Signed-off-by: Philippe Mathieu-Daudé --- hw/usb/dev-storage.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/usb/dev-storage.c b/hw/usb/dev-storage.c index 90da008df1..4883c1d89e 10

[PATCH v2 06/18] hw/i386/intel_iommu: Remove unused includes

2020-02-28 Thread Philippe Mathieu-Daudé
intel_iommu.h does not use any of these includes, remove them. Acked-by: John Snow Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i386/intel_iommu.h | 4 1 file changed, 4 deletions(-) diff --git a/include/hw/i386/intel_iommu.h b/include/hw/i386/intel_iommu.h index 66b931e526..a1c4a

[PATCH v2 07/18] hw/alpha/alpha_sys: Remove unused "hw/ide.h" header

2020-02-28 Thread Philippe Mathieu-Daudé
alpha_sys.h does not use anything from the "hw/ide.h" header. Remove it. Acked-by: John Snow Signed-off-by: Philippe Mathieu-Daudé --- hw/alpha/alpha_sys.h | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/alpha/alpha_sys.h b/hw/alpha/alpha_sys.h index bc0a286226..e2c02e2bbe 100644 --- a/hw

[PATCH v2 09/18] hw/hppa/machine: Include "net/net.h"

2020-02-28 Thread Philippe Mathieu-Daudé
hw/hppa/machine.c uses NICInfo variables which are declared in "net/net.h". Include it. This fixes (when modifying unrelated headers): hw/hppa/machine.c:126:21: error: use of undeclared identifier 'nb_nics' for (i = 0; i < nb_nics; i++) { ^ hw/hppa/machine.c:127:30

[PATCH v2 13/18] hw/i2c/smbus_ich9: Include "qemu/range.h"

2020-02-28 Thread Philippe Mathieu-Daudé
hw/i2c/smbus_ich9.c calls range_covers_byte(). Include "qemu/range.h" which declares it. This fixes (when modifying unrelated headers): hw/i2c/smbus_ich9.c:66:9: error: implicit declaration of function 'range_covers_byte' is invalid in C99 [-Werror,-Wimplicit-function-declaration] if (ra

[PATCH v2 10/18] hw/acpi/cpu_hotplug: Include "hw/pci/pci.h"

2020-02-28 Thread Philippe Mathieu-Daudé
hw/acpi/cpu_hotplug.c calls pci_address_space_io(). Include "hw/pci/pci.h" which declares it. This fixes (when modifying unrelated headers): hw/acpi/cpu_hotplug.c:103:28: error: implicit declaration of function 'pci_address_space_io' is invalid in C99 [-Werror,-Wimplicit-function-declaration]

[PATCH v2 08/18] hw/alpha/dp264: Include "net/net.h"

2020-02-28 Thread Philippe Mathieu-Daudé
hw/alpha/dp264.c uses NICInfo variables which are declared in "net/net.h". Include it. This fixes (when modifying unrelated headers): hw/alpha/dp264.c:89:21: error: use of undeclared identifier 'nb_nics' for (i = 0; i < nb_nics; i++) { ^ hw/alpha/dp264.c:90:30: err

[PATCH v2 11/18] hw/timer/hpet: Include "exec/address-spaces.h"

2020-02-28 Thread Philippe Mathieu-Daudé
hw/timer/hpet.c calls address_space_stl_le() declared in "exec/address-spaces.h". Include it. This fixes (when modifying unrelated headers): hw/timer/hpet.c:210:31: error: use of undeclared identifier 'address_space_memory' address_space_stl_le(&address_space_memory, timer->fsb >> 32

Re: [PATCH v1 4/8] iotests: filter out compression_type

2020-02-28 Thread Denis Plotnikov
On 27.02.2020 17:03, Eric Blake wrote: On 2/27/20 1:29 AM, Denis Plotnikov wrote: After adding compression type feature to qcow2 format, qemu framework commands reporting the image settingd, e.g. "qemu-img create", started settings reporting the compression type for the image which breaks

[PATCH v2 17/18] hw/pci-host/q35: Remove unused includes

2020-02-28 Thread Philippe Mathieu-Daudé
Only q35.c requires declarations from "hw/i386/pc.h", move it there. Remove all the includes not used by "q35.h". Acked-by: John Snow Signed-off-by: Philippe Mathieu-Daudé --- include/hw/pci-host/q35.h | 7 --- hw/pci-host/q35.c | 1 + 2 files changed, 1 insertion(+), 7 deletions(-)

[PATCH v2 12/18] hw/pci-host/q35: Include "qemu/range.h"

2020-02-28 Thread Philippe Mathieu-Daudé
The MCHPCIState structure uses the Range type which is declared in "qemu/range.h". Include it. This fixes (when modifying unrelated headers): In file included from hw/pci-host/q35.c:32: include/hw/pci-host/q35.h:57:11: error: field has incomplete type 'Range' (aka 'struct Range') Range

[PATCH v2 18/18] hw/i386/pc: Clean up includes

2020-02-28 Thread Philippe Mathieu-Daudé
Various headers are not required by hw/i386/pc.h: - "qemu/range.h" - "qemu/bitmap.h" - "qemu/module.h" - "exec/memory.h" - "hw/pci/pci.h" - "hw/mem/pc-dimm.h" - "hw/mem/nvdimm.h" - "net/net.h" Remove them. Add 3 headers that were missing: - "hw/hotplug.h" PCMachineState::acpi_dev i

[PATCH v2 14/18] hw/pci-host/piix: Include "qemu/range.h"

2020-02-28 Thread Philippe Mathieu-Daudé
hw/pci-host/piix.c calls various functions from the Range API. Include "qemu/range.h" which declares them. This fixes (when modifying unrelated headers): hw/pci-host/i440fx.c:54:11: error: field has incomplete type 'Range' (aka 'struct Range') Range pci_hole; ^ include/qemu/

[PATCH v2 15/18] hw/acpi: Include "hw/mem/nvdimm.h"

2020-02-28 Thread Philippe Mathieu-Daudé
Both ich9.c and piix4.c use methods/definitions declared in the NVDIMM device header. Include it. This fixes (when modifying unrelated headers): hw/acpi/ich9.c:507:46: error: use of undeclared identifier 'TYPE_NVDIMM' if (object_dynamic_cast(OBJECT(dev), TYPE_NVDIMM)) {

[PATCH v2 16/18] hw/i386: Include "hw/mem/nvdimm.h"

2020-02-28 Thread Philippe Mathieu-Daudé
All this files use methods/definitions declared in the NVDIMM device header. Include it. This fixes (when modifying unrelated headers): hw/i386/acpi-build.c:2733:9: error: implicit declaration of function 'nvdimm_build_acpi' is invalid in C99 [-Werror,-Wimplicit-function-declaration] n

Re: [edk2-devel] A problem with live migration of UEFI virtual machines

2020-02-28 Thread Laszlo Ersek
On 02/28/20 12:47, Laszlo Ersek wrote: > On 02/28/20 05:04, Andrew Fish wrote: >> Given the above it seems like the 2 options are: >> 1) Pad OVMF_CODE.fd to be very large so there is room to grow. > > There's already room to grow, *inside* OVMF_CODE.fd. As I've shown > elsewhere in this thread, e

Re: [PATCH v1 3/8] qcow2: add zstd cluster compression

2020-02-28 Thread Denis Plotnikov
On 27.02.2020 17:18, Vladimir Sementsov-Ogievskiy wrote: 27.02.2020 17:11, Denis Plotnikov wrote: On 27.02.2020 12:55, Vladimir Sementsov-Ogievskiy wrote: 27.02.2020 10:29, Denis Plotnikov wrote: zstd significantly reduces cluster compression time. It provides better compression performan

[PATCH] vfio: avoid SET_ACTION_TRIGGER ioctls

2020-02-28 Thread Roman Kapl
For MSI-X interrupts, remember what the last used eventfd was (KVM bypass vs QEMU) and only call vfio_set_irq_signaling if it has changed. This not only helps with performance, but it seems that interrupts can be lost during VFIO_IRQ_SET_ACTION_TRIGGER. With the 'x-no-kvm-msix' switch and this pat

[PATCH] hw/ppc/pnv: Fix typo in comment

2020-02-28 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- hw/ppc/pnv_lpc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ppc/pnv_lpc.c b/hw/ppc/pnv_lpc.c index f150deca34..b5ffa48dac 100644 --- a/hw/ppc/pnv_lpc.c +++ b/hw/ppc/pnv_lpc.c @@ -829,7 +829,7 @@ ISABus *pnv_lpc_isa_create(PnvLp

[PATCH] block: Remove trailing newline in format used by error_report API

2020-02-28 Thread Philippe Mathieu-Daudé
The error_report API doesn't want trailing newline characters. Remove it, to avoid and error when moving the code around: ERROR: Error messages should not contain newlines Signed-off-by: Philippe Mathieu-Daudé --- block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/blo

Re: [PATCH] hw/ppc/pnv: Fix typo in comment

2020-02-28 Thread Cédric Le Goater
On 2/28/20 1:33 PM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Thnaks, C. > --- > hw/ppc/pnv_lpc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/ppc/pnv_lpc.c b/hw/ppc/pnv_lpc.c > index f150deca34..b5ff

[PATCH 0/2] block/qcow2: Fix bitmap reopen with 'auto-read-only' file child

2020-02-28 Thread Peter Krempa
See patch 2/2 for explanation. Also please excuse the lack of tests caused by my ignorance of not figuring out where to put them. Peter Krempa (2): block: Introduce 'bdrv_reopen_commit_post' step block/qcow2: Move bitmap reopen into bdrv_reopen_commit_post block.c | 9 +

[PATCH 1/2] block: Introduce 'bdrv_reopen_commit_post' step

2020-02-28 Thread Peter Krempa
Add another step in the reopen process where driver can execute code after permission changes are comitted. Signed-off-by: Peter Krempa --- block.c | 9 + include/block/block_int.h | 1 + 2 files changed, 10 insertions(+) diff --git a/block.c b/block.c index 1bdb9c679d

[PATCH 2/2] block/qcow2: Move bitmap reopen into bdrv_reopen_commit_post

2020-02-28 Thread Peter Krempa
The bitmap code requires writing the 'file' child when the qcow2 driver is reopened in read-write mode. If the 'file' child is being reopened due to a permissions change, the modification is commited yet when qcow2_reopen_commit is called. This means that any attempt to write the 'file' child will

Re: [PATCH v4 0/2] virtiofsd: Fix xattr operations

2020-02-28 Thread Vivek Goyal
On Thu, Feb 27, 2020 at 02:59:25PM +0900, Misono Tomohiro wrote: > Currently xattr operations on virtiofs does not work properly in some case: > - directory ... cannot set > - special files (pipe) ... cause hang > > This fixes these problems and now xfstests generic/062 passes on virtiofs > with

[PATCH 2/5] hw/arm/mainstone: Simplify since the machines are little-endian only

2020-02-28 Thread Philippe Mathieu-Daudé
We only build the little-endian softmmu configurations. Checking for big endian is pointless, remove the unused code. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/mainstone.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/hw/arm/mainstone.c b/hw/arm/mainstone.c in

[PATCH 0/5] hw/arm: Remove big-endian checks on machine code

2020-02-28 Thread Philippe Mathieu-Daudé
We only build the little-endian softmmu configurations. Checking for big endian is pointless, remove the unused code. Philippe Mathieu-Daudé (5): hw/arm/gumstix: Simplify since the machines are little-endian only hw/arm/mainstone: Simplify since the machines are little-endian only hw/arm/oma

[PATCH 1/5] hw/arm/gumstix: Simplify since the machines are little-endian only

2020-02-28 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé As the Connex and Verdex machines only boot in little-endian, we can simplify the code. Reviewed-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé --- v2: Do not use target_words_bigendian(), arm-softmmu is only little endian (Peter Maydell) --- hw/arm/g

[PATCH 3/5] hw/arm/omap_sx1: Simplify since the machines are little-endian only

2020-02-28 Thread Philippe Mathieu-Daudé
We only build the little-endian softmmu configurations. Checking for big endian is pointless, remove the unused code. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/omap_sx1.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/hw/arm/omap_sx1.c b/hw/arm/omap_sx1.c

[PATCH 4/5] hw/arm/z2: Simplify since the machines are little-endian only

2020-02-28 Thread Philippe Mathieu-Daudé
We only build the little-endian softmmu configurations. Checking for big endian is pointless, remove the unused code. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/z2.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/hw/arm/z2.c b/hw/arm/z2.c index 4bb237f22d..a0f40

[PATCH 5/5] hw/arm/musicpal: Simplify since the machines are little-endian only

2020-02-28 Thread Philippe Mathieu-Daudé
We only build the little-endian softmmu configurations. Checking for big endian is pointless, remove the unused code. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/musicpal.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/hw/arm/musicpal.c b/hw/arm/musicpal.c index db8b03cb83.

Re: [PATCH v3 1/4] scripts/simplebench: add simplebench.py

2020-02-28 Thread Aleksandar Markovic
On Fri, Feb 28, 2020 at 8:19 AM Vladimir Sementsov-Ogievskiy wrote: > > Add simple benchmark table creator. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > scripts/simplebench/simplebench.py | 128 + > 1 file changed, 128 insertions(+) > create mode 100644 sc

Re: [PATCH v3 2/4] scripts/simplebench: add qemu/bench_block_job.py

2020-02-28 Thread Aleksandar Markovic
On Fri, Feb 28, 2020 at 8:19 AM Vladimir Sementsov-Ogievskiy wrote: > > Add block-job benchmarking helper functions. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- Reviewed-by: Aleksandar Markovic > scripts/simplebench/bench_block_job.py | 119 + > 1 file change

Re: [PATCH] block: Remove trailing newline in format used by error_report API

2020-02-28 Thread Liam Merwick
On 28/02/2020 12:36, Philippe Mathieu-Daudé wrote: The error_report API doesn't want trailing newline characters. Remove it, to avoid and error when moving the code around: s/and/an/ ERROR: Error messages should not contain newlines Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: L

Re: [PATCH v2 05/18] hw/usb/dev-storage: Remove unused "ui/console.h" header

2020-02-28 Thread Gerd Hoffmann
On Fri, Feb 28, 2020 at 12:46:36PM +0100, Philippe Mathieu-Daudé wrote: > The USB models related to storage don't need anything from > "ui/console.h". Remove it. > > Acked-by: John Snow > Signed-off-by: Philippe Mathieu-Daudé Acked-by: Gerd Hoffmann

Re: [PATCH v3 3/4] scripts/simplebench: add example usage of simplebench

2020-02-28 Thread Aleksandar Markovic
On Fri, Feb 28, 2020 at 8:21 AM Vladimir Sementsov-Ogievskiy wrote: > > This example may be used as a template for custom benchmark. > It illustrates three things to prepare: > - define bench_func > - define test environments (columns) > - define test cases (rows) > And final call of simplebenc

Re: [PATCH v3 4/4] MAINTAINERS: add simplebench

2020-02-28 Thread Aleksandar Markovic
On Fri, Feb 28, 2020 at 8:19 AM Vladimir Sementsov-Ogievskiy wrote: > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- Reviewed-by: Aleksandar Markovic > MAINTAINERS | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 5e5e3e52d6..16d069adc5 10064

Re: [PATCH v3 1/4] scripts/simplebench: add simplebench.py

2020-02-28 Thread Vladimir Sementsov-Ogievskiy
28.02.2020 16:03, Aleksandar Markovic wrote: On Fri, Feb 28, 2020 at 8:19 AM Vladimir Sementsov-Ogievskiy wrote: Add simple benchmark table creator. Signed-off-by: Vladimir Sementsov-Ogievskiy --- scripts/simplebench/simplebench.py | 128 + 1 file changed, 128

Re: [PULL 0/5] MIPS queue for February 27th, 2020

2020-02-28 Thread Peter Maydell
On Thu, 27 Feb 2020 at 13:27, Aleksandar Markovic wrote: > > From: Aleksandar Markovic > > The following changes since commit db736e0437aa6fd7c1b7e4599c17f9619ab6b837: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2020-02-25 13:31:16 +) > > are availa

[Bug 1865048] Re: qemu-img --force-share does not disable file locking

2020-02-28 Thread Max Reitz
Hi Olaf, Every “node” in the block graph corresponds to some driver. A driver can be a protocol or a format driver (or a filter driver, but that isn’t important here). In your example, there is only a single node, for a protocol driver (namely “file”). You need a format driver node on top to in

Re: [PATCH v4 00/10] vTPM for aarch64

2020-02-28 Thread Stefan Berger
On 2/27/20 3:07 AM, Auger Eric wrote: Hi Stefan, On 2/26/20 11:44 PM, Stefan Berger wrote: On 2/26/20 3:59 PM, Eric Auger wrote: This series adds the capability to instantiate an MMIO TPM TIS in ARM virt. It is candidate to qemu 5.0. I queued it now here: https://github.com/stefanberger/qemu-t

Re: [PATCH v4 00/10] vTPM for aarch64

2020-02-28 Thread Auger Eric
Hi Stefan, On 2/28/20 3:37 PM, Stefan Berger wrote: > On 2/27/20 3:07 AM, Auger Eric wrote: >> Hi Stefan, >> On 2/26/20 11:44 PM, Stefan Berger wrote: >>> On 2/26/20 3:59 PM, Eric Auger wrote: This series adds the capability to instantiate an MMIO TPM TIS in ARM virt. It is candidate to q

[Bug 1865160] [NEW] Unpredictable behaviour resulting in User process faults

2020-02-28 Thread A. Farrell
Public bug reported: An example of the behaviour can be reproduced when using NPM, whereby running the command multiple times will result in a variety of error conditions causing the command to fail: Example of failure: Segmentation fault.] / rollbackFailedOptional: verb npm-session 1a805a5e0ff7

Re: [PATCH 4/5] KVM: Kick resamplefd for split kernel irqchip

2020-02-28 Thread Peter Xu
On Fri, Feb 28, 2020 at 11:34:46AM +0100, Paolo Bonzini wrote: > On 26/02/20 23:55, Peter Xu wrote: > > + > > +/* Kick resamplefd if KVM is bypassed */ > > +kvm_resample_fd_notify(n); > > This is only needed for level-triggered interrupts, so it can be placed > below the te

[PATCH] scsi/qemu-pr-helper: Fix out-of-bounds access to trnptid_list[]

2020-02-28 Thread Christophe de Dinechin
Compile error reported by gcc 10.0.1: scsi/qemu-pr-helper.c: In function ‘multipath_pr_out’: scsi/qemu-pr-helper.c:523:32: error: array subscript is outside array bounds of ‘struct transportid *[0]’ [-Werror=array-bounds] 523 | paramp.trnptid_list[paramp.num_transportid++] = id;

Re: [PATCH 4/5] KVM: Kick resamplefd for split kernel irqchip

2020-02-28 Thread Paolo Bonzini
On 28/02/20 15:58, Peter Xu wrote: > Yes I was thinking it the same way, however... I noticed that VFIO > will even mask edge INTx after getting IRQ (vfio_intx_handler). INTx is always level-triggered so that's okay. > And if look into current KVM kernel implementation, it has done the > same lo

Re: [PATCH 0/5] vfio/pci: Fix up breakage against split irqchip and INTx

2020-02-28 Thread Peter Xu
On Fri, Feb 28, 2020 at 11:36:55AM +0100, Paolo Bonzini wrote: > On 26/02/20 23:50, Peter Xu wrote: > > VFIO INTx is not working with split irqchip. On new kernels KVM_IRQFD > > will directly fail with resamplefd attached so QEMU will automatically > > fallback to the INTx slow path. However on o

Re: [PATCH 0/5] vfio/pci: Fix up breakage against split irqchip and INTx

2020-02-28 Thread Paolo Bonzini
On 28/02/20 16:25, Peter Xu wrote: > My current thought is that we keep this hackery in userspace only so > we keep split+resamplefd forbidden in the kernel and be clean there. It is better, yes. The kernel solution makes some sense because split irqchip _does_ have a concept of ioapic GSIs and r

[PATCH v3 03/33] texi2pod: parse @include directives outside "@c man" blocks

2020-02-28 Thread Peter Maydell
From: Paolo Bonzini This enables splitting the huge qemu-doc.texi file and keeping parallel Texinfo and rST versions of the documentation. texi2pod is not going to live much longer and hardly anyone cares about its upstream status, so the temporary fork should be acceptable. Signed-off-by: Paol

[PATCH v3 00/33] Convert qemu-doc to rST

2020-02-28 Thread Peter Maydell
Hi; this series does a complete conversion of qemu-doc from Texinfo to rST, including the hxtool-generated parts and creation of the qemu.1 manpage from rST. It's marked v3 because it's a development of the v2 that Paolo sent out earlier this week. Changes from v2: * I made the various review-co

[PATCH v3 02/33] qemu-doc: remove target OS documentation

2020-02-28 Thread Peter Maydell
From: Paolo Bonzini This section covers OSes up to Windows 2000, and as such it is mostly obsolete. Zap it. Reviewed-by: Peter Maydell Signed-off-by: Paolo Bonzini Message-id: 20200226113034.6741-3-pbonz...@redhat.com Signed-off-by: Peter Maydell --- qemu-doc.texi | 96 -

[PATCH v3 01/33] qemu-doc: convert user-mode emulation to a separate Sphinx manual

2020-02-28 Thread Peter Maydell
From: Paolo Bonzini The final addition to the set of QEMU manuals is the user-mode emulation manual, which right now is included in qemu-doc.texi. Extract it and convert it to rST, so that qemu-doc.texi covers only full system emulation. Signed-off-by: Paolo Bonzini Message-id: 20200226113034.

[PATCH v3 07/33] qemu-doc: move system requirements chapter inside PC section

2020-02-28 Thread Peter Maydell
From: Paolo Bonzini The system requirements documented in this chapter are limited to x86 KVM targets. Clean them up and move them to the target section. Signed-off-by: Paolo Bonzini Message-id: 20200226113034.6741-8-pbonz...@redhat.com Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell

[PATCH v3 04/33] qemu-doc: split CPU models doc between MIPS and x86 parts

2020-02-28 Thread Peter Maydell
From: Paolo Bonzini The MIPS CPU models end up in the middle of the PC documentation. Move them to a separate file so that they can be placed in the right section. The man page still includes both x86 and MIPS content. Signed-off-by: Paolo Bonzini Message-id: 20200226113034.6741-5-pbonz...@re

[PATCH v3 06/33] qemu-doc: extract common system emulator documentation from the PC section

2020-02-28 Thread Peter Maydell
From: Paolo Bonzini Move the section on PC peripherals together with other targets. While some x86-specific information remains in the main system emulation chapter, it can be tackled more easily a section at a time. Signed-off-by: Paolo Bonzini Message-id: 20200226113034.6741-7-pbonz...@redhat

[PATCH v3 11/33] qemu-doc: move included files to docs/system

2020-02-28 Thread Peter Maydell
From: Paolo Bonzini Since qemu-doc.texi is mostly including files from docs/system, move the existing include files there for consistency. Signed-off-by: Paolo Bonzini Message-id: 20200226113034.6741-12-pbonz...@redhat.com [PMM: update MAINTAINERS line for qemu-option-trace.texi] Reviewed-by: P

[PATCH v3 12/33] qemu-doc: remove indices other than findex

2020-02-28 Thread Peter Maydell
From: Paolo Bonzini These indices are not well-maintained, and pandoc also chokes on the directives. Just nuke them. Signed-off-by: Paolo Bonzini Message-id: 20200226113034.6741-13-pbonz...@redhat.com Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- docs/system/keys.texi

[PATCH v3 17/33] docs/system: convert managed startup to rST.

2020-02-28 Thread Peter Maydell
Fix one typo in the process and format more option and command names as literal text, but make no significant changes to the content. Signed-off-by: Peter Maydell Signed-off-by: Paolo Bonzini Message-id: 20200226113034.6741-17-pbonz...@redhat.com --- docs/system/index.rst | 2 +- doc

[PATCH v3 10/33] qemu-doc: move qemu-tech.texi into main section

2020-02-28 Thread Peter Maydell
From: Paolo Bonzini The only remaining content in qemu-tech.texi is a few paragraphs about managed start up options. Move them in the main section about full system emulation. Signed-off-by: Paolo Bonzini Message-id: 20200226113034.6741-11-pbonz...@redhat.com Reviewed-by: Peter Maydell Signed

[PATCH v3 09/33] qemu-doc: Remove the "CPU emulation" part of the "Implementation notes"

2020-02-28 Thread Peter Maydell
The "CPU emulation" part of the "Implementation notes" in qemu-tech.texi looks like it is documenting what features of various CPUs we do or don't emulate. However: * it covers only six of our 21 guest architectures * the last time anybody updated it for actual content was in 2011/2012 for Xt

[PATCH v3 14/33] docs: Create defs.rst.inc as a place to define substitutions

2020-02-28 Thread Peter Maydell
Rather than accumulating generally useful rST substitution definitions in individual rST files, create a defs.rst.inc where we can define these. To start with it has the |qemu_system| definition from qemu-block-drivers.rst. Add a comment noting a pitfall where putting literal markup in the defini

[PATCH v3 16/33] docs/system: Convert security.texi to rST format

2020-02-28 Thread Peter Maydell
security.texi is included from qemu-doc.texi but is not used in the qemu.1 manpage. So we can do a straightforward conversion of the contents, which go into the system manual. Signed-off-by: Peter Maydell Signed-off-by: Paolo Bonzini Message-id: 20200226113034.6741-16-pbonz...@redhat.com --- do

[PATCH v3 15/33] docs/system: Convert qemu-cpu-models.texi to rST

2020-02-28 Thread Peter Maydell
From: Kashyap Chamarthy This doc was originally written by Daniel P. Berrangé , introduced via commit[1]: 2544e9e4aa (docs: add guidance on configuring CPU models for x86, 2018-06-27). In this patch: - 1-1 conversion of Texinfo to rST, besides a couple of minor tweaks that are too trivial

[PATCH v3 13/33] docs/system: put qemu-block-drivers body in an included file

2020-02-28 Thread Peter Maydell
From: Paolo Bonzini This removes the "only" directives, and lets us use the conventional "DESCRIPTION" section in the manpage. This temporarily drops the qemu-block-drivers documentation from the system manual, but it will be put back (in the right place in the toctree) in a later commit. Signe

[PATCH v3 18/33] docs/system: convert the documentation of deprecated features to rST.

2020-02-28 Thread Peter Maydell
We put the whole of this document into the system manual, though technically a few parts of it apply to qemu-img or qemu-nbd which are otherwise documented in tools/. We only make formatting fixes, except for one use of 'appendix' which we change to 'section' because this isn't an appendix in the

[PATCH v3 08/33] qemu-doc: split target sections to separate files

2020-02-28 Thread Peter Maydell
From: Paolo Bonzini Signed-off-by: Paolo Bonzini Message-id: 20200226113034.6741-9-pbonz...@redhat.com Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- docs/system/target-arm.texi | 264 ++ docs/system/target-i386.texi| 92 docs/system/target-m68k.texi| 4

[PATCH v3 23/33] docs: Roll semihosting option information into qemu-options.hx

2020-02-28 Thread Peter Maydell
Currently the per-target documentation for those targets that implement semihosting includes a bit of text that goes into both the manual and the manpage about options specific to the target. This text is redundant with the earlier generic option description of the semihosting option produced from

[PATCH v3 24/33] docs: Roll -prom-env and -g target-specific info into qemu-options.hx

2020-02-28 Thread Peter Maydell
The SPARC and PPC targets currently have a fragment of target-specific information about the -g and -prom options which would be better placed as part of the general documentation of those options in qemu-options.hx. Move the relevant information to those locations. SPARC also has a bit of text ab

[PATCH v3 22/33] doc/scripts/hxtool.py: Strip trailing ':' from DEFHEADING/ARCHHEADING

2020-02-28 Thread Peter Maydell
In hxtool files, section headings defined with the DEFHEADING and ARCHHEADING macros have a trailing ':' DEFHEADING(Standard options:) This is for the benefit of the --help output. For consistency with the rest of the rST documentation, strip any trailing ':' when we construct headings with the

[PATCH v3 28/33] docs: Split out sections for the manpage into .rst.inc files

2020-02-28 Thread Peter Maydell
Sphinx doesn't have very good facilities for marking chunks of documentation as "put this in the manpage only". So instead we move the parts we want to put into both the HTML manuals and the manpage into their own .rst.inc files, which we can include from both the main manual rst files and a new to

[PATCH v3 05/33] qemu-doc: split qemu-doc.texi in multiple files

2020-02-28 Thread Peter Maydell
From: Paolo Bonzini In order to facilitate the reorganization of qemu-doc.texi content, as well as the conversion to rST/Sphinx, split it in multiple .texi files that are included from docs/system. The "other devices" section is renamed to ivshmem and placed last. Signed-off-by: Paolo Bonzini

[PATCH v3 21/33] hmp-commands-info.hx: Add rST documentation fragments

2020-02-28 Thread Peter Maydell
Add the rST versions of the documentation fragments. Once we've converted fully from Texinfo to rST we can remove the ETEXI fragments; for the moment we need both. Note that most of the SRST fragments are 2-space indented so that the 'info foo' documentation entries appear as a sublist under the

[PATCH v3 25/33] scripts/hxtool-conv: Archive script used in qemu-options.hx conversion

2020-02-28 Thread Peter Maydell
This commit archives the perl script used to do conversion of the STEXI/ETEXI blocks in qemu-options.hx. (The other .hx files were manually converted, but qemu-options.hx is complicated enough that I felt I needed some scripting.) Signed-off-by: Peter Maydell --- Please don't critique the script,

[PATCH v3 19/33] docs/system: convert Texinfo documentation to rST

2020-02-28 Thread Peter Maydell
From: Paolo Bonzini Apart from targets.rst, which was written by hand, this is an automated conversion obtained with the following command: makeinfo --force -o - --docbook \ -D 'qemu_system_x86 QEMU_SYSTEM_X86_MACRO' \ -D 'qemu_system QEMU_SYSTEM_MACRO' \ $texi | pandoc -f docb

[PATCH v3 32/33] docs: Remove old texinfo sources

2020-02-28 Thread Peter Maydell
We can now delete the old .texi files, which we have been keeping in the tree as a parallel set of documentation to the new rST sources. The only remaining use of Texinfo is the autogenerated manuals and HTML documents created from the QAPI JSON doc comments. Signed-off-by: Peter Maydell --- MAI

[PATCH v3 30/33] ui/cocoa.m: Update documentation file and pathname

2020-02-28 Thread Peter Maydell
We want to stop generating the old qemu-doc.html; first we must update places that refer to it so they instead go to our top level index.html documentation landing page. The Cocoa UI has a menu option to bring up the documentation; make it point to the new top level index.html instead. Signed-off-

[PATCH v3 20/33] hmp-commands.hx: Add rST documentation fragments

2020-02-28 Thread Peter Maydell
Add the rST versions of the documentation fragments. Once we've converted fully from Texinfo to rST we can remove the ETEXI fragments; for the moment we need both. Since the only consumer of the hmp-commands hxtool documentation is the HTML manual, all we need to do for the monitor command docume

[PATCH v3 27/33] qemu-options.hx: Fix up the autogenerated rST

2020-02-28 Thread Peter Maydell
This commit contains hand-written fixes for some issues with the autogenerated rST fragments in qemu-options.hx: * Sphinx complains about the UTF-8 art table in the documentation of the -drive option. Replace it with a proper rST format table. * rST does not like definition list entries wit

[PATCH v3 29/33] docs: Generate qemu.1 manpage with Sphinx

2020-02-28 Thread Peter Maydell
Generate the qemu.1 manpage using Sphinx; we do this with a new top-level rst source file which is just the skeleton of the manpage and which includes .rst.inc fragments where it needs to incorporate sections from the larger HTML manuals. Signed-off-by: Peter Maydell --- Makefile

[PATCH v3 31/33] docs: Stop building qemu-doc

2020-02-28 Thread Peter Maydell
Stop building the old texinfo qemu-doc; all its contents are now available in the Sphinx-generated manuals and manpages. Signed-off-by: Peter Maydell --- docs/specs/ivshmem-spec.txt | 4 ++-- Makefile| 39 - .gitignore |

Re: [PATCH v2 0/2] hw/arm/xilinx_zynq: Fix USB port instantiation

2020-02-28 Thread Peter Maydell
On Thu, 20 Feb 2020 at 15:05, Peter Maydell wrote: > > On Sat, 15 Feb 2020 at 12:23, Guenter Roeck wrote: > > > > USB ports on Xilinx Zync must be instantiated as TYPE_CHIPIDEA to work. > > Linux expects and checks various chipidea registers, which do not exist > > with the basic ehci emulation.

Re: [PULL 00/15] Pull migration patches

2020-02-28 Thread Peter Maydell
On Fri, 28 Feb 2020 at 09:25, Juan Quintela wrote: > > The following changes since commit 8b6b68e05b43f976714ca1d2afe01a64e1d82cba: > > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging > (2020-02-27 19:15:15 +) > > are available in the Git repository at: > > https

Re: [PATCH 0/4] tests/acceptance: nSeries and integrator/CP tests

2020-02-28 Thread Peter Maydell
On Tue, 25 Feb 2020 at 17:25, Philippe Mathieu-Daudé wrote: > > This series collects patches adding tests for arm machines. > All patches are reviewed. > > Philippe Mathieu-Daudé (2): > tests/acceptance: Extract boot_integratorcp() from test_integratorcp() > tests/acceptance/integratorcp: Veri

Re: [PATCH] tests/acceptance/ppc_prep_40p: Use cdn.netbsd.org hostname

2020-02-28 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Use NetBSD content delivery network to get faster downloads. Even with this patch I get failures on my big dev box: (48/67) tests/acceptance/ppc_prep_40p.py:IbmPrep40pMachine.test_openbios_and_netbsd: INTERRUPTED: Failed to fetch NetBSD-7.1.2-prep.iso.\nRun

[PATCH v2 2/5] vfio/pci: Use kvm_irqchip_add_irqfd_notifier_gsi() for irqfds

2020-02-28 Thread Peter Xu
VFIO is currently the only one left that is not using the generic function (kvm_irqchip_add_irqfd_notifier_gsi()) to register irqfds. Let VFIO use the common framework too. Follow up patches will introduce extra features for kvm irqfd, so that VFIO can easily leverage that after the switch. Revie

[PATCH v2 0/5] vfio/pci: Fix up breakage against split irqchip and INTx

2020-02-28 Thread Peter Xu
v2: - pick tags - don't register resamplefd with KVM kernel when the userspace resamplefd path is enabled (should enable fast path on new kernels) - fix resamplefd mem leak - fix commit message of patch 4 [Eric] - let kvm_resample_fd_notify() return a boolean, skip ioapic check if returned true

[PATCH v2 1/5] vfio/pci: Disable INTx fast path if using split irqchip

2020-02-28 Thread Peter Xu
It's currently broken. Let's use the slow path to at least make it functional. Tested-by: Eric Auger Reviewed-by: Eric Auger Signed-off-by: Peter Xu --- hw/vfio/pci.c | 12 1 file changed, 12 insertions(+) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index 5e75a95129..98e0e0c994 1

[PATCH v2 4/5] KVM: Kick resamplefd for split kernel irqchip

2020-02-28 Thread Peter Xu
This is majorly only for X86 because that's the only one that supports split irqchip for now. When the irqchip is split, we face a dilemma that KVM irqfd will be enabled, however the slow irqchip is still running in the userspace. It means that the resamplefd in the kernel irqfds won't take any ef

[PATCH v2 3/5] KVM: Pass EventNotifier into kvm_irqchip_assign_irqfd

2020-02-28 Thread Peter Xu
So that kvm_irqchip_assign_irqfd() can have access to the EventNotifiers, especially the resample event. It is needed in follow up patch to cache and kick resamplefds from QEMU. Reviewed-by: Eric Auger Signed-off-by: Peter Xu --- accel/kvm/kvm-all.c | 16 ++-- 1 file changed, 10 in

[PATCH v2 5/5] Revert "vfio/pci: Disable INTx fast path if using split irqchip"

2020-02-28 Thread Peter Xu
With the resamplefd list introduced, we can savely enable VFIO INTx fast path again with split irqchip so it can still be faster than the complete slow path. Signed-off-by: Peter Xu --- hw/vfio/pci.c | 12 1 file changed, 12 deletions(-) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c i

Re: [PATCH v4 1/7] target/arm: Improve masking of HCR RES0 bits

2020-02-28 Thread Peter Maydell
On Tue, 25 Feb 2020 at 18:08, Richard Henderson wrote: > > Don't merely start with v8.0, handle v7VE as well. > Notice writes from aarch32 mode, and the bits that > ought not be settable from there. > > Suggested-by: Peter Maydell > Signed-off-by: Richard Henderson > --- > target/arm/helper.c |

Re: [PATCH v4 2/7] target/arm: Honor the HCR_EL2.{TVM,TRVM} bits

2020-02-28 Thread Peter Maydell
On Tue, 25 Feb 2020 at 18:08, Richard Henderson wrote: > > These bits trap EL1 access to various virtual memory controls. > > Buglink: https://bugs.launchpad.net/bugs/1855072 > Signed-off-by: Richard Henderson > --- > v2: Include TTBCR. > v4: Include not_v8_cp_reginfo, lpae_cp_reginfo, CONTEXTIDR

  1   2   3   4   >